From nobody Tue Feb 10 23:01:31 2026 Received: from irl.hu (irl.hu [95.85.9.111]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BD7657F7D9; Tue, 2 Apr 2024 13:21:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.85.9.111 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712064084; cv=none; b=ZDtraJqwt9ONd178zcHSNY14m9okod0IxrZen7vS+Xg1NBhj1hW5TujaJ/h0I8DPF2g+aTExe4q1i9SlwacUwNZoD5z/6SbA9CelwEJB10VymYcde9KRbnhxqYCLeyscQa5bUX3Z1BuhqJ80HNZCeEqixzb+Wc/fGXGXHhsFlUw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712064084; c=relaxed/simple; bh=eqOnowuBwudlc18x7RPtSFiahPlp8fewD9/UlPbj0Pk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Mime-Version:Content-Type; b=nGfYO9MvYYiZzbQK3gPFn6QkSCOM+uiT+S+IbyZ/mKvCchjohID+hVI89pw8Rlsxj9vHsvyl5vpizPBKhVch+Vy1GZGvD/4sU9xOqsQpX+6swppUDgMxoIWoBtuJQxxe1GbExvkrUD+d7WLqsRIVBwuwUX35x+dlgcaDdqpxXl0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=irl.hu; spf=pass smtp.mailfrom=irl.hu; arc=none smtp.client-ip=95.85.9.111 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=irl.hu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=irl.hu Received: from fedori.lan (51b69867.dsl.pool.telekom.hu [::ffff:81.182.152.103]) (AUTH: CRAM-MD5 soyer@irl.hu, ) by irl.hu with ESMTPSA id 0000000000064405.00000000660C064A.002529C9; Tue, 02 Apr 2024 15:21:13 +0200 From: Gergo Koteles To: Ike Panhc , Hans de Goede , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , Pavel Machek , Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, Gergo Koteles Subject: [PATCH 2/3] platform/x86: ideapad-laptop: add fn_lock_get/set functions Date: Tue, 2 Apr 2024 15:21:01 +0200 Message-ID: X-Mailer: git-send-email 2.44.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Mime-Autoconverted: from 8bit to 7bit by courier 1.0 Content-Type: text/plain; charset="utf-8" The FnLock is retrieved and set in several places in the code. Move details into ideapad_fn_lock_get and ideapad_fn_lock_set functions. Signed-off-by: Gergo Koteles Reviewed-by: Hans de Goede --- drivers/platform/x86/ideapad-laptop.c | 38 +++++++++++++++++++-------- 1 file changed, 27 insertions(+), 11 deletions(-) diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform/x86/i= deapad-laptop.c index 901849810ce2..529df08af548 100644 --- a/drivers/platform/x86/ideapad-laptop.c +++ b/drivers/platform/x86/ideapad-laptop.c @@ -513,11 +513,8 @@ static ssize_t fan_mode_store(struct device *dev, =20 static DEVICE_ATTR_RW(fan_mode); =20 -static ssize_t fn_lock_show(struct device *dev, - struct device_attribute *attr, - char *buf) +static int ideapad_fn_lock_get(struct ideapad_private *priv) { - struct ideapad_private *priv =3D dev_get_drvdata(dev); unsigned long hals; int err; =20 @@ -525,7 +522,27 @@ static ssize_t fn_lock_show(struct device *dev, if (err) return err; =20 - return sysfs_emit(buf, "%d\n", !!test_bit(HALS_FNLOCK_STATE_BIT, &hals)); + return !!test_bit(HALS_FNLOCK_STATE_BIT, &hals); +} + +static int ideapad_fn_lock_set(struct ideapad_private *priv, bool state) +{ + return exec_sals(priv->adev->handle, + state ? SALS_FNLOCK_ON : SALS_FNLOCK_OFF); +} + +static ssize_t fn_lock_show(struct device *dev, + struct device_attribute *attr, + char *buf) +{ + struct ideapad_private *priv =3D dev_get_drvdata(dev); + int brightness; + + brightness =3D ideapad_fn_lock_get(priv); + if (brightness < 0) + return brightness; + + return sysfs_emit(buf, "%d\n", brightness); } =20 static ssize_t fn_lock_store(struct device *dev, @@ -540,7 +557,7 @@ static ssize_t fn_lock_store(struct device *dev, if (err) return err; =20 - err =3D exec_sals(priv->adev->handle, state ? SALS_FNLOCK_ON : SALS_FNLOC= K_OFF); + err =3D ideapad_fn_lock_set(priv, state); if (err) return err; =20 @@ -1709,7 +1726,6 @@ static void ideapad_wmi_notify(struct wmi_device *wde= v, union acpi_object *data) { struct ideapad_wmi_private *wpriv =3D dev_get_drvdata(&wdev->dev); struct ideapad_private *priv; - unsigned long result; =20 mutex_lock(&ideapad_shared_mutex); =20 @@ -1722,11 +1738,11 @@ static void ideapad_wmi_notify(struct wmi_device *w= dev, union acpi_object *data) ideapad_input_report(priv, 128); break; case IDEAPAD_WMI_EVENT_FN_KEYS: - if (priv->features.set_fn_lock_led && - !eval_hals(priv->adev->handle, &result)) { - bool state =3D test_bit(HALS_FNLOCK_STATE_BIT, &result); + if (priv->features.set_fn_lock_led) { + int brightness =3D ideapad_fn_lock_get(priv); =20 - exec_sals(priv->adev->handle, state ? SALS_FNLOCK_ON : SALS_FNLOCK_OFF); + if (brightness >=3D 0) + ideapad_fn_lock_set(priv, brightness); } =20 if (data->type !=3D ACPI_TYPE_INTEGER) { --=20 2.44.0