From nobody Fri Dec 19 08:06:35 2025 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A8F151D5CE8 for ; Thu, 10 Apr 2025 16:25:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744302321; cv=none; b=W7Hz6GestWKc7xnT2NfR4rMW3ENaoDa053xLxNidS4ayrs/68/SXziN5/wTFuRoduTJXMWwFjBnRs8KJLB1WcCOSBKa5Bzl6s3YAbjNIbOcwyndhle9DXBU185p1iesxKC3u5mLvNCEC8JvDE9Xmj3CKl+JHev58agQPtcrtz5I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744302321; c=relaxed/simple; bh=Xyqh31/up32k9QyjvOp1tbHBRtZxHnBYUmmh3lPeV3Q=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=Gs+EBk4F6t6aiQ6uAwPcG+lwD1fLvbxDlM9ng+Ho9sewcf2vCnsEB3rB2iFSb+ntcHustpQKfKBCiALoHvLCCDq25gpY+j6COuwAedVD/DywpLrq2ynGiv9xkpBSCnKsMVE6ez4GL1ea80SNR6Eb+Rl0oNsnU6hNxUdIKIxkSeo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=ineRWtWX; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ineRWtWX" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-39c266c1389so655222f8f.1 for ; Thu, 10 Apr 2025 09:25:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1744302318; x=1744907118; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=wB7GpXUjol0KQ/YbX53LBVb2Ev80ElCPLnkY+8Zk89U=; b=ineRWtWXQW7mvtsTlMk6+UVf38cq23wMxvihzK7sCHY+qm6x6JJsG994OH4HzFeruY P3IB5HIyR2d0DaKYeVZlYhJGqYSWN8JgK3m9UBSIyPFD8I+D7pZY9JVI8qeQ0pbrDhVu LTZU3q9S9xD8zF5om89+oRB6cwYoyAbnh6QhwUNPPrjAz+L7kkcwmtVBJfJ1lpV8OW4Y RV7+fdra4lWO0XVH8yG6CK9iWb18iHuUZNj3BaU1EjR7vFqH9lsuFNL2cZIsLNt1ha7F 1nzzOe5fw/gc15YvscoFdkO7twPQFYmp+0u77le3tUURLG9WNyuGn2kVGwlCXa74YjKQ 4bCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744302318; x=1744907118; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wB7GpXUjol0KQ/YbX53LBVb2Ev80ElCPLnkY+8Zk89U=; b=q/yu91NmgjQ4DnlhXuCC8ecGi8I9iuUDJNVFrsQSvo6hkZrozhuyJnx2HdsAsZmLK8 WYQpgTr6rLHyl83zbW8PxIVV3jdlVNYEZBVdop8m6TCpRi+QCqszxYkKI5uXDIgWHCrJ WQWIObMqg7+vK0YhBcvjqqdMePBApubHbSG5ilCRZgbmIsQrelJQFMpmfXqDrpOx7h6f u3o0fKB7iaIVvW2tpGUtUPJ5o9uMNxr7c3eBLU1b36z3FUf6xMLqmqQ+F7YEzSzuFly+ YAe37QUHvykTeornEKeSvxIkIWI/ZZGNrPB+rGRgEWVPsrgrk+Gb8XfvgHvCXolwBRId Fs9w== X-Forwarded-Encrypted: i=1; AJvYcCUBcvA0cBGjvjHrWkFmXhaADomRDvRR9MSxiUECmpvVRslV3h9+NzDF6iwNAkR5DbCOzAebaiJ1J2iorq8=@vger.kernel.org X-Gm-Message-State: AOJu0YzKh3qdjcIDAxrHmO6SmV/kCj25hmEftO/8/3v8MHv+00gTGonU oRwA+8Aql1HuDM05B5Zovewxnicwliwcn4hEOemDVekzUZaqjNnkg+tIwzX3X6E= X-Gm-Gg: ASbGncsDZHw4W8tzCyzzD/tGwkp0koRv7WtZdAt56Ly0IDqtC/gCzb/C/6eLM7uO7f5 nL1FaLUZCOoaF0NxjnCpSfj/NyNtn+Y6iXeRq0IEiajLvtKekmRLG7WTXTvNO/Al97i1pmO+X62 3Ru2ojbdmJAECOiRjoVou/uChlYBWEbG2HKl6TljuVycF3fgDkwUJhLA2SOh7FWcKcLaFu1r/Lu CXHofRBz2EeS84fU2ASe8d1Sza+kXYqSxaeY4UL+mNUzLMpiXJq1bhfa6IhSKaRp9iiiyZpWbBy gT5xH8/MvENj/76FzR4o9LAg5QD8z5X5Oa5eMH6nUXsYaQ== X-Google-Smtp-Source: AGHT+IFeTZmUdQ2vt1x1tnJcXZclhQ5dTgbaFR30GmeNzwyzvcpuB5z3WB17x7rprpf4keTp6EzbIA== X-Received: by 2002:a05:6000:2903:b0:391:4999:778b with SMTP id ffacd0b85a97d-39d8fd522b7mr2970676f8f.28.1744302317763; Thu, 10 Apr 2025 09:25:17 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-39d89362fd6sm5398648f8f.16.2025.04.10.09.25.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Apr 2025 09:25:17 -0700 (PDT) Date: Thu, 10 Apr 2025 19:25:14 +0300 From: Dan Carpenter To: Dmitry Baryshkov Cc: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jani Nikula , Imre Deak , Lyude Paul , Ankit Nautiyal , Suraj Kandpal , Andy Yan , Abel Vesa , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] drm/display: dp: delete some dead code Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email haha only kidding Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" We re-worked this code a bit in commit af67978ee37e ("drm/display: dp: use new DCPD access helpers") but there was a little bit of stray dead code left over. Clean it up. Signed-off-by: Dan Carpenter Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/display/drm_dp_helper.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/display/drm_dp_helper.c b/drivers/gpu/drm/disp= lay/drm_dp_helper.c index 57828f2b7b5a..f38b4dc14e1c 100644 --- a/drivers/gpu/drm/display/drm_dp_helper.c +++ b/drivers/gpu/drm/display/drm_dp_helper.c @@ -3570,7 +3570,6 @@ EXPORT_SYMBOL(drm_dp_pcon_frl_configure_1); int drm_dp_pcon_frl_configure_2(struct drm_dp_aux *aux, int max_frl_mask, u8 frl_type) { - int ret; u8 buf =3D max_frl_mask; =20 if (frl_type =3D=3D DP_PCON_FRL_LINK_TRAIN_EXTENDED) @@ -3579,10 +3578,6 @@ int drm_dp_pcon_frl_configure_2(struct drm_dp_aux *a= ux, int max_frl_mask, buf &=3D ~DP_PCON_FRL_LINK_TRAIN_EXTENDED; =20 return drm_dp_dpcd_write_byte(aux, DP_PCON_HDMI_LINK_CONFIG_2, buf); - if (ret < 0) - return ret; - - return 0; } EXPORT_SYMBOL(drm_dp_pcon_frl_configure_2); =20 @@ -4044,7 +4039,7 @@ int drm_edp_backlight_enable(struct drm_dp_aux *aux, = const struct drm_edp_backli if (ret < 0) { drm_dbg_kms(aux->drm_dev, "%s: Failed to write aux backlight mode: %d\n", aux->name, ret); - return ret < 0 ? ret : -EIO; + return ret; } =20 ret =3D drm_edp_backlight_set_level(aux, bl, level); @@ -4192,7 +4187,7 @@ drm_edp_backlight_probe_state(struct drm_dp_aux *aux,= struct drm_edp_backlight_i if (ret < 0) { drm_dbg_kms(aux->drm_dev, "%s: Failed to read backlight mode: %d\n", aux->name, ret); - return ret < 0 ? ret : -EIO; + return ret; } =20 *current_mode =3D (mode_reg & DP_EDP_BACKLIGHT_CONTROL_MODE_MASK); --=20 2.47.2