From nobody Sun Feb 8 05:53:28 2026 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 25BB218CC1E for ; Tue, 20 Aug 2024 13:43:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724161434; cv=none; b=TIAK+Qd5gOnzxJqXp2i/XpDk0oG/qEgW9B9zKvEPqrr+TaPYuJGWHRfHMRYVKmfgSMJshQPuvbKUR0SzPAMjVHHzexhxIldCZtvEFUCo5I1XsK14WRt5OOTSFyBOz5zJboOzTJvfxUsXj7PF/6txVkACJDNNrUL1fgDTKIpMt6Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724161434; c=relaxed/simple; bh=CRbyTO4VHkSm+ayF0Ti8oPicH/UIR4BZeHQJvPd6J8I=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=Bz8ASkHRFzqp46XkZJ9BC98d8q/0bRbji6YyXlt8rtypdg4vZfOsvMZrh0Fdng1kv6EOToi7mLGCZop5k0zZ3v8qQ3JIs7155NMUdTisEw/tjyEsqHipohpcuoFkAYMb616FL7H66Zt1kTb5ZysZE1yomPNXn5dzRhkIWQ3aKms= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=iRLTn5dt; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="iRLTn5dt" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-37198a6da58so3226702f8f.0 for ; Tue, 20 Aug 2024 06:43:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1724161430; x=1724766230; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=j1XMeyDmodCe7KZthl+BnWSu3Nbgczd7OGGhn6K/W/g=; b=iRLTn5dtQdtXI31/3LFx53DVMcS/VumZOATKoqMSzh4uNBXIHm8wxTJDUxg+mTzjZj ZnBFhCby7lYCU17ePQzat6t2+u3bfmFpLz/4zUqD3mfpsP3bPnElKz9kXXx7j8cKGmZk BQkDmrLMX7/DXqhNX7x/SpsrMka7pBV5nEWGBJebTmJe9J1OyTwgWyQIpZ1wHh+I42gj rXmuhReE/kWdguEhx+r7Kf7W8j+XITnWzz8X3QjtFPwn0mm0pJ4PZM4FZtON5VphJy1P 3H1fwO0QMBRL2wckbkRkxXjr570x8AVcTg7ysJYjbFvKTGQCj3AVLECwnSxuVBAXCbKj f9ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724161430; x=1724766230; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=j1XMeyDmodCe7KZthl+BnWSu3Nbgczd7OGGhn6K/W/g=; b=a5kyoQzDrsH0vs3oEzlkeX+2Ao741fCoHpNCHJ8dAxO1M1dCSenrJORLkhYHVvZesl sHGhSvw/ZsSP5kpvTFEpiD76So87BFZIngoPFY5Y1Z7xO/LeB6b+PUHyiaQN6pHULaxg JfDTPfxQ/0wGBl4Z06+ocE+MkMiguRz6g2EMwZKKpKdyT3vuqO/pj6/DcwvTHBsA8GtA irQHZ63kGjeYhB5MX4alR1kzj3p9BFSQPeummdznL5dbinyf7BAmKVo7EJhI9k0YGUS9 T6YfabkuFjiGlv7jdWhObcRV5f719t9XAT4b0QvhjXSs/lqMeChDel28fg9IXbGtp7cI VT6Q== X-Forwarded-Encrypted: i=1; AJvYcCXoSBtiF7YnqdpVjbkUSJzFHifrcwmKBzWVPCo/GTjxkIkfie9f1gNLdYFr84bPDGKTgxFk/XI/eU1RpLwwemCPZyRnW9f/IwZxdNeR X-Gm-Message-State: AOJu0Yzkrb4pUxJhDfrCE4i3y40RC1h1QPOfL72+FacZPFcHb02andxu QugR/hNbaG6jsw91XH+yf/DXd4n0F+4YEQaR+s+vhXu2rtCyuLkXKI0f2I3rTKcivN8vCalrdLp z X-Google-Smtp-Source: AGHT+IHBWCmam+ulMm2FM1FGLnrPJ/iowdO3I8ObDwrPHCtP4njXnNaxIQIGXyL+mmo/wO6NYs+ySQ== X-Received: by 2002:a5d:55cd:0:b0:371:8bce:7a7c with SMTP id ffacd0b85a97d-371943155f6mr11277051f8f.13.1724161430386; Tue, 20 Aug 2024 06:43:50 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a83838c6a42sm762670166b.44.2024.08.20.06.43.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Aug 2024 06:43:50 -0700 (PDT) Date: Tue, 20 Aug 2024 16:43:46 +0300 From: Dan Carpenter To: Junfeng Guo Cc: Tony Nguyen , Przemek Kitszel , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Qi Zhang , Marcin Szycik , Ahmed Zaki , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH net-next] ice: Fix a 32bit bug Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email haha only kidding Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" BIT() is unsigned long but ->pu.flg_msk and ->pu.flg_val are u64 type. On 32 bit systems, unsigned long is a u32 and the mismatch between u32 and u64 will break things for the high 32 bits. Fixes: 9a4c07aaa0f5 ("ice: add parser execution main loop") Signed-off-by: Dan Carpenter Reviewed-by: Alexander Lobakin --- drivers/net/ethernet/intel/ice/ice_parser_rt.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/intel/ice/ice_parser_rt.c b/drivers/net/e= thernet/intel/ice/ice_parser_rt.c index d5bcc266b01e..dedf5e854e4b 100644 --- a/drivers/net/ethernet/intel/ice/ice_parser_rt.c +++ b/drivers/net/ethernet/intel/ice/ice_parser_rt.c @@ -377,11 +377,11 @@ static void ice_pg_exe(struct ice_parser_rt *rt) =20 static void ice_flg_add(struct ice_parser_rt *rt, int idx, bool val) { - rt->pu.flg_msk |=3D BIT(idx); + rt->pu.flg_msk |=3D BIT_ULL(idx); if (val) - rt->pu.flg_val |=3D BIT(idx); + rt->pu.flg_val |=3D BIT_ULL(idx); else - rt->pu.flg_val &=3D ~BIT(idx); + rt->pu.flg_val &=3D ~BIT_ULL(idx); =20 ice_debug(rt->psr->hw, ICE_DBG_PARSER, "Pending update for flag %d value = %d\n", idx, val); --=20 2.43.0