From nobody Mon Feb 9 18:19:44 2026 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2CEF128A3FA for ; Tue, 29 Jul 2025 10:36:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753785400; cv=none; b=Lg6lyh74DR9pVcA/uAQfKnK4vEJkWzeqzNMI0+I8cUpBQ1DXxVHEdH6LGTGkqMNOkLZW74BCZszo+0K9sjbmlnY2oVbw+LmiYXWZ4iSfb4f0mgBTomqOpDpUWF2+vymUdG9HZGpmYcUt6NAhtKoy9YS2864RZwMuyohmEmYKFEY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753785400; c=relaxed/simple; bh=xVCQ0H9cdadixp4wtnM9PE8JviA4z1kl3G/Q1/TlS2E=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Ja3SSdoFOsxzY/UJ9yBufm/iV5W1mqmRUxgMhDJ71u/GOfHZBNHUVEM9NA1DrTSr7/kAEbZf6kH5BXV0/sjOJoCbMUmkyZnLEOB53l3cqAn46CH2Srcu2Y75ZzvQSeZtssNGucrwrMydoZOcy2FB88+NhTRtRAu+r/B17CyXrGM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=ikVhMw9E; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="ikVhMw9E" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-3a54700a46eso2552449f8f.1 for ; Tue, 29 Jul 2025 03:36:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1753785395; x=1754390195; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bOT/FGVWZXt1k9nEtD7r2OSEKfVEuUP//VH1iukiEmU=; b=ikVhMw9EP14utVrUyZzTt8vXSxYR+99KaYziRDjooGT/5vRq1fhPRKgz5HF+IcVJr5 z+ZH2229PVJ1m6msbmPnWg4TRkma/XU1RYaCaamBKRGvpU8PNt3k7cuYVAYKSSFIzIIp EuAI/oJGlHMPW3YIgHW4HLk+Ib1J3FoSlzpFPG6AFMD6FpHRxKkSozLjcF4VGgu/Pi4+ tzCPmiqY13v/ba9Y0R8sDTZlryosw1SnTkA142i6t39QZuILYYU6c/UUxav0ctUXVL9e BLaPXQsolLJxvD7L/CwO4xQTshwNGvx2Qpu2Ytq1QY1tCXTgDHOd5hGx8fwD60ImwzLS Ie6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753785395; x=1754390195; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bOT/FGVWZXt1k9nEtD7r2OSEKfVEuUP//VH1iukiEmU=; b=kz8PzODWwQStMTcKk9eV5qCOmLW+mrRKoaZmcBiEkbvEG8A6SFbIiex2nrPuq+QQXj rzgBmf3IXbQCKyZIhG8X+Q/2Cz337EkEi3rrlZ+BnZywhfiRpsgnwNqQtxzdf1oiShzk FuQygJ4KGxGs+6cj4KedIp2modAXhDnwI3M19kojHOK2dLDiaV2HJPzADeeDdeHKKfYU KFjiu6RntilDCXATNmwDGSQtFfEThPQpOfYDJM9Xf+pfiX4AiNKEXuiLuFQUQ3aMOGQq 9r26U51OWywvY8U0KYLdqa+BAMO842bobMjtrP/rqSzPUPFxGOTnCjAyW4sRB7CBw6DA B6FQ== X-Forwarded-Encrypted: i=1; AJvYcCVmt+D6hqZJJTP/FxRMIk0QJ4r9vyM7Q3rj1uqeu77nlP28vhjR1EtaCQBnJhcE7l5gUYY7hvZJaoNosBs=@vger.kernel.org X-Gm-Message-State: AOJu0YzehyrYHWtwO8LQGlO8kbYIy1spXgp03nhQh7WLOHOPkY+dXboq Xx8u9trUHvvhiwt7TKe2P4uzM9a63ImzoRhNO+y5KTKZHGd+dWIHUvMt9pG2++9FBr4= X-Gm-Gg: ASbGncv2O+gu3aQat/EBkoMTir2in9+9kzO2j43Zf68lbuXwKN+LG8BHlT9yoASw5Jj RP79kKo0mrAu0w+vFLstUZ+IPyg4Vd2ychETPq8fT4eDWKnwB5ZfnNBfP3snIfvOZRhvw+A9gd/ 7grRCAoEMDjeL/SfL7b5EXfmtb/saOMZEpmpaMiz1cflb2zPrgrz2mFDGG8wNleW0twNK7Ec/tQ FbuUznlZsg2hukTJ2gWxKYqP+u+N1O06e/B1qaqlKhAF9OiIltssPvpKSvshrDohaviWIPEz9/j Zc67BPId4EHplwaV/8doohl+jyzrquu7QrejwnHsgP87VebnkGoXoowkZLyEX5otRPqKWFvGqXb kATjR1q9yv2jQ2k6pgddhxb2b2lnAnp8GAerP9EXpTaiOMpa60Vl8mZUw3MoZDWzk X-Google-Smtp-Source: AGHT+IEUDe5Y8ch5reMaJR+e1UFpIOuCDt4FLaqjklslZwM9SscKPmK3GMlaAo0W9OWsUQ8airUKaQ== X-Received: by 2002:a5d:5d07:0:b0:3a6:c923:bc5f with SMTP id ffacd0b85a97d-3b7767298a5mr10328260f8f.17.1753785394967; Tue, 29 Jul 2025 03:36:34 -0700 (PDT) Received: from localhost (p200300f65f06ab0400000000000001b9.dip0.t-ipconnect.de. [2003:f6:5f06:ab04::1b9]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-3b778eb284fsm12058183f8f.12.2025.07.29.03.36.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Jul 2025 03:36:34 -0700 (PDT) From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: linux-pwm@vger.kernel.org Cc: David Jander , Clemens Gruber , linux-kernel@vger.kernel.org Subject: [PATCH 3/5] pwm: pca9685: Make use of register caching in regmap Date: Tue, 29 Jul 2025 12:36:02 +0200 Message-ID: X-Mailer: git-send-email 2.50.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1711; i=u.kleine-koenig@baylibre.com; h=from:subject:message-id; bh=xVCQ0H9cdadixp4wtnM9PE8JviA4z1kl3G/Q1/TlS2E=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBoiKQYvIpI9MwDeOqnxPYjnZJTPNea9xJ6Rux4Y vHLCAtxEzWJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCaIikGAAKCRCPgPtYfRL+ Ti17B/4qD2l36dVNP600NKdoY5Ft0nkFPN587ZhFvA4yMAWrWTr6u5NufyUWbuOIcgmHFI65X19 0UXABHvyhfqtECZhRzLSwa82q+zh6ZTLMZzNb6OQm7BPPJqYKsVfBMueQWF13bR8IWdLTHRNnAk m968ublJe/gsicp9OxjuVrAnoLqqKJR10OUuwn3Umkbg2XsdLFJWFA1tgKzSc/xOP40BK6cEZ26 jqPR3oUFNObN3rzEHi/S0m79KunyTywv8C3VhPosbWmIy+0CNphK2EhxknGmzkUJXWA/d0V8CZ/ zzGHrOmnE26xGk/tROM9WwXViXOygE+PggP7XoehZz31NKAf X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable This essentially only caches the PRESCALE register because the per channel registers are affected by the ALL configuration that is used by the virtual pwm #16. The PRESCALE register is read often so caching it saves quite some i2c transfers. Signed-off-by: Uwe Kleine-K=C3=B6nig --- drivers/pwm/pwm-pca9685.c | 27 ++++++++++++++++++++++++++- 1 file changed, 26 insertions(+), 1 deletion(-) diff --git a/drivers/pwm/pwm-pca9685.c b/drivers/pwm/pwm-pca9685.c index 75cf10f2b269..536a3e15a254 100644 --- a/drivers/pwm/pwm-pca9685.c +++ b/drivers/pwm/pwm-pca9685.c @@ -521,11 +521,36 @@ static const struct pwm_ops pca9685_pwm_ops =3D { .free =3D pca9685_pwm_free, }; =20 +static bool pca9685_readable_reg(struct device *dev, unsigned int reg) +{ + /* The ALL_LED registers are readable but read as zero */ + return reg <=3D REG_OFF_H(15) || reg >=3D PCA9685_PRESCALE; +} + +static bool pca9685_writeable_reg(struct device *dev, unsigned int reg) +{ + return reg <=3D REG_OFF_H(15) || reg >=3D PCA9685_ALL_LED_ON_L; +} + +static bool pca9685_volatile_reg(struct device *dev, unsigned int reg) +{ + /* + * Writing to an ALL_LED register affects all LEDi registers, so they + * are not cachable. :-\ + */ + return reg < PCA9685_PRESCALE; +} + static const struct regmap_config pca9685_regmap_i2c_config =3D { .reg_bits =3D 8, .val_bits =3D 8, + + .readable_reg =3D pca9685_readable_reg, + .writeable_reg =3D pca9685_writeable_reg, + .volatile_reg =3D pca9685_volatile_reg, + .max_register =3D PCA9685_NUMREGS, - .cache_type =3D REGCACHE_NONE, + .cache_type =3D REGCACHE_MAPLE, }; =20 static int pca9685_pwm_probe(struct i2c_client *client) --=20 2.50.0