From nobody Wed Nov 13 02:12:17 2024 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 53FA444C84 for ; Sun, 17 Dec 2023 14:30:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rEs9c-0006VM-WF; Sun, 17 Dec 2023 15:30:05 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rEs9c-00GUhD-GI; Sun, 17 Dec 2023 15:30:04 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1rEs9c-004hz1-7A; Sun, 17 Dec 2023 15:30:04 +0100 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Krzysztof Kozlowski Cc: kernel@pengutronix.de, Santosh Shilimkar , linux-kernel@vger.kernel.org Subject: [PATCH 03/15] memory: emif: Convert to platform remove callback returning void Date: Sun, 17 Dec 2023 15:29:29 +0100 Message-ID: X-Mailer: git-send-email 2.42.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1692; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=unkZGXW/GBMij3XUkpyQaAXYnruITJsZtJqqHnqW6wY=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlfwXIlYCuL20IU+oKd4SHoVuSVc2z9AqLE+XQP VhL8Zc1e3eJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZX8FyAAKCRCPgPtYfRL+ TkcuB/9xUatnUb3NxjSCoYvzf/ZDrQDjLfZpdz6ty/hfopPE7HsdjEpp1xC68ChCZFEpul2N6ka m5baMNk4B2dtrhQR4UMqwmMLL+NK4H57cYWbQmi2scmzb7nk72ewlnpvIy9x/zDbV4mGXWvuYL2 Cwnr3ddJKhhS1huGAh1sY+pasL7xBIIxjCg8PTV7stp1c+tCw7pf2pjPUtJq62Fz8nLhFBW3Yaw fSeVVqCsu+f/fF2/ji7ikpx+tew/rZft/hESOd53krOs9FxQcDfucVp2wMGDjjEp+SUT1I4pO/i 9chBR4OWfNTWcbjvh54/hUFbh4/wlGe004eGG4i2ccRe771G X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-K=C3=B6nig --- drivers/memory/emif.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/memory/emif.c b/drivers/memory/emif.c index f305643209f0..434982545be6 100644 --- a/drivers/memory/emif.c +++ b/drivers/memory/emif.c @@ -1159,13 +1159,11 @@ static int __init_or_module emif_probe(struct platf= orm_device *pdev) return -ENODEV; } =20 -static int __exit emif_remove(struct platform_device *pdev) +static void __exit emif_remove(struct platform_device *pdev) { struct emif_data *emif =3D platform_get_drvdata(pdev); =20 emif_debugfs_exit(emif); - - return 0; } =20 static void emif_shutdown(struct platform_device *pdev) @@ -1185,7 +1183,7 @@ MODULE_DEVICE_TABLE(of, emif_of_match); #endif =20 static struct platform_driver emif_driver =3D { - .remove =3D __exit_p(emif_remove), + .remove_new =3D __exit_p(emif_remove), .shutdown =3D emif_shutdown, .driver =3D { .name =3D "emif", --=20 2.42.0