From nobody Fri Apr 10 02:39:39 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 102993A0B35; Wed, 4 Mar 2026 17:22:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772644951; cv=none; b=YLS8bVUtFklNnVIctolk4K3wp8X5DafLjIhNdMpDPPBsR4nF68w/IL9RLXTmkPZ4HfOkcWvmnSJgSgLB6l7BuUOzDd+tchLzCQwGt654asv1ZNcVtN9oN8jDtKw7n9bBtzsToF8FXqjQQudtPpZeQ+M3LL6Vdd5ufdEGUKHcWQo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772644951; c=relaxed/simple; bh=kzeAmW8ai6m+Tt0p0RRAcjdmfPdkrIbUdsKHJcDH3pY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=XzI4KmTPgSoqDZ2mJEoB7Vc/XvhxxRYFtRyJ6xU8qLSxXZAhHq2gTV5j5Gy6CxYOnL7zuv6V8eQaWSH7kMRhNNpr+eJ92admb1Twxvy/pzeEe/p1QaQvHeJlSpP+tyNvAsC/LnmolWRQZfL2Nl6VAF3aFS0f6A6lXl+P3DZfX1E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 09C00C4CEF7; Wed, 4 Mar 2026 17:22:23 +0000 (UTC) From: Geert Uytterhoeven To: Marc Zyngier , Thomas Gleixner , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Lorenzo Pieralisi , Antoine Tenart , Florian Fainelli , Broadcom internal kernel review list , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Mark-PK Tsai , Daniel Palmer , Matthias Brugger , AngeloGioacchino Del Regno , Thierry Reding , Jonathan Hunter , Nishanth Menon , Tero Kristo , Santosh Shilimkar , Kunihiko Hayashi , Masami Hiramatsu Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, imx@lists.linux.dev, linux-amlogic@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-tegra@vger.kernel.org, linux-arm-msm@vger.kernel.org, Geert Uytterhoeven Subject: [PATCH 3/4] irqchip/gic: Use GIC_* DT binding definitions Date: Wed, 4 Mar 2026 18:21:58 +0100 Message-ID: X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace magic numbers by symbolic DT binding definitions. This improves readability, and makes it easier to find where the various GIC interrupts types are handled. Signed-off-by: Geert Uytterhoeven --- drivers/irqchip/irq-gic-v3.c | 14 ++++++++------ drivers/irqchip/irq-gic.c | 6 ++++-- 2 files changed, 12 insertions(+), 8 deletions(-) diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c index d75163e71bf22473..6ac103cb40097acc 100644 --- a/drivers/irqchip/irq-gic-v3.c +++ b/drivers/irqchip/irq-gic-v3.c @@ -35,6 +35,8 @@ #include #include =20 +#include + #include "irq-gic-common.h" =20 static u8 dist_prio_irq __ro_after_init =3D GICV3_PRIO_IRQ; @@ -1602,25 +1604,25 @@ static int gic_irq_domain_translate(struct irq_doma= in *d, return -EINVAL; =20 switch (fwspec->param[0]) { - case 0: /* SPI */ + case GIC_SPI: if (fwspec->param[1] > 987) pr_warn_once("SPI %u out of range (use ESPI?)\n", fwspec->param[1]); *hwirq =3D fwspec->param[1] + 32; break; - case 1: /* PPI */ + case GIC_PPI: if (fwspec->param[1] > 16) pr_warn_once("PPI %u out of range (use EPPI?)\n", fwspec->param[1]); *hwirq =3D fwspec->param[1] + 16; break; - case 2: /* ESPI */ + case GIC_ESPI: if (fwspec->param[1] > 1023) pr_warn_once("ESPI %u out of range\n", fwspec->param[1]); *hwirq =3D fwspec->param[1] + ESPI_BASE_INTID; break; - case 3: /* EPPI */ + case GIC_EPPI: if (fwspec->param[1] > 63) pr_warn_once("EPPI %u out of range\n", fwspec->param[1]); @@ -1738,8 +1740,8 @@ static int gic_irq_get_fwspec_info(struct irq_fwspec = *fwspec, struct irq_fwspec_ struct fwnode_handle *fw; =20 switch (fwspec->param[0]) { - case 1: /* PPI */ - case 3: /* EPPI */ + case GIC_PPI: + case GIC_EPPI: break; default: return 0; diff --git a/drivers/irqchip/irq-gic.c b/drivers/irqchip/irq-gic.c index ec70c84e9f91dd7b..a2225ca1efeb700d 100644 --- a/drivers/irqchip/irq-gic.c +++ b/drivers/irqchip/irq-gic.c @@ -47,6 +47,8 @@ #include #include =20 +#include + #include "irq-gic-common.h" =20 #ifdef CONFIG_ARM64 @@ -1094,10 +1096,10 @@ static int gic_irq_domain_translate(struct irq_doma= in *d, return -EINVAL; =20 switch (fwspec->param[0]) { - case 0: /* SPI */ + case GIC_SPI: *hwirq =3D fwspec->param[1] + 32; break; - case 1: /* PPI */ + case GIC_PPI: *hwirq =3D fwspec->param[1] + 16; break; default: --=20 2.43.0