From nobody Fri Sep 25 21:02:39 2026 Received: from master.debian.org (master.debian.org [82.195.75.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 84E6846C859; Mon, 21 Sep 2026 10:04:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=82.195.75.110 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789985069; cv=none; b=lNoOgKPY3cjWZc3LDTSSN4KddL/iEXdAMvJJrtv2rwKQNsizB/ffMFcSGkcRzuqp//XYxXY29KDDnYl6cNSi0z7OZWlRZIUyBm1GD4tIwXZIfU1K+kDIg7VdPdVVioLivw57dGU5uaQhzgOrL40ub19K+A6ea37G0QJ50IaRnno= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789985069; c=relaxed/simple; bh=J3G1XOgEGyUEGCnYT9ndKultr5rQzQu//Zfvfn/nyg8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=mXynWSTpDgu1K56kET2hn3/xGMw5UaKgE1NRDguiPyOzYVROookLprgtHWNUi9B66Ve2cw99t5RwaPJLPf71j41sDaWA5pR58e8wwLdMp4w8ChBAM2vRlqgjC0Cq8XvcTXHcFH+VPk2x0GsLF5QNLS8zR1tokuDRwemIKXdrprk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=debian.org; spf=none smtp.mailfrom=master.debian.org; dkim=pass (2048-bit key) header.d=debian.org header.i=@debian.org header.b=IzLBqfXu; arc=none smtp.client-ip=82.195.75.110 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=debian.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=master.debian.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=debian.org header.i=@debian.org header.b="IzLBqfXu" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debian.org; s=smtpauto.master; h=Content-Transfer-Encoding:Content-Type:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID :Content-Description; bh=vUrv4dKFZHvoMjiZaM/UQjVujiL3fg+yNBiJxL3e+tI=; b=IzLB qfXuwEBBwj0PhFsGsj+OyPk8yo4eC3PEyz82Yp9Hai/+diKZLiJuzCsVnFt6DHRrBEc/u8Befwc2f DViZzcNmguu+bokyc6MoLdJaKmTodNy7b48A7AIhePBpIWa/ffmF5GXNNsxwJ2/2LfAjRAxOwb94l Q2CdLWJBxocLjJ8OOadERFNiaPVjL/SU6zgwh0oRy569v7sxIKvy2YrN4FK8Y1IwxV6jz6/kYggbv /8+aGz1ITVKpwpJQyIYjTjITc3j06uqEdLkVdWbK07gHk5hBtj+JW4ZOvjuprr/ji9XD8hAYut2lt j+H5xPNrbC+WtcQ7nbB/f206T83LHA==; Received: from ukleinek by master.debian.org with local (Exim 4.96) (envelope-from ) id 1x8aXb-003NLI-0F; Mon, 21 Sep 2026 09:42:27 +0000 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Linus Walleij , Chen-Yu Tsai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/4] pinctrl: axp209: Drop check for disabled devices Date: Mon, 21 Sep 2026 11:41:46 +0200 Message-ID: <40e52e7300313b33d7c49e9edea71ec98808c7fd.1789983244.git.ukleinek@debian.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=881; i=ukleinek@debian.org; h=from:subject:message-id; bh=J3G1XOgEGyUEGCnYT9ndKultr5rQzQu//Zfvfn/nyg8=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBqsPvezBM24sw6ksLZrgu17a2imrDm2cwVGmxZN 7MNyR12y26JATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCarD73gAKCRCPgPtYfRL+ TkeSB/9c1Lkq01EBbbG2mF/yzeMSnwH5l0Aak9xTG1X2MPOXlo6NYbosouBvSuw53xgMjvjH8wo 6esJOsR3+iU//EGJy8AblL5KD2eJzM5vxiyF7Y3BoRcENSUVbbRwU6P2MiTC1/wO3Bo1VnM+dE2 unmEKUyyxbFIWSEBGZjTtzLvr82t44ko49Q5wisnHlpIZrXWbBeIUo9WG04lILkvh07yS+nUy+d drcm3zFbupF3+RSGOZt8JcYssp07H3G4why2CGST4bcKp+O0fSajBHi6ozRIYX1EBpGLBuRfSzf iEebc2GwOisVtJc52pdfznd69wA0xy+JwA143AqldXsIeWP6 X-Developer-Key: i=ukleinek@debian.org; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable Since commit 6b5c350648b8 ("mfd: mfd-core: Honour Device Tree's request to disable a child-device") the mfd core checks for disabled devices, so there is no use in doing that again in the mfd child driver. Drop the check. Signed-off-by: Uwe Kleine-K=C3=B6nig Reviewed-by: Chen-Yu Tsai --- drivers/pinctrl/pinctrl-axp209.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/pinctrl/pinctrl-axp209.c b/drivers/pinctrl/pinctrl-axp= 209.c index 2bd8487484a8..5539ce642b39 100644 --- a/drivers/pinctrl/pinctrl-axp209.c +++ b/drivers/pinctrl/pinctrl-axp209.c @@ -442,9 +442,6 @@ static int axp20x_pctl_probe(struct platform_device *pd= ev) struct pinctrl_desc *pctrl_desc; int ret; =20 - if (!of_device_is_available(pdev->dev.of_node)) - return -ENODEV; - if (!axp20x) { dev_err(&pdev->dev, "Parent drvdata not set\n"); return -EINVAL; --=20 2.47.3 From nobody Fri Sep 25 21:02:39 2026 Received: from master.debian.org (master.debian.org [82.195.75.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C828524DFF9; Mon, 21 Sep 2026 10:04:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=82.195.75.110 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789985073; cv=none; b=nthvPP8ieCNAIgEU/MoQ1v6hS0TfChNLbXm/92BjYv66hYoJqBSDpj9emAUb0Y3kLkvt0llTckbFIxsgTgWxPO0z7lzdf+k3ZZcCjMysRDSiaH0eZ71potNuOUG8MFaOdVtueq1SQ+QyFv7jvWeDw3XOdyMpKAcEeUpau/QOjXU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789985073; c=relaxed/simple; bh=guIzjU+DNLL7ubPKDYqbgqMXg+Wtg1CXpKpij7HTUdQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=tpLXcsYy3tJW6XnvE2Pax3iUISyqODV9D+wa3pDeozo0rJhEZsxLbBvdDr5sFv2Y9fyGLPZ+yagrLP/eGj7gx8F+mQZ4I4q5eNbT0tM+wVZ1MEiD4qwhVXPXCbnQLpNn3zNNl3fGa4IXOWFqqCI5Y0XFnTnGavBbsSU4TPoi7Ek= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=debian.org; spf=none smtp.mailfrom=master.debian.org; dkim=pass (2048-bit key) header.d=debian.org header.i=@debian.org header.b=QgHB7TRS; arc=none smtp.client-ip=82.195.75.110 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=debian.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=master.debian.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=debian.org header.i=@debian.org header.b="QgHB7TRS" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debian.org; s=smtpauto.master; h=Content-Transfer-Encoding:Content-Type:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID :Content-Description; bh=30SciPvdgNF2o66DRRScNlCvwze0H+1S2lAwk8P6jxk=; b=QgHB 7TRSDL9m4fueqtqolBf27Vd4FlOnnfHCYhW1PG11HDRBu5v2tNyXI1qgWXDLj4qYkEj/qBy38y3dL SLaf8V6biwAfJu+PjNH20h0ujbvEZ6MfhIaAJuOO9KHA0U8VGKo31Jc8xobOYpKRRFqhBOlifukbP miVlLbg5nhn/LsIXldXa9Co0DjgE0hft5f0JsOCa1AssmrCWOHS2i995UPQbcnobjU9JR1OD9TXjA MD7Kt0lXTd0jWFPcrfpOQiP8Gpd0NlBRSmbsMKDK9Lld51wek8JzugHIigPmuqh1eGrkUu/pW8sbO akfs6hThy24zlnRQ4JAqC6l2sILXGA==; Received: from ukleinek by master.debian.org with local (Exim 4.96) (envelope-from ) id 1x8aXb-003NLT-2G; Mon, 21 Sep 2026 09:42:27 +0000 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Sebastian Reichel , Chen-Yu Tsai Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/4] power: supply: axp20x*: Drop check for disabled devices Date: Mon, 21 Sep 2026 11:41:47 +0200 Message-ID: X-Mailer: git-send-email 2.47.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=2128; i=ukleinek@debian.org; h=from:subject:message-id; bh=guIzjU+DNLL7ubPKDYqbgqMXg+Wtg1CXpKpij7HTUdQ=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBqsPvhqwF3EAkOmLw6OP1gK9f93vJmWAlfDTbpg e0M5KZpGJ6JATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCarD74QAKCRCPgPtYfRL+ TvdACACj8QLLfiDrwwSpTrsUb10HR4yusExVME569XPqfDHv1/HIh18JQTjzmrHQTBlYqSB4wbq Jx0IsjShuKOSImB5TZTYRYI7GIByWwIk5NdSUtzFmL0+Qt89718xBCdY8qZKkltEK5u+x6P6Q9K +arfMNPflaoWkIlIyrp6+lGPaIEKj7HTbFLCIVKUXIRJYraE39yxe/NWJKWnMht5P0erwba7Hew HXc+PcVxHkKnV8JVN3YalnqZhc78vnwHubOYJFs0Ez0eBo/vdHlvhligctS7AFTtLqsiNwDQU/h bXcHyKGG5AGRU+ZpUcV4DKPASZQiePUAZewZWwEKD9JN3ZbC X-Developer-Key: i=ukleinek@debian.org; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable Since commit 6b5c350648b8 ("mfd: mfd-core: Honour Device Tree's request to disable a child-device") the mfd core checks for disabled devices, so there is no use in doing that again in the mfd child driver. Drop the check in the two power drivers. Signed-off-by: Uwe Kleine-K=C3=B6nig Reviewed-by: Chen-Yu Tsai --- drivers/power/supply/axp20x_ac_power.c | 3 --- drivers/power/supply/axp20x_battery.c | 3 --- drivers/power/supply/axp20x_usb_power.c | 3 --- 3 files changed, 9 deletions(-) diff --git a/drivers/power/supply/axp20x_ac_power.c b/drivers/power/supply/= axp20x_ac_power.c index d9892b351621..46889567bc18 100644 --- a/drivers/power/supply/axp20x_ac_power.c +++ b/drivers/power/supply/axp20x_ac_power.c @@ -326,9 +326,6 @@ static int axp20x_ac_power_probe(struct platform_device= *pdev) const struct axp_data *axp_data; int i, irq, ret; =20 - if (!of_device_is_available(pdev->dev.of_node)) - return -ENODEV; - if (!axp20x) { dev_err(&pdev->dev, "Parent drvdata not set\n"); return -EINVAL; diff --git a/drivers/power/supply/axp20x_battery.c b/drivers/power/supply/a= xp20x_battery.c index ee8701a6e907..c119014b319a 100644 --- a/drivers/power/supply/axp20x_battery.c +++ b/drivers/power/supply/axp20x_battery.c @@ -1097,9 +1097,6 @@ static int axp20x_power_probe(struct platform_device = *pdev) struct device *dev =3D &pdev->dev; int ret; =20 - if (!of_device_is_available(pdev->dev.of_node)) - return -ENODEV; - axp20x_batt =3D devm_kzalloc(&pdev->dev, sizeof(*axp20x_batt), GFP_KERNEL); if (!axp20x_batt) diff --git a/drivers/power/supply/axp20x_usb_power.c b/drivers/power/supply= /axp20x_usb_power.c index e951b2b64b25..463f9fe35cec 100644 --- a/drivers/power/supply/axp20x_usb_power.c +++ b/drivers/power/supply/axp20x_usb_power.c @@ -924,9 +924,6 @@ static int axp20x_usb_power_probe(struct platform_devic= e *pdev) const struct axp_data *axp_data; int i, irq, ret; =20 - if (!of_device_is_available(pdev->dev.of_node)) - return -ENODEV; - if (!axp20x) { dev_err(&pdev->dev, "Parent drvdata not set\n"); return -EINVAL; --=20 2.47.3 From nobody Fri Sep 25 21:02:39 2026 Received: from master.debian.org (master.debian.org [82.195.75.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 279AB46DFF4; Mon, 21 Sep 2026 10:04:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=82.195.75.110 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789985063; cv=none; b=ISHBT8LOKs8wXTNMnaJv0CcGXjqEi3eagzWmUm5irej3bw3SA4WUdNkoDg+GPRIDZ5YUcotL9mGw/evavKy4Rk6eUEGzlVgGaIdwtahtYaSn7+67UH7bPZ8mqe3pAkO4QzrnL2oO87eEJjycEEPfD/TH/fosq6ze9UNoo4zwlys= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789985063; c=relaxed/simple; bh=gg25qhHUozmURV2g5k4pHl4UyRqIAIqQl3hDObxAYPM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=HrSKpZrk1EuLvtrUax1ChtCRMOJNDEF3Qc1CO5DGJUN8F4f5UHqy1U4FLd4SZFetuMkW3SjUdmylU2GsiN/MRw08Pw978Q7iq3/CsLo93htvJgVB2IkM32R22+NY3Z/Ryiq0fZuCIVj982QwZo1krRqQAZ2ffFk1MVC4YjlMVI8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=debian.org; spf=none smtp.mailfrom=master.debian.org; dkim=pass (2048-bit key) header.d=debian.org header.i=@debian.org header.b=ymT57+DF; arc=none smtp.client-ip=82.195.75.110 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=debian.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=master.debian.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=debian.org header.i=@debian.org header.b="ymT57+DF" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debian.org; s=smtpauto.master; h=Content-Transfer-Encoding:Content-Type:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID :Content-Description; bh=z5n4EYuINE3lAyBylaDRVh3cEp86bCNaJ116BMmwFWk=; b=ymT5 7+DF+D5hn3VwY25LXKxx/HdFC+X1Z8cetN8yQ12h4vvEYeWTA70EZLzN3ubLqsFsSdpTHuOKRxMJM cmfHt3ecgH6bzLoxiPOhkqHAmJIX/cURpjFPzNljsM42Okx5i3IYA4wwyHX78Kb4yJFLmXoF24LQF NlzT/z6TP8y0NXYlHf4qRAWWDOu1IPoFiIxav1s/W41rgY3Dczn5MUomt12t6TwGYKTg0U3E0NJvC nWmptgXPr465KbX2xGtOiut/sGCUXk3R3uWYlrZ6DtchfTZtFR+oK2A4IxxWxrlmdC9KWSXosQE4M Yel7xNso/45QOESv5OrfiAdg6OUgGw==; Received: from ukleinek by master.debian.org with local (Exim 4.96) (envelope-from ) id 1x8aXc-003NLm-0y; Mon, 21 Sep 2026 09:42:28 +0000 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Sebastian Reichel , Chen-Yu Tsai Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/4] power: supply: axp20x_usb: Introduce a helper variable for &pdev->dev Date: Mon, 21 Sep 2026 11:41:48 +0200 Message-ID: X-Mailer: git-send-email 2.47.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=4334; i=ukleinek@debian.org; h=from:subject:message-id; bh=gg25qhHUozmURV2g5k4pHl4UyRqIAIqQl3hDObxAYPM=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBqsPvjiafXGoLxesODdahFOU+e6atbmpRTM0yF2 iLKziXDGwGJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCarD74wAKCRCPgPtYfRL+ Ti9vB/4+GuWh2fvmIIBHPWUBvzXw7O4aTj6h58z50JeVFMaFEDz3imlgHvO6bl/bVfwVHHQoaTo mxUKQHNMFJu/5sXgbu5Gs58Ghn6abt8k/mZ4aiB/JFtQtzV95vjSTdMDzC6uR2g+/9NolRXhIUC JU7TLcYiEaZjyEaDJ91DdQwcy8y1VBCvClbLVZkZFpqjcpU++97BWrzb7Nqee+6kOsS3he9+0wc 9Rl4CtsQZcuRXcpn01Tayo3LbxDrNKh0+9cuIf1vpO9zYR45nI6q3anD7Mxzjmle+5u1oZ7EBAi 6DJ7VY8ym/hoLmScaCQofjfS8H81YSElooN93Wj/Ldf9CP1J X-Developer-Key: i=ukleinek@debian.org; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable With the next commit adding several new usages of &pdev->dev, a helper variable is well justified. To not clutter that commit, split out the introduction of the helper out in this separate change to simplify review. Signed-off-by: Uwe Kleine-K=C3=B6nig Reviewed-by: Chen-Yu Tsai --- drivers/power/supply/axp20x_usb_power.c | 34 ++++++++++++------------- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/drivers/power/supply/axp20x_usb_power.c b/drivers/power/supply= /axp20x_usb_power.c index 463f9fe35cec..7ee3ec49d695 100644 --- a/drivers/power/supply/axp20x_usb_power.c +++ b/drivers/power/supply/axp20x_usb_power.c @@ -918,70 +918,70 @@ static void axp20x_usb_power_parse_dt(struct device *= dev, =20 static int axp20x_usb_power_probe(struct platform_device *pdev) { - struct axp20x_dev *axp20x =3D dev_get_drvdata(pdev->dev.parent); + struct device *dev =3D &pdev->dev; + struct axp20x_dev *axp20x =3D dev_get_drvdata(dev->parent); struct power_supply_config psy_cfg =3D {}; struct axp20x_usb_power *power; const struct axp_data *axp_data; int i, irq, ret; =20 if (!axp20x) { - dev_err(&pdev->dev, "Parent drvdata not set\n"); + dev_err(dev, "Parent drvdata not set\n"); return -EINVAL; } =20 - axp_data =3D of_device_get_match_data(&pdev->dev); + axp_data =3D of_device_get_match_data(dev); =20 - power =3D devm_kzalloc(&pdev->dev, - struct_size(power, irqs, axp_data->num_irq_names), + power =3D devm_kzalloc(dev, struct_size(power, irqs, axp_data->num_irq_na= mes), GFP_KERNEL); if (!power) return -ENOMEM; =20 platform_set_drvdata(pdev, power); =20 - power->dev =3D &pdev->dev; + power->dev =3D dev; power->axp_data =3D axp_data; power->regmap =3D axp20x->regmap; power->num_irqs =3D axp_data->num_irq_names; =20 - power->curr_lim_fld =3D devm_regmap_field_alloc(&pdev->dev, power->regmap, + power->curr_lim_fld =3D devm_regmap_field_alloc(dev, power->regmap, axp_data->curr_lim_fld); if (IS_ERR(power->curr_lim_fld)) return PTR_ERR(power->curr_lim_fld); =20 - axp20x_usb_power_parse_dt(&pdev->dev, power); + axp20x_usb_power_parse_dt(dev, power); =20 - ret =3D axp20x_regmap_field_alloc_optional(&pdev->dev, power->regmap, + ret =3D axp20x_regmap_field_alloc_optional(dev, power->regmap, axp_data->vbus_valid_bit, &power->vbus_valid_bit); if (ret) return ret; =20 - ret =3D axp20x_regmap_field_alloc_optional(&pdev->dev, power->regmap, + ret =3D axp20x_regmap_field_alloc_optional(dev, power->regmap, axp_data->vbus_mon_bit, &power->vbus_mon_bit); if (ret) return ret; =20 - ret =3D axp20x_regmap_field_alloc_optional(&pdev->dev, power->regmap, + ret =3D axp20x_regmap_field_alloc_optional(dev, power->regmap, axp_data->usb_bc_en_bit, &power->usb_bc_en_bit); if (ret) return ret; =20 - ret =3D axp20x_regmap_field_alloc_optional(&pdev->dev, power->regmap, + ret =3D axp20x_regmap_field_alloc_optional(dev, power->regmap, axp_data->usb_bc_det_fld, &power->usb_bc_det_fld); if (ret) return ret; =20 - ret =3D axp20x_regmap_field_alloc_optional(&pdev->dev, power->regmap, + ret =3D axp20x_regmap_field_alloc_optional(dev, power->regmap, axp_data->vbus_disable_bit, &power->vbus_disable_bit); if (ret) return ret; =20 - ret =3D devm_delayed_work_autocancel(&pdev->dev, &power->vbus_detect, + ret =3D devm_delayed_work_autocancel(dev, &power->vbus_detect, axp_data->axp20x_read_vbus); if (ret) return ret; @@ -1008,10 +1008,10 @@ static int axp20x_usb_power_probe(struct platform_d= evice *pdev) return ret; } =20 - psy_cfg.fwnode =3D dev_fwnode(&pdev->dev); + psy_cfg.fwnode =3D dev_fwnode(dev); psy_cfg.drv_data =3D power; =20 - power->supply =3D devm_power_supply_register(&pdev->dev, + power->supply =3D devm_power_supply_register(dev, axp_data->power_desc, &psy_cfg); if (IS_ERR(power->supply)) @@ -1024,7 +1024,7 @@ static int axp20x_usb_power_probe(struct platform_dev= ice *pdev) return irq; =20 power->irqs[i] =3D regmap_irq_get_virq(axp20x->regmap_irqc, irq); - ret =3D devm_request_any_context_irq(&pdev->dev, power->irqs[i], + ret =3D devm_request_any_context_irq(dev, power->irqs[i], axp20x_usb_power_irq, 0, DRVNAME, power); if (ret < 0) --=20 2.47.3 From nobody Fri Sep 25 21:02:39 2026 Received: from master.debian.org (master.debian.org [82.195.75.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1B52C46D2A6; Mon, 21 Sep 2026 10:04:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=82.195.75.110 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789985059; cv=none; b=aZxV+xq5hiRJ6jzLx70L1T/UJrNy/jWFAjppF4Rq0b+lTgg75WI5VuG84YEGzY1oxSFm0cAB3HgT1w07QrpvXdBQH/eEld8MWDfwIdNK9wqmp4rK3/tAC4sQyeKCiBJ/0dJOlWdeYNNbMqXsBLg3OafQCaUIThD+zsvh2CciRds= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789985059; c=relaxed/simple; bh=o8tkEtfdaCLslGnC7wOOlGKIAZ3lpJ9QEspVa1+MQcE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=FoEnUyWNaAPwNEygFH7Irw6m6S9PU/lGQ/gKOgSfnYDNucdFXNs0GgUIaIMtq+jVxKRahXZV3uTMuPszdJvNgvHWgtdjFRaMUOWbzGGF9P9NVzPirMwgGWjLM0uRAjEMN1A1EVn8WkZIPa27oBhe7DvbDDCz4nmsw7dn7vCcCVY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=debian.org; spf=none smtp.mailfrom=master.debian.org; dkim=pass (2048-bit key) header.d=debian.org header.i=@debian.org header.b=a2CuvkH4; arc=none smtp.client-ip=82.195.75.110 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=debian.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=master.debian.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=debian.org header.i=@debian.org header.b="a2CuvkH4" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debian.org; s=smtpauto.master; h=Content-Transfer-Encoding:Content-Type:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID :Content-Description; bh=sex8s1aAK4pDSoD9g8Psig1XFq5ZelUJOPbZALqcOA0=; b=a2Cu vkH4irWghq/a7o76/vQSJexagV5gHG6L6UrI6pJ1vcFkOXpYQ0/T2PhmSIBFuYpQq8l/jOGiUCyVr P28wkdCc+k5zuTZqOr7/vU4XnLZvoTItIyQtKixa8xrN5tErfcFNZiqDXSpshfrGCov3Ya0j7B7i/ qttw65JcNIYEVtvFJNxW/ZUOX5G9u7owZdrQSJCAqZyKA8jStZSu8SwtOqNenhmtv2AivJj/0szV9 azo5JvpSVH6aduuCF5Lya4q68F6v/bGWuRfZ/i5wJrnLWy6wTG6SPTj/9bOYwnTwRtL4rKLLl5ISt fdQOGt8xDFK40tRkgzi+5d5l1SmXxQ==; Received: from ukleinek by master.debian.org with local (Exim 4.96) (envelope-from ) id 1x8aXc-003NLx-34; Mon, 21 Sep 2026 09:42:28 +0000 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Sebastian Reichel , Chen-Yu Tsai Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 4/4] power: supply: axp20x_usb: Improve probe error reporting Date: Mon, 21 Sep 2026 11:41:49 +0200 Message-ID: X-Mailer: git-send-email 2.47.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=2530; i=ukleinek@debian.org; h=from:subject:message-id; bh=o8tkEtfdaCLslGnC7wOOlGKIAZ3lpJ9QEspVa1+MQcE=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBqsPvlMhq722loO0BAZOdRKkNGKPvrINNsWRu9h jEj/giuHDGJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCarD75QAKCRCPgPtYfRL+ ThiZCAC0DT90Y3g9lKVDJJq44XlyIGCgx6fen/3X749gu/KzRWYXu0U4UYkTM7r4PxTbw6xWFPb NKk3m/WO+jYdW5vEPhqJOvtwLVs1rQ8KigeCiWhbutbnhX0LCOEqAwvT08CyJhB+0c+wG96CZ+s aVwE3qw1FQULC3stpobkHoNWN5C3H8knjkPPKHbB17oaNG8DJNBMvBvJ0bXEAq5aeGJ/xD277cx trZdM1jFTVM3JBaB2hpyec6rBQ7Tl70OcFVXbJayISlA2ZeaiByPtUnjbpzhw6ZbgVmrV7HvBR0 ggw6tET1Xggjxzf6V7IVrsphSmdiaceDzuQcfMUcZRz88BBs X-Developer-Key: i=ukleinek@debian.org; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable Don't be silent about probe fail issues. Just having axp20x-usb-power-supply in /sys/kernel/debug/devices_deferred without a reason is making it harder than necessary to debug the actual issue. So be a bit more cooperative and add an error message for the typical failure points. Exit paths where the error is -ENOMEM and register write failures are skipped, these should be quite obvious even without a dedicated error message. Signed-off-by: Uwe Kleine-K=C3=B6nig Reviewed-by: Chen-Yu Tsai --- drivers/power/supply/axp20x_usb_power.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/power/supply/axp20x_usb_power.c b/drivers/power/supply= /axp20x_usb_power.c index 7ee3ec49d695..7625366104bc 100644 --- a/drivers/power/supply/axp20x_usb_power.c +++ b/drivers/power/supply/axp20x_usb_power.c @@ -925,10 +925,8 @@ static int axp20x_usb_power_probe(struct platform_devi= ce *pdev) const struct axp_data *axp_data; int i, irq, ret; =20 - if (!axp20x) { - dev_err(dev, "Parent drvdata not set\n"); - return -EINVAL; - } + if (!axp20x) + return dev_err_probe(dev, -EINVAL, "Parent drvdata not set\n"); =20 axp_data =3D of_device_get_match_data(dev); =20 @@ -998,7 +996,9 @@ static int axp20x_usb_power_probe(struct platform_devic= e *pdev) ret =3D axp_data->axp20x_cfg_adc_reg(power); =20 if (ret) - return ret; + return dev_err_probe(dev, ret, + "Failed to initialize for %s usage\n", + IS_ENABLED(CONFIG_AXP20X_ADC) ? "iio" : "adc"); } =20 if (power->usb_bc_en_bit) { @@ -1015,12 +1015,14 @@ static int axp20x_usb_power_probe(struct platform_d= evice *pdev) axp_data->power_desc, &psy_cfg); if (IS_ERR(power->supply)) - return PTR_ERR(power->supply); + return dev_err_probe(dev, PTR_ERR(power->supply), + "Failed to register power supply\n"); =20 /* Request irqs after registering, as irqs may trigger immediately */ for (i =3D 0; i < axp_data->num_irq_names; i++) { irq =3D platform_get_irq_byname(pdev, axp_data->irq_names[i]); if (irq < 0) + /* platform_get_irq_byname() already produced an error message */ return irq; =20 power->irqs[i] =3D regmap_irq_get_virq(axp20x->regmap_irqc, irq); @@ -1028,6 +1030,7 @@ static int axp20x_usb_power_probe(struct platform_dev= ice *pdev) axp20x_usb_power_irq, 0, DRVNAME, power); if (ret < 0) + /* devm_request_any_context_irq() already produced an error message */ return ret; } =20 --=20 2.47.3