From nobody Fri Sep 25 00:02:41 2026 Received: from mail-wr2-f12.google.com (mail-wr2-f12.google.com [74.125.225.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3CD312ED16D for ; Fri, 18 Sep 2026 14:34:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.225.76 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789742044; cv=none; b=kyQSQquB0g6OUoli6QuJwXFuJwgZvKJ2tGdK0x9huAiEo3hrA+RMtce2B8UJEFOOrQoh45NPFvHHTEWW9+RmO8qLohvgq+0FxU+k8VNIN62zhFFpey4awlKSNuSuLsq+vEk8AjRyFytXh67grv+Bu/54va2rQuaVOp2vkDMkbVg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789742044; c=relaxed/simple; bh=7Cv4SBcra0Ohdz6SOqua5EyRhbXggKO8tv0Gpq49x+8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=esJQK6y6x2pjrokU4THgvpTvp+h9dAJDGp+sH/Pm3UO4SM14P1C3g/eAIX3S7S5UpvYvsSIvxMhO6nw7DUlIu/XzlUwEF93hII2ov2ZKGeqgAJSiXE8hxymRSf7oOejD+G8h7WANxkdi5jbgelwbBwf6eSEO+gZIyd4pkxE1tnA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=ZhDRM7H8; arc=none smtp.client-ip=74.125.225.76 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="ZhDRM7H8" Received: by mail-wr2-f12.google.com with SMTP id ffacd0b85a97d-482f6350faaso464222f8f.0 for ; Fri, 18 Sep 2026 07:34:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1789742040; x=1790346840; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=Sjx4o8bJ6g5b8nq5GAvpSa8wVIWcrZHnOeqXqn9scx8=; b=ZhDRM7H85uR/DnyY2luQxPixNVkAI1NoICkA5SctxuNa6VrLloCn/NX1Mx/m1Jvqyn o7iZKyo0Y1rcTxfIzJS3aebN2B8JoqrqT10sq9YgaSMzq0CtQLI1oU2Yzu6/jTtb4Ygu uI1+K8aXOmUxsFhtlGHG64q71pHUEkHa94/ODoKW2SSnY7wojMNUtjm57UpsO+Z8HyFt zXXyThBcMYopoIJTaBWJ1QpjhATAY6jqv6z386DF0oCfN4GAep0tzozvSpImIO2oanTk tDXDy+npZzBNJz+dfgXj9BeO56DsrnHooYA2C+PlxrbhYdiVf5OrQI7I2gCIqoFTbF/7 aPLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789742040; x=1790346840; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Sjx4o8bJ6g5b8nq5GAvpSa8wVIWcrZHnOeqXqn9scx8=; b=FmzIYyltlOIlo0BG855nZy6nv5Jo8b1ZYdzRK9Chx/cs2Cq0lT8lbGjaLuTUaE96Ub pd+fl78+BWOZLx6seUK+MXl3GBoetpdIRj7di4wHBHcruho18Z6ZDix091t5ZhgCqvPt sg3m7ahQctvBpf0W+kJlxieaGVMWyauEeRUMT//gJACBcqfFD4OAHNDOCifZs9AOIrb2 GNWEpSQ3ON4wukoX924EeraIXOE9t1DPBvXsrfu5egdiDSCDOX9OTiAc3QKIyhUyF9qk gwixS9zcS0R4iAjLebsZe0xuLcCvjjOvL8WDf/YVwhucseAhB9qZzKWfZds6vG4RfES1 5CTw== X-Forwarded-Encrypted: i=1; AKwUvBw1BESvgZXHbdiFrQtQmwQwWGnAAv2wJIrnxJ1rXKnlTW9yKSp1gXim3utc0db7jMEqwfTWq2EBt0a5mqo=@vger.kernel.org X-Gm-Message-State: AFuF++k0SSX6opt0XfTjKtMPzqKhuuvFEOnpNoc3X3MfV9EVuoK8ghO+ pyOqfBMlrjfJ8zSHCvZksGWoTJaYnJaVMUhidlSuhSG2wvJy1GKNKWJwFs17E1bBYg0= X-Gm-Gg: AYBFou2o7rgV8t0SlK012WvIP8sXkesYZzZ0U+M/rr5++gMtHAeBQZG95Ht8TJRcqsf 7v86Uf4gBaU2j+rgzqy2mHUvhujT8pdVjgUPHyy/TsGbQrt2mcBUMshmhJJON3VcWhG/2k80Ti2 1fUYvj+VAA7+0xavAvVr1SA/qbqqYJFAqp08eUjs9uodhhStqGLCthyhvNt56MFKgey1xIm8U3v LxRH+utNPA+dQm/qTvNnrt/QWPwL4I/4jJBmpLhMlE9JM9/B5KpvKw1NfZOwiLSfI1r6QL/fKh3 FdCVPW7Mfpzit0kH8IyyM4Agf44bl+0a1Cm0NAutGqNsGExZLAgBxX9QorxlHmcUh+8Y8zNJp9+ ZdDJPY4c2r2gLOb+9H/yxWNtb4cWD1iTB7RFQVzXcHYmvi8dqkYbOCJuhlSmQ7wB4OXmPfu8aNm xxcQN/ZVGC41QbcHFOo2/+gH3QV4qGhJn8P2otPe5ntm9/X3RtVKo8+nEL2hpvbE6tj5fRVOJ3w oGuXGkXnYFcqGmJ10Z+oa6UjhGykh8z/cy3RSaocStk1OWvGYNEl6ZzoYPuJw== X-Received: by 2002:adf:e011:0:20b0:487:21a6:51d with SMTP id ffacd0b85a97d-48721a60df4mr1710417f8f.15.1789742040504; Fri, 18 Sep 2026 07:34:00 -0700 (PDT) Received: from localhost (p200300f65f19a90444c8989fe13f5be4.dip0.t-ipconnect.de. [2003:f6:5f19:a904:44c8:989f:e13f:5be4]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-4872008160csm5384787f8f.32.2026.09.18.07.33.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Sep 2026 07:33:59 -0700 (PDT) From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Thierry Reding , Jonathan Hunter , Mikko Perttunen Cc: Philipp Zabel , linux-pwm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/3] pwm: tegra: Make use of dev_err_probe() Date: Fri, 18 Sep 2026 16:33:45 +0200 Message-ID: <641219a7d76bbcd8fe98b5955f2355ed45f55986.1789741839.git.u.kleine-koenig@baylibre.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=4230; i=u.kleine-koenig@baylibre.com; h=from:subject:message-id; bh=7Cv4SBcra0Ohdz6SOqua5EyRhbXggKO8tv0Gpq49x+8=; b=owGbwMvMwMXY3/A7olbonx/jabUkhqy13mf+ZyUymK5KWyytFmks5K93LOmMm6hGxZRzFw8rV uxNV5jWyWjMwsDIxSArpshi37gm06pKLrJz7b/LMINYmUCmMHBxCsBEONI5GLYcldvP5PT8+RX9 dM6AY99NXvN19Hv9dOGr1kh45nbAr8HHydzqvsmRH6HZtueZD5bP3C+jy31o5pkPV758US/RXDC h91aDs5BoeavFvpnsn9OymUpt/tksEd1Vfm8h4+r09/fKZ93X2Ge2veCveDV/tYn3BbYux3vlYl 9N9fTk9Hu3sMzIzFNqveJVb7Ln9s0tvlknJxsKdbg/Yeax3iXx+qXtO493GZ/2zznWNyVx1R7NB 8LKH88vP6fzZ+MrTZ6DB2pueR185ihcGdEoYXy85Mn7BrPwEv7mXBFHocXNC7jLdnac45+/eYpP bN8tJ3nrfy7WsevWs2ady6+wEX2zVbWhr/yl5qQky/qPAA== X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable Usage of dev_err_probe() is more compact than dev_err()'s, emits the error code and handles -ENOMEM and -EPROBE_DEFER properly. Benefit from these improvements. Also add a few messages in error paths that lacked an output before. Reviewed-by: Mikko Perttunen Signed-off-by: Uwe Kleine-K=C3=B6nig --- drivers/pwm/pwm-tegra.c | 52 ++++++++++++++++++++++++----------------- 1 file changed, 31 insertions(+), 21 deletions(-) diff --git a/drivers/pwm/pwm-tegra.c b/drivers/pwm/pwm-tegra.c index 5cdbe120ba2d..efb7ab60f602 100644 --- a/drivers/pwm/pwm-tegra.c +++ b/drivers/pwm/pwm-tegra.c @@ -316,14 +316,15 @@ static const struct pwm_ops tegra_pwm_ops =3D { =20 static int tegra_pwm_probe(struct platform_device *pdev) { + struct device *dev =3D &pdev->dev; struct pwm_chip *chip; struct tegra_pwm_chip *pc; const struct tegra_pwm_soc *soc; int ret; =20 - soc =3D of_device_get_match_data(&pdev->dev); + soc =3D of_device_get_match_data(dev); =20 - chip =3D devm_pwmchip_alloc(&pdev->dev, soc->num_channels, sizeof(*pc)); + chip =3D devm_pwmchip_alloc(dev, soc->num_channels, sizeof(*pc)); if (IS_ERR(chip)) return PTR_ERR(chip); pc =3D to_tegra_pwm_chip(chip); @@ -331,28 +332,39 @@ static int tegra_pwm_probe(struct platform_device *pd= ev) pc->soc =3D soc; =20 pc->regs =3D devm_platform_ioremap_resource(pdev, 0); - if (IS_ERR(pc->regs)) + if (IS_ERR(pc->regs)) { + /* + * devm_platform_ioremap_resource() already emits an error + * message with CONFIG_HAS_IOMEM, so don't emit another message + * here. + */ return PTR_ERR(pc->regs); + } =20 platform_set_drvdata(pdev, chip); =20 - pc->clk =3D devm_clk_get(&pdev->dev, NULL); + pc->clk =3D devm_clk_get(dev, NULL); if (IS_ERR(pc->clk)) - return PTR_ERR(pc->clk); + return dev_err_probe(dev, PTR_ERR(pc->clk), "Failed to get clock\n"); =20 - ret =3D devm_tegra_core_dev_init_opp_table_common(&pdev->dev); - if (ret) + ret =3D devm_tegra_core_dev_init_opp_table_common(dev); + if (ret) { + /* + * devm_tegra_core_dev_init_opp_table_common() emits an error + * message most of the time, so don't add another. + */ return ret; + } =20 - pm_runtime_enable(&pdev->dev); - ret =3D pm_runtime_resume_and_get(&pdev->dev); + pm_runtime_enable(dev); + ret =3D pm_runtime_resume_and_get(dev); if (ret) - return ret; + return dev_err_probe(dev, ret, "Failed to runtime resume device\n"); =20 /* Set maximum frequency of the IP */ - ret =3D dev_pm_opp_set_rate(&pdev->dev, ULONG_MAX); + ret =3D dev_pm_opp_set_rate(dev, ULONG_MAX); if (ret < 0) { - dev_err(&pdev->dev, "Failed to set max frequency: %d\n", ret); + dev_err_probe(dev, ret, "Failed to set max frequency\n"); goto put_pm; } =20 @@ -363,8 +375,7 @@ static int tegra_pwm_probe(struct platform_device *pdev) */ pc->clk_rate =3D clk_get_rate(pc->clk); if (pc->clk_rate < TEGRA_PWM_DEPTH) { - dev_err(&pdev->dev, "clock maximum frequency out of range\n"); - ret =3D -ERANGE; + ret =3D dev_err_probe(dev, -ERANGE, "Clock maximum frequency out of rang= e\n"); goto put_pm; } =20 @@ -372,10 +383,9 @@ static int tegra_pwm_probe(struct platform_device *pde= v) pc->min_period_ns =3D (NSEC_PER_SEC / (pc->clk_rate / TEGRA_PWM_DEPTH)) + 1; =20 - pc->rst =3D devm_reset_control_get_exclusive(&pdev->dev, "pwm"); + pc->rst =3D devm_reset_control_get_exclusive(dev, "pwm"); if (IS_ERR(pc->rst)) { - ret =3D PTR_ERR(pc->rst); - dev_err(&pdev->dev, "Reset control is not found: %d\n", ret); + ret =3D dev_err_probe(dev, PTR_ERR(pc->rst), "Failed to get reset contro= l\n"); goto put_pm; } =20 @@ -385,17 +395,17 @@ static int tegra_pwm_probe(struct platform_device *pd= ev) =20 ret =3D pwmchip_add(chip); if (ret < 0) { - dev_err(&pdev->dev, "pwmchip_add() failed: %d\n", ret); + dev_err_probe(dev, ret, "Adding pwmchip failed\n"); reset_control_assert(pc->rst); goto put_pm; } =20 - pm_runtime_put(&pdev->dev); + pm_runtime_put(dev); =20 return 0; put_pm: - pm_runtime_put_sync_suspend(&pdev->dev); - pm_runtime_force_suspend(&pdev->dev); + pm_runtime_put_sync_suspend(dev); + pm_runtime_force_suspend(dev); return ret; } =20 --=20 2.47.3 From nobody Fri Sep 25 00:02:41 2026 Received: from mail-wr2-f12.google.com (mail-wr2-f12.google.com [74.125.225.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A0E413DF008 for ; Fri, 18 Sep 2026 14:34:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.225.76 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789742046; cv=none; b=QtFx2JmxUnXmI7pC5YVUOx61jTHRAYbaASMG2mDw8zSBl9RpdgAof3K1Lxfpg08jeDXsVl0fYSDZP2SDzF8ejqOGpQwhM+o5FQVrJVC4TT6Il5aHEAcO1iBJNZx6CM7ns8jm/J+l8Ttxvi2i0OLoafMtKyKsUjI+Z0BSQTo/h+Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789742046; c=relaxed/simple; bh=2qoRJ0EfVBn79bEPYyMqFcoyr6B/4C2K35zl5VDE3eo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=FVRBpo7E7rYVXUFVwWZ+tGP3ybUSHle3bcr9NmnkiZRFnA0mF4dxAseidChSzdb5mQJxhUnwAsa95P+PPW/UctVTorQ3jps14NIKG2DR92KV4TYRk/hh7OW/NbdHUFysXk67jHi9uYKHWJ9i9/SzKH2Fiky04dfEvjHQwNqMr3I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=J+/snMVG; arc=none smtp.client-ip=74.125.225.76 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="J+/snMVG" Received: by mail-wr2-f12.google.com with SMTP id ffacd0b85a97d-482f6351831so438146f8f.1 for ; Fri, 18 Sep 2026 07:34:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1789742043; x=1790346843; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=UxDe6gUzn40JCI8qcPtk5k9ALSIeeeIUpuxJOenZVXE=; b=J+/snMVGbQps9lwPp/EqjZHmJhuAVhJEuHubYBOguxxDVVB9y6uh94ej3i2eXXVqe4 8HKF0O0iD4bPrFQYEgohxNwJc5ZeGc03tYRdIHrm/eVq0/yvxsIyvkn60rnjpyaWsRuy BqfWmio+Sl7+CmhL+hlxEPGjVl/mlUfN5uZtLni4i2NNwimv1wNSr7OBTzoLqP7QsMLP bkvE9jhJ7xF8LPFvv8Z/5gIiKhNKLVXuiJtUNVG1z5gZzJh6B4yP41bzqmESa7F/o24k /CnTV1kxWdkL/9WGzuJen7JMIOn+x1ryhfSUwW+2HnShw0XrGE0Z2pFjA4AsfGFVUM+8 AQWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789742043; x=1790346843; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=UxDe6gUzn40JCI8qcPtk5k9ALSIeeeIUpuxJOenZVXE=; b=KTsn22vn3SE/N7yyU5RgFJjQR95EPYt1uwdTJAsL9lML3ittrEdQ3bPk+TVbpQJDhk bPwKLWLB0ydZCPiURi+JGZAmIwt1J9414hfL9ZKBWirDStUvO3u9S7MwUOSVFlPfI6vT 8kymbGVhL4zy6F3eZ5t9XwOjbYY8fCNpguiOAySBwaUxCfzVzfkMkxLBDzewjJbUdP2Z MRXP514rigKz7hzg48DttHitvVN5gy89/THamzxTN60fLnlgdEuNRHN6M//PUd7tf8nI bqNoBq4g7gWXSuFmIncRrCAcztyywrx/sV/WmfQgfnGIytDy0eY3rL/mjINc/j3z4wBE rmhg== X-Forwarded-Encrypted: i=1; AKwUvBxvTi8LzuF/tFPgHWKvJONuefoOP4iQoSAGZWMS2xEAVFgggapfw+KUqv71SDIGsCuGweLRUNxTxOY5iW0=@vger.kernel.org X-Gm-Message-State: AFuF++mo552+HFoui6luiw2ohNqEx8N+GA9D0FKISaqRalAf38+9u583 ZrRcpIVhUjdaBOfZWThXNmbVlNzZjsIuHUyndVmz20a7DJGir+SKzEnQEjDb1OLlI+A= X-Gm-Gg: AYBFou0sepiZjpAmw5KAfgIqa3tD0hRJU9wUz05hYbLwe0ptidlcAJ2c8XAKC70GaP3 OhfA/YT1zSSbkgmd5UmeCccewjyu0eE3Hgsgkp7vFBtqwWepdZXMb/7YUaitW7H3ExQzaGiPQUP TMphnCapAGSd3kqiwbeDdV+ZKKz9v1f0pTsrx7ZNIEe2pUkRt42gE3U8s4YwYXYC2uUvsnehKVs SyD5uDjlW6KKI/YNTx2O41IbQCKc+v09Vzj79JOdSK3NEonTo2iyA77byG1paCuPWOmLxRFF4mR Kg3y8qq+QfGcPuPUln9Sz1tx3zEFOnrMoiRXqL3RTg2sPeS57XEHvtdTuBC7H+VvdamOBK2zXh0 OPvRwCS+9FEgnnpNqgJxQyxnFKZY+nCwotXpWb+mE3uu/rVJXi85eMbVGNP3r1CW2ydLhJzWAQ+ TsqIMDn84TV3RM1IgKBIMwslThXTMc0z0ZcqmA+DGdDATIFy8uWrqgFaOYHvvKML7MNUkaHQEyT O5WSZvs50tPZG4oXJRkvEgmfdwhZTHRR1HJ4c2r2CX8Ogr7mbLfJaNQS+SOPQ== X-Received: by 2002:a05:6000:4809:b0:487:b50:1020 with SMTP id ffacd0b85a97d-4871e221a3dmr3786100f8f.24.1789742042764; Fri, 18 Sep 2026 07:34:02 -0700 (PDT) Received: from localhost (p200300f65f19a90444c8989fe13f5be4.dip0.t-ipconnect.de. [2003:f6:5f19:a904:44c8:989f:e13f:5be4]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-4872008fe3csm4571627f8f.37.2026.09.18.07.34.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Sep 2026 07:34:01 -0700 (PDT) From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Thierry Reding , Jonathan Hunter , Mikko Perttunen Cc: Philipp Zabel , linux-pwm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 2/3] pwm: tegra: Check for match_data being NULL Date: Fri, 18 Sep 2026 16:33:46 +0200 Message-ID: X-Mailer: git-send-email 2.47.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=948; i=u.kleine-koenig@baylibre.com; h=from:subject:message-id; bh=2qoRJ0EfVBn79bEPYyMqFcoyr6B/4C2K35zl5VDE3eo=; b=owGbwMvMwMXY3/A7olbonx/jabUkhqy13ud63rfP7uDkjurJaYiep5fuKSkqdGpL8LnrWySTd +5827emk9GYhYGRi0FWTJHFvnFNplWVXGTn2n+XYQaxMoFMYeDiFIAbvZj9nz3Tx8s7cn4K6DbL upx8kSqszOKs2qpYclZON/5DdYAqo2jYHt8FN537v3ovvLGpu+TPmXv2PXeKo26/PpZ34pOiRE/ yjWevH942vJ3i53B2I3u6kjGjZb5iQtGmaa2+v5Jk4jYZyF2KvjLvhNIdNYGiHa0TzRQOM2/ijo 8+YmczdWFBW8Xm76/d1opJ5q7ltG/TP7/zTrt4Tjl/lOCW48LWoQm5ln8PCwm9T3txc+HVK//dG E/J3Gx189d6HS7Oftjos0yJ9ucW+VUCr+MaLv5wz77E26P+exJb47NNUypT3y0S8fyw/aR+HMPb peF35W8s2y21lOl4ef7WdTN+xSfzygo8ZJV0tMgKu5sKAA== X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable It's unlikely but not impossible that of_device_get_match_data() returns NULL. Handle this case instead of triggering a NULL pointer exception. Signed-off-by: Uwe Kleine-K=C3=B6nig --- drivers/pwm/pwm-tegra.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/pwm/pwm-tegra.c b/drivers/pwm/pwm-tegra.c index efb7ab60f602..b461d3877f43 100644 --- a/drivers/pwm/pwm-tegra.c +++ b/drivers/pwm/pwm-tegra.c @@ -323,6 +323,14 @@ static int tegra_pwm_probe(struct platform_device *pde= v) int ret; =20 soc =3D of_device_get_match_data(dev); + if (!soc) { + /* + * This can only happen if pdev was matched via pdev->name + * (which should not happen today) or in combination with a + * driver override. + */ + return dev_err_probe(dev, -ENODEV, "Unsupported device\n"); + } =20 chip =3D devm_pwmchip_alloc(dev, soc->num_channels, sizeof(*pc)); if (IS_ERR(chip)) --=20 2.47.3 From nobody Fri Sep 25 00:02:41 2026 Received: from mail-wm2-f13.google.com (mail-wm2-f13.google.com [74.125.225.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 11EE749D587 for ; Fri, 18 Sep 2026 14:34:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.225.141 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789742049; cv=none; b=bv8L3tDHfQ8VUuL4pQJJM0mRub1P0CR/HlYSq1+uqRtf4hZoHgYAzzejoy/5EB2C5jR8tLzxJbNbDdwG0OJZfU3rqoJXfJ9k5Aodwrgrv6yCm2i/o4CbV4ma1ZSzGlMGuE6vLf9so9BBg2o9kk/fOiZm+uODBhRoT3jXbE0duTw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789742049; c=relaxed/simple; bh=xWBZ1RSCOb2sPTHZ3/cPm3sP3q3od05A9jCMXfg09xI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=kB6Xs8SvjRt8EujrO9cTdIDsits89kueRbKca17dcsbfpVX/j/5CpGjSEZ4YlL3wb1tFD/YWkibnwPjv9Cv2tpmyhh9xmqoBQ/3qR2WSV+sxknlC7FLksSS6NYQl87jEjN9jUM8A0mvGHcuxS3z0s+mNbsiAAOOF3mwJN1HhTJM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=mt+Y09Lz; arc=none smtp.client-ip=74.125.225.141 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="mt+Y09Lz" Received: by mail-wm2-f13.google.com with SMTP id 5b1f17b1804b1-49e83a388f8so5366235e9.1 for ; Fri, 18 Sep 2026 07:34:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1789742044; x=1790346844; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=xqW5h3rRLnqhtoQ3APikYnZ226msCNVttggqavOp9CY=; b=mt+Y09Lz0DHRDJPhkWYmsNzpgQXD9a30qGPi8En1XGxlgvkTDOi6i++dkq3sWCD1+4 eXZIYXM8jpluhvF+YvvP7jwwk8Oy5jne9xUm3TLowozVblvVQr1fULdWPZKErvpLV4iw TyoLrKPdCi95eR3dc+f1CCBg0hv1POkSySxkqIIerVVTpudsKeQLvWenzqWgy46Rkq3z bERwBsAL69yzZlFgCShjp9uRu/KQA7FjcteYfxSxZ1UKAfjc1ua6M0fh2HMKofhwGSWj WAtfFV6fMaHFcIP51XBMY2XM2yA08+6FM/y1NVrzZm55z8yY4N9n+t4l80+uPCTD3IVK H8jA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789742044; x=1790346844; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=xqW5h3rRLnqhtoQ3APikYnZ226msCNVttggqavOp9CY=; b=bDSdLrlmyt3l6Bx4S0yG1BxMHe/vCcbHBgDh7JH26E2Dm6byKa5eYzMRZJG11tCIc5 N66DWs+DHkd3jNQlDIvQJqHXGm8D3mzU4IDfiF/nFnWCoWegTpW4pYNrsLqTVydxrn9W 7T37/Bope53bQ13/Audn0XizjU0bQiO6hTp7qwq5rpYmUjv1R7pK07JHbJLFDf76lb8P GxncZU4LaIbQPtxW7DAagdyHYU0Irgs8RwxwkwChjW+UPV4jU9p+1MYI1eTSfVJp7MIj GWDD5ax6jmhI4+9asTWs8E8fwDBcYBlUkLc4gVTwOTBxfG3jeyY8JdKNRFRumdoIlrBh f/Mw== X-Forwarded-Encrypted: i=1; AKwUvBwf7KVdpXsSRBqWgZSJVkWqZex7gNez+fl34BViWv1VoRvShtnRV4oXJjdMJ26DIEl8fjsBsAq1BQcTzHo=@vger.kernel.org X-Gm-Message-State: AFuF++mPFtvW9TdUVj5a3lNBl0QXWoY1RP4Xvw/i0EZREPNX0u2q09jD UBXde+vTxM5UJR4PpcDsjKvC2lavFwrbxESN3mN8psfNSAcVEMzIDTqBFoBqtHan8lEeEgtPmGC P7tLk X-Gm-Gg: AYBFou2CiWuoI+UqaL69rill7kB8BEJ7bBPUeoIphtd48/SE0TLJF/FAh5wPs5XYDj9 MI/bzsv4RMPO6kjhJUu438WSHKk928lA3Fg0sCucmvCbB3RBpIMCG09TtqHh810C4T3MjuewpCM s+3b5zAmtlBchkN9ifS0s2NhPKoF6DyRIF1HV2wHk/3/5KZVg5UsddgyuKocQfUHXAid38h7sVi +2Jop7XktslXw35p8d6GZH2aqxl3RuktsuvLB5d67FosSWT5cn68VI3sqfPVj2VxGx/JaJBlUQ9 /n3xGR2zOOhlyw7DrRtRV/Ckh4wNJnt0r8JN1DeBT+AbbwtFBZ81FtCFB8NfpwLEVS4AYY0+o8G aOhzLc+h2hljEWfnOqr8knjZvuP0biFtilxsyYvAjNF5kFp/s0fJMnhSVzvp29uCYcZDs04kPte goVl9gjwlGTZHt7kbOfvwDonfC7z753/EsdfGMOOPq8wAjSX1QCYMYpfK1TaoBUH5ywkVZ1NmPp n6pKEy5PLwjkRla2ULXQ+X/9ZVr4tgT9knU3+lJhOngQwzDA62FUbJWGJEJsg== X-Received: by 2002:a05:600c:8b8b:b0:49e:663c:c69f with SMTP id 5b1f17b1804b1-49fc56d170dmr31354845e9.15.1789742044127; Fri, 18 Sep 2026 07:34:04 -0700 (PDT) Received: from localhost (p200300f65f19a90444c8989fe13f5be4.dip0.t-ipconnect.de. [2003:f6:5f19:a904:44c8:989f:e13f:5be4]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-48720072efcsm4458883f8f.25.2026.09.18.07.34.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Sep 2026 07:34:03 -0700 (PDT) From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Thierry Reding , Jonathan Hunter , Mikko Perttunen Cc: Philipp Zabel , linux-pwm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, "Ola Chr. Vaage" Subject: [PATCH v2 3/3] pwm: tegra: Implement .get_state() Date: Fri, 18 Sep 2026 16:33:47 +0200 Message-ID: X-Mailer: git-send-email 2.47.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=2234; i=u.kleine-koenig@baylibre.com; h=from:subject:message-id; bh=xWBZ1RSCOb2sPTHZ3/cPm3sP3q3od05A9jCMXfg09xI=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBqrUvQk/+ohXgs+lRHunSsyku0trjD3CJV3pLrs FzIO5KtU/GJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCaq1L0AAKCRCPgPtYfRL+ TmCIB/9rvizxMyVjppYBSRwq+FlnCb8gCWROptuLc40bhFoK6f3ZCQJyRXKUXnpPnqaaf5uQHhr bzb+uleAxKPXxgltstGwYvAGn8SJDFDUAfkjkgXxpNAUSSg5qKD9T3p3mjo17Xbkjxi1WsFFmmX +r7O4gFFKpuFJXzoDLQYIFHXgT3pzb41I2+jXeU9P91qmiEiT5tGz5IR7LSfQ0NJOQ4nczMuMT9 Y5myRL2tIBOa5913212w1Z06twEHBMdloj6tJi1LMNzfuMh1g9n1jtRjve6T59rJsspyFG/8MsO pP8l0Pq1E4xACWk612IdxIptrnEoK1eondT1tuca8NFl5neP X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable The registers of the PWM IP are readable. Use that to implement the .get_state() callback. Reviewed-by: Mikko Perttunen Tested-by: Ola Chr. Vaage Signed-off-by: Uwe Kleine-K=C3=B6nig --- drivers/pwm/pwm-tegra.c | 48 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 48 insertions(+) diff --git a/drivers/pwm/pwm-tegra.c b/drivers/pwm/pwm-tegra.c index b461d3877f43..0520d025c776 100644 --- a/drivers/pwm/pwm-tegra.c +++ b/drivers/pwm/pwm-tegra.c @@ -310,8 +310,56 @@ static int tegra_pwm_apply(struct pwm_chip *chip, stru= ct pwm_device *pwm, return err; } =20 +static int tegra_pwm_get_state(struct pwm_chip *chip, struct pwm_device *p= wm, + struct pwm_state *state) +{ + struct tegra_pwm_chip *pc =3D to_tegra_pwm_chip(chip); + int rc; + u32 val; + + rc =3D pm_runtime_resume_and_get(pwmchip_parent(chip)); + if (rc) + return rc; + + val =3D tegra_pwm_readl(pwm, pc->soc->enable_reg); + if (val & TEGRA_PWM_ENABLE) { + u32 scale, pwm0; + + if (pc->soc->enable_reg !=3D TEGRA_PWM_CSR_0) + val =3D tegra_pwm_readl(pwm, TEGRA_PWM_CSR_0); + + scale =3D (val >> TEGRA_PWM_SCALE_SHIFT) & ((1 << pc->soc->scale_width) = - 1); + pwm0 =3D (val >> TEGRA_PWM_DUTY_SHIFT) & (2 * TEGRA_PWM_DEPTH - 1); + + if (pwm0 > TEGRA_PWM_DEPTH) + pwm0 =3D TEGRA_PWM_DEPTH; + + /* + * scale + 1 is at most 1 << 17, TEGRA_PWM_DEPTH is 256, so the + * multiplication for .period doesn't overflow a u64. With + * pwm0 =E2=89=A4 TEGRA_PWM_DEPTH, .duty_cycle is also fine. + */ + *state =3D (struct pwm_state){ + .period =3D DIV64_U64_ROUND_UP((u64)(scale + 1) * TEGRA_PWM_DEPTH * NSE= C_PER_SEC, pc->clk_rate), + .duty_cycle =3D DIV64_U64_ROUND_UP((u64)(scale + 1) * pwm0 * NSEC_PER_S= EC, pc->clk_rate), + .polarity =3D PWM_POLARITY_NORMAL, + .enabled =3D true, + }; + + } else { + *state =3D (struct pwm_state){ + .enabled =3D false, + }; + } + + pm_runtime_put(pwmchip_parent(chip)); + + return 0; +} + static const struct pwm_ops tegra_pwm_ops =3D { .apply =3D tegra_pwm_apply, + .get_state =3D tegra_pwm_get_state, }; =20 static int tegra_pwm_probe(struct platform_device *pdev) --=20 2.47.3