From nobody Fri Sep 25 09:19:41 2026 Received: from mta0.migadu.com (out-73.mta0.migadu.com [91.218.175.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A3F09399013 for ; Mon, 14 Sep 2026 19:13:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.73 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789413241; cv=none; b=B87QNrkZ3Zc/HVrhQSdcfHysDq1ByZImTuEJS/lytKNBvhs+M1IHLvKwSWUmETHt/lZ6mWvByaLimANyJmPYxHZ5b75jw5QWk6NwMI+duM32obvHZixHFWueon5qWvgpK1es7JeaBZp05HaUk6BZEnrtwunUd9occ9ZlXmwPHFs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789413241; c=relaxed/simple; bh=+4kR8MIFX6t5QidLegcaQ2NHPJ54cO3nz9NAO9k7Jtc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type; b=icUdCCXQnBRFVoZqVOUVpM3QhH4ydUW+A9C/Rxe2xTm628fvyV4h20t/NfXQ5v93doxqRfxHcxUYu1oRt97LuwzTD4vxYOG045YwyaCacxdwuJg15PLAbl7v32a4dzPoq9UKoBaZM9kB3m45FGHR2Om+cLnfiRSaNaMUytoYNtE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=FLJAM3Hg; arc=none smtp.client-ip=91.218.175.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="FLJAM3Hg" X-Envelope-To: linux-kernel@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=+4kR8MIFX6t5QidLegcaQ2NHPJ54cO3nz9NAO9k7Jtc=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1789413234; v=1; x=1790018034; b=FLJAM3HgLUre2b7FRUVga6aPVoCsw03u17EeF6gxeC5+5r/VceviZN+JqBk/HL4pyQuC1Oid GF0ZWsqp2iogor2TXJbEX4QIhy6szGpFst6jDrGz62EHOlQUyuCwlr2D+/oSd+ObaMEbIaAghwM KXEoTOx6evekxP74FPbXQgzc= X-Envelope-To: linux-kernel@vger.kernel.org Received: by mta10.migadu.com with ESMTPS id 72d3a83f1702b20c; Mon, 14 Sep 2026 19:13:54 +0000 X-Mizu-Trace-ID: 72d3a83f1702b20c X-Migadu-Flow: FLOW_OUT From: wen.yang@linux.dev To: Gabriele Monaco Cc: Nam Cao , linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org, Wen Yang , =?UTF-8?q?Thomas=20Wei=C3=9Fschuh?= Subject: [PATCH v6 1/4] rv/reactors: use LD_WAIT_SPIN as the reactor lockdep wait type Date: Tue, 15 Sep 2026 03:13:34 +0800 Message-Id: <5586dd00789a0f904cc299cd8889744b8c6f8dc9.1789412799.git.wen.yang@linux.dev> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable From: Wen Yang rv_react() overrides the lockdep wait type to LD_WAIT_FREE to enforce that reactor callbacks take no locks. But callbacks run in the context of the triggering tracepoint, which can be preemptible task context on any kernel. A timer interrupt firing during the callback makes the interrupt-exit path schedule and take rq->__lock (LD_WAIT_SPIN) while the LD_WAIT_FREE override is still held, producing a spurious "Invalid wait context" warning: [ BUG: Invalid wait context ] context-{5:5} 1 lock held by kunit_try_catch/209: #0: (rv_react_map-wait-type-override){+.+.}-{1:1} kunit_try_catch/209 is trying to lock: ffff8a743ed3e8a0 (&rq->__lock){-...}-{2:2} Use LD_WAIT_SPIN instead of LD_WAIT_FREE, which causes false-positive warnings in preemptible contexts due to scheduler preemption taking rq->__lock. Fixes: 69d8895cb9a9 ("rv: Add explicit lockdep context for reactors") Reviewed-by: Gabriele Monaco Signed-off-by: Wen Yang Cc: Thomas Wei=C3=9Fschuh --- kernel/trace/rv/rv_reactors.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/kernel/trace/rv/rv_reactors.c b/kernel/trace/rv/rv_reactors.c index 2f5fc8d18dea..ff7d478227c3 100644 --- a/kernel/trace/rv/rv_reactors.c +++ b/kernel/trace/rv/rv_reactors.c @@ -465,7 +465,15 @@ int init_rv_reactors(struct dentry *root_dir) =20 void rv_react(struct rv_monitor *monitor, const char *msg, ...) { - static DEFINE_WAIT_OVERRIDE_MAP(rv_react_map, LD_WAIT_FREE); + /* + * Reactors must not explicitly take locks, so they should be + * LD_WAIT_FREE. However, reactor callbacks can run with preemption + * enabled, meaning the preempting code (e.g. the scheduler taking + * rq->__lock at LD_WAIT_SPIN) may violate that constraint. Use + * LD_WAIT_SPIN to avoid false-positive lockdep reports. + * But you should still NOT be using locks in reactors. + */ + static DEFINE_WAIT_OVERRIDE_MAP(rv_react_map, LD_WAIT_SPIN); va_list args; =20 if (!rv_reacting_on() || !monitor->react) --=20 2.25.1 From nobody Fri Sep 25 09:19:41 2026 Received: from mta0.migadu.com (out-79.mta0.migadu.com [91.218.175.79]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 97EA2384CF2 for ; Mon, 14 Sep 2026 19:14:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.79 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789413247; cv=none; b=QAYWN4d7XYNHrlXDT6o7tF4CLmRHaErS3YEcKkGrMN+aje9VWuOWTlw6Kh3CHLYnHNxToccjSGzbat8rAvo/uhE7u6RFV7RNelauD4M8NbpDgTbMJcR+gJ4/8ycaQFpAXbSczJf5YL/G8bqU7Ik1/jt9en/YNjDFxrQAy1ReQho= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789413247; c=relaxed/simple; bh=xb99JgDGTtCItKyuxlPAFODc8L6TfNE8KIBXgN0TWUQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=tI4jgqzF9bHFgtcvULx/jdcElQGFGU4HN4mXAKtEWoh6lzuqw8xkloV6VRtAIqhi+quo3/6nfE6DTZVTR+fWSFJ5DhaJrjMw/hKY0N+VHb+PdRrxuIb9JiWnNq0QDrnUqs4v6llsWjT2GeodHm3BmsIt5+fBkBLhKvAx6SPRpVA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=FWS1lNLp; arc=none smtp.client-ip=91.218.175.79 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="FWS1lNLp" X-Envelope-To: linux-kernel@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=xb99JgDGTtCItKyuxlPAFODc8L6TfNE8KIBXgN0TWUQ=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1789413237; v=1; x=1790018037; b=FWS1lNLpoPI1tBVZMBqF5IeelD/6x6FEAAj4IacdwFCb+Psvq8atJPc+1FFpDFVDdC96VThv GygIE7W+0I34RCn331S2z0NPKyx8FOX0Qd5uAFmfGB4OaITPi/yI4V4BOHluWVasSClFXZ5u5Ry 4EZo+a4Z0GvHYDvURVGs4hE4= X-Envelope-To: linux-kernel@vger.kernel.org Received: by mta10.migadu.com with ESMTPS id 418e8b628414cde1; Mon, 14 Sep 2026 19:13:57 +0000 X-Mizu-Trace-ID: 418e8b628414cde1 X-Migadu-Flow: FLOW_OUT From: wen.yang@linux.dev To: Gabriele Monaco Cc: Nam Cao , linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org, Wen Yang Subject: [PATCH v6 2/4] rv/reactors: propagate rv_register_reactor() error from reactor init Date: Tue, 15 Sep 2026 03:13:35 +0800 Message-Id: <1684c66520cee66ba86224f2b9e473c7dd2416ee.1789412799.git.wen.yang@linux.dev> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Wen Yang Both register_react_printk() and register_react_panic() ignore the return value of rv_register_reactor() and always return 0. If the registration fails (e.g. a duplicate reactor name), the init functions silently report success even though the reactor was not registered. Propagate the error from rv_register_reactor() so a failed registration is reported instead of being silently ignored. Reviewed-by: Gabriele Monaco Reviewed-by: Nam Cao Signed-off-by: Wen Yang --- kernel/trace/rv/reactor_panic.c | 3 +-- kernel/trace/rv/reactor_printk.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/kernel/trace/rv/reactor_panic.c b/kernel/trace/rv/reactor_pani= c.c index 76537b8a4343..db7116ceafff 100644 --- a/kernel/trace/rv/reactor_panic.c +++ b/kernel/trace/rv/reactor_panic.c @@ -26,8 +26,7 @@ static struct rv_reactor rv_panic =3D { =20 static int __init register_react_panic(void) { - rv_register_reactor(&rv_panic); - return 0; + return rv_register_reactor(&rv_panic); } =20 static void __exit unregister_react_panic(void) diff --git a/kernel/trace/rv/reactor_printk.c b/kernel/trace/rv/reactor_pri= ntk.c index 48c934e315b3..002a10f6aa7b 100644 --- a/kernel/trace/rv/reactor_printk.c +++ b/kernel/trace/rv/reactor_printk.c @@ -25,8 +25,7 @@ static struct rv_reactor rv_printk =3D { =20 static int __init register_react_printk(void) { - rv_register_reactor(&rv_printk); - return 0; + return rv_register_reactor(&rv_printk); } =20 static void __exit unregister_react_printk(void) --=20 2.25.1 From nobody Fri Sep 25 09:19:41 2026 Received: from mta0.migadu.com (out-82.mta0.migadu.com [91.218.175.82]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D50283B9DAB for ; Mon, 14 Sep 2026 19:14:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.82 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789413247; cv=none; b=F05P6H0Mlqr8O+IOBTspXbNrFw6De4E8PGYABGn2hMZKoiKNLimnJVtaTcgyPFCQricZZstbp19KWa6paA5UNmsVAY+hApGqHSQpbSTDckVNMQNS/p3O/JNZQyr0eRb03209ZaJS8+3v9324N1ziIEksUxA7b2ieluoDBZ6XmVQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789413247; c=relaxed/simple; bh=eTbZ0dyiDFT16Alt0dAIvaliqkaJj1LNEmU2jMelxIc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=juAOe55j8Wa2c1Gf52sIL9/fayjE/1ocRWd5iATtUzqjdjZe+/hfRn3Zu4ww+XqV8ZMypKRZTjUEKJkmAxhQkoydE598B+Hddu7hX+FHdQw9M0mGHKxprheGWWdA7/y8g2p6n+TpzpLogG7WK51M2NsYBqLnlbyTQAJX2GCMuv4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=BCovMbmy; arc=none smtp.client-ip=91.218.175.82 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="BCovMbmy" X-Envelope-To: linux-kernel@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=eTbZ0dyiDFT16Alt0dAIvaliqkaJj1LNEmU2jMelxIc=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1789413240; v=1; x=1790018040; b=BCovMbmyPrNqc6gHI2f5W1ngdPia/9aFsDW5ZkgCqv1rkSRI/sWx8ssAx+Gf1HusgsW2QCw5 41Xv0FCca8WPv69XVVH7GD/Z9V58X6XDbvIWlNv5XWVGZIbQkfRPiAl4QLASbWAqoMu5w+tQ1OW yU5GI2Eyw6qzm34uj6c76H1w= X-Envelope-To: linux-kernel@vger.kernel.org Received: by mta10.migadu.com with ESMTPS id 0d17df70ff850e5e; Mon, 14 Sep 2026 19:14:00 +0000 X-Mizu-Trace-ID: 0d17df70ff850e5e X-Migadu-Flow: FLOW_OUT From: wen.yang@linux.dev To: Gabriele Monaco Cc: Nam Cao , linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org, Wen Yang Subject: [PATCH v6 3/4] rv/reactors: export rv_register_reactor() and rv_unregister_reactor() Date: Tue, 15 Sep 2026 03:13:36 +0800 Message-Id: <94b7ec120a92b9368541ac050601e66be8fe653a.1789412799.git.wen.yang@linux.dev> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Wen Yang rv_react() is exported to modules, but the reactor registration helpers are not. Export them with EXPORT_SYMBOL_GPL() so reactor modules and the tristate KUnit test module can register and unregister reactors without hitting undefined symbol errors at link time(modpost). Commit 3d3800b4f7f4 ("rv: Remove reactor's reference counter") noted that module-based reactors, if supported, should be pinned with try_module_get()/module_put() to prevent unloading under an active monitor. This patch does not add that support. The only in-tree module consumer, the tristate KUnit reactor test module, registers and unregisters its reactor within a controlled test lifecycle. The actual pinning is left to a follow-up series that adds support for loadable-module reactors. Reviewed-by: Gabriele Monaco Signed-off-by: Wen Yang --- kernel/trace/rv/rv_reactors.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/kernel/trace/rv/rv_reactors.c b/kernel/trace/rv/rv_reactors.c index ff7d478227c3..8e57a95d446b 100644 --- a/kernel/trace/rv/rv_reactors.c +++ b/kernel/trace/rv/rv_reactors.c @@ -314,6 +314,7 @@ int rv_register_reactor(struct rv_reactor *reactor) guard(mutex)(&rv_interface_lock); return __rv_register_reactor(reactor); } +EXPORT_SYMBOL_GPL(rv_register_reactor); =20 /** * rv_unregister_reactor - unregister a rv reactor. @@ -327,6 +328,7 @@ int rv_unregister_reactor(struct rv_reactor *reactor) list_del(&reactor->list); return 0; } +EXPORT_SYMBOL_GPL(rv_unregister_reactor); =20 /* * reacting_on interface. --=20 2.25.1 From nobody Fri Sep 25 09:19:41 2026 Received: from mta0.migadu.com (out-85.mta0.migadu.com [91.218.175.85]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C8B73ACEE0 for ; Mon, 14 Sep 2026 19:14:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.85 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789413251; cv=none; b=e4RWtq/BsRE1fuv5VsQG1CiiHoA/7xmgf7km12qYFb+hPoa9LOh4wp3rlouoq+/WAXiNYFyUumh5TbvGo5JZtsUpfJVCpsCHDReLnjvC3nWakfGmuDK3oaxQHa9e9Y9/8vjHQMdFCez/9N2JXViNrmLrieNyrtwgCkFcl2BwMmE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789413251; c=relaxed/simple; bh=E5rD+GC6hBExNZ+C0zpz9VB7RMnNCVhPsy+cbEyF7II=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=pNIojqtqXj9vlDkN+A6t9knIsN5RsX265yIXv0gA0nBwt3+1lotB+RrlNf8HGf0gnYhWHiDw5FS0roYDKlnYWgHqVgrhQna/PezM2DjTHvmG6okvIi1NhFH5KhDdQPCuUV6ajl6L9Va2NxQjM/7ShIA+6YYg47r+QVHROJxONpQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=L6DoL0Vj; arc=none smtp.client-ip=91.218.175.85 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="L6DoL0Vj" X-Envelope-To: linux-kernel@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=E5rD+GC6hBExNZ+C0zpz9VB7RMnNCVhPsy+cbEyF7II=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1789413244; v=1; x=1790018044; b=L6DoL0VjSHJapG1NLQ9mH2HPHE4+ogacHPTDmxAUULhBrwL8lARPy/X31kC+Sb2gPOQZjFxi Suodqrbvhzjow5Rpcr7ZIntSVkrml2f0ZcIRyNbvLar5/TcygyirmglubDKatJvnLdlTZjBQaVp 6Jth1DiSh0TvngOslX7tvzQA= X-Envelope-To: linux-kernel@vger.kernel.org Received: by mta10.migadu.com with ESMTPS id 7dd95a410480780c; Mon, 14 Sep 2026 19:14:04 +0000 X-Mizu-Trace-ID: 7dd95a410480780c X-Migadu-Flow: FLOW_OUT From: wen.yang@linux.dev To: Gabriele Monaco Cc: Nam Cao , linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org, Wen Yang Subject: [PATCH v6 4/4] rv/reactors: add KUnit tests for reactor registration and dispatch Date: Tue, 15 Sep 2026 03:13:37 +0800 Message-Id: <7d213b110815da45595ad8cd7bcce5641fac3404.1789412799.git.wen.yang@linux.dev> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Wen Yang Add KUnit tests covering the reactor register/unregister lifecycle (including duplicate and name-length rejection) and rv_react() dispatch (a no-op without a callback, exactly one invocation with one). The mdelay() callback keeps the CPU busy so a timer interrupt lands inside rv_react()'s lockdep context, exercising the LD_WAIT_SPIN wait type from the previous patch; a spurious lockdep splat there would show up in the test output. The dispatch tests rely on reacting_on being enabled, since rv_react() returns early when it is off. Reviewed-by: Gabriele Monaco Signed-off-by: Wen Yang --- kernel/trace/rv/Kconfig | 12 +++ kernel/trace/rv/Makefile | 1 + kernel/trace/rv/rv_reactors_kunit.c | 111 ++++++++++++++++++++++++++++ 3 files changed, 124 insertions(+) create mode 100644 kernel/trace/rv/rv_reactors_kunit.c diff --git a/kernel/trace/rv/Kconfig b/kernel/trace/rv/Kconfig index efa930f94ea4..9bfd429ffdea 100644 --- a/kernel/trace/rv/Kconfig +++ b/kernel/trace/rv/Kconfig @@ -113,6 +113,18 @@ config RV_REACT_PANIC Enables the panic reactor. The panic reactor emits a printk() message if an exception is found and panic()s the system. =20 +config RV_REACTORS_KUNIT + tristate "KUnit tests for RV reactors" if !KUNIT_ALL_TESTS + depends on KUNIT + depends on RV_REACTORS + default KUNIT_ALL_TESTS + help + Enable KUnit tests for RV reactor registration and dispatch. + These tests verify the register/unregister lifecycle, duplicate + rejection, and that rv_react() correctly invokes callbacks. + + If unsure, say N. + config RV_MONITORS_KUNIT_TEST tristate "KUnit tests for RV monitors" if !KUNIT_ALL_TESTS depends on KUNIT && RV && RV_REACTORS diff --git a/kernel/trace/rv/Makefile b/kernel/trace/rv/Makefile index cdbf68c84f5a..c895d81dfdad 100644 --- a/kernel/trace/rv/Makefile +++ b/kernel/trace/rv/Makefile @@ -25,4 +25,5 @@ obj-$(CONFIG_RV_MON_WAKEUP) +=3D monitors/wakeup/wakeup.o obj-$(CONFIG_RV_REACTORS) +=3D rv_reactors.o obj-$(CONFIG_RV_REACT_PRINTK) +=3D reactor_printk.o obj-$(CONFIG_RV_REACT_PANIC) +=3D reactor_panic.o +obj-$(CONFIG_RV_REACTORS_KUNIT) +=3D rv_reactors_kunit.o obj-$(CONFIG_RV_MONITORS_KUNIT_TEST) +=3D rv_monitors_test.o diff --git a/kernel/trace/rv/rv_reactors_kunit.c b/kernel/trace/rv/rv_react= ors_kunit.c new file mode 100644 index 000000000000..3850c6dda288 --- /dev/null +++ b/kernel/trace/rv/rv_reactors_kunit.c @@ -0,0 +1,111 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * KUnit tests for RV reactor registration and dispatch. + * + * The dispatch tests rely on reacting_on being enabled, since rv_react() + * returns early when it is off. It is on by default when the suites run + * built-in; as a module, re-enable it if disabled via + * /sys/kernel/tracing/rv/reacting_on. + */ + +#include +#include +#include +#include +#include "rv.h" + +static struct rv_reactor test_reactor =3D { + .name =3D "kunit_test_reactor", + .description =3D "KUnit test reactor", +}; + +static void reactor_teardown(void *arg) +{ + rv_unregister_reactor(&test_reactor); +} + +static void register_test_reactor(struct kunit *test) +{ + KUNIT_ASSERT_EQ(test, rv_register_reactor(&test_reactor), 0); + KUNIT_ASSERT_EQ(test, + kunit_add_action_or_reset(test, reactor_teardown, NULL), 0); +} + +static void test_double_register(struct kunit *test) +{ + register_test_reactor(test); + KUNIT_EXPECT_EQ(test, rv_register_reactor(&test_reactor), -EINVAL); +} + +static const char long_reactor_name[] =3D "kunit_reactor_name_too_long_xxx= _"; +static_assert(sizeof(long_reactor_name) - 1 >=3D MAX_RV_REACTOR_NAME_SIZE, + "long_reactor_name must be at least MAX_RV_REACTOR_NAME_SIZE chars= "); + +static void test_name_too_long(struct kunit *test) +{ + static struct rv_reactor long_reactor =3D { + .name =3D long_reactor_name, + }; + + KUNIT_EXPECT_EQ(test, rv_register_reactor(&long_reactor), -EINVAL); +} + +static struct kunit_case rv_reactor_registration_cases[] =3D { + KUNIT_CASE(test_double_register), + KUNIT_CASE(test_name_too_long), + {} +}; + +static struct kunit_suite rv_reactor_registration_suite =3D { + .name =3D "rv_reactor_registration", + .test_cases =3D rv_reactor_registration_cases, +}; + +static int react_call_count; + +__printf(1, 0) static void mock_react(const char *msg, va_list args) +{ + react_call_count++; + /* Busy-wait so a timer interrupt fires inside rv_react(). */ + mdelay(20); +} + +static void test_react_no_callback(struct kunit *test) +{ + struct rv_monitor monitor =3D { + .name =3D "kunit_null_react", + }; + + react_call_count =3D 0; + rv_react(&monitor, "no callback"); + + KUNIT_EXPECT_EQ(test, react_call_count, 0); +} + +static void test_react_callback_invoked(struct kunit *test) +{ + struct rv_monitor monitor =3D { + .name =3D "kunit_dispatch_monitor", + .react =3D mock_react, + }; + + react_call_count =3D 0; + rv_react(&monitor, "callback invocation test"); + KUNIT_EXPECT_EQ(test, react_call_count, 1); +} + +static struct kunit_case rv_react_dispatch_cases[] =3D { + KUNIT_CASE(test_react_no_callback), + KUNIT_CASE(test_react_callback_invoked), + {} +}; + +static struct kunit_suite rv_react_dispatch_suite =3D { + .name =3D "rv_react_dispatch", + .test_cases =3D rv_react_dispatch_cases, +}; + +kunit_test_suites(&rv_reactor_registration_suite, &rv_react_dispatch_suite= ); + +MODULE_LICENSE("GPL"); +MODULE_DESCRIPTION("KUnit tests for RV reactor registration and dispatch"); --=20 2.25.1