From nobody Sat Sep 26 11:00:58 2026 Received: from mta1.migadu.com (out-103.mta1.migadu.com [95.215.58.103]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D32053EC686 for ; Wed, 2 Sep 2026 08:48:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.103 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788338939; cv=none; b=rdXRTgXUpiO4dNgcEUentRc1ckAK2QBMETXyiH6+BUwVTUTOh5YRVmx3usfiN9ANW7VZ/GRAMptmbeC6R0ReBABZRBil62F4dYwSyPPRgxb7T5KQaWQjEZwfOwYj60gzASZ4IUBiAoWCrV27t9mHZkyMo4/JZ15nezxpo+Boq7Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788338939; c=relaxed/simple; bh=QXx9mFoUJC8ulhUiCe0BLwO8FCobVwePgiwThut3sT0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=G836l2YXlYumTY81tfMYNpU9nay2yXV3/mSQ18ml9hfGgoOJvjJo4h09dlt3VegOxUUgDd67qVaG4srjwyPYS3T3QpOgMv/Ht5Th31tNo1VLolhf/xwrhAILIsBgcmWmSj9Fv/7oILMjCbD+X3/d2PTtB0QAUu0Gx/LkSXFBOrE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=ENPvW02t; arc=none smtp.client-ip=95.215.58.103 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="ENPvW02t" X-Envelope-To: linux-kernel@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=QXx9mFoUJC8ulhUiCe0BLwO8FCobVwePgiwThut3sT0=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1788338934; v=1; x=1788943734; b=ENPvW02tKLM4gGwS9TAuxocHzREJNJSI7pFTATOTWW7LSpmqRBWZrx//PdwqrMFSRcF4rk62 UH/xG9Aslm26WV4KiieicPdsSe9sV3hTe0mN1EC76UUrsncqTuqYAnaISvyla3/5k7SkkOA2QDS GygpCKNZ/VHJik4OAQNMG8eM= X-Envelope-To: linux-kernel@vger.kernel.org Received: by mta10.migadu.com with ESMTPS id f91dbd0a606b14d3; Wed, 02 Sep 2026 08:48:54 +0000 X-Mizu-Trace-ID: f91dbd0a606b14d3 X-Migadu-Flow: FLOW_OUT Date: Wed, 2 Sep 2026 11:48:46 +0300 From: Matti Vaittinen To: Matti Vaittinen , Matti Vaittinen , Matti Vaittinen Cc: Matti Vaittinen , Jonathan Cameron , David Lechner , Nuno =?iso-8859-1?Q?S=E1?= , Andy Shevchenko , Mehdi Djait , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 1/3] iio: light: rohm-bu27034: Fix infinite delay on error Message-ID: Reply-To: Matti Vaittinen References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="n2rkCrTUGVjlzaNU" Content-Disposition: inline In-Reply-To: --n2rkCrTUGVjlzaNU Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Matti Vaittinen When reading an integration-time fails, the code will use error code to compute the sleep time. Fix this by using the smallest integration time as a default if reading fails. Fixes: e52afbd61039 ("iio: light: ROHM BU27034 Ambient Light Sensor") Suggested-by: Jonathan Cameron Signed-off-by: Matti Vaittinen --- I am not happy how intrusive this patch is for a fix. I really believe what I suggested in discussion: wait_ms =3D bu27034_get_int_time(data) / USEC_PER_MSEC; if (wait_ms < BU27034_INT_TIME_MIN_MS) wait_ms =3D BU27034_INT_TIME_MIN_MS; https://lore.kernel.org/all/5d274bfb-2570-4336-af16-60640550e6c9@gmail.com/ would be better as a fix. Well, if this is what reviewers prefer, then I can live with it. Revision history: v2 =3D> v3: - Changed the signature of the measurement time getter as suggested by Jonathan. v1 =3D> v2: - Moved Fixes before SOB - Clarified units for the smallest integration time as suggested by Andy --- drivers/iio/light/rohm-bu27034.c | 60 +++++++++++++++++++------------- 1 file changed, 36 insertions(+), 24 deletions(-) diff --git a/drivers/iio/light/rohm-bu27034.c b/drivers/iio/light/rohm-bu27= 034.c index 28d111ac8c0a..9c7c7e118cbb 100644 --- a/drivers/iio/light/rohm-bu27034.c +++ b/drivers/iio/light/rohm-bu27034.c @@ -137,6 +137,7 @@ static const struct iio_gain_sel_pair bu27034_gains[] = =3D { #define BU27034_MEAS_MODE_200MS 2 #define BU27034_MEAS_MODE_400MS 4 =20 +#define BU27034_INT_TIME_US_MIN (55 * USEC_PER_MSEC) static const struct iio_itime_sel_mul bu27034_itimes[] =3D { GAIN_SCALE_ITIME_US(400000, BU27034_MEAS_MODE_400MS, 8), GAIN_SCALE_ITIME_US(200000, BU27034_MEAS_MODE_200MS, 4), @@ -296,7 +297,7 @@ static int bu27034_get_gain(struct bu27034_data *data, = int chan, int *gain) return 0; } =20 -static int bu27034_get_int_time(struct bu27034_data *data) +static int bu27034_get_int_time(struct bu27034_data *data, int *itime) { int ret, sel; =20 @@ -304,24 +305,30 @@ static int bu27034_get_int_time(struct bu27034_data *= data) if (ret) return ret; =20 - return iio_gts_find_int_time_by_sel(&data->gts, - sel & BU27034_MASK_MEAS_MODE); + ret =3D iio_gts_find_int_time_by_sel(&data->gts, + sel & BU27034_MASK_MEAS_MODE); + if (ret < 0) + return ret; + + *itime =3D ret; + + return 0; } =20 static int _bu27034_get_scale(struct bu27034_data *data, int channel, int = *val, int *val2) { - int gain, ret; + int gain, itime, ret; =20 ret =3D bu27034_get_gain(data, channel, &gain); if (ret) return ret; =20 - ret =3D bu27034_get_int_time(data); - if (ret < 0) + ret =3D bu27034_get_int_time(data, &itime); + if (ret) return ret; =20 - return iio_gts_get_scale(&data->gts, gain, ret, val, val2); + return iio_gts_get_scale(&data->gts, gain, itime, val, val2); } =20 static int bu27034_get_scale(struct bu27034_data *data, int channel, int *= val, @@ -397,12 +404,10 @@ static int bu27034_try_set_int_time(struct bu27034_da= ta *data, int time_us) int ret, int_time_old, i; =20 guard(mutex)(&data->mutex); - ret =3D bu27034_get_int_time(data); - if (ret < 0) + ret =3D bu27034_get_int_time(data, &int_time_old); + if (ret) return ret; =20 - int_time_old =3D ret; - if (!iio_gts_valid_time(&data->gts, time_us)) { dev_err(data->dev, "Unsupported integration time %u\n", time_us); @@ -841,7 +846,7 @@ static int bu27034_meas_set(struct bu27034_data *data, = bool en) static int bu27034_get_single_result(struct bu27034_data *data, int chan, int *val) { - int ret; + int ret, itime; =20 if (chan < BU27034_CHAN_DATA0 || chan > BU27034_CHAN_DATA1) return -EINVAL; @@ -850,11 +855,11 @@ static int bu27034_get_single_result(struct bu27034_d= ata *data, int chan, if (ret) return ret; =20 - ret =3D bu27034_get_int_time(data); - if (ret < 0) + ret =3D bu27034_get_int_time(data, &itime); + if (ret) return ret; =20 - msleep(ret / 1000); + msleep(itime / 1000); =20 return bu27034_read_result(data, chan, val); } @@ -904,12 +909,10 @@ static int bu27034_calc_mlux(struct bu27034_data *dat= a, __le16 *res, int *val) if (ret) return ret; =20 - ret =3D bu27034_get_int_time(data); - if (ret < 0) + ret =3D bu27034_get_int_time(data, &meastime); + if (ret) return ret; =20 - meastime =3D ret; - d1_d0_ratio_scaled =3D (unsigned int)ch1 * (unsigned int)gain0 * 100; helper64 =3D (u64)ch1 * (u64)gain0 * 100LLU; =20 @@ -970,9 +973,9 @@ static int bu27034_read_raw(struct iio_dev *idev, switch (mask) { case IIO_CHAN_INFO_INT_TIME: *val =3D 0; - *val2 =3D bu27034_get_int_time(data); - if (*val2 < 0) - return *val2; + ret =3D bu27034_get_int_time(data, val2); + if (ret) + return ret; =20 return IIO_VAL_INT_PLUS_MICRO; =20 @@ -1157,11 +1160,20 @@ static int bu27034_buffer_thread(void *arg) { struct iio_dev *idev =3D arg; struct bu27034_data *data; - int wait_ms; + int wait_ms, ret; =20 data =3D iio_priv(idev); =20 - wait_ms =3D bu27034_get_int_time(data); + /* + * If reading the integration time fails, default to the minimum so we + * don't lose samples. This may waste CPU cycles, but as a hardening + * against theoretical, once-in-a-blue-moon error, this should be Ok. + */ + wait_ms =3D BU27034_INT_TIME_US_MIN; + ret =3D bu27034_get_int_time(data, &wait_ms); + if (ret) + dev_warn(data->dev, "Failed to get integration time\n"); + wait_ms /=3D 1000; =20 wait_ms -=3D BU27034_MEAS_WAIT_PREMATURE_MS; --=20 2.55.0 --n2rkCrTUGVjlzaNU Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEIx+f8wZb28fLKEhTeFA3/03aocUFAmqX4u4ACgkQeFA3/03a ocXsjgf+NZlr0Jj9ZksqzZVh+Y7R9Z7S9rVpb51l3d2Eap7SEQ8EsUmw85hQBgXa n+RnmPdzzS+z9XNofh1YcZ7H+yTnZipgLt80OlLj108YGhFFh1dGT7DaYAENvaLy q62ckLmULqbtCAVk5/oX1PckanhOz0eafYNMaio0fHjSQL7CLN15kVhgICAAXKBZ FwNNnIScYPzYcDo8Z4g7gUgtF/Wc4gv0bDo3hT6lNPaFhT6YjHt9f/SyZN0g5l2R ZOMMFKAy3+PB8pE3Fs9owxZLyKSd/mAJsbUisvmYBongKhZX+Yq8lEqhq63rRJAd 2qRPHqkIuOFZII0aGrOyqlsMEPTnVg== =Uprp -----END PGP SIGNATURE----- --n2rkCrTUGVjlzaNU-- From nobody Sat Sep 26 11:00:58 2026 Received: from mta0.migadu.com (out-123.mta0.migadu.com [91.218.175.123]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C7403F326B for ; Wed, 2 Sep 2026 08:49:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.123 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788338953; cv=none; b=BibMAVn71jxJZm50o58VLo9ZkaW9V3RpDUV0LUfUrUPA5Lv4KfM3ZBfiAoDuRyG3e2ps2224wWSjCJD4RAvlfR/s1575/MD3lU57+5o2Cgl1qR8SBtFmxjFFQ5vRBxYn8zpFtlvkt+hpx19diSTfX5+0sBFeKEB4lMHf8CCe2oU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788338953; c=relaxed/simple; bh=f2w/exKd+WcPfD8TsUEpGLX2tdskAkF4cBe0xDl9JDY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Mkjqj3w/1VQcMWHzLkx3r9I22Tr7uMI57FoMAlTa+5Vqnbv1EbzqsboX3OF+t9nmm2w/kpU+5pIYAhUutnKloZzxzZn4fBuNdf6+VrERSKqAERlVEhvILfsbiYdG9N4UEnTMemGHgVrM/K1lmVhcr9JLoVAFv48tP4tSsMfLWd8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=nnBeO/5m; arc=none smtp.client-ip=91.218.175.123 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="nnBeO/5m" X-Envelope-To: linux-kernel@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=f2w/exKd+WcPfD8TsUEpGLX2tdskAkF4cBe0xDl9JDY=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1788338949; v=1; x=1788943749; b=nnBeO/5mdINlx2GixxU24jzRMqCen5qLp3avBs0maQCKuEUX6/lA94uN8u2nxhFYm5KJQnpA 0iNNSDbo35rTXymrdMuVV7dxfKWF8fUUn/p8SPk+1ycSJxDqYJIABtxO0Hf8mKF/8evHszTWntL Wncozj3rtbNzkSTaogyvzYhw= X-Envelope-To: linux-kernel@vger.kernel.org Received: by mta12.migadu.com with ESMTPS id 9143ef27d57fefb4; Wed, 02 Sep 2026 08:49:09 +0000 X-Mizu-Trace-ID: 9143ef27d57fefb4 X-Migadu-Flow: FLOW_OUT Date: Wed, 2 Sep 2026 11:49:05 +0300 From: Matti Vaittinen To: Matti Vaittinen , Matti Vaittinen , Matti Vaittinen Cc: Matti Vaittinen , Jonathan Cameron , David Lechner , Nuno =?iso-8859-1?Q?S=E1?= , Andy Shevchenko , Mehdi Djait , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 2/3] iio: accel: kionix-kx022a: Prevent memory leak and fix state Message-ID: Reply-To: Matti Vaittinen References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="8p/Ptea5Jbk6Fz4j" Content-Disposition: inline In-Reply-To: --8p/Ptea5Jbk6Fz4j Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Matti Vaittinen The driver allocates memory for samples at buffer enable path. If regmap operation fails in the kx022a_fifo_enable() at the buffer enable path, the allocated memory is never freed. Furthermore, the state information and previous hardware configuration(s) aren't undone, potentially leaving WMI interrupts and buffers enabled, or driver state flags wrong. Free the memory and revert the hardware configuration and state flags on error path. Fixes: e7123a4dfcd7 ("iio: accel: kionix-kx022a: Refactor driver and add ch= ip_info structure") Signed-off-by: Matti Vaittinen Reviewed-by: Mehdi Djait --- Revision history: v2 =3D> v3: - Make all of the fifo_enable unwinding goto labels describe what clean-up action is to be taken. v1 =3D> v2: - Fix unwinding the fifo enabling - Move Fixes before the SOB. --- drivers/iio/accel/kionix-kx022a.c | 28 +++++++++++++++++++++++----- 1 file changed, 23 insertions(+), 5 deletions(-) diff --git a/drivers/iio/accel/kionix-kx022a.c b/drivers/iio/accel/kionix-k= x022a.c index 8f2810c8ffeb..00482cb4451f 100644 --- a/drivers/iio/accel/kionix-kx022a.c +++ b/drivers/iio/accel/kionix-kx022a.c @@ -981,26 +981,44 @@ static int kx022a_fifo_enable(struct kx022a_data *dat= a) guard(mutex)(&data->mutex); ret =3D __kx022a_turn_on_off(data, false); if (ret) - return ret; + goto err_free_out; =20 /* Update watermark to HW */ ret =3D kx022a_fifo_set_wmi(data); if (ret) - return ret; + goto err_turn_on_out; =20 /* Enable buffer */ ret =3D regmap_set_bits(data->regmap, data->chip_info->buf_cntl2, KX022A_MASK_BUF_EN); if (ret) - return ret; + goto err_turn_on_out; =20 data->state |=3D KX022A_STATE_FIFO; ret =3D regmap_set_bits(data->regmap, data->ien_reg, KX022A_MASK_WMI); if (ret) - return ret; + goto err_buf_disable_out; =20 - return __kx022a_turn_on_off(data, true); + ret =3D __kx022a_turn_on_off(data, true); + if (ret) + goto err_wmi_clear_out; + + return ret; + +err_wmi_clear_out: + regmap_clear_bits(data->regmap, data->ien_reg, + KX022A_MASK_WMI); +err_buf_disable_out: + regmap_clear_bits(data->regmap, data->chip_info->buf_cntl2, + KX022A_MASK_BUF_EN); + data->state &=3D ~KX022A_STATE_FIFO; +err_turn_on_out: + __kx022a_turn_on_off(data, true); +err_free_out: + kfree(data->fifo_buffer); + + return ret; } =20 static int kx022a_buffer_postenable(struct iio_dev *idev) --=20 2.55.0 --8p/Ptea5Jbk6Fz4j Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEIx+f8wZb28fLKEhTeFA3/03aocUFAmqX4wEACgkQeFA3/03a ocUpjQgAt8OXBc1s/x1b58941krvZvMgyRfQx08SAVekxM0zLYbZ60mPsELjSzgq AqFn85bCMMDdJBFW/QHOCbzbayn52r/nq7J0mLsLnv6JG1HwxudL92yxwzNuJJgh bjFAfxfRR+lO4ldpEu3fZqQcon6PDdZA7ZI+acsDrorvwAFCbWDnIfz/poF0vsfT uC/ib89IP8/RQOGy3y/WhfGnbqPEoogsyrHdMCtxI+3T6btuAcUZIQaSfoOYIsz7 kbx4YVXTMmLrwIt5ct5OrO4gpgxLi8cOGNJ0rQxUAqts8pFTUhetPVTCR5TTjduZ emD0Y+3yVnFGoL5TWkrOYLz4vRzYuw== =IjZp -----END PGP SIGNATURE----- --8p/Ptea5Jbk6Fz4j-- From nobody Sat Sep 26 11:00:58 2026 Received: from mta1.migadu.com (out-124.mta1.migadu.com [95.215.58.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 293F93EC816 for ; Wed, 2 Sep 2026 08:49:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788338969; cv=none; b=AYUI6i2raFgvj80pAzwv9NaBxuDp/hso70xqe0vxJl7kGBCnxerIJ202+BHKK4nWQ1/8nwRixbcPkrzbL5hNYLgRbD4nkJxi6A3GVfLyIKZwCX2vls2InvPex1Kcfy5TTHbimKcCIEj3vWsQ6aAfZ2J8JYXr69OPEsshLE5Ny8U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788338969; c=relaxed/simple; bh=5LER9EYvbKs9Qka4Wbjxj3pXZ4EQVA5Hj6MTLn2ZuJc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=iH4VHDY5v0z1qvKPqI1WEuXe/33LFyxo3SjkipgFHkN2Xl4I+avSp8DWe/hsiNA8zq9RO7xFSCoMTr74XY4SW5v/ZviZC5qLdaLmOUBKXdeNlLq17zH/YUSO2jbn2s/Dfl8+4Quwo3E++lbxpWRYmghMuyrr36YCuG5aoLAkRQI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=HApcDrlR; arc=none smtp.client-ip=95.215.58.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="HApcDrlR" X-Envelope-To: linux-kernel@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=5LER9EYvbKs9Qka4Wbjxj3pXZ4EQVA5Hj6MTLn2ZuJc=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1788338966; v=1; x=1788943766; b=HApcDrlRhVWTQw7bl4NI3Wq13MBFOT4DtWXDx3sC4gNwyyo1XQ0JsJ4zqtboJxGTT8TiNClk qV2q0ddEnU3wlATcS9cvBAurCkrR/XIC3wXDJ0B2US+hmPzS/nM6pTJCwumto93sPf1/2fUeb5t wl5LMbOJ61TOtN4wzlOeLjVE= X-Envelope-To: linux-kernel@vger.kernel.org Received: by mta11.migadu.com with ESMTPS id 488d2f085647059f; Wed, 02 Sep 2026 08:49:25 +0000 X-Mizu-Trace-ID: 488d2f085647059f X-Migadu-Flow: FLOW_OUT Date: Wed, 2 Sep 2026 11:49:18 +0300 From: Matti Vaittinen To: Matti Vaittinen , Matti Vaittinen , Matti Vaittinen Cc: Matti Vaittinen , Jonathan Cameron , David Lechner , Nuno =?iso-8859-1?Q?S=E1?= , Andy Shevchenko , Mehdi Djait , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 3/3] iio: accel: kionix-kx022a: Fix IPOL macro name Message-ID: <542c61177f34fe6f6c0f937021f6b3b7ca51a024.1788336588.git.mazziesaccount@gmail.com> Reply-To: Matti Vaittinen References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="AiCy6vkZhqDS8qHz" Content-Disposition: inline In-Reply-To: --AiCy6vkZhqDS8qHz Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Matti Vaittinen The "interrupt polarity high"-macro for KX022A variant is defined as: "#define KX022A_MASK_IPOL KX022A_MASK_IPOL1" However, the KX022A_MASK_IPOL1 is not defined anywhere, so actually using the KX022A_IPOL_HIGH would produce a compile error. Fix the define by using correct mask. Fixes: 7c1d1677b322 ("iio: accel: Support Kionix/ROHM KX022A accelerometer") Signed-off-by: Matti Vaittinen Reviewed-by: Mehdi Djait --- Revision history: v2 =3D>: - No changes v1 =3D> v2: - Fixed the commit message where line: "#define KX022A_MASK_IPOL KX022A_MASK_IPOL1" was lost, as git treated it as a comment :) - Moved Fixes before SOB --- drivers/iio/accel/kionix-kx022a.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/accel/kionix-kx022a.h b/drivers/iio/accel/kionix-k= x022a.h index 0ed54f584223..a2d122c1e234 100644 --- a/drivers/iio/accel/kionix-kx022a.h +++ b/drivers/iio/accel/kionix-kx022a.h @@ -65,7 +65,7 @@ #define KX022A_MASK_IEN BIT(5) #define KX022A_MASK_IPOL BIT(4) #define KX022A_IPOL_LOW 0 -#define KX022A_IPOL_HIGH KX022A_MASK_IPOL1 +#define KX022A_IPOL_HIGH KX022A_MASK_IPOL #define KX022A_MASK_ITYP BIT(3) #define KX022A_ITYP_PULSE KX022A_MASK_ITYP #define KX022A_ITYP_LEVEL 0 --=20 2.55.0 --AiCy6vkZhqDS8qHz Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEIx+f8wZb28fLKEhTeFA3/03aocUFAmqX4w4ACgkQeFA3/03a ocX/8wf/TZ5VbC5SsQV+t50SQGok6kUP5YW0B5HwYVmlPMGQG6zg5JI6eBPdnKpU a4hq0i+SgfZQNdAFRN8qc+1Kr2cXIbkRF0G8S2HTaGr/F0jmcGS+Yfut3Lv5b5yc AGVpsjD1WCJmlUVAmuurHyOc8Jgik0Z5KldA97PqneabfhBbrdRYptxQ0WufH2BT y4f2gXpxyd41rBwPEc2Qrwn3NDLEDe6dxIsO/qE4mu2EjKVkbCLA3a9I9YdJbjKg YlGP6T9G4k9e8Ktkl0gzHSZSGgJJLV018ysV2/1FqA9cGGP3S5Ia7UnOc7UBqR7b Byb9mAdPkX1zSjBpSjnbqBxuQW99yg== =K/lY -----END PGP SIGNATURE----- --AiCy6vkZhqDS8qHz--