From nobody Sat Sep 19 05:58:33 2026 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5ECFD3793AC for ; Tue, 1 Sep 2026 17:48:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788284895; cv=none; b=GPiXw3tIridwH6XnAAg47DE6a0LlNXOy8RU+IT86hJWrDVojfSqyW2ZI2b8Ps87EB3j/ia9+7HuhSBiFMBCe3AC46/aR7It+u1qhasXNsJ5GUYmBkvffsaVXxlW8Z6VOkOsyx0iHr9UfpcJ3qDqPOTyOcvDCA2bi5ELMR+/Ap0E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788284895; c=relaxed/simple; bh=vlg77wolsoVFMBQPq6m20qH3uHGfUAOllu68Fyi4ZQU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=pT8mpCm6gRlN2gcWY9lzayte6PbewngWJF3RIfVSUFzNBHqkC/Tk3ztoOCdcYQRB6oKoxs2GIvn/6gBpCeIjS47ef95MlZXJvSK4jgPZV9PRLkc0Vv6twwUHN/PYx2QgEaUOTU1pijyKzTPccXsVuc5tk3shmwNbkA1C8QXSxAo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=starlabs.systems; spf=pass smtp.mailfrom=starlabs.systems; dkim=pass (2048-bit key) header.d=starlabs-systems.20251104.gappssmtp.com header.i=@starlabs-systems.20251104.gappssmtp.com header.b=KtZlXdjL; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=starlabs.systems Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=starlabs.systems Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=starlabs-systems.20251104.gappssmtp.com header.i=@starlabs-systems.20251104.gappssmtp.com header.b="KtZlXdjL" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-49b0dbfbf7bso366565e9.2 for ; Tue, 01 Sep 2026 10:48:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=starlabs-systems.20251104.gappssmtp.com; s=20251104; t=1788284890; x=1788889690; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=tXCHJIwjGHRpvPAJmWpnTHd3j6ug3youjBf+VTwSpcg=; b=KtZlXdjLovzHLVDpdrs5gHUoROvQH337qIyXHQC4ZbakMWW3qEitWw5xvLorU0j2hG DoQ1Vv3AdxB2CVTbw2khCIO0k/k1EgdNeaCBeR+KHeV9QrEklupHjeSQxh6VYKSG54OB 3ChIqQ+Ybnw2ceyOKqekrqt9iez596uNjjommNycKQisyfdVbnXt5kJdZqsEdZYNwdX0 wNM4LLd6PHoArGWk2O9XHIfmXnRPu8wFJ4gw6OCwuP26R1zCJt1sDvK0Lk3vrIbR8yJK GP4vQoxkzR9r5qVByryh5yEbLmkMdOMR8n3HhJZwk9iqMexzsjgmqimAC5FI2tPjq4Oo qSiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788284890; x=1788889690; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=tXCHJIwjGHRpvPAJmWpnTHd3j6ug3youjBf+VTwSpcg=; b=IfhEqJ5aOCnuwocQeJXTVJL/TTy85Hci3Mz6TcAauTA48Bwjl4+Y5rNfzglpicoPA6 JbB+xZKMGdBikEkjXkIr3ILXKgqeo20rIJ7PN9BzKpbNvWagAsTOj6yl12jwtPnq2ZrL +UOlrkbyf7o1moXQEFn311tvmKCPcSXN729mYCCebRq1QbEn//s/PUsCwbV7YEN0A6y6 TtHA/4Jad86Tcx6XDerK+EcCHHBfOmcC7VWKfxLXunTobxjEiz/mIyLdGVXNJnQor+H0 38eSJpPVFmyHCDY/ffLsDGAejxpTic2rUY5rcvJO3XON1niXrFpe7JvV/F5/jiE5m1Wv J0nA== X-Gm-Message-State: AFuF++miHXAdzGpZelS9FNQS+2m5PGYdweJ/F92YYVRSqPp7DzrD5bTP pFxb13jatevoHJxjS25u4V9wfpvQAOjSdPIcQFDJgTDIVji7aRDWndBOzHX/Bt1pZ3Nf+C3PUq3 bJlW2bk6o X-Gm-Gg: AR+sD11yund4dllxpm1ovte3yxdIoICvBOnSfyNeamEn9w5Ru54PTknWV1YZ4NMmfb7 IAvAWdGAksjzJYoZY6Rfa/vXZO4fKfs+1P25zSsUpvEU9dtfnRYE7bkkejBsb/OvvA80GEJ7svp 5RU4FUtYTfVOu6pCNpuzoGEXGHvechrcIn9rOl67GOE5QuCp0/UMaAsv+78HeGr+iJ1AR9IBxST 7kmAdsU9HiJrDhmgi5x+CkTlbuWGUN4G1OZfkMVeaxsEmyHuy8ttTD6pt4IReosrHonwcfuGM0H /VpkeR4OXnvqojPopYPsQX45nGwK3uFX6qmYEZVhK6c2giNnUHxh5YZZg7QDTsHn8EkM09QH1xM F9d27k2J1+xmfqxoXcqwC2woP4Mfv7i1aFk9oHXsibQ2DmaN8il86Q5mmMPVWp6Bt+wDw+TQGch 7iZRWLPuctmzZRO+DpSkdeW4iHNQzc49f4EQ/6BxHya2JSPE7Uk2kr/rw0AoUOsnBw3nOxAOWHc CPoULLwnAGlehk8 X-Received: by 2002:a05:600c:83c7:b0:499:8174:9f39 with SMTP id 5b1f17b1804b1-49cdc3cf96amr196466835e9.0.1788284890166; Tue, 01 Sep 2026 10:48:10 -0700 (PDT) Received: from horizon ([217.155.46.38]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49ce47885b1sm2369225e9.14.2026.09.01.10.48.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Sep 2026 10:48:09 -0700 (PDT) From: Sean Rhodes To: linux-kernel@vger.kernel.org Cc: Hans de Goede , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , Corentin Chary , "Luke D. Jones" , Denis Benato , Prasanth Ksr , Jorge Lopez , Mark Pearson , "Derek J. Clark" , Joshua Grisham , Will Deacon , Douglas Anderson , "Kiryl Shutsemau (Meta)" , Sean Rhodes , Huacai Chen , Chen-Yu Tsai , Thomas Zimmermann , platform-driver-x86@vger.kernel.org, Dell.Client.Kernel@dell.com, Tzung-Bi Shih , Brian Norris , Julius Werner , Javier Martinez Canillas , Bjorn Helgaas , Danilo Krummrich , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig=20=28The=20Capable=20Hub=29?= , Titouan Ameline de Cadeville , Laxman Acharya Padhya , Yidi Lin , Kees Cook , Takashi Sakamoto , chrome-platform@lists.linux.dev, Maarten Lankhorst , Maxime Ripard , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, Krzysztof Kozlowski , Bjorn Andersson , Dmitry Baryshkov , Geert Uytterhoeven , Arnd Bergmann , Eric Biggers , Luca Weiss , Michal Simek , Sven Peter , Alexandre Belloni , Linus Walleij , Drew Fustini , linux-arm-kernel@lists.infradead.org, soc@lists.linux.dev Subject: [PATCH v14 1/5] firmware: Move firmware attributes class helper Date: Tue, 1 Sep 2026 18:48:02 +0100 Message-ID: <5682c2228fa4a784d3953664b56a06e0dd9ccdef.1788284852.git.sean@starlabs.systems> X-Mailer: git-send-email 2.53.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Move the firmware attributes class helper from drivers/platform/x86 to drivers/firmware and expose its class declaration through a public Linux header. The helper is not x86-specific. Keeping it in drivers/firmware lets coreboot firmware drivers use the standard firmware-attributes ABI without living under platform/x86. Replace the affected drivers' relative helper includes directly with the new public header. Suggested-by: Derek J. Clark Reviewed-by: Mark Pearson Reviewed-by: Derek J. Clark Tested-by: Oliver Lin Signed-off-by: Sean Rhodes Reviewed-by: Tzung-Bi Shih --- MAINTAINERS | 8 ++++++++ drivers/firmware/Kconfig | 3 +++ drivers/firmware/Makefile | 1 + .../x86 =3D> firmware}/firmware_attributes_class.c | 2 +- drivers/platform/x86/Kconfig | 3 --- drivers/platform/x86/Makefile | 2 -- drivers/platform/x86/asus-armoury.c | 2 +- drivers/platform/x86/dell/dell-wmi-sysman/sysman.c | 2 +- drivers/platform/x86/hp/hp-bioscfg/bioscfg.c | 2 +- drivers/platform/x86/lenovo/think-lmi.c | 2 +- drivers/platform/x86/lenovo/wmi-other.c | 2 +- drivers/platform/x86/samsung-galaxybook.c | 2 +- .../linux/firmware_attributes.h | 6 +++--- 13 files changed, 22 insertions(+), 15 deletions(-) rename drivers/{platform/x86 =3D> firmware}/firmware_attributes_class.c (9= 4%) rename drivers/platform/x86/firmware_attributes_class.h =3D> include/linux= /firmware_attributes.h (60%) diff --git a/MAINTAINERS b/MAINTAINERS index 4dfc1fb14ef7..a8048eaf49e5 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -10181,6 +10181,14 @@ F: include/linux/firewire.h F: include/uapi/linux/firewire*.h F: tools/firewire/ =20 +FIRMWARE ATTRIBUTES CLASS +M: Hans de Goede +M: Ilpo J=C3=A4rvinen +L: platform-driver-x86@vger.kernel.org +S: Maintained +F: drivers/firmware/firmware_attributes_class.c +F: include/linux/firmware_attributes.h + FIRMWARE FRAMEWORK FOR ARMV8-A M: Sudeep Holla L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers) diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig index b7cc11e4fbfa..35dd6d422caf 100644 --- a/drivers/firmware/Kconfig +++ b/drivers/firmware/Kconfig @@ -8,6 +8,9 @@ menu "Firmware Drivers" =20 source "drivers/firmware/arm_scmi/Kconfig" =20 +config FW_ATTR_CLASS + tristate + config ARM_SCPI_PROTOCOL tristate "ARM System Control and Power Interface (SCPI) Message Protocol" depends on ARM || ARM64 || COMPILE_TEST diff --git a/drivers/firmware/Makefile b/drivers/firmware/Makefile index be46f1e1dc77..0e1e1b92a486 100644 --- a/drivers/firmware/Makefile +++ b/drivers/firmware/Makefile @@ -17,6 +17,7 @@ obj-$(CONFIG_FIRMWARE_MEMMAP) +=3D memmap.o obj-$(CONFIG_MTK_ADSP_IPC) +=3D mtk-adsp-ipc.o obj-$(CONFIG_RASPBERRYPI_FIRMWARE) +=3D raspberrypi.o obj-$(CONFIG_FW_CFG_SYSFS) +=3D qemu_fw_cfg.o +obj-$(CONFIG_FW_ATTR_CLASS) +=3D firmware_attributes_class.o obj-$(CONFIG_SYSFB) +=3D sysfb.o obj-$(CONFIG_SYSFB_SIMPLEFB) +=3D sysfb_simplefb.o obj-$(CONFIG_TH1520_AON_PROTOCOL) +=3D thead,th1520-aon.o diff --git a/drivers/platform/x86/firmware_attributes_class.c b/drivers/fir= mware/firmware_attributes_class.c similarity index 94% rename from drivers/platform/x86/firmware_attributes_class.c rename to drivers/firmware/firmware_attributes_class.c index 736e96c186d9..503ecc288086 100644 --- a/drivers/platform/x86/firmware_attributes_class.c +++ b/drivers/firmware/firmware_attributes_class.c @@ -3,7 +3,7 @@ /* Firmware attributes class helper module */ =20 #include -#include "firmware_attributes_class.h" +#include =20 const struct class firmware_attributes_class =3D { .name =3D "firmware-attributes", diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig index 957034f39e4e..4851bf45157d 100644 --- a/drivers/platform/x86/Kconfig +++ b/drivers/platform/x86/Kconfig @@ -925,9 +925,6 @@ config DASHARO_ACPI =20 source "drivers/platform/x86/x86-android-tablets/Kconfig" =20 -config FW_ATTR_CLASS - tristate - config INTEL_IMR bool "Intel Isolated Memory Region support" depends on X86_INTEL_QUARK && IOSF_MBI diff --git a/drivers/platform/x86/Makefile b/drivers/platform/x86/Makefile index 872ac3842391..cab20a4145e3 100644 --- a/drivers/platform/x86/Makefile +++ b/drivers/platform/x86/Makefile @@ -63,8 +63,6 @@ obj-$(CONFIG_X86_PLATFORM_DRIVERS_HP) +=3D hp/ # Hewlett Packard Enterprise obj-$(CONFIG_UV_SYSFS) +=3D uv_sysfs.o =20 -obj-$(CONFIG_FW_ATTR_CLASS) +=3D firmware_attributes_class.o - # IBM Thinkpad (before 2005) obj-$(CONFIG_IBM_RTL) +=3D ibm_rtl.o obj-$(CONFIG_SENSORS_HDAPS) +=3D hdaps.o diff --git a/drivers/platform/x86/asus-armoury.c b/drivers/platform/x86/asu= s-armoury.c index 93d9665717af..fb382de5b57b 100644 --- a/drivers/platform/x86/asus-armoury.c +++ b/drivers/platform/x86/asus-armoury.c @@ -21,6 +21,7 @@ #include #include #include +#include #include #include #include @@ -35,7 +36,6 @@ #include =20 #include "asus-armoury.h" -#include "firmware_attributes_class.h" =20 #define ASUS_NB_WMI_EVENT_GUID "0B3CBB35-E3C2-45ED-91C2-4C5A6D195D1C" =20 diff --git a/drivers/platform/x86/dell/dell-wmi-sysman/sysman.c b/drivers/p= latform/x86/dell/dell-wmi-sysman/sysman.c index ab46a023cc34..ae89670f73b4 100644 --- a/drivers/platform/x86/dell/dell-wmi-sysman/sysman.c +++ b/drivers/platform/x86/dell/dell-wmi-sysman/sysman.c @@ -10,13 +10,13 @@ #include #include #include +#include #include #include #include #include #include #include "dell-wmi-sysman.h" -#include "../../firmware_attributes_class.h" =20 #define MAX_TYPES 4 #include diff --git a/drivers/platform/x86/hp/hp-bioscfg/bioscfg.c b/drivers/platfor= m/x86/hp/hp-bioscfg/bioscfg.c index 309634c1cc20..d5a2d0963bbf 100644 --- a/drivers/platform/x86/hp/hp-bioscfg/bioscfg.c +++ b/drivers/platform/x86/hp/hp-bioscfg/bioscfg.c @@ -7,6 +7,7 @@ =20 #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt =20 +#include #include #include #include @@ -14,7 +15,6 @@ #include #include #include "bioscfg.h" -#include "../../firmware_attributes_class.h" #include #include =20 diff --git a/drivers/platform/x86/lenovo/think-lmi.c b/drivers/platform/x86= /lenovo/think-lmi.c index a0e3fa766e37..ebfc6182986e 100644 --- a/drivers/platform/x86/lenovo/think-lmi.c +++ b/drivers/platform/x86/lenovo/think-lmi.c @@ -14,13 +14,13 @@ #include #include #include +#include #include #include #include #include #include #include -#include "../firmware_attributes_class.h" #include "think-lmi.h" =20 static bool debug_support; diff --git a/drivers/platform/x86/lenovo/wmi-other.c b/drivers/platform/x86= /lenovo/wmi-other.c index fbb32bf404f2..b175971bb308 100644 --- a/drivers/platform/x86/lenovo/wmi-other.c +++ b/drivers/platform/x86/lenovo/wmi-other.c @@ -33,6 +33,7 @@ #include #include #include +#include #include #include #include @@ -50,7 +51,6 @@ #include "wmi-capdata.h" #include "wmi-events.h" #include "wmi-helpers.h" -#include "../firmware_attributes_class.h" =20 #define LENOVO_OTHER_MODE_GUID "DC2A8805-3A8C-41BA-A6F7-092E0089CD3B" =20 diff --git a/drivers/platform/x86/samsung-galaxybook.c b/drivers/platform/x= 86/samsung-galaxybook.c index 99f72b204a51..88ef11004ad0 100644 --- a/drivers/platform/x86/samsung-galaxybook.c +++ b/drivers/platform/x86/samsung-galaxybook.c @@ -14,6 +14,7 @@ #include #include #include +#include #include #include #include @@ -28,7 +29,6 @@ #include #include #include -#include "firmware_attributes_class.h" =20 #define DRIVER_NAME "samsung-galaxybook" =20 diff --git a/drivers/platform/x86/firmware_attributes_class.h b/include/lin= ux/firmware_attributes.h similarity index 60% rename from drivers/platform/x86/firmware_attributes_class.h rename to include/linux/firmware_attributes.h index d27abe54fcf9..d4026ba1fcc2 100644 --- a/drivers/platform/x86/firmware_attributes_class.h +++ b/include/linux/firmware_attributes.h @@ -2,11 +2,11 @@ =20 /* Firmware attributes class helper module */ =20 -#ifndef FW_ATTR_CLASS_H -#define FW_ATTR_CLASS_H +#ifndef _LINUX_FIRMWARE_ATTRIBUTES_H +#define _LINUX_FIRMWARE_ATTRIBUTES_H =20 #include =20 extern const struct class firmware_attributes_class; =20 -#endif /* FW_ATTR_CLASS_H */ +#endif /* _LINUX_FIRMWARE_ATTRIBUTES_H */ From nobody Sat Sep 19 05:58:33 2026 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B82448D881 for ; Tue, 1 Sep 2026 17:48:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788284896; cv=none; b=NNj9fJfitYyJbuTBA2zAzZ9erR9jhKSOFuUmj2fm5KFyGcOnhgG86dnwZfFk5z1RfNE6h1QBzsyVHnHR7xFEs156nTdxVUBBHANR1WYg7mhhy1OFR3fZEmBXfCbt9kfZyImDSivzHXVCYrrynWqevzhmKewxYerYRSnKIah1RTY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788284896; c=relaxed/simple; bh=JkGm0UaS5Y3Qe3Vn2Bz1+l4/YRY5ooddh+4LtrMHuHU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=iqPsmZh4qXy0gaPWNnfQON8fbgbtR3KJpvl5ER69Jy7EQ7miyj7RFv2dCt7as1ojX5yrqZpvCqYD4bK231MxVWFPY4+oeFalCytW/48IykPbC9D/KcLpafyEkl/+dBXQX/YreGotWuDJtprbiCtFkrjoYQsyoQ4e4wKJfzOioSo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=starlabs.systems; spf=pass smtp.mailfrom=starlabs.systems; dkim=pass (2048-bit key) header.d=starlabs-systems.20251104.gappssmtp.com header.i=@starlabs-systems.20251104.gappssmtp.com header.b=HZl6OgH6; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=starlabs.systems Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=starlabs.systems Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=starlabs-systems.20251104.gappssmtp.com header.i=@starlabs-systems.20251104.gappssmtp.com header.b="HZl6OgH6" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-49b8e527d63so532305e9.2 for ; Tue, 01 Sep 2026 10:48:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=starlabs-systems.20251104.gappssmtp.com; s=20251104; t=1788284892; x=1788889692; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=zj7jRoHjkudAVVu49wNa7RpBG/Rcn+AOqbhR2Afeq2k=; b=HZl6OgH6Ff8AdFhI8U5oQ97xpEawD7D1cZB6XqMvmJIcHe5vaEphf1C7BwzmVOMe4G mZ8WtZPeDPSPcZRv2JCFoUn7QPoGRDiKCHCf1wR7fGR1/K3ie4iQGBF/lYIVKEz1IpU6 UZLUUp6izBwMOUe2CGnwQHqECstTfm5t/Vlq/5cf+QjCSaOGdxa9+1RwbFsgJq3Sc8/S cEtMdlj08uMob/j+w7fw9lry+sHO3DZ1dFgJAkl3ZekD+GPeAEHV1iLSsQ/RDPZIpRgW 5pYdZEqGMGxEMgDnnS/k9bOKdztTlv2QVioePNSUMNgEujPeJ8e5jHyWwuYI+v528Nur t4Hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788284892; x=1788889692; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=zj7jRoHjkudAVVu49wNa7RpBG/Rcn+AOqbhR2Afeq2k=; b=oOI8gv8M+A0zaklwr9KnZJUYtzX1bBcma90TOApwenznmGusolKHl4CXsxn49axevJ tm0ChwQIM91PxRss1Ipfz9AYSFw9PFG4f0JS8HEb1U3i8CxYLJUQ5n8v2sPWY1kgc4zO lKCzJ8xizzD0Tg95BJrj4y7LMZ2jeVoI5XhlhNi36q+Y4ZKWlngqFm3L9hoZbxFx00+d 41qahdbUAPXxhe2muTcEdBLZPbCzBQZ9fXk/NARUfwR3GfEATSZfr5Twd4d/vr4lhtrE mlIPsSJwaCowR9erU/pbQwV15Hojw1dvzhMKV0M4Vk+bBRoS6h5/srf+oO+0X9+WS9/G GLNg== X-Gm-Message-State: AFuF++kW/qmQ0wfTv0NgdUCUK8yjSJA3/S/j9VVDOoAcpcjp+3kRY3gK C6Ws1s0RK2+r7E9CPvyro/AcBREkZhnCpe++KJyi4DDzjKK6iqQ6ZKhFXiltGcphpl5irbJlpqR 6FSW0wBjc X-Gm-Gg: AR+sD10nzowTUnHHe4PMdxprrHigHLJ/cXYi94l2NSoMTxNeNpLy72QezqOzvrqDy2p jVAuAHQcIXZpHN4hf14XfHYp7Q1HJtv5gnAW7K21t1HJtYIgYX+AGURjWTO+66MIYS9Blje3rXP grykEYNGIxIUYBtBIL2Xp7D9wdTsDJqq3wWSmuUYNtiqaXdM+4WQa55Aqjr/nf4ik/mdSej5dOq 5lFYX9X+z1m9napE9baSKO0hKiJH3mK6Etdh91g9+LWh3jQi3rl1F+lqVexLvhfoM0VDZY3fXiw +p2YamCj5wByRP5nVkIByEjgAGPS1WcxKLrFCjZtqCMx87EhaXnXmIbR0/Clo4x1hnzfuE1kmNq 0tIcWhCGyny4rzFOh2a6j8FouqBjR5W/XctNbJmsCawCeRuohj5p9JnuvZOsHDB09zHXOpOpxQe tpO5SzRdsZ2nAfDW288im7xbGhgh8aUllKq+7GCWBl9UrOGJEpQ9UJAWqQmU0SRtPFbvWXBMXcn vlivnhIJwtMlqs= X-Received: by 2002:a05:600c:4704:b0:493:cefc:d113 with SMTP id 5b1f17b1804b1-49b91c2d8femr551603875e9.5.1788284891619; Tue, 01 Sep 2026 10:48:11 -0700 (PDT) Received: from horizon ([217.155.46.38]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49ce47885b1sm2369225e9.14.2026.09.01.10.48.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Sep 2026 10:48:11 -0700 (PDT) From: Sean Rhodes To: linux-kernel@vger.kernel.org Cc: Hans de Goede , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , Corentin Chary , "Luke D. Jones" , Denis Benato , Prasanth Ksr , Jorge Lopez , Mark Pearson , "Derek J. Clark" , Joshua Grisham , Will Deacon , Douglas Anderson , "Kiryl Shutsemau (Meta)" , Sean Rhodes , Huacai Chen , Chen-Yu Tsai , Thomas Zimmermann , platform-driver-x86@vger.kernel.org, Dell.Client.Kernel@dell.com, Tzung-Bi Shih , Brian Norris , Julius Werner , Javier Martinez Canillas , Bjorn Helgaas , Danilo Krummrich , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig=20=28The=20Capable=20Hub=29?= , Titouan Ameline de Cadeville , Laxman Acharya Padhya , Yidi Lin , Kees Cook , Takashi Sakamoto , chrome-platform@lists.linux.dev, Maarten Lankhorst , Maxime Ripard , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, Krzysztof Kozlowski , Bjorn Andersson , Dmitry Baryshkov , Geert Uytterhoeven , Arnd Bergmann , Eric Biggers , Luca Weiss , Michal Simek , Sven Peter , Alexandre Belloni , Linus Walleij , Drew Fustini , linux-arm-kernel@lists.infradead.org, soc@lists.linux.dev Subject: [PATCH v14 2/5] firmware: Rename google firmware directory to coreboot Date: Tue, 1 Sep 2026 18:48:03 +0100 Message-ID: <0a81e0d8e15c13f6a65c45ce476e37b33564ad61.1788284852.git.sean@starlabs.systems> X-Mailer: git-send-email 2.53.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Most drivers in drivers/firmware/google are coreboot table drivers rather than Google-specific firmware drivers. Rename the directory to coreboot and update the Kconfig prompt, build path and maintainer entry. Rename the generic firmware Kconfig symbols to CONFIG_COREBOOT_* at the same time so new configurations describe the firmware interface rather than one vendor. Keep the old CONFIG_GOOGLE_* names as transitional symbols so existing configurations keep selecting the same drivers during the rename. Leave defconfig updates to a separate patch so the configuration churn is easy to review independently. Suggested-by: Julius Werner Signed-off-by: Sean Rhodes --- MAINTAINERS | 20 ++--- drivers/firmware/Kconfig | 2 +- drivers/firmware/Makefile | 2 +- drivers/firmware/{google =3D> coreboot}/Kconfig | 74 ++++++++++++++----- .../firmware/{google =3D> coreboot}/Makefile | 10 +-- drivers/firmware/{google =3D> coreboot}/cbmem.c | 0 .../{google =3D> coreboot}/coreboot_table.c | 0 .../{google =3D> coreboot}/coreboot_table.h | 0 .../framebuffer-coreboot.c | 0 drivers/firmware/{google =3D> coreboot}/gsmi.c | 0 .../memconsole-coreboot.c | 0 .../memconsole-x86-legacy.c | 0 .../{google =3D> coreboot}/memconsole.c | 0 .../{google =3D> coreboot}/memconsole.h | 6 +- drivers/firmware/{google =3D> coreboot}/vpd.c | 0 .../{google =3D> coreboot}/vpd_decode.c | 0 .../{google =3D> coreboot}/vpd_decode.h | 0 17 files changed, 76 insertions(+), 38 deletions(-) rename drivers/firmware/{google =3D> coreboot}/Kconfig (64%) rename drivers/firmware/{google =3D> coreboot}/Makefile (51%) rename drivers/firmware/{google =3D> coreboot}/cbmem.c (100%) rename drivers/firmware/{google =3D> coreboot}/coreboot_table.c (100%) rename drivers/firmware/{google =3D> coreboot}/coreboot_table.h (100%) rename drivers/firmware/{google =3D> coreboot}/framebuffer-coreboot.c (100= %) rename drivers/firmware/{google =3D> coreboot}/gsmi.c (100%) rename drivers/firmware/{google =3D> coreboot}/memconsole-coreboot.c (100%) rename drivers/firmware/{google =3D> coreboot}/memconsole-x86-legacy.c (10= 0%) rename drivers/firmware/{google =3D> coreboot}/memconsole.c (100%) rename drivers/firmware/{google =3D> coreboot}/memconsole.h (82%) rename drivers/firmware/{google =3D> coreboot}/vpd.c (100%) rename drivers/firmware/{google =3D> coreboot}/vpd_decode.c (100%) rename drivers/firmware/{google =3D> coreboot}/vpd_decode.h (100%) diff --git a/MAINTAINERS b/MAINTAINERS index a8048eaf49e5..4646744002dc 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -6716,6 +6716,16 @@ F: tools/testing/selftests/cgroup/test_hugetlb_memcg= .c F: tools/testing/selftests/cgroup/test_kmem.c F: tools/testing/selftests/cgroup/test_memcontrol.c =20 +COREBOOT FIRMWARE DRIVERS +M: Tzung-Bi Shih +R: Brian Norris +R: Julius Werner +L: chrome-platform@lists.linux.dev +S: Maintained +T: git git://git.kernel.org/pub/scm/linux/kernel/git/chrome-platform/linux= .git +F: drivers/firmware/coreboot/ +F: include/linux/coreboot.h + CORETEMP HARDWARE MONITORING DRIVER L: linux-hwmon@vger.kernel.org S: Orphan @@ -11144,16 +11154,6 @@ S: Maintained F: Documentation/networking/device_drivers/ethernet/google/gve.rst F: drivers/net/ethernet/google =20 -GOOGLE FIRMWARE DRIVERS -M: Tzung-Bi Shih -R: Brian Norris -R: Julius Werner -L: chrome-platform@lists.linux.dev -S: Maintained -T: git git://git.kernel.org/pub/scm/linux/kernel/git/chrome-platform/linux= .git -F: drivers/firmware/google/ -F: include/linux/coreboot.h - GOOGLE TENSOR SoC SUPPORT M: Peter Griffin R: Andr=C3=A9 Draszik diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig index 35dd6d422caf..b7d4df89cfb1 100644 --- a/drivers/firmware/Kconfig +++ b/drivers/firmware/Kconfig @@ -302,7 +302,7 @@ endif # TURRIS_MOX_RWTM source "drivers/firmware/arm_ffa/Kconfig" source "drivers/firmware/broadcom/Kconfig" source "drivers/firmware/cirrus/Kconfig" -source "drivers/firmware/google/Kconfig" +source "drivers/firmware/coreboot/Kconfig" source "drivers/firmware/efi/Kconfig" source "drivers/firmware/imx/Kconfig" source "drivers/firmware/meson/Kconfig" diff --git a/drivers/firmware/Makefile b/drivers/firmware/Makefile index 0e1e1b92a486..ce925e8ee526 100644 --- a/drivers/firmware/Makefile +++ b/drivers/firmware/Makefile @@ -31,7 +31,7 @@ obj-y +=3D broadcom/ obj-y +=3D cirrus/ obj-y +=3D meson/ obj-y +=3D microchip/ -obj-$(CONFIG_GOOGLE_FIRMWARE) +=3D google/ +obj-$(CONFIG_COREBOOT_FIRMWARE) +=3D coreboot/ obj-y +=3D efi/ obj-y +=3D imx/ obj-y +=3D psci/ diff --git a/drivers/firmware/google/Kconfig b/drivers/firmware/coreboot/Kc= onfig similarity index 64% rename from drivers/firmware/google/Kconfig rename to drivers/firmware/coreboot/Kconfig index b78c644fa253..d273bd836245 100644 --- a/drivers/firmware/google/Kconfig +++ b/drivers/firmware/coreboot/Kconfig @@ -1,13 +1,16 @@ # SPDX-License-Identifier: GPL-2.0-only -menuconfig GOOGLE_FIRMWARE - bool "Google Firmware Drivers" +menuconfig COREBOOT_FIRMWARE + bool "coreboot firmware drivers" + default GOOGLE_FIRMWARE default n help - These firmware drivers are used by Google servers, - Chromebooks and other devices using coreboot firmware. + These firmware drivers are used by devices running coreboot + firmware, including Chromebooks and some Google servers. + They include shared support for coreboot table entries and + drivers for CBMEM, framebuffer, firmware console and VPD records. If in doubt, say "N". =20 -if GOOGLE_FIRMWARE +if COREBOOT_FIRMWARE =20 config GOOGLE_SMI tristate "SMI interface for Google platforms" @@ -19,9 +22,10 @@ config GOOGLE_SMI driver provides an interface for reading and writing NVRAM variables. =20 -config GOOGLE_CBMEM +config COREBOOT_CBMEM tristate "CBMEM entries in sysfs" - depends on GOOGLE_COREBOOT_TABLE + depends on COREBOOT_TABLE + default GOOGLE_CBMEM help CBMEM is a downwards-growing memory region created by the Coreboot BIOS containing tagged data structures from the @@ -34,9 +38,10 @@ config GOOGLE_CBMEM memory for each entry in sysfs under /sys/bus/coreboot/devices/cbmem-. =20 -config GOOGLE_COREBOOT_TABLE +config COREBOOT_TABLE tristate "Coreboot Table Access" depends on HAS_IOMEM && (ACPI || OF) + default GOOGLE_COREBOOT_TABLE help This option enables the coreboot_table module, which provides other firmware modules access to the coreboot table. The coreboot table @@ -44,42 +49,75 @@ config GOOGLE_COREBOOT_TABLE device tree node /firmware/coreboot. If unsure say N. =20 -config GOOGLE_MEMCONSOLE +config COREBOOT_MEMCONSOLE_COMMON tristate - depends on GOOGLE_MEMCONSOLE_X86_LEGACY || GOOGLE_MEMCONSOLE_COREBOOT + depends on GOOGLE_MEMCONSOLE_X86_LEGACY || COREBOOT_MEMCONSOLE + default GOOGLE_MEMCONSOLE =20 config GOOGLE_MEMCONSOLE_X86_LEGACY tristate "Firmware Memory Console - X86 Legacy support" depends on X86 && ACPI && DMI - select GOOGLE_MEMCONSOLE + select COREBOOT_MEMCONSOLE_COMMON help This option enables the kernel to search for a firmware log in the EBDA on Google servers. If found, this log is exported to userland in the file /sys/firmware/log. + This driver is limited to x86 systems that expose the legacy + Google EBDA console format. =20 -config GOOGLE_FRAMEBUFFER_COREBOOT +config COREBOOT_FRAMEBUFFER tristate "Coreboot Framebuffer" - depends on GOOGLE_COREBOOT_TABLE + depends on COREBOOT_TABLE + default GOOGLE_FRAMEBUFFER_COREBOOT help This option enables the kernel to search for a framebuffer in the coreboot table. If found, it is registered with a platform device of type coreboot-framebuffer. Using the old device of type simple-framebuffer is deprecated. =20 -config GOOGLE_MEMCONSOLE_COREBOOT +config COREBOOT_MEMCONSOLE tristate "Firmware Memory Console" - depends on GOOGLE_COREBOOT_TABLE - select GOOGLE_MEMCONSOLE + depends on COREBOOT_TABLE + select COREBOOT_MEMCONSOLE_COMMON + default GOOGLE_MEMCONSOLE_COREBOOT help This option enables the kernel to search for a firmware log in the coreboot table. If found, this log is exported to userland in the file /sys/firmware/log. + This is the coreboot-table backed variant of the firmware memory + console driver. =20 config GOOGLE_VPD tristate "Vital Product Data" - depends on GOOGLE_COREBOOT_TABLE + depends on COREBOOT_TABLE help This option enables the kernel to expose the content of Google VPD under /sys/firmware/vpd. + VPD records carry firmware-provided key/value data used by + Google devices. + +endif # COREBOOT_FIRMWARE =20 -endif # GOOGLE_FIRMWARE +config GOOGLE_FIRMWARE + bool + transitional + +config GOOGLE_CBMEM + tristate + transitional + +config GOOGLE_COREBOOT_TABLE + tristate + transitional + +config GOOGLE_MEMCONSOLE + tristate + transitional + +config GOOGLE_FRAMEBUFFER_COREBOOT + tristate + transitional + +config GOOGLE_MEMCONSOLE_COREBOOT + tristate + transitional diff --git a/drivers/firmware/google/Makefile b/drivers/firmware/coreboot/M= akefile similarity index 51% rename from drivers/firmware/google/Makefile rename to drivers/firmware/coreboot/Makefile index 8151e323cc43..e681f274417a 100644 --- a/drivers/firmware/google/Makefile +++ b/drivers/firmware/coreboot/Makefile @@ -1,14 +1,14 @@ # SPDX-License-Identifier: GPL-2.0 =20 obj-$(CONFIG_GOOGLE_SMI) +=3D gsmi.o -obj-$(CONFIG_GOOGLE_COREBOOT_TABLE) +=3D coreboot_table.o -obj-$(CONFIG_GOOGLE_FRAMEBUFFER_COREBOOT) +=3D framebuffer-coreboot.o -obj-$(CONFIG_GOOGLE_MEMCONSOLE) +=3D memconsole.o -obj-$(CONFIG_GOOGLE_MEMCONSOLE_COREBOOT) +=3D memconsole-coreboot.o +obj-$(CONFIG_COREBOOT_TABLE) +=3D coreboot_table.o +obj-$(CONFIG_COREBOOT_FRAMEBUFFER) +=3D framebuffer-coreboot.o +obj-$(CONFIG_COREBOOT_MEMCONSOLE_COMMON) +=3D memconsole.o +obj-$(CONFIG_COREBOOT_MEMCONSOLE) +=3D memconsole-coreboot.o obj-$(CONFIG_GOOGLE_MEMCONSOLE_X86_LEGACY) +=3D memconsole-x86-legacy.o =20 # Must come after coreboot_table.o, as this driver depends on that bus typ= e. -obj-$(CONFIG_GOOGLE_CBMEM) +=3D cbmem.o +obj-$(CONFIG_COREBOOT_CBMEM) +=3D cbmem.o =20 vpd-sysfs-y :=3D vpd.o vpd_decode.o obj-$(CONFIG_GOOGLE_VPD) +=3D vpd-sysfs.o diff --git a/drivers/firmware/google/cbmem.c b/drivers/firmware/coreboot/cb= mem.c similarity index 100% rename from drivers/firmware/google/cbmem.c rename to drivers/firmware/coreboot/cbmem.c diff --git a/drivers/firmware/google/coreboot_table.c b/drivers/firmware/co= reboot/coreboot_table.c similarity index 100% rename from drivers/firmware/google/coreboot_table.c rename to drivers/firmware/coreboot/coreboot_table.c diff --git a/drivers/firmware/google/coreboot_table.h b/drivers/firmware/co= reboot/coreboot_table.h similarity index 100% rename from drivers/firmware/google/coreboot_table.h rename to drivers/firmware/coreboot/coreboot_table.h diff --git a/drivers/firmware/google/framebuffer-coreboot.c b/drivers/firmw= are/coreboot/framebuffer-coreboot.c similarity index 100% rename from drivers/firmware/google/framebuffer-coreboot.c rename to drivers/firmware/coreboot/framebuffer-coreboot.c diff --git a/drivers/firmware/google/gsmi.c b/drivers/firmware/coreboot/gsm= i.c similarity index 100% rename from drivers/firmware/google/gsmi.c rename to drivers/firmware/coreboot/gsmi.c diff --git a/drivers/firmware/google/memconsole-coreboot.c b/drivers/firmwa= re/coreboot/memconsole-coreboot.c similarity index 100% rename from drivers/firmware/google/memconsole-coreboot.c rename to drivers/firmware/coreboot/memconsole-coreboot.c diff --git a/drivers/firmware/google/memconsole-x86-legacy.c b/drivers/firm= ware/coreboot/memconsole-x86-legacy.c similarity index 100% rename from drivers/firmware/google/memconsole-x86-legacy.c rename to drivers/firmware/coreboot/memconsole-x86-legacy.c diff --git a/drivers/firmware/google/memconsole.c b/drivers/firmware/corebo= ot/memconsole.c similarity index 100% rename from drivers/firmware/google/memconsole.c rename to drivers/firmware/coreboot/memconsole.c diff --git a/drivers/firmware/google/memconsole.h b/drivers/firmware/corebo= ot/memconsole.h similarity index 82% rename from drivers/firmware/google/memconsole.h rename to drivers/firmware/coreboot/memconsole.h index aaff2b72b606..58899c2abaaa 100644 --- a/drivers/firmware/google/memconsole.h +++ b/drivers/firmware/coreboot/memconsole.h @@ -7,8 +7,8 @@ * Copyright 2017 Google Inc. */ =20 -#ifndef __FIRMWARE_GOOGLE_MEMCONSOLE_H -#define __FIRMWARE_GOOGLE_MEMCONSOLE_H +#ifndef __FIRMWARE_COREBOOT_MEMCONSOLE_H +#define __FIRMWARE_COREBOOT_MEMCONSOLE_H =20 #include =20 @@ -33,4 +33,4 @@ int memconsole_sysfs_init(void); */ void memconsole_exit(void); =20 -#endif /* __FIRMWARE_GOOGLE_MEMCONSOLE_H */ +#endif /* __FIRMWARE_COREBOOT_MEMCONSOLE_H */ diff --git a/drivers/firmware/google/vpd.c b/drivers/firmware/coreboot/vpd.c similarity index 100% rename from drivers/firmware/google/vpd.c rename to drivers/firmware/coreboot/vpd.c diff --git a/drivers/firmware/google/vpd_decode.c b/drivers/firmware/corebo= ot/vpd_decode.c similarity index 100% rename from drivers/firmware/google/vpd_decode.c rename to drivers/firmware/coreboot/vpd_decode.c diff --git a/drivers/firmware/google/vpd_decode.h b/drivers/firmware/corebo= ot/vpd_decode.h similarity index 100% rename from drivers/firmware/google/vpd_decode.h rename to drivers/firmware/coreboot/vpd_decode.h From nobody Sat Sep 19 05:58:33 2026 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7264348CD7B for ; Tue, 1 Sep 2026 17:48:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788284902; cv=none; b=T6nfPSq7X1B+dDBmU+NCuoA7YF6Vab8oye1o2QhOU0KKk1KWIKHavFVe2eTnAepnR7jQoMS+r0MMPYO/HQMCwSdGWilM9QX17fkVCwx8PprrdiTcLNpqLPS2Q/6S9qYVoRQbBOMyq6KFQfWmqHzN72gH9kROG23FWTfilq9CL+M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788284902; c=relaxed/simple; bh=vfQaj9ly6LhRgNLfN+7UahmQXADGA5101PUjRoWcTdU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hZSYJGix4AXJv9BHGiWo7DzlH+KVX2QAKYN7cUD8DOOPFFvFAcf8SZ3xOp4oj17ysQGUZ0u2eivlGrMYRGViMMA3egp0ikL9p/7we9+9Uosj+QfJ07D43UXuVw2zQCHD/QdOV1JzVAFXg+QQnBVHi+pCdw6imGFmvmJM91h1gm0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=starlabs.systems; spf=pass smtp.mailfrom=starlabs.systems; dkim=pass (2048-bit key) header.d=starlabs-systems.20251104.gappssmtp.com header.i=@starlabs-systems.20251104.gappssmtp.com header.b=Ny+qmMUK; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=starlabs.systems Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=starlabs.systems Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=starlabs-systems.20251104.gappssmtp.com header.i=@starlabs-systems.20251104.gappssmtp.com header.b="Ny+qmMUK" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-49b8be0409fso307225e9.2 for ; Tue, 01 Sep 2026 10:48:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=starlabs-systems.20251104.gappssmtp.com; s=20251104; t=1788284893; x=1788889693; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=0l43AVlC6vAtGNyUJOGdQyBhYz3ewWV5F6wFrMVKpks=; b=Ny+qmMUKeweMa71IhvvxF8Q7ikGujhiyOc+73zDRLfTv2G/AfQxyI6sE7pNc8io4fi uFtSCtqLBcwM+S2wTHJ/c14oKkdTpMeJuA7/eGXOwpNtAULdjxRg/anq1rmJozQLiBKp aDOX/apfGgmaGsGpY4kITVLzOfDRB9IaJ2/V83+yRi1pdA8Xx2pAJqmcCMl9ongAJH34 Rz8d7TivgBKxzNoU9HB/BHlWxDW8VF1XBzLRvFN2DFg0isbBOUa+S+Udji9caAD8NLv+ zVBSQ9ZqTC1c/QLunuGEaDM9GTvtOm8xp0ForhbWULQyNOSjs7GF5l52MQxatIE74XeH Xuog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788284893; x=1788889693; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=0l43AVlC6vAtGNyUJOGdQyBhYz3ewWV5F6wFrMVKpks=; b=d1UY7jp5dNv+CP52+fOVaaD0qVfG1humvzzCLZ179ceIqhPc6EkayQ+hdPGsH/7Q0L PDs8kzT73U7aPUI9WNTeKKg4vcDVtvAZYFis3d+V8cBvgJL0hQnckCWgakC0/TYjwvbV 0KrQYmwfIF7qj5dtUE/hv4BF6IZlBcoxnA5u1rnotrZeK/YZ1ZuZkd1Bc7ZMLZnsq51m l3tALU6a7T5gkRc9D0SIsZ3NDrjObVSLucPGlSr0lqj2P2UOP7B5iCXnWhd3oGI96Ivk 3aVuRZpupTP0X3fBX/qKhBAF936YWScjADspQD/ssv3tqXOim/6VF559eIpXo4O5/ToC u2iw== X-Gm-Message-State: AFuF++lTaTiW9k6swoPcOL2sQSb5P/PWWMcGtNQol8F+rdgEj/8ZGqAE gkloMVBGc+I8iBjli3239JNxJDLpgrcmVizSrhvQ6Et5JPT082xHohgYCwmziJK4R8mYBoy2UT2 5BR9V0YCp X-Gm-Gg: AR+sD12ZxWYeLlMEjfpVNKbpFMEuUmOUfxry+eiyqyoRXEb9lhBdRrB/QBI64DoFQLV xYa3gpEoQrAXuqtJIuXi6cY4zN/F0V/9GsiugcCqZ6d7oiaIFR6gqXZKleAWBrNj4Di0FDs6uyL 9An2CstDxBNj4sHk35D8mPjAxZ946p+afHFyRZa6VrLIop/Vgs9hzAnvmMkncagz54Rt2YyLspL rDGoiV/E4mGHjMz9FkLCMqO3IjbgEWd5qqkDKFVN7lFVLZqdHZHzFnJ/3VaWlX9K7HZ8WAgkFnr S2rtUAl00VJyhfdwo4HW2J1rJVIwcZm6X6YB6sqY4xNW9dwmQSGZrG6I4xMK6iz2BjRkBulwb9M eH5hhqwo8W1pG7i6p58ybeyV6XQreeCv53aRSFameJch3Hte1zCly/kN0KJNOZAokG0bQ7cFh+3 O/2siXwNBSBxE55xvW0L/fAThS99cEGOTRNeiB+UQi50Ayo1/JKmrudoKcip0ngOIJmYSqIzcgo cKHpmHTEI+cZ5U= X-Received: by 2002:a05:600c:4512:b0:49c:dc14:d681 with SMTP id 5b1f17b1804b1-49cdc14d69dmr178611345e9.3.1788284893038; Tue, 01 Sep 2026 10:48:13 -0700 (PDT) Received: from horizon ([217.155.46.38]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49ce47885b1sm2369225e9.14.2026.09.01.10.48.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Sep 2026 10:48:12 -0700 (PDT) From: Sean Rhodes To: linux-kernel@vger.kernel.org Cc: Hans de Goede , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , Corentin Chary , "Luke D. Jones" , Denis Benato , Prasanth Ksr , Jorge Lopez , Mark Pearson , "Derek J. Clark" , Joshua Grisham , Will Deacon , Douglas Anderson , "Kiryl Shutsemau (Meta)" , Sean Rhodes , Huacai Chen , Chen-Yu Tsai , Thomas Zimmermann , platform-driver-x86@vger.kernel.org, Dell.Client.Kernel@dell.com, Tzung-Bi Shih , Brian Norris , Julius Werner , Javier Martinez Canillas , Bjorn Helgaas , Danilo Krummrich , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig=20=28The=20Capable=20Hub=29?= , Titouan Ameline de Cadeville , Laxman Acharya Padhya , Yidi Lin , Kees Cook , Takashi Sakamoto , chrome-platform@lists.linux.dev, Maarten Lankhorst , Maxime Ripard , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, Krzysztof Kozlowski , Bjorn Andersson , Dmitry Baryshkov , Geert Uytterhoeven , Arnd Bergmann , Eric Biggers , Luca Weiss , Michal Simek , Sven Peter , Alexandre Belloni , Linus Walleij , Drew Fustini , linux-arm-kernel@lists.infradead.org, soc@lists.linux.dev Subject: [PATCH v14 3/5] drm/sysfb: Update coreboot framebuffer Kconfig symbol Date: Tue, 1 Sep 2026 18:48:04 +0100 Message-ID: <1748b8899ec772cc435dc57dc55f76c15da95f0a.1788284852.git.sean@starlabs.systems> X-Mailer: git-send-email 2.53.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The coreboot firmware directory rename introduces COREBOOT_FRAMEBUFFER as the user-facing symbol while retaining GOOGLE_FRAMEBUFFER_COREBOOT as a transitional compatibility symbol. Make DRM_COREBOOTDRM depend on the new symbol. This keeps the DRM dependency aligned with the renamed firmware option without changing runtime behavior. Signed-off-by: Sean Rhodes Reviewed-by: Thomas Zimmermann --- drivers/gpu/drm/sysfb/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/sysfb/Kconfig b/drivers/gpu/drm/sysfb/Kconfig index f7e48178885e..2bfcd59bfe6d 100644 --- a/drivers/gpu/drm/sysfb/Kconfig +++ b/drivers/gpu/drm/sysfb/Kconfig @@ -10,7 +10,7 @@ config DRM_SYSFB_HELPER config DRM_COREBOOTDRM tristate "Coreboot framebuffer driver" depends on DRM && MMU - depends on GOOGLE_FRAMEBUFFER_COREBOOT + depends on COREBOOT_FRAMEBUFFER select APERTURE_HELPERS select DRM_CLIENT_SELECTION select DRM_GEM_SHMEM_HELPER From nobody Sat Sep 19 05:58:33 2026 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0AD8348D897 for ; Tue, 1 Sep 2026 17:48:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788284901; cv=none; b=EeaPcl2aaJMEc3CiX/6rphpyyMEIzd2rKw3nc0KM43dH4Ou9PZnrXpdapC9/xd6JmmnInvTby0EN7VEX8bDD5R5BGugFth31Nn9OeJjC5EcT7JnvNd4E9jiUzHXbDowEk+t+cLEzTYRrWyZJ04OFWHaic+sS3vgALayJTSVqwxc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788284901; c=relaxed/simple; bh=4hEgPfvivxX3yp5+4wICoRbv2smJXjGLeVG7Hp/iGjg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rSf61JcBZY3C3miNKaTBDwceMXBx7W77G77Nae0aw9LJqN9qkHPNoKIdgmfLcOU6SiWpFjsM50omsgKhQtmERG0INCGq3M9awvszobIodF5rc5KKPOTvdvgEMgL7Pyv8YOId5sT6dLvhVf88XNFyOn4eWAt3UrMEgSW/83WPZTc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=starlabs.systems; spf=pass smtp.mailfrom=starlabs.systems; dkim=pass (2048-bit key) header.d=starlabs-systems.20251104.gappssmtp.com header.i=@starlabs-systems.20251104.gappssmtp.com header.b=BW3kwXYM; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=starlabs.systems Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=starlabs.systems Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=starlabs-systems.20251104.gappssmtp.com header.i=@starlabs-systems.20251104.gappssmtp.com header.b="BW3kwXYM" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-499ac87c92bso615405e9.1 for ; Tue, 01 Sep 2026 10:48:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=starlabs-systems.20251104.gappssmtp.com; s=20251104; t=1788284895; x=1788889695; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=XFdXZ9lToyySBZPlYStaX8tcbsNRKYBK8GHG3pEPXyo=; b=BW3kwXYMQxHvOvuBqOM+pf0pMdnhvyjhpx0ae4oYVQIWCreB8kWOHepn+Jsm+No3Ja cuxEpsyFaP98Q8YxKPLaGOZkEg2zYhFj0PO9HRtdAsNpii/vrFIIqGn0iPqLeVcytBcX wYgFIsa16w1zVFSs1j36sedQ1ljcM3yFi+9r85g7tHjUuGP6SQBhbPIWveI7JOlrAsGT XepeYBERM5tXc9AzFYFCmOqauMDiA0fimyr+NKpd0nVwXbHHER+lJEcxYtRT/v3t77jx D3lK4J0iPr9R5PsRLLqru1zob2vCnl4S14LXv+bxJdwgt7xlgneAeqhidbeIZM/p1CG1 qFNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788284895; x=1788889695; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=XFdXZ9lToyySBZPlYStaX8tcbsNRKYBK8GHG3pEPXyo=; b=e4DsXw3Qgp3fWAp3Oz1qQbtO6kFveS3bz0W8M/2sjHR+qmKrHf2LR2xlhnpb8+4Eo6 Oz31Cf0UNTQ2n2AdbHOqxZJbrFQrkHcf5YrXFLMNAbI9OHEO2f0db2XAanq3s+9JN6dx cK4MvY9n+VneDYoBZPn1O0BB+90P7vEQcbNjMiRS1HXrKNl85uQDX507yxeEvptxTYc6 wKCx6CLUEiNm9p3IWQUtMlE18pCIv30Pve6hrSDFpdszgTMt5WSQ8bxlwOmSdv2BiRQC XwRGmrKxUG49Xpb5aJO6Gib986gyQ1JnsyXdSYrzU/hD5VnFoEMxwOatLXz9K+nLKLrN n7Cw== X-Gm-Message-State: AFuF++n9A8+AlMIRVW9cjrJck7ZNP9aFXqF3lBYXxXFURmFWlJBQYlAs YV4tD8nvJzkdgEyWZ5Eta2CdFgmeJdyQf5EJui48OPCwkEo9UyyWlDgTboquSFmZhPtdFUyh0wM Gtz9itDg6 X-Gm-Gg: AR+sD12vgNwx+4xcvhEbcNYLbFscSqdxybsj4GuIulRCNkiQYk7Ivlg1OnKbX1PgdYN +FAgk9XmiNyNSnfW/ZcyhIKuvk7+RtqLonmsRU3urArDwoC/HZnb0ADoCbIGPN7qVL5Vmi5fTV9 QR1Ftre68yOQVeajceTAnOr8+Y17T6hU5futQigQO1JpmSj43tVJVCR1UyHuGAPu5ebn7/3eprj fYJA+vvyHxRvrK8C7uolbcj2D2q8EGxAWb/K60oL0BH4RmRFCzavKIl7jxt29imRdv05wPB1xVO p0Y8hWH59VqAPA97LYv6+rS14qscyIT9MV7pV+spJZHgvgHH0d7NHUiVIghsYxY16IGQ13cjJ28 u2YMsRW8MfdNPnY5uPJ1khR95UEXnrKPAFjRH531HGiw4pcgtpEehbCJrQgc21Tro177EbUzboz lb2PfOiJFQmtKlX1E61xicPsITsS8s0tr2N2OaVV0P590NbPrNLyHsE1V9XA0Z1Qlgr8zTfvTPu C3kPcBZNjv6VrnzIV3Qkp1+Iw== X-Received: by 2002:a05:600c:8b45:b0:49c:e27c:6b10 with SMTP id 5b1f17b1804b1-49ce27c6b5amr79421835e9.3.1788284894625; Tue, 01 Sep 2026 10:48:14 -0700 (PDT) Received: from horizon ([217.155.46.38]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49ce47885b1sm2369225e9.14.2026.09.01.10.48.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Sep 2026 10:48:14 -0700 (PDT) From: Sean Rhodes To: linux-kernel@vger.kernel.org Cc: Hans de Goede , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , Corentin Chary , "Luke D. Jones" , Denis Benato , Prasanth Ksr , Jorge Lopez , Mark Pearson , "Derek J. Clark" , Joshua Grisham , Will Deacon , Douglas Anderson , "Kiryl Shutsemau (Meta)" , Sean Rhodes , Huacai Chen , Chen-Yu Tsai , Thomas Zimmermann , platform-driver-x86@vger.kernel.org, Dell.Client.Kernel@dell.com, Tzung-Bi Shih , Brian Norris , Julius Werner , Javier Martinez Canillas , Bjorn Helgaas , Danilo Krummrich , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig=20=28The=20Capable=20Hub=29?= , Titouan Ameline de Cadeville , Laxman Acharya Padhya , Yidi Lin , Kees Cook , Takashi Sakamoto , chrome-platform@lists.linux.dev, Maarten Lankhorst , Maxime Ripard , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, Krzysztof Kozlowski , Bjorn Andersson , Dmitry Baryshkov , Geert Uytterhoeven , Arnd Bergmann , Eric Biggers , Luca Weiss , Michal Simek , Sven Peter , Alexandre Belloni , Linus Walleij , Drew Fustini , linux-arm-kernel@lists.infradead.org, soc@lists.linux.dev Subject: [PATCH v14 4/5] firmware: coreboot: Add CFR firmware attributes driver Date: Tue, 1 Sep 2026 18:48:05 +0100 Message-ID: <73204be94586622903da7fa90757fb091e8a7c2c.1788284852.git.sean@starlabs.systems> X-Mailer: git-send-email 2.53.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" coreboot can publish a CFR tree in its coreboot table to describe firmware setup options. Add a firmware-attributes driver for that table entry under the coreboot firmware driver directory. The driver exposes runtime EFI variable-backed boolean, enum and integer settings through the firmware-attributes ABI. It only registers settings with readable runtime EFI variables, skips suppressed, volatile, dependency-gated and non-runtime options, and keeps read-only or inactive options read-only in sysfs. For settings with an APM_CNT runtime-apply record, write the EFI variable and ask firmware to apply the setting immediately with an I/O port SMI command. If firmware reports a failure, restore the old EFI variable value. Settings without a runtime apply hook keep the EFI variable update and set pending_reboot. Depend on HAS_IOPORT because APM_CNT uses legacy I/O ports. Tested on a Star Labs Byte with firmware 26.07: runtime APM_CNT apply was verified with power_led, and reboot-needed behavior was verified with debug_level. Link: https://doc.coreboot.org/drivers/cfr.html Link: https://doc.coreboot.org/drivers/cfr_internal.html Signed-off-by: Sean Rhodes --- MAINTAINERS | 6 + drivers/firmware/coreboot/Kconfig | 15 + drivers/firmware/coreboot/Makefile | 1 + drivers/firmware/coreboot/coreboot-cfr.c | 1204 ++++++++++++++++++++++ 4 files changed, 1226 insertions(+) create mode 100644 drivers/firmware/coreboot/coreboot-cfr.c diff --git a/MAINTAINERS b/MAINTAINERS index 4646744002dc..349d394c3fbf 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -6716,6 +6716,12 @@ F: tools/testing/selftests/cgroup/test_hugetlb_memcg= .c F: tools/testing/selftests/cgroup/test_kmem.c F: tools/testing/selftests/cgroup/test_memcontrol.c =20 +COREBOOT CFR FIRMWARE ATTRIBUTES DRIVER +M: Sean Rhodes +L: chrome-platform@lists.linux.dev +S: Maintained +F: drivers/firmware/coreboot/coreboot-cfr.c + COREBOOT FIRMWARE DRIVERS M: Tzung-Bi Shih R: Brian Norris diff --git a/drivers/firmware/coreboot/Kconfig b/drivers/firmware/coreboot/= Kconfig index d273bd836245..acfc7d187228 100644 --- a/drivers/firmware/coreboot/Kconfig +++ b/drivers/firmware/coreboot/Kconfig @@ -49,6 +49,21 @@ config COREBOOT_TABLE device tree node /firmware/coreboot. If unsure say N. =20 +config COREBOOT_CFR + tristate "coreboot CFR firmware attributes" + depends on EFI + depends on COREBOOT_TABLE + depends on HAS_IOPORT + select CRC32 + select FW_ATTR_CLASS + help + This driver parses the coreboot CFR table and exposes runtime EFI + variable-backed options through the firmware-attributes sysfs + interface. + + If you have a system running coreboot with CFR runtime + configuration support, say Y or M here. + config COREBOOT_MEMCONSOLE_COMMON tristate depends on GOOGLE_MEMCONSOLE_X86_LEGACY || COREBOOT_MEMCONSOLE diff --git a/drivers/firmware/coreboot/Makefile b/drivers/firmware/coreboot= /Makefile index e681f274417a..a08d167a95a8 100644 --- a/drivers/firmware/coreboot/Makefile +++ b/drivers/firmware/coreboot/Makefile @@ -2,6 +2,7 @@ =20 obj-$(CONFIG_GOOGLE_SMI) +=3D gsmi.o obj-$(CONFIG_COREBOOT_TABLE) +=3D coreboot_table.o +obj-$(CONFIG_COREBOOT_CFR) +=3D coreboot-cfr.o obj-$(CONFIG_COREBOOT_FRAMEBUFFER) +=3D framebuffer-coreboot.o obj-$(CONFIG_COREBOOT_MEMCONSOLE_COMMON) +=3D memconsole.o obj-$(CONFIG_COREBOOT_MEMCONSOLE) +=3D memconsole-coreboot.o diff --git a/drivers/firmware/coreboot/coreboot-cfr.c b/drivers/firmware/co= reboot/coreboot-cfr.c new file mode 100644 index 000000000000..2d9ea5d213d8 --- /dev/null +++ b/drivers/firmware/coreboot/coreboot-cfr.c @@ -0,0 +1,1204 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * coreboot CFR firmware attributes driver. + * + * Parses LB_TAG_CFR_ROOT records from the coreboot table and exposes + * runtime EFI variable-backed options through the firmware-attributes cla= ss. + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#include "coreboot_table.h" + +#define DRIVER_NAME "coreboot-cfr" + +#define LB_TAG_CFR_ROOT 0x47 +#define CFR_VERSION 0 + +enum cfr_tags { + CFR_TAG_OPTION_FORM =3D 1, + CFR_TAG_ENUM_VALUE =3D 2, + CFR_TAG_OPTION_ENUM =3D 3, + CFR_TAG_OPTION_NUMBER =3D 4, + CFR_TAG_OPTION_BOOL =3D 5, + CFR_TAG_VARCHAR_OPT_NAME =3D 7, + CFR_TAG_VARCHAR_UI_NAME =3D 8, + CFR_TAG_RUNTIME_APPLY =3D 13, +}; + +enum cfr_option_flags { + CFR_OPTFLAG_READONLY =3D BIT(0), + CFR_OPTFLAG_INACTIVE =3D BIT(1), + CFR_OPTFLAG_SUPPRESS =3D BIT(2), + CFR_OPTFLAG_VOLATILE =3D BIT(3), + CFR_OPTFLAG_RUNTIME =3D BIT(4), +}; + +enum cfr_runtime_apply_method { + CFR_RUNTIME_APPLY_NONE =3D 0, + CFR_RUNTIME_APPLY_APM_CNT =3D 1, +}; + +struct lb_cfr { + u32 tag; + u32 size; + u32 version; + u32 checksum; +} __packed; + +struct lb_cfr_varbinary { + u32 tag; + u32 size; + u32 data_length; +} __packed; + +struct lb_cfr_enum_value { + u32 tag; + u32 size; + u32 value; +} __packed; + +struct lb_cfr_runtime_apply { + u32 tag; + u32 size; + u32 method; + u32 id; +} __packed; + +struct lb_cfr_numeric_option { + u32 tag; + u32 size; + cb_u64 object_id; + cb_u64 dependency_id; + u32 flags; + u32 default_value; + u32 min; + u32 max; + u32 step; + u32 display_flags; +} __packed; + +struct lb_cfr_option_form { + u32 tag; + u32 size; + cb_u64 object_id; + cb_u64 dependency_id; + u32 flags; +} __packed; + +#define COREBOOT_CFR_OPT_SKIP_FLAGS \ + (CFR_OPTFLAG_SUPPRESS | CFR_OPTFLAG_VOLATILE) + +#define COREBOOT_CFR_OPT_READ_ONLY_FLAGS \ + (CFR_OPTFLAG_READONLY | CFR_OPTFLAG_INACTIVE) + +#define COREBOOT_CFR_EFI_ATTRS \ + (EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_BOOTSERVICE_ACCESS | \ + EFI_VARIABLE_RUNTIME_ACCESS) + +#define COREBOOT_CFR_APM_CNT_PORT 0xb2 +#define COREBOOT_CFR_APM_STS_PORT 0xb3 +#define COREBOOT_CFR_APM_APPLY_CMD 0xe3 +#define COREBOOT_CFR_MAX_FORM_DEPTH 16 + +static efi_guid_t coreboot_cfr_guid =3D EFI_GUID(0xceae4c1d, 0x335b, 0x468= 5, + 0xa4, 0xa0, 0xfc, 0x4a, + 0x94, 0xee, 0xa0, 0x85); + +enum coreboot_cfr_setting_type { + COREBOOT_CFR_SETTING_ENUM, + COREBOOT_CFR_SETTING_NUMBER, + COREBOOT_CFR_SETTING_BOOL, +}; + +struct coreboot_cfr_enum { + char *label; + u32 value; +}; + +struct coreboot_cfr_setting { + struct kobject kobj; + struct list_head node; + struct coreboot_cfr_drvdata *drvdata; + enum coreboot_cfr_setting_type type; + char *name; + char *display_name; + struct coreboot_cfr_enum *values; + unsigned int n_values; + u32 default_value; + u32 min; + u32 max; + u32 step; + u32 runtime_apply_method; + u32 runtime_apply_id; + bool read_only; +}; + +struct coreboot_cfr_drvdata { + struct device *class_dev; + struct kset *attrs_kset; + struct list_head settings; + /* Serializes EFI variable writes and the matching runtime apply hook. */ + struct mutex lock; + bool efi_writes_supported; + bool pending_reboot; +}; + +struct coreboot_cfr_iterator { + const u8 *cursor; + size_t remaining; +}; + +static struct coreboot_cfr_setting *to_coreboot_cfr_setting(struct kobject= *kobj) +{ + return container_of(kobj, struct coreboot_cfr_setting, kobj); +} + +static bool coreboot_cfr_string_is_valid_name(const char *name) +{ + return name && name[0] && !strchr(name, '/') && + strcmp(name, "pending_reboot") !=3D 0; +} + +static bool coreboot_cfr_string_is_valid_label(const char *label) +{ + return label && !strchr(label, ';') && !strchr(label, '\n'); +} + +static char *coreboot_cfr_string_dup(const struct lb_cfr_varbinary *str) +{ + const char *data =3D (const char *)(str + 1); + size_t len =3D str->data_length; + + if (len && !data[len - 1]) + len--; + + return kmemdup_nul(data, len, GFP_KERNEL); +} + +static const struct coreboot_table_entry * +coreboot_cfr_next_entry(struct coreboot_cfr_iterator *iterator) +{ + const struct coreboot_table_entry *entry; + + if (!iterator->remaining) + return NULL; + + if (iterator->remaining < sizeof(*entry)) + return ERR_PTR(-EINVAL); + + entry =3D (const struct coreboot_table_entry *)iterator->cursor; + if (entry->size < sizeof(*entry) || entry->size > iterator->remaining) + return ERR_PTR(-EINVAL); + + iterator->cursor +=3D entry->size; + iterator->remaining -=3D entry->size; + + return entry; +} + +static const struct coreboot_table_entry * +coreboot_cfr_child_entry(const void *base, size_t len, u32 tag) +{ + struct coreboot_cfr_iterator iterator =3D { + .cursor =3D base, + .remaining =3D len, + }; + const struct coreboot_table_entry *entry; + + for (;;) { + entry =3D coreboot_cfr_next_entry(&iterator); + if (IS_ERR_OR_NULL(entry)) + return entry; + + if (entry->tag =3D=3D tag) + return entry; + } +} + +static const struct lb_cfr_varbinary * +coreboot_cfr_child_string(const void *base, size_t len, u32 tag) +{ + const struct lb_cfr_varbinary *str; + const struct coreboot_table_entry *entry; + + entry =3D coreboot_cfr_child_entry(base, len, tag); + if (IS_ERR(entry)) + return ERR_CAST(entry); + if (!entry) + return NULL; + + if (entry->size < sizeof(*str)) + return ERR_PTR(-EINVAL); + + str =3D (const struct lb_cfr_varbinary *)entry; + if (str->data_length > entry->size - sizeof(*str)) + return ERR_PTR(-EINVAL); + + return str; +} + +static const struct lb_cfr_runtime_apply * +coreboot_cfr_child_runtime_apply(const void *base, size_t len) +{ + const struct lb_cfr_runtime_apply *runtime_apply; + const struct coreboot_table_entry *entry; + + entry =3D coreboot_cfr_child_entry(base, len, CFR_TAG_RUNTIME_APPLY); + if (IS_ERR(entry)) + return ERR_CAST(entry); + if (!entry) + return NULL; + + if (entry->size < sizeof(*runtime_apply)) + return ERR_PTR(-EINVAL); + + runtime_apply =3D (const struct lb_cfr_runtime_apply *)entry; + if (runtime_apply->method =3D=3D CFR_RUNTIME_APPLY_APM_CNT && + runtime_apply->id > U8_MAX) + return ERR_PTR(-EINVAL); + + return runtime_apply; +} + +static efi_char16_t *coreboot_cfr_efi_name(const char *name) +{ + size_t len, i; + + len =3D strlen(name); + if (len >=3D EFI_VAR_NAME_LEN) + return ERR_PTR(-ENAMETOOLONG); + + efi_char16_t *efi_name __free(kfree) =3D + kcalloc(len + 1, sizeof(*efi_name), GFP_KERNEL); + if (!efi_name) + return ERR_PTR(-ENOMEM); + + for (i =3D 0; i < len; i++) { + if (!isascii(name[i])) + return ERR_PTR(-EINVAL); + efi_name[i] =3D name[i]; + } + + return no_free_ptr(efi_name); +} + +/* Caller must hold the efivar lock. */ +static int coreboot_cfr_read_efi_value(efi_char16_t *efi_name, u32 *value, + u32 *attrs) +{ + unsigned long size =3D sizeof(__le32); + efi_status_t status; + __le32 data; + u32 attr; + + status =3D efivar_get_variable(efi_name, &coreboot_cfr_guid, &attr, + &size, &data); + if (status !=3D EFI_SUCCESS) + return efi_status_to_err(status); + + if (size !=3D sizeof(data)) + return -EINVAL; + + if (!(attr & EFI_VARIABLE_RUNTIME_ACCESS)) + return -EOPNOTSUPP; + + *value =3D le32_to_cpu(data); + if (attrs) + *attrs =3D attr; + + return 0; +} + +static int coreboot_cfr_read_value(const struct coreboot_cfr_setting *sett= ing, + u32 *value, u32 *attrs) +{ + efi_char16_t *efi_name __free(kfree) =3D + coreboot_cfr_efi_name(setting->name); + int ret; + + if (IS_ERR(efi_name)) + return PTR_ERR(no_free_ptr(efi_name)); + + ret =3D efivar_lock(); + if (ret) + return ret; + + ret =3D coreboot_cfr_read_efi_value(efi_name, value, attrs); + efivar_unlock(); + + return ret; +} + +/* Caller must hold the efivar lock. */ +static int coreboot_cfr_write_efi_value(efi_char16_t *efi_name, u32 value, + u32 attrs) +{ + efi_status_t status; + __le32 data; + + if (!efivar_supports_writes()) + return -EROFS; + + data =3D cpu_to_le32(value); + status =3D efivar_set_variable_locked(efi_name, &coreboot_cfr_guid, attrs, + sizeof(data), &data, false); + if (status !=3D EFI_SUCCESS) + return efi_status_to_err(status); + + return 0; +} + +static int coreboot_cfr_apply_runtime(struct coreboot_cfr_setting *setting) +{ + u8 status; + + if (setting->runtime_apply_method !=3D CFR_RUNTIME_APPLY_APM_CNT) + return -EOPNOTSUPP; + + outb((u8)setting->runtime_apply_id, COREBOOT_CFR_APM_STS_PORT); + outb(COREBOOT_CFR_APM_APPLY_CMD, COREBOOT_CFR_APM_CNT_PORT); + status =3D inb(COREBOOT_CFR_APM_STS_PORT); + if (status) + return -EIO; + + return 0; +} + +static int coreboot_cfr_write_value(struct coreboot_cfr_setting *setting, + u32 value) +{ + efi_char16_t *efi_name; + u32 attrs; + u32 old; + int restore_ret; + int ret; + + if (setting->read_only) + return -EACCES; + + efi_name =3D coreboot_cfr_efi_name(setting->name); + if (IS_ERR(efi_name)) + return PTR_ERR(efi_name); + + mutex_lock(&setting->drvdata->lock); + + ret =3D efivar_lock(); + if (ret) + goto out_unlock_mutex; + + ret =3D coreboot_cfr_read_efi_value(efi_name, &old, &attrs); + if (ret) + goto out_unlock_efi; + + if ((attrs & COREBOOT_CFR_EFI_ATTRS) !=3D COREBOOT_CFR_EFI_ATTRS) { + ret =3D -EOPNOTSUPP; + goto out_unlock_efi; + } + + if (old =3D=3D value) + goto out_unlock_efi; + + ret =3D coreboot_cfr_write_efi_value(efi_name, value, attrs); + if (ret) + goto out_unlock_efi; + + ret =3D coreboot_cfr_apply_runtime(setting); + if (ret =3D=3D -EOPNOTSUPP) { + /* EFI changed; firmware will consume it after reboot. */ + setting->drvdata->pending_reboot =3D true; + ret =3D 0; + } else if (ret) { + restore_ret =3D coreboot_cfr_write_efi_value(efi_name, old, attrs); + if (restore_ret) { + setting->drvdata->pending_reboot =3D true; + ret =3D restore_ret; + } else { + goto out_unlock_efi; + } + } + + efivar_unlock(); + kobject_uevent(&setting->drvdata->class_dev->kobj, KOBJ_CHANGE); + mutex_unlock(&setting->drvdata->lock); + kfree(efi_name); + return ret; + +out_unlock_efi: + efivar_unlock(); +out_unlock_mutex: + mutex_unlock(&setting->drvdata->lock); + kfree(efi_name); + return ret; +} + +static const char * +coreboot_cfr_label_from_value(const struct coreboot_cfr_setting *setting, + u32 value) +{ + unsigned int i; + + for (i =3D 0; i < setting->n_values; i++) { + if (setting->values[i].value =3D=3D value) + return setting->values[i].label; + } + + return NULL; +} + +static int coreboot_cfr_parse_value(struct coreboot_cfr_setting *setting, + const char *label, u32 *value_out) +{ + unsigned int i; + + for (i =3D 0; i < setting->n_values; i++) { + if (!sysfs_streq(label, setting->values[i].label)) + continue; + + *value_out =3D setting->values[i].value; + return 0; + } + + return kstrtou32(label, 0, value_out); +} + +static bool coreboot_cfr_value_is_valid(struct coreboot_cfr_setting *setti= ng, + u32 value) +{ + u32 delta; + + if (setting->type !=3D COREBOOT_CFR_SETTING_NUMBER) { + /* Enum and bool values are valid only if they have a label. */ + return coreboot_cfr_label_from_value(setting, value); + } + + if (value < setting->min || value > setting->max) + return false; + + if (!setting->step) + return true; + + delta =3D value - setting->min; + return delta % setting->step =3D=3D 0; +} + +static ssize_t type_show(struct kobject *kobj, struct kobj_attribute *attr, + char *buf) +{ + struct coreboot_cfr_setting *setting =3D to_coreboot_cfr_setting(kobj); + + if (setting->type =3D=3D COREBOOT_CFR_SETTING_NUMBER) + return sysfs_emit(buf, "integer\n"); + + return sysfs_emit(buf, "enumeration\n"); +} + +static ssize_t display_name_language_code_show(struct kobject *kobj, + struct kobj_attribute *attr, + char *buf) +{ + return sysfs_emit(buf, "en_US.UTF-8\n"); +} + +static ssize_t display_name_show(struct kobject *kobj, + struct kobj_attribute *attr, char *buf) +{ + struct coreboot_cfr_setting *setting =3D to_coreboot_cfr_setting(kobj); + + return sysfs_emit(buf, "%s\n", setting->display_name); +} + +static ssize_t possible_values_show(struct kobject *kobj, + struct kobj_attribute *attr, char *buf) +{ + struct coreboot_cfr_setting *setting =3D to_coreboot_cfr_setting(kobj); + ssize_t len =3D 0; + unsigned int i; + + for (i =3D 0; i < setting->n_values; i++) { + len +=3D sysfs_emit_at(buf, len, "%s%s", i ? ";" : "", + setting->values[i].label); + } + + len +=3D sysfs_emit_at(buf, len, "\n"); + return len; +} + +static ssize_t min_value_show(struct kobject *kobj, struct kobj_attribute = *attr, + char *buf) +{ + struct coreboot_cfr_setting *setting =3D to_coreboot_cfr_setting(kobj); + + return sysfs_emit(buf, "%u\n", setting->min); +} + +static ssize_t max_value_show(struct kobject *kobj, struct kobj_attribute = *attr, + char *buf) +{ + struct coreboot_cfr_setting *setting =3D to_coreboot_cfr_setting(kobj); + + return sysfs_emit(buf, "%u\n", setting->max); +} + +static ssize_t scalar_increment_show(struct kobject *kobj, + struct kobj_attribute *attr, char *buf) +{ + struct coreboot_cfr_setting *setting =3D to_coreboot_cfr_setting(kobj); + + return sysfs_emit(buf, "%u\n", setting->step); +} + +static ssize_t default_value_show(struct kobject *kobj, + struct kobj_attribute *attr, char *buf) +{ + struct coreboot_cfr_setting *setting =3D to_coreboot_cfr_setting(kobj); + const char *label; + + if (setting->type =3D=3D COREBOOT_CFR_SETTING_NUMBER) + return sysfs_emit(buf, "%u\n", setting->default_value); + + label =3D coreboot_cfr_label_from_value(setting, setting->default_value); + if (!label) + return sysfs_emit(buf, "%u\n", setting->default_value); + + return sysfs_emit(buf, "%s\n", label); +} + +static ssize_t current_value_show(struct kobject *kobj, + struct kobj_attribute *attr, char *buf) +{ + struct coreboot_cfr_setting *setting =3D to_coreboot_cfr_setting(kobj); + const char *label; + u32 value; + int ret; + + ret =3D coreboot_cfr_read_value(setting, &value, NULL); + if (ret) + return ret; + + if (setting->type =3D=3D COREBOOT_CFR_SETTING_NUMBER) + return sysfs_emit(buf, "%u\n", value); + + label =3D coreboot_cfr_label_from_value(setting, value); + if (!label) + return -EINVAL; + + return sysfs_emit(buf, "%s\n", label); +} + +static ssize_t current_value_store(struct kobject *kobj, + struct kobj_attribute *attr, + const char *buf, size_t count) +{ + struct coreboot_cfr_setting *setting =3D to_coreboot_cfr_setting(kobj); + u32 value; + int ret; + + ret =3D coreboot_cfr_parse_value(setting, buf, &value); + if (ret) + return ret; + + if (!coreboot_cfr_value_is_valid(setting, value)) + return -EINVAL; + + ret =3D coreboot_cfr_write_value(setting, value); + if (ret) + return ret; + + return count; +} + +static struct kobj_attribute type_attr =3D __ATTR_RO(type); +static struct kobj_attribute display_name_language_code_attr =3D + __ATTR_RO(display_name_language_code); +static struct kobj_attribute display_name_attr =3D __ATTR_RO(display_name); +static struct kobj_attribute possible_values_attr =3D __ATTR_RO(possible_v= alues); +static struct kobj_attribute min_value_attr =3D __ATTR_RO(min_value); +static struct kobj_attribute max_value_attr =3D __ATTR_RO(max_value); +static struct kobj_attribute scalar_increment_attr =3D __ATTR_RO(scalar_in= crement); +static struct kobj_attribute default_value_attr =3D __ATTR_RO(default_valu= e); +static struct kobj_attribute current_value_attr =3D __ATTR_RW(current_valu= e); + +static struct attribute *coreboot_cfr_setting_attrs[] =3D { + &type_attr.attr, + &display_name_language_code_attr.attr, + &display_name_attr.attr, + &possible_values_attr.attr, + &min_value_attr.attr, + &max_value_attr.attr, + &scalar_increment_attr.attr, + &default_value_attr.attr, + ¤t_value_attr.attr, + NULL, +}; + +static umode_t coreboot_cfr_attr_is_visible(struct kobject *kobj, + struct attribute *attr, int n) +{ + struct coreboot_cfr_setting *setting =3D to_coreboot_cfr_setting(kobj); + + if (setting->type =3D=3D COREBOOT_CFR_SETTING_NUMBER && + attr =3D=3D &possible_values_attr.attr) + return 0; + + if (setting->type !=3D COREBOOT_CFR_SETTING_NUMBER && + (attr =3D=3D &min_value_attr.attr || attr =3D=3D &max_value_attr.attr= || + attr =3D=3D &scalar_increment_attr.attr)) + return 0; + + if (setting->read_only && attr =3D=3D ¤t_value_attr.attr) + return 0444; + + return attr->mode; +} + +static const struct attribute_group coreboot_cfr_setting_group =3D { + .attrs =3D coreboot_cfr_setting_attrs, + .is_visible =3D coreboot_cfr_attr_is_visible, +}; + +static void coreboot_cfr_free_setting(struct coreboot_cfr_setting *setting) +{ + unsigned int i; + + for (i =3D 0; i < setting->n_values; i++) + kfree(setting->values[i].label); + + kfree(setting->values); + kfree(setting->display_name); + kfree(setting->name); + kfree(setting); +} + +static void coreboot_cfr_setting_release(struct kobject *kobj) +{ + coreboot_cfr_free_setting(to_coreboot_cfr_setting(kobj)); +} + +static const struct kobj_type coreboot_cfr_setting_ktype =3D { + .release =3D coreboot_cfr_setting_release, + .sysfs_ops =3D &kobj_sysfs_ops, +}; + +static ssize_t pending_reboot_show(struct kobject *kobj, + struct kobj_attribute *attr, char *buf) +{ + struct device *dev =3D kobj_to_dev(kobj->parent); + struct coreboot_cfr_drvdata *data; + + data =3D dev_get_drvdata(dev); + + return sysfs_emit(buf, "%d\n", data->pending_reboot); +} + +static struct kobj_attribute pending_reboot_attr =3D __ATTR_RO(pending_reb= oot); + +static int coreboot_cfr_copy_bool_values(struct coreboot_cfr_setting *sett= ing) +{ + static const struct coreboot_cfr_enum bool_values[] =3D { + { .label =3D "Disabled", .value =3D 0 }, + { .label =3D "Enabled", .value =3D 1 }, + }; + unsigned int i; + + setting->values =3D kcalloc(ARRAY_SIZE(bool_values), sizeof(*setting->val= ues), + GFP_KERNEL); + if (!setting->values) + return -ENOMEM; + + for (i =3D 0; i < ARRAY_SIZE(bool_values); i++) { + setting->values[i].label =3D kstrdup(bool_values[i].label, + GFP_KERNEL); + if (!setting->values[i].label) + return -ENOMEM; + setting->values[i].value =3D bool_values[i].value; + setting->n_values++; + } + + return 0; +} + +static int coreboot_cfr_count_enum_values(const void *base, size_t len) +{ + struct coreboot_cfr_iterator iterator =3D { + .cursor =3D base, + .remaining =3D len, + }; + const struct coreboot_table_entry *entry; + int count =3D 0; + + for (;;) { + entry =3D coreboot_cfr_next_entry(&iterator); + if (IS_ERR(entry)) + return PTR_ERR(entry); + if (!entry) + return count; + + if (entry->tag =3D=3D CFR_TAG_ENUM_VALUE) + count++; + } +} + +static int coreboot_cfr_copy_enum_values(struct coreboot_cfr_setting *sett= ing, + const void *base, size_t len) +{ + struct coreboot_cfr_iterator iterator =3D { + .cursor =3D base, + .remaining =3D len, + }; + const struct lb_cfr_enum_value *enum_value; + const struct lb_cfr_varbinary *label; + const struct coreboot_table_entry *entry; + struct coreboot_cfr_enum *value; + int count; + + count =3D coreboot_cfr_count_enum_values(base, len); + if (count <=3D 0) + return count ?: -EINVAL; + + setting->values =3D kcalloc(count, sizeof(*setting->values), GFP_KERNEL); + if (!setting->values) + return -ENOMEM; + + for (;;) { + entry =3D coreboot_cfr_next_entry(&iterator); + if (IS_ERR(entry)) + return PTR_ERR(entry); + if (!entry) + return 0; + + if (entry->tag !=3D CFR_TAG_ENUM_VALUE) + continue; + + if (entry->size < sizeof(*enum_value)) + return -EINVAL; + + enum_value =3D (const struct lb_cfr_enum_value *)entry; + label =3D coreboot_cfr_child_string(enum_value + 1, + enum_value->size - sizeof(*enum_value), + CFR_TAG_VARCHAR_UI_NAME); + if (IS_ERR(label)) + return PTR_ERR(label); + if (!label) + return -EINVAL; + + value =3D &setting->values[setting->n_values]; + value->label =3D coreboot_cfr_string_dup(label); + if (!value->label) + return -ENOMEM; + if (!coreboot_cfr_string_is_valid_label(value->label)) { + kfree(value->label); + value->label =3D NULL; + return -EINVAL; + } + + value->value =3D enum_value->value; + setting->n_values++; + } +} + +static bool +coreboot_cfr_possible_values_fit(const struct coreboot_cfr_setting *settin= g) +{ + size_t len =3D 1; /* Trailing newline. */ + size_t label_len; + unsigned int i; + + for (i =3D 0; i < setting->n_values; i++) { + if (len >=3D PAGE_SIZE) + return false; + + if (i) + len++; + + label_len =3D strlen(setting->values[i].label); + if (label_len >=3D PAGE_SIZE - len) + return false; + + len +=3D label_len; + } + + return true; +} + +static int coreboot_cfr_setting_is_usable(struct coreboot_cfr_setting *set= ting) +{ + u32 value; + int ret; + + ret =3D coreboot_cfr_read_value(setting, &value, NULL); + if (ret) + return ret; + + if (!coreboot_cfr_value_is_valid(setting, value)) + return -EINVAL; + + return 0; +} + +static int coreboot_cfr_register_setting(struct coreboot_cfr_drvdata *data, + struct coreboot_cfr_setting *setting) +{ + int ret; + + ret =3D kobject_init_and_add(&setting->kobj, &coreboot_cfr_setting_ktype, + &data->attrs_kset->kobj, "%s", setting->name); + if (ret) + goto err_put_kobj; + + ret =3D sysfs_create_group(&setting->kobj, &coreboot_cfr_setting_group); + if (ret) + goto err_put_kobj; + + list_add_tail(&setting->node, &data->settings); + return 0; + +err_put_kobj: + kobject_put(&setting->kobj); + return ret; +} + +static int coreboot_cfr_add_numeric_option(struct coreboot_cfr_drvdata *da= ta, + const struct lb_cfr_numeric_option *option, + bool parent_read_only) +{ + const struct lb_cfr_varbinary *name; + const struct lb_cfr_varbinary *display_name; + const struct lb_cfr_runtime_apply *runtime_apply; + const void *child_base =3D option + 1; + struct coreboot_cfr_setting *setting; + size_t child_len =3D option->size - sizeof(*option); + int ret; + + if (!(option->flags & CFR_OPTFLAG_RUNTIME)) + return 0; + + if (option->flags & COREBOOT_CFR_OPT_SKIP_FLAGS) + return 0; + + if (option->dependency_id) + return 0; + + setting =3D kzalloc_obj(*setting, GFP_KERNEL); + if (!setting) + return -ENOMEM; + + INIT_LIST_HEAD(&setting->node); + setting->drvdata =3D data; + setting->default_value =3D option->default_value; + setting->min =3D option->min; + setting->max =3D option->max; + setting->step =3D option->step ?: 1; + setting->read_only =3D + (option->flags & COREBOOT_CFR_OPT_READ_ONLY_FLAGS) || + !data->efi_writes_supported || parent_read_only; + + runtime_apply =3D coreboot_cfr_child_runtime_apply(child_base, child_len); + if (IS_ERR(runtime_apply)) { + ret =3D PTR_ERR(runtime_apply); + goto err_put_setting; + } + + if (runtime_apply && runtime_apply->method =3D=3D CFR_RUNTIME_APPLY_APM_C= NT) { + setting->runtime_apply_method =3D runtime_apply->method; + setting->runtime_apply_id =3D runtime_apply->id; + } + + name =3D coreboot_cfr_child_string(child_base, child_len, + CFR_TAG_VARCHAR_OPT_NAME); + if (IS_ERR(name)) { + ret =3D PTR_ERR(name); + goto err_put_setting; + } + if (!name) { + ret =3D -EINVAL; + goto err_put_setting; + } + + setting->name =3D coreboot_cfr_string_dup(name); + if (!setting->name) { + ret =3D -ENOMEM; + goto err_put_setting; + } + + if (!coreboot_cfr_string_is_valid_name(setting->name)) { + ret =3D -EINVAL; + goto err_put_setting; + } + + display_name =3D coreboot_cfr_child_string(child_base, child_len, + CFR_TAG_VARCHAR_UI_NAME); + if (IS_ERR(display_name)) { + ret =3D PTR_ERR(display_name); + goto err_put_setting; + } + if (display_name) + setting->display_name =3D coreboot_cfr_string_dup(display_name); + else + setting->display_name =3D kstrdup(setting->name, GFP_KERNEL); + if (!setting->display_name) { + ret =3D -ENOMEM; + goto err_put_setting; + } + + switch (option->tag) { + case CFR_TAG_OPTION_BOOL: + setting->type =3D COREBOOT_CFR_SETTING_BOOL; + setting->min =3D 0; + setting->max =3D 1; + setting->step =3D 1; + ret =3D coreboot_cfr_copy_bool_values(setting); + break; + case CFR_TAG_OPTION_ENUM: + setting->type =3D COREBOOT_CFR_SETTING_ENUM; + ret =3D coreboot_cfr_copy_enum_values(setting, child_base, + child_len); + break; + case CFR_TAG_OPTION_NUMBER: + setting->type =3D COREBOOT_CFR_SETTING_NUMBER; + if (setting->max < setting->min) + ret =3D -EINVAL; + else + ret =3D 0; + break; + default: + ret =3D -EINVAL; + break; + } + + if (ret) + goto err_put_setting; + /* possible_values must be returned completely in one sysfs read. */ + if (setting->type !=3D COREBOOT_CFR_SETTING_NUMBER && + !coreboot_cfr_possible_values_fit(setting)) { + ret =3D 0; + goto err_put_setting; + } + + ret =3D coreboot_cfr_setting_is_usable(setting); + if (ret) { + /* + * CFR may describe options without a matching, readable runtime + * EFI variable. Skip those, but propagate transient EFI failures. + */ + if (ret =3D=3D -ENOENT || ret =3D=3D -EINVAL || ret =3D=3D -EOPNOTSUPP || + ret =3D=3D -ENAMETOOLONG) + ret =3D 0; + goto err_put_setting; + } + + /* The kobject release callback owns setting after this call. */ + return coreboot_cfr_register_setting(data, setting); + +err_put_setting: + coreboot_cfr_free_setting(setting); + return ret; +} + +static int coreboot_cfr_parse_records(struct coreboot_cfr_drvdata *data, + const void *base, size_t len, + unsigned int depth, + bool parent_read_only) +{ + struct coreboot_cfr_iterator iterator =3D { + .cursor =3D base, + .remaining =3D len, + }; + const struct lb_cfr_option_form *form; + const struct lb_cfr_numeric_option *option; + const struct coreboot_table_entry *entry; + const void *child_base; + size_t child_len; + int ret; + + for (;;) { + entry =3D coreboot_cfr_next_entry(&iterator); + if (IS_ERR(entry)) + return PTR_ERR(entry); + if (!entry) + return 0; + + switch (entry->tag) { + case CFR_TAG_OPTION_FORM: + if (entry->size < sizeof(struct lb_cfr_option_form)) + return -EINVAL; + + form =3D (const struct lb_cfr_option_form *)entry; + if (form->dependency_id || + form->flags & CFR_OPTFLAG_SUPPRESS) + break; + + if (depth >=3D COREBOOT_CFR_MAX_FORM_DEPTH) + return -E2BIG; + + child_base =3D form + 1; + child_len =3D entry->size - sizeof(struct lb_cfr_option_form); + ret =3D coreboot_cfr_parse_records(data, child_base, + child_len, depth + 1, + parent_read_only || + (form->flags & + COREBOOT_CFR_OPT_READ_ONLY_FLAGS)); + if (ret) + return ret; + break; + case CFR_TAG_OPTION_ENUM: + case CFR_TAG_OPTION_NUMBER: + case CFR_TAG_OPTION_BOOL: + option =3D (const struct lb_cfr_numeric_option *)entry; + if (entry->size < sizeof(*option)) + return -EINVAL; + ret =3D coreboot_cfr_add_numeric_option(data, option, + parent_read_only); + if (ret) + return ret; + break; + default: + /* Ignore unsupported, child-only and future record types. */ + break; + } + } +} + +static void coreboot_cfr_unregister_settings(struct coreboot_cfr_drvdata *= data) +{ + struct coreboot_cfr_setting *setting, *tmp; + + list_for_each_entry_safe(setting, tmp, &data->settings, node) { + sysfs_remove_group(&setting->kobj, &coreboot_cfr_setting_group); + list_del(&setting->node); + kobject_put(&setting->kobj); + } +} + +static int coreboot_cfr_probe(struct coreboot_device *dev) +{ + const struct lb_cfr *root =3D (const struct lb_cfr *)dev->raw; + struct coreboot_cfr_drvdata *data; + size_t payload_len; + int ret; + + if (dev->entry.size < sizeof(*root)) + return -EINVAL; + + if (root->tag !=3D LB_TAG_CFR_ROOT || root->version !=3D CFR_VERSION) + return -EINVAL; + + if (root->size < sizeof(*root) || root->size > dev->entry.size) + return -EINVAL; + + payload_len =3D root->size - sizeof(*root); + if (crc32_be(0, root + 1, payload_len) !=3D root->checksum) + return -EBADMSG; + + if (!efivar_is_available()) + return -EPROBE_DEFER; + + data =3D devm_kzalloc(&dev->dev, sizeof(*data), GFP_KERNEL); + if (!data) + return -ENOMEM; + + ret =3D efivar_lock(); + if (ret) + return ret; + data->efi_writes_supported =3D efivar_supports_writes(); + efivar_unlock(); + + INIT_LIST_HEAD(&data->settings); + ret =3D devm_mutex_init(&dev->dev, &data->lock); + if (ret) + return ret; + + dev_set_drvdata(&dev->dev, data); + + data->class_dev =3D device_create(&firmware_attributes_class, NULL, + MKDEV(0, 0), NULL, DRIVER_NAME); + if (IS_ERR(data->class_dev)) + return PTR_ERR(data->class_dev); + dev_set_drvdata(data->class_dev, data); + + data->attrs_kset =3D kset_create_and_add("attributes", NULL, + &data->class_dev->kobj); + if (!data->attrs_kset) { + ret =3D -ENOMEM; + goto err_unregister_dev; + } + + ret =3D sysfs_create_file(&data->attrs_kset->kobj, + &pending_reboot_attr.attr); + if (ret) + goto err_unregister_attrs; + + ret =3D coreboot_cfr_parse_records(data, root + 1, payload_len, 0, false); + if (ret) + goto err_unregister_settings; + + if (list_empty(&data->settings)) { + ret =3D -ENODEV; + goto err_unregister_settings; + } + + return 0; + +err_unregister_settings: + coreboot_cfr_unregister_settings(data); + sysfs_remove_file(&data->attrs_kset->kobj, &pending_reboot_attr.attr); +err_unregister_attrs: + kset_unregister(data->attrs_kset); +err_unregister_dev: + device_unregister(data->class_dev); + return ret; +} + +static void coreboot_cfr_remove(struct coreboot_device *dev) +{ + struct coreboot_cfr_drvdata *data =3D dev_get_drvdata(&dev->dev); + + coreboot_cfr_unregister_settings(data); + sysfs_remove_file(&data->attrs_kset->kobj, &pending_reboot_attr.attr); + kset_unregister(data->attrs_kset); + device_unregister(data->class_dev); +} + +static const struct coreboot_device_id coreboot_cfr_ids[] =3D { + { .tag =3D LB_TAG_CFR_ROOT }, + { } +}; +MODULE_DEVICE_TABLE(coreboot, coreboot_cfr_ids); + +static struct coreboot_driver coreboot_cfr_driver =3D { + .probe =3D coreboot_cfr_probe, + .remove =3D coreboot_cfr_remove, + .drv =3D { + .name =3D DRIVER_NAME, + }, + .id_table =3D coreboot_cfr_ids, +}; +module_coreboot_driver(coreboot_cfr_driver); + +MODULE_AUTHOR("Sean Rhodes "); +MODULE_DESCRIPTION("coreboot CFR firmware attributes driver"); +MODULE_LICENSE("GPL"); +MODULE_IMPORT_NS("EFIVAR"); From nobody Sat Sep 19 05:58:33 2026 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 334FE48F83F for ; Tue, 1 Sep 2026 17:48:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788284901; cv=none; b=W0QhOh2U7fRmULJuPPIilk0yzI5JFT/hM+oUVuRcMu2Ki4OxwEcLi7v1VYkSn+2Kpfy8mUcwtLbRHYvPJlRDBkSkWtZLnf6l5+CWjsFWZbVtvl0nYG927o3my27Ra8+Nx/qzkeE4UvRtRxJxEJkfrn0jBH24jZSdY+IHZ1jo7NU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788284901; c=relaxed/simple; bh=2Ybla6Y62reZI1CmxWmKc144ZA3IjT4POIfUXQKsL2w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dre7VfTbYdFoFYjGkEeG4icdPebtK37NambXh+Ci4azO78Xvl8rir3PzXnX7ygxAHX4+CmjL4rWDYhWJOD8plb3MjqAz8g7Ckhfgf+avs2I+lTVUUG8p0I3QC5RuwHDDdvOt9DKW3/eWdIbFmsU6aoyB66tFiWP9hDFYDVY232U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=starlabs.systems; spf=pass smtp.mailfrom=starlabs.systems; dkim=pass (2048-bit key) header.d=starlabs-systems.20251104.gappssmtp.com header.i=@starlabs-systems.20251104.gappssmtp.com header.b=jfMK/TqO; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=starlabs.systems Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=starlabs.systems Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=starlabs-systems.20251104.gappssmtp.com header.i=@starlabs-systems.20251104.gappssmtp.com header.b="jfMK/TqO" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-49954b88fffso480185e9.0 for ; Tue, 01 Sep 2026 10:48:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=starlabs-systems.20251104.gappssmtp.com; s=20251104; t=1788284896; x=1788889696; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=2Ybla6Y62reZI1CmxWmKc144ZA3IjT4POIfUXQKsL2w=; b=jfMK/TqO2Gy8jVCaZGO6zzzIHtMXpYCU8aZyPg2hoUVh8K90PDjI44DpplArnwSORZ /7rsbUnf415ojs2IIswTHrEVDTidjI7MBS9SUr2BP1Vq407nvY94H4kTLOiWxTReO5F3 qeg4nz5hXI71cGPEmh00Nf7KBD1o866Vz2xSv2l/I8y9gdVy4AOO27GOPMACDdASe7Q4 myyH9f5z7diRwLcBP/oy/H1TGc0CLBnd40axOJmZ+MD8VQwH5YJ5JXo90nYKMVigwl3n H7A+nJNK4F3r5VZVjf4qlJ2dA+v7SLD98fZKT6eUK4xPa/zOvHqqT8UwnxV2Hi9if0Ky DUNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788284896; x=1788889696; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=2Ybla6Y62reZI1CmxWmKc144ZA3IjT4POIfUXQKsL2w=; b=EmraMTP0Hx1rbwS4JHwrPzAPiHO0h8Xgv+IjThS/rJiBAiIDCrO+a8dvuWxpJ1/WyY 5/Y4aipHvkVemskiEuflOcs1IFdeE72R78rxAphgQtVuebTI4gZYpvwMhdAobYk4QsTY CZYXn8UoArDtz1O4RxNtIIFCb8dLMW1gMEaHN6TW6//eyTnPkVjhatmp4Jg1oMHFIDnJ CUhZt7V47BEByibyuu+yq9udqJiG8lcOW/fZWZbsQdOSlZ8yoBmUjiXapwsNjQFn50qa HVMVnhV1/DbCX0vOogQ46yeIW3hFiUmE+Jc7DRDPj110ciRe2My5aWpJgnT4EfGYKhio EMhw== X-Gm-Message-State: AFuF++kei6o5vcZ2BHnJTxnvigjBORxSfAihyDxf8gcvAfP1YsdWen9t RH/3tRuP9BlACbYqfN7tF9o+jxKH0vMF5BYH8O+ilyy4qhRzcYvpgUHgBSFTJSpp+XGfcWgUr3p i22/CE1Ug X-Gm-Gg: AR+sD11+mNOIcb5kbqijIxrZNmUzC0X6NrU9pUMgJS/VplDktF84z2CMUwdbTIF0bU+ wuoQrXbp726GkACQ4QlsJCQPw7htqC0IzEY3UYscza+GM6EFEsd6uH70xMiJQ8QDDyiotNiq8s2 ZKnSYWIIpJdAPxWjhp5yLMSEFk6+Np6OCCnx3pwPBZIVk1lXOLX3s0kzLle2DTNbVEhfZnVaLqw HisO2fg1jc1j9wi8QQE1G3ihrI/HQhXSZ1P8dLbwYVMyvl64vlNmDhBLuylhMT/lOaN8ePky0yB zTJfjbZ/aCRB1eiKhzv7nfBI2Jgtn8BExCnkcZVGUwtf7VW7pkxA3fHh+05il1dx4YcXNs1fUQn /XLGR8lBDm0m+u9yNKUEM/7/yTOG/5wSzYyUUQrwK/utm6nSRGHXLKxrhTl9CBY20dvChnEMh4l OQSe3D4ISskpaF1tkl+4vxL1grw1ZfeJZpHCk0KtOf47bph3n3b7obfZPjuMf1BtwB4Rmm19KdH uxq8N9jO89yguvOOEsDVVmYrg== X-Received: by 2002:a05:600c:8107:b0:49c:d26a:cf70 with SMTP id 5b1f17b1804b1-49cd26ad005mr380287175e9.15.1788284896231; Tue, 01 Sep 2026 10:48:16 -0700 (PDT) Received: from horizon ([217.155.46.38]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49ce47885b1sm2369225e9.14.2026.09.01.10.48.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Sep 2026 10:48:15 -0700 (PDT) From: Sean Rhodes To: linux-kernel@vger.kernel.org Cc: Hans de Goede , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , Corentin Chary , "Luke D. Jones" , Denis Benato , Prasanth Ksr , Jorge Lopez , Mark Pearson , "Derek J. Clark" , Joshua Grisham , Will Deacon , Douglas Anderson , "Kiryl Shutsemau (Meta)" , Sean Rhodes , Huacai Chen , Chen-Yu Tsai , Thomas Zimmermann , platform-driver-x86@vger.kernel.org, Dell.Client.Kernel@dell.com, Tzung-Bi Shih , Brian Norris , Julius Werner , Javier Martinez Canillas , Bjorn Helgaas , Danilo Krummrich , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig=20=28The=20Capable=20Hub=29?= , Titouan Ameline de Cadeville , Laxman Acharya Padhya , Yidi Lin , Kees Cook , Takashi Sakamoto , chrome-platform@lists.linux.dev, Maarten Lankhorst , Maxime Ripard , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, Krzysztof Kozlowski , Bjorn Andersson , Dmitry Baryshkov , Geert Uytterhoeven , Arnd Bergmann , Eric Biggers , Luca Weiss , Michal Simek , Sven Peter , Alexandre Belloni , Linus Walleij , Drew Fustini , linux-arm-kernel@lists.infradead.org, soc@lists.linux.dev Subject: [PATCH v14 5/5] arm64: defconfig: Update coreboot firmware symbols Date: Tue, 1 Sep 2026 18:48:06 +0100 Message-ID: <72952b598bd73ca282026139e4a1db7af89c30ba.1788284852.git.sean@starlabs.systems> X-Mailer: git-send-email 2.53.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The generic coreboot firmware Kconfig symbols were renamed from CONFIG_GOOGLE_* to CONFIG_COREBOOT_* while keeping the old names as transitional compatibility symbols. Select the new names directly in the arm64 defconfig so the checked-in defconfig follows the visible Kconfig symbols. Keep this separate from the rename patch so the configuration churn is easy to review independently. Signed-off-by: Sean Rhodes --- arch/arm64/configs/defconfig | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index 6ec8d3a69c98..90a7b49d408b 100644 --- a/arch/arm64/configs/defconfig +++ b/arch/arm64/configs/defconfig @@ -267,9 +267,9 @@ CONFIG_RASPBERRYPI_FIRMWARE=3Dy CONFIG_INTEL_STRATIX10_SERVICE=3Dy CONFIG_INTEL_STRATIX10_RSU=3Dm CONFIG_MTK_ADSP_IPC=3Dm -CONFIG_GOOGLE_FIRMWARE=3Dy -CONFIG_GOOGLE_CBMEM=3Dm -CONFIG_GOOGLE_COREBOOT_TABLE=3Dm +CONFIG_COREBOOT_FIRMWARE=3Dy +CONFIG_COREBOOT_CBMEM=3Dm +CONFIG_COREBOOT_TABLE=3Dm CONFIG_EFI_CAPSULE_LOADER=3Dy CONFIG_IMX_SCU=3Dy CONFIG_QCOM_TZMEM_MODE_SHMBRIDGE=3Dy