From nobody Mon Sep 28 06:32:04 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C443E45D1A4 for ; Tue, 25 Aug 2026 14:19:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787667595; cv=none; b=M3aWtSUGI/VRg999fkBFJ9fWYhYKCer6qYHlv7igGuEALNJIgPtJLQHOgFOM/9NqCyLTL6SmiJ1Qj1kAWB08175n/UEU1/K8Y0HdQTWQ18H+iq0o0GeIkS6ZFJCZtolzL9R6qmEeY83lWan/pfbnU3WAESqAeYaFqfdMbk10IDA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787667595; c=relaxed/simple; bh=5hUNZDQWKJpKHv9XdIuO3dKhDkzgrvKIiU+TlyvgRVU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=l5PuuCO6wPh+cCMFnNZ6ibFSn3RDRjcqp07yXBU6b3RwEfXJvK6/zjPL24gNlUCu1Wm6kPIIuhpW0kIi4HKt3GEOd9hc6+FrYNS1jS5J8FH+vuZ0ly1aQGpsiwF1wNCKMLrGBxjpKqUCxGISlseO25kyqnO8MOdQ5DSCTQV/rs0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=T8FH5/qA; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="T8FH5/qA" Received: by smtp.kernel.org (Postfix) with UTF8SMTPSA id DE74A1F000E9; Tue, 25 Aug 2026 14:19:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1787667594; bh=Xk0dNc7B36bwDKmRn5sL8ALUnv0/054lZYNtGFvdOpY=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=T8FH5/qAdqSaoDKKlg1O4VOOa89peEvvy+zljYLuWMBj6KoTlmU7+ZD2X0nEWDNzz NLAYF3dbezVhevy41KhV1TV9LMyWt5a6NlsiuksVIFsXTmpgAXFkQ7Y5NAmCe973+0 R3B428/U82AHynqe2e4xG7+XzQAhGpoX9OVXDeprunA4RwLnznqKaQv4X/2CwT+myJ NmFc4mqZQ6O0TVUQpLiluENK4ThWlgIWJSF0hno4b+4ASYJO/jfBnKD1S4gsWjMvmH 4Wu7P3OyeTv9YZSlThnX2A5P7ugzD0kmCIpsjTLLXbUSKrtDgj/KH1E++Af0rbgP6k a5TFXdVGtwBGA== From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Jassi Brar , Heiko Stuebner Cc: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Subject: [PATCH v1 1/3] mailbox: rockchip: Add a prefix for register defines Date: Tue, 25 Aug 2026 16:19:24 +0200 Message-ID: <2f057b0a7fdec721457962e0f1ca37b07e2b592c.1787667315.git.ukleinek@kernel.org> X-Mailer: git-send-email 2.55.0.11.g153666a7d9bb In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=3104; i=ukleinek@kernel.org; h=from:subject:message-id; bh=RMzhspIF+h3rHuDcRebgUTq0TyN/+X/y3aEHxu6zPE8=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBqjaR3yVdKAwmmTzuja8pG1pzDOzm2ZrxQm7tzY 5E7/VLaEkeJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCao2kdwAKCRCPgPtYfRL+ ThKvB/4nFnH4yltKXhUbewS1SoYJsI4JqtpGaeKg0bmkvJss++HQhjjEviTV6tX+PN80bmPpBbU PtcOd06OsihwXSpXxwCsRJ+5ZvV+oOnztCon1PTKQ4B/82v9F0ucMKCcH/+7EJdVEcbDWyCt5dq 8SCtCnSQdweUyI4vhsjj1tv70j2SkkXTUzC10xYgRV0/3sH3tMDuhDtgZG80yXpoTgKnoojfQqk pqVGO6ag+YVn/726w8KCB2XY0uckGxGduteZROn/Dz3d+BrJpO4HeN4tCorUIj7kIHlOz+J16Xv n9I0cPytuNTGtWyL9HTEFFyt6zBDrSdtIiyvVlezdQfjpjRy X-Developer-Key: i=ukleinek@kernel.org; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable From: Uwe Kleine-K=C3=B6nig This way the defines don't make the impression to be more generic than they actually are. Signed-off-by: Uwe Kleine-K=C3=B6nig --- drivers/mailbox/rockchip-mailbox.c | 29 +++++++++++++++-------------- 1 file changed, 15 insertions(+), 14 deletions(-) diff --git a/drivers/mailbox/rockchip-mailbox.c b/drivers/mailbox/rockchip-= mailbox.c index bc2f9dd798dd..7ebe5f0d0233 100644 --- a/drivers/mailbox/rockchip-mailbox.c +++ b/drivers/mailbox/rockchip-mailbox.c @@ -12,15 +12,15 @@ #include #include =20 -#define MAILBOX_A2B_INTEN 0x00 -#define MAILBOX_A2B_STATUS 0x04 -#define MAILBOX_A2B_CMD(x) (0x08 + (x) * 8) -#define MAILBOX_A2B_DAT(x) (0x0c + (x) * 8) +#define ROCKCHIP_MAILBOX_A2B_INTEN 0x00 +#define ROCKCHIP_MAILBOX_A2B_STATUS 0x04 +#define ROCKCHIP_MAILBOX_A2B_CMD(x) (0x08 + (x) * 8) +#define ROCKCHIP_MAILBOX_A2B_DAT(x) (0x0c + (x) * 8) =20 -#define MAILBOX_B2A_INTEN 0x28 -#define MAILBOX_B2A_STATUS 0x2C -#define MAILBOX_B2A_CMD(x) (0x30 + (x) * 8) -#define MAILBOX_B2A_DAT(x) (0x34 + (x) * 8) +#define ROCKCHIP_MAILBOX_B2A_INTEN 0x28 +#define ROCKCHIP_MAILBOX_B2A_STATUS 0x2C +#define ROCKCHIP_MAILBOX_B2A_CMD(x) (0x30 + (x) * 8) +#define ROCKCHIP_MAILBOX_B2A_DAT(x) (0x34 + (x) * 8) =20 struct rockchip_mbox_msg { u32 cmd; @@ -68,9 +68,10 @@ static int rockchip_mbox_send_data(struct mbox_chan *cha= n, void *data) =20 mb->chans[chans->idx].msg =3D msg; =20 - writel_relaxed(msg->cmd, mb->mbox_base + MAILBOX_A2B_CMD(chans->idx)); + writel_relaxed(msg->cmd, mb->mbox_base + + ROCKCHIP_MAILBOX_A2B_CMD(chans->idx)); writel_relaxed(msg->rx_size, mb->mbox_base + - MAILBOX_A2B_DAT(chans->idx)); + ROCKCHIP_MAILBOX_A2B_DAT(chans->idx)); =20 return 0; } @@ -81,7 +82,7 @@ static int rockchip_mbox_startup(struct mbox_chan *chan) =20 /* Enable all B2A interrupts */ writel_relaxed((1 << mb->mbox.num_chans) - 1, - mb->mbox_base + MAILBOX_B2A_INTEN); + mb->mbox_base + ROCKCHIP_MAILBOX_B2A_INTEN); =20 return 0; } @@ -92,7 +93,7 @@ static void rockchip_mbox_shutdown(struct mbox_chan *chan) struct rockchip_mbox_chan *chans =3D mb->chans; =20 /* Disable all B2A interrupts */ - writel_relaxed(0, mb->mbox_base + MAILBOX_B2A_INTEN); + writel_relaxed(0, mb->mbox_base + ROCKCHIP_MAILBOX_B2A_INTEN); =20 mb->chans[chans->idx].msg =3D NULL; } @@ -107,13 +108,13 @@ static irqreturn_t rockchip_mbox_irq(int irq, void *d= ev_id) { int idx; struct rockchip_mbox *mb =3D (struct rockchip_mbox *)dev_id; - u32 status =3D readl_relaxed(mb->mbox_base + MAILBOX_B2A_STATUS); + u32 status =3D readl_relaxed(mb->mbox_base + ROCKCHIP_MAILBOX_B2A_STATUS); =20 for (idx =3D 0; idx < mb->mbox.num_chans; idx++) { if ((status & (1 << idx)) && (irq =3D=3D mb->chans[idx].irq)) { /* Clear mbox interrupt */ writel_relaxed(1 << idx, - mb->mbox_base + MAILBOX_B2A_STATUS); + mb->mbox_base + ROCKCHIP_MAILBOX_B2A_STATUS); return IRQ_WAKE_THREAD; } } --=20 2.55.0.11.g153666a7d9bb From nobody Mon Sep 28 06:32:04 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A64E94499B3 for ; Tue, 25 Aug 2026 14:19:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787667598; cv=none; b=abiDzw5rPGvf+o0YrkCNyNKn5wtLJNjZNln5yYnyha2WbJUd6lEN4qSXesLSqs6SqebhZXQnA9mfCxDDB6vR8RpY0ngxSks0ydA38Tm3hzqZMcAEn4h0XLXTrIfY5Bgb09L9l0qm0sHZkq5rWbMcod1u5dD07NAiShr4hrKjcoI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787667598; c=relaxed/simple; bh=97XcOpDy/VcuFNmrauWOckST01s5EZgPVCifeWDNjis=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=R9Y6y7x0FZNfM8WsZ9aCVJVNPyT9YmyHTAB673qMiJXWnvcYAAfWsn6enGJ/lbemtjWTDwUFcNzD3CJnlWgHII8Zepy7EzPTXW1Zcd5P2is243wu32zYv14BFmGOx2BveJveiyh0vdwanactq+e9nNiLadA4OVLkl6RR3vRTI/o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=j6Gs4CUx; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="j6Gs4CUx" Received: by smtp.kernel.org (Postfix) with UTF8SMTPSA id 8260A1F000E9; Tue, 25 Aug 2026 14:19:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1787667597; bh=iyFnPxZUNik3tVvE8NS582frtpIcudnRJLt+tg4S4AQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=j6Gs4CUx9zGGfWkFL9kxN81oUxJi/3cZOKlbzN//vE56CYTE2qKC2azkTE0eVyxQU GHtOd79FNbwm1Cr2HUUyE6mTmGmnQ3b2BHPkWvTx3Vu9frpPWa4KuGAqQmKaSpZWCJ w33lJpC8zDjUt3jEE5WW2xJObtmynej9X8shk2Yi7AfzRujhWsGGVECLnx0KP0eGps SXZctug35HZuJhTd5ne/cibQAmWPenMzWhWbGxtd6XQWtAuez8S7ZckDNpQoWtuFls XnUQ2eiBF//Mct2UnZIj+WbAFGmziVum1FrEsb2BveH/sL3cwhpOjTBkH3B+2cQ+Kv rdMHshw80myHQ== From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Jassi Brar , Heiko Stuebner Cc: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Subject: [PATCH v1 2/3] mailbox: rockchip: Simplify device variant handling Date: Tue, 25 Aug 2026 16:19:25 +0200 Message-ID: X-Mailer: git-send-email 2.55.0.11.g153666a7d9bb In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=3432; i=ukleinek@kernel.org; h=from:subject:message-id; bh=pzggRP623iO5S7KrEPih5LAJb6wdzzDR+CfLkKw6td4=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBqjaR6Sf/Ve89FI/rGYndoGMR2iXbJ9E4otZ4vm ZSabc1AbiOJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCao2kegAKCRCPgPtYfRL+ TvTLCAC40D08o18ghprM8wNyi2PAJ30xapMGZU/kzhgWM39cp7F9mYbHpnEIicggOnepyJQP5wc G8zYKpjfe90Y7Y1MwITNPbslNV+/kRaS9JQYU38kRtCRDN8/81V3jJzDG+RonoTqLUdBgncdLYU 0lYsYfnhS5J3qC6sXFvbcUss4LoaOqXud5dBnmbx0191A4z4cW9MNrbIGxWItovFVzHnhBeMbRH xNhFUZnf8B73BGQ572vrBdz37A6f1wieWtYHX+QKcByDfrIWKODDcUGQUAaODjbOS1X3ARH54XE r5zBmAGrOLsNl+rJgvLXiaSwFQiZNeWDlKtQx/pE/RByXVW5 X-Developer-Key: i=ukleinek@kernel.org; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable From: Uwe Kleine-K=C3=B6nig There is only a single device variant. Let's not use multi-device abstraction for that but hardcode the information relevant for that single device type. Bloat-o-meter reports the following size reduction for an ARCH=3Darm64 build: add/remove: 0/1 grow/shrink: 0/1 up/down: 0/-492 (-492) Function old new delta rk3368_drv_data 4 - -4 rockchip_mbox_probe 2084 1596 -488 Total: Before=3D7185, After=3D6693, chg -6.85% Signed-off-by: Uwe Kleine-K=C3=B6nig --- drivers/mailbox/rockchip-mailbox.c | 27 ++++++++++----------------- 1 file changed, 10 insertions(+), 17 deletions(-) diff --git a/drivers/mailbox/rockchip-mailbox.c b/drivers/mailbox/rockchip-= mailbox.c index 7ebe5f0d0233..ada2bd419880 100644 --- a/drivers/mailbox/rockchip-mailbox.c +++ b/drivers/mailbox/rockchip-mailbox.c @@ -22,15 +22,13 @@ #define ROCKCHIP_MAILBOX_B2A_CMD(x) (0x30 + (x) * 8) #define ROCKCHIP_MAILBOX_B2A_DAT(x) (0x34 + (x) * 8) =20 +#define ROCKCHIP_MAILBOX_NUM_CHANS 4 + struct rockchip_mbox_msg { u32 cmd; int rx_size; }; =20 -struct rockchip_mbox_data { - int num_chans; -}; - struct rockchip_mbox_chan { int idx; int irq; @@ -151,20 +149,15 @@ static irqreturn_t rockchip_mbox_isr(int irq, void *d= ev_id) return IRQ_HANDLED; } =20 -static const struct rockchip_mbox_data rk3368_drv_data =3D { - .num_chans =3D 4, -}; - static const struct of_device_id rockchip_mbox_of_match[] =3D { - { .compatible =3D "rockchip,rk3368-mailbox", .data =3D &rk3368_drv_data}, - { }, + { .compatible =3D "rockchip,rk3368-mailbox" }, + { } }; MODULE_DEVICE_TABLE(of, rockchip_mbox_of_match); =20 static int rockchip_mbox_probe(struct platform_device *pdev) { struct rockchip_mbox *mb; - const struct rockchip_mbox_data *drv_data; struct resource *res; struct clk *pclk; int ret, irq, i; @@ -172,13 +165,13 @@ static int rockchip_mbox_probe(struct platform_device= *pdev) if (!pdev->dev.of_node) return -ENODEV; =20 - drv_data =3D (const struct rockchip_mbox_data *) device_get_match_data(&p= dev->dev); - - mb =3D devm_kzalloc(&pdev->dev, struct_size(mb, chans, drv_data->num_chan= s), GFP_KERNEL); + mb =3D devm_kzalloc(&pdev->dev, + struct_size(mb, chans, ROCKCHIP_MAILBOX_NUM_CHANS), + GFP_KERNEL); if (!mb) return -ENOMEM; =20 - mb->mbox.chans =3D devm_kcalloc(&pdev->dev, drv_data->num_chans, + mb->mbox.chans =3D devm_kcalloc(&pdev->dev, ROCKCHIP_MAILBOX_NUM_CHANS, sizeof(*mb->mbox.chans), GFP_KERNEL); if (!mb->mbox.chans) return -ENOMEM; @@ -186,7 +179,7 @@ static int rockchip_mbox_probe(struct platform_device *= pdev) platform_set_drvdata(pdev, mb); =20 mb->mbox.dev =3D &pdev->dev; - mb->mbox.num_chans =3D drv_data->num_chans; + mb->mbox.num_chans =3D ROCKCHIP_MAILBOX_NUM_CHANS; mb->mbox.ops =3D &rockchip_mbox_chan_ops; mb->mbox.txdone_irq =3D true; =20 @@ -195,7 +188,7 @@ static int rockchip_mbox_probe(struct platform_device *= pdev) return PTR_ERR(mb->mbox_base); =20 /* Each channel has two buffers for A2B and B2A */ - mb->buf_size =3D (size_t)resource_size(res) / (drv_data->num_chans * 2); + mb->buf_size =3D (size_t)resource_size(res) / (ROCKCHIP_MAILBOX_NUM_CHANS= * 2); =20 pclk =3D devm_clk_get_enabled(&pdev->dev, "pclk_mailbox"); if (IS_ERR(pclk)) --=20 2.55.0.11.g153666a7d9bb From nobody Mon Sep 28 06:32:04 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 107C23126AD for ; Tue, 25 Aug 2026 14:19:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787667601; cv=none; b=oGz9q04zx2wTZ+SLlgGkjpE7SfH3zQOzRS9jLiCWbL0fMXNgyxzlFEIWS3ny4DSSWC8g8MrZXxu0HZO8xzWo4BEwX5n0SGLAQeWd+tUFrfHHoJI4qMrNXTRhq2G09lDQXsuCdxZ98oZOepnw+KeY5voAL5qz5HTjfK2QoAnYioU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787667601; c=relaxed/simple; bh=wqZ200zYZ5i4UEPEwIr5WYt6K4/6OBKne3NM7eKxvA8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=TS5pK3TKpWc4Fw4WRxCFabAxJEDlgA0MzVVwHxsAXycNfTSEDHfTL5QsBv03HV2si56ZOCLspRJpsrtQLJqo1rx+vsyODWuigyBDICA8Pn4g9hGjh3HYVCiiSzQENfuUcEuty2HNfxiAJ8MdHALANengu7njlbjZWceGgT4vMhc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Rcb+ITSm; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Rcb+ITSm" Received: by smtp.kernel.org (Postfix) with UTF8SMTPSA id 2A0801F000E9; Tue, 25 Aug 2026 14:19:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1787667599; bh=7kbOFm9Q7fFBHZscYY11fL/APaCBS5q0JYfHLMJc2GA=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=Rcb+ITSmpXQ9yDVdZsnOF81C3pecmwfa97695h1hb3I8NjctLJC+MwI00PBhKzVf4 EKRr//m8FaVy9IbJD4b0Fb6WxcoRocR1La5W4q/DJM59VhVtroERIZPkAIcQ3V0p17 RSNK4oiAzjodtv/lcqfAGdBGGEEvtUAYVCL8Na8BsDKOfaytSMkMrclvq5TuiFd8K2 uhEB0MO4/CRKlU30dFqgRE0AbES6UsHs73SJxwEps04kVe8WpO9dhyxZgXbb+Xq8fT HvT3+74o8vOUBAZHboArXARFl/4pAnp8k9LATT2qktDclS90YkDwannlh8uA7+y8/4 FnrczFpQ+jTMg== From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Jassi Brar , Heiko Stuebner Cc: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Subject: [PATCH v1 3/3] mailbox: rockchip: Convert to use dev_err_probe() Date: Tue, 25 Aug 2026 16:19:26 +0200 Message-ID: X-Mailer: git-send-email 2.55.0.11.g153666a7d9bb In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1347; i=ukleinek@kernel.org; h=from:subject:message-id; bh=e54aXlzGcps+TytsLYfn64m7yyNVmy3TFL/QXt0cNmk=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBqjaR8R3+yy+UgL4aM0YFZQKOc+8xHdAh7wkA/n EcZ7UqEc9mJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCao2kfAAKCRCPgPtYfRL+ TuawB/0d681t1JSRae/ZmngcxUkB/0ubaM3S981Usz9hGmomb76gpu0OZ020BdAR5iQyt0jJNCy 7RKE405NSVJbPLV8KF9pYjPme1y5pqBRk0hZiA4Qi68vMJOqLjplzc4EVQ/ecGqplhkKTqt1fZF 59Sqiaf/JzpW+dFjQnUwsojOjHmqeeSM1tBCpsFzS89FtKxMHuceUIQJspNxOdmg/Q6zuA2uzUv EZjxAXNHzx6mUt4iOrCQUkh/caBD2DcQ24ceLdbOObs+eFuS/0Br4YxcjQBcrcIx2GyuQs4GVa7 lIKsnXnJzq9xIe5plIsBD8mucdA8mZfS0kFFxEUcR+RG2Aly X-Developer-Key: i=ukleinek@kernel.org; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable From: Uwe Kleine-K=C3=B6nig This is more compact in source code and also compiles to smaller code. Bloat-o-meter reports: add/remove: 0/0 grow/shrink: 0/4 up/down: 0/-76 (-76) Function old new delta rockchip_mbox_probe 1596 1592 -4 _entry_ptr 24 16 -8 __func__ 62 42 -20 _entry 132 88 -44 Total: Before=3D6693, After=3D6617, chg -1.14% Signed-off-by: Uwe Kleine-K=C3=B6nig --- drivers/mailbox/rockchip-mailbox.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mailbox/rockchip-mailbox.c b/drivers/mailbox/rockchip-= mailbox.c index ada2bd419880..790c34a22ec5 100644 --- a/drivers/mailbox/rockchip-mailbox.c +++ b/drivers/mailbox/rockchip-mailbox.c @@ -215,9 +215,9 @@ static int rockchip_mbox_probe(struct platform_device *= pdev) =20 ret =3D devm_mbox_controller_register(&pdev->dev, &mb->mbox); if (ret < 0) - dev_err(&pdev->dev, "Failed to register mailbox: %d\n", ret); + return dev_err_probe(&pdev->dev, ret, "Failed to register mailbox\n"); =20 - return ret; + return 0; } =20 static struct platform_driver rockchip_mbox_driver =3D { --=20 2.55.0.11.g153666a7d9bb