From nobody Mon Sep 28 21:07:48 2026 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 694A146A5F2 for ; Mon, 17 Aug 2026 17:21:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786987282; cv=none; b=E+v7y6bWeKudc7NuLlHzf+JrBXUdtGnHBzpp7BkqZ8mujJD8sSm75dA1olxLZZAxco7UQ5bDwO3AQwBLXTVYlBhrE9NUJKLcLwhnc6Dz8iXCfZ1fgi16NeVamOO7IxPxEa9uz0xqigrB0E4ZBCnPf8nhs2UXTfyMPVnvkQiixgg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786987282; c=relaxed/simple; bh=rsWpgWyTG8F1CuDnXVgty6t/FxOndhvrhLNDCyp5r0s=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kXq3MMX6cOsiFIqXMoioSA8A1qjTpPbSTD61NcSpmYaMKJugex1BIFBttMIMkE03uYQngcMxDqdQ+YOi4isTVnYezRe6wG3cjaV6UthPoRzJBcywGghrhuR+C2BBWOBFwO5WsPrXw50nXndVwYzHMnGKeo584JfWZo9kaVl+DHo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=nebusec.ai; spf=pass smtp.mailfrom=nebusec.ai; dkim=pass (2048-bit key) header.d=nebusec.ai header.i=@nebusec.ai header.b=M78YjQJa; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=nebusec.ai Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nebusec.ai Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nebusec.ai header.i=@nebusec.ai header.b="M78YjQJa" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-2d53197d8b5so29960425ad.3 for ; Mon, 17 Aug 2026 10:21:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nebusec.ai; s=google; t=1786987281; x=1787592081; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=DSEJPmFXNKbNuUcOcjgoKVWZNDzQ/7KKx2/i/MKTQ10=; b=M78YjQJaSJzLf/5+AfE06qFTS1VeBQqoUm9c1+DmoZ8RkgZhdO9S622QRlY1/JK9Kl 1pCvUAGVQSeYWlH6DeEqtzw1+Fgh8a/fjFbDNyq6nwn27hR9macbEeiec5wrJiQptUQ5 kdr5AU0bkVzgKpjy9C/1Btjq2KqFQefGJFLM66913gfWRxcTJ2UuGLnEQw3iOQn1lNiS 089gm2pOg5vqtK7E3yDwAKd1BtTnkB2bWpY5RGtwcfoVdwJdR1HsP08YgfYuAdhHmKST pgb9g/HognLXFJg8crm4D1wuggf+zuwte60EUVWSm+dTZE1oCVCUS+fADEL2+Je7lgTX 5UyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786987281; x=1787592081; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=DSEJPmFXNKbNuUcOcjgoKVWZNDzQ/7KKx2/i/MKTQ10=; b=EjJEn/HRtsrLQxgaMSwE+e1GX/AssqTkVA2ovilEHvhYCCZ8E6J0qqn5rBrZ5VQgl0 uwZBgO6XbDgSUleX4QoOWrJdJO0XBb8yeJ6bQWEsD2Le1bvevofKhemFVbAdg2ouORLW RaqDv9X6iofNtkGWAMn8WicZ9ajMJ94nQpVEJZkrTWe2y5tEtPo9it0+cMoig9J9U3id KCEc3jO+8XZ+WiQLH6Cw1+zyeDWDZhcbFyHtqx64qU2+zvkOVpcWcEz/bvqtW2WWJQbu mvon274QiJSE1S3UAOGFVu60TXX2s7ijntxanV9aLInVZKjAZRojGsw1fvaNxff4aHZX yrZA== X-Forwarded-Encrypted: i=1; AHgh+Rosg2J6JMeEvR0cPLbuY0/k9EC3slCYWpY7+1sZSOzvn4rY8yAQhPhz3/DwPwSQUCp/G7g2UHpvQMM//jU=@vger.kernel.org X-Gm-Message-State: AOJu0YxWC8NjbZH+qr/7D240BCmuMabqm6wcNPfwO/qC1PenD9mHEJDM tyeMMlRYNEVUi+zhuyX8jb/wsinnQJv+2b0cuHVR4mx+9zcs82dKSKPipQnl1AxTxmZ4 X-Gm-Gg: AR+sD12pWtKnxQb2M/MmbT4McJx1h3oKBObY5z6hJGl4alCaHu9N2V0GnnENADon/uc Lt73jqecnJqiNy54D+RFsSaGTjL7S0AqwYO5XVdqN6Ym1Hmwa/I4FZu8IMdKYlaC3gd6JXnU9hs /evATwQVrVpfa8SeRGIajPDa82pdtTkbVQU6Iv2Wh9M3vl2P8Q0cyTE4pj6pShqpFiA49/6QvGU vL4MX9EY4y4CY/1ufPCGQYSqJsBIeBP0acT1ZH/oO08A4kobFFx6fXP/iXrYz3IONXZuNth6o+j ASUcKnam1NWGGkG9TbXlP3xguz4KYXN1/wCZdNYbZH7ccvPJhzEsP3m3YeNxCPih0isaVDRRsOP jV1EGKcDizKatdhLJeauRwnCrH6SjiY7AQnKe9o9ItPY7x9bknLZvWj9VCoDhRW8ulyb9iSYQk2 irGa/AKM1boO3ZyX63o1sUJHIcgS+z06VqA+ngCAMsuFOwlcxSQ6geQw== X-Received: by 2002:a17:902:e5cd:b0:2c9:bf82:dd11 with SMTP id d9443c01a7336-2d5c4f38113mr13840855ad.7.1786987278618; Mon, 17 Aug 2026 10:21:18 -0700 (PDT) Received: from gmail.com ([115.196.71.116]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2d5c1e8de43sm6184255ad.57.2026.08.17.10.21.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Aug 2026 10:21:18 -0700 (PDT) From: Zihan Xi To: netdev@vger.kernel.org Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, bhong@brocade.com, stephen@networkplumber.org, sven@brocade.com, linux-kernel@vger.kernel.org, Zihan Xi , stable@vger.kernel.org, Vega Subject: [PATCH net 1/1] net: l2tp: ignore multicast notification errors in netlink commands Date: Mon, 17 Aug 2026 17:21:09 +0000 Message-ID: X-Mailer: git-send-email 2.47.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" l2tp_nl_cmd_tunnel_create(), l2tp_nl_cmd_session_create(), and l2tp_nl_cmd_session_modify() update live state before sending their multicast notifications. A notification helper can fail while allocating or encoding the message, or while multicasting it. Returning any such best-effort notification error after the state change makes a successful command look like a failure and can cause retries to accumulate live objects. Keep sending notifications for listener visibility, but do not let their best-effort status overwrite the command result. The explicit (void) casts make this intentional for all notification helper failures. Fixes: 33f72e6f0c67 ("l2tp : multicast notification to the registered liste= ners") Cc: stable@vger.kernel.org Reported-by: Vega Assisted-by: Codex:gpt-5.4 Signed-off-by: Zihan Xi --- net/l2tp/l2tp_netlink.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/net/l2tp/l2tp_netlink.c b/net/l2tp/l2tp_netlink.c index 59457c0c1..21160284f 100644 --- a/net/l2tp/l2tp_netlink.c +++ b/net/l2tp/l2tp_netlink.c @@ -248,8 +248,8 @@ static int l2tp_nl_cmd_tunnel_create(struct sk_buff *sk= b, struct genl_info *info kfree(tunnel); goto out; } - ret =3D l2tp_tunnel_notify(&l2tp_nl_family, info, tunnel, - L2TP_CMD_TUNNEL_CREATE); + (void)l2tp_tunnel_notify(&l2tp_nl_family, info, tunnel, + L2TP_CMD_TUNNEL_CREATE); l2tp_tunnel_put(tunnel); =20 out: @@ -645,8 +645,8 @@ static int l2tp_nl_cmd_session_create(struct sk_buff *s= kb, struct genl_info *inf session =3D l2tp_session_get(net, tunnel->sock, tunnel->version, tunnel_id, session_id); if (session) { - ret =3D l2tp_session_notify(&l2tp_nl_family, info, session, - L2TP_CMD_SESSION_CREATE); + (void)l2tp_session_notify(&l2tp_nl_family, info, session, + L2TP_CMD_SESSION_CREATE); l2tp_session_put(session); } } @@ -710,8 +710,8 @@ static int l2tp_nl_cmd_session_modify(struct sk_buff *s= kb, struct genl_info *inf if (info->attrs[L2TP_ATTR_RECV_TIMEOUT]) session->reorder_timeout =3D nla_get_msecs(info->attrs[L2TP_ATTR_RECV_TI= MEOUT]); =20 - ret =3D l2tp_session_notify(&l2tp_nl_family, info, - session, L2TP_CMD_SESSION_MODIFY); + (void)l2tp_session_notify(&l2tp_nl_family, info, + session, L2TP_CMD_SESSION_MODIFY); =20 l2tp_session_put(session); =20 --=20 2.43.0