From nobody Tue Sep 29 09:45:49 2026 Received: from out-179.mta1.migadu.com (out-179.mta1.migadu.com [95.215.58.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F1F1369206 for ; Sun, 9 Aug 2026 17:11:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786295473; cv=none; b=RLDUrurPjsctyFlSyI5UgHt0ZEOXqS0R/ILQ0LiYjw6cDSTR9NYz/Uy8fp69NDOoP+zVLQotDLp535MCwLs6/wHR6PRGY9P5U641p8nAFI5jMgIVutjpjvvuF8+hQk/HUyHfEylIcjbAQWvoNNsyaNuCi+QH0AUCkuK/QhGLoHk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786295473; c=relaxed/simple; bh=c1gUrWjTy4h7QtYQ5HE07DtR8x4SaBsVSQpOeOpvmlg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type; b=OywENF7QeN/bOIS1ARqVuEJ7J0IhmfCc3rejBhQgbyhxu+VK5MzuM1Z6AHZ1qMcfKah6POptPSNiLscYkR/ZYfw2m3KKf6EBbCgKnlH5EEY/hfNObyUTP0HUVOdQ5sGcnhA3MKdDKsQFTO3IItPjNt4wbgbLor7/CjpH99AVxlE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=gfpXjL+M; arc=none smtp.client-ip=95.215.58.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="gfpXjL+M" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1786295469; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XpBp+WbQsCcpWpuQO9GCleO3iIrhhT4MJgEdXq+DRcE=; b=gfpXjL+MZ850Mbfg64iLeZ+NLNghktQm360N/y4elGeAiH6y987ivzhNKwGku7ImCyYw65 Y/3P083F+8F1bZbk8D0t9O/tZZb84u0mZx7eVk0v8JYs0MS1TRbhmf/GnB6EkAB/ascWrK RmXpec829QDivW0WHgqPvNIU260g258= From: wen.yang@linux.dev To: Gabriele Monaco Cc: Nam Cao , linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org, Wen Yang , =?UTF-8?q?Thomas=20Wei=C3=9Fschuh?= Subject: [PATCH v3 1/4] rv/reactors: use context-sensitive lockdep wait type in rv_react() Date: Mon, 10 Aug 2026 01:10:38 +0800 Message-Id: <26526e555baa5118325b2383e9f7f0f8f9b6a199.1786294920.git.wen.yang@linux.dev> In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT From: Wen Yang Reactors must not explicitly take locks, so they should comply with LD_WAIT_FREE. However, reactor callbacks can run with preemption enabled on any kernel (not just PREEMPT_RT). If a timer interrupt fires during the callback, the interrupt exit path schedules and acquires rq->__lock (LD_WAIT_SPIN) while the lockdep override map that declared LD_WAIT_FREE is still held, triggering a spurious "Invalid wait context" warning: [ BUG: Invalid wait context ] context-{5:5} 1 lock held by kunit_try_catch/209: #0: (rv_react_map-wait-type-override){+.+.}-{1:1} kunit_try_catch/209 is trying to lock: ffff8a743ed3e8a0 (&rq->__lock){-...}-{2:2} Fixes: 69d8895cb9a9 ("rv: Add explicit lockdep context for reactors") Suggested-by: Gabriele Monaco Signed-off-by: Wen Yang Cc: Thomas Wei=C3=9Fschuh Reviewed-by: Gabriele Monaco --- kernel/trace/rv/rv_reactors.c | 20 +++++++++++++++----- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/kernel/trace/rv/rv_reactors.c b/kernel/trace/rv/rv_reactors.c index 2f5fc8d18dea..5830229210e8 100644 --- a/kernel/trace/rv/rv_reactors.c +++ b/kernel/trace/rv/rv_reactors.c @@ -465,18 +465,28 @@ int init_rv_reactors(struct dentry *root_dir) =20 void rv_react(struct rv_monitor *monitor, const char *msg, ...) { - static DEFINE_WAIT_OVERRIDE_MAP(rv_react_map, LD_WAIT_FREE); + /* + * Reactors must not explicitly take locks, so they should be + * LD_WAIT_FREE. However, reactor callbacks can run with preemption + * enabled, meaning the preempting code (e.g. the scheduler taking + * rq->__lock at LD_WAIT_SPIN) may violate that constraint. Use + * LD_WAIT_SPIN in preemptible contexts to avoid false-positive lockdep + * reports; keep LD_WAIT_FREE in NMI/hardirq where preemption is + * disabled and the scheduler cannot run. + */ + static DEFINE_WAIT_OVERRIDE_MAP(rv_react_map, LD_WAIT_SPIN); + static DEFINE_WAIT_OVERRIDE_MAP(rv_react_map_atomic, LD_WAIT_FREE); + struct lockdep_map * __maybe_unused map; va_list args; =20 if (!rv_reacting_on() || !monitor->react) return; =20 + map =3D (in_nmi() || in_hardirq()) ? &rv_react_map_atomic : &rv_react_map; va_start(args, msg); - - lock_map_acquire_try(&rv_react_map); + lock_map_acquire_try(map); monitor->react(msg, args); - lock_map_release(&rv_react_map); - + lock_map_release(map); va_end(args); } EXPORT_SYMBOL_GPL(rv_react); --=20 2.25.1 From nobody Tue Sep 29 09:45:49 2026 Received: from out-180.mta1.migadu.com (out-180.mta1.migadu.com [95.215.58.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3FA552D12ED for ; Sun, 9 Aug 2026 17:11:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786295476; cv=none; b=hKFgtBaJfJE08FtGVIngrXDRIAgTQCXl8SpZSUw0WlCmMfZHqcfoMPeNDQZ7g68Zq/eFLoq2MRlBiXWwqNphHxMa9QJ/JIvEdBjS1f7FRPArRkvN0CpINr0Q3tVTtXI4VuDl8b0P7Nv5/RyiI47Q3es1U4DmYSgOVQsPVHlscyA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786295476; c=relaxed/simple; bh=wAQg/9NmXrfLyobx5fIeaAV5CS0AJ9K9oCiIVxJDzZI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=aZeIkQHODj87pj14rCRrduzwcJW9VJjv8gGQlHQL2c6bkMu9u5VwHCxGsD05GXE8mQ/eQXHmejCFtgR/yB2CeHUtro1OkPp/qn7MCR56nlNeddgY2yagfjTICBDmd4tdFraLFY2WPzTxS2PZblrmsli/fE+OuNXVJKP+tn+fB4k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=tN7C2eaS; arc=none smtp.client-ip=95.215.58.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="tN7C2eaS" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1786295471; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mQPNtqtBOPHBRFHptLFqoDAxsGiZfQYOCpsB9fHjmzw=; b=tN7C2eaSbRU9RpJFA2QPdUnFaG80k6OGQw8mxSQE2L35xK1ip7Fb+qGvNJ2NoQYRxHsN4t ulgvFYTItAWMG2H4NAgTQjyRbBO2dhgDmM1ORcMnfgOA+2PKeJ/Ncqgsp2rO0sP6Cbi+P9 4s7ffT6ucWBiG0VG0jehJgJTzMNTXmg= From: wen.yang@linux.dev To: Gabriele Monaco Cc: Nam Cao , linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org, Wen Yang Subject: [PATCH v3 2/4] rv/reactors: propagate rv_register_reactor() error from reactor init Date: Mon, 10 Aug 2026 01:10:39 +0800 Message-Id: In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" From: Wen Yang Both register_react_printk() and register_react_panic() ignore the return value of rv_register_reactor() and always return 0. If the registration fails (e.g. a duplicate reactor name), the init functions silently report success even though the reactor was not registered. Propagate the error from rv_register_reactor() so a failed registration is reported instead of being silently ignored. Suggested-by: Gabriele Monaco Reviewed-by: Gabriele Monaco Signed-off-by: Wen Yang Reviewed-by: Nam Cao --- kernel/trace/rv/reactor_panic.c | 3 +-- kernel/trace/rv/reactor_printk.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/kernel/trace/rv/reactor_panic.c b/kernel/trace/rv/reactor_pani= c.c index 76537b8a4343..db7116ceafff 100644 --- a/kernel/trace/rv/reactor_panic.c +++ b/kernel/trace/rv/reactor_panic.c @@ -26,8 +26,7 @@ static struct rv_reactor rv_panic =3D { =20 static int __init register_react_panic(void) { - rv_register_reactor(&rv_panic); - return 0; + return rv_register_reactor(&rv_panic); } =20 static void __exit unregister_react_panic(void) diff --git a/kernel/trace/rv/reactor_printk.c b/kernel/trace/rv/reactor_pri= ntk.c index 48c934e315b3..002a10f6aa7b 100644 --- a/kernel/trace/rv/reactor_printk.c +++ b/kernel/trace/rv/reactor_printk.c @@ -25,8 +25,7 @@ static struct rv_reactor rv_printk =3D { =20 static int __init register_react_printk(void) { - rv_register_reactor(&rv_printk); - return 0; + return rv_register_reactor(&rv_printk); } =20 static void __exit unregister_react_printk(void) --=20 2.25.1 From nobody Tue Sep 29 09:45:49 2026 Received: from out-171.mta1.migadu.com (mta1.migadu.com [37.59.57.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1569C3B3884 for ; Sun, 9 Aug 2026 17:11:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=37.59.57.117 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786295477; cv=none; b=ErnQjwYFmvja/DsVyV4GEsIR6BtDLo2BqnuCf0kUSmTpeUYyEau9Yxty4xOsPjK6668vOW/tgZnxmbtNkrgCb1DNPRej6ICCFr0NYaSi4Ztth/jXyfVk5bWV1besit2ssdSJvOd273SOwzG04rA/H5yIHaNWWEdxydM0Dfn1Wgg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786295477; c=relaxed/simple; bh=JbsI9yfPOBsdH+UmNWDF8eZ1SFtsOLnJfGlkmJRqsso=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=eJD7wmzy/KwrVphS915/hC87ZyfJuivM1/gucaXCTRSYf8mpTKmNygoMXJx8OvzZiRUwZ/criW6bvResfN2riH8p2r2hV4KbsVcFfMI8GnadvI3znmcpmT2Jqa6ZvKyDlCp6/rItWApx3HfBvAnK2APb9/5f6NuSE3wWLQ5IJgo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=WpdmEODe; arc=none smtp.client-ip=37.59.57.117 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="WpdmEODe" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1786295473; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KbHqbqg+2l0IB5FBzF8BcE24Z+K4eE6uADC0MfP/Hxc=; b=WpdmEODeaHOf2M1n4Cwvb9hmPr3Z7Ju2yfpWo2BhLPz6DCeSs2hHDJOnqRkD/qN6nParWR NEamFsmfaHkRpg8b91q55ZgKBVKCdx3J4SmPjT9yISWIu1cXLj3rg37ibB1g1/zDZYD4Mn ZBSH5TJtjlC2kaKYK9ODeaYWRrIvFJY= From: wen.yang@linux.dev To: Gabriele Monaco Cc: Nam Cao , linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org, Wen Yang Subject: [PATCH v3 3/4] rv/reactors: export rv_register_reactor() and rv_unregister_reactor() Date: Mon, 10 Aug 2026 01:10:40 +0800 Message-Id: <71492c2a3a4596131bc1cdc4256d855ca527daf6.1786294920.git.wen.yang@linux.dev> In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" From: Wen Yang rv_react() is exported to modules, but the reactor registration helpers are not. Export them with EXPORT_SYMBOL_GPL() so reactor modules and the tristate KUnit test module can register and unregister reactors without hitting undefined symbol errors at link time(modpost). Reviewed-by: Gabriele Monaco Signed-off-by: Wen Yang --- kernel/trace/rv/rv_reactors.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/kernel/trace/rv/rv_reactors.c b/kernel/trace/rv/rv_reactors.c index 5830229210e8..5c85e3efe42e 100644 --- a/kernel/trace/rv/rv_reactors.c +++ b/kernel/trace/rv/rv_reactors.c @@ -314,6 +314,7 @@ int rv_register_reactor(struct rv_reactor *reactor) guard(mutex)(&rv_interface_lock); return __rv_register_reactor(reactor); } +EXPORT_SYMBOL_GPL(rv_register_reactor); =20 /** * rv_unregister_reactor - unregister a rv reactor. @@ -327,6 +328,7 @@ int rv_unregister_reactor(struct rv_reactor *reactor) list_del(&reactor->list); return 0; } +EXPORT_SYMBOL_GPL(rv_unregister_reactor); =20 /* * reacting_on interface. --=20 2.25.1 From nobody Tue Sep 29 09:45:49 2026 Received: from out-179.mta1.migadu.com (out-179.mta1.migadu.com [95.215.58.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 064B43B38B8 for ; Sun, 9 Aug 2026 17:11:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786295486; cv=none; b=XZ4hKDcIJnaRws7qsq+ak/Vcu2x7j0zf9YZMOcJtP8EosPgWjfBhXCCF7ewgIJ3tZXbQjn1VQrqrnVds0j9beH8gEyETAxw5mKnBKFqbTlAA6TOqMy08T70FPzZwE2SThSZZVnMULBjOtrc0FPyFuZIjzsWbTj0KJaegRVgjFhg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786295486; c=relaxed/simple; bh=wnquJR+5vXNgOlT7/7bQkGGxiSmrctDirKmYq0iJow8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ZAtDg25fRo+m6aDIZQCh+x+6zPVGLwP3MRRJ7/4qyK7RiZqcFCClBFkxzvgCRSsJJCY4Dl5oCyLLRRUD1QqcgAwPu4xiiJ0vBUGigDIr7U2nAfKjhrE4VyKqRdsCkaejsmc3o4FV0Z7S4PabRZp6ZpJLXIWEo7JPXQUA3sxRy6o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=j3K4Yu6E; arc=none smtp.client-ip=95.215.58.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="j3K4Yu6E" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1786295478; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Wn5zEW2hyaObBuC/eUmpPRrpZwxqCcMW2x2qCB2BR+o=; b=j3K4Yu6EgBwq3p4CRaweh3UjZHQbG1GqBbAm+fqnmRUhpWUB3ouoV6oiLEOaD5QWws7Rub r8A1nKW4OcfXsJSYpZhx6Kpcw1fZt8Ow8c1XEbev0gGTbQmNedsdINnLxrBP79lTfoaUQu +PQ8JsGVWCn4ggAdMfgFP5+y36DZoMM= From: wen.yang@linux.dev To: Gabriele Monaco Cc: Nam Cao , linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org, Wen Yang Subject: [PATCH v3 4/4] rv/reactors: add KUnit tests for reactor registration and dispatch Date: Mon, 10 Aug 2026 01:10:41 +0800 Message-Id: <2b91af9f6d045f7fdb8620ef5c66c3b3e189833b.1786294920.git.wen.yang@linux.dev> In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" From: Wen Yang Add KUnit tests covering the reactor register/unregister lifecycle (including duplicate and name-length rejection) and rv_react() dispatch (a no-op without a callback, exactly one invocation with one; the mdelay callback keeps the CPU busy so a timer interrupt exercises the LD_WAIT_SPIN lockdep context). The Kconfig entry is tristate so the tests can be built as a module when CONFIG_KUNIT=3Dm; only RV_REACTORS is required. Suggested-by: Gabriele Monaco Signed-off-by: Wen Yang Reviewed-by: Gabriele Monaco --- kernel/trace/rv/Kconfig | 12 +++ kernel/trace/rv/Makefile | 1 + kernel/trace/rv/rv_reactors_kunit.c | 119 ++++++++++++++++++++++++++++ 3 files changed, 132 insertions(+) create mode 100644 kernel/trace/rv/rv_reactors_kunit.c diff --git a/kernel/trace/rv/Kconfig b/kernel/trace/rv/Kconfig index efa930f94ea4..9bfd429ffdea 100644 --- a/kernel/trace/rv/Kconfig +++ b/kernel/trace/rv/Kconfig @@ -113,6 +113,18 @@ config RV_REACT_PANIC Enables the panic reactor. The panic reactor emits a printk() message if an exception is found and panic()s the system. =20 +config RV_REACTORS_KUNIT + tristate "KUnit tests for RV reactors" if !KUNIT_ALL_TESTS + depends on KUNIT + depends on RV_REACTORS + default KUNIT_ALL_TESTS + help + Enable KUnit tests for RV reactor registration and dispatch. + These tests verify the register/unregister lifecycle, duplicate + rejection, and that rv_react() correctly invokes callbacks. + + If unsure, say N. + config RV_MONITORS_KUNIT_TEST tristate "KUnit tests for RV monitors" if !KUNIT_ALL_TESTS depends on KUNIT && RV && RV_REACTORS diff --git a/kernel/trace/rv/Makefile b/kernel/trace/rv/Makefile index cdbf68c84f5a..c895d81dfdad 100644 --- a/kernel/trace/rv/Makefile +++ b/kernel/trace/rv/Makefile @@ -25,4 +25,5 @@ obj-$(CONFIG_RV_MON_WAKEUP) +=3D monitors/wakeup/wakeup.o obj-$(CONFIG_RV_REACTORS) +=3D rv_reactors.o obj-$(CONFIG_RV_REACT_PRINTK) +=3D reactor_printk.o obj-$(CONFIG_RV_REACT_PANIC) +=3D reactor_panic.o +obj-$(CONFIG_RV_REACTORS_KUNIT) +=3D rv_reactors_kunit.o obj-$(CONFIG_RV_MONITORS_KUNIT_TEST) +=3D rv_monitors_test.o diff --git a/kernel/trace/rv/rv_reactors_kunit.c b/kernel/trace/rv/rv_react= ors_kunit.c new file mode 100644 index 000000000000..d5b731eb11f3 --- /dev/null +++ b/kernel/trace/rv/rv_reactors_kunit.c @@ -0,0 +1,119 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * KUnit tests for RV reactor registration and dispatch. + */ + +#include +#include +#include +#include +#include "rv.h" + +static struct rv_reactor test_reactor =3D { + .name =3D "kunit_test_reactor", + .description =3D "KUnit test reactor", +}; + +static void reactor_teardown(void *arg) +{ + rv_unregister_reactor(&test_reactor); +} + +static void register_test_reactor(struct kunit *test) +{ + KUNIT_ASSERT_EQ(test, rv_register_reactor(&test_reactor), 0); + KUNIT_ASSERT_EQ(test, + kunit_add_action_or_reset(test, reactor_teardown, NULL), 0); +} + +static void test_double_register(struct kunit *test) +{ + register_test_reactor(test); + KUNIT_EXPECT_EQ(test, rv_register_reactor(&test_reactor), -EINVAL); +} + +/* + * Use a fixed-size array so sizeof() gives the exact byte count at + * compile time. + */ +static const char long_reactor_name[] =3D "kunit_reactor_name_too_long_xxx= _"; +_Static_assert(sizeof(long_reactor_name) - 1 >=3D MAX_RV_REACTOR_NAME_SIZE, + "long_reactor_name must be at least MAX_RV_REACTOR_NAME_SIZE chars= "); + +static void test_name_too_long(struct kunit *test) +{ + static struct rv_reactor long_reactor =3D { + .name =3D long_reactor_name, + }; + + KUNIT_EXPECT_EQ(test, rv_register_reactor(&long_reactor), -EINVAL); +} + +static struct kunit_case rv_reactor_registration_cases[] =3D { + KUNIT_CASE(test_double_register), + KUNIT_CASE(test_name_too_long), + {} +}; + +static struct kunit_suite rv_reactor_registration_suite =3D { + .name =3D "rv_reactor_registration", + .test_cases =3D rv_reactor_registration_cases, +}; + +static atomic_t react_call_count; + +__printf(1, 0) static void mock_react(const char *msg, va_list args) +{ + atomic_inc(&react_call_count); + /* + * Hold the CPU for 5 ms so a timer interrupt is likely to fire + * inside rv_react()'s lockdep context, exercising the LD_WAIT_SPIN + * constraint. mdelay() is a calibrated busy-wait with no scheduler + * interaction. + */ + mdelay(5); +} + +static void test_react_no_callback(struct kunit *test) +{ + struct rv_monitor monitor =3D { + .name =3D "kunit_null_react", + }; + + atomic_set(&react_call_count, 0); + rv_react(&monitor, "no callback"); + + /* + * The only possible failure in this test case is a kernel panic. + * NULL react guard: callback must NOT have been invoked + */ + KUNIT_EXPECT_EQ(test, atomic_read(&react_call_count), 0); +} + +static void test_react_callback_invoked(struct kunit *test) +{ + struct rv_monitor monitor =3D { + .name =3D "kunit_dispatch_monitor", + .react =3D mock_react, + }; + + atomic_set(&react_call_count, 0); + rv_react(&monitor, "callback invocation test"); + KUNIT_EXPECT_EQ(test, atomic_read(&react_call_count), 1); +} + +static struct kunit_case rv_react_dispatch_cases[] =3D { + KUNIT_CASE(test_react_no_callback), + KUNIT_CASE(test_react_callback_invoked), + {} +}; + +static struct kunit_suite rv_react_dispatch_suite =3D { + .name =3D "rv_react_dispatch", + .test_cases =3D rv_react_dispatch_cases, +}; + +kunit_test_suites(&rv_reactor_registration_suite, &rv_react_dispatch_suite= ); + +MODULE_LICENSE("GPL"); +MODULE_DESCRIPTION("KUnit tests for RV reactor registration and dispatch"); --=20 2.25.1