From nobody Sat Oct 3 03:52:40 2026 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 37489386C08 for ; Wed, 5 Aug 2026 14:42:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785940954; cv=none; b=gDBl/zYbYKBCxHMo8WbLGSezgZITPFRTT0r0pWGJL3EFaZGDohBXDEj5oHhlw0pwWEUiYPTHCPGL5o3KAKsglNP3+mqr94I0Xn5DpY8K3rmDep+ldj9sDGgPvhiiKKGv8lR1IgESorBt0/fEfNfupw782dDEUQs9Wdd/rKLrmrY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785940954; c=relaxed/simple; bh=xqKP2B8yETwTauQ8GaukmhFqG3QYgPaM5Z61iJYywO8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UYUjy/NE/gLP8H4elFb9FyzBE4WAbdVjpeOjwF6O+e4QW17DIr0FpqmGwUGHE5hh4iKeH/KXFbNOhLF4ZhjQgbx7Ohns7gPsiPGJx5qy44iK5I2ebtlOpNKMIsGsGExKHS1TJCiPQinLu7uRsv+7cxsPGVBjGKwbcdV+6F6yt2g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PQl07l8K; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PQl07l8K" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-47f7027ca11so729088f8f.3 for ; Wed, 05 Aug 2026 07:42:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785940948; x=1786545748; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=fOyJt1GjebvcdavnL8pSeT2aveC2x2fYTTclxb3ByIE=; b=PQl07l8KRhTJalUivtKQfm+wq6zJ9FVa0PfcF0rcxEWvVsa14vTaaYtS2Y6e0D1zIg AIQ1+tB91SA0w2J65agg95ODKTFPGG6GqziO36k5lkMFDX0j1Rq0hDIRP6xd8yFZsS3/ NIx1yhlpB+c0V4+lfICj2bLTrqUg5YoxqbPWL6Qg23VduE78Os9qIDdmx5bQBFSUYI0s qwX/Op3RJR0sihdmgtG97ghga3Vr39xdHkfuwXIsJg36Udcd0T5ZI3/UGgjWxb9PM53R rUpg7Qa3mI69rsuMxugJmhIfA/Vv4iqm2DjBJmnSfwRna05IXMw3KA915meiMH8GMs0X q4Iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785940948; x=1786545748; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=fOyJt1GjebvcdavnL8pSeT2aveC2x2fYTTclxb3ByIE=; b=oAqDIEyJpOlntO8/wwSjSnHCAcWdX1fhoR43xrkonrJor+085piwvVDQcCHB4vvLN6 rvNEn8t+6mDm9dA251glV47FQepWVpLYiPIaxhvJAzbbdAKTCBoLO/kw2F2Aidhw9Y9w 1X6yITlAnmA9j1LXo/010Kj5Q3qYKOQF9NJJW3rPJ6/sI7zDy/kr2WHhsIIMLltnmVp2 1DWXfrJR4tw8GFwynlVFQL48cKUnLfYJzcFxBkRIzaRKddVh+sUjLNcxZiWH/+ZStg/p nRnOXe9frd2sri9vepxvuxswq9idVxBbHgjhUrGGwJezlvYGF4FFizRNnvir4Tzem0hE VIhQ== X-Forwarded-Encrypted: i=1; AHgh+Ro5zeNbZ+WZ+VM6PyI6BQ0qbvGFRlNTnm2UegwUMWvCYIEid2AldqiB9YHzr6c65NzBe1jtf1fc1UPBeyQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxEsMpGp+IQPFIzhIGEs1vsguA/INwI3jF0Dz9KYBNxhKaXn2nd WJgUYPRMDCM7Cid3NUg0DZJc+xriSvngwTSChdbtcqQ6wNW9hcSffaUz X-Gm-Gg: AR+sD12C5I0///IfD1AAWsH2pN6XNP09lGESvyssoAEMFvF66Y41SBfeJkQpzYDyyqB 1VS3jPsU+rak529Dj6WmE6hgIVjKeh4wc6nlv6sIZGbwAhZgMGXL1h0R/EV2TCPnOJAAy3VAUuM MuuD1LhYVHWluTvYAVb53FmheTgEE8wCtFUrREfM2v4HGikFiHkUNMkCst2ubbxFv33svTtcavh WUnwL/jWee6DFoSw27Bb3HO8OF2UZzESe7RpVmMQXbbAxvkCcErtqOoA5xgb5wzUa97Z9prrm02 NvUFQCSHLR7aDJMdxJbcU/tcAJEtHDZ8d3LlxfInHLZeqGPVu1iZQKqK0Pgg/iSVbPMXwMzonMq XS5L64ppk9paQFnw1nTTnKn1AZJyP79DeAesHtBpZR9WPg4f7vzotvADLscrUQTNxy2U4JtcZa5 fJO14GkhUq7fcLvY1lKw1jXyXtUovvq2SXS/36G5ILIvtQmfeXe7yQDSe3ljW0ESMxpHA6becEv TImAiZjz8EQJUdaFPsthSo= X-Received: by 2002:a05:6000:40da:b0:47f:93b6:8d06 with SMTP id ffacd0b85a97d-47fec482347mr12815889f8f.0.1785940947427; Wed, 05 Aug 2026 07:42:27 -0700 (PDT) Received: from LAPTOP-AVI.taile24b5.ts.net ([2a00:a040:1b7:4f41:6df7:ffe8:d01:255d]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47fec232333sm10094289f8f.18.2026.08.05.07.42.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Aug 2026 07:42:27 -0700 (PDT) From: Avi Weiss To: Andrew Morton Cc: David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Soheil Hassas Yeganeh , Arjun Roy , Eric Dumazet , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Avi Weiss Subject: [PATCH v2 1/3] mm/memory.c: rename walk_to_pmd() to populate_to_pmd() Date: Wed, 5 Aug 2026 17:42:17 +0300 Message-ID: <1d3d22df3b43080855d4728095f9ebaddfd7bf88.1785847364.git.thnkslprpt@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This helper allocates any missing page-table levels (it doesn't just 'walk'. Rename for clarity. Signed-off-by: Avi Weiss --- mm/memory.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/mm/memory.c b/mm/memory.c index ff338c2abe92..8658feba8be9 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -2268,7 +2268,7 @@ void zap_special_vma_range(struct vm_area_struct *vma= , unsigned long address, } EXPORT_SYMBOL_GPL(zap_special_vma_range); =20 -static pmd_t *walk_to_pmd(struct mm_struct *mm, unsigned long addr) +static pmd_t *populate_to_pmd(struct mm_struct *mm, unsigned long addr) { pgd_t *pgd; p4d_t *p4d; @@ -2293,7 +2293,7 @@ static pmd_t *walk_to_pmd(struct mm_struct *mm, unsig= ned long addr) pte_t *get_locked_pte(struct mm_struct *mm, unsigned long addr, spinlock_t **ptl) { - pmd_t *pmd =3D walk_to_pmd(mm, addr); + pmd_t *pmd =3D populate_to_pmd(mm, addr); =20 if (!pmd) return NULL; @@ -2437,7 +2437,7 @@ static int insert_pages(struct vm_area_struct *vma, u= nsigned long addr, int ret; more: ret =3D -EFAULT; - pmd =3D walk_to_pmd(mm, addr); + pmd =3D populate_to_pmd(mm, addr); if (!pmd) goto out; =20 --=20 2.43.0 From nobody Sat Oct 3 03:52:40 2026 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 54AB6352008 for ; Wed, 5 Aug 2026 14:42:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785940957; cv=none; b=gVqinfg6q5SeACT034znsSNZMxNZBo8OI+3l6HtGhCoGfxa0eiw2/75KYjF0VfpyuuSPzgowzElI5OTYgu+BwnLTiew+ksQiWd4L3Yo3r6nHb7bozOdBSnt+IQKsyCQGb4vrnBoOawNkpSwBN2+abGUO0M/C5v5iYfWPcAEppws= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785940957; c=relaxed/simple; bh=cnAJUOffakJVhIyBDxUWuaHwK0B+FjaDZZhhgwWfY28=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=C8OvVID34oSu//uwbi982QNGZZOmdoXaTxFIvjKHoUJlXWkpEcOxdv4mGujo6H54Ax3JDcCXisrq6hpEHG103KCRG9HXld6Cg4mFNUmn/ERf5L00e743uphLSqWnx+UeZLDUET/kwDgbZ1hDC6Y0HaNRbn+z0QuvtCBfwF5Oi4Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HkzZvGFA; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HkzZvGFA" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-47c6e9a694bso699235f8f.1 for ; Wed, 05 Aug 2026 07:42:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785940950; x=1786545750; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=awORHCEFJ8S0UqHq55puPxkhFlpDUSfBHw3cahKX9ew=; b=HkzZvGFA9Pq0287uoAcJopYFwIqv1HlS3bI8LwPh9C6FNseAYQUdMuq8DPCD9neaJK 4doGLyMl3LDnxN8LBZKfdLe6NpDqUvUiFUa7y3T9oGUBM/bXeNX387F5FTGcvGJLIhH2 oBwACGfEVKc30c422befOvg7xg5aI6Sbm0e7nYWavtt2SFBlMo9W/4Yb7NY494W9xXIM bZ0hzs2sXyka6UpwYlkBV1W0zSHau2pOpDT/+f68UXdPzRC6n2th8HSIIzWihd3LT4HF Z9WxJ09eC/HqCHdFavI/5ccI/cSH6vAnJGKlpoHJ/IeukRhi2A8zBKitvOXmFF2A22aZ BJeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785940950; x=1786545750; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=awORHCEFJ8S0UqHq55puPxkhFlpDUSfBHw3cahKX9ew=; b=opTtGUf1xfr48vVzawGAVoQQEBrmP6kLQMXpA/UnnBBsJtOV7DN5oOwNuha16kLxuC eEux4M8DRf9/MGJqB1Pv8LqJIyztaActTWtMjw9CVcAJpG+FzFE5xk+IPggVbFJp7TsM 1uR9XgLUy40trAq56tFBWov8gSK5vfTsEAnYLNY2Noik5VUTy01Wtm0bHm0V76sJqe4j nZlRn/qz/LgtfgJOnKq6/r+cbO2rtbEtoRDrj6YLGOw90QcWrwMBPH1ZLs1sKOqGbn92 z2WlSK/03sxb4YiJhJeRUTWkZwh0f/cGBhPR2Px5NX7CMaF4ihScY6raWj0Hkyjx5D18 sk/g== X-Forwarded-Encrypted: i=1; AHgh+RrMh8cFEazQ/X7IibVabF3xghXJ3ivR6C7/6Npm2SRw9NwdEWOdIn58HjhqSIjFlYaqo6PYU3ZPoTtd7iU=@vger.kernel.org X-Gm-Message-State: AOJu0YxkzeWizch+sB8ElsjqtGj8VfGwrrGzNKhzGdGdclVFhrenjbdo NH2iSm8rZ+6Ingpox9+b4CN87THN7zwk90l+962Rq4epRtfdhONl3vsF X-Gm-Gg: AR+sD122tTOaUYEOGK1Nqcf7oxknsmy4qrl4irsbhElaHXW+u/x7a/p7c4qvId1VcGD PknXN9zvoTntrDJX79tDO3p8dRMV4MGLJ/uWN89GEfGTB3L2k8t1cDX5+lGk/5kUEAbN5SA53gW rNMPNqYxd7KntQakuN5XCJ1dz19gA1GpUGIfQ1Qfn6QaOpJqz1ZWumZu7Fj/RIZdI3RmLCZuYoS Rlm6HsRVogMRmWLbYqCaAxy/Y8py5QiDXXONVGb+XsuU9UwmJtV0+k+zwvB2uFkcj9RZMmXjrzV u29AUUPdhKfOguixfptoQFwCfGvTD65wQPn0RuYZr0BSMAtr8j36mcbRDcR0m8XHk4Ng0BqDTO/ 1BIZKIJL+a/qKqYcMZ76oaNnluC9S+uEcMVmTtQ2ktUZEIVAvBRTjMYS/BVNVPe9z8KHLuWQEoJ 217yEaeKsJMbqAbRQ0JX0ecI/gPIKH87OuBbLLQyP8osI4+gxdWZRyo49yWtEcMeOlwX2QAVGly mtdxbGfh3FNA96ds3bBorQ= X-Received: by 2002:a05:6000:460a:b0:47f:8866:bd6a with SMTP id ffacd0b85a97d-47fec63a8ddmr13340683f8f.19.1785940949557; Wed, 05 Aug 2026 07:42:29 -0700 (PDT) Received: from LAPTOP-AVI.taile24b5.ts.net ([2a00:a040:1b7:4f41:6df7:ffe8:d01:255d]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47fec232333sm10094289f8f.18.2026.08.05.07.42.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Aug 2026 07:42:29 -0700 (PDT) From: Avi Weiss To: Andrew Morton Cc: David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Soheil Hassas Yeganeh , Arjun Roy , Eric Dumazet , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Avi Weiss Subject: [PATCH v2 2/3] mm/memory.c: simplify error handling in insert_pages() Date: Wed, 5 Aug 2026 17:42:18 +0300 Message-ID: X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Initialize error return status to zero and then set it as needed at each point of failure. Assign -ENOMEM explicitly when pte_alloc() fails as the pte_alloc() macro returns a boolean. Signed-off-by: Avi Weiss Acked-by: David Hildenbrand (Arm) --- mm/memory.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/mm/memory.c b/mm/memory.c index 8658feba8be9..11bb4fb98761 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -2434,20 +2434,22 @@ static int insert_pages(struct vm_area_struct *vma,= unsigned long addr, unsigned long curr_page_idx =3D 0; unsigned long remaining_pages_total =3D *num; unsigned long pages_to_write_in_pmd; - int ret; + int err =3D 0; more: - ret =3D -EFAULT; pmd =3D populate_to_pmd(mm, addr); - if (!pmd) + if (!pmd) { + err =3D -EFAULT; goto out; + } =20 pages_to_write_in_pmd =3D min_t(unsigned long, remaining_pages_total, PTRS_PER_PTE - pte_index(addr)); =20 /* Allocate the PTE if necessary; takes PMD lock once only. */ - ret =3D -ENOMEM; - if (pte_alloc(mm, pmd)) + if (pte_alloc(mm, pmd)) { + err =3D -ENOMEM; goto out; + } =20 while (pages_to_write_in_pmd) { int pte_idx =3D 0; @@ -2455,15 +2457,14 @@ static int insert_pages(struct vm_area_struct *vma,= unsigned long addr, =20 start_pte =3D pte_offset_map_lock(mm, pmd, addr, &pte_lock); if (!start_pte) { - ret =3D -EFAULT; + err =3D -EFAULT; goto out; } for (pte =3D start_pte; pte_idx < batch_size; ++pte, ++pte_idx) { - int err =3D insert_page_in_batch_locked(vma, pte, - addr, pages[curr_page_idx], prot); + err =3D insert_page_in_batch_locked(vma, pte, addr, + pages[curr_page_idx], prot); if (unlikely(err)) { pte_unmap_unlock(start_pte, pte_lock); - ret =3D err; remaining_pages_total -=3D pte_idx; goto out; } @@ -2476,10 +2477,9 @@ static int insert_pages(struct vm_area_struct *vma, = unsigned long addr, } if (remaining_pages_total) goto more; - ret =3D 0; out: *num =3D remaining_pages_total; - return ret; + return err; } =20 /** --=20 2.43.0 From nobody Sat Oct 3 03:52:40 2026 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B66619AD90 for ; Wed, 5 Aug 2026 14:42:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785940959; cv=none; b=KHizv2EdOlzdFbkg3W5ZMwAIY2tk4NZgGTDZ9JKBj5n7QzQIlZOGtpFkcyVuLjZ6wBAukA7aJ9fA7gpIjvweNEhHEq3NvxyCK4MmxUBrdggTbOWsfrE4Q3Lm5XvU7hHrOBooAYgqjc1lNgM/EWaRk9dYzPdQnB4eSx2utn+jpeg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785940959; c=relaxed/simple; bh=ZGZEVljx/pyqH7mFAASrVQDD3tuyOQrKBWVIRv5+8g0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=fwXjIqHLXNhF4s1xMub35qwk2LtPTElFWlqkrr/bAFrdXHTvNdg0jBy/7EvwmdrTT/UNhNCL5rl6xZydmkfpvnsLwhtv5xpACzMQ8jsiK+WQNqxeMjVDNMoo2wYOHCnM+77VnG4vfvfg0FADQnBSV12TfgNtU0bOB7Y5glPgv84= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=b74pPg2K; arc=none smtp.client-ip=209.85.221.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="b74pPg2K" Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-47f93b2fe4cso746378f8f.0 for ; Wed, 05 Aug 2026 07:42:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785940951; x=1786545751; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ld+XQ0JcCd/3+XlB4VjbGbKYAZ1iedXZLkBJ6yeGTpE=; b=b74pPg2KqVXzpGPapCnbkLL8ZShOuZIwMEmv+Ca4BtOvfBIxN1zftS2/REMSToyqHn JWg7VCxUT0IrlspMx82Ui3D3Y5hTSuDWsmE8rbRdeHcNgEE9QnFtNuObLc8vw4STbF7k TvU7xIZrxm/iI21pp/NPEsiVpRmP4kJhP/AI0KrZtRznd7LasrneTX1X+NI89RTmm+nQ SaIJ5P34nVFYevGGRtjX+fovT+Lqsy+Y0tmgfxdEQPy2UUVeykX9nnebmGOisR1gPnsA Ex5JAk/tmu1pLziiVerafyyfLAkid9IgyV3TjrlkTPaQuVnTVTO7qynedgLcAEgSluau GmBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785940951; x=1786545751; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=ld+XQ0JcCd/3+XlB4VjbGbKYAZ1iedXZLkBJ6yeGTpE=; b=PlRhRs1nq1jRloyKea51+3MQxVTq7+SA+E1+pYlEPh8k10nSH7jKVGzSNMqCYxB4BA JLxLZ2CyhTldAEvDID8RS5v+nNvQipgQhFjg2H6gYVJ9Xbo01T2sdummwgn1uZhAEDIo peu3s3iLD1TFRrV/4og3yBYcGWoy8mHfD4sfIVVJno3b/hsJ24mE7EpaOlzUj0l3B7lx FAmFRFGobGiOjI6PUgUEoVphH/IqVvNMR7zZOgiMx0h23Kw83dAA4vRRFJptAKg158io 2oiqU4CQljcJTiSzFMlKXY7EdMeTP69o5RfyRAuQYsVilb5/5s7tHMVH8RhallJgwSQD 96Uw== X-Forwarded-Encrypted: i=1; AHgh+RrvFnUc3q1nq3WS1HFSJNrjNZt1caQk3tezjqEgI2oLsOrbFo0jMD7UeXxtXkYaTBYmgccKdUq0Xw85ico=@vger.kernel.org X-Gm-Message-State: AOJu0YwdsNXkBG6e1lNr3Z9dlBRriwQgfs+PjYEGzVb42q/KAraNrw2V ne4eBB59i/UU6AqNUcDjQByy0+12cH8FDZc2/TdbE+plZFfynzIG2i7N X-Gm-Gg: AR+sD11tOChy+JkbkkzLWDxc9LyGWRxieiDbt2XKe2AtKXLfbo539s3uhI4ioq/LR+y XyHrz1OIr/FzpyiL1Zxq60X9O+9FBk6EM2xvZxVHW8YU3S/AS/vyeAqNK5Z3h3UKOVl+4UgxZJ3 I2bvMaD89CL3Kv+NxyEzK0SaQ4rQmSQq/g3eXHHg0822CrfCG22iFKKdQ4mG7751mc1GAN6Zuhu e16+lSMOILXXIANBbPhNtOz8tea1orWk+w2MB504K/IjQVkg7/uwhIFa8LqxiBzXdJGjttgTfP9 iloqosnb1IXlaaMnwF56pBg0lnECORvKoUVbC8YCRNih2ZmvGL01jBpDuxKSOFYo3u1pyO9Bxvz +xrrMKrqNFBo6tSBub8V6sugMXGGBkaj5CeGfpkFI1WvP7EEgdCE3CYp2dZh7/uVC5RuRdlkYZx TweSJQ2+VuUZQL/MCq7Zo3+qHG3ZjN7pjsnT1VJivCJU8SRpdtNZdJ01zrmSr6NWidxLFFVP+H5 4+f0ijar4fM X-Received: by 2002:a05:6000:2489:b0:47f:59ef:bbb2 with SMTP id ffacd0b85a97d-47fec634cecmr11644817f8f.17.1785940951438; Wed, 05 Aug 2026 07:42:31 -0700 (PDT) Received: from LAPTOP-AVI.taile24b5.ts.net ([2a00:a040:1b7:4f41:6df7:ffe8:d01:255d]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47fec232333sm10094289f8f.18.2026.08.05.07.42.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Aug 2026 07:42:31 -0700 (PDT) From: Avi Weiss To: Andrew Morton Cc: David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Soheil Hassas Yeganeh , Arjun Roy , Eric Dumazet , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Avi Weiss Subject: [PATCH v2 3/3] mm: return -ENOMEM for page-table allocation failure in insert_pages() Date: Wed, 5 Aug 2026 17:42:19 +0300 Message-ID: X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" populate_to_pmd() returns NULL only when p4d_alloc(), pud_alloc(), or pmd_alloc() fails. These are page-table allocation failures, but insert_pages() currently reports them as -EFAULT. Return -ENOMEM instead, consistent with the subsequent pte_alloc() failure and with the single-page insert_page() path, which reports failure of the same page-table allocation chain as -ENOMEM. Address and range validation failures in vm_insert_pages() continue to return -EFAULT. Keep the later -EFAULT return for pte_offset_map_lock(), which is not an allocation failure. Signed-off-by: Avi Weiss Acked-by: David Hildenbrand (Arm) Reviewed-by: Lorenzo Stoakes (ARM) --- mm/memory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/memory.c b/mm/memory.c index 11bb4fb98761..16093479d341 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -2438,7 +2438,7 @@ static int insert_pages(struct vm_area_struct *vma, u= nsigned long addr, more: pmd =3D populate_to_pmd(mm, addr); if (!pmd) { - err =3D -EFAULT; + err =3D -ENOMEM; goto out; } =20 --=20 2.43.0