From nobody Mon Jun 8 17:44:59 2026 Received: from SN4PR0501CU005.outbound.protection.outlook.com (mail-southcentralusazon11011058.outbound.protection.outlook.com [40.93.194.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 26A67283C83; Wed, 27 May 2026 18:19:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.194.58 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779905973; cv=fail; b=q7XLM5Du3vFYU2ZJDmcXLd6P7rw5z5pZY6uLrQax4uC3GXXuDYe2MqgWShl8jxgnIY2ORtiuP4qTPhDhvImr28cy65lIvHzad/P8FFTUAbud5v/lyadAr8EbhO337lMQTeRHkVkcPuo8h6wS0KQ5NQskVBI3CcClRXbFWSVROPA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779905973; c=relaxed/simple; bh=gN4K/a9PTfv7p71mlOEqk4O2gr3SUGhHDX622kowwIg=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=mSB21B1MvTQ+tOgfN+aYMqiqy4GoiXjb3bIVddOD7PIw4qd+L7OhrWaKe4Bj+Dgq2zCccq4YKUV3nglkSj8sYpIAHudxLjNG/RV5ciXY1cPIqNlFQPfLdTS0QspFAO/zSmHhXCq5Hxi7NwBnxNWUafNaGJxOyrbe7rvBziAMh70= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=YQelLEpI; arc=fail smtp.client-ip=40.93.194.58 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="YQelLEpI" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=MGfdwuXOHqJ3lxQO8BPtuVEmoTa+3Rd/UwZ/EKe8bHqT8LBejvMtr/ySpQxFpoet5gYNbQsO69umHBa7fdH8HYLA7l1i0Tol5PUvX522z3/I0FR7teb/Oyo3AJ9tbYIUB8mi+aU5wqjd8IMrNlmCOraWXoCYInkytEPmjlFgEqagg/61BUeBGya+aSGfQvowGvZTlPb2Kskt1jSq0wI7F/4GC0zBZfI90CmXm81jZXd5Up7fc0qEbD9Jjo5JJqaAncudA2r5qznjGI6/idrDvyVryN13NIJaqv8cGVPysBBgcr9XjQUzG7qEVXP/Kod1svaL9jGfCZwrDRp19PQGBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=siUhwQcZOxpzAFBCOdKBuU0TOIS0iMhCvqwiTh26uvQ=; b=tGMETlj/w86B5Vz97iyBWddfYhgH4OGpel8QenobIFRBa9eX5fuSnFhd33DXviCZuX25pYl6femRpNTHZ6DoF2XnAiqvJgvID0xUR35QnJGCELWowzSlyr+lEpDM8WgIShP0RauCOXrkDAXfwwJp1H3DUPRxud8lRjjEieOLsFw4tMTKCb9XQvb2p5XpbDc538elPcAzGpFhdMnnm7pmzi7y+UirAjF07IFZLEvaAEOicwul9cSRN8+cYzzxoPA4etEGFREJaa7TnQj874nfDv4dHHgXLysMjBhbXafx7VQJZypSyTySvZ90rVx8/xF9wmgiqvb493an7rtWTU3ORw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=microchip.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=siUhwQcZOxpzAFBCOdKBuU0TOIS0iMhCvqwiTh26uvQ=; b=YQelLEpIxmtNDQ1WjlExVIliWelvOF6OfG0ND5vv6Z0qg2auMRQrYe/hpfExxqS1ax5qJ8mitqjWwgFhXsdBk6PC1aqOLb9hlWxeSVChPtrli5H36UYjEatIW9A5Wu4qoJ9m9GaES+wa5dpX+3hfTwSh9evJFccJgyygXAqVZXxIFYCKhZPNbcGG22U1QAw4AUs40zILKaLvxOKh/jCgN8XhPmh5kPXPP88tClxA68BNeLsXleCWLlC14Dd2v32yIxDyBakXvvDtTtgeAIi2vyGnb1G3s/51MBoQnn8h9Aq3fpdVfn55M0MluC1QFd/N6Q8hJBdbhWuMvZ5u0kzHKA== Received: from DS7PR03CA0092.namprd03.prod.outlook.com (2603:10b6:5:3b7::7) by DS0PR12MB999079.namprd12.prod.outlook.com (2603:10b6:8:302::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.48.17; Wed, 27 May 2026 18:19:28 +0000 Received: from SA2PEPF000015C9.namprd03.prod.outlook.com (2603:10b6:5:3b7:cafe::31) by DS7PR03CA0092.outlook.office365.com (2603:10b6:5:3b7::7) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.71.13 via Frontend Transport; Wed, 27 May 2026 18:19:28 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by SA2PEPF000015C9.mail.protection.outlook.com (10.167.241.199) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.71.7 via Frontend Transport; Wed, 27 May 2026 18:19:28 +0000 Received: from rnnvmail202.nvidia.com (10.129.68.7) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Wed, 27 May 2026 11:19:06 -0700 Received: from rnnvmail202.nvidia.com (10.129.68.7) by rnnvmail202.nvidia.com (10.129.68.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Wed, 27 May 2026 11:19:06 -0700 Received: from vdi.nvidia.com (10.127.8.9) by mail.nvidia.com (10.129.68.7) with Microsoft SMTP Server id 15.2.2562.20 via Frontend Transport; Wed, 27 May 2026 11:19:06 -0700 From: David Thompson To: , , , , , , CC: , , David Thompson Subject: [PATCH net-next v2 1/2] net: lan743x: add "message level" module parameter Date: Wed, 27 May 2026 18:18:57 +0000 Message-ID: <4c240063db57c93541e3de61900a5d7adffdfd27.1779903597.git.davthompson@nvidia.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA2PEPF000015C9:EE_|DS0PR12MB999079:EE_ X-MS-Office365-Filtering-Correlation-Id: 41ad26a3-d812-4b1c-64d5-08debc1c7d7a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|36860700016|82310400026|376014|18002099003|22082099003|56012099006|11063799006; X-Microsoft-Antispam-Message-Info: awJLKUSIRjogwlxDuT1ogTyNUGW2IBvZTscnKGEL2NO6WVRxTT3r6Sggvm2UW2H8TUmJXr5fNxn0wcUBRXGMUXp8B1ZcKiNaz4WkRAQ7/sDsG6F2nKWE5UIjDASxMg/Sn8XWkYxKS9RMVqrpwZi7cESeOH823ot1GnXUlN1/+i8YLcSIzruYoH1lLuyAieUiP0j6kiasZjMjUwozjyZMhVuL8+9D2jQc0YocejaMj6gwNQKib3kGSGlSsyn0lBVAv7xJ02nW2oSLkH8i2lfeZP2u1mozKfKj62TiubXWsExpjV5z3gUEj+QUVHFfMTSYtgPk+akHRRbz55BisDW5BVXIQ+gFvf8pUFYpen+yeYl/JSJu5iZiY+Rl3UD1N/IvBsdIozzBHriIm3gqsv17Lc8BHmR/RbjgObn2Z4m8YY62X7CK2iXEUPrkuXezZR+W1FaWkvbHL8qF0dolqBb4YunS/vRX8bgDAo2NbM/6/hqaRU+zk+/0Rii5ACWqVXbtZVkV2Ltxi2LiOz/VtuAWbuELdP8zRlvsGPdnMClWGl+FfYlMos6D1rcdeLmAM/KSH0Fv20knmSZ70M7schMfpk2wAi2mZCMZo/bFl/FuRatEuZaKA7zxlKI+DVuBv3p0nsXRJH//jd1upYK2SWb7KXSIxzXhl0OMj1dHdr8mJdZlhyhiAoKs54t+ntabWb4X3/OLY8X0gY4zcQFQwnikT8UeJmTeqZxdKxK24VWzBGU= X-Forefront-Antispam-Report: CIP:216.228.117.161;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge2.nvidia.com;CAT:NONE;SFS:(13230040)(1800799024)(36860700016)(82310400026)(376014)(18002099003)(22082099003)(56012099006)(11063799006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: tZedFK5REpLCCX00A7opAz2fUEAjzomWEGePtjX353AkaAj8Mrtu9j+zy86WotWBmee54F0Qynk8GIVAMq2z54C4O3BsPjzhvuK7K0vEgCSEylYS4E1OznWZoNtpAc62v3TJK4lvN2WgJKKLS3Sf+iT9rkGJ8QNel633buiFGNWwzlzZt/09eMN4u0C5CvjNy1HRQZQvDafFba0MnWZWr9JTOWuASijRiv0hqqQqfeeYVQDdhvlfYN8i7beqMYiELmjsm+G97E0m5QlMFLYlIKJ+8gnCipRHtRH+IDUb9CphfVBRTG2ETez3MetnifJsyDDFteXLXeybYrgX9LbAqOTaBjxD/UrNWwGlJIIDXxQ67KtWwECQ++Fb5gtFEIor04eP42bH89rv6cokJfFGY7gsF4P9knSgNOned2QMseDHFwM8wXoVrfaGQ0KeqrEH X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 May 2026 18:19:28.2056 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 41ad26a3-d812-4b1c-64d5-08debc1c7d7a X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SA2PEPF000015C9.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB999079 Content-Type: text/plain; charset="utf-8" The lan743x driver currently hardcodes the initial value of the msg_enable parameter during probe(), and uses this value for netdev message logging. Instead, the driver should provide a "message level" module parameter to allow users to configure the logging level at load time. Signed-off-by: David Thompson --- v2: - new patch added in v2 --- drivers/net/ethernet/microchip/lan743x_main.c | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/microchip/lan743x_main.c b/drivers/net/et= hernet/microchip/lan743x_main.c index f3332417162e..793633cced19 100644 --- a/drivers/net/ethernet/microchip/lan743x_main.c +++ b/drivers/net/ethernet/microchip/lan743x_main.c @@ -28,6 +28,17 @@ =20 #define RFE_RD_FIFO_TH_3_DWORDS 0x3 =20 +#define LAN743X_DEF_MSG_ENABLE \ + (NETIF_MSG_DRV | \ + NETIF_MSG_PROBE | \ + NETIF_MSG_LINK | \ + NETIF_MSG_IFUP | \ + NETIF_MSG_IFDOWN | \ + NETIF_MSG_TX_QUEUED) +static int lan743x_msg_enable =3D -1; +module_param(lan743x_msg_enable, int, 0); +MODULE_PARM_DESC(lan743x_msg_enable, "Debug message level"); + static bool pci11x1x_is_a0(struct lan743x_adapter *adapter) { u32 dev_rev =3D adapter->csr.id_rev & ID_REV_CHIP_REV_MASK_; @@ -3661,9 +3672,7 @@ static int lan743x_pcidev_probe(struct pci_dev *pdev, pci_set_drvdata(pdev, netdev); adapter =3D netdev_priv(netdev); adapter->netdev =3D netdev; - adapter->msg_enable =3D NETIF_MSG_DRV | NETIF_MSG_PROBE | - NETIF_MSG_LINK | NETIF_MSG_IFUP | - NETIF_MSG_IFDOWN | NETIF_MSG_TX_QUEUED; + adapter->msg_enable =3D netif_msg_init(lan743x_msg_enable, LAN743X_DEF_MS= G_ENABLE); netdev->max_mtu =3D LAN743X_MAX_FRAME_SIZE; =20 of_get_mac_address(pdev->dev.of_node, adapter->mac_address); --=20 2.43.0 From nobody Mon Jun 8 17:44:59 2026 Received: from BL0PR03CU003.outbound.protection.outlook.com (mail-eastusazon11012062.outbound.protection.outlook.com [52.101.53.62]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4538346AF2D; Wed, 27 May 2026 18:19:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.53.62 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779905981; cv=fail; b=n7eM6d29Mg4hRtGqaeIX8oG7j+wqmJg7AXkaoKULW7z6nCNGsAn+o9ajBr7Dead2BDTOGcrp+Y4L8dyvIo1C9rSawrE4EN/0FE8otCJx5IRPyJ33praAwUiQHUjHPHXJEiLSsXEThLwrFJ6g9u+qWfUdGSLM+fi2fn6etNwwn9I= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779905981; c=relaxed/simple; bh=z8HlvWXiql2aZz6+i1Y/hTOXHxHJDtEO21vwcPOej+A=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=LPURH4+/oQRk+I7PeKPDpDCp5RyZSDAQipafobzxDh+InS18ocChL1LE1isTcpiJaeCaxDAjtS5vqGh91ilEO4OxZNx0DKAmA2ONWz8VLxacRlLrW2zNpfIpOKGOet42jyQsaxlkD6Afaccb+6Qi/f0HYL8Hs9g1LGgnVXc1K4E= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=MoE9R8Dm; arc=fail smtp.client-ip=52.101.53.62 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="MoE9R8Dm" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=e4QRvW07Z9alPT54kqZAFMUb95n6KOHmjdPK3bz7weoU7uiRTpQk+eQ6oqiAtyMjmKML2Vlbw5gtunQUuAyr9oMA5X/wNan42hzIUmTxr9Km8GUy8RbDCEE8lXm5Ky4IIy9ZpzArjbBvOHXJ7lQ03zEEN9nF/uenYUkKqlu21NpBwWGRK3RggKtX8gs7Dg5WDw8k5zYnPAPJcCkMKlZgoFDYMpOoW/ms2AkW/o5qxR+xwdy0IS+rOmq0jDwNfQRldMweS+IyO7VK3kW/JHDAYLqzqH1yVnTeOw8lD3rarCJQmz+OLTj7LtMgF/GvCeNWCkK0po0zAukpRnk1QkXygA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aj19Fcws16X5HU7Husnn1UIRXTtiGFwNvBb1WU97I3A=; b=l+JybX3d0LPtSY9MZF0WayAnwpSwqSW7H6ugWPx9g/3evN3IyPC114o1VgpQz9f3zH3kiSLbAIezKElB7YprpnwkKyBsfCQ9pym2bMhoB84g+XjQEEpqWxLNRKguQvjWfRKvy5Ijxdl8kRPtyU+AiY5y5oPrzoC3jl0oJnHDlKHLbvplTZXyZXOgNOL7qvQxpNlH4H74nI6PTVkvH6jURDPNyefSP7go5Eo1pCTEZb500mQh+H2wKVFrrCHrYia0Wpyr52Cg5rSbTtfVMgrJ9I9UPlT0LHLzvZW18gI8Cu2tGdFXqGmJcOCw4ZR5xOES3Fmu1bbx6nx/aw7887lawg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=microchip.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aj19Fcws16X5HU7Husnn1UIRXTtiGFwNvBb1WU97I3A=; b=MoE9R8DmxP3iKU/wESW/uXM4LGsV4sqetHq9h8iKdUUTGLBjulRZPrjM10tetCROSsv4HR2z8DongUGw6d6PTauvVZ+WtlSj/lv+VYqnB3HbKKNwBjt2rdvDafWdBmGDQdc2OnqnBa5CNSf9wi6ooXBmKA8uhnWezDpr3snAkal8QQ7Zm0fX4vvUOI38xJGwt/rYQTPdEHCtA9d1ctjW/gSCpdt9HKwOw7QE69gwk/bzv6TfpuesAadEbB1sypdeA2d/nLr/njScrQqr1Y8pykphMYO2+XhVvmycVjMgbnNDBqgUyAYqQA016JmJKfIupYDurg7iGfJ3qkHgvFMAdw== Received: from DS1PR05CA0009.namprd05.prod.outlook.com (2603:10b6:8:457::6) by DM6PR12MB4402.namprd12.prod.outlook.com (2603:10b6:5:2a5::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.48.18; Wed, 27 May 2026 18:19:31 +0000 Received: from SA2PEPF000015C7.namprd03.prod.outlook.com (2603:10b6:8:457:cafe::78) by DS1PR05CA0009.outlook.office365.com (2603:10b6:8:457::6) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.92.4 via Frontend Transport; Wed, 27 May 2026 18:19:30 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by SA2PEPF000015C7.mail.protection.outlook.com (10.167.241.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.71.7 via Frontend Transport; Wed, 27 May 2026 18:19:30 +0000 Received: from rnnvmail202.nvidia.com (10.129.68.7) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Wed, 27 May 2026 11:19:09 -0700 Received: from rnnvmail202.nvidia.com (10.129.68.7) by rnnvmail202.nvidia.com (10.129.68.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Wed, 27 May 2026 11:19:09 -0700 Received: from vdi.nvidia.com (10.127.8.9) by mail.nvidia.com (10.129.68.7) with Microsoft SMTP Server id 15.2.2562.20 via Frontend Transport; Wed, 27 May 2026 11:19:09 -0700 From: David Thompson To: , , , , , , CC: , , David Thompson Subject: [PATCH net-next v2 2/2] net: lan743x: avoid netdev-based logging before netdev registration Date: Wed, 27 May 2026 18:18:58 +0000 Message-ID: <8909217245395f6418cdc2699147511c443085e4.1779903597.git.davthompson@nvidia.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA2PEPF000015C7:EE_|DM6PR12MB4402:EE_ X-MS-Office365-Filtering-Correlation-Id: 4c096982-c542-4ec0-80ed-08debc1c7ee9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700016|376014|1800799024|82310400026|6133799003|11063799006|18002099003|22082099003|56012099006; X-Microsoft-Antispam-Message-Info: bysj4sRpdXXf+/yQc66PiAA6yv5muJbyY016z+uM2AduPVBZnw9YI92TpgQ1/byWTw3xJfRGU6ZO//t5r8YtjyIfjYQb6iOOWen6QqiRs7c5uPBALgNA4Dyuukmrbf4ar07YqIDo2orQ/6LpZMBjWCSUoo1PCCWbe52vwW/97bTR2ygOokf4kIwhl4nQD+hL3aRfqlDa5PP5F3LPop70KZPFmuJ4BHDHqWBARltHyM81yEhdBvGRkOqRVew+3BTbOlmIapHSWCfG1WH1L79PSaQYmv7/gDgNBcCUP/VzO6ZJL172Q+CDL8mBotKzdgDjClv5miyudHb+ygmZ94Pk7YJi8xMGe+6QY7ySog4KE9y2f/JBhFH/yGUS3tITmYzljXLwSBwAYwGgmB8JP3778qcd/r3RgQUAXBEyEOUReQKMeoPKTpbB+MyKALt9m/4JjTN+G5NnY1YfNAIEIL8cTxXTJ8dJjqQudwnM1wAj3UH2heL2ni/ynknPy/VJnm/BHX3SjJOYQ6WijoMuIJ7M9xoi7HI/HmDvm0YXM+nd7lZFNl4iG0Gh8HrPr9IDVYw0Muo638u8OdAVUuMYT6RigFzeMB2SWRnH+pNtoBck0AKrIKfNPXhx0RK9DpCdBufzFJyL3/r/ppNzm1dZIMqpka1sN6NbWxAJgVS82SRL8F2ukqGWtVjDPNcQpkb/RImfJImhEXwtM5TldPvSLtlbJ+i8BakigJkgnD4pS5nSGtA= X-Forefront-Antispam-Report: CIP:216.228.117.161;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge2.nvidia.com;CAT:NONE;SFS:(13230040)(36860700016)(376014)(1800799024)(82310400026)(6133799003)(11063799006)(18002099003)(22082099003)(56012099006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: kmdtQx4QS6S2zsoBPw5FTuVNmBrwhgZYaH8S1UKxCNj97a3C55H2f0E4VZ4il+YQXyoIwOydXK7wnqhKlHXqImJQD6z1nHAzzjGu0fcHIwSNxGE9N7FseMGV8gM2ok+SO+LwnqZ3qoA3XQSO8Yw3cyJfmGlqhSBnPb1Tegv/kArgeIm3sYJTc2/oltRc5dq69LLsTYJIGa3Ohoy+I9HEZRcbLqd7sC09uF47maKESSApsV44fHLRpqOoNZwjUMmZ429QkI1ZRUre6PPTiwKRHKH/ZIlMkSy0Pfi04sFyN07o+vkb8WTU/mrTP398JsHa9wBE+xh4cON6R52Pj6GXUO1mjJc1Sgl7TaKL3Bgx4KpEj725GCiOQVMB2aocBczgzBULthFPMfS+mo2kFEN4YI0kMa1MuRkVY6/ZrtF9uBRCQKnmGl4agfscLwfjeyiB X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 May 2026 18:19:30.6162 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4c096982-c542-4ec0-80ed-08debc1c7ee9 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SA2PEPF000015C7.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4402 Content-Type: text/plain; charset="utf-8" This patch updates the lan743x driver to prevent the use of netdev-based logging APIs (such as netdev_dbg) before the network device has been successfully registered. Using netdev-based logging prior to registration results in log messages referencing "(unnamed net_device) (uninitialized)", which can be confusing and less informative. The driver must use netif_msg_ APIs and device-based logging (e.g. dev_dbg) until netdev registration is complete. This ensures log entries are associated with the correct device context and improves log clarity. After registration, netdev-based logging APIs can be used safely. Signed-off-by: David Thompson --- v2: - Changed target repo from "net" to "net-next" - Removed "Fixes" tag --- drivers/net/ethernet/microchip/lan743x_main.c | 72 ++++++++++++------- 1 file changed, 45 insertions(+), 27 deletions(-) diff --git a/drivers/net/ethernet/microchip/lan743x_main.c b/drivers/net/et= hernet/microchip/lan743x_main.c index 793633cced19..bca2f3d1ad41 100644 --- a/drivers/net/ethernet/microchip/lan743x_main.c +++ b/drivers/net/ethernet/microchip/lan743x_main.c @@ -119,9 +119,10 @@ static int lan743x_pci_init(struct lan743x_adapter *ad= apter, if (ret) goto return_error; =20 - netif_info(adapter, probe, adapter->netdev, - "PCI: Vendor ID =3D 0x%04X, Device ID =3D 0x%04X\n", - pdev->vendor, pdev->device); + if (netif_msg_probe(adapter)) + pci_info(pdev, + "PCI: Vendor ID =3D 0x%04X, Device ID =3D 0x%04X\n", + pdev->vendor, pdev->device); bars =3D pci_select_bars(pdev, IORESOURCE_MEM); if (!test_bit(0, &bars)) goto disable_device; @@ -203,10 +204,11 @@ static int lan743x_csr_init(struct lan743x_adapter *a= dapter) =20 csr->id_rev =3D lan743x_csr_read(adapter, ID_REV); csr->fpga_rev =3D lan743x_csr_read(adapter, FPGA_REV); - netif_info(adapter, probe, adapter->netdev, - "ID_REV =3D 0x%08X, FPGA_REV =3D %d.%d\n", - csr->id_rev, FPGA_REV_GET_MAJOR_(csr->fpga_rev), - FPGA_REV_GET_MINOR_(csr->fpga_rev)); + if (netif_msg_probe(adapter)) + dev_info(&adapter->pdev->dev, + "ID_REV =3D 0x%08X, FPGA_REV =3D %d.%d\n", + csr->id_rev, FPGA_REV_GET_MAJOR_(csr->fpga_rev), + FPGA_REV_GET_MINOR_(csr->fpga_rev)); if (!ID_REV_IS_VALID_CHIP_ID_(csr->id_rev)) return -ENODEV; =20 @@ -964,8 +966,9 @@ int lan743x_sgmii_read(struct lan743x_adapter *adapter,= u8 mmd, u16 addr) u32 val; =20 if (mmd > 31) { - netif_err(adapter, probe, adapter->netdev, - "%s mmd should <=3D 31\n", __func__); + if (netif_msg_probe(adapter)) + dev_err(&adapter->pdev->dev, + "%s mmd should <=3D 31\n", __func__); return -EINVAL; } =20 @@ -994,8 +997,9 @@ static int lan743x_sgmii_write(struct lan743x_adapter *= adapter, int ret; =20 if (mmd > 31) { - netif_err(adapter, probe, adapter->netdev, - "%s mmd should <=3D 31\n", __func__); + if (netif_msg_probe(adapter)) + dev_err(&adapter->pdev->dev, + "%s mmd should <=3D 31\n", __func__); return -EINVAL; } mutex_lock(&adapter->sgmii_rw_lock); @@ -1226,8 +1230,14 @@ static void lan743x_mac_set_address(struct lan743x_a= dapter *adapter, lan743x_csr_write(adapter, MAC_RX_ADDRH, addr_hi); =20 ether_addr_copy(adapter->mac_address, addr); - netif_info(adapter, drv, adapter->netdev, - "MAC address set to %pM\n", addr); + if (netif_msg_drv(adapter)) { + if (adapter->netdev->reg_state =3D=3D NETREG_REGISTERED) + netdev_info(adapter->netdev, + "MAC address set to %pM\n", addr); + else + dev_info(&adapter->pdev->dev, + "MAC address set to %pM\n", addr); + } } =20 static int lan743x_mac_init(struct lan743x_adapter *adapter) @@ -1381,8 +1391,9 @@ static void lan743x_phy_interface_select(struct lan74= 3x_adapter *adapter) else adapter->phy_interface =3D PHY_INTERFACE_MODE_RGMII; =20 - netif_dbg(adapter, drv, adapter->netdev, - "selected phy interface: 0x%X\n", adapter->phy_interface); + if (netif_msg_drv(adapter)) + dev_dbg(&adapter->pdev->dev, + "selected phy interface: 0x%X\n", adapter->phy_interface); } =20 static void lan743x_rfe_open(struct lan743x_adapter *adapter) @@ -3179,7 +3190,7 @@ static int lan743x_phylink_create(struct lan743x_adap= ter *adapter) } =20 adapter->phylink =3D pl; - netdev_dbg(netdev, "lan743x phylink created"); + dev_dbg(&adapter->pdev->dev, "lan743x phylink created"); =20 return 0; } @@ -3592,30 +3603,36 @@ static int lan743x_mdiobus_init(struct lan743x_adap= ter *adapter) adapter->mdiobus->priv =3D (void *)adapter; if (adapter->is_pci11x1x) { if (adapter->is_sgmii_en) { - netif_dbg(adapter, drv, adapter->netdev, - "SGMII operation\n"); + if (netif_msg_drv(adapter)) + dev_dbg(&adapter->pdev->dev, + "SGMII operation\n"); adapter->mdiobus->read =3D lan743x_mdiobus_read_c22; adapter->mdiobus->write =3D lan743x_mdiobus_write_c22; adapter->mdiobus->read_c45 =3D lan743x_mdiobus_read_c45; adapter->mdiobus->write_c45 =3D lan743x_mdiobus_write_c45; adapter->mdiobus->name =3D "lan743x-mdiobus-c45"; - netif_dbg(adapter, drv, adapter->netdev, - "lan743x-mdiobus-c45\n"); + if (netif_msg_drv(adapter)) + dev_dbg(&adapter->pdev->dev, + "lan743x-mdiobus-c45\n"); } else { - netif_dbg(adapter, drv, adapter->netdev, - "RGMII operation\n"); + if (netif_msg_drv(adapter)) + dev_dbg(&adapter->pdev->dev, + "RGMII operation\n"); // Only C22 support when RGMII I/F adapter->mdiobus->read =3D lan743x_mdiobus_read_c22; adapter->mdiobus->write =3D lan743x_mdiobus_write_c22; adapter->mdiobus->name =3D "lan743x-mdiobus"; - netif_dbg(adapter, drv, adapter->netdev, - "lan743x-mdiobus\n"); + if (netif_msg_drv(adapter)) + dev_dbg(&adapter->pdev->dev, + "lan743x-mdiobus\n"); } } else { adapter->mdiobus->read =3D lan743x_mdiobus_read_c22; adapter->mdiobus->write =3D lan743x_mdiobus_write_c22; adapter->mdiobus->name =3D "lan743x-mdiobus"; - netif_dbg(adapter, drv, adapter->netdev, "lan743x-mdiobus\n"); + if (netif_msg_drv(adapter)) + dev_dbg(&adapter->pdev->dev, + "lan743x-mdiobus\n"); } =20 snprintf(adapter->mdiobus->id, MII_BUS_ID_SIZE, @@ -3705,8 +3722,9 @@ static int lan743x_pcidev_probe(struct pci_dev *pdev, =20 ret =3D lan743x_phylink_create(adapter); if (ret < 0) { - netif_err(adapter, probe, netdev, - "failed to setup phylink (%d)\n", ret); + if (netif_msg_probe(adapter)) + dev_err(&pdev->dev, + "failed to setup phylink (%d)\n", ret); goto cleanup_mdiobus; } =20 --=20 2.43.0