From nobody Mon Jun 8 21:46:09 2026 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D89293CFF44 for ; Tue, 26 May 2026 08:54:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779785652; cv=none; b=rqKmv4vv9Va7yid15bIfvHyzLfCbzrgmETM2SiFsuxMdjdnvRNMXGmIRfpNC82amGEhuTNf9W4dMWKM+lSX+uKoL37pUaRpOVYlGLsh+Hd9mfCXLYv3Es7zjpQr0D9H5cRghMOurh1zIQmggOHACnlXnq3DIhtKaA/QqKxsc2X0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779785652; c=relaxed/simple; bh=RrMBgPib/thu9oeiDhV5/5eX2V7QsjYTMu7AxXFeZDM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=NeheiE+UXYvo2JGwAW8lhq8ADjowYyu/vMcBoO6QScsDwvdJKpnIv543MCnqmvTTdRiCnEFqfaacfT6B+abuUoOwnYiG+JlX/o/4ND3mei2A5Xjg26tZP3Dfp60T4BydzXa2x2E6eP/iTditxYNJFvjjBLvXhfng+eZtN1LVvOE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=oEWeN3OX; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="oEWeN3OX" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-4891b0786beso69438985e9.1 for ; Tue, 26 May 2026 01:54:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1779785649; x=1780390449; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8Nv4uVlsgH0oU163SeHDh1CxvlHzGOdg8eSrDYJi3Qs=; b=oEWeN3OXhytGFpmwGn7waul+/8LuYyH0BHq+7XUNrA8btjxHZU+ZFmt1bR2C/tBpq/ Je5JamVJbhzd0U2ZAudJir1+D6XOoZhBHw7d6zzLcFQn9jtzrB9CDXrB4YkbdlKjpcb1 4eu+3dUKgK71Qd2SopU5TkaEDS9PiAion23YKOGtMqS7eWnvirq2ZW8Q/Zk0Ho7dA61T zpt8xwi8VXHA7bQxSK+8Nqh1ccnQEl5w/hQagFXzTIr7dl4fe4wGoe5S7Od77Se5UKhh WyHljpVU0EUi1jyU7s+6z/1to6V1bcdHe6bVxOJ1CX3t8FBhZgFpfFyu+R4hgUJp660e 47Lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779785649; x=1780390449; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=8Nv4uVlsgH0oU163SeHDh1CxvlHzGOdg8eSrDYJi3Qs=; b=qDWFb4m0VhOB+7vHn9rHu9Q3fM0jbET6uj9fLuvMN4MvWJlsX4J2XFEYPacrWEs0yT QAuS2eTRrOBpFKkYmETpKbZmgzJVDUCvPqPsi8y+RWxmTQeogqbnADcFcVhEl91y8YPE EWRyj9zPhxS/bs4fAg8caO2MPdG/sg8Y+ZeWyw0lHOeXZanWPLSeDjhIpiezq06pRhY/ iTGdyx7/gZt/74k0uuRez6qTCCb9XvRJsIiNROCINMHMMWSPuNCCFHElUa50Z+z7sMQl 8cxlISWBfTdHy5HL9oGaphac0KqxpICTnKVqLSfkJFBYcd891u5+9zOFUkVMO8/Z4S8N g9KQ== X-Gm-Message-State: AOJu0YzgXNFxNSIJE1nSSPUb8ZUbFQQEYfka8OxDlKoy5g7q9TZ3BNg4 lQcRkzGOQdyiwZaJyNw32y0ThmPZbS6I7xkDSC91ajsT+hkOUqsjw/XY36SVWkw6004= X-Gm-Gg: Acq92OH7rKAsqoFi+VRoKxF6vSYd2lW/COEtz1BXISErMzS+UTaikoS4WR73DorX8jX 4HzBpXAa4PE7SZ8x7/YpyZNj2TdfgbdETTTU9OUvnXMY8mrXsJVrp2BV/1tf239X94jla0kzb6T z5RAsdEpP3QfsX4aua2EacUpSFxfTiA1w8LlUjb09Kh+z52NrhRuYg8QQ9HvO3HXOlZ2xq1cPHH 5BuOvWVravJLSubtKU7T6UFnoryN/gxR+Y4nE++TslkMK6qwiiZGmi+tig9TrUc2lv3AGhePaFa 4O1CGEPhrptZkRwwa5MV3Kf60iCVycG0PYRMAabE6eD0xmcYFmytsLXzxk7bwsFGsxfzxzAakV7 ublW5jqAimOrLqQcq9SBcjzADgmg02qvR4aLY43lzvsmKFFoJ1rFJxfs/YkSrpDlyDzOf7De/Xi RaUIB9Q6h3jy3l5kNI/NkW92FWVfrXCNvCbTU3uRm2HEhS7DB0fwOxDNVcbScEyEeP4bM3oo+ff GhAV15Ok5x2VdESKs5slNjG X-Received: by 2002:a05:600d:6413:20b0:48a:9540:1a3a with SMTP id 5b1f17b1804b1-49042495183mr219782715e9.8.1779785649230; Tue, 26 May 2026 01:54:09 -0700 (PDT) Received: from localhost (p200300f65f47db047ec792ae18ec05cd.dip0.t-ipconnect.de. [2003:f6:5f47:db04:7ec7:92ae:18ec:5cd]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-45eb6d5e363sm34632285f8f.28.2026.05.26.01.54.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 May 2026 01:54:08 -0700 (PDT) From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig=20=28The=20Capable=20Hub=29?= To: Arnd Bergmann , Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org Subject: [PATCH v1 1/3] misc: pch_phub: Complete enum usage for device identification Date: Tue, 26 May 2026 10:52:07 +0200 Message-ID: <8a97d9d5fb0a4abf7032324643e3e2337b1347bd.1779785111.git.u.kleine-koenig@baylibre.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1919; i=u.kleine-koenig@baylibre.com; h=from:subject:message-id; bh=RrMBgPib/thu9oeiDhV5/5eX2V7QsjYTMu7AxXFeZDM=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBqFV893FLREAiiPLSvFrBM9FDIVTgLRH90pGG8T 98FI00QjgqJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCahVfPQAKCRCPgPtYfRL+ Tns9B/0bgseVV+Sk89AflCEYrPaiAZgoVUFsqbuwMaEVGjD9zuFrHoMjfpAxs1KGltH52Mh2PH+ E2r6jmL7CRW/bxNuApv4wR/hb+lv6zWusOHAXjrW9O59xY7UPa2UPSJrJAjNlET0WpZDecqTUOQ P+SmwQxeEAWXPQPdQt8piIUd+R07X3c/jdUcRDbAl/9dMMYBpRuiHn/biHcIgAXH7snE9FE2f9i FPnang0X/6FD0n/wkuEqlZbkn0OrDkCPQSR142ELMBVNSJ+aaCFEMurf25gY5tkflkxIxM00rKY thphnsyH+/DtxEL8m4C8uoNKMQCZNTXr2ym8HZ3M+GLiksM8 X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable Recently an enum was introduced to identify the different hardware variants instead of magic constants. The respective commit however missed to adapt one code location that still checks the old values. As the values shifted by one this is a relevant fix. Fixes: 7b1d4ad96ea4 ("misc: pch_phub: Introduce an enum for device indentif= ication") Signed-off-by: Uwe Kleine-K=C3=B6nig (The Capable Hub) --- drivers/misc/pch_phub.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/misc/pch_phub.c b/drivers/misc/pch_phub.c index 19c4fa017f24..0097611b97af 100644 --- a/drivers/misc/pch_phub.c +++ b/drivers/misc/pch_phub.c @@ -83,6 +83,14 @@ =20 #define PCH_PHUB_OROM_SIZE 15360 =20 +enum pch_phub_type { + PCH_EG20T, + PCH_ML7213, + PCH_ML7223M, + PCH_ML7223N, + PCH_ML7831, +}; + /** * struct pch_phub_reg - PHUB register structure * @phub_id_reg: PHUB_ID register val @@ -125,7 +133,7 @@ struct pch_phub_reg { void __iomem *pch_phub_extrom_base_address; u32 pch_mac_start_address; u32 pch_opt_rom_start_address; - int ioh_type; + enum pch_phub_type ioh_type; struct pci_dev *pdev; }; =20 @@ -344,7 +352,7 @@ static int pch_phub_write_gbe_mac_addr(struct pch_phub_= reg *chip, u8 *data) int retval; int i; =20 - if ((chip->ioh_type =3D=3D 1) || (chip->ioh_type =3D=3D 5)) /* EG20T or M= L7831*/ + if (chip->ioh_type =3D=3D PCH_EG20T || chip->ioh_type =3D=3D PCH_ML7831) retval =3D pch_phub_gbe_serial_rom_conf(chip); else /* ML7223 */ retval =3D pch_phub_gbe_serial_rom_conf_mp(chip); @@ -537,14 +545,6 @@ static const struct bin_attribute pch_bin_attr =3D { .write =3D pch_phub_bin_write, }; =20 -enum { - PCH_EG20T, - PCH_ML7213, - PCH_ML7223M, - PCH_ML7223N, - PCH_ML7831, -}; - static int pch_phub_probe(struct pci_dev *pdev, const struct pci_device_id *id) { --=20 2.47.3 From nobody Mon Jun 8 21:46:09 2026 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4D1343CF693 for ; Tue, 26 May 2026 08:54:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779785653; cv=none; b=nUTLretvM57kuy8lvVApURrPxjZF35H/txpS34I7we3O22c4ZbpZGEdKEX6KmR4OW2DMjH0wB6M6OcP0RqyUodygKXHx+knuXkvFWqNmfKx/raHMkCXIMqSPaBzq+HOwyER/GNIbuZM/zmo92tHUqVitbdpcTZnqkqSD5qgV+cs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779785653; c=relaxed/simple; bh=wki0xjQ/p0vPHqE/bWZ7yMtfYN8d0jsB36oNdqHsGdo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=F02Mk9CoyXCunZnfWfIcY9qYpSzJu7HJ4QAiubkl8D08u6hDKYBxuD9FxzAIUCl8PkRT7/yRHTNwIwFP4MQMekpcit1cvREY7f4bOyE3qGP7LrNYclzjgIgP/E8LOgelGYMQA0tEl6iC/QCrnpSrlYI/TWzRP4mGElNtLZmkqnY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=BVrjyppy; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="BVrjyppy" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-490686877a1so11731675e9.0 for ; Tue, 26 May 2026 01:54:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1779785650; x=1780390450; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=O/I5IB6ZumltG0Sv+YaUc0JPVcsEmjHv2omykN4+lLY=; b=BVrjyppytqgQI5NrNLEDzhZ2AeZnog+q68Rm2VxGA1kP/QXjx34H6aypJDrYVX8LfC +b7aQXFN8kt5DCf+ey6pE1e5GoYBlwLTyWl3kzvy/3UTBl5DHmuWdfcnCGffrvfMFhM3 Oe+75owf0Ll3668Vwxv4C5/EYZdNwGy9noKdFSIMkdXyIzt9ERcaBT6gP/82z4RSOVHq 8B+Wji2xpY+8yEdGcyijkbpIdGT0K/RdDUeI2EyiLeho0woapOlWB8RXJNkNIQJIVY9E 0JpNLDBABjiaWt1F5LkhEGnFn5WcXp1HRoOeSpWyKQar5DWh7grrldcM6SHwG5cw5XLa 69Yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779785650; x=1780390450; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=O/I5IB6ZumltG0Sv+YaUc0JPVcsEmjHv2omykN4+lLY=; b=N0x9d0wro28joC4AYfbuWHTcaucwGNOD7uKdYyXTK69TjvrJyoX0G2jIcLLdD5Gth5 9wuPTv8gJ4KKiCjiWjWQyUv6ssDYGGhdqLqOz3V+YQivlYohiQ24p0kUeBHZCP5n84YM IJqeW83dtdVIQaSgeUhTzkmRwHZ0lcShhzHSiluGhfeGKLKNCQOjI0yTeySbEWB/ROLg lxWw7VdlJ3LBG4LX167PpQFSfk9ytagzrM/oGlgpIPUIIoiAtYt602S+t4euNppKgHzO pftaqRBTUTJbBjGLcTq4mOKFo7BukB7IJsuB5AAtxTG4ohuGBA0q4S+R9Pi0RVXawxCX 4jUA== X-Gm-Message-State: AOJu0YzrXNsF8x1azSUWUeR9h8OiuPZEAaAWWLndFQ0G7zHQjgna5bSw +n9h0GvxkD9xaWp+qKzefw8H70Pewvfr4G3AeVR4TmTtuHZWJfvOo7lyJrvTXGzpNN4= X-Gm-Gg: Acq92OFuvcgupYYrBI1Ia1roV6dfTpGu9/Fozf1gpCU4XQ/9cMmeD4M57kQtdjCQh7x FTAHO635htWd6ggfnmhbSi3o64pWibdu2sI6tXhSaofu3FAVPMiQq6BsALHMew52O3BBtS4HZJg I5IhAEAyupbU/XlrytJdPUyf1+22cu8B/oOnbyb2nOCT0Gi8Fm+7T6HWHVIcMTGLqBbQsgX64rU HShXzsWkxatcvedr3XE/K/sTNLZ3qGxoZmzwCG0giIbWDjd0zrP/DzOrGlfmMe//KunAXaiPE+K xxLJNGMwTBJDNfAKaUIvuxwwB0i8riggPomyIr9ycuJCE9pQQ1MiXLQxdKmoV+ZZUsgU/bFOS7s Y9OiP6j/Sh1addRPHHekne8UkVf3V/uHzpqJrVQQx8OAtYaHUxiYXaeOAejavxLi/lGEkv2zeNr 3q5MYb+4R6Sn14WTeUew/857xIiwLCplOeiKiA1+UC3huWiIFU+vGjaz99dloYH/XUZMznfSKL0 Nv/bi/dMU0j+tJw7q62TBPX X-Received: by 2002:a05:600c:1d19:b0:48a:761:5816 with SMTP id 5b1f17b1804b1-4904245fe58mr249474065e9.8.1779785650556; Tue, 26 May 2026 01:54:10 -0700 (PDT) Received: from localhost (p200300f65f47db047ec792ae18ec05cd.dip0.t-ipconnect.de. [2003:f6:5f47:db04:7ec7:92ae:18ec:5cd]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-490454c60b5sm339740685e9.1.2026.05.26.01.54.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 May 2026 01:54:10 -0700 (PDT) From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig=20=28The=20Capable=20Hub=29?= To: Arnd Bergmann , Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org Subject: [PATCH v1 2/3] misc: pch_phub: Drop unused members from struct pch_phub_reg Date: Tue, 26 May 2026 10:52:08 +0200 Message-ID: <459d402dad63a6cc0e230b6f2305556bb915579c.1779785111.git.u.kleine-koenig@baylibre.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=2254; i=u.kleine-koenig@baylibre.com; h=from:subject:message-id; bh=wki0xjQ/p0vPHqE/bWZ7yMtfYN8d0jsB36oNdqHsGdo=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBqFV9ATO0+aMMnSiaFe5VTkBAB2t9moqfVE+6zG KrYtkAtUD+JATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCahVfQAAKCRCPgPtYfRL+ TguNCACJnYhBWBIO86AGgTJ/LSqwgIjfiZpFPtbLYUxFFDr4IluOg+mHxTSQqqtXBHXjmRMe+Bm DwzQkRrxByMHa3egnK3LhiPapXanjYJD2SdlK8ipsFpmMGWT71Pl6cc/0Ld3QZnpEKFmYKnmaLZ aw57VaSuZWX5LwNf6qjoffpec9VkDx2GpSoPYdej/rq2lPjGXgQVm23Pj6C1k+/9PDZE6FTnAkr xqRxCm/LW4ALgKKsxSU7FF5bJMV5DwC4VbvKuZO6vD1pj8ZTizp2Xm9Ci9vt727YZm1O8ee1Fvg sKrIXb/geSxkqEd3gnxgV5InfeobctY6EMZKQhPViUb9kAm6 X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable Since commit d14b649fd99f ("misc: pch_phub: Drop two unused functions") all the register values in struct pch_phub_reg are unused. Drop them. Signed-off-by: Uwe Kleine-K=C3=B6nig (The Capable Hub) --- drivers/misc/pch_phub.c | 28 ---------------------------- 1 file changed, 28 deletions(-) diff --git a/drivers/misc/pch_phub.c b/drivers/misc/pch_phub.c index 0097611b97af..5adf7f0c84ab 100644 --- a/drivers/misc/pch_phub.c +++ b/drivers/misc/pch_phub.c @@ -93,20 +93,6 @@ enum pch_phub_type { =20 /** * struct pch_phub_reg - PHUB register structure - * @phub_id_reg: PHUB_ID register val - * @q_pri_val_reg: QUEUE_PRI_VAL register val - * @rc_q_maxsize_reg: RC_QUEUE_MAXSIZE register val - * @bri_q_maxsize_reg: BRI_QUEUE_MAXSIZE register val - * @comp_resp_timeout_reg: COMP_RESP_TIMEOUT register val - * @bus_slave_control_reg: BUS_SLAVE_CONTROL_REG register val - * @deadlock_avoid_type_reg: DEADLOCK_AVOID_TYPE register val - * @intpin_reg_wpermit_reg0: INTPIN_REG_WPERMIT register 0 val - * @intpin_reg_wpermit_reg1: INTPIN_REG_WPERMIT register 1 val - * @intpin_reg_wpermit_reg2: INTPIN_REG_WPERMIT register 2 val - * @intpin_reg_wpermit_reg3: INTPIN_REG_WPERMIT register 3 val - * @int_reduce_control_reg: INT_REDUCE_CONTROL registers val - * @clkcfg_reg: CLK CFG register val - * @funcsel_reg: Function select register value * @pch_phub_base_address: Register base address * @pch_phub_extrom_base_address: external rom base address * @pch_mac_start_address: MAC address area start address @@ -115,20 +101,6 @@ enum pch_phub_type { * @pdev: pointer to pci device struct */ struct pch_phub_reg { - u32 phub_id_reg; - u32 q_pri_val_reg; - u32 rc_q_maxsize_reg; - u32 bri_q_maxsize_reg; - u32 comp_resp_timeout_reg; - u32 bus_slave_control_reg; - u32 deadlock_avoid_type_reg; - u32 intpin_reg_wpermit_reg0; - u32 intpin_reg_wpermit_reg1; - u32 intpin_reg_wpermit_reg2; - u32 intpin_reg_wpermit_reg3; - u32 int_reduce_control_reg[MAX_NUM_INT_REDUCE_CONTROL_REG]; - u32 clkcfg_reg; - u32 funcsel_reg; void __iomem *pch_phub_base_address; void __iomem *pch_phub_extrom_base_address; u32 pch_mac_start_address; --=20 2.47.3 From nobody Mon Jun 8 21:46:09 2026 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 760C73CEBB7 for ; Tue, 26 May 2026 08:54:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779785655; cv=none; b=HU3yY4nO79XYDAJGNlkw/pPqp8axexLysXIJrzPOXBvgA5SDagoJqZMRZCdpyCrhF+ErPKuFu48CFJpnu3EHwP/U+FCRRzaA/IGG6GQwv6A96cLyxEXrHINgiq/5FE23PXfAqLDRchoF5kWYq3KZpXzUsft32WDuRci3cj2pHGA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779785655; c=relaxed/simple; bh=mFWzHCc0QVW+zZP3L+db7FoCGdmuWJq+7Uh0xV7p+Bg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=WMZK68mdKk330htI97OqPjTqVmmMt1DGh6RvZ53LNzNRU6QWQ6/2YXc7jTnEPQHcssI0CHlU9xyBZtbjXzBTfgtyo6ryG05LuRCA4PnzZuwTzLqoER9McqtSaai/p2UJCjdPTLzXZL0VNSdTKabsCU4SZWZzNT8t3RLkBWTKL6k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=JyaE/3r0; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="JyaE/3r0" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-4891e5b9c1fso88475945e9.2 for ; Tue, 26 May 2026 01:54:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1779785652; x=1780390452; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gxa1c+8qFl9vsdYXkMBiERdb42n/qlsiAnLaMu6JPTw=; b=JyaE/3r0fIwmYvgq0qd8ajby3FbNdmI+5b64g9Sf3PP7+edDbOmEnOXhHNFpo5maJw ycH+ygkXR9olInPXDhlrmPUq1LLSqzmi1leZok3m7zO/Ovhir2ApOt/WEp+j9n9UdkGE LVtPdZDo+73J0guTI1erfvNq9+IHr+BfdzsR+yUOyZ18/LXC2neu7IW6jghasaR1v+vu 02ms0jO9wN5x647JMMmZM3WHkCkFHb50llIkYBsRAg2su69PAWaN9hgaW3qtz2R0AT5G wapOApqU+PeOLVPIS4dSmn5asCtZt0XX2Tpkg2OngG/x9qznchpgx53vMXOcEpk6N+od LSIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779785652; x=1780390452; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=gxa1c+8qFl9vsdYXkMBiERdb42n/qlsiAnLaMu6JPTw=; b=IbRJhpXYFR09De6kY7XY9CTuvjTP9yj5FUc+ssWsiVhTTrOzoa4HBNwvtNbOV1PkwE qcg4S/rHvx3C6qYUV+F+D681l+PGvejskCP+CS6DIoSbSKHfp4JAjH2MrphhWogrMTKr VfLZQon6cX48GhaT58dzAEmHkdg9wfjVnkp3tSaeFG9+F0HwhjQ4xyv9Esd5At5RXD5t FbO4kOJkjLFUDwjr6aLOesSgTwi6a3aeMpIdiKS5hHPPE3maeqLfyrTRfZz29H9v2hu1 1s7Pd5trQeTJZvcn6YOrBxO6A0kW3+9Hw3hmII/8NKZGo2/iriH5pArRn2W4S1riPlfl OKsA== X-Gm-Message-State: AOJu0Yxn7Niyt5AF46NqHBrY0iEjs3u/0DVsW0nrhZTqOJZTEO4HBnep uXqHcGYJRVQ/iYKD5L39y5kpFTUC/M1oVvlMFbl+1ZDDfOb9PGswrLroQDHOQ0EvtiM= X-Gm-Gg: Acq92OFYaJ2EYX0LCTZZ3RPzRWRAI3rhRiSu1Q8YUOsXD4LGOdILTXBkxttFljW7jFW t3W8LGaJvsNyVVkS50qz1n8BUCRNNDOn9xAKWjhGXLE9V9rJeWk6oEhBCe9onbIrtJS0fql2kyI GjHPX4X/DT5C3kQsn+UwYA5CtN+DvlKuRxpJMFeeVr4b2taJov8+5DI8Ek978KpZYAANex+gJ+h ekUTo0szA5SMes5eq5bJptjkUy5uRONCaLWzMhzqtZ3TvDheT0b2LKcdNgQAXTVJuqDwyDRjMjf hE07IqUsYoKx7cEbs729sUgGFFE3zC+BNSwopmovHHvSeVJ242kw94fcKZOgLBW5wKrjmwcpbw9 b3IKTIHjYCig+aWDeuUDDftg9FotBfrjxFD315B77hfAZYlc20J8tukQyO+wXAC8UwJRxCXxTy3 KhzG8aLlEdTluYzZx2E12UAN8uVFXrp2lrIuqaYSJaVW+IDdjFF33y9sCbGtfsXXfLSaByzoiL5 fHJL/BtKFzmFK12owzqtHEy X-Received: by 2002:a05:600c:1c0b:b0:490:44eb:c1dc with SMTP id 5b1f17b1804b1-49044ebc2e0mr316603105e9.20.1779785651836; Tue, 26 May 2026 01:54:11 -0700 (PDT) Received: from localhost (p200300f65f47db047ec792ae18ec05cd.dip0.t-ipconnect.de. [2003:f6:5f47:db04:7ec7:92ae:18ec:5cd]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-45eb6d48e23sm32585951f8f.20.2026.05.26.01.54.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 May 2026 01:54:11 -0700 (PDT) From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig=20=28The=20Capable=20Hub=29?= To: Arnd Bergmann , Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org Subject: [PATCH v1 3/3] misc: pch_phub: Make MAC address configuration more robust Date: Tue, 26 May 2026 10:52:09 +0200 Message-ID: <796b3667ea49d9156ecc03d1ce9668972316d90b.1779785111.git.u.kleine-koenig@baylibre.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1169; i=u.kleine-koenig@baylibre.com; h=from:subject:message-id; bh=mFWzHCc0QVW+zZP3L+db7FoCGdmuWJq+7Uh0xV7p+Bg=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBqFV9DAtUXfQDG+i5RGqRnO2s60n0Nw1+zLmnGZ qvoo8xBRVCJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCahVfQwAKCRCPgPtYfRL+ TrAlCACIYSE8kfd6vPBrjYMAv6ip5jcE/fNCjWfCdy1aX0dJYdRuNyXMoAFh68YDmaRQsgaI3kh H+ohOHXr/2K8AjH7++AnlNDJ/d+fgK9mN0Gioq4Jc2KWy4B2tDKHfmAvZsK7knNWbcWiVp1v3Jw SM2wjj0OgdDl5ZOiTiX6RWGwAu4Ubi0oe/AjxBr2BoFIVPjpTZhEvmqLD8JhMXHIuYKKr2Loihr zfdv3n8cO45OyfdwKwJBdPtiGbPEpr56S07nZf0wwTs6TQKU0N1Qjf2G86PPwq8iOv9v6s4EaHp iG2g6J8d53aAh3aU8Zrh1pZoOQSV0DWDuP3+4CqrPvoXlxen X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable The comment in pch_phub_write_gbe_mac_addr() suggests that only EG20T, ML7831 and ML7223 are handled. Replace the code construct using an if with a switch that has the same semantics but issues a warning if a new device type is added to the driver without adapting this function. Signed-off-by: Uwe Kleine-K=C3=B6nig (The Capable Hub) --- drivers/misc/pch_phub.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/misc/pch_phub.c b/drivers/misc/pch_phub.c index 5adf7f0c84ab..15785597da40 100644 --- a/drivers/misc/pch_phub.c +++ b/drivers/misc/pch_phub.c @@ -324,10 +324,19 @@ static int pch_phub_write_gbe_mac_addr(struct pch_phu= b_reg *chip, u8 *data) int retval; int i; =20 - if (chip->ioh_type =3D=3D PCH_EG20T || chip->ioh_type =3D=3D PCH_ML7831) + switch (chip->ioh_type) { + case PCH_EG20T: + case PCH_ML7831: retval =3D pch_phub_gbe_serial_rom_conf(chip); - else /* ML7223 */ + break; + + case PCH_ML7213: + case PCH_ML7223M: + case PCH_ML7223N: retval =3D pch_phub_gbe_serial_rom_conf_mp(chip); + break; + } + if (retval) return retval; =20 --=20 2.47.3