Hello,

v1 of this series is available at
https://lore.kernel.org/cover.1779360001.git.u.kleine-koenig@baylibre.com.

Sashiko[1] found a few issues that are addressed here:

 - Drop various members from pch_phub_reg (patch #1)
 - Also handle ioh_type comparisons against magic constants
 - Using an enum shifts the values used to identify the different
   hardware variants. For the corner case where new pci ids are added at
   runtime to the driver 0 is special. I think this doesn't matter in
   practise but I noted that in the commit log.

@Greg: I already received mail that you picked up v1 of this series. I
hope it's not too late to drop it still?! Please tell me if you don't
want to drop it any more, then I send incremental patches for the issues
addressed here.

Best regards
Uwe

[1] https://sashiko.dev/#/patchset/cover.1779360001.git.u.kleine-koenig%40baylibre.com

Uwe Kleine-König (The Capable Hub) (2):
  misc: pch_phub: Drop two unused functions
  misc: pch_phub: Introduce an enum for device indentification

 drivers/misc/pch_phub.c | 181 +++++-----------------------------------
 1 file changed, 19 insertions(+), 162 deletions(-)


base-commit: 254f49634ee16a731174d2ae34bc50bd5f45e731
-- 
2.47.3

On Sun, May 24, 2026 at 12:38:24PM +0200, Uwe Kleine-König (The Capable Hub) wrote:
> Hello,
> 
> v1 of this series is available at
> https://lore.kernel.org/cover.1779360001.git.u.kleine-koenig@baylibre.com.
> 
> Sashiko[1] found a few issues that are addressed here:
> 
>  - Drop various members from pch_phub_reg (patch #1)
>  - Also handle ioh_type comparisons against magic constants
>  - Using an enum shifts the values used to identify the different
>    hardware variants. For the corner case where new pci ids are added at
>    runtime to the driver 0 is special. I think this doesn't matter in
>    practise but I noted that in the commit log.
> 
> @Greg: I already received mail that you picked up v1 of this series. I
> hope it's not too late to drop it still?! Please tell me if you don't
> want to drop it any more, then I send incremental patches for the issues
> addressed here.

Just send an incremental set of patches please.

thanks,

greg k-h