From nobody Sun May 24 20:33:35 2026 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B7F1E385D77 for ; Fri, 22 May 2026 20:35:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779482134; cv=none; b=c3cG7EwEn11YLpt1gW6CTtGnwPrIEUwiraEx5DokbIi6gIRmCGCIfMq/99bfy1v0YJ8NIZzE0cb5+iANBMIQnEj1ibeTMlhTPYpbHByVw1r66RaXK8ZjWcNhbcGpODFt5tmiy9ftWvMNeqnfZBU4C0EBf3PhagS3mhHRVz4NYKQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779482134; c=relaxed/simple; bh=iAjQZT5aUoAWVJVFTqyNXVazgRDPkpuN3yaqpW1aML0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=lb9EyJBF7zpDQrBCc1j24mj5NukxdS0oB3ghnMI2M1eAdSjLv5NM3tYL8caA8Pq7jwoN07IbP9uz2h9WYmwKjx3pGeQdVkur9+COKizBGtxQPN9HrTrrOaesK9BVOfhK6NyDzozR+aqhwjrtT7YgUaibvUaYAF5VtnaUav7V5VU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=dNhQsHjw; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="dNhQsHjw" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-449d6c68ed8so4409268f8f.0 for ; Fri, 22 May 2026 13:35:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1779482130; x=1780086930; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=hiIrfEjXizuDvUFyygdqA7+8wvQNjBlFchL1YFzPjzw=; b=dNhQsHjwAZqo4wg8dV1KPi0/sNXyvpDV/WvG8W4+jG3CLq6Z0J7yAVp1cfHsAYoJn5 jJN99YSDKV7NoxfhfnVhaEI8QGGQARoaZOpoIWSxJa7Xfi+cK+gVipJ8834zYMtx+4pB iZXKmAxw3InSmtkPdIMja9r/OAU6/EGmw8bSP0QK/eRrq11DBx11ziCCf5T38c8KKW4X T2Nnczf9jtnSEFOxLe90+oiGB0oHg79EqIW0xaBVwO3nwzYbUYYJcvMy9DCdQCYQrWF8 rCPBy/8H2mS2rtEuO3jdpTkVkArHemgqKCqlGCRGfnEPmzq6U7XUobxVssbpW8mp2ZI5 68xA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779482130; x=1780086930; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=hiIrfEjXizuDvUFyygdqA7+8wvQNjBlFchL1YFzPjzw=; b=JlyYdfm7taXGDttjkEQ549dxIg7e0oTJfj+OONRnOCQVgMqba8OCl6BDzOsGbfIGt3 DLkwIftcb/YDYdlFLQbNPwj32FjvV8QYM4Kf8PIB0SfNZF+hLQ94G1cWYYS+Auzv1a2N 2Nm/EbDCgXTGQ0bMEfy3+CYVkMMVnWP/eXEggPxJKY0OeDtv5SzArcqRTK68Y27AYX0v rD/xmqzekUB+sN1OR2+sB8IdDmJTzio67dHHVMdWARp/ucw3UAxa1MgYrlzpMcwKsVx8 GUw9Mbry8uHP/Laqa2UAfND/SoPK9uVY5wwzhD6Lip4vTk7kBv2WsTYanx9Uh/U4Kkst cBwg== X-Forwarded-Encrypted: i=1; AFNElJ/T19K7WATMqOxRU3vdUuUGJaqHzC7mzgvIA1SkfO2wmiOu519CLuejEhmFX3hfnWBw4iWE5bvbkKElYPQ=@vger.kernel.org X-Gm-Message-State: AOJu0YztMLIRwMwiHxNuhyZ2qII9F4ISNPOa3HsH8aU2qyC3w6WQCH5V ZKpKFeF2xwnBxybrMPDgr9XJmpjNalvUaTpBaC96CcrjHEDrKJZMdWWvrPHYbMtXstc= X-Gm-Gg: Acq92OHwHwqIXZj4XR9ca+Kb/5VdUMAXrItKbcMrjmN/32jj1AK1apzhYejtXHaZQSM toQEwwPtJ1iQ9M/g1ZIClWb22deVIazVbTnPf5CMgKslO4z/65dcgAqTgW5dV49ufp3FDZlfTsW rwYVTZP4+fj108kspNfEbEMIOb+pcCbE/mfuBr2pxqhHI+feG/2gUKllhbryXSAEsa4QUjQx03o 5/szVpxWZuzPfmDgT6rG7BykGbYpiH8YgxWM29nFqEQEC1vN3b3U0NC/dM31DFriQ38zQWubblE FARBFcTgJyUx7A6SRVXbnTcjh0LmT9J1OW5rpFuW3gB9pxBQXfkkOQ8rZb5p9MG6UVAct7bpzUI GjM7wVeYDAoimkyQGLZ3YMc5qpt6EaZ6GlxQbXbNgN9l9PM/Sm7PzfdXdDdE0peG2/pkqHFu/sP tJqyy7wL4chsoHiaERqX72tC/f8XizPAc4z4WTCvk= X-Received: by 2002:a05:6000:26c3:b0:45d:b14b:23fb with SMTP id ffacd0b85a97d-45eb369c7abmr8298560f8f.11.1779482130180; Fri, 22 May 2026 13:35:30 -0700 (PDT) Received: from localhost ([2a02:8071:56d1:2de0:1d24:d58d:2b65:c291]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-45eb6c9f548sm7357082f8f.2.2026.05.22.13.35.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 May 2026 13:35:29 -0700 (PDT) From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig=20=28The=20Capable=20Hub=29?= To: Mika Westerberg , Andi Shyti Cc: Andy Shevchenko , Jan Dabros , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/2] i2c: designware-pcidrv: Consistently define pci_device_ids using named initializers Date: Fri, 22 May 2026 22:35:13 +0200 Message-ID: <68667c4ab85716b190d8b705813b610e21a386f6.1779481436.git.u.kleine-koenig@baylibre.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=5239; i=u.kleine-koenig@baylibre.com; h=from:subject:message-id; bh=iAjQZT5aUoAWVJVFTqyNXVazgRDPkpuN3yaqpW1aML0=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBqEL4E3vg7OBUUJN+Z3hqJ+PYfvCEbd07WmzNrQ RCI5nQ33y+JATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCahC+BAAKCRCPgPtYfRL+ TmngB/9KvsHUQJwx3BVGjf2QW/fJyFWRPnkJFxsHb2AXhfbc52YJkVmXA4iJbMGMe1VGqD4E2cK dnjg4HjA+qD2CUaN9RN2T6c1netwBVP87TygN7oDSMhGPTLNRk1mXu9RXE8d9gNmSMj31ygpHWR Pxayen4yl6mwcoiLOGOSkRBJJZwmvEgipY9JLR+s30QreKBmCCAQO7fy4HOce6ojqIBvUovIXpF U8oiN4td7GMogyeNSXpPRe1rmfFEvUy+x3OWubCubs7Hr+j4w7f128FUIBzNWI42r/IVq0Tw9I3 hE0SJRYzWMIu5XSn+PqiFmIWVpJiztqpmIf9lO5mIzpungkN X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable The .driver_data member of the struct pci_device_id array were initialized by list expressions. This isn't easily readable if you're not into PCI. Using named initializers is more explicit and thus easier to parse. This change doesn't introduce changes to the compiled pci_device_id array. Tested on x86 and arm64. Signed-off-by: Uwe Kleine-K=C3=B6nig (The Capable Hub) --- drivers/i2c/busses/i2c-designware-pcidrv.c | 78 +++++++++++----------- 1 file changed, 39 insertions(+), 39 deletions(-) diff --git a/drivers/i2c/busses/i2c-designware-pcidrv.c b/drivers/i2c/busse= s/i2c-designware-pcidrv.c index f21f9877c040..aa358eb6656d 100644 --- a/drivers/i2c/busses/i2c-designware-pcidrv.c +++ b/drivers/i2c/busses/i2c-designware-pcidrv.c @@ -308,51 +308,51 @@ static void i2c_dw_pci_remove(struct pci_dev *pdev) =20 static const struct pci_device_id i2c_designware_pci_ids[] =3D { /* Medfield */ - { PCI_VDEVICE(INTEL, 0x0817), medfield }, - { PCI_VDEVICE(INTEL, 0x0818), medfield }, - { PCI_VDEVICE(INTEL, 0x0819), medfield }, - { PCI_VDEVICE(INTEL, 0x082C), medfield }, - { PCI_VDEVICE(INTEL, 0x082D), medfield }, - { PCI_VDEVICE(INTEL, 0x082E), medfield }, + { PCI_VDEVICE(INTEL, 0x0817), .driver_data =3D medfield }, + { PCI_VDEVICE(INTEL, 0x0818), .driver_data =3D medfield }, + { PCI_VDEVICE(INTEL, 0x0819), .driver_data =3D medfield }, + { PCI_VDEVICE(INTEL, 0x082C), .driver_data =3D medfield }, + { PCI_VDEVICE(INTEL, 0x082D), .driver_data =3D medfield }, + { PCI_VDEVICE(INTEL, 0x082E), .driver_data =3D medfield }, /* Merrifield */ - { PCI_VDEVICE(INTEL, 0x1195), merrifield }, - { PCI_VDEVICE(INTEL, 0x1196), merrifield }, + { PCI_VDEVICE(INTEL, 0x1195), .driver_data =3D merrifield }, + { PCI_VDEVICE(INTEL, 0x1196), .driver_data =3D merrifield }, /* Baytrail */ - { PCI_VDEVICE(INTEL, 0x0F41), baytrail }, - { PCI_VDEVICE(INTEL, 0x0F42), baytrail }, - { PCI_VDEVICE(INTEL, 0x0F43), baytrail }, - { PCI_VDEVICE(INTEL, 0x0F44), baytrail }, - { PCI_VDEVICE(INTEL, 0x0F45), baytrail }, - { PCI_VDEVICE(INTEL, 0x0F46), baytrail }, - { PCI_VDEVICE(INTEL, 0x0F47), baytrail }, + { PCI_VDEVICE(INTEL, 0x0F41), .driver_data =3D baytrail }, + { PCI_VDEVICE(INTEL, 0x0F42), .driver_data =3D baytrail }, + { PCI_VDEVICE(INTEL, 0x0F43), .driver_data =3D baytrail }, + { PCI_VDEVICE(INTEL, 0x0F44), .driver_data =3D baytrail }, + { PCI_VDEVICE(INTEL, 0x0F45), .driver_data =3D baytrail }, + { PCI_VDEVICE(INTEL, 0x0F46), .driver_data =3D baytrail }, + { PCI_VDEVICE(INTEL, 0x0F47), .driver_data =3D baytrail }, /* Haswell */ - { PCI_VDEVICE(INTEL, 0x9c61), haswell }, - { PCI_VDEVICE(INTEL, 0x9c62), haswell }, + { PCI_VDEVICE(INTEL, 0x9c61), .driver_data =3D haswell }, + { PCI_VDEVICE(INTEL, 0x9c62), .driver_data =3D haswell }, /* Braswell / Cherrytrail */ - { PCI_VDEVICE(INTEL, 0x22C1), cherrytrail }, - { PCI_VDEVICE(INTEL, 0x22C2), cherrytrail }, - { PCI_VDEVICE(INTEL, 0x22C3), cherrytrail }, - { PCI_VDEVICE(INTEL, 0x22C4), cherrytrail }, - { PCI_VDEVICE(INTEL, 0x22C5), cherrytrail }, - { PCI_VDEVICE(INTEL, 0x22C6), cherrytrail }, - { PCI_VDEVICE(INTEL, 0x22C7), cherrytrail }, + { PCI_VDEVICE(INTEL, 0x22C1), .driver_data =3D cherrytrail }, + { PCI_VDEVICE(INTEL, 0x22C2), .driver_data =3D cherrytrail }, + { PCI_VDEVICE(INTEL, 0x22C3), .driver_data =3D cherrytrail }, + { PCI_VDEVICE(INTEL, 0x22C4), .driver_data =3D cherrytrail }, + { PCI_VDEVICE(INTEL, 0x22C5), .driver_data =3D cherrytrail }, + { PCI_VDEVICE(INTEL, 0x22C6), .driver_data =3D cherrytrail }, + { PCI_VDEVICE(INTEL, 0x22C7), .driver_data =3D cherrytrail }, /* Elkhart Lake (PSE I2C) */ - { PCI_VDEVICE(INTEL, 0x4bb9), elkhartlake }, - { PCI_VDEVICE(INTEL, 0x4bba), elkhartlake }, - { PCI_VDEVICE(INTEL, 0x4bbb), elkhartlake }, - { PCI_VDEVICE(INTEL, 0x4bbc), elkhartlake }, - { PCI_VDEVICE(INTEL, 0x4bbd), elkhartlake }, - { PCI_VDEVICE(INTEL, 0x4bbe), elkhartlake }, - { PCI_VDEVICE(INTEL, 0x4bbf), elkhartlake }, - { PCI_VDEVICE(INTEL, 0x4bc0), elkhartlake }, + { PCI_VDEVICE(INTEL, 0x4bb9), .driver_data =3D elkhartlake }, + { PCI_VDEVICE(INTEL, 0x4bba), .driver_data =3D elkhartlake }, + { PCI_VDEVICE(INTEL, 0x4bbb), .driver_data =3D elkhartlake }, + { PCI_VDEVICE(INTEL, 0x4bbc), .driver_data =3D elkhartlake }, + { PCI_VDEVICE(INTEL, 0x4bbd), .driver_data =3D elkhartlake }, + { PCI_VDEVICE(INTEL, 0x4bbe), .driver_data =3D elkhartlake }, + { PCI_VDEVICE(INTEL, 0x4bbf), .driver_data =3D elkhartlake }, + { PCI_VDEVICE(INTEL, 0x4bc0), .driver_data =3D elkhartlake }, /* AMD NAVI */ - { PCI_VDEVICE(ATI, 0x7314), navi_amd }, - { PCI_VDEVICE(ATI, 0x73a4), navi_amd }, - { PCI_VDEVICE(ATI, 0x73e4), navi_amd }, - { PCI_VDEVICE(ATI, 0x73c4), navi_amd }, - { PCI_VDEVICE(ATI, 0x7444), navi_amd }, - { PCI_VDEVICE(ATI, 0x7464), navi_amd }, - {} + { PCI_VDEVICE(ATI, 0x7314), .driver_data =3D navi_amd }, + { PCI_VDEVICE(ATI, 0x73a4), .driver_data =3D navi_amd }, + { PCI_VDEVICE(ATI, 0x73e4), .driver_data =3D navi_amd }, + { PCI_VDEVICE(ATI, 0x73c4), .driver_data =3D navi_amd }, + { PCI_VDEVICE(ATI, 0x7444), .driver_data =3D navi_amd }, + { PCI_VDEVICE(ATI, 0x7464), .driver_data =3D navi_amd }, + { } }; MODULE_DEVICE_TABLE(pci, i2c_designware_pci_ids); =20 --=20 2.47.3 From nobody Sun May 24 20:33:35 2026 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D7CB384CE8 for ; Fri, 22 May 2026 20:35:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779482135; cv=none; b=M+2HC+pH7rn1AZFZnR9zIjdQh6T1yLQ571QLVuxLmoqsg3qn+UP6IrJQZ3uNsNmR1ut0XvxJOwMIzRXHpWxBIVFlj8vZakRI8lKo9U+3VI6JLnwbmv9K+7BGPXJa/i48IAYT310hO7Uo4Uf8mF/COLFyCJ4KDO990IZdWjTTyRU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779482135; c=relaxed/simple; bh=Q9ZIxPqq+avWubd/LonKxN16U7vM7tUrFVIGXJ359Kw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=SKFma+JxLiBuTZ4dmaDxrKM80AJt/CUp4/UDvHgheK5n+fVW2DqWKC6jcDgmpYyr0RFwqcvwnQMEgiD/ICgBPx7evlexSz9WQ6hWEnpDEsYbuxKpfyXAKfSAVVAjHsvVdgfFsa2nMVOJ2/0Tgu4tk/5G0MPTt65KAu8nPZh1LsU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=VeVEfuIV; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="VeVEfuIV" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-44c350a5b87so4814051f8f.3 for ; Fri, 22 May 2026 13:35:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1779482132; x=1780086932; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=f2y3T/h7K/6PEJ0HofLl2zEWQ0yuqByR/h59bZrxMAs=; b=VeVEfuIVCGgPIZv61Z5lFYzJ+dE1BlBllFNPg7P2TVy4wxcJU6/QOkKTCGWYQSnVq1 LI4jh/WYO0fZQZdhL8ExdzeR/oB3WYvOBg5YyIakqrsH2fluDaOsUdoIlrrwOt/FuIs4 ULfSIuju5qG787LmoEI+QxB133cqIvCbI/mPNXQjQ6qgFo3J0YogSpUab5rb/jkIm36+ BRMDATM5L7DkLqXsxjLHrxhi5kk9upy3WwcGKxxL888vVuYA9qggr0l38YfJ0ASMjNd/ TWxyrTofYDACBbZSen8+RYZw/lWqbkbdsypxgnKO5aWTe0bAYWBykHBlEaM7p31mkeHN YvEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779482132; x=1780086932; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=f2y3T/h7K/6PEJ0HofLl2zEWQ0yuqByR/h59bZrxMAs=; b=AmqQrmZW3/a9sEc2Kug44/enxaFDGCIPSJYq1ftwZlSIJmyHJcqhKcb+zhyvRUmPQX xgrgXwjqqt8lide4laufhS1sGGF653zC1B3jtAyAoDpBZWQlE1OQZKWevnLCNLy59Jvt CHCyxwDD4BjiyQof0RP4Dvx+esfKiAm2KTiOO3qOZAxn/0AiiyWHE70rjO/XO8DsC++T 7ns7XT+RhQRzwWGq6RjzmHYPlFbdSGpG0IljWAMPqge7hGXr3qb9yZkLSSTQU9nIbZ/C pDPrFwfFRS4cP990YHn4KFpx4sIUJhtQMpzw3jN8EVWbGgRx7U5WxV278tU8YrX4Xdh0 eoCg== X-Forwarded-Encrypted: i=1; AFNElJ9q5aBwszBSNte3wJn/TJ3XCRSSB5rojjquWjMmwmGDaHD3YmW0NntCCAf7bQCgFbAuZRR+tl9M2x4fSJ0=@vger.kernel.org X-Gm-Message-State: AOJu0YzmbMIhD8Emi5aT7KmYzWhoOkQYIb+oZKl+x256E8nQi79UoTJr iDF0ASOY8VXYyQdp/hFgLSo80Z24XrkN9figUCtgve3cwNkmUhnKyrF43pTKN5L7EsQvSA1tkja DNRHsZYQ= X-Gm-Gg: Acq92OGyfQvql4nakA0T4RJCKopQwYouDS2/UDkMZ0N2Tl2Yulh/Y9vFQ38u10mgf0i HEBE+Mu/qF0Xry3TVGa/y3ujg8mmFX75ojjLdgC+wjsu0S2Zgli/vTgtc+0HJmJXUqZwhDG3OnV DfsxXrE3zfCaFZyvRUQsfv64fiPjQJUNGcOry6oaxAWo0uWCQWhqJMfgNtGa08D7H7uVA1MdjJW CjHRfgWzwQe4Vz3r3bQKUdXyydtQM9A7oET5saKE54ydwfl5b5BlCkcKeX6SkYw0MZcSwWo6kYy DH/jkPCuD4kRMtJ6em3n8k+xSMG+Ux38sUvaoZZ93cUrtjVfjiv+xA9+QLioTwF2XBh4MoLs8q7 IB6etPZOF8+X7uj3AyD2H4n96zvmXaA9JyMn9N1keIMi8oTUMJfqagTcXUl4CjVDCwSkP7BA2cU 2uLvG5G7pugSWWuxBigPkbTKZtnGUh X-Received: by 2002:a05:6000:1848:b0:43d:733f:aee6 with SMTP id ffacd0b85a97d-45eb3687dedmr8362080f8f.10.1779482132065; Fri, 22 May 2026 13:35:32 -0700 (PDT) Received: from localhost ([2a02:8071:56d1:2de0:1d24:d58d:2b65:c291]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-45eb6cd151asm5990419f8f.13.2026.05.22.13.35.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 May 2026 13:35:31 -0700 (PDT) From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig=20=28The=20Capable=20Hub=29?= To: Andi Shyti Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 2/2] i2c: eg20t: Consistently define pci_device_ids using named initializers Date: Fri, 22 May 2026 22:35:14 +0200 Message-ID: <41316792102ff2860ec019373293cb07d545a0b0.1779481436.git.u.kleine-koenig@baylibre.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1449; i=u.kleine-koenig@baylibre.com; h=from:subject:message-id; bh=Q9ZIxPqq+avWubd/LonKxN16U7vM7tUrFVIGXJ359Kw=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBqEL4GxS/C+lP+v+RJzVjXostgzeQlSIU7laJcF lyuZpQXjOCJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCahC+BgAKCRCPgPtYfRL+ TtbjCACehs6et6YO9YlnIwjf+9u/LKci1facCtQV80XlbdTylbWgFTZYexbqV61wLP/fFgQ6Zl9 AqMEqSu7SlEXzyoRtdxQgJehR+HfRC2ug1ZskWe8Jy3X0GurprWK07b80RzyYm+pZgUJrlgZ+nG Zr1Jre0jTA3sngHQIIelEaYYFMTUButjklBfKqOcqZyrVlSlImObehIy8P3a1M3eE/8aJvnGg8D yl9dRWwbvaV806QNljGt7i8SqFxEPipXsfDEk00oeem90Z1dUlQvAKp1rVBATnd8TXnp+WVkfux rXRlb++Qee0XT1xq0sh9fcUYM/OFrGVWsrrpyQ3rxgtP8P2v X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable The .driver_data member of the struct pci_device_id array were initialized by list expressions. This isn't easily readable if you're not into PCI. Using named initializers is more explicit and thus easier to parse. This change doesn't introduce changes to the compiled pci_device_id arrays. Tested on x86 and arm64. Signed-off-by: Uwe Kleine-K=C3=B6nig (The Capable Hub) --- drivers/i2c/busses/i2c-eg20t.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/i2c/busses/i2c-eg20t.c b/drivers/i2c/busses/i2c-eg20t.c index f83238868802..8c67ab4f2aad 100644 --- a/drivers/i2c/busses/i2c-eg20t.c +++ b/drivers/i2c/busses/i2c-eg20t.c @@ -169,11 +169,11 @@ static DEFINE_MUTEX(pch_mutex); #define PCI_DEVICE_ID_ML7831_I2C 0x8817 =20 static const struct pci_device_id pch_pcidev_id[] =3D { - { PCI_VDEVICE(INTEL, PCI_DEVICE_ID_PCH_I2C), 1, }, - { PCI_VDEVICE(ROHM, PCI_DEVICE_ID_ML7213_I2C), 2, }, - { PCI_VDEVICE(ROHM, PCI_DEVICE_ID_ML7223_I2C), 1, }, - { PCI_VDEVICE(ROHM, PCI_DEVICE_ID_ML7831_I2C), 1, }, - {0,} + { PCI_VDEVICE(INTEL, PCI_DEVICE_ID_PCH_I2C), .driver_data =3D 1 }, + { PCI_VDEVICE(ROHM, PCI_DEVICE_ID_ML7213_I2C), .driver_data =3D 2 }, + { PCI_VDEVICE(ROHM, PCI_DEVICE_ID_ML7223_I2C), .driver_data =3D 1 }, + { PCI_VDEVICE(ROHM, PCI_DEVICE_ID_ML7831_I2C), .driver_data =3D 1 }, + { } }; MODULE_DEVICE_TABLE(pci, pch_pcidev_id); =20 --=20 2.47.3