From nobody Sun May 24 20:33:10 2026 Received: from CY7PR03CU001.outbound.protection.outlook.com (mail-westcentralusazon11010054.outbound.protection.outlook.com [40.93.198.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DEC527260F; Fri, 22 May 2026 00:37:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.198.54 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779410223; cv=fail; b=rHR7zWGaPYlxxBp15u25YfxSHiVay82R6Or/RAdEFNrtfGEwPT34n0TWP7j+ZDSjNiXz/nDNU3vA3ngGs/2X8GzD+h5Jeaz/wNoF0gqTtxl8JOiBlmlsmf/I/p7el3H+WtWK/pqbWfqSxC6hdN2vHZnGUkjKkkfO6LbO8paK8uw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779410223; c=relaxed/simple; bh=0EdPmZas632ldc+RpZz/e7wnoJ1fGsJ0K3Gi2XFj8Kc=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=f6hy6j3yaVup+MRa9WhhlYoye4pyTSEcupcm2yBkj3Mha0X8T8eye294i1jfpx06z4FLlWsAwS3hqWh96qM5879MdZ5g67tuO1QYdAXzv1RI4r6Q7uLGlRk3d2DHU9Xmov8KbsE6bKEqC2DAgjlunE0VfknK7RbFMbNVE1v5Yas= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=BD2Jsmz/; arc=fail smtp.client-ip=40.93.198.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="BD2Jsmz/" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=khSzcfEZYiS0Qs3yb8kf12thZa2xaHnbNge4NeX2QHnreWt2JaHJsn1GaKWOiEcPjbbEiu4NgFQUD3Cn8vLn2pwXN4n5mxC+qlj79oRuws6rlrvfNAHHPg1CC62Cn3/mXHXweGkVSW4JFaS55jVS1jVwkRy2cGVGwvM/NPC8kJjNNKBIbviU5aWLnb7xm3p3v7s/FM60RiVxnbr/blXidBeXlZAdcOHV1S+XWyoebz2XTfP4J5JDkKf7/vc5RF9kWe0181ilx7oinkfUwvxkcbnHCB6+PYrf5oXPS9uMNdlcfTjpZpC1sopozW/fgbqwzv2/03gPol4BrwEsemEZFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MojnsBeKUD/yCEDAHKcrUO5bjytKIiQFDaSw5jmNe5k=; b=U7uwKxCA0rToZdPHqDvzZnJ11b+mAGLLl3WQ2Uv3Lk0+xY2/qF5ZqHrW74MDnXhj8OuvcyRMyPnvl+NNjq/PcTWXNPF57hBhmGsT09N5gGsn5YJQU/BtRoerzKafGhIMlQOIsKsztzRoK/M+mRHSt5b+5yJXjPGxiRHjqw+407ybqEJ0FwBK78Ol03j5bFeF39Y6ylbGQE7/M2MumwCfAAOreijWTG/6av4UE40FH8V9uwKdUfAuMh0wyjWCHd2pjCAJuwCW/PtRlK8mqb7zUkm3UTWQ9Y9HiX7WoMOdRxV0M7IWxXdDbzA3GWlPQYdTglC9SehNTINtIxEw0nmcsQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MojnsBeKUD/yCEDAHKcrUO5bjytKIiQFDaSw5jmNe5k=; b=BD2Jsmz/7gK7BQdSChJ1NqUL9saTC4YcWaD8vgv+51RE9FDUz4ybleceaa7csu1m9nwc8jA1sLmMoJlW9Pk0LOqZcjejmuuAO7Xkjp2/c1rpnNVZDrRAGKr8BMbsaNPo9d2fDyMHP2siNGnqfMyHo69By4dnbCTDy01w9FbbWh4Tk2KV6Yhir8FBsYppoibdNLxHposNGXHKt8qid4EI8W5CJAycJaUNSkGwlxVPtWkLMXmJKXkE/oxqq6cDXvNgxHGZ6RmIk5fbRGuT/n15B+DdR6+LdHagMecK9e9jp/wp5OBtA91vNp4sZ2P3kLWILwwbqifMRRLMtu+ObhFcxQ== Received: from SJ0PR03CA0355.namprd03.prod.outlook.com (2603:10b6:a03:39c::30) by IA1PR12MB6017.namprd12.prod.outlook.com (2603:10b6:208:3d7::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.48.17; Fri, 22 May 2026 00:36:58 +0000 Received: from CO1PEPF000075F0.namprd03.prod.outlook.com (2603:10b6:a03:39c:cafe::12) by SJ0PR03CA0355.outlook.office365.com (2603:10b6:a03:39c::30) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.48.17 via Frontend Transport; Fri, 22 May 2026 00:36:57 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by CO1PEPF000075F0.mail.protection.outlook.com (10.167.249.39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.71.7 via Frontend Transport; Fri, 22 May 2026 00:36:57 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Thu, 21 May 2026 17:36:41 -0700 Received: from rnnvmail203.nvidia.com (10.129.68.9) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Thu, 21 May 2026 17:36:41 -0700 Received: from Asurada-Nvidia.nvidia.com (10.127.8.9) by mail.nvidia.com (10.129.68.9) with Microsoft SMTP Server id 15.2.2562.20 via Frontend Transport; Thu, 21 May 2026 17:36:40 -0700 From: Nicolin Chen To: , CC: , , Subject: [PATCH rc v2 1/4] iommufd: Fix data_len byte-count vs element-count mismatch Date: Thu, 21 May 2026 17:36:32 -0700 Message-ID: X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000075F0:EE_|IA1PR12MB6017:EE_ X-MS-Office365-Filtering-Correlation-Id: bc64ad77-a816-4858-9bca-08deb79a3ae1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|82310400026|36860700016|376014|11063799006|22082099003|18002099003|56012099003; X-Microsoft-Antispam-Message-Info: kkZY8pEpJeAie/5iG4L0lASbL5YQpE6k2gIkMVcwprlO9PFwRggBA7XoQbjFwSKBdMkPTlAiNjmELj5sZFLYsXtTa8h44L7UBUvbTbCNtFZzga5MgnsrM4zZU5SvynWkGFzxvaI91h3tyVHn7U0ut2KHAZoaTCJIC7gdLyDEHyBb6YG/tLkjkYeqFFCAIbanhIZWN4Z6b7ztepCjj5unqsh/rQid0z4SREYWfx7S6wi1RFU7z8GeQRy5O2Vyq9w8S4Y+h0omZz8YJYb6yiNOmH9lSJHLcqlnH6bdOEGSorx+SSywlfqMZq7X+K5SosNvTOrdawNYgmw2jkF3jIjM10ZbDNLU9WBTm7FQWGjnUJ3eYFeyo/jOJPrkXyCHnOqnGKkb8MlRrXwFKXHnX3FJr4+QR9yuw/mON8W0q7oe8FkRZSUFoI/yPfIg3G56wbaRN8Oi2ihQydSaK3bTd95JfXk8e8kgzzEivkllIv1pM1SLZpJynfqn422Aslv0kumMcuEXhmvICnlGMjJnr3YvumP4d4S+YfV2mp3TMejX5jWnSu+tXUut+LNTzgAe+jqGVDF5apzkQRZqWe3qfhBtTIEffHUKChU5LP1ZnV4hxv5WtS3Mt+srzJPV2oaqACdz3c0o1qW76yT2VT5bXDPJR+JgrHYUTemkjt7CCz8Hppk7k1h5nOiXIBh2wDTtEMcp9LpkEImqGfKJK9r0Q8XyA+fDMwQbyyblHDg7Hx4Ms0g= X-Forefront-Antispam-Report: CIP:216.228.117.161;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge2.nvidia.com;CAT:NONE;SFS:(13230040)(1800799024)(82310400026)(36860700016)(376014)(11063799006)(22082099003)(18002099003)(56012099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: p05iXhwr8VMva8m/gCiU3EV2JTrMmnVKoa9/zPfqIPwmLEIXfsmOp/3TDBaZeMMH4YwrsEze6cTUjYv6jQFTKH4gmERrmJ8fFPTNT93A4GmkTAtEp0OxUfL1HHbH5brel6FtmcJa/g6GlafydVx96RCB7VyhdMUJ/u1ExQSOeCRGP7ZnerOH9Rw7Mu2XByP/UkxpWkEbP5AYGwSWcH5mhkN4gfJPZeXToIStE6EopF99+L168JChpWFjCXYwux7AMSoJOIEYMVrHYUvIBMucx3KxCv+m3HrW95G2ffmJmK463HIbNBlRdyLq+yUOhoHSd5gbeydvZEXedOC7D5WyulFn+NKsK3Tf3eUxjODgxXNEp4EL1AFybKGX2gGMFMpekvSu+kCDtknWQxQGhmyIdaCnjFuGYQbuNOGdttP6xRtbM1rE9G9CwmXB2MJjrmJD X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 May 2026 00:36:57.2830 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: bc64ad77-a816-4858-9bca-08deb79a3ae1 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000075F0.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6017 Content-Type: text/plain; charset="utf-8" kzalloc_flex() computes the allocation size. With event_data typed as u64, data_len is interpreted as a u64 element count. Yet, every caller and the read path treat data_len as a byte count. The current code over-allocates by sizeof(u64) and the __counted_by() annotation overstates the length by the same factor. Re-type event_data as u8. No functional change in user-visible behavior. Fixes: e36ba5ab808e ("iommufd: Add IOMMUFD_OBJ_VEVENTQ and IOMMUFD_CMD_VEVE= NTQ_ALLOC") Cc: stable@vger.kernel.org Reviewed-by: Jason Gunthorpe Signed-off-by: Nicolin Chen --- drivers/iommu/iommufd/iommufd_private.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iommu/iommufd/iommufd_private.h b/drivers/iommu/iommuf= d/iommufd_private.h index 6ac1965199e9a..43fbc5bed8de3 100644 --- a/drivers/iommu/iommufd/iommufd_private.h +++ b/drivers/iommu/iommufd/iommufd_private.h @@ -602,7 +602,7 @@ struct iommufd_vevent { struct iommufd_vevent_header header; struct list_head node; /* for iommufd_eventq::deliver */ ssize_t data_len; - u64 event_data[] __counted_by(data_len); + u8 event_data[] __counted_by(data_len); }; =20 #define vevent_for_lost_events_header(vevent) \ --=20 2.43.0 From nobody Sun May 24 20:33:10 2026 Received: from SN4PR0501CU005.outbound.protection.outlook.com (mail-southcentralusazon11011070.outbound.protection.outlook.com [40.93.194.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C7DD25B0A6; Fri, 22 May 2026 00:37:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.194.70 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779410228; cv=fail; b=K9XTdxKfgVpi/YDeu4s4tYadgk9NRI3BP5Q2iiswkWZBdPzTRim0OzOh/TKyiVU78RriqH7kGb520+hvfCvrRnoUblshbeTSx7zfM++jTvjE75dCi/IEHME2U+iy4tkT1pM08EAc9TJQX4Yu2zzI9WzNWmU+ItMtHSTXqFHUJw8= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779410228; c=relaxed/simple; bh=lpIapICeCUAwsHL9Jok+DYYWiP1wgr/472BTetFhcHQ=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=DAUPhbRLkRzoxxzVdgjI1bfUgfYd88A3+/TcBo5qRi1+R8XcKI7gIUUp2/tw54kWMaf9usIPMe+YPcLPIffKkj8OaAbww5ny3+tWyTBzBOvpYcIJoel+HIRIxlG6nWTFV52DDEIHGjItplDvDPkdC6dQNEPltQxQqZiLi8n1Wss= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=fAGRTU1j; arc=fail smtp.client-ip=40.93.194.70 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="fAGRTU1j" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=m/8fQLUmxzbZtMGSQ3b0CGlIWWG0eF2vIdWPL8wOOPeJv1yRh7cWBcrHjoxrJ0Bjm5EeshzYVSQJPjwy9Bw4UaABL86SypbLY9ifvryB5dN2KtF7J61eoZtBTPaK7Fzq6FbhTxyx2eH+3cqg2U8BYw/TpmyWnEggtVbZWNAM4SQmSR4ZBNFkk3u8VmhEZdvW24ofTDmUzMy2AeRcn/Zg0LDUzHydP3zGDEyhuMsyzFUaRl802KQxGGMFXnZV3Y0yEonB+ToilOd+Wn+U79Qq5GqFPD0ke9Y4VOUWf09yrYHx10RKUU/NVspj/jCBwAwo1faXFD/91wz8mLdFCgIqUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZfUrXoe1NConvoBjdPyXyojNhByhj4h7V/o/E7LVQ38=; b=ZfgjhSz/DpfDxX8NDOYh9nn+MMJZL5j1PSbEep+uEd7jLYVAWXwDAEfZb3dFBRW0MAiO6AJIL5HC7sv/6hGg+lqnl1m/cDu7/iert/VAz0vON0xZ/mzR9Pj1AFw5ecnJ8OdQ+dynqi8YZh9YrECF6K3oMAF2sJ0rLCCCThmWVrMHuw+DQZv9liQJJBvoNppwr9lZ2YZXzroHc7vOxpKiSygYGNbd7se77cPFML9e0yJ0JV9Bq9Hyb1BpJHF/ACu3WO6/nvk/cMZwScjku0FGjZNgDbRQ7vWy2y7uIyi+VuGVJ57I1v3id0js2ZID2o/B7ro4TIIeqMTgRZ7om0scHw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZfUrXoe1NConvoBjdPyXyojNhByhj4h7V/o/E7LVQ38=; b=fAGRTU1jMC0aBsnX8h5Dszj5kK4SIJRMLeM9nvtbDNOPgHjp6eMYhe+AkFYVfNIFS39NHmVlgbkprtJlN3CC9fRDNWZ48oODsgC5r2TaL3PvqUUoWgV4nJAzLGCRjyTSbpzJhDCF7aeK5wv60uHyKO0hHpXDNMSq7dYq4ekG1r5QE1moa75ZToESP2oCzC/eWb95kA8YrU8tnvsvBm46Ad5iY4cjmARLXCvDCPPfmdYubefFSaZWvegEuzPh4TYOxsu0hpOMqwI08GLq3+EzSZKNpDKT6luPD8KPHsJbrmE2o2bUQ1JBeSiJ7sOcejqFc9Wf+lQyLYXDBBOU8pPkTg== Received: from PH8PR22CA0016.namprd22.prod.outlook.com (2603:10b6:510:2d1::9) by CH0PR12MB8550.namprd12.prod.outlook.com (2603:10b6:610:192::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.25.22; Fri, 22 May 2026 00:37:01 +0000 Received: from CY4PEPF0000FCBE.namprd03.prod.outlook.com (2603:10b6:510:2d1:cafe::69) by PH8PR22CA0016.outlook.office365.com (2603:10b6:510:2d1::9) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.48.17 via Frontend Transport; Fri, 22 May 2026 00:36:59 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CY4PEPF0000FCBE.mail.protection.outlook.com (10.167.242.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.71.7 via Frontend Transport; Fri, 22 May 2026 00:36:59 +0000 Received: from rnnvmail205.nvidia.com (10.129.68.10) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Thu, 21 May 2026 17:36:42 -0700 Received: from rnnvmail203.nvidia.com (10.129.68.9) by rnnvmail205.nvidia.com (10.129.68.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Thu, 21 May 2026 17:36:41 -0700 Received: from Asurada-Nvidia.nvidia.com (10.127.8.9) by mail.nvidia.com (10.129.68.9) with Microsoft SMTP Server id 15.2.2562.20 via Frontend Transport; Thu, 21 May 2026 17:36:41 -0700 From: Nicolin Chen To: , CC: , , Subject: [PATCH rc v2 2/4] iommufd: Move vevent memory allocation outside spinlock Date: Thu, 21 May 2026 17:36:33 -0700 Message-ID: <5ff36b5d80f7f6299f851be532a5195c1d2f1dae.1779408671.git.nicolinc@nvidia.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000FCBE:EE_|CH0PR12MB8550:EE_ X-MS-Office365-Filtering-Correlation-Id: cd687478-c3ab-4491-fdf5-08deb79a3bfb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|376014|1800799024|36860700016|11063799006|56012099003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: KUtISB2XNC3JM70QwbR7PL4gLVbwtqYK+wMtI4+QjWENS2oaRJ5CYOFJvUgekhOfb4B4ynEadfiXW4e/JifIkHcNTH0zVtvP7kI99ESMhAR9Elctc+KBMaZ30P8M4828cap4WPMrIOruZl8grs0K4ISwEp3eUP5IVp85p5m5KD9eT2RlBmr+IIajfhrbXXA1MVwQoEuZIIsfVD+C25k9ayyizFJDt/FVrCJ+r2FbU2iIK6oJTxdeIGYKtaqah7WCu/XbhL0s9a7n8l+EA4aeL9NXfWQkyl4jV7jbyDsfshXtf67jNSiczLFhmvHzrKHa4eNnrZ5nRfG/G+bD4XU4osM7jSFlhftaUfvJ+erR6d6932xJ0NXRykAsrYzy3VSuLMh7XBKYin/MiOTmsFo/o6wJV4BiL4+PORqzBEEnJD+XxbzOfzrFD5wvS2SGGlg+t7pWCr3zchl8ZxI8RiCYAHNUBHg/b7TodnaXq58Yqn7wHne/1j2xsyP5MB+6UcKv5l0Mq5PosDpHI+nWqkdE1HXn880TlX1e1jg3GxUucmr1hSE9y6/0mLd/1xVhYFlhEZ6RkanjUY7ZxBUPOrKBsW53xNqxU5qJFhkxaaC/tuXPkSwGu0WtvgPlZ7l5oSIfUEsYRL6ctabLJzOR1jqXD71g8VNlWxTETGJu74GcdYf8AFtos85UokLoMfZFJNOYU9DpWXDDqkICnxbUew3ar3Ie9OgKtt/4jcYjbeneE0g= X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230040)(82310400026)(376014)(1800799024)(36860700016)(11063799006)(56012099003)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: ivKZD+5cKcuHOHeBB67edg4AO2n/4OnqQzgIVCzg95qnUi9KYwFPEquSoysbOG4Vq7UHTno7jXa8epN8Bg2jsQ3uWaZRCH1jFfBC0JwGP8WMnSnYcIuLFXPTDyifTmazxr6zbLrRiSEqs90VgL7xRKAhkGv6R5yAb/OZj0RRZnBCsIlAFwX0TCILYmQkUC9wku2l8M/gnz8iscIDReASRe5k5KXFT7ZnBRikDGUbwsR3Ze/rsK5piMGADLh5BJadhS6FaCx7BpwRXYHljwGV5VolK2sV5ys62ON4s8V4H8HVIxKmIm0HcHv12o4oXPy4UCeMKbPmZ/Y8Qr5DZ4JYgbsrhQbVk7F1fpqB10t4ijJwEf08AQVtBhm+IL1Vis3vzHk0HFEKzY7cy1g3onTx7/YV4rwIeyUBQZg6sfRqqXOHwe3y3ugFhGkzuiO3Zvc+ X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 May 2026 00:36:59.1039 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cd687478-c3ab-4491-fdf5-08deb79a3bfb X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000FCBE.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB8550 Content-Type: text/plain; charset="utf-8" The veventq memory allocation happens inside the spinlock. Given its depth is decided by the user space, this leaves a vulnerability, where userspace can allocate large queues to exhaust atomic memory reserves. Move the allocation outside the spinlock and use GFP_NOWAIT, which can fail fast under memory pressure without dipping into the GFP_ATOMIC reserves or direct-reclaiming from the threaded IRQ handler. On allocation failure, queue the lost_events_header (so userspace learns of the drop) and return -ENOMEM so the caller learns of the kernel-side memory pressure. This is intentionally distinct from the queue-overflow path, which also queues the lost_events_header but returns 0: a full queue is an expected userspace-pacing condition rather than a kernel error. A subsequent change will cap the upper bound of the veventq_depth. Fixes: e36ba5ab808e ("iommufd: Add IOMMUFD_OBJ_VEVENTQ and IOMMUFD_CMD_VEVE= NTQ_ALLOC") Cc: stable@vger.kernel.org Reviewed-by: Jason Gunthorpe Signed-off-by: Nicolin Chen --- drivers/iommu/iommufd/driver.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/iommu/iommufd/driver.c b/drivers/iommu/iommufd/driver.c index 61e6b02601d1a..3b8067976eac0 100644 --- a/drivers/iommu/iommufd/driver.c +++ b/drivers/iommu/iommufd/driver.c @@ -149,15 +149,18 @@ int iommufd_viommu_report_event(struct iommufd_viommu= *viommu, goto out_unlock_veventqs; } =20 - spin_lock(&veventq->common.lock); - if (veventq->num_events =3D=3D veventq->depth) { + /* Pre-allocate to avoid GFP_ATOMIC; use GFP_NOWAIT to avoid sleeping */ + vevent =3D kzalloc_flex(*vevent, event_data, data_len, GFP_NOWAIT); + if (!vevent) { + spin_lock(&veventq->common.lock); vevent =3D &veventq->lost_events_header; + rc =3D -ENOMEM; goto out_set_header; } =20 - vevent =3D kzalloc_flex(*vevent, event_data, data_len, GFP_ATOMIC); - if (!vevent) { - rc =3D -ENOMEM; + spin_lock(&veventq->common.lock); + if (veventq->num_events =3D=3D veventq->depth) { + kfree(vevent); vevent =3D &veventq->lost_events_header; goto out_set_header; } --=20 2.43.0 From nobody Sun May 24 20:33:10 2026 Received: from BN8PR05CU002.outbound.protection.outlook.com (mail-eastus2azon11011063.outbound.protection.outlook.com [52.101.57.63]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 888E81A6830; Fri, 22 May 2026 00:37:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.57.63 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779410229; cv=fail; b=KGWzo1lOG1bnLMP+xyRbPHYicmUU+HNkH34p7TFtWq6WRWqJKNhUNZKU+YoFSFqAb1IuGJbLk+dxFZxY2EmeCHCt+CWj0SQWgz/0EagMtE8Fsc+Hszo4lrTFTCisQTf2UUxWtxdih+e7mJHO82MPlKtAxcn8XDEkU9f89GHVqjU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779410229; c=relaxed/simple; bh=f9zT6lHn4sZmk5SEPdO1em/IsDyjT0oVI+RnRAjN+qM=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=hrXN2dfUY5N2kkcfA6KIskp9s2MqzwQ1okjhoMqagnefgq+NN473QytPbfl8ogOu9ViwAUtY5nJWNSabiOXKcKAWjmKnfC870QERt+D3SA/046xWAGTw0VyohFoLpeu+2+T51XRnWPJWdMYZBz4w1+OJ0LPNy6s4h5rOXCGRqv0= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=Zf/sBX5i; arc=fail smtp.client-ip=52.101.57.63 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="Zf/sBX5i" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=CuZfqqvSs+p7ORn0MNem+9oKbpHrZyccEP/iAoXurvJ86wpAIW3Jvp4nFyklS7VXVubucGqN1KRVncdaDqBcWxVfwuArjIGE7PJAnvKbfvIZ+5ubn+MK4EyOP19L+phasbnYJOCpwnkqQEjDQ739YPrr/TJNjbWSzbS45RDgHjrtdXQ66W889aXvkYdBLl2KdLo+dWaYG72ZTos46gIT440yiItdpUr7eq5WCNNIfmxKFoHsE49zzJle5mpuM4mzoypzD9dxhxImFQUqNeIM2iqDFL9UKfSlBuqdBkET+65knrVXKYh/3a5vZci6QBzObGqzxwdm08NOzetW0Ya3og== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0pXNcD8dqr177LjUHTJOoYQnuhsg+LCXEUqPcTXr6c0=; b=d5JzRv26wfP+bWAfZ0rA20w3BxH5joXaDTZFrqtDbm810tMtRTDYrqVGG/1bMUn0wPuKe7elesCRxFFX9YJ6zGU5bHjXtdM7D3Ao2IGVqMCh2UNj8I6jzDBsHThuewQ4uT8aGro2e0aygDMTjrt3/qYGT0n4JYX8OY+pnBNlNfUTRAdkGVVeAWWNgclVklxrHCaUgfiiCRzU93O/GR7SBTliRXC6KaFvE9VXmsywcCgb02lfS0OIMovK6KuUd1yNWOiAkCKlbJ7uEIIIhdRn2rT347DQs03xBpYv5lWCit+2Qr8uZKsPkKiRXGGUxA75Q4895Qs7W56u++e733zfbw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0pXNcD8dqr177LjUHTJOoYQnuhsg+LCXEUqPcTXr6c0=; b=Zf/sBX5ir+qqjdDFOOarWL7BpzBPPQXmx8f9MfPZhuRepbYNAopcEeF6WAXyMHMjJ/T5qkOvMXWuxa+N330wAeyNSvBYYcHEGW/3BSxf2j3C2D+bg8SW418JzS7BTbu6kgAYpp2iMOVpQoV1+HQJ8qDoPGGrkHKEYavfuzhRur4QBtxCfcE6Rf+4zUFJVW9Q6ODBaCS/U9aoQr5BB8+gxwoZEzhmojgHIiiIpfIcsViKA1hiipKIF6JowEA0FOZz+vSXSQUgpcKL8xF+NHAuwnnbjTDKZHJwgpyIEYUrYFoOpszmSMk5nCkvE+HkEQFFQMumeWQ2xcPNyc9EtLA/Ug== Received: from PH8PR22CA0017.namprd22.prod.outlook.com (2603:10b6:510:2d1::13) by MN2PR12MB4224.namprd12.prod.outlook.com (2603:10b6:208:1dd::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.48.14; Fri, 22 May 2026 00:37:00 +0000 Received: from CY4PEPF0000FCBE.namprd03.prod.outlook.com (2603:10b6:510:2d1:cafe::95) by PH8PR22CA0017.outlook.office365.com (2603:10b6:510:2d1::13) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.48.17 via Frontend Transport; Fri, 22 May 2026 00:36:59 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CY4PEPF0000FCBE.mail.protection.outlook.com (10.167.242.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.71.7 via Frontend Transport; Fri, 22 May 2026 00:36:59 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Thu, 21 May 2026 17:36:42 -0700 Received: from rnnvmail203.nvidia.com (10.129.68.9) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Thu, 21 May 2026 17:36:42 -0700 Received: from Asurada-Nvidia.nvidia.com (10.127.8.9) by mail.nvidia.com (10.129.68.9) with Microsoft SMTP Server id 15.2.2562.20 via Frontend Transport; Thu, 21 May 2026 17:36:41 -0700 From: Nicolin Chen To: , CC: , , Subject: [PATCH rc v2 3/4] iommufd: Set veventq_depth upper bound Date: Thu, 21 May 2026 17:36:34 -0700 Message-ID: <8426cbaa5e8294472ec7f076ef427cc473be5985.1779408671.git.nicolinc@nvidia.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000FCBE:EE_|MN2PR12MB4224:EE_ X-MS-Office365-Filtering-Correlation-Id: 62db34c7-d97d-4864-7708-08deb79a3c1f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700016|1800799024|376014|82310400026|11063799006|18002099003|22082099003|56012099003; X-Microsoft-Antispam-Message-Info: LOmBjSDdrbJO5Z3DKBHKwoTuITOsidpWwvNv1nx18ctpQrNxPsSc1E2Vr9vrj0xfv1KsqcvYPfPJBQKemjw7Jf3nS8Qcb3v812THVRCH31beyRNdHpAlnU2rEhGJKfUCByX4H/7sujKhvIF9kPmcQGvCMH3CRxMOj8WXQxpxEzJRNDU8UcvuJrCXp8Tuv2wYebPqwT7gHhkNzFFYucf2/VZaTeRvBaf79oaezYqwcs7c8M0lSxNZK3xiWd86KJ/8RQTkZbBmX4LcX/qw0bzMkxJJxcQKmxan0LgJgB0623tZ0YM3MWLKwY8+kDB726xOqkRpPWuKiq3wHmJHmgKvYm1JiZG3eC6Ti5/hGaY8BNG3fZj5FCspo0/rStEwsbcSRYprQdT1r+cCd6bYfGQI8/cjPNZZqy8qI3QybSBfuIWp2/wXKVQyEyG57vssiyMFcpxg+HZp0KzWxROrjE7RsASffM/vD4zjrd7nw9T/mhcKaO2pgJNEWcfb1Jys/6eUh+Q6v/YLmETJwPMP+KYZqnjkrFKZCOQGixu8XvzhCBv6NGurzUeeLb4/J4vpNdN9Y86PVBMPmSfj7k0a4liP8wF6qyRYs3KCIW8NrpE+KRvjmBZsXf4VGUmgte+CPb5+KbpIgrh3L6EbOLJo0CvalZ9xAv61OvqJfkJR44yjIExRhSHhZ+MWeLb+fM+z9s/DsP9Zp7JoSynCaTnFxxXK30FWvQ5IHNuiM9qbZ5QfHsw= X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230040)(36860700016)(1800799024)(376014)(82310400026)(11063799006)(18002099003)(22082099003)(56012099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: jqge+poNb4h8X8UO50DwyYVyl5zt9WTojKt+Z8AzrrkMVblVWP17NcScTzZhqDnVQyx8wsZIA+nrll/TEs9jRVadRduBv7DnRQQ+xdr8kwsM7tgU37eG4xkBggXk913xAXGZROCobB+iFBHgTqss9DER/fj46OEXwxtXM0EwQrktb6Spz+YopnVDz7A1FIdYsNTyaLYubFYo0CKDLauwtx1Eip3O9MjKFDbJMrqtTxQvpm29+Ge/L7pw1Xo2VAGXXc1YoYv5VCuFlG/XjD8WXZyeyQM7WhrGmQw+d3eRiGPvF+h8gA5qhrTHUYISXM6KOTPkecD4a6ZSi+B8PLzrR3YoATdM7++XINGsxknfTtwInJhA5lwEAiIsd6XEXhjsWnDFyUdqafiPwZSFqpkYaskeZV6ja8dYnBwK4hfy5M/Vq5elQswCcg1XaSNyUEJq X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 May 2026 00:36:59.3441 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 62db34c7-d97d-4864-7708-08deb79a3c1f X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000FCBE.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4224 Content-Type: text/plain; charset="utf-8" iommufd_veventq_alloc() accepts any !0 veventq_depth from userspace, with an upper bound at U32_MAX. This leaves a vulnerability where userspace can allocate excessively large queues to exhaust kernel memory reserves. Cap the veventq_depth (maximum number of entries) to 1 << 19, matching the maximum number of entries in the SMMUv3 EVTQ (the largest use case today). Fixes: e36ba5ab808e ("iommufd: Add IOMMUFD_OBJ_VEVENTQ and IOMMUFD_CMD_VEVE= NTQ_ALLOC") Cc: stable@vger.kernel.org Reviewed-by: Jason Gunthorpe Signed-off-by: Nicolin Chen --- drivers/iommu/iommufd/eventq.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/iommu/iommufd/eventq.c b/drivers/iommu/iommufd/eventq.c index 78689fb52d24c..1f1e415285b1a 100644 --- a/drivers/iommu/iommufd/eventq.c +++ b/drivers/iommu/iommufd/eventq.c @@ -473,6 +473,9 @@ int iommufd_fault_iopf_handler(struct iopf_group *group) static const struct file_operations iommufd_veventq_fops =3D INIT_EVENTQ_FOPS(iommufd_veventq_fops_read, NULL); =20 +/* An arbitrary upper bound for veventq_depth that fits all existing HWs */ +#define VEVENTQ_MAX_DEPTH (1U << 19) + int iommufd_veventq_alloc(struct iommufd_ucmd *ucmd) { struct iommu_veventq_alloc *cmd =3D ucmd->cmd; @@ -484,7 +487,7 @@ int iommufd_veventq_alloc(struct iommufd_ucmd *ucmd) if (cmd->flags || cmd->__reserved || cmd->type =3D=3D IOMMU_VEVENTQ_TYPE_DEFAULT) return -EOPNOTSUPP; - if (!cmd->veventq_depth) + if (!cmd->veventq_depth || cmd->veventq_depth > VEVENTQ_MAX_DEPTH) return -EINVAL; =20 viommu =3D iommufd_get_viommu(ucmd, cmd->viommu_id); --=20 2.43.0 From nobody Sun May 24 20:33:10 2026 Received: from BL2PR02CU003.outbound.protection.outlook.com (mail-eastusazon11011071.outbound.protection.outlook.com [52.101.52.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C5D725B085; Fri, 22 May 2026 00:37:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.52.71 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779410230; cv=fail; b=c6y01BsnS2HvyeU3Nov301hUXA+2RAIZsh3sUnHFCBNyUHfid8oHkvVtF7fDXu8dIduXJdAzlIKB/FLPNVYfLQ6crCa8EtNAecXSCdwX0Nbqpets5B+6k5BDN+qYXxWIvGy5VgYAag37vbo0lUnZ6beYbe9s8GCIFebzu6MPeE4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779410230; c=relaxed/simple; bh=GT0AUSVUCuQCW6gcF+TiFUVddGPKVDiY8pvVplqM7iw=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Yws7jaNmBHjGXSSewWRmJ4s7HoPYB//vlcBzXnd+QNnqK9kY53if4qGFkfOlWY9PnuZ4+IlQkvuvPxZEoKCoBv8C+ykc+x4fttFJVpEEA2mfnI32FcdOfRPM2PTlwk3d6b+pd0DTLnDDSSsFTRhIZrJNYYZksf4jWtCbiL+MaiI= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=UuJfEcC8; arc=fail smtp.client-ip=52.101.52.71 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="UuJfEcC8" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Z9ffXu9YY4dE6Ht6B5RlGoXvr20hFG77AxIwGaUfC9wSqNDjzo2kG305zs9RUj0+cYkpqNXFSFQkh7jCTMvE2yzzD5pVYqcsHpKrvzTROC9KJRkr3nIe2+utSa0Kg5+YtDntekvJWi8EY9VKtJuHrtRRwM0oT0cZdm9J64YuE28YHPkTe6OGMZ+gAQZIEVS2TLkIavF1Q0zOL0V4F+VUAFv2gT2+/HOYA2v3hr84BCjmhnDjx1Cn6kkvnjTur+6gazIyYlFsWsHZDgkU4ri9iD9k26gb0fr/p/MOTZgqTutilofx/C2uRrxSRm+Ui9m628bkJouL+IzfJjKlw1/jFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gov9BKeVnSWW3QrhCMW/hZNf0fugHK+cxQ55e28u2e8=; b=PiOfHieL+bi8Rv7dXyd5fYic2ojNd0iUW1JWUto009O00I1p5JP7b6QwR/GngsGMkD8nQkh0ES7iylyvbNyRfLKxEXkqHf70VT6Dn4St3E88nSE8NtQlnpKp9bC2s2daAzFEyU/DANEUcRWGMi2/6l2Cm+3as+WM7GDIIcZqGQ5iYv1Z77l0Zjsm108MAs1NDg7OsVKPa5EOnv121PWSksk7zZRuHEib0eSvVYtMfTLeSMMCBX0Ic6HiMvXuP8x8pZvFfPC84tMREnDX2czsY+vwKwiRzL59yKBzkXkc/hlt7+Mv/tLGvOo1HpVHqOzD96feNUwA8w9TVPMMfK+VUA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gov9BKeVnSWW3QrhCMW/hZNf0fugHK+cxQ55e28u2e8=; b=UuJfEcC8xGWqztDtC+ChBmAwOQVacCBCu789CRpNZPBEU1pOxqLaHoolUSWJIHJUqBFiH/ntLWe+EZcMLGk/+SbvNk7X5vrsvRLeA2R22hboG5D7gai5/lA37bGv+W0t4NdTijfM2yN2cbPoNylKkUvkZ0HEhkrhED8ofQkdTXj1DtdShCpnEq381jtyqYVJ7KEOYwyt2SOF/d/2/pRcf+m8RGyvKMZNsIDY68l9hS7+CyfdRongIwjlsbPz8Kinai8F8zj4qArHINAhSeHhrFyeIDtvyLv2PW4MqHIa76iNM9LgUBcneNqvCtDv1OsQfLSmlWHyIfg2xuWLeC7M5A== Received: from MW4PR03CA0128.namprd03.prod.outlook.com (2603:10b6:303:8c::13) by DS3PR12MB999217.namprd12.prod.outlook.com (2603:10b6:8:390::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.48.14; Fri, 22 May 2026 00:37:00 +0000 Received: from CO1PEPF000075ED.namprd03.prod.outlook.com (2603:10b6:303:8c:cafe::b5) by MW4PR03CA0128.outlook.office365.com (2603:10b6:303:8c::13) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.48.17 via Frontend Transport; Fri, 22 May 2026 00:37:00 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by CO1PEPF000075ED.mail.protection.outlook.com (10.167.249.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.71.7 via Frontend Transport; Fri, 22 May 2026 00:37:00 +0000 Received: from rnnvmail205.nvidia.com (10.129.68.10) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Thu, 21 May 2026 17:36:43 -0700 Received: from rnnvmail203.nvidia.com (10.129.68.9) by rnnvmail205.nvidia.com (10.129.68.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Thu, 21 May 2026 17:36:42 -0700 Received: from Asurada-Nvidia.nvidia.com (10.127.8.9) by mail.nvidia.com (10.129.68.9) with Microsoft SMTP Server id 15.2.2562.20 via Frontend Transport; Thu, 21 May 2026 17:36:42 -0700 From: Nicolin Chen To: , CC: , , Subject: [PATCH rc v2 4/4] iommufd/selftest: Add boundary tests for veventq_depth Date: Thu, 21 May 2026 17:36:35 -0700 Message-ID: X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000075ED:EE_|DS3PR12MB999217:EE_ X-MS-Office365-Filtering-Correlation-Id: 59781b85-e9c0-4bb9-a5d2-08deb79a3c8e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|82310400026|1800799024|36860700016|22082099003|18002099003|56012099003|11063799006|6133799003; X-Microsoft-Antispam-Message-Info: 6jcHm3QC5GLJXFTE4exPfjHyId6f0o6hAWOH5OKKBaWpxNi+OFlf4h9zg/B+ui6Tu/KKh6ZSnYnMHTBh73yUjuOE9Nqp1l1SYsn5CkiDFKXMMnnphRRXMFLDktGN+ZN8qXngnI68cw9X9V/CuxTZx0LJ/5FljtZaCX8EbOJVbKaMSd8V4A8B6iLJBe48f9AkCteh9NBFkfehlLoQ9VehWMuKeueyQlNI7MO+OwttCWR16mOjYC1MmMlCtPD5N2ASfLFdnerZjywQrpjyWOzujBn1XzIUJb1RvZctjezisc7JBzdRlrlR3LCUslzjlD6ujR9RkXzWDzhc+8kcVQDWBM2QXkVik6vXdtn63K/yYvGuB8PXTtA7BUXG8XKFJif58UZqiKvVlbFhXNlsuKiNbOxjQVPMC0Wp7LBYMj5/+a5USf7soDC6Uuq2hPDUoy0uE6c5Ynqf7wUnZ1LqyuLBFUEFO8HHO596UHPWVfjp0cqiEJxsqniYhlh4yKCoLGhZh890zP8WJeRKrYMhCsaJ42GPI70hBIBRN02GX/tHXWsjgirlmgXnJ9GH0WuWU+yALP0xKBKyKU1E/HQt6HDCVxgJMTwGI+14BwscDnR55NbHezq+kzHHaQ8+BZDpNVO5sDZ+bfgfvNVKOqWiQ3CpiXVyoOBtpIez8mxjoLCpY0OWZ54LhtMEyTkVJMX2Qh+J8+Vfus9fWZwtc0JEPs/5I9UNufG+vIaanuokT/9pHd4= X-Forefront-Antispam-Report: CIP:216.228.117.161;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge2.nvidia.com;CAT:NONE;SFS:(13230040)(376014)(82310400026)(1800799024)(36860700016)(22082099003)(18002099003)(56012099003)(11063799006)(6133799003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 6oOnuRzRqSsd+ULxQ7rHGXhtSmDHfmrDcPSJBD19nX8ON+lKpnEBh7N9AstVqpJlhdwjeznA9wpwNcucyRJcu1h/LOo0kmM2yKtjcVrpcoI5EBX5Wjh+CYjrwQeuiB+iyRn078nzJ+eJ0bWKYLAIl70wT0Gz5nNofTLgFdmPrA93v83s0LW4MvOUIdEHFMshpzwBRpwRecTsiggLv0eOIXXAnevBJdOpvcykhZS+C5jOOEwHYv56Mq4mQ1t9qa+X3W7b2hFgjKeJZyATCBtX4dz0ybYfp4T3ROC11tLF5sOhs2rFLJTYHsO/PZZHfzukRwW4e3k8JV6PJewwv5/Jy4vsdN5UuFjTB+HKWtzBvj6HjQjdlpwAznLVBvm0TTUB/G7ApSS4RdC31KpycaRos89in6Un7u6TQvDMJiiEVfbvGqzVenhQRNvbFizI0S0F X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 May 2026 00:37:00.0946 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 59781b85-e9c0-4bb9-a5d2-08deb79a3c8e X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000075ED.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS3PR12MB999217 Content-Type: text/plain; charset="utf-8" Test veventq_depth to cover a memory exhaustion vulnerability. Keep veventq_depth=3D2 for the existing callers. Reviewed-by: Jason Gunthorpe Signed-off-by: Nicolin Chen --- tools/testing/selftests/iommu/iommufd_utils.h | 17 +++++++++-------- tools/testing/selftests/iommu/iommufd.c | 19 +++++++++++++++++-- .../selftests/iommu/iommufd_fail_nth.c | 2 +- 3 files changed, 27 insertions(+), 11 deletions(-) diff --git a/tools/testing/selftests/iommu/iommufd_utils.h b/tools/testing/= selftests/iommu/iommufd_utils.h index 5502751d500c8..b4928cbd4d9c8 100644 --- a/tools/testing/selftests/iommu/iommufd_utils.h +++ b/tools/testing/selftests/iommu/iommufd_utils.h @@ -1060,12 +1060,13 @@ static int _test_cmd_hw_queue_alloc(int fd, __u32 v= iommu_id, __u32 type, base_addr, len, out_qid)) =20 static int _test_cmd_veventq_alloc(int fd, __u32 viommu_id, __u32 type, - __u32 *veventq_id, __u32 *veventq_fd) + __u32 depth, __u32 *veventq_id, + __u32 *veventq_fd) { struct iommu_veventq_alloc cmd =3D { .size =3D sizeof(cmd), .type =3D type, - .veventq_depth =3D 2, + .veventq_depth =3D depth, .viommu_id =3D viommu_id, }; int ret; @@ -1080,13 +1081,13 @@ static int _test_cmd_veventq_alloc(int fd, __u32 vi= ommu_id, __u32 type, return 0; } =20 -#define test_cmd_veventq_alloc(viommu_id, type, veventq_id, veventq_fd) \ - ASSERT_EQ(0, _test_cmd_veventq_alloc(self->fd, viommu_id, type, \ +#define test_cmd_veventq_alloc(viommu_id, type, depth, veventq_id, veventq= _fd) \ + ASSERT_EQ(0, _test_cmd_veventq_alloc(self->fd, viommu_id, type, depth, \ veventq_id, veventq_fd)) -#define test_err_veventq_alloc(_errno, viommu_id, type, veventq_id, \ - veventq_fd) \ - EXPECT_ERRNO(_errno, \ - _test_cmd_veventq_alloc(self->fd, viommu_id, type, \ +#define test_err_veventq_alloc(_errno, viommu_id, type, depth, veventq_id,= \ + veventq_fd) \ + EXPECT_ERRNO(_errno, \ + _test_cmd_veventq_alloc(self->fd, viommu_id, type, depth, \ veventq_id, veventq_fd)) =20 static int _test_cmd_trigger_vevents(int fd, __u32 dev_id, __u32 nvevents) diff --git a/tools/testing/selftests/iommu/iommufd.c b/tools/testing/selfte= sts/iommu/iommufd.c index d1fe5dbc2813e..2e8a27dab0bb8 100644 --- a/tools/testing/selftests/iommu/iommufd.c +++ b/tools/testing/selftests/iommu/iommufd.c @@ -2986,11 +2986,26 @@ TEST_F(iommufd_viommu, vdevice_alloc) test_err_mock_domain_replace(ENOENT, self->stdev_id, self->nested_hwpt_id); =20 + /* Test depth lower and upper bounds (mirrors kernel cap) */ +#define VEVENTQ_MAX_DEPTH (1U << 19) + test_err_veventq_alloc(EINVAL, viommu_id, + IOMMU_VEVENTQ_TYPE_SELFTEST, 0, NULL, + NULL); + test_err_veventq_alloc(EINVAL, viommu_id, + IOMMU_VEVENTQ_TYPE_SELFTEST, + VEVENTQ_MAX_DEPTH + 1, NULL, NULL); + test_cmd_veventq_alloc(viommu_id, IOMMU_VEVENTQ_TYPE_SELFTEST, + VEVENTQ_MAX_DEPTH, &veventq_id, + &veventq_fd); + close(veventq_fd); + test_ioctl_destroy(veventq_id); + /* Allocate a vEVENTQ with veventq_depth=3D2 */ test_cmd_veventq_alloc(viommu_id, IOMMU_VEVENTQ_TYPE_SELFTEST, - &veventq_id, &veventq_fd); + 2, &veventq_id, &veventq_fd); test_err_veventq_alloc(EEXIST, viommu_id, - IOMMU_VEVENTQ_TYPE_SELFTEST, NULL, NULL); + IOMMU_VEVENTQ_TYPE_SELFTEST, 2, NULL, + NULL); /* Set vdev_id to 0x99, unset it, and set to 0x88 */ test_cmd_vdevice_alloc(viommu_id, dev_id, 0x99, &vdev_id); test_cmd_mock_domain_replace(self->stdev_id, diff --git a/tools/testing/selftests/iommu/iommufd_fail_nth.c b/tools/testi= ng/selftests/iommu/iommufd_fail_nth.c index 45c14323a6183..25495d8dceb3d 100644 --- a/tools/testing/selftests/iommu/iommufd_fail_nth.c +++ b/tools/testing/selftests/iommu/iommufd_fail_nth.c @@ -712,7 +712,7 @@ TEST_FAIL_NTH(basic_fail_nth, device) return -1; =20 if (_test_cmd_veventq_alloc(self->fd, viommu_id, - IOMMU_VEVENTQ_TYPE_SELFTEST, &veventq_id, + IOMMU_VEVENTQ_TYPE_SELFTEST, 2, &veventq_id, &veventq_fd)) return -1; close(veventq_fd); --=20 2.43.0