From nobody Sun May 24 21:37:42 2026 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3FD2E23D2A4 for ; Thu, 21 May 2026 10:46:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779360417; cv=none; b=u2ELxkBVcanRBrsLfHVRupxMkXpUk91hhMpXZR37/fFK/ryhxcS6csv+uIUpR53V5AyTBPbGqC15r3ti+Irnpws75NQrEF8CNCPWJ32Wf7jvDGEN8qlZjOp1NJeG8opo77vTf0MfhcY7FNCH4C7cCFLcqrWcY+hf9CNNH9K35OM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779360417; c=relaxed/simple; bh=hHqm2JajeDJkz7bgdxBpifnFANuMr7Q4jybWP3ijEV8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Rffb/a0FAB4HSN5TcFfnSP4K9/b9vl7xmUS5o93+nFhZ5GVxkvxRIb3SWtGfE1+ZdipFub89HbBLqLXBJQfVrkFAUFpq0bSi5ps1dt/29hE/rq9A88B83jhfP+zOiZYEbMWQIGC5OtotIsr/t0Huj6yfU3Xp+Q60ucHrQ1FdCs4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=PsgsJyjr; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="PsgsJyjr" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-48d146705b4so66184925e9.3 for ; Thu, 21 May 2026 03:46:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1779360413; x=1779965213; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fudxIc1zi5+p7NnnZQQo2fKLSTB9Gth4+OZ1JNao65A=; b=PsgsJyjr/AcD/rlAp9L8OwOjVKY/NltCs7dM/EKogRIF8Zc5d2e5caReUMt3A+0/1k z9Nezb9vX2lscGcEju+OVUeEmjBlPQWxExbi6Vfhaa7V2VItnWJKyunRFGaSoM8WMr2W aruiJT63Z+v75ZUaFKH+ivRn8uL/4eQqsu9kAZ//uODtudQIXOwWsbPe+flrteKdXzk0 41Qy7ubhGXzU/qwFO1xXRK4nlKd8DTA6aU/mYOMugnwvT50uFOeNAj1KRp/uwG808K2R uAGNLFQhEC1mzx7QZthu8YBMrLBrsqocL8KolO6gzs7uEl4LS+R489a9pLT4jcP6J/6M sGGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779360413; x=1779965213; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=fudxIc1zi5+p7NnnZQQo2fKLSTB9Gth4+OZ1JNao65A=; b=J8CWHQdBsi15BTDrWTUeE03TlRWf/8SbRRBim8Fv21wQ0dhRkR+qIYwXNqU1k+QyKJ 4caRAU1fjXBErnSIz/KiNrFa/tTofLM/xdWj9DwRKdu2aE1HeAJYRpL4oPh51PnBUOg4 vN+pVKTKtQ4ZWLhmG8ekJPl6/quU7a/CY7aMp83cQ2Bs89FR0s9b7o0l1uXIq7+V9LRF SSET2DxVnW3DZh1iN9XUHVL4RDDy6h0Z9dTn2Z1O9roMj0wK5KrhGAYfTqK9MwwDlBOK 3DpSJWE1yh1DrOgHzzWEqvJTCpGsX03Il9q/55EC052w9+rIdfcmU5oM27S5AwjKBIZZ yagw== X-Gm-Message-State: AOJu0YxnMzrehNyZPeuDwUyYo9+sVKkUuGSbb1/SxqWRiJ2mhCfhyyzw wZUEAzue8ajffg/oaUMFwkrDPjMo5Y7ArBtoYEPdcvOi6K9cE5lsoS/gFt+bge+g5H32v3h8N4T CrEUKV+g= X-Gm-Gg: Acq92OHiGag1Fp+JIZLwO2njaasLk9ZnrKt9xf/Sq3nkH+yllmYP7qmkbnZaqgxGgZR jfAX+yBHyaS/2u89CqHgrjM86ukh5iGVhMpC3Le2eJdzGAbLNtFbdLHiA/U/L2lvyJ3rPGg77qT E0hhUYV+bt2/hhSWk8t4iGlirrr0GtiwElqwG8J6I876RSmovRwM1HR/A/kM9PB/w8z/ciLtfIr W4R8M5OXBmkx+E5XzIu1QxVvyzYB7R26kQQkszn3tgN3Bw4/z/nr+NWyQwXZt2FJST9F6AdMXiv TEPLXMgDq9D5esLebPgvHu8pMxNh0N8nYPAiyFzSLS3jbcU+36LZ3StQNO196bdzlppe7luU69v FU/HWNkdQMc+zziMHVd/vB5kkX1Nc/Khpl59J0yCz3ZuoF6XqtYWjySAcJcPtyrT2QSeGsClvTK rV1SlJkmtOFr7MdSCqMkfN0Ha9+vgQXNtYrbU6cw7yNBSI/BEo2TxZzpThN1UTZfnHQ7RmlCkWk FxBYziqu3fVOQ6GQ4oAJsCn X-Received: by 2002:a05:600c:32af:b0:488:9ed3:1492 with SMTP id 5b1f17b1804b1-4903605e3damr21099645e9.10.1779360413578; Thu, 21 May 2026 03:46:53 -0700 (PDT) Received: from localhost (p200300f65f47db040f2ec809c82cfba7.dip0.t-ipconnect.de. [2003:f6:5f47:db04:f2e:c809:c82c:fba7]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-4903cd7f7efsm14417995e9.14.2026.05.21.03.46.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 May 2026 03:46:53 -0700 (PDT) From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig=20=28The=20Capable=20Hub=29?= To: Arnd Bergmann , Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org Subject: [PATCH v1 1/2] misc: pch_phub: Drop two unused functions Date: Thu, 21 May 2026 12:46:35 +0200 Message-ID: X-Mailer: git-send-email 2.47.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=5738; i=u.kleine-koenig@baylibre.com; h=from:subject:message-id; bh=hHqm2JajeDJkz7bgdxBpifnFANuMr7Q4jybWP3ijEV8=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBqDuKONmf9s8a/mKlS/exf8mpa29h5wvUInB916 uE55oCjTZKJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCag7ijgAKCRCPgPtYfRL+ Tlx4B/97M6tCPoq8zOeB5opwOObfCbt/davBo8ZMfgYd0bUIZ1ZxUFkviZVjG6FDTVtOrYUqoDB 9q6fQPfOh2LZVOItnHYJYdweTnWlTbrKSjhnqKQPlHWpGNPl4jJLPTZv4k+NJSrZm0OzLrrvsmy RQlF6iBYQqhV0vl0KIsp3jjSGMHOW9ZM88A01/LfzykutT5sriKs3xLOnUd8nS+zicKcDWOZPKX 5y08a95OXEyGg0pN2RFyCUjZytwgNHPZt3TlIDB+GSxOc01GOafm0nP1lOYKDHJtVpLUniHO6Z9 EOYPRTFYib1BPkcxogLmNIvJTaEMid1pBT8/IGbiidAdRRPj X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable The two functions are unused since commit 34afa1d657d4 ("misc/pch_phub.c: use generic power management") but the compiler didn't warn about it because the same commit marked the functions as __maybe_unsed. Signed-off-by: Uwe Kleine-K=C3=B6nig (The Capable Hub) --- drivers/misc/pch_phub.c | 123 ---------------------------------------- 1 file changed, 123 deletions(-) diff --git a/drivers/misc/pch_phub.c b/drivers/misc/pch_phub.c index fd147fd2800f..539912e825eb 100644 --- a/drivers/misc/pch_phub.c +++ b/drivers/misc/pch_phub.c @@ -149,129 +149,6 @@ static void pch_phub_read_modify_write_reg(struct pch= _phub_reg *chip, iowrite32(((ioread32(reg_addr) & ~mask)) | data, reg_addr); } =20 -/* pch_phub_save_reg_conf - saves register configuration */ -static void __maybe_unused pch_phub_save_reg_conf(struct pci_dev *pdev) -{ - unsigned int i; - struct pch_phub_reg *chip =3D pci_get_drvdata(pdev); - - void __iomem *p =3D chip->pch_phub_base_address; - - chip->phub_id_reg =3D ioread32(p + PCH_PHUB_ID_REG); - chip->q_pri_val_reg =3D ioread32(p + PCH_PHUB_QUEUE_PRI_VAL_REG); - chip->rc_q_maxsize_reg =3D ioread32(p + PCH_PHUB_RC_QUEUE_MAXSIZE_REG); - chip->bri_q_maxsize_reg =3D ioread32(p + PCH_PHUB_BRI_QUEUE_MAXSIZE_REG); - chip->comp_resp_timeout_reg =3D - ioread32(p + PCH_PHUB_COMP_RESP_TIMEOUT_REG); - chip->bus_slave_control_reg =3D - ioread32(p + PCH_PHUB_BUS_SLAVE_CONTROL_REG); - chip->deadlock_avoid_type_reg =3D - ioread32(p + PCH_PHUB_DEADLOCK_AVOID_TYPE_REG); - chip->intpin_reg_wpermit_reg0 =3D - ioread32(p + PCH_PHUB_INTPIN_REG_WPERMIT_REG0); - chip->intpin_reg_wpermit_reg1 =3D - ioread32(p + PCH_PHUB_INTPIN_REG_WPERMIT_REG1); - chip->intpin_reg_wpermit_reg2 =3D - ioread32(p + PCH_PHUB_INTPIN_REG_WPERMIT_REG2); - chip->intpin_reg_wpermit_reg3 =3D - ioread32(p + PCH_PHUB_INTPIN_REG_WPERMIT_REG3); - dev_dbg(&pdev->dev, "%s : " - "chip->phub_id_reg=3D%x, " - "chip->q_pri_val_reg=3D%x, " - "chip->rc_q_maxsize_reg=3D%x, " - "chip->bri_q_maxsize_reg=3D%x, " - "chip->comp_resp_timeout_reg=3D%x, " - "chip->bus_slave_control_reg=3D%x, " - "chip->deadlock_avoid_type_reg=3D%x, " - "chip->intpin_reg_wpermit_reg0=3D%x, " - "chip->intpin_reg_wpermit_reg1=3D%x, " - "chip->intpin_reg_wpermit_reg2=3D%x, " - "chip->intpin_reg_wpermit_reg3=3D%x\n", __func__, - chip->phub_id_reg, - chip->q_pri_val_reg, - chip->rc_q_maxsize_reg, - chip->bri_q_maxsize_reg, - chip->comp_resp_timeout_reg, - chip->bus_slave_control_reg, - chip->deadlock_avoid_type_reg, - chip->intpin_reg_wpermit_reg0, - chip->intpin_reg_wpermit_reg1, - chip->intpin_reg_wpermit_reg2, - chip->intpin_reg_wpermit_reg3); - for (i =3D 0; i < MAX_NUM_INT_REDUCE_CONTROL_REG; i++) { - chip->int_reduce_control_reg[i] =3D - ioread32(p + PCH_PHUB_INT_REDUCE_CONTROL_REG_BASE + 4 * i); - dev_dbg(&pdev->dev, "%s : " - "chip->int_reduce_control_reg[%d]=3D%x\n", - __func__, i, chip->int_reduce_control_reg[i]); - } - chip->clkcfg_reg =3D ioread32(p + CLKCFG_REG_OFFSET); - if ((chip->ioh_type =3D=3D 2) || (chip->ioh_type =3D=3D 4)) - chip->funcsel_reg =3D ioread32(p + FUNCSEL_REG_OFFSET); -} - -/* pch_phub_restore_reg_conf - restore register configuration */ -static void __maybe_unused pch_phub_restore_reg_conf(struct pci_dev *pdev) -{ - unsigned int i; - struct pch_phub_reg *chip =3D pci_get_drvdata(pdev); - void __iomem *p; - p =3D chip->pch_phub_base_address; - - iowrite32(chip->phub_id_reg, p + PCH_PHUB_ID_REG); - iowrite32(chip->q_pri_val_reg, p + PCH_PHUB_QUEUE_PRI_VAL_REG); - iowrite32(chip->rc_q_maxsize_reg, p + PCH_PHUB_RC_QUEUE_MAXSIZE_REG); - iowrite32(chip->bri_q_maxsize_reg, p + PCH_PHUB_BRI_QUEUE_MAXSIZE_REG); - iowrite32(chip->comp_resp_timeout_reg, - p + PCH_PHUB_COMP_RESP_TIMEOUT_REG); - iowrite32(chip->bus_slave_control_reg, - p + PCH_PHUB_BUS_SLAVE_CONTROL_REG); - iowrite32(chip->deadlock_avoid_type_reg, - p + PCH_PHUB_DEADLOCK_AVOID_TYPE_REG); - iowrite32(chip->intpin_reg_wpermit_reg0, - p + PCH_PHUB_INTPIN_REG_WPERMIT_REG0); - iowrite32(chip->intpin_reg_wpermit_reg1, - p + PCH_PHUB_INTPIN_REG_WPERMIT_REG1); - iowrite32(chip->intpin_reg_wpermit_reg2, - p + PCH_PHUB_INTPIN_REG_WPERMIT_REG2); - iowrite32(chip->intpin_reg_wpermit_reg3, - p + PCH_PHUB_INTPIN_REG_WPERMIT_REG3); - dev_dbg(&pdev->dev, "%s : " - "chip->phub_id_reg=3D%x, " - "chip->q_pri_val_reg=3D%x, " - "chip->rc_q_maxsize_reg=3D%x, " - "chip->bri_q_maxsize_reg=3D%x, " - "chip->comp_resp_timeout_reg=3D%x, " - "chip->bus_slave_control_reg=3D%x, " - "chip->deadlock_avoid_type_reg=3D%x, " - "chip->intpin_reg_wpermit_reg0=3D%x, " - "chip->intpin_reg_wpermit_reg1=3D%x, " - "chip->intpin_reg_wpermit_reg2=3D%x, " - "chip->intpin_reg_wpermit_reg3=3D%x\n", __func__, - chip->phub_id_reg, - chip->q_pri_val_reg, - chip->rc_q_maxsize_reg, - chip->bri_q_maxsize_reg, - chip->comp_resp_timeout_reg, - chip->bus_slave_control_reg, - chip->deadlock_avoid_type_reg, - chip->intpin_reg_wpermit_reg0, - chip->intpin_reg_wpermit_reg1, - chip->intpin_reg_wpermit_reg2, - chip->intpin_reg_wpermit_reg3); - for (i =3D 0; i < MAX_NUM_INT_REDUCE_CONTROL_REG; i++) { - iowrite32(chip->int_reduce_control_reg[i], - p + PCH_PHUB_INT_REDUCE_CONTROL_REG_BASE + 4 * i); - dev_dbg(&pdev->dev, "%s : " - "chip->int_reduce_control_reg[%d]=3D%x\n", - __func__, i, chip->int_reduce_control_reg[i]); - } - - iowrite32(chip->clkcfg_reg, p + CLKCFG_REG_OFFSET); - if ((chip->ioh_type =3D=3D 2) || (chip->ioh_type =3D=3D 4)) - iowrite32(chip->funcsel_reg, p + FUNCSEL_REG_OFFSET); -} - /** * pch_phub_read_serial_rom() - Reading Serial ROM * @chip: Pointer to the PHUB register structure --=20 2.47.3 From nobody Sun May 24 21:37:42 2026 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 814203ABD98 for ; Thu, 21 May 2026 10:46:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779360418; cv=none; b=qezVhDM2tseSK3grDsR4DhO9mVLCcbZeKNIfjqboKDdYsvDwmYoP+JAD4oqVmpkkxl6vqcvNK9UUzxuq9VipDlHOjoXUsd1S6fqMhfXSkj0YDTKLudI46iay6aqmcDC1+Dps55lC2qRh8zlw4BLCKObOcVz+/746ftEKUUi59iE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779360418; c=relaxed/simple; bh=x8ti7oZfW/QnelpJ698IS10leyZ4WpUCpJwO5tzf0xQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Shv0c1InoZ0lc4iMPyoeHpi6NISEZqtQwtUdV+txwCCBqWwAqcso0BF6URRN9wNlMphAI/atXlmlfyAKK54lMSxmTVCiGjUyD2MhGtyeKw5RY62P+CvZnz8aOGY0jP/YwYQq5dl1oEWvmQTgRSa14FYIl3xFsD/Wen2q4f//5Hc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=CT297wBB; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="CT297wBB" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-43d734223e4so3949856f8f.0 for ; Thu, 21 May 2026 03:46:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1779360415; x=1779965215; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=KFwqthb+KE006WyCJrSta7wPem5BYQJyBIalucAzTR4=; b=CT297wBBoArCK+HPBH4394IBkbYo+BHI8V+77phyOziGtxG/Z16JPmPBVvPy68CN+l vWbJL2J5RjbEoiqzJBxPBbgta4HzIGwKrzPjDvci7B/gkd3ExpAolhbyV67Vb78OYiVy /iU5n0EBHHpF6/FGS0H76IrK7v8ca99aMicYKCO7E/b1D5XbRKdQLHPtZtPqP+BJ1kxi y4+PW/Hz0Z5dTVGzyP2Q6koWr82BPtk5PK1YrBnbGInR6m6xDf6Qw6ZhjSUJuaNEq0FW 3Y9ev4Ivm36/D5ocBBwveTwZpIK1F2HNojcX6ec79Kvz9mOE/bt6oltQj76BgK/OQCIt TpxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779360415; x=1779965215; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=KFwqthb+KE006WyCJrSta7wPem5BYQJyBIalucAzTR4=; b=TX0VajCymIXweGCnBf9t0YfYJ7EM/i1g0UzpgIkQqYu5/Wui3yfMZRrtr7mPLJmQqf ukE8WP1qsuFMTYp8eSIa+DqgE4d7vuBKFAoQA6Lv+b4FePDFvBU9FKTwTauo2RE1sgZ4 X2zJv5188yxGG1rmP9vKjL4RYEg+bEpbwfLKL5uSlOk/ZY0og+7vi621xqVAlUXRkzh/ PEoz2mmvp2pp+m7l3k/ekJi3xQxvKYs1uuC3LlcI3SXWv3yee5QXCUqne+UGvFAvHnim 6UncSyvpeEaEQ6vJjWNNM/Sxf8FY4M9KlaGjq/EQl0eQJdvaTHz/2BcJNmqGuilYfGJN db0A== X-Gm-Message-State: AOJu0Yy9H3nM/dVYjUcd2QM0/tCcFvSmfGI/JIx2AlAEL4Gf0nGJU2a6 LtNUmwej7HWgZIJszQF6PsUbc91zNprqfA+hds7VbxrWij4O5Dhlpshwa7MlEIjjGn4= X-Gm-Gg: Acq92OFWXYJd2e5Otaehh4cKNux0AAxozk5/Rm9+a/dj3vIruYxKbEe53tobIWrVnBk UDTCqh9R1O5pbipE3yO02WmdhkBvPFjiL+kH32isQITSPoX9YasUO6HdLcNRnG5kWOdF3ynDkGC wEFdpXHK2VHoBd7LonERbMv7RSmc04PKqfr09IP9otYml+TC5krHHfC1YMF+GuG+J4UI6gnbKcS JmKd/GU6TNubiEj0a1/H/kV3qxvJoJ9m6146Je8TeXbDMAEjQA6sqgASk/XylGyhJpFsemF+pQn 1lI6Qc81TE6NZ5/c42CIw9ED3t5rZea0gNPapQ9qJBkPht6nKrqaO0CkF9fDUcPxQuKDnI7/zbZ OiLBspG8w4XBHBiIloqBG2dxrDBTxh/Cc6b/isFf1roV/c6/On3qL8UhPz0ypxG/VgLNR214oGz CWtSpMybxnPa91yET/xpiYah9g7LGOxwp22H8pF63fjx8/dgX7Cxjjh6tFEYbQWsjsewnpDWORs Iwjinbz7D2oTpdYWnihCOfB X-Received: by 2002:a5d:5c89:0:b0:45e:89e9:348b with SMTP id ffacd0b85a97d-45ea3138df8mr3967106f8f.7.1779360415018; Thu, 21 May 2026 03:46:55 -0700 (PDT) Received: from localhost (p200300f65f47db040f2ec809c82cfba7.dip0.t-ipconnect.de. [2003:f6:5f47:db04:f2e:c809:c82c:fba7]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-45eaa7dab28sm2160499f8f.12.2026.05.21.03.46.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 May 2026 03:46:54 -0700 (PDT) From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig=20=28The=20Capable=20Hub=29?= To: Arnd Bergmann , Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org Subject: [PATCH v1 2/2] misc: pch_phub: Introduce an enum for device indentification Date: Thu, 21 May 2026 12:46:36 +0200 Message-ID: <62223b743982616b1085c03f67ff88a2412d3da1.1779360001.git.u.kleine-koenig@baylibre.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=3705; i=u.kleine-koenig@baylibre.com; h=from:subject:message-id; bh=x8ti7oZfW/QnelpJ698IS10leyZ4WpUCpJwO5tzf0xQ=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBqDuKRlAe43c5Exxr67vDiGCNsFvesF6by3sCUD u/hP9irPkGJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCag7ikQAKCRCPgPtYfRL+ TmEUB/sGeyj+1y1DF+j7dju3cpF2CNINB95f8Piihdr7o7HEHKlGUgdk5gPx/nQBuW+CLIOc9OY RxgZsdT1Xn2/xBKa1/yWHGNUB+iM7f7HDAb1/tarmJdrVBi9CV1z6B1q99TeXFeNaNy8jMfKBFy PTD2xtqihg/4P0vsJQ8h2reTPvWGPTVg/eD2EQ6imQluw7c+CRLRQ1PYHcJZUuRw733meYdye0Q 1VQUxlWDccAq8CFse9//UaqgXfX0/MbDmWihCVMGre6KcpX6urzBU7Jr6P5j8TuW3pIddwYY54N zYzq1iax6z0svrSdePEIDhN121/a2FqtfLJiV6cvxKbHW1iv X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable Instead of using magic constants give them names that make the code more idiomatic. While touching the pci_device_id array, use named initializers to assign .driver_data. Signed-off-by: Uwe Kleine-K=C3=B6nig (The Capable Hub) --- drivers/misc/pch_phub.c | 28 ++++++++++++++++++---------- 1 file changed, 18 insertions(+), 10 deletions(-) diff --git a/drivers/misc/pch_phub.c b/drivers/misc/pch_phub.c index 539912e825eb..19c4fa017f24 100644 --- a/drivers/misc/pch_phub.c +++ b/drivers/misc/pch_phub.c @@ -537,6 +537,14 @@ static const struct bin_attribute pch_bin_attr =3D { .write =3D pch_phub_bin_write, }; =20 +enum { + PCH_EG20T, + PCH_ML7213, + PCH_ML7223M, + PCH_ML7223N, + PCH_ML7831, +}; + static int pch_phub_probe(struct pci_dev *pdev, const struct pci_device_id *id) { @@ -579,7 +587,7 @@ static int pch_phub_probe(struct pci_dev *pdev, =20 chip->pdev =3D pdev; /* Save pci device struct */ =20 - if (id->driver_data =3D=3D 1) { /* EG20T PCH */ + if (id->driver_data =3D=3D PCH_EG20T) { /* EG20T PCH */ const char *board_name; unsigned int prefetch =3D 0x000affaa; =20 @@ -627,7 +635,7 @@ static int pch_phub_probe(struct pci_dev *pdev, CLKCFG_UART_MASK); } } - } else if (id->driver_data =3D=3D 2) { /* ML7213 IOH */ + } else if (id->driver_data =3D=3D PCH_ML7213) { /* ML7213 IOH */ ret =3D sysfs_create_bin_file(&pdev->dev.kobj, &pch_bin_attr); if (ret) goto err_sysfs_create; @@ -640,7 +648,7 @@ static int pch_phub_probe(struct pci_dev *pdev, iowrite32(0x000affa0, chip->pch_phub_base_address + 0x14); chip->pch_opt_rom_start_address =3D\ PCH_PHUB_ROM_START_ADDR_ML7213; - } else if (id->driver_data =3D=3D 3) { /* ML7223 IOH Bus-m*/ + } else if (id->driver_data =3D=3D PCH_ML7223M) { /* ML7223 IOH Bus-m*/ /* set the prefech value * Device8(GbE) */ @@ -650,7 +658,7 @@ static int pch_phub_probe(struct pci_dev *pdev, chip->pch_opt_rom_start_address =3D\ PCH_PHUB_ROM_START_ADDR_ML7223; chip->pch_mac_start_address =3D PCH_PHUB_MAC_START_ADDR_ML7223; - } else if (id->driver_data =3D=3D 4) { /* ML7223 IOH Bus-n*/ + } else if (id->driver_data =3D=3D PCH_ML7223N) { /* ML7223 IOH Bus-n*/ ret =3D sysfs_create_file(&pdev->dev.kobj, &dev_attr_pch_mac.attr); if (ret) @@ -667,7 +675,7 @@ static int pch_phub_probe(struct pci_dev *pdev, chip->pch_opt_rom_start_address =3D\ PCH_PHUB_ROM_START_ADDR_ML7223; chip->pch_mac_start_address =3D PCH_PHUB_MAC_START_ADDR_ML7223; - } else if (id->driver_data =3D=3D 5) { /* ML7831 */ + } else if (id->driver_data =3D=3D PCH_ML7831) { /* ML7831 */ ret =3D sysfs_create_file(&pdev->dev.kobj, &dev_attr_pch_mac.attr); if (ret) @@ -731,11 +739,11 @@ static int __maybe_unused pch_phub_resume(struct devi= ce *dev_d) } =20 static const struct pci_device_id pch_phub_pcidev_id[] =3D { - { PCI_VDEVICE(INTEL, PCI_DEVICE_ID_PCH1_PHUB), 1, }, - { PCI_VDEVICE(ROHM, PCI_DEVICE_ID_ROHM_ML7213_PHUB), 2, }, - { PCI_VDEVICE(ROHM, PCI_DEVICE_ID_ROHM_ML7223_mPHUB), 3, }, - { PCI_VDEVICE(ROHM, PCI_DEVICE_ID_ROHM_ML7223_nPHUB), 4, }, - { PCI_VDEVICE(ROHM, PCI_DEVICE_ID_ROHM_ML7831_PHUB), 5, }, + { PCI_VDEVICE(INTEL, PCI_DEVICE_ID_PCH1_PHUB), .driver_data =3D PC= H_EG20T }, + { PCI_VDEVICE(ROHM, PCI_DEVICE_ID_ROHM_ML7213_PHUB), .driver_data =3D PC= H_ML7213 }, + { PCI_VDEVICE(ROHM, PCI_DEVICE_ID_ROHM_ML7223_mPHUB), .driver_data =3D PC= H_ML7223M }, + { PCI_VDEVICE(ROHM, PCI_DEVICE_ID_ROHM_ML7223_nPHUB), .driver_data =3D PC= H_ML7223N }, + { PCI_VDEVICE(ROHM, PCI_DEVICE_ID_ROHM_ML7831_PHUB), .driver_data =3D PC= H_ML7831 }, { } }; MODULE_DEVICE_TABLE(pci, pch_phub_pcidev_id); --=20 2.47.3