Hello,

my objective is to convert all pci_device_id assignments to use named
initializer for a further cleanup. See
https://lore.kernel.org/all/20260507074102.2654314-2-u.kleine-koenig@baylibre.com/
for details about that.

While working on the pch_phub driver, I found a few more opportunities
for improvement and the conversion to named initializers is just a side
effect of the 2nd patch.

If a "= 1" was added to the definition of PCH_EG20T in patch #2, there would be
no differences in the generated code. Without that there is a shift in the
magic constants that doesn't change the semantics however.

Best regards
Uwe

Uwe Kleine-König (The Capable Hub) (2):
  misc: pch_phub: Drop two unused functions
  misc: pch_phub: Introduce an enum for device indentification

 drivers/misc/pch_phub.c | 151 +++++-----------------------------------
 1 file changed, 18 insertions(+), 133 deletions(-)


base-commit: 254f49634ee16a731174d2ae34bc50bd5f45e731
-- 
2.47.3

Hello Greg,

On Thu, May 21, 2026 at 12:46:34PM +0200, Uwe Kleine-König (The Capable Hub) wrote:
> my objective is to convert all pci_device_id assignments to use named
> initializer for a further cleanup. See
> https://lore.kernel.org/all/20260507074102.2654314-2-u.kleine-koenig@baylibre.com/
> for details about that.
> 
> While working on the pch_phub driver, I found a few more opportunities
> for improvement and the conversion to named initializers is just a side
> effect of the 2nd patch.
> 
> If a "= 1" was added to the definition of PCH_EG20T in patch #2, there would be
> no differences in the generated code. Without that there is a shift in the
> magic constants that doesn't change the semantics however.

Sashiko[1] found a few issues in this series that I'd like to address. Can
you please drop this series from your queue?

Best regards
Uwe

[1] https://sashiko.dev/#/patchset/cover.1779360001.git.u.kleine-koenig%40baylibre.com