From nobody Fri Apr 3 17:31:55 2026 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 55F41158535 for ; Mon, 23 Mar 2026 19:01:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774292478; cv=none; b=Opyg1tQKP5qoKLhaLw4bXRp92S9DcgmXhVbFeElsu/1EMUVhhH0t6bC7fONbU96P83kEKBVfMWheOO9fSYYj9vLiyYB5Ck7hF6xmIIMUBUszSNQFEwRRTrKraA0JgwFMDxxaSRwcGO9csaXHaieMvygb1irQQVKl/zE+3njNCRU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774292478; c=relaxed/simple; bh=6Ah0GZtHWlJhWUz0Crf58vbcXv+9COZbbw5o4RQlGLU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=LgpvuvJatqhsQtOh4xIRZD0srJh8pnTCZr91QaxHUHnYX4PJRafKk2m29k8Ijszp9nh5QSu4g4zVBVXgivMSstkz0vKBpIufvePe+kEsbF7o/5b0ysDiBHD/G33LF1cWx/CSdwiCizaoLraaFWIzPT/SuJgHdHyaPg9GPatw7Os= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=pQvrTfQo; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="pQvrTfQo" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-4852e9ca034so29898955e9.2 for ; Mon, 23 Mar 2026 12:01:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1774292474; x=1774897274; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=dY0rDhZYHoT7nVKeHkYiyNCYW9aaueyrXJ7hodb5Gwo=; b=pQvrTfQoDiEqCCfLKfBdnARANq+47Xlx4PQ+DdIvXgz6/nugbiYqaJyuMuoEWN49bo g1IH21IsjBUrLmE3FoyC1XX/MUMGYZFkKUpkrWLEdBnh+KsAnVHx8gClFxok8B0qAtwh KxrTim92YmrzL21jlC/JXyfTw4cMGa4gBETQROt05pmkUOPKFo0Pc30yREiSVHTgOXPR lgtgbxgfcLp7rs+Z9Famwo3HWEkJBIGyK33oYQcSZgb85Zpjg1/Qt4QeJ9Yo3Nbsxjaz 9sMYs1m+KCqHwWnZccoJQQaXHsLc+jqncMJsiqt85+daZR6RI9XdLgkyNKUZzhOttjzn rMQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774292474; x=1774897274; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dY0rDhZYHoT7nVKeHkYiyNCYW9aaueyrXJ7hodb5Gwo=; b=so0owjPivPfltiK0MnpijknZioqZU4fMb8Uatbq4yLeRsAPFPhy5FLX8U/hDxKgVtf SpMmwIM0pzfvK3MlfiQWXTMwyUj56RmBOdy6bKP4K6kuf3UgMzUzAXCZfB+529CFwL0w 6PNFQ9uZHdMxB1e5uZH3dRbS5ABhFazce3uolSIkeLIBRIkkYMsG9dQVEwbOnyE4K5tj a/GBisi8sBDye+Cnwi1ifIFtoXQzi3eDjqzkGiiYnJnFTnWhxn1985lYUVZkoaYlsXHo YAR+pCRKfhmiv8MGdCUXnxAKtCr+QKuUoNdTdZ1Gi85WMZld/tO7D+eJB9qxMZcFtLmy AeUg== X-Forwarded-Encrypted: i=1; AJvYcCXziFJZt4pGzHZyWSX06KEltpchhrtQ6V652mbOXqUcz+Nb270trIeBjtHgdtyzThSTFYoEfNiplAsRO5Q=@vger.kernel.org X-Gm-Message-State: AOJu0Yw8rQJbRHDgDun25BOLQTv7B5l2imUYkV2WnVr/30g8S5xQRZg7 3gPuH4+yz8tNXsA73kJAikE+KfDcHVViUQQ+qfBnGyLVC/1zSySsCUBhY20B0o96lUQ= X-Gm-Gg: ATEYQzyIe50HHeqUm8p+nUWx8qJLMa0W3RPP/S2HeC08GSE2TuHEfc+5PJNfLXbua/0 DCcLr4RJItABuXgbKXuPjmDTgHaCoGSrwUyoHxGuXuIGDF62X73HirB6c0jm6HtkjUvyr5iKjI6 zwTRRoC9qoxab2zr0SNAcgA4WYul9Yb5XOe3egF+lzjJl0p7NNiad9sTAksVI+glaMUttWbds/N c3X7pESMVaKC93c6iwdloqfGk0msxp0zDcdalMUXImbfFgQpyvyJ4G8ZURpgBAVUgIeG+7AHMhv CXyl9B33wnp3A+xXz/YRHuC7l9/DOApCHEKD4THVUrhsG5HKGrWS89uEugWKctFWOdgVTPz//6L FzVjtRo8Faqnjv26tIq21qYLDRKWVy3AjPtSr3SxbClgRoWGBoEjcW1FnvPtJw7qN4F6J2T9W5x MQ1veVxuCWfumJwOL9lQ+srA9iqxUsngmBxSgVE98= X-Received: by 2002:a05:600c:3554:b0:486:fc4a:2951 with SMTP id 5b1f17b1804b1-486ff01d7f3mr173323405e9.28.1774292473972; Mon, 23 Mar 2026 12:01:13 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4870f83c84fsm999765e9.10.2026.03.23.12.01.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Mar 2026 12:01:13 -0700 (PDT) Date: Mon, 23 Mar 2026 22:01:10 +0300 From: Dan Carpenter To: Linus Walleij , AKASHI Takahiro Cc: Bartosz Golaszewski , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Shevchenko , Linus Walleij , Bartosz Golaszewski , arm-scmi@vger.kernel.org, Vincent Guittot , Khaled Ali Ahmed , Michal Simek Subject: [PATCH v6 1/7] pinctrl: introduce pinctrl_gpio_get_config() Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: AKASHI Takahiro This is a counterpart of pinctrl_gpio_set_config(), which will be used to implement the ->get() interface in a GPIO driver for SCMI. This also requires that we create a stub so pin_config_get_for_pin() can build when CONFIG_PINCONF is disabled. Signed-off-by: AKASHI Takahiro Signed-off-by: Dan Carpenter Reviewed-by: Linus Walleij Reviewed-by: Andy Shevchenko --- v6: Fix build breakage with !CONFIG_PINCONF v5: No change v4: Fix kernel-doc (Andy). Add r-b tags v3: Forward port drivers/pinctrl/core.c | 31 +++++++++++++++++++++++++++++++ drivers/pinctrl/pinconf.h | 6 ++++++ include/linux/pinctrl/consumer.h | 9 +++++++++ 3 files changed, 46 insertions(+) diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/core.c index 2edc9bdad183..c471f3fbd035 100644 --- a/drivers/pinctrl/core.c +++ b/drivers/pinctrl/core.c @@ -30,6 +30,7 @@ #include #include #include +#include #include =20 #include "core.h" @@ -938,6 +939,36 @@ int pinctrl_gpio_set_config(struct gpio_chip *gc, unsi= gned int offset, } EXPORT_SYMBOL_GPL(pinctrl_gpio_set_config); =20 +/** + * pinctrl_gpio_get_config() - Get the config for a given GPIO pin + * @gc: GPIO chip structure from the GPIO subsystem + * @offset: hardware offset of the GPIO relative to the controller + * @config: the configuration to query. On success it holds the result + * Return: 0 on success, negative errno otherwise + */ +int pinctrl_gpio_get_config(struct gpio_chip *gc, unsigned int offset, uns= igned long *config) +{ + struct pinctrl_gpio_range *range; + struct pinctrl_dev *pctldev; + int ret, pin; + + ret =3D pinctrl_get_device_gpio_range(gc, offset, &pctldev, &range); + if (ret) + return ret; + + mutex_lock(&pctldev->mutex); + pin =3D gpio_to_pin(range, gc, offset); + ret =3D pin_config_get_for_pin(pctldev, pin, config); + mutex_unlock(&pctldev->mutex); + + if (ret) + return ret; + + *config =3D pinconf_to_config_argument(*config); + return 0; +} +EXPORT_SYMBOL_GPL(pinctrl_gpio_get_config); + static struct pinctrl_state *find_state(struct pinctrl *p, const char *name) { diff --git a/drivers/pinctrl/pinconf.h b/drivers/pinctrl/pinconf.h index 2880adef476e..659a781e2091 100644 --- a/drivers/pinctrl/pinconf.h +++ b/drivers/pinctrl/pinconf.h @@ -74,6 +74,12 @@ static inline int pinconf_set_config(struct pinctrl_dev = *pctldev, unsigned int p return -ENOTSUPP; } =20 +static inline int pin_config_get_for_pin(struct pinctrl_dev *pctldev, unsi= gned int pin, + unsigned long *config) +{ + return -ENOTSUPP; +} + #endif =20 #if defined(CONFIG_PINCONF) && defined(CONFIG_DEBUG_FS) diff --git a/include/linux/pinctrl/consumer.h b/include/linux/pinctrl/consu= mer.h index 63ce16191eb9..11b8f0b8da0c 100644 --- a/include/linux/pinctrl/consumer.h +++ b/include/linux/pinctrl/consumer.h @@ -35,6 +35,8 @@ int pinctrl_gpio_direction_output(struct gpio_chip *gc, unsigned int offset); int pinctrl_gpio_set_config(struct gpio_chip *gc, unsigned int offset, unsigned long config); +int pinctrl_gpio_get_config(struct gpio_chip *gc, unsigned int offset, + unsigned long *config); =20 struct pinctrl * __must_check pinctrl_get(struct device *dev); void pinctrl_put(struct pinctrl *p); @@ -101,6 +103,13 @@ pinctrl_gpio_direction_output(struct gpio_chip *gc, un= signed int offset) return 0; } =20 +static inline int +pinctrl_gpio_get_config(struct gpio_chip *gc, unsigned int offset, + unsigned long *config) +{ + return 0; +} + static inline int pinctrl_gpio_set_config(struct gpio_chip *gc, unsigned int offset, unsigned long config) --=20 2.53.0 From nobody Fri Apr 3 17:31:55 2026 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E8CA314A83 for ; Mon, 23 Mar 2026 19:01:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774292483; cv=none; b=dmoy6LbyE5acfGHMlgmBQ0YwLtJnnXRq6RSGz/nmieioXovHFdX861+iGLd3Vb3m/qZsvuDCJiJCRwTJbAADQAiUlYuUoKPf4f23MxcsWPVVpArt5jrao1GTKdbHUaJD9DWnd5ki2oxK3tYLv8DvgDyQamr4NB2+zXGnV4uKXw8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774292483; c=relaxed/simple; bh=9ndQcMnASHDbDGInbvhNloK+6vYvAxVufHQrRaTqfBY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=MecNSNoIT8ty4Ozj65JeTsnK5Gr8q7SCJwnYxFMaHjbc8YhatewXT2dpKJeVOAPv6eNWyovEOLhFbmE2g9/ohBfqujT4aZIqGBtYFfRshOO0Yd4uOsXNH2oRr9/ehoioLu9RJAGELgDDbhG1MNt8+vuyyAoDBDG0aG/IEfaG4GQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=lfaTK2Lk; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="lfaTK2Lk" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-4853e1ce427so32827555e9.3 for ; Mon, 23 Mar 2026 12:01:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1774292480; x=1774897280; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=cYNDUizmJ/rKIkz2DY5qa0t62hb9uVCR9S4PHSBe3sY=; b=lfaTK2LkXzYhLRsZbF2zfeQEHweoJBNUrcrF6XswHplYxJvc1x1kegGN3P/7U7AW3K NGlVFGjTaFHUReqAv4s6PSYKqx2WVAR0cM1Jc/1BZa1qM9OLFbuXRZMYF+4m74QvMX36 0z3hn4aPY+2C537MufwQg4eSJy8h+3gDeSPcl2kPGgkgqVAODD9htDBNTbf3Fr884I+N ttC08fyUjUM/Gm0/8bqOSauVUohP6ATr3Phw8Wwgq595I1Sgbak57LlbQMA0INgcDtzI Bbl0xaCbrp7amKEMSoPv6gaf+9dSxKQ7F/zQ6QmUS80pJnnCNTwgh4icvRbAErZU/BNz s6hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774292480; x=1774897280; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cYNDUizmJ/rKIkz2DY5qa0t62hb9uVCR9S4PHSBe3sY=; b=GWcEiRxzS7LNSyE9+tLbv+PU8NIbg+l5APrUCRDyt0XLxpmgpsIH7MRLRYP9vZPwF9 ecVFvxybhA6vSgfG1hkIGX7BAP3P/EE5aCB2QS8EjrWSkafirMsWePOLxolQ9VgHNeJV HdSi+EXYBsQChdg6aKefnP4LHwPxohOceXvRflIIPyGQHcfrKzrRswdawS+GgFwE/Q15 C9K/64k2LepI5rNAuTP7KKH7N3FxgURFpO5APZIevAt3y04FSKYwOOlRUy5Lo6VDQ1Kl /htbapnPTS/z1JO6qYlgX/j2ELyl7K3wt2OgH/BRbDq5qgullz1whxbt+K1aibkYZzgJ cIuA== X-Forwarded-Encrypted: i=1; AJvYcCXJ1QGaMCu0JUc123NU6g9uMZpxkDGALTcI+xJPyqIzDE+p3D+lMDjQzWS3bDA8ah1S5JoyurOiYzQXT48=@vger.kernel.org X-Gm-Message-State: AOJu0YwsB5uGeInZ9Hz5KgaIOOT+giwVxl2va/ibBymMFC8W6RDdOP0K Xl8Fak5dcL1cj7kg3hNXTDFRnl27L9zE89Pa4op8I08RDQyWE1Pbg9oxDgrw9xnXRG4= X-Gm-Gg: ATEYQzyk3zmb0Hh72uu9LjflAOCRgEsPB5iVHPOK6JqYaxu22Ef5KAFwN4RFY89mHx1 +W11VsCOoQDAjjxfHAzhWCMBml5PfUrqMGHsIR79TQ7j/ZtAUG9UzPBSUDR20iIcDgGjvVruE71 bzgp00HBz6GglrY5jpNbIU/me4pHFUpKcZ7odDGIOUYSVxhjaz4s/o2VOmqJG9enJBaqimZSbRy eQLJmtSVFg5d6Fg8e4uPno9og6o/kooB+hKzavvzU2ZIHDm9lDd3fZSszK4030mfwqf126Lyo4i VSV80lrvbM7XuxGFWBftjiF0zkHTTVxtEy2hZNYHli5oIQWWixz3b8RmWTQ/LwC8Nsetem4EKda k0QBbyit+SQw6C51LTPrBbPaQsn2JZehqrDSxoX7jW/dwcSmynH5JaqH5vT3lXNNxBS+CK15fDj ZCDD8Foi+BXTsW95fAeVC+M4cJOSuZ X-Received: by 2002:a05:6000:4382:b0:43b:5192:894b with SMTP id ffacd0b85a97d-43b642426afmr20898486f8f.23.1774292479509; Mon, 23 Mar 2026 12:01:19 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b644ae16fsm32522970f8f.8.2026.03.23.12.01.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Mar 2026 12:01:19 -0700 (PDT) Date: Mon, 23 Mar 2026 22:01:15 +0300 From: Dan Carpenter To: Sudeep Holla , AKASHI Takahiro Cc: Cristian Marussi , Linus Walleij , arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Shevchenko , Bartosz Golaszewski , Vincent Guittot , Khaled Ali Ahmed , Michal Simek Subject: [PATCH v6 2/7] pinctrl: scmi: Add SCMI_PIN_INPUT_VALUE Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The PIN_CONFIG_LEVEL parameter represents the value of the pin, whether reading or writing to the pin. In SCMI, the parameter is represented by two different values SCMI_PIN_OUTPUT_VALUE for writing to a pin and SCMI_PIN_INPUT_VALUE for reading. The current code translates PIN_CONFIG_LEVEL as SCMI_PIN_OUTPUT_VALUE (writing). Add a function to translate it to either INPUT or OUTPUT depending on whether it is called from a _get or _set() operation. Signed-off-by: Dan Carpenter Reviewed-by: Linus Walleij Acked-by: Sudeep Holla --- v5: no change v4: add r-b tags v3: new patch drivers/pinctrl/pinctrl-scmi.c | 33 ++++++++++++++++++++++++++------- 1 file changed, 26 insertions(+), 7 deletions(-) diff --git a/drivers/pinctrl/pinctrl-scmi.c b/drivers/pinctrl/pinctrl-scmi.c index f4f296e07be5..5d347e6b2e4c 100644 --- a/drivers/pinctrl/pinctrl-scmi.c +++ b/drivers/pinctrl/pinctrl-scmi.c @@ -251,9 +251,6 @@ static int pinctrl_scmi_map_pinconf_type(enum pin_confi= g_param param, case PIN_CONFIG_MODE_LOW_POWER: *type =3D SCMI_PIN_LOW_POWER_MODE; break; - case PIN_CONFIG_LEVEL: - *type =3D SCMI_PIN_OUTPUT_VALUE; - break; case PIN_CONFIG_OUTPUT_ENABLE: *type =3D SCMI_PIN_OUTPUT_MODE; break; @@ -276,6 +273,28 @@ static int pinctrl_scmi_map_pinconf_type(enum pin_conf= ig_param param, return 0; } =20 +static int pinctrl_scmi_map_pinconf_type_get(enum pin_config_param param, + enum scmi_pinctrl_conf_type *type) +{ + if (param =3D=3D PIN_CONFIG_LEVEL) { + *type =3D SCMI_PIN_INPUT_VALUE; + return 0; + } + + return pinctrl_scmi_map_pinconf_type(param, type); +} + +static int pinctrl_scmi_map_pinconf_type_set(enum pin_config_param param, + enum scmi_pinctrl_conf_type *type) +{ + if (param =3D=3D PIN_CONFIG_LEVEL) { + *type =3D SCMI_PIN_OUTPUT_VALUE; + return 0; + } + + return pinctrl_scmi_map_pinconf_type(param, type); +} + static int pinctrl_scmi_pinconf_get(struct pinctrl_dev *pctldev, unsigned int pin, unsigned long *config) { @@ -290,7 +309,7 @@ static int pinctrl_scmi_pinconf_get(struct pinctrl_dev = *pctldev, =20 config_type =3D pinconf_to_config_param(*config); =20 - ret =3D pinctrl_scmi_map_pinconf_type(config_type, &type); + ret =3D pinctrl_scmi_map_pinconf_type_get(config_type, &type); if (ret) return ret; =20 @@ -363,7 +382,7 @@ static int pinctrl_scmi_pinconf_set(struct pinctrl_dev = *pctldev, =20 for (i =3D 0; i < num_configs; i++) { param =3D pinconf_to_config_param(configs[i]); - ret =3D pinctrl_scmi_map_pinconf_type(param, &p_config_type[i]); + ret =3D pinctrl_scmi_map_pinconf_type_set(param, &p_config_type[i]); if (ret) { dev_err(pmx->dev, "Error map pinconf_type %d\n", ret); goto free_config; @@ -405,7 +424,7 @@ static int pinctrl_scmi_pinconf_group_set(struct pinctr= l_dev *pctldev, =20 for (i =3D 0; i < num_configs; i++) { param =3D pinconf_to_config_param(configs[i]); - ret =3D pinctrl_scmi_map_pinconf_type(param, &p_config_type[i]); + ret =3D pinctrl_scmi_map_pinconf_type_set(param, &p_config_type[i]); if (ret) { dev_err(pmx->dev, "Error map pinconf_type %d\n", ret); goto free_config; @@ -440,7 +459,7 @@ static int pinctrl_scmi_pinconf_group_get(struct pinctr= l_dev *pctldev, return -EINVAL; =20 config_type =3D pinconf_to_config_param(*config); - ret =3D pinctrl_scmi_map_pinconf_type(config_type, &type); + ret =3D pinctrl_scmi_map_pinconf_type_get(config_type, &type); if (ret) { dev_err(pmx->dev, "Error map pinconf_type %d\n", ret); return ret; --=20 2.53.0 From nobody Fri Apr 3 17:31:55 2026 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4A2C0175A85 for ; Mon, 23 Mar 2026 19:01:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774292498; cv=none; b=Wimius841LgaHuAJmurBaansx4kofRmwkP13SJhPqRNebAQjJk/+pNOdtXHHFDGXShf2ttJc2AYYIotrtH0WZ+Xbq3qs64e1uEhcZXFpEE3ASZWw+HWPSukG/IlPtQr3J0/MFdM2/p8aosIYU5mn054lDheGsZ2j8VP+9QhhCr8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774292498; c=relaxed/simple; bh=jCF+eLwlD7MQ3lst0osm4ZMLlYmOygIY+kAEfdT6yWo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=t3CY4vLEmKMIayxop2ZmkvtuqdmS3EAVWYf2SvUoMvQzP/lt1IGK9BTb3BybVIIIGaIM5xJdyLZ1grvF5U3lM57bTfOIrrUTZKuQis1Njd3cVcQj+LEogDfZ1u1Dl9CRRMYLCATqx+3x8AnmI62w+JjxL1mfF330Jz1Gz7gwkrM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=QrwhrYv/; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="QrwhrYv/" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-48700b1ba53so29781965e9.1 for ; Mon, 23 Mar 2026 12:01:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1774292496; x=1774897296; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=8mX/GcwoKo6bWMEhcm0gaJZhmtfjF5BKuCj21CKeODo=; b=QrwhrYv/AiZUW4cgVLrFKBOVuIr8yilP2bWIRJCZdfGgG+MqU81TEbYDEH4xkoKt8q wgrBlO02TSTv1WTiuHghqBGWgh3iU6GrLVNMp92rXN9XXet5PWcH5PpbC+g5TSG5b7il aPHmkfB37jRoUGzNgMggH4R1Sv5a+jYwa5gXb0XbDmHtcT6Nyswah2CtNBzxSMajoxYQ uoNsKxO+HBnMEZB9TbgGl3RzqhhUc/Jy1JqeTZ78N3ZGylz8ylq4YUVyKagiwj1Eey1O 2d8BFJxo/xnvUjD0pfyNNr6JlcFdf3iTCfpV92i+RncgfTJJdb7Zn0bDp6pd93BciefM MTPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774292496; x=1774897296; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8mX/GcwoKo6bWMEhcm0gaJZhmtfjF5BKuCj21CKeODo=; b=qvcZawrYlv4omweCDEEwULFN4DqG8R/GkScZVuANPMDpDHk3n4mbIM/nL2Kk44e/HL 7ZRyfiiaKhkRe6Ee9TSK9RJULtUrSM3oe+tAa1Bk/wBMHHTXmRLdqYdVeLBzDSlAEszl 0RM4GSyCBM3yxJLcqlqjWSFv5Uwhe5pIr6CPs4kJqvz/YvRBgcU+uwGGtmvghzOfoFG9 7KZEeXyOjTJzArkHAtzsOTwNACjpA6jQX5QTsMf1eau7rGIH1SOXu7DS/W8JPNdymt+X JnZF2bvaBiO3pDnroiHdf6x9yRhC9vtevVodqsaoFT/pqHJNmUrMKckqLg1Z3QmZIS+s 1mmA== X-Forwarded-Encrypted: i=1; AJvYcCVtdmOK6egpBrkz3jbTMOwScVzXtn2TBhua1/1Gh+z+LTXKB8SFRbs/pJ4tZdVmVwxIe+rdG2SkLmZ+lV8=@vger.kernel.org X-Gm-Message-State: AOJu0YzdV5ddnugS2cznCOkYL0sbJSU0/HlSpfaw7vl3DU77AIQIbd7Z p/aViTjkWsQRgTolVXkvCxgcKWPKK5pkjU7UOGmvxhbExMCR45k6z4pmPsCzYEfxh/o= X-Gm-Gg: ATEYQzwpIRW36cp0Q+s4DT5cCHizz4Bn9UJLO16C8cAUfC3eu4ON6CFORy0hwvqLzxO acft5SXvfh/YBX22kP2jSjudAa3Fzrn/ka3Ck8sGuuJ/bcs7EsomnDzoLIa1ai4LEz+YhpzGCI1 +zlyk7TJz97KW8bXJR2YmjnXUYAvL5Xhy0gNhN+Kei1kIl7vdYM4jjlEK3kj0N+C0fwxZQoIjy1 HgwR/JaL+1+sywaa+wrks2Qw1fQ6pKEgMh9xUdk2r10PKripxQlEbrIVICb+eBaid2i9e/XvJCT mG7Rr+pto40LOIKpBoDftqpFVYxnaeUVZe+4r6YH8XAXO7k8KW8L7GFVdXhzG3ipdr5blbN3Djl jFWDgN3iRRDyu0LE2ttuJEPHxy+UUiOEWlVIzFhFyOrMdaV1RPb6w+MzqEtkJIzh861aOGtR9p0 lDEBx0x+mrixrUqUXn65OWvzRtnDyv X-Received: by 2002:a05:600c:3514:b0:485:3d3e:1675 with SMTP id 5b1f17b1804b1-486fedb5624mr182256275e9.8.1774292495555; Mon, 23 Mar 2026 12:01:35 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4870f80b6a3sm1441505e9.21.2026.03.23.12.01.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Mar 2026 12:01:35 -0700 (PDT) Date: Mon, 23 Mar 2026 22:01:32 +0300 From: Dan Carpenter To: Sudeep Holla , AKASHI Takahiro Cc: Cristian Marussi , Linus Walleij , arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Shevchenko , Bartosz Golaszewski , Vincent Guittot , Khaled Ali Ahmed , Michal Simek , Peng Fan Subject: [PATCH v6 3/7] pinctrl: scmi: Delete PIN_CONFIG_OUTPUT_IMPEDANCE_OHMS support Message-ID: <48bee15dbf615c0c9a76ee4313bed7c06a07f143.1774283146.git.dan.carpenter@linaro.org> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The argument for PIN_CONFIG_OUTPUT_IMPEDANCE_OHMS is supposed to be expressed in terms of ohms. But the pinctrl-scmi driver was implementing it the same as PIN_CONFIG_OUTPUT and writing either a zero or one to the pin. The SCMI protocol doesn't have an support configuration type so just delete this code instead of replacing it. Cc: Peng Fan Signed-off-by: Dan Carpenter Reviewed-by: Linus Walleij --- v5: fix subystem prefix v4: add r-b tags v3: new patch drivers/pinctrl/pinctrl-scmi.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/pinctrl/pinctrl-scmi.c b/drivers/pinctrl/pinctrl-scmi.c index 5d347e6b2e4c..de8c113bc61d 100644 --- a/drivers/pinctrl/pinctrl-scmi.c +++ b/drivers/pinctrl/pinctrl-scmi.c @@ -254,9 +254,6 @@ static int pinctrl_scmi_map_pinconf_type(enum pin_confi= g_param param, case PIN_CONFIG_OUTPUT_ENABLE: *type =3D SCMI_PIN_OUTPUT_MODE; break; - case PIN_CONFIG_OUTPUT_IMPEDANCE_OHMS: - *type =3D SCMI_PIN_OUTPUT_VALUE; - break; case PIN_CONFIG_POWER_SOURCE: *type =3D SCMI_PIN_POWER_SOURCE; break; --=20 2.53.0 From nobody Fri Apr 3 17:31:55 2026 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DE9943148D9 for ; Mon, 23 Mar 2026 19:01:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774292489; cv=none; b=vAHlVOhKPDUZulu063fMjgAgaw8YTLOGqA41BDlsmdj4QJ4aOXaU3FtdF3M0lCOQ691sIYfH25YuzunTKDo3B+ywLyWyLSs875Cj+SkUTxVtYfPuymBlk1QyHGieeHatKFSyOKSoYRGZypPYCT2cpnsV3ZKU+r4fHx0m6oYLEik= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774292489; c=relaxed/simple; bh=kIkQ3M6MU6ffdc+UMu8eQEns2WLf8THRIkoxJZ1wwWc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=rqhyoyvSD+rnccQVlNogEPqkJPTWi9ark6H7c+Wvv1b4dkdvA+Bha2LW1dXz1SDfpcHed1fdmR56QYGzlJYNgTzLnNKjcoXlyPV0A91ukcRE4wSLTISqUdfWSqWp8ihnZ8DWswDgFzX5acknfIzm9ruqe0Tg4gXoWk3Nn7YTLbc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=RdWDjuPG; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="RdWDjuPG" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-43b3f91a7abso342310f8f.1 for ; Mon, 23 Mar 2026 12:01:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1774292486; x=1774897286; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=MHuRsDVkQUUGFXQRrZ4RkpmncGpGmYSyMNCrKIAVWFs=; b=RdWDjuPGYWu7xTAdZ0Di3v8bO9qpTJkejEU/ttzbhIxCjB5Bg9jmBZ0Y9UO6kAn5M8 fzsApKjiehVe8UceOL/7jvfECqlG9NajTDd+vE7NlOysqbIRsUb6NPP6dGDWuZPjdYI0 9Iz+nXnrv5BfRnqVzBZEvfmUKkrL3B7NntXegxeSnowYrqqagEHIi0ipJPCnrWDDYa3w c2f6g467G5BOy7P1TDb+t7TS6ZH5o/6CLPDr7CD+nzB2b6HofYnPkNTgQZe3bYErKLc3 0tGfGrPFpAotvJ24x+jJULrqJJqSfJz5cgqn58RK3+um1jwrMqJHR4GLhQ/PJfjD5txg JlDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774292486; x=1774897286; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MHuRsDVkQUUGFXQRrZ4RkpmncGpGmYSyMNCrKIAVWFs=; b=cTzyFkZPM5c2AO8q3Q5dEBCv4PgaksCZQvN9nf/dd/W+UNcbBk1ned58KFV0vs4mzW zIAQSc2CHQDfTNTE91AyFYT8KYYItumBMZ9TiNBWzit5Daj8uyGtWfmt/MGoj4Pdp+GF itBYqGKHYJvtGg8lpQA9REp1L4I03sGZA7A+YoGbB5dkXrAbqkql14EW5C1yRxSAENyT RbynLA315ZmbPYSbO7cHcWUObSh320SWY/KyMad4tVKWLEF/n+VDIJjEjxrbF9taj/A6 8aFeejKj40Aeqw/eouZKd1IaHtIQFReb6Jr94eE/etkRRb3IZxxiJVOpErF85GUKR6yf pB4Q== X-Forwarded-Encrypted: i=1; AJvYcCVTyUQlGf7Ewf3DzlksoLWSwTBV02o9qNXRg8EAeGDXIVDEybD0h2OhhI1Q/fu0dMk0lDQI7zWp+Pd1Epo=@vger.kernel.org X-Gm-Message-State: AOJu0Yy45J3x8C7K3dV41sIUsp4SPgXZMe6FrlGdYimAnT5J/DFRxj1I 1SIyexxvBYy+Nmnsi163gpIJXd4BgGGUaX05F8xiL8W2LS9qtoeVzgsPeWQCRv/Y/cQ= X-Gm-Gg: ATEYQzyCDGsqm39h+fUd7nVlM4ZJgH4Lxj57ksWY5w+7+lHCMlM9MZw6IbQaClW4CEs w1EDJWsmPZ4LzGGDMgG8ncZRqOljxQuGWyVCY3QZGL0tppLpW0jQDK63KLv5c95JfL+dqxodCI7 7DpsEDgcatUPrt19Qw/qdCwyvauzQ5+iKHGPwHXvwzLK3AlRAJ3DgHR1mXL+2+NahVhkMsGCHVP RBoV278guxf21Ts1II17IfBspnSnpraBuzl48KjHrTro/ltq+Byok+AaKfQyrsx9oj+42jsC5QI WgqVvigWrfmLGXCdpFIdu3ub22EwBf0BhCPlsBIP8CT6k5ht9X1rlyW0ZySW6l2zBJKL5AjM6Mm Ly7TbS3J7wmbHEXbkjcPua/pg7jzHluvSpzEWBlXck9ydrzPEEME5kQpzLZhMlNnRmf/x40K+js 94L95uEdv9a1hinFIXBBkgPlkJ02T4 X-Received: by 2002:a05:600c:5248:b0:485:3a27:a961 with SMTP id 5b1f17b1804b1-486feb5d845mr199608445e9.0.1774292486005; Mon, 23 Mar 2026 12:01:26 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b64714decsm28604894f8f.31.2026.03.23.12.01.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Mar 2026 12:01:25 -0700 (PDT) Date: Mon, 23 Mar 2026 22:01:22 +0300 From: Dan Carpenter To: Sudeep Holla , AKASHI Takahiro Cc: Cristian Marussi , Linus Walleij , arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Shevchenko , Bartosz Golaszewski , Vincent Guittot , Khaled Ali Ahmed , Michal Simek Subject: [PATCH v6 4/7] pinctrl: scmi: ignore PIN_CONFIG_PERSIST_STATE Message-ID: <77357ddd5c96622e4be77c0b209206d5a59c9b05.1774283146.git.dan.carpenter@linaro.org> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The PIN_CONFIG_PERSIST_STATE setting ensures that the pin state persists across a sleep or controller reset. The SCMI spec does not have an equivalent command to this so just ignore it. Signed-off-by: Dan Carpenter Reviewed-by: Linus Walleij --- v5: fix subsystem prefix v4: Add r-b tags v3: No change drivers/pinctrl/pinctrl-scmi.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/pinctrl/pinctrl-scmi.c b/drivers/pinctrl/pinctrl-scmi.c index de8c113bc61d..f22be6b7b82a 100644 --- a/drivers/pinctrl/pinctrl-scmi.c +++ b/drivers/pinctrl/pinctrl-scmi.c @@ -361,7 +361,7 @@ static int pinctrl_scmi_pinconf_set(struct pinctrl_dev = *pctldev, unsigned long *configs, unsigned int num_configs) { - int i, ret; + int i, cnt, ret; struct scmi_pinctrl *pmx =3D pinctrl_dev_get_drvdata(pctldev); enum scmi_pinctrl_conf_type config_type[SCMI_NUM_CONFIGS]; u32 config_value[SCMI_NUM_CONFIGS]; @@ -377,17 +377,21 @@ static int pinctrl_scmi_pinconf_set(struct pinctrl_de= v *pctldev, if (ret) return ret; =20 + cnt =3D 0; for (i =3D 0; i < num_configs; i++) { param =3D pinconf_to_config_param(configs[i]); - ret =3D pinctrl_scmi_map_pinconf_type_set(param, &p_config_type[i]); + if (param =3D=3D PIN_CONFIG_PERSIST_STATE) + continue; + ret =3D pinctrl_scmi_map_pinconf_type_set(param, &p_config_type[cnt]); if (ret) { dev_err(pmx->dev, "Error map pinconf_type %d\n", ret); goto free_config; } - p_config_value[i] =3D pinconf_to_config_argument(configs[i]); + p_config_value[cnt] =3D pinconf_to_config_argument(configs[i]); + cnt++; } =20 - ret =3D pinctrl_ops->settings_conf(pmx->ph, pin, PIN_TYPE, num_configs, + ret =3D pinctrl_ops->settings_conf(pmx->ph, pin, PIN_TYPE, cnt, p_config_type, p_config_value); if (ret) dev_err(pmx->dev, "Error parsing config %d\n", ret); --=20 2.53.0 From nobody Fri Apr 3 17:31:55 2026 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8DD823101A5 for ; Mon, 23 Mar 2026 19:01:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774292503; cv=none; b=FXI1FhvEfDnno86SInMNpoMMwt4AV1D1NZh3T40gomqIb+px1ntCzOXHisHlfIaYoC6qg1E8n89T6Ek1kTy20g//yrmZkxPnZ6ciLb33NAnpbv/6LMA3FgE13v8GwX1j5vGjLeeXwH2KK0dlYpY7vx8mUYxi7y6zK/sNv8igElY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774292503; c=relaxed/simple; bh=4eMRyd7ypxHELGqboKMzfQdvI1AzqqmZaR+Esy/mH5Y=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=RLisrvVu+XErWRrx3CfYMf5d6rWu/qEMBrCsvcogRcEslkZdmYnd3Tlu0lQfJyC27mgoXxGC1Zudebr9Rswg1I1nZYrInwiHkuuiDBKcbTBSYa4aLR0YmHhPDQZmaRGBbZvK3G3OIKrQ7hPe5X8wKpQhIzBWrY339XfVcEuRs8g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=btnBsPSF; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="btnBsPSF" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-486ff201041so26037835e9.1 for ; Mon, 23 Mar 2026 12:01:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1774292501; x=1774897301; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=wqJ8L0iDmB6uCpuEVuLQCen8FVgOtcZrswCudIKUuCI=; b=btnBsPSF92cKZrz8T6VQhotiwZbNd18MKjnhDSiZyBAnN1eqPBxva9wvOE3Fremi9H iMhE5YFPQQOMeoDtrkQ1NMUgMd0R0QY0ySqjpvqB7mkKvIDEduP7rv7Kva8CYUoRB9SX oZrL8V+Dizk8Bd0cM6qhM0dmCOP6sUPSwrM5g0WO8llcQotV4Mr6UdU62vETUZWicaLE M/o1G/IBGTt5wtXoxw4wMcUnu6hoeb10Td+5GB8TivzOul1iRNTabc27s5Tdq0S/T4ge ieXy0R1gRgbFZsKe9l9NfxuY2n+DmmCNwyZXr5IC5oQlC356SYjE0GBBbmwIkVS7Z5b2 Z4PA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774292501; x=1774897301; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wqJ8L0iDmB6uCpuEVuLQCen8FVgOtcZrswCudIKUuCI=; b=G+aTUQHiReJOH4csfcyDuZp4AMlvHn6vPc7noVLMHhI8wbohQ1a3+AzPNPlfi9XcRL 7sw6LkeceDWM87KeqnxaDbCjTauryfYo9Ide2Y6q53kA4hQUnMFMPpM9PNgyRlG3vaKv 02GJxQo+heq1LWzbT2yWZ/yipX0vzZRTzO0udxKo9nNaK7jfRdquFQFZBKbodLHc26+e Oa7Drypca6dNq/WLlxuOPiIDunFdnaAYLn9Qyhdbs3kw4cloqCPWE1vas1hc7WlXXBgT jjEseONc6Qh2iMKDc77bH4NLuDm5YcCvBI8yA6FmTxHWDWwP0MKo8kHPHSSl8NPEaCun ZHdw== X-Forwarded-Encrypted: i=1; AJvYcCUtzEQMc1ldG2agEArQxpw0keEPz3wK3hbLf1070zhEephkKg4IHHI3dxE219wquKRyzrZgd1lyhMVU0fY=@vger.kernel.org X-Gm-Message-State: AOJu0Yz05Ia2/3y3jBJ6D9LY0PuQc6Wgl2G8WSaOFI5YYTAMamV+bHzG Uj8jIOG4pLkeEMMUwCePYiK4MfgpSdrZ275hw81L9gU/pYTxTww40ibiY56GYjffRlM= X-Gm-Gg: ATEYQzwlzXiemmyaEqxw6/aPMha2YO2MsVK2D7HfI0t39n/d0/jYegdLmzaTcARipfT DSC+14OO6j1dh1fodtpZcU1hscpRCFbSHPb+ckQ3v2L6U/lVfkSWQh0M5VTSQ0iQmBCtbFIThfY l3TwYQmqei5lN1HyPmoyC+HTAxh/vtUUHiJI1azmPwe8j+xQ2NO7DZfe8y9rXdDStr61C1uaAyp x41rBwWOFRaYg2rn7yUa3YTCmyXlm0iG9qXn6swPw/ybgbJ9sC6l4U1qHzjNeSv/OrbXwE3nfbR LmPGI19aZY+Vuj3Wz1C1L3A7goEtQqr8tevY/SFHoiBOwQsrFlAYrqfKhxbgXcQ3kROX32gyUv7 lJk9a1pb16vf1eGCNqMO1jx5TgAepD52fpjuNR5rfNJicMjcJ8j1rKcmhlupOqQ86o7YrCKMQaH 2F69bychqeqw9CGZlHWAS4RB3PM3rB X-Received: by 2002:a05:600c:608e:b0:485:419c:4eba with SMTP id 5b1f17b1804b1-486febb58a9mr166627335e9.1.1774292500848; Mon, 23 Mar 2026 12:01:40 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-486fe032a55sm582792635e9.7.2026.03.23.12.01.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Mar 2026 12:01:40 -0700 (PDT) Date: Mon, 23 Mar 2026 22:01:37 +0300 From: Dan Carpenter To: Sudeep Holla , AKASHI Takahiro Cc: Cristian Marussi , arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Andy Shevchenko , Linus Walleij , Bartosz Golaszewski , linux-gpio@vger.kernel.org, Vincent Guittot , Khaled Ali Ahmed , Michal Simek Subject: [PATCH v6 5/7] firmware: arm_scmi: Allow PINCTRL_REQUEST to return EOPNOTSUPP Message-ID: <2089955559d22747745c0f3fed19c1bea8608d83.1774283146.git.dan.carpenter@linaro.org> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The SCMI protocol specification says that the PINCTRL_REQUEST and PINCTRL_RELEASE commands are optional. So if the SCMI server returns -EOPNOTSUPP, then treat that as success and continue. Signed-off-by: Dan Carpenter Reviewed-by: Linus Walleij Reviewed-by: Sudeep Holla --- v5: fix subsytem prefix v4: add r-b tags v3: new patch drivers/firmware/arm_scmi/pinctrl.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/firmware/arm_scmi/pinctrl.c b/drivers/firmware/arm_scm= i/pinctrl.c index a020e23d7c49..42cb1aef1fe1 100644 --- a/drivers/firmware/arm_scmi/pinctrl.c +++ b/drivers/firmware/arm_scmi/pinctrl.c @@ -578,6 +578,8 @@ static int scmi_pinctrl_request_free(const struct scmi_= protocol_handle *ph, tx->flags =3D cpu_to_le32(type); =20 ret =3D ph->xops->do_xfer(ph, t); + if (ret =3D=3D -EOPNOTSUPP) + ret =3D 0; ph->xops->xfer_put(ph, t); =20 return ret; --=20 2.53.0 From nobody Fri Apr 3 17:31:55 2026 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A0DCD314B84 for ; Mon, 23 Mar 2026 19:01:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774292509; cv=none; b=kRupcIrQRpyLZwOi9CcyrwFlDYrWEXUklbafJqmg5nF/XQLIEjOBtNz6s8d8+lxq6uKCRvDb3shkIm8FGoNQQgjKqtKwTaLxZZWfZTFVJLFYjyN7rBCVNNzDa7hhDsYEU9zV9Ogqps0p2DyjF0+TGW/7xCuewqMOkNjHmTKZ6lk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774292509; c=relaxed/simple; bh=HwXxD/Mvckwc9RensaO5rKc7xsT38UOSxYK2/xxw7d4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=c7e8J4qPOfKCv0L1n34u1aMYN4kMgK1D1ON0+88F2emD+TMy3Q3xrvfFsJctlMDsmaT4h1oDXfr4poEd+FEzqic6o2LaqZ+w+AEaFi22BK3WtApt50M2kc5W8l/d3iTM4Hi+RilX/9XVJmi8ZKLb7ydurcvmsjnK/fddMCLZUAs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=VCsTMxEC; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="VCsTMxEC" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-48540d21f7dso37180525e9.0 for ; Mon, 23 Mar 2026 12:01:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1774292506; x=1774897306; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=NvES5asAEJe0f+U9lkKESn8eUh5IqEP6vkqyZhx4vo4=; b=VCsTMxECs1+Tf9bOrw+28UVAEhC2a6Go3DLk/9hBOjZNWCUP1fyFeoR57HVrZ3Pi4d LAmXtugh8WwFt3VK3Q2MZ/TOu/iZjNA5WosqvBJhHYA/9XssdfUKvaFJdMd+aIzeO00i XYUYAaTXYrfdll3cRlxd5jTug1IauGRmg6Hs4sp67pV5+CJwTxFun1sbS7IYeh1zBZxw 1CimWpGUFdSXprFmb1XvdZrpTCLK2N+IUMS/61NgxTxCxuq75+g4s746y5fMxTqr8YoJ 4l6Mvr+dE6yLpw9E5dfbL08O1UBtF+cHa51FuVC9T+GvAPbOaKHr3qSUCNeCxtl0c4GL PRyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774292506; x=1774897306; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NvES5asAEJe0f+U9lkKESn8eUh5IqEP6vkqyZhx4vo4=; b=a6GOEXWxFQBrrEz5mzQBOk5GD+8rKCaqxKesACwtD1HtjhJbIsczkB17yHdhZ+RS8Y rUnCViZ/IRy36GQbxiM2LZrKoJ1WmLRyqVunxMewtMOcGdFpK0Oy0QpaoHgAibfzZeCd lyMvvLGSupht06j/y1BoMrrWQWRXZfyAMXB7Qs/5pEHRA9v+5KalcH03zoMNNFG0uq5i 4bpv8iw8pSCnM+MZBDg/B/HsmFPuOEVaGwNjTohgvU4kZhDzz951sAfTJs+sY56HSt2h eU55/CI66zlw2g1XxUamQDGPKIlENSrv03vcpoMIqfJz8qOLpeRPIVSZE6S5+UdJesz+ KPAA== X-Forwarded-Encrypted: i=1; AJvYcCVIPils663iYVoZdE6mbfRKDn7L47XRL3L0+MDyhRx2095YeVhd23eUc8m/f8kKmzbNj6UOUPyFmhAxpRM=@vger.kernel.org X-Gm-Message-State: AOJu0YzeUlCZFJ9tlpOfU6nT4g4cTcKntz0jQeFlEfQlKNWFxZYfLe+f jSp+rgXvlqLJUYcrgCrC0aRGKlwadaA6g4984HhTUN6WxWRidZ6PmxTwsIt28u2Ap6c= X-Gm-Gg: ATEYQzyeU3lZvIXc4jsShfZXp9jB6KbUP97RmRToZ5ixk+mh3PfF6uyfcH0WN0lN/// sU1zeiwUQ0wST6cBeGJxHqjrW5srOeJAAXfi1JqRIjqWq+Gxt9uvt4+BnNaig/CRYEy4GfBDwDp +EqYMPISoMcuK6sxCT3Jaqg8EveOCMfi1CYuiIyXQMMq+w+8e3lJJm6YZvwYJ6OjoNtpPuUNgrE hu4g9+6Rcbbrcd+Bv8biU6LDus0I63Bj01hDAbi5bITQPuge69rVe7NomhUYVsVRxYmp/VMS6js IEAcsOpVCjIsDj0+swnQkannXwyZrHLdUcf3k1xmPjQQ3a3z08sx3jRpAPVMLIdwoqgHbeG0QK2 PJp/Gkfx89DbU660tB0Px5wI4suGutxSzuf6Cqvl4Hwv4E+o3WFvcY+7gcKoQWfOFKPOrSbQzMe fDP5V+zSXa9NY3wghCudbahCuzoah0 X-Received: by 2002:a05:6000:186c:b0:43b:42e2:f4fc with SMTP id ffacd0b85a97d-43b64263ff2mr21553564f8f.26.1774292505939; Mon, 23 Mar 2026 12:01:45 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b64714decsm28606638f8f.31.2026.03.23.12.01.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Mar 2026 12:01:45 -0700 (PDT) Date: Mon, 23 Mar 2026 22:01:42 +0300 From: Dan Carpenter To: Linus Walleij , AKASHI Takahiro Cc: Bartosz Golaszewski , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Shevchenko , Linus Walleij , Bartosz Golaszewski , arm-scmi@vger.kernel.org, Vincent Guittot , Khaled Ali Ahmed , Michal Simek Subject: [PATCH v6 6/7] gpio: dt-bindings: Add GPIO on top of generic pin control Message-ID: <3ff8504571babfc0acaa74fccd1e12024d33dd11.1774283146.git.dan.carpenter@linaro.org> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: AKASHI Takahiro Traditionally, firmware will provide a GPIO interface or a pin control interface. However, the SCMI protocol provides a generic pin control interface and the GPIO support is built on top of that using the normal pin control interfaces. Potentially, other firmware will adopt a similar generic approach in the future. Document how to configure the GPIO device. Signed-off-by: AKASHI Takahiro Signed-off-by: Dan Carpenter Reviewed-by: Linus Walleij Reviewed-by: Krzysztof Kozlowski --- v6: Fix the subject. Sorry! Fix typo in my email. Add Krzysztof's reviewed-by tag. v5: Fix subsystem prefix Re-word the commit message I removed all references to the driver. I also removed the reference to pin muxing because that's described in the pin control spec file. Fix 3 vs 4 typo in the example. v4: Changed additionalProperties: true to false. Add gpio-line-names. Deleted one example. Add r-b tags v3: Forward port and update .../bindings/gpio/pin-control-gpio.yaml | 59 +++++++++++++++++++ 1 file changed, 59 insertions(+) create mode 100644 Documentation/devicetree/bindings/gpio/pin-control-gpio= .yaml diff --git a/Documentation/devicetree/bindings/gpio/pin-control-gpio.yaml b= /Documentation/devicetree/bindings/gpio/pin-control-gpio.yaml new file mode 100644 index 000000000000..a05cd339253a --- /dev/null +++ b/Documentation/devicetree/bindings/gpio/pin-control-gpio.yaml @@ -0,0 +1,59 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/gpio/pin-control-gpio.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Pin control based generic GPIO controller + +description: + The pin control-based GPIO will facilitate a pin controller's ability + to drive electric lines high/low and other generic properties of a + pin controller to perform general-purpose one-bit binary I/O. + +maintainers: + - Dan Carpenter + +properties: + compatible: + const: scmi-pinctrl-gpio + + gpio-controller: true + + "#gpio-cells": + const: 2 + + gpio-line-names: true + + gpio-ranges: true + + ngpios: true + +patternProperties: + "^.+-hog(-[0-9]+)?$": + type: object + + required: + - gpio-hog + +required: + - compatible + - gpio-controller + - "#gpio-cells" + - gpio-ranges + - ngpios + +additionalProperties: false + +examples: + - | + gpio { + compatible =3D "scmi-pinctrl-gpio"; + gpio-controller; + #gpio-cells =3D <2>; + ngpios =3D <4>; + gpio-line-names =3D "gpio_5_17", "gpio_5_20", "gpio_5_22", "gpio_2= _1"; + gpio-ranges =3D <&scmi_pinctrl 0 30 4>; + pinctrl-names =3D "default"; + pinctrl-0 =3D <&keys_pins>; + }; --=20 2.53.0 From nobody Fri Apr 3 17:31:55 2026 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF9A531F994 for ; Mon, 23 Mar 2026 19:01:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774292513; cv=none; b=khe1F2j454uw8FWVZ3NjoS/UkoqvioBybxMvCZN0McqlriEOWu3ICI13hok3G1H0lXWHcRJEwbg1yvWW/78/O/b/IbamjZQHEjpPqzcXgCGrj1IQjH9KafnBO/eLn7MD+YPY8r7iAKfV5XwW0qilkB1Lfd9vTbPFC9cG10qddXg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774292513; c=relaxed/simple; bh=78h6zo0OmGYwoE9jXpMgQ5eL1Q+6zRrrpxk2B2OYgvs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ZAQN1C7CsbniCJioFxLEJGAsVNA2SHAVi5wWMfahJ9eg7MjoDMOjVsQ7enzs2NHzm85cA+Gsz+5JNiOWg3/npi03J2XEu/p4LhtVgghcitXJdo8QW6qPpQPuDFr8NwCOuQcU6QwV7AZ/IH0sYGJCa6UCy57Ctz3AcBNGpv+aGAY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=fV+Y5bfb; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="fV+Y5bfb" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-486ff201041so26039235e9.1 for ; Mon, 23 Mar 2026 12:01:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1774292510; x=1774897310; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=YC5M6Gei+tjtXgncpnAEt2N0RrhP9pRpNjEcwCa4CLI=; b=fV+Y5bfblPjFkJ961WGi0rUyIyBKwC4HabC7T8ODnCTisgWLZKLfIEcuhxk9PP2iD4 E0Nbm1ZHzp0x2k4iTapeaSq1EBriOO3szTVBDTVUR6VGWR9MSBnz6717zcg6JkaT4frF Qrr7/r59jZyiVtT4bwlzMtkGGy7LuA/hcvvLJw6WbcZ18x3H6Xi9ZILPb85HBoo24VCb NC2M1Ms3INzq7HOyWWWN0CwrnjwpmYFwY5ZIyZbP7TmrjGSaM6BhXa+IW+ZQ//Ib/ND9 HO0FjoZqRaFPDGnNXljzh879UgJQAHKLTq/kMR2ert05tD1AT1w0GCrGioMb9/CNVlye aFTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774292510; x=1774897310; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YC5M6Gei+tjtXgncpnAEt2N0RrhP9pRpNjEcwCa4CLI=; b=ZtaSt9nVf1hP6ItPcNPFmH1r88XQ0rcnS4DnoVnOXqrEmBddokZdDpb52ugeSvtWj6 dC/knoPMAwZGi9Cp6o6h5dpPWwIhvV9nw5HqsDS6sBAlhkKGCZ2unJDZe5FJSWHkOEGu 3bA7NOoLYRLu8wpdX4ylql3B/NRPFIwKgjwCTr0nJzf7oBYzK27q0A9H3kXk95KJeSro +HdPGWl+RarEOZ13NLYp3gg3rjlUADXtG9pB9HIkRX1E6GChjjdgTKfQU1UNKBnAMHWE L8e1upCulPrl32qEhHBmFKvwkLmUQJDaIFL5hOn181NvMhNhyvTi9cnM2YjWfhzBCs7j 88yw== X-Forwarded-Encrypted: i=1; AJvYcCVI4eCdbA8JFRnqc3a/GvFcK6Y/pSUaNzRP7GHozIAtEuYIGhyja7g/9ztcSCf5TfDTONrgKCaWEJksgWc=@vger.kernel.org X-Gm-Message-State: AOJu0YywrJrkY1+6pxg0OQZUCDRVTYXXg/5GSNq7V0oExmLe2YU1Q02C CDsvJh/pXdFE1ajthuBF9BhNsDW1Odke2ybixrgMkSCJkTSNFDvHNlZ0NBICIiEXDXM= X-Gm-Gg: ATEYQzxhMx3BSb0E1ZKqjIciHofL5DAb+j9BSGgQid5W+pwBT8HltJYReZb2oii9hiS osbVLQllNI9gZK24eedKE/FNJgQzC7Ay7C0obdS/apkjk+j1jfNKImiYN9hJfkfYTSqb3i1+Rsm OiFBJKFDy/LTCmutvnH4Os4zJanztgzElCbzJ9zcZos7hRB1MdIcPNIhiN1AvOXAQOebncpijfh /9Wy8YoT+U97344+6H4uXAAERSXiPPtujzhjzXVfbMTMMG1TEVYgqpynBBapHtlLoep8J3rx66I yb1axEcIapJbGi0D88Rbx+YxE7e8EEKB4mgjnSaZUfgCXfHYizL1nJi5mazn69dNLp+dJ9uyuZd S1P2wn5olCs6HqkLD2s1PYKSAiVrtk1GQnndEN8supBkgzze60ExGyfDaIWR10KkPuO0IPncYq6 LaBIKfJHxnIu8sl36OMCQjegACpRDP X-Received: by 2002:a05:6000:2486:b0:43b:4951:6479 with SMTP id ffacd0b85a97d-43b642800a7mr20717468f8f.37.1774292510222; Mon, 23 Mar 2026 12:01:50 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b644bdaf8sm36940550f8f.13.2026.03.23.12.01.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Mar 2026 12:01:49 -0700 (PDT) Date: Mon, 23 Mar 2026 22:01:47 +0300 From: Dan Carpenter To: Linus Walleij , AKASHI Takahiro Cc: Bartosz Golaszewski , linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Andy Shevchenko , Linus Walleij , Bartosz Golaszewski , arm-scmi@vger.kernel.org, Vincent Guittot , Khaled Ali Ahmed , Michal Simek Subject: [PATCH v6 7/7] gpio: gpio-by-pinctrl: add pinctrl based generic GPIO driver Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: AKASHI Takahiro The ARM SCMI pinctrl protocol allows GPIO access. Instead of creating a new SCMI GPIO driver, this driver is a generic GPIO driver that uses standard pinctrl interfaces. Signed-off-by: AKASHI Takahiro Signed-off-by: Dan Carpenter Reviewed-by: Linus Walleij Acked-by: Bartosz Golaszewski Reviewed-by: Andy Shevchenko --- v6: Use pinconf_to_config_packed() instead of PIN_CONF_PACKED() v5: Clean up based on Andy's feedback: Update Kconfig entry Update Copyright date Fix includes Get rid of unused private data Simplify pin_control_gpio_get_direction() v4: Add r-b tags v3: Forward port and update --- drivers/gpio/Kconfig | 13 +++++ drivers/gpio/Makefile | 1 + drivers/gpio/gpio-by-pinctrl.c | 101 +++++++++++++++++++++++++++++++++ 3 files changed, 115 insertions(+) create mode 100644 drivers/gpio/gpio-by-pinctrl.c diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig index b45fb799e36c..c631ecb01e07 100644 --- a/drivers/gpio/Kconfig +++ b/drivers/gpio/Kconfig @@ -246,6 +246,19 @@ config GPIO_BRCMSTB help Say yes here to enable GPIO support for Broadcom STB (BCM7XXX) SoCs. =20 +config GPIO_BY_PINCTRL + tristate "GPIO support based on a pure pin control backend" + depends on GPIOLIB + help + Support for generic GPIO handling based on top of pin control. + Traditionally, firmware creates a GPIO interface or a pin + controller interface and we have a driver to support it. But + in SCMI, the pin control interface is generic and we can + create a simple GPIO device based on the pin control interface + without doing anything custom. + + This driver used to do GPIO over the ARM SCMI protocol. + config GPIO_CADENCE tristate "Cadence GPIO support" depends on OF_GPIO diff --git a/drivers/gpio/Makefile b/drivers/gpio/Makefile index c05f7d795c43..20d4a57afdaa 100644 --- a/drivers/gpio/Makefile +++ b/drivers/gpio/Makefile @@ -51,6 +51,7 @@ obj-$(CONFIG_GPIO_BD9571MWV) +=3D gpio-bd9571mwv.o obj-$(CONFIG_GPIO_BLZP1600) +=3D gpio-blzp1600.o obj-$(CONFIG_GPIO_BRCMSTB) +=3D gpio-brcmstb.o obj-$(CONFIG_GPIO_BT8XX) +=3D gpio-bt8xx.o +obj-$(CONFIG_GPIO_BY_PINCTRL) +=3D gpio-by-pinctrl.o obj-$(CONFIG_GPIO_CADENCE) +=3D gpio-cadence.o obj-$(CONFIG_GPIO_CGBC) +=3D gpio-cgbc.o obj-$(CONFIG_GPIO_CLPS711X) +=3D gpio-clps711x.o diff --git a/drivers/gpio/gpio-by-pinctrl.c b/drivers/gpio/gpio-by-pinctrl.c new file mode 100644 index 000000000000..ddfdc479d38a --- /dev/null +++ b/drivers/gpio/gpio-by-pinctrl.c @@ -0,0 +1,101 @@ +// SPDX-License-Identifier: GPL-2.0 +// +// Copyright (C) 2026 Linaro Inc. +// Author: AKASHI takahiro + +#include +#include +#include +#include +#include +#include +#include + +#include "gpiolib.h" + +static int pin_control_gpio_get_direction(struct gpio_chip *gc, unsigned i= nt offset) +{ + unsigned long config; + int ret; + + config =3D PIN_CONFIG_OUTPUT_ENABLE; + ret =3D pinctrl_gpio_get_config(gc, offset, &config); + if (ret) + return ret; + if (config) + return GPIO_LINE_DIRECTION_OUT; + + return GPIO_LINE_DIRECTION_IN; +} + +static int pin_control_gpio_direction_output(struct gpio_chip *chip, + unsigned int offset, int val) +{ + return pinctrl_gpio_direction_output(chip, offset); +} + +static int pin_control_gpio_get(struct gpio_chip *chip, unsigned int offse= t) +{ + unsigned long config; + int ret; + + config =3D PIN_CONFIG_LEVEL; + ret =3D pinctrl_gpio_get_config(chip, offset, &config); + if (ret) + return ret; + + return !!config; +} + +static int pin_control_gpio_set(struct gpio_chip *chip, unsigned int offse= t, + int val) +{ + unsigned long config; + + config =3D pinconf_to_config_packed(PIN_CONFIG_LEVEL, val); + return pinctrl_gpio_set_config(chip, offset, config); +} + +static int pin_control_gpio_probe(struct platform_device *pdev) +{ + struct device *dev =3D &pdev->dev; + struct gpio_chip *chip; + + chip =3D devm_kzalloc(dev, sizeof(*chip), GFP_KERNEL); + if (!chip) + return -ENOMEM; + + chip->label =3D dev_name(dev); + chip->parent =3D dev; + chip->base =3D -1; + + chip->request =3D gpiochip_generic_request; + chip->free =3D gpiochip_generic_free; + chip->get_direction =3D pin_control_gpio_get_direction; + chip->direction_input =3D pinctrl_gpio_direction_input; + chip->direction_output =3D pin_control_gpio_direction_output; + chip->get =3D pin_control_gpio_get; + chip->set =3D pin_control_gpio_set; + chip->set_config =3D gpiochip_generic_config; + + return devm_gpiochip_add_data(dev, chip, NULL); +} + +static const struct of_device_id pin_control_gpio_match[] =3D { + { .compatible =3D "scmi-pinctrl-gpio" }, + { /* sentinel */ } +}; +MODULE_DEVICE_TABLE(of, pin_control_gpio_match); + +static struct platform_driver pin_control_gpio_driver =3D { + .probe =3D pin_control_gpio_probe, + .driver =3D { + .name =3D "pin-control-gpio", + .of_match_table =3D pin_control_gpio_match, + }, +}; +module_platform_driver(pin_control_gpio_driver); + +MODULE_AUTHOR("AKASHI Takahiro "); +MODULE_DESCRIPTION("Pinctrl based GPIO driver"); +MODULE_LICENSE("GPL"); --=20 2.53.0