From nobody Tue Apr 7 11:14:49 2026 Received: from mx0a-00128a01.pphosted.com (mx0a-00128a01.pphosted.com [148.163.135.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 243E6390229; Fri, 13 Mar 2026 11:58:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.135.77 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773403111; cv=none; b=DECPuJu6TK5Y8Wn3eaIVV73cHpbudF4dnjZ/by62739ufWHLzOzSBQGhdWmTwIP9c1V1OFOShN24oJMGdsBlm1i55g9tZY5PeGTvXhz8zUvRy9iBw9sUniu9B2pF5nuvG0+ku+gj1APnucYqZqqXkNUprh5p86ZR3aYeqNkCyRc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773403111; c=relaxed/simple; bh=IZ2wxagAcWSa9Iw81akn3/w+gAZjiyRE1I5tYZZ+N4U=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=mMG4ow/Q+JZG0B3sPEyx0J3mJkm5l4j6dgk99BiXE3Y468Iil2/CSYnmykJFdf9Qgbk0yVx6BRoG3zMiQg8W4GCLB91SvxhZxhQGMfVAcDzlI5qlwGy/2ZnVL9Rkx51MObO7b8SQbH6g7Nw8bAVNJ68QKwUll5PrGOUmuUd8rKI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com; spf=pass smtp.mailfrom=analog.com; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b=gM1x+G2k; arc=none smtp.client-ip=148.163.135.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=analog.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b="gM1x+G2k" Received: from pps.filterd (m0516787.ppops.net [127.0.0.1]) by mx0a-00128a01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62DAKSo52907096; Fri, 13 Mar 2026 07:58:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=DKIM; bh=72fHS Nspt53onFw34g/FZYy+lUxRj8IDqVGlUFXDD+w=; b=gM1x+G2kcKTpmvtr0lnif Kctuge9fmrzpLuSmgI2YUGayn0nZESjcgC3HcbuXmEtBhMWjIJtuzeBinVoFOPdJ /AdcaQqr25WBkNnSTk9K03vxnJxrEe0IEWkXxq9OwrMlcYkBm8VZvjCuZ2uZFZT+ C8MdOoAe13lbsepSEG4AoETUdRDtDECOtPOz5ixEqaN5UQ+l2WsDNXiITzTuSsk8 HGrxn8IOQ8wgpHnOAIQGNU4v67bFAuBNdeUmEJrpYuqEYpO4AnkE++LttpkuwXwX qtdPyrwvge2PsN8g9PXEmta7fEWfflhk58Ed/zcsK6jwLPKV/7I5mMjBWjWAGOBv w== Received: from nwd2mta4.analog.com ([137.71.173.58]) by mx0a-00128a01.pphosted.com (PPS) with ESMTPS id 4cuh50xyyv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 13 Mar 2026 07:58:10 -0400 (EDT) Received: from ASHBMBX9.ad.analog.com (ASHBMBX9.ad.analog.com [10.64.17.10]) by nwd2mta4.analog.com (8.14.7/8.14.7) with ESMTP id 62DBw9Fa017524 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 13 Mar 2026 07:58:09 -0400 Received: from ASHBMBX9.ad.analog.com (10.64.17.10) by ASHBMBX9.ad.analog.com (10.64.17.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.37; Fri, 13 Mar 2026 07:58:09 -0400 Received: from zeus.spd.analog.com (10.66.68.11) by ashbmbx9.ad.analog.com (10.64.17.10) with Microsoft SMTP Server id 15.2.1748.37 via Frontend Transport; Fri, 13 Mar 2026 07:58:09 -0400 Received: from HYB-b1tGeUj4GP1.ad.analog.com (HYB-b1tGeUj4GP1.ad.analog.com [10.48.65.247]) by zeus.spd.analog.com (8.15.1/8.15.1) with ESMTP id 62DBvrv1024538; Fri, 13 Mar 2026 07:58:01 -0400 From: Antoniu Miclaus To: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , , CC: Antoniu Miclaus , Andy Shevchenko Subject: [PATCH v2 1/4] iio: frequency: admv4420: add dev variable Date: Fri, 13 Mar 2026 13:57:41 +0200 Message-ID: <5983c617d748a6bbee44694b8c6f0e18e8499c71.1773050333.git.antoniu.miclaus@analog.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ADIRuleOP-NewSCL: Rule Triggered X-Authority-Analysis: v=2.4 cv=RsjI7SmK c=1 sm=1 tr=0 ts=69b3fbd2 cx=c_pps a=3WNzaoukacrqR9RwcOSAdA==:117 a=3WNzaoukacrqR9RwcOSAdA==:17 a=Yq5XynenixoA:10 a=VkNPw1HP01LnGYTKEx00:22 a=0sLvza09kfJOxVLZPwjg:22 a=OmVn7CZJonkx5R5zMQLL:22 a=QyXUC8HyAAAA:8 a=gAnH3GRIAAAA:8 a=lZ2AnQk9egpdupJ9vqsA:9 X-Proofpoint-ORIG-GUID: SV3ZzdiksJpuNymUeflAX1kfGNz1YVJN X-Proofpoint-GUID: SV3ZzdiksJpuNymUeflAX1kfGNz1YVJN X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEzMDA5NSBTYWx0ZWRfX+oJT/cfYjpdm Dl6FnIRb4xD/juAzXPuDx/Vb8G0IjhonkIAPtGB4G99abQp1G4DLpCYQcn5fFs7fn3zsepY4A14 RPNV/wfb/hzy/Wt6vw9IWoPQcpDTo30j6YCwkAh5/QUXwTJ8GcZbCcxkZwYGustAhATYoZKk6vr S3v+vFgQM8lAkQmeB5pdOyGQnvrZSYe5TdA6S/H3ZjiBbdY9etixSv+F556s1bwqgC2pWTMG6A1 GWs7EgZSGMRJ8uKT0nCelrZUFSdBo1pcuxZtZQ62avZyR4kqQI+4z2pIn7QItAMNHojvD9Y5xla MsMB7B24xtxFE7BW7LldFYw3rwNPKKw13Zs5vtk4aoYKhd3ZGBBjZOPs163TDfjZcbG5q1qdi/V rK0F7dIIxPdfwnc8KIEB+RGAyK0CRS4U3xIqtoY2BGJ0CAu0LCR0O7VLO0Y+zwlp6gKaB1EFL2e TABRiZUc93Tow2DTciQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-13_02,2026-03-13_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 adultscore=0 suspectscore=0 impostorscore=0 clxscore=1015 spamscore=0 bulkscore=0 phishscore=0 lowpriorityscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603130095 Content-Type: text/plain; charset="utf-8" Introduce a local struct device variable in admv4420_probe() to simplify subsequent conversions and improve code readability. No functional change. Reviewed-by: Andy Shevchenko Signed-off-by: Antoniu Miclaus --- Changes in v2: - No changes drivers/iio/frequency/admv4420.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/iio/frequency/admv4420.c b/drivers/iio/frequency/admv4= 420.c index 8748d9747639..6ebfe08fc211 100644 --- a/drivers/iio/frequency/admv4420.c +++ b/drivers/iio/frequency/admv4420.c @@ -344,18 +344,19 @@ static int admv4420_setup(struct iio_dev *indio_dev) =20 static int admv4420_probe(struct spi_device *spi) { + struct device *dev =3D &spi->dev; struct iio_dev *indio_dev; struct admv4420_state *st; struct regmap *regmap; int ret; =20 - indio_dev =3D devm_iio_device_alloc(&spi->dev, sizeof(*st)); + indio_dev =3D devm_iio_device_alloc(dev, sizeof(*st)); if (!indio_dev) return -ENOMEM; =20 regmap =3D devm_regmap_init_spi(spi, &admv4420_regmap_config); if (IS_ERR(regmap)) - return dev_err_probe(&spi->dev, PTR_ERR(regmap), + return dev_err_probe(dev, PTR_ERR(regmap), "Failed to initializing spi regmap\n"); =20 st =3D iio_priv(indio_dev); @@ -373,7 +374,7 @@ static int admv4420_probe(struct spi_device *spi) return ret; } =20 - return devm_iio_device_register(&spi->dev, indio_dev); + return devm_iio_device_register(dev, indio_dev); } =20 static const struct of_device_id admv4420_of_match[] =3D { --=20 2.43.0 From nobody Tue Apr 7 11:14:49 2026 Received: from mx0b-00128a01.pphosted.com (mx0a-00128a01.pphosted.com [148.163.135.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B2CAF1DDC28; Fri, 13 Mar 2026 11:58:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.135.77 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773403107; cv=none; b=Db0M0wsF5BHCdJWhtzFX5TteWqOt5gwW0JuWpoqgZIahRY+L5HgwhHoQUv4oA1baB107KQCvBm9Fq3LOwK7NwLfFMkUsETB5wRoibNRcb0EyRAwkmEZhbo/YUIjYB6n/owIkHjA4/Ozj3nA3GLG6PY/pkVZJSwkfcg5ewk/av8E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773403107; c=relaxed/simple; bh=0saWHYlJvZSqOR4C0RQY7CuhVYF35JGzVKzonDuEVF0=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=u6EoMsbWr6oxI/V859x24raUqpzMgIJr6yxQFksRQiR1GPkpn0HFKRcU/J/svRwxUxJ9fZIQGNJjHE0IIQiJ35JjgFUCClD5EzrDPs5zLk0zirO3vS6X3nJM4TbchyJ0TA7lgvOov7z/ON1HqrZesk/Cc4lwm8wY8m+zZ9+7M70= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com; spf=pass smtp.mailfrom=analog.com; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b=eSACi5lQ; arc=none smtp.client-ip=148.163.135.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=analog.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b="eSACi5lQ" Received: from pps.filterd (m0375855.ppops.net [127.0.0.1]) by mx0b-00128a01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62DATGCi3650897; Fri, 13 Mar 2026 07:58:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=DKIM; bh=SLd14 gYSeEuzgXs2UReCp1exp7e4AuntZeqie1uXqf0=; b=eSACi5lQjtbrVeY1RfPLi bEmqGYDNLFpF8TO9afrbn7SrURM3dXgYn5yl1hA1+DTHq11hr5T+WAUFbxQs04H8 LEBr/MaEobL2ZjHRiUFUAiBQ1QI6wAA3n/hvAQ+TqEVcMGf0fBqUrKHTKl5GEuga EJ2kK0JgY/l+jXJPju4AY7NrEwZOxCLWcj+0aAZHaB+dnaPksytCjKC+eDyoeX1y 7kz0eVx+zdRxo3Lw7UwjpiSAAvgUcmB7pEkpDsIe2/lPcj9wKzAIP8uXoZ7nT170 UGMYXwqb0iCGPsPaonjIUTQuOfIuoH/QdqpUQYsak4FpE5lc52OxX4L9+xsjFONT g== Received: from nwd2mta4.analog.com ([137.71.173.58]) by mx0b-00128a01.pphosted.com (PPS) with ESMTPS id 4cuh6bf126-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 13 Mar 2026 07:58:10 -0400 (EDT) Received: from ASHBMBX9.ad.analog.com (ASHBMBX9.ad.analog.com [10.64.17.10]) by nwd2mta4.analog.com (8.14.7/8.14.7) with ESMTP id 62DBw9Fb017524 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 13 Mar 2026 07:58:09 -0400 Received: from ASHBMBX8.ad.analog.com (10.64.17.5) by ASHBMBX9.ad.analog.com (10.64.17.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.37; Fri, 13 Mar 2026 07:58:09 -0400 Received: from zeus.spd.analog.com (10.66.68.11) by ashbmbx8.ad.analog.com (10.64.17.5) with Microsoft SMTP Server id 15.2.1748.37 via Frontend Transport; Fri, 13 Mar 2026 07:58:09 -0400 Received: from HYB-b1tGeUj4GP1.ad.analog.com (HYB-b1tGeUj4GP1.ad.analog.com [10.48.65.247]) by zeus.spd.analog.com (8.15.1/8.15.1) with ESMTP id 62DBvrv2024538; Fri, 13 Mar 2026 07:58:03 -0400 From: Antoniu Miclaus To: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , , CC: Antoniu Miclaus , Andy Shevchenko Subject: [PATCH v2 2/4] iio: frequency: admv4420: use dev_err_probe Date: Fri, 13 Mar 2026 13:57:42 +0200 Message-ID: <5f839124a0f831664fdf650761e70f058627e4d8.1773050333.git.antoniu.miclaus@analog.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ADIRuleOP-NewSCL: Rule Triggered X-Proofpoint-ORIG-GUID: jiUwty38oFMtvHiySczuvFPFdeE6e4nq X-Authority-Analysis: v=2.4 cv=c6amgB9l c=1 sm=1 tr=0 ts=69b3fbd2 cx=c_pps a=3WNzaoukacrqR9RwcOSAdA==:117 a=3WNzaoukacrqR9RwcOSAdA==:17 a=Yq5XynenixoA:10 a=VkNPw1HP01LnGYTKEx00:22 a=0sLvza09kfJOxVLZPwjg:22 a=N--XFCr6TIEc_64PeIT2:22 a=QyXUC8HyAAAA:8 a=gAnH3GRIAAAA:8 a=nRDzGk8YMT79mXSh_94A:9 X-Proofpoint-GUID: jiUwty38oFMtvHiySczuvFPFdeE6e4nq X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEzMDA5NSBTYWx0ZWRfXzG2w59sOFmE4 UHB8fS1ycBITtzUAj9BYqXa4cYG2htY9E054v0UEpckhe1Es0Vc6tUOFLt6e+OG5cC7892yyitW 9TDs62hUZzyBdwKw3HEq+fjRFZc25sibXkm621zBhzF9dx+vrQ9bn3BxJEeVQuPoMlqluM+zzMo HetLOd4C2TcqAtHM/nzjLl+vpVYfrLfFxR3jzPOEKf2/+SvehVqFqouZd7MjsLSAKepfe2/AFw7 2Zgw1W4rKoQOKEnWGkAwWnRA5smdEzJ9STnd8z4E9ApO80ki/7pa6ArnqWEvGsE8X6Pnlo2v7xQ +EURyv622Tn5KQVTe26Hoad3zkMRNJYNwvDKDZh+2lXTOmTVBwEEyV0rMB5nCXUYyC35Of2dM8f nPj+w8/sALOGJWdRNYNdxy+3TX50JYGDo0N9LPongkIl531Xf3jiCLlxHxfGUYIOVTKwduSNI12 2o7D2DFEsINiSMK0ENw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-13_02,2026-03-13_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 adultscore=0 malwarescore=0 suspectscore=0 lowpriorityscore=0 impostorscore=0 bulkscore=0 spamscore=0 phishscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603130095 Content-Type: text/plain; charset="utf-8" Use dev_err_probe() instead of dev_err() in the probe path to ensure proper handling of deferred probing and to simplify error handling. Also fix the format specifier for vco_freq_hz from %lld to %llu since it is u64 (unsigned), and add missing newline to the error message. Reviewed-by: Andy Shevchenko Signed-off-by: Antoniu Miclaus --- Changes in v2: - Fix vco_freq_hz format specifier from %lld to %llu - Add missing newline to error message drivers/iio/frequency/admv4420.c | 28 ++++++++++++---------------- 1 file changed, 12 insertions(+), 16 deletions(-) diff --git a/drivers/iio/frequency/admv4420.c b/drivers/iio/frequency/admv4= 420.c index 6ebfe08fc211..618511eddfb1 100644 --- a/drivers/iio/frequency/admv4420.c +++ b/drivers/iio/frequency/admv4420.c @@ -279,10 +279,9 @@ static int admv4420_setup(struct iio_dev *indio_dev) if (ret) return ret; =20 - if (val !=3D ADMV4420_SCRATCH_PAD_VAL_1) { - dev_err(dev, "Failed ADMV4420 to read/write scratchpad %x ", val); - return -EIO; - } + if (val !=3D ADMV4420_SCRATCH_PAD_VAL_1) + return dev_err_probe(dev, -EIO, + "Failed ADMV4420 to read/write scratchpad %x\n", val); =20 ret =3D regmap_write(st->regmap, ADMV4420_SCRATCHPAD, @@ -294,10 +293,9 @@ static int admv4420_setup(struct iio_dev *indio_dev) if (ret) return ret; =20 - if (val !=3D ADMV4420_SCRATCH_PAD_VAL_2) { - dev_err(dev, "Failed to read/write scratchpad %x ", val); - return -EIO; - } + if (val !=3D ADMV4420_SCRATCH_PAD_VAL_2) + return dev_err_probe(dev, -EIO, + "Failed to read/write scratchpad %x\n", val); =20 st->mux_sel =3D ADMV4420_LOCK_DTCT; st->lo_freq_hz =3D ADMV4420_DEFAULT_LO_FREQ_HZ; @@ -305,10 +303,10 @@ static int admv4420_setup(struct iio_dev *indio_dev) admv4420_fw_parse(st); =20 ret =3D admv4420_calc_parameters(st); - if (ret) { - dev_err(dev, "Failed calc parameters for %lld ", st->vco_freq_hz); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, + "Failed calc parameters for %llu\n", + st->vco_freq_hz); =20 ret =3D regmap_write(st->regmap, ADMV4420_R_DIV_L, FIELD_GET(0xFF, st->ref_block.divider)); @@ -369,10 +367,8 @@ static int admv4420_probe(struct spi_device *spi) indio_dev->num_channels =3D ARRAY_SIZE(admv4420_channels); =20 ret =3D admv4420_setup(indio_dev); - if (ret) { - dev_err(&spi->dev, "Setup ADMV4420 failed (%d)\n", ret); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, "Setup ADMV4420 failed\n"); =20 return devm_iio_device_register(dev, indio_dev); } --=20 2.43.0 From nobody Tue Apr 7 11:14:49 2026 Received: from mx0a-00128a01.pphosted.com (mx0a-00128a01.pphosted.com [148.163.135.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 678FA390219; Fri, 13 Mar 2026 11:58:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.135.77 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773403109; cv=none; b=fUloGG+Gk7yRSHnrDER/zp6hB9FDntep21ldFME0SWXiX3cD/Kwjl9TUt5it/U/zB5Kxpt96+RP8J39nHdW+4yMH9D5ioc/0yIezur1EUAgCcBsQEQFgiEgL6KnpXye6aGSMpEJI9gTf3S0JMllmegQBEzx11l+tioiRdB2/QO8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773403109; c=relaxed/simple; bh=NNnshLKY6u1TGyYcvBGCcLvBPlyOb0YU616m7byM7zE=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Ti0eImHuaRGOYZRvEbeURezDKmUdaSyfC44ZlIFrgDIL+hcRmCUIQUy09mPH7cFhWHaW90zcs/n4NRAX0e9vhNyeu5LCA5iZ7FwHvutyO6uin4+Y4JhMZnxF8o3dGC2CxPeHVqoWnJQ0OdWnxs7gR3Xg+hflE8nnR4clK9QI9Gg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com; spf=pass smtp.mailfrom=analog.com; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b=kbu8eVg9; arc=none smtp.client-ip=148.163.135.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=analog.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b="kbu8eVg9" Received: from pps.filterd (m0167088.ppops.net [127.0.0.1]) by mx0a-00128a01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62DAoOjt030390; Fri, 13 Mar 2026 07:58:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=DKIM; bh=eXJda /axdJpJzhg6SFmA4F1jJINnWt9MTr4qc328EgA=; b=kbu8eVg9vojrQq4L/CZ4l oL/nPUO3gnn5XlHaanDFKh70VfYLgDn9aSNFcWFPLnxyBOvYXgtUZeUiytfoCYjI sdWAzDOcEfiLwfHElhnc/gqIrLO88jCKQAyQsBYfQFCOLApqBhCk+Hz3HS557n4x XWbknGt7uqEQLNwzKfydHe0pQHqVNarL0QsI/nW6eCDgdnQVo39NcmQdHGQS9/dd 65JWxdrYljXonvkh6vQYVRNqtLXhjUsJQmUzU5+fjlQC0H7LONClW15x1Ps+tIoS FVSDMOTD2Tv27uBaWcYP0ctu0JLXQSiG+ZLjAsLEz8qN3mU889WcNp6xwYkjKikF Q== Received: from nwd2mta4.analog.com ([137.71.173.58]) by mx0a-00128a01.pphosted.com (PPS) with ESMTPS id 4cuh766yjr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 13 Mar 2026 07:58:14 -0400 (EDT) Received: from ASHBMBX8.ad.analog.com (ASHBMBX8.ad.analog.com [10.64.17.5]) by nwd2mta4.analog.com (8.14.7/8.14.7) with ESMTP id 62DBwD0o017538 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 13 Mar 2026 07:58:13 -0400 Received: from ASHBCASHYB5.ad.analog.com (10.64.17.133) by ASHBMBX8.ad.analog.com (10.64.17.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.37; Fri, 13 Mar 2026 07:58:13 -0400 Received: from ASHBMBX8.ad.analog.com (10.64.17.5) by ASHBCASHYB5.ad.analog.com (10.64.17.133) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.37; Fri, 13 Mar 2026 07:58:13 -0400 Received: from zeus.spd.analog.com (10.66.68.11) by ashbmbx8.ad.analog.com (10.64.17.5) with Microsoft SMTP Server id 15.2.1748.37 via Frontend Transport; Fri, 13 Mar 2026 07:58:13 -0400 Received: from HYB-b1tGeUj4GP1.ad.analog.com (HYB-b1tGeUj4GP1.ad.analog.com [10.48.65.247]) by zeus.spd.analog.com (8.15.1/8.15.1) with ESMTP id 62DBvrv3024538; Fri, 13 Mar 2026 07:58:05 -0400 From: Antoniu Miclaus To: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , "David Lechner" , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , , CC: Antoniu Miclaus Subject: [PATCH v2 3/4] iio: frequency: ad9523: add dev variable Date: Fri, 13 Mar 2026 13:57:43 +0200 Message-ID: X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ADIRuleOP-NewSCL: Rule Triggered X-Proofpoint-ORIG-GUID: 9-apH99X-UQ9-bNXGy-0v_6ZKAPamln3 X-Authority-Analysis: v=2.4 cv=AI0/m/Lt c=1 sm=1 tr=0 ts=69b3fbd6 cx=c_pps a=3WNzaoukacrqR9RwcOSAdA==:117 a=3WNzaoukacrqR9RwcOSAdA==:17 a=Yq5XynenixoA:10 a=VkNPw1HP01LnGYTKEx00:22 a=0sLvza09kfJOxVLZPwjg:22 a=uXIjobp8t2wMuQ0fPvqm:22 a=gAnH3GRIAAAA:8 a=9Uukg2pZKlto5Ld3BdsA:9 X-Proofpoint-GUID: 9-apH99X-UQ9-bNXGy-0v_6ZKAPamln3 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEzMDA5NSBTYWx0ZWRfX3q5lYXrc0GVg BfGhcaKjIdPfX1Q0A9d8SWsA+CrsJ67wpqNt6GAmLE0srfwy0pVBzGx0Ni44kXoO9rGEbze4X1Z ENs1f0JmO/HQr0nti5nPoYOk3vYmd0Uwgk7ubZw3LaAEAf76RrwoatwNt/9JnRQoFlWW1k1Ct9m 1G7BbqXO508Eak4jBowZqF3TmRFLr9tyO38CsnfPfy4TC82iyWruzbvleJeWv7yhkrg0wIjHUiA th9O+qfq5PTj7DLBJM+VucAhzTqWaPrPB06c2IjXScXozC5x1219k7imrdbWpg8qwOWOsUNmF9T 0Xir+RWlt98u/lABBMuw8PDDwvrlVQAB26eKcYvM20I9UHWPj9DHzK/WsWyWhsV7P8H/d1u49Q7 ADC2Y/Wj1TOE/xb3CBPsPUzUJX6Q9wl66jSpC6bf638AO/rJjgD2/hBbbDNMT3p+YJEf46VeUfT KuX927GAmtdDThURUTA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-13_02,2026-03-13_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 suspectscore=0 impostorscore=0 spamscore=0 phishscore=0 bulkscore=0 malwarescore=0 lowpriorityscore=0 clxscore=1015 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603130095 Content-Type: text/plain; charset="utf-8" Introduce a local struct device variable in ad9523_probe() to simplify subsequent conversions and improve code readability. Split pdata declaration and assignment since the result is validated immediately after. No functional change. Signed-off-by: Antoniu Miclaus Reviewed-by: Andy Shevchenko --- Changes in v2: - Split pdata declaration and assignment - Leave dev_err(&spi->dev, ...) untouched, let patch 4 handle the full dev_err_probe(dev, ...) conversion drivers/iio/frequency/ad9523.c | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/drivers/iio/frequency/ad9523.c b/drivers/iio/frequency/ad9523.c index ad32eb66edca..f4e80ea0c6d2 100644 --- a/drivers/iio/frequency/ad9523.c +++ b/drivers/iio/frequency/ad9523.c @@ -948,17 +948,19 @@ static int ad9523_setup(struct iio_dev *indio_dev) =20 static int ad9523_probe(struct spi_device *spi) { - struct ad9523_platform_data *pdata =3D dev_get_platdata(&spi->dev); + struct device *dev =3D &spi->dev; + struct ad9523_platform_data *pdata; struct iio_dev *indio_dev; struct ad9523_state *st; int ret; =20 + pdata =3D dev_get_platdata(dev); if (!pdata) { dev_err(&spi->dev, "no platform data?\n"); return -EINVAL; } =20 - indio_dev =3D devm_iio_device_alloc(&spi->dev, sizeof(*st)); + indio_dev =3D devm_iio_device_alloc(dev, sizeof(*st)); if (indio_dev =3D=3D NULL) return -ENOMEM; =20 @@ -966,16 +968,16 @@ static int ad9523_probe(struct spi_device *spi) =20 mutex_init(&st->lock); =20 - ret =3D devm_regulator_get_enable(&spi->dev, "vcc"); + ret =3D devm_regulator_get_enable(dev, "vcc"); if (ret) return ret; =20 - st->pwrdown_gpio =3D devm_gpiod_get_optional(&spi->dev, "powerdown", + st->pwrdown_gpio =3D devm_gpiod_get_optional(dev, "powerdown", GPIOD_OUT_HIGH); if (IS_ERR(st->pwrdown_gpio)) return PTR_ERR(st->pwrdown_gpio); =20 - st->reset_gpio =3D devm_gpiod_get_optional(&spi->dev, "reset", + st->reset_gpio =3D devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_LOW); if (IS_ERR(st->reset_gpio)) return PTR_ERR(st->reset_gpio); @@ -985,7 +987,7 @@ static int ad9523_probe(struct spi_device *spi) gpiod_direction_output(st->reset_gpio, 1); } =20 - st->sync_gpio =3D devm_gpiod_get_optional(&spi->dev, "sync", + st->sync_gpio =3D devm_gpiod_get_optional(dev, "sync", GPIOD_OUT_HIGH); if (IS_ERR(st->sync_gpio)) return PTR_ERR(st->sync_gpio); @@ -1005,7 +1007,7 @@ static int ad9523_probe(struct spi_device *spi) if (ret < 0) return ret; =20 - return devm_iio_device_register(&spi->dev, indio_dev); + return devm_iio_device_register(dev, indio_dev); } =20 static const struct spi_device_id ad9523_id[] =3D { --=20 2.43.0 From nobody Tue Apr 7 11:14:49 2026 Received: from mx0b-00128a01.pphosted.com (mx0a-00128a01.pphosted.com [148.163.135.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 243501DDC28; Fri, 13 Mar 2026 11:58:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.135.77 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773403111; cv=none; b=gLOhd45xiIN1INluEoz0FFNddDeGhE+btfwu4prXR1xYnCdQF/WxeG18b44js6IuKp8agD/eqHPYIN/b1jLNWhmyQr3OezusoeBvpFX7gSfEgQdWthmNKGJJXeT16qHQ+8X3GQ/+9YnxZVXls39mOPYF/oTZmoTv685Jd1Fn0Zw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773403111; c=relaxed/simple; bh=+k+sf/I/cFVWyw0Yzc127mFsOSyMAoO7ELAZsKNEZYw=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=dWdpK7cl7dCuUyq/dWrDvljwduH5m68Ih9Im0VFCi2ebHhLbbK329mB8ik4qqFoICzRxafzWIGlRHxNklzzNkzjFM8yvBcLb49TxWLnVQdXBfBx9YXsToOuQsNH5OKIcR3hGujU2vvPsWsadWvTlHXif/GH2+ZLQgQe2r4w7LEU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com; spf=pass smtp.mailfrom=analog.com; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b=pECmWWPg; arc=none smtp.client-ip=148.163.135.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=analog.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b="pECmWWPg" Received: from pps.filterd (m0375855.ppops.net [127.0.0.1]) by mx0b-00128a01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62DBdIPB3650902; Fri, 13 Mar 2026 07:58:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=DKIM; bh=aYT6d w8V0jj4UVYHOcmhzsaaGN3QdWfCCU+wqOx8DVo=; b=pECmWWPg4GavR5xA3wEja XWLGzidXHO55xfnZWpo1Z3qusVBTV33rwZeDBDyXNaX7ewTrW/+sozAy5AS6cL95 EvM2JsGCviHFGsbxMXRftm+Zo6vilrupBce5ZEX97wdlntVcwu+i38uPeoBACmRi u5XTdgn/zLuC4uWQUHHtSg36t8wUvWC9wh9hxv/aYS1pGthJpH+zFB2khYWx/xnO O+//ArDDWYGlVfm/wbBjTgZK69U2jLhrMU7CPL/c5uHIeZPukme2F1kN6nSXQ34b xrsDXTWcguiMJyI2N98Ml3Rv02j8CKCt8h5syPCd9SxnUMr6SREQRyHlP2r32Nk4 Q== Received: from nwd2mta4.analog.com ([137.71.173.58]) by mx0b-00128a01.pphosted.com (PPS) with ESMTPS id 4cuh6bf12k-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 13 Mar 2026 07:58:16 -0400 (EDT) Received: from ASHBMBX9.ad.analog.com (ASHBMBX9.ad.analog.com [10.64.17.10]) by nwd2mta4.analog.com (8.14.7/8.14.7) with ESMTP id 62DBwFGf017542 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 13 Mar 2026 07:58:15 -0400 Received: from ASHBCASHYB5.ad.analog.com (10.64.17.133) by ASHBMBX9.ad.analog.com (10.64.17.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.37; Fri, 13 Mar 2026 07:58:15 -0400 Received: from ASHBMBX9.ad.analog.com (10.64.17.10) by ASHBCASHYB5.ad.analog.com (10.64.17.133) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.37; Fri, 13 Mar 2026 07:58:15 -0400 Received: from zeus.spd.analog.com (10.66.68.11) by ashbmbx9.ad.analog.com (10.64.17.10) with Microsoft SMTP Server id 15.2.1748.37 via Frontend Transport; Fri, 13 Mar 2026 07:58:15 -0400 Received: from HYB-b1tGeUj4GP1.ad.analog.com (HYB-b1tGeUj4GP1.ad.analog.com [10.48.65.247]) by zeus.spd.analog.com (8.15.1/8.15.1) with ESMTP id 62DBvrv4024538; Fri, 13 Mar 2026 07:58:07 -0400 From: Antoniu Miclaus To: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , "David Lechner" , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , , CC: Antoniu Miclaus Subject: [PATCH v2 4/4] iio: frequency: ad9523: use dev_err_probe Date: Fri, 13 Mar 2026 13:57:44 +0200 Message-ID: <7a43f75f91e94b7c91684cc18b16ed7ee9a91825.1773050333.git.antoniu.miclaus@analog.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ADIRuleOP-NewSCL: Rule Triggered X-Proofpoint-ORIG-GUID: PVBpZhCgYpgr04ruIph0uX7pqYAL3nJm X-Authority-Analysis: v=2.4 cv=c6amgB9l c=1 sm=1 tr=0 ts=69b3fbd8 cx=c_pps a=3WNzaoukacrqR9RwcOSAdA==:117 a=3WNzaoukacrqR9RwcOSAdA==:17 a=Yq5XynenixoA:10 a=VkNPw1HP01LnGYTKEx00:22 a=0sLvza09kfJOxVLZPwjg:22 a=N--XFCr6TIEc_64PeIT2:22 a=gAnH3GRIAAAA:8 a=uzGMpvntIC49hWhQwZ0A:9 X-Proofpoint-GUID: PVBpZhCgYpgr04ruIph0uX7pqYAL3nJm X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEzMDA5NSBTYWx0ZWRfXy0cmVg0slPjn pT+/8TjNM8fAXun+uoSxg2LZH/e4DYEhcEcQJDSGwV/gSUWB55bmMQmq66LPV7xnUlD0efGvcu+ HS7lwr6+gu1ILS6rWLySkE5+JPHn8rjnAT8y6URezmlG+gn26+Qfd+5zsNvx5RtP9cTKCB22oMs SGMcpKCDb6mziVtcjUzFZAxciJE7Hz0louXkAUHFSuKMRzbDn7yGZHLldoSGdl8eB6EfxsritDC Zo7RkkXi56W5Brq6pZ9JrWqd6NOdIneh8ZOHcJR2DjRoU4IVVhiflr5eXzoJHBbbt/iCQXJW/mE 8u0x6pWUzwLTxPwxyU5SrANhh+8SXSGyxSJfHmz8nCx8MXFp3TkgntbeYYG1PLQMiqscA+Y10bs 7meEvcI0ql2KcSGHujYBYnXoNIEXOp3FDcHkLKDU/ZUmR8hus/n3ZbbiJffhYofWAoA3MnlJPt4 NHhap48pDQTMXHIsRQg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-13_02,2026-03-13_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 adultscore=0 malwarescore=0 suspectscore=0 lowpriorityscore=0 impostorscore=0 bulkscore=0 spamscore=0 phishscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603130095 Content-Type: text/plain; charset="utf-8" Use dev_err_probe() instead of dev_err() in the probe path to ensure proper handling of deferred probing and to simplify error handling. Signed-off-by: Antoniu Miclaus Reviewed-by: Andy Shevchenko --- Changes in v2: - No changes drivers/iio/frequency/ad9523.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/iio/frequency/ad9523.c b/drivers/iio/frequency/ad9523.c index f4e80ea0c6d2..ea4d2763564a 100644 --- a/drivers/iio/frequency/ad9523.c +++ b/drivers/iio/frequency/ad9523.c @@ -955,10 +955,8 @@ static int ad9523_probe(struct spi_device *spi) int ret; =20 pdata =3D dev_get_platdata(dev); - if (!pdata) { - dev_err(&spi->dev, "no platform data?\n"); - return -EINVAL; - } + if (!pdata) + return dev_err_probe(dev, -EINVAL, "no platform data?\n"); =20 indio_dev =3D devm_iio_device_alloc(dev, sizeof(*st)); if (indio_dev =3D=3D NULL) --=20 2.43.0