From nobody Thu Apr 2 10:56:06 2026 Received: from mail-pg1-f201.google.com (mail-pg1-f201.google.com [209.85.215.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AAEDE349B1B for ; Mon, 23 Feb 2026 07:34:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771832067; cv=none; b=oMTR93z0JbNSzFMw/sQb6h2tzq5JifNzYE/vBN5LlHwLKIWNhH3D23aa+H0OEpgtfM8OvRU/l+n7u+rdtNrkuwnlaOXPUBALkmTjs1sC92x4wO7lbFl7SKC6xW1+t8Sv0ognRUeE1Ay838GBn1fwvkuRG6Su4Rne4cLt+YU4UO0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771832067; c=relaxed/simple; bh=GEBZzoosESo4pVyEE900e5vvLvbT0HdkzZFOpsUWUWQ=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=Sw8ljnwFKvvDBzFFgOW8dIZIWUP7LaeoJfXMKC3aCDbfLmL81K/6FGprwSg5kL1Ltq4KqoiZEXvtaDmZmFU96BqRiTgw+UybH0GDlYXpVaUyp1/6Ap2ByDlz27bZlw73fxa3xX49qK3ap/hNssOZhgdqkDrMYrg9SoZOFCGdyeE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--ackerleytng.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=cg2qgAb1; arc=none smtp.client-ip=209.85.215.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--ackerleytng.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="cg2qgAb1" Received: by mail-pg1-f201.google.com with SMTP id 41be03b00d2f7-c6de1ee12a3so2826021a12.2 for ; Sun, 22 Feb 2026 23:34:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1771832065; x=1772436865; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=sTzyqQEPt79Zpwhd6jWg3UfI8Z+bf/09VsUr7zJytLU=; b=cg2qgAb1ADlli6AU1OKylDslnicVQckrXqdrW1179KhyPOMDLEAl60AqpteeeAz/Fo k5KygpB/vMJmd5KxNncXwG6fwClXZTG2eHW9YWBeHkmvz7MT5bYU8u+yaiF7Epu5ZGzq 2yd+3gChoAyCkZQ6+FFrTnlMAtzHDPzi52/kPwVF7VgAcYfcOxiYCNmiYilnllUrlEQR 3VFNu5muSvEzW7MI8l6JQfQ9eno5yuCQh8uVHy5oNeGVrbOjl0hZX4R/lDxfCL8QN9jf Jm6KW4yzLmHaFThuJtMJ8f5i5xfwCvnGc/vc1MqXOp0TFHRvzITV05iFqxLyia/2glyJ G2rA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771832065; x=1772436865; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=sTzyqQEPt79Zpwhd6jWg3UfI8Z+bf/09VsUr7zJytLU=; b=aqZSXVZ0KkEtSNR1dG184CjbgH6NIIJfoqHil0xDeeUFvrWiaewF9P/XvctUx9iGeD vfwZWrU5ctXa/JepBZyVb5zsidzD08D0s/oTThhD5w6o8WMU6pCbjhSr/vE68/oocb44 ZsAzc9VmUEPrKOLYNjBCdGQL9AkON5AS2dMoSDoZWuYurBeXNzvk3HGk/zokf12Svmyh fMv9MaacGOsy8juROmD1JKv6Ns+kDHjgVnge/E8K2Y94PN4xX8uPh3dqy8MyeN3AnIOD ZbDX5fvDzv4WUHSegiv1m+3iVVzvYJROTKttCoJPEAydLkmuTfAQnkIIrzRz68Q+KeH3 iv4Q== X-Forwarded-Encrypted: i=1; AJvYcCXXw7hFZ2a+xQwW3mP0OnG4e9bp8WjN1EkLmG97GfcjzSMZvktrSg0Gs3UJVJ7D314yZJjp3KPqgINJQdk=@vger.kernel.org X-Gm-Message-State: AOJu0YwiDZSWCVa+T9e0Edmh8dOKhK8nVtEe3srsKW3FHOQBiYR3LYxh Yid4Cb4a22pkV42nLKE4pluIjUgUzU7gAXhxBXj0NnsKTCNOfBy3CtqpHTKrdIalRAH+0qJEFi5 tVQ72EpYQ37d3u3s3GOadcKPBig== X-Received: from pfbdo13.prod.google.com ([2002:a05:6a00:4a0d:b0:824:b4f6:5f0d]) (user=ackerleytng job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:1495:b0:81e:c67a:1a79 with SMTP id d2e1a72fcca58-826da9079e7mr6244452b3a.25.1771832064755; Sun, 22 Feb 2026 23:34:24 -0800 (PST) Date: Mon, 23 Feb 2026 07:34:13 +0000 In-Reply-To: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: X-Mailer: git-send-email 2.53.0.345.g96ddfc5eaa-goog Message-ID: <3d698e6fcf052628629d9bd928fcef5fea049a76.1771831836.git.ackerleytng@google.com> Subject: [RFC PATCH v3 1/2] XArray tests: Fix check_split tests to store correctly From: Ackerley Tng To: willy@infradead.org, akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: david@kernel.org, michael.roth@amd.com, dev.jain@arm.com, vannapurve@google.com, Ackerley Tng Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" __xa_store() does not set up xas->xa_sibs, and when it calls xas_store(), xas_store() stops prematurely and does not update node->nr_values to count all values and siblings. Hence, when working with multi-index XArrays, __xa_store() cannot be used. Fix tests by calling xas_store() directly with xas->xa_sibs correctly set up. Signed-off-by: Ackerley Tng --- lib/test_xarray.c | 20 ++++++++++++++++---- 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/lib/test_xarray.c b/lib/test_xarray.c index 5ca0aefee9aa5..e71e8ff76900b 100644 --- a/lib/test_xarray.c +++ b/lib/test_xarray.c @@ -1846,8 +1846,14 @@ static void check_split_1(struct xarray *xa, unsigne= d long index, xas_split_alloc(&xas, xa, order, GFP_KERNEL); xas_lock(&xas); xas_split(&xas, xa, order); - for (i =3D 0; i < (1 << order); i +=3D (1 << new_order)) - __xa_store(xa, index + i, xa_mk_index(index + i), 0); + for (i =3D 0; i < (1 << order); i +=3D (1 << new_order)) { + xas_set_order(&xas, index + i, new_order); + /* + * Don't worry about -ENOMEM, xas_split_alloc() and + * xas_split() ensures that all nodes are allocated. + */ + xas_store(&xas, xa_mk_index(index + i)); + } xas_unlock(&xas); =20 for (i =3D 0; i < (1 << order); i++) { @@ -1893,8 +1899,14 @@ static void check_split_2(struct xarray *xa, unsigne= d long index, xas_unlock(&xas); goto out; } - for (i =3D 0; i < (1 << order); i +=3D (1 << new_order)) - __xa_store(xa, index + i, xa_mk_index(index + i), 0); + for (i =3D 0; i < (1 << order); i +=3D (1 << new_order)) { + xas_set_order(&xas, index + i, new_order); + /* + * Don't worry about -ENOMEM, xas_split_alloc() and + * xas_split() ensures that all nodes are allocated. + */ + xas_store(&xas, xa_mk_index(index + i)); + } xas_unlock(&xas); =20 for (i =3D 0; i < (1 << order); i++) { --=20 2.53.0.345.g96ddfc5eaa-goog From nobody Thu Apr 2 10:56:06 2026 Received: from mail-pj1-f73.google.com (mail-pj1-f73.google.com [209.85.216.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B37F34BA42 for ; Mon, 23 Feb 2026 07:34:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.73 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771832068; cv=none; b=cyZ72njV+tq11SiHyFHvPWUpPFyV1QZAnWRoOqLaxOdcDbMhHhbUqWA8QHZkh0D9VMSIJP0ZWXLzMyl1qozczvOm7UwzlYn4nQhu1kuR9QCHWuofdDvmFxeAOmuA2IFZGC+FfSWL4o52M6Cill0dHioZclBovLMJp6OveY6aGjE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771832068; c=relaxed/simple; bh=iq53DsPecxUJv9f/n8TBeugQc53j2Da8dw7zuDKVyiI=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=FeX37oQF9j/zYetEPb23xTePXR4dR9js2OgNHPAf/CZtsnyixWkUepfKa/UPhIIExVYfcrTM10UjnJ+j8fc6mJz6CcPLBwBbauuw3FzxsKH34SaAFbnbzC11n2irfHajDMUjkjRw/Yxh6xIAsfDtMzAq10hcHu4ZduuiL85edok= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--ackerleytng.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=Wr9mKf6G; arc=none smtp.client-ip=209.85.216.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--ackerleytng.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Wr9mKf6G" Received: by mail-pj1-f73.google.com with SMTP id 98e67ed59e1d1-3562171b56dso4441513a91.2 for ; Sun, 22 Feb 2026 23:34:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1771832066; x=1772436866; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=H4IDTTN2imEE24tZz4W9ct9niFiZM+M1v4/EEqKS/dA=; b=Wr9mKf6G1NW6hbUa9sz4KKHVwn2byXn5Bh8UQ9qmm3g8Gu0b+i8GaaDfqDiTs8og+E LuG0pXvdJN8s18X3ddmUEg24eUh3uYXd10a/BL4pknZKCHjGZ0RZ41mOasI/6V0gKb+2 5gXcvEtypUnCEjmd3h9sYWqB/TbQdbF08D/z5WNZGi4v9XdQ+yrqfTkP4TlR1YpOXjue lbuSZEyEz4q2EelKW8pT9QEtGTxgEW8kBTYxxCAHJaU4Ljz90PiHq0fEPXR82shLOCHb 6gWT7h6A6wh4jN61LBxwSJQZ0qs1muDPVMK2P64LFR5UtaaVeiz3VvGiqZzO+iTV/h7g FOjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771832066; x=1772436866; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=H4IDTTN2imEE24tZz4W9ct9niFiZM+M1v4/EEqKS/dA=; b=exLuyfYzF9JIqdzryvVE227Q8TZVY/d8q7k1+ALRNsqysi1OIc7NIO8ZQi9kAaxJ2f rG7xh00ftf9Rt9cY6kNCBDK3COwIbB5nHs6FuzTi1MIeqMu03VRDRqR4e6QGwrjJMhtt a6qhPzhg6q8/3myaFwa1FhemZ+bVx+Wl5S/klSfLYwNbzQzTARn5oRMQUFp/+VqSlVQU HzKffwnv4ekqMOpM2jEBCCbhMPtZyYZEqtmCfJXaBUPwIa2RnTvEBozlJi+pzkxiBd+Z FqgfF/SeEUYLJagVJHDbrIHG3DGVFfMR6wuzF20yPuELeftS/ERjxSzwUTW/Iqgmpb6P H8Mg== X-Forwarded-Encrypted: i=1; AJvYcCUJ4igIVDqVkYeZEvIp6RoAJNRftclsRhO+P+ybLq+4PXJJYFJZCSgq37t2u7RFQxeBmXxym02VELzEMhA=@vger.kernel.org X-Gm-Message-State: AOJu0YzJ7nkCM9iRLmoF4u+i1iFpSVOY+ZWeDkG5zjmWmOaa/+GyLntr oEsPBnILyBDYWFiP15fcs3wZaRCTZfCmMbDPqpIH/vAKnra2IZgVuYlz5fSJTV38Vjc9OA92K88 7j2GwNlY9C7x7XWtMV0qcRXwH3Q== X-Received: from pjbbx20.prod.google.com ([2002:a17:90a:f494:b0:34c:dd6d:b10e]) (user=ackerleytng job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:17c8:b0:353:6373:590b with SMTP id 98e67ed59e1d1-358ae7c352bmr6655610a91.7.1771832066318; Sun, 22 Feb 2026 23:34:26 -0800 (PST) Date: Mon, 23 Feb 2026 07:34:14 +0000 In-Reply-To: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: X-Mailer: git-send-email 2.53.0.345.g96ddfc5eaa-goog Message-ID: Subject: [RFC PATCH v3 2/2] XArray tests: Verify xa_erase behavior in check_split From: Ackerley Tng To: willy@infradead.org, akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: david@kernel.org, michael.roth@amd.com, dev.jain@arm.com, vannapurve@google.com, Ackerley Tng Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Both __xa_store() and xa_erase() use xas_store() under the hood, but when the entry being stored is NULL (as in the case of xa_erase()), xas->xa_sibs (and max) is only checked if the next entry is not a sibling, hence allowing xas_store() to keep iterating, hence updating node->nr_values correctly. Add xa_erase() to check_split tests that verify functionality, with the added intent to illustrate the usage differences between __xa_store(), xas_store() and xa_erase() with regard to multi-index XArrays. Signed-off-by: Ackerley Tng --- lib/test_xarray.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/lib/test_xarray.c b/lib/test_xarray.c index e71e8ff76900b..bb9471a3df65c 100644 --- a/lib/test_xarray.c +++ b/lib/test_xarray.c @@ -1874,6 +1874,10 @@ static void check_split_1(struct xarray *xa, unsigne= d long index, rcu_read_unlock(); XA_BUG_ON(xa, found !=3D 1 << (order - new_order)); =20 + for (i =3D 0; i < (1 << order); i +=3D (1 << new_order)) + xa_erase(xa, index + i); + XA_BUG_ON(xa, !xa_empty(xa)); + xa_destroy(xa); } =20 @@ -1926,6 +1930,10 @@ static void check_split_2(struct xarray *xa, unsigne= d long index, } rcu_read_unlock(); XA_BUG_ON(xa, found !=3D 1 << (order - new_order)); + + for (i =3D 0; i < (1 << order); i +=3D (1 << new_order)) + xa_erase(xa, index + i); + XA_BUG_ON(xa, !xa_empty(xa)); out: xas_destroy(&xas); xa_destroy(xa); --=20 2.53.0.345.g96ddfc5eaa-goog