From nobody Mon Feb 9 01:44:21 2026 Received: from pidgin.makrotopia.org (pidgin.makrotopia.org [185.142.180.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E38C1EA7CC; Tue, 27 Jan 2026 13:18:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.142.180.65 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769519924; cv=none; b=ahsI6VqaeL6jyVjo6kvuB8VRFHOinn3C5lesyJPkQ2Is1+Wm2WzKvC4TJETp9Hw64VzDjMVfbZvbYrI6NjIF83zBLkBIIg6Sj3JRuqc/XOa0IwLT/Qp9ANwfy5sEvT5G38GzzEfNxiVpjq5kojvKV13b10BM/Nm8gpA6zSD1+ys= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769519924; c=relaxed/simple; bh=AZEUjWP6z6TjM2vxB5zbvlCTgV70Eb1pQd9sUdUGo6k=; h=Date:From:To:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XIl/MRpx6qTLDzL9+Y3GVXglK/4LAr+j2ESjjalmz2m7AnD5FGD6kjYG9tn4AvrJBplqYGGDzjnedFlAMU8IFABkYKFk+KrlATvdHRYvwhBHGO9L8jmM7WbbEHx7DZibOoJYBZJkeYM4R5or2jujVBDE0TrPckokxNFakMOC/P4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=makrotopia.org; spf=pass smtp.mailfrom=makrotopia.org; arc=none smtp.client-ip=185.142.180.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=makrotopia.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=makrotopia.org Received: from local by pidgin.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.99) (envelope-from ) id 1vkixs-000000000Sb-0l1m; Tue, 27 Jan 2026 13:18:40 +0000 Date: Tue, 27 Jan 2026 13:18:37 +0000 From: Daniel Golle To: Hauke Mehrtens , Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next 1/3] dt-bindings: net: dsa: lantiq,gswip: reference common PHY properties Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Reference the common PHY properties so RX and TX SerDes lane polarity of the SGMII/1000Base-X/2500Base-X PCS can be configured. Signed-off-by: Daniel Golle --- Documentation/devicetree/bindings/net/dsa/lantiq,gswip.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/net/dsa/lantiq,gswip.yaml b/= Documentation/devicetree/bindings/net/dsa/lantiq,gswip.yaml index f601e5f9fa6a..bf199b096dc5 100644 --- a/Documentation/devicetree/bindings/net/dsa/lantiq,gswip.yaml +++ b/Documentation/devicetree/bindings/net/dsa/lantiq,gswip.yaml @@ -105,6 +105,7 @@ patternProperties: patternProperties: "^(ethernet-)?port@[0-6]$": $ref: dsa-port.yaml# + $ref: /schemas/phy/phy-common-props.yaml# unevaluatedProperties: false =20 properties: --=20 2.52.0 From nobody Mon Feb 9 01:44:21 2026 Received: from pidgin.makrotopia.org (pidgin.makrotopia.org [185.142.180.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A1B781EA7CC; Tue, 27 Jan 2026 13:18:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.142.180.65 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769519933; cv=none; b=cu3ufLJiX9DI0D7USKrBV0aC19hPrtzQykOCVZ0erUry8eorF6KOPLz3AXCEtpQEFzJHYrgJm6ZKGZ98eO70bscbYSn9ZoYbIfsSaulDgozds5zq/h7QouhLbP58BTp7V7eaqT4rTCThd+igsMUQxUkX6AvYJyf26CaY9AWIM1M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769519933; c=relaxed/simple; bh=D42JR7u13Ao0gUEQVTk0Kz9ZYGv29KYP29e+BV8Iv+k=; h=Date:From:To:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WBAjWlgznzW9g6OyD0DpjvYKpnvmjqtDiP6K6BuBfQ71hvQNq29mEEQ5HeziIEmoKIw5KlceCkSgnuCpqAyw1dYyxz3GEf0Wgbza6cIMhLpC3ilUy7vMdXAZ09Tvvf3kMwEBE2qL+WoQYIJy6gN1E0F12+Ikmqz4hR/HJ5gbYho= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=makrotopia.org; spf=pass smtp.mailfrom=makrotopia.org; arc=none smtp.client-ip=185.142.180.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=makrotopia.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=makrotopia.org Received: from local by pidgin.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.99) (envelope-from ) id 1vkiy0-000000000Sn-2NvO; Tue, 27 Jan 2026 13:18:48 +0000 Date: Tue, 27 Jan 2026 13:18:45 +0000 From: Daniel Golle To: Hauke Mehrtens , Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next 2/3] net: dsa: mxl-gsw1xx: configure PCS polarities Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Configure SerDes PCS RX and TX polarities using the newly introduced generic properties. Signed-off-by: Daniel Golle --- drivers/net/dsa/lantiq/Kconfig | 1 + drivers/net/dsa/lantiq/mxl-gsw1xx.c | 38 +++++++++++++++++++++-------- 2 files changed, 29 insertions(+), 10 deletions(-) diff --git a/drivers/net/dsa/lantiq/Kconfig b/drivers/net/dsa/lantiq/Kconfig index bad13817af25..98efeef2661b 100644 --- a/drivers/net/dsa/lantiq/Kconfig +++ b/drivers/net/dsa/lantiq/Kconfig @@ -15,6 +15,7 @@ config NET_DSA_MXL_GSW1XX tristate "MaxLinear GSW1xx Ethernet switch support" select NET_DSA_TAG_MXL_GSW1XX select NET_DSA_LANTIQ_COMMON + select PHY_COMMON_PROPS help This enables support for the Intel/MaxLinear GSW1xx family of 1GE switches. diff --git a/drivers/net/dsa/lantiq/mxl-gsw1xx.c b/drivers/net/dsa/lantiq/m= xl-gsw1xx.c index 79cf72cc77be..6284b9afdbbb 100644 --- a/drivers/net/dsa/lantiq/mxl-gsw1xx.c +++ b/drivers/net/dsa/lantiq/mxl-gsw1xx.c @@ -15,6 +15,8 @@ #include #include #include +#include +#include #include #include #include @@ -229,11 +231,17 @@ static int gsw1xx_pcs_phy_xaui_write(struct gsw1xx_pr= iv *priv, u16 addr, 1000, 100000); } =20 -static int gsw1xx_pcs_reset(struct gsw1xx_priv *priv) +static int gsw1xx_pcs_reset(struct gsw1xx_priv *priv, phy_interface_t inte= rface) { + struct dsa_port *pcs_port; + unsigned int pol; int ret; u16 val; =20 + pcs_port =3D dsa_to_port(priv->gswip.ds, GSW1XX_SGMII_PORT); + if (!pcs_port) + return -EINVAL; + /* Assert and deassert SGMII shell reset */ ret =3D regmap_set_bits(priv->shell, GSW1XX_SHELL_RST_REQ, GSW1XX_RST_REQ_SGMII_SHELL); @@ -260,15 +268,19 @@ static int gsw1xx_pcs_reset(struct gsw1xx_priv *priv) FIELD_PREP(GSW1XX_SGMII_PHY_RX0_CFG2_FILT_CNT, GSW1XX_SGMII_PHY_RX0_CFG2_FILT_CNT_DEF); =20 + ret =3D phy_get_rx_polarity(of_fwnode_handle(pcs_port->dn), + phy_modes(interface), + BIT(PHY_POL_NORMAL) | BIT(PHY_POL_INVERT), + PHY_POL_NORMAL, &pol); + if (ret) + return ret; + /* RX lane seems to be inverted internally, so bit * GSW1XX_SGMII_PHY_RX0_CFG2_INVERT needs to be set for normal * (ie. non-inverted) operation. - * - * TODO: Take care of inverted RX pair once generic property is - * available */ - - val |=3D GSW1XX_SGMII_PHY_RX0_CFG2_INVERT; + if (pol =3D=3D PHY_POL_NORMAL) + val |=3D GSW1XX_SGMII_PHY_RX0_CFG2_INVERT; =20 ret =3D regmap_write(priv->sgmii, GSW1XX_SGMII_PHY_RX0_CFG2, val); if (ret < 0) @@ -277,9 +289,15 @@ static int gsw1xx_pcs_reset(struct gsw1xx_priv *priv) val =3D FIELD_PREP(GSW1XX_SGMII_PHY_TX0_CFG3_VBOOST_LEVEL, GSW1XX_SGMII_PHY_TX0_CFG3_VBOOST_LEVEL_DEF); =20 - /* TODO: Take care of inverted TX pair once generic property is - * available - */ + ret =3D phy_get_tx_polarity(of_fwnode_handle(pcs_port->dn), + phy_modes(interface), + BIT(PHY_POL_NORMAL) | BIT(PHY_POL_INVERT), + PHY_POL_NORMAL, &pol); + if (ret) + return ret; + + if (pol =3D=3D PHY_POL_INVERT) + val |=3D GSW1XX_SGMII_PHY_TX0_CFG3_INVERT; =20 ret =3D regmap_write(priv->sgmii, GSW1XX_SGMII_PHY_TX0_CFG3, val); if (ret < 0) @@ -336,7 +354,7 @@ static int gsw1xx_pcs_config(struct phylink_pcs *pcs, u= nsigned int neg_mode, priv->tbi_interface =3D PHY_INTERFACE_MODE_NA; =20 if (!reconf) - ret =3D gsw1xx_pcs_reset(priv); + ret =3D gsw1xx_pcs_reset(priv, interface); =20 if (ret) return ret; --=20 2.52.0 From nobody Mon Feb 9 01:44:21 2026 Received: from pidgin.makrotopia.org (pidgin.makrotopia.org [185.142.180.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 978E9284690; Tue, 27 Jan 2026 13:18:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.142.180.65 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769519941; cv=none; b=Mnbb4d2hrt0tjL9cBQnLITs/NxrR3bTRk66s1a0Qc7UdCCQcbDCK/if5mo99mOCZvCidRVyFkEeUhswi9dSNImsU3wPfO4PrgzoaBAafuuNejEyjslUtmJvJfK8QBuQeUmewV0Husb2fynmgO0zpIDbUEXQdbOreq1ojYKUOtlw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769519941; c=relaxed/simple; bh=1gtUumC4TmfZHWPDt1Gl1OUd8p+6pJQW372zQwMXqu0=; h=Date:From:To:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=YpZyr2XEaiCCmqrHx1q4oDmpa5mWSgAmODc6FvqVviLHeBsp3xba3fcSXwbPJ+A8WrXuel5X8YogvQzXfjsiEWG9eV1BmVJYLhvV2C86o4KTLU4J4itHHvehaWpIYqE0wOR4aRfrbal0dSpTPYG3lkIh2f8/gV2/YiqxK3jpMqg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=makrotopia.org; spf=pass smtp.mailfrom=makrotopia.org; arc=none smtp.client-ip=185.142.180.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=makrotopia.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=makrotopia.org Received: from local by pidgin.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.99) (envelope-from ) id 1vkiy8-000000000Sz-0EkY; Tue, 27 Jan 2026 13:18:56 +0000 Date: Tue, 27 Jan 2026 13:18:53 +0000 From: Daniel Golle To: Hauke Mehrtens , Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next 3/3] net: dsa: mxl-gsw1xx: validate chip ID Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" No check for actually present hardware is being performed in the probe function of the mxl-gsw1xx switch driver. So even if the switch isn't present at the configured MDIO bus address the driver wrongly tells the user that a "GSWIP version 0 mod 0" was found, outputting errors about PHY capabilities not matching. Read and validate the chip MANU_ID and PNUM_ID registers and output information while probing, but return an error and abort probing in case the hardware is not actually present. Signed-off-by: Daniel Golle --- drivers/net/dsa/lantiq/mxl-gsw1xx.c | 27 ++++++++++++++++++++++++++- drivers/net/dsa/lantiq/mxl-gsw1xx.h | 9 +++++++++ 2 files changed, 35 insertions(+), 1 deletion(-) diff --git a/drivers/net/dsa/lantiq/mxl-gsw1xx.c b/drivers/net/dsa/lantiq/m= xl-gsw1xx.c index 6284b9afdbbb..68034ce25e5a 100644 --- a/drivers/net/dsa/lantiq/mxl-gsw1xx.c +++ b/drivers/net/dsa/lantiq/mxl-gsw1xx.c @@ -689,7 +689,9 @@ static int gsw1xx_probe(struct mdio_device *mdiodev) { struct device *dev =3D &mdiodev->dev; struct gsw1xx_priv *priv; - u32 version; + u32 version, val; + u8 shellver; + u16 pnum; int ret; =20 priv =3D devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); @@ -737,6 +739,27 @@ static int gsw1xx_probe(struct mdio_device *mdiodev) if (IS_ERR(priv->shell)) return PTR_ERR(priv->shell); =20 + ret =3D regmap_read(priv->shell, GSW1XX_SHELL_MANU_ID, &val); + if (ret < 0) + return ret; + + /* validate chip ID */ + if (FIELD_GET(GSW1XX_SHELL_MANU_ID_FIX1, val) !=3D 1) + return -ENODEV; + + if (FIELD_GET(GSW1XX_SHELL_MANU_ID_MANID, val) !=3D + GSW1XX_SHELL_MANU_ID_MANID_VAL) + return -ENODEV; + + pnum =3D FIELD_GET(GSW1XX_SHELL_MANU_ID_PNUML, val); + + ret =3D regmap_read(priv->shell, GSW1XX_SHELL_PNUM_ID, &val); + if (ret < 0) + return ret; + + pnum |=3D FIELD_GET(GSW1XX_SHELL_PNUM_ID_PNUMM, val) << 4; + shellver =3D FIELD_GET(GSW1XX_SHELL_PNUM_ID_VER, val); + ret =3D gsw1xx_serdes_pcs_init(priv); if (ret < 0) return ret; @@ -757,6 +780,8 @@ static int gsw1xx_probe(struct mdio_device *mdiodev) if (ret) return ret; =20 + dev_info(dev, "standalone switch part number 0x%x v1.%u\n", pnum, shellve= r); + dev_set_drvdata(dev, &priv->gswip); =20 return 0; diff --git a/drivers/net/dsa/lantiq/mxl-gsw1xx.h b/drivers/net/dsa/lantiq/m= xl-gsw1xx.h index d1fded56e967..caa8f1008587 100644 --- a/drivers/net/dsa/lantiq/mxl-gsw1xx.h +++ b/drivers/net/dsa/lantiq/mxl-gsw1xx.h @@ -110,6 +110,15 @@ #define GSW1XX_SHELL_BASE 0xfa00 #define GSW1XX_SHELL_RST_REQ 0x01 #define GSW1XX_RST_REQ_SGMII_SHELL BIT(5) +#define GSW1XX_SHELL_MANU_ID 0x10 +#define GSW1XX_SHELL_MANU_ID_PNUML GENMASK(15, 12) +#define GSW1XX_SHELL_MANU_ID_MANID GENMASK(11, 1) +#define GSW1XX_SHELL_MANU_ID_MANID_VAL 0x389 +#define GSW1XX_SHELL_MANU_ID_FIX1 BIT(0) +#define GSW1XX_SHELL_PNUM_ID 0x11 +#define GSW1XX_SHELL_PNUM_ID_VER GENMASK(15, 12) +#define GSW1XX_SHELL_PNUM_ID_PNUMM GENMASK(11, 0) + /* RGMII PAD Slew Control Register */ #define GSW1XX_SHELL_RGMII_SLEW_CFG 0x78 #define RGMII_SLEW_CFG_DRV_TXC BIT(2) --=20 2.52.0