From nobody Wed Feb 11 10:38:07 2026 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B5512FF65F for ; Fri, 16 Jan 2026 11:22:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768562528; cv=none; b=KcoTtjGr2iH38saIWvZH6L7OvP2Fk5zbsnO9hiwrrXXQosBBoQNmHDYP/6hwbygfD3WxLM1bzhM6i9PBEWDwwNyYAD/K7irCww5ukiq/T3W1CLkimZ0ZyoPZIIroBfUUCBb92ZZiQ4vSxMxyJSXJAODM/6Clz+rhcEtxJC3Hg90= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768562528; c=relaxed/simple; bh=pr4cWs1eLjKRKl1LbYgKPy4nfy9kqEHWdlsL7NXwIXw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=f/hqQIJDVu2W6rin+jeELhNDIm/BXmUMBymp990/1K303WLtn/REjLcREd8UREAjcxDXCLi0yCUYBqdV3NZpwo8IlJIzTRLZekXzlHq9Ny3JN+jtFeu8PCSMKAcNr1BaotD3hxbAEjCccAPf50pkMA5pm1N16RovAX1RdpXkaQI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=kernel.org; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=kernel.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-47edd6111b4so16510165e9.1 for ; Fri, 16 Jan 2026 03:22:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768562523; x=1769167323; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=D4elv1fqKc7sn/PwKjeJQlmFrczbaYL/T6XFp0mSUlU=; b=lh7O861U0yHNv28I1QZHPencK2jli+2Y0LAILp/bJMkZ4tITp6DP6FFXlmkuj7mqyq tZnsnh9SamuEr59M4kjOn7ciqYrRKHwWyGXha+n9ex0yDyji4yBNcS+r8n95ibqEtMUb IfjKGgbvyB4eYq/jeYuEDU6/kK5HHWfnLEUl3r0oqBMGDrYguOWg7GCfmoyUQYuPuP6h 9GuSlQuaHfYUNlSbFU8mz5yRWNFtB6mkOtfAZEw376X097vW2t78gw+NH1HlmwHK+X2F IAW7Nq0GTntaH3Me05U6Qw83GKikvFfkNDMDdGAv6kirJceEfCnGIujCfLkzUe4xRJX+ RXTQ== X-Gm-Message-State: AOJu0YyBgCjHMFH22ar88W9nfmJpIfTINZ9+fQbvYiF0/biVQnV0Tq8D 5eix0MEDOb1R2v6V2KYiuebJrfUfm7zrJ7WYnVA9xDwqiOEUf/MZCd+x X-Gm-Gg: AY/fxX5RNlyUyfkw1a9Ngss1RPM6mL9PLadu5HLI34H8KwqvkIyOnEh/QBoVBUvI4DO kpGymz8S3gMHoapofO7L2+5HETNjebePbydam95Y7EqnISLpxE9a7+LCJwztCShm6kxA8eY58xc PGLVKBiIW4WAbJ6hHugszUs1xq50gz+2Qi0sW/GgSK6HvtIyVNsruDNJILLuMlJuKN6lflXI2M5 ti66KAt3dqjCBeiMvS3S2uSaAAnBcCFmxeuaGQtKhbKQ1hpm0C/oxHMb+1/I8PnG+ithIYyJeCU 9PnsL43HDvqOxnk1b/5DipvadEJHwaDfWp1R9UIbcOFzmWDVDONHyVQ2ZNYMbBzJ+CF29NLnaAx ubwGeFfKXQ94Z/DeEHNRCGugzGUjle0Oo0a0dEJxqbjYY94XpYtdCjOnDQGPa5oEuLgBn12kWfP Jc3ZNoM6MwCZsJPc4LxPjTep4gekNNOeuh9JcIRwSyws+fs8E/KVAXwlv7aiS9CMwzYcaIsg== X-Received: by 2002:a05:600c:358b:b0:475:da1a:5418 with SMTP id 5b1f17b1804b1-4801e2f0573mr34678985e9.1.1768562523440; Fri, 16 Jan 2026 03:22:03 -0800 (PST) Received: from nuc.fritz.box (p200300f6f7287300fa633ffffe02074c.dip0.t-ipconnect.de. [2003:f6:f728:7300:fa63:3fff:fe02:74c]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4801e9425e9sm17725815e9.0.2026.01.16.03.22.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Jan 2026 03:22:03 -0800 (PST) From: Johannes Thumshirn To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, Jose Javier Rodriguez Barbarin , Johannes Thumshirn Subject: [PATCH 1/1] mcb: fix incorrect sanity check Date: Fri, 16 Jan 2026 12:21:41 +0100 Message-ID: <16fb55bd59d9c1d2ce2443f41d4dec2048f9a8ec.1768562302.git.jth@kernel.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Jose Javier Rodriguez Barbarin __mcb_register_driver() makes some sanity checks over mcb_driver to check if .probe and .remove callbacks are set. However, since commit 3bd13ae04ccc ("gpio: menz127: simplify error path and remove remove()") removed the .remove callback from menz127-gpio.c, not all mcb device drivers implement .remove callback. Remove .remove check to ensure all mcb device drivers can be loaded. Signed-off-by: Jose Javier Rodriguez Barbarin Fixes: 3bd13ae04ccc ("gpio: menz127: simplify error path and remove remove(= )") [ jth: added statement about menz127-gpio.c ] Signed-off-by: Johannes Thumshirn --- drivers/mcb/mcb-core.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/mcb/mcb-core.c b/drivers/mcb/mcb-core.c index c1367223e71a..3d487d75c483 100644 --- a/drivers/mcb/mcb-core.c +++ b/drivers/mcb/mcb-core.c @@ -85,7 +85,8 @@ static void mcb_remove(struct device *dev) struct mcb_device *mdev =3D to_mcb_device(dev); struct module *carrier_mod; =20 - mdrv->remove(mdev); + if (mdrv->remove) + mdrv->remove(mdev); =20 carrier_mod =3D mdev->dev.parent->driver->owner; module_put(carrier_mod); @@ -176,13 +177,13 @@ static const struct device_type mcb_carrier_device_ty= pe =3D { * @owner: The @mcb_driver's module * @mod_name: The name of the @mcb_driver's module * - * Register a @mcb_driver at the system. Perform some sanity checks, if - * the .probe and .remove methods are provided by the driver. + * Register a @mcb_driver at the system. Perform a sanity check, if + * .probe method is provided by the driver. */ int __mcb_register_driver(struct mcb_driver *drv, struct module *owner, const char *mod_name) { - if (!drv->probe || !drv->remove) + if (!drv->probe) return -EINVAL; =20 drv->driver.owner =3D owner; --=20 2.51.0