From nobody Sun Feb 8 16:36:03 2026 Received: from OS0P286CU010.outbound.protection.outlook.com (mail-japanwestazon11011070.outbound.protection.outlook.com [40.107.74.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB7F71E1C02; Tue, 30 Dec 2025 10:40:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.74.70 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767091230; cv=fail; b=DWOeP2qNrF3hXdlO9ijaEbbqKSrB6Mcdvbytw+aeTGk/JVZVdY+wyPiGuf1N18GRA9QL0hY/BRv/j65w8sGzKUZwWDfM+iWaf+g+Q6yufgKmFi2vBZLSgQRWaM/3G86OtU5db17wkIzzypC2jLPdmWWbLCCQprzGqOp6QWAnr0k= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767091230; c=relaxed/simple; bh=XDlQK7M9nJN7C/L5Wb4lIQVllCr7SsAvHZ9Nv6ILuI4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=prosaBA+Wi2JO5Ry/RYHOH6qT5Apd9Kk0qDqoAhQHHY94gdsLHPqtrB0HCYv2UM48TVX+IQwhWw1zSPupAM0XySlfxsS4SnB1lxZ+lBtlMxyfNDZzopslPQ8mNW18jgF3ow0XjL8qxFegCqIvS92Q5hM1ZbFBCxl7baF+yIQKsk= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=bp.renesas.com; spf=pass smtp.mailfrom=bp.renesas.com; dkim=pass (1024-bit key) header.d=bp.renesas.com header.i=@bp.renesas.com header.b=mwCXGmF8; arc=fail smtp.client-ip=40.107.74.70 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=bp.renesas.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bp.renesas.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=bp.renesas.com header.i=@bp.renesas.com header.b="mwCXGmF8" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=MMKv+ZT9eysgYVTBLoVY9SZbLOC02cWuj9xA7NPWaiihjJvQipD76+rz6aEkWcSttlk1Uhi01W+XApow2f3mLWZ3EQ1jBmo8hWf4iSjMCllzruXOLzPGv/oK1MtSxeEepbnvsX7LvcQAEzsoXKQSc6bxM0DRJ92yYi5bSE7u9L4WFcAZSinSI5Le+/8SwqiLAVrCUiCUS6Og/lASWhA73/bA2hiQdoM09vJOlvTBPcbN5OQwQNkytmj+wFUlgeqahFsCZ/QobIlPEohOA6Yha93A0E6NnuPtY6u+IZ4uJpCXiRHicl/xRtgsbgtQ/kZwefbFLr6xaoZyV9YcnycoBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=10s4t7+RtFTAcdQODx67YIZO/ZPHbH3TmNS9M9l8BLU=; b=B4tUcEKXVKbkKdkJCdCGD/K9gNks//3KM2HS881ky7aI2QsxHCPvHOA7iQESTM7V2rhf/Pp2S23TsQBJRYiJyqY/5qyvSsglcyi9Hkll0RZBQDXtk4WyFJoxAgzub1dF1UU9jdUO8JSlEszU7forsU4dYuIZ1/IxCk8/B/fM3KXJvxgELza0S/poZUwl8uRqDdkNok4Gq1qsy01L5sDazB3IyOAjmLIrQGZv9dyl4KoEIBfuUdVS0zKDfsd3UdqyutLZjC1CiIV969MA8yBaBOcZR3mqg6DzFWTcb5U8fFWbe/8HYP1+QLuAchL4R46qTpur2L0oxVF9Uhdcnmy7WA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=bp.renesas.com; dmarc=pass action=none header.from=bp.renesas.com; dkim=pass header.d=bp.renesas.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bp.renesas.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=10s4t7+RtFTAcdQODx67YIZO/ZPHbH3TmNS9M9l8BLU=; b=mwCXGmF86YcWAzHvZA7Fe1Z0//6tmOajJOEmdUmuxSm/N1uGYZLmyUQDW5evqzPYbkLjbQbKS9Uhkpb8NELd+G5kaCmcPi2wmrQoDyGTCQ650e+vTsVFmqE0FMrESMUnDF3CfhRcEIyUEEX4pQKXO0KXiuNLd+wJVmYsvX2uZzs= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=bp.renesas.com; Received: from TYCPR01MB11947.jpnprd01.prod.outlook.com (2603:1096:400:3e1::6) by TY7PR01MB13563.jpnprd01.prod.outlook.com (2603:1096:405:1ee::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9478.4; Tue, 30 Dec 2025 10:40:22 +0000 Received: from TYCPR01MB11947.jpnprd01.prod.outlook.com ([fe80::33f1:f7cd:46be:e4d8]) by TYCPR01MB11947.jpnprd01.prod.outlook.com ([fe80::33f1:f7cd:46be:e4d8%5]) with mapi id 15.20.9478.004; Tue, 30 Dec 2025 10:40:22 +0000 From: Tommaso Merciai To: tomm.merciai@gmail.com Cc: linux-renesas-soc@vger.kernel.org, biju.das.jz@bp.renesas.com, Tommaso Merciai , Wolfram Sang , Alexandre Belloni , Frank Li , Philipp Zabel , linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/4] i3c: renesas: Switch to clk_bulk API and store clocks in private data Date: Tue, 30 Dec 2025 11:39:36 +0100 Message-ID: <29d6558c381b726f53c22088a5a2ad5adf9fe142.1767090535.git.tommaso.merciai.xr@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FR0P281CA0056.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::6) To TYCPR01MB11947.jpnprd01.prod.outlook.com (2603:1096:400:3e1::6) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: TYCPR01MB11947:EE_|TY7PR01MB13563:EE_ X-MS-Office365-Filtering-Correlation-Id: 6fb91ebd-820a-44d4-01f1-08de478fd56d X-LD-Processed: 53d82571-da19-47e4-9cb4-625a166a4a2a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|52116014|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?0btH1Zu6BzDONpmx5ySbiZ6BSTH7GNy1ilM7Dyfuvsxw4goO4Zx54YCLNFrc?= =?us-ascii?Q?zGJrfccxTkSQgha5VZiSZU3suw8o3cmc7tyESoAd8Rg9XT084j8GhphvBOWk?= =?us-ascii?Q?Az1R3K4TAwbvmmrVYdEPFrE3u58Nf+xqqp+B+fClI2h4c6GCAXdHqSPDfMer?= =?us-ascii?Q?I0C26BkjEDUyhtOiIkqvz92t37MX0jV8EF57/K21uzfGwwhSji7N1HpHB5bv?= =?us-ascii?Q?5Bgon3SjwwhqnpSoLdMo7sOTQjXVJ9t0gIwGvVlZZ9S22/s4G9Oxxw+6RUno?= =?us-ascii?Q?yHqWMcshhuZ3WjEPmVW4dfKIV8Vo/VQPhq4mhsqgOCSy3TaAubUUo7e/DtoZ?= =?us-ascii?Q?4T/rmsKtczV7dmMYz/uEI2R3EkxFIfPtsOurKXBcIHVYv4/SttdUG0vDeoGO?= =?us-ascii?Q?rZNPADx9PCgiAnczTgg6Cq0HEzRDIxvHFqvZurS55ojd75il3sOiEawNbCa5?= =?us-ascii?Q?Ro5TDcFA61OyvF4BvugxPhc+fDFPq2KXpLLzHthndHLNZVy/tkmAWNEcotW8?= =?us-ascii?Q?QqeBxH5h0csQVeApOjZRaCjxruqwkEq01XPl9r/xBIaWTd9ed4f+eEsZKTZh?= =?us-ascii?Q?DgtH+tp2yv3C8g8PmK7DV2CJH3OQ22FLaIUsUkEIh11jfrb8hNCFy8NHwhOu?= =?us-ascii?Q?4jab5EP25aN5cQLtic3a1mK6Xc5/GYuGYO3B9kW554hO82lNdHpjKWNArXNs?= =?us-ascii?Q?D85cu6HrtqU30jHMyHju71v6H6+NibGQAX1mKHSjkNCRmgdG772yB8VF5MfS?= =?us-ascii?Q?CLBpz/GvMM5l6AmOaTfnCmdHhPh/A3W2laK4FXOfyXSKCkpEF6myIiogunAQ?= =?us-ascii?Q?3oYOYNhR829qkdzfHcm1lO4XTDbrnvy6aktucHsPncgYSyst97mfrwD7b5z4?= =?us-ascii?Q?v+kEzbvkoOTf/G3yTlgJmE9Omqfngep006VmNHOckxVXs1oLoTcUDEYkivug?= =?us-ascii?Q?dyqfvJgFCyzp8hl0V1XDkYXrWhmZnCNOgq1iVvl2goVB9C7E95TcNmYI9hXE?= =?us-ascii?Q?s4lM2R928K9vOfTMg2JYpY+OtEcRWugF9jNqHoYv9hUePvb53gjc0gjde4Fe?= =?us-ascii?Q?iyeXQCnvCwXQrTVD4f5gzww/HNYcIxOHJZXeD6swfzrPXjEiaXtwL6h1Xgt8?= =?us-ascii?Q?86Mxa+0tHzJfG1ZQPB/7tVSSYJJju+TEVt/zsRr5Ks/twROhGcoGcmZyMig1?= =?us-ascii?Q?3VxwlaYntqM4ZUKE5PinboHO+wm1j0BDDxyiKvT24zSAGlaljcQliEKzn/ha?= =?us-ascii?Q?HH0yVkTQz0K+v24+YeY8j7yJpIL1AXWjRn4mZoJTuJKEB8sigQvCOEYwekQG?= =?us-ascii?Q?NF34y2g7M42qOnEqFDqjK2cm1O2X4oLs3NCA0zyN0GLEITAOjF1QsfI0uTIM?= =?us-ascii?Q?9Af1qQgk2CGulz2B6PWXeT7R9Uypv5bC8oQQMj8vhg1/PMzimGnHQJpLkuTT?= =?us-ascii?Q?yXup8UvjImgAM8SBaLE4ZKPbpkgQhU14vBD6ff9Oh3yoM8DJrWJ3rk22v6+d?= =?us-ascii?Q?HvFyMoNUj6iHyTL/zx6qebRz67wvF6VHbr0t?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TYCPR01MB11947.jpnprd01.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(52116014)(1800799024)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?xfrlXhvthsPRqLP1WNk3JzI5l/StuDRmI26YbaMQgNtbkJoLF4COOkViDlnK?= =?us-ascii?Q?OX2hWK+R3MpnhuT9mhurhmhKNOUJ//xwjpZP+kCXXTH1hNMZywX209pq5KZX?= =?us-ascii?Q?cpnyd4mANVVQvuyvbkAeg2Jzt1iF0DbCMRM7q7FmLtPbTo7T/QBjljcmDuVb?= =?us-ascii?Q?mUeZx0fJtvgui160e7osMzx0MH9vjUG+0E8kGEBsN0cJFsfRn3DdXUemLNFN?= =?us-ascii?Q?9/KtaXtZB14qnJgh9iJ7xHSS0773S8ZymDXLKBWe4dTJT8FJCh0cPWwYeG/x?= =?us-ascii?Q?0aR43lZ6R1I6hCQse0iWE6M6W37PVCv8zZCXh0i4OyWa7UJQ3S6oI+5Upy2e?= =?us-ascii?Q?9RRepf8s79iI4gk1OTvbPoVbMuIirZa4H/o1pZGKOOalJL8QzZKfywKJWGwM?= =?us-ascii?Q?1uxIln1ng6PFN8JUTTntUricnk3NNzWSZHnnpckQcnhMMNthIJb3rRi80nsQ?= =?us-ascii?Q?I58KTn2+zi5r4HzZhsI2csmmZUlJNbNhcVOz+hNPaeYXys/RH4gwFw1fl2bW?= =?us-ascii?Q?OY+QSKES+rA8dksKgEqXaP7rctIX9gVxV+9G+m2kHbJpIw9HiIxK37iTDSTv?= =?us-ascii?Q?mxIO8qS2ICbFyiZPHNE0mCMet0ZzDScp4xt6p026ppc9E1lrmod7YZBp5r9q?= =?us-ascii?Q?+bdWiQZSrC+s4BErn4XucFyyiEM1pyLNrl2f9m9kqbUJign67FE7n7I8DOHE?= =?us-ascii?Q?tS55Eq0supuK3IwMS3d4MQytRdkeoXGZuZj8rIJKX615NKdNFQO73rx62v3t?= =?us-ascii?Q?PkUKL8D3aBCj+xr21iC6TPpwdhPJVo26XPa2Ic1y71Sm9Q+Qtcx5tAsDzM7a?= =?us-ascii?Q?k0f6DAU3vOXJp1RFhEjAgkhREs512PnFnUiHYMPp5TZTWmFgFSo4a2AMPFjC?= =?us-ascii?Q?BKfxEf0k4ATM2ouebDohd/BwT7FoRiiaJKoOBMw28fPQv3uNDRHoSVUk80ds?= =?us-ascii?Q?UFacV6FHf4NOrt/30yPL5C07UIxgqb9ysE4vFFj9SdjSNHz6Q+rvAZ/z1pIi?= =?us-ascii?Q?sHbX8I28oaSErs26hXmQuQgTmyznzibzuPRd8VwG54YcRS3aq3ZAst+WfjPG?= =?us-ascii?Q?cTEgLdIGygiBzwxJmABNODCiuDf6enSUU0+zKIseq1q/qrquoTVHRm6uIpmA?= =?us-ascii?Q?mAMOoREhTSiW1yuFlYMnh+ietnpHwd3WW2sdyPioD6n3iZOstPRGUJn5n1Qg?= =?us-ascii?Q?8lPZJZZIBBhoX2yEz2wrQBlXc9y0ouVn+ia9jYPpZKtRD69INO8EEEh4wOJ7?= =?us-ascii?Q?YLiRuayl0b89SbaCyml5E43mRRyHJDliAGjP2luqORSgl8JuWD6PfkbD4G4X?= =?us-ascii?Q?aTTsTM0JozF8mgx5qNAgV1rnZ+T3hfs0Ozau09wcCvwVOdzcYDm8oBpKJart?= =?us-ascii?Q?BJ1YBjWWnQq5K8nn27aWCfp0Uw9lZMotEtBvpmVIGGx0QIKoLc27WeAml/ej?= =?us-ascii?Q?d6cmFq4PcH3IUccXC6/U6PdTSnR8ojqMauB7z4Sk/Q2DmQZObvgeTuVNiQfm?= =?us-ascii?Q?1AniBTYH15BLAEO7rWlwUBYhj0aL11GSdd6a54N1X0pzzv/MBeka3Ct5I59G?= =?us-ascii?Q?qeUuxx3QpJsRKHBre2SKBWHRH3/XfbM5iBOnemyYbkkrX8ofz9QWDSo7VXUJ?= =?us-ascii?Q?fbYiEpthz32i192LlNwzcMuj/oA7+OUXqX2fK9BB6NSpWcAOWaX9jdJ08GSp?= =?us-ascii?Q?4z80BO4BlH0HAyToVgTdnqoNcBVTea+h6CCF6p1r4knE8tqJ9g6CdaULZ2mQ?= =?us-ascii?Q?ytv3WgundHEb9ACYoWFq6VlrvF9r1VEoXGiS/aRcFjpZujmxj4bC?= X-OriginatorOrg: bp.renesas.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6fb91ebd-820a-44d4-01f1-08de478fd56d X-MS-Exchange-CrossTenant-AuthSource: TYCPR01MB11947.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Dec 2025 10:40:22.1053 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DMtNKdUm2aBLNkpOEuQ7P9UVzEoffAZFz4xq6aiYagVo2tSyYDOQx0nextVBXNliW0yB0OWPRBcwzZoh269xlRyGsgxuJYJFbRG8dAgBOPDCyqM1j2bSZqb066pfigWs X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY7PR01MB13563 Content-Type: text/plain; charset="utf-8" Replace individual devm_clk_get_enabled() calls with the clk_bulk API and store the clock handles in the driver's private data structure. This simplifies the code, and prepares the driver for upcoming suspend/resume support. No functional change intended. Signed-off-by: Tommaso Merciai --- v1->v2: - New patch. drivers/i3c/master/renesas-i3c.c | 42 +++++++++++++++++++++----------- 1 file changed, 28 insertions(+), 14 deletions(-) diff --git a/drivers/i3c/master/renesas-i3c.c b/drivers/i3c/master/renesas-= i3c.c index 426a418f29b6..8ef6ff06df90 100644 --- a/drivers/i3c/master/renesas-i3c.c +++ b/drivers/i3c/master/renesas-i3c.c @@ -259,7 +259,8 @@ struct renesas_i3c { u8 addrs[RENESAS_I3C_MAX_DEVS]; struct renesas_i3c_xferqueue xferqueue; void __iomem *regs; - struct clk *tclk; + struct clk_bulk_data clks[3]; + u8 num_clks; }; =20 struct renesas_i3c_i2c_dev_data { @@ -276,6 +277,10 @@ struct renesas_i3c_config { unsigned int has_pclkrw:1; }; =20 +static const char * const renesas_i3c_clks[] =3D { + "pclk", "tclk", "pclkrw" +}; + static inline void renesas_i3c_reg_update(void __iomem *reg, u32 mask, u32= val) { u32 data =3D readl(reg); @@ -489,7 +494,7 @@ static int renesas_i3c_bus_init(struct i3c_master_contr= oller *m) int od_high_ticks, od_low_ticks, i2c_total_ticks; int ret; =20 - rate =3D clk_get_rate(i3c->tclk); + rate =3D clk_get_rate(i3c->clks[1].clk); if (!rate) return -EINVAL; =20 @@ -1298,11 +1303,17 @@ static const struct renesas_i3c_irq_desc renesas_i3= c_irqs[] =3D { { .name =3D "nack", .isr =3D renesas_i3c_tend_isr, .desc =3D "i3c-nack" }, }; =20 +static void renesas_i3c_clk_bulk_disable_unprepare(void *data) +{ + struct renesas_i3c *i3c =3D data; + + clk_bulk_disable_unprepare(i3c->num_clks, i3c->clks); +} + static int renesas_i3c_probe(struct platform_device *pdev) { struct renesas_i3c *i3c; struct reset_control *reset; - struct clk *clk; const struct renesas_i3c_config *config =3D of_device_get_match_data(&pde= v->dev); int ret, i; =20 @@ -1317,19 +1328,22 @@ static int renesas_i3c_probe(struct platform_device= *pdev) if (IS_ERR(i3c->regs)) return PTR_ERR(i3c->regs); =20 - clk =3D devm_clk_get_enabled(&pdev->dev, "pclk"); - if (IS_ERR(clk)) - return PTR_ERR(clk); + i3c->num_clks =3D config->has_pclkrw ? 3 : 2; =20 - if (config->has_pclkrw) { - clk =3D devm_clk_get_enabled(&pdev->dev, "pclkrw"); - if (IS_ERR(clk)) - return PTR_ERR(clk); - } + for (i =3D 0; i < i3c->num_clks; i++) + i3c->clks[i].id =3D renesas_i3c_clks[i]; =20 - i3c->tclk =3D devm_clk_get_enabled(&pdev->dev, "tclk"); - if (IS_ERR(i3c->tclk)) - return PTR_ERR(i3c->tclk); + ret =3D devm_clk_bulk_get(&pdev->dev, i3c->num_clks, i3c->clks); + if (ret) + return ret; + + ret =3D clk_bulk_prepare_enable(i3c->num_clks, i3c->clks); + if (ret) + return ret; + + ret =3D devm_add_action_or_reset(&pdev->dev, renesas_i3c_clk_bulk_disable= _unprepare, i3c); + if (ret) + return ret; =20 reset =3D devm_reset_control_get_optional_exclusive_deasserted(&pdev->dev= , "tresetn"); if (IS_ERR(reset)) --=20 2.43.0 From nobody Sun Feb 8 16:36:03 2026 Received: from OS0P286CU010.outbound.protection.outlook.com (mail-japanwestazon11011070.outbound.protection.outlook.com [40.107.74.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C0112BE625; Tue, 30 Dec 2025 10:40:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.74.70 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767091233; cv=fail; b=ns9ldT4m6P/vCOAqlzSXD1Q1Q7Qek/X9l94JJPV3dv/f/jfNWwAWI3v2zhERjPEmoifjFaXrQWwqBLjA545Jf3GKxhRHp8yMK4pDDZ5jc12G8DtR+2JAyPbA0pku+uOJWzZC/nLBTJ8R/jodVZEcP5raKYx4+WiLjIU79blgRfo= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767091233; c=relaxed/simple; bh=gmpHAnzFNttwDhhDXbpSJaAvBr1cCtGuyW9NxeMpnSE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=Gp4f3TaaFJ8fLlx9usT4JIBA1fEiyPgu6n/6lB/j44ijtfRD8FM0Rk/V+O/zHTotU6b+wY0PmZ86MDHkVYQiPT3BX15euUxkp/qXsw8Y0rh75IwX+1YxBDDQOVOSQGeqsUD7YOEajLyq9kEpxYcooQ9ligjLo8LP3QnqRRmmqnA= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=bp.renesas.com; spf=pass smtp.mailfrom=bp.renesas.com; dkim=pass (1024-bit key) header.d=bp.renesas.com header.i=@bp.renesas.com header.b=mSmVGf2C; arc=fail smtp.client-ip=40.107.74.70 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=bp.renesas.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bp.renesas.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=bp.renesas.com header.i=@bp.renesas.com header.b="mSmVGf2C" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Li0iGx1Grm+Oz4CtsvyJj2pejTC8RHvuP57pwhlVZV0RejAMzk+n0y8S6n1ZindSb/x6ARRjC9z4kySN1G1SQNfzaomc3Iy3+xqHk31qHShiNKqqXC8LS3xhIllunxjt2FCiAGk6uIWDsO1JuRPaIguf3kDaj5bznFzAGQY3frKMeDhE+eTSs8d1teSkWRgGMm55AC/10pbGMdF1QB5mjY6XAbhZYBs90OmPrUksVanWxYrXVKg+8E6O/xZzN7VVzwAQGOk08GdHTnufu+Sc9KuMuqMpdA7vLHHpGAR/VHeI94QnrFY28zYhavzsHmovV8Hu2bVA0CztArNF3X27nQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iIp8EuxQxPL+uPvHJFY60QB2b4NVaELOBeJ887qthWw=; b=qyHIc4wUk2WF0FUWnjleI/tEv6UGmh82RpPQa4V4Ek/yLMs8IDY0trS2fWtuqx4nN6gKeF2yiX32oQT/jyF3a61t9HbxWwGuCgWZkN47cOrMtIQAVQh2F7DurrN1Tw0u04v4XPMJzcvVhBpGGgvWCbzgfLc9ZlDVG2SWzNM/BNk3PwwBh+MylzSAvFldZotZ9nIpm4qKVbdTJkueYgjjgva3ILHSqmBqpg7mwwFeuxLNFN97bOXA+rW6uefpDH6GkxnF/98AkWXEmq3Z/kaARoiTQ1dErrFBSElL4p3PkyRGX1nMmGV5Q1T4zcFhn4ZWpGRSUKxiCQEatUuQPNLD3Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=bp.renesas.com; dmarc=pass action=none header.from=bp.renesas.com; dkim=pass header.d=bp.renesas.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bp.renesas.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iIp8EuxQxPL+uPvHJFY60QB2b4NVaELOBeJ887qthWw=; b=mSmVGf2CHMZqwNE5w4l18TTorSKdzR5A/dplJTpk+36utDJE0UtTVuuZYcsiCP3nHBhn6k2xG3eRVchuTqqw7SnJrY/4ccr2kHzBd2wo8VWtMbNXaYE8xgCYtzU39wxIOs6ZIWT6ARq4f/wmEbbRXFNEvzC40eVVr33hFR7Mqio= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=bp.renesas.com; Received: from TYCPR01MB11947.jpnprd01.prod.outlook.com (2603:1096:400:3e1::6) by TY7PR01MB13563.jpnprd01.prod.outlook.com (2603:1096:405:1ee::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9478.4; Tue, 30 Dec 2025 10:40:26 +0000 Received: from TYCPR01MB11947.jpnprd01.prod.outlook.com ([fe80::33f1:f7cd:46be:e4d8]) by TYCPR01MB11947.jpnprd01.prod.outlook.com ([fe80::33f1:f7cd:46be:e4d8%5]) with mapi id 15.20.9478.004; Tue, 30 Dec 2025 10:40:26 +0000 From: Tommaso Merciai To: tomm.merciai@gmail.com Cc: linux-renesas-soc@vger.kernel.org, biju.das.jz@bp.renesas.com, Tommaso Merciai , Wolfram Sang , Alexandre Belloni , Frank Li , Philipp Zabel , linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 2/4] i3c: renesas: Store clock rate and reset controls in struct renesas_i3c Date: Tue, 30 Dec 2025 11:39:37 +0100 Message-ID: X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FR0P281CA0056.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::6) To TYCPR01MB11947.jpnprd01.prod.outlook.com (2603:1096:400:3e1::6) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: TYCPR01MB11947:EE_|TY7PR01MB13563:EE_ X-MS-Office365-Filtering-Correlation-Id: 1277367f-4cf2-4d8e-abcf-08de478fd7d9 X-LD-Processed: 53d82571-da19-47e4-9cb4-625a166a4a2a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|52116014|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?X0rfRLnMvBIhSsVLoh6U10FFS0i0u+BdLZUP12AMbrWUn6YbeFRJSAQ/5MML?= =?us-ascii?Q?XSCDFPPJxA8EbIZF8D4dY3MoJUC6BGM1wGJGowv1bn6w+CcBORo4hlaJO4ZT?= =?us-ascii?Q?T0ARcR5dxhR0JgWrIlUJGOkOWzQMHB+A/wWAngkg8r1rxJpb9KjzFbmLX/CQ?= =?us-ascii?Q?yFUqC+lEEN+A/9v85Sj+1P01MyXnRwigmr+pmrqAN8diYqgXoaLLZDnB7101?= =?us-ascii?Q?k/0nIKITaudC5LDZ9Hj7eBeRP0BWq8Ss7nvfHTnK+/8cWTAcI04PfxJ977xb?= =?us-ascii?Q?t43gkdV1BBhtXl4GrIR4gV1AGen5gM/1MvLe6Y0XCil5ASlMKHeGPKSQ3Wum?= =?us-ascii?Q?MoijEoJP+dSFKFEaPS3ju6a8M/ADGOGUKjJs6siQgEAAUE/oOJlz6GnH2VxW?= =?us-ascii?Q?zirmMyLxeWjygbiyGoFXIs9czFeaEUy1BAOENHuDBSmjTMvxMXlH0N8h2sRR?= =?us-ascii?Q?WBJrOgtFavX9z/z0QH/tloi5a58Tlzzs8vClJAOchIdOMN+XmcIYd/7jbCOY?= =?us-ascii?Q?mQ55VoUB3WQ5WdZDRK2wRTUSu7eRtl+xjgHYkAoSsut+cNdS+FIxLrzQ/C86?= =?us-ascii?Q?Oxpknv067fWWE0PwGvGapDw6BHHj+Meo4TbJUfnJV9B/yR7366SrpiXrMkLU?= =?us-ascii?Q?CqojjJTAiuHX5xU+ve60JIH6rEsnlAiaeTxaycY/a+tjpugxdhe6gthR/SSh?= =?us-ascii?Q?hMbw18i3dEn1dSKhOlU+Shdp/qLUEMkwflYnmLUxo5GcWzbSaBObtLMP4DTA?= =?us-ascii?Q?SlvsB4Ed5E0IWPZFWCHMcUQ0sm9FFNl4isJbaDjaS2MxLhD8G9NlLhr5O9q7?= =?us-ascii?Q?TF8O0NiXOxygx2VtKPfknemryMCRgC0n6MpJ3169/0jCfeHu1ReoXIMr3mbr?= =?us-ascii?Q?lYEM89DV5qNBuZO2vHcE1zwlEMbyKeQn4EDDhzTKpuw8vKb1wK+Cct0m6r8E?= =?us-ascii?Q?5A3m9kiTs3fYaKT/B/m9oMTI2fqeklaYMQYFlJuwhhMQHUP9J5BdiyVBNjkv?= =?us-ascii?Q?eJSUxdHA45QAgcURo2V9WY0W9B2Ms3I1PxlLmPfwhHOipwBndEnbEQBidnSZ?= =?us-ascii?Q?5uZHe/G35RETx6NpIWhEsqqj/z6dqKDViNwaRw12mrz28jTsEs9dR64TWMCb?= =?us-ascii?Q?iEuHeta7yJUCKwr/s7z01OJaP2uygaG2L7DKnyoYIG7BQu0tNylvKTSXIxEd?= =?us-ascii?Q?CSv4SLMx3djx1CwnYcInUORyfiahcXqoCoQEpsuqZsjFPmUFlNvIugF4Zieh?= =?us-ascii?Q?E7tsfkldbisL9jdZq76tTq+n86exVGUUek3+RkbUfjlaFvQYkjRB5DkjEZyD?= =?us-ascii?Q?BPUCltZYj+rnRTSOWKTa1PMAUT2v44GkWK9hapvXganehTJBa/SRpCHKc8Xw?= =?us-ascii?Q?nTQzVkDlN+xcdecmMlVOJ0xbE/mnJM9rCsyZ8YU+V1wE6//kNp0fTL7a3K/U?= =?us-ascii?Q?CRI9igL6D4nrJwU1P771dEuQQhcHjfOdyPSGzgeMaSQ3rmEqw8fNVoiWb8EV?= =?us-ascii?Q?Pz+hT+Wtfuv3haxlJU3OyNgH4E7KyylvBq7H?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TYCPR01MB11947.jpnprd01.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(52116014)(1800799024)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?qUtFifibVA/FVCXlefgpoVeVKYcXXCQ5b/j1agP2F8JW7U1P/oNZyk0rOlf2?= =?us-ascii?Q?jL5BAj8asuu9IGYtzzEX3Nx8rD3c/zcxtdGdTTmDWSnPZfGlmtwa/BOnXuTJ?= =?us-ascii?Q?rRV8yy0mtl74+f3bhghSk9tZ5UYNNGy2JoUBDLNDI05/1kzJrQmPjSiDwaZi?= =?us-ascii?Q?DdolBCvjlxiosTVm19bEU0wt58EUrftSLRhyzkEz9rXCsNqu+SMhgrciqBd8?= =?us-ascii?Q?5Ltfm3kYk68RW6d+ht4MGKCkI0CI8KYgJZcSkMFnay/FSRAk5FyWWj7dPwS5?= =?us-ascii?Q?VuVtUPtcODwwgh/bt+PP6CWqWXU4uI23QfZk5nAHl0EA3twVydJFW0EUp4/4?= =?us-ascii?Q?GHJv2JREWzB8c2d/RAFqR19eDQJ0VVpkhHvvY7dwYlINgXfh9G1p6SS5vjvs?= =?us-ascii?Q?ojpEBLCrGyCWGDeCu7zFTpxEN+hPDU8HSRXbpct6bjaRs2/ap6fwbxQJPKRZ?= =?us-ascii?Q?V8oDZI3E+ksy6N7SANdCvcLuN9/yRx9qtMU9eJaxxxRIX5bJfcKsb17b5Bj6?= =?us-ascii?Q?IDsborF7Fz1an+r5C4GW/MEqHTZXGtYy4cgnhHgUBbaN5bS4FcgM0vI3C3cz?= =?us-ascii?Q?Z8tECwX3hbFJSrhkn9ED8ms9Og7kjhtRs61xftN+mbatRauEO9mbnzdyBSEM?= =?us-ascii?Q?EQpOJpA+F5f4qBGmcVIqanIYJ5yQ8OkPaPMB+cUNbYz4gCe1xu+U8LoLRioh?= =?us-ascii?Q?Vfr58oQ4JS8EZPBZHBDb/K4vJAFOYS2OrFsniVp2EWwZmLmZ1AQI/vO6YNfp?= =?us-ascii?Q?8h0sdUWZ2kc7uxt1cgBeFe9o7kF7rEhYAUd3qwoJOjS1xOG0ucQZlbaDG3D7?= =?us-ascii?Q?5JvYt6wSDFy+i6tp2brtvTMFJBIHEEWAiq9+ICMCAT9hErrV5ZwPMCw6Rbto?= =?us-ascii?Q?bziYn/3eyDP+wLcUkILmpa+QAa+eOBbMtxKw1Gt34LZtTH94bwjbwdldIlU4?= =?us-ascii?Q?oRFlqBGERK1SwE5/6rFScVgUP47pctRItg61XfrcAHzfn3Rk8t1fy6KeOvpn?= =?us-ascii?Q?flKh2TexXfUGY1cYikgXtmrPP2ZZlAp70dh4wRlOWh/sn7B/B0h1gKT7u9y/?= =?us-ascii?Q?2ijpKvbEX18APYv7OhpJfOM5MRTTyjzO0MemfHxIE6chQyMozBQwfIZm7lzG?= =?us-ascii?Q?d99xB3M3HXhMp6Dta2zwmJnUQ4H8u2+Str2q/OFLWrhIwdkIXMeuxJgN3/N1?= =?us-ascii?Q?JlbtrPnjhrajEPe+GusOw3oUglt7m8klEJyaUlDY6d53zcF6IgPZSmifMoZL?= =?us-ascii?Q?zUnolFfZAPfDR15MdTywcOwBFfPuSHsMYvt9Jk4SbsJQT5MxKrWtiVBdRtGB?= =?us-ascii?Q?0GivzjksXlaI16oREyqh3MHjV+BFoHriV2Rj4gTODq0+F/lJCGZNCVvnAfCy?= =?us-ascii?Q?G2BVt/VR2MVopRslClDKAPZEGxt+c5M38HHWlCDduJqxsN/nm568TtnDNRTo?= =?us-ascii?Q?S65GmgV6C1mkoiGS4fzjP4haIBeebiDEYeQvex/2Zw1FUALQkF9Tpyl6KNYn?= =?us-ascii?Q?yzVus7evk6h/XVCPaLqWg9XqNJwvKOn8ZSQt81aD5Phb+pz1sxA7vgBDxt7w?= =?us-ascii?Q?zbjSfd+iUlsAINo+O+sCqdTvZWLZic4ij16uXjlZ6/3gURgftCj7crrTV8P3?= =?us-ascii?Q?k3KLGC4eI3gwIaHLW47WQvcAnMAjAbb3XuYS/rELp5lw/IOlhE3n9wVvAYIi?= =?us-ascii?Q?c42ED+xSotgBqfgC1jqyGVZ5DFjIaZk2KZfsRoLsK20pUWN18s0xbrvHN+Q/?= =?us-ascii?Q?BpdXW26g9oaIQLKWbb2K5ICr8LdaSxFFUNfppikzHVG3jgG6hbjU?= X-OriginatorOrg: bp.renesas.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1277367f-4cf2-4d8e-abcf-08de478fd7d9 X-MS-Exchange-CrossTenant-AuthSource: TYCPR01MB11947.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Dec 2025 10:40:26.1299 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qgUjRohfxsgmkpg15xtCPsjdef1PkzKu2huAvWDLl17zVPIrvpXC37P5NYCqB+9/nLi2GhcsLvRYQouBKNECr7J4N3E3SdaP5IpIyOHT5kK2nlRfblJL5KjR2edijE36 X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY7PR01MB13563 Content-Type: text/plain; charset="utf-8" Update the struct renesas_i3c to store the clock rate, presetn and tresetn handlers. Replace local usage of the clock rate and reset controls with these structure fields. This simplifies the code, and prepares the driver for upcoming suspend/resume support. No functional change intended. Signed-off-by: Tommaso Merciai Reviewed-by: Frank Li --- v1->v2: - New patch. drivers/i3c/master/renesas-i3c.c | 39 ++++++++++++++++---------------- 1 file changed, 20 insertions(+), 19 deletions(-) diff --git a/drivers/i3c/master/renesas-i3c.c b/drivers/i3c/master/renesas-= i3c.c index 8ef6ff06df90..2736363c9074 100644 --- a/drivers/i3c/master/renesas-i3c.c +++ b/drivers/i3c/master/renesas-i3c.c @@ -256,11 +256,14 @@ struct renesas_i3c { u32 free_pos; u32 i2c_STDBR; u32 i3c_STDBR; + unsigned long rate; u8 addrs[RENESAS_I3C_MAX_DEVS]; struct renesas_i3c_xferqueue xferqueue; void __iomem *regs; struct clk_bulk_data clks[3]; u8 num_clks; + struct reset_control *presetn; + struct reset_control *tresetn; }; =20 struct renesas_i3c_i2c_dev_data { @@ -488,22 +491,21 @@ static int renesas_i3c_bus_init(struct i3c_master_con= troller *m) struct i3c_bus *bus =3D i3c_master_get_bus(m); struct i3c_device_info info =3D {}; struct i2c_timings t; - unsigned long rate; u32 double_SBR, val; int cks, pp_high_ticks, pp_low_ticks, i3c_total_ticks; int od_high_ticks, od_low_ticks, i2c_total_ticks; int ret; =20 - rate =3D clk_get_rate(i3c->clks[1].clk); - if (!rate) + i3c->rate =3D clk_get_rate(i3c->clks[1].clk); + if (!i3c->rate) return -EINVAL; =20 ret =3D renesas_i3c_reset(i3c); if (ret) return ret; =20 - i2c_total_ticks =3D DIV_ROUND_UP(rate, bus->scl_rate.i2c); - i3c_total_ticks =3D DIV_ROUND_UP(rate, bus->scl_rate.i3c); + i2c_total_ticks =3D DIV_ROUND_UP(i3c->rate, bus->scl_rate.i2c); + i3c_total_ticks =3D DIV_ROUND_UP(i3c->rate, bus->scl_rate.i3c); =20 i2c_parse_fw_timings(&m->dev, &t, true); =20 @@ -516,7 +518,7 @@ static int renesas_i3c_bus_init(struct i3c_master_contr= oller *m) pp_high_ticks =3D ((i3c_total_ticks * 5) / 10); else pp_high_ticks =3D DIV_ROUND_UP(I3C_BUS_THIGH_MIXED_MAX_NS, - NSEC_PER_SEC / rate); + NSEC_PER_SEC / i3c->rate); pp_low_ticks =3D i3c_total_ticks - pp_high_ticks; =20 if ((od_low_ticks / 2) <=3D 0xFF && pp_low_ticks < 0x3F) @@ -524,7 +526,7 @@ static int renesas_i3c_bus_init(struct i3c_master_contr= oller *m) =20 i2c_total_ticks /=3D 2; i3c_total_ticks /=3D 2; - rate /=3D 2; + i3c->rate /=3D 2; } =20 /* SCL clock period calculation in Open-drain mode */ @@ -545,8 +547,8 @@ static int renesas_i3c_bus_init(struct i3c_master_contr= oller *m) STDBR_SBRLP(pp_low_ticks) | STDBR_SBRHP(pp_high_ticks); =20 - od_low_ticks -=3D t.scl_fall_ns / (NSEC_PER_SEC / rate) + 1; - od_high_ticks -=3D t.scl_rise_ns / (NSEC_PER_SEC / rate) + 1; + od_low_ticks -=3D t.scl_fall_ns / (NSEC_PER_SEC / i3c->rate) + 1; + od_high_ticks -=3D t.scl_rise_ns / (NSEC_PER_SEC / i3c->rate) + 1; i3c->i2c_STDBR =3D (double_SBR ? STDBR_DSBRPO : 0) | STDBR_SBRLO(double_SBR, od_low_ticks) | STDBR_SBRHO(double_SBR, od_high_ticks) | @@ -597,13 +599,13 @@ static int renesas_i3c_bus_init(struct i3c_master_con= troller *m) renesas_set_bit(i3c->regs, SCSTRCTL, SCSTRCTL_ACKTWE); =20 /* Bus condition timing */ - val =3D DIV_ROUND_UP(I3C_BUS_TBUF_MIXED_FM_MIN_NS, NSEC_PER_SEC / rate); + val =3D DIV_ROUND_UP(I3C_BUS_TBUF_MIXED_FM_MIN_NS, NSEC_PER_SEC / i3c->ra= te); renesas_writel(i3c->regs, BFRECDT, BFRECDT_FRECYC(val)); =20 - val =3D DIV_ROUND_UP(I3C_BUS_TAVAL_MIN_NS, NSEC_PER_SEC / rate); + val =3D DIV_ROUND_UP(I3C_BUS_TAVAL_MIN_NS, NSEC_PER_SEC / i3c->rate); renesas_writel(i3c->regs, BAVLCDT, BAVLCDT_AVLCYC(val)); =20 - val =3D DIV_ROUND_UP(I3C_BUS_TIDLE_MIN_NS, NSEC_PER_SEC / rate); + val =3D DIV_ROUND_UP(I3C_BUS_TIDLE_MIN_NS, NSEC_PER_SEC / i3c->rate); renesas_writel(i3c->regs, BIDLCDT, BIDLCDT_IDLCYC(val)); =20 ret =3D i3c_master_get_free_addr(m, 0); @@ -1313,7 +1315,6 @@ static void renesas_i3c_clk_bulk_disable_unprepare(vo= id *data) static int renesas_i3c_probe(struct platform_device *pdev) { struct renesas_i3c *i3c; - struct reset_control *reset; const struct renesas_i3c_config *config =3D of_device_get_match_data(&pde= v->dev); int ret, i; =20 @@ -1345,14 +1346,14 @@ static int renesas_i3c_probe(struct platform_device= *pdev) if (ret) return ret; =20 - reset =3D devm_reset_control_get_optional_exclusive_deasserted(&pdev->dev= , "tresetn"); - if (IS_ERR(reset)) - return dev_err_probe(&pdev->dev, PTR_ERR(reset), + i3c->tresetn =3D devm_reset_control_get_optional_exclusive_deasserted(&pd= ev->dev, "tresetn"); + if (IS_ERR(i3c->tresetn)) + return dev_err_probe(&pdev->dev, PTR_ERR(i3c->tresetn), "Error: missing tresetn ctrl\n"); =20 - reset =3D devm_reset_control_get_optional_exclusive_deasserted(&pdev->dev= , "presetn"); - if (IS_ERR(reset)) - return dev_err_probe(&pdev->dev, PTR_ERR(reset), + i3c->presetn =3D devm_reset_control_get_optional_exclusive_deasserted(&pd= ev->dev, "presetn"); + if (IS_ERR(i3c->presetn)) + return dev_err_probe(&pdev->dev, PTR_ERR(i3c->presetn), "Error: missing presetn ctrl\n"); =20 spin_lock_init(&i3c->xferqueue.lock); --=20 2.43.0 From nobody Sun Feb 8 16:36:03 2026 Received: from OS0P286CU010.outbound.protection.outlook.com (mail-japanwestazon11011070.outbound.protection.outlook.com [40.107.74.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA6932BF00B; Tue, 30 Dec 2025 10:40:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.74.70 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767091236; cv=fail; b=AjwT0gC83mi71yyqzbVbMywvESlAx9U5lGNjyDAE82eCO+SNhAMoPwsCB5VPYoSM3L/zoHsaRBRnD5DTA8ZC2H5dl8j5r1eFDZx/8Hfms5bLz3qyJMLxeExp3t8DpW+VbyVvrXiz+PczRnYI/1bGLgZ5H8jNjOfHJLuZnaCndDM= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767091236; c=relaxed/simple; bh=QnSxPreFheszigty9xLfILbIprFRjz00PMiRU7c/02s=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=qVqj+JxudElSgCiEXo0H/8rZijNdpwXXRxx+UDK9gd9MOhLsbyu77/lvB3wCR0QzAPSizErgc931XHOQeTZFvtkf+0OIzM4ZT6J6TKb3Sb9osGC1W/HMUnsZlf3SOiOBed+4Rqsn2vNGgQHcaVSEIGHR1k3wiVxHlqqsDfMsL5Y= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=bp.renesas.com; spf=pass smtp.mailfrom=bp.renesas.com; dkim=pass (1024-bit key) header.d=bp.renesas.com header.i=@bp.renesas.com header.b=Y3Pr0Bp+; arc=fail smtp.client-ip=40.107.74.70 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=bp.renesas.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bp.renesas.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=bp.renesas.com header.i=@bp.renesas.com header.b="Y3Pr0Bp+" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=v0pww1W7E8mFqPm+OHy/KGYft+8MZYEjI4qpCWHJbhXorJqhAq8p3bBssfjfmIsib4Nkf7dfRNPJnyg+sSK4Qv73qn+QxhmiPKwAMCcPwd0MXqA4Fl/6kPBahUHHV+YCC+rTBcRG7yVV2fTUq2wepCM7LfWU3IuS8CYv95Bg6zE495u5TgZhr2s0fYJE2lQ7Zb6wagrSah+F/JLobZYjWiGz5cTLDjmKwSTbAESCbsPW4rgMxhDaX/jkjKGr/TiXQLAmj40JHgUjrH7U0tHqCf/x8kHxdGpmsU+fKsCjmP5R/sZiZ8qvQbHOxfE3xE3KNWRnrZvOPyqbS46ciKk6Vw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=E+xyvQfHknbG5K+9pvIEx+KU2bn9sXTktx4gYcCzivg=; b=JAu/ylMGnrDJKONncZyZTwwRVWuwwmj3wBF/N7WE+CS+vN/wLEEwO6slQrCGVQTQDDfZy7jtVex9Wu1E+6TkMnFxMZyzm3qcSnr25wGSvAdUmPAQmntDzTcBVBXluEV8CftW5tCZJrulPGxFM1YkOe1+AaOPhzldzLk74gK+xPej9jln4tPUoe8OI6VFo9TNwSXGqoOvpXvPDXtefZY3rZ7EqGcuIioIkXgM0WcUANOyr7/n0dUOwmiBDu2pqKqYzj4Y4zw1G2Z0GZRkHMv87CXgoTIdwx6C+/bK/7+yY3VGa7vH62fPdgnLieuKEC58gMZPJqZrY8ZyGnKcRBpPZA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=bp.renesas.com; dmarc=pass action=none header.from=bp.renesas.com; dkim=pass header.d=bp.renesas.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bp.renesas.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=E+xyvQfHknbG5K+9pvIEx+KU2bn9sXTktx4gYcCzivg=; b=Y3Pr0Bp+RLPbvtu90sSo7mA0Hg38bqCkrcF0rZoGH39+pCrwggmVdm76o4A0GFKRzP+73vlsnSM2iy1A77GviG43z0orl0Vxg2mZUc9dpvIBmtO2Sk3IsSjc2jFqM1aMOWAJBhvzbzCrZ2fmqnYfvM+a1EejO8Xllxf1EQtudSQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=bp.renesas.com; Received: from TYCPR01MB11947.jpnprd01.prod.outlook.com (2603:1096:400:3e1::6) by TY7PR01MB13563.jpnprd01.prod.outlook.com (2603:1096:405:1ee::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9478.4; Tue, 30 Dec 2025 10:40:30 +0000 Received: from TYCPR01MB11947.jpnprd01.prod.outlook.com ([fe80::33f1:f7cd:46be:e4d8]) by TYCPR01MB11947.jpnprd01.prod.outlook.com ([fe80::33f1:f7cd:46be:e4d8%5]) with mapi id 15.20.9478.004; Tue, 30 Dec 2025 10:40:30 +0000 From: Tommaso Merciai To: tomm.merciai@gmail.com Cc: linux-renesas-soc@vger.kernel.org, biju.das.jz@bp.renesas.com, Tommaso Merciai , Wolfram Sang , Alexandre Belloni , Frank Li , Philipp Zabel , linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 3/4] i3c: renesas: Factor out hardware initialization to separate function Date: Tue, 30 Dec 2025 11:39:38 +0100 Message-ID: X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FR0P281CA0056.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::6) To TYCPR01MB11947.jpnprd01.prod.outlook.com (2603:1096:400:3e1::6) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: TYCPR01MB11947:EE_|TY7PR01MB13563:EE_ X-MS-Office365-Filtering-Correlation-Id: bde37978-b54c-4549-74d2-08de478fda47 X-LD-Processed: 53d82571-da19-47e4-9cb4-625a166a4a2a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|52116014|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?wDjySowZUxWWeUDRC5uBnAx7aBa1Y+2MaoLW1raej3fiWaNQP/rvzZyHymIr?= =?us-ascii?Q?iWrsN+Ok89qBF+QvqGMo7lvEI+/tTwQYjrlS/MaNAUMSgS/poHvEVjcG0aqb?= =?us-ascii?Q?1WCVQ2EG1KEZCpaYKaLvhSN+hx65o/jsrvLqkzspyzZxkD74CU9vZQk2Ccu0?= =?us-ascii?Q?PqwoLdRQCAQCIpRWIicwmNxbBebBSmegIpsQcv9EHdtTFq899hnEI2nLrPbc?= =?us-ascii?Q?tszJK7RhSsa2YYnaYfwPwjE9+oTG35yt88h1aSTqB8zIHNxUhqTwMmvMTFCR?= =?us-ascii?Q?iG6Jb/1pAJeOm7nBuTi4h1SIY9l4sdTtw19ARWfosnFJdJ4sPDWSfkJ9om1o?= =?us-ascii?Q?jTBsLtNdxNS5HiIuzQv/aWSPQIBFv5NQ4FcKyfmm0HO4wsF6harPnibI1csq?= =?us-ascii?Q?w1NBrkQVsBcqc7vHj/wasuQ/ITC55KKTh/QayrQJigwd82JdHrirYjkR5yoX?= =?us-ascii?Q?rxZ1YMhYjAcfzKq9cspk/bKpo+1G7UfFS1VxWE/TH146Z8nLAnGc+WrY4xme?= =?us-ascii?Q?M+4jfcu8xWFBILtsOsb1jUd9rWJhbpxL21//yGHHFJzjsioN/hvvEDSEUshK?= =?us-ascii?Q?NA/3r+STSp3o4A9kPJGUa4N9CCIjY/K9M8kDYrlqPWfJUuIX+SMp3Y5XEbOe?= =?us-ascii?Q?iRqRHzSfGc0UxbThwprNsd1Qmc98wLcXMpNPlHxqkKuRVxfx0IulrAytHl31?= =?us-ascii?Q?YND0cOrHTFwI3p3oV1rGLQHVlQZuHzLSL9EsutFAu2TvTfa26GF//UQy1t7j?= =?us-ascii?Q?G3ieH/cTjTDoaP9ps7MG56yijLPiWuayASqPfYjb+aGtBkUYcfgWXDivcNeE?= =?us-ascii?Q?9gwqAvY4ZlalOr53A0ryy1H5WCfOh72WvtmtIaCJq3NjcVgWGD2FdXKnSoX7?= =?us-ascii?Q?uev1ujMMNyJ8CsHGGWGBcnen8M56xkZWYfwYBKKXIfafac8o2ihrPWKnIoze?= =?us-ascii?Q?0w+epPf8JS3ntzkuTVo/J6D35XcF9+NeSSpI1QsB1OHvE9PSxgJGntJnYJ82?= =?us-ascii?Q?JG3d2eZfFUmSI/nmGmVFp29siLQZW88W69/PtYiZIxGv1yfCXQRYQL8peVy7?= =?us-ascii?Q?jOMyIIMoaboLcJ6VAr7+3n7v6pabwvNuuGIpm8EFvSvx54JPcef9urDYMnqJ?= =?us-ascii?Q?WdOyMk5H7KjvNZpZFC6HU+JGLLguxprZSA7092+NVI8F6XqdMOsmJtyiq3Yr?= =?us-ascii?Q?aP/lZFn0YIwB14861kR9OX0OhQnvkfYB1OROjO+o8H516UyoZpbIBA0gWw4O?= =?us-ascii?Q?GSCdGQAWcs/tERs3Q+yQ7s8NdnzR2P01PDGM67pyJZ6xAAq80Khaf4oJQq8R?= =?us-ascii?Q?2xFUm92aSSXE0taelZoPI8y63T9CgTJvqjcOBmEmwyFRT7JMD39XBpKWVz5H?= =?us-ascii?Q?vcVTItKE8ng1RfsXdTkSb2wSWDvEpv1qir/yAuRmCx/SCchHHS3Uoh2sJNPO?= =?us-ascii?Q?prBnnYiN6v+sUWdSwZfI7CCSQkcyesZpAhf1cv9S5XG+0RnYQ8vcnTDyfVM6?= =?us-ascii?Q?RaHcatni/IKGBM6YcjUOa+/4dBkPDNHzvvw4?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TYCPR01MB11947.jpnprd01.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(52116014)(1800799024)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ogqI55/u1PfQZ4rhnee7thCsHsI/DuqklaNVJqcJSg1OsrUhhTpWVKZ0U8wY?= =?us-ascii?Q?xUgt/HVuooJEJusAi3Rv7rGuTR36FMthisikLd6pCfVgqMXFZvn1AfjCyIyt?= =?us-ascii?Q?+hPK1EjemXChTlxQGQoYjMCElKE9WAkz8kUJY1wg2CUj4qIXk2FGJUBF9/PN?= =?us-ascii?Q?reTbjk7H34WyzsImpr5gdh7jpaTWOWdn08daUvKSUoHdsvocrfCALYV8Vn00?= =?us-ascii?Q?CFYL9Hhu1++TErotQT9mmhuXWezE9H11Vk3etePMGSoOWMm7Se2D0/ViRETr?= =?us-ascii?Q?HgAPzYm/QDYRqveB9NRTfTTaxIccoPkFoPVjd9/KmdyBby39z/EsJifuEM/N?= =?us-ascii?Q?8en/mVu8fm33Lem/FpES0gYt6VY1Ix5KRPEz9WCBm/OzzPnV/ES+XnQImICu?= =?us-ascii?Q?odET+4MyRKWnnyc6BKSvdVwDnjZ7cdOxeR2wCIrBMxKt5IFhuWB/zGgkRtui?= =?us-ascii?Q?YfKfafSIelSFCiU03C0GRQwpR3A0dXSoBB7wudgogFD2BiodeSe9AR7OTkDN?= =?us-ascii?Q?jI5AVADEP5J9JeGUPBnaXflfRFYWzij9IPPP13xhtK5cuYWo8IcrqJjOaQkg?= =?us-ascii?Q?2l+8bkkOOYpDkZNQh7I8yhPt1r4aK+z0wyPivrck66bF1JnmguhzaB5JvmS0?= =?us-ascii?Q?aNq1p8OL6JXTlaBxVHzy1DxpnltQf3UtlQxvtdzYNCvHgKjKjVbcWCDG1WYb?= =?us-ascii?Q?YMnbiA0ZK4HCEYEY2hoyFxyZgu7/Qu9UkRfwgx6kAFjSzFS5ow0cB6Zqz+v7?= =?us-ascii?Q?gtp5nITS+VPxdxJAU+wEEWhfEgw83N0ytyv6v/d+qwT0zuAZ+MRQ4s86peJ/?= =?us-ascii?Q?uQ+yxXPQB9kBgTQr/nf5aNMt/UgtOAv36ElkRvff6Ls39GMZBecyREhtEkY9?= =?us-ascii?Q?/vUIUH9tij4S45uLDkxY9i5YPAU80jpq1PDE2JTHv1UNyeIuSp749mpgPygJ?= =?us-ascii?Q?bk/2FzoAWqVsXamyMdqBAvfv0YLMj2QfefaDkl21Z4SXda4YIu/B5Tm22yNG?= =?us-ascii?Q?xNUUR0qGmImNBfEaOEqWlzoSTdwWr9ppCKvfYBDN3GAZSgtq8TDABdoDltFJ?= =?us-ascii?Q?fz6CJ7lJ90eux39OuimIV/qw/JxV4VvkLXqeCx4pjJy1kHWhDFPrh3dkaxKZ?= =?us-ascii?Q?OB57CCcumhu8LoJW+zfZWLYwOmmQy386XqNQ9gd/k7j9TP2Ux9aNAOcF48d5?= =?us-ascii?Q?HBAf9F3XA8OacUV5wum7yPlDw+gr4kz5UpQEvFcQXGDPwDFDFcFcQaslUK9y?= =?us-ascii?Q?/UUaHPKVkK1LviS+Aig2acIwC7fj2hP0KmBGoYZcMrCyj2w5u4lZAJ+vA99M?= =?us-ascii?Q?lmjk0dLGTyUqU0HWssuivwjmwrOzyLVGcu7XHlPnzbfDtOvP9IbFPencq5AT?= =?us-ascii?Q?BpiUFhsWG4UW1EGKK41XI/9IpmPNQ8BIWvHyIIVULcai4PuanvU+bMsBxzmp?= =?us-ascii?Q?8ZPtpxg5GVBsULUXq+ARDE51/BSVGjrs2bn51qR8z5aSu2Ujwp06RZgDNhAT?= =?us-ascii?Q?PYhvuD7BpaSEgRUNyMGzr1dvWU5yCAi+ntdmEsIQ6+zoRHZJ1KTF2WLkLq8s?= =?us-ascii?Q?HCHzRHQDmqbNLqG5Et2pesk0DLLXkUep90xBP8vBc1eqZMxoi5eGx5CYPWI4?= =?us-ascii?Q?cHXA29uY8I7j90+0lJKyVwRJcXD+HtQF/9rEsuAl8s57C190dBb6sIH5YPyB?= =?us-ascii?Q?sTxQ7I+09cfZPNSGf8dgT0k663Z2LcSPW8q24wxlYihTQAj732thQ4GDRWlH?= =?us-ascii?Q?3xcBLUA4QDNLcZt/E34tgZstki4satn4uZ3bRMJb+t8fnbIHjj9v?= X-OriginatorOrg: bp.renesas.com X-MS-Exchange-CrossTenant-Network-Message-Id: bde37978-b54c-4549-74d2-08de478fda47 X-MS-Exchange-CrossTenant-AuthSource: TYCPR01MB11947.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Dec 2025 10:40:30.4524 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kjYKxDodEEQTc+28yvCQNcaRV4G1fBT8lHitVxprhabrWtwX+ifLJPX/3UXJq4RCe3Ky2kbJmsQHsws8N31lFJXQODO5ZgR87mOpXO81pkH4eiMH8LXR35x+zLyZ0jn5 X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY7PR01MB13563 Content-Type: text/plain; charset="utf-8" Move the hardware initialization sequence in renesas_i3c_bus_init() into a dedicated renesas_i3c_hw_init() helper. This simplifies the code, and prepares the driver for upcoming suspend/resume support. No functional change intended. Signed-off-by: Tommaso Merciai Reviewed-by: Frank Li --- v1->v2: - New patch. drivers/i3c/master/renesas-i3c.c | 99 ++++++++++++++++++-------------- 1 file changed, 55 insertions(+), 44 deletions(-) diff --git a/drivers/i3c/master/renesas-i3c.c b/drivers/i3c/master/renesas-= i3c.c index 2736363c9074..4f076c372b36 100644 --- a/drivers/i3c/master/renesas-i3c.c +++ b/drivers/i3c/master/renesas-i3c.c @@ -485,13 +485,65 @@ static int renesas_i3c_reset(struct renesas_i3c *i3c) 0, 1000, false, i3c->regs, RSTCTL); } =20 +static void renesas_i3c_hw_init(struct renesas_i3c *i3c) +{ + u32 val; + + /* Disable Slave Mode */ + renesas_writel(i3c->regs, SVCTL, 0); + + /* Initialize Queue/Buffer threshold */ + renesas_writel(i3c->regs, NQTHCTL, NQTHCTL_IBIDSSZ(6) | + NQTHCTL_CMDQTH(1)); + + /* The only supported configuration is two entries*/ + renesas_writel(i3c->regs, NTBTHCTL0, 0); + /* Interrupt when there is one entry in the queue */ + renesas_writel(i3c->regs, NRQTHCTL, 0); + + /* Enable all Bus/Transfer Status Flags */ + renesas_writel(i3c->regs, BSTE, BSTE_ALL_FLAG); + renesas_writel(i3c->regs, NTSTE, NTSTE_ALL_FLAG); + + /* Interrupt enable settings */ + renesas_writel(i3c->regs, BIE, BIE_NACKDIE | BIE_TENDIE); + renesas_writel(i3c->regs, NTIE, 0); + + /* Clear Status register */ + renesas_writel(i3c->regs, NTST, 0); + renesas_writel(i3c->regs, INST, 0); + renesas_writel(i3c->regs, BST, 0); + + /* Hot-Join Acknowlege setting. */ + renesas_set_bit(i3c->regs, BCTL, BCTL_HJACKCTL); + + renesas_writel(i3c->regs, IBINCTL, IBINCTL_NRHJCTL | IBINCTL_NRMRCTL | + IBINCTL_NRSIRCTL); + + renesas_writel(i3c->regs, SCSTLCTL, 0); + renesas_set_bit(i3c->regs, SCSTRCTL, SCSTRCTL_ACKTWE); + + /* Bus condition timing */ + val =3D DIV_ROUND_UP(I3C_BUS_TBUF_MIXED_FM_MIN_NS, + NSEC_PER_SEC / i3c->rate); + renesas_writel(i3c->regs, BFRECDT, BFRECDT_FRECYC(val)); + + val =3D DIV_ROUND_UP(I3C_BUS_TAVAL_MIN_NS, + NSEC_PER_SEC / i3c->rate); + renesas_writel(i3c->regs, BAVLCDT, BAVLCDT_AVLCYC(val)); + + val =3D DIV_ROUND_UP(I3C_BUS_TIDLE_MIN_NS, + NSEC_PER_SEC / i3c->rate); + renesas_writel(i3c->regs, BIDLCDT, BIDLCDT_IDLCYC(val)); +} + static int renesas_i3c_bus_init(struct i3c_master_controller *m) { struct renesas_i3c *i3c =3D to_renesas_i3c(m); struct i3c_bus *bus =3D i3c_master_get_bus(m); struct i3c_device_info info =3D {}; struct i2c_timings t; - u32 double_SBR, val; + u32 double_SBR; int cks, pp_high_ticks, pp_low_ticks, i3c_total_ticks; int od_high_ticks, od_low_ticks, i2c_total_ticks; int ret; @@ -564,49 +616,8 @@ static int renesas_i3c_bus_init(struct i3c_master_cont= roller *m) =20 renesas_writel(i3c->regs, REFCKCTL, REFCKCTL_IREFCKS(cks)); =20 - /* Disable Slave Mode */ - renesas_writel(i3c->regs, SVCTL, 0); - - /* Initialize Queue/Buffer threshold */ - renesas_writel(i3c->regs, NQTHCTL, NQTHCTL_IBIDSSZ(6) | - NQTHCTL_CMDQTH(1)); - - /* The only supported configuration is two entries*/ - renesas_writel(i3c->regs, NTBTHCTL0, 0); - /* Interrupt when there is one entry in the queue */ - renesas_writel(i3c->regs, NRQTHCTL, 0); - - /* Enable all Bus/Transfer Status Flags */ - renesas_writel(i3c->regs, BSTE, BSTE_ALL_FLAG); - renesas_writel(i3c->regs, NTSTE, NTSTE_ALL_FLAG); - - /* Interrupt enable settings */ - renesas_writel(i3c->regs, BIE, BIE_NACKDIE | BIE_TENDIE); - renesas_writel(i3c->regs, NTIE, 0); - - /* Clear Status register */ - renesas_writel(i3c->regs, NTST, 0); - renesas_writel(i3c->regs, INST, 0); - renesas_writel(i3c->regs, BST, 0); - - /* Hot-Join Acknowlege setting. */ - renesas_set_bit(i3c->regs, BCTL, BCTL_HJACKCTL); - - renesas_writel(i3c->regs, IBINCTL, IBINCTL_NRHJCTL | IBINCTL_NRMRCTL | - IBINCTL_NRSIRCTL); - - renesas_writel(i3c->regs, SCSTLCTL, 0); - renesas_set_bit(i3c->regs, SCSTRCTL, SCSTRCTL_ACKTWE); - - /* Bus condition timing */ - val =3D DIV_ROUND_UP(I3C_BUS_TBUF_MIXED_FM_MIN_NS, NSEC_PER_SEC / i3c->ra= te); - renesas_writel(i3c->regs, BFRECDT, BFRECDT_FRECYC(val)); - - val =3D DIV_ROUND_UP(I3C_BUS_TAVAL_MIN_NS, NSEC_PER_SEC / i3c->rate); - renesas_writel(i3c->regs, BAVLCDT, BAVLCDT_AVLCYC(val)); - - val =3D DIV_ROUND_UP(I3C_BUS_TIDLE_MIN_NS, NSEC_PER_SEC / i3c->rate); - renesas_writel(i3c->regs, BIDLCDT, BIDLCDT_IDLCYC(val)); + /* I3C hw init*/ + renesas_i3c_hw_init(i3c); =20 ret =3D i3c_master_get_free_addr(m, 0); if (ret < 0) --=20 2.43.0 From nobody Sun Feb 8 16:36:03 2026 Received: from OS0P286CU011.outbound.protection.outlook.com (mail-japanwestazon11010023.outbound.protection.outlook.com [52.101.228.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A36E92E0B71; Tue, 30 Dec 2025 10:40:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.228.23 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767091240; cv=fail; b=elxXjYMqXHkq8SQj0Io5J3cz/KRPqgOZR61a195JoKnINOslUzdGV6s2bZWez5jSxpdinujlEhzNy24bK6kf7R/0I2Ny20c1vwgjXz9AiHONWLhm/6NVpZ2zezdhokAmUF7P8Sh+hueALRePYnbhdUy7wmVvxqL95Q21y01R9Vs= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767091240; c=relaxed/simple; bh=TYNF2ZkKj1EN04v1j5ZvXJbA2vneUZlbaC7qGgLqFUw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=upLRLWZrupjRmQkaIcvHODMt7CzK95bFiLovTu/HZSNO5CLdMWQLCnYfJnOUPkX7ZPNoVF4qcrMxkDgzeY7LFh+DeYTG4+OjTez8jgOIA6fruPJJOdJjlxAj5cppSoeFfGgdUax+2pSNyy6uiOQsFJCoIVx+kZrHCkczAn34MBc= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=bp.renesas.com; spf=pass smtp.mailfrom=bp.renesas.com; dkim=pass (1024-bit key) header.d=bp.renesas.com header.i=@bp.renesas.com header.b=sygKQla3; arc=fail smtp.client-ip=52.101.228.23 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=bp.renesas.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bp.renesas.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=bp.renesas.com header.i=@bp.renesas.com header.b="sygKQla3" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=MHwXH2gvTTdnqqNBQ5EKdOmhxuKaU+FItWPan9AYBNVnj73Hw+tUA2eEzuLlQdvx4iTwQkRLwhb3J9PIhahv/tLK/PnwgMACYEbs8QygBinD9vrYf3KiYBwwXPPhqJKiXOk2tbfC9foo0eYb0VhVtgZufCuBcR6QJ0wEs2+lwN+Yx/KLA6J/A+FEoI60Yc/0vyEJJw7IIZdMmTftZPHPg6kyyLHRe8Aj3ya9qLJ6GP5zD+PowZ1M6VqTHwmHgjrXVj+KXl8h+hrBvrodLds9ypvWJX5rcJ8PjRgZCRY82qGq/w8xXqZWfoRPJKizXyz0CBHboe/qPGvzNspyHb2xiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QpzxI7cdHTF5LAbjfEdG+qEnFHXHvMFvvcgPuJ5Zzz0=; b=tR+bMIpiNupZmYqnPTsjbWWKi0jWJ+Tzfaui1sA2uIuSP8jwH4kwfsIDETs8sfcKDgVKnZZ0BcfKfm1VfcQMNJTOZGneZtRRG4lo0WdztqncSp/qhIbiPZx5rGy0V8zQRN0W8oKDWIcaquQHb0tJ91PFhP+j5FTWaWbkxjKH/OcfS7XlTP9BRgvxow+RI8iLScG0vTC9u12kyC5teOSL6MoOykPo7gBdWgtEu9cPbg6ZWkymJ9N+nHLwIqI51uRvgKx0Q/BP6KlmsUX6kN3adEhiMsNL4dKwC4iuxzja/tbhx/Lp3vVzRzGKuhoulFsTa5SLd9uapjRM39IclcoEJw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=bp.renesas.com; dmarc=pass action=none header.from=bp.renesas.com; dkim=pass header.d=bp.renesas.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bp.renesas.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QpzxI7cdHTF5LAbjfEdG+qEnFHXHvMFvvcgPuJ5Zzz0=; b=sygKQla39D5N3uqMtDBYw8e3e+m/LsRNS+JNGXyfZf1f87fTeetMWcLvS7z+UHJNCntE/QKGOfDFIEf28xe1Fi/Mb1FN4CtpphXaoEc6sTpg7hU4oqhPnTEj2fY+mz9pWglpHGTCvGWeC3RuKkBr5kh2XGtIjohTBlh2txsh+VI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=bp.renesas.com; Received: from TYCPR01MB11947.jpnprd01.prod.outlook.com (2603:1096:400:3e1::6) by OS9PR01MB16048.jpnprd01.prod.outlook.com (2603:1096:604:3db::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9478.4; Tue, 30 Dec 2025 10:40:34 +0000 Received: from TYCPR01MB11947.jpnprd01.prod.outlook.com ([fe80::33f1:f7cd:46be:e4d8]) by TYCPR01MB11947.jpnprd01.prod.outlook.com ([fe80::33f1:f7cd:46be:e4d8%5]) with mapi id 15.20.9478.004; Tue, 30 Dec 2025 10:40:34 +0000 From: Tommaso Merciai To: tomm.merciai@gmail.com Cc: linux-renesas-soc@vger.kernel.org, biju.das.jz@bp.renesas.com, Tommaso Merciai , Wolfram Sang , Alexandre Belloni , Frank Li , Philipp Zabel , linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 4/4] i3c: renesas: Add suspend/resume support Date: Tue, 30 Dec 2025 11:39:39 +0100 Message-ID: <8cba44d24d436bf11477c7f2b91de3c32dfe1809.1767090535.git.tommaso.merciai.xr@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FR0P281CA0056.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::6) To TYCPR01MB11947.jpnprd01.prod.outlook.com (2603:1096:400:3e1::6) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: TYCPR01MB11947:EE_|OS9PR01MB16048:EE_ X-MS-Office365-Filtering-Correlation-Id: 0ddc951b-4524-4922-5646-08de478fdcd6 X-LD-Processed: 53d82571-da19-47e4-9cb4-625a166a4a2a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|52116014|376014|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?Ju7P3HTbvrgrsEqdglZ7f5v40K7+SH4dAfYr4t8VVfTJ0C1/rvUg5k60AOhi?= =?us-ascii?Q?Cl0XDX/bnZte/wzD2GQn5kHQIYoPfyv/XRQtizkR17gyWKcfT0+PU0ZvCrR0?= =?us-ascii?Q?M565JKLx8msc/ZArPy2KuaCfJoataXoo9vDv4sgKIlnNiWQWa92ktel61A3M?= =?us-ascii?Q?CiiDSRenpX6Q7pl6vHuNsuXe/gRg4L/wkZEM7Qk7/tDo0n73e/nvlbyFNasP?= =?us-ascii?Q?gTgW3k7dC2j8yuDppyoxjJRNJ+fo4MTak4/LqpnyZQHc7HpXbBSfB2PuLLDt?= =?us-ascii?Q?n1/VISMpqvUg0Lkpwca3FnqZJH0610xyNRKJVe4i5lmgi1vkeTHj8wSeQVNV?= =?us-ascii?Q?WwkXeoNKxSuhbvPpsjd0pVJGyhSr4wro+DGKZMTj7FoFZnYIAnrHN+2HNLNW?= =?us-ascii?Q?q3wtgO7/XPqoXPolbkvOGOqEf5V9yEIGifVwZxvxsgLgUVmvv/mRmmvCHFMH?= =?us-ascii?Q?rUJg6SxMzYtLUQRrX+/IlERpXzPvkMSSmW36JFCQ+zH9i/lELY3IlO4aCmpu?= =?us-ascii?Q?QmOK8lqjTfRUgtMvfIKKdisNQicaqd6Zk0vePAt/3N5W1AQ/5UfZP7z146we?= =?us-ascii?Q?GKA2zXXhsO7xa/Uk/CyxIIT2grRroFgSz5Ov+35z97Sg9be6z/dCusPSaTot?= =?us-ascii?Q?Uv+DMGNyCAmQtkNKt63wr6L5WtppKEEo8PI3AMFAXeXCTpQIL1NpNkk1Eyd2?= =?us-ascii?Q?GtBcUkaFa1vO3CEYjRwPyAAV8KUOfZpDri7rjscEjX4ltxkMX7RU9P5AaIrJ?= =?us-ascii?Q?UVmaruNqtb7ydZ+C0pvFOP+3CsEdWMBotMmScl2AkZpscRZHWZrvSoD7fn3k?= =?us-ascii?Q?uQsSiBpxrwi5HeESbmEgirvYmGblpjVwjq7Onzxw1KwIkJxB52q/VSKpYTjz?= =?us-ascii?Q?5C5exY9UPBlBF4q4q7Kmb0A8ZIjeT0P7h5dH2jIePLWaCXHmWCILwsI1uX/t?= =?us-ascii?Q?Vxr0gW4/kGnTVOoDucBaanc6UbVIx1FRWW9Ls7chCQjh31m/G0LLZi7alhoY?= =?us-ascii?Q?v9ud55Eq4eDf2Tj4RijW/6YkUtjpwvL9xmRLiJvTTxU2D98pi6xMGECamrAR?= =?us-ascii?Q?ybnpBoBuygrZof8F2CbYK7l1jEnvyNJjLY9KRX/i8mpzyKeHWVO02NXIOkuN?= =?us-ascii?Q?ZTMl1ce1xbLVfLXrP/CCVCHGuE+ya1G6EveVpAk+keaL+GN3HIs7Xmx2BDn3?= =?us-ascii?Q?i+YSkrDGhjdelPt1FPBDG60qRyZdOtOALAdk1Cu2wVS3dIHZoU6QhYGH4C0a?= =?us-ascii?Q?W3uz7CAfym+KzbzrekhhYL3ZhGhBQQCNkV6SKTEV42iL82VLC/74bJlK1ZHT?= =?us-ascii?Q?JTjT6lu+MPUHzHzuqlujzT6jJ4XLhRAMK1cw4DKIbt8Lj176gjGgTTmI9Rms?= =?us-ascii?Q?Gzf+fHSAJpmqa+Xo0RlbmBpMl7v3dDM8Kzz1YNwa7Gexd0fZ5JhCUe7RnSOe?= =?us-ascii?Q?5ZoKDmWyljc1rq3ch3Svi7SybJCTRitbV2nG4Sg7HBsPZc3NJjiLdbkPCkJP?= =?us-ascii?Q?y+m2GTyUUz0OfGeyENVLpK+aH6BYv35sZyM/?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TYCPR01MB11947.jpnprd01.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(52116014)(376014)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?H6lTgOOn8PZjUjRk8Dq2AwUBK061yB5FUolUeIEs0sSdUTwmUVsE2BCpb7jz?= =?us-ascii?Q?QzntiILY3GRWY9MhwzpXT8f3KBLAHJaL5NeSG118ltkoOirq/wcZ89tR8GBU?= =?us-ascii?Q?n+lhaLm2Ll3i5o/FqmDKeGkcju8Hr86zTVx0N+mHWO8cKLfb/3yo1XeDkR6h?= =?us-ascii?Q?BjdOScsipg5Dh/MHDY+jn3XWAZ3NEqnqFT5+iMFB5kvhvOlgjhd2VIrmQegx?= =?us-ascii?Q?shIWB5IMq1K2rfRQksV86Xto/flaW5Kv4Ml7xjRwuq6YjVYLSpeY6Kp/z5cx?= =?us-ascii?Q?bHjcbZ3KokC4NnGhI2sAU9r1LMCThXGtcKORdvKggkfqNO+nD5fo/hBAZCtr?= =?us-ascii?Q?+auWJz4T8oTeMLD88m3pAv9v3rMhQIJPyDQ0RXozoNg+Mx0a2H142xpIwzp/?= =?us-ascii?Q?Cglo1HGeIrbgt3qtTB3TxNkUpwC+chbO6xOMvcvUz2B8D2q8sLVscQQDgBpW?= =?us-ascii?Q?rB8alVC6dluLfATdI2x4LPUtb8nnkWjSFZIiyzanr/BYIV8E3Kw8SxnQYjk2?= =?us-ascii?Q?f5QkKNql1goN0POIAXagEzBdkeQLZdZC/X3bTCu/Zg/NQPnoN1hFJVIRDkR9?= =?us-ascii?Q?uaRpJOixaFwEKMOhz2anNujGjAfskbStTpMPfRk3x90VNrmYRslXLvY31KRV?= =?us-ascii?Q?rSaZoTlo4dIJpXgWDjbxzz0B+Hh2/HD+ntqGWCsa/uVjgCZQWWSPOO6hnuys?= =?us-ascii?Q?gqSfsSClgtRt7GcCLoFLJzyvYWT42Fcj+qIrlHU+zlfZV4WPmIWtrbG1JZRn?= =?us-ascii?Q?BT5dfFglouqNYg2Iznhm6tvHsQTV/F8XKBaLtmH6zSXeoRESOPxjeW/TqFJ1?= =?us-ascii?Q?SNzaHOPSKy/Z5+ww/ZoJ57dJR5AuGzA/dl3DWABmyv3RqOCwvMg2I3Y04qp5?= =?us-ascii?Q?MPiBlwdBLoVGBXDlnGCtN53EWrSXWUWJOJOs4/y519MxdJkhFDtfD5ACmxeA?= =?us-ascii?Q?6Lx26hsomisC4SvViIGgbqiN3nnNi4Ft6rGW0X/BREL5x1Os0663sxa1elTb?= =?us-ascii?Q?I90X0Qk6tLhpxHkWEF0Ljb3gKsrn7Zj8lLuMPMwE0QR8H7V8QWLdjoIOt/4y?= =?us-ascii?Q?50l+Gu/Sl7kWrttOHZzPHHGqNRmq3jX8KPsX3gfx8fwixUdkw8F3nZksylYa?= =?us-ascii?Q?bV2Eni+irjTmW/21VZjYIqS/A6sNKIKn0WhQrOyrVodDPlk0GVYRz49WNzG/?= =?us-ascii?Q?MFMj+Wn95/jTb5q9aUsnqbE+D0bNhHcfGoo++iZCo/31kdRHQyn/IeTUTupn?= =?us-ascii?Q?ogRLPhiVLEczyo0pb91mTz41ut92bi0ZMc9NzQ89gvqxjjZwlKWTh6iB2T8d?= =?us-ascii?Q?lZ/I7vO85FrVh8i9bdxpVMK9JyQIJjySvAc0bdMIDhTTCjTbdabW6c5WjFiu?= =?us-ascii?Q?Z4K3ICsQbnXfZJUJkPE1sLYRFtXHYl+v59B+QUiCwaSHr7WjybfCAFPe4xNX?= =?us-ascii?Q?+hJAP+b1KuIPA38vAwb6mrLXzxT0JpkHWtZpiWc8ykRtnsbgTfYIIBXWyfrj?= =?us-ascii?Q?mMCzZqqLmSORLYoIAfxTrkLqbCXL1pBwR2ah0N5a4CwxUWL+KD/x9TVm0rqx?= =?us-ascii?Q?GWYXTVa83kktCYeROIbQkOXLNIDK035vjfMp+EAcis1rvdUKi/pHKU2gbkN6?= =?us-ascii?Q?HQyu2x5cO8HJserrh7b98bRRyUUax0YLs5uvI7gt1kC9rIJ3NPDt3SkQ+hMF?= =?us-ascii?Q?z+IXC3tl4OGCHQ3Obin/MrXbMf2k1piPgVLrOdZ+wB8EbVrJ+XAjAQXYGCEr?= =?us-ascii?Q?oQcIHmUZoXo99rSYt+k73b/FgLUsI2bK09wVE22Mz+Xxf02PT8QI?= X-OriginatorOrg: bp.renesas.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0ddc951b-4524-4922-5646-08de478fdcd6 X-MS-Exchange-CrossTenant-AuthSource: TYCPR01MB11947.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Dec 2025 10:40:34.4993 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: N8cDmPmmi0fow1jPJVaqGTBwZ7umpuWdZWWpqGN+fHbEgb3YrsYAmPu/AgO0hA+QGzCo8k/UFmG2vqJjeZboTJ2364MwXuOuC992fi+BsgLXDKg0hVyRw4Zclk8vmAzS X-MS-Exchange-Transport-CrossTenantHeadersStamped: OS9PR01MB16048 Content-Type: text/plain; charset="utf-8" The Renesas I3C controller does not retain its register state across system suspend, requiring the driver to explicitly save and restore hardware configuration. Add suspend and resume NOIRQ callbacks to handle system sleep transitions. During suspend, save the Device Address Table (DAT) entries, assert reset lines, and disable all related clocks to allow the controller to enter a low-power state. On resume, re-enable clocks and reset lines in the proper order. Restore the REFCKCTL register, master dynamic address, and all DAT entries, then reinitialize the controller. Store the REFCLK divider value, and the master dynamic address to restore timing and addressing configuration after resume. Signed-off-by: Tommaso Merciai --- v1->v2: - Updated commit as v1 has been split into smaller patches. - Use clock bulk API into renesas_i3c_suspend_noirq() and renesas_i3c_resume_noirq(). - Updated commit body accordingly. drivers/i3c/master/renesas-i3c.c | 85 ++++++++++++++++++++++++++++++++ 1 file changed, 85 insertions(+) diff --git a/drivers/i3c/master/renesas-i3c.c b/drivers/i3c/master/renesas-= i3c.c index 4f076c372b36..f089bbf19fa5 100644 --- a/drivers/i3c/master/renesas-i3c.c +++ b/drivers/i3c/master/renesas-i3c.c @@ -254,16 +254,19 @@ struct renesas_i3c { enum i3c_internal_state internal_state; u16 maxdevs; u32 free_pos; + u32 dyn_addr; u32 i2c_STDBR; u32 i3c_STDBR; unsigned long rate; u8 addrs[RENESAS_I3C_MAX_DEVS]; struct renesas_i3c_xferqueue xferqueue; void __iomem *regs; + u32 *DATBASn; struct clk_bulk_data clks[3]; u8 num_clks; struct reset_control *presetn; struct reset_control *tresetn; + u8 refclk_div; }; =20 struct renesas_i3c_i2c_dev_data { @@ -615,6 +618,7 @@ static int renesas_i3c_bus_init(struct i3c_master_contr= oller *m) EXTBR_EBRHP(pp_high_ticks)); =20 renesas_writel(i3c->regs, REFCKCTL, REFCKCTL_IREFCKS(cks)); + i3c->refclk_div =3D cks; =20 /* I3C hw init*/ renesas_i3c_hw_init(i3c); @@ -623,6 +627,7 @@ static int renesas_i3c_bus_init(struct i3c_master_contr= oller *m) if (ret < 0) return ret; =20 + i3c->dyn_addr =3D ret; renesas_writel(i3c->regs, MSDVAD, MSDVAD_MDYAD(ret) | MSDVAD_MDYADV); =20 memset(&info, 0, sizeof(info)); @@ -1390,6 +1395,13 @@ static int renesas_i3c_probe(struct platform_device = *pdev) i3c->maxdevs =3D RENESAS_I3C_MAX_DEVS; i3c->free_pos =3D GENMASK(i3c->maxdevs - 1, 0); =20 + /* Allocate dynamic Device Address Table backup. */ + i3c->DATBASn =3D devm_kzalloc(&pdev->dev, + sizeof(u32) * i3c->maxdevs, + GFP_KERNEL); + if (!i3c->DATBASn) + return -ENOMEM; + return i3c_master_register(&i3c->base, &pdev->dev, &renesas_i3c_ops, fals= e); } =20 @@ -1400,6 +1412,78 @@ static void renesas_i3c_remove(struct platform_devic= e *pdev) i3c_master_unregister(&i3c->base); } =20 +static int renesas_i3c_suspend_noirq(struct device *dev) +{ + struct renesas_i3c *i3c =3D dev_get_drvdata(dev); + int i, ret; + + i2c_mark_adapter_suspended(&i3c->base.i2c); + + /* Store Device Address Table values. */ + for (i =3D 0; i < i3c->maxdevs; i++) + i3c->DATBASn[i] =3D renesas_readl(i3c->regs, DATBAS(i)); + + ret =3D reset_control_assert(i3c->presetn); + if (ret) + return ret; + + ret =3D reset_control_assert(i3c->tresetn); + if (ret) { + reset_control_deassert(i3c->presetn); + return ret; + } + + clk_bulk_disable_unprepare(i3c->num_clks, i3c->clks); + + return 0; +} + +static int renesas_i3c_resume_noirq(struct device *dev) +{ + struct renesas_i3c *i3c =3D dev_get_drvdata(dev); + int i, ret; + + ret =3D reset_control_deassert(i3c->presetn); + if (ret) + return ret; + + ret =3D reset_control_deassert(i3c->tresetn); + if (ret) + goto err_presetn; + + ret =3D clk_bulk_prepare_enable(i3c->num_clks, i3c->clks); + if (ret) + goto err_tresetn; + + /* Re-store I3C registers value. */ + renesas_writel(i3c->regs, REFCKCTL, + REFCKCTL_IREFCKS(i3c->refclk_div)); + renesas_writel(i3c->regs, MSDVAD, MSDVAD_MDYADV | + MSDVAD_MDYAD(i3c->dyn_addr)); + + /* Restore Device Address Table values. */ + for (i =3D 0; i < i3c->maxdevs; i++) + renesas_writel(i3c->regs, DATBAS(i), i3c->DATBASn[i]); + + /* I3C hw init. */ + renesas_i3c_hw_init(i3c); + + i2c_mark_adapter_resumed(&i3c->base.i2c); + + return 0; + +err_tresetn: + clk_bulk_disable_unprepare(i3c->num_clks, i3c->clks); +err_presetn: + reset_control_assert(i3c->presetn); + return ret; +} + +static const struct dev_pm_ops renesas_i3c_pm_ops =3D { + NOIRQ_SYSTEM_SLEEP_PM_OPS(renesas_i3c_suspend_noirq, + renesas_i3c_resume_noirq) +}; + static const struct renesas_i3c_config empty_i3c_config =3D { }; =20 @@ -1420,6 +1504,7 @@ static struct platform_driver renesas_i3c =3D { .driver =3D { .name =3D "renesas-i3c", .of_match_table =3D renesas_i3c_of_ids, + .pm =3D pm_sleep_ptr(&renesas_i3c_pm_ops), }, }; module_platform_driver(renesas_i3c); --=20 2.43.0