From nobody Wed Dec 17 03:59:53 2025 Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 236CA299AA3 for ; Mon, 15 Dec 2025 14:17:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765808264; cv=none; b=I438TmN/GznJ/wSHzCIWrvi5Tpvn1Z5Ah5v83WQqj+yuKfoWaQFGlKND5WGPMKsJDYBDwhdls7Yzj2poAVCGg7hglK1NYBoTD4TS/wAwJ+q0U8DuLH6m8BfuDYv8On3t8NIbDq4ir35DwfJTz9CQtOrDfszQrFrt4JVUiDkT/o8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765808264; c=relaxed/simple; bh=xC2ltYeeueP5vlvmDoWPRSRk09PJusQKgFR+Yv8ms48=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=j9ItLUuiTBXAqz6t3IXASyr4UApf83pntWoZ6X/03q6VgKRfsNFfn44dkebHabju9fIkzWPuWgcuBO1PWz/fFF0iXvMDrNFb6bNerP3YpExSzkIZ0YDB9z7gVKKgX2adrK8fkWHvtnsKBB9vXxZlWPWOdkgaGBf4Qqam1BKTMVg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=ss+QJ3WE; arc=none smtp.client-ip=209.85.218.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="ss+QJ3WE" Received: by mail-ej1-f47.google.com with SMTP id a640c23a62f3a-b7bd8b170e0so399121666b.3 for ; Mon, 15 Dec 2025 06:17:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1765808257; x=1766413057; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TKLIW1Otm/CvIibORJ3xOD9U+OAfBBsE0DeO8Ciovak=; b=ss+QJ3WEYwn9hvtPHSUjb1AE2ohb4MfOD6mZ9V2gZdJzMIq4/9jLoNcDw50ufufZan m/1RwniFfNiHgBcMrcxjsWl19WN8nI3Yej918G3LOgT/AN5Mf+4o46P+qAd0DQR2Ysnc ACnF+TgMux2xF42iglvECzi6TlVvlPCvp1BlsNXk3W77uSP+CYhgtVFmJepVDTXvKbOu xIJkNMS01aSMuUeQt4wuja90vkanSZmKt19Bcb5graoo4e0d7w90YIWqpIypk+BgjeDR dwF/hY9YLG5PYbtwyMCU8vYOGZfR0XzsrpuwEleepZXGEApZbfgirRR9IPVhZW3OoVHH uBEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765808257; x=1766413057; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=TKLIW1Otm/CvIibORJ3xOD9U+OAfBBsE0DeO8Ciovak=; b=laAEENlHUiq/MlyE/wUiErW8iR56X3ckhHL0YMCd5e9VZLE+SKi/wS+z1yH3EkoK7m L0jSPwmblCQFhNanG83lQ4qpUtyBNSJft6TeyCym0OG5+xTK8tsANeAcEr9RH2mc3Glh 551jvXmNVmpwQ1U4iXQlZM6f+nwT2qoR5wOWjs8jnBJsSAgvXwp4EJoB1kYNvMAsjBMC lONixDohejmKBmwGv6Z8quIzKY94SE9PNPAxpg9tC3hUmHnsDBORoso9EGO89sIY/ozz M9UuR+lWfQrfnSAqnkEvGqON0Q+oxc8E16SnRUlUHvANDwbEldQ9ePF3lWs8lh/wcp0i VmAg== X-Forwarded-Encrypted: i=1; AJvYcCU9zZHrFIw4L3acXXemvPIZ1mzmbDQklictrj5B2jJ1dt8ew0CYh1jihsAHBJgBftKTf398bImM9+/je8w=@vger.kernel.org X-Gm-Message-State: AOJu0YyWlDqhkUfk2VhCRQZ9WGTsJz5UezosPdrYZRh8VDboFtSFubKD wj1068DwYvPyndIoYQBTmFYH89O9cQv/0DlJVF+qlewrpUEuaAdNkb5DmH2GmjQBf5rxkXS/MTu CUz+0 X-Gm-Gg: AY/fxX7A7+xJYXmDE8fvhhAxyT1XPFC12WFooQwG+4bNEMpJBdfB8rWxVgJ301Q9Ace 2QFo+vOkQTmw67hSVV6+qR8E/CHFp+cOp5jbGv2jwQf9o8r/8ftBuVGCod6ISZXVxdFgwrsztjm SIpUTNnzdKUoq/gep5pY7XtzpexazIUlrVQZ10qE6ODqhUo6SeCcCPEkMxLnQOx+oytA/kOBHFG dblfgTGupfe6Zi1MJQeR8omhVmM2+E3mFh8rXJGw426tQNbEkS1sg0fTPyYy5BObqI6+uvJUQ7M XHXP5H4CostOsr/MYGta4J6C/ClpS6R/z09N9xtnFSxdkFOHTXgHaepQsMlg3/rRQAkZekn52Hh qtqhHA+AvU+XsP7ysTT3xdPcVVi4lxqHBKREPxFFP4JXo8/84fn1zbQJxUFcL10lRb8nCVtA7Wi x7GP0uVz/kOoNDgFHtIdaxbyJKWhm7V9XOvSPJy3g0w1n2Rhw51Mtb2BrBNg== X-Google-Smtp-Source: AGHT+IGnIW9OB19xF3q3JCaHg3DeUHqEK/cfaz7GtvANmTVQUUPZGevLylhKSJajUN3cRj/4ocKrGg== X-Received: by 2002:a17:907:7f29:b0:b76:da45:e3d6 with SMTP id a640c23a62f3a-b7d2361d3b5mr1127857966b.16.1765808256517; Mon, 15 Dec 2025 06:17:36 -0800 (PST) Received: from localhost (ip-046-005-122-062.um12.pools.vodafone-ip.de. [46.5.122.62]) by smtp.gmail.com with UTF8SMTPSA id a640c23a62f3a-b7cfa2eb9c6sm1427881866b.20.2025.12.15.06.17.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Dec 2025 06:17:36 -0800 (PST) From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Jens Wiklander Cc: Sumit Garg , op-tee@lists.trustedfirmware.org, linux-kernel@vger.kernel.org, Sumit Garg Subject: [PATCH v2 01/17] tee: Add some helpers to reduce boilerplate for tee client drivers Date: Mon, 15 Dec 2025 15:16:31 +0100 Message-ID: <563931b951a69d579fa9a00134b09354c346789e.1765791463.git.u.kleine-koenig@baylibre.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=2024; i=u.kleine-koenig@baylibre.com; h=from:subject:message-id; bh=xC2ltYeeueP5vlvmDoWPRSRk09PJusQKgFR+Yv8ms48=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBpQBhOzSbait71TPEiQwqVv/v5kQMZpHFWXZ8Ps k02jYgJGruJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCaUAYTgAKCRCPgPtYfRL+ TuA/B/91zsgbTlCB7AYsgezO8lNhWEqaKK+g6H4HGG/FHRWFJvHBuk4oEa++o0ppXtSFIhcrpLu X+oc2qjhsVTOj4eut2/IV2ryLVx+oYslFdhfwC6OgNY/46OzseFbHS6Hwxd/+X8SaB3y79Bq0mX jrK7V9egowQMft8t3TAN3lnrFq089sC3DSXFQto1+CNaw/RS3FXJ4MgVNUNY3jhu9ahxkB823Xh m7fplwCrqnwJ4UZi/5ZOUYQBLxxlhiHWvwycF3PEBZSn4F3oIfaDQumyGnbxf88klKXlhxl74c6 jkO8jPGoTfvRCKtX6KfA5rR5RiOU7uLq4JKcZt9CFKOhnMn4 X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable Similar to platform drivers (and others) create dedicated register and unregister functions and a macro to simplify modules that only need to handle driver registration in their init and exit handlers. Reviewed-by: Sumit Garg Signed-off-by: Uwe Kleine-K=C3=B6nig --- drivers/tee/tee_core.c | 16 ++++++++++++++++ include/linux/tee_drv.h | 9 +++++++++ 2 files changed, 25 insertions(+) diff --git a/drivers/tee/tee_core.c b/drivers/tee/tee_core.c index d65d47cc154e..51379f7fc5d5 100644 --- a/drivers/tee/tee_core.c +++ b/drivers/tee/tee_core.c @@ -1405,6 +1405,22 @@ const struct bus_type tee_bus_type =3D { }; EXPORT_SYMBOL_GPL(tee_bus_type); =20 +int __tee_client_driver_register(struct tee_client_driver *tee_driver, + struct module *owner) +{ + tee_driver->driver.owner =3D owner; + tee_driver->driver.bus =3D &tee_bus_type; + + return driver_register(&tee_driver->driver); +} +EXPORT_SYMBOL_GPL(__tee_client_driver_register); + +void tee_client_driver_unregister(struct tee_client_driver *tee_driver) +{ + driver_unregister(&tee_driver->driver); +} +EXPORT_SYMBOL_GPL(tee_client_driver_unregister); + static int __init tee_init(void) { int rc; diff --git a/include/linux/tee_drv.h b/include/linux/tee_drv.h index 88a6f9697c89..850c03b2cdea 100644 --- a/include/linux/tee_drv.h +++ b/include/linux/tee_drv.h @@ -322,4 +322,13 @@ struct tee_client_driver { #define to_tee_client_driver(d) \ container_of_const(d, struct tee_client_driver, driver) =20 +#define tee_client_driver_register(drv) \ + __tee_client_driver_register(drv, THIS_MODULE) +int __tee_client_driver_register(struct tee_client_driver *, struct module= *); +void tee_client_driver_unregister(struct tee_client_driver *); + +#define module_tee_client_driver(__tee_client_driver) \ + module_driver(__tee_client_driver, tee_client_driver_register, \ + tee_client_driver_unregister) + #endif /*__TEE_DRV_H*/ --=20 2.47.3 From nobody Wed Dec 17 03:59:53 2025 Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 40AE333CEAF for ; Mon, 15 Dec 2025 14:17:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765808264; cv=none; b=diKQx9iXWI+OuFpReAbWJVZOqo/5FwpH9unCW/ZX0JchVUQaKFd+AMOQ+G5GTBH2X52rr/upyQPAm22OhUCJ5/+/T0gE1p4ooLbLqvZAuVQWZKGOG+HuLM3ghAk8g42KltM9KHbxMzSIcrEq8Nnu2G7W6C2pQ7E6qPoJ8eqmXPU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765808264; c=relaxed/simple; bh=qF1IcEKbJFmyVmb3aXHXWHWAtPeq4SU+toAkI6ZHppU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=pPZoLZ1ut6XfD79X8BiCbkyJ3WK3/FERyNWB9rObMb7TtNWA9m20TLNqTN3e6W5MQeRDqwO+lG/aDaOLwyaOsmc4r2GYoyQSNjmEB3tE3hbXE/dbNA+m22CIvBKU2PEtsAjqiAY83uWycHNi3mAizIHZquGyVN8gZz+0ZHfDJSg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=yJpmB5oS; arc=none smtp.client-ip=209.85.218.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="yJpmB5oS" Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-b7355f6ef12so645844966b.3 for ; Mon, 15 Dec 2025 06:17:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1765808258; x=1766413058; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=pYbyn8/EnLRxLtN5kn4exRhzxKPrsMPkbxoYT9sJDCo=; b=yJpmB5oSSFz4K7gtDqWcl1O44InjUkhTvtTcDhHoI6zmb1fQoPUo169r5l2XOI4j1d hpOHlrjROnYuckruoWKYg7uKW8NJrK79Yg4MiMwynXTFFAP1rXuC51tFzhQ7AmQV9T0l AKT8eq2ea6Tl5mJFnc/vyTr77Lf9pxvgWSX7ysVnE0uTLFWArtEPsp0M2hOwG8BEsy9z PRDtcPD+Gps1X9i4n3kuFfR9x9KFFuQYgI0GS5TxKPyo4sSjMz0ofNI7eAXxTWgX09Kb WkAuJCRodIaaVmGn95O+mEFGAzX85onYdnoYjX8WKco//jlxNqD2yNJaRWOT+wv1HJWL 3Oow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765808258; x=1766413058; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=pYbyn8/EnLRxLtN5kn4exRhzxKPrsMPkbxoYT9sJDCo=; b=FEaht0I11azSRHZxfIbm4TD52sgIYNmmeGc6/L2ZrM93Ww9vzBQ4x8FbzEXewUhLOj lovKlsYZ5WcQ9QpXHmzqwx/zQV2fW6bk6FRZXnOb0WW6GD3XcktZWtSs6qJ8pSDL3Ky/ 7GGz4EIs4bxY9MO0eAQeoWGRqiYpkDfFCcHXyTr/bSPOW/08Tu3h2clWtuB8gGYVjYC4 jSM44lygWEKouCA0flIv2vkprtFEC36Dn3f+S14A43yWa6xFsjZ6ErGbBwueMHakwsra Ob2NJMdjVmteD+r70EmGjubmR6z5RF1xjc526PAgZarAyulHeDgKQgg6/WX8Wk7O+odm 9IGw== X-Forwarded-Encrypted: i=1; AJvYcCV44bajcT4Pn8W+GSRawMPzuNd9LNsIpIIkgPENtH182+x1PaKvOkJdFzITq8EXbS882SthHEGFhwkGMoo=@vger.kernel.org X-Gm-Message-State: AOJu0YwPSpyonRZD7nki+wh6MJ4yGMzO0/THC1LbL9g/xRdBkTIVqkI/ dl1NiHrSH/EC+uUP4hqWPqJ1HZ+8AMNaX1dvOn+hKh5ICgJ13xvDzXB8EoKT6Ve4fs8= X-Gm-Gg: AY/fxX7zfJQExVfhOwZNl+wBum8euBIUMypFuWRCoanKJiIt7DsW/GluYredJGbUfZC zIGJbd87q4ia6OMf2eyGPg4XaBGs8ZCZ3M9TJz1Q4+K7WxahPcBp5ufeRtbvK7Vt0ESxReee9MY rWtYkwWp1qSzQR4CROm0M/o5sv3h5nhSKIbrS9JZYAaTRwIKlNuzNFTD9UbXhQmEienqs9ntaA8 VqvKm0t+CBDJ27Uywi1RmX0l8mgxNhocf7b3TfLySJ6ObwJacLf8SB2DKP2pa9sCwuraUPJErPr R/GiVTGoy4NKjEQkJLVIx4cLk8ALmOF56wePsYDtnv3B+AxdMgtEQnh5FGwmT1q21ur9YVfsR49 eBDjaONIW8YsDm9mLmw2PdJ0XtoJLmzars0BIL7gHzYwLa4ROh2VVVM/SBjsgM/hNjysWnplCUP EToxQBpcUKaeabgIpDAH7+DpFvBq/C+BvrX+BzZoud+ND9Jf6JOPnPajNPhg== X-Google-Smtp-Source: AGHT+IH2YAK0HCE3AKMihYwZpmjmWE6HYGsq9gAMwxcv1jzlhc75cjnc7OqoPvVUExhp0Mdl2kklIQ== X-Received: by 2002:a17:907:7f27:b0:b79:c879:fe71 with SMTP id a640c23a62f3a-b7d23a47753mr1098582566b.19.1765808258026; Mon, 15 Dec 2025 06:17:38 -0800 (PST) Received: from localhost (ip-046-005-122-062.um12.pools.vodafone-ip.de. [46.5.122.62]) by smtp.gmail.com with UTF8SMTPSA id a640c23a62f3a-b7cfa29beabsm1433409166b.4.2025.12.15.06.17.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Dec 2025 06:17:37 -0800 (PST) From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Jens Wiklander Cc: Sumit Garg , op-tee@lists.trustedfirmware.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 02/17] tee: Add probe, remove and shutdown bus callbacks to tee_client_driver Date: Mon, 15 Dec 2025 15:16:32 +0100 Message-ID: <667477a172a4296ee060508a5778be7b0d2ca375.1765791463.git.u.kleine-koenig@baylibre.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=4205; i=u.kleine-koenig@baylibre.com; h=from:subject:message-id; bh=qF1IcEKbJFmyVmb3aXHXWHWAtPeq4SU+toAkI6ZHppU=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBpQBhQbqdn/HuaqlN6kLv5W75bm0Ws8yfNZJCnV lmMCiioe2eJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCaUAYUAAKCRCPgPtYfRL+ ThZ4B/0Z1HxbnrrtOrIAoOjKPDeR10PHx55cuFqJa8OlpcOghtKk5foX2Knev9V32xsuzOx1TdP wIT3KfWcT2pi1yhhSDI9W+qeGXYZALUNRgLE/L75wGZ3wD1tzUo70QkfHZI7u+D6yYNe35495FE WJvkfziyIEV7peL8U710+JK4KsEZUNZjg1JJJ/23maTVZ/yU1jaEYc1JlSuVbeQ4NXLh4nMdhPB 0S09YShtrY01kAvtF1Of4uNdeO3S4VuNoGy9QJQoq6mCzLk0wEH8P7H/Vb80OUj3HTICm6FNlUA rEmq2rxB7ct+dtHlCBA3sua5ap4LwbCrX+fS3GFs7LQy5qS1 X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable Introduce a bus specific probe, remove and shutdown function. For now this only allows to get rid of a cast of the generic device to a tee_client device in the drivers and changes the remove prototype to return void---a non-zero return value is ignored anyhow. The objective is to get rid of users of struct device_driver callbacks .probe(), .remove() and .shutdown() to eventually remove these. Until all tee_client drivers are converted this results in a runtime warning about the drivers needing an update because there is a bus probe function and a driver probe function. Signed-off-by: Uwe Kleine-K=C3=B6nig --- drivers/tee/tee_core.c | 68 +++++++++++++++++++++++++++++++++++++++++ include/linux/tee_drv.h | 3 ++ 2 files changed, 71 insertions(+) diff --git a/drivers/tee/tee_core.c b/drivers/tee/tee_core.c index 51379f7fc5d5..a015730664c7 100644 --- a/drivers/tee/tee_core.c +++ b/drivers/tee/tee_core.c @@ -1398,19 +1398,87 @@ static int tee_client_device_uevent(const struct de= vice *dev, return add_uevent_var(env, "MODALIAS=3Dtee:%pUb", dev_id); } =20 +static int tee_client_device_probe(struct device *dev) +{ + struct tee_client_device *tcdev =3D to_tee_client_device(dev); + struct tee_client_driver *drv =3D to_tee_client_driver(dev->driver); + + if (drv->probe) + return drv->probe(tcdev); + else + return 0; +} + +static void tee_client_device_remove(struct device *dev) +{ + struct tee_client_device *tcdev =3D to_tee_client_device(dev); + struct tee_client_driver *drv =3D to_tee_client_driver(dev->driver); + + if (drv->remove) + drv->remove(tcdev); +} + +static void tee_client_device_shutdown(struct device *dev) +{ + struct tee_client_device *tcdev =3D to_tee_client_device(dev); + struct tee_client_driver *drv =3D to_tee_client_driver(dev->driver); + + if (dev->driver && drv->shutdown) + drv->shutdown(tcdev); +} + const struct bus_type tee_bus_type =3D { .name =3D "tee", .match =3D tee_client_device_match, .uevent =3D tee_client_device_uevent, + .probe =3D tee_client_device_probe, + .remove =3D tee_client_device_remove, + .shutdown =3D tee_client_device_shutdown, }; EXPORT_SYMBOL_GPL(tee_bus_type); =20 +static int tee_client_device_probe_legacy(struct tee_client_device *tcdev) +{ + struct device *dev =3D &tcdev->dev; + struct device_driver *driver =3D dev->driver; + + return driver->probe(dev); +} + +static void tee_client_device_remove_legacy(struct tee_client_device *tcde= v) +{ + struct device *dev =3D &tcdev->dev; + struct device_driver *driver =3D dev->driver; + + driver->remove(dev); +} + +static void tee_client_device_shutdown_legacy(struct tee_client_device *tc= dev) +{ + struct device *dev =3D &tcdev->dev; + struct device_driver *driver =3D dev->driver; + + driver->shutdown(dev); +} + int __tee_client_driver_register(struct tee_client_driver *tee_driver, struct module *owner) { tee_driver->driver.owner =3D owner; tee_driver->driver.bus =3D &tee_bus_type; =20 + /* + * Drivers that have callbacks set for tee_driver->driver need updating + * to use the callbacks in tee_driver instead. driver_register() warns + * about that, so no need to warn here, too. + */ + if (!tee_driver->probe && tee_driver->driver.probe) + tee_driver->probe =3D tee_client_device_probe_legacy; + if (!tee_driver->remove && tee_driver->driver.remove) + tee_driver->remove =3D tee_client_device_remove_legacy; + if (!tee_driver->shutdown && tee_driver->driver.probe) + tee_driver->shutdown =3D tee_client_device_shutdown_legacy; + return driver_register(&tee_driver->driver); } EXPORT_SYMBOL_GPL(__tee_client_driver_register); diff --git a/include/linux/tee_drv.h b/include/linux/tee_drv.h index 850c03b2cdea..e561a26f537a 100644 --- a/include/linux/tee_drv.h +++ b/include/linux/tee_drv.h @@ -315,6 +315,9 @@ struct tee_client_device { * @driver: driver structure */ struct tee_client_driver { + int (*probe)(struct tee_client_device *); + void (*remove)(struct tee_client_device *); + void (*shutdown)(struct tee_client_device *); const struct tee_client_device_id *id_table; struct device_driver driver; }; --=20 2.47.3 From nobody Wed Dec 17 03:59:53 2025 Received: from mail-ej1-f67.google.com (mail-ej1-f67.google.com [209.85.218.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F7FF33CEA7 for ; Mon, 15 Dec 2025 14:17:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.67 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765808265; cv=none; b=PLF5eV62qc5R8miC90eWB6jBtiWaD57T+vp7Ab12QSpZY/uG1AkouVq78mwpccJkM3KWmhzzVcHxRjbI45dMLiwY88DbT1szVYm6cRbakCEpuegso8/PrzjAtAcsTLCFM02zZt1wMX/5gQoqmXQmybOw5uBlLTEitEeiOT2pWZs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765808265; c=relaxed/simple; bh=qgIeskizQ6k5pCTS+tBJjIOrZYKzKB9RZLZ3eLktzMA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=QQ/RAwYEtciA4RIJ1ZFSmZDA+yjU/kkCJp3oS6hOkYJKS5pgU+vPet0JN1NU3gBY/3d5Ap8Igp8+RIiBr/Q6TEuJmE6XFPKFB91W4KD8BCiwOImPUX5NQm7+MOi4v0LbvFVACfzho9V3vHz2qA66umpGG5C6HfIgQtunk8MZMZI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=I4EcfV1U; arc=none smtp.client-ip=209.85.218.67 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="I4EcfV1U" Received: by mail-ej1-f67.google.com with SMTP id a640c23a62f3a-b73161849e1so789452566b.2 for ; Mon, 15 Dec 2025 06:17:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1765808259; x=1766413059; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jkiTD4px65dM2skIdFl/J9dVCQORv+uwK+yX/RVP6Rc=; b=I4EcfV1UH3TlEF5NOgpOKvGnh+tYNSa+w3PpwRY481Lv4F+s/kDUwHNOxwlgguD2HC zkJDEW1JzIXWFoUC7ah6g1W/y5/+FmktIuO3Rs63eOiAxAmOdPgEY9YdXjxdp9pZ3j7i C2RqPD8Am8bV9OLfm15TqejYjgq3+D8Lc6B8+2j5JW079QAVNrRzRVVfgw1k/JuTiKIe bfe9gYz6U3L8lwgph6rwbtUYZAghW/9z/iLcfJIxHxrWwFxxe259sZUJHhhNavF+U1W7 pk/LHRLowB0ayMHfmJXIimkcz99yGlOMDfuO0OvPhxwwSjM7pDOYZ/TvT/vICuzm83al PZ3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765808259; x=1766413059; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=jkiTD4px65dM2skIdFl/J9dVCQORv+uwK+yX/RVP6Rc=; b=dFiBuFDWe2TtjLt+BmD/AZDB0R+z59EMnfjcsg4eulmAYVdo4R7/Sc/2OOyTHHtOeD bFupWp7nZPb3bTNEPUnbcxVgIEw6E73rmBQL5eFPG8C2QVz9bVr39mFLP+YGS2SHCOPM dgLpAPErrnWT+4gW+B6we5qPD+keHM/McGxygKsYSqqZPI3poIOffEi6KvDuz/C2RJr6 QrMoCPN99kTS7MkGsmkdCh5KdplsEcJm1o50newGTXRDpk4TFlfKeqTogWtBvjLKyauN 0URr7DrA7JtmHmikj2nk91joTFJQkBOURQBZ5GXLknzbBUENSPku824NG4oQdo73pZO8 88hw== X-Forwarded-Encrypted: i=1; AJvYcCW8RUx5rN4edEkgfirVChYbUrmvmZni6y5eAMIq66A4SZ4leRMoNgXmbfxYYwz/XaQ9vsDSNIE4FEQoja4=@vger.kernel.org X-Gm-Message-State: AOJu0YxR3y4sRz/+xT9yLdZxeNW6ULpoWe+PwkmNLBYrRt2YLpgAR147 ne8AryneUosg4M4ylFvG0Nd3ZCX4CdPFwPdr3TDZUkmsyCsP84ZcCKJuYn6GdWlHuePFTivIOch qBN/kPH8= X-Gm-Gg: AY/fxX7KYyifkwlKROcjsobO8ZA0qvv5tSth3O5uijb7TTlarQHD04oXkOkol/SXvTv hLaUCE27PmZ7a0/7snypQXT3VauJIf1wWaB/vEwnu/fGnT6geAjyJQJz01+FssAvZ8dBnyPcXCa HZ2HOqv0jUEbic1ldJ/md9Vh4wTrgEmSjZFj3LMfMnuw1p+WOxsdBYI8M+5XZgouCJaPiJz/OrV l2JS9fTWxET1aOl7q1p7QWl2PdUliDtcJJ0aA/jedapsd1IQawzHkbZHl+dM59ZDGSTk5ZrJohi LPx13/JPSiAzS4jLu2rdGcmbvFz/ZZy+CLn/jacK30acr1cZEBp0blr42h1EiOt+35r5mkQrYne q6PXVdnHeUFbMDwxT7fCV4sukMCvuPuGj4e7qN83XaSRP4Uz9EOegWs6XCqxmQfCVasYxha7GFC yt7FspRMvYtsTPdlQ6FWkZn/u/bnkaIfON1ra2t7fDYHw6VlkR4sn2P9gyYA== X-Google-Smtp-Source: AGHT+IHKV4igaHwn7+K2vwYBtyQFxVpzIQraC3kpQm7Azogd0RTCY38G5wp3SBzUcJ46GS6qptq6qA== X-Received: by 2002:a17:907:db03:b0:b73:1634:6d71 with SMTP id a640c23a62f3a-b7d23693326mr1093680166b.26.1765808259567; Mon, 15 Dec 2025 06:17:39 -0800 (PST) Received: from localhost (ip-046-005-122-062.um12.pools.vodafone-ip.de. [46.5.122.62]) by smtp.gmail.com with UTF8SMTPSA id a640c23a62f3a-b7cfa5c9d22sm1435302666b.61.2025.12.15.06.17.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Dec 2025 06:17:39 -0800 (PST) From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Jens Wiklander , Jonathan Corbet Cc: Sumit Garg , op-tee@lists.trustedfirmware.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Sumit Garg Subject: [PATCH v2 03/17] tee: Adapt documentation to cover recent additions Date: Mon, 15 Dec 2025 15:16:33 +0100 Message-ID: <5aeee7a827cf928f1d68b7f680a59685117948df.1765791463.git.u.kleine-koenig@baylibre.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1318; i=u.kleine-koenig@baylibre.com; h=from:subject:message-id; bh=qgIeskizQ6k5pCTS+tBJjIOrZYKzKB9RZLZ3eLktzMA=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBpQBhS0WoEn4Bdownd57bRxYSl7t13OvpmqNRXW GkJNk6vgCSJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCaUAYUgAKCRCPgPtYfRL+ TvinB/9EIDFgtID3fmVhXXlk4A/3oeXKOggta0tcV5pJkVVqettorkuMukUos3F64qUG9dfUwdm hIAyJTKLPIyTNxWnxUfuucogoLAJ3adnn3KWUoVgBCcNMsvM5nkve7In9cZ9PJp9TI3b+o+72NC GZD+0Fr35s/FNjF+oZ8Gv0XaxQUoHoX420dzXrvQmpY79p1jcRwnzxtxLBA7GX0zQnMJJotNITC wpv2OVKb2sCXd6sqH8iA3gIECJDYegN1d5JRblp9d7dNDN5lcHd0nh9Oj2USgmDBirXlzgUCczl cOYapG0cgNTwNeI76zy4BsN/x06W6+Noq/qCs+A6WiicD4kt X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable The previous commits introduced some helpers to reduce boilerplate and bus specific callbacks for probe and remove. Adapt the reference example to make use of these. Reviewed-by: Sumit Garg Signed-off-by: Uwe Kleine-K=C3=B6nig --- Documentation/driver-api/tee.rst | 18 +++--------------- 1 file changed, 3 insertions(+), 15 deletions(-) diff --git a/Documentation/driver-api/tee.rst b/Documentation/driver-api/te= e.rst index 5eaeb8103988..4d58ac0712c1 100644 --- a/Documentation/driver-api/tee.rst +++ b/Documentation/driver-api/tee.rst @@ -43,24 +43,12 @@ snippet would look like:: MODULE_DEVICE_TABLE(tee, client_id_table); =20 static struct tee_client_driver client_driver =3D { + .probe =3D client_probe, + .remove =3D client_remove, .id_table =3D client_id_table, .driver =3D { .name =3D DRIVER_NAME, - .bus =3D &tee_bus_type, - .probe =3D client_probe, - .remove =3D client_remove, }, }; =20 - static int __init client_init(void) - { - return driver_register(&client_driver.driver); - } - - static void __exit client_exit(void) - { - driver_unregister(&client_driver.driver); - } - - module_init(client_init); - module_exit(client_exit); + module_tee_client_driver(client_driver); --=20 2.47.3 From nobody Wed Dec 17 03:59:53 2025 Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D441533CEA2 for ; Mon, 15 Dec 2025 14:17:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765808268; cv=none; b=EE4gw6fiz+SdM70JtdkHttkSXYkfRnqqBWnettx3TqVaybnUYpnSLMAyLkJnsp2QvVUAOoaaSJRukkq/6f1dhZZXjmp1aZsPhqKXPQtruA0qgipvvGNKxRl8UkDAyViZlDsv1dvAJeJDmphpiEjr0am1ExJLUczUApJ36XonO14= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765808268; c=relaxed/simple; bh=SjEd6VJRjSq6j+23i9dm+VIV1mrWqjZFs7/yjFJu9o0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=i+/+BF2OaV5SdqijFPges0OBm3wbaUKL/Xosac9qvlT04QYt3H6D1tv7r6KGPUFkykuT3eGd2mft396Zm7EUJgwuyJNatzRgRN+b4Wa90iQ8MVLBG7cpGu+aoYCcaSd2vVdfvKzaIHHFVnyLChmNDxHlCPNeUTil+QwyjEXpHeE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=h/JK6J4H; arc=none smtp.client-ip=209.85.218.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="h/JK6J4H" Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-b7cee045187so693326566b.0 for ; Mon, 15 Dec 2025 06:17:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1765808261; x=1766413061; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=PbC785QpAYQenK85VtICOF43iYYBs1NW0kuyf7DWA0o=; b=h/JK6J4H49E4WhyzuQjHG7QTpJg5cYLaoN+kFvbnCh8FxdQE6KptszdJbtvpJ16gzl r4m6BAtiEUG2NtM0+9XviBkQyyElGX6zUC7cxOuUy/FZoVn2bl8Ccbn0lmJWRU7LIQBT uq564W752jZ4DoW+bRubLu3FMtZTuRVt/l4Tm2T+5aCKVG2PKt25auY/kaCKOAtYtV6M r+sdRUtiYFodPZmtfxZ9B6T1qUlV8Rcrv+QF+KqzMCGKnFkPMT2R2aGCzjtf7cnTyAbD VDAONVK9G8lixMYljHbeOwUxljR7i804l6cncvQi4mOhBho+3u0CRCjjbn3Z1ZwtPbum i3DA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765808261; x=1766413061; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=PbC785QpAYQenK85VtICOF43iYYBs1NW0kuyf7DWA0o=; b=l8PgAOT3ve4hyqbuG57qYtQ+JfWxFeKfzhBMYZuUXUslXrVvt3Wnuwj7i0/7kjIe9+ yIbf6TeYhDPgd+T/j25OAEDa6DK3V7X7d4OlHnvU2Xss32Lhlct3OL0FI2RJWz0q8UlU HnVLG25OI4vcp0IS1wuZdnjK8mtEX+MwEJB0wXC4Q+fjMjkbCLG/u1Ooq9v/5ffe/f0A W+IJM0MIgfKZipdtddBe4gTTwj83I+lx5x0LaLlEJqGuJwSCYdCUZ2qRMXvsSbJituf9 p+0mDQR0Dt/w3TeMQuaCYvfxSkMiSZ5DDGaZkWUsIKNgqSwfivIkKRoiIxyJf3e2AcaG WjZA== X-Forwarded-Encrypted: i=1; AJvYcCX8X+3LEqrfwZMzhImjhsYjyqB0Wzy5fkcO3kp6Z3eVPXKd+NwYR6Id15MQ2WD80nJywVBYLx/hi/JANug=@vger.kernel.org X-Gm-Message-State: AOJu0Yyi0cmv9AUUVSvnWxODHhGpUduPVrC1syPf4jSpZ8mujJfq8VpD TSDcIslURsxzi6HAJgpTcGxX9O6xEqSm1MK5cmImMfbFB/zZXctem+If3fBi/RQPAJM= X-Gm-Gg: AY/fxX68lHnrO9jLHTamEpI7rJd0ce/NNEaadaKJfy9002SdZZlcVLLcyujZxM9EvNN LdOAMTt5KY6XfVN8zQLel+w2PHF+KtesihkimN/wxTe+mvUBvRAeIC/biAvhZzDauTiwPgAY2EM JE3ZCucMRFrWvG4OhThmWvEYPbTWMz9z5JGIAYrneUDfyaUACuC2svVLVb67nhuGM54u3uYvXb9 kKawR/V+f2tkAQWIpC81dO0bkGO+0OrxqJDSeqvwlUMNj8iDy8wivzjbWEo6/Pek2+ZPKYHbRVZ RIv9ZzOIrEvaBify+DXCzY1b9jK9cs8KaKXJr2V++nP4ypLoxZDd2WZ5nnwR10MXs4iYBcNByf8 /t639r2hD05efp6trTN6E8+Z2TppW946icnbeNBuTNvhKfQXECIEAW8DggpjbcMCAXtUnDHvM7e 9AkAIumirVcZSkOqz0LWOG2M+iPfggEC5DaKHhOndysZcOVoH38dFi6NmdIw== X-Google-Smtp-Source: AGHT+IEZpKvQ+hycfkLhAZU1bkIfs9hjT/nN1SWB48QII7f5RuGpBZd/Ndg22CntlimXslvQkoET6A== X-Received: by 2002:a17:907:94c6:b0:b7c:cc8d:14f4 with SMTP id a640c23a62f3a-b7d0213705cmr1612870366b.4.1765808261098; Mon, 15 Dec 2025 06:17:41 -0800 (PST) Received: from localhost (ip-046-005-122-062.um12.pools.vodafone-ip.de. [46.5.122.62]) by smtp.gmail.com with UTF8SMTPSA id 4fb4d7f45d1cf-64982040e2bsm13503641a12.6.2025.12.15.06.17.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Dec 2025 06:17:40 -0800 (PST) From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Jens Wiklander , Sumit Garg , Olivia Mackall , Herbert Xu Cc: op-tee@lists.trustedfirmware.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, Sumit Garg Subject: [PATCH v2 04/17] hwrng: optee - Make use of module_tee_client_driver() Date: Mon, 15 Dec 2025 15:16:34 +0100 Message-ID: X-Mailer: git-send-email 2.47.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1318; i=u.kleine-koenig@baylibre.com; h=from:subject:message-id; bh=SjEd6VJRjSq6j+23i9dm+VIV1mrWqjZFs7/yjFJu9o0=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBpQBhVdjM0yUwXxXFzx4aHBLn/Ds+MiNtpCXJ3V 953KZqt7++JATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCaUAYVQAKCRCPgPtYfRL+ Ts3hB/4rg9tut6lPOPfor6BYQUFfnX83d3OmNYlQfMOEoVlpBiI3dveN+tab1HfLbXvsdJxEYii PuEfVOeX7Lop+gOlexjK7TxmbSY/TFYicwC5P7r7a/LZ7avaYB1HjDktvTueCGtgHLmAXZsmleq ZW/qLiQmVbdCKMqrMp8aUxUI8wslhF5UCZYemgcXHho/CnsHqq90HdqXrY6Hwc4iStBkFZ34HDP MGqmlzs+XukATpnr7RjvVk8a0Nh+eXyUaEyglo/2O/9f6AU+PqUcKc3n7+2qU+LSDUz3egKtOYi xn1KyXoW6Dsw9bXNU8YUAOMXWO7Jj0msC1/mXh+DkgM3UJZg X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable Reduce boilerplate by using the newly introduced module_tee_client_driver(). That takes care of assigning the driver's bus, so the explicit assigning in this driver can be dropped. Reviewed-by: Sumit Garg Signed-off-by: Uwe Kleine-K=C3=B6nig --- drivers/char/hw_random/optee-rng.c | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/drivers/char/hw_random/optee-rng.c b/drivers/char/hw_random/op= tee-rng.c index 96b5d546d136..6ee748c0cf57 100644 --- a/drivers/char/hw_random/optee-rng.c +++ b/drivers/char/hw_random/optee-rng.c @@ -281,24 +281,12 @@ static struct tee_client_driver optee_rng_driver =3D { .id_table =3D optee_rng_id_table, .driver =3D { .name =3D DRIVER_NAME, - .bus =3D &tee_bus_type, .probe =3D optee_rng_probe, .remove =3D optee_rng_remove, }, }; =20 -static int __init optee_rng_mod_init(void) -{ - return driver_register(&optee_rng_driver.driver); -} - -static void __exit optee_rng_mod_exit(void) -{ - driver_unregister(&optee_rng_driver.driver); -} - -module_init(optee_rng_mod_init); -module_exit(optee_rng_mod_exit); +module_tee_client_driver(optee_rng_driver); =20 MODULE_LICENSE("GPL v2"); MODULE_AUTHOR("Sumit Garg "); --=20 2.47.3 From nobody Wed Dec 17 03:59:53 2025 Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 155922F0C76 for ; Mon, 15 Dec 2025 14:17:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765808268; cv=none; b=PObe3y4oO5idoYMMDboKhtB1wYwsyWjzCklL+LInKu6YeyzOy6Y+52Q/hgGpp3em3Yn4CMQ01SRRF8JZRx3W9rni3RDPCl9kMw+Z+1GpArY8sOzP4M0PSkltfl90BMmuSbMmCte87VkoXrfBjVcOe+0n4RJoqiLtant8VmovbSs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765808268; c=relaxed/simple; bh=1uJJpA9Ql9BbSXGSv2HLkK7u07CA6mF+itptx+5e3Xs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=sIIPnIcB2a9zqpqoVr6S6Zt8+7uwpmkqI8NQ2aKWOBOttMVOZIvBIeeQpTWAthYQB4WLrrOvm90gANtdTWMdRJcvnBegREOJBa8ufilUEEFgEUohpL9Y6PCI0rG9ISBa8wu6VPUmZqPOHejsejGEvdPYuFtLb19LR3A5Q5Ub8rg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=Ugxs9h9H; arc=none smtp.client-ip=209.85.208.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="Ugxs9h9H" Received: by mail-ed1-f50.google.com with SMTP id 4fb4d7f45d1cf-6499159273dso4304497a12.3 for ; Mon, 15 Dec 2025 06:17:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1765808262; x=1766413062; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=QIUQR9A1vYIw9QlcE/Qa0VTdIdcn5aCO46D96t68m0E=; b=Ugxs9h9Hu14Zr8d6axdt8o7D8NR++TA/EqsmVSN1W5KjJ4/8lcRl5QHu/R+TShngmF 5+mOpQmpRwD1dCLCiyR+ext32DdGM9ix7WVY++3fYMNNL4EJdMuqE8kfUEeRChv30SGg DwjWJgTJqik3RlGq0D4wWw2ur7flrQh0RrLyZlSRnbJpqYbX4GZU2dvl1cv6r2Bf0BXT xIkkxrzXCNRMM6/FuR5AFJbxe99kYxYTiPuvkFkePsfH28g5H5OGnM9yLkASWFz26IlY X/uIYiPfY3FYbZYGvYu09GyAO5kwGh8oRB6jmb7rUYK9QQLvqi3RsXwtsWPWBR20ugxW RGEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765808262; x=1766413062; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=QIUQR9A1vYIw9QlcE/Qa0VTdIdcn5aCO46D96t68m0E=; b=SLsbHtfo1/dJNWSrxY3LK/zitJiA04cH/ZmEaQ5Btlm1O//HsMWFkIgD+eUSIZn0+T zHV0oCH0nePyGnFrAhbsZDDWbMd1DV8mB8qZhCEk0dVSmFUD4jd/TuKlBOU7HZLjL8vJ sq634Ji4W9vU4CuZXXhPGoCucT7eW+TbyJ15zK48XdBa1rcZjGjaVySQUHTrMfvVUkKk tKMfapio8iFYjl9zsc9Qe3+c4Fap7LehNdGybtt2EAXXF/JB4FbheoMqSi55Pl9ip6c2 OMfKaPG/YSkS58XHQopfVZGmu8Ux0NKomqJpTKwF6QxkjJbzmYlS2jxPzvd6We8n2GrR ld+g== X-Forwarded-Encrypted: i=1; AJvYcCX+9RbzGoXZ84GRw6t/pXWtkBkW0zm1m+0v7zoGiBmMkba1RqEkgIWUB2UABVWb5ZDI8ccZXCzzkLcH5S4=@vger.kernel.org X-Gm-Message-State: AOJu0Yzc0jtaYtajABrqcRQlCrwl6RESvu33ELTUqU6/Mx8VBIYcyWfi qsUGxgyJfo4dZyf8HOBeYDgnOsKeOAZy4WjmUWH/HXjieUoEA3UbzUyH9KSH6LpcWTg= X-Gm-Gg: AY/fxX648HYsm/Rk0cm/XrGzFJbdaNamY4qjApjpQNupGP+oq5sXfKpbAATkqQM1Urf v15+f+hLzt6t9Mlx9bYkHy2Hfi5g3fo12DGEha09isSwMgU3BnaaSKWxE5kQcxDbLTCFRTF1dSf sfRrIld6p8BcPuIvEetlBhsU7dxtuYwBY33DKz5onExhXJExP8XlzjbysiTp0wST4iP2fy8g5JA nNMlK/E3dbuRDeYqmH/14T8T/M2yUDKol0c4Bh0j5wJP8nOPBSzvnr+ugAVo86rnxMhKbdyDDSJ +bgPpYO9zbB8a07oxq377vN34MOJ+WClZnNg0vWAfRvcZg65D2Y0I36TsHCyuq54Ws34sWsebEI eLuu0Bl//m+C8H//9hSdLxsyvWm3YON8KWVHtbVgzEEHEAgKcqwLcqPR/lFFO3/JNSCcIvM98wY MHTtuhclktF0u5tkoNAh0uQ/GsMPZrMm8E3tbFhZ4Dc+GBmTG/jYzoWqNPvg== X-Google-Smtp-Source: AGHT+IGgNV09AuYgsqnGmm65Wezv684KCpS+08Dd8VMBIrTAAoyAJyvM9gNMVpz7WAarxXBPjKme+g== X-Received: by 2002:a17:907:1c0b:b0:b7a:1be1:984 with SMTP id a640c23a62f3a-b7d23a912c7mr1001442866b.64.1765808262516; Mon, 15 Dec 2025 06:17:42 -0800 (PST) Received: from localhost (ip-046-005-122-062.um12.pools.vodafone-ip.de. [46.5.122.62]) by smtp.gmail.com with UTF8SMTPSA id 4fb4d7f45d1cf-6498204fbb3sm13523420a12.8.2025.12.15.06.17.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Dec 2025 06:17:42 -0800 (PST) From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Jens Wiklander , Sumit Garg , Olivia Mackall , Herbert Xu Cc: op-tee@lists.trustedfirmware.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, Sumit Garg Subject: [PATCH v2 05/17] hwrng: optee - Make use of tee bus methods Date: Mon, 15 Dec 2025 15:16:35 +0100 Message-ID: <170dceec036ffe468a1f9f26fa08ac9e157ada29.1765791463.git.u.kleine-koenig@baylibre.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1885; i=u.kleine-koenig@baylibre.com; h=from:subject:message-id; bh=1uJJpA9Ql9BbSXGSv2HLkK7u07CA6mF+itptx+5e3Xs=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBpQBhXu4/bwtxASM5yQ5sR2LOaNmcTkAhZ5XaYd riWdpm51lGJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCaUAYVwAKCRCPgPtYfRL+ TiHYB/0Rn5IqZ2NZ5jNZ7qhs3+bCUIODZ5brLERcCe++79d/CFyEMLoIbkC7IrHhW/w6rf8d5ec P3QZ4XFV36zh0ByWKjm37dnphaan9VGVrf3AOnvcgTNpNtFsFzh70z9s8VN9xvgRW5tbAllBM7f fd6pZoiQz7yXeDj/OkdNa8vtTlSqOpTihSEM6wu3U97yq1lWfdiYBrT8Gjj3IP4VXRlPbVJHG44 3sLs6/eDddZUsq1L/LxYImmr8SVdBeskUGgqQufZsne2BQzMWhpxd2mBDY1olq/Bx/0yevHUr7Z CvGicBaxS9KGPVUHWdtAeD3h/4gmlwcbWLWHtXpWAJX/J/l4 X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable The tee bus got dedicated callbacks for probe and remove. Make use of these. This fixes a runtime warning about the driver needing to be converted to the bus methods. Reviewed-by: Sumit Garg Signed-off-by: Uwe Kleine-K=C3=B6nig --- drivers/char/hw_random/optee-rng.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/char/hw_random/optee-rng.c b/drivers/char/hw_random/op= tee-rng.c index 6ee748c0cf57..5a3fa0b38497 100644 --- a/drivers/char/hw_random/optee-rng.c +++ b/drivers/char/hw_random/optee-rng.c @@ -211,9 +211,9 @@ static int optee_ctx_match(struct tee_ioctl_version_dat= a *ver, const void *data) return 0; } =20 -static int optee_rng_probe(struct device *dev) +static int optee_rng_probe(struct tee_client_device *rng_device) { - struct tee_client_device *rng_device =3D to_tee_client_device(dev); + struct device *dev =3D &rng_device->dev; int ret =3D 0, err =3D -ENODEV; struct tee_ioctl_open_session_arg sess_arg; =20 @@ -261,12 +261,10 @@ static int optee_rng_probe(struct device *dev) return err; } =20 -static int optee_rng_remove(struct device *dev) +static void optee_rng_remove(struct tee_client_device *tee_dev) { tee_client_close_session(pvt_data.ctx, pvt_data.session_id); tee_client_close_context(pvt_data.ctx); - - return 0; } =20 static const struct tee_client_device_id optee_rng_id_table[] =3D { @@ -278,11 +276,11 @@ static const struct tee_client_device_id optee_rng_id= _table[] =3D { MODULE_DEVICE_TABLE(tee, optee_rng_id_table); =20 static struct tee_client_driver optee_rng_driver =3D { + .probe =3D optee_rng_probe, + .remove =3D optee_rng_remove, .id_table =3D optee_rng_id_table, .driver =3D { .name =3D DRIVER_NAME, - .probe =3D optee_rng_probe, - .remove =3D optee_rng_remove, }, }; =20 --=20 2.47.3 From nobody Wed Dec 17 03:59:53 2025 Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 60BBF33D6EF for ; Mon, 15 Dec 2025 14:17:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765808270; cv=none; b=fAEr//Wwb91cBaH6Cw5ZGkcZkCVlsQ4j/lLDA/2I47oQ1r0cadu2DSXw66ELNR7yP27ZCcXMEH6nHzTQI54eOHWDEk7gHwapaJKTDchF0N9S5fg8FYAs0G6ooV032XfQLr+6nAWHYvDcGqdVhrtRzB0FAbO8u4jyYxhoFijsJ4s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765808270; c=relaxed/simple; bh=8xBlw1gjbdzbNdrRW7jRBiV40wdZTcJoR7/j5OL6ib8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=l0RvjuP0ohcV/cjXqFqXp1x89oU31b2CsElKlhAmuCAmlh2G+p/9lgCXWFdDqVBLcmZY611AzAzjmy7OcyJBTPAoGj3VH+YC0pyMn2qhGHTijWsqCWJ8HzDDB7sFkYwYP9zP6lYPD8vQPaAsHjTaI4iJ3CIaeydkx+P4oGC29Oo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=Hk+iJVev; arc=none smtp.client-ip=209.85.218.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="Hk+iJVev" Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-b79d6a70fc8so618755966b.0 for ; Mon, 15 Dec 2025 06:17:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1765808264; x=1766413064; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MeVmB6pdOKliNGaheWVpdrKRlK51LVSf7JP1hhbHQFo=; b=Hk+iJVevmFG0yUznMDhz5rkSqcCiNI+NtEwqvJR+sWCWn5n2LKv3obxB8o74Q6xwb3 4yj4m7sPLzGNt8pKTvr0re83D5gSUWWImzOslNcaE4+Eki7SvvfBeXbjdYwDp29Xi4BC Do1YVFi4FoSQgCx5G/VDtJo/2dTGcAt050l57ztQpuipOBgujpYgmHNgVsUM9vc6LJyj vT3UybGbC2+PElTXUEi+qtBwReP7J5y3WRtJaMFAKTwyRu2eDm+Mzu00IaGjisfrfIDK RvfFrwK5717nxC0NHGpnwQkl9smpFsNG1Q756F1gUL1tCo77xUvHqFdtTvIDLj6hwYVb R29g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765808264; x=1766413064; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=MeVmB6pdOKliNGaheWVpdrKRlK51LVSf7JP1hhbHQFo=; b=KgwIfrKt9nHpL/ECiYhbL/nUhpUP9ZWYnqOP9e71y03eSEsxURa6j0lNhYnqvOpoGk qOF0b4tkka5vhteg0oomujTvCo5hc6GCWng8j+1KYl5pjW+IORjVDUGHvFzZQZb8Ork/ vs/EAB1XZh8T+7ttjG6WJqInAMokH1oSOJVSUnG3RKVM7sGETGOdN8EBjRbQufDb5KVj 92P2zY1qqMqKyviLIjbXyiswkHt1aY0pHtLZPChs/6BHbJYAyz1AYj3DL+uaxjxmyfDH 8JT50L9UuFcwl+RjKvnyAwpL+iGpb7axFNCCgyazDe0tOIVwoboNnKICXHyxDVnGwKtg EzqA== X-Forwarded-Encrypted: i=1; AJvYcCW3nOhnYMAtw2tvtlM3U+WvJcOyXfsPwntY9OAllz17KpEjQWlHSlYZcUUEAwgSJYCdKLFKU/sf9H3LwAI=@vger.kernel.org X-Gm-Message-State: AOJu0YwvoIFEGs5hQ8y2drB3waH9bip5bZR+gWKdsaAjQ6YHX3v8jHT1 PcipROk8BZTJfWqyTyxRz6WxJJrVg0MLnMpnEno5i9ZNqpXo24TslTRkK5xDhl/CPu0= X-Gm-Gg: AY/fxX4meTOScL2jixw4XvAUnu7H5rMl/QK0l+ysT+H1c47+2Jg4D5DDA4cRQSemfbM 8MYkL2xkvNducCAqD6eH2A3HqxaGC7eJDCI06/2FnzJdh9jawl8C58jOK+i2RMnzfUBv2HGteVb YruT3gFlR83FlRoMNrOmXzvG0zX672EnbIiHwASG0FD+gHSLISxnQxOE6YBbnU1CZUqeYCSjVcl 7sP7SIWis7d6/TES0WV/uy8hH021kwr5+5GxyV0Yyo038Cel51dYTfZAb9gGNrnGvoFQ7cxZRoT 1uez5jfoNyumvmQs4Hwi1j+N9M+Q1i1y+Q9JJbGaqsxrxRpERtqmHfqbZQfIuvkESmBmmYZN6Ih 58UxHSqRe40Uvb4C7sHtEBtkCOGizlag8i2Kn6MWXG3/BxHPJZZJzjQ5n5zAEq5VMVpUeaqlkwq 2JJfSQp6vE9Ge0DsnJsl5+bKtUvkbVHSGQXrqw3OkwaPPnMrWHALtpNL0pH6KnyyO4miQG X-Google-Smtp-Source: AGHT+IGjuIlGhVLGV8y/XU/LQ0KVHoNFed57MFBl0SJ8RGXpjTQqBLrhIQJec3QABMGxBdUrXwOG6A== X-Received: by 2002:a17:907:9816:b0:b79:c233:c8a7 with SMTP id a640c23a62f3a-b7d23665c82mr1069817966b.21.1765808264061; Mon, 15 Dec 2025 06:17:44 -0800 (PST) Received: from localhost (ip-046-005-122-062.um12.pools.vodafone-ip.de. [46.5.122.62]) by smtp.gmail.com with UTF8SMTPSA id a640c23a62f3a-b7cfa5d1e89sm1393673866b.69.2025.12.15.06.17.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Dec 2025 06:17:43 -0800 (PST) From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Jens Wiklander , =?utf-8?b?Q2zDqW1lbnQgTMOpZ2Vy?= , Alexandre Belloni Cc: Sumit Garg , op-tee@lists.trustedfirmware.org, linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, Sumit Garg Subject: [PATCH v2 06/17] rtc: optee: Migrate to use tee specific driver registration function Date: Mon, 15 Dec 2025 15:16:36 +0100 Message-ID: <6da13fa15497f8bde6e2621ebb11ab74764f890a.1765791463.git.u.kleine-koenig@baylibre.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1476; i=u.kleine-koenig@baylibre.com; h=from:subject:message-id; bh=8xBlw1gjbdzbNdrRW7jRBiV40wdZTcJoR7/j5OL6ib8=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBpQBhb75mJ64PBhRfXSJJzfGImqsFztPlgX9E8Y hTlBWg5zv6JATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCaUAYWwAKCRCPgPtYfRL+ TsC4B/9HAtoQkHHcfMd9S0b9RyrKfMyDk9Oj7QkjAjCz5NCrRVQJwW1Szu4f0ATJxzGMnnC77H1 KwvApK2BvtqK66JJi96d1LwD0CMVlbji/IB4YsGF/lFpiBHiuBLxd7yg5iXBqvX87v+jorwAq77 7Wsrzaew2TImyvruUOTZwf9M1By1wkdIfaKg+ebLVwVJyWDzPVQxVja2stgsP2pooGyhhLdZeq3 1bdSzHk0G5rWmqfCtivdifouKeQwshMxGn5u8XcYMBmeMTG4f/1MkBa/X1Ri56FGv0VX+YiRyHY qbYRrIwYVd21yg9XFfq6shF2miyMo1Te9ZxC4KQ6IdyupLqK X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable The tee subsystem recently got a set of dedicated functions to register (and unregister) a tee driver. Make use of them. These care for setting the driver's bus (so the explicit assignment can be dropped) and the driver owner (which is an improvement this driver benefits from). Reviewed-by: Sumit Garg Acked-by: Alexandre Belloni Signed-off-by: Uwe Kleine-K=C3=B6nig --- drivers/rtc/rtc-optee.c | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/drivers/rtc/rtc-optee.c b/drivers/rtc/rtc-optee.c index 184c6d142801..f924a729ead0 100644 --- a/drivers/rtc/rtc-optee.c +++ b/drivers/rtc/rtc-optee.c @@ -726,25 +726,13 @@ static struct tee_client_driver optee_rtc_driver =3D { .id_table =3D optee_rtc_id_table, .driver =3D { .name =3D "optee_rtc", - .bus =3D &tee_bus_type, .probe =3D optee_rtc_probe, .remove =3D optee_rtc_remove, .pm =3D pm_sleep_ptr(&optee_rtc_pm_ops), }, }; =20 -static int __init optee_rtc_mod_init(void) -{ - return driver_register(&optee_rtc_driver.driver); -} - -static void __exit optee_rtc_mod_exit(void) -{ - driver_unregister(&optee_rtc_driver.driver); -} - -module_init(optee_rtc_mod_init); -module_exit(optee_rtc_mod_exit); +module_tee_client_driver(optee_rtc_driver); =20 MODULE_LICENSE("GPL v2"); MODULE_AUTHOR("Cl=C3=A9ment L=C3=A9ger "); --=20 2.47.3 From nobody Wed Dec 17 03:59:53 2025 Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B7FCA2D0C9D for ; Mon, 15 Dec 2025 14:17:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765808272; cv=none; b=lDW9OT72y6N70dWv8Q93ajzvvEeTQpKBiJMm/RskEO28BNQNctwZAWZl0+aDnikdi0TFl1NE5RAi+/dodwRKlyhQrSMCMW0V1F10dgPFQqDy9WAxrl/4dViNMymuc/goncW6hbimRCYdVsAHNOHBSh+kX4hsyOidRo2/Uh+Zl4s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765808272; c=relaxed/simple; bh=ikmzIlbOd+LEhbyDv3j+DT9OAKYhGjQzZlQGjQMpYL8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ab7qLc+VOdsHg/deGRaJMJjqn2Gy3bMowRQ9g91o0IYmHs4eKMbmlfZ/pveQYTvZ5EruNJgOOyfrC+ZmAqKV36DEBZG+5GyiugEfOV9zPWygNPR5Fk54xw8VFGYwwycr5muKLy3WY742JjfwAxXXjC7RZIl0HIea9JOzc+6XbEQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=JsYgT0yN; arc=none smtp.client-ip=209.85.218.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="JsYgT0yN" Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-b7636c96b9aso581940866b.2 for ; Mon, 15 Dec 2025 06:17:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1765808265; x=1766413065; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=DstP1u05CPAHjOAUetfVzJW1wXxCkT+pjUtyyoYANxU=; b=JsYgT0yN+8lnYfvrLJVeu1PMbXUH584OwU1eAjaZi9SajgpFrWn1Xz0feUYqosaA3N fLelMUb+/UxbtiOhd9ZRtfFTdfEHucQT6v8jigmsq5Ksj0FsuXpYKiuugsVlZu9XWWGA T9oPK6WEfeQjaz9JfSDDduSW19EXjwlUnTstHjUQckLfGHwf1ktpJmcfwMM1ioVSNR4D aNaNzza+FQi7GPJS2jhlxCHAF+RK/8JSp5FyaWseXy3PAyDhkuHF/3HRyudjxxyQi3Ti BvbmvvTiT/X26NP1je7Qea7bcSsIKt0vV6qgzAuydRhJDgpWPZ4Oe4yRa2ArL4wucqfk XcNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765808265; x=1766413065; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=DstP1u05CPAHjOAUetfVzJW1wXxCkT+pjUtyyoYANxU=; b=NOgPq1zg3gNYPmpRkRcEQRU9UjDeBu1nsIhHKRlts5wy2B7q48SLN6/Jp70pOXXccu CyAOk2Ipeo/ZZDpLFEPJ4EMqWo8UEsn9LxNakcD9oIMy3193eXIuNtXlgqSFhUbR0yNE BRgLKKj1LiaKfCDCBdA18tCg2ss4DO5uaW4r5f12xgrGFKVYW+doAkLqGBT7MFCqC7eJ 4z0oHp5qVwjkFu5Ae7fTnw45KpsoqLbBbTl1icIA3Ij76HCG7IoXQv2OpWtfQfJsFfkB 1CHpjxU+8NQJyTodyDjwSlVzaohcLvaI7B/U2/pJqVRIsod1Pw7lurdzGq8ALQ74K93s qOIw== X-Forwarded-Encrypted: i=1; AJvYcCW6sO1G2O1HQBAdGdBxlOWRO7aDWJAzVsKKt0LiD/ArQ450Px/q0/cv9ibFH3PZSnjFv8iwymrW8ZKKYKs=@vger.kernel.org X-Gm-Message-State: AOJu0Yz5WY9Vl7/K+pwGY42Gu79btuu4PLbfqn+pDXSS6cor1r53z8Kf PKe4e8okQ2S8cbV8f5CIF+dXqGqOdkx7MykMiPdG80UBY5jRa5xbHEwGRm1a/MZXn0Q= X-Gm-Gg: AY/fxX7qG9UJEQaBcKK46d+1GXNJeSEYFz2209mJ3kG8IhsQGD7Vo6gkTDMdMcrFHBT 8WZB6XYvkucbAIZtE+qUbX8azZm/5ZqonbCxiUo8vvP9U1UK8qdmmzupSQuJ5djanx3s9Nmwe5n 5blyicqN0HUmU64FiwaNvRjdQ9gy0dp8Dxs6doLT2oGMc9I7xWOjXxjsf89YNiW3MpsKuG+dw9v jAcHJG5Qm1iizswUUrpGqmAHA1RoTjKQQOXmIJQWBluqRiKU4v/cF9uXyhjdiicqBLa4Ed7EAW7 Tzi/qvuiWuFz4OvigWUHgLrMGsSTb4NjzsRSi7VRS+X4CXhfP9w0nqA7VLgDoQv7zo2D8NlAnfI grgwkVrWenRfSye5dVYiHpUQvA7+gmJ8XiCWuaJFdVdPskF5D0EHkNXfNmLDOVb+5QITHuz4z2e TFmrKnCHiv1zc23zOIRMc05jqxOtxzRawhrLPbPXgb0C0H7ybTJABLG14XOg== X-Google-Smtp-Source: AGHT+IG0aR1aVYo2hR9RY9GcMGEh3RQBWvatdAkF4IYLW7cEYQ+IwII2kbMYm7+RM3tx3GVb8FNltA== X-Received: by 2002:a17:907:3c89:b0:b73:572d:3b07 with SMTP id a640c23a62f3a-b7d236b62a1mr1080879566b.28.1765808265489; Mon, 15 Dec 2025 06:17:45 -0800 (PST) Received: from localhost (ip-046-005-122-062.um12.pools.vodafone-ip.de. [46.5.122.62]) by smtp.gmail.com with UTF8SMTPSA id a640c23a62f3a-b7cfa29f6cbsm1438920266b.5.2025.12.15.06.17.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Dec 2025 06:17:45 -0800 (PST) From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Jens Wiklander , =?utf-8?b?Q2zDqW1lbnQgTMOpZ2Vy?= , Alexandre Belloni Cc: Sumit Garg , op-tee@lists.trustedfirmware.org, linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, Sumit Garg Subject: [PATCH v2 07/17] rtc: optee: Make use of tee bus methods Date: Mon, 15 Dec 2025 15:16:37 +0100 Message-ID: X-Mailer: git-send-email 2.47.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=2133; i=u.kleine-koenig@baylibre.com; h=from:subject:message-id; bh=ikmzIlbOd+LEhbyDv3j+DT9OAKYhGjQzZlQGjQMpYL8=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBpQBheMbvEqJBwhAhTqzRRzs/PHvyCJQxdPljAW tHVglfhLtOJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCaUAYXgAKCRCPgPtYfRL+ TutZB/wIvA2FIQU9tGTYvprs23GCWKp5tv902PnEn1WRPNA2wqjSj8Et20EmH8sojRdzzDJRsSa QNyyrBuRRrXRk+hnLGBnG5qTINCrKGW6TpoBHjLH5oDpUe9MoqbkKi4dLGxYIMTV7DNp7ANGg50 qdv6a7E3IcMB2qYuhJzPC4b1uQ/PiQcd0xej78j8Y1CY+fCPH1i0kLC3Hk5nHsHd/zftj/dBn56 DEd0WTmplWXVg9eMG/rwS8Q9+9ROV3yQ4+Jxcm4TfSpezTMHurNx0RFJxPWzBxWtblzX3tXFZsT 14C1B+SHAWvizy9CoqaogXbeS/QgQaxL+lyhvYrb9UaRJMjL X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable The tee bus got dedicated callbacks for probe and remove. Make use of these. This fixes a runtime warning about the driver needing to be converted to the bus methods. Reviewed-by: Sumit Garg Acked-by: Alexandre Belloni Signed-off-by: Uwe Kleine-K=C3=B6nig --- drivers/rtc/rtc-optee.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/rtc/rtc-optee.c b/drivers/rtc/rtc-optee.c index f924a729ead0..eefde789d194 100644 --- a/drivers/rtc/rtc-optee.c +++ b/drivers/rtc/rtc-optee.c @@ -547,9 +547,9 @@ static int optee_ctx_match(struct tee_ioctl_version_dat= a *ver, const void *data) return 0; } =20 -static int optee_rtc_probe(struct device *dev) +static int optee_rtc_probe(struct tee_client_device *rtc_device) { - struct tee_client_device *rtc_device =3D to_tee_client_device(dev); + struct device *dev =3D &rtc_device->dev; struct tee_ioctl_open_session_arg sess2_arg =3D {0}; struct tee_ioctl_open_session_arg sess_arg =3D {0}; struct optee_rtc *priv; @@ -682,8 +682,9 @@ static int optee_rtc_probe(struct device *dev) return err; } =20 -static int optee_rtc_remove(struct device *dev) +static void optee_rtc_remove(struct tee_client_device *rtc_device) { + struct device *dev =3D &rtc_device->dev; struct optee_rtc *priv =3D dev_get_drvdata(dev); =20 if (priv->features & TA_RTC_FEATURE_ALARM) { @@ -696,8 +697,6 @@ static int optee_rtc_remove(struct device *dev) tee_shm_free(priv->shm); tee_client_close_session(priv->ctx, priv->session_id); tee_client_close_context(priv->ctx); - - return 0; } =20 static int optee_rtc_suspend(struct device *dev) @@ -724,10 +723,10 @@ MODULE_DEVICE_TABLE(tee, optee_rtc_id_table); =20 static struct tee_client_driver optee_rtc_driver =3D { .id_table =3D optee_rtc_id_table, + .probe =3D optee_rtc_probe, + .remove =3D optee_rtc_remove, .driver =3D { .name =3D "optee_rtc", - .probe =3D optee_rtc_probe, - .remove =3D optee_rtc_remove, .pm =3D pm_sleep_ptr(&optee_rtc_pm_ops), }, }; --=20 2.47.3 From nobody Wed Dec 17 03:59:53 2025 Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C5D833D6F0 for ; Mon, 15 Dec 2025 14:17:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765808273; cv=none; b=DoUSFD8Z80siswLN6nHytD0FEMfrMCoTZ9lnqLl52P4OJYRMKGdp3PT6spCGk63oN329wFKvuotk/U8ELI+xf/lI2344A91Yist1VeZesbWchwK1MMwVyNgVg/DHPeezplzibiWyPTmJwvGhEUKj67bwbhZAKgRlYFIR+xm50sg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765808273; c=relaxed/simple; bh=yB7VDr3EZSkvb6JHyGDNmAwFJZy2w/A1L0P7+9qGdqk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=lJd8aa7RDab2XDE5Zisu8NFQgzlN5K4k5BsSocSy+CKp79m7N/3Et91VwJBypY6gVaHPcacOFuCdhjF3ru3gtI0aDrdxIxHQTjKaM5zXEIn7WrD3lzjW//b+/XAg7C+Qsgjc4+QR0veIUdlR1otS7SQARfe1mU1SERj5KcAXcxc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=oJn9TuUY; arc=none smtp.client-ip=209.85.218.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="oJn9TuUY" Received: by mail-ej1-f52.google.com with SMTP id a640c23a62f3a-b735b7326e5so544518866b.0 for ; Mon, 15 Dec 2025 06:17:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1765808267; x=1766413067; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/lBoMkq+p5dQ2OsBBFnXVtnCRh4ggCKmjrfxDYkmgHo=; b=oJn9TuUYHuV/h15zxGm9nrzTyVYAzpC6DVX/zZz2DvFGXlted0QQPdoYVVsn8gsNP1 aueIOLnTlxBfW8RjLbJkA7NKEvZtbAn3fgLQQiP/zo+0gGPhNmo9nkR0heQEB0VMtx7K RhqcJBicT3Sx0AQNuXgRn9pwZgjFHOuvI0zkHxmMw/bhe3/5EWRZxS1wiHMDRXPlQ1ca dQERPuPA6k5Hq90URDuP6Cj5ytnvqrEUiIKn2pubi3ShmBA3w5t8BxhlsLzv8XpzErW/ N/CCLOycAu9e08Tqu3zzuB3Rcz5rm5/HP55295CLxUw5fyrH0t5KxbZ1pw7L0B8aLXBW Lzkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765808267; x=1766413067; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=/lBoMkq+p5dQ2OsBBFnXVtnCRh4ggCKmjrfxDYkmgHo=; b=edo4OMQkZHWCZwMDcY8aLhj+JlcISPIT51YwG4w6D46R2T9hcfjtkqOo1SwO4ugesM JZYW7ofbiLRZXmG5ZcRuLajgAMnqSNKxp5RmXKpCN33iQdlpzfGlVMzuMVkzYF354JQt xbawR52C8goW1pnqfaiGwf7IP0WJkZwzj6xAiHBnhsRV/yhKwTyNdiDWyqVDfHZmdiok xEDfyK5tZfmuQZ12PQ/A5ek0TCIKSTZFuiiD1ehiZGdLVfQLSTCY5312webznwY1FLrV 8wyYhRbUTTIUbp20X8njb2Lu7UXMHpYrJS60KICpxLqoup2JDYvVzBustVBKTsPuj9i0 Xc8g== X-Forwarded-Encrypted: i=1; AJvYcCV3XUlTuM72WZhb5k3ETdFlvIItUrNotZe/X+q/p01z75vk1cG1MRYy5N/sR5dq6vVZIh/CG+maw/0GQ8s=@vger.kernel.org X-Gm-Message-State: AOJu0YyXmNtbtrPVv6fxdzKQPuaheHfOalm+2Jw49/JyhWk/ua1acT2w 9At87ggtsyl/RfnWeBgaF78mtk1AZGaOJYsb+5O1OUaCEUI8X1NjukOYQ3XOxeyo+us= X-Gm-Gg: AY/fxX7NgFSqFvo+xbHhZv4NKxil5L2jTBVQ0D1ELcdYnPGcPHMPsKglolfB1AHzUT1 efAqXM8v3EPqo/jNgCRwLB5gJrfJZkkcGfnKROWGBwCQREY5qCqYK9zkFWqik/8ljCMIj/Bi3/Q quFLzEc6RnrDsv1KjTG8GZFm25Xlt3M/nX9n1kUY3vkYK7zMBlfUwl6aJmpkkkN9J951cViPkHX fi59cR6ZSPCqpYTyWcnfg9uyaaeVCe9q2jkgUiUA+zqeHzeLvTjI40HX6otjakuAOz1fxGIdh6s BrYtHuJS/bZUM5tzeeYOkqL84g1foFBXxphv8f9vZFRVCk9rWt8Z42xe6cG3XC4DKEX/Xau3Y8n 02TdVQUDC6MNKMA9F3zrDxnQv/56HHoN7dtJPYkHgYG7m/bBXBGIAd9FVhEzrWPnxoQm3yVI7uv A74ze0OABTQW4dpXDVxRq3lKa+SsLgZL4EFjq62Tu0O7hVH7T2Zk+KcNmlWsrMJY0yvFA3 X-Google-Smtp-Source: AGHT+IEwhpzpbutxcSFXZMLWPGgvdTBRCn78tGwOj7IZhNrS+hZ8IxpcNZHWAUSqv1MI4HUnh3hlrQ== X-Received: by 2002:a17:907:dab:b0:b07:87f1:fc42 with SMTP id a640c23a62f3a-b7d217ed7d2mr1308406266b.16.1765808266933; Mon, 15 Dec 2025 06:17:46 -0800 (PST) Received: from localhost (ip-046-005-122-062.um12.pools.vodafone-ip.de. [46.5.122.62]) by smtp.gmail.com with UTF8SMTPSA id a640c23a62f3a-b7fbd7a55dfsm554177066b.25.2025.12.15.06.17.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Dec 2025 06:17:46 -0800 (PST) From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Jens Wiklander , Ard Biesheuvel , Maxime Coquelin , Alexandre Torgue , Sumit Garg , Ilias Apalodimas , Jan Kiszka , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= Cc: linux-efi@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, op-tee@lists.trustedfirmware.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 08/17] efi: stmm: Make use of module_tee_client_driver() Date: Mon, 15 Dec 2025 15:16:38 +0100 Message-ID: <6a56ee61e485703d548e9e44d53b2920b4e43ca6.1765791463.git.u.kleine-koenig@baylibre.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1393; i=u.kleine-koenig@baylibre.com; h=from:subject:message-id; bh=yB7VDr3EZSkvb6JHyGDNmAwFJZy2w/A1L0P7+9qGdqk=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBpQBhgZ97MgwPHXb+Xx9vet2pJx/fRw7XXThLnp 2crAvT8GvSJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCaUAYYAAKCRCPgPtYfRL+ ToTlCACS5iflL8JzBfIHFC4dd9QU1VLCJ23/o3MwueoTbG3c0T+3+Ab5eAFzodoVurAYliob5pu dCvIygjW7D5m9ySrn4/XgKkHiY54AGvSbmsSNrVesGd4oFJGf3Nbo3TsaUZZWYnmY0+ypytx3sC jYoNu+MOi8Cr8BnQTHvWqdqh3lzQzJ8TOJIedFd0Wdh/LeHfoC6mf8mhe6wrufJ5R6QAS3sVl5y 1KnEG5sqI8XvYvgx261qZIjrxPtBeaWahLjOKNLFkGpC7HWMfBbAVP8nVWNbNXWRUZ3IVjMiJlW 5seuM+gr+TKUjwts24xtV5LeZbaCTzjo6uZIsnOl+ujpHHdr X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable Reduce boilerplate by using the newly introduced module_tee_client_driver(). That takes care of assigning the driver's bus, so the explicit assigning in this driver can be dropped. Reviewed-by: Sumit Garg Signed-off-by: Uwe Kleine-K=C3=B6nig Acked-by: Ilias Apalodimas --- drivers/firmware/efi/stmm/tee_stmm_efi.c | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/drivers/firmware/efi/stmm/tee_stmm_efi.c b/drivers/firmware/ef= i/stmm/tee_stmm_efi.c index 65c0fe1ba275..5903811858b6 100644 --- a/drivers/firmware/efi/stmm/tee_stmm_efi.c +++ b/drivers/firmware/efi/stmm/tee_stmm_efi.c @@ -584,24 +584,12 @@ static struct tee_client_driver tee_stmm_efi_driver = =3D { .id_table =3D tee_stmm_efi_id_table, .driver =3D { .name =3D "tee-stmm-efi", - .bus =3D &tee_bus_type, .probe =3D tee_stmm_efi_probe, .remove =3D tee_stmm_efi_remove, }, }; =20 -static int __init tee_stmm_efi_mod_init(void) -{ - return driver_register(&tee_stmm_efi_driver.driver); -} - -static void __exit tee_stmm_efi_mod_exit(void) -{ - driver_unregister(&tee_stmm_efi_driver.driver); -} - -module_init(tee_stmm_efi_mod_init); -module_exit(tee_stmm_efi_mod_exit); +module_tee_client_driver(tee_stmm_efi_driver); =20 MODULE_LICENSE("GPL"); MODULE_AUTHOR("Ilias Apalodimas "); --=20 2.47.3 From nobody Wed Dec 17 03:59:53 2025 Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0783F33DEF9 for ; Mon, 15 Dec 2025 14:17:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765808274; cv=none; b=MyBHEo4tluyr8pk1xCKaqDrtab6KAJfnF0vm0BJnqHnWQHx32nqzIIBo+aZJe3VypKZntgKtrZmStfziFK/dEi5eAPR47I29LCjfXRAM9ts/xK0MtVWOH3ZjT+PXrfl0h8mpq/LGJLTlJvbNbe/JSB3lqT/9Q+SLkME7mRm18tY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765808274; c=relaxed/simple; bh=U2aCK4CwX4oX996AKQXtxl/fnEvZCMh7YIAYyx6fXTo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=jzWmeTr0xsCA96kPVvYS7RD6nMZ/cpGtj7Hhy6SDWS4hpB1gPwFCz2qunrmMKi8uLilcX/5Ts2h8qpNVN8ceA/WfMdOeguJSHeR7wGo/oY6nrJXgBz1JG2HEmRnhjC3LYInqZAaeIxMsZaW3QWHaq7QZtAZqjqSkPSDAmu5xroo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=j0UM5/yw; arc=none smtp.client-ip=209.85.208.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="j0UM5/yw" Received: by mail-ed1-f43.google.com with SMTP id 4fb4d7f45d1cf-649822b4b64so5577841a12.3 for ; Mon, 15 Dec 2025 06:17:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1765808269; x=1766413069; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jtA7J2/qth5t0PM6hBWIeoPmBTb33drrrwinTXvOw1g=; b=j0UM5/yw00OlOhh0eXxdyC51JfQloSwgi2Jhgfdm32iWXPTnMac2PGa4jn5PYqg5C+ 8KJdK1HBykP8Dpb0IFdVaS0G5h1kvy+W493UpNTJFm5ye7EsWx5+KitjDkNDmbLuoiVV HYbECGjtCZtQpvrTuMOaYmYTbHdeFD37jurzrYU1M6ol7EZqjxriXC3fEHqG7fuf2hvO 7SCbOMcdR1541ap8U8X63vmV4yo2aA7l9Hnte+eI5yBkt72AZtyJ38mxtJ5vQVhehotW mRRRwNEOL6vfaO419bOKya1PLZMneCvGq4UJiMD/xgYLN/MpDEhrc3wYJ0qaaXOVnjS0 Ir1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765808269; x=1766413069; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=jtA7J2/qth5t0PM6hBWIeoPmBTb33drrrwinTXvOw1g=; b=IxfGjAk1F+Dp9LGbsoXdUvqZQbKscqyml1QbRk/OO6eUwGzO6AKLEqTsXiBF3CdLxy fQ080/4Q6arvsS70nsy1nZ/vCgQFpdV84N5HUjtJg0jXnbVx603rK0tep7xAVeq0QHpX AKS25+gzH1vIsrQ4wHjCLCx+Nc8xChod2RrHRv5uyN1Z96rxevjjWQKHsN0m/K/5YBg4 In8UHI89U3f9cUiJVc9z+ZtQ9LGr1VUFLdM8ESEof/9N+Ezs/e1K0a9wADQ990rpyZ6a /15zD8vON6KunFKSd0J9oONk1t/BIv0w3mYKMDsVWzpCWcK8x+Xpxm/2LqYru3q3sCtI VcnA== X-Forwarded-Encrypted: i=1; AJvYcCUh+b+Bp+/LzB4FrBEUYhjKghw23HM+14tMv9OEFLG3enk+osqpnTkqgTZJ5UZRj++osSFXDvHOcTg3bVE=@vger.kernel.org X-Gm-Message-State: AOJu0YysBZ3q5WVf8ya1OIVAX8c8/d4lNDi85sPIfyP/5M9R3b9kvQwS H22/7y/Yb0axS/1WBvdGcpTMvWq592q1t3mO5yQR3huG2Ve00H96tmPYNZr7vlour6U= X-Gm-Gg: AY/fxX7Xpyui3SdNyylLoKdoGrxpl038wo4rTQneAtAZ5Poo7I0uWw4djmpo3S5IZTy SAxnwB+97BD49X9TYGBZEl782NGjwSISJDTxltWoxsnNF2maNBjUbZHbByy8/Q02sr2EP1BHBhH BIihQIsU67jRAglJowywS+eYG2GEMw5POoD/ittyrCRVkoQE6okoMb9AK72QQRE7DtLAFq8Hdkq mz9BXhheaKr6ogDF94jhsflkJbuMdKdQ/HLq2DZ8WRlBJWv2+YVu+uxiziu4OvVwQgR++YQMOR3 LYnlTdmTurjwrDH0sIbA2aRm9OjZ6ECSgNee5aZeoLk/32jYBGWqWgabC5QrZpsU4OjqaRxl0YW se6ArmC+fRlD3waywV+q3uy/RlJ9uSXZ4JiYKcsSPqdclzHHCGT5Z8nldnMAJpMBC4pFFuZ0Y5u QrAk2a0UeUMpk79ZIjOpskPjXmdpQf1ZHI0LHgXA+sPYDhtLf98tpkWiWVww== X-Google-Smtp-Source: AGHT+IFv/1u5W9CnoFiaYoPlvVQjDIdpfyxbrw8ig3P6eLn1uHC5BYn5sqa+mcQbAnC/+TOxgPrUcw== X-Received: by 2002:a05:6402:2747:b0:640:abd5:863d with SMTP id 4fb4d7f45d1cf-6499b1c2a09mr11674219a12.20.1765808268604; Mon, 15 Dec 2025 06:17:48 -0800 (PST) Received: from localhost (ip-046-005-122-062.um12.pools.vodafone-ip.de. [46.5.122.62]) by smtp.gmail.com with UTF8SMTPSA id 4fb4d7f45d1cf-6498210ed32sm13548630a12.29.2025.12.15.06.17.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Dec 2025 06:17:48 -0800 (PST) From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Jens Wiklander , Ard Biesheuvel , Maxime Coquelin , Alexandre Torgue , Sumit Garg , Ilias Apalodimas , Jan Kiszka , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= Cc: linux-efi@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, op-tee@lists.trustedfirmware.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 09/17] efi: stmm: Make use of tee bus methods Date: Mon, 15 Dec 2025 15:16:39 +0100 Message-ID: X-Mailer: git-send-email 2.47.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1644; i=u.kleine-koenig@baylibre.com; h=from:subject:message-id; bh=U2aCK4CwX4oX996AKQXtxl/fnEvZCMh7YIAYyx6fXTo=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBpQBhiuTDaNseAt3EsBljDKzQwacM+pSRuQiPAQ arTLi9z4TCJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCaUAYYgAKCRCPgPtYfRL+ TnPbB/93KOuWIwDOJ283H+/wb1IIrgxqlC+DspRkdayu/Cjo2Z3TLbCwKyVMa5P6gZTnCDpH9Si 8rY5VZw8XaCqtqlLyVXjKit0WM5xeWDSRTlO+Q9WpokHiBxGfYIyP6YwTr+uo5OUlZshddxiDMz 2SQfGZcAHDksHjUDaPeVnlK7IUY6b0gcAmXFtPxNMEs4g1V8A58bIiOWqeAH6qjmW/P1Cxu7xac jYyR+lv+iCEhcIfMPVN9z2+RE8RmB7GbwgvuIPvs3GJJEULWKqdkcmdpkMlwQ48qO2LpQPvrvw2 Iu45H6xt8WaFrlDiRp+l+5sICtpI1uY89HTZulc2m2fYD7tb X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable The tee bus got dedicated callbacks for probe and remove. Make use of these. This fixes a runtime warning about the driver needing to be converted to the bus methods. Reviewed-by: Sumit Garg Signed-off-by: Uwe Kleine-K=C3=B6nig --- drivers/firmware/efi/stmm/tee_stmm_efi.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/firmware/efi/stmm/tee_stmm_efi.c b/drivers/firmware/ef= i/stmm/tee_stmm_efi.c index 5903811858b6..7b04dd649629 100644 --- a/drivers/firmware/efi/stmm/tee_stmm_efi.c +++ b/drivers/firmware/efi/stmm/tee_stmm_efi.c @@ -520,8 +520,9 @@ static void tee_stmm_restore_efivars_generic_ops(void) efivars_generic_ops_register(); } =20 -static int tee_stmm_efi_probe(struct device *dev) +static int tee_stmm_efi_probe(struct tee_client_device *tee_dev) { + struct device *dev =3D &tee_dev->dev; struct tee_ioctl_open_session_arg sess_arg; efi_status_t ret; int rc; @@ -571,21 +572,19 @@ static int tee_stmm_efi_probe(struct device *dev) return 0; } =20 -static int tee_stmm_efi_remove(struct device *dev) +static void tee_stmm_efi_remove(struct tee_client_device *dev) { tee_stmm_restore_efivars_generic_ops(); - - return 0; } =20 MODULE_DEVICE_TABLE(tee, tee_stmm_efi_id_table); =20 static struct tee_client_driver tee_stmm_efi_driver =3D { .id_table =3D tee_stmm_efi_id_table, + .probe =3D tee_stmm_efi_probe, + .remove =3D tee_stmm_efi_remove, .driver =3D { .name =3D "tee-stmm-efi", - .probe =3D tee_stmm_efi_probe, - .remove =3D tee_stmm_efi_remove, }, }; =20 --=20 2.47.3 From nobody Wed Dec 17 03:59:53 2025 Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 67C1229D291 for ; Mon, 15 Dec 2025 14:17:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765808277; cv=none; b=J/b0BBS956sYdmHCejw40Nsf6o8Npm8AjDS50BdTCo/QC3bnMuvFHCunluPireQZ7h9bSWaPCD0jihHl15EggQEcA+X6BuLku0v+Pnkxy9wncZnRDKMHDtyzOrEOwbTwcPfN6Oks3r4CIc+X/cenN6XI4qdOg83QNckR6R+3NdI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765808277; c=relaxed/simple; bh=djoazKNFNWBpRKVOu8VgnZQUMBy5m2efHrrhLCTajBI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Vv9vbSCcSo5R14dDaelkUxaH1o/NEzDUIPNSooEq8fEdUq+9aCmzHYz/PYbu2Bu2dn2xVzgjSZNtUzdoB6om0tC0VtdprkhgXHP2b3Y2gzMcV2Ppa8ziWrFegsMu+ChqZCo/J/T6gw85V7rsoidZX9Hafnhjmo4MiOR1usmJols= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=Y64eS6Hw; arc=none smtp.client-ip=209.85.208.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="Y64eS6Hw" Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-6499159273dso4304718a12.3 for ; Mon, 15 Dec 2025 06:17:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1765808271; x=1766413071; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ZKbJnfJE7xkWU00mrWTEhz/b//1iCTobbbTcn9iMvYI=; b=Y64eS6HwSS+LjS1jF7Uq6cKyFWEk4XXBpea6jVT2NhXvx+8v+eQK6H9svLfXkgW+D1 sSGRLimOQcH25SNvo0go7O0bKeiEBjXfummuhgj6/P7jEkciZWHaZ12T/bvGJTMCSRJm AhcXae6HrcaHMNgGbK/KzZN/GFd2qgzo1ApB6dJdMYhFAXPBJQGOAQOjas7jl8OFLubt iAct+6FnMIs5ikIl2dRhESy07l0O/u77mkckEI5o0lceVk7dS8j6niofJElsd8RPan5H bVsWV7bcuH6EUNKQwqVYfx5iCKzWBQdlXfJP2Aj/ux3DvQQMS1L1KeA3Qc0cGqnc+LFF FH3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765808271; x=1766413071; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ZKbJnfJE7xkWU00mrWTEhz/b//1iCTobbbTcn9iMvYI=; b=v23WbmktAaj1USKUXl1YuKRJ7MhqzQzys6T0fM0TX87AJh3JnPuSnioDlY+Qm4xPkz dc0v7tu1cXFUNtHp2U8UFsTMwTISPLvfxHDpMPi6uveqoMUaq33lh89uoFzVtx+mYzK/ j2Rt8fbW7hK56eJyCkTrohoHIPKpzWo0w3ItJ/evdiYR379+8GUH1y678AlzB8wLpsT1 kj4aiDNQyuSKnWaQqUpOPZ6s4UL+ch7ZxmNb9Xcwt/KJiZbqFx1tgjw+ATkZvCMX9FZr 0KoEiNhzRu8GHGIZ4EdGrXVsx7hQ/mJSf3Qdcw89PgBYEomzlTcrn/iFqbYDCnpsBUwt x/AA== X-Forwarded-Encrypted: i=1; AJvYcCXzpgYbMrdo+B945ZMVnL5zFR+q7RDD1CBScQwZGITjATILHoSiy6n+uGsov+9Fg9dvdxnwmQYRIn6sowc=@vger.kernel.org X-Gm-Message-State: AOJu0Yyw8iUeNbRxZIN432MZSFSO102atHdmgx8JpwS+5XKrgT2mkOrG 1OcUE8IGy0gGRvL9ZxgCgsMdnlG4fpGEQxeinL9Z9gSlET0wPFQQddJ683qLKm3gzcA= X-Gm-Gg: AY/fxX4trzaZVFX1/ue1ld+MpTB2YbS/CbC2fFNWFHkZIvruNwMjOGOATQJZlWRJibN 1fGXoLFYtClTXsDQ5FVD7ssTvVt7Q6ztzJ4sKvQSkoLVBJIZugDkMfA4YOk+k8gzMOnqPQPP8Kv XBfhNAGVMEFpokRzUetZ9fcn1qPiteOFx7D+/oDwY8DtYhvA04tYpSLDbSuOpAW3Vhqry09inxZ R8QHHwlJZ5olWE4WDYhhyslD3aUnWEX4Bv2o62Zp9uXeJysDsro4o+x8y1htFJBXQUWqY5nvR/K LfVjWqSfbJYbK7B5bARyQ8kieUtfbcnkEnBDs2JCyHUrUDwQwkVc72/+RKd+KlzQVnNEflSjIMO TfS4wEYinljndn91VEjw2/2cNm9WP/KHXOqoq3tu6k42IkUDvqYjO1XeHP2dMFTNhpYiXqFJXwR gklr6jlM433wndWjZBFMj0PyL/ceCOcZ4Q04iCF7cwOW0hPjSWlQgFuk0jNw== X-Google-Smtp-Source: AGHT+IEeSJVfJZs2amYWw+KLmEmBNVhUpqN/6+ZL8YgyOFyTuCX5haEwqwHXINz3XjvZu+mkawojpw== X-Received: by 2002:a05:6402:5190:b0:649:cafc:2656 with SMTP id 4fb4d7f45d1cf-649cafc26c4mr4434360a12.11.1765808270921; Mon, 15 Dec 2025 06:17:50 -0800 (PST) Received: from localhost (ip-046-005-122-062.um12.pools.vodafone-ip.de. [46.5.122.62]) by smtp.gmail.com with UTF8SMTPSA id 4fb4d7f45d1cf-6498204fbb3sm13523660a12.8.2025.12.15.06.17.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Dec 2025 06:17:50 -0800 (PST) From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Jens Wiklander , Sudeep Holla , Sumit Garg , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Christophe JAILLET Cc: Cristian Marussi , arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, op-tee@lists.trustedfirmware.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 10/17] firmware: arm_scmi: optee: Make use of module_tee_client_driver() Date: Mon, 15 Dec 2025 15:16:40 +0100 Message-ID: <983988a9020a2829bbedfd599fb6a52f8867e37b.1765791463.git.u.kleine-koenig@baylibre.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1534; i=u.kleine-koenig@baylibre.com; h=from:subject:message-id; bh=djoazKNFNWBpRKVOu8VgnZQUMBy5m2efHrrhLCTajBI=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBpQBhlaY2qxCEcyR8weby9a0kZHvfdpLdOH2fIH cLAkAUU1SWJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCaUAYZQAKCRCPgPtYfRL+ Tm8KCACFX8eQzR1FU1YYCPyj7bjkaPb1IJMAne74xoK4zA3MizdDdnVj2jg38iTR72qB2ShDcYl m5G5Mnl8h4+UfOlGR5qzEmCbu89xesxDd20Sw95hoAUVz0pmelASWucFk/Jd6VnV3rG/n7NZo22 +3EQyvtFlSVGKdWFk2qXUJxXteCmVDN7EZGLLs0sR9tZ1VSESx2gPy+4AKC1jd7FYaliy79sV53 VKQyVvFcddYJFYjP6hQxEvlwnEScer6VulhTzAxgkG2lUsElYoPUmoSnEu0FQInj+ge7ThPx9HV g+mRx396gQ39PUOMdWVo9ck0W7i0qCVcz3/vA9UQ+E7jL/UP X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable Reduce boilerplate by using the newly introduced module_tee_client_driver(). That takes care of assigning the driver's bus, so the explicit assigning in this driver can be dropped. Reviewed-by: Sumit Garg Reviewed-by: Sudeep Holla Signed-off-by: Uwe Kleine-K=C3=B6nig --- drivers/firmware/arm_scmi/transports/optee.c | 13 +------------ 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/drivers/firmware/arm_scmi/transports/optee.c b/drivers/firmwar= e/arm_scmi/transports/optee.c index dc0f46340153..8fdb80d3fabd 100644 --- a/drivers/firmware/arm_scmi/transports/optee.c +++ b/drivers/firmware/arm_scmi/transports/optee.c @@ -612,23 +612,12 @@ static struct tee_client_driver scmi_optee_service_dr= iver =3D { .id_table =3D scmi_optee_service_id, .driver =3D { .name =3D "scmi-optee", - .bus =3D &tee_bus_type, .probe =3D scmi_optee_service_probe, .remove =3D scmi_optee_service_remove, }, }; =20 -static int __init scmi_transport_optee_init(void) -{ - return driver_register(&scmi_optee_service_driver.driver); -} -module_init(scmi_transport_optee_init); - -static void __exit scmi_transport_optee_exit(void) -{ - driver_unregister(&scmi_optee_service_driver.driver); -} -module_exit(scmi_transport_optee_exit); +module_tee_client_driver(scmi_optee_service_driver); =20 MODULE_AUTHOR("Etienne Carriere "); MODULE_DESCRIPTION("SCMI OPTEE Transport driver"); --=20 2.47.3 From nobody Wed Dec 17 03:59:53 2025 Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E8A5A33DEF1 for ; Mon, 15 Dec 2025 14:17:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765808280; cv=none; b=qdo5EaFm7gkuRk83ZMYPWsR/bmtg68lTxeXikjgE2vjQjJGH27/O3mBkQ14fC4ZaYxxyD8TgOHf9o4Bh+kKR5YZk9v8+foxslWrKx+TrNjo0TnRS+XEe+E9Xjey5FApy6hUSop7fl5wYRBMIf8IFKqfX91lPThhRmBtWigjPfbM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765808280; c=relaxed/simple; bh=4A/9VAHmTaZWnv8JgiT7H1qCJuRsg+ML7SSaVfNtUv0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=WXzz6egS/n9i7+NLUD1k/hDbEdglHjGj1cu7LzV55xI4RRZvD94cD39JVf+mb4GtG8QjaCn8Z0qM//JdtxaY6HGdg5tcS7r4IEiQzZ/ttHUFGQlw0oc9wYmQMYX8z4eCyiD3GF5e4w3OalBQlsK05nye5elZT9EKpxmoQBTsW5o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=mm+vn8Iz; arc=none smtp.client-ip=209.85.208.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="mm+vn8Iz" Received: by mail-ed1-f52.google.com with SMTP id 4fb4d7f45d1cf-6492e25cd7eso1240523a12.0 for ; Mon, 15 Dec 2025 06:17:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1765808272; x=1766413072; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=sfzDwdLQJZM+QWaZp429a9MEMQ68gzEG7kbM26+AAC8=; b=mm+vn8IzC5KfpdLYgEU6KpMr4FaNGnqtVc7NfPa8oDlyyfkwbZ9JBhQfzxIwYVfNQH +lFEAH78R3djpoYCQSSLSGyXJB0wOUbAr96TlcOEkS3ElR5ifMSJFOlyk+aN97eeE7aX 0C4PWbDAwVcuBJnFe/2y5f1pmBvlbfk/odUsRxG/JNltcpVNddNU57A+TQeBGzQxrysh zn7+UhKFbO9d5CDa/dJq9uufSkJTsQQXucOaD7cejll4aL65oI9E+e5OjAg3xCsLMTq7 M/bTVqCQsJEuWeN+KwvWv37TSd+3uslxq8I+0qggaQTZtp912S1GPFE8mum0bXXFVXQI hDEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765808272; x=1766413072; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=sfzDwdLQJZM+QWaZp429a9MEMQ68gzEG7kbM26+AAC8=; b=XJQTTq/yG978eiyBI9AW+3VgQ0d67Ghsx3Ae0zdxZNwbOq+qwb0EC7M0jxTLHBiFxK syZmaD5kEYDZJHz9llQAnnWey/U/2JQqDdmK+CMzae8DjOgs/sCcvHipQpyvG4N+gcQp yquyw+r5FzaucVk952FlLAHA572bwQddNvbOECKNtS1JMhfVnNjyJ78wMOy9POfMXWCB y83WgWXso+GznwlDh4KlXa8/byfxt18gftIOrdv+aUJQouQ9JgDBrijNOV9M8squI2aa PTI+D6z8jfipCKt3nrRFnlPGKS+/EAXYio1GAOsK7he/s4EHLa1/0e/v0/xiJCQ+DUxT auUg== X-Forwarded-Encrypted: i=1; AJvYcCVxe9bVFS+K0GDssiHRrxuablE1XdhSAyIIRpZVKUvswI35nWWvjo4cfgTIsciEAisE0iFO4rAMLG0r+YE=@vger.kernel.org X-Gm-Message-State: AOJu0YxnGzFimai1C9r00Z/mQRgWW/wUaZHLVj5jUBeVdRa7wjf7VSo/ H3Kuq24zuRVUAqrk6M9nR6np4BlQngcc/sZChK2jA2iznK2sN2oy7eAC0d3uy4/9Wrw= X-Gm-Gg: AY/fxX53Qt/AXFknLBsy2hN88gBdgUgczYhj+AqoPsyGQM6wphYC9kRClfPFLspJjG1 NmZ40c7HyLya+44oezk2uZ9LgvPAW4kSU6p3UOH5PJTqO7UUuTcY5wVT5KctCBm1wR3123UFld2 gapduHnwzXXoUORcT7AoKX6pKLW/K9CdU3TUusBrp+qXWsf1IKW/cl2LcDLRd2Nk8g9RuaKxutN jXMVqvzw/4f4FalwGCy/4I5LEf6gNDm598cnYr+5M24vvU2sNzBnpwMUSrmnG+9UH55h0sy7bm+ NCsWbryhTncvQKsQbVKvIoJREydv5OVS+1/ymV+tnOOCOHW7VcGqP3TGB6/URnJ61yNuTllzusy 7Vc84PlCV4236/bZ+jxYyD0cJoUwYZTEQBtuBGvxUnEgAKEfZSV1vX4QktE+llCN/7ZNVGOlIIh 2mPuIVhOJkZX7I/qyaY9BHGuWmG8gTKQ8mtznaJOFJ/NSltRdque1R5IxKYZbvho0aRCaq X-Google-Smtp-Source: AGHT+IFOJgC5Ya2iL64i8Tv4dTF8QQYDLC4+J0wActxyot5OM2vMJCd/KcUe/O38HWI5lnvavkRPtA== X-Received: by 2002:a05:6402:345b:b0:640:abb1:5eff with SMTP id 4fb4d7f45d1cf-6498745b430mr10332378a12.8.1765808272372; Mon, 15 Dec 2025 06:17:52 -0800 (PST) Received: from localhost (ip-046-005-122-062.um12.pools.vodafone-ip.de. [46.5.122.62]) by smtp.gmail.com with UTF8SMTPSA id 4fb4d7f45d1cf-64981fa5514sm13619843a12.0.2025.12.15.06.17.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Dec 2025 06:17:52 -0800 (PST) From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Jens Wiklander , Sudeep Holla , Sumit Garg , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Christophe JAILLET Cc: Cristian Marussi , arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, op-tee@lists.trustedfirmware.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 11/17] firmware: arm_scmi: Make use of tee bus methods Date: Mon, 15 Dec 2025 15:16:41 +0100 Message-ID: <859339714ce238c34fdc4832fa23d6d6abec6ba1.1765791463.git.u.kleine-koenig@baylibre.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=2594; i=u.kleine-koenig@baylibre.com; h=from:subject:message-id; bh=4A/9VAHmTaZWnv8JgiT7H1qCJuRsg+ML7SSaVfNtUv0=; b=owGbwMvMwMXY3/A7olbonx/jabUkhkwHiXSzA2c6kuc0awa3zu+SCZ668nFKvHWuQ19u+6RrV +fOP2TSyWjMwsDIxSArpshi37gm06pKLrJz7b/LMINYmUCmMHBxCsBELnWw/7OWWaMvsKvlGqeJ z1e9vfb6bD16p1Yo+j3aH1+h4WE+cR+rYGip+ZscsVOCdsvEzzEe/2OuPX1C0dzONVfenBSXdO6 e1BtrkaJnFXTX9qFbVku81gGHfJl9i7dtXOw37fxuLncN9+t2MjZ9TFN03JkW/zSd8+Hcdrf3Yu pCDWLba9+rzpdm/bDznlWxX63nqrDMdlVjC6bdwWea7PgbbQsaD3usDXjRmnko2+n6OT7dn1PuK vutPc98QFulL1RplW5+csjilybqX3IPKcRm3Xw5LW/Jft5d9ns+zE+5xtCrPjX07ZFLfxQsBcSi Jt3TWi4c4RbgyGilb3ldI3iztf2EVXo9Fy6eZON4E9APAA== X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable The tee bus got dedicated callbacks for probe and remove. Make use of these. This fixes a runtime warning about the driver needing to be converted to the bus methods. Note that the return value of .remove() was already ignored before, so there is no problem introduced by dropping the error returns. Reviewed-by: Sumit Garg Reviewed-by: Sudeep Holla Signed-off-by: Uwe Kleine-K=C3=B6nig --- drivers/firmware/arm_scmi/transports/optee.c | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/firmware/arm_scmi/transports/optee.c b/drivers/firmwar= e/arm_scmi/transports/optee.c index 8fdb80d3fabd..07ae18d5279d 100644 --- a/drivers/firmware/arm_scmi/transports/optee.c +++ b/drivers/firmware/arm_scmi/transports/optee.c @@ -529,8 +529,9 @@ static const struct of_device_id scmi_of_match[] =3D { DEFINE_SCMI_TRANSPORT_DRIVER(scmi_optee, scmi_optee_driver, scmi_optee_des= c, scmi_of_match, core); =20 -static int scmi_optee_service_probe(struct device *dev) +static int scmi_optee_service_probe(struct tee_client_device *scmi_pta) { + struct device *dev =3D &scmi_pta->dev; struct scmi_optee_agent *agent; struct tee_context *tee_ctx; int ret; @@ -578,24 +579,22 @@ static int scmi_optee_service_probe(struct device *de= v) return ret; } =20 -static int scmi_optee_service_remove(struct device *dev) +static void scmi_optee_service_remove(struct tee_client_device *scmi_pta) { struct scmi_optee_agent *agent =3D scmi_optee_private; =20 if (!scmi_optee_private) - return -EINVAL; + return; =20 platform_driver_unregister(&scmi_optee_driver); =20 if (!list_empty(&scmi_optee_private->channel_list)) - return -EBUSY; + return; =20 /* Ensure cleared reference is visible before resources are released */ smp_store_mb(scmi_optee_private, NULL); =20 tee_client_close_context(agent->tee_ctx); - - return 0; } =20 static const struct tee_client_device_id scmi_optee_service_id[] =3D { @@ -609,11 +608,11 @@ static const struct tee_client_device_id scmi_optee_s= ervice_id[] =3D { MODULE_DEVICE_TABLE(tee, scmi_optee_service_id); =20 static struct tee_client_driver scmi_optee_service_driver =3D { - .id_table =3D scmi_optee_service_id, - .driver =3D { + .probe =3D scmi_optee_service_probe, + .remove =3D scmi_optee_service_remove, + .id_table =3D scmi_optee_service_id, + .driver =3D { .name =3D "scmi-optee", - .probe =3D scmi_optee_service_probe, - .remove =3D scmi_optee_service_remove, }, }; =20 --=20 2.47.3 From nobody Wed Dec 17 03:59:53 2025 Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 85B0A33EB0A for ; Mon, 15 Dec 2025 14:17:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765808280; cv=none; b=rOoYjCwq2EaXknxWfDyK38SONyojDFAwzHs64A3kWNiZNmIG+XQV6QkSbGGVAPrg45neNRa4WeCRA2jUBc3/9uGv7zJdubnniYaNZdPQ7498mT50zlSkVDzh9TGnHt3L9eioakn/qpUbiM8QS+Kupd24lmbmWgiUB9xCQTV9JOM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765808280; c=relaxed/simple; bh=KuzBomJ+2b6IkLEr6dylmkMduKhBvGwTMDuWUs1IqUQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=BWkJ6L3KRc2c+QSjOY+RGumfPNXv2zJoDGhuLwJIF47AOSYVqWN00cmARI0Oy2pe3wMowpLsz2NrdV9dxaL3D1oyO++glEg6ynjmVEMv6/o6j8Qce4kSTki8x/4j6jVw5zqnhYe6VLNnsl9l5pNVTbdCEnBQMbLrRVJNLhxKeQg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=GHfUKKIA; arc=none smtp.client-ip=209.85.208.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="GHfUKKIA" Received: by mail-ed1-f51.google.com with SMTP id 4fb4d7f45d1cf-64981b544a1so4742155a12.1 for ; Mon, 15 Dec 2025 06:17:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1765808275; x=1766413075; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=tz/rLe0gEEPSg+6BoTZK8cqpnlYbSYNZB83UFAX5Ufw=; b=GHfUKKIAYVKLvy09ubIhhIgS7Iiy9f4fcOTP1Uw6+Eu47oaOvce+moUrZ9APBpAnbr 1x5O2j/riRKrnvSpor3Or20MTA08jmXLRRfCsXNfRk9Ft88GYomfjR0nuWyQqnUxUNLB MSf56mbGr3NjPJPhYKtIDu57mCmVqMuRfTcMrvHDWc2dxocuSb4R2UQxVTiPY4psx7uT yJCotxm/g3MAho6vaBxEDHRq+qVFsk1frhoRzn21CtcTK9yBVhjtCANlBsxOJCUYwBbN X5kwvKwnhTemkpdy+leMkV3G/jzUnnSj1Rg9aAc+0xvr0MSmxSY+AOXP3skq0xeChrgB NVEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765808275; x=1766413075; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=tz/rLe0gEEPSg+6BoTZK8cqpnlYbSYNZB83UFAX5Ufw=; b=TnBnEApbd9y1ZQFMjDoGXJE7Jyr2yu4+Ng+lBTvtHEUpNT9HzY6zXaEEm91/f8XHTT UQIn7OaN8RkYD7P3aDglGz5kGMnQlfdoj8IcQtnZkA1VR8/YwIU69//e3va4d11olsRC U1iBjPQdmnpsO+P8p8oex+mbSlU58p+PPq/BEfY4l9S8Ao61D3KCWEbIINfYvLR6MWzk 8gXBDM8p8O/MUd3s0wIzTQwiLW0ocWnPisKNjSXn0I19jiZNpcrbWLwoX7TtzWDlM4Oy k/Un9BFI+fiJLnvzqcJhKikWLWUuMrjN1z0dIfCdAk6mg5jsCnnX7sHBS50ot4Om9VY5 FPXA== X-Forwarded-Encrypted: i=1; AJvYcCVPUtLTiL3jQXKbjDYFmNcTyyz8tiwalIGjFQtnE55gNWfjaBqLuYyRdwpOjXvBSRMSai3v5Kw0Su5CNDY=@vger.kernel.org X-Gm-Message-State: AOJu0YwbAQzTdvkv/3oKy2vPlzNm84WgzHoNrzxKXx+tl9Uh74EZ34Vc M7Un2VVmSGPAL5Nq3XlxaaPGW/7puL21wkBAG43t/Nk7k13B698XtGXI1rCufzBPZpI= X-Gm-Gg: AY/fxX7KrSMqC8trI0qEvmsu0H1Picq2TyWEyvM4hrncDrokpwQNmbByNzMHR8dxYFt aOrMK76PZo8qmMonkxMJeiWTtlCktof2Y4kTk15llrs3GV7BjSJALxsQmz2FH52uA14BUucev6L kPGX5uRBIj2j9kcXm9exJHdkcihDbVGsRwoJ6THxLa+8TWIeiBmOutbr0/QvmZ0QRv+OOKzpKX8 CaMxCTnErPFWKDMHkr76NVKukdDxVrmFbbe/20W9ueCJ7U4tDV8Ow+gQQLjjP5qNFQjdZ6bFgCa FCCEkzn4pDcM2AOjXpz2OABhK6CZggGOPIh95r42x0bNjz6UUhgZ2ebs6O7lbkW6FZyJUa1cwJg 8jv5KwD+Qc7PWUT/pjW4JPswc8TnBdGUWRoAVPM/q1M53Kt480D2OHZLLxy92zbsbB/HzHtr6t/ 6p3ZcUjTW2Kfx4yCqMA9DIn1EWp0y7gJ5Um6HO8MsV5gl9auej9suE0s4+hA== X-Google-Smtp-Source: AGHT+IHXNUiy/5yBOT4dn7umwiox+CfDP3uCJtKbMP9NvLprVYwnlB88jSKq4lkDDOMP5RZKyuAxog== X-Received: by 2002:a05:6402:4404:b0:647:a636:76c with SMTP id 4fb4d7f45d1cf-6499b1f8b4dmr9871722a12.31.1765808275438; Mon, 15 Dec 2025 06:17:55 -0800 (PST) Received: from localhost (ip-046-005-122-062.um12.pools.vodafone-ip.de. [46.5.122.62]) by smtp.gmail.com with UTF8SMTPSA id 4fb4d7f45d1cf-64982227ba1sm13523693a12.33.2025.12.15.06.17.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Dec 2025 06:17:54 -0800 (PST) From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Jens Wiklander , =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= , Michael Chan , Pavan Chebbi Cc: Sumit Garg , linux-mips@vger.kernel.org, netdev@vger.kernel.org, op-tee@lists.trustedfirmware.org, linux-kernel@vger.kernel.org, Sumit Garg Subject: [PATCH v2 12/17] firmware: tee_bnxt: Make use of module_tee_client_driver() Date: Mon, 15 Dec 2025 15:16:42 +0100 Message-ID: X-Mailer: git-send-email 2.47.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1438; i=u.kleine-koenig@baylibre.com; h=from:subject:message-id; bh=KuzBomJ+2b6IkLEr6dylmkMduKhBvGwTMDuWUs1IqUQ=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBpQBhplUIGHxY+kNc+ZnO2NN941Q0i8QiNARXnc uHMb9q9vG+JATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCaUAYaQAKCRCPgPtYfRL+ Tpg5CAC2TR34NPIIYAuCMyG/P/V874WeW0I8DBjfDj1sHTP/b5eQM9txRkeuAySo9lTtzf81I2A YZ13WAyDX0adgP5RhgtEsjfa90Hk+YTfNuszrHVf/XL2FMVoNxFvv+x2DqypHVM6eguDjv2F39L b+/hoVh6XHoGrr0U9KvJ3Pm15CINftKatRbBgm85spaL315JL78QMLhLet2I1dzCLblTLOBPSNk 5vB00SoF4E/JkOme7zwKoKdBozHPHlFCH6koMJTjAsB0HswWjxs64c16CUl61+W/4tJQYUniXof 8E4qisqElJ8CG1CgS6EqyNLPpVvFhWBQL2mUY7EZtOKt9jrf X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable Reduce boilerplate by using the newly introduced module_tee_client_driver(). That takes care of assigning the driver's bus, so the explicit assigning in this driver can be dropped. Reviewed-by: Sumit Garg Signed-off-by: Uwe Kleine-K=C3=B6nig --- drivers/firmware/broadcom/tee_bnxt_fw.c | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/drivers/firmware/broadcom/tee_bnxt_fw.c b/drivers/firmware/bro= adcom/tee_bnxt_fw.c index 40e3183a3d11..fbdf1aa97c82 100644 --- a/drivers/firmware/broadcom/tee_bnxt_fw.c +++ b/drivers/firmware/broadcom/tee_bnxt_fw.c @@ -261,25 +261,13 @@ static struct tee_client_driver tee_bnxt_fw_driver = =3D { .id_table =3D tee_bnxt_fw_id_table, .driver =3D { .name =3D KBUILD_MODNAME, - .bus =3D &tee_bus_type, .probe =3D tee_bnxt_fw_probe, .remove =3D tee_bnxt_fw_remove, .shutdown =3D tee_bnxt_fw_shutdown, }, }; =20 -static int __init tee_bnxt_fw_mod_init(void) -{ - return driver_register(&tee_bnxt_fw_driver.driver); -} - -static void __exit tee_bnxt_fw_mod_exit(void) -{ - driver_unregister(&tee_bnxt_fw_driver.driver); -} - -module_init(tee_bnxt_fw_mod_init); -module_exit(tee_bnxt_fw_mod_exit); +module_tee_client_driver(tee_bnxt_fw_driver); =20 MODULE_AUTHOR("Vikas Gupta "); MODULE_DESCRIPTION("Broadcom bnxt firmware manager"); --=20 2.47.3 From nobody Wed Dec 17 03:59:53 2025 Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D99D33E34C for ; Mon, 15 Dec 2025 14:17:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765808283; cv=none; b=gE6J+qVQD0bYK0EW1wzqckOqLSObnY9gOL94kvTSjyoPi27eS/6ye7S0X0Nwerwlr2SOgqHlKTXi/QT7MTA/HKyqs9XQ1HI61DxnyLtYvkMpXNGWTd+3RoZqRphnv+405BQFMlY2bmxBsI/hDQU1zJyJuG8Eoyf3tC1kzIqfKvM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765808283; c=relaxed/simple; bh=Kkjk2HQyXaBvr0FeLY8PHK1oOoMWNcJDWQq+WFZGpZA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=qQZUQpW9QfXlZADRDB8Vmhdi6k4I1EK9XV8fv8ArEx8C6TdK7oLDdQOFquieNXrWTiwmtQ/uXxGQXOcBPADX61o+P3ZHabiJSSB1gjRVTklVnScoaRlm9GzM5E4qhHhPXvoO7fEX+xffmSYSv2EcEQoziE0gdxHQsEX4ayXijDg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=LBjmBYOw; arc=none smtp.client-ip=209.85.218.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="LBjmBYOw" Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-b725ead5800so534783966b.1 for ; Mon, 15 Dec 2025 06:17:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1765808277; x=1766413077; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7iqJF7orvlMqhIrghvfFQasl/uMqZ7gfWiSQOSJzmXI=; b=LBjmBYOw/a1epGCKyuNDnRTSqpAXSOdCu2WsyKxvKWCjjxDlfYSNvYCYC7BnJmOoMG LHw1tY5MqS11eoZD6IOIGMH5nMs7bdLI/nmAK3+pqzj3YFYNsPwL8qY9KnvzBWzbyBno DbxUfdxtr36sCNu8aheqQoyRuC1YTAv5JLZaxs19V2O6QMeD0i8Fxi+acdkjFkODE1CA x08I7v/U3afCPwGBLuQn3w6wTS6DzUp4AJhVXYR/YFlytKw+pqtG7L4p6T7UZHXHTUH6 CeCzAjNqn9lEjoRCq9mk9knpv8mA/k5KmyDUc8hVof2JC3O6o8o3O0cFxXPHw8mVSvFT Wt9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765808277; x=1766413077; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=7iqJF7orvlMqhIrghvfFQasl/uMqZ7gfWiSQOSJzmXI=; b=cp7HC2UkKIUuBALIOXXofUp98TB5yAJX+Aeui2BKD2em4ZfT69usu33V15ui2B4n01 l3iZd3/OjvDW4X/aVLrkpB0Wy7F6w0Tgp9DhCr0Isuys1bhPj5ldQ7soST+ahd3NEKgU 6Pa1mDS/fTfwjv40RVk2kaa02kWFICsqMpirrikLQt+v1wLhTCuvMVOK4Tzj25Npqyi0 Gs5O+I6ZxM4RagqNi3N0fqYfgROwb6YpmqiEdrcG7sObXrrlVSWDgin0EBBiDNMK8yL/ u92TpSzLCoy4DHXymrWCgbgMkvPCTIbD2ldlMkjt1yxujlV+9h+44B2eq+lEsjEM3rkQ Czog== X-Forwarded-Encrypted: i=1; AJvYcCU5PYC1IMTZYxz9l2DmlEfBmnY2pRQ+NZcVa8Ke986I7tLvxuhgP6PKF3fr8psp4Sj6QHdyQca4s7d/f1c=@vger.kernel.org X-Gm-Message-State: AOJu0YwEFAf4DygtHBr/uBkiFEq1JL8E7pPrCFcKxAl4XLlVO//u0Mxc RvRdIZujWo4s1Dv54ggPLAmEQIMWpui300XcDWuJFt1vs3B/VaBLvQ0d2t2kXBs3jHg= X-Gm-Gg: AY/fxX6CcefQsbcMnoTdF7Vp9R6ExR4z9KE14UrpBjsmXpqb0TPvlNrH4SOlUznDsYQ jKKr8Kt1bk/WBBmfhzrAl8FO5C3NRYFvetUzcJW6rupK6ZGpvToeaO0qGhI0OvY+IqE1AOuoQWS IPkN9+OHm1YlbDb+Z9YBK9EcOoa/Y8kndVp4+hjSoAOrOVRD4nC+py6AvWAMGKBgQwVKEcsMD49 HEuoTrNs4hXQoHNUZKm8pXkK25UGV1za/XvLaTOe4XFzxY+AAYFxDwVvyTBtmus4psLkdUWbbpz pmIGcUXlZh3Zdu2Fwm+g+W6Pq0hXwOCIetUh5NGINcxnvsyYMH3kuIbkRQyoZQqb40P2qw/LXoT SGdEMxdwR0P5njxvMYcxV+REo/GtWx5Lq04g1cOEp3PkiEQdH8HwB3nWNSfhxNLSeIuLydnE+9l VSuXkyfLm3ods2MTVxVeAWzJxPvirbteKNcF3lcdojJ9c2Iwm8MaXV9a6bsA== X-Google-Smtp-Source: AGHT+IEPjHTBezRQ3PDr8F60Bso0OUB75ZXwyfvhYmt5eGS3puxlFDVYpAwYmpGEYvObi0dAnABghw== X-Received: by 2002:a17:907:6e90:b0:b73:78f3:15c1 with SMTP id a640c23a62f3a-b7d23b92012mr1014789266b.52.1765808276856; Mon, 15 Dec 2025 06:17:56 -0800 (PST) Received: from localhost (ip-046-005-122-062.um12.pools.vodafone-ip.de. [46.5.122.62]) by smtp.gmail.com with UTF8SMTPSA id a640c23a62f3a-b7cfa29eb48sm1444020266b.1.2025.12.15.06.17.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Dec 2025 06:17:56 -0800 (PST) From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Jens Wiklander , =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= , Michael Chan , Pavan Chebbi Cc: Sumit Garg , linux-mips@vger.kernel.org, netdev@vger.kernel.org, op-tee@lists.trustedfirmware.org, linux-kernel@vger.kernel.org, Sumit Garg Subject: [PATCH v2 13/17] firmware: tee_bnxt: Make use of tee bus methods Date: Mon, 15 Dec 2025 15:16:43 +0100 Message-ID: <96f7df595a96f631b40c2c0a6fcf8bf7217d02f4.1765791463.git.u.kleine-koenig@baylibre.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=2314; i=u.kleine-koenig@baylibre.com; h=from:subject:message-id; bh=Kkjk2HQyXaBvr0FeLY8PHK1oOoMWNcJDWQq+WFZGpZA=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBpQBhsfHXkwvq5lo/liy5xLt/2zfSDHM/HASEZs rSXC1P7uA6JATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCaUAYbAAKCRCPgPtYfRL+ TjIHCACKt2PBL1ggi18gXW89o2wjtHLVPQLHCVpHjtN5rjdFvrbEnb8GMhyPmXCkVmVoss7QFdW UbeQereVoPtirVXXeCZWy9g9T0WSKPbeURogL5yJ2CUFbRV2xnjlstiWQSVm8Kqzp+SWAZYvYR6 Jztwhm3a/vQfJOJNAs+QMLGr29GLfItZLW+6/mxmfWWm/PF5PYmA21k/UylJImDTGlrdDl7dqRS jWesv1pzELsMZ/EHQnDEoPByjLvWWtbbrLxTZeTrZ+rN3pJcjTYAsDtLb2/VHlwBg2B397iMbbw yyAwbQOxcIWjlvWNJA4Li96zLkxmhy9Rrt6Lw5ZiJ62bSLDC X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable The tee bus got dedicated callbacks for probe and remove. Make use of these. This fixes a runtime warning about the driver needing to be converted to the bus methods. Reviewed-by: Sumit Garg Signed-off-by: Uwe Kleine-K=C3=B6nig --- drivers/firmware/broadcom/tee_bnxt_fw.c | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/drivers/firmware/broadcom/tee_bnxt_fw.c b/drivers/firmware/bro= adcom/tee_bnxt_fw.c index fbdf1aa97c82..a706c84eb2b6 100644 --- a/drivers/firmware/broadcom/tee_bnxt_fw.c +++ b/drivers/firmware/broadcom/tee_bnxt_fw.c @@ -181,9 +181,9 @@ static int optee_ctx_match(struct tee_ioctl_version_dat= a *ver, const void *data) return (ver->impl_id =3D=3D TEE_IMPL_ID_OPTEE); } =20 -static int tee_bnxt_fw_probe(struct device *dev) +static int tee_bnxt_fw_probe(struct tee_client_device *bnxt_device) { - struct tee_client_device *bnxt_device =3D to_tee_client_device(dev); + struct device *dev =3D &bnxt_device->dev; int ret, err =3D -ENODEV; struct tee_ioctl_open_session_arg sess_arg; struct tee_shm *fw_shm_pool; @@ -231,17 +231,15 @@ static int tee_bnxt_fw_probe(struct device *dev) return err; } =20 -static int tee_bnxt_fw_remove(struct device *dev) +static void tee_bnxt_fw_remove(struct tee_client_device *bnxt_device) { tee_shm_free(pvt_data.fw_shm_pool); tee_client_close_session(pvt_data.ctx, pvt_data.session_id); tee_client_close_context(pvt_data.ctx); pvt_data.ctx =3D NULL; - - return 0; } =20 -static void tee_bnxt_fw_shutdown(struct device *dev) +static void tee_bnxt_fw_shutdown(struct tee_client_device *bnxt_device) { tee_shm_free(pvt_data.fw_shm_pool); tee_client_close_session(pvt_data.ctx, pvt_data.session_id); @@ -258,12 +256,12 @@ static const struct tee_client_device_id tee_bnxt_fw_= id_table[] =3D { MODULE_DEVICE_TABLE(tee, tee_bnxt_fw_id_table); =20 static struct tee_client_driver tee_bnxt_fw_driver =3D { + .probe =3D tee_bnxt_fw_probe, + .remove =3D tee_bnxt_fw_remove, + .shutdown =3D tee_bnxt_fw_shutdown, .id_table =3D tee_bnxt_fw_id_table, .driver =3D { .name =3D KBUILD_MODNAME, - .probe =3D tee_bnxt_fw_probe, - .remove =3D tee_bnxt_fw_remove, - .shutdown =3D tee_bnxt_fw_shutdown, }, }; =20 --=20 2.47.3 From nobody Wed Dec 17 03:59:53 2025 Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 940BD33F38D for ; Mon, 15 Dec 2025 14:18:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765808285; cv=none; b=kNd/2mjvdjgd78hOs2mDspmDmdWGengnbl691xOFmUfase8N6WmpmVXreyXWideVawxiIjJlKxytnorH57gxFj+EmJHRMpeOnhX5r/YfbOU6k9aizwR+Ltf1VmJ8DVnL9t5gTH20uGzQlYwn5wr/QcBh+TcJCl5HTFPoGVSs/ws= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765808285; c=relaxed/simple; bh=Zg7mCOEZ4Z6I10BCWu77BY4uJ1KchHXm6/KivSfImCk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=n+80HmtWDhbA+HOxjCIxzjy/0WWk7HxPjEzog8VqjItgbTq21+SDs1xsyXKrkiilQ1k3mMFren7pXgUZTvZih0IPYuXwfyFgexx6lHolU3t9f2wUE6x0lvc1fsXo/UtDOp1FeUz5BRqy0yUIBSjzLbzSWQMVwsMnir6clxHLyPk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=euLqReZi; arc=none smtp.client-ip=209.85.218.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="euLqReZi" Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-b73161849e1so789523166b.2 for ; Mon, 15 Dec 2025 06:18:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1765808279; x=1766413079; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6+EJpP28ACswVH+s22Escdl3RH0kKfptytDh+TM4ml8=; b=euLqReZi1buW9Pt6pFNFg1JGQi6ms8IluV+HAjs7TSAJoOBB3hfCWEXlVAPXCTmRKJ /nd80Q3krOT0rb7g37WOv3lO1POnMZOPISgXRuRy92dm+jK+ZFw+xWsuR04N6KZZlf8R t3QmgdWnFRqRZluw3OBNlODMZoiNXRsnSj/pSsl++MIOObUQ/qozfHEVNnCP0VvwYAnJ ixY78zV/uOD5HPgZhrqg/bXdMLkIC9IsvCRAuQc6yHnP4UMaLuiq2DKwqwmU3kR/BzZ6 X2nTEvzrlMIOe37VNRZ/ALJ8IR3ZA3H3EEVzQ7PtFoBUOvul2UMZIVJpWZ1mq4xtMNHr GgXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765808279; x=1766413079; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=6+EJpP28ACswVH+s22Escdl3RH0kKfptytDh+TM4ml8=; b=NyPiNnAJ5YJMxMZp7ZxrNLE5sgmXRkPqkV4D8eJN8aERZYHIrlM+Jbs4IpMp5H2McK OCwp+iteeoN9/S4EsDjnz5jhQKAH6L9qAsjlrUJAo5tM8CF7ARUmc7/TrZ/wddHLeUdS enRULCFsYQm2yiyLm3OHcaBS97EAd0jOCRZey03WsQKBtY10jqvPwh1hzM5N8ww38T5s nQb4T8VeWagM1KXCdRp2Tmm+8eBHeAZAiQc9Jn79Dev5hUGJ40TWKowIQPbLl6z+COmp Lfe2z+H8UPVQ7cvywmBSPT8MV9F/ed8E1rS7ZSTTeMjM0hqP+ZxS7odOUTfuveDV1ZNU 6nRQ== X-Forwarded-Encrypted: i=1; AJvYcCVar2SDojOpVpFTmszvRgXQ2llKSA6WWBaa1GrO8DV150d4+auxpIA+XrSJTvXQomHM2AX+zpy/neOyzAg=@vger.kernel.org X-Gm-Message-State: AOJu0Yy30Asz+bI5nBFTAkp6pelhNECb7dexcnJUQ7XJBYl7js91AMwc u0z+2gCqsVjmtTzp6F1w/vdcUPqAJsfxBIJ3AqEAOLstBWwokXoKgaeG8QsnWbDybCo= X-Gm-Gg: AY/fxX6Sq/FYgXhePHRPYmbDybCdrFeC57jJzTaYTeHu9eUncnRzK+zBbkrf43rLYe2 mgJCCTe2XxXsquF7OYQaLBkH0+BJQGIesvtE9rRxF0ydfOZ7EFt9yaSPWwx2CMB0v1aBPZoHETC UFFOZtjt5jpPKz3/dvlJvF5TGOqEjvIZ+cFjKohuurelOnwm14RwznnjTzwwuQOOQrQ076jwigm 8uz7h75KuHm+DcLpSWNJIn0+bjxGeIQ2AHrQK/f2RhcQTR65DnkDj8Rve1auErsFWCcynOxnXTQ 4HQLimCCUI7KjVa95Rq8hRPb2xTtkYrZX4A+i6DjbkLTaCEaUbnlPT4GAoUPGLtMAo8LZErKC7o uGgpIa/eDv9NUwqBPf7gZIva324v+Ly8NxLHSjZjuok0x1JbRTjUT/hB8MmSwsITuRh6oJqJ2pX Q+KzK0MI5vrvRhIIrcxyeqpd3zXbB07aqspf5cCnNoT5eWytKSG5DJQj1guw== X-Google-Smtp-Source: AGHT+IEK116a+hzlpDVrTZCFE6XuiyE4/HJN0uW0RxfmRWXh+Z7K4wAXn5iM/HwRNMkehyWwuERbtA== X-Received: by 2002:a17:907:944a:b0:b7c:f5b6:bb52 with SMTP id a640c23a62f3a-b7d23a22c68mr1176743866b.43.1765808279239; Mon, 15 Dec 2025 06:17:59 -0800 (PST) Received: from localhost (ip-046-005-122-062.um12.pools.vodafone-ip.de. [46.5.122.62]) by smtp.gmail.com with UTF8SMTPSA id a640c23a62f3a-b7cfa29e060sm1447274266b.2.2025.12.15.06.17.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Dec 2025 06:17:58 -0800 (PST) From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Jens Wiklander , Sumit Garg , James Bottomley , Jarkko Sakkinen , Mimi Zohar , David Howells , Paul Moore , James Morris , "Serge E. Hallyn" Cc: linux-integrity@vger.kernel.org, keyrings@vger.kernel.org, linux-security-module@vger.kernel.org, op-tee@lists.trustedfirmware.org, linux-kernel@vger.kernel.org, Sumit Garg Subject: [PATCH v2 14/17] KEYS: trusted: Migrate to use tee specific driver registration function Date: Mon, 15 Dec 2025 15:16:44 +0100 Message-ID: <687c004c32718ba7044ffa9165f33842267a745d.1765791463.git.u.kleine-koenig@baylibre.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1462; i=u.kleine-koenig@baylibre.com; h=from:subject:message-id; bh=Zg7mCOEZ4Z6I10BCWu77BY4uJ1KchHXm6/KivSfImCk=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBpQBhuRfKfm9AOVl8Q/VvcEeDtJDpwUt6Lmf7cq XA9w6mZtvWJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCaUAYbgAKCRCPgPtYfRL+ TsZpCACirKqeCOo4fBLSL2yhYE15pWpKfHROUGgAZZeKbVTJC+rvy2kfsHLSn29V5iUFd6n/aBB RLMpQStbyHgc70HfHAyCuTdZObAa7h3bTSPGnjOjmLZigHIKG8/6g3+CqxBL8pTOH97z5DxZWNX VvkFx7JbUtReVr6BFh73Afq+MQ+f5TAL8pAFAgaE/nIFZCpM/LtSoIbp2blmkVrNpNEeNa0PYfd RA5nfTVhDCElUIctzgjpURVdvtEdKi8neQAbH6MIaiIU0cei0mA1FAKf6PQmApjRoegk+gVMHbu EBwmm55AFygfkyiAxcXwwxwcne/wKbaG9kvdFW74ByDZmhIM X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable The tee subsystem recently got a set of dedicated functions to register (and unregister) a tee driver. Make use of them. These care for setting the driver's bus (so the explicit assignment can be dropped) and the driver owner (which is an improvement this driver benefits from). Reviewed-by: Sumit Garg Signed-off-by: Uwe Kleine-K=C3=B6nig --- security/keys/trusted-keys/trusted_tee.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/security/keys/trusted-keys/trusted_tee.c b/security/keys/trust= ed-keys/trusted_tee.c index aa3d477de6db..3cea9a377955 100644 --- a/security/keys/trusted-keys/trusted_tee.c +++ b/security/keys/trusted-keys/trusted_tee.c @@ -264,7 +264,6 @@ static struct tee_client_driver trusted_key_driver =3D { .id_table =3D trusted_key_id_table, .driver =3D { .name =3D DRIVER_NAME, - .bus =3D &tee_bus_type, .probe =3D trusted_key_probe, .remove =3D trusted_key_remove, }, @@ -272,12 +271,12 @@ static struct tee_client_driver trusted_key_driver = =3D { =20 static int trusted_tee_init(void) { - return driver_register(&trusted_key_driver.driver); + return tee_client_driver_register(&trusted_key_driver); } =20 static void trusted_tee_exit(void) { - driver_unregister(&trusted_key_driver.driver); + tee_client_driver_unregister(&trusted_key_driver); } =20 struct trusted_key_ops trusted_key_tee_ops =3D { --=20 2.47.3 From nobody Wed Dec 17 03:59:53 2025 Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD28433F8BF for ; Mon, 15 Dec 2025 14:18:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765808286; cv=none; b=tJ0V+aOvRY88uvzeZ2kbieGwPUsrDAjPSzHlqTG0NZ+rfLSs9PHZqZF7pBcvkQR3YHTP7EhfARAcPs1Lr6SF0N292V0gFwjZJhPSfDNmKuzPrjoqsnVXBdx6f6K1+bnw4QmR1mztxLt/J+gLZYdGlKqWofYwN4sz/kdVWYRvtys= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765808286; c=relaxed/simple; bh=GGyKb0nPpNUP9YxvKC/UL/zntZq4nlTFqMxQrMaeHc8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=dVsDXZGKyEjPSgnKV8i8wQ0/dg1rL3kr7JUy/WwBOSrtQ894Ly44K2pV/VdxZedHaslVD9zDpB4CgyEd9yi0GG7TrrtOP6+XJiEuVXPJnW3TAoCRyCTWm6ATh9xpWlXwRn4fy/b/Rw9QNFb6VlkRy6dXdvB7IBqP+ePgwiTMnZE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=yizn8qVm; arc=none smtp.client-ip=209.85.218.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="yizn8qVm" Received: by mail-ej1-f45.google.com with SMTP id a640c23a62f3a-b79f8f7ea43so748077766b.2 for ; Mon, 15 Dec 2025 06:18:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1765808281; x=1766413081; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VhxFEbi3upUhHH0lvs3ziMzH7rdhLkVDsyriiRkxcyM=; b=yizn8qVmlHUteyWzETfUZFGprgK080TTkYDl9FAfO3X/CC/uQgH8LL72/tO3nY0nmK eH2uRnxFmtnfjqadvHeZDddxpYZh5PkJpd/vvXaHf46joHBI1O867ml6vXu/7K+daZqh Sg10xVlzUVvZJ6EUjwtqa0XRNWaA2Ua7F0+RXUVPxTVXC5WgXANt+rL5cudyyvjZ4DX1 J5Sh97MF0baeHJRSFM5cyCx7NBfUrM0jrDaORHUi8tbSDX/2vcJocI9h16poIzWyPDw/ ctraDBoLCiZ5bW1PAIkYXSGZqljS1OtIISaRXXnKjrYX1EE+FSbZbuvylLSQp+gFUywT km4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765808281; x=1766413081; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=VhxFEbi3upUhHH0lvs3ziMzH7rdhLkVDsyriiRkxcyM=; b=ht+rc/yP6iZ9Ee8RqtygnL5vt/zTcRyaPcnZdgp7HDxMC3gl+BEUQtV+eByQer4jRx g7XqfoJJApkDr8YP8kLN0DUzjUvnIInDmR0MxNwry1NuQSlE5o9wUZ5dAyMWtapaYL8J 2n+FBCIjBIxmVs8qHbOqDhiNez0Rba4wjEuQo7vJ+n2szWCZ4NZNNdG3uJHSbtDqMqYf RH8FOEAX0MRom0nPp//ZIYnDRYKSC6/R/8braRFomSUjDJLYr6aLGDpqajSsA1GjblKY PSL+NYwtoG7zS6Q1JcyPMx1OEQGmgQRdRap+AKrrt/jfQO5YEY14EnYpu6/iWGTI6Edx 8Qyg== X-Forwarded-Encrypted: i=1; AJvYcCU3662iY0NRGKT/VRXX5G9roo/TgxgfKnsxyh7K91Yd+X4oiHPaah+s4bhJ80VEE/5lUsh73NM67OtIECg=@vger.kernel.org X-Gm-Message-State: AOJu0YzLVKv/3L5OUvAYH5CKGRbbVPUVmW7jeeE9g/q2zXAdveS2gWcr SqOmpyZqWuwqa4k5t4gjvzgT23iPBhwKQJ8FzZIJgkaOUtHI1G6eE/q0TcnRd8rnDhk= X-Gm-Gg: AY/fxX5B0/FMz5e98W5eVs7W/NULwPsNSZpjMkJnQss+W1HGQ6q+OrT9KzIynFoijkh gwwtOj8gdDKG34Uhdy6SZJfuVFeUpUEbL4jKYwHWRPuydHzLzRPvca479XjyLqk+zRQ2et+d2+i h8kWh+IEodXf/DnSdMIiM5rh+Y3QR6yc/vwkbFU9oRNjHbnertkFu1BxZ9V1okh65GPR6V+nxnR isxLhEJAF4eoDEWysTJXLn6YVXpTO/QHkgO24KBGvSKqrdDdvLHPRpUC7rR73nh/7v6H4LgcIrN 7ArAin4WkAhzqohiV6VbbjqvP4NKrZc+8l2I9oqNAB9rHrHhQJ2I9WMxQL6TPkksPSx0pJuFyUn AcCENIin/u9GAl7Hr/CzdupBHSVIxRjdOEpHRNIXSD7UzRRANgCxZ6SwkONAxqOkqlWFPmrJG0o AaFTb6q1Oh8Ja3dZ8QEY0HwokHiUXtfKeYY/VIWeAte9g0QUabyKec7s11b8UoZkVW+pdi X-Google-Smtp-Source: AGHT+IHC8ujpn/jRAp3uyUfhPlLVYnf8gdfe5eEvlFd2Ct3yaq9KShqsTrao9oJk1KAsuZl7TA5Hxw== X-Received: by 2002:a17:907:7b82:b0:b70:68d7:ac0c with SMTP id a640c23a62f3a-b7d238ddd7emr957125366b.42.1765808281128; Mon, 15 Dec 2025 06:18:01 -0800 (PST) Received: from localhost (ip-046-005-122-062.um12.pools.vodafone-ip.de. [46.5.122.62]) by smtp.gmail.com with UTF8SMTPSA id a640c23a62f3a-b7cfa57190dsm1442761666b.49.2025.12.15.06.18.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Dec 2025 06:18:00 -0800 (PST) From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Jens Wiklander , Sumit Garg , James Bottomley , Jarkko Sakkinen , Mimi Zohar , David Howells , Paul Moore , James Morris , "Serge E. Hallyn" Cc: linux-integrity@vger.kernel.org, keyrings@vger.kernel.org, linux-security-module@vger.kernel.org, op-tee@lists.trustedfirmware.org, linux-kernel@vger.kernel.org, Sumit Garg Subject: [PATCH v2 15/17] KEYS: trusted: Make use of tee bus methods Date: Mon, 15 Dec 2025 15:16:45 +0100 Message-ID: X-Mailer: git-send-email 2.47.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1963; i=u.kleine-koenig@baylibre.com; h=from:subject:message-id; bh=GGyKb0nPpNUP9YxvKC/UL/zntZq4nlTFqMxQrMaeHc8=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBpQBhwtaw6vWGcyIGKsWICqFr37WWt86tvJxrvx 1eTqfVDJZqJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCaUAYcAAKCRCPgPtYfRL+ Th3cB/9e3Pv5r3zMgBKsAgjAsHEhpC0EgCY2oqRVfxKl8HHNjl+lB20MGJ2Q8pSnEUNYokQO3QL mOTOzUqSZn9hAaGG/5LKUE70SRu5xo1OgksDBfRcBInzXTVG7RDE0gQMoPbW3O/QimI6W2kQfJx KesCYRfngtF0s9Jq1wiZvB24whWT0ZvkV2bFXypQVF3Ta77WO8PtMmx3Bk+0u+EkLt3e/pfof0U NylFPVRHjBIX4DRRlA9oRL2MT4Npc9hTQBUo9iUHIoOxuI3uaEzDXB/69vwGC5Y1KsCDA+XS5Ma emNcInkIoXdw9B5y8cwnaf8ckyn6/3KiWopHnE+ahW+5sT3k X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable The tee bus got dedicated callbacks for probe and remove. Make use of these. This fixes a runtime warning about the driver needing to be converted to the bus methods. Reviewed-by: Sumit Garg Signed-off-by: Uwe Kleine-K=C3=B6nig --- security/keys/trusted-keys/trusted_tee.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/security/keys/trusted-keys/trusted_tee.c b/security/keys/trust= ed-keys/trusted_tee.c index 3cea9a377955..6e465c8bef5e 100644 --- a/security/keys/trusted-keys/trusted_tee.c +++ b/security/keys/trusted-keys/trusted_tee.c @@ -202,9 +202,9 @@ static int optee_ctx_match(struct tee_ioctl_version_dat= a *ver, const void *data) return 0; } =20 -static int trusted_key_probe(struct device *dev) +static int trusted_key_probe(struct tee_client_device *rng_device) { - struct tee_client_device *rng_device =3D to_tee_client_device(dev); + struct device *dev =3D &rng_device->dev; int ret; struct tee_ioctl_open_session_arg sess_arg; =20 @@ -244,13 +244,11 @@ static int trusted_key_probe(struct device *dev) return ret; } =20 -static int trusted_key_remove(struct device *dev) +static void trusted_key_remove(struct tee_client_device *dev) { unregister_key_type(&key_type_trusted); tee_client_close_session(pvt_data.ctx, pvt_data.session_id); tee_client_close_context(pvt_data.ctx); - - return 0; } =20 static const struct tee_client_device_id trusted_key_id_table[] =3D { @@ -261,11 +259,11 @@ static const struct tee_client_device_id trusted_key_= id_table[] =3D { MODULE_DEVICE_TABLE(tee, trusted_key_id_table); =20 static struct tee_client_driver trusted_key_driver =3D { + .probe =3D trusted_key_probe, + .remove =3D trusted_key_remove, .id_table =3D trusted_key_id_table, .driver =3D { .name =3D DRIVER_NAME, - .probe =3D trusted_key_probe, - .remove =3D trusted_key_remove, }, }; =20 --=20 2.47.3 From nobody Wed Dec 17 03:59:53 2025 Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E82A433FE10 for ; Mon, 15 Dec 2025 14:18:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765808287; cv=none; b=O7YTf38DuIJ5Xsm/oEcXqXDs/eTHpEoGZL/dfIizhOJ6bNxBmNCun2oR9iEWb2Otpw7F5qBHbNsPO4J02iMhQQ+x2VtYrCEYZu5ixlfSVt7Prwmn+czifpmdgGy3peNHVidEHfN+VeTh5TUsskHJ60AYpQwSJII55hzqFxBsCNk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765808287; c=relaxed/simple; bh=sf0K4iIYSb02rL0mKJ9MRRhFzpLL6kAy33jJ54lqjio=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ZEW6MGhM/saz6l1MXVhOT6oOT4TZrMfhSNcxcOw9PD1cZSlnNZFV1O1oj2Yc4KXbapuGo4Jd/KyYMtMnWIcHIjRKaK6eVhfmiSkmSccSF5Ds90qAAEkj9eOPZPe0BcLioWGvTquuznZz2K7yq8EBFBKCJanmXkbW+5ESUUQqNk8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=YyEfo06K; arc=none smtp.client-ip=209.85.218.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="YyEfo06K" Received: by mail-ej1-f52.google.com with SMTP id a640c23a62f3a-b7636c96b9aso582002066b.2 for ; Mon, 15 Dec 2025 06:18:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1765808283; x=1766413083; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HrasR7kGrYrWNKAZkndazvg9Pq5KLcOmeoZP0wqwfBQ=; b=YyEfo06KQ9FnqKvR995Xxgtcqug/8cLhuCA/F6IUPhEHhacHFCu59Ig2tFHpouI0rq ocoVR4Pzf9zbY7RvPRRLMeKdL+GuKX+LsmDA90mptdMW7YL/y/8aT1imd/oAAgxcFGQS x6msnudDu66fDx3+GSFTe4FJjdvhHRum61AHFOE6tSA/n9yXe3c9zZQdAHXYlql9m0wF 8hbIkYZNLUvw+hSrJdGHXwfyjetcU55rglPA4gNyBSJOZq66Uo24nKoIf58pwU3pOyTw 9PdIcVmZ/00l5wOPj36niTVHmEXgwgnZmpZZzgjtT9Sv1Qrn0d6yefh8+pAr821XwgfD 7fvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765808283; x=1766413083; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=HrasR7kGrYrWNKAZkndazvg9Pq5KLcOmeoZP0wqwfBQ=; b=WOrggXbKoFdAuij1r2VFvIbirbkJzZD2G+HnzBRkR5CJjciBJyG917xgo02VlW8hlF BJ5hVZlRwswcvlFpuH9CVtb5HcvSkKXtwmvy6+0S7GbEYlUiTLTZUym3WjBOY7onuVDE GC40DnR7NoWZavyIVSKYRJ2s2Vqbe/8acSkiVO0NRQE7bQJbgbYzAj/S9YOU17q3HcPn J/WauyLgDfzML/eZAEz2E8HjydfYgLB9w4ekbgoOrhlvn1zRtMtHRbZAUdpHRRJvvBVG C/4kLwzgbha/ClUkNyNvIJoblLBssC8KxDaD9iuy2rJS5W6vxU3xD/HcYAQ37QtmJMch wylA== X-Forwarded-Encrypted: i=1; AJvYcCWwQZJAPCekynfi/NkAaSxNJxZJrYxdOt0svoBFnNYyGgDJ00w180OPJp1niEQ19XOGzsJ3yh4jQyTEPsw=@vger.kernel.org X-Gm-Message-State: AOJu0YwcPF0EJnoIifAocVjq8qAdFA0RlOwLXYKDXMdzru+KaE66muhv r1BdQGjNDu4n8jPDvC7b81yJsbxRcFovOfxS2djHARux8jy6jmxYHhryN0XdnLKtjuM= X-Gm-Gg: AY/fxX79j6ol7AIL9DziDGh/+jG8Cr/HkuV6LOtHhbv5ngE+slkd4k3rV2YYwMBTham EANlcVO2bLcP3X6wqVj3RXitbZSDD7c4ox/M5025rHya7DWRzTGVNZ2yI1hkKkIWaGuNnvwSQxY 3RQratdNytHdHbhtF/6fnqKPVsXHl0pBh956zci1WWGEXrPh/DcX2t3rcVIP+MosNzCCyVAaL5x OHJGlCpIzHpbAG2TOpI6nsv2jhBj9Ka1It2K2D/g9/scBiTCIWLSOLf7vd/zG0YOS4W6wqHn62C 7iTugmR2Eso3T41rVXOLqGxywUPtdm1i+X3vhfVEb511PxaCeaU/LrboFIwj8N2apPzZ+/s2Ob/ DOfkcMOuBPmwdMSqwIfUdInKdCq/08LkeTvsPBdBvZ8CXZ+q3WWJNOqJedByYJ+bQIfKIR9o8FS 3i5Y57tcc5CS0/0A389ZLvgyYmHN8pxWXFlAQVkYmf1CfZ06FHiBiDxpuEaw== X-Google-Smtp-Source: AGHT+IHX0m7kbMZvY8tope7JC2GsN2BbWZe1dZGY3zQ0k7S4MMiH/CtKoy5x3794CwzbShUzQ3pDRg== X-Received: by 2002:a17:907:3e12:b0:b73:54b6:f892 with SMTP id a640c23a62f3a-b7d2356a6b5mr1114211066b.4.1765808283065; Mon, 15 Dec 2025 06:18:03 -0800 (PST) Received: from localhost (ip-046-005-122-062.um12.pools.vodafone-ip.de. [46.5.122.62]) by smtp.gmail.com with UTF8SMTPSA id a640c23a62f3a-b7cfa2e70c2sm1388507066b.15.2025.12.15.06.18.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Dec 2025 06:18:02 -0800 (PST) From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Jens Wiklander , Peter Huewe , Jarkko Sakkinen Cc: Jason Gunthorpe , Sumit Garg , linux-integrity@vger.kernel.org, op-tee@lists.trustedfirmware.org, linux-kernel@vger.kernel.org, Sumit Garg Subject: [PATCH v2 16/17] tpm/tpm_ftpm_tee: Make use of tee specific driver registration Date: Mon, 15 Dec 2025 15:16:46 +0100 Message-ID: <5c8d6d420338d0d028f785680520d375e8a49673.1765791463.git.u.kleine-koenig@baylibre.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1424; i=u.kleine-koenig@baylibre.com; h=from:subject:message-id; bh=sf0K4iIYSb02rL0mKJ9MRRhFzpLL6kAy33jJ54lqjio=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBpQBhzv7fuyRMHA7lEtOeYNZ6CC9fofHw/mF7L7 AvGJoDhvh+JATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCaUAYcwAKCRCPgPtYfRL+ TvL9CACVhcY+gEOTNpIRErp2w/DR0HVcSHlsZUncxxNqkggxg/NdYhINtrPC7TX2L8c7demb+/3 hngi+GznovcCzmDBw4iVI2Dg0un0NfTmRnrgDJkyeDiZ6YfwLRTMLRUUNXbjbR/X4wkxAOBN3gm +UhKQPDnGZ/OFX2n0KDIDFSkD6jm2bWwseMZcWgrX9UV6KqrMa5ruNDfjvi1Zk88xofINe35S4y FpC9jQzdzGcU1qIOrSjQ5/6lEhZQMETearZ0GAS96ED1elqYF4XjLZdtfV+Rw2Yec1AjqscWGf0 YKd7cQr/XDBJ27pKG7mgv0+wsPyUalXZWHOBsd5AN1Ja8QAf X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable tee_client_driver_register() is typed more strongly and cares about assigning the driver's bus. Similar for tee_client_driver_unregister(). Make use of these functions. Reviewed-by: Sumit Garg Signed-off-by: Uwe Kleine-K=C3=B6nig --- drivers/char/tpm/tpm_ftpm_tee.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/char/tpm/tpm_ftpm_tee.c b/drivers/char/tpm/tpm_ftpm_te= e.c index 4e63c30aeaf1..e5fbc70b0eca 100644 --- a/drivers/char/tpm/tpm_ftpm_tee.c +++ b/drivers/char/tpm/tpm_ftpm_tee.c @@ -338,7 +338,6 @@ static struct tee_client_driver ftpm_tee_driver =3D { .id_table =3D optee_ftpm_id_table, .driver =3D { .name =3D "optee-ftpm", - .bus =3D &tee_bus_type, .probe =3D ftpm_tee_probe, .remove =3D ftpm_tee_remove, }, @@ -352,7 +351,7 @@ static int __init ftpm_mod_init(void) if (rc) return rc; =20 - rc =3D driver_register(&ftpm_tee_driver.driver); + rc =3D tee_client_driver_register(&ftpm_tee_driver); if (rc) { platform_driver_unregister(&ftpm_tee_plat_driver); return rc; @@ -364,7 +363,7 @@ static int __init ftpm_mod_init(void) static void __exit ftpm_mod_exit(void) { platform_driver_unregister(&ftpm_tee_plat_driver); - driver_unregister(&ftpm_tee_driver.driver); + tee_client_driver_unregister(&ftpm_tee_driver); } =20 module_init(ftpm_mod_init); --=20 2.47.3 From nobody Wed Dec 17 03:59:53 2025 Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C7F2340A79 for ; Mon, 15 Dec 2025 14:18:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765808288; cv=none; b=eHMV/WdQb2dPRs+twpItRcVe2/i2uGIqAWxBNmjcUjgzLl7OMEu46oGcjhvYm9L567q+TGUcqKJ/6tdOoQ5Xgbx/2RpAbWLYxWigHUUAqc4IVskxhk/o3yDjrJ1iz/dG0EuUAqg2kvQOm1NgdxxbSIB0a/DHTbSBCYgrYrJqJuI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765808288; c=relaxed/simple; bh=2qrjsylMFa+SF9mw2N00GCNY0QrYs1HpZggQBT0ZSoQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=czsdNUocE3qaiKosWjwXHc/94PFlpPlJWz5Rk0Dqi8IEdFSBVIaG9QScrJYRdHmizu02NcILuHQl0xDiI3YtFXhvbMvhhJKue94ljswcNta5Z6A/JM9a6qrIyswo3+JquUUqppEY+8O+IzP+EvBALH7i9jjETEYZ69pTVxHDxtk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=DEg+dULy; arc=none smtp.client-ip=209.85.218.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="DEg+dULy" Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-b735b7326e5so544576066b.0 for ; Mon, 15 Dec 2025 06:18:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1765808285; x=1766413085; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2yBB10wIDhntVhF7Adi7eu+afyFDfQDzYe1DB3rR/Q0=; b=DEg+dULyuiSawNLqDUWOk0sBimSO4cini80bKuQroBmoyPs2ifn4wk1fyM32x5jVQn YqNOWJ6slYUY4uzdMf5nTM5qpjNwTzf97Kq9603te3kJTdOnXFX6SQSNSKBYMLFbyFwF W3IxskTPCNWHxKHbXMz0tvwizUyGv6/gXCdPMJviC1KybAxYuCCPRCFV7g/+9i3F175Y /L+/vwYt7DwY/mOMrXWswNQ/bcP+q8ToCy1IXnUP6NiqfAw3JVI8kY/ph6h4zirCeOjS 6PWvNhQYHAuiJ6oaHzV/tGCVCviahxp6mnJdWg6LLPXiUQwC8ZcqnSVmsnasgb5/A/go 6fEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765808285; x=1766413085; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=2yBB10wIDhntVhF7Adi7eu+afyFDfQDzYe1DB3rR/Q0=; b=M57cZ7dgjDcZDPV008Rqt1ktRpM2x02QDRa0J2xTolZFmZOBwD9rCWiMTQe2Y6ivnw +SdQAkKg3MIpfiOyKJgmyklvcBehIQe1kwcPU3UzvUCoJesObiHtFBfQJ4kY1ck1IXCL buj43JwCZ4F+k0huy5bgk4mYwJ5aZW5cqXAwFgMuWgvgcBPB9yOTOh/G+H3iQHTG7A9c toxiMMuPpPYX/krTXZJ7M7VVxQmKAr9Agg8ipSIYugnckTGtdG609lzsNO0veNFiXrsL OxZcTAumFi2ZJPyMR+PC0CC+K5IAU6PNu5JfOVPYa7l05N7l2gQFnfES7gm2ttX3Tujq XvpA== X-Forwarded-Encrypted: i=1; AJvYcCWTloyU9tBy9KGEFpvBBF8vlYKBxWaF7DkiWrCSEIcF9rJgBScg5h7soOf2BzHXampRYtq5qUTG4TXxSlY=@vger.kernel.org X-Gm-Message-State: AOJu0YxUoPSRx8oWWQy9fZHpYNe8xikmke0R0Rv4KuPEHW7wE0EjR0Wi 7C16Ac9iar6GjWq1BgAw85NbjY+SK1BkTnGn/TFvX/DixJ2x8B/VQt0qszavrNdzd+rmAU0GkVB mNm9l X-Gm-Gg: AY/fxX4ba8T3sVJ8iUHqR2qUSwpaLUxbEwbd/hO64d6agzoXyLgONPeYQ1W29Kls0Kt debEiETVBygaDWZgwmuKEJwRVd9TrljIzoGR6h8WZPsbSCZoGYcZyDBPTSJPdGiEvsDXIgNgo+I Uqt3XUIw1/i8aMSrF5id5+IhYDi8+OJSu5ZsqAenFI0d0x1MkuUuUXx7sqX2JBWoBoBdnfXbUZL c5ug30LiSFER8YPTM25Y09Qjc3smSKVPgMko/HWAT+c94j6qOsAYZHSUkNOH1+TM602uwcsvict DpGmuI6jGPcJcBAnscSncck1vdllB1ZqQD2uSLA2SJkNFEPfqQO+2r8wTvrNjqmHAs2QUJewT1V arfxK6UtbwF5GixVpjzyezd8a5GpaCVfrcBREiFnIYpzbMeiDdnTn9TepvGjN2RX0LctJaGyU16 Mxoixrn1VootyFKDESIhqOHK/shSNP3TN7q/BljjdZt0yAIuSSuf+ozzMasg== X-Google-Smtp-Source: AGHT+IFo9FOJaDLcFkLTxYDl5ZKYhlEDF+L2OGvBOrKgVtsuxe0NnsUtGKir1wRggxQLMFuuLtm7wg== X-Received: by 2002:a17:907:d17:b0:b72:6a39:49e6 with SMTP id a640c23a62f3a-b7d217ed7b0mr1542327266b.18.1765808284912; Mon, 15 Dec 2025 06:18:04 -0800 (PST) Received: from localhost (ip-046-005-122-062.um12.pools.vodafone-ip.de. [46.5.122.62]) by smtp.gmail.com with UTF8SMTPSA id a640c23a62f3a-b7cfa5191fasm1381389266b.33.2025.12.15.06.18.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Dec 2025 06:18:04 -0800 (PST) From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Jens Wiklander , Peter Huewe , Jarkko Sakkinen Cc: Jason Gunthorpe , Sumit Garg , linux-integrity@vger.kernel.org, op-tee@lists.trustedfirmware.org, linux-kernel@vger.kernel.org, Sumit Garg Subject: [PATCH v2 17/17] tpm/tpm_ftpm_tee: Make use of tee bus methods Date: Mon, 15 Dec 2025 15:16:47 +0100 Message-ID: <7bb98eeb8a478ca69344499f2e58016bbf787313.1765791463.git.u.kleine-koenig@baylibre.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=2647; i=u.kleine-koenig@baylibre.com; h=from:subject:message-id; bh=2qrjsylMFa+SF9mw2N00GCNY0QrYs1HpZggQBT0ZSoQ=; b=owGbwMvMwMXY3/A7olbonx/jabUkhkwHidK6wz4Hj+uVpPCJP5L6dz43PaivJl/576HsdzNjg k+37LfqZDRmYWDkYpAVU2Sxb1yTaVUlF9m59t9lmEGsTCBTGLg4BWAiV9vY/3CuuRiqe+tigNLE zW45WUxXPM81bz1gJrHHjzPDZK1B5bmtKv0qDikNS332dTGsMM//cnzPnpCOHQ7b4s7nH6mRmNy h2Mr/K351jGpfltHDY9ILs3wuRTxbu+Ii42WVR1GT2ty3suyNDFdYEn0110V2pcbl/dKPN87dqd tVumRqJ1e5zFVJJyuxd7a/HVIFc3OEoyM+20c+1czzlzAT0W24NKnw5VERz6W8h1/u7+zpUwk4I 2Adqs7xJPfTFi+zWTVPpngmFjzIfuiumqiWvGEeo8SL9W9dCiPecLhITH/aEhMUOelChlO7fWOt mVtRUWyZW5roy12OJz7cMP9TLG3FZ6Uj0jzlQpXK+psA X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable The tee bus got dedicated callbacks for probe and remove. Make use of these. This fixes a runtime warning about the driver needing to be converted to the bus methods. Reviewed-by: Sumit Garg Reviewed-by: Jarkko Sakkinen Signed-off-by: Uwe Kleine-K=C3=B6nig --- drivers/char/tpm/tpm_ftpm_tee.c | 26 +++++++++++++++++++------- 1 file changed, 19 insertions(+), 7 deletions(-) diff --git a/drivers/char/tpm/tpm_ftpm_tee.c b/drivers/char/tpm/tpm_ftpm_te= e.c index e5fbc70b0eca..20294d1953a3 100644 --- a/drivers/char/tpm/tpm_ftpm_tee.c +++ b/drivers/char/tpm/tpm_ftpm_tee.c @@ -169,7 +169,7 @@ static int ftpm_tee_match(struct tee_ioctl_version_data= *ver, const void *data) * Return: * On success, 0. On failure, -errno. */ -static int ftpm_tee_probe(struct device *dev) +static int ftpm_tee_probe_generic(struct device *dev) { int rc; struct tpm_chip *chip; @@ -251,11 +251,18 @@ static int ftpm_tee_probe(struct device *dev) return rc; } =20 +static int ftpm_tee_probe(struct tee_client_device *tcdev) +{ + struct device *dev =3D &tcdev->dev; + + return ftpm_tee_probe_generic(dev); +} + static int ftpm_plat_tee_probe(struct platform_device *pdev) { struct device *dev =3D &pdev->dev; =20 - return ftpm_tee_probe(dev); + return ftpm_tee_probe_generic(dev); } =20 /** @@ -265,7 +272,7 @@ static int ftpm_plat_tee_probe(struct platform_device *= pdev) * Return: * 0 always. */ -static int ftpm_tee_remove(struct device *dev) +static void ftpm_tee_remove_generic(struct device *dev) { struct ftpm_tee_private *pvt_data =3D dev_get_drvdata(dev); =20 @@ -285,15 +292,20 @@ static int ftpm_tee_remove(struct device *dev) tee_client_close_context(pvt_data->ctx); =20 /* memory allocated with devm_kzalloc() is freed automatically */ +} =20 - return 0; +static void ftpm_tee_remove(struct tee_client_device *tcdev) +{ + struct device *dev =3D &tcdev->dev; + + ftpm_tee_remove_generic(dev); } =20 static void ftpm_plat_tee_remove(struct platform_device *pdev) { struct device *dev =3D &pdev->dev; =20 - ftpm_tee_remove(dev); + ftpm_tee_remove_generic(dev); } =20 /** @@ -335,11 +347,11 @@ static const struct tee_client_device_id optee_ftpm_i= d_table[] =3D { MODULE_DEVICE_TABLE(tee, optee_ftpm_id_table); =20 static struct tee_client_driver ftpm_tee_driver =3D { + .probe =3D ftpm_tee_probe, + .remove =3D ftpm_tee_remove, .id_table =3D optee_ftpm_id_table, .driver =3D { .name =3D "optee-ftpm", - .probe =3D ftpm_tee_probe, - .remove =3D ftpm_tee_remove, }, }; =20 --=20 2.47.3