From nobody Sat Feb 7 13:58:47 2026 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A9240314D14 for ; Thu, 11 Dec 2025 17:15:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765473358; cv=none; b=oT/PmUMJGQ3rgKXoIgH9nwrzHu7XuB2QkWq/dLLWI11pvwIx5m/497As9HC6aDMtSrWRQcgEN/r17qGF/pgCIu16dEOlCpiVUzcv2HokBu1e7luWnJaYBMBL3xT/SPVEfcSWZ6IVo5u6T3WU9hCwnlWXFQADxnUgJ2EvnQGlxp8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765473358; c=relaxed/simple; bh=wu6oefWKnIU9WzWjX5GOqr1eBeTnbSAfvrahT97CN+M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=E9NlPRFTrSZKzJ6Ygp1dRZWKtfUcOBYZsOVicCKHeq/yq1nGYeiI2kq+0aPi5BEGTkyJDgok0GQpYqTChn3kyJ/QMOMYCp7Z7kCPz2f+Gfn+1VAcrpayEhRjKQmj5FsNwbCrZlvmvd5pd+jQ0DdqFBRxH8MpAK1wuBSJyHY/2Sw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=ybEn9xwp; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="ybEn9xwp" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-477bf34f5f5so3413345e9.0 for ; Thu, 11 Dec 2025 09:15:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1765473354; x=1766078154; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=WYGrrB8fuS9mG1lO++7R0Er9vYlfUnB8vYICuaIO95U=; b=ybEn9xwpqwegxpI6Z/UyzJkrEGC+0cn5r8A2KfwCmVkHh9ZSF3jeofY5E2YJXQAjrf jeIOdKjPTg2rx/9NOsT+aJ4wzLPYXRcvsTJh+V6ORL9snG4sieuOlEhTlHnvYFM8h8Bm YldLyEzDAFIpLD8sHLxeSujJ833IcnQKJ8BY1qLS7KKT/RNySDL3B3MfLZgfgph6DpwQ H64Pcyku6eOt656+ea3uoxUQl9BMV6FLAr4hqQ3bVFbnuzdi5goIkYep5LEg2SmG5Gug egq8m6/CWFivje7saG2r3bXUi8iD5HGNZ2WXXulYQejsYnlKQkmON768dFjqHHO7eMek TBTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765473354; x=1766078154; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=WYGrrB8fuS9mG1lO++7R0Er9vYlfUnB8vYICuaIO95U=; b=H3202j1Us+2isdm1ClB4BAwrcnNNBk2/QCa4lJkW7qrmf3uE4gthOQCLMWIjsvgDyU 5hQw/Z3XBqgAW17S2SY2DMXLMCBXirUmK0QMkf7Qein8Mmj+NDFECVal3jVm2g8PEQ04 wFkMsTV2zAiFfR/dWcD1ZpnVyCEmzwBSd3obzBehRmNmJI+Jlyve+3efy+VOw8G4FFs+ IM9EiG+JpFXycjhOiaoLVRBaNw1dV1V1KfqWeRMyOS+DH5kC74JaSnpM+eMXmt0dYbUV GMhLT8PmbBSfmmFvPOvoKe3vEUp7s4quckLqc44ghye2uky4icOzg1lOtk9/b44fAudH 1HPw== X-Forwarded-Encrypted: i=1; AJvYcCVUl9krUyi/hy0R/phj2zjRwt+aJ4aoMsLYT9fU03IjsZV4newZslIB/pF2fZnPgOUzEXywIzGywJ1mQyA=@vger.kernel.org X-Gm-Message-State: AOJu0YznVkredj47pfRHK6lBp6O5YKBGaJ9CzyT7bOU13MeoQOvmJ7H3 R9YIMRCtDhuAotYlFjKtdlUo6egUY/2WjuJUrFzpgxvDsPPjkj3Yuu9uqlJie9RUuWc= X-Gm-Gg: AY/fxX7Bgt9TjlRuIZVval6mVxQD+c9EsqWobECf8Ybu4jgBzQv1oYlHFL5HOIEjDOG dM0osgIy544gx+5bxfkFQ2SZuJx8AUByl2PfFGAUxllAh2Ofv2jW3pfEB968CuBjmRcFSX3YHtC Hv7qS7w0yNrUVmfCkSRJ1AwDZ3NZKwgMyOKqNTmDcid3M/6tmF/kRPz3ICOMVc6kgvTJ6DJqwqG gacYnNbYIwm6g8ogfTwJ/U9FBEEdExB9MJeGJiRcsDHvQ/Wj4a9wkefGkeo0uzGETo2WXmmSNqd zTJORa8UFVwUaREwF4d3sC6nLORkffQCEvUA8XjHr9SwPtn7xiEDEoSsQXIdJFOnyx1elF0RltW eSCE5KVz0TggnZnJbLNGKoDeOPBBjx2i6/8Jr8dhcfx3dnApgo4kcnXEtpZOt3FsVH+a2+iNvul GHbsj/lJ16gmn74p3d8YVzoF7/VOo3mEI9LlvV3QC655j/E2y5wQVuRn5C4Wf+Fgny+9ZRt1xtu DA= X-Google-Smtp-Source: AGHT+IE6M3q2VFu6u/fo4kWRAEIyesdqN/bWPrsvZJM6/G4yT7LeZmkftuZ3Kd0OKFWnEDhUzIzWYA== X-Received: by 2002:a05:600c:1913:b0:479:3a87:208f with SMTP id 5b1f17b1804b1-47a837a00dbmr65625795e9.36.1765473354545; Thu, 11 Dec 2025 09:15:54 -0800 (PST) Received: from localhost (p200300f65f006608b66517f2bd017279.dip0.t-ipconnect.de. [2003:f6:5f00:6608:b665:17f2:bd01:7279]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-47a89d70ac4sm17003405e9.2.2025.12.11.09.15.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Dec 2025 09:15:54 -0800 (PST) From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Jens Wiklander Cc: Sumit Garg , op-tee@lists.trustedfirmware.org, linux-kernel@vger.kernel.org Subject: [PATCH v1 01/17] tee: Add some helpers to reduce boilerplate for tee client drivers Date: Thu, 11 Dec 2025 18:14:55 +0100 Message-ID: <899e887aa68206155f2fc56ad768cbcf40012fb6.1765472125.git.u.kleine-koenig@baylibre.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1969; i=u.kleine-koenig@baylibre.com; h=from:subject:message-id; bh=wu6oefWKnIU9WzWjX5GOqr1eBeTnbSAfvrahT97CN+M=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBpOvwWMOUhCGSVbWSQI8W2OOIB53T/WvCJCMowB j2V1XtzRHiJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCaTr8FgAKCRCPgPtYfRL+ TiOEB/0aR+efhPwiQcZJpUyCAlxHdq4odKrgNo1C7UqmJAxDXlWzQOINASU+YQo+sbx/qoIwQJV ZivxHhlvwCel4aJZqXl2AAYD/CGug/CzJdYzZfiFKruRf/StTkMCMn/HKzOmXSeST/V4uHPJ5Ff DthHEs0aolb+n4BMzMK168CvTRMSpYkO3Pu2DPFefTiDa1qKjWHoAzWXYIGo89E1zwn4vRYdulK XqU9J5Pa0+AU8rmaNysO78WNY4sxE+/95ejeHnkWG38/l+NT0z6vCcxT2Q50UW5AmnS/1wJLRET yMBUnOPpm+xvFCyNRD5x+hClHr8nV5hComdWozHNljx/ZnXE X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable Similar to platform drivers (and others) create dedicated register and unregister functions and a macro to simplify modules that only need to handle driver registration in their init and exit handlers. Signed-off-by: Uwe Kleine-K=C3=B6nig Reviewed-by: Sumit Garg --- drivers/tee/tee_core.c | 16 ++++++++++++++++ include/linux/tee_drv.h | 9 +++++++++ 2 files changed, 25 insertions(+) diff --git a/drivers/tee/tee_core.c b/drivers/tee/tee_core.c index d65d47cc154e..51379f7fc5d5 100644 --- a/drivers/tee/tee_core.c +++ b/drivers/tee/tee_core.c @@ -1405,6 +1405,22 @@ const struct bus_type tee_bus_type =3D { }; EXPORT_SYMBOL_GPL(tee_bus_type); =20 +int __tee_client_driver_register(struct tee_client_driver *tee_driver, + struct module *owner) +{ + tee_driver->driver.owner =3D owner; + tee_driver->driver.bus =3D &tee_bus_type; + + return driver_register(&tee_driver->driver); +} +EXPORT_SYMBOL_GPL(__tee_client_driver_register); + +void tee_client_driver_unregister(struct tee_client_driver *tee_driver) +{ + driver_unregister(&tee_driver->driver); +} +EXPORT_SYMBOL_GPL(tee_client_driver_unregister); + static int __init tee_init(void) { int rc; diff --git a/include/linux/tee_drv.h b/include/linux/tee_drv.h index 88a6f9697c89..850c03b2cdea 100644 --- a/include/linux/tee_drv.h +++ b/include/linux/tee_drv.h @@ -322,4 +322,13 @@ struct tee_client_driver { #define to_tee_client_driver(d) \ container_of_const(d, struct tee_client_driver, driver) =20 +#define tee_client_driver_register(drv) \ + __tee_client_driver_register(drv, THIS_MODULE) +int __tee_client_driver_register(struct tee_client_driver *, struct module= *); +void tee_client_driver_unregister(struct tee_client_driver *); + +#define module_tee_client_driver(__tee_client_driver) \ + module_driver(__tee_client_driver, tee_client_driver_register, \ + tee_client_driver_unregister) + #endif /*__TEE_DRV_H*/ --=20 2.47.3 From nobody Sat Feb 7 13:58:47 2026 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 748E5314D1D for ; Thu, 11 Dec 2025 17:15:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765473359; cv=none; b=NY1hHWZKZBbbXLhJ81HXKhlZVPpoGcJfQoMW2V0ECroU3DTQy+CQ/e7ocqV6NhOKzlPeGMyXSdrzjemORJHZB1J72wanZK9t8Z9ec9B+3OkyKMITeT0+p5rT/ssV45pCOVGrh00ZrF+9PpG9hf/yvo3liY6y38h66vfQ6WXN7Yw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765473359; c=relaxed/simple; bh=c9YlOyDcWBkhTT0+VL5SCAt+Rn9uz/WnQRKclVZqJbo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=trIumOcmuzWurGrWum3HdMDKTg5VFm55lFFhCnU+K6HIBUpcz1tl63vm32di+0+9gIf4v9kQqFD9+02Rc5o31fqnimoMD6CyyVQciISrRa/YgSnEXv+vMMNOXrP69KwQcxce6UUalU9JLXciDrKfugil5CBF4Uw9TnR7WL4Lu7M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=iJOg8CbI; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="iJOg8CbI" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-42e2ba54a6fso146264f8f.3 for ; Thu, 11 Dec 2025 09:15:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1765473356; x=1766078156; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=JoDz0g7RPOFum09gAkR6MAN5nJYo7w/Vlx1iJV+OcGM=; b=iJOg8CbInR/zJQzuu+UV/knNWcB006pkcJxx61y78FwEhdFFx/CJ5RGU8nqwpvGj3t T+9QrwoHsUOprjPhFLMKltvrPzTCEYXgI+hQju8/yLsCQkhDsa4YY9oFmpmSb8YjTVRc yDX/G63IeWS8ViA1CHeztMvzKFwgHTr91gGKA3pJmVliopNc22PE8lbFUfiflvPUpDCw 6v+mpf07djdH4pZSJYI5g4fbZGyOTSpSZhkv29SP1RepKaTQ70y+wTjiOjpnD4hQXD+t 7eJtLy33qxs0EEfDs1rHYiVEQIJoGyqTlJW1NLhC6ku/aKb8xmoiz+v7dCnaHVNXkyXC n+ZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765473356; x=1766078156; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=JoDz0g7RPOFum09gAkR6MAN5nJYo7w/Vlx1iJV+OcGM=; b=AHSqz+lqqkAIM8+sosto8VykzMAEnHq5muugQABQSjoifBw9VFWSpIsZUoi26kieI2 0xZJXfRpGewDlWxLPNFgr7Z6R89yZPSfBZdP23sZZdhRukbxpR6pX/kdHs88PRR1D3wJ kuF5ldI9Xr9Od+p7cy3SuXSz2DfuBw8nqljwvSjyNLeYkKPB1o1v+R7JVC+c/HanQKsK Dj+TA3S6iOEg7uxONUbkZ1AH5SA/S7OzRMHr/TTxUQmi7MdvGJXKDT7hZJY2DBBm20aW 9d7emDc4gw4jpAIdFfcPpcHLbBsJJJD0xEOxYcA4yxuoC/UxfifPQ7iBEtE36r4kKSLU vH9Q== X-Forwarded-Encrypted: i=1; AJvYcCUaQMthdG4UA6k+4TnfQ3fRueCdJwXNUoPUWica8hsRtNHF6z/+U4qXlR2hw8a6J5H7xtYsWDWGLLNPgBA=@vger.kernel.org X-Gm-Message-State: AOJu0Yxl1gWOtHazA2RWhS1qYctSwSMlnnEUDsdk721X9e/tzs/LRok3 LMD1FhG2i4cFX14+JNtUsq23tQpRJ/04CgkNj6N+R3e+13vK9bgAUkDtgNq+fLDPpJE= X-Gm-Gg: AY/fxX6HaiSFUl5n+HBDHfttEu7hwABKydE/QJ/vdvnHyuOWeEv4SJ/y7DpEF1AvF+d CRvHCZDCh6fY6QgNjLfRVrH3bb+oVLi8NKQlRsS5Rsc/zxYaQO2wti7Ux1r4qf2KmrUXNrkTF2Y I7zFQZMfmpwhUa6FjPsNxWNOJSDFouVk1qEqkivS3s7cHTWOyGaN1akww1cqe+HLXlaAAFxzzXP QMH0gVpbFAPbAR9oVw2ms4AYZEICnlBD1r3cbgDm4IRHNj35+JfcwS0HoJD3+j17LGXbF8UUpaa QDoLTiZzgRnDq5jjGWgCM2GK3TaiXyQD0anPTNNkCeSb6lnxqcWJQWMoBZVNh+UngBJ+oqIjvqW W8sTbZu/0HMc+kdFatamz8ZPZggdhyD59pM0dm5ElbBPK1TVtAJqoakYgVU8GlIa1eWAiC3/RPC /HjlZLnQepVb48mDT5BJbUa0lLd7swAp1WM8VMTKNYGtm4nrGvIPqWPhNnA1/AQMQK83L9ZSNhh Qg= X-Google-Smtp-Source: AGHT+IFX5qkS45BdG6KrFISTn3JdM74C2f1uOGK7ovoJCi0e2RbWzgAqkhMepwXzD+6oAtSN/zVJ+g== X-Received: by 2002:a5d:584d:0:b0:42b:5567:857f with SMTP id ffacd0b85a97d-42fa3b06460mr7996197f8f.50.1765473355683; Thu, 11 Dec 2025 09:15:55 -0800 (PST) Received: from localhost (p200300f65f006608b66517f2bd017279.dip0.t-ipconnect.de. [2003:f6:5f00:6608:b665:17f2:bd01:7279]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-42fa8b8a941sm6801232f8f.34.2025.12.11.09.15.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Dec 2025 09:15:55 -0800 (PST) From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Jens Wiklander Cc: Sumit Garg , op-tee@lists.trustedfirmware.org, linux-kernel@vger.kernel.org Subject: [PATCH v1 02/17] tee: Add probe, remove and shutdown bus callbacks to tee_client_driver Date: Thu, 11 Dec 2025 18:14:56 +0100 Message-ID: <7f73b2ee784c0b78fa3bfee3aaa3b95f47041178.1765472125.git.u.kleine-koenig@baylibre.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=4197; i=u.kleine-koenig@baylibre.com; h=from:subject:message-id; bh=c9YlOyDcWBkhTT0+VL5SCAt+Rn9uz/WnQRKclVZqJbo=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBpOvwYajd9lnTeUjp8JrSQ61m2kOr2I918qzpFH CQQdN5WOW+JATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCaTr8GAAKCRCPgPtYfRL+ TtqnB/0e0Ca02BcMczYkBj0OW13MuyK6WFiPs3pZVKv3Ke16TmDMPoDgqSqGLVv/Ux/i26e1yw/ ncuZFvjNEgvn07QlnvsZ67ym5blbk78GUUaC+WSEHDGMfSpS2DhBOfjCHeYdIpNdqJo3sWfmMqd gK1hAzuzjM7NnoQN4OZqCd3fZ2SyXd3qN8vpd9KkQesXGtz3T3fwa1PPy0BaNOJiGjKKFW7YeFO Czq2FSz1NUlf2qPMb+gCsKfql//YY662lUM45hGXe5RRNrj/wzT3kUtY7Eo+MaYP7fz4m1dbNvq QXF3sdbFE6Bw9SdkuT/WnhX1PQ8xs4+Mxg1xlEnwmPmUDxik X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable Introduce a bus specific probe, remove and shutdown function. For now this only allows to get rid of a cast of the generic device to a tee_client device in the drivers and changes the remove prototype to return void---a non-zero return value is ignored anyhow. The objective is to get rid of users of struct device_driver callbacks .probe(), .remove() and .shutdown() to eventually remove these. Until all tee_client drivers are converted this results in a runtime warning about the drivers needing an update because there is a bus probe function and a driver probe function. Signed-off-by: Uwe Kleine-K=C3=B6nig --- drivers/tee/tee_core.c | 68 +++++++++++++++++++++++++++++++++++++++++ include/linux/tee_drv.h | 3 ++ 2 files changed, 71 insertions(+) diff --git a/drivers/tee/tee_core.c b/drivers/tee/tee_core.c index 51379f7fc5d5..89164d35fc5c 100644 --- a/drivers/tee/tee_core.c +++ b/drivers/tee/tee_core.c @@ -1398,19 +1398,87 @@ static int tee_client_device_uevent(const struct de= vice *dev, return add_uevent_var(env, "MODALIAS=3Dtee:%pUb", dev_id); } =20 +static int tee_client_device_probe(struct device *dev) +{ + struct tee_client_device *tcdev=3D to_tee_client_device(dev); + struct tee_client_driver *drv =3D to_tee_client_driver(dev->driver); + + if (drv->probe) + return drv->probe(tcdev); + else + return 0; +} + +static void tee_client_device_remove(struct device *dev) +{ + struct tee_client_device *tcdev=3D to_tee_client_device(dev); + struct tee_client_driver *drv =3D to_tee_client_driver(dev->driver); + + if (drv->remove) + drv->remove(tcdev); +} + +static void tee_client_device_shutdown(struct device *dev) +{ + struct tee_client_device *tcdev=3D to_tee_client_device(dev); + struct tee_client_driver *drv =3D to_tee_client_driver(dev->driver); + + if (dev->driver && drv->remove) + drv->remove(tcdev); +} + const struct bus_type tee_bus_type =3D { .name =3D "tee", .match =3D tee_client_device_match, .uevent =3D tee_client_device_uevent, + .probe =3D tee_client_device_probe, + .remove =3D tee_client_device_remove, + .shutdown =3D tee_client_device_shutdown, }; EXPORT_SYMBOL_GPL(tee_bus_type); =20 +static int tee_client_device_probe_legacy(struct tee_client_device *tcdev) +{ + struct device *dev =3D &tcdev->dev; + struct device_driver *driver =3D dev->driver; + + return driver->probe(dev); +} + +static void tee_client_device_remove_legacy(struct tee_client_device *tcde= v) +{ + struct device *dev =3D &tcdev->dev; + struct device_driver *driver =3D dev->driver; + + driver->remove(dev); +} + +static void tee_client_device_shutdown_legacy(struct tee_client_device *tc= dev) +{ + struct device *dev =3D &tcdev->dev; + struct device_driver *driver =3D dev->driver; + + driver->shutdown(dev); +} + int __tee_client_driver_register(struct tee_client_driver *tee_driver, struct module *owner) { tee_driver->driver.owner =3D owner; tee_driver->driver.bus =3D &tee_bus_type; =20 + /* + * Drivers that have callbacks set for tee_driver->driver need updating + * to use the callbacks in tee_driver instead. driver_register() warns + * about that, so no need to warn here, too. + */ + if (!tee_driver->probe && tee_driver->driver.probe) + tee_driver->probe =3D tee_client_device_probe_legacy; + if (!tee_driver->remove && tee_driver->driver.remove) + tee_driver->remove=3D tee_client_device_remove_legacy; + if (!tee_driver->shutdown && tee_driver->driver.probe) + tee_driver->shutdown =3D tee_client_device_shutdown_legacy; + return driver_register(&tee_driver->driver); } EXPORT_SYMBOL_GPL(__tee_client_driver_register); diff --git a/include/linux/tee_drv.h b/include/linux/tee_drv.h index 850c03b2cdea..e561a26f537a 100644 --- a/include/linux/tee_drv.h +++ b/include/linux/tee_drv.h @@ -315,6 +315,9 @@ struct tee_client_device { * @driver: driver structure */ struct tee_client_driver { + int (*probe)(struct tee_client_device *); + void (*remove)(struct tee_client_device *); + void (*shutdown)(struct tee_client_device *); const struct tee_client_device_id *id_table; struct device_driver driver; }; --=20 2.47.3 From nobody Sat Feb 7 13:58:47 2026 Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6FB3131618C for ; Thu, 11 Dec 2025 17:15:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.65 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765473361; cv=none; b=ZkiamdbF/eosYKl1UXeymE85u1Vx8N0T9V+YuvgxX1fGKisAOCKDThfDhmDtqaHgRgU/ZIztqT0aRRUl+Z+v2Uk5DaFSVjJpAChgvt8TvkVq4SZ+GCQrojbHPN8MFe3C3tg7W0YtAvUxxy1w4PcjhYq4SdXH6z+VikccoFrrArM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765473361; c=relaxed/simple; bh=8zVhKFZP7IOwG2HejecPI/IgKt38gHvxnCsmDQ6Sszk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=u1KyWJQIpMULUYnc/lpOMWC/h64Pf2SLAB7hUcKxwlUknwy03wlKIwUnmY9drXMeu4xG1CXLbOzUVNmKZMYtduhcVhIiu1i9XyJuD5DhNSPauTu9Is8TyUUkHKvtOyu11trOHqrSUwzoHamGyVXq1ijtVVKCPRgpUdjhssfPPdw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=biedej/8; arc=none smtp.client-ip=209.85.128.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="biedej/8" Received: by mail-wm1-f65.google.com with SMTP id 5b1f17b1804b1-477ba2c1ca2so4526095e9.2 for ; Thu, 11 Dec 2025 09:15:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1765473357; x=1766078157; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=c7ZJJmdzlrCrLbhlEnenhFAo4uP9QJmazFjd0L4SbNo=; b=biedej/8sLqJMb9sSsoyy1zXxOitOCa6x642+9eeBOrno1rYMqgXp8aP4bFnz57G0R cYl3d2oMDN0xLH5HfKo8JqNCezrV/Ya7f7UUv3LGU+a9cgp/mSRhUxsY1/nlVyOiOa64 xB3bsPZtThzp46iYdWnEvYri0J1d5GjbKOn/1z8+sqCTOMdzYDZxlq03XgyrjpyTZPHM AcV3egG8PVVIL76Kt21yR5vb7FoQpXSfN6Qkb0IfuvZ3YKWOKx6yRAgWudOwL1F+m0dm XV9c5pluaHwV2jSD6kj6IyqdXT4OefRuAqMCc4mP5cdzW5lqCcM3sijIfcf0V42Pi1jm WiUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765473357; x=1766078157; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=c7ZJJmdzlrCrLbhlEnenhFAo4uP9QJmazFjd0L4SbNo=; b=YA8lF/b4i7exa3Vtkh50uZHUsmTOcnwLQmkpBr11RXiUTDrloZaRLIIz/qzgDYO713 d0P1ylKVOjYC7R3xmmpwXjaoFULUEHYJOfUdpqfkSqNsEg1B5WHstHxCEyCfH3aD/Z4l HlDBAupSd8cvPPgplkRrU7JfcsKvIxl0jgyYKL8mGP6cKLvSR1XwAHCEyQO++kJvybSI prfF/oYNRZAHSXQLDMpSd1epJB21VOgH9ikPjx/KYdmIYLoZT3U6erPfbKHMErniV9DG hhVw6YOGfJOBx4rh+ipt2+DccGVNYY+71/JfZ1kAflVyda5zjr+pzEetXkB625LG3RB0 k9RQ== X-Forwarded-Encrypted: i=1; AJvYcCUafaLzhNgfXywY3HyqS9Ytppe4gcclL+7ndt4bai4cC0HtIIHpbkgYGT95jGB1tmEKu4ZGgaa5jrF58dI=@vger.kernel.org X-Gm-Message-State: AOJu0Yw13fTEj6Ps2h//opTE+1eKdm6DWnD1mywaHXXpkT/o+3wrI9kp 1OFhQiBzyPoqN2gi3M635DaFGSYUUdZGZ3SmxAyjF7BvLeOWFWwh9GcdPPU65ONTxYo= X-Gm-Gg: AY/fxX5Fk5oZzN+V3QT5lAqRutapxyHUQ9Fureo5q9E1lc25rUPIyxk/ygXaDoeyahO 9nN7Fh0o9r47g8v1VXTYfRwG/NTukONtggfgwumVDf9SOHPCUMTf7QRjRsgpuF+9HyvvfSXTWOy C5PSmgZVLDCbacT4B9Iuh84zLwqlZXzHBecDuHtIHQAbdKHIGqoq1r2fwBP+GY40YzSiYBoZNH8 dnUeGiO+lK3QKQVhUPQt3lrxKXPIm3LXWujNA2c/jqrfGIsp2q360AinE4iInyZVesdo5g4g4SF a38MIwUcTkG6oE3Vga3iqUd3ax71Fxgps1zI29J2SiDBRWN4GLgBwsW/eDcdKUiETX8hrUx1Piw jJK405dse4gxPstZcDBw8WcRTpfs0vISUD0DO5PQPo+rfggKW2hVdTYEltojhUIbAAHMaMSje74 fRJ85HRW+VDS/gzJ5NAXU1gYrfn4wGpfjBpFbsqnSyFLElP2gNikM1fspMV9iUX61RXU9gQt7pr Hk= X-Google-Smtp-Source: AGHT+IE1mgSXNtTkZxTIkIVNCLHiHTWh3zcJ768KXxVhi/PFBHebJl9bcsXJ/5Lq6ADso4vAmmKvDA== X-Received: by 2002:a05:600c:154d:b0:46e:4a30:2b0f with SMTP id 5b1f17b1804b1-47a8384dd86mr72360895e9.29.1765473356862; Thu, 11 Dec 2025 09:15:56 -0800 (PST) Received: from localhost (p200300f65f006608b66517f2bd017279.dip0.t-ipconnect.de. [2003:f6:5f00:6608:b665:17f2:bd01:7279]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-47a89da4756sm47517785e9.6.2025.12.11.09.15.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Dec 2025 09:15:56 -0800 (PST) From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Jens Wiklander Cc: Sumit Garg , op-tee@lists.trustedfirmware.org, linux-kernel@vger.kernel.org Subject: [PATCH v1 03/17] tee: Adapt documentation to cover recent additions Date: Thu, 11 Dec 2025 18:14:57 +0100 Message-ID: X-Mailer: git-send-email 2.47.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1263; i=u.kleine-koenig@baylibre.com; h=from:subject:message-id; bh=8zVhKFZP7IOwG2HejecPI/IgKt38gHvxnCsmDQ6Sszk=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBpOvwbYEpgUrQTB/R/2GTeWL815mB0BAhAQpj3E kRFR2HG5BWJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCaTr8GwAKCRCPgPtYfRL+ TggTCACRua3Ow2uFKSN9NaHuIpY/1x6Vn+D8N3yqVWCzpXWfLFn0uYy3wim+63CPJUM7UVA/4GG CTqizdb/AgYzcCV6kuZmneAZ9YyoafvSMTU/buBSxjBzOa0W5yXwPyy3JDER2as71IIEowULq+s b6kE8ShtIlEa70Kyh/GY2/7UxkXvpjUFRe1xwPVQ8QyBdU5i87OiD3/tbOOA6Hi0ewyo2srDxD+ kdbprxutTs0tAuSs6yk1jhuLR5iJDQI3Gx0u5DvehnehxvSr1Rjh/3brqVAUpltlzvxQJlYSF/l bwblBx0k1eEMf//lYAMx3mI65i2KwOywW7qxZgQTiCfN6mbw X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable The previous commits introduced some helpers to reduce boilerplate and bus specific callbacks for probe and remove. Adapt the reference example to make use of these. Signed-off-by: Uwe Kleine-K=C3=B6nig Reviewed-by: Sumit Garg --- Documentation/driver-api/tee.rst | 18 +++--------------- 1 file changed, 3 insertions(+), 15 deletions(-) diff --git a/Documentation/driver-api/tee.rst b/Documentation/driver-api/te= e.rst index 5eaeb8103988..4d58ac0712c1 100644 --- a/Documentation/driver-api/tee.rst +++ b/Documentation/driver-api/tee.rst @@ -43,24 +43,12 @@ snippet would look like:: MODULE_DEVICE_TABLE(tee, client_id_table); =20 static struct tee_client_driver client_driver =3D { + .probe =3D client_probe, + .remove =3D client_remove, .id_table =3D client_id_table, .driver =3D { .name =3D DRIVER_NAME, - .bus =3D &tee_bus_type, - .probe =3D client_probe, - .remove =3D client_remove, }, }; =20 - static int __init client_init(void) - { - return driver_register(&client_driver.driver); - } - - static void __exit client_exit(void) - { - driver_unregister(&client_driver.driver); - } - - module_init(client_init); - module_exit(client_exit); + module_tee_client_driver(client_driver); --=20 2.47.3 From nobody Sat Feb 7 13:58:47 2026 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 93831314D28 for ; Thu, 11 Dec 2025 17:15:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765473361; cv=none; b=kS2A6F1Ciev8PFEEldtbsSO4iG+piLx8G3ibLV8YD0GCOUOOFjc3xY2r/7FsYoAk6o3Ih977K28j1PUkNB/M37m3w3dC6F0oBYj9IbrslVyG8PHOkSbJAkU0Fk19kdjDwNpghuGkvcX/ExXeSxWgzivaLUEaKp3dO1bYkPSELJE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765473361; c=relaxed/simple; bh=ED4QDS/p5ezOJu9uewMwjvvUOpx4P5cPN2q3KMWraJk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=QqSTlAz+RFzfY9SwWZAEkS/PUtK5wxInJtB9Um0QBEv+z6EIgYggirYVmIUr4e4Z8pGjBUox/PrDWRV0Ui23qFCPp4XZKKJfWEGBZRPoUtsuiFzrdaZITvwIQYK3mbPW0Hkn+HkivD4ayv2m2Law+le7t2bBMW2gFvCp9psACos= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=UaPOZ/jh; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="UaPOZ/jh" Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-42e2e47be25so195251f8f.2 for ; Thu, 11 Dec 2025 09:15:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1765473358; x=1766078158; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2sYBv0VIc9uiVK7zr2SScY7OQ8xufQ34jRkhj5KD4lc=; b=UaPOZ/jhF/bbyo6KpQfUEhzZdan9fMXkQhmENLWWwTSDa6lurV0N+jUXu95lMo3st0 55G7/RUmf1sGq0+rDD6MfyZ/1KjETo7tfcEC7oKCGDJqwUZ66jDVyY6ODficOzvXcOMu 65qiVmnL58VI9J8GVkVXfj+hG0o71B2jz1NqsK01dvJWdtuKbEVos4H34+mhUXANhb2T s3H/qLJAFCJsGTZXPy/CcpfCGVpsQMJ9CC0BlIBLNUac05KqwZifmBnmnNYgSSYRmiM8 qKGCTPgXTnsqdVGqEuIWNX+0rowIztO2nETmCM5RxkewNnYR9piMmJA1dEPgPduLbv18 n4IA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765473358; x=1766078158; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=2sYBv0VIc9uiVK7zr2SScY7OQ8xufQ34jRkhj5KD4lc=; b=ZbxMnMCA5ZSdttt7EB/kKMgTOucVqUn2GkQv+RaB5f3jz4v3rClHdQxFMfeab97q0P 7nO0OydgnENicabIizC/n0DqE5D50MhBVphOIzAlUN2DlquIHyq0H3xKKJ/k536aXl+s bDuX+HnvRLveN9c7t+mBxM4SK8lxLD9LQyPAXqa50glgcoxhpJr4Iz1FroFp5aX73Vz3 q/BoXQUe/HQjT/hA1/u91ciCQQOjdnfk53QuW7qel45EXis1vkqPxa3dH5eDMzqJupkp guNdWwPkElkpWNSvOLy3KOXmD/l/gL4LoIziosFki/zMKbfVS1pF5X3XdvMNm0h3bVf1 AsRQ== X-Forwarded-Encrypted: i=1; AJvYcCWwin5QPpC1HlPhpGsHkGhGmtwFYcobce6QKMQr7ImKtyUQtesCOVJdQIwzGIIt7zQCt/zI1tJPiwNjJ3o=@vger.kernel.org X-Gm-Message-State: AOJu0Yz5RxgDsDjivqGyP6ZoqhH0UJKLjS6eUyC+VeBq+/5H77H9JWbd TGtaeLjGAvuq9CGA9DLgdhLt7zvnMK1GWzMEF+6QE8LYxTkoAtPqxtaSS2mRm3LtyHg= X-Gm-Gg: AY/fxX4umTeEcKrcw3ptWJpiy3PX+e9zyurS0pKtSPQaTzR/E7tdlMCpVfg6FKtf1tg S4YAhkJWFJTBd8bBY9QVTTjXO4IDOMpEBYinUszD3OwoqXPTtrUaU0eqNq7KcZQvReYqzFKFO0J /JVLqnGhtrEhfDMV0qBOW+0XY08m6prJG9DgatOR+NI7vwz/dUHpydg6VKge7EulD60H9VgZSQr j5ZQR0jF8KKqBWtdBsJNfK6jj6cXTvTuO4JWSfufqXGQHU6zxxD79s5RVLdZmp3R5QvF5UhvghT ttIRQ/eYG/YRtj3xkOz+OunKDBrQpwW/jIwEFiaeDW78KyZrkarmLapEbsteHTpAbjSOc43ITvw JjqhO30WFoDYP2LUeUFdBxPUcQpf5hYmaZzGvL7NJer8xVoraE/B+CcIdwhFEVSW3kmL1t68bAc iIBT0qu2NVb7PzRX5F2fbi63JUZXub069sT7MJ+v1qAksE0I+uXCIS8BWzXPLnS9sItMHL5coRj A8= X-Google-Smtp-Source: AGHT+IGF1uSM01yvW8d2TIvQK6LFiBzRrZVRvLXXlEpWqmt343Ufg3Z/zBmzXdNt3aJjfGwNiJhuTg== X-Received: by 2002:a05:6000:4010:b0:42b:3978:157a with SMTP id ffacd0b85a97d-42fa3afe913mr8449237f8f.39.1765473357944; Thu, 11 Dec 2025 09:15:57 -0800 (PST) Received: from localhost (p200300f65f006608b66517f2bd017279.dip0.t-ipconnect.de. [2003:f6:5f00:6608:b665:17f2:bd01:7279]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-42fa8b8601csm7593114f8f.22.2025.12.11.09.15.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Dec 2025 09:15:57 -0800 (PST) From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Jens Wiklander , Sumit Garg , Olivia Mackall , Herbert Xu Cc: op-tee@lists.trustedfirmware.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v1 04/17] hwrng: optee - Make use of module_tee_client_driver() Date: Thu, 11 Dec 2025 18:14:58 +0100 Message-ID: X-Mailer: git-send-email 2.47.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1263; i=u.kleine-koenig@baylibre.com; h=from:subject:message-id; bh=ED4QDS/p5ezOJu9uewMwjvvUOpx4P5cPN2q3KMWraJk=; b=owGbwMvMwMXY3/A7olbonx/jabUkhkyrP7KF1stD5hcvn3powhP5/7MvcLiIFF7SWuTDpJSzc /eHO6JHOhmNWRgYuRhkxRRZ7BvXZFpVyUV2rv13GWYQKxPIFAYuTgGYSMx29v9FwWuOs71I5nqu zmoe1RIq1nFZ7ejRsCy9NXscWbR2XpUws+Hlsz25wu1CQILcllxh+3c77n/y/nc9Kpyx86AQ15+ XBV+5+tOmeHamRL1ke2K5govz1RU/rSdqd93lS6x6v/y692p72jxN0asM+/6nTnSoCDpjxXrukO Y+QfOw2ylu5ur635IjjLYZzzxW57VVyUHq2NrkfcdDTu/6lRGmXRzI8lRli3CHTeyaWdwft2tGb bvK89DmqPUd9lPM03T73New+71p+bqmNEu4N5OtxtLXb3J3g6Vkiz1nh5LK6hqDp35/JXzcg+V/ ez80OeqTJNSuWCjMeeIY63tB120PLJps9A+ESm8Vzq8EAA== X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable Reduce boilerplate by using the newly introduced module_tee_client_driver(). That takes care of assigning the driver's bus, so the explicit assigning in this driver can be dropped. Signed-off-by: Uwe Kleine-K=C3=B6nig Reviewed-by: Sumit Garg --- drivers/char/hw_random/optee-rng.c | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/drivers/char/hw_random/optee-rng.c b/drivers/char/hw_random/op= tee-rng.c index 96b5d546d136..6ee748c0cf57 100644 --- a/drivers/char/hw_random/optee-rng.c +++ b/drivers/char/hw_random/optee-rng.c @@ -281,24 +281,12 @@ static struct tee_client_driver optee_rng_driver =3D { .id_table =3D optee_rng_id_table, .driver =3D { .name =3D DRIVER_NAME, - .bus =3D &tee_bus_type, .probe =3D optee_rng_probe, .remove =3D optee_rng_remove, }, }; =20 -static int __init optee_rng_mod_init(void) -{ - return driver_register(&optee_rng_driver.driver); -} - -static void __exit optee_rng_mod_exit(void) -{ - driver_unregister(&optee_rng_driver.driver); -} - -module_init(optee_rng_mod_init); -module_exit(optee_rng_mod_exit); +module_tee_client_driver(optee_rng_driver); =20 MODULE_LICENSE("GPL v2"); MODULE_AUTHOR("Sumit Garg "); --=20 2.47.3 From nobody Sat Feb 7 13:58:47 2026 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 03F0A3161A6 for ; Thu, 11 Dec 2025 17:16:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765473362; cv=none; b=PkP2Y7oC/XcloW8Zax69fSeivWsttN73yEtgj403VLzSpBGqeamQFxoeloWZKdXHlnAyKStGbGpB3H0ahbwtP13NO3S0LABATCwnL4nNZW3PkB7ZB8/LykFAqtQoh8g435dG40IDWiPRyMwpo3TU+QHJmHScM0qQVARnMQz8yD0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765473362; c=relaxed/simple; bh=9/MWuHZltbfrljfghNMjsFGbpJYDdAIf/qKdNwaHWyQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=c5ykdKw1zudiRpQAwDWIHCu5JHvt9dQy/8n8/5ecSOUw1KrtoId9GEm+eLkr/SuZ6c6Gz7QuIlBJAVRIRQhI3tM5y60LX25ACvxQqOl5WHbucsrz19upxw1DIpTsBFE06XwCFeosY54s9jR6WHN42rmKZW8cYdNFWXIk0ylYEX4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=gdrL7IIc; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="gdrL7IIc" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-42b3669ca3dso197630f8f.0 for ; Thu, 11 Dec 2025 09:16:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1765473359; x=1766078159; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=I4l2h6ylecBmmb2NFGzo9KVhF/u4WxGR1OPEqHGghSQ=; b=gdrL7IIcidOpr5xYgEdPCULyHIwZL9xLmvlYt6Arnkhx+CQH7SXWRQWsAnUs3V/PSv FkkD7KsXJfAmMIkJILTionY53sn8jYQO45CKuHGwPoKIX9CMtaOiYRzdFTXauES33Mo8 T51CInjnhD5zdEN8gqhEQtBxHk4W/mGyqqdXCF+1Ex6vqZfdt6ajBJC6pUHoba8Fm2nV VbQhNYakG8LWalF/5qCnTLIjeHqkRDb75biC1CGt0jx+YkowovjIr8dpuHX5SaC2BLI/ THtYO9AUW4nUCVwCNfOxuDkWiikFIit08KjxybeRyTqe8DoiQPK1HqOBCetOG6dX5EZn G4Kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765473359; x=1766078159; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=I4l2h6ylecBmmb2NFGzo9KVhF/u4WxGR1OPEqHGghSQ=; b=RAqwDn2EYlmlb8RIPDGZnqE9si5dbYiNsptJZHLbSiFDtjnHqXcUHptl1z/SaJPUMO OjRgWlMRbTgMrq1GkDHfOFkHA7kY1uF4PtzI2kjoaNCpceC0Ddv3LgUUa7ZgCKN/KKDq eYULIpmqZJMqNczbrZXqfhLKLX5ZPyH1KAs1XXBZ+NygHkiWDP0+O9Bq+mkhQq4kE0Lf cefsXvaZUlpJfvYMWsgptGg37rNAYc6KEODmoIrcAoIR73UK519TZwcqKKdlFAQER6IQ Tb6guZr6BH9yiAB6Rw7RKILGY699k1H3jfmTTP+XCs9sKyZ/F3e7DCSyNqEbrMZaDLDA h0Cg== X-Forwarded-Encrypted: i=1; AJvYcCVR/v1QLe8UU25g+5378jXESr411V9X9C96ktgrIYEZPuh7KSlaDeEMs2Oxg0fbh9SeOy8N53qARdHMul4=@vger.kernel.org X-Gm-Message-State: AOJu0Yxl0iHh+v7IgoyM7jSUE+mVYgY7rVcr43zlajy7K0PsRo6QpY05 Us66PmH0PzjkRbMyg4uyiOtcV6bIIw/+rE1qzE+9wBt2sY3a3Yf2TlHOaeXU43s6+P4= X-Gm-Gg: AY/fxX4m0IRT9cdP/yk270gshzu3LTiVN49RcTD2OBh38bUyzPjg16Fr8wRZnw2AYnu qp6Jcu/M8Bc8YiMiKA9p/io1qexay3FDW2QHKtqbTNG6hCyIXNF3mAbqarJ5/XJsbIfNLmmG6cc myl4qlvFDw9AyC63TfKTRID+FCL9CTuEuRlzjso8dg++LHWNgpa3kMJTEEU5ApMTuF0PEVbNb8D IoP+JSx4B0tuhHGO+ZS2uBEAaSBUdJrqcGttYzZIXYlCaA4bCzK9X77V7CSsakHtGQ46KAiASbs 2eAAChMfgE4eAtYFxHM0ZZFfsAmdGoSG8XGgxc3/qcKExIN65V2FiK5ZEKPvRWAzH9SDSWScFWA F+RgUJFUkZBXrO4P2ctnTA80Gn2LXShvejNepTF7VFpdAmKAad11ZASmV2rP/8J7QEH3aC3mOHD xIonbOaA2JMn7SdGwZ577hxtl9lySZaotbDzDuTK4gpbFGBjvH2iLBv8pHv2qeTLscMZnM7/u7e RI= X-Google-Smtp-Source: AGHT+IHznnkl74xT2z8JC40wM/v7wIF0q/FLhgvdfq6Hs39to3yRCTNdr19bDlPbZFNrY6LaQx6MyQ== X-Received: by 2002:a05:6000:4308:b0:42b:2c53:3aa8 with SMTP id ffacd0b85a97d-42fa3af8df1mr6951355f8f.37.1765473359065; Thu, 11 Dec 2025 09:15:59 -0800 (PST) Received: from localhost (p200300f65f006608b66517f2bd017279.dip0.t-ipconnect.de. [2003:f6:5f00:6608:b665:17f2:bd01:7279]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-42fa8a702a1sm7588863f8f.13.2025.12.11.09.15.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Dec 2025 09:15:58 -0800 (PST) From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Jens Wiklander , Sumit Garg , Olivia Mackall , Herbert Xu Cc: op-tee@lists.trustedfirmware.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v1 05/17] hwrng: optee - Make use of tee bus methods Date: Thu, 11 Dec 2025 18:14:59 +0100 Message-ID: <83301effbb923117122f5f076edbfdad1f947386.1765472125.git.u.kleine-koenig@baylibre.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1830; i=u.kleine-koenig@baylibre.com; h=from:subject:message-id; bh=9/MWuHZltbfrljfghNMjsFGbpJYDdAIf/qKdNwaHWyQ=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBpOvwglYVLSe7x2hJUzJuiko+CB65bc9zowSFvy IrqbvBxWmWJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCaTr8IAAKCRCPgPtYfRL+ TjUkB/0RRiOrgJTBYNMrNgeZXzR7aDDF6ecj9C1B+6tXZ7EDmvu8w1XfWPampNGADTlFFns02Y2 LcJ0fjr5W8rEgvvRvmeDkmqIlZDW1J7Z9k0ShbGUoFVmleBaweG7398LO15X4tX3jJcOBzM94+f CfiOZAwcVz/lm2J3pH1msmxQJRWnmsB4T2q1dcBBMcwK+fH38MUrcB9sQ0VujUDfH4GGttfGC0B tIGIcWaG0JZeEBzxS3WiBsIiiZBFQeYyMtV5HaGpas8QjbvkfSJlACbwShtObNGb5zbOpskW+qR rZZE6YursT3IFX7j7pUMcFZthadnRzFHjaS0aAf/8pw+LVJe X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable The tee bus got dedicated callbacks for probe and remove. Make use of these. This fixes a runtime warning about the driver needing to be converted to the bus methods. Signed-off-by: Uwe Kleine-K=C3=B6nig Reviewed-by: Sumit Garg --- drivers/char/hw_random/optee-rng.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/char/hw_random/optee-rng.c b/drivers/char/hw_random/op= tee-rng.c index 6ee748c0cf57..5a3fa0b38497 100644 --- a/drivers/char/hw_random/optee-rng.c +++ b/drivers/char/hw_random/optee-rng.c @@ -211,9 +211,9 @@ static int optee_ctx_match(struct tee_ioctl_version_dat= a *ver, const void *data) return 0; } =20 -static int optee_rng_probe(struct device *dev) +static int optee_rng_probe(struct tee_client_device *rng_device) { - struct tee_client_device *rng_device =3D to_tee_client_device(dev); + struct device *dev =3D &rng_device->dev; int ret =3D 0, err =3D -ENODEV; struct tee_ioctl_open_session_arg sess_arg; =20 @@ -261,12 +261,10 @@ static int optee_rng_probe(struct device *dev) return err; } =20 -static int optee_rng_remove(struct device *dev) +static void optee_rng_remove(struct tee_client_device *tee_dev) { tee_client_close_session(pvt_data.ctx, pvt_data.session_id); tee_client_close_context(pvt_data.ctx); - - return 0; } =20 static const struct tee_client_device_id optee_rng_id_table[] =3D { @@ -278,11 +276,11 @@ static const struct tee_client_device_id optee_rng_id= _table[] =3D { MODULE_DEVICE_TABLE(tee, optee_rng_id_table); =20 static struct tee_client_driver optee_rng_driver =3D { + .probe =3D optee_rng_probe, + .remove =3D optee_rng_remove, .id_table =3D optee_rng_id_table, .driver =3D { .name =3D DRIVER_NAME, - .probe =3D optee_rng_probe, - .remove =3D optee_rng_remove, }, }; =20 --=20 2.47.3 From nobody Sat Feb 7 13:58:47 2026 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F19AF79F2 for ; Thu, 11 Dec 2025 17:16:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765473363; cv=none; b=WHP035dhxkHpVL4QFyDUH0r7iQLwNd5ABfdb5nsLOJ8sn5Bwt1UA7biYdeqrBnZshLgIxGuB6trdLCEdW5BLw5dcTXVrgcl4LLzP+U7eD6oRqNJx6qwQ9N3sudSYyhkCq78Xk9EhXdDUKr/7/vWLYK+XP1/ftz+vi+zw4JhhI+M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765473363; c=relaxed/simple; bh=KbP7EtIirsjcRAVahUftVfemTrSz9aRFfaaIcH7+JL8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=aKXoo3r9Zu2ZoskWazGv5Ymp3rR8zB6wQ5tPcSxRYMpZ5nLrtDgjYjV7bADzpF48tGP0eQ0SAaJoRJws7hojA7T1TB35AhmyWlD3TRns18fNM0kg7Nj9Zv5GeWOD7xwMSeaoHh80i2S1gM5SzdLAxoni+frYsYVKRq6ttA/Kv0k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=fD0ls+X1; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="fD0ls+X1" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-47775fb6cb4so3492305e9.0 for ; Thu, 11 Dec 2025 09:16:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1765473360; x=1766078160; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/JeA5gq6kRi4Lyd+VAOvX0wqPm9BAkVnCbcQJTu0Rxw=; b=fD0ls+X1rltarPRenZleAvJyz8C+3IVfKR0xvSm4/hnyQtYR7iRCgSPMPKF+0GeQwc 4P7B1sJG1eBOEMSmngDfVM60Y/qvU8Xv502UlV7mgXyIU8Wdiiyl8KW3OqMF7iTWf7zL uF5n1H+ab1PNRrpGRq/28OIPNyULw810D02ZowoG8fWizu3mVEV7piKAKBvjjsE5kyz8 DjEFeGtoynZgIX2mgCUNayp2ytrFKuvz7FFMwAAknew1sfBuQODuMe7ggA1B6gI9dQHB Q6aYyAfa0Rx1M5o4wN3mYaZvMS5CmecFFyJTyz+bX91BbUyeupd/iFD4fip16RVwO7U/ ieYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765473360; x=1766078160; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=/JeA5gq6kRi4Lyd+VAOvX0wqPm9BAkVnCbcQJTu0Rxw=; b=uc0+9pZ2e3Bbu37iyCGdNqvuwdUJw5u9XDOXAV7ym/KkqenHiGkmsBy3HXO+RFr7Ov 9NwmDPJmac7GGl4poT/4K1n83W3L8Rls3E1C1HTvaNvQo0B+2wfyxkEUDbpC/rF713Vk oUTpSo9uE2ll5OiR3wM24w9dooUrV8Kh4ufwClfpty+x3Qap2BuHabtHcurnb5trJZKL qgR1/7TVx9krkJ3BewHzmPrV3mwKT3s9bA8EdU9nJYUWHOnGaOeMRy+Nqn6daYRCKvZ2 zCyAqS23yzAgoENoU4DHJ8srV43midcKJXfZqHZpG4rKAax7Bd1HxQ8+NB0gi3FuZHyl x7ZA== X-Forwarded-Encrypted: i=1; AJvYcCVYWZVKR4h7EVIWf36oXLXiG7wHTaVz+g94zvFE0y6yjmKYIvkca642L137zLt9kLgHRvWvaVQsk5celJU=@vger.kernel.org X-Gm-Message-State: AOJu0Yz3xYJIEJr47t2svzgoyzaDvjzzyYvowjuuzsvrRG7pTnJZ//Wg YnWIbjrtZ7ej77R2y9V/VspUt5qz9guTL+kyZ3TDHBlqBsWnSLIq8iSbLjLSkCugStQ= X-Gm-Gg: AY/fxX4J/TZH+aXburoumjaeRA9SGvVVNG1s3/qM4D2smkl/MRodz9qnlX62L0WrfbQ HkP7QKjJIyXw6Om2m/vCrPP+ZaXAgdUh4os8/kaknTRv3pjzRWW7/NfVabF0rZhCY29mmnQRkLd d6DnwWCsLJottlf12T3RoEeaws5+IEKCFF/qCLyO+n293zvRJP8SZfdj4yxbD6yPKHmoOjqs9i8 x+6yYghSdIepIHXcHP1jKs4gYhQ4CxMzK7fIiG267NWKlhWQX3rIukqdzSRYbfZbawTEal+4uJY s8wEO04//qYc7moc48E3wAOmnHQSh0GXhmRoAdAJ4eWZVe3p6GxOVgU6xoaJdSEhHznyJSywVLf aTlvyfMvkoAbMClQbCJ+XVWnflwenO7HqpZbjH7Pfhpc+D4mKWFZqk1DYUNZEAOPJ6yoPqRqR8C bZlWXdxXmd4slLdhYhvy16WRS7QqmCdTvWTD4wRTYnjoAG5MPm4HaztNDp0U2/3QksIg9Qak/Mf o+PQ8aYZr8lzg== X-Google-Smtp-Source: AGHT+IG/NQc3Y5Xt3abMDqEbPYOZHmotYsONgdb/bGoMIyIIzzMZ1acDR16pUEw26tEqcueZJ6sXRQ== X-Received: by 2002:a05:600c:8207:b0:475:daba:d03c with SMTP id 5b1f17b1804b1-47a83804375mr67687815e9.13.1765473360269; Thu, 11 Dec 2025 09:16:00 -0800 (PST) Received: from localhost (p200300f65f006608b66517f2bd017279.dip0.t-ipconnect.de. [2003:f6:5f00:6608:b665:17f2:bd01:7279]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-47a89ef954asm47349765e9.10.2025.12.11.09.15.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Dec 2025 09:15:59 -0800 (PST) From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Jens Wiklander , =?utf-8?b?Q2zDqW1lbnQgTMOpZ2Vy?= , Alexandre Belloni Cc: Sumit Garg , op-tee@lists.trustedfirmware.org, linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v1 06/17] rtc: optee: Migrate to use tee specific driver registration function Date: Thu, 11 Dec 2025 18:15:00 +0100 Message-ID: X-Mailer: git-send-email 2.47.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1360; i=u.kleine-koenig@baylibre.com; h=from:subject:message-id; bh=KbP7EtIirsjcRAVahUftVfemTrSz9aRFfaaIcH7+JL8=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBpOvwiVjxH75Z6V50l5vwIkZOM4q9gf3DvDfDBz Rf+99hzFmyJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCaTr8IgAKCRCPgPtYfRL+ TsWFB/sETCAgBSQbnWadmTkVaxUsX0RQ9keYFWz9xaj+ZG8EblKQPnZlpyxpCfxRZdba4NgHXCR p4f7Q7PUDE51bxiwpQV1v7pZM53XSF8Yugau8J/vt2j7z04FHsasETvyeLc9k24wy5OERHU/7HD 6kaptYCge7hFfQXdGGciUwf6raZqq5dww2Tkqm3Qv7x4p7mzeql9dW8ydUNN852Rkb9ySfPaYTT a6Q7ZxOqowSsSkidxfXID5+uFyELafRGsTEK7P+OPQzNQkFUebTB8uSE3D9RWWUnmSKo5SKYoK4 uvyChsBQUxiQqtP3K6Hos1EqHSmbdGSvMc78yl2iMymDW94L X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable The tee subsystem recently got a set of dedicated functions to register (and unregister) a tee driver. Make use of them. These care for setting the driver's bus (so the explicit assignment can be dropped) and the driver owner (which is an improvement this driver benefits from). Signed-off-by: Uwe Kleine-K=C3=B6nig Acked-by: Alexandre Belloni Reviewed-by: Sumit Garg --- drivers/rtc/rtc-optee.c | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/drivers/rtc/rtc-optee.c b/drivers/rtc/rtc-optee.c index 184c6d142801..f924a729ead0 100644 --- a/drivers/rtc/rtc-optee.c +++ b/drivers/rtc/rtc-optee.c @@ -726,25 +726,13 @@ static struct tee_client_driver optee_rtc_driver =3D { .id_table =3D optee_rtc_id_table, .driver =3D { .name =3D "optee_rtc", - .bus =3D &tee_bus_type, .probe =3D optee_rtc_probe, .remove =3D optee_rtc_remove, .pm =3D pm_sleep_ptr(&optee_rtc_pm_ops), }, }; =20 -static int __init optee_rtc_mod_init(void) -{ - return driver_register(&optee_rtc_driver.driver); -} - -static void __exit optee_rtc_mod_exit(void) -{ - driver_unregister(&optee_rtc_driver.driver); -} - -module_init(optee_rtc_mod_init); -module_exit(optee_rtc_mod_exit); +module_tee_client_driver(optee_rtc_driver); =20 MODULE_LICENSE("GPL v2"); MODULE_AUTHOR("Cl=C3=A9ment L=C3=A9ger "); --=20 2.47.3 From nobody Sat Feb 7 13:58:47 2026 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 22B33314D11 for ; Thu, 11 Dec 2025 17:16:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765473365; cv=none; b=dDB9H5gsXqSU61EwnE5clWTTkgYTkCigV3vcrtRCc47g2lQA8TmpmYH5u7WLdIVKKCng9vbTLyNXG/B0PGrbSEnU7qleQ6SJ/fnMGQgNzbtxlcgerwJVmp7On4A/odIIO5nNN4SOJxG2TyK1M+9fwekpe1OVwbiKUmlj4GE8ZX0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765473365; c=relaxed/simple; bh=AjXr0RnxTKaBv6olXD/4z+FRU9Mi+0TF8cBSgEg6f8g=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Oqfs+L0j1zMUSAYUnoKa41uxLCji8GV2UskjDC2M9M8Q00BpYrJiz/B3RZRdU5JDYojqppGYSMj1j/9KL/P1i6919ebyLBzoW12Z+UXIBN06r71Cn358EPeU7+Nl6P89TmkzvwKBoChFu5mlCHdvCcZmRb+skbpvPfAtm9gdmJM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=ZJA7zHH7; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="ZJA7zHH7" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-477b5e0323bso1787845e9.0 for ; Thu, 11 Dec 2025 09:16:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1765473361; x=1766078161; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=hi5/UGBTaIFNW77cWN4A+BHUVzdoSL5Par1+AonNNpI=; b=ZJA7zHH7SvrEoZQhLtHm46QxqJ8f0hUwHtn9mnktXnjXZNDXgZjY1V7/eT4lMUrASR 3+f0LPaQdjLkLSTDz/UyaJxry3QCv0ekS5C2wrjPnxlblMqgXBvFU/avkcAiOxfxHnxr trvXEScSsBE1Y1t32HEdE3zIrtwTc43Cz6UxpWwjUg32WUWl20v6M3mgCRfYtuf4fFig JFvpGN28aq0MtZOCxLCPeBUhy3YVfpnwWkPX/j5EY2B8tPTDkLXsRI9eh0mmDAjjtkvh Z5azExzUHbhl8zYA32crWGFOB1RpL9LtCsCzQxGf6yBT2J2Ea1NlPsttLFiCIQZ7BZDH 9XGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765473361; x=1766078161; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=hi5/UGBTaIFNW77cWN4A+BHUVzdoSL5Par1+AonNNpI=; b=kKNfMCPEikrCb66rE6YPg0H9GtOhl3U7M8+71KcBvypNcN9fXDRd4oAdOWZY8vjyAT Gr6aRkBBCDNNMMwomcXFd2JUkHmVk+CfJlF/RPbXehAe8uL2jQrSEmYLxPKQNAZvrn3e xoZD/44dbR2E5ZPGkcSPHC/WGf0QEKGt9Hy4uZeWtrqqlYMz1fTv8Q4XNtJXU91GopZN Xk559pKGtD+5FhCe65TZkpn0ZMTc7Lfhj9hyLRNSTXbYzSkIJFmFKTgzrQbnzHRd4eY9 FmlUIChVXz+/jy6BZBzmZB4o91g+qhGsCV4bH9kW8E3luBZywTOBqa84Y7Aw0cVfog/T awpw== X-Forwarded-Encrypted: i=1; AJvYcCXa0UUwXz9qG6QQKXMz1WhyoJJVw/b5ZVzABLsY9fHSLD8ELeKLC0qAV/bz6LtsyHFiRQkw048hRabZmsk=@vger.kernel.org X-Gm-Message-State: AOJu0YzT59t/TedjrXjeISRrCI06Shnypg63Zz541JVk1hkkFd6aDYwJ kPgoeFF4iEsCYgzE3X/DXECPvAkN9mhyvElEvx3zOYekTueRMuP8oi7TjR8IB3uF0eMU/2fxnVx b7cnK X-Gm-Gg: AY/fxX4WcyfgLD2HjvCaztH4ADPQX82NGZoGjt59prSGq0i0Kn0E1qAoiHRUqDMPO5h QYdYRlqf+u6TGBfcCx9BP1Z3B1rPem7bXsDinIPRfU/rftC+Jo1rUTJy+V6xoWRAlxN63+vYf+L s2lnI3ZfPEB6JuRpAdfJ351SUGTaVU40t30VRPnrAJWJwzvNMad4hEKNIFqOaCRoRVUeYDyabNZ 94aESJvWjcbT3F07S7sVolCoMoNLRlUis5Cy4NaeOYINwPtRoHQn6KZAQjlPi3s7F52AXqAVRHU QHNgSCvdZ6swB/gZo+0aHKtafbucBlI6ve33MIyGCxeSZHEEz/b11NVwevvKXOPEN6NerbJ5rbT 9zyTimXA8I28rsD7+AoeCOKCGQ5Qt64pZVJCn5PdNtkShbNDoIc0yySRCyDJ//oHeIwCwqh6wNq GdTgGL2Q4zxAq2EH9qQMyGdq3Rq5vtzg73gjWqEGs5BgBw+hyD+Agid5eFF11JLYie4uAWzbvmd WINHHB6GKUZ0A== X-Google-Smtp-Source: AGHT+IHY5a2mEHV1AlyouwF5+8ViaviivoNCaFkw1PgSwNyXbPnlUyEvOyVbTypMN1j/t55IMaGQ6g== X-Received: by 2002:a05:600c:190c:b0:471:665:e688 with SMTP id 5b1f17b1804b1-47a8d746f10mr9774955e9.17.1765473361369; Thu, 11 Dec 2025 09:16:01 -0800 (PST) Received: from localhost (p200300f65f006608b66517f2bd017279.dip0.t-ipconnect.de. [2003:f6:5f00:6608:b665:17f2:bd01:7279]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-47a89f35ae6sm43759865e9.6.2025.12.11.09.16.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Dec 2025 09:16:01 -0800 (PST) From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Jens Wiklander , =?utf-8?b?Q2zDqW1lbnQgTMOpZ2Vy?= , Alexandre Belloni Cc: Sumit Garg , op-tee@lists.trustedfirmware.org, linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v1 07/17] rtc: optee: Make use of tee bus methods Date: Thu, 11 Dec 2025 18:15:01 +0100 Message-ID: X-Mailer: git-send-email 2.47.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=2017; i=u.kleine-koenig@baylibre.com; h=from:subject:message-id; bh=AjXr0RnxTKaBv6olXD/4z+FRU9Mi+0TF8cBSgEg6f8g=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBpOvwlpOdez8ZhYb5hNC93qHUDTTVphLfbIo0cN E8LOH90v7iJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCaTr8JQAKCRCPgPtYfRL+ Tu6KB/9R/MR/L8dDMQAk3ITRzGaW3NxF1PUGNuhcn+AAeP0p6NBUMyehIjROdQz0/PnL7Zc/QL6 OfGHkdyaP6OArGGH0K0EwPhQPj5RBoJN3L9BZhzwt0V6g536z4sFqL9hcGAuIJTglvMsr6kN3Hg 7qnK+8ufdVV/Ammwt5Uw9Q4BdSiR8b7BitYQoO6kEu3ekvy1Xk/+d9GQ33yjsPk2SAZ/oL76R+o 7nZBEX7iA/9w1OESEQhrM632QEQIv2P+KMl4NBbLVnJ8a+TlnVf7T/Sh+QtGTanBUxVaa7+0He3 3U3AWT0ecAbzOq/jKxvH9fx1I8raUujwbhvQnB+o5VEZPKeB X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable The tee bus got dedicated callbacks for probe and remove. Make use of these. This fixes a runtime warning about the driver needing to be converted to the bus methods. Signed-off-by: Uwe Kleine-K=C3=B6nig Acked-by: Alexandre Belloni Reviewed-by: Sumit Garg --- drivers/rtc/rtc-optee.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/rtc/rtc-optee.c b/drivers/rtc/rtc-optee.c index f924a729ead0..eefde789d194 100644 --- a/drivers/rtc/rtc-optee.c +++ b/drivers/rtc/rtc-optee.c @@ -547,9 +547,9 @@ static int optee_ctx_match(struct tee_ioctl_version_dat= a *ver, const void *data) return 0; } =20 -static int optee_rtc_probe(struct device *dev) +static int optee_rtc_probe(struct tee_client_device *rtc_device) { - struct tee_client_device *rtc_device =3D to_tee_client_device(dev); + struct device *dev =3D &rtc_device->dev; struct tee_ioctl_open_session_arg sess2_arg =3D {0}; struct tee_ioctl_open_session_arg sess_arg =3D {0}; struct optee_rtc *priv; @@ -682,8 +682,9 @@ static int optee_rtc_probe(struct device *dev) return err; } =20 -static int optee_rtc_remove(struct device *dev) +static void optee_rtc_remove(struct tee_client_device *rtc_device) { + struct device *dev =3D &rtc_device->dev; struct optee_rtc *priv =3D dev_get_drvdata(dev); =20 if (priv->features & TA_RTC_FEATURE_ALARM) { @@ -696,8 +697,6 @@ static int optee_rtc_remove(struct device *dev) tee_shm_free(priv->shm); tee_client_close_session(priv->ctx, priv->session_id); tee_client_close_context(priv->ctx); - - return 0; } =20 static int optee_rtc_suspend(struct device *dev) @@ -724,10 +723,10 @@ MODULE_DEVICE_TABLE(tee, optee_rtc_id_table); =20 static struct tee_client_driver optee_rtc_driver =3D { .id_table =3D optee_rtc_id_table, + .probe =3D optee_rtc_probe, + .remove =3D optee_rtc_remove, .driver =3D { .name =3D "optee_rtc", - .probe =3D optee_rtc_probe, - .remove =3D optee_rtc_remove, .pm =3D pm_sleep_ptr(&optee_rtc_pm_ops), }, }; --=20 2.47.3 From nobody Sat Feb 7 13:58:47 2026 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F8203168E7 for ; Thu, 11 Dec 2025 17:16:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765473366; cv=none; b=YSNFOd4AilxCeYERBokDWQC9TXLDrL+utXhmxSTF0WsSRVP/9oYcCVpwiV6lKHbdmUvQPFwv0KE0xGsnoOTiiTxaAQBHtNmr7IFR1ocUjb3SjPDQswYtkCSbfcIN5R6f36FcvMQDPvuW9IyZSAOmbAx2oE6GWfB2nOVde1HPxHY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765473366; c=relaxed/simple; bh=kVl/h/+w7Wr0R904x5vNxSBa3qE7VLiGeImjLkLbd5E=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=bNfRg1swIE3o5iCRk9FVMJ13dn5v2dJBuhtokYNoHROW6gkcHiJ3OJSIvg11bhC+BlM+eMH5D6gLrmBlJ769UmcooS3CYrFLiVa+Iz4IG92zc8219vLRq4Z5Cd8dq6qEt0iikGlGGl3UjQQx00LWhRXuDmbylFHMicm5RXf/aoM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=y/pO/xiI; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="y/pO/xiI" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-477b1cc8fb4so2444075e9.1 for ; Thu, 11 Dec 2025 09:16:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1765473362; x=1766078162; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5a4wMDZK2ViUHeY8ITMBosr5lNb7hmzarN7W0g0+DF8=; b=y/pO/xiIbUTK3/+Pu9NPKYogkm+aMNqXlfdtz+V2TgwAg+X6Ygr0UZ1aC/4U/EPz6H aKBxu8g5bJ9E3u9uR/bXsgZn1LKIyOrtyZjgOIl7Aectczbo1CZ1hHK+jdBfTEQxp0l2 AIcKE2sPXiZSwD0RnC0aYBez8xEpw41l5mpbItONSMi3lHqMPeHfmXEf+PZfVv3CLm3w P5fFFQPySgJScg5a+4n9pKx6fVckaciHbcWyD+ZHc8VTYcks23PJ+q1hXJFgfObaoF6L fTA2yJ9lfyiphuu3Vjgmn/rPElA8dllIOODAVsuIAK+5poObyYQXT1sNsIYgnDmV74ze Sd4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765473362; x=1766078162; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=5a4wMDZK2ViUHeY8ITMBosr5lNb7hmzarN7W0g0+DF8=; b=TjGI6gi4EkxPSlQnS5gty2ntA5dpSm+K6cbSWpJReAPl9I4hQUouZhEeAF7jFtAzUk C422eOVLhbgPc6G6AcUgVDQ/Ie7rERu+5l/0HL5LGBDRmd7kn1LCjsX9WjMDdau3KH6+ Lf3Ikq2fyQZqXZ8hl+ixHRCC44Xgr9Kfd7QYn/aMii5tGC3jybkyLyHSsM/C/RnOW62M RjwIWC9GaxT1EWV/bRR4Ed4otPOR+jKu7xNw1XKArWFSyRgWrsxNGq97cVoU5eDIArDy cV0C7LVN2ZxLmfock/16M326AlsC+5MioCKBZfDiXXsSygxA+1b49XBVj5FJyZnQHqHK 1NMg== X-Forwarded-Encrypted: i=1; AJvYcCUhAqJI8H9oH0t9aTVfOt5++q/OEkZl52+Vviq1jRmlWa8EyJyt7mYJbUlaKsS4VNxHboaYXQrRV31YpQc=@vger.kernel.org X-Gm-Message-State: AOJu0YweBLfGliLFUk8Z8QFXZwRy1vi7M97pAEPzld7DcC7evehn7as/ AwEkkMK+OAu7YO0qYyb29MPnlagznyYPXI7p8cxsi3V6Ya3d6DiA0SxhRch0bnfpRTY= X-Gm-Gg: AY/fxX4eLnBhEH14x9krqpde5J96vtNJo+RugSXFmtOB8K92f2RrNHkYzF6JCsIbS04 e11w0Paz1lThCVR3LC3GbumeeOKADh/oAH/20VDKDifoqY9yHRIH6CyzbDN25sei4PLg1Eonn26 QCnnnfDXcMNEjDw+yb7KuI0o0ilYAdWR0Iu6umhyzzgbPeeNgHfZu+nTgzBzul+AeYZf01rKdG/ UikbGGzMU9W4q++O1mqhJ8KXSsOMszTYTDL2p2DDxCWhi7/I4/1sDun1kCHnEpikh2E5YNbepRV 9Zvb6oVsDvUTAAfK9a5Asg8EXVHyMsIdyzQEhX2bbP5eJ7upEaI/P9YVA8SE6ZemJjiYg3vbcIC Hs64ZAedEiHekuamTq40qOyuG4OdZYzDzEb8imJ1TW2DSJAh6KAVO6HUtGDFXFB+qhqlzWss09z gftgW7OZovAet8pGsqzc5i6rOY1CdwXcQ9836B/b4aCZKUpF+OdIaRjPCvjkJRpFMmod5JJCH6n r4= X-Google-Smtp-Source: AGHT+IE+X9wMDaoG4Q+goEXvBdmDRMpx3iuUbrVTqUSpfRdjag7tAC9TsJa1xQ5gBIFCyk9gG0Z+Bw== X-Received: by 2002:a05:600c:4705:b0:477:7925:f7fb with SMTP id 5b1f17b1804b1-47a8377b8bemr79943275e9.10.1765473362428; Thu, 11 Dec 2025 09:16:02 -0800 (PST) Received: from localhost (p200300f65f006608b66517f2bd017279.dip0.t-ipconnect.de. [2003:f6:5f00:6608:b665:17f2:bd01:7279]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-47a8be549d0sm37688665e9.1.2025.12.11.09.16.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Dec 2025 09:16:02 -0800 (PST) From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Jens Wiklander , Ard Biesheuvel , Maxime Coquelin , Alexandre Torgue , Sumit Garg , Ilias Apalodimas , Jan Kiszka Cc: op-tee@lists.trustedfirmware.org, linux-efi@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v1 08/17] efi: stmm: Make use of module_tee_client_driver() Date: Thu, 11 Dec 2025 18:15:02 +0100 Message-ID: <0896270bc530d1e3b7fbcf5f7e168172dcc05d1e.1765472125.git.u.kleine-koenig@baylibre.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1338; i=u.kleine-koenig@baylibre.com; h=from:subject:message-id; bh=kVl/h/+w7Wr0R904x5vNxSBa3qE7VLiGeImjLkLbd5E=; b=owGbwMvMwMXY3/A7olbonx/jabUkhkyrPxrp7FaL9OXe8ilvWtXDYnnXyuCubaF9/dc/qQ+s2 AX+fO/tZDRmYWDkYpAVU2Sxb1yTaVUlF9m59t9lmEGsTCBTGLg4BWAiS5TY/+dkhfWruk/vtTP0 cL2huff2Oa1DFz4+fvn+Z02QTsTZFcapRusUt3/LZol+FL1N4tx5WUnjj0vO9YtIlius3v/mkau lmEV/hrqgQ5Bo9+Z7c/u0D25JeHz1OU9of+bCC5nxDBrThLKXqna/lbZUSpX+yui1/4fwgVXZpg Vy73eFanE1iS53SWH2/Xa2N0e57UTUw1naEuIVizpdPt++cObS6W8dZyOy/66SXC7sfGmugYKp0 zdbqaeB3W3zTn2K/Z5UGl1h4r6npf6chcnpkA1NKuf+rPvXYhTp+7Q5N+XH7YzNOYd8rGv0i3Pz Fj5qvefCb/9NnHHpBEeFpB98fzf/7Jqp5mXXdlSnzIgPAA== X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable Reduce boilerplate by using the newly introduced module_tee_client_driver(). That takes care of assigning the driver's bus, so the explicit assigning in this driver can be dropped. Signed-off-by: Uwe Kleine-K=C3=B6nig Reviewed-by: Sumit Garg --- drivers/firmware/efi/stmm/tee_stmm_efi.c | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/drivers/firmware/efi/stmm/tee_stmm_efi.c b/drivers/firmware/ef= i/stmm/tee_stmm_efi.c index 65c0fe1ba275..5903811858b6 100644 --- a/drivers/firmware/efi/stmm/tee_stmm_efi.c +++ b/drivers/firmware/efi/stmm/tee_stmm_efi.c @@ -584,24 +584,12 @@ static struct tee_client_driver tee_stmm_efi_driver = =3D { .id_table =3D tee_stmm_efi_id_table, .driver =3D { .name =3D "tee-stmm-efi", - .bus =3D &tee_bus_type, .probe =3D tee_stmm_efi_probe, .remove =3D tee_stmm_efi_remove, }, }; =20 -static int __init tee_stmm_efi_mod_init(void) -{ - return driver_register(&tee_stmm_efi_driver.driver); -} - -static void __exit tee_stmm_efi_mod_exit(void) -{ - driver_unregister(&tee_stmm_efi_driver.driver); -} - -module_init(tee_stmm_efi_mod_init); -module_exit(tee_stmm_efi_mod_exit); +module_tee_client_driver(tee_stmm_efi_driver); =20 MODULE_LICENSE("GPL"); MODULE_AUTHOR("Ilias Apalodimas "); --=20 2.47.3 From nobody Sat Feb 7 13:58:47 2026 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 279943168E5 for ; Thu, 11 Dec 2025 17:16:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765473368; cv=none; b=O2xz4sXIEkU8wpWXNrBl1MRGEWVR/60LtKSScTLLSxLOOHvMdqc/RsxMTfiPWeBzwow74nSAX+46I3lSrg5b+3o/jl7tAo/hfFhIglQgRElO+BRSzoC+T8R8MTzbuzHv3jzgI6RwY1XWLtCVJAx/n2lp8d/mRYc8OJT19KGrTaU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765473368; c=relaxed/simple; bh=qEDk8mMFP/XEe464QAjK/gPzKwVOi+IAVX6mgf9QBHw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=dPw8N9tOEnHePcXYkFXxzKol83bnHYJjDboORh8uHGPj3GkTfnbThvNL6boY8/B+HsiisGJEjb7mVc6hIA+vKnJxcaTkVLUpjgdmjkwmr7UThhq8P/Qjd/Sb5stvEadlamGeg6jn3jSxRs3H0pGnw3c8tVy080v75UWi4FSNEvM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=gx0uqkRT; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="gx0uqkRT" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-4779a4fc95aso1755195e9.1 for ; Thu, 11 Dec 2025 09:16:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1765473363; x=1766078163; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=UMKKApEFn5c8w14X+9lJPDLyCyjEvXThCatdwXgudow=; b=gx0uqkRT5M5tZE5eYvMmf/5CIsqzyGyhy4BW1kGKwvqcNfTAfU5LZDXkqdm98eHXBk BED55SWJ/BLUjJ0Lkzsm1wMyTDi0RUtzinbelnp++NZg4yCQ6jdMtP1Jls4Vcuq283lF 4g0yNWF1kxRTq20+HyhPSPP1cccKMFUUMJuYJuPsZzY2XI1gOJizO6urqo8+Wq5ks3fp QA7KIrj11WCLw7uPSNeMkOQsNIVz0MsxMpUu5NhIepOU1E1FJ98MVc0ztKz7EoJE9A6G qCzQ7LAG32K70INfPGClUF/nog5Bkp6oLyySwrgtuN2DCGwBH6qhO70gYghug8kDPXzg vd9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765473363; x=1766078163; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=UMKKApEFn5c8w14X+9lJPDLyCyjEvXThCatdwXgudow=; b=KH2djlEnAJBJZfSkBktBKxgQ9krsllizQ40Iu7SZQLgo9kUTxalxtIiwhr1cCRqdAL IvicukkTHT84xneSvOK7QbH6Fd6TXObz2uLtOHkcCD9nFkNFoKlMDmdzRfV2TyJZ99G5 COFVGUTQSKZBOh1oxmyauxMx1ta1LxHdijJIbXeALaoFJs9m/eQZtV017+rcuIIp3R+x czMGQc4eZyEIBcTjlW+eslOZqIpW3TnFk35D27mfXRnzkyvew6B4hopx8gJIDyiO7wYy DO6VMroxfVUbU0yByQDFZJ/u/jSmRDd6dwrzI7fm15m7yUPUsJaZw7v6p+eROSVTHWCc JriA== X-Forwarded-Encrypted: i=1; AJvYcCX+ueN/UP6Km6bPMO9O7Vga5E5HanuFOZmTKPQ18qF0AZ1jJ15V/VGODY6FkNsRdv/iqUmLpMu4OrxOL2I=@vger.kernel.org X-Gm-Message-State: AOJu0YyDtwwtZ0cG2jJBd6RjmQnmKND1YWv7vr5sImmXWz/MeVHtXNcI 4DiGU6vhY4N6Ud60XAdcYX0DE2qnlGnzC0SQ7iNUT+iDtT2UcogPcFxjOYBKHHgWZTE= X-Gm-Gg: AY/fxX4u7fb30rVb6y0N4xyACZUwI4J4j6PhDjNhPKPXrSSx3i31fymuA2l4eBeqa4Z UTZFcCzg5CUl/XeVEVFw3bVwG01mG5Ia8A/X7GpIR+ivow73h4xuZAHGWtontzSscbjHyDGG1HD gaXdqtiW/cUnkVzFu6yGgkRwUr/m0W0dSmJ3K8hOhXkfaSOptUwDJg+X1Pg+d2hC37YWFQJt8GS CJGZjlMqsVMtbXnddK5d7Y7pbT0G8Lx2Wg5oI7qvvrukpwHKqfhtdX17T4BrqAe31XqyNvvmT5J yb21Mq+1KvBb2tbS6OcIqB9uRSPAIDZdRnr38Y3VzvN4QoWOcN8KDkHP+v7cMQLDA6+MU3qEOTU ib2aEwyQ8g9XB9J2JHReH0F8hby05DhewI7G+GSkiu7MBSF1vQi2baMvH8hctzuUHpCtg6epSZh RApZo7//7xfM9noTFGNm8J82mZePvIxxD111mUGY8uG5PBXoE5lyzD46XCrYbGke0A2P3eqSbnT 6U= X-Google-Smtp-Source: AGHT+IHR5wjI76zu9sSNjB/TR53h9qMqGGV22PiW6Sdd0Ha2DeU4S6wSatCpyfSEE7httE0vZDzqrQ== X-Received: by 2002:a7b:c8c8:0:b0:477:a71c:d200 with SMTP id 5b1f17b1804b1-47a89ecc772mr21399785e9.11.1765473363525; Thu, 11 Dec 2025 09:16:03 -0800 (PST) Received: from localhost (p200300f65f006608b66517f2bd017279.dip0.t-ipconnect.de. [2003:f6:5f00:6608:b665:17f2:bd01:7279]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-47a89da4756sm47522465e9.6.2025.12.11.09.16.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Dec 2025 09:16:03 -0800 (PST) From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Jens Wiklander , Ard Biesheuvel , Maxime Coquelin , Alexandre Torgue , Sumit Garg , Ilias Apalodimas , Jan Kiszka Cc: op-tee@lists.trustedfirmware.org, linux-efi@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v1 09/17] efi: stmm: Make use of tee bus methods Date: Thu, 11 Dec 2025 18:15:03 +0100 Message-ID: <9e3d9ab0f7987f313237b51911865f0cccae8eb5.1765472125.git.u.kleine-koenig@baylibre.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1589; i=u.kleine-koenig@baylibre.com; h=from:subject:message-id; bh=qEDk8mMFP/XEe464QAjK/gPzKwVOi+IAVX6mgf9QBHw=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBpOvwrs/+p/EDhPyVo0hsuMP6NMvstZvfqWF6GI tijtgKig1OJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCaTr8KwAKCRCPgPtYfRL+ TsBoB/wNEFSwNDkrKKSZy5aBqOoPmgOHHGWeulZsknyP3eoMH8etCfP7O5OsQJHFzYBTbcaeW6u ullpwQB4VirhqNZF9P+gKDCKywT9I9jIWFaS7dkKKzEQ1YCt0H4nGxR094WM6gq4PAUWPdnjGzY LC1E95XggFZrSmDz+c4c61Ifzcg7EpDMDlkoaDDSz8D5QHMKZG/uGMMQAujC5kP8C0yREbR+diO ZGXnzGlKJr+qOIIXYrnvnZLxZJFd8X9AaDf16BFDO7erlIo8VpODXbUJkxIT3/VgPeZx3SWUTql a9O+gvtyLIm9AgLef3J5+UoIw4BpKfDQAJByZVX6gOhes9a2 X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable The tee bus got dedicated callbacks for probe and remove. Make use of these. This fixes a runtime warning about the driver needing to be converted to the bus methods. Signed-off-by: Uwe Kleine-K=C3=B6nig Reviewed-by: Sumit Garg --- drivers/firmware/efi/stmm/tee_stmm_efi.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/firmware/efi/stmm/tee_stmm_efi.c b/drivers/firmware/ef= i/stmm/tee_stmm_efi.c index 5903811858b6..7b04dd649629 100644 --- a/drivers/firmware/efi/stmm/tee_stmm_efi.c +++ b/drivers/firmware/efi/stmm/tee_stmm_efi.c @@ -520,8 +520,9 @@ static void tee_stmm_restore_efivars_generic_ops(void) efivars_generic_ops_register(); } =20 -static int tee_stmm_efi_probe(struct device *dev) +static int tee_stmm_efi_probe(struct tee_client_device *tee_dev) { + struct device *dev =3D &tee_dev->dev; struct tee_ioctl_open_session_arg sess_arg; efi_status_t ret; int rc; @@ -571,21 +572,19 @@ static int tee_stmm_efi_probe(struct device *dev) return 0; } =20 -static int tee_stmm_efi_remove(struct device *dev) +static void tee_stmm_efi_remove(struct tee_client_device *dev) { tee_stmm_restore_efivars_generic_ops(); - - return 0; } =20 MODULE_DEVICE_TABLE(tee, tee_stmm_efi_id_table); =20 static struct tee_client_driver tee_stmm_efi_driver =3D { .id_table =3D tee_stmm_efi_id_table, + .probe =3D tee_stmm_efi_probe, + .remove =3D tee_stmm_efi_remove, .driver =3D { .name =3D "tee-stmm-efi", - .probe =3D tee_stmm_efi_probe, - .remove =3D tee_stmm_efi_remove, }, }; =20 --=20 2.47.3 From nobody Sat Feb 7 13:58:47 2026 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 83DB3317708 for ; Thu, 11 Dec 2025 17:16:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765473368; cv=none; b=i2HpmBUmyyQK8WvBhXhMbgHPsDLKKzN+AS1hCnsBuWxTfgr6DdaZt6KtLEdNborW3Skk/tz0eqFoX45ADVU+UCIkotL31vJhSwSIsJYTP2x4gah8YIv+QaVDZoMbvfBcdJwfFKWDYOvfPhzShlDs5KBS7FhnpckLUcQt1XCKm0A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765473368; c=relaxed/simple; bh=XCE+dl0ldCkIhemm2S2ZeqHCREzROrXlRdPi5igiXsk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=TBlkkmaaT7GeqkX8Oy+COhQlLm0qRi+Ks2FccUz2HKCBI3ql1H0GJ73Ruqu6gqWP+A1w/9M3tqkbqUvPHqHaJfBnqEyRF7Y+0cH/0ORqqdfTGMyNmUAdjJT/PtrLXioBILBMJSt3Bhz/PSya6h5h+1xK3SCkmtktOfRWwO5Qntc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=wKJ5quxG; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="wKJ5quxG" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-42e33956e76so205540f8f.3 for ; Thu, 11 Dec 2025 09:16:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1765473365; x=1766078165; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0Jsu33z0wmycD38Ck1lob20P1g6o+zkut+jonvSWb/k=; b=wKJ5quxGtR/l9tA8vmg6AFfMefeZXVT7BXJyNbTkRzc2fsd2RKV7RzpDGK7igOUIh2 /uNLBpFfLK+wWA21BL8TYS9AkRhYnMN9PmN6aPbUeeyAbNaPb9MycteRDUFeENqFBSx9 NdnGo+iI2s0+Ya49nt5Fc00k3PAKu0NDnaVqd3pf6oNn/g9+Qy7d+RREPnptnG80aHO3 3NWsInEzfcOjiqD9J0y8CBizF0f1lIJAo1ZRXzLsMPWWPPpvx0UlHce1su/omDdvhhII 4pLfS135dmEJTlJalLXabQ6bq0RWGIU8eaUVGyXf7N9qBzemyWUBNcgKfiwtWMV2KaqT OjfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765473365; x=1766078165; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=0Jsu33z0wmycD38Ck1lob20P1g6o+zkut+jonvSWb/k=; b=U0GpDePVl8gDkBWalLNUUs2f7ZRPG6u7IXcuQ0nNDDAE3yEx6PIvP7o+qRRt4kXgIV ppvvsM6xoMk/fFsJtIWK+BRSP403Xfruslpa9Y7qxw+02XTZCm90v9KxkuE5kAMfD8Um M9KiziWPshshwkfdFfeQZifa2jCDemI4jQ6b+Tifn34aMXAGBdjpGzlfjop+Uk8Knae7 I5s0uuKV+iojMD3NijEGWKoj2HBccZdH/aYyBRYM9JoqvFRUtHoexKN1qFSOxGhb/KcT zAkhEidjCfPdvjEqHpVDKPcyTNsXsrphSihR3CrVSufaze5z/TSV62eUzuVDYDA7Ff1g CCrg== X-Forwarded-Encrypted: i=1; AJvYcCWV89xMuSoVmWaUhM7I/zjOJqCjwRXq40ZDb2bFyAOF/tWoOK4DiFxOQ9aRRLnGtgFdU6MbPp4UDxo5lIE=@vger.kernel.org X-Gm-Message-State: AOJu0YzUZM0LLqIuLsP1/I40+1Qnq9NOcI+jM8jz/5dY52WrxCA6V30Y klCLTlOKHSJS7szT8hOc4Thp1Q77bZhDlRx3zqvT3yCYIEUxBzjUYnn7FTdJcMcucbY= X-Gm-Gg: AY/fxX4qdj+hARtCZybF0N/TSGMfA3Izkr7PMB2EhISTFPXOCaHIKMiM7IJgmxsfVPg KVkPpKQT+x1Re/CzqsG+ckrzyTcx6Mua4kFmSdC+gcgBD9Bk9nst+OAY8b+nPD+o/BiwdxVYNT+ n9n60a/oN3Hii/TX6/yDXAF8KyE3M322dd/a0rAIZ11L4WrVi4gF8PF720xd1hFCgpsHrNSbtXJ 9DhP+Sq4SVHRWRpci4lv7HHgyDJWQQ2vhzyGkMoVhCE67xcnDqyFLAuQkv94Lu2NBBrSdV180Rq LQuSETePXTGEiIsJszrwuLSZ9LqBpwndHTxWW6IwroafOOnUs47mdzbL8RozikDP1YQePSjUAcF /82QQ5sW5QBNS9G+BxOCO6rX9QZPGpd6PAPHhmaVLSeD/3BARsnZ2YT/eLb9MSpGlqmZMXBq5LG Xbi6pK8y6qkrHX5FAclkK/4iUUOvrXQkXL+QQEWM/uUlRcdOzkjDjyT5Nk7U+jGVvs1dR7k0O+r /0= X-Google-Smtp-Source: AGHT+IHT/47lM8U2n9kb0yO2qNfCYTAMiiikeGIeIkkmwYtl5yfApNSyt+GvQrmmfeRCuqCiWdtNfQ== X-Received: by 2002:a05:6000:2008:b0:42b:3c8d:1932 with SMTP id ffacd0b85a97d-42fa39dff34mr7462013f8f.23.1765473364680; Thu, 11 Dec 2025 09:16:04 -0800 (PST) Received: from localhost (p200300f65f006608b66517f2bd017279.dip0.t-ipconnect.de. [2003:f6:5f00:6608:b665:17f2:bd01:7279]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-42fa8b9b20dsm6977919f8f.38.2025.12.11.09.16.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Dec 2025 09:16:04 -0800 (PST) From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Jens Wiklander , Sudeep Holla , Christophe JAILLET Cc: Cristian Marussi , Sumit Garg , op-tee@lists.trustedfirmware.org, arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v1 10/17] firmware: arm_scmi: optee: Make use of module_tee_client_driver() Date: Thu, 11 Dec 2025 18:15:04 +0100 Message-ID: <537c48e3db243b5c68c3192179a948efb3a180c7.1765472125.git.u.kleine-koenig@baylibre.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1429; i=u.kleine-koenig@baylibre.com; h=from:subject:message-id; bh=XCE+dl0ldCkIhemm2S2ZeqHCREzROrXlRdPi5igiXsk=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBpOvwtSZF4Ik75GwqQ+EWV8U0/usd0EXZO6Sryo OtegG9XU8GJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCaTr8LQAKCRCPgPtYfRL+ TkGsB/4kfZYi859BNNllj8EMK4U0tKtFDeScFfbKa+NwjGXgHVpSR89DKubfoO7V7TXzKxzZvMC v63m9WjAd7iwwwDv5xXNjj1JC1KnscMoyDrKlzKWrZiLuYJHCZrk3Sydo/8FtIfFKhL3/J5Vixg P+q+Yafa9vNA3OaLq/baAtLoPdm17/FoQA8NR4prce1EHo8UMzLvPXuyrpEGvq/WvuDVwpPraxd H88+knoEsk+vtjpVUa1O6A91PsS5YPd1QCPuwaCJ22w3g8vPvCpO+5sOP5c7Yfu4Mf9ShaalcGG QH/pUvOksk9bBlExdPdfrM98AqIk/xJKyHsRfm6/hBZGcaId X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable Reduce boilerplate by using the newly introduced module_tee_client_driver(). That takes care of assigning the driver's bus, so the explicit assigning in this driver can be dropped. Signed-off-by: Uwe Kleine-K=C3=B6nig Reviewed-by: Sudeep Holla Reviewed-by: Sumit Garg --- drivers/firmware/arm_scmi/transports/optee.c | 13 +------------ 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/drivers/firmware/arm_scmi/transports/optee.c b/drivers/firmwar= e/arm_scmi/transports/optee.c index dc0f46340153..8fdb80d3fabd 100644 --- a/drivers/firmware/arm_scmi/transports/optee.c +++ b/drivers/firmware/arm_scmi/transports/optee.c @@ -612,23 +612,12 @@ static struct tee_client_driver scmi_optee_service_dr= iver =3D { .id_table =3D scmi_optee_service_id, .driver =3D { .name =3D "scmi-optee", - .bus =3D &tee_bus_type, .probe =3D scmi_optee_service_probe, .remove =3D scmi_optee_service_remove, }, }; =20 -static int __init scmi_transport_optee_init(void) -{ - return driver_register(&scmi_optee_service_driver.driver); -} -module_init(scmi_transport_optee_init); - -static void __exit scmi_transport_optee_exit(void) -{ - driver_unregister(&scmi_optee_service_driver.driver); -} -module_exit(scmi_transport_optee_exit); +module_tee_client_driver(scmi_optee_service_driver); =20 MODULE_AUTHOR("Etienne Carriere "); MODULE_DESCRIPTION("SCMI OPTEE Transport driver"); --=20 2.47.3 From nobody Sat Feb 7 13:58:47 2026 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B6033164A0 for ; Thu, 11 Dec 2025 17:16:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765473369; cv=none; b=j96uvlqonYzDH7d8ItivfaLjVAyqZYlHk2s9eNSlHii/oN324dOEFNh9OWlmx2LV64PY0Tj2CNcwH1/+/GSBvu1N4AP+x+t/3q46RbJBDwm940Lf4zDFrnxKdiEXINyzkvS0UJzcRTKsYPiFhV2bsVxfkW00mMMH/HLMbUKA6gg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765473369; c=relaxed/simple; bh=CThuCWJi4dOQENcO7QkBfz1Ye/Pbs4UbUDXRANvmB2A=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=FlwpbQ1JXZDlKYYBBISLqGfJGCfORnPvE6rAUqGmXH8XtuZjl9c/bloge4NHZzEWiTkp2dzf/qWys6MAjnuEiYNldXHr9iM+tZv0afUr5hVKIvFVbLQ2e5paSTlvE4sgohoxvuzm28/4EaJ4pQTEmIufPKLy7W3MF2vUXZqVQ4Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=lGTTRowI; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="lGTTRowI" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-477a219dbcaso2929555e9.3 for ; Thu, 11 Dec 2025 09:16:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1765473366; x=1766078166; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=uJvuh2zJXk/iXDELpMIpnq6ZsR0QR0lcnSQ7RpEarGA=; b=lGTTRowINsFcOVe02lSNjSll2fQ855VfYEwxB0PZAzZCm9BARiiuMTwWFtsOxnOXLJ oxmLE473FunVvaebavQ7ae830a+XmlksI4UPrjGOVEaqK1Gr4BS4A1Rg+ZIfikbQceiL y/KaNKMOU/xedGN8nQB547V7fCjbU770vFOQogqspq60AHfTjEQQmkVjYYdPCl5Cn3mz wqr6zHPZPQFjJx/4FJgdqLeMLYrWC0XvSybIihkNlfJ6fbhpaEfW211c2BGOE70sR6nE Y1yIKnCxJSsk3bVuLZHRV62xd4ZpkPilK2mmNorbjQOnJZolMWpwPixRO15CaGBnpsmG +Ssw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765473366; x=1766078166; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=uJvuh2zJXk/iXDELpMIpnq6ZsR0QR0lcnSQ7RpEarGA=; b=T1BYrsXqPFqeAvBTbNRojdST+seu/3Vde/eOKSutm2KdGAxj9RwCS6VyO+cNqR/zMe D8Ph8J16BrPlQucZa9xSOp5zrWxY4QXl0ycVw244gha1twu+cUjsvzdw+lho+RJLNouw o47apxwhUcR+xgdG2Avv/SK3C9aISH+I4WLm3nB1Gj/op2p0x9lIx8Rlz/aCKrDV0z5n Pub/ZNo/H1XGA+/iWFcjr4pY+AMNyo/Ka06ELOTpfrJY6K53+MOmL/YCKnzkc5Jd+s5J R8Kk9i8wqAr6ndwsKN0+yQVn4miv9Dhd2LZyk5B0p2KyBt7Z0u+CXifNP4TjwnRHwUgd xKBQ== X-Forwarded-Encrypted: i=1; AJvYcCUCv4cZckiCocQYu7us/7TrigxFFTfBpyPEytP0kfcYF8OYzEudbTmfWT//puV8EEawEpaDlKs8LRtz4Kg=@vger.kernel.org X-Gm-Message-State: AOJu0YzpjHxYvJu7R0g86hRsiL+09X4mZPGsv8h6YIT8Z2HwIos5rqW9 1XTo8KMnYiuU4Z+/O3vRNTTuJS8fP/M0YaPn5gXh/7KqQG/Gs8rW3OTB/ulERcHxhDA= X-Gm-Gg: AY/fxX5W1janAtB6PE37QFFBDhU+Hj5x+76dA9qErF7OSTOephtIcXGh4a0IFNJcAoy fEVKK5aqOGNaBJkqJLZeuW/H6XisbM7HUwLi1M7z3iF/n76QZOAVzIKLTZauBPHUBpv89euaxuU YGHYeTaoHEHTiAS9/KRk6RUSMZ6Fo3BbdGGLOGU8RvZEwLQ+z3QD7NXtxgPPUrEL0hm+kZkm5Ug CY2aC3gyNyWHMGul0gJugJYfQkAOnp6asQPFmTQ3I9CshiVJhF7PvKndfGfl016dbxaf64UFT8Z YWGrZPs8VDYCEPYZsYllfrhjZecE7dpeh6Hbk2umTuYOupk1KBNCn1FOo9w+8mSYsM7dCyPZH14 2wpNtT6BGVJ0EDcGxfCu+tk+MRWBMYWdedeXCj+OyXbQyODJSUVh6iRyZHdXRSiloFoMmLkuwdq vmm07pAvcnpYLbSSpB7cwYvgNUQi0kRs+CKlybqkaqDxdFG9/YcjpV3PgzHMOGJpC14P7QqKglU GI= X-Google-Smtp-Source: AGHT+IEGmS+1LhS4ZsJsEwUzoNuTKqPZKX6sWYZNnchoA1D32F7TBe8hMOH8GOYwpwExY7BjQ6puZw== X-Received: by 2002:a05:600c:470a:b0:477:c478:46d7 with SMTP id 5b1f17b1804b1-47a8384bb93mr65103155e9.22.1765473365857; Thu, 11 Dec 2025 09:16:05 -0800 (PST) Received: from localhost (p200300f65f006608b66517f2bd017279.dip0.t-ipconnect.de. [2003:f6:5f00:6608:b665:17f2:bd01:7279]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-47a89ed6813sm18027445e9.6.2025.12.11.09.16.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Dec 2025 09:16:05 -0800 (PST) From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Jens Wiklander , Sudeep Holla , Christophe JAILLET Cc: Cristian Marussi , Sumit Garg , op-tee@lists.trustedfirmware.org, arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v1 11/17] firmware: arm_scmi: Make use of tee bus methods Date: Thu, 11 Dec 2025 18:15:05 +0100 Message-ID: <46dae3cada663b3a5ae1989881d9e74ef40acce5.1765472125.git.u.kleine-koenig@baylibre.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=2489; i=u.kleine-koenig@baylibre.com; h=from:subject:message-id; bh=CThuCWJi4dOQENcO7QkBfz1Ye/Pbs4UbUDXRANvmB2A=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBpOvww5Fdhu+aWz2MP7psFnJDaCqSIMI0L6LHTN epd1RJ6lh6JATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCaTr8MAAKCRCPgPtYfRL+ TmkNB/0YKwt4sdh/V0tvwCmGZWV8z4k4PtU5uKfNbIzaUiD6HqBwjSazrEryMHtANr/UGgSXKIY g6wAfPHQ7BBgbU8Vh2aGoY76LpexA4nfFlq68n8Suxao5uRi6oduzNpX8YoMvSsFQKZLFPonVdU tLx7XPSKIBhVdbMadabM2MGwZmSfYe6lCQY5zuKRxzk2CXnwk1Ip8rZMZYq7qqY15E6ysSl1y6a tLiFhXD7hUsGffmgeMlBtuHsXOKqk9k7Os37VByPrcKt1yqVayq6gSWhgzGIFo7P2NiyqakZgf6 l6t7cZBtlhYHU4BluapUDhLu26g/LOWvt+tVlchYsiKw2ESz X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable The tee bus got dedicated callbacks for probe and remove. Make use of these. This fixes a runtime warning about the driver needing to be converted to the bus methods. Note that the return value of .remove() was already ignored before, so there is no problem introduced by dropping the error returns. Signed-off-by: Uwe Kleine-K=C3=B6nig Reviewed-by: Sudeep Holla Reviewed-by: Sumit Garg --- drivers/firmware/arm_scmi/transports/optee.c | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/firmware/arm_scmi/transports/optee.c b/drivers/firmwar= e/arm_scmi/transports/optee.c index 8fdb80d3fabd..07ae18d5279d 100644 --- a/drivers/firmware/arm_scmi/transports/optee.c +++ b/drivers/firmware/arm_scmi/transports/optee.c @@ -529,8 +529,9 @@ static const struct of_device_id scmi_of_match[] =3D { DEFINE_SCMI_TRANSPORT_DRIVER(scmi_optee, scmi_optee_driver, scmi_optee_des= c, scmi_of_match, core); =20 -static int scmi_optee_service_probe(struct device *dev) +static int scmi_optee_service_probe(struct tee_client_device *scmi_pta) { + struct device *dev =3D &scmi_pta->dev; struct scmi_optee_agent *agent; struct tee_context *tee_ctx; int ret; @@ -578,24 +579,22 @@ static int scmi_optee_service_probe(struct device *de= v) return ret; } =20 -static int scmi_optee_service_remove(struct device *dev) +static void scmi_optee_service_remove(struct tee_client_device *scmi_pta) { struct scmi_optee_agent *agent =3D scmi_optee_private; =20 if (!scmi_optee_private) - return -EINVAL; + return; =20 platform_driver_unregister(&scmi_optee_driver); =20 if (!list_empty(&scmi_optee_private->channel_list)) - return -EBUSY; + return; =20 /* Ensure cleared reference is visible before resources are released */ smp_store_mb(scmi_optee_private, NULL); =20 tee_client_close_context(agent->tee_ctx); - - return 0; } =20 static const struct tee_client_device_id scmi_optee_service_id[] =3D { @@ -609,11 +608,11 @@ static const struct tee_client_device_id scmi_optee_s= ervice_id[] =3D { MODULE_DEVICE_TABLE(tee, scmi_optee_service_id); =20 static struct tee_client_driver scmi_optee_service_driver =3D { - .id_table =3D scmi_optee_service_id, - .driver =3D { + .probe =3D scmi_optee_service_probe, + .remove =3D scmi_optee_service_remove, + .id_table =3D scmi_optee_service_id, + .driver =3D { .name =3D "scmi-optee", - .probe =3D scmi_optee_service_probe, - .remove =3D scmi_optee_service_remove, }, }; =20 --=20 2.47.3 From nobody Sat Feb 7 13:58:47 2026 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 888713164C1 for ; Thu, 11 Dec 2025 17:16:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765473370; cv=none; b=eux5yTkuW2y0BYfDCDWjE1gYHMXt0lbiFuQrpkKyqvqFV7Jzb4SnaL01GMKixuULJzGLa3ZXL5M6jAh+A2Txj7zfZGZjznZb05brdSJDkEKBItwS+LcH6zoPvDtDCbRBvM//tfdmbmrPPh4qnynPQplj1DH2PgkXvuQEOOy7k70= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765473370; c=relaxed/simple; bh=u+iIVeAYKLIIY8APv+qwbM4v5dD7Dwi5f/EPantu/m8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=k+KrWC9BdcWnwWUyiTq1BseHAXnighbGJ4DhQ1OqeY8QhNO3dYY0BkAsCx9t4TezotM6WXgzP1lrFltRcQNyEjWJX5dRFMBo0zBWR9wAyV/tSctVBZJBwMND2C0g+4Dk0qbeZNMwApTU7E1k+PPgyJDMfaajEHQCGF5hN6wdT7I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=lSu/qdQp; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="lSu/qdQp" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-4779ce2a624so4338205e9.2 for ; Thu, 11 Dec 2025 09:16:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1765473367; x=1766078167; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=diZjdouzEEhILOHSiCyNRKR9P2lTi1L2KPZWsItgxqs=; b=lSu/qdQpWZsfSa6uNvVqgshjoix4KLW8sDq6IJ6SPVA64qeA/pQvivR4agi8pua8yb wnW4evN0uCkz7VqEg07eb5Ay6VJvdGJMCZjr/EShYIjgHF3E7lmAmEQRzCczG3Jg2TWy km73bkQk2Tt6F8EbYdgpt9CgRM790kLTFZN9OvI68t8gQPNN4HcXEqc+O2Yia2d0w2+c glkLlMtaMhLaJheI2RPKDiVitzUeI1+vKJ269gaICs3AlMxPc+64Vrnd+p8Gl4azn5hb Y9oGhU/9M1/AhGAFGOJvVC0qVDo2MQjKBiDjWvyj+mLuRyXu7y0L15nitMLZ3jHvkgDu x/eQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765473367; x=1766078167; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=diZjdouzEEhILOHSiCyNRKR9P2lTi1L2KPZWsItgxqs=; b=nypflTpWjt3pRVY5YJOSYUXaZOQRn/cQwHcNYNP5G37XvSlOGi8KtyrcAq19c2W4zP gu5KREkiy6DlWJnEHwOvss9/nlor3vI1g40wxawBzq83hkSaambQjT0t35dTxOmvb7eo LE/fI0lRW+AL9P7S19639XhxDmgtCBtkcxToVtVgiaty+x+MIc1nPPSSag8k1Yzcfulz 7P07ddkGGWAhkpib2QHw2RLtvep3Fl5Yq6DtVyfO24v8cNW4WcTiZ1zfGAR8LZWyb1OJ C5+Rm6ZphnMsPcNULExMl7ccYYN1znuRseoK7is3yC2KSXlSTXzzjjlOL459MlmUoyxu nMiw== X-Forwarded-Encrypted: i=1; AJvYcCXdxlPXpJ75sUwHXAwPtcAOGax95Suk5vRGhoNuuWJGPGDCWPuNTZh+lePMA5+COQjUttlsxyp/b1xrnCY=@vger.kernel.org X-Gm-Message-State: AOJu0YzDv7a9VNmkTkVrcGpGT+lwwM8lUQLUfAghzNQ5ROCHaqOlXJfn BP3wslW9ZE6pv6+JwI7Ge1fqOpDL+UT3tbX8tGQVePQajgrliBzSC9RXCLfI7ju+wfM= X-Gm-Gg: AY/fxX55pZ3Cx1hkJSYd2KYVBaaPkmgSCahN4WfL/h3lMDIDGbNKloisHT9msge6lPD nhg8TK5VoW9r5nGMhOWu9b8gfE+SoPaCtb9pkai+c5QaBwKwAazfniI1F+TQy8yOb5mymfasMem ijNt5ZNi0EAWnXpSpw0TQja72IqX5JB69GPJFXyI7jeuVyJeJY9glZzSIhGD3njKh7XIV4zq5HB eaxLVSbc2b23SgarDHw0GgD2OKZqKvm+rJ8CtBWwCIRX/PyqTWqH80UUZYYcQPeG7vrf5BI2L2p P6hm5vNuMwJBbMcOdTXXiGQQzYX3WRS1/yuImgbI8+Y7wW5EpWTGbLE8Nz3VYa3XAEXu+nGG6qu d3RxR1TrB6ONFCUgBn19NEXk7fw/vxbQnla6Kn6VRiEEXlh9u1KlW2xMdbrTJq+0s2/qeyd0uYN vIed+rINdIneRQvGN/IMSClD4KxqWKx4nq8o5g6fQJtBPLZTdJw4PB5geDRcZpKFfCCXRjWWfeQ oA= X-Google-Smtp-Source: AGHT+IGUKWVSCHYwBEoDyb8aKAI3xda4j5uLNgFsDdq/ww+IXbbby6vKzmjBu3oTuW9ZdKJm7c1h5Q== X-Received: by 2002:a05:600c:548f:b0:477:b0b9:3131 with SMTP id 5b1f17b1804b1-47a83745633mr73090605e9.8.1765473367020; Thu, 11 Dec 2025 09:16:07 -0800 (PST) Received: from localhost (p200300f65f006608b66517f2bd017279.dip0.t-ipconnect.de. [2003:f6:5f00:6608:b665:17f2:bd01:7279]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-47a89d8e680sm16759715e9.6.2025.12.11.09.16.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Dec 2025 09:16:06 -0800 (PST) From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Jens Wiklander , Michael Chan , Pavan Chebbi , =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= Cc: Sumit Garg , op-tee@lists.trustedfirmware.org, netdev@vger.kernel.org, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v1 12/17] firmware: tee_bnxt: Make use of module_tee_client_driver() Date: Thu, 11 Dec 2025 18:15:06 +0100 Message-ID: <5b520fd96f8b385acc280226f548913c9ee98011.1765472125.git.u.kleine-koenig@baylibre.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1383; i=u.kleine-koenig@baylibre.com; h=from:subject:message-id; bh=u+iIVeAYKLIIY8APv+qwbM4v5dD7Dwi5f/EPantu/m8=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBpOvwzZJpnWSisd7DkoPNb7IKu3CNNzmY0kgG26 G88eoSnRsqJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCaTr8MwAKCRCPgPtYfRL+ Tgg/CACLTMdXNNR7oub78YhSrxPLhhHLys5JO5AfQdc7fc3upwrr/QfvoJ9HBdditXtvbVcJ/oY g/aKUVLH+ObNA20u8STng/Jqr6WmHu3+GJrzaYryu3q8tTvwVJlR7W4K3bCvLeoJlGWghCd0XUd FP0J12bY4/zvrbxOdPrNLXyt+33F/T7KeaRzpGa/tG++NAAEJ9uIRD8FtHdDD93eua0b0/k3H5M oqYEsIJgtT+71HZ99ufbhcjvi/oJ7BIiTodO2UafKakUtFAHlILcJl/OmOUiWWSqY/GlzMbBL8t gI1at+MmI2xPdyew1CWuPWaSSZyKwMElpp8S1sao/LcW0gHv X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable Reduce boilerplate by using the newly introduced module_tee_client_driver(). That takes care of assigning the driver's bus, so the explicit assigning in this driver can be dropped. Signed-off-by: Uwe Kleine-K=C3=B6nig Reviewed-by: Sumit Garg --- drivers/firmware/broadcom/tee_bnxt_fw.c | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/drivers/firmware/broadcom/tee_bnxt_fw.c b/drivers/firmware/bro= adcom/tee_bnxt_fw.c index 40e3183a3d11..fbdf1aa97c82 100644 --- a/drivers/firmware/broadcom/tee_bnxt_fw.c +++ b/drivers/firmware/broadcom/tee_bnxt_fw.c @@ -261,25 +261,13 @@ static struct tee_client_driver tee_bnxt_fw_driver = =3D { .id_table =3D tee_bnxt_fw_id_table, .driver =3D { .name =3D KBUILD_MODNAME, - .bus =3D &tee_bus_type, .probe =3D tee_bnxt_fw_probe, .remove =3D tee_bnxt_fw_remove, .shutdown =3D tee_bnxt_fw_shutdown, }, }; =20 -static int __init tee_bnxt_fw_mod_init(void) -{ - return driver_register(&tee_bnxt_fw_driver.driver); -} - -static void __exit tee_bnxt_fw_mod_exit(void) -{ - driver_unregister(&tee_bnxt_fw_driver.driver); -} - -module_init(tee_bnxt_fw_mod_init); -module_exit(tee_bnxt_fw_mod_exit); +module_tee_client_driver(tee_bnxt_fw_driver); =20 MODULE_AUTHOR("Vikas Gupta "); MODULE_DESCRIPTION("Broadcom bnxt firmware manager"); --=20 2.47.3 From nobody Sat Feb 7 13:58:47 2026 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C21CC3191D8 for ; Thu, 11 Dec 2025 17:16:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765473372; cv=none; b=RWZk1jvSrDzSI0F0hSVdfeqs5PfreIk5I9P1lu4e9e5XD5F/diDUrGwdm+N8RDSuwgealieg4hcwQENEJlWhvbcZeAg3X57HYOGr6GaaWIUxYgvwOXQETuHuY8YHGRWZXL2xV5Tac+Xqm1sxuWhfk44tVncXHZgCb6Tu2ataUEo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765473372; c=relaxed/simple; bh=/zcdGCyO/zJVJHXiHKgniHKKW+1n+is3abvzUXVsx+4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=t4fkNY0KdsY/CDB5sk8Y1D1sRjuHBuQBkQLKBlxZA/eTzmIojRF8mONUoQHXTf5cbB4ou2BUjuIckpBV40wSfShKOShXbaWHGZEhRozA0McOjdR5hU63cX30dDtI5SOD4BXqJOlSCpmYz9ZXdPRika6e9dRMGW/1v0jMavahUcI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=mAfvNkP7; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="mAfvNkP7" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-477aa218f20so2918745e9.0 for ; Thu, 11 Dec 2025 09:16:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1765473368; x=1766078168; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=s5Ml4HJmxurjzbFHuGXuWnrdRmEuv/7EaCb1T3xZqb4=; b=mAfvNkP7P43IGyFu4r7QhTMUtmSve4AMsKLN8i1Rx1goClXjJybGIMLREy0l+Bsmmy xko+FllmPzopY0siygA3OVo5PZP1/6zHREVqsPCARbKEIYU9YGiRXhpsb28JDZmPqoZZ vUapsgUM7ORbofmr8L0YxWGcy+Ku+cpaHdzyshzJrAVdcbi53pBKTGNqZqk7wU6rvzXf IAU/KaJz+mbGdpxxudcZPTdg6lzEO3eTu+YHLrWx7bg7IE2giJpalscR58NYXBYXgDF2 bAtIFJXNcoZcOO4UPrtzzlqNJ7FQHbUGKhCd7lWOwTR7mC2AaQ12yRjGFXPj1t/1QYU3 tW6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765473368; x=1766078168; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=s5Ml4HJmxurjzbFHuGXuWnrdRmEuv/7EaCb1T3xZqb4=; b=ltkCzWnXrHhw/B8hHekMrGpUUvQlEgRKrDiapnH5YE4pLDH+i7t0+BgoZZdbs3l6fU k1HP55Zx8KF1B98nFVnLnb3HJZLx/DFG1KK01k3fEA1ycCfN0aGKBKhLn2uh1OGw0drl NSJZ/c+FqJ+CopxLr7t9jvhT2k0S8djAfFOomBQUuX17VM4qBIH4+jrZ+/3alFuKBBjy iPku668Bwu+XKb/a/o5gZl5kXNWSzrWgNb+3+F9dmOXtW0I58DLtJXCSM8KOT3BxoVn4 BfkFE/70fWekfsN6hNflcc2/IM4XC6Nnlajwr1g2jzUIru2ZbjU3vXhO+eNaEg9aeBat bpSA== X-Forwarded-Encrypted: i=1; AJvYcCXcrR54LqL+aH9HTgtWfW+vuj3aJODAwysX1zXL1+5rikFKilEvWLrRvneuL5GfvCuHiBeT22w/j3fO0pk=@vger.kernel.org X-Gm-Message-State: AOJu0YwpDTPfMZamvWWfeERm9WDZ0wPlZcM7m2l2ok2OxqWVrja5EXoV Uol0+ONTMmNAdMGwk4CNUEPlYz0G5XF7PpYjbU8kkmUdyPhorKcjAku0VIuJ4Tvn/2c= X-Gm-Gg: AY/fxX44yVwrCZ86PkdyrmUuYZrt84nYarQUE9kcPRcHy1Ye3hSPRiqzFlN6DxwJqfY a5lz06zt2Ne7acCbYVjubxygR9kjDCr6VnQSQdCBMv1avF02Vtpkwd1ho5PrRaeFoRlYeBlO0AL 5izxUsU8kN/Omq2KPkx8ut1AjEe6Z4XEfvSmuCgMBgjQoBZnlkDmp69H8jZpMw7VmClAHiI4M2I daL4CDP2E29UAdIGNRHXb915HS1ODX9SsCE3BQA5cYzUWT48cQTIOCedre8l4vqpuqdTVMAie+g QPfcGsW7hm82M9L55uY14I8wBFLRm6KuUJg2xFQByiUMcySZIzLOsFgOZyMzZiyMcJlcPZuL0/n nIk7ySFA80tV3hvEeVSPSIvS3H17BLT8dZj0nXMcvIUF7AN+mBntaUGOWj3UTLubyDTt99uYy6i Nru5SCnGADudm/MFRyP2H7rlkKOUFNFNTsujZDewSWZrsYnQI/FNyzCdJ2ot84K9qf56SudSoMi rU= X-Google-Smtp-Source: AGHT+IE0Pak8/lbklEkRDCW8Y7zvjMkJReE6ZBMN8ZhmPk/MHipynV8W1+LPXu/33++KhGMjio+QMA== X-Received: by 2002:a05:600c:4e49:b0:477:7c7d:d9b7 with SMTP id 5b1f17b1804b1-47a837a27d0mr82898065e9.33.1765473368108; Thu, 11 Dec 2025 09:16:08 -0800 (PST) Received: from localhost (p200300f65f006608b66517f2bd017279.dip0.t-ipconnect.de. [2003:f6:5f00:6608:b665:17f2:bd01:7279]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-47a89f1e947sm52522015e9.3.2025.12.11.09.16.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Dec 2025 09:16:07 -0800 (PST) From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Jens Wiklander , Michael Chan , Pavan Chebbi , =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= Cc: Sumit Garg , op-tee@lists.trustedfirmware.org, netdev@vger.kernel.org, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v1 13/17] firmware: tee_bnxt: Make use of tee bus methods Date: Thu, 11 Dec 2025 18:15:07 +0100 Message-ID: X-Mailer: git-send-email 2.47.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=2259; i=u.kleine-koenig@baylibre.com; h=from:subject:message-id; bh=/zcdGCyO/zJVJHXiHKgniHKKW+1n+is3abvzUXVsx+4=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBpOvw1dE1CQuBYvGVTWVxDbTjDXphCrVIig97hx yKXj9t/eKmJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCaTr8NQAKCRCPgPtYfRL+ TheQB/4y6MUCe6HoDloGZNlxErv3xbN/7CcKgAqBSZLsIY2AnM58rwFoeQpZtwcQFoh5vJPSjgf JBd0iBFOoJIXWK17LWD7nmG917NzAWX+Wu/btEbP3SY6iMZUDMVV4bJetR0Jc6BsXVSSDctjtvK Wttn4wjRwmSXr37rfytMHye+tBx1MRouulCVZmRT/nlyVKM5exWD/kri89uXya5zgLcg5nCOtv1 YLdPhUPsb+e4eMZCwwGm2Fs9BsRAHgMzTEkvtTFdkMrYQVEW56gsHqQVr1JTTMZIqzxahoq4XxO y42vX36v0uM2lxdFmFJgCeRVpXKcZvCeC4wvz6BzZgdB5Mh7 X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable The tee bus got dedicated callbacks for probe and remove. Make use of these. This fixes a runtime warning about the driver needing to be converted to the bus methods. Signed-off-by: Uwe Kleine-K=C3=B6nig Reviewed-by: Sumit Garg --- drivers/firmware/broadcom/tee_bnxt_fw.c | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/drivers/firmware/broadcom/tee_bnxt_fw.c b/drivers/firmware/bro= adcom/tee_bnxt_fw.c index fbdf1aa97c82..a706c84eb2b6 100644 --- a/drivers/firmware/broadcom/tee_bnxt_fw.c +++ b/drivers/firmware/broadcom/tee_bnxt_fw.c @@ -181,9 +181,9 @@ static int optee_ctx_match(struct tee_ioctl_version_dat= a *ver, const void *data) return (ver->impl_id =3D=3D TEE_IMPL_ID_OPTEE); } =20 -static int tee_bnxt_fw_probe(struct device *dev) +static int tee_bnxt_fw_probe(struct tee_client_device *bnxt_device) { - struct tee_client_device *bnxt_device =3D to_tee_client_device(dev); + struct device *dev =3D &bnxt_device->dev; int ret, err =3D -ENODEV; struct tee_ioctl_open_session_arg sess_arg; struct tee_shm *fw_shm_pool; @@ -231,17 +231,15 @@ static int tee_bnxt_fw_probe(struct device *dev) return err; } =20 -static int tee_bnxt_fw_remove(struct device *dev) +static void tee_bnxt_fw_remove(struct tee_client_device *bnxt_device) { tee_shm_free(pvt_data.fw_shm_pool); tee_client_close_session(pvt_data.ctx, pvt_data.session_id); tee_client_close_context(pvt_data.ctx); pvt_data.ctx =3D NULL; - - return 0; } =20 -static void tee_bnxt_fw_shutdown(struct device *dev) +static void tee_bnxt_fw_shutdown(struct tee_client_device *bnxt_device) { tee_shm_free(pvt_data.fw_shm_pool); tee_client_close_session(pvt_data.ctx, pvt_data.session_id); @@ -258,12 +256,12 @@ static const struct tee_client_device_id tee_bnxt_fw_= id_table[] =3D { MODULE_DEVICE_TABLE(tee, tee_bnxt_fw_id_table); =20 static struct tee_client_driver tee_bnxt_fw_driver =3D { + .probe =3D tee_bnxt_fw_probe, + .remove =3D tee_bnxt_fw_remove, + .shutdown =3D tee_bnxt_fw_shutdown, .id_table =3D tee_bnxt_fw_id_table, .driver =3D { .name =3D KBUILD_MODNAME, - .probe =3D tee_bnxt_fw_probe, - .remove =3D tee_bnxt_fw_remove, - .shutdown =3D tee_bnxt_fw_shutdown, }, }; =20 --=20 2.47.3 From nobody Sat Feb 7 13:58:47 2026 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E1DB83168E2 for ; Thu, 11 Dec 2025 17:16:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765473374; cv=none; b=qeriDGx+shGxISOn91JuHn3tBrpyuVacEd/v1TNWUv0I5lEmdEnWUXUDB6XbpTdMrmepSH0Mj9s1lIp85NOuMv6WYo3FqbjkBWHd1N/Rnsd5ktFkrEVGWLXs3972xzBFiNyC2gnRRRqgDQapw2jJLd7Fr2jZDPqmLnLkCPBXK14= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765473374; c=relaxed/simple; bh=PWG1Uz/7pwDZMqUJE8wpnS6Sgs1oh93ryPafYte5lCg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=tBk8Cnn49ttVWUX6Macs5YujsUfR/w5mIA4GZKyn8iO+k0VqC70ZsU90tbXnNQLnU+89A8bjF3ncI0PwsRnoC34w+10iiCVPIyc5G11TewlaFkYNE1gUI9fdM01dOI5LvD+NezhR0LO/oAonJRm4ebhveTzvU8GWpUHX7u065GU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=evrcycxE; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="evrcycxE" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-47118259fd8so4287805e9.3 for ; Thu, 11 Dec 2025 09:16:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1765473369; x=1766078169; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8tX/pvRZ03DwrZb4C0GHe6B+z8lS6Bu0suU9z+WmGCw=; b=evrcycxEyxXWRxHBsgB/8CiWvdgVxTbkzR+AbIVAwgMBS0rklVbuYbV1jcrqjeR02j W9y5+yAgrKU67wc/TGQ0Tfm7U7bU5oW0sp+drCXaSO+YYajSSdjc6iA9zRFIPFUzTQFa egeHeXGe6df6Jve0kbp+0ZJyIli+mEQWmHg+nqNfwxdo1fILDnGRWUXti+E2eZvmJ/18 GMHLT5xdjpR78Bod/OaH45wrMu9/QV240SEc/dmm2TVG6FUkhMmplCKWAsRdshlS9ocE zt4rElplny/M6NUCUSVOaQDQ01WfY56kFq31mzrV7AKJSGipGN0Ugli3MbxPWSUSDESW NpJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765473369; x=1766078169; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=8tX/pvRZ03DwrZb4C0GHe6B+z8lS6Bu0suU9z+WmGCw=; b=FlpVygX45Uficxs7Lhp0krkRrbhdw95aL9HzilHoTNYWhChmWGyQAENrNwbv2INN20 BRgDdrC7BZ1zwhzbI7dLi2kq1+voqlxox7bpqywOcKZdgEyCMJdCNyHbXr+alHmZ8fVs 51GEsFIWk06l6kZI6vGxb9ahod3j7U9nNh3NaRGFogTh+1N4zx7jSrXkA19oSk47LVO4 MOTZOIb7PzMqC1n44AU6Lk5xTWpWDcZnFByF16E7JVwIeBNCXsqbk6km2UVfKhCneUp4 /1ScD7vc0/PvreAP32O7sN+JwI10h3ZEwiqnC95+oWQH1Ea4w7BBwGy/pe7jSRvH4txS lI2w== X-Forwarded-Encrypted: i=1; AJvYcCUhAhTV1hbo+yTFJS/7QUkDNpNdWiTSKjw2jkySdA5eAMPO8B8Sg9PspvOLCOZWxQhY/EHZN3qTW4Jv874=@vger.kernel.org X-Gm-Message-State: AOJu0YyYRf65BcvE5JQXd1cQ5r4ALK11J2WURNbXGaISTxjdhgMStiHj geRbbhfXXP4SQnisz0XNI4S1xg9FEwzUn7uqpJhNSHIOGsg5+G+ypx0xFLF4YRefqvU= X-Gm-Gg: AY/fxX4//6BBlw1wUhZAV3XY1NhOVolPOo+VW3Sa2lalWsHVsrFb0T4Z1BkA5zpniRu 5+nLXMBUT6iNJqmtAkw/SETObEjijzXsnaED00hHt+OpsPrv3LzCvH7sixgXCzTyJJ6WSFVJG8C lYpQvYAjP9Q6zkLjZ1T4UflKLYoqCC6or0e4jNTGg0HNSuKhcMmqlLXwxpWBg9zc+Ze3pZbZVBg S3TCfk082beNEUeikegAmGlTZpLxOzb+OkkAJN71lZLmP77JSOiPYaqkN8njTI4oGAILvIMyr3q Bl62UfPBSmCBUASNk3MGwPFBLJG3lE8uJHY7KAD5AbtKapGbPNFQqDecxdS+/M0dbKSWAn2iBBx mj1easg5mA8RiaDIpLG88YAnqSmEkGomGWspeJWhRzTsj5XdgUSbOrRaPsKdHMJpSEGzVMytNSb ZXDIpB9mnSxBs9VHxrI6ljRTj8dNmHyn9ynhz9GK9aZ8BZhtWko95FRreqYhVBAaWRY1tZX1gAq R0= X-Google-Smtp-Source: AGHT+IHGBUOwE9r4ORaulvN3C5ZVCojqUo6qjWJCQQ7Y+7ElotvWRIvUrk2Iy3v9fIQm2AQbku9BvA== X-Received: by 2002:a05:600c:8010:b0:479:3046:6bb3 with SMTP id 5b1f17b1804b1-47a837aca24mr61787215e9.23.1765473369183; Thu, 11 Dec 2025 09:16:09 -0800 (PST) Received: from localhost (p200300f65f006608b66517f2bd017279.dip0.t-ipconnect.de. [2003:f6:5f00:6608:b665:17f2:bd01:7279]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-47a89f0e42asm44521885e9.14.2025.12.11.09.16.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Dec 2025 09:16:08 -0800 (PST) From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Jens Wiklander , Sumit Garg , James Bottomley , Jarkko Sakkinen , Mimi Zohar , David Howells , Paul Moore , James Morris , "Serge E. Hallyn" Cc: op-tee@lists.trustedfirmware.org, linux-integrity@vger.kernel.org, keyrings@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v1 14/17] KEYS: trusted: Migrate to use tee specific driver registration function Date: Thu, 11 Dec 2025 18:15:08 +0100 Message-ID: <0b3ce259fa26e59ef24a91ca070e2b08feeede82.1765472125.git.u.kleine-koenig@baylibre.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1407; i=u.kleine-koenig@baylibre.com; h=from:subject:message-id; bh=PWG1Uz/7pwDZMqUJE8wpnS6Sgs1oh93ryPafYte5lCg=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBpOvw4fJEaOX0vcpHk3eLvUdGT9H5CpTDKlptW8 lA5zTtov2yJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCaTr8OAAKCRCPgPtYfRL+ Tus6B/46H6BzlY4ooZ66vBemZu+u9k40M56CS1npEuvxZzdqVdr5+yYBtvf0sFepZiA1kZLByHC qmvwOMfVSURaQxhSnUSW3sf5PogyKEeJGChX0Aet1HFsu5I0s3KtUZq9MwTR+bcWJnQOEU7xT1w fhU1DQ87m1Qu3KgVdq1fZKtzmUPAQHqXryaG1Onoy8LTkDRF3SQYO6h278bsvtBs38kRzaOcAvz hOgLGCS5wqtWh94/e0lQHwClfg0b+BQsNClTafeNu0B+HnvcDhTyHoEGqOQk0MWRf5Pa3laE0BV XoyAv8patZJKyEfoJDbzwDswrq0Vny5P+AXykut/8qQ3Ajgq X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable The tee subsystem recently got a set of dedicated functions to register (and unregister) a tee driver. Make use of them. These care for setting the driver's bus (so the explicit assignment can be dropped) and the driver owner (which is an improvement this driver benefits from). Signed-off-by: Uwe Kleine-K=C3=B6nig Reviewed-by: Sumit Garg --- security/keys/trusted-keys/trusted_tee.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/security/keys/trusted-keys/trusted_tee.c b/security/keys/trust= ed-keys/trusted_tee.c index aa3d477de6db..3cea9a377955 100644 --- a/security/keys/trusted-keys/trusted_tee.c +++ b/security/keys/trusted-keys/trusted_tee.c @@ -264,7 +264,6 @@ static struct tee_client_driver trusted_key_driver =3D { .id_table =3D trusted_key_id_table, .driver =3D { .name =3D DRIVER_NAME, - .bus =3D &tee_bus_type, .probe =3D trusted_key_probe, .remove =3D trusted_key_remove, }, @@ -272,12 +271,12 @@ static struct tee_client_driver trusted_key_driver = =3D { =20 static int trusted_tee_init(void) { - return driver_register(&trusted_key_driver.driver); + return tee_client_driver_register(&trusted_key_driver); } =20 static void trusted_tee_exit(void) { - driver_unregister(&trusted_key_driver.driver); + tee_client_driver_unregister(&trusted_key_driver); } =20 struct trusted_key_ops trusted_key_tee_ops =3D { --=20 2.47.3 From nobody Sat Feb 7 13:58:47 2026 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 542C6319848 for ; Thu, 11 Dec 2025 17:16:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765473374; cv=none; b=R2LXDyYqfiZqAl77It+uBVENbNcl7F65ow22lUj7B4f5yDe5PYHEmC7Q/Gd8HQUGS7+bKKPhU6jlQFFkRUtgmRDG4e8tMF/OTA8gzJjbw0LWKieJODcykqetH4xoybP42uMxJLpLtcOpPGUreie4RTAbw2c3oy/bMgraWee3S40= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765473374; c=relaxed/simple; bh=CzasmjigxMDc3RbPNhKzZOfqJrGSXpxinQ87lLaAs6M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=YH1p3sdC48TNMoE7//D06FFQknV44ErsXFXtMs9N52HN8WUiHq0EGbSOZhgh2Uc16GXd4tpyunb7poQCFtvMMXB4CVauj/cpppYtRRDChfZgQtRQIn6Nu31g/eKpGZcytdFF+d8Y4ZlSJbVcIqVweCrX8JcYXpYtRd7Fj2qwiOs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=IgjWqMd9; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="IgjWqMd9" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-42e2ba54a6fso146362f8f.3 for ; Thu, 11 Dec 2025 09:16:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1765473370; x=1766078170; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=n+SHfa6vAHr55xEpYtx8saNp/3XbgtX4zTiJHIYfZ1k=; b=IgjWqMd9j04SJLnMtl+zQippp7RKIYHp0avf98okpcRZctk9dwkIOVIm/h4F6e9gNG R16rEHDttSX2nlOUb3axfIPs4SuLcNY4LqlwuLMAfkpjnkgJKDR24Lna63MRVnVgDSSC jf7dnvXuHKEVjgw9LKWcfMglWf4gAWzWNNPKaDPXx+Y5/0Mr9F4At1yrO9Bbd1Y2nWTg jarUF9Kxpy/Tys7m/Ep46iyTD2tiErOlkA+vhf1Z1vlU/EtGTY8GHzudzxKNpqxIo6wC /v/R6T0N866RML9olQDqs+ehSlADhbM2VBcSDbTYQmkpmi9a7I1MlpwP6bSwLLS5N/CO RNJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765473370; x=1766078170; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=n+SHfa6vAHr55xEpYtx8saNp/3XbgtX4zTiJHIYfZ1k=; b=cWG5cWVtsFNpKOLxwXdm3iKxb9ii/eAPKqm7u0rSw3C4bO3EBQO5hZwfmsvCXm6WI3 EXeP0NJyc0r558UNVw8QqLcULaroliQKxfHWEkvNKsQDjS4CEUvw7pdq97l74IQ92OEO 2zWPN5ZZheWnBCxxxtDiueUdVedpv4JPUntz+lU0+00/xDZDW9LkeP7iPma8gy4Lcq/q TJb+Jhn8ZvrQ6bR+A4mJqOECgY149g0P0FajB/OqmkBjR6Au9rYR1E0EYIoXW5/KdBGR LwpBUKPhQIC7LKQkcBgOQcX4tGK+4gR1nA9Dz5OaKHGS/MU5eGPqE3AcExIcKov2uSL+ Vs+Q== X-Forwarded-Encrypted: i=1; AJvYcCX60H0NYaSjCXfcliXQTMMrlrYbaDnQzqR4VKqoesBw4MSZynTME/eAnRCPHovdcFsbfHpw8dOvwM+9C44=@vger.kernel.org X-Gm-Message-State: AOJu0YzdyFwB+rc2F2jXI9mu41Pkj4gu90ByS8k1kNtU9RcESQQsrml8 HmE+y6pSSstYRw0cfousrTsGuw6Z13C3nnXQTBo8GRFt7Qa5tCg1mLu5AOum8yF8LEc= X-Gm-Gg: AY/fxX4SsOXpTFGjyTJ7r4kGpXjbZzfQi747bwiPg6QUyPH1rQCLajEjlb3KDdiR/Bc mx1f3zeVQNggYTJ1cJriOb/OXB2iO3a3zhsutlYcrOVc3PTjogq3WYzKJo9YW52ilV9XZL8mFsG BYEjKN9b2B6qlx+GINzQFYiAMaTiso3SuRgJlgKxaQmCP9/Ju/cxwrqq8u8oq4rRriEJpMXJ6Qh fe5QGkHDTccfmc/l09Fb0iTpCn1s3YbjVnQulbBQYfc9vtHxhzRDaqNB13zy/2TdbNsvmH1EkGE 00I7SA5fbwex/a650qKa3vAcj7vx56Y0TE01rE7cIYgdxd5ghBESQkmQAXNBGSSBLzMOp3QIWQN OcO+qkreHnPvwlbkcyuhN7acNys8O1LjAD+HnyXS6rJL9egU9rGXlElrWWQejBXR0h8/mnAKeG9 pxmigqYeDYAiSIECzDxWviZEjoGBGB7/nmpIqa2+QPucZSYI8iyeFan08ZmiU52i2A/qrjD994i Kk= X-Google-Smtp-Source: AGHT+IEVlfLgsF/P2fkju8/EGLrakjagEMlQtCpgWX8RHB5vEnT2Q9O+No1JYvdMM/sRnem0fYfvQQ== X-Received: by 2002:a05:6000:2012:b0:42b:3978:158e with SMTP id ffacd0b85a97d-42fa3af895fmr6416347f8f.30.1765473370344; Thu, 11 Dec 2025 09:16:10 -0800 (PST) Received: from localhost (p200300f65f006608b66517f2bd017279.dip0.t-ipconnect.de. [2003:f6:5f00:6608:b665:17f2:bd01:7279]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-42fa8b8a973sm7064875f8f.36.2025.12.11.09.16.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Dec 2025 09:16:09 -0800 (PST) From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Jens Wiklander , Sumit Garg , James Bottomley , Jarkko Sakkinen , Mimi Zohar , David Howells , Paul Moore , James Morris , "Serge E. Hallyn" Cc: op-tee@lists.trustedfirmware.org, linux-integrity@vger.kernel.org, keyrings@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v1 15/17] KEYS: trusted: Make use of tee bus methods Date: Thu, 11 Dec 2025 18:15:09 +0100 Message-ID: X-Mailer: git-send-email 2.47.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1908; i=u.kleine-koenig@baylibre.com; h=from:subject:message-id; bh=CzasmjigxMDc3RbPNhKzZOfqJrGSXpxinQ87lLaAs6M=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBpOvw6brlrzvg29fcU3xprVy3jDUvD6QI895K+A 4P0ITtETEGJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCaTr8OgAKCRCPgPtYfRL+ ToAKCACHrdHSasYStywLZJGRNAkC64NWvFb/BwKzZCoF8C+nTT45O0JbfN5t/ZZlz3WQUTo5Kj7 m5QHbprAIkb7KlG6c9wMZpIvnIBvKwpE7j+PUzZ2X2+UD2nnn20123zaagJYaJHriTJetqmRK/g fl4EgbD/AzpOofrYMbezG60UvGRmRCPd4NvhNQ6GXkzjyAH5oICnrjI/ufaG65GzQSejD8nT5qK UIdLIccaehc7imlrk0QNv17cD5+/y0ZIwdI2uAIuelzdvUdNHWDYI1/zMNQ3t+FkqM+vgaElDdx 8Ft+pQXoK9ErCp8MIxolmLzr+4840mvUoLiV3YhnVRyUrSkT X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable The tee bus got dedicated callbacks for probe and remove. Make use of these. This fixes a runtime warning about the driver needing to be converted to the bus methods. Signed-off-by: Uwe Kleine-K=C3=B6nig Reviewed-by: Sumit Garg --- security/keys/trusted-keys/trusted_tee.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/security/keys/trusted-keys/trusted_tee.c b/security/keys/trust= ed-keys/trusted_tee.c index 3cea9a377955..6e465c8bef5e 100644 --- a/security/keys/trusted-keys/trusted_tee.c +++ b/security/keys/trusted-keys/trusted_tee.c @@ -202,9 +202,9 @@ static int optee_ctx_match(struct tee_ioctl_version_dat= a *ver, const void *data) return 0; } =20 -static int trusted_key_probe(struct device *dev) +static int trusted_key_probe(struct tee_client_device *rng_device) { - struct tee_client_device *rng_device =3D to_tee_client_device(dev); + struct device *dev =3D &rng_device->dev; int ret; struct tee_ioctl_open_session_arg sess_arg; =20 @@ -244,13 +244,11 @@ static int trusted_key_probe(struct device *dev) return ret; } =20 -static int trusted_key_remove(struct device *dev) +static void trusted_key_remove(struct tee_client_device *dev) { unregister_key_type(&key_type_trusted); tee_client_close_session(pvt_data.ctx, pvt_data.session_id); tee_client_close_context(pvt_data.ctx); - - return 0; } =20 static const struct tee_client_device_id trusted_key_id_table[] =3D { @@ -261,11 +259,11 @@ static const struct tee_client_device_id trusted_key_= id_table[] =3D { MODULE_DEVICE_TABLE(tee, trusted_key_id_table); =20 static struct tee_client_driver trusted_key_driver =3D { + .probe =3D trusted_key_probe, + .remove =3D trusted_key_remove, .id_table =3D trusted_key_id_table, .driver =3D { .name =3D DRIVER_NAME, - .probe =3D trusted_key_probe, - .remove =3D trusted_key_remove, }, }; =20 --=20 2.47.3 From nobody Sat Feb 7 13:58:47 2026 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 44C2B248F77 for ; Thu, 11 Dec 2025 17:16:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765473375; cv=none; b=gGTVgM91gcDmBbJkr11mkPAC1KNz9woMZFvveahJxJmTjNKi4t7rnEqinWrQXtpNhVNSvgkb7b8mvf9C3+qQPW+u5a/5yHW7WOtBNetD5NklbJHGXcCm8nb1W2k9J5E/TA/SYBte10pEQ8ewBMpxfp3lXXIYdh3BkWNyr5ZIACQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765473375; c=relaxed/simple; bh=5qNJMJD9NKYLkVk7kOpcgd1zMxW4iDtExg+oTk6DzX8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=g4jG+1Lx9UcWBDNA4hxOKCLi3D6QxY3HVyCTkL8ozrh2wEwhH1qTTTDtnK6zzkrPS6CRURSQ/5N6n+K/ACgl7CRc5HzPtmvQPFV9X8USKvtmocCZ04x6bDM68879uyh7kwcEhHquc2e42zUzgTa8f/HZif8V+3rj6m3PYmIhrlE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=kV367gP4; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="kV367gP4" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-47a80d4a065so2900885e9.2 for ; Thu, 11 Dec 2025 09:16:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1765473371; x=1766078171; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ZBhu1Uqa8RVHn7QCjomFckovl/MFhjzqjW3Qy6nBbgQ=; b=kV367gP49DVkUnjW/zWuUTaSsJWrDNoHGOwZiqikhZmOAqBT8WJQzw3kGCMpfW4XQI pJiuwlHeoCI//y2GRN058R7rt0R2Gjnnb3FIsAXHMe67qnLDB8bB4oyhrR1KIO9ljHVo Rck3eix67N7xoZG1RpH4xEKrrnuvKWVbpOtSIYAgH7XgIx9Eiryq2q8RIIUCD0ADcDXY yKbBsAjlTEuenxdxzCkatiNMCC8dBra31PYwhjrxLVczWMgAR6gVglKcSJVsZatOG5eu 4qjEK6qIBqjzssRK9rtPI5kKNTA35pk13UBloaGDEjN9pVZd2cVi1ifToghOYzBC5+T1 JrPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765473371; x=1766078171; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ZBhu1Uqa8RVHn7QCjomFckovl/MFhjzqjW3Qy6nBbgQ=; b=FmgqVl7tCtxwnNaCSQWHy30W2SJ/lr4kna7ZYGkT/pFbSY/McOLkB04NuhxC9ombnB Drpirryb6oauWrDs8DY/yy1N3o+FJpxaRLjgJSwnDSKgyNGlneNTOyHzO1sZTW3++vvn mf3ERqRpDn/svOCQ3qPDZZmjB4JyfGSpqmuVYi7YWjAw03plZ+RYds/JyKR8h8xGS3uW B+EDc0D+fZwOQp+REiBTdYyps4TbcvG+uULCdv3wCYXT/pu30rlpORyV3/3iDwMMcYqP T3yS0l9SSQJm//IblIas+d14oWm06tQJXD2/sg+Hg4eo/1py4EbVg+Y6eMCGoWMtdNVS lJIw== X-Forwarded-Encrypted: i=1; AJvYcCUdphEWiw4I8SyoL/miUnD8cKqIfEK+ccE8bxi8aafpSv4KIVfFV8VL5LQJ9+UMuJZ5QRHLoH0IJDNIW9Y=@vger.kernel.org X-Gm-Message-State: AOJu0YwdpoqvG+ej/aavU1e+rOjY3MYsu1tr0zgoVVE18MzwtsFdoSPA B9gEY0H07Ik5vqD0hCKRSz6o3Oi8h7U3sm54Pfsji00LvdUl8/eCsoaBUyJW02NuSYs= X-Gm-Gg: AY/fxX4+KoWUzTb7awoTkoc0LpXbO9oS3AfEO0toQ1RM1Zm+Euo7roo/E4K14sddAyG iP0IaoV50MhBf9fH3wk5FWMaCj8ZtYpmX8eU8FjzVGO2MeVenZJlhytIJocJKFVIxFFsgoY1xgP 2C2GNRgCeal+Mf/H4FzpRAvk1WbW28+Qy7LbFgtYAIfK14FghH+l1fByG+Xy0St6+VfmabmoIIL Ig/kqfkwBE5th8zWtw2jWOHlQ4BPPqNnTcbxnYLQ0lECiB83hIr+lB59+O5qqPLAF0G0oAGQc++ dGLXr1B1c6ye1/cA3yt03z92usqRHr3aTHBvPa7JDYLt4FoetVcZHaiOYRtv7vLUkIaprvi5qnS RqOTJrvT5b7sNQBfI41o1oFiNDHcvzMw9+groPk8zm+9YgyJs9y4AlHvQmBgFjrMIUmQiVUo9V2 fNvJsekrYCEi3GQ6ivX4wMG/Il0gLiREIUXmOmK6brCLZO2eUv8uRyDNc2iKKlxw0n9W6q9O475 Vw= X-Google-Smtp-Source: AGHT+IGk45+DhZ6tL02Xp6VckzN+X1jTYMhezBcXnBBMkdftVDcvtciBmncNg6/XCy6IPmPPgrbLng== X-Received: by 2002:a05:600c:b8a:b0:477:8b2e:aa7d with SMTP id 5b1f17b1804b1-47a83847b05mr75101475e9.30.1765473371412; Thu, 11 Dec 2025 09:16:11 -0800 (PST) Received: from localhost (p200300f65f006608b66517f2bd017279.dip0.t-ipconnect.de. [2003:f6:5f00:6608:b665:17f2:bd01:7279]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-47a89f8b31bsm48120115e9.13.2025.12.11.09.16.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Dec 2025 09:16:11 -0800 (PST) From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Jens Wiklander , Peter Huewe , Jarkko Sakkinen Cc: Jason Gunthorpe , Sumit Garg , op-tee@lists.trustedfirmware.org, linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v1 16/17] tpm/tpm_ftpm_tee: Make use of tee specific driver registration Date: Thu, 11 Dec 2025 18:15:10 +0100 Message-ID: <812e5c580599b27d4f752ba8cfc35ad5371ab545.1765472125.git.u.kleine-koenig@baylibre.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1369; i=u.kleine-koenig@baylibre.com; h=from:subject:message-id; bh=5qNJMJD9NKYLkVk7kOpcgd1zMxW4iDtExg+oTk6DzX8=; b=owGbwMvMwMXY3/A7olbonx/jabUkhkyrP7ZRP1fMjFA/WaKg5FDBu+/h0r09x78+ZffZdZXTX K8x3rywk9GYhYGRi0FWTJHFvnFNplWVXGTn2n+XYQaxMoFMYeDiFICJ/K5n/x8w65hR5gxFs+/u GzYLL+XpyOWJ+hfn4z9vftb2s2XL1hfeEixpKTt0buWjXDHxXelbk46nXLwyr6poXvT2xtqS9hl T1NyyC3deOH33eYneLyW9bPcF81Yo20hdYTD3mbLAI2qG4Xfn/yvcyzl26umo8Nk1r91sMq2Xsd piJS+/VXiansHLype26+RzmPXOi03Wz6/tW1i+2PjcOlmePwKFhbPYP9isfeKc5agau/VyuUlL/ emWkHg9Ad34ZQZXLqafXHT08r8IrWn8sW0Vmu+mJmmEs096+fBOW7qN5S7GphJeHcPI9zeLGR5s tdyd/pNpd+W7gEgO14dTjq/1jVD3LJzv5hjy+pTq2YcnAA== X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable tee_client_driver_register() is typed more strongly and cares about assigning the driver's bus. Similar for tee_client_driver_unregister(). Make use of these functions. Signed-off-by: Uwe Kleine-K=C3=B6nig Reviewed-by: Sumit Garg --- drivers/char/tpm/tpm_ftpm_tee.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/char/tpm/tpm_ftpm_tee.c b/drivers/char/tpm/tpm_ftpm_te= e.c index 4e63c30aeaf1..e5fbc70b0eca 100644 --- a/drivers/char/tpm/tpm_ftpm_tee.c +++ b/drivers/char/tpm/tpm_ftpm_tee.c @@ -338,7 +338,6 @@ static struct tee_client_driver ftpm_tee_driver =3D { .id_table =3D optee_ftpm_id_table, .driver =3D { .name =3D "optee-ftpm", - .bus =3D &tee_bus_type, .probe =3D ftpm_tee_probe, .remove =3D ftpm_tee_remove, }, @@ -352,7 +351,7 @@ static int __init ftpm_mod_init(void) if (rc) return rc; =20 - rc =3D driver_register(&ftpm_tee_driver.driver); + rc =3D tee_client_driver_register(&ftpm_tee_driver); if (rc) { platform_driver_unregister(&ftpm_tee_plat_driver); return rc; @@ -364,7 +363,7 @@ static int __init ftpm_mod_init(void) static void __exit ftpm_mod_exit(void) { platform_driver_unregister(&ftpm_tee_plat_driver); - driver_unregister(&ftpm_tee_driver.driver); + tee_client_driver_unregister(&ftpm_tee_driver); } =20 module_init(ftpm_mod_init); --=20 2.47.3 From nobody Sat Feb 7 13:58:47 2026 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 80F4B319877 for ; Thu, 11 Dec 2025 17:16:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765473377; cv=none; b=Z3B5WSRAGJuedGL6cOzRFV2SMiVfKGYyflI6cO03/3OroATLPGwNGY+EKfqhhZZRdOq+PX/mV+9zqAfPwglNa91qVht07QnU9U/Fz9kF00hP6y+xiBuMqqx2QNJqUM+srFndELslQIR3YRbUcRTXWgBuSp+6gVrcO6gAQDRtozM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765473377; c=relaxed/simple; bh=Svc6/wu5PiStY9NpUW3zypfWEAb+rgVj8zt7WVDcjFU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=LTgGWKGrvlJz6FNyk9AYao0kEnpw5V6kH8Mg2wjN8eY0n+FLUDjgbmkrKpYqXlQ6e6CyQ4n/Zg0OsiT+aV1wLnJTaRgvbJmPxUIN/qiZyMI/YceAw38T+Cui2n/djPuig4v2kc89A0sAz9WTtFlI1XPjC+/Wu9KwFbUO7yKtEy8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=pS+XODJl; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="pS+XODJl" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-42e2e2eccd2so274000f8f.1 for ; Thu, 11 Dec 2025 09:16:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1765473372; x=1766078172; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7slVLIofatSoTo54gYSEEiPQgSIuIVsTlq2fZY6I/RA=; b=pS+XODJlspeVbExUvf9zAENPsYpswfqZ9sMugG1VGwfwTK9osGq2tCk9Qt0+S3/nnk kqWbOIcjONKvl7FKuWskOBTnlq4gxOEY4IVVcQQ2AoH94HWXn6eZz+F68m2TVF6IybpO FsJOyOC5LLlkToTAw1Q2nEI3NEWrRJmInhzvs/6Qu0gYPTC/AK7Heau8rEzDd0IgIGZI e3Gl4tF0YznFz6eDNVTi9qd8pczkxtXv9RVeyqVaXiuXQqg+4dGGHZDiLL8ZnuLNxd7Q FaQ8eFm0asIWsTCdqh6K3AikJsn7VooZJcadCReF9KGPEGu6CFKdhUp9ts+defIO/2FE NYpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765473373; x=1766078173; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=7slVLIofatSoTo54gYSEEiPQgSIuIVsTlq2fZY6I/RA=; b=gFMW5vRaAHdwopCpeok2t7ic4QloIYaZYDHikq7z+H37QV/EmxHt3uoXcvjA45LfEw q73p8LK5zN+B2Uj/AHzqAb3O0AM5pqrN65VeO9jjX2bssZW/Dc1Jt4Ac/53yiU2BGAZ0 gqa6iY7VeaIu3dJ74oFN8scClcbCYSaDVZ8bloUSWpeQ/NUIrO57Qzm1Y7s1Yvn6cY8z w15Ozhat/FynBXjhtEi2bdgTXfPrDBbMs3S+2azeXA6f5wmHBxLl6lWVrbyMxRK11NcD 8jztreARQvoBLpNz/p+66KTIbwZ8UQeIld3XkcZSdxM9OXXdXlofekMSCGcI0B6++CM4 0/Iw== X-Forwarded-Encrypted: i=1; AJvYcCVYggzD6HJ4vU1JhFk19fTeAs+fa83D7s6sQrObsCL1zNo85Bi7Uzp5fa/rENQvk0ICR0gry2ezuaiyE/g=@vger.kernel.org X-Gm-Message-State: AOJu0YwI2CloM7FVUsFszRvV/Hl8YupVYoac/9h16M15a4Q77FuiPGIz njHXBfvLvof2rs9+mMTrhssS5+q45GOCgbrXu/0e5GNF4qFNpGKgoLHJ663BqhdWbNA= X-Gm-Gg: AY/fxX6pMCVrQvsOrdpMwLaNotF2Ps5NuEqnCaqqOsCXN0SbwPx+IWQ3jOFe96vYynT hJEXeW/xWjJ75wWncEtRIgZGtC7uGIn4/Lqdg/DvkdhTzg+W66M+LZ9qEcS5o453ARaasG5QFEv RQWy3Nw9OOVcD1SZO+BLuPGO5XQXIdq/WunHKO7t7lWz+fkI8KPeD07+YqfgTtajHJAvu61a1Ky Pdd+u8Fr+Xm4zl4uafzuXhsnQW+thLxx4gN4gEea/CzNZBARljr+m+rMGZPTxVq0/xv1wuLHQrk v/iW0fFE/z8WhzablnGhs8ceHAY+oUtnraSGUoyqkr2iS08rPVWlJQ8HWpKt6DO7o2s0dsCb3bv FmV9DjZXtWoJowlvxYyJ8ieHKrMprA+UFojvXB0WzCpou0sAi3rxJThADdU9OxRS4fFWjBPNI/n Pkg+/ph5OiL70ea0mE/HuV/xG0lb89UPjKzlrXtrIpT+z75lf+TmcOQjEOCPFHH/fsvWHGuFuCC 8k= X-Google-Smtp-Source: AGHT+IGJvbFZQsknQaRH6NGcKkb8LTeqvHIo6DvlNxlXfRNU3KD3pAM+iHJV5Xd8AsZ/8DUR/5v8wQ== X-Received: by 2002:a05:6000:2489:b0:429:8bfe:d842 with SMTP id ffacd0b85a97d-42fa39cf06dmr7635910f8f.4.1765473372543; Thu, 11 Dec 2025 09:16:12 -0800 (PST) Received: from localhost (p200300f65f006608b66517f2bd017279.dip0.t-ipconnect.de. [2003:f6:5f00:6608:b665:17f2:bd01:7279]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-42fa8b8a941sm6802514f8f.34.2025.12.11.09.16.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Dec 2025 09:16:12 -0800 (PST) From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Jens Wiklander , Peter Huewe , Jarkko Sakkinen Cc: Jason Gunthorpe , Sumit Garg , op-tee@lists.trustedfirmware.org, linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v1 17/17] tpm/tpm_ftpm_tee: Make use of tee bus methods Date: Thu, 11 Dec 2025 18:15:11 +0100 Message-ID: X-Mailer: git-send-email 2.47.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=2542; i=u.kleine-koenig@baylibre.com; h=from:subject:message-id; bh=Svc6/wu5PiStY9NpUW3zypfWEAb+rgVj8zt7WVDcjFU=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBpOvxANVuZTA+Vs41/jfUCca0wp0pub3aHXza8N 0dKzZ+eSCOJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCaTr8QAAKCRCPgPtYfRL+ Tj+NB/9VP2U8NFQ0NoJVMJc3zyFqZ1tv3cfVRRg/zerpzGxs0TU0wiMUcNVrwY/foFivXYxySWi sBBzEr3Nbh81+LLjnzbnBZWMmMlR/LDg1eZEKjt9oRRqblTq9vKa0v2Jw+zGSBVjfHWCWEroVcL Ah0WQompRwLVbSfLGUP50lh/teI82ay9QXe9Jr6R843myqJnsCWcPFMxUOQycE0aHwvXkmyVv5M +Uk45OlbqDsep5AzX+PLGbJu8QgBpdkwDf3qwzB881AWz3UvzneB0Aj7IqtjA3LqayVrwPiatzs uythHyB0xKp+f2PNjUzkiaZYKpKSSugZ3rVhqqVXLMZFQwez X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable The tee bus got dedicated callbacks for probe and remove. Make use of these. This fixes a runtime warning about the driver needing to be converted to the bus methods. Signed-off-by: Uwe Kleine-K=C3=B6nig Reviewed-by: Jarkko Sakkinen Reviewed-by: Sumit Garg --- drivers/char/tpm/tpm_ftpm_tee.c | 26 +++++++++++++++++++------- 1 file changed, 19 insertions(+), 7 deletions(-) diff --git a/drivers/char/tpm/tpm_ftpm_tee.c b/drivers/char/tpm/tpm_ftpm_te= e.c index e5fbc70b0eca..20294d1953a3 100644 --- a/drivers/char/tpm/tpm_ftpm_tee.c +++ b/drivers/char/tpm/tpm_ftpm_tee.c @@ -169,7 +169,7 @@ static int ftpm_tee_match(struct tee_ioctl_version_data= *ver, const void *data) * Return: * On success, 0. On failure, -errno. */ -static int ftpm_tee_probe(struct device *dev) +static int ftpm_tee_probe_generic(struct device *dev) { int rc; struct tpm_chip *chip; @@ -251,11 +251,18 @@ static int ftpm_tee_probe(struct device *dev) return rc; } =20 +static int ftpm_tee_probe(struct tee_client_device *tcdev) +{ + struct device *dev =3D &tcdev->dev; + + return ftpm_tee_probe_generic(dev); +} + static int ftpm_plat_tee_probe(struct platform_device *pdev) { struct device *dev =3D &pdev->dev; =20 - return ftpm_tee_probe(dev); + return ftpm_tee_probe_generic(dev); } =20 /** @@ -265,7 +272,7 @@ static int ftpm_plat_tee_probe(struct platform_device *= pdev) * Return: * 0 always. */ -static int ftpm_tee_remove(struct device *dev) +static void ftpm_tee_remove_generic(struct device *dev) { struct ftpm_tee_private *pvt_data =3D dev_get_drvdata(dev); =20 @@ -285,15 +292,20 @@ static int ftpm_tee_remove(struct device *dev) tee_client_close_context(pvt_data->ctx); =20 /* memory allocated with devm_kzalloc() is freed automatically */ +} =20 - return 0; +static void ftpm_tee_remove(struct tee_client_device *tcdev) +{ + struct device *dev =3D &tcdev->dev; + + ftpm_tee_remove_generic(dev); } =20 static void ftpm_plat_tee_remove(struct platform_device *pdev) { struct device *dev =3D &pdev->dev; =20 - ftpm_tee_remove(dev); + ftpm_tee_remove_generic(dev); } =20 /** @@ -335,11 +347,11 @@ static const struct tee_client_device_id optee_ftpm_i= d_table[] =3D { MODULE_DEVICE_TABLE(tee, optee_ftpm_id_table); =20 static struct tee_client_driver ftpm_tee_driver =3D { + .probe =3D ftpm_tee_probe, + .remove =3D ftpm_tee_remove, .id_table =3D optee_ftpm_id_table, .driver =3D { .name =3D "optee-ftpm", - .probe =3D ftpm_tee_probe, - .remove =3D ftpm_tee_remove, }, }; =20 --=20 2.47.3