From nobody Fri Dec 19 09:43:05 2025 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 07767285CB9 for ; Tue, 9 Dec 2025 11:41:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765280486; cv=none; b=FJhEHt5zLZhkBe6SNVlfF2oxMkRCrLDpFTB0TtpQ39Uyam5CTGsSVftyfkinHnvWigs5u0kKWMbwN+8JAFuagfT85z7ovTV6Eh+tPtQ42wP6K3nI11wARAUMJStjziFteHNb+NUC60OmX+jxTBMJ8DYRo3KRm5lfJVnO1M39iL8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765280486; c=relaxed/simple; bh=l3fXYKi4pGNSt7kFvw6nHQp4KrwuyWix9tbYeZiuZFk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=MSi2LagL/2wJjlBuNJRf7Uyu5BLyWfSjaM7AA3AN9TA5Pr1PFhnblIhJ2aJETrxFAwfCArY77Jx5/Gl/1dsZMtKk5ABARjODjb7uOblgzQMQZZACeYYNCQHe6XdqVl4qsWjsn+9AYUuemkqUhHWMn4MFdfhKucv2LcT/PnZ6D64= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=ysY82u2O; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="ysY82u2O" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-42e2d02a3c9so3739430f8f.3 for ; Tue, 09 Dec 2025 03:41:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1765280481; x=1765885281; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1D/MN/XFrIK+XQsOry+m0d08hGOkhZCu9Lh+2mw+SB4=; b=ysY82u2O48HTgVeKm0dvsWOgCLSbfQNeMl330RthTfICtxTzzSYwmfyvnA/ATW2UEG Tp0+2MPLaaTSCMX7VD/LYD5F6a+HswN7Zyvc5E485sS0rNMOsChs/Ysk1CvkewblxRA1 gTNaLyrDGn8MG9daD3MGunDq3LXmldL8NFE77r3qQd+WxiWLw5dxvU+fAnWJzL5H3l2j y8ibD0+ZKLJhGOLzTZbYWJcf0g8zK3dWibZsU/dOKsnT4S5/ZMyOmK0n/HZxrDu9O/1x BsueJ4MB4WBOaG1pDxhnB/PDlyC8Kwoy2vHi8MOLfH7ZilfGCDOwoEOEPAJDeoOOPxyY hT0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765280481; x=1765885281; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=1D/MN/XFrIK+XQsOry+m0d08hGOkhZCu9Lh+2mw+SB4=; b=CCi5hkwOZ2f1H4/MbFkQUQAf+3NgIsIu896vF9iDim6TCAe04nES+rfpogxI2LGYqd Y86gkwmU4ur4FUeZcnk2f1nnmDKHjLoJn6uIH+U3wPJuYxVbdryLx1uvU/lOLjJUPbG/ S/9pDu8RJi1Wn5zPku7Cn9bkUT8eoDccKdKqcWEXKrExKQ0fnFuhuQX6bgEkQGMOjm0a PJxPx2DdRvbpA0q97LuUFTLRaKQGP8tNxXhZizEul+UMLc+XPArHtYY/jsocZXToi6vs wH/sDkHYH/xRYFdK57kmWg2iFcnwTdVxJ1GTd1JN2HQsRs5Ryo6vHSFzqPd5Cu0uGbP5 NV4w== X-Forwarded-Encrypted: i=1; AJvYcCWg5hx3x6f4nNNPWaf3l/9FfMYVZhw873C1JhYD026/Sdr0ab2tjIF/VGBfIlGRDYUN54cVFG7X65UjvvI=@vger.kernel.org X-Gm-Message-State: AOJu0YzWAs5b56euURkAC7ThiSfjQ1QZtZXRui5EZuFDFQjXyNmY61O5 gsHSozqMLtaLtctPQRk4QpmPOAr6u1SSckaWqHg6jWDvtw5W953iexmjJIwBLDb0vlo= X-Gm-Gg: AY/fxX54O5GPwzqhTmyoizrZ/09d9diC0muwz+aII3u+Nb3Q1RLSHsYpmKQDgYBqLlC 5Jg4KdiovE09vxlzBNIh8LdnHupSeq7LXbetZ9gJCvXMsWKUiZt30Vf/8uEbTrKSQQ5xk2NGowa kR8cSFWGezQxCoXcxVCmmWoe3P6vQFjgX4V4Nr8FCfuXnwPMOoy16aZ2f3YjJ3QOuTOaRyKQssn bWxY8vYGMwzpLH4S4cpMnvyuykkZO2gmtwHmF6XRJ7qTd3x8U4AZV+K106v1xqHp1iwW7wvzlOV XeXYtKintSjY/JHa2ebihny8C8LaRIpVGNQXQ7B9x1dkKox4oIiA4XtINTEp9+wTQA3zdrbiL2p KXvMWe9/oWfMLTogAdrv2ogTL2Ooi39S/4U1CtivKBT07GrWyB2UX3kxMuDRuUL0X9pKReRgxST 6CBYhtwmrAxRuf+unpoePHrO5ENeyZAmf+3ctnfv8KomW+N3l9F0YHEmM07w7NbOCdhjBrtF4E0 xI= X-Google-Smtp-Source: AGHT+IH8PTqfKEPbQ7sZpSC7KHGQrE91kdMShP6HVnP6VbX10qbjblgbC3+603XCYV39CIqgmfoM4Q== X-Received: by 2002:a05:6000:402c:b0:42b:4279:eddd with SMTP id ffacd0b85a97d-42f89f0e25cmr12076790f8f.24.1765280481285; Tue, 09 Dec 2025 03:41:21 -0800 (PST) Received: from localhost (p200300f65f00660846b2ba6e435ad603.dip0.t-ipconnect.de. [2003:f6:5f00:6608:46b2:ba6e:435a:d603]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-42f7d353c9esm30112480f8f.40.2025.12.09.03.41.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Dec 2025 03:41:20 -0800 (PST) From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Eddie James Cc: Ninad Palsule , linux-fsi@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 01/13] fsi: Make use of module_fsi_driver() Date: Tue, 9 Dec 2025 12:40:25 +0100 Message-ID: <602437dc213cbe35ee75d0d0a4b4a2c28859e3f9.1765279318.git.u.kleine-koenig@baylibre.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1570; i=u.kleine-koenig@baylibre.com; h=from:subject:message-id; bh=l3fXYKi4pGNSt7kFvw6nHQp4KrwuyWix9tbYeZiuZFk=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBpOAqzGg3nwMe564aGogl01RV0XrSyAKZ82DnVC aZjuWykm8iJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCaTgKswAKCRCPgPtYfRL+ Tg2aB/4pTTKuygeTvHTDmjlsaR2Jq0AIuCpUj3Z1Oh0WlEN9aWewWThrP0kJANllUDFJWLaUf63 h/RPt3bsgD3UTV2PJ8rW2OuTqG1fZ/pgM9mZSnykQ4xtRTUHiVqvOOpPLGBxyeeuumkUlrD5PxI Z9JdLMQv6MlPx6f6GjHu83VNABoLamh9E1MXByHYaJZIFXiLAyu9Cs4BMi+pbjUMoAzLzS9yl55 n/oGaT81DzjVJZet5lFng+3lRJarJCbCy77RxAgDaztlyY5KAqOoMR1jNjq/LPxHDAQeaa9H8Y7 UVB9pVNJFxgQmllF+sXdddE1n1gvjy9qTMjIA1MWz4uJRwM6 X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable All other fsi drivers already use this helper to reduce boilerplate. Catch up for the last two remaining ones. Signed-off-by: Uwe Kleine-K=C3=B6nig --- drivers/fsi/fsi-sbefifo.c | 13 +------------ drivers/fsi/fsi-scom.c | 13 +------------ 2 files changed, 2 insertions(+), 24 deletions(-) diff --git a/drivers/fsi/fsi-sbefifo.c b/drivers/fsi/fsi-sbefifo.c index 0a98517f3959..5a08423d0c7e 100644 --- a/drivers/fsi/fsi-sbefifo.c +++ b/drivers/fsi/fsi-sbefifo.c @@ -1139,18 +1139,7 @@ static struct fsi_driver sbefifo_drv =3D { } }; =20 -static int sbefifo_init(void) -{ - return fsi_driver_register(&sbefifo_drv); -} - -static void sbefifo_exit(void) -{ - fsi_driver_unregister(&sbefifo_drv); -} - -module_init(sbefifo_init); -module_exit(sbefifo_exit); +module_fsi_driver(sbefifo_drv); MODULE_LICENSE("GPL"); MODULE_AUTHOR("Brad Bishop "); MODULE_AUTHOR("Eddie James "); diff --git a/drivers/fsi/fsi-scom.c b/drivers/fsi/fsi-scom.c index 411ddc018cd8..f533106085ac 100644 --- a/drivers/fsi/fsi-scom.c +++ b/drivers/fsi/fsi-scom.c @@ -613,17 +613,6 @@ static struct fsi_driver scom_drv =3D { } }; =20 -static int scom_init(void) -{ - return fsi_driver_register(&scom_drv); -} - -static void scom_exit(void) -{ - fsi_driver_unregister(&scom_drv); -} - -module_init(scom_init); -module_exit(scom_exit); +module_fsi_driver(scom_drv); MODULE_DESCRIPTION("SCOM FSI Client device driver"); MODULE_LICENSE("GPL"); --=20 2.47.3 From nobody Fri Dec 19 09:43:05 2025 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 053E4291C1F for ; Tue, 9 Dec 2025 11:41:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765280487; cv=none; b=WvlBo6W6yZJFJTNMiXUY8iIvVtfMwfdxP/gFNmUjTL7EvHHp1AnM/1OFlIuVIw9xZTB3fDE47iyzrRPf6arrFK2V6olxzSw/jxawFSy/E226DwmqJnj7GLa72kSt0l2pzvkc3E/fPB2dVAaRygD5lOOz7RRat5fuFHE3oiiS/9Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765280487; c=relaxed/simple; bh=wRaWW24pXY+OPYNZIR5cKkkiBGL1akjSxYa2wBmqxHs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=itcGIlUtX5vjWGs6VQDOVJiMZe8wV6ocyQfBq87XYBhGX4bHtuoCYqhRlEoHzD+bK3j1tQVv27T1GUZw8yBnz/AsNAUwSBFIB+aEkS2envBkaxZHi7JY86KgBfaUv9Bfo4hj86OO95CnsKODCrszJIzYF62OlqpAXaYWLyP9/do= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=HaFUYIZ/; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="HaFUYIZ/" Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-42b3c5defb2so3065823f8f.2 for ; Tue, 09 Dec 2025 03:41:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1765280483; x=1765885283; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/wpozwXd7C0ITdX+8ILepswCKxR/Gjoqj1EK8uGzLC4=; b=HaFUYIZ/VmdVeE1pGmqzTokHQOmMyt9Q97P1Hdwl0+eISf1aGxHs3smFOJh6nocHcs tvkJq1xixDRjQFJ+OwAaPc8+4jHq+KVrRmUEPN5sJA6PBbzlMygZrJNBpq7OodJg5rK0 NTw16FNi9LIcg06OgYwL09JgEK9UsX8MNiyMBCODG1T1jGhj6X7UIsAvTbx5VRtxf+/O cSs+xOSiqrO4/jhw+SnKRXtCjS/4/yipKWZTd9tFiYSDlfSk/PqKQeVQVm1ALueMwIYm xGWNUKw6al8c0Z8FtzVH4mzDbntAR3+M82v6rbA4tGAeMaFK66Oa8oQb3e6g5chhTb53 +6iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765280483; x=1765885283; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=/wpozwXd7C0ITdX+8ILepswCKxR/Gjoqj1EK8uGzLC4=; b=XwA0lPj2XsbGvBy46ZBDlgoB7Yf9T5a/MfrvSA3v4/nLaXvfHj3gPpIYwFGbRej3Ko dFTfoocUD+JEcUBjErITsm4nPYuX7pzgUgd8uJ5AIbTKeV8a+bM3+n6vaDD1Ass5DiMm z3pzvOAhYOxj/0nrAlRe09HgpjCMEzVjfVQFeFDfOy6WljLr2pZm6qwehwROGrFY8937 gH7h0HSDSTsKHyliTtHtSP7pPQ+usN8rF7sSz+5nrpahlpR6XHB8GTWTkN+FA1wJtffN PE8i3SV0MYzmEhvDP/IA9x1BDD510tRsoqriAg6/fnQUoaSwsJeC/0fjGquxxTtlZaQe ofig== X-Forwarded-Encrypted: i=1; AJvYcCXuOL18JwH8j14zfLrSAYKEdCQn6v5EDhvnSeE2PCk6iKKZl2JLORebHfbbDWQkI++L1CDAeFRWp/QalI4=@vger.kernel.org X-Gm-Message-State: AOJu0Yy75cOARxaBboBhmqonVZQF6cPDw16CO0bIWdskD6Z1nEz7JLEH 6djMtrwyOqoZx0tajGH3aCceYuXSsGb7n0cAQMS5U8Yrq7tnYdBvE9B8uwqAu02kKcg= X-Gm-Gg: ASbGncs4cQQieCeqKqxXt3TWhcu9/eu6u7NJDVeZsBY14xeV50XwIq6+qDVxCz4pTo2 kUtL8GyCtFyv1fzhKYCX39fERYXMXVCeNysh67ln7jpdix9WmKTa7Yejg8d+fCi99SyWDMMiSSc Oz14rnuum0IDZHIYabrBXao7GfvajKNMfEsPLHWOOWlw9pSVDTbzoyLsJmmUF3nlbAzq6NUkN90 Ldqd76P/reXlaJMrmhT/WBjlvDOvTJmCQK04UXTGV03HvUTb5wi4XXZv0F9C/CMekPGft0BQqxO XIHR32BaoBEeh2KyAU6MOBusihmyMRRawGTmTdsbTS4JD0cRX+4IDnv20GFVQVgUMDHjHw1+M6w r2v+RDSsTW8FAeDyDMfKGvl4g+eSoVmPyRT4dPublr+B+kENMV3JCaNfE3fOscs5ZKTosLOS1lP 8EVYGS2Ky7wBWphvKV+vimnEAtw+162/VfAsWvlUr0Ii4o466JBnYYxSC0ZHOASkC/SgDU8cJqu J8= X-Google-Smtp-Source: AGHT+IGu+ihYfOznoUSPkIK2L6OWfJzRKcvLC8eNQMQTjW+WCFjZ0qTIE80NYheCWPcjNZEWG7Y7vw== X-Received: by 2002:a05:6000:2384:b0:42b:3746:3b85 with SMTP id ffacd0b85a97d-42f89f568f4mr11582598f8f.45.1765280483285; Tue, 09 Dec 2025 03:41:23 -0800 (PST) Received: from localhost (p200300f65f00660846b2ba6e435ad603.dip0.t-ipconnect.de. [2003:f6:5f00:6608:46b2:ba6e:435a:d603]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-42f7d353f80sm30900065f8f.41.2025.12.09.03.41.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Dec 2025 03:41:22 -0800 (PST) From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Eddie James Cc: Ninad Palsule , linux-fsi@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 02/13] fsi: Assign driver's bus in fsi_driver_register() Date: Tue, 9 Dec 2025 12:40:26 +0100 Message-ID: <54804c2cd4d84a6b5fb679831122b6acdd36b168.1765279318.git.u.kleine-koenig@baylibre.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=2642; i=u.kleine-koenig@baylibre.com; h=from:subject:message-id; bh=wRaWW24pXY+OPYNZIR5cKkkiBGL1akjSxYa2wBmqxHs=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBpOAq3hIlgOjX4c3SxZjpxi2WYkeqyINbLc6GK9 VnkguHfkDeJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCaTgKtwAKCRCPgPtYfRL+ TlKyB/9mppsRBVYB2gN9wVj3i2A90NaSd0AQ2t85SJ7PbimwKxrHYa/5dXEimcdZTyMbcIVGSTw IC0zbA3hRjq/Y4FEi3peRrxbXyV8waD/Zs+eym9mzLuW/aP8lGMwWF3ujN0v9ve8rDqId2p2X2p uIhNLYzMA9WF/oyxyZpYrj0gY1Aqk6nLPOdmXsVeWEA/ItnJKlAH/r/0VvQyJx5bXQ4ovyjIwuC iA9z/nhYAPBQkoV3QWXJy7i4O9TKmP1CsnVtMEt4r+/MOqEgzzBORpYU0zu5Do5fWL1cwHqtOZ4 8s2qbMa94y0Z6XGupuZ1NQbps0t/JToNa/V4RJ0Sk9gAFSgd X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable Instead of letting each driver assign the bus, do it once in the fsi driver register function. Simplify the fsi drivers that are living in drivers/fsi accordingly. Once all fsi drivers dropped assigning the bus, fsi_bus_type can be made a static variable. Signed-off-by: Uwe Kleine-K=C3=B6nig --- drivers/fsi/fsi-core.c | 2 ++ drivers/fsi/fsi-master-hub.c | 1 - drivers/fsi/fsi-sbefifo.c | 1 - drivers/fsi/fsi-scom.c | 1 - drivers/fsi/i2cr-scom.c | 1 - 5 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/fsi/fsi-core.c b/drivers/fsi/fsi-core.c index c6c115993ebc..e1ea1124282e 100644 --- a/drivers/fsi/fsi-core.c +++ b/drivers/fsi/fsi-core.c @@ -1394,6 +1394,8 @@ int fsi_driver_register(struct fsi_driver *fsi_drv) if (!fsi_drv->id_table) return -EINVAL; =20 + fsi_drv->drv.bus =3D &fsi_bus_type; + return driver_register(&fsi_drv->drv); } EXPORT_SYMBOL_GPL(fsi_driver_register); diff --git a/drivers/fsi/fsi-master-hub.c b/drivers/fsi/fsi-master-hub.c index 6568fed7db3c..d389856d18ac 100644 --- a/drivers/fsi/fsi-master-hub.c +++ b/drivers/fsi/fsi-master-hub.c @@ -288,7 +288,6 @@ static struct fsi_driver hub_master_driver =3D { .id_table =3D hub_master_ids, .drv =3D { .name =3D "fsi-master-hub", - .bus =3D &fsi_bus_type, .probe =3D hub_master_probe, .remove =3D hub_master_remove, } diff --git a/drivers/fsi/fsi-sbefifo.c b/drivers/fsi/fsi-sbefifo.c index 5a08423d0c7e..fde1c34743a0 100644 --- a/drivers/fsi/fsi-sbefifo.c +++ b/drivers/fsi/fsi-sbefifo.c @@ -1133,7 +1133,6 @@ static struct fsi_driver sbefifo_drv =3D { .id_table =3D sbefifo_ids, .drv =3D { .name =3D DEVICE_NAME, - .bus =3D &fsi_bus_type, .probe =3D sbefifo_probe, .remove =3D sbefifo_remove, } diff --git a/drivers/fsi/fsi-scom.c b/drivers/fsi/fsi-scom.c index f533106085ac..2eda44451cc1 100644 --- a/drivers/fsi/fsi-scom.c +++ b/drivers/fsi/fsi-scom.c @@ -606,7 +606,6 @@ static struct fsi_driver scom_drv =3D { .id_table =3D scom_ids, .drv =3D { .name =3D "scom", - .bus =3D &fsi_bus_type, .of_match_table =3D scom_of_ids, .probe =3D scom_probe, .remove =3D scom_remove, diff --git a/drivers/fsi/i2cr-scom.c b/drivers/fsi/i2cr-scom.c index cb7e02213032..dfdb16afd205 100644 --- a/drivers/fsi/i2cr-scom.c +++ b/drivers/fsi/i2cr-scom.c @@ -140,7 +140,6 @@ static struct fsi_driver i2cr_scom_driver =3D { .id_table =3D i2cr_scom_ids, .drv =3D { .name =3D "i2cr_scom", - .bus =3D &fsi_bus_type, .of_match_table =3D i2cr_scom_of_ids, .probe =3D i2cr_scom_probe, .remove =3D i2cr_scom_remove, --=20 2.47.3 From nobody Fri Dec 19 09:43:05 2025 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7A2282D77E9 for ; Tue, 9 Dec 2025 11:41:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765280488; cv=none; b=QeI1UWSFyKYirWRs0Vz/DUldDayOFCc2YCF1FeOWYBV0JJzyhPHwayXNVqUKc2kTOhgd+2VQHyKzWAtZ1rSxRkb3FL4QaCCGDnXwbVU3Hdwh98B9zNyn/8xpV4txgh8rNs3KVZi+IYbFI01kzeEE+DcSg2bFfeCC5Mc/PkwhrlY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765280488; c=relaxed/simple; bh=z/3JVW40CX0aiChWM56FVqew2AA2quKP+Q5LAFkIOn4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=QYmeGs5qBrb3kJlxsA8d8Xk0eKuJ8vwhKnhF0nRjsE8dQZsss4NjbhgBKa1itDDcz8c9i17NSZ/C6c9xDeGb/qMCNJtPBqIO4TlsJ9JLwzN+KtwuxqI/KxdKtcQrd9Pm5/h4fOm4oQ4qZNfHsqk+PyWlZBseek+XR9hpoofEFzU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=C3K91hf+; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="C3K91hf+" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-42e33956e76so2495913f8f.3 for ; Tue, 09 Dec 2025 03:41:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1765280485; x=1765885285; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=G/DXJ/onigpflOgZSB00x5l3wftqsveAzjxO4xUOspk=; b=C3K91hf+HCEci3rbbPmQaFnR+ItBONIBtDSFzEwmtz+WnoC+/sJBrKP+gYJDLkNrdE +D5iWctH7wVXC1EIjnfX7Gdj42jVzhzjrWpTSn5JZMH6xFMRRHS3xaflkcK/7NhCvtYc 5vNHuIUD4NPgIBtyax0QdFtZRG3sXEnTg9L5JRfAVanN+JvGDHL2y5rorvkNoJ8ufzEv P1iq/yf8SQVeFTi1v5RcHlAL0IO4xUwylU5axEDLhDn3D4/r/AnGgzA9A4s9dX1M1k+z Ej6IUtj/i3C6nCfj6/+SOT604TdvKPYkw38L0RfQcibiyT9r1Fp1jeD3vCiNfQ0GbuiC cXQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765280485; x=1765885285; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=G/DXJ/onigpflOgZSB00x5l3wftqsveAzjxO4xUOspk=; b=kexREICamtCNWmez811iBHxXZ9rxzktlTHZuTTqftt6Bj2fo6A9M3b0/TpmovN6kJP 7f77jUVi4zg6E7/SdSsR9BNJkQZZ22nYWcC8bu7G6GsTP0vlrOhiA9Zl590K5S4/98EH RoDSi68mcv+PhgWl1mDnr6kCXw/0ScQfMnd7tFjvPSORJ/U76vcHPr7q5DgRqGScmp+y 5rwMhpYSGa0UgsWCdCmtxj0iiUDGINVS70mndjDDCep2Y/0calpSJaTQi9qxcI1pi27l f3wWEaPD7tJvOD3aQweKddz6IQBQDItRSX2rRbMftpPS/xlHr3BFyoJ7yKoJdgUOD3BA 6Uvw== X-Forwarded-Encrypted: i=1; AJvYcCXMPawPiEV+R8xryBkSccqjwkZ3uSHa2t993N3kUKhRV/nqjmOMiF3L+jn7ryVxlELDli8U5A26QrhlFJQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yx5LWSU7kHOgir+RIzFBmyHNgQfh4SD4xxjU5KcTaCUKZbxIGHJ RvcdjI//jq5fYrtOVjVZgY26Gm1mhv9Qr/PwaF6GHBHvd8dG+2F66uysUOJrQmVl+1Y= X-Gm-Gg: ASbGncsceeZfWgghRvD7Oky4tSsbaTNZ8+nNU+IKT7/Kb3okSV98gVe/ovRzSHjgO+m UkNsCSv6hIj60uLOAkRqsp+qaaR5pmpHie+MSNKVmeDMSTO4a8m31WnBKm8/je3LZulmZ05JFVH nD4TI6h0xvwBValw96sfamoKYvlQ+lmXJL8cyo4IW+bIR3GNINmonO5lZuEBwQNqo5IbBzspmDG VqWmxzx5urLmHlhlBrV7PP4/UoKhYT2WiXhcdWtDxtkAMRBu+0fnx7Rse5VyiUbQmoV14rLVW2Q RgRPna0+5fEeu+smJ/sjkGDnrxGF0TrcBnAlk0x5T68k17XeSliyXTGMYhnw3zC6YhhnckzW8zw CXzibIlVJUrESvk+a0TYAvyCm0NKKlAKoRbZIC2QEqxm9LWjs4LM5a0Mp6+BUaIwJ59/kM8O5Ex 8dfj4Z7qXy+3AUQ3oG5o97xOGzNbpmDMN8U9Cuttogfha5oOm5rwtpq98XxB/3krMBdgnXFQI83 yU= X-Google-Smtp-Source: AGHT+IEOnVh1WLEO0PhYAe9+fHelviLRYSkozaz65yLQY6txQ+2V6LSTpLKs2jjsyMWbzHw/qt2Qkw== X-Received: by 2002:a05:6000:608:b0:42b:4219:269 with SMTP id ffacd0b85a97d-42f89f48476mr12171956f8f.41.1765280484854; Tue, 09 Dec 2025 03:41:24 -0800 (PST) Received: from localhost (p200300f65f00660846b2ba6e435ad603.dip0.t-ipconnect.de. [2003:f6:5f00:6608:46b2:ba6e:435a:d603]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-42f7d353c9esm30112716f8f.40.2025.12.09.03.41.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Dec 2025 03:41:24 -0800 (PST) From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Eddie James Cc: Ninad Palsule , linux-fsi@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 03/13] fsi: Provide thin wrappers around dev_[gs]et_data() for fsi devices Date: Tue, 9 Dec 2025 12:40:27 +0100 Message-ID: <5de7a7cbb30918b3503235130bd8aa1a9a63d71c.1765279318.git.u.kleine-koenig@baylibre.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=898; i=u.kleine-koenig@baylibre.com; h=from:subject:message-id; bh=z/3JVW40CX0aiChWM56FVqew2AA2quKP+Q5LAFkIOn4=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBpOAq6EZS2llN1e7+ZRq6kKycrdFzNCmKIZpKLa /rL/LeKj5mJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCaTgKugAKCRCPgPtYfRL+ Tj+UB/9/yD18Z2hm/bhwbtbTlEvUVfNOmftYxfW1RqrNRGEVp60CDJYhra1Tyg7kBqP8ecolalm LivgX7DMI5zcIZJeO/nKQRma/K1V7TROa6yGYWv2hPWKT6L12NWTg5KAN5AxN5ZvInNUONfSHCq NLe+giCMuuWmLCJCVoE9B4KyM7WY1B3wIq/j6Rk60FXnVFbUFoVS32r30MPvLNz24DxKWUEHWwy RHucVHDGF7gATiYgrYedSgBWFX0oKeTxvXK6K08/a6+KjkeNIUGmlz9e7Y6QvYCqlufLQgfPpGD ByYpm3c/pM1iLCLDmRk7iKCvHGaADYAE8MW84xkkQXffaRvK X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable Similar to wrappers for other subsystems provide inline functions for fsi devices to store driver data. Signed-off-by: Uwe Kleine-K=C3=B6nig --- include/linux/fsi.h | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/include/linux/fsi.h b/include/linux/fsi.h index adea1b432f2d..05be75869a69 100644 --- a/include/linux/fsi.h +++ b/include/linux/fsi.h @@ -19,6 +19,16 @@ struct fsi_device { uint32_t size; }; =20 +static inline void *fsi_get_drvdata(struct fsi_device *fsi_dev) +{ + return dev_get_drvdata(&fsi_dev->dev); +} + +static inline void fsi_set_drvdata(struct fsi_device *fsi_dev, void *data) +{ + dev_set_drvdata(&fsi_dev->dev, data); +} + extern int fsi_device_read(struct fsi_device *dev, uint32_t addr, void *val, size_t size); extern int fsi_device_write(struct fsi_device *dev, uint32_t addr, --=20 2.47.3 From nobody Fri Dec 19 09:43:05 2025 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 480612BEC45 for ; Tue, 9 Dec 2025 11:41:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765280490; cv=none; b=LK8tZsvk+AnFTBwg5CSZ2lOBGXl3kwP7wvyPHTFz/W+EUGouhEF3I1ES4VJ2tjkZwBUm2nNqXQX/MqmiTDpRFMQX5PTOzz09hyjLwB/G79M/V/RrvtVHAtLD4Iw4HcDihGa540j1MYWbnCgiUcpU13DxY3v502Tj+sirBUGYJ3U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765280490; c=relaxed/simple; bh=YXNtV+Vdnj9V5HmbInqMeie6ojhBt0TgobcWxdMwcl4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Ix78Kvc49kb2WN4cqogoqYwHQSOT0/bR6Tn+ySZZdlOhyo9KHyRSuv+jlVNtg9jPkLXLHZAEdwnBOk49EpigKYx8/9NDvP7iFT3XJpvNvUEFmUqJY6ztZM3SQc4x0ccbHRBk0vMEr2EfoxoMMGdxzS4XiuazytmucU+fLpiw3II= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=iJDXEzWu; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="iJDXEzWu" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-477b198f4bcso47913265e9.3 for ; Tue, 09 Dec 2025 03:41:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1765280487; x=1765885287; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Wd3Z4KYvF0dD65L7DPvviKR5Z1NQM0iwjwdQuL1cHwg=; b=iJDXEzWuVzFyc3c8jk1noOc7EiDdjWzNXDqwFg941t4Rb4pcweHAVGHhxd0HZmFBV2 Vd6Kzwc+LRMeB/8XDX7NTFVc53Wkz2YlPZErer4qslXAQKiI+qsUSBP68XPn95fIEXDw dWK5wkqkHOvMApBQZ+dIQwTMZs+ueajoSTiRVdvZKOyt7BxOzChhJtb5QjHIInckkcuL N8fKkprVkEetfDmNf2q7zhcUa8KdWZQr4pzVazAYLQhEH/H282Xerc9UrI9AUSoyp/kb hvcTMh1b/ywbP2886Rqxp4nuH/1ufASyc2QoyBY0ABVL5MNJwwyRAvAUVhNNB8nUhI9C Xnog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765280487; x=1765885287; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Wd3Z4KYvF0dD65L7DPvviKR5Z1NQM0iwjwdQuL1cHwg=; b=FwDnonFpGqMVIz5QdZqYG+0lu3cUSdZsfOB9sEAZJcrmPt6X3N0fW4vo383YDOBDo8 Gv7HfwT8at85gFqGFidNDfY9r+toFTMaOAdCuYsXnIY3UtepV3ItB4BZWr302fs9JKdU XCVg8UAfR4jLW5O+wHiRS25Mw+tBpllTNLNXJCeV73odrGoBchH/E9YusfDJwNweeOeJ UW/GjoZ3AgtxMI/Z80WamTIw59EgnoWGRuN1kWik9XXtmtqTGd2I8Gl27JipNk4rfJkP 5zuC3Fwwwa5h5WYQoJWq9hnCAvru80GFCRA4F518N5saixQl82nEFMbJiCmOVXBqDMui h+5A== X-Forwarded-Encrypted: i=1; AJvYcCVmMISWaF/A9f9fzZ92v0tHoSlHP488EkoeVZmlHkUDnwproA8V9o42oyGnEqbG/MqKh2y6sEWHXqbQVCA=@vger.kernel.org X-Gm-Message-State: AOJu0Yxa3F2ZbEU4t4onS+d9+gYCQZ6XHAkSEZvu2lsAL4EPn+kok5jY ax7dAfW5P/WXkgk8dT89GKFhcneLrAFTQVPbJtIuJnR83oVcP0NhMNYHSEsrKBa3rAM= X-Gm-Gg: ASbGnct3vNNJi90sPF+w61+yk2XS2iMwr50cgTPUdQ6co/IB/TsSgI0D4SNN5+kvjGT V4inZ0wFnFIpGoWW750+0de5qF/7zn3Ly11ibO7U4c0fXXfH4sHt/TcqqVE3tnxn6Fq11Te/7iK S0ujNQj1a/MFD1kqFxoHsEkUFxfYo3JyCogqEZ4g33r0240pxBY0UjoeF1oVF+aKVZfQnBjaYQe eJUfz6X0Ak7+P+vHoaLD4++vkoAN9rXk7Y00nL29RrFhybX535z4QBAf3TyXIxmN679rJzkZk37 wgBTgJN2krC6tFkF7Be0HyjBYbPb5Yt55TILTN3MF7qHHy54G/WggSqS8JS8LU/Zt7v2DvWQ8M3 tnTbxA+me0/zVHXoM+mojCB0qSn0l0rLPoy2ZvLq9w2EM9WE62HLKDejqDYD20TaKCXJQMS0QwV /HKkWdp6lLHCx0slFp67rRTiGQuUFYPRnWKMuZwwefnF4Meu3V+gywxmySZAUFWOeXByvVEkp96 hg= X-Google-Smtp-Source: AGHT+IHHuEvpcoKORlw30IlhcBh1e4pcDw71sf4iDJdmgzkWvf/FjxDAXF+Ko3/c/puYTdhF2sl9Aw== X-Received: by 2002:a7b:cc17:0:b0:47a:7fbf:d5c8 with SMTP id 5b1f17b1804b1-47a7fcf1a0bmr9909865e9.26.1765280486547; Tue, 09 Dec 2025 03:41:26 -0800 (PST) Received: from localhost (p200300f65f00660846b2ba6e435ad603.dip0.t-ipconnect.de. [2003:f6:5f00:6608:46b2:ba6e:435a:d603]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-42f7d331a4fsm34712660f8f.33.2025.12.09.03.41.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Dec 2025 03:41:26 -0800 (PST) From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Eddie James Cc: Ninad Palsule , linux-fsi@lists.ozlabs.org, Andi Shyti , linux-i2c@vger.kernel.org, openbmc@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 04/13] i2c: fsi: Drop assigning fsi bus Date: Tue, 9 Dec 2025 12:40:28 +0100 Message-ID: <8a36a0dba809d3bfe225627fd178daece10ff6a5.1765279318.git.u.kleine-koenig@baylibre.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=799; i=u.kleine-koenig@baylibre.com; h=from:subject:message-id; bh=YXNtV+Vdnj9V5HmbInqMeie6ojhBt0TgobcWxdMwcl4=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBpOAq9zNegZqa1wjuAOOn4xg/8fl9JG81iUbT8f Tc+6+Zews2JATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCaTgKvQAKCRCPgPtYfRL+ TiICCACH/a6b/DA0OoKBiD1H/ZF6cgKeZWRn9faoWbhmFszSfpE4w5/CavC/ChSDHOFRrzhykfU M2DU3MbnWz1gk59midovBAEfVIHBUEeW/dBnvyL0DYrEQ0bE9C85cNDIjrtq+4P850X6m8sw2p0 g6rjAIXGhQ+fXkfmh7xg7bwEmNC7F1uxetrtJ5zLjGwWyxCxOz331plNdoArKoiP7JuJw9vMadO lC1tarO9a6AmpZ5qbVR2xZ3XpID0/5On/vj3peRrmZLaIXX+wDYv8I5PS0YWuuiBwBq8gYu+V1T Py8Bsrb5maxD4KeVfAVLstDv92Gs4SWIdOCqmnoYMpKYM9se X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable Since commit FIXME ("fsi: Assign driver's bus in fsi_driver_register()") module_fsi_driver() cares about assigning the driver's bus member. Drop the explicit driver specific assignment. Signed-off-by: Uwe Kleine-K=C3=B6nig Reviewed-by: Andi Shyti --- drivers/i2c/busses/i2c-fsi.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-fsi.c b/drivers/i2c/busses/i2c-fsi.c index ae016a9431da..e98dd5dcac0f 100644 --- a/drivers/i2c/busses/i2c-fsi.c +++ b/drivers/i2c/busses/i2c-fsi.c @@ -763,7 +763,6 @@ static struct fsi_driver fsi_i2c_driver =3D { .id_table =3D fsi_i2c_ids, .drv =3D { .name =3D "i2c-fsi", - .bus =3D &fsi_bus_type, .probe =3D fsi_i2c_probe, .remove =3D fsi_i2c_remove, }, --=20 2.47.3 From nobody Fri Dec 19 09:43:05 2025 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BDE3D2EBDE0 for ; Tue, 9 Dec 2025 11:41:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765280491; cv=none; b=DgRMW1/m9u7dRZu11iyKHiQQHqyF33Poburmt+x7Bl0I3+xUETnKbyp0B4gOFZtJ2GHm+bwb2xPvnvTPzut0jTZo3CsDT6r49Gx1uxtgK/0K/g1/QolWcuxnwyjCcAzoLzT7HUSsSkMcEDoe0iZZOWbjCYyzGQ2Bhs4cEEaAMQ4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765280491; c=relaxed/simple; bh=dHhpHyfcU9fEFwxJNNEciJRyq/D4zCBHU1vVA3bGDlI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=D/rU8IgI9fsfBHlfvAfGwhySuAIFECcFKCL82Djh3IziO2yZ3DVkY5mICmUYPGf1esahtR+WvwkZG2UpWrHY6HaVDojZAGUilZuKDW/TfvS+7N1iBCdNZD4quhII2tYbREQjfvHDJP7DKDOz6bh3iDqvLYcTywpQgGSVMCSWUCs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=JIOrMyOf; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="JIOrMyOf" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-4779a4fc95aso40531985e9.1 for ; Tue, 09 Dec 2025 03:41:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1765280488; x=1765885288; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=B+4bfZ/t4/ENkJ2A9KCN8Mdc4bBDCO1QqKBV9qPPq/Q=; b=JIOrMyOfQlHGnYM973w8JfMAyxml/jvJVRzCVbzWd08JLj9JeCTvUUBw+VkXyDc0gu MWE3kySWwhXoi/RpodYP2i3OCLBdyuBCUqGrsBfykg8hVsyFvZ5uasrA4sQYmwvQ/w+F /4hun3bU7VC92+DVAS4aNU/8vkZTcyDTepkTtSMoQqIhLDGkSFOGaeQtkQdw3fGpXIti 9VnP9DJtyJ9+Rt3xsprk/Sg5MQ7an7k1mtSOpInNT8xyrke8zGMq//lmBh3PTsy22EiF I1+fr+hYppOHn3VW0RhZlDeYQoUdj7R21R/w1lzLgmv89arKe4bag/epKgS2yWIdVQKP pKEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765280488; x=1765885288; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=B+4bfZ/t4/ENkJ2A9KCN8Mdc4bBDCO1QqKBV9qPPq/Q=; b=YEHIg/8u/gsUXn7MP+dE1Trh9akeQo4wWSt2MktBTo/7fbM/NdRf9kvyHz/kEA2VhI ATctBI3UtJdf4o7/dmF69L1pcqibMt76zdenYDOf94jcbh+TjpPiEXm8vECnvFXuitdc ofU7c5AN7WJ/DmbtvXO4EalXIXmDps+lQRvtNKVfxkXSqdBYMOOz/ZkI4HcP60vTb50u +sJ6wGq/DZnwy8necdCMlv9m7QUEF3cwV0mLXV6T8xhaG0v6aeLvsLO+d2b5yX4nezUO U77PrvAiAtsGyQDs395BG3c/Zkt1YEKOhqJ8GxQ+TinRzdmbZNKIzhwwDKK06q5KMyTN j9ew== X-Forwarded-Encrypted: i=1; AJvYcCWglB+8DJ0Jb/ZUOkTo3rHH1pjcl/fr6yEvOANt1U0emoqB3Yp5s6X8AAYNnMZdOuvXtXuMYRXiJhQK1Mk=@vger.kernel.org X-Gm-Message-State: AOJu0YzSvchTaK3lwG2oPwj4RNlCGd5LXtWgXzE+xQXiRhfRWfIsi8NR MjY+zCz8rCuA8dX2uj0BeVKXMNOIZqSrzDM7PNA46JLi6B1CAFl/qJ3JsYUkrFu3x14= X-Gm-Gg: ASbGncuqzJnAFtCgG3GEm8yUHnw64zEcOV1rwEt6/l0OGSbwX/23ULAQGIbddPTqMBC X9aihcdQQK6JaOPYmlMA0Der4FBuumFIVL4FNTj+Ug9OQMaMag4F2i+Li8nRe5x6UwKEUxwKxra Gojj4pbR/GJftPDBE6AH+NhRyfxHlMBgfQSMsOGO7UPysmsvQ0lA0vW3l0d4ufVEU86yRaGu3DE 1MrV3pTwGApndXj4P/ErMO9Ke5kDhQbGkAf99UingkUiWyuF1XCSHDjlwxQ2aIWNMU4/WA9ZT6U tRFQbsSyb6dl34xMaz1dIvJF4S8/VqwYvV8WCRzcbhATQZESsbxmdUlcjvnLFciOfT/mxWV+rmX TcQkKlqJliPJEPw7hQU8dfEm3wlZ+k+3h62kaZ18otErYi3tSICTUVYmqJaJnbv+KVDWX7790J8 mS/Hn4ppWCqYpy8g0PDhHiC5Pxsn3IFct+ka6lF7OAudqirLwKQPLY0ev1vKbbqWIQ2b3X2vsdH xg= X-Google-Smtp-Source: AGHT+IGXKHe4veBZ6hDBMR9TFxZYdUh5ntT4MOWKuDihIG9Z6MljyZmo6GAc9/XdLms9sUyJ5c8wsg== X-Received: by 2002:a05:600c:888e:b0:479:3a8e:c85c with SMTP id 5b1f17b1804b1-47a7f969677mr10498795e9.18.1765280488094; Tue, 09 Dec 2025 03:41:28 -0800 (PST) Received: from localhost (p200300f65f00660846b2ba6e435ad603.dip0.t-ipconnect.de. [2003:f6:5f00:6608:46b2:ba6e:435a:d603]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-47a7d6eb296sm34104485e9.1.2025.12.09.03.41.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Dec 2025 03:41:27 -0800 (PST) From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Eddie James Cc: Ninad Palsule , linux-fsi@lists.ozlabs.org, Mark Brown , linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 05/13] spi: fsi: Drop assigning fsi bus Date: Tue, 9 Dec 2025 12:40:29 +0100 Message-ID: <279e26a6740f10d119be7ea01d4af596309b3bb4.1765279318.git.u.kleine-koenig@baylibre.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=733; i=u.kleine-koenig@baylibre.com; h=from:subject:message-id; bh=dHhpHyfcU9fEFwxJNNEciJRyq/D4zCBHU1vVA3bGDlI=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBpOAq/VmEHZ2+rH0Ld4JW6VqPHrFOtsac4G2FHq F3/b1x1QCuJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCaTgKvwAKCRCPgPtYfRL+ TsBmB/9+vmwSapgwy4aosTlt270eN1BEiVoJZBP9VSnWe1xy/yV+p6/PEmHf60I6BK1L9VOOzIa cq6DyP5qabYozHPOByCeUNPBSH1LtNDLDyaT4IYCI/Ot+T+zTqu2QcRpBgkgaoknGKSdYAAVaWE pVfVtHxK1VE1hrkS/++IWrgYkCVl90DPOQpMtMjG9qCJi20O2EhGeufm07UHrv/WnNqElLxkjbg GYN1zb2a/zUInkcwB6wU4jHu5VDfzKjG5XVE6/Q7N9RKYGsQYSiKAE5rMVSZRWL/tyxejVO2svX 3KHc5b6fS9dc24vioIIPWlGdhuFi8zmoMf+a9hrg4wBAaqkM X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable Since commit FIXME ("fsi: Assign driver's bus in fsi_driver_register()") module_fsi_driver() cares about assigning the driver's bus member. Drop the explicit driver specific assignment. Signed-off-by: Uwe Kleine-K=C3=B6nig Acked-by: Mark Brown --- drivers/spi/spi-fsi.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/spi/spi-fsi.c b/drivers/spi/spi-fsi.c index e01c63d23b64..f9c15b99dba5 100644 --- a/drivers/spi/spi-fsi.c +++ b/drivers/spi/spi-fsi.c @@ -595,7 +595,6 @@ static struct fsi_driver fsi_spi_driver =3D { .id_table =3D fsi_spi_ids, .drv =3D { .name =3D "spi-fsi", - .bus =3D &fsi_bus_type, .probe =3D fsi_spi_probe, }, }; --=20 2.47.3 From nobody Fri Dec 19 09:43:05 2025 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 731112F60A4 for ; Tue, 9 Dec 2025 11:41:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765280493; cv=none; b=F65W3hMe5avWgANKyQNUWsvjkzscjKO++swN1oKJ68vqQ6BKU1gwU8EsejmrovAEEJohUgUEBtBkUx6e8nuREI27zaHk/v3WFHBpDw0qNAiMGCUiBXJL6tRMOmSIUvgoxvm2K4FnjaJm2/FdQvEJ++aIpiInGmw4cWtZ7G7oye0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765280493; c=relaxed/simple; bh=kDKWmaDyk940it9Am6kUIJ9K+r0D1G/IO6T4V2FGKmE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=CR7bEhTIcqtEEXOQJhRBrbumBUYgwWg+DTuDUWoCiy/6d2XUnzS0G9KtFf2wPY8UKdNFHRoJ4PpmkCVDvPTo17FCxuKiZIHTmoyXXi4Jhg3KOHPfFcnQzZ7SvlzJuxVIMlr5A79QSmp58ww+r02xp4ypNggBUN/9059t6m4xK7I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=GdYiXhBD; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="GdYiXhBD" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-42f762198cbso3575603f8f.3 for ; Tue, 09 Dec 2025 03:41:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1765280490; x=1765885290; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HIwjyOA1JxVccQqRxG8W1vQfz0CfbpI3YL/o7YqIcdE=; b=GdYiXhBD9WDEhix0Avhbv7D0E9gQ879NxpodbK21gbRT4KHRGtRM+D2IVjw+0X4Jy/ ZINGip+m7ewD2RzaAkEy4nwHReNvuMpuevNFSCYbR5VoVxcC6maJLFh+zgr3EwJFMY9L GxEHMQtOu8HE0eKKLonhfXRU511BmDf1zE6NwoUY7FwhCAvxnhF7Kxj2/6bpiJH2o7Yo GOz4ermQBINSNYmyFGUgjacj87Mom7ztujhBCqrWyIjvlasKKSyWzCPPccShsotLZGSw rv8/3sIBO4YpuSye05my5H+mFutf4rZoYD+CgmzTxfO39MUIj0ufqqAZGzS4QfOY6fly pPpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765280490; x=1765885290; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=HIwjyOA1JxVccQqRxG8W1vQfz0CfbpI3YL/o7YqIcdE=; b=qyzWgLdNpETtNYjJPYYc0+mx2oMzsml+8dtHM17Yi+nk9qJDotSPz9TprTRFFFqG+o BktJ33pgXvZf9e5urirz2D8fm/6BCczNTEHlEQ7hXrixDAPgNDjG2B/JHUQYEuBGGclL gDNCNnRq62KceTWxaelVUpEtml2bRJKGEJRpmKhWj9c/zI0O/705IVxHWwOdI0AhVMyr CRRqi2tyXodl5wffVlFAEjy8H4XoYYYLU3wFKx783rbThclqZt81v1hq/9EWO+9p/08i bqhyKLkrnYlqfdkYujiOFPSKPaBNm2OuFWuIOsSIKEQW27hde2HlWzegVpK6NXgdVUIT orRg== X-Forwarded-Encrypted: i=1; AJvYcCXSDr3Hjr1DWDBBMfq81OnMpuj33UPFTFqwRCNp3vs5OuxBWmrD2o36I9iPAyuK3pTGJaTL94LgiKnEDIo=@vger.kernel.org X-Gm-Message-State: AOJu0YycjH68DLXQP8hIicv+CYSGij40kcEv+0BQflH/DmFmVW908/qq XYIh3bMo3leLWwcliRjQBTU7sIoOSIc3/7n9B24KRQJlVAYlBCo/r3ACbZq6qz369dc= X-Gm-Gg: ASbGnctLLWL/J8tNYjkK5xzbr4DCFRQKPYilwZr+JUej+SRSMhqgTm7KEEGcKbqCWpY 73whbzXM+GpqS7v7PRqqlikGLSepExW7DyzeaiKX4wyobRp5cXrcObkhdPEhFwhbRhzIE+gbjkA og6qVT+CPiXAXk+b3OEMTs9X3FD6xSD2GAWdBAoksrq5yADaCQE1fN+KirtQpK7D7ODlC9HkiRS xeYnbzVcBt4T9lAjEnahvS0VKUW8nc6XrU764OrQyXPA8BuAjWoMbXT4QlFRkRn2pW/Xo4k2WXF tvB6GuNiqytyPKrN5pBlTgXTyytYsF4DB75Sgh6J9Fcx+Fk+UMOmGufff5/NUP24iS8S1c+My4C AW1M2EEkvazb+LPVIB1CI7aVzzvbiYIOjPPej6jMdXl7hcbJjeBk7kmhhi0XMljAUX9O+kfF61p NbnG04Fc/2HjSu7c95vhRuMQ8UO5kMvOXvtQ2Aie/UFw76BQBgyVozoN1FXYJM4Ag3gXjvEW/MR NU= X-Google-Smtp-Source: AGHT+IEwHSdo+Ic7opultYftPU3t2iGUu/G+4AQ+j2D3YrxFwywS2Yy5d282AZgzKfE6IWafc3jrYA== X-Received: by 2002:a05:6000:2502:b0:42b:3220:93e8 with SMTP id ffacd0b85a97d-42f89f58c88mr11443528f8f.57.1765280489662; Tue, 09 Dec 2025 03:41:29 -0800 (PST) Received: from localhost (p200300f65f00660846b2ba6e435ad603.dip0.t-ipconnect.de. [2003:f6:5f00:6608:46b2:ba6e:435a:d603]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-42f9f5ab46csm3326299f8f.19.2025.12.09.03.41.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Dec 2025 03:41:29 -0800 (PST) From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Eddie James Cc: Ninad Palsule , linux-fsi@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 06/13] fsi: Make fsi_bus_type a private variable to the core Date: Tue, 9 Dec 2025 12:40:30 +0100 Message-ID: X-Mailer: git-send-email 2.47.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=3496; i=u.kleine-koenig@baylibre.com; h=from:subject:message-id; bh=kDKWmaDyk940it9Am6kUIJ9K+r0D1G/IO6T4V2FGKmE=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBpOArCtWbXEdVtRIYdPDckWG/HrlRcvfBOmqkoG JyBZl5HgJWJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCaTgKwgAKCRCPgPtYfRL+ ThymB/wKG5LIVXuZwe4pYLANqAH2zDcVHIIplSEfvtnLOBQrwl6lKEkYJzfHWJjhywTjO+WglOq FEiiaia7wGgIUAcq6C84XPf8syoFUNNME6LJ583uuXkGm+kH2HjFlLoQnziLmQm4CXCQpRoDguJ 5Cgo6hmKE3Lt5RPhpDzd4msHhd3+lS1Yire/ZfCKyvzCvcNSew7JFAMIGpyPmNFNt5Gdmfh4fk4 nXHflSWAUMuI0oIuVn4JRoBBEODyl44wTk9xypodWhtvTJuOK9fR0tB/Dnfpq4d+mKY2Vj4TP5Q IshO8ayHyqpDfrIYHUESIvU096ghIsfcWZi4qJEAlV/4uiXg X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable There are no users of fsi_bus_type outside of fsi-core.c, so make that variable static, don't export it and drop the declaration from the public header file. As there is a usage of fsi_bus_type in fsi_create_device() the definition of that variable must happen further up in the file to not have to add a local declaration. Signed-off-by: Uwe Kleine-K=C3=B6nig --- drivers/fsi/fsi-core.c | 67 +++++++++++++++++++++--------------------- include/linux/fsi.h | 1 - 2 files changed, 33 insertions(+), 35 deletions(-) diff --git a/drivers/fsi/fsi-core.c b/drivers/fsi/fsi-core.c index e1ea1124282e..4e60d4b17c11 100644 --- a/drivers/fsi/fsi-core.c +++ b/drivers/fsi/fsi-core.c @@ -100,6 +100,39 @@ static int fsi_master_write(struct fsi_master *master,= int link, uint8_t slave_id, uint32_t addr, const void *val, size_t size); static int fsi_master_break(struct fsi_master *master, int link); =20 +/* FSI core & Linux bus type definitions */ + +static int fsi_bus_match(struct device *dev, const struct device_driver *d= rv) +{ + struct fsi_device *fsi_dev =3D to_fsi_dev(dev); + const struct fsi_driver *fsi_drv =3D to_fsi_drv(drv); + const struct fsi_device_id *id; + + if (!fsi_drv->id_table) + return 0; + + for (id =3D fsi_drv->id_table; id->engine_type; id++) { + if (id->engine_type !=3D fsi_dev->engine_type) + continue; + if (id->version =3D=3D FSI_VERSION_ANY || + id->version =3D=3D fsi_dev->version) { + if (drv->of_match_table) { + if (of_driver_match_device(dev, drv)) + return 1; + } else { + return 1; + } + } + } + + return 0; +} + +static const struct bus_type fsi_bus_type =3D { + .name =3D "fsi", + .match =3D fsi_bus_match, +}; + /* * fsi_device_read() / fsi_device_write() / fsi_device_peek() * @@ -1359,34 +1392,6 @@ void fsi_master_unregister(struct fsi_master *master) } EXPORT_SYMBOL_GPL(fsi_master_unregister); =20 -/* FSI core & Linux bus type definitions */ - -static int fsi_bus_match(struct device *dev, const struct device_driver *d= rv) -{ - struct fsi_device *fsi_dev =3D to_fsi_dev(dev); - const struct fsi_driver *fsi_drv =3D to_fsi_drv(drv); - const struct fsi_device_id *id; - - if (!fsi_drv->id_table) - return 0; - - for (id =3D fsi_drv->id_table; id->engine_type; id++) { - if (id->engine_type !=3D fsi_dev->engine_type) - continue; - if (id->version =3D=3D FSI_VERSION_ANY || - id->version =3D=3D fsi_dev->version) { - if (drv->of_match_table) { - if (of_driver_match_device(dev, drv)) - return 1; - } else { - return 1; - } - } - } - - return 0; -} - int fsi_driver_register(struct fsi_driver *fsi_drv) { if (!fsi_drv) @@ -1406,12 +1411,6 @@ void fsi_driver_unregister(struct fsi_driver *fsi_dr= v) } EXPORT_SYMBOL_GPL(fsi_driver_unregister); =20 -const struct bus_type fsi_bus_type =3D { - .name =3D "fsi", - .match =3D fsi_bus_match, -}; -EXPORT_SYMBOL_GPL(fsi_bus_type); - static int __init fsi_init(void) { int rc; diff --git a/include/linux/fsi.h b/include/linux/fsi.h index 05be75869a69..3e3a8f3adac3 100644 --- a/include/linux/fsi.h +++ b/include/linux/fsi.h @@ -78,7 +78,6 @@ extern int fsi_slave_read(struct fsi_slave *slave, uint32= _t addr, extern int fsi_slave_write(struct fsi_slave *slave, uint32_t addr, const void *val, size_t size); =20 -extern const struct bus_type fsi_bus_type; extern const struct device_type fsi_cdev_type; =20 enum fsi_dev_type { --=20 2.47.3 From nobody Fri Dec 19 09:43:05 2025 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7AD342FD1B0 for ; Tue, 9 Dec 2025 11:41:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765280496; cv=none; b=JErqAzR7IzH1p52M2r+6J1eE2OHLvNNWUu/+AJvD1igOYlIm1W1KsJmaioyz+J/9KOBlkriPrQDH1vibzYBJYSdLp+HY7U2ttuXkAt/z2oJjxvKREqcTAfarDfzEmXBYcfh+XNjZ5Ze+Q6Om0tgfCIi0lbe1esySaZvw0oxX4uM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765280496; c=relaxed/simple; bh=Q+zxnfnQdryvVJp99STbQXDRvJzA78lU1qjQYV0jJ0U=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=FR6cmBo5e3bkn8mXPYMzcLLr5oju5pXk2B4wfqou73Oub9JmYRUFtyjEhGCE9zGiLJrVCgG4brkGKqcNrnpEXT6W2B+Fv1wR9gornAu57KSx6/CyMAvxX6uRnhuZQdGPa3vDrUHch4CsjOjrFhC798PcwGNgUS7giriDipAIEwI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=Ihl4IVMA; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="Ihl4IVMA" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-47775fb6c56so47485125e9.1 for ; Tue, 09 Dec 2025 03:41:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1765280492; x=1765885292; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=s02EFpzfO9VS5EuZvl9knv4EQQswePSsPBSNV1lnBQc=; b=Ihl4IVMAmTop72HVTiYjhhYcBBSnirIE74+/1DDx+DWkXkO3uUjIMIZJCBBJkWSzxX ePX86dWDLmbNGazZyhQgIlqG2vu1556ed+657tr0Z37FxDGnnMo6jf11tyS5r+L2HyK0 LmlzWJuo5Hr6zXsuXzWcGzuCtuDH0Udqa6Q8MMwvl2UX5YBtlJ4ojFjL1LvxjTPX2m2G coCJXLBgrAfzfJdVYv11KS6XM3symfxNMpXM/wZC0o9Wpmto7mFIIYcB+jdMnpCDeTHf oMPdGNt+AdvW2ei+NYPU/ZAEIZBv+8xWxu2LYxzogQWFVLdHFfheVgLVgZUC9egwL9Ed OSgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765280492; x=1765885292; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=s02EFpzfO9VS5EuZvl9knv4EQQswePSsPBSNV1lnBQc=; b=fsG/eihxBnBg0Xo51ei0o6pM5f9qMjVBNkcuAoVNADYWwfXAnQv+BgUw7a2IMk5rD6 5NJaWGL/OOgoraksQDCLB0cilYx68RG/0TX9d6fZ5dRh4UFbIhVnFiJGI9MzNeiZAxle e0T1ADCP3pnwLl+tBN87QepxqpoS0MQeIJFc+Vb8wwFB+EnxG/fkTKOsIuX30knwxaGO e43d06na88wYK3P2XbH3MA54eAqGmXz8Mvv0GTX/kUeIyaYRY4anSZR3Gmjwldhvxi/M augEP+I7VXQtn/5nlaJEl+bhr82bna/sxJdV3fQNi24NMkRdIXEc5ArBHbLsdLL1CgC+ bhIw== X-Forwarded-Encrypted: i=1; AJvYcCWWlxjr386g87jLJ0aPVCPCgo1oomWZT7uy0L0rjNnzUWbtlbPO2vuqcgkiblglGfYPBQRO77MmY6ApOOQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzZGjj2TmgCYoG0AlkAjSCq58oFccu1R4ofBzkkPHmHYUHtQZhe h09Z4s9HOWytpYSfk4K04oVCazYciDqdrjZZuS4IBXt1SKf+ws4mMWDrAjC8Z4VTV/k= X-Gm-Gg: ASbGncs+xrj+et5ppPGZDlXPEshZRu8TFF6G6dYNINBuj3ZO7A8Ys2YYJIShVDKgjhH 2q8i2lBllDilAdba0r4f4o4Fxci4EfQCjZ1A/zJioU3z81f5fqCsLIAvKPORV6LVvH51m/TT/l4 LQrPmrROBVcgcI2QSbi/rqiQhyLeORPnfSC6b+95c0fU9Y4Vei5yPI/f+3nuL6wXHLnUsSmmof7 R+LwvTvdO3kdCTeinfyxTUB5MnxDJJmLXy3DkSMqJb+ev6pC5D1mskPI0pfi9TciJqQ1boZggfo ceFlWzbwuTKjVo6HLrskRwNng9kThTAw+8ase5T5ydSvNzBUf7GcBf7XJC1y0Gk5q2bVBwm7RZu 01Wfj2qzHG/BcA06hdOQ9mWcprlds5zkXVuIcpQP9JYbPBHG6JO49jG6ssZikEIoQE19sgPK5Ov GIdZ8vhHqqinsYAqxfYJuqdq2Xh6rerPrpJbD4/Cg6zEKmxqdZKx3emNPY5r1nYWA5FsGp46SGZ lY= X-Google-Smtp-Source: AGHT+IGwqE7G2KIX1IqnauprWiO6Shquq9u0Dw78y4OpiNAm0lc+6m0JqxsCb1QwpwWXH4q8QF1xdA== X-Received: by 2002:a05:600c:37c6:b0:477:5c45:8100 with SMTP id 5b1f17b1804b1-47939e2b584mr138637135e9.24.1765280491759; Tue, 09 Dec 2025 03:41:31 -0800 (PST) Received: from localhost (p200300f65f00660846b2ba6e435ad603.dip0.t-ipconnect.de. [2003:f6:5f00:6608:46b2:ba6e:435a:d603]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-47a7d70fa07sm35685325e9.11.2025.12.09.03.41.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Dec 2025 03:41:31 -0800 (PST) From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Eddie James Cc: Ninad Palsule , linux-fsi@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 07/13] fsi: Create bus specific probe and remove functions Date: Tue, 9 Dec 2025 12:40:31 +0100 Message-ID: <3b53adb75a5ae7894736d46cb6eb85f5ef36520e.1765279318.git.u.kleine-koenig@baylibre.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=3323; i=u.kleine-koenig@baylibre.com; h=from:subject:message-id; bh=Q+zxnfnQdryvVJp99STbQXDRvJzA78lU1qjQYV0jJ0U=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBpOArFB6UuGooggE8cKx4BVehfzmWZa+/qN32mP lIERsXcQJiJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCaTgKxQAKCRCPgPtYfRL+ TntwCAChCVz7WkZIjYLcXNPaatIOIOTHS9mAkmxtLPQCVQ6NTzN4hPyBeagR7lMcspuqTaIjIRM E9SMfmR7cvriPyDlRXYKTcwGov1CfAfqMMhfyvb3Cu1I7Di+7V8vCv/qsRc+GdUj1p23DLEOLDU yecll886YK0ENdNVls0+nfDPrcF9vHyr1zPQ5SyyJgpvxIORxwbtCzCeRT0C1j/FT7MhNX51tYz EmnmwXXmbNZMA7ho592HjOy/j+m6N0ovLcJmApbNeA5JN1EVqdVyWkgf79uJPnmsPV0J/bpmBtc Oj8XuPZf6lKQENh9IHOZApd0D/m5zYSXECSL1Eh/515ofCPq X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable Introduce a bus specific probe and remove function. For now this only allows to get rid of a cast of the generic device to an fsi device in the drivers and changes the remove prototype to return void---a non-zero return value is ignored anyhow. The objective is to get rid of users of struct device callbacks .probe(), .remove() and .shutdown() to eventually remove these. Until all fsi drivers are converted this results in a runtime warning about the drivers needing an update because there is a bus probe function and a driver probe function. Signed-off-by: Uwe Kleine-K=C3=B6nig --- drivers/fsi/fsi-core.c | 50 ++++++++++++++++++++++++++++++++++++++++++ include/linux/fsi.h | 2 ++ 2 files changed, 52 insertions(+) diff --git a/drivers/fsi/fsi-core.c b/drivers/fsi/fsi-core.c index 4e60d4b17c11..83599a1c548b 100644 --- a/drivers/fsi/fsi-core.c +++ b/drivers/fsi/fsi-core.c @@ -128,9 +128,31 @@ static int fsi_bus_match(struct device *dev, const str= uct device_driver *drv) return 0; } =20 +static int fsi_probe(struct device *dev) +{ + struct fsi_device *fsidev =3D to_fsi_dev(dev); + struct fsi_driver *fsidrv =3D to_fsi_drv(dev->driver); + + if (fsidrv->probe) + return fsidrv->probe(fsidev); + else + return 0; +} + +static void fsi_remove(struct device *dev) +{ + struct fsi_device *fsidev =3D to_fsi_dev(dev); + struct fsi_driver *fsidrv =3D to_fsi_drv(dev->driver); + + if (fsidrv->remove) + fsidrv->remove(fsidev); +} + static const struct bus_type fsi_bus_type =3D { .name =3D "fsi", .match =3D fsi_bus_match, + .probe =3D fsi_probe, + .remove =3D fsi_remove, }; =20 /* @@ -1392,6 +1414,25 @@ void fsi_master_unregister(struct fsi_master *master) } EXPORT_SYMBOL_GPL(fsi_master_unregister); =20 +static int fsi_legacy_probe(struct fsi_device *fsidev) +{ + struct device *dev =3D &fsidev->dev; + struct device_driver *driver =3D dev->driver; + + return driver->probe(dev); +} + +static void fsi_legacy_remove(struct fsi_device *fsidev) +{ + struct device *dev =3D &fsidev->dev; + struct device_driver *driver =3D dev->driver; + int ret; + + ret =3D driver->remove(dev); + if (unlikely(ret)) + dev_warn(dev, "Ignoring return value of remove callback (%pe)\n", ERR_PT= R(ret)); +} + int fsi_driver_register(struct fsi_driver *fsi_drv) { if (!fsi_drv) @@ -1401,6 +1442,15 @@ int fsi_driver_register(struct fsi_driver *fsi_drv) =20 fsi_drv->drv.bus =3D &fsi_bus_type; =20 + /* + * This driver needs updating. Note that driver_register() warns about + * this, so we're not adding another warning here. + */ + if (!fsi_drv->probe && fsi_drv->drv.probe) + fsi_drv->probe =3D fsi_legacy_probe; + if (!fsi_drv->remove && fsi_drv->drv.remove) + fsi_drv->remove =3D fsi_legacy_remove; + return driver_register(&fsi_drv->drv); } EXPORT_SYMBOL_GPL(fsi_driver_register); diff --git a/include/linux/fsi.h b/include/linux/fsi.h index 3e3a8f3adac3..9c67c43f9e6c 100644 --- a/include/linux/fsi.h +++ b/include/linux/fsi.h @@ -49,6 +49,8 @@ struct fsi_device_id { .engine_type =3D (t), .version =3D (v), =20 struct fsi_driver { + int (*probe)(struct fsi_device *fsidev); + void (*remove)(struct fsi_device *fsidev); struct device_driver drv; const struct fsi_device_id *id_table; }; --=20 2.47.3 From nobody Fri Dec 19 09:43:05 2025 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 285CB2EB87C for ; Tue, 9 Dec 2025 11:41:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765280497; cv=none; b=sU1bzX7V6U8PcoCkQOEvp1I7OTUuTq3mYspe0ZNl/XM226l2hLLTDRHwCRkHBg/BG0kcsopGE6S9f9gE9VF2I3l8IJUYblmN2GpMhDVSAzIVVm4uQso1QQoWXa9iZnBO9X0JOcn/Qie6StD/N0wueGN3bI4hmtSo0KTtgZX81MY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765280497; c=relaxed/simple; bh=+m0ykDOyaZxJ2zqx2DElztRjz119toksPQt+bZla/Es=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=GJ/YCiuEGmHruS2+eZLRqQyVASnTNry6P/SdS7f2ldHjbG6IJHHsYsimkA/v5V++2lHMuP7HbfrWNF4UmSjpU7mZXpk2lbl2Cz2F0zjdxV41473XO7COzZ8yMxNZuOwRjKPN9Blf7aEAMexwRe4Pm/MxbIfjoS6gE/lPYSyT9QA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=AmagyqmV; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="AmagyqmV" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-4779cb0a33fso72881115e9.0 for ; Tue, 09 Dec 2025 03:41:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1765280493; x=1765885293; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HLU2mjDHhvzcMFDyNaKELE1mAV0FFc7jlz9buqvil9k=; b=AmagyqmV7qIMp49zA/aqBPZ1mN6HrsLCQ0x2o7TewuRfaILbDCJJtpBU4aO34ytZQC OEUIBLtLSmSAq9+KVTc/Fg3APuHT927PFCO0EWL/NKHILlbFjd9SBAYOlEaPdIo1veml etEuGZi1+jdfrdXI7bxxEzsvkw92TiOcRzq7oDw6G4KfK4KzzVOwDvj4wt393n866tIc 3zE6q9tVa4bFIVrqEN/u4ejBGhQkSWPy71jLLpEmK49BsEn6piHnY6T3/mh4LoGeWZWd vGnRYkDI/usOiHSGQMiLP+VPvaGAP8IBkotjN5qfhlDhmp30xfWpLojoz004Th8ruH4W M1ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765280493; x=1765885293; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=HLU2mjDHhvzcMFDyNaKELE1mAV0FFc7jlz9buqvil9k=; b=PAa2hVtWB5Q9KnkMMcuHpBdEUxLaK5oxeWJlhBOyeQhmV0fmMi9aax7qMGO7gWCKgV qgcbdljHv56sYsoBjs5m9J2DyjLDTpmw+ExwokBR4Xo21JHD3Empz3/kqlXnkZEpfB8V ZUCk7zMNbIPw+CsOic6co8ZCPDa6ttxbmicrx8XNISojKLjba3snpKK6UlFSnshuJB2N ljbyO6CA7Cq6dlj9qlxPVOA1fvBbgnJ+nWi+hkkwb/bqp6CHtcRZHkPRIQsWUR8Mq4u8 cgNdXoyAwVTV2jzug+r8BGKqlzHuFukyr4YZSJOJ4OBFHVTmQADRtA+X1LQ5+l7u6JDK 2hig== X-Forwarded-Encrypted: i=1; AJvYcCUhxi/4uy4Jw+lk5vX+7oqczMhUcr2EMNIgqxz9UFiFCAy0oxnFvtntquT2VyKi2NaL3aZ9YPh5fp8IWL8=@vger.kernel.org X-Gm-Message-State: AOJu0YyK/pL4YV5RRN+BI/de8vItZzyQ998kx8nfCLkrdR82sk8cAoqB B/5vn05GHPnevxdWd78a+D9LPIaXnaSLBxK6ZAKEInNoIIyZm4x86X5PCkUrvFrYLZs= X-Gm-Gg: ASbGncsBIG+TjFUxLvK75lDWDTEjoQxdMDh3Ndc8HK3NlhV+9lS/uoZ4GZN1oMG1QAs g3o+fHUFhMyzcpFFXJblmWZgCzwh/CjsFZIAmTgmR5IV0d8ncClJOVVwEkreK4bYgwqSK2pPZBG 6q5jvaM3//+uyE0N4FVnvCreZnjLccWX7cZv4ZeQxEsMHSw4/y3LCd8tGcmLz47Izct6IVm+lBl 4n9roLjAbVAeh4xARWpbvAVri6dgwvGIamuqtAoXEuubEZwxcZUC87uIcoh613R/Lgz4T+oTK6C kunS6sZ6WzD57io4K4zsolrpxUxVc5NatczSxpn/j8RFuxV+f/BxtFRJStNXXPbWEphxH+IKxTm t8EVUVJTyon4OzBKn/FbdjJKAZL5WWO1w7802JbYX3oTx8/alWJFMSWNlEMVhcvwh4aEctYiq7Q 2I5NY0QQ+J/K7K8XM6rWzGtN88qlPcw1c6BdqnZvzO2f9UR8m80eJ35XJHMXnk9hnpFJiYbHzXk 5g= X-Google-Smtp-Source: AGHT+IEwG9dS6lKE4No5zOFVZVdssGz9HQb9HYvh2l7XL1TN2XOk4z3VeSDVC5AkhHmM+B4jrXIl5A== X-Received: by 2002:a05:600c:a013:b0:477:9ce2:a0d8 with SMTP id 5b1f17b1804b1-47939c8bc7dmr123986565e9.0.1765280493523; Tue, 09 Dec 2025 03:41:33 -0800 (PST) Received: from localhost (p200300f65f00660846b2ba6e435ad603.dip0.t-ipconnect.de. [2003:f6:5f00:6608:46b2:ba6e:435a:d603]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-47a7d68abcesm35047025e9.11.2025.12.09.03.41.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Dec 2025 03:41:32 -0800 (PST) From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Eddie James Cc: Ninad Palsule , linux-fsi@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 08/13] fsi: i2cr-scom: Convert to fsi bus probe mechanism Date: Tue, 9 Dec 2025 12:40:32 +0100 Message-ID: <694a7d077316c3e2883a8410eade67cd578ee556.1765279318.git.u.kleine-koenig@baylibre.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1732; i=u.kleine-koenig@baylibre.com; h=from:subject:message-id; bh=+m0ykDOyaZxJ2zqx2DElztRjz119toksPQt+bZla/Es=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBpOArHGSsJfuCUAFO/bBCwhkxJmUJ3evjYTkJUC 72ZmGrMkjeJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCaTgKxwAKCRCPgPtYfRL+ Tn6xB/9vSNuOO02zH5BIY+WmQv6zP7KhzUgM0eBaXArk19pmHCPEDjmbWN27SZ7VWdqMBGERmyP 4BuxaY+RxDHLtdfPfCuQhW4X5rQplh+uuhUJVlwuVdifxxRUZ/xHik1tCC1oQx3SLfAzpZuCojI dAaLSzde+EJ7n0cMUjtOl+xaXKkKJpAtt6i7iGz8gWDUcitfhhODUoznhGBSnYiyYzcGmPlt8K3 1Rz4E19v6f/720FaD1CQ/1TQMBvnyvG72R6FScOAOix7cu8nz5f6vXtV1taPx6c0EBsYEJsoa1n ErvjvaD9X5KLfsA7O/9pUSJ/6heQS9bEBVakXH75uce7uOqy X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable The fsi bus got a dedicated probe and remove callback. Make use of them. This fixes a runtime warning about the driver needing to be converted to the bus methods. Signed-off-by: Uwe Kleine-K=C3=B6nig --- drivers/fsi/i2cr-scom.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/fsi/i2cr-scom.c b/drivers/fsi/i2cr-scom.c index dfdb16afd205..3efca2e944bb 100644 --- a/drivers/fsi/i2cr-scom.c +++ b/drivers/fsi/i2cr-scom.c @@ -81,9 +81,9 @@ static const struct file_operations i2cr_scom_fops =3D { .write =3D i2cr_scom_write, }; =20 -static int i2cr_scom_probe(struct device *dev) +static int i2cr_scom_probe(struct fsi_device *fsi_dev) { - struct fsi_device *fsi_dev =3D to_fsi_dev(dev); + struct device *dev =3D &fsi_dev->dev; struct i2cr_scom *scom; int didx; int ret; @@ -115,14 +115,12 @@ static int i2cr_scom_probe(struct device *dev) return ret; } =20 -static int i2cr_scom_remove(struct device *dev) +static void i2cr_scom_remove(struct fsi_device *fsi_dev) { - struct i2cr_scom *scom =3D dev_get_drvdata(dev); + struct i2cr_scom *scom =3D dev_get_drvdata(&fsi_dev->dev); =20 cdev_device_del(&scom->cdev, &scom->dev); fsi_free_minor(scom->dev.devt); - - return 0; } =20 static const struct of_device_id i2cr_scom_of_ids[] =3D { @@ -137,12 +135,12 @@ static const struct fsi_device_id i2cr_scom_ids[] =3D= { }; =20 static struct fsi_driver i2cr_scom_driver =3D { + .probe =3D i2cr_scom_probe, + .remove =3D i2cr_scom_remove, .id_table =3D i2cr_scom_ids, .drv =3D { .name =3D "i2cr_scom", .of_match_table =3D i2cr_scom_of_ids, - .probe =3D i2cr_scom_probe, - .remove =3D i2cr_scom_remove, } }; =20 --=20 2.47.3 From nobody Fri Dec 19 09:43:05 2025 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D28BD2F60A4 for ; Tue, 9 Dec 2025 11:41:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765280499; cv=none; b=Y87a5TzleKwpxC3RsaJqw7YLyuraddzJ5wc+ULKJse3n0ki0WZuMaBf0xKmy3mEnQOs37FaFQMACQr3FsddrJpYBPCSV2PiYeaWbfgNgXAFY92R+FlF0xWOSCk1B0Cr0M4TPpnq7STQvzQjJD0dcr2Ro/GPbx7ZLPKJVqwG5P2k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765280499; c=relaxed/simple; bh=pv/oI52Higjb39QCJi+rknwb1EgrVYSVqEXSZszYOB4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=A3XTvg8pU0Xhe3WmbV0asrDM5MpvRa7lHtp22XSFJAcAKK4s73gGZATQGvFTFleyyJY6Gtm+DurdhdGuZGAVgarqN9wOjujbmwqxqc5enNhuspHKto3Gp6UjI+gbkVYW4q48v/WmCyV+ceZYwhQv7+hYKbZ7KN/Gw+sOvHL43cU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=BKuH2vGY; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="BKuH2vGY" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-477b91680f8so61388985e9.0 for ; Tue, 09 Dec 2025 03:41:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1765280496; x=1765885296; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bEipV9vuWJgReUhW4RDw7dJGSFdctd0Ige2m1IpP68A=; b=BKuH2vGY2F0LrXBiBYfAugJLp/d/PLsDZtYmh0FBOWJb2NKVkNb21AK0Ovy6uTmXT2 C9m8y5vIWUSZWgf4C1uhpy2R0LWM9EpZrbriUawl/9MNDqKQIN5JBOn40CyfK+6y6NQn XVa0ovQf3G7WnkNVLKEzud3KMvUl9Chy2JEZukUedNS8MHYM5fXoTAT6z12iUlqICy6Q mcOrH+JnomEkPEalD47KxALVKiVLXll3ZGYXQs40CT4yo3DYYMnI/N/OaWTqfQGE1VGc h9sikXEzJkL0p3iVnGB9X1WU4c8DAemGFuMRhfocxtEX4jOdTfkasYo3+TMJO4cr7wip 3/hA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765280496; x=1765885296; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=bEipV9vuWJgReUhW4RDw7dJGSFdctd0Ige2m1IpP68A=; b=nbYzDe4CbRff5Uw8BKoN0uMIc86StngoCjc7kof5gNtkLVjqFVr1C0HBebh6O3Ex+2 zQ8bJXQTGSS6V3w8ehnAaiLsVM3Us6F68ew3itiyTimM1zITPdKCNKtyTb6j9qjnaXGl jsE6F4yTuEE/5sy90sm7t5UrLjmeKJxm8wTUtF38flXNXGGQeNdxuNV7ZOV0ssdtPsMm /7jkbi/14sUptHtDPIK8NttZ2I00bKU41Xzid7fkLzz0IDolLcE7TQZkQAnXhjMRvppd P6psmeFO1XKdr2qM90NnsiIQOR+1eBoegE1Ud3+ts8/7DUAPYrCI3JroJk5AuNmWLbuG e0mg== X-Forwarded-Encrypted: i=1; AJvYcCUZ54vYgiM1AsLgWwLigVchnwXltGTu3MYYlYFfCYF27aBV51aQu88dGxeftMYz4ozdDHg4beGVplJIb7k=@vger.kernel.org X-Gm-Message-State: AOJu0YwdHYpPmKzPpvhwgGyeW97ap4pJmxANoVObdfH72lo+9UtkgFPK koad18bbVjv5SwLXXVYtEJgYI919Tbg+QTUTFxHxDEm3GqySgHxuna34EFQyhnxZVoAf5S1yoa0 /vnAK X-Gm-Gg: ASbGncv3jW0G+R8ip4Fp2aDCcdes6DO2rCgS5chPAAkhXqopbYXfEu9qbjY+679Raf6 G0+irkkFxjC3v7Lvmtjw+dMOF5+PpPhU/ck4UV6X+CV44ogIlIXMwf9oW9GpvRtTPtREeSMUX2Y BKoYIXAp37grUgQ5I9v2TnLbyhgwGZWeOwB7MLUzbS7db2RYPrioH2YPO+m+aamPamnvLzIcHgn 0KqfF3RR1xPSEvAnkR/bz1rVOF9hSw02ycMXtYcczcBIylZJdwL1+inzY/XnFonhy3UXFsvcRe7 +soEiYIhPdamUHpXPDOhIKBRd051Bbj9P0o5YiF5DlOeB5+yjRz0UqX6r1+faTBXkqQRq5I+clG h65hcNYMVdxKN+bMvqPD8zYCU2jrPVICpDSx6WCYmMkkhxmNPv9iHDfwh9tQwlQ8bJ9zmXeMjfj kzVV9rXWmzHs+Wf+hAZayC4pUPqH3bNi9AXZ+jaPiLqTCpe/Rq9a6dh8C7ilnTjuKnyAd8/PLHn SE= X-Google-Smtp-Source: AGHT+IF8AsIgGjsrqvHpgPBFgnFTtutf8YrVINOgkFmeP3o2pQOgRB1YMEUYc9x+PPTpMmdLp8C8aA== X-Received: by 2002:a05:600c:4ed3:b0:45d:f83b:96aa with SMTP id 5b1f17b1804b1-47939df12f6mr114687315e9.7.1765280496020; Tue, 09 Dec 2025 03:41:36 -0800 (PST) Received: from localhost (p200300f65f00660846b2ba6e435ad603.dip0.t-ipconnect.de. [2003:f6:5f00:6608:46b2:ba6e:435a:d603]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-47a7d70fa07sm35688155e9.11.2025.12.09.03.41.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Dec 2025 03:41:35 -0800 (PST) From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Eddie James Cc: Ninad Palsule , linux-fsi@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 09/13] fsi: master: Convert to fsi bus probe mechanism Date: Tue, 9 Dec 2025 12:40:33 +0100 Message-ID: <17686d71b4ad3f7ebb63e92453273095a5dd09ea.1765279318.git.u.kleine-koenig@baylibre.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=2200; i=u.kleine-koenig@baylibre.com; h=from:subject:message-id; bh=pv/oI52Higjb39QCJi+rknwb1EgrVYSVqEXSZszYOB4=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBpOArKrzelxsrmGSo9mQDWSi0a48SW/y4RatZAm mgNrDF58g2JATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCaTgKygAKCRCPgPtYfRL+ TiXUB/9RkhU0ecPUJNxceqZqmdwjnUKfo/IfWbroSMT5eGcsu1OLqTlsNY2wQtIX+5w8ebaqtH1 6AHwFkddARtnlPEKVHZ6v+T8WTdLJMW4C4RPBarr+mlVZt73eaYc/J3oEqMLamB0UEahPHmez/9 84B9heEQqZ46VV7OftN/B/aB0LlmbMWjvzDHNOGTgAtS4DgM1V3IKVl2rVRj3Ru54Z13BIMGyWp ZpLum0ULluLnb0r267c4Ch5yW7U89aTfjiBu0B2sLkZZnEmVyiiW0BcWPWwTS63+3caZk8xNZ7Y 4N2hF3cCVF4y/BQHDKd6XHIUQtHk3ifONRi397QhD67v0Vug X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable The fsi bus got a dedicated probe function. Make use of that. This fixes a runtime warning about the driver needing to be converted to the bus probe method. Signed-off-by: Uwe Kleine-K=C3=B6nig --- drivers/fsi/fsi-master-hub.c | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/drivers/fsi/fsi-master-hub.c b/drivers/fsi/fsi-master-hub.c index d389856d18ac..a84955bb23b1 100644 --- a/drivers/fsi/fsi-master-hub.c +++ b/drivers/fsi/fsi-master-hub.c @@ -192,9 +192,9 @@ static int hub_master_init(struct fsi_master_hub *hub) return fsi_device_write(dev, FSI_MRESB0, ®, sizeof(reg)); } =20 -static int hub_master_probe(struct device *dev) +static int hub_master_probe(struct fsi_device *fsi_dev) { - struct fsi_device *fsi_dev =3D to_fsi_dev(dev); + struct device *dev =3D &fsi_dev->dev; struct fsi_master_hub *hub; uint32_t reg, links; __be32 __reg; @@ -235,7 +235,7 @@ static int hub_master_probe(struct device *dev) hub->master.send_break =3D hub_master_break; hub->master.link_enable =3D hub_master_link_enable; =20 - dev_set_drvdata(dev, hub); + fsi_set_drvdata(fsi_dev, hub); =20 hub_master_init(hub); =20 @@ -259,9 +259,9 @@ static int hub_master_probe(struct device *dev) return rc; } =20 -static int hub_master_remove(struct device *dev) +static void hub_master_remove(struct fsi_device *fsi_dev) { - struct fsi_master_hub *hub =3D dev_get_drvdata(dev); + struct fsi_master_hub *hub =3D fsi_get_drvdata(fsi_dev); =20 fsi_master_unregister(&hub->master); fsi_slave_release_range(hub->upstream->slave, hub->addr, hub->size); @@ -272,8 +272,6 @@ static int hub_master_remove(struct device *dev) * the hub */ put_device(&hub->master.dev); - - return 0; } =20 static const struct fsi_device_id hub_master_ids[] =3D { @@ -286,10 +284,10 @@ static const struct fsi_device_id hub_master_ids[] = =3D { =20 static struct fsi_driver hub_master_driver =3D { .id_table =3D hub_master_ids, + .probe =3D hub_master_probe, + .remove =3D hub_master_remove, .drv =3D { .name =3D "fsi-master-hub", - .probe =3D hub_master_probe, - .remove =3D hub_master_remove, } }; =20 --=20 2.47.3 From nobody Fri Dec 19 09:43:05 2025 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C4142E8B91 for ; Tue, 9 Dec 2025 11:41:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765280501; cv=none; b=E1bWUOyPd9Kw6++OzrFNQZNBmTRMJkiaF4zT8voy+70ljxL6imZDdNQNaraqPt6JmG89vYGTVjF1JgU9XovtF3iDh//0hD2BcF8ikwEpAIbeSThikNBEluVTrGcNjMf2g9e8IciNRvCMHYvRYxohYkUDI3iAWYn5paGaXEMQtU4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765280501; c=relaxed/simple; bh=QIJjUzbPPEXixJC/UenX9JmaeP67xomil8h8VVKadW8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=iDLg2SoCN/N5ynzyXAq9Wf95UmxMvORkRZdfCi2XSOce0WVClxTi16ReDGGxw51Y6mO6TIspZwnuPOW3mosVPk0sXuuhJYYE71C97SZMEeqhYReM5UoHyFvkiw3rxcWi4ZZWIcb3QKBD7pQ2Reb558rbPbtmTmXTiwaEO/vx3b4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=k/a4Aw8C; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="k/a4Aw8C" Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-42e2e3c3a83so2493011f8f.1 for ; Tue, 09 Dec 2025 03:41:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1765280498; x=1765885298; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=S5X0/AJXqVClNw+MMSHwGakWsUuvrSeOBMXGWWz5k68=; b=k/a4Aw8CYi4Jb6Yg1BkKzsaY/LHFMzNwhUuYpPFL1unVCBiSzmkmS0LL1RxGFowZVx pnJRBSCupZ24kg2xlG+xdk4h8IYGvBYO/pSVnvD0bZZdhcZCKuG20jlWXNLwCVqZyiAq R3WsNT4RnS6YXkRsoJ+yigk2NzrdWzISuQKWE2I2rEIBF1rfuafbif5k21JCuLUHLN0N +B0TD4EbExUQyTCMB0jTaOaNDtt48D+zJ7CFJIaLKcD6V6tmeFzblZQ/PfUylVabhAIl JE4YhzP39lO7iLRI3IKsxrrv4+kMFs5u+PlwfHJvkARPbnTkION9upg7PC0Pd5EhjlSI CokQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765280498; x=1765885298; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=S5X0/AJXqVClNw+MMSHwGakWsUuvrSeOBMXGWWz5k68=; b=ksjjKlTvNQJXl5OfXihIUh68jJR5Hq14AVpQwio4+sbZFf5D1V1GKBbdzxJEqGPm1n Apf17DR4kG8+qtg/SIJMyvHFQzFMNwje+esjDcpPiAso/HiMLG/3jvNKbIGQmu5R5MNO jXXHRG9sGRVufrfhpOLi7cUJBzzrFJz/q1uwGU9xL66Vl7ZRHQCLTSrdGBD1XHI6V/ju 62B6jMTaGw4Eg/95ZT/XflV8OYrYQnv+lFVXA/tuKohStGYIMYyc82OUIJvmGgup0+Fw 40NYCOPzCW4BgJQy6fGW3ae/b4IY8CWxUyilI9cvX+VxnffuquPvD/0Vg59b39wZTNQ7 fA7Q== X-Forwarded-Encrypted: i=1; AJvYcCW6SmDyqQQVegAgJX8/0LmZCdCSqWBVBFdUnNSJffshzYWCJfZRQPVpIh+UzmoAOlEnXxcHKIsEeU7QVZM=@vger.kernel.org X-Gm-Message-State: AOJu0YzIGcrtlBUIrnUsU6xXR1pKKtGDSzsMUetLjIlZHgp2zlPtalDy DwVHoRkBIrEJO3ZdqdSzBxgRDpMV3cYXuSdnK/POZlVR0aDowzPrHV3DinOpK6nvnQw= X-Gm-Gg: AY/fxX5poaQpZKyVb5cyhaLCtKqimuW3NUxzRwD5rHcM4YXRaYMpjtHGDxHV3Iz68uT ekVUJgNYJWHbXFHcE56JrfaRD1gRHbtWdornpkwYf00zsNps4EYPaRF/mU5JqPl2Hli04t2+6SR hS16zA3OwfGBGUZpBA/ruDIeefftNq/VDOkmsVQ/pHw1nfbg6RLJjON4oX4MwcSEPfMgVTUg6L0 fTFyg8nYnxtygGX5KdcB1tcn9CSxt0J4HIRoWECjObnXQUS2N1hT5jo/X6I9b4qMwEElAzP+1Tp mpo8FIC+zvdimEK/L3DdARQ79irVxJemTpZB8wXXhOSWjXmjlyViBPjenI9OK26QG69GhgGdYYR uXXd8YRhjwJyW1GoSuoJ2AMmmWpL9Mv4dhTKj+XHzrJZ47Hv547cjorPYy6+ufd16EEmouZ1HHV rtBS86xqsQmE1FUlEFRwLgTfqt/nOcz2k8f2alvuWvI2nDWOTceqpCw+D5DKHrxMAE4Z4Buvybe geJxqqoOYgifQ== X-Google-Smtp-Source: AGHT+IHLoPb7pKnPS+3yNlU5Ojwjr5FU6mWYP/ID8CE4pAKhpUsge68fcZzXRjtSowKOY2J2qqxJVg== X-Received: by 2002:a05:6000:2913:b0:42b:2e39:6d45 with SMTP id ffacd0b85a97d-42f89f1273bmr12577619f8f.15.1765280497722; Tue, 09 Dec 2025 03:41:37 -0800 (PST) Received: from localhost (p200300f65f00660846b2ba6e435ad603.dip0.t-ipconnect.de. [2003:f6:5f00:6608:46b2:ba6e:435a:d603]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-42f7d2226e7sm32222333f8f.27.2025.12.09.03.41.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Dec 2025 03:41:37 -0800 (PST) From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Eddie James Cc: Ninad Palsule , linux-fsi@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 10/13] fsi: sbefifo: Convert to fsi bus probe mechanism Date: Tue, 9 Dec 2025 12:40:34 +0100 Message-ID: <79dd5a9459f0719b7602165c89eb6fc24815f3b5.1765279318.git.u.kleine-koenig@baylibre.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=2272; i=u.kleine-koenig@baylibre.com; h=from:subject:message-id; bh=QIJjUzbPPEXixJC/UenX9JmaeP67xomil8h8VVKadW8=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBpOArNO3WJYXFqmuQCbays1Nr5ZU9BXR+5HfxqS nEHbqG/y+OJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCaTgKzQAKCRCPgPtYfRL+ TtfzCACQAP+O2gbpi0gSCqiHkV0eF9QIk5eOmS9PSRSYNkKi/+Y41X7CQbYl1/82jI8q4jkNE8R ALrjdJ+79Ok6X6fl2zEt0ZqnOz61dNVr/rWBd3ZC6hmBKbB38FWFOaq2MUH4GOLwBM6Xv4LPJND obOfR0uZjTVGXYyYzv+5+C7JfD/hykDJPhpAbfopMmnA99sz2xl1X/MzMLOMdT8PxPpu9yhMEwQ s+oEbZ2LxUZ2ehsgA8hKJFRYvKm+DFySTatMKhSJAWQZIpUoTK9H2gVYSoL/OcLL6dJ3OxHyuvK BP/uHUTY3mANTEI3ubkshWZndLjCyoa3KLk+Cn67cPzTjemV X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable The fsi bus got a dedicated probe function. Make use of that. This fixes a runtime warning about the driver needing to be converted to the bus probe method. Signed-off-by: Uwe Kleine-K=C3=B6nig --- drivers/fsi/fsi-sbefifo.c | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/drivers/fsi/fsi-sbefifo.c b/drivers/fsi/fsi-sbefifo.c index fde1c34743a0..6ca5817910cd 100644 --- a/drivers/fsi/fsi-sbefifo.c +++ b/drivers/fsi/fsi-sbefifo.c @@ -1022,9 +1022,9 @@ static void sbefifo_free(struct device *dev) * Probe/remove */ =20 -static int sbefifo_probe(struct device *dev) +static int sbefifo_probe(struct fsi_device *fsi_dev) { - struct fsi_device *fsi_dev =3D to_fsi_dev(dev); + struct device *dev =3D &fsi_dev->dev; struct sbefifo *sbefifo; struct device_node *np; struct platform_device *child; @@ -1045,7 +1045,7 @@ static int sbefifo_probe(struct device *dev) =20 sbefifo->magic =3D SBEFIFO_MAGIC; sbefifo->fsi_dev =3D fsi_dev; - dev_set_drvdata(dev, sbefifo); + fsi_set_drvdata(fsi_dev, sbefifo); mutex_init(&sbefifo->lock); sbefifo->timeout_in_cmd_ms =3D SBEFIFO_TIMEOUT_IN_CMD; sbefifo->timeout_start_rsp_ms =3D SBEFIFO_TIMEOUT_START_RSP; @@ -1101,9 +1101,10 @@ static int sbefifo_unregister_child(struct device *d= ev, void *data) return 0; } =20 -static int sbefifo_remove(struct device *dev) +static void sbefifo_remove(struct fsi_device *fsi_dev) { - struct sbefifo *sbefifo =3D dev_get_drvdata(dev); + struct device *dev =3D &fsi_dev->dev; + struct sbefifo *sbefifo =3D fsi_get_drvdata(fsi_dev); =20 dev_dbg(dev, "Removing sbefifo device...\n"); =20 @@ -1117,8 +1118,6 @@ static int sbefifo_remove(struct device *dev) fsi_free_minor(sbefifo->dev.devt); device_for_each_child(dev, NULL, sbefifo_unregister_child); put_device(&sbefifo->dev); - - return 0; } =20 static const struct fsi_device_id sbefifo_ids[] =3D { @@ -1131,10 +1130,10 @@ static const struct fsi_device_id sbefifo_ids[] =3D= { =20 static struct fsi_driver sbefifo_drv =3D { .id_table =3D sbefifo_ids, + .probe =3D sbefifo_probe, + .remove =3D sbefifo_remove, .drv =3D { .name =3D DEVICE_NAME, - .probe =3D sbefifo_probe, - .remove =3D sbefifo_remove, } }; =20 --=20 2.47.3 From nobody Fri Dec 19 09:43:05 2025 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 39CF52E370C for ; Tue, 9 Dec 2025 11:41:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765280503; cv=none; b=iNYKiitGV+FLNEZrs1eFMpinLsc8bdW5pD1EcD2SDQT0m46roQ3weZdY5+xaA/uei7A9YxME88+ZQou7xwFzfE7vP8eNgqeJ7Wy9irKVZQ+eg8/5ef7pK9DQVysMzXKHKSCmoSRbkVQ/s59xmyGzeQ62HC83Vn769aBGVs/fm1A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765280503; c=relaxed/simple; bh=48XhV1ead+kMhmolJfzkj7xK7TKmOSTcIV7UIXmqXBw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=dsPgBG3W9PWZU3I/suDrf8Wxq+F4vL6iS+pP6hKDQCpP1FOIuarBup5nrDFjQYrKA3k/6u3Ggyw7aClDLgG6I4nnwqvjLnRd9r13z1BHXKawjVTHnOShJGL8G54Iz+DJkZy8S+Sw6zDFHR6iGVJBvT6KMag0I+LEtLekUdXfe8I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=andvB9Dn; arc=none smtp.client-ip=209.85.221.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="andvB9Dn" Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-42e2b90ad22so2053370f8f.2 for ; Tue, 09 Dec 2025 03:41:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1765280499; x=1765885299; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XXnSVFokVbdMFj6Qaw0zpV5xPeOXjzZvsyUo2XNucKk=; b=andvB9Dn4OyJMJyXWf86zE/tXWbgcwVistYSYPrIkNEmjMna54nkJh/2IT9XiYYC4I Ir/Ewe4S9/hmQkIhoCqfd4Q9v4RrhkSx19OVjQdIDjFzlzHJPSk9PrR+7a48tqz97wjU uiX7Vcz2o2oaNga/hNpZRQ0WwulO/z426U8Z6BTfj3WxpRDS/d5gyfU9tAyEZPliCigZ PG54CYBGJv9yMWe7wUU8G8vA3GxqhlggOYaeQIWx1GAmnfly+pG4idl1LpManPBj+tpv abe6vn7Mjco4o42WsKrXm50eCxJeCZRckyk9PK37rHTYlcmX5/Ti2jNrNfAGcMSq973f fxdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765280499; x=1765885299; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=XXnSVFokVbdMFj6Qaw0zpV5xPeOXjzZvsyUo2XNucKk=; b=q+LOpmv02CXxP2IkUzRLFm+jlnqvGVAx+0ILS+uibYDxqmVsW1XY+EPp7xK0WlemZp csDum9Rg3WWHOyhR38L4QCg2Ynjzj6izGPAwc2IjV2SmmmsDmuZj3xLEHCIEhAs+++9C jOKu8CXxfILCAumtv5b4BZ+XAqbJmNTyjgNUywyp5LZ6oFvW7l1CVVNUPrcj1HhuyBcg vANw7WqFAWpOHbYXSSYp9dFoK85yJljin2dBLsJVq/kiM85duY32MC21f6UqYX1iDRRU PsaAksffvpKSD36Io1B0KdvtsjHQ4rTrj59Qm9LxZKGHVI3G+H64e8VhEgktDSRZmikf CXhw== X-Forwarded-Encrypted: i=1; AJvYcCVH/VIoMf9OEGyIMJ5ssaZjKNI584+4BYHnjXsqH5xzmIFy2zhfyTHAPEyHpMUEMlfPGf22BAkP8V8hygk=@vger.kernel.org X-Gm-Message-State: AOJu0YzFWBDBIcbiIC/Vjpucj8pVhkZTY/gE8lfK3xpIRvlOxFTGcfLP 00Z9GUtoVzEURNL23aYrUjxOh49X0DBiExuTukmJG2o+X9E6DD1z7mdEDkfHIYqj1eJDaAAQl31 M6SJJ X-Gm-Gg: AY/fxX4f0b0e9qTv4jgtYBG9I5ndAKD+i/LhEPEZmdbpF9ZNPLRA1cnENAhzV86Lfry EKykf0F1Q4NMmDdeaxTmQGxbwX+DH8GaNd6RM22BNAXyweFDAC0hn+YTAWHyt4n7BZAUEujtU5N bk18yZ6Bc08WE7xSVuMr5SIKVxcFBHPv41zYd3Weo4eIii4WRXrAKGoAfMooQ5/c8lmCoiOm2Yd o6TLgck54FL50Tfynx//yB03MXT0k55LSv3BOizqnSxlx/SgA1igWP5gw2DWGNsBwF3nYci7xx8 Wu2po2y67VHmzQ3p9/Yi87zW8jDD97dlSSfxPh/D4fp/hUfprOPaFxbQLHF8WIPmuz9bTWkk3Gw eDeBqCKnMnAFGC8kFMbxmhzC5S1j0JI/iLPnbP2FoO6UNig3F2O8ozfzjSbJIj/kPFTtD63U6go wS97+JTgjqslXN1YEMB5VE8gqjNVpjfx1wuK3PI3/cDD88hmTH1NtpvLebXwqgbTy1KMIr7PlBL Aw= X-Google-Smtp-Source: AGHT+IGgdMfJ7PK3k5URNmIZUI7wMC5d4u3M6FZ012ff4ItCYB8PjRNmPcUUKEPw3lS1xaXxW7zAXA== X-Received: by 2002:a05:6000:4013:b0:42b:39ee:288e with SMTP id ffacd0b85a97d-42f89f0b223mr11749620f8f.13.1765280499525; Tue, 09 Dec 2025 03:41:39 -0800 (PST) Received: from localhost (p200300f65f00660846b2ba6e435ad603.dip0.t-ipconnect.de. [2003:f6:5f00:6608:46b2:ba6e:435a:d603]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-42f9f5ab46csm3326986f8f.19.2025.12.09.03.41.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Dec 2025 03:41:39 -0800 (PST) From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Eddie James Cc: Ninad Palsule , linux-fsi@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 11/13] fsi: scom: Convert to fsi bus probe mechanism Date: Tue, 9 Dec 2025 12:40:35 +0100 Message-ID: X-Mailer: git-send-email 2.47.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=2008; i=u.kleine-koenig@baylibre.com; h=from:subject:message-id; bh=48XhV1ead+kMhmolJfzkj7xK7TKmOSTcIV7UIXmqXBw=; b=owGbwMvMwMXY3/A7olbonx/jabUkhkwLrgtlBcsiL7fM3MdRNcm6chPXWv+UCy15xhtkQoSOW zMILOzsZDRmYWDkYpAVU2Sxb1yTaVUlF9m59t9lmEGsTCBTGLg4BWAi2Zs4GHYaiIfIPjrusmzh zOm/VIvqH8srG0Zu3tgi9amEyULr5DR//fnqV4x+/5hyXqtPQW2h+Y+iP2EO0VmZL9XP5bZLvks 7Lsq4hztTJ+b5g4evH26a8PJF9upZWwRyVl2Q0z3qJ5bO2hzv+smh2jl7ydfM/ayHOF/FVBQWr8 58vsyiJDDEnlPorNhTdebq4xlB6VuSn2spM3pYH9By/xqzvdlb5lJptKOV/XMNfvljHj8ZKpXbX yh0hpmtulq6cWaeaSs3w6wZLGvUJ7D+E0pl6Jmi9IHt4J97y18+t15seNLiv+YLNl8/K53Ipxcj FNY2Pdx+6/4Nh6NiLY/Da+pE62fW7ddZnxN+8Hv4xOlzAQ== X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable The fsi bus got a dedicated probe function. Make use of that. This fixes a runtime warning about the driver needing to be converted to the bus probe method. Signed-off-by: Uwe Kleine-K=C3=B6nig --- drivers/fsi/fsi-scom.c | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/drivers/fsi/fsi-scom.c b/drivers/fsi/fsi-scom.c index 2eda44451cc1..67cd45605fe4 100644 --- a/drivers/fsi/fsi-scom.c +++ b/drivers/fsi/fsi-scom.c @@ -527,16 +527,16 @@ static void scom_free(struct device *dev) kfree(scom); } =20 -static int scom_probe(struct device *dev) +static int scom_probe(struct fsi_device *fsi_dev) { - struct fsi_device *fsi_dev =3D to_fsi_dev(dev); + struct device *dev =3D &fsi_dev->dev; struct scom_device *scom; int rc, didx; =20 scom =3D kzalloc(sizeof(*scom), GFP_KERNEL); if (!scom) return -ENOMEM; - dev_set_drvdata(dev, scom); + fsi_set_drvdata(fsi_dev, scom); mutex_init(&scom->lock); =20 /* Grab a reference to the device (parent of our cdev), we'll drop it lat= er */ @@ -574,9 +574,9 @@ static int scom_probe(struct device *dev) return rc; } =20 -static int scom_remove(struct device *dev) +static void scom_remove(struct fsi_device *fsi_dev) { - struct scom_device *scom =3D dev_get_drvdata(dev); + struct scom_device *scom =3D fsi_get_drvdata(fsi_dev); =20 mutex_lock(&scom->lock); scom->dead =3D true; @@ -584,8 +584,6 @@ static int scom_remove(struct device *dev) cdev_device_del(&scom->cdev, &scom->dev); fsi_free_minor(scom->dev.devt); put_device(&scom->dev); - - return 0; } =20 static const struct of_device_id scom_of_ids[] =3D { @@ -604,11 +602,11 @@ static const struct fsi_device_id scom_ids[] =3D { =20 static struct fsi_driver scom_drv =3D { .id_table =3D scom_ids, + .probe =3D scom_probe, + .remove =3D scom_remove, .drv =3D { .name =3D "scom", .of_match_table =3D scom_of_ids, - .probe =3D scom_probe, - .remove =3D scom_remove, } }; =20 --=20 2.47.3 From nobody Fri Dec 19 09:43:05 2025 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4784F2FD1B0 for ; Tue, 9 Dec 2025 11:41:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765280505; cv=none; b=RqzPGcZPtDjomFPzatocAJjkPteoQjEFNH+KgmnLvzrtuyiPHedLnyz/EMr6Xhc8NEhDwrxOOLzqHMFEN9aVDtHa935l85wffpKqvB7EZPNSPYz0M+EzmJYe9+n8AfJcSfBdXVs+Cb4ueJHXh7Q2tXRHgRHP+hN5oDsGWY+jcu8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765280505; c=relaxed/simple; bh=5HX3OW285ekofJr+ZMAtH3Qgn6AjwhMDtCWinCjqMKk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ZOSJOTfjFgbM5Xw/HsGNIOrPb7nZ0ZyjI+QwfPsxzEACVo7zEQRAcvHHYnG4NsZEL3FR4esnYTPID1nJbIbp+h52BHih1fgWNHDQtafJ5bbEV/whzaLB9/td57W/LzKX4pL766ihc6bnjA3kUfoBri7fLOArj51IvIFiA8BLG+8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=13XHVvOQ; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="13XHVvOQ" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-477619f8ae5so43069455e9.3 for ; Tue, 09 Dec 2025 03:41:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1765280501; x=1765885301; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=iNVZpPWstq6UQ7hNmWtjUM9pqjmls6FXKaYoayGkq+0=; b=13XHVvOQiOrpLumjDokm2hx/HlUXCm9ltKNf0P++W/CdkcfD2DnKGhS3DokJQmTrX7 5h2begMyEv9hEuBWR2hH8MNvfDOxY+uTcRU4DQ4WfFssSPBbVF2dx/+yXBg0arXv5Pb+ MW0snIOdadfqAggiKfdbwmJyuXL6pUX6hpRmvw4lgY0jw6xfK23oYCdjvJvEiEnFgaqY muQfr/7CKODAjUMyuYNtu4cEY0Cnagw+VQypFy7H54voMoJQA/Lg85pmRGV+hRyNIbs1 jMwJJhjxIB4fP1eHfhz5EVQc1D3zxME3JDDST6KGcmppfujX+S9N1UGDBjtLMVLq8PCC hdtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765280501; x=1765885301; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=iNVZpPWstq6UQ7hNmWtjUM9pqjmls6FXKaYoayGkq+0=; b=fGxwkuitRWi6qIF/28luccnMNDBcWkMdyGpAQwu6+tHCtjV1+iHBaqv+xXxoNYCqGz 9JE2LU3TFw/vVaUZ2Nsdo9Ri4Ws/nKE19J+EfP4XLgEavl/r3YUSaGNPSpQ4fv2ptlEf z9fFUBYFJkBi+siS2480DgBp7E3O64rMfanNdQdtvu8qzWoJuCv1JBRjyY5quYsJ/eIm vt8pN3AJ4a6XNYItV5GKyeC5klxLTSf5RIcaLjWjc7iD5356c+RGNRKOavFQRPlTZ96L dyGgCOOrBWV67VNlt2QkU1G73CjjFJDkEJljH315kMF0rF1licu2kagerNRFbsLQSMqY 3NvA== X-Forwarded-Encrypted: i=1; AJvYcCVCzfoC11HfJZApwXbvFRR8CYXovhq8cp8zrbY3yyKDq6hwmSCW+10a9p5UvgYL3DJzfZJVthXpSd57uiA=@vger.kernel.org X-Gm-Message-State: AOJu0Ywu2JW8WnGByUIuNS75ZHF/0Gt+YA7hdGIpQbRTY6st4y8To5Qx p/YMqosB4wUgW6FdcsA69225bm00ZzeF/ih5chXD4La8L0b2WkOTYpo/DK5j+dY21wc= X-Gm-Gg: ASbGncvXBUhC+1orYfg4Y+uFlluTUZDpDJ0N9ova7rK0psY9YVtNKaEus87xV3NyiJ1 kBS/EGL7UxyivqrZeuYTujMcOBPXFLzAjp0ZHcTsL76NduSFuXz/N91TAHK75i3KyYLSBBWnyAq OF4XqnGsNN72vhlBMOjtGnlqh9sj3vls0dZ9gDIRTJeu/eKG5A8nlvCFugOJmQaaR1M+V+PCvOL 4yLJjrD+fZkjnrHRN4qJhlN1gi1EcjRGjkoju32VgnhrBAuHg2nHZvBvoXZjpOEp5QGQt+rKsgp 9BdYxYW1iIO1QrLe6nXoYfny30/1bWIa5ST2f0Lqa32uy6tGnSHnDbK9WwH3YGGLHBu2l7nbjrZ SaNbiLtpdak2i5ptNEpr2TazGzqnERY7958k8q+F82+/yLZV5cF37tm4k94yKujWflWH1vAvnii ZROjhdMbk1C5uNkiBLCOsVvyEZm7PzPmKqVhQDrblP7bq32DKSWeYTgi0W1ssFNJPObF6fdmboR efKJg0aliDm3w== X-Google-Smtp-Source: AGHT+IFqjeFtTWyJo7Yt1w2zgHCCsE/PgpgUbX7INlU2Fq5tEzzIvyp2oysXTDSIJZ6c1m1oL5+SVw== X-Received: by 2002:a05:600c:6014:b0:479:3a2a:94e7 with SMTP id 5b1f17b1804b1-4793a2a952fmr81397435e9.10.1765280501553; Tue, 09 Dec 2025 03:41:41 -0800 (PST) Received: from localhost (p200300f65f00660846b2ba6e435ad603.dip0.t-ipconnect.de. [2003:f6:5f00:6608:46b2:ba6e:435a:d603]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-47a7d70fae2sm34084825e9.12.2025.12.09.03.41.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Dec 2025 03:41:41 -0800 (PST) From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Eddie James Cc: Ninad Palsule , linux-fsi@lists.ozlabs.org, Andi Shyti , linux-i2c@vger.kernel.org, openbmc@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 12/13] i2c: fsi: Convert to fsi bus probe mechanism Date: Tue, 9 Dec 2025 12:40:36 +0100 Message-ID: X-Mailer: git-send-email 2.47.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1975; i=u.kleine-koenig@baylibre.com; h=from:subject:message-id; bh=5HX3OW285ekofJr+ZMAtH3Qgn6AjwhMDtCWinCjqMKk=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBpOArStEL5Ys2R2thb6Z/34Sl59kUwOR6aGpFPS ZCbRTq8ETqJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCaTgK0gAKCRCPgPtYfRL+ Tvf0B/92vabNFUU6s1pdd/h9ixnoGht1iEP8dpZA3iUTxQVwQ1HSizaycKJdQ8uF6xKNCjVH+yg ZURYCCI3ni8m5mLq6G56KkKc+hZQKgfCANtjXOZT9kUzVe0SrOVl6F0bJt/E5YPOq3/Cs0mPQLd pzOH8RgvinIylj8TXpA0bZkFiGRSTKUYyhg8pUGvIW7o1hzc3JvlX1fyygBjM8eJENvw+XAJ828 FH0rpp4dxaY7CzJ/PUEoBudHXnWxfEM2UW9muqHSu/KV5ksn5eLYl+hE4gogRhYzLAv+2lEeQp2 RKtHM62FUtNwhkVZbNr5cvI5Uz6NpQVkU4gV5/hTHJiFxvOb X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable The fsi bus got a dedicated probe function. Make use of that. This fixes a runtime warning about the driver needing to be converted to the bus probe method. Signed-off-by: Uwe Kleine-K=C3=B6nig Reviewed-by: Andi Shyti --- drivers/i2c/busses/i2c-fsi.c | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/drivers/i2c/busses/i2c-fsi.c b/drivers/i2c/busses/i2c-fsi.c index e98dd5dcac0f..3a7e577e6eac 100644 --- a/drivers/i2c/busses/i2c-fsi.c +++ b/drivers/i2c/busses/i2c-fsi.c @@ -674,8 +674,9 @@ static struct device_node *fsi_i2c_find_port_of_node(st= ruct device_node *fsi, return NULL; } =20 -static int fsi_i2c_probe(struct device *dev) +static int fsi_i2c_probe(struct fsi_device *fsi_dev) { + struct device *dev =3D &fsi_dev->dev; struct fsi_i2c_ctrl *i2c; struct fsi_i2c_port *port; struct device_node *np; @@ -735,14 +736,14 @@ static int fsi_i2c_probe(struct device *dev) list_add(&port->list, &i2c->ports); } =20 - dev_set_drvdata(dev, i2c); + fsi_set_drvdata(fsi_dev, i2c); =20 return 0; } =20 -static int fsi_i2c_remove(struct device *dev) +static void fsi_i2c_remove(struct fsi_device *fsi_dev) { - struct fsi_i2c_ctrl *i2c =3D dev_get_drvdata(dev); + struct fsi_i2c_ctrl *i2c =3D fsi_get_drvdata(fsi_dev); struct fsi_i2c_port *port, *tmp; =20 list_for_each_entry_safe(port, tmp, &i2c->ports, list) { @@ -750,8 +751,6 @@ static int fsi_i2c_remove(struct device *dev) i2c_del_adapter(&port->adapter); kfree(port); } - - return 0; } =20 static const struct fsi_device_id fsi_i2c_ids[] =3D { @@ -761,10 +760,10 @@ static const struct fsi_device_id fsi_i2c_ids[] =3D { =20 static struct fsi_driver fsi_i2c_driver =3D { .id_table =3D fsi_i2c_ids, + .probe =3D fsi_i2c_probe, + .remove =3D fsi_i2c_remove, .drv =3D { .name =3D "i2c-fsi", - .probe =3D fsi_i2c_probe, - .remove =3D fsi_i2c_remove, }, }; =20 --=20 2.47.3 From nobody Fri Dec 19 09:43:05 2025 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BD0512FD1B6 for ; Tue, 9 Dec 2025 11:41:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765280506; cv=none; b=S6VuZ+2vS5AkX0UcNiXIMUKRrAKHMkB/5ZgkTCwZ6rprhjADi7mK+oNCQuBK+DM1l+NUzvl2clWFllOSNRfz2zUptI8fXeB5AHON+AgYvC60lyJqhGSJyaMkz9IM9MsGbyGSeoYo/PQKaqjyosXhO8vrM3/QFkcaWP8N4ObfWaA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765280506; c=relaxed/simple; bh=06BdsgBVMEqXdfbdXIticJ66myk41PEFHYio8i5FOnI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=qBIU7wft2qR+CdlJ2/1pfiS9RuWaIcowJ8lhYZtAqCN4oFr34GLoBaJtJgouJZYdFjbL2U65SUgAzyfMjtGpMxQ2cK5Q2TmWT4rSwCJscKspNfnfRzKobBfgN/hKSdoev1k8E4Acvuvj3eMWxWMGseWcr+tpa5Bb6VSEekJBJEM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=gI0xScNe; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="gI0xScNe" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-4775e891b5eso27852775e9.2 for ; Tue, 09 Dec 2025 03:41:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1765280503; x=1765885303; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=rhL9+AU6HoZyZQmOa4BOGYYt3eA+LGP7dYShjppdZks=; b=gI0xScNefQwHSYCklFqHP+ib1e2C/jj3qNX2VeSotkMt7jedoq1SDcj+UCaZkM1NJ7 9khl67qGjw8xJNV/Z+wbC1uUW0WrByVDAktkDtK/2V46Eygae5Zo3WvsAwN7oG3oJAok fqazVJ1NmjIozZ6HSZW2/dKFkOw93tKM7Uyu1XcIYfgKcaJvsuqLtGfIqtZA/rwehdz5 avzdhZEcOuQXj2o19Qtkbr7Bod13DFJQeQWYLk9WKijofKoKESLRVpHnqhGvGE/2eXof jfWEL2K1Dla6UKIfJTkxBSnkhNYSg/PU5nR9xCz7I17dyEWvO+XDkqU1LX4lbAqP8dij N9KQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765280503; x=1765885303; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=rhL9+AU6HoZyZQmOa4BOGYYt3eA+LGP7dYShjppdZks=; b=v49ls5jrDynzqqLbxXQnbVOK89eaKGinXsF/wbdTzog/+I6Cg8rRUzp1SoL9utndFm xSlsTmqvW8pIRXwMNsJoDUufGiu91jhf8RWc9LE0H6QMT0/h7e8kq/HY8rjPBEHfIaX3 moA9UsAgOatK54w522UwcruhSb3rphAEs2ttzyqvi9fj3fpAs2YajoRn+4T/Zq3BhOH9 yEAWTcTuL+EdUMYPSGc8si7MiwGhxzbR5qmty+JS0GhtYDFDZ2jGyGI21izMwmeCT45R WVwS5nMsCKXZIGpsO2zhfcQAsjHq80jl+qbWVs2/L65YPnk+3nxrk56y1CsJjXYV9XVq TeTA== X-Forwarded-Encrypted: i=1; AJvYcCWSN9mFc/NdTmLDB0rogBdeB7u52H5JNfF4O4u1yHM4N2VvG8VlqP/QtYN00KjXns53fYgwKm6PefxRMxA=@vger.kernel.org X-Gm-Message-State: AOJu0YyxIwn3OgtteBMrgoOOJUZaDPnnQFziXZkQHJrU1KLc94gst4oI 2+s66/i1Wn3zjpdk6XFRBDGWcsjAkcCafzKlqT11euNMf4jR5v8cK75OrRGC49RooiU= X-Gm-Gg: ASbGncuT7v/Hm6Xju0nYJ99i9/RP9JUKLCOkvj1O1Kvoeeowe3X23Y7H7b75NTmv29P FGEjfLpA+TPYsSeMuHIsvuWCJmmUz8MIRkUIkk/eigV4bJPEzdXQD1O71t9Dha2wc3YjAlpkNa7 6/rBYfhe8yeajhm2y6cQA2h5+W/apfLvMVbQRQMHSMIS4poicfYn7mBpEH76/twRC1dJWSeM5df EZ9ftEPRg6PAqAc8B6m+9KPD3O+UN2YZMHCQRQ0FL5eOu8MHMXF2Ga0z1WoCYiCvsK1Sy1vdP/z bbxSaXS9lkIU7LhekzL6BraxFqjhqVGWr30jcNZBIgmXNUbgAFLmKvgaqfaxQ4F4HQITTOOiAox p/zBM9y2021SPz01u5lgw+OLWMOpbx/yxlVyAXpiblW+qd+PF7DPFSIbyhnrt49YBFZdoEzEcMO t2WUY7gUR4tJJ1Q8UZW3H14jYXlur8v4aCbxcA0Mo+DRVQ/fLov4eZbSh0yaOjJYxRXxzJ83EIp Rk= X-Google-Smtp-Source: AGHT+IGuRTUH7a39Dsyspi2QJ5C/0tpwri8+2mZFiVZoulK+TTvvMH+3GNzkr6TbOUOeSCmow+m4DA== X-Received: by 2002:a05:6000:40df:b0:429:bc93:9d8a with SMTP id ffacd0b85a97d-42f89f476b3mr10441592f8f.37.1765280503200; Tue, 09 Dec 2025 03:41:43 -0800 (PST) Received: from localhost (p200300f65f00660846b2ba6e435ad603.dip0.t-ipconnect.de. [2003:f6:5f00:6608:46b2:ba6e:435a:d603]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-42f7d222506sm33270410f8f.28.2025.12.09.03.41.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Dec 2025 03:41:42 -0800 (PST) From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Eddie James Cc: Ninad Palsule , linux-fsi@lists.ozlabs.org, Mark Brown , linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 13/13] spi: fsi: Convert to fsi bus probe mechanism Date: Tue, 9 Dec 2025 12:40:37 +0100 Message-ID: X-Mailer: git-send-email 2.47.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1271; i=u.kleine-koenig@baylibre.com; h=from:subject:message-id; bh=06BdsgBVMEqXdfbdXIticJ66myk41PEFHYio8i5FOnI=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBpOArVinCbj1VedreZCccuR2KxrKHV8acSr36wx R6jwNzck6KJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCaTgK1QAKCRCPgPtYfRL+ TjDDB/wIHTvw0hGof8gtMjpiFRj2jv4jZnXlhHmUy0svAJUTKRPPRUNtOEv7aMXxfzszw4kyOri TSJrnvvN1WHj6USRO44tb9zScZxt2GeBwlbdEyoYrTIG+5oJYdCxuSD/SyP3OHTtaKoGjqDwC88 6WHJJ2KI8rW1/HUttDvLNQnDyeuy+pz15iCazfvsU1PnmOgK1JX0gwi9qQiSnyNjIZ3L8vyu7Sp C1e54ReVtgkugjUzOXEpSsE7wYQEG9lCyLEdjrhp8WrQ0amSSzMZrG/af2BT6yRCEzEjWvB12Ub f99wL9YTrKYch+/wFMoyklysOXFQZSg1Al0A2Ll1WXideXUv X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable The fsi bus got a dedicated probe function. Make use of that. This fixes a runtime warning about the driver needing to be converted to the bus probe method. Signed-off-by: Uwe Kleine-K=C3=B6nig Acked-by: Mark Brown --- drivers/spi/spi-fsi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/spi/spi-fsi.c b/drivers/spi/spi-fsi.c index f9c15b99dba5..07dc3d24f2c9 100644 --- a/drivers/spi/spi-fsi.c +++ b/drivers/spi/spi-fsi.c @@ -528,13 +528,13 @@ static size_t fsi_spi_max_transfer_size(struct spi_de= vice *spi) return SPI_FSI_MAX_RX_SIZE; } =20 -static int fsi_spi_probe(struct device *dev) +static int fsi_spi_probe(struct fsi_device *fsi) { int rc; struct device_node *np; int num_controllers_registered =3D 0; struct fsi2spi *bridge; - struct fsi_device *fsi =3D to_fsi_dev(dev); + struct device *dev =3D &fsi->dev; =20 rc =3D fsi_spi_check_mux(fsi, dev); if (rc) @@ -593,9 +593,9 @@ MODULE_DEVICE_TABLE(fsi, fsi_spi_ids); =20 static struct fsi_driver fsi_spi_driver =3D { .id_table =3D fsi_spi_ids, + .probe =3D fsi_spi_probe, .drv =3D { .name =3D "spi-fsi", - .probe =3D fsi_spi_probe, }, }; module_fsi_driver(fsi_spi_driver); --=20 2.47.3