From nobody Mon Dec 1 22:04:09 2025 Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2BD191A704B for ; Sat, 29 Nov 2025 16:58:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764435511; cv=none; b=N4fVps/pSgDt60ppC6/6n7Tw4X5d7GYGZfA3YNAtEyhjT8wFFsn4NPAwwIoIuZQwRG8IOReaseQ+Z9pZ0Dz4RZFTNoBHokAgfwIJBhrcpdqh0K1RLtBnd+tx57Rft4JcLadwjtNQ0Nj5aunof8K6cVmCOdrqmeXnNrOl3TtE3lY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764435511; c=relaxed/simple; bh=l3fXYKi4pGNSt7kFvw6nHQp4KrwuyWix9tbYeZiuZFk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=EsJCkE+c2eLBIbd49/a16ISkDl/OYoBHi0PGS8auMED66/ThLf29ov/mRWirwO4kiE3B+mBj0OuSpuZMxlQz5A4NeoPmV/Tk8gl9+LWcCtnTyyfkWppCt3cJFNQHtKZN8hIZqA3cRAVOrTYEyoNu5kAnLw/80zeYZwZnSDBOsIQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=RdiCn0mX; arc=none smtp.client-ip=209.85.208.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="RdiCn0mX" Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-64088c6b309so4886844a12.0 for ; Sat, 29 Nov 2025 08:58:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1764435507; x=1765040307; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1D/MN/XFrIK+XQsOry+m0d08hGOkhZCu9Lh+2mw+SB4=; b=RdiCn0mXmlqjkN+R89lQFqgcliMIY4QLXQacmmcn6j9lepOwsGkkUPavkH/eKoSADb 3AKcJdaNF/ngktpxpWZ+ff4XcSdZX+E8iHZFZZap46Has63h14PgR20RIWpHv4X7q95v aJrILce50DiZQ9aFSCEcOsTTNR+IpkSZuqVtdFfh7UZijkHaX3kjJuULUFsjTuZHZ8Qi 9iYhu0ou3j+N9DcaKpL+R/2u0e1zaJtVXJVkjBogoEzTscu9C7qaKJXgIv1yYh2MUHy9 Nbo3A8hQ5XTf1y8ipF5v6hKHksRT73BvDJrp/4ESiWR8BuQVGNz2yyUjDEN7MrEVnhPL NULg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764435507; x=1765040307; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=1D/MN/XFrIK+XQsOry+m0d08hGOkhZCu9Lh+2mw+SB4=; b=tYVj6KEHS0STa6dDe/ujCZ8zBD/uxbAoQJuhRgTijECmRguAOe41fjcAnf9SU2dLgk 6EWwz0oq+IcqNH7BvuSGyMgYIovlCSoIMOFeIMfVhgrThPdGNBEwzfrmlibCyncD2JoH BcXyLQFdWZLwltlND7VrVQHzUfZnj+XnlFjWBYogMlBFxhumNkkzHlOdhG6TSELkEwPy hn8MqFC7rDNxNxBvOK4x1gY4fxcR646t9CnEaDmP8RyCT4dyL6mQWH77dkGyRp5bSuqS iEpLzBTNH5kIPC4L+qw/D0mWT325Tk5l6s/+vtx0I1gigzPyn0VDAq1q9ps6kHhzRNGj nk+w== X-Forwarded-Encrypted: i=1; AJvYcCWEErHa836ZZoxfy3lH4Pw6FFyfjPxE+oTkEeA79j+jeFoXIZKe6ifyBZ25vb/iljPfLV9D92j6EnFQogE=@vger.kernel.org X-Gm-Message-State: AOJu0YzcwGSFsNrVR5y2qeljbz6NWc/gjj4XnnRrz//J0NVV9bcN9QU4 kujTZDQ/R2u0J5jGL+PaIwFhs4Kh54M8QMHC329io8buwk9b9uviqe710ZKOaFDiuAY= X-Gm-Gg: ASbGnctEGTQINmmBvt1B06x+F0Y45M1Yx64CLxQMdCnpwGEQo9mt7a9Sn3gaz75aGva 0ccvp4ADNMg8vNcOWd9Fr/QlSyOe7fO9YZuliysfbxSpJ7nVapFO/IMdgYMxPGF9SWwktdUQEGe 81RB2lAll4JmReVrFhkq+cR3E9oeCulwz7wVb5lOeJmO0cHh2QAXirSpOHlMR88e4kLUh+FExed dCmTnw6SaGn8DVanCyhJ0LsgSCPyFLTHmON6N2lBNAiLIx3W0Ren0BXxS4dL8Al5ymclR4beD4K jt155ClK/+fQvNID7U1jH7iIfsy86mEK+NWDzAbt1kLyAb2IrEw3MKd8cg4irDZ4+h0fqtal+ji r9OfLxiTei1mFxhnaromDfB2Hj/dN86ztZfhMUvgdtBe5DGEIKT2Y+Cpg7COhZkNYRsdGFgVA7E Ld1AhlLLOhDaHJDFPv X-Google-Smtp-Source: AGHT+IEpcVV1zL0Qj3MqZq6mZZaFDOHLx1LapLPimrD3X0g1lFho0Oq1RvR822ahKoXCj8UEL14ihg== X-Received: by 2002:a17:907:968c:b0:b3c:8940:6239 with SMTP id a640c23a62f3a-b7671b12672mr3609328966b.52.1764435507359; Sat, 29 Nov 2025 08:58:27 -0800 (PST) Received: from localhost ([2a02:8071:b783:6940:1d24:d58d:2b65:c291]) by smtp.gmail.com with UTF8SMTPSA id a640c23a62f3a-b76f519e8f4sm747014766b.22.2025.11.29.08.58.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Nov 2025 08:58:27 -0800 (PST) From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Eddie James Cc: Ninad Palsule , linux-fsi@lists.ozlabs.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman Subject: [PATCH 01/12] fsi: Make use of module_fsi_driver() Date: Sat, 29 Nov 2025 17:57:37 +0100 Message-ID: X-Mailer: git-send-email 2.47.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1570; i=u.kleine-koenig@baylibre.com; h=from:subject:message-id; bh=l3fXYKi4pGNSt7kFvw6nHQp4KrwuyWix9tbYeZiuZFk=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBpKyYFafIY6/vds7EuJ5NGalrW5i118A56VP8Wm rz2mt6Z8qeJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCaSsmBQAKCRCPgPtYfRL+ TixDCAC01ArCA5YOmf1tkpOXo9DLAF5vrA6RP6xGSvHp+c5Dfxfl3+82BnvLLKq97pjTE5Y2a2c 6Tg+fJauoBiyXF47+XwN7wbjgFu7f5R76UnOiJNSvnap01XaToRJtYNo683Zc4y1feONQY1FE0x R8jrQunbL8HboCRUDhXl3Na4sOIrL42sQ7BVjEDJaZ1M7bFFcRmPqmNTXJh8k92ZzbHBmYotXJK lP2K3mTRnKPgHzL4GoQRlJkEYvyiiEYfR8/xfAWR2Xv9FFrD2D7hp5GW7tatnfV7RX8n2zLxKBs L1J2ckCI4VJJHzPn3cjZ3rRUt/KPZoQ3dmjcosfRxPGl9IUl X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable All other fsi drivers already use this helper to reduce boilerplate. Catch up for the last two remaining ones. Signed-off-by: Uwe Kleine-K=C3=B6nig --- drivers/fsi/fsi-sbefifo.c | 13 +------------ drivers/fsi/fsi-scom.c | 13 +------------ 2 files changed, 2 insertions(+), 24 deletions(-) diff --git a/drivers/fsi/fsi-sbefifo.c b/drivers/fsi/fsi-sbefifo.c index 0a98517f3959..5a08423d0c7e 100644 --- a/drivers/fsi/fsi-sbefifo.c +++ b/drivers/fsi/fsi-sbefifo.c @@ -1139,18 +1139,7 @@ static struct fsi_driver sbefifo_drv =3D { } }; =20 -static int sbefifo_init(void) -{ - return fsi_driver_register(&sbefifo_drv); -} - -static void sbefifo_exit(void) -{ - fsi_driver_unregister(&sbefifo_drv); -} - -module_init(sbefifo_init); -module_exit(sbefifo_exit); +module_fsi_driver(sbefifo_drv); MODULE_LICENSE("GPL"); MODULE_AUTHOR("Brad Bishop "); MODULE_AUTHOR("Eddie James "); diff --git a/drivers/fsi/fsi-scom.c b/drivers/fsi/fsi-scom.c index 411ddc018cd8..f533106085ac 100644 --- a/drivers/fsi/fsi-scom.c +++ b/drivers/fsi/fsi-scom.c @@ -613,17 +613,6 @@ static struct fsi_driver scom_drv =3D { } }; =20 -static int scom_init(void) -{ - return fsi_driver_register(&scom_drv); -} - -static void scom_exit(void) -{ - fsi_driver_unregister(&scom_drv); -} - -module_init(scom_init); -module_exit(scom_exit); +module_fsi_driver(scom_drv); MODULE_DESCRIPTION("SCOM FSI Client device driver"); MODULE_LICENSE("GPL"); --=20 2.47.3 From nobody Mon Dec 1 22:04:09 2025 Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 44E30238C16 for ; Sat, 29 Nov 2025 16:58:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764435513; cv=none; b=hrVJV49TKllf2KfusEiYUMu/UDHkcu9R1k5g263rbsdu2Q26fENFlSzD1dN+j26SRgytpf0NRw5aUAX1OuLiB0YmJbRhkk0wSLR+k/UgzMQVaDwsruYzEE0dms9+qVaieYyTqN2eJ8m3NaWoqE3G/kogtOxobF7eW4QpiXT2GDI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764435513; c=relaxed/simple; bh=wRaWW24pXY+OPYNZIR5cKkkiBGL1akjSxYa2wBmqxHs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=WDF4pHsC7LTiJZVGKPy3+dl4Bzv5/MercixCVMwr/8RW9gc3kBL89z/pSPsHIs6gGsGDZ9lVys1oMA1oEpSle0y41LwSZqrA0BqQmuaB+a7YIC8v18nMyxVsXHb5d7esfQ0f+NFValbwmKc+D0m87P/wjgn9bwH1ls55kWAchGA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=gE4zHyps; arc=none smtp.client-ip=209.85.208.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="gE4zHyps" Received: by mail-ed1-f43.google.com with SMTP id 4fb4d7f45d1cf-6418738efa0so4692863a12.1 for ; Sat, 29 Nov 2025 08:58:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1764435510; x=1765040310; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/wpozwXd7C0ITdX+8ILepswCKxR/Gjoqj1EK8uGzLC4=; b=gE4zHypsSFq5Htz/0hE5qAVMXyBkAkSJsMfY8pGW9til5uj9JpVxwnXdAHjeuJM3U2 ntNjauArQKAiJ33mmO5KhvZ1SwNBj5KuxyHJv8rFbN89YuHETbtNoKDyL/mq7VLYyBvk EkBB/bn6TSgbRUYcS18O/2Or6hqxrx3rnro4IGJFOJifVhEM/q7lYXwIlxuMYxiloHWr h7QNM25fFv3dVWT9R3RDMOo5UF+8bqaO05xElatcdA7qBKrL7vRoHj1rMnIaH7RxhRCf yVn2lzyninwuAHk4D8SZu/m+cPYZJDEJ6SNaHEFomS58WXgpWhuW3LUQy3oUw2PslMq5 KOIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764435510; x=1765040310; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=/wpozwXd7C0ITdX+8ILepswCKxR/Gjoqj1EK8uGzLC4=; b=G+DW8NiXEEOAlx8C0S6QMjtkJeRlQAudfVKkEloq0DQZB6C1Mpn4D6fpv61vnb55vM VyGCLUnFw59QaXwT9CV2HkGKnzWIEfgNr7T6UGEXpXLbnpWi2GHYg5/BAl3NN5lu43z6 OlNu5utyRvK8z7bNRZSVV6pWkz75SXIizYf929EGU+IVvaAO8pEr1lejRtIw2DKYWQ0y 3pa6mB8CYMs+QLiOHsOtUlLHlB0PJWv7AvvVjvJO6lVS0Qjz9zNZRLjt35YzjdiblCfp vXIPLnKZ9/rdMLSlOwiYPIgywHWbTTLiMqx1R5XzyQPSX+wXILrrdoVbuNwSqW1Ja1+c r3aQ== X-Forwarded-Encrypted: i=1; AJvYcCWoCYUALm0NQ8+qgYJAyW+8LOQgR5caDqA8HME27pueVn2MrQig7TF4hRcpLtq6Uay6p957G2R4l3/kQt0=@vger.kernel.org X-Gm-Message-State: AOJu0Yz+GAHz2boRbb+5lBVkh7RPaaWeseibL3HUYLoWrP6OFWB9ec+T 46pKafZkzW5pKB4JIeeWAtSvrrHNuJSFbtiUSAj1me67grgILNai7/UKIXlixaweHu4= X-Gm-Gg: ASbGncsrNeFL5PJKh0IGhJ2N6UX9AkVAwbOQi4BSGfm3iEsig6rKd+kXGpyLA4OQPJQ Qo+PAv0TUBLCs8Fd0tn5lfVSi56TcDQl0olZVAP+c1zdATc8ZKfUIypmhg0CUuCye3sT5ZwoZ9i H/kFK7wplzy56cmj+hAnoEO9B2Yusmpt/pVsR/JP6sFsfQjgcmloFKXarw7WDAGHn1PQkLqqFgI xhdaYZvu1CL80twwZR+qwzunK6n9kZXPjzoyqq4CMovza7WB4Sp6cyahrUxT22u007Wc6y6uBf6 GqgJWfHfKiODTp59SxqYVTOR72DqZRQYCNejt462GYRazkLIHenD5scSWgrq6UCAkUGmCqseD7p 6ZyPjdOKxAalrfWk7B1FDNjrvLbbZiJhdiRJDTLk9UG3yUMUTqbUXQbUDHQ0GAtne7lr1jtny4k vCW1YQOwQdN4EnbYI1 X-Google-Smtp-Source: AGHT+IGe9wchOw5JqFvcAaJbkiDOA2j0knrgH/KIUjW7jQKXW2h1mNe5JSDzAt2HhsTMSTjwyr3K2g== X-Received: by 2002:a05:6402:4313:b0:645:d3fe:8c57 with SMTP id 4fb4d7f45d1cf-645d3fe8d77mr22289879a12.18.1764435509662; Sat, 29 Nov 2025 08:58:29 -0800 (PST) Received: from localhost ([2a02:8071:b783:6940:1d24:d58d:2b65:c291]) by smtp.gmail.com with UTF8SMTPSA id 4fb4d7f45d1cf-647510519efsm7161100a12.29.2025.11.29.08.58.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Nov 2025 08:58:29 -0800 (PST) From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Eddie James Cc: Ninad Palsule , linux-fsi@lists.ozlabs.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman Subject: [PATCH 02/12] fsi: Assign driver's bus in fsi_driver_register() Date: Sat, 29 Nov 2025 17:57:38 +0100 Message-ID: <8b9819184800317a4cf1fd74d7bead2a5fab8526.1764434226.git.ukleinek@kernel.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=2642; i=u.kleine-koenig@baylibre.com; h=from:subject:message-id; bh=wRaWW24pXY+OPYNZIR5cKkkiBGL1akjSxYa2wBmqxHs=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBpKyYIj0Cf013pDcQJ1jJJrygUC3zzpnwblLUHC EQwzU9+lu2JATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCaSsmCAAKCRCPgPtYfRL+ TsqhB/9apW5scIhySt1dCdodszytXKL0ylyytMXCeimIgFZ4k/L0ycSMijw/hFUXMQJI43TfMqc vZZdzbs26qJCzDRILKplZCkNmRBa3Y6L1Ttc1L+CEsdb2VayWZGW5dq7yTyiCaLeu6FdowQaGaf K258K6q6VeyOsM/O2QIe+rim8yvdwQO7b1qpDeMZpoJFd/l4gYeWOq5MDM7iLrudia3tmYfvlFQ Ys+DAlOD4g4vii9x5Wox7Pps74C+qeXw7/Ki9jn/hjZIYOrvhWSYoV9LjXos3pqYpztkSgvY9UW xoHkHWKai0d3qXzeCguM2NQI7WBM1osvJUrn2Q+i87DdI/At X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable Instead of letting each driver assign the bus, do it once in the fsi driver register function. Simplify the fsi drivers that are living in drivers/fsi accordingly. Once all fsi drivers dropped assigning the bus, fsi_bus_type can be made a static variable. Signed-off-by: Uwe Kleine-K=C3=B6nig --- drivers/fsi/fsi-core.c | 2 ++ drivers/fsi/fsi-master-hub.c | 1 - drivers/fsi/fsi-sbefifo.c | 1 - drivers/fsi/fsi-scom.c | 1 - drivers/fsi/i2cr-scom.c | 1 - 5 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/fsi/fsi-core.c b/drivers/fsi/fsi-core.c index c6c115993ebc..e1ea1124282e 100644 --- a/drivers/fsi/fsi-core.c +++ b/drivers/fsi/fsi-core.c @@ -1394,6 +1394,8 @@ int fsi_driver_register(struct fsi_driver *fsi_drv) if (!fsi_drv->id_table) return -EINVAL; =20 + fsi_drv->drv.bus =3D &fsi_bus_type; + return driver_register(&fsi_drv->drv); } EXPORT_SYMBOL_GPL(fsi_driver_register); diff --git a/drivers/fsi/fsi-master-hub.c b/drivers/fsi/fsi-master-hub.c index 6568fed7db3c..d389856d18ac 100644 --- a/drivers/fsi/fsi-master-hub.c +++ b/drivers/fsi/fsi-master-hub.c @@ -288,7 +288,6 @@ static struct fsi_driver hub_master_driver =3D { .id_table =3D hub_master_ids, .drv =3D { .name =3D "fsi-master-hub", - .bus =3D &fsi_bus_type, .probe =3D hub_master_probe, .remove =3D hub_master_remove, } diff --git a/drivers/fsi/fsi-sbefifo.c b/drivers/fsi/fsi-sbefifo.c index 5a08423d0c7e..fde1c34743a0 100644 --- a/drivers/fsi/fsi-sbefifo.c +++ b/drivers/fsi/fsi-sbefifo.c @@ -1133,7 +1133,6 @@ static struct fsi_driver sbefifo_drv =3D { .id_table =3D sbefifo_ids, .drv =3D { .name =3D DEVICE_NAME, - .bus =3D &fsi_bus_type, .probe =3D sbefifo_probe, .remove =3D sbefifo_remove, } diff --git a/drivers/fsi/fsi-scom.c b/drivers/fsi/fsi-scom.c index f533106085ac..2eda44451cc1 100644 --- a/drivers/fsi/fsi-scom.c +++ b/drivers/fsi/fsi-scom.c @@ -606,7 +606,6 @@ static struct fsi_driver scom_drv =3D { .id_table =3D scom_ids, .drv =3D { .name =3D "scom", - .bus =3D &fsi_bus_type, .of_match_table =3D scom_of_ids, .probe =3D scom_probe, .remove =3D scom_remove, diff --git a/drivers/fsi/i2cr-scom.c b/drivers/fsi/i2cr-scom.c index cb7e02213032..dfdb16afd205 100644 --- a/drivers/fsi/i2cr-scom.c +++ b/drivers/fsi/i2cr-scom.c @@ -140,7 +140,6 @@ static struct fsi_driver i2cr_scom_driver =3D { .id_table =3D i2cr_scom_ids, .drv =3D { .name =3D "i2cr_scom", - .bus =3D &fsi_bus_type, .of_match_table =3D i2cr_scom_of_ids, .probe =3D i2cr_scom_probe, .remove =3D i2cr_scom_remove, --=20 2.47.3 From nobody Mon Dec 1 22:04:09 2025 Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 95D1C30FC13 for ; Sat, 29 Nov 2025 16:58:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764435516; cv=none; b=Gt4J6ZLWnt6/h/XMLm+GNGFo54Zg+eZBjIq4IB6QZ9MR6wDetP7bneQeqzmjVXYEQ+pCvovWwuI61gp+aA2nmPPgpffgxLYFDgWsLguSCZ+msvqSj3Ykon1vycGPijwi/lKTuJByfK00bIRRoymjvw2ms2TB0aXuK51TBZqSkAk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764435516; c=relaxed/simple; bh=z/3JVW40CX0aiChWM56FVqew2AA2quKP+Q5LAFkIOn4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=SBZRAlce7qyrwcLo6TVi7bvSjWrr60kxOxQVN39cVlxZLLZ+DaDolgUx07aXZO2leAgQo0sJ8lImUW/DmmvNIkhwWwi8VUjJJN9rW8a1ry51Mu8HW9n2Hv83sINPUDFXMbTMLLY+dnvgeACnr9Rw/0ZzsF4BV+udubrpuBrEV0Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=l/F1fbc9; arc=none smtp.client-ip=209.85.208.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="l/F1fbc9" Received: by mail-ed1-f54.google.com with SMTP id 4fb4d7f45d1cf-645a13e2b17so4450079a12.2 for ; Sat, 29 Nov 2025 08:58:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1764435512; x=1765040312; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=G/DXJ/onigpflOgZSB00x5l3wftqsveAzjxO4xUOspk=; b=l/F1fbc9GNOqjH1QJqafuHPi0d5aBW8IiU0cVdCLGdOwVn5T6dODL3AV0Jp++lW+mO +4Yi8bnIHhY3oVYaLMsguUYb0DmgtL2Xe6tBDv8san881baoE7eFAbJmIjhcySxdZybC qhta+Ek9KuZkSEqREHcnb669mn7UVqR5crddC7u0NQPOjX+yLv8NbdVlkMbLMxAWlDFH hOiFUzIjskPIXtKN8P2jeAwWT2wfKpOZFnKrtYDrF8iOUei4YxU1EXFCqvagMK7DUTGt ipMVHDGB51+3FFcY0wKF7MdaJ1/hK3pJpkwxh8VRlL+QVXSj/yIMMz576KdTTpgGc2Xx E9aA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764435512; x=1765040312; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=G/DXJ/onigpflOgZSB00x5l3wftqsveAzjxO4xUOspk=; b=d4iaCwm20bWvFAzyb0Lyp9ImJjRPAyde7Nni9cUwDM3CTPPG8OfQHFpq5QcsIUw2Tw nsX+uNLy3iQYLr/UaxWr8ccJ3+xD2f1mZ1uAUnzZ2j6JXerDy0RoqfH3G+cCnnUu10k4 PjTPRQaYp1frBGRgRbCWiYtYE7m15lgxsPmqTBb6uv/CpbNqC5yiWJVP7NRODYaJ8eJU pGaFnjY3VS+TXFhZJMF9IvCpy5piOwFMaqmzBGhvBD5kyNx1ncDtvG0bdBnn1ZBHX3nF l8lRk2tXgW/4tmOAr+YhZb2RpuoOCjYr3Ja5vpJJjjDZPWSS6z+zKE4TlDXYRhOVDeHY ofIg== X-Forwarded-Encrypted: i=1; AJvYcCVupomux1Luw2uke9cFXfcAFPOWHXskQiDqLN5t/W6ybB7NaNoVSDf1KgVEC9Z4LdkqK+eWAiW0e+LwNd8=@vger.kernel.org X-Gm-Message-State: AOJu0YwptXoRh58MxlV5YMkxzfQHFtUj/Y5d0HecqcgINRSLPAlaTDVO tFDO0FOhCOVtPby5/ERMSXn/rulRzrtT0s7u6dzKWXOF1EszYwjkUIOgr+4xrv41UmzROl1+SKn eH5gR X-Gm-Gg: ASbGncsEYCITTAEPYhpZbFrp29wHyTRPakkicI3Xv4cm7rYoi2KECtgdH9if6GwWIJ7 TTKZDFppCwhVf9/CswaJ+t3De88a3jAVje7fAchaY8cbbZZMKp7teQEJwXGxD13e4SekFSZ5xu3 tLpWRZMj0IkBpVh/w+3wpHptp+0juxybg1+AkKxdhHXwAuDp9bn1fV8vta7wxf8p0hVEMMJ3H61 YMfCHUewoCdrYti3z82vZwmhRu8KnOkDrOdapThc0Wtq8i5t8s1lW6MV0vOOCVJlVFaHVtTaOFV kTByWJY/PtXxabJDBDR1reJR/LygYMQLMeeBX20jgYwCs93Xmr7+fu0aXAvf7IqJG9nLviA7dbV CLZxvxs53FxFAFaAj605M0hy6f5E3eg4xYN5z2sMz2vu+rU7uUMmxqDrrgDdWh6VV9tLyHK3dnT h2ZTzNxhK0aeZ5aAe4 X-Google-Smtp-Source: AGHT+IFxXmxPq7GQGTaQYd2mQENrOpuvBXPn8/A7tEDb9DlCMA7oTEm3MCCoiXkQeQhaRxipSf11oQ== X-Received: by 2002:a05:6402:3492:b0:647:5fbd:f065 with SMTP id 4fb4d7f45d1cf-6475fbdf099mr4787014a12.32.1764435511952; Sat, 29 Nov 2025 08:58:31 -0800 (PST) Received: from localhost ([2a02:8071:b783:6940:1d24:d58d:2b65:c291]) by smtp.gmail.com with UTF8SMTPSA id 4fb4d7f45d1cf-647510508d4sm7124419a12.26.2025.11.29.08.58.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Nov 2025 08:58:30 -0800 (PST) From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Eddie James Cc: Ninad Palsule , linux-fsi@lists.ozlabs.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman Subject: [PATCH 03/12] fsi: Provide thin wrappers around dev_[gs]et_data() for fsi devices Date: Sat, 29 Nov 2025 17:57:39 +0100 Message-ID: X-Mailer: git-send-email 2.47.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=898; i=u.kleine-koenig@baylibre.com; h=from:subject:message-id; bh=z/3JVW40CX0aiChWM56FVqew2AA2quKP+Q5LAFkIOn4=; b=owGbwMvMwMXY3/A7olbonx/jabUkhkxtNW7dWVwH6mVKsvb6PQ8Q8/S4r2W+cFPv2Qy17KXnS mv/nrjYyWjMwsDIxSArpshi37gm06pKLrJz7b/LMINYmUCmMHBxCsBEZmlwMGxn7Izd4cI/WV5g SuG5/BgJqVideNX5qlKc2gGn3+WlVF+dpFLIfMJRIS50wuU4oSjbhzOUP91wnfeTsbFldrvXov1 WpuWl01c47V3uVsFhWhJ38+KEgyqvknlNPnbWX61OLT4+dc5Fnah12d21JcK+PskarzJffdO6fT CE47LefN4bu25b5beZBGaE8BQbv1HPy7B1f5QYL2V8eLP1VJ8Orz9mM7gOeO8y63ptKRDxSz2he o5pccykpm+vbifctVuTzG2yUnu27Im/3oJXUtpuZvJ6nOL3dfctalHX7Yy8cIZd4oC62pHm1B6p qKPBZr+0e45bhvCoxJxIWGCyUzru6EOX3UmPjjwpEQAA X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable Similar to wrappers for other subsystems provide inline functions for fsi devices to store driver data. Signed-off-by: Uwe Kleine-K=C3=B6nig --- include/linux/fsi.h | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/include/linux/fsi.h b/include/linux/fsi.h index adea1b432f2d..05be75869a69 100644 --- a/include/linux/fsi.h +++ b/include/linux/fsi.h @@ -19,6 +19,16 @@ struct fsi_device { uint32_t size; }; =20 +static inline void *fsi_get_drvdata(struct fsi_device *fsi_dev) +{ + return dev_get_drvdata(&fsi_dev->dev); +} + +static inline void fsi_set_drvdata(struct fsi_device *fsi_dev, void *data) +{ + dev_set_drvdata(&fsi_dev->dev, data); +} + extern int fsi_device_read(struct fsi_device *dev, uint32_t addr, void *val, size_t size); extern int fsi_device_write(struct fsi_device *dev, uint32_t addr, --=20 2.47.3 From nobody Mon Dec 1 22:04:09 2025 Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 465A430FF3C for ; Sat, 29 Nov 2025 16:58:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764435517; cv=none; b=FIqCDP8hMpSWNAhL+v/YJaVfS1VdcclXNgkflJeGd278hj/iQ+21T/jfTxOuUHf9SGxWMoDraM3a85+xk+hFPbi9+aPPtCFtuqQKiH5/Vn08wFbLOo/7jixrSAWuU6ZofKDM54hIvXuoZE2Rzlqpg7bQ+N9d4FepgD6SNpFfguI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764435517; c=relaxed/simple; bh=1VfHxw2ik6pzPD8vLs+mn8BWmuJDAturdWzRRyIrqd0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=MFANOwPJwWuFH0VvIO0zHLhdexJfHaTX9ndfc1CsUrBIpKXYpg+dprbM+DqwQuGNorjghe+SVZSSUJaVgGm/rQS9Jq1hLAwXte0zF1cYv7VFUBv1aIbC3rOT1k+sudWDfn2oD+pdx1qheiD2BcFyt4iiVzEPt6pAPO/Hg7Syla0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=f7NYHYXI; arc=none smtp.client-ip=209.85.208.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="f7NYHYXI" Received: by mail-ed1-f52.google.com with SMTP id 4fb4d7f45d1cf-64198771a9bso5421680a12.2 for ; Sat, 29 Nov 2025 08:58:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1764435513; x=1765040313; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Gr1otfYaqpnm7bjSkZRheFMZkv0FIFM3TuO+TEbpsfc=; b=f7NYHYXIVF+qRK5HXZeSUpS5Dp4hNqsO4zS3xjXTUf0B+/uSv1atUzAwjA58sIIRDF qJa7Nub8b7y0fFZDKEUzCmgrehyiNsTFuqkLn8I5Vx7A7MAaY4CO+ZT44U2c20nLXW6Y mg5oNg7wEmXJPEHZYXOiWRqvqCQmaLERCd9C26lLCiPPwUohwQmBi2UPlo7p6M8p1Tvn YA3ze/Tlkcpcb7svir8hMkpsqdt0uBI0I9cwXHrcP9NYoeQC0iM5Aq2/zQaxXYFP/jJR qboz5I5LQL0B3nFZI9P5QbtHHD17kBLO6kw9pU9bM9Hnyq6fXecV7cDpVkdP0t/yA+N7 txuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764435513; x=1765040313; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Gr1otfYaqpnm7bjSkZRheFMZkv0FIFM3TuO+TEbpsfc=; b=hcKpNkpdSn8a0oD1py+pV3sW5yKoUzZZguilmbVGFhMDQ5L1Z4TgBPoDLuXciaDUrh qcBLgTPjvTAeFKO3PTGEj8p3la3Tvz8OAEoVqBzqngsCmKjUu6inXXqw40QX2ZNXMKR0 KGjQ605bk++l+2LWVOE1RHcd1OFAc4jBF7bBXg5BhkqzVA7rZwMIWQyzWF9U9fFfaJS3 WpPTCsYIEtrOcxwG5EOnq46lMeVrifkJagVekemXXotFIVAh+4sVN6jqgGwaZwYh2zsj 6DvZM4PWDkN8W7O1od+N9BlwpQOSGBdtf3yvvQ5c8BKLMMooc6J2JeV++gdL2zhSyecj ZRLA== X-Forwarded-Encrypted: i=1; AJvYcCWjbwquPdyKvYqVmbfb2vWaG9iwITuVaa8+uQRVAwOd4A5LKcDipnpKDd1at3LvzMvndaMBFG9RvDSUmd8=@vger.kernel.org X-Gm-Message-State: AOJu0YxxdpQQZqD2DFq28/avcVhz1uSZruRIQ9Q4HOVZLyIuoR18H1Fy tipFRjW84f7/Pqgw0tTZ58CMyRIZWPYQojb3UjcRTq8NuZmo2UB8FbTP9P99CUDjHtg= X-Gm-Gg: ASbGnct5vLHvD5MigOKWdxa1GsOijiiPeZDGpPcCNHqHHeIAPOJyodnsNEQdorSxY2I b6+VC/oJ5wzQMOTlPiV4MUzYw/YFwKnIwsDgKhGkphHeRXsAj/4+4A/RHkME4tKHcYQ6vgGMJyK KfWGhjad2u9Et0ndQr4aV4s/Q/velpKUQiNH82bREHfvmdy0jG0N7pXipxXP6GSQt9ED9x+/aQ/ NIhUHQA0aPbY0UIywZauo4b5C1IjplVhCYpUe/QKVcENxza166VxNvASCIRrjThW30M98EmM/UP 0j4v3vQHwCxRCQJtwUpCn6zQyO2M9wEQd05eje1fxHBuldDfovfFE1/PWlxgOjg7yCBG7QN4L6b qyENfiHmSHLRyZDncI9TUdEKfXHwg0GQHqKk1BoZ+GIDNWiz2qgTnuHEdR1OPOaJQKnoQcAhL4J 3KV0XR7keXal75dK2p X-Google-Smtp-Source: AGHT+IFKnLXqE8LRIlt2QVhHOKoMN+oTpxrL+57F7QBEnjRT27+V6LIYdrwq+mi99tb4ALfJSxXVkw== X-Received: by 2002:a17:906:f34c:b0:b73:5db5:b6d9 with SMTP id a640c23a62f3a-b76718aab35mr2340211066b.55.1764435513394; Sat, 29 Nov 2025 08:58:33 -0800 (PST) Received: from localhost ([2a02:8071:b783:6940:1d24:d58d:2b65:c291]) by smtp.gmail.com with UTF8SMTPSA id a640c23a62f3a-b76f5a4a652sm742627266b.65.2025.11.29.08.58.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Nov 2025 08:58:33 -0800 (PST) From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Eddie James , Andi Shyti Cc: Ninad Palsule , linux-i2c@vger.kernel.org, openbmc@lists.ozlabs.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman Subject: [PATCH 04/12] i2c: fsi: Drop assigning fsi bus Date: Sat, 29 Nov 2025 17:57:40 +0100 Message-ID: X-Mailer: git-send-email 2.47.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=750; i=u.kleine-koenig@baylibre.com; h=from:subject:message-id; bh=1VfHxw2ik6pzPD8vLs+mn8BWmuJDAturdWzRRyIrqd0=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBpKyYN8lBrGJpOMDv2bj2UXkW6vOeHEDQSWIxFR +fQY+otSveJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCaSsmDQAKCRCPgPtYfRL+ TjqhCACJ26AKCTEQ2AdYGn8TW4BjKP668+yBDwJOS/VEho+vaICy9AGZPulA2zsc7SyxgONX9UQ WByf2w5LQ1eNkxcYyKRqCPaG2XJZ3KrF93BTAD2LOt7OcwuD+1SDMMvoRY33JU8Lx9T8/2x7U2r dsLH9479cCnr9qM9gw+mt4en/auHBnxLEP1utO6n9UkLIPTFenquh2ydFCF8mRHq3082Lrd7G9B h8hvNdEtNYXz1+e3yguVT9Wl3I9PkXpl3/KPgqt6EXXKe93KiMjm9p685un7xZxJ8zpH/wdK18j n3RjFo1f2KA7qNeCBuBr/tdll8V4RQIa9tdBGt2eDa/BtZPv X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable Since commit FIXME ("fsi: Assign driver's bus in fsi_driver_register()") module_fsi_driver() cares about assigning the driver's bus member. Drop the explicit driver specific assignment. Signed-off-by: Uwe Kleine-K=C3=B6nig --- drivers/i2c/busses/i2c-fsi.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-fsi.c b/drivers/i2c/busses/i2c-fsi.c index ae016a9431da..e98dd5dcac0f 100644 --- a/drivers/i2c/busses/i2c-fsi.c +++ b/drivers/i2c/busses/i2c-fsi.c @@ -763,7 +763,6 @@ static struct fsi_driver fsi_i2c_driver =3D { .id_table =3D fsi_i2c_ids, .drv =3D { .name =3D "i2c-fsi", - .bus =3D &fsi_bus_type, .probe =3D fsi_i2c_probe, .remove =3D fsi_i2c_remove, }, --=20 2.47.3 From nobody Mon Dec 1 22:04:09 2025 Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 05C083101A0 for ; Sat, 29 Nov 2025 16:58:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764435520; cv=none; b=uVcsESqlV+8bDdgJutcPOIcHgVMY7prc3sHcg1KeLkHnbJRagNRAuYbMDPYl0KS2rK6TNumy2gZS/EIo7OmPJmZU5K/Yo7cJMCQVCvBSxSvPYNZbbRI3Ml9Gh5mCGID8lBHKRasfkPKphGHmNNihzw2Ee44nCsnc296HoZN4h1Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764435520; c=relaxed/simple; bh=AVA5GFVBkRs1wbRpAiu51ZHKLu14kC8JNNO4YtqCsQg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=MztLdVPnyfghX6Edo8MsaRtiO73Q7ktQzYNHaSnUwvI6sNvLS8Am1PTpFCKmNZvyHkHEbAIsq4Xij80MEjnjVzzF5E3HeItMWRG6EAUu9AQn7qX1SpU0IxBjOHtDBd2Eurd+qmruvkksrxnLoC8ydyAgePnuYxwrxdpToDw/41c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=Pu/IOCbL; arc=none smtp.client-ip=209.85.208.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="Pu/IOCbL" Received: by mail-ed1-f52.google.com with SMTP id 4fb4d7f45d1cf-640c1fda178so5392991a12.1 for ; Sat, 29 Nov 2025 08:58:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1764435516; x=1765040316; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8yIYJ4hsA2H8VindlpqoF2Djje2uUDv7uh8NHitowKg=; b=Pu/IOCbL47hYyLyqpAIALYv0djp084094+vFEuHV9/KoMVtu/Sjg7YVkUM9QfWxbaQ 2aiMX62TDjZ4Zsa1pZixJyxk35BVL3LIozLe9XbV0TzdUqBHT1JdCsjpFWGXWc/p1HW8 ZVK7Ehbpe4tPTJyVApqAKsq7c6RDX5tjSxI0EYVFD/HZGHk5R0QOEkA9GCbig65dxE8D u4z6a9jRMlgdlAj6P/RVWw+dT7SIWNDXY3ePpACG764MwY03Q1VglAR6Iz1FW3PaBST8 j0qnqZHRWmThzhzSQJHo5/l8XqM+R21f/MzVphe4o924/hmM80exh8TSfIkYI8WlJsDx KzTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764435516; x=1765040316; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=8yIYJ4hsA2H8VindlpqoF2Djje2uUDv7uh8NHitowKg=; b=fFvr02OPEwtVtLvJiNtmrcX5IKH3v9rFop2ueGD2mW/pyIRYTO7xE8BztLiCiV1WsO 3AzzcfbnBRlHwv91fSUMG5HGP3XLjcWMQZ1r5MWAR3oX6sYVlueJwszg3JPwhqcgwygz 5NVV1XrWCtCMfaK10YYp/7w7CNA1uAW3anSveHH1AJCc2lgKJKPj/LW0Qe9EmaTGOiY9 IuOY6NJtUuiXgv5M2FBJ65PGXhOnOl5qw4a8VaNbmWw3vZHNlyPkQpoIgUbZirzP7zOt xI3wu94XTHyuSvDREWQKT3z4gy7rmV9qzAC6xflU1jBv8dd3iemMF3n4tV0UcEpvMdui S9CA== X-Forwarded-Encrypted: i=1; AJvYcCVWhuVRkvz8GF8YKMXpkaw3HC5/40MkYMRb6d4NgQ3yUkHXyebIpe+7wGbEWCk3XCHcnpiMP4+zd1jvVSU=@vger.kernel.org X-Gm-Message-State: AOJu0YwgSABgM9dExY5YR8LdzpwUqQwCEmtqj873G/LJN9zkYQq32oJL HXjlD/VIF4yM5RbMz/4EpPCIMxOpAZGrxuiBYj7oBg22Tt/qXULBonIGYaKSqvUtqtLKrIPZkMm rMPiE X-Gm-Gg: ASbGncttbIgzFcPZITQP7NjvKZzvUNvOU2tTjIX2Moy0XNQSyhbBMRbkgle3oDT8KPm Ny8KAckVAYCfoICuSbA8HasA2Pzbnjs8gHKUwAAmDIgC5DTG6Xnh66i5//TJE0K776ByuAABjk7 g8aLTMB+72R31wXmvbPz2ov7oqM41si6BO2ENPkB8t4nWE2KW9JReDuxFq7BxT+bx6xbTvUj9pV IeaR+oz3PsY2+iEU1k28ZgivVGvM9NRlGKv2VbyTTgjz4CXibW4SRgFimxzWTYbmJ0x74d42EM9 Ye4kAYOqL8hFzpdqQhAufjXoypa33nW/MpJXg5QwGiSMyxJGJPHJPsudi5yoLZ8yIA9DPX5TTyP 3kn6LwZ9RGe0yNc3vVi6ucz1n+7tFttdgxXBT8N23iGlaiwSt0Vs6kgZdsuXYxDkhn2Vk+ZJOzC gLgwqxHrRCT0G5gNNN X-Google-Smtp-Source: AGHT+IGIuMdvH/1tKC0GuiX7Gt1dCZsROagA1pC0AM3CevNgSG+kcT21e2Bdl7GfR8yr/m+sJVrOFQ== X-Received: by 2002:a05:6402:1471:b0:640:9993:3cb8 with SMTP id 4fb4d7f45d1cf-64555b86c99mr32037434a12.5.1764435516385; Sat, 29 Nov 2025 08:58:36 -0800 (PST) Received: from localhost ([2a02:8071:b783:6940:1d24:d58d:2b65:c291]) by smtp.gmail.com with UTF8SMTPSA id 4fb4d7f45d1cf-6475104fd7asm7137690a12.23.2025.11.29.08.58.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Nov 2025 08:58:35 -0800 (PST) From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Eddie James , Mark Brown Cc: Ninad Palsule , linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman Subject: [PATCH 05/12] spi: fsi: Drop assigning fsi bus Date: Sat, 29 Nov 2025 17:57:41 +0100 Message-ID: <948f0de217633462f79a3fe2110f8f168f19dde6.1764434226.git.ukleinek@kernel.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=690; i=u.kleine-koenig@baylibre.com; h=from:subject:message-id; bh=AVA5GFVBkRs1wbRpAiu51ZHKLu14kC8JNNO4YtqCsQg=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBpKyYPHjAHhF+ULcOvvkqkGdGH717OEbRZMKbee Nkfi6RhElGJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCaSsmDwAKCRCPgPtYfRL+ TtsBB/9LWPveK4RW7ktobXwpQpv25VxzxhtLIr6rz4CbJG89rgYhWagqevuJ0njOqFm9bYv+RaM pKrfCvwrv0eRd8YdPtU1nksoMOiXLXZ/AYmE0fdrhpoSTblASkWmXifoSqJbpxu1c1njk12e0fc o15kc+tqCK6cJ7mnmfsCJsrO4YZmqVnAVRgY1Q8htkCx9HdCiytvjDI5BdBsYhsimijY8FtUe+y RoR1BeJ0xFXvfi910r1fySZXuGy/BNuqcx/kuJkbjqN8olbBmphjwYl9M46l65QX0DDLmQLnegf 4zbSJSp0VX45LtXHfh9HOe5sZwx7+zXRmPrVAA9MsW2wAKm5 X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable Since commit FIXME ("fsi: Assign driver's bus in fsi_driver_register()") module_fsi_driver() cares about assigning the driver's bus member. Drop the explicit driver specific assignment. Signed-off-by: Uwe Kleine-K=C3=B6nig --- drivers/spi/spi-fsi.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/spi/spi-fsi.c b/drivers/spi/spi-fsi.c index e01c63d23b64..f9c15b99dba5 100644 --- a/drivers/spi/spi-fsi.c +++ b/drivers/spi/spi-fsi.c @@ -595,7 +595,6 @@ static struct fsi_driver fsi_spi_driver =3D { .id_table =3D fsi_spi_ids, .drv =3D { .name =3D "spi-fsi", - .bus =3D &fsi_bus_type, .probe =3D fsi_spi_probe, }, }; --=20 2.47.3 From nobody Mon Dec 1 22:04:09 2025 Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B53D230B512 for ; Sat, 29 Nov 2025 16:58:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764435522; cv=none; b=k4jTtFx1HkbX/4R3frzkKXvvDnPLXDM9EvkJBd4bJs5laIg/JFrp7eGX05zbpvT3l2VF3oiinluzJ5YnwT88uwBFxfbI/+3WFOyMuMyx3LbMwZcsQOcTUNbUgvbJDoI09U1wZ/bkJJbpMAEZXl4WVjpsqwHvoHzbkaLZ2PgGy9s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764435522; c=relaxed/simple; bh=y0iUAnme9ancpNuL3b19N4isLf/JgWSJ8VGbTxQzl8s=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=cR6R9TfEE2H89FnnKjQk1KhxjIZSDWaS93Jp1v0U0lQs+5Sf4aXVB9BnDOZZAIIP2TrmX+JIa8wIwToQRlr5WpmLk1V97sUTkvYsMi5dN620quS1cAq7CgjyDlkwOxiLExYjqfo1Og8m1YVXVGE/PdTfATiulyzdNimCETymA6g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=wrZi3mb1; arc=none smtp.client-ip=209.85.218.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="wrZi3mb1" Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-b76b5afdf04so500849866b.1 for ; Sat, 29 Nov 2025 08:58:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1764435518; x=1765040318; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lRP+naOibaSUBbYH6cwwgyLh7xe70Jwd0KUP+d+yfD8=; b=wrZi3mb1dlr719iooubeNTyikoylTsa0Maa8q42X9bM2p02nyeGuHm6IX3lcl+lSWB sE7bC/3i9pBwZh40wU/q8tjuQ4d+wHwwL/A+kmhLI075LBoFsfl5Vn/fP2g2NfKo9Dnn BjBPpdJIua1xR1EJptTKcx4y1frWA/ywIgBfkLxEk4NZV0jtiRslZRQ4ZXa+jvviMuIo yCu7HZlvt/gWRwkW3kWXXeS9cnN8hZ9RXERdrgQI/Lg8Q1+B5gX+CVi/KpzDz6iswShj XHfBdc1jpUYFNT0YNH97QzjDyxtHPMz7rjuNy+SK7kGjrL6vpvZo9aVFKSeeKLFwXQwb OhnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764435518; x=1765040318; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=lRP+naOibaSUBbYH6cwwgyLh7xe70Jwd0KUP+d+yfD8=; b=tT/5tm5PbnNhzd5VgzlxfFSbUOd/yKMidnNT87FZND/SlBzT4kE/ilueFDS1ZxpWo1 ffWix+CC1KqWt1+fPlqrkqPo1YEqDP3KiydE4Jbz+3jNjaWCD3VYKNmyrg6ZOsqU4Uf0 w0BnrSc9no52mQzUnK05d0GsBzotU+HuRZBf5NzLbfUoeA1T1f2fpX99A1CSeTc06r6T r+cvp1Zw9tvqR6WwzJWk2A8e+a2SgpmKc4o9Acz1EMNLML1NmjksX0GXoHfcb8lvsxNL dbh17ySi5E5YPT1IR0Gn3HtCOf5qLqvmVRvBbH9/fRWx9zh8+MVBS3ZnBx10khFCiTyH JdAg== X-Forwarded-Encrypted: i=1; AJvYcCW5gQbM+ogtqYE9eOBqgLcVn9KtRhWrxgQGyDK4uLXsrCjQ/qhS4fD2S4FGTnJJvvSMApwjBgiyqANt9aQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyMscFiDvmOObTfsn8dpRnf9SGOnLyR9cRA37ea5x5L7jGbFHKx /lWT6MQAV5p9OnW8IjpOBARXaAQFjL+c5t2vCKO+VT5WUHvlypFpppfLEHzX7/GEa1E= X-Gm-Gg: ASbGnctjx0oYh5wnbIFJ3xSrD1XgnkAoLAZ0SCGVn3xjVvZLetXJfb32Rmozl0+5CwH iz98kJDfBTjZbud8VphJ5eQO4+auq/3FHVOo2EzuIQjGK1dbOTyeniff1ZG6pJOxWCwWkoe3tei DX6qHtPxGiuvf9jaVB0IouBjXxqJ7JAdY+NzPLw3Nvutxip6foP+60Vp67AbNX7tkCeNKVCgwE4 owh80SdXZ4UACwiDYKmeqXYYURofqs9CRqvKyZI39nhYG4heC6N2z0on5Imo7i648v5xYoQozM2 Ah0HqqnBJcbstbR97BU7YP4ePz3w3OPwxPz/QkfAl2/l5Vr84/xmnUkDlRFkdDqvZ0MJOX57uDj 09YHoGzXYGBBIJM261nV+2lwuOS6iUByRgWaQjvMajydJ+9c0rHOMV6qKo4vzKSDkFvGjlc7ddX /CYm1h0yrVpDrKbqW8 X-Google-Smtp-Source: AGHT+IHk435fyWGaAlYu505n4ZiLfYNLu4Dv/x3eLai2IZhDkiOJ/FAwb6oAn2fAPeTbO8YodthfmA== X-Received: by 2002:a17:907:6d10:b0:b77:1233:6f32 with SMTP id a640c23a62f3a-b7712336f9dmr710978166b.48.1764435517910; Sat, 29 Nov 2025 08:58:37 -0800 (PST) Received: from localhost ([2a02:8071:b783:6940:1d24:d58d:2b65:c291]) by smtp.gmail.com with UTF8SMTPSA id a640c23a62f3a-b76f5a4b926sm741307566b.68.2025.11.29.08.58.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Nov 2025 08:58:37 -0800 (PST) From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Eddie James Cc: Ninad Palsule , linux-fsi@lists.ozlabs.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman Subject: [PATCH 06/12] fsi: Make fsi_bus_type a private variable to the core Date: Sat, 29 Nov 2025 17:57:42 +0100 Message-ID: X-Mailer: git-send-email 2.47.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=3429; i=u.kleine-koenig@baylibre.com; h=from:subject:message-id; bh=y0iUAnme9ancpNuL3b19N4isLf/JgWSJ8VGbTxQzl8s=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBpKyYS7dfRkhNI/Sbvf0he6nFANdJ4uQvA8wUIc k4Bidlit9GJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCaSsmEgAKCRCPgPtYfRL+ TsdoB/9i978oUBhM2Kkwr6Aj5PdUmZUxKeynrqQHbnjl9tbdFc9rH0y7rZqjUHNCAHUjuU+lSBX ft+4APg0THAlSFVYtFiQpeOxDzx4tcNHs7z++fxmWvdHRmXIKj2kBwHDIp66306K6DCRMug3E/P ZxiSbv+VhI/tSGMerYm2sCBz2Db8ONqQx7xOn11HocMninwZ51/lyo77qxKxf4J5S6D3n88rtWw S/ABMW1yIgANi9MN7xjieFXelIgFplBYAZAe7rhyFfQw/yKWyXNasV1tWPiFHqjs+mk5a5dXY5i BxbZO2fY2QX3Mrwh6avsLG6kjJFtqD2oj3KVinvcgm/SkZ8d X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" There are no users of fsi_bus_type outside of fsi-core.c, so make that variable static, don't export it and drop the declaration from the public header file. As there is a usage of fsi_bus_type in fsi_create_device() the definition of that variable must happen further up in the file to not have to add a local declaration. --- drivers/fsi/fsi-core.c | 67 +++++++++++++++++++++--------------------- include/linux/fsi.h | 1 - 2 files changed, 33 insertions(+), 35 deletions(-) diff --git a/drivers/fsi/fsi-core.c b/drivers/fsi/fsi-core.c index e1ea1124282e..4e60d4b17c11 100644 --- a/drivers/fsi/fsi-core.c +++ b/drivers/fsi/fsi-core.c @@ -100,6 +100,39 @@ static int fsi_master_write(struct fsi_master *master,= int link, uint8_t slave_id, uint32_t addr, const void *val, size_t size); static int fsi_master_break(struct fsi_master *master, int link); =20 +/* FSI core & Linux bus type definitions */ + +static int fsi_bus_match(struct device *dev, const struct device_driver *d= rv) +{ + struct fsi_device *fsi_dev =3D to_fsi_dev(dev); + const struct fsi_driver *fsi_drv =3D to_fsi_drv(drv); + const struct fsi_device_id *id; + + if (!fsi_drv->id_table) + return 0; + + for (id =3D fsi_drv->id_table; id->engine_type; id++) { + if (id->engine_type !=3D fsi_dev->engine_type) + continue; + if (id->version =3D=3D FSI_VERSION_ANY || + id->version =3D=3D fsi_dev->version) { + if (drv->of_match_table) { + if (of_driver_match_device(dev, drv)) + return 1; + } else { + return 1; + } + } + } + + return 0; +} + +static const struct bus_type fsi_bus_type =3D { + .name =3D "fsi", + .match =3D fsi_bus_match, +}; + /* * fsi_device_read() / fsi_device_write() / fsi_device_peek() * @@ -1359,34 +1392,6 @@ void fsi_master_unregister(struct fsi_master *master) } EXPORT_SYMBOL_GPL(fsi_master_unregister); =20 -/* FSI core & Linux bus type definitions */ - -static int fsi_bus_match(struct device *dev, const struct device_driver *d= rv) -{ - struct fsi_device *fsi_dev =3D to_fsi_dev(dev); - const struct fsi_driver *fsi_drv =3D to_fsi_drv(drv); - const struct fsi_device_id *id; - - if (!fsi_drv->id_table) - return 0; - - for (id =3D fsi_drv->id_table; id->engine_type; id++) { - if (id->engine_type !=3D fsi_dev->engine_type) - continue; - if (id->version =3D=3D FSI_VERSION_ANY || - id->version =3D=3D fsi_dev->version) { - if (drv->of_match_table) { - if (of_driver_match_device(dev, drv)) - return 1; - } else { - return 1; - } - } - } - - return 0; -} - int fsi_driver_register(struct fsi_driver *fsi_drv) { if (!fsi_drv) @@ -1406,12 +1411,6 @@ void fsi_driver_unregister(struct fsi_driver *fsi_dr= v) } EXPORT_SYMBOL_GPL(fsi_driver_unregister); =20 -const struct bus_type fsi_bus_type =3D { - .name =3D "fsi", - .match =3D fsi_bus_match, -}; -EXPORT_SYMBOL_GPL(fsi_bus_type); - static int __init fsi_init(void) { int rc; diff --git a/include/linux/fsi.h b/include/linux/fsi.h index 05be75869a69..3e3a8f3adac3 100644 --- a/include/linux/fsi.h +++ b/include/linux/fsi.h @@ -78,7 +78,6 @@ extern int fsi_slave_read(struct fsi_slave *slave, uint32= _t addr, extern int fsi_slave_write(struct fsi_slave *slave, uint32_t addr, const void *val, size_t size); =20 -extern const struct bus_type fsi_bus_type; extern const struct device_type fsi_cdev_type; =20 enum fsi_dev_type { --=20 2.47.3 From nobody Mon Dec 1 22:04:09 2025 Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E145B3101DE for ; Sat, 29 Nov 2025 16:58:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764435523; cv=none; b=VpPl+oZjXvOBQGCvK7fUE1zX1ADf3v4pRR+4zmaW5tXo608DetuMHYhzkA25oBfKmLZMERgrzsLXlBb+kDZ799AhCh80CvFnSwG6mg4T78pgAPAou9Q8DxhCp1qOU6Dz5jYE6SCCbZ7kECRaAO5BNBZBkJCPpfUxxB1uSQ4RvUg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764435523; c=relaxed/simple; bh=5Ko9OFc0vr0gGtFxjBBAa/QVqxQ0ngFCXdaNCP4hmfw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=SzcbvDoFwt8uizvamOzu8OnyCe8Z91sMoCENJgflSgoDS/AVuvV4faYmZOstrnE1dBdLNoDXOSPK7WVgHisONoHun9JfaOl/y++BWLQ3rb6ajUXCb/bIVRPmSvGprsIlHl8ipYJg5AzeoMli0XkwOL6bcoRgiA06NAiA6cEXRLE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=Aefwkf83; arc=none smtp.client-ip=209.85.218.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="Aefwkf83" Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-b735e278fa1so620163666b.0 for ; Sat, 29 Nov 2025 08:58:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1764435519; x=1765040319; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=JLhX8tQBG7Ugjs6QPYIozvOuqN85HAlCvTON9W26PZk=; b=Aefwkf83D7tSMni+p1eUfP5ONEkQOeuJoOFRWGafuTTGuoAYpLEi/NqlO6kcvr1Fxh PMrqpD1Pe/mLt8lA+XYN/HY9XaxUj8MFVa+wj5mNSADLxZVV81EaD700SIdFT6iyAEYu 610fG4vTKw6SRdehcp/i2QnuVEG/jyyPVRi7wF1n9NvIoSozk0YO1k4YIUPdSaWD65wm HJ+jbepKxePK3iqsqPOKZWB6GS+CM0mgUXr5ngu0vPssJI/4AvISDbE5fVNlWze2ZEq1 BqzkO13zBmClGhYUxtxJlztVTbFzRwW2q4CzbFvKFazzx2NDXMSo5CRe9BUjyIxFTXnn hJTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764435519; x=1765040319; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=JLhX8tQBG7Ugjs6QPYIozvOuqN85HAlCvTON9W26PZk=; b=DSkRY2i77ZZ3lcuIcbaNjx9hypDXEkvLp8il0XRNkK+ovZNkzNwOI7bqlLoz1fJgv4 /5LpdUelkfWRt5JFYaTJrWsbfNXXWU4qBXpLtO9KCUMcjAK30wNJzBmXi8RvsBRmaaSX UkYrxNagXSzCFD0pidTy6ncxZN0AqOB52riffTRDOPYFNj5myVPDkRc4mySNw2pbWXgG Yhm9SlZLUUoTp+8JIymDXgTryHsqHJLWE90A8vntiax4DgSkC/USB06uDDZ7M1X3Vfx9 CbEjMx65W7RZl34QFC/yVE58NcN8bXKy6pB2mrYEQJBuhs4foIf4YDHWgpcCzn1C7zg/ Rl9g== X-Forwarded-Encrypted: i=1; AJvYcCU9OzdgRuAv/T7oaKUSpZlePp49Hq1xPOK4iFE0l1e+9JU6LnRQucXuoS1+9H1pCS7NIS4XIU3b8VW9AqY=@vger.kernel.org X-Gm-Message-State: AOJu0YwB9MrGU2jqrehRp7OeqX+PWeB3ZvG0bFnCaQ/50vV2IRitZPbP zYzRmF9/IrUdXCjw6KTlzIWL8PuyNIehGN6QohhNsrJH04t+NeY5gi+WvvOMjk+8oNI= X-Gm-Gg: ASbGncsmicg7/oN26DXs0mIk8vMRKkAxBItSW5g6NN5a455JpdtQVPMVPrQIgOKKh67 RdSPPS65WJkDYQ0frPiqxOZoyzvgDDBXPOsId+j1Qi0k5mD52xAZgNKPoNqxkC0pKXfbY6snpnr /0+RcIrkdlqE9h9ufioJteCPTM2XDHPXM6r8VX8Y/BPRxbVkC7LgnCstonGP1J9RPFF7EQ4oyFR 23g+t/N7I4R2GoiAaGjbsXNIVCHSTuVNWfSQa26NbBf3TYIIWl+94UQRf7uQLh66KKOTS8pzzjx ctLbUUOUh/bxDeprJ200AvA0yE4BOBRFIhrZ7kNPX8l13D3F2pz6cIA/w+byB2OSzR0pXoC2+i4 nVfjsgbGcEL2MHLM3xCfb4tNW1/YIdp+ZJ00wkMVSnUhI+CaYMB62IOU2ZLbxopW7rbCHfe8JUN gKTr7sQCZ/P3z7WV0X X-Google-Smtp-Source: AGHT+IEOXIFzARMujXRF5ColFiNLis/8c1lSq4x61az1JeqnMHUrGdROHy7DyXPj4bpmOJpZ4qR7eA== X-Received: by 2002:a17:907:94d0:b0:b76:23df:c993 with SMTP id a640c23a62f3a-b76c5669651mr2384092166b.56.1764435519244; Sat, 29 Nov 2025 08:58:39 -0800 (PST) Received: from localhost ([2a02:8071:b783:6940:1d24:d58d:2b65:c291]) by smtp.gmail.com with UTF8SMTPSA id a640c23a62f3a-b76f5a265d4sm735909466b.60.2025.11.29.08.58.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Nov 2025 08:58:38 -0800 (PST) From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Eddie James Cc: Ninad Palsule , linux-fsi@lists.ozlabs.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman Subject: [PATCH 07/12] fsi: Create bus specific probe and remove functions Date: Sat, 29 Nov 2025 17:57:43 +0100 Message-ID: <20fbddeac9962e35db315a731c3a7ea360803efc.1764434226.git.ukleinek@kernel.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=3323; i=u.kleine-koenig@baylibre.com; h=from:subject:message-id; bh=5Ko9OFc0vr0gGtFxjBBAa/QVqxQ0ngFCXdaNCP4hmfw=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBpKyYUGfR4dKbeiRDCoX4BBWIlXxD4dk5847maa txyAIerzciJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCaSsmFAAKCRCPgPtYfRL+ TtYaB/9p1kxndBQLB4u+g4T0UJAGjqG3U+l//JhihN7uCH1QqYN+7RgbDbp2Re25U89II+iWUwa OhtL4f7HMpYL1lwG8AevOceialWvMD5zIbxKxTjY+/Bd8ehHuK6KugzJZkASqxXC1oBfBpHULfJ hRcOEylnE/+l95XzI6O9Gej0lavlYsi6BGCbGeL61fl4VUFKtppq8XIbEXfbUzjtcQOkh1hlkDV u6kDJ9cY/ZClNyqWO4uxjut2BA7J/4I0CI6DFLzJyVUN2BNJ2zjvzflxLtrMr9ApQe3Xp50n5sK OmW+h+iplTL9Ip/oGQtayPRXVJEyBLQGg0etbxcomdLLotp9 X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable Introduce a bus specific probe and remove function. For now this only allows to get rid of a cast of the generic device to an fsi device in the drivers and changes the remove prototype to return void---a non-zero return value is ignored anyhow. The objective is to get rid of users of struct device callbacks .probe(), .remove() and .shutdown() to eventually remove these. Until all fsi drivers are converted this results in a runtime warning about the drivers needing an update because there is a bus probe function and a driver probe function. Signed-off-by: Uwe Kleine-K=C3=B6nig --- drivers/fsi/fsi-core.c | 50 ++++++++++++++++++++++++++++++++++++++++++ include/linux/fsi.h | 2 ++ 2 files changed, 52 insertions(+) diff --git a/drivers/fsi/fsi-core.c b/drivers/fsi/fsi-core.c index 4e60d4b17c11..83599a1c548b 100644 --- a/drivers/fsi/fsi-core.c +++ b/drivers/fsi/fsi-core.c @@ -128,9 +128,31 @@ static int fsi_bus_match(struct device *dev, const str= uct device_driver *drv) return 0; } =20 +static int fsi_probe(struct device *dev) +{ + struct fsi_device *fsidev =3D to_fsi_dev(dev); + struct fsi_driver *fsidrv =3D to_fsi_drv(dev->driver); + + if (fsidrv->probe) + return fsidrv->probe(fsidev); + else + return 0; +} + +static void fsi_remove(struct device *dev) +{ + struct fsi_device *fsidev =3D to_fsi_dev(dev); + struct fsi_driver *fsidrv =3D to_fsi_drv(dev->driver); + + if (fsidrv->remove) + fsidrv->remove(fsidev); +} + static const struct bus_type fsi_bus_type =3D { .name =3D "fsi", .match =3D fsi_bus_match, + .probe =3D fsi_probe, + .remove =3D fsi_remove, }; =20 /* @@ -1392,6 +1414,25 @@ void fsi_master_unregister(struct fsi_master *master) } EXPORT_SYMBOL_GPL(fsi_master_unregister); =20 +static int fsi_legacy_probe(struct fsi_device *fsidev) +{ + struct device *dev =3D &fsidev->dev; + struct device_driver *driver =3D dev->driver; + + return driver->probe(dev); +} + +static void fsi_legacy_remove(struct fsi_device *fsidev) +{ + struct device *dev =3D &fsidev->dev; + struct device_driver *driver =3D dev->driver; + int ret; + + ret =3D driver->remove(dev); + if (unlikely(ret)) + dev_warn(dev, "Ignoring return value of remove callback (%pe)\n", ERR_PT= R(ret)); +} + int fsi_driver_register(struct fsi_driver *fsi_drv) { if (!fsi_drv) @@ -1401,6 +1442,15 @@ int fsi_driver_register(struct fsi_driver *fsi_drv) =20 fsi_drv->drv.bus =3D &fsi_bus_type; =20 + /* + * This driver needs updating. Note that driver_register() warns about + * this, so we're not adding another warning here. + */ + if (!fsi_drv->probe && fsi_drv->drv.probe) + fsi_drv->probe =3D fsi_legacy_probe; + if (!fsi_drv->remove && fsi_drv->drv.remove) + fsi_drv->remove =3D fsi_legacy_remove; + return driver_register(&fsi_drv->drv); } EXPORT_SYMBOL_GPL(fsi_driver_register); diff --git a/include/linux/fsi.h b/include/linux/fsi.h index 3e3a8f3adac3..9c67c43f9e6c 100644 --- a/include/linux/fsi.h +++ b/include/linux/fsi.h @@ -49,6 +49,8 @@ struct fsi_device_id { .engine_type =3D (t), .version =3D (v), =20 struct fsi_driver { + int (*probe)(struct fsi_device *fsidev); + void (*remove)(struct fsi_device *fsidev); struct device_driver drv; const struct fsi_device_id *id_table; }; --=20 2.47.3 From nobody Mon Dec 1 22:04:09 2025 Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 37ECE30F93C for ; Sat, 29 Nov 2025 16:58:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764435524; cv=none; b=lL8mJKXPQltOBS2paBUE7FTEVOUGXannVtpXMRbFy5x6fu+O7AHgnPTg5qK6x4NGpSaOwtLCs92hoSO2oGreUn65DnEdLcPGsoapHK6dJ8c5m/OzsiM9oUw5lv63LjBTsqqbuzIuRrFlIzOxHPii5KkPUzQbEQ4V9t8iw/1ANsM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764435524; c=relaxed/simple; bh=pv/oI52Higjb39QCJi+rknwb1EgrVYSVqEXSZszYOB4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=toQDJVwJV9NWflvdLr7V1MTQvXpMQZYGyk6IwOAwtVkH+7fOVJ1dvoC+77N4hguxwF6cllrTuiSsrB+uTTeajNFFQTdkIWxosL3hj6YcLb0F2x2q3LtrdimquEgVx6mwu/fhCgW1KsGP5UO1SWATU7yRvaE6QLd85ah034CxkZ8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=oDhzrIRd; arc=none smtp.client-ip=209.85.218.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="oDhzrIRd" Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-b713c7096f9so452724166b.3 for ; Sat, 29 Nov 2025 08:58:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1764435520; x=1765040320; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bEipV9vuWJgReUhW4RDw7dJGSFdctd0Ige2m1IpP68A=; b=oDhzrIRdPFcaiGVl0/uOYf1H8UppaniaKz4Kot7k05LirpWqgnrGdrBnDGC948yVM7 76Pl0h4cW6MIgQ/xx6hvrt8P7ChTuFzsDW5L2AUyA7UG+capmDEyQu0sZuWwyVilYQLP hwkvz8oZCHhBL383TwJISUDnwQuW1uN3QhjCAJlEHjhkGsQ+mSpfZi14XemeSs0mSS6W JqHwDL9ouUgVAimKNKPeBjNzxxHEVmkVaaYXLSTf/EnP3JpYPVLZJyF+s8NTF8LO8jZu P5nX9dbSCOVnhdbHrthLlViNOxeUSvcZLDhIawnxIdCnmUxBX55AFTYmWS0nOd+Sw0uz iumw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764435520; x=1765040320; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=bEipV9vuWJgReUhW4RDw7dJGSFdctd0Ige2m1IpP68A=; b=aoBnIx8rEbI5G7hPHjUxBdG+Lq+BUH4xjjVcGdZCSHdjcKXHC5v52laQ/1GeSQsLtf zkb2O9XWcsC0SlS8dNvCMashXHODhqzxuPMosvL14bIPJ9K+qivEkTCCc79KqPw8acRw WtXHV3jjTLdITeTetj6EOV3kG27rD0fp+3QysorjMCZbhy6COEEdwFnO9VZ4UXaaDMmK aBXy1RUL83XZKR0e/RXGXHVwOEjmAwligG8bRx1hJ0brw57D0b4SFvZeOUt4HYComdd1 W4tm8F7E59tB7tpCFVQ2HvSltgvo5WCUD9044S5adHcFlAdJgej+0r/rT0rD356OPf8v OwDw== X-Forwarded-Encrypted: i=1; AJvYcCWIsurMRGzi6a4M7A+MBRA20vlO92/z8mcFpwFjuaamOL1nKhoS9ar7lEN0HRhBToVcw+c4G4bgsZPim2Y=@vger.kernel.org X-Gm-Message-State: AOJu0Yx6u/2uiB8W0ef+RtwDMSnEjbcim1HYRH7sobvumkk9uZpVV24R AmBWlicYxOdTkUL1m3LeR2S2q+daW/iznt4a8sCc/cPZHw2ZNBKzgn6VRJ5CB0JvYfxVAzT8mtn HZxzm X-Gm-Gg: ASbGncvh0nVz2ZJb5+Ww2ILoZH62DwzzS14HOpfIBmdnp9WrqEh91b0d18dg73z0Wh5 f19tA3XZUUIbMzt2PQcY6CtG+DTG33bk6QXFC/BeyTFIXxJ2RGtuFyCNut6BYa9Hr2eLyA4Iy0t VJpq8b2vVZTazw7ys13pPB33Ih46UpKwVcZ8sDt5Es9HneG9+ts+kb6JVDnZxTsg5M3rir4p8MR 37kP3hKcKrRRUw8wCOQzpj+xJP/sbZRZa/Up2rAW049R8pDpVIG15g2FCjigzYT8U8drbJXoG0V 0XUvvhbkpKo+yJJf8r3GtPm2vFHk6VfWBQJYQOyic6+0gH7T3H8x14ADr0B4OaG7r4HOYRkmiBZ VFuuwVVslQt9cgvf3JqkOQYLROi6GjW6E2E4kDEcY6fxVp2t83QO2F9JzJI2G0KbP8Sy/f/CYtp 6fdmFxHt+80qcnghxZ X-Google-Smtp-Source: AGHT+IGQw9EcfzJ1MkYm88FFfd+ZFcSZYoXXSUYV++MAM8Vjnl2B1hD3zoB5kTeQioTEHs1IlaNtng== X-Received: by 2002:a17:906:c34b:b0:b73:6d56:f3ff with SMTP id a640c23a62f3a-b76715abd41mr2593978566b.20.1764435520598; Sat, 29 Nov 2025 08:58:40 -0800 (PST) Received: from localhost ([2a02:8071:b783:6940:1d24:d58d:2b65:c291]) by smtp.gmail.com with UTF8SMTPSA id a640c23a62f3a-b76f51c6c12sm728714566b.29.2025.11.29.08.58.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Nov 2025 08:58:40 -0800 (PST) From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Eddie James Cc: Ninad Palsule , linux-fsi@lists.ozlabs.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman Subject: [PATCH 08/12] fsi: master: Convert to fsi bus probe mechanism Date: Sat, 29 Nov 2025 17:57:44 +0100 Message-ID: <4477f474c39922da8095c36eed87e8443bbc1ea5.1764434226.git.ukleinek@kernel.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=2200; i=u.kleine-koenig@baylibre.com; h=from:subject:message-id; bh=pv/oI52Higjb39QCJi+rknwb1EgrVYSVqEXSZszYOB4=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBpKyYWXiTRHzuwDAD9K5dUhw9fvuLQV3+qffsKl zWYXEWGKi+JATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCaSsmFgAKCRCPgPtYfRL+ TqCQB/9nB0njghSF3/Hfm3JX3k4mV7gAf9FWwn3xi+aDhxy4gb5pBh966gLClst7BslNppYZdsd RaLKMx+m32/tbV6Sf7nZUEdSckjpOABHIdBjCNX5Wmgkf/X+4qSDEtaDBIXZMK+aHPL5YY8TZca D59jHPUC6pKeclxYDrBoQne2mNqCyuDubrpyFoDq/GEdiq3ZHw69KHTzJNNGoo97n7mbtaDIoZW 9aj/jvq5e1jg7NqZpF323HKWQIZynNKSBH1UsqzcAOKsTBTMB3FEJHR4uoohvuFRMsT+O9CLw8Z GzCEsVHhzk3hh6U3kcesyP1bjeui/emHDa07dUNzzLjlKuIZ X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable The fsi bus got a dedicated probe function. Make use of that. This fixes a runtime warning about the driver needing to be converted to the bus probe method. Signed-off-by: Uwe Kleine-K=C3=B6nig --- drivers/fsi/fsi-master-hub.c | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/drivers/fsi/fsi-master-hub.c b/drivers/fsi/fsi-master-hub.c index d389856d18ac..a84955bb23b1 100644 --- a/drivers/fsi/fsi-master-hub.c +++ b/drivers/fsi/fsi-master-hub.c @@ -192,9 +192,9 @@ static int hub_master_init(struct fsi_master_hub *hub) return fsi_device_write(dev, FSI_MRESB0, ®, sizeof(reg)); } =20 -static int hub_master_probe(struct device *dev) +static int hub_master_probe(struct fsi_device *fsi_dev) { - struct fsi_device *fsi_dev =3D to_fsi_dev(dev); + struct device *dev =3D &fsi_dev->dev; struct fsi_master_hub *hub; uint32_t reg, links; __be32 __reg; @@ -235,7 +235,7 @@ static int hub_master_probe(struct device *dev) hub->master.send_break =3D hub_master_break; hub->master.link_enable =3D hub_master_link_enable; =20 - dev_set_drvdata(dev, hub); + fsi_set_drvdata(fsi_dev, hub); =20 hub_master_init(hub); =20 @@ -259,9 +259,9 @@ static int hub_master_probe(struct device *dev) return rc; } =20 -static int hub_master_remove(struct device *dev) +static void hub_master_remove(struct fsi_device *fsi_dev) { - struct fsi_master_hub *hub =3D dev_get_drvdata(dev); + struct fsi_master_hub *hub =3D fsi_get_drvdata(fsi_dev); =20 fsi_master_unregister(&hub->master); fsi_slave_release_range(hub->upstream->slave, hub->addr, hub->size); @@ -272,8 +272,6 @@ static int hub_master_remove(struct device *dev) * the hub */ put_device(&hub->master.dev); - - return 0; } =20 static const struct fsi_device_id hub_master_ids[] =3D { @@ -286,10 +284,10 @@ static const struct fsi_device_id hub_master_ids[] = =3D { =20 static struct fsi_driver hub_master_driver =3D { .id_table =3D hub_master_ids, + .probe =3D hub_master_probe, + .remove =3D hub_master_remove, .drv =3D { .name =3D "fsi-master-hub", - .probe =3D hub_master_probe, - .remove =3D hub_master_remove, } }; =20 --=20 2.47.3 From nobody Mon Dec 1 22:04:09 2025 Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E993B31195D for ; Sat, 29 Nov 2025 16:58:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764435527; cv=none; b=NN0nqxLnntklILlMne5cOtNUJigW+GhBMblLOXzWE4Iae36e866npja/A9oqbOJUFMskN9M+rL/UMRGAHHm5d48dhEgGuSoCfEBkLcGZEGecLrl2AqBpflX88ZvxOljnJ3yQzO76n88QFn+ZdDcbfZ9h6g7zz+t56CGHpkPKxpU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764435527; c=relaxed/simple; bh=QIJjUzbPPEXixJC/UenX9JmaeP67xomil8h8VVKadW8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=C3FxEOsV+08pNycRnPONdfabQ/oQTQ70hySYWM5IbAdHjcivRhbpOINon5KJiOGbPQurHNopnK9EINjgOwNV5T9yQx4zvxUfZ77aFJlVreTrZTLPSH/SbUHr61uEEK5OaG10kVKum9BRzE4FeiBwoRcyBwZpVNYDomyk9J1i+/M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=dNmWA8CS; arc=none smtp.client-ip=209.85.208.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="dNmWA8CS" Received: by mail-ed1-f50.google.com with SMTP id 4fb4d7f45d1cf-64162c04f90so5337146a12.0 for ; Sat, 29 Nov 2025 08:58:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1764435522; x=1765040322; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=S5X0/AJXqVClNw+MMSHwGakWsUuvrSeOBMXGWWz5k68=; b=dNmWA8CSAlumAefDnpk2zlMdoE+6Y6CbPYVFixOY8xR/Cut7FVnsemwqahpvW/q5jv tze0x2DYYOVjlMtLpMDP4AkPhCIAA2bIGVnRSEBn0W3LjlM/c77HTxFDx9vG/0HtWQLO 4J0Jro8UGlfHMOgArtbNlqJiRXLz5Eyo+CwJJfRjCTJrNIeReOVMsxlpaZQVQb14Yy96 SYeQ8k+/zV1NMGFsjgx+VSUe29IjYE09Jg16B5rIabvGbfnW2dHAUYHldrFaCZrGdZ0C +YV6iEyqMLZLX9f+Itt88G8A3U8jyDXvEd9WgZJSHOTgFG09rdjYLbN6ceTwrueXNjKD TGhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764435522; x=1765040322; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=S5X0/AJXqVClNw+MMSHwGakWsUuvrSeOBMXGWWz5k68=; b=OqlckIK8Sma/M12ICEKbQo/WQ+ZRe40Fo6oBpc5ZxPUpTZxNdO2kgQqILd7Nck73Me oe+2Cq8ldzmFXGEgoDHDw0C/W13GyFd+BXXrkeSFtdg1FeeXH+5r+LCTa6nUInf3X8Nl TP5pdLeknWBRFTgi2d5egEKLi4IRfgwoE8yjuYyFTfA8fdJXp9/L6WxfQK0vHK4IpdFZ ZGi9c60Xf881pf6D2zPnF/a1s+xYEP/qUOR12GaKrvFYcMhb34PybmLYJHM3hzV89oUp Y60W7MjdjSCYsVibVKIlKqh1CN2OqNpoepypkIvwpbDC0TD9R25mXfUwu9GXzLsi7NXm AQ0Q== X-Forwarded-Encrypted: i=1; AJvYcCWHyhINiCEpKaX/LBpatln1CCaNSKB0IBmILmqFIZzAJDAuO5EqdU6eld3Cz13HgZmFn5Tkn+0PRHcCZtM=@vger.kernel.org X-Gm-Message-State: AOJu0Yy2ds9lRm/EIP60Hyw1Zpw3iNTp7WHYA3fR2stgx805itYnKQ2L Zas1Crnj4EYEif05NO29G157vveuIPhcjj/rnv754cyYQOejk7UNFwHfJJD3RR+/GwA= X-Gm-Gg: ASbGncswu5bWxl+LfxXu/0uBfwUHblctEBeggEC05/NgpwAmRAqCGKqi3YxeGozw9V0 JjhCmte2wq2IAFtIBj5CvdGuIteMmBE/ZYh1NRBOYLadlEWEcaJF8K4XfNRcuKkhDUWsCrpubhp Uy51leA1BEsFVhiC/L7BAYztM9ue1reqZpkn8ZeozgUOPxNoDHTKGpQPY1LWGMgM/Mk9/f2ZKn0 1i1+aAUJ+BYlmuZ1YuKAwwdmoOv+HWy2jJ9XAafuwUNMhsN2HvACyMc26iUXt0cnfp1gBv7Psd0 RmUrPbTGHaBG90YWIOFQ2tEBOLbILO/grVqDb55PQRXUGA00laMVnidFcff5P3ZIin8MVG/+56d UzpoLhjQpD9tGXfzH3IqBB6BOQpCghmJg1IqYMefr/JE/6YtFB9EKAgYlnl8zqfuGSeu0MFzILR EbkPb52w8AAZe+NXBD X-Google-Smtp-Source: AGHT+IFqY9OKcjFLczHtiKTvE6IhTNLUU2I6lutyiHcX0MhifhK72ajDJWIgvdeNV7+Gi9tVtC3gZw== X-Received: by 2002:a05:6402:42c7:b0:63e:b49:c9c3 with SMTP id 4fb4d7f45d1cf-64555cf83f3mr29269462a12.31.1764435521892; Sat, 29 Nov 2025 08:58:41 -0800 (PST) Received: from localhost ([2a02:8071:b783:6940:1d24:d58d:2b65:c291]) by smtp.gmail.com with UTF8SMTPSA id 4fb4d7f45d1cf-64750a90d5dsm7227734a12.12.2025.11.29.08.58.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Nov 2025 08:58:41 -0800 (PST) From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Eddie James Cc: Ninad Palsule , linux-fsi@lists.ozlabs.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman Subject: [PATCH 09/12] fsi: sbefifo: Convert to fsi bus probe mechanism Date: Sat, 29 Nov 2025 17:57:45 +0100 Message-ID: <04d44c0e6a41290948695b531f8a647db26f0fa6.1764434226.git.ukleinek@kernel.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=2272; i=u.kleine-koenig@baylibre.com; h=from:subject:message-id; bh=QIJjUzbPPEXixJC/UenX9JmaeP67xomil8h8VVKadW8=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBpKyYZB0GCozOUDotIiHSzZ44pSsaq0Nc1OFalf owR11Tghf2JATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCaSsmGQAKCRCPgPtYfRL+ TiXkB/wJRzBAioRxkpq/t36NTLDT2HyhA0Rnq4YsmUeZjlafohrSWpmecsPJeLjL59FYSpJWsO1 1mhjy3nx/yrRzbf/5yd3+DySCrRqzljUk7K/VyXFLNxajnhWs1mrLWFUbTr0eA/sIawc/5jWd5m 9r4fCFH0RzTHiSMQwPyGEcFn/Fd3HzphL7FvWJHSAZzUqKypTWPqL8Zrq0brsS/XdI49RaCnaCd /VEgE6WOmgqmuoch1xnt8Sfs52vohucW5+4SNsDRiXB0IcKEQD2OgSSzc0FjgSSeV78z6DDXHGK IvFcEmMiymZJV7nxQN+yt5RN+TYFvkjaq91LbYnPC0ku1iPK X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable The fsi bus got a dedicated probe function. Make use of that. This fixes a runtime warning about the driver needing to be converted to the bus probe method. Signed-off-by: Uwe Kleine-K=C3=B6nig --- drivers/fsi/fsi-sbefifo.c | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/drivers/fsi/fsi-sbefifo.c b/drivers/fsi/fsi-sbefifo.c index fde1c34743a0..6ca5817910cd 100644 --- a/drivers/fsi/fsi-sbefifo.c +++ b/drivers/fsi/fsi-sbefifo.c @@ -1022,9 +1022,9 @@ static void sbefifo_free(struct device *dev) * Probe/remove */ =20 -static int sbefifo_probe(struct device *dev) +static int sbefifo_probe(struct fsi_device *fsi_dev) { - struct fsi_device *fsi_dev =3D to_fsi_dev(dev); + struct device *dev =3D &fsi_dev->dev; struct sbefifo *sbefifo; struct device_node *np; struct platform_device *child; @@ -1045,7 +1045,7 @@ static int sbefifo_probe(struct device *dev) =20 sbefifo->magic =3D SBEFIFO_MAGIC; sbefifo->fsi_dev =3D fsi_dev; - dev_set_drvdata(dev, sbefifo); + fsi_set_drvdata(fsi_dev, sbefifo); mutex_init(&sbefifo->lock); sbefifo->timeout_in_cmd_ms =3D SBEFIFO_TIMEOUT_IN_CMD; sbefifo->timeout_start_rsp_ms =3D SBEFIFO_TIMEOUT_START_RSP; @@ -1101,9 +1101,10 @@ static int sbefifo_unregister_child(struct device *d= ev, void *data) return 0; } =20 -static int sbefifo_remove(struct device *dev) +static void sbefifo_remove(struct fsi_device *fsi_dev) { - struct sbefifo *sbefifo =3D dev_get_drvdata(dev); + struct device *dev =3D &fsi_dev->dev; + struct sbefifo *sbefifo =3D fsi_get_drvdata(fsi_dev); =20 dev_dbg(dev, "Removing sbefifo device...\n"); =20 @@ -1117,8 +1118,6 @@ static int sbefifo_remove(struct device *dev) fsi_free_minor(sbefifo->dev.devt); device_for_each_child(dev, NULL, sbefifo_unregister_child); put_device(&sbefifo->dev); - - return 0; } =20 static const struct fsi_device_id sbefifo_ids[] =3D { @@ -1131,10 +1130,10 @@ static const struct fsi_device_id sbefifo_ids[] =3D= { =20 static struct fsi_driver sbefifo_drv =3D { .id_table =3D sbefifo_ids, + .probe =3D sbefifo_probe, + .remove =3D sbefifo_remove, .drv =3D { .name =3D DEVICE_NAME, - .probe =3D sbefifo_probe, - .remove =3D sbefifo_remove, } }; =20 --=20 2.47.3 From nobody Mon Dec 1 22:04:09 2025 Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A2BF311C11 for ; Sat, 29 Nov 2025 16:58:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764435529; cv=none; b=N0xjBd0Fx0d0iUf6J5ViIh2/Fkjl/mDV9M/SgJJtBiO8/4+fz2kkLAnbo8wiuipKfsAU2Uu3fgAC7/HiEjUPEyAXNaVQoamRSPjj04RjqdC7GtNwTDbIRo/0GPZHUwdoeB9k5f13CMws54jiPAIEcqH4B5IOmXW9mKnC9m4LqfE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764435529; c=relaxed/simple; bh=48XhV1ead+kMhmolJfzkj7xK7TKmOSTcIV7UIXmqXBw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=idqoWGgnWE0ukAdPaTVtUnFfNDucqftidbnB+4THmAOJrC0bWHMEATYnKF9prYC27PJvi8jmWT6rx1gP3UdIn/IWyV0MpkC2ESU1IseOHej39H/tKlNM9Z/pomdBme5xuCGhehFT7aRUHhTCTICfo2/nZvvMJww225AdgSiiou8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=HdkCxqbs; arc=none smtp.client-ip=209.85.208.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="HdkCxqbs" Received: by mail-ed1-f54.google.com with SMTP id 4fb4d7f45d1cf-64320b9bb4bso5496644a12.0 for ; Sat, 29 Nov 2025 08:58:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1764435524; x=1765040324; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XXnSVFokVbdMFj6Qaw0zpV5xPeOXjzZvsyUo2XNucKk=; b=HdkCxqbsb9BoU5Qk57PbQh4T2w9TGNcgS7+h/OiK1XxbMbtP/Y6UbEDvmScV+MSpkR xRigjSwafoO5cf0c1S2hF1VUhSGSJ/vleBy5NuMSU9KrBtpkDtrdFjr3tYx+UADPNtac xlD6DDNYMLLfPJGdKn/jNlDThGfO8+YG65L0a7qM0Jjwj3y/znc8E/dW/cOTgQkccq4z D3avWH4CsgqRhXzxpeU7IY/pjxZug0KvKTszs3X/puDZfn0i6ijcyeUMlim3YuPjFard SY3uc0wohnyHiyJl83vXZfvAlHZLx+UU4YLwqRA7poZXZe5T4vrVosvPRL4TaC8y1Kfu SrgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764435524; x=1765040324; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=XXnSVFokVbdMFj6Qaw0zpV5xPeOXjzZvsyUo2XNucKk=; b=tKnAXwcqi7L5novQ1lxeNA0W84Pm775851hzWNNH9xsC18zwXKf9MBsTyAUr49byOz VuYY12DbVZBtjHCHm+jIYE9p6OxbXWD4LjYua6CKGtPPLuqW5FR+V1t2uEGw1DuihwhF V/IBFJgHO6fLg5YyKJSweTfMqAUbANdc0MXPMNjYTdjtjlVq3OuqrxT2rNcuP+1zhl6f eEYmhZet3qT9iOZiwbK86vDhcFbzpY4U4VhVWanhTYI8NYVoyiUqS7kDH05pvanYi2L/ eX7z6Xc4X0WXb3Q/Py848G8+NKQPS2cCCgKiA+9d978ikvOl3uFMS+YB1AAMSqyAzG7W K48Q== X-Forwarded-Encrypted: i=1; AJvYcCX/ifZYIexhtF1jKuSdmrdkQpd5dvw0KplVH2tQGHnHndYOdHz8CbTbjjZm9s1vskQC/WT55PL8iPQjhXA=@vger.kernel.org X-Gm-Message-State: AOJu0YxqmRNj9XRUlQZNFf1Rblyd2ZKOlVNJZr5CaF1+mZoHjcmqRHsp Xs40sAMAC5DNEgteSGrOo2bfc9YBxN2cHcVUMRpjM8VX5VW1CHNxFoVYtU7E1GGHv08= X-Gm-Gg: ASbGncuKhvzT9lTdkn4F2zKorklB1xVjCUGrzZLyDzkatbD2o57k4eA5hlcjToKQrPp 8Ya9UDoG7pabvFfOoHu1Da3fjBofqbdGEP6UiZuROa4vbMe2Or7SeySrz5ypwCl2nGsJGVTyqxP Dj5Cbr9/FEpLjz1B8qkwxM0iEM6PuV961GcWTowToX6RmoWMeq+NdNH5EIHSPdpI+w0RPKSQfsB DOaWNIg8sjtS+Zx0Jp2rSIf2+IRgg6BY0o36tXZVDycNDicQrHbFWvB42WF8Pw6XPNtIX9URUzz JHVFGGWXrzkaZzRJsGSW9MoTvJCJXkyxHmoIxDAnER41ZmyYc13IglHl/3s4MKCA/2z+Qolwbe2 cnw9KKpU95mHswEwjOkTFq3ue5ZDqxHHuBg0m73yrw/Ujk29JEbtC9amvPCOfpzbqzk9U+NFI9R Lp3qX+2b6ZFkrFv0Qq X-Google-Smtp-Source: AGHT+IG9akUUhfQGKZxTwoqMFVj7xOVRL/91ikMm9ZHQfewsnVSZFi0YkeYIvRLsZfr59to7clDHRg== X-Received: by 2002:a05:6402:34d1:b0:643:4e9c:d165 with SMTP id 4fb4d7f45d1cf-645550808a7mr31393352a12.5.1764435524067; Sat, 29 Nov 2025 08:58:44 -0800 (PST) Received: from localhost ([2a02:8071:b783:6940:1d24:d58d:2b65:c291]) by smtp.gmail.com with UTF8SMTPSA id 4fb4d7f45d1cf-64750a90d45sm7236282a12.8.2025.11.29.08.58.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Nov 2025 08:58:43 -0800 (PST) From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Eddie James Cc: Ninad Palsule , linux-fsi@lists.ozlabs.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman Subject: [PATCH 10/12] fsi: scom: Convert to fsi bus probe mechanism Date: Sat, 29 Nov 2025 17:57:46 +0100 Message-ID: X-Mailer: git-send-email 2.47.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=2008; i=u.kleine-koenig@baylibre.com; h=from:subject:message-id; bh=48XhV1ead+kMhmolJfzkj7xK7TKmOSTcIV7UIXmqXBw=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBpKyYcUdYCJ9vuSCjR8hBJA5k4tpX7iZpZ2bhlB VvlZhw16m+JATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCaSsmHAAKCRCPgPtYfRL+ TtOSB/9Cc00Qe0qF5ycDAuoijNWeSJ6cJ6xkVQAE2JgZLqjQL1Bpx9TalznV9KDgB8lkeMdIk9/ l6FxdrwTqRkHShYSnGptKVzx4wRT1rn6EIELn/5yWfPLBdgVr5tdegysT0UtCYBktAq5sk+wsBV O2+hmKW8Oe+h8YWjRikqMk1DnungwfQQrwfcbsqfNhCqe7L1QoFFHamZUt4ow9XHu+2NtxLauiu 0ExyxcmROv+aS1UeU0Eb7SaK69VQf+Q6lyXMQ2EC/wYp1ynge12CKwT3gmkAbkRNQKDhDrI+Mnt +wtN2KMA8iYRVxdfZiPkx47sdYUDUcC8ydmXel9SkTx5ac1a X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable The fsi bus got a dedicated probe function. Make use of that. This fixes a runtime warning about the driver needing to be converted to the bus probe method. Signed-off-by: Uwe Kleine-K=C3=B6nig --- drivers/fsi/fsi-scom.c | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/drivers/fsi/fsi-scom.c b/drivers/fsi/fsi-scom.c index 2eda44451cc1..67cd45605fe4 100644 --- a/drivers/fsi/fsi-scom.c +++ b/drivers/fsi/fsi-scom.c @@ -527,16 +527,16 @@ static void scom_free(struct device *dev) kfree(scom); } =20 -static int scom_probe(struct device *dev) +static int scom_probe(struct fsi_device *fsi_dev) { - struct fsi_device *fsi_dev =3D to_fsi_dev(dev); + struct device *dev =3D &fsi_dev->dev; struct scom_device *scom; int rc, didx; =20 scom =3D kzalloc(sizeof(*scom), GFP_KERNEL); if (!scom) return -ENOMEM; - dev_set_drvdata(dev, scom); + fsi_set_drvdata(fsi_dev, scom); mutex_init(&scom->lock); =20 /* Grab a reference to the device (parent of our cdev), we'll drop it lat= er */ @@ -574,9 +574,9 @@ static int scom_probe(struct device *dev) return rc; } =20 -static int scom_remove(struct device *dev) +static void scom_remove(struct fsi_device *fsi_dev) { - struct scom_device *scom =3D dev_get_drvdata(dev); + struct scom_device *scom =3D fsi_get_drvdata(fsi_dev); =20 mutex_lock(&scom->lock); scom->dead =3D true; @@ -584,8 +584,6 @@ static int scom_remove(struct device *dev) cdev_device_del(&scom->cdev, &scom->dev); fsi_free_minor(scom->dev.devt); put_device(&scom->dev); - - return 0; } =20 static const struct of_device_id scom_of_ids[] =3D { @@ -604,11 +602,11 @@ static const struct fsi_device_id scom_ids[] =3D { =20 static struct fsi_driver scom_drv =3D { .id_table =3D scom_ids, + .probe =3D scom_probe, + .remove =3D scom_remove, .drv =3D { .name =3D "scom", .of_match_table =3D scom_of_ids, - .probe =3D scom_probe, - .remove =3D scom_remove, } }; =20 --=20 2.47.3 From nobody Mon Dec 1 22:04:09 2025 Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 40D9A30FC17 for ; Sat, 29 Nov 2025 16:58:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764435531; cv=none; b=bS7xjgi44r60gLG8rv034q1FSPyrO89ghvRpNUwnZ86Uimk7ss8RFdTlliNS0bJT0dnVEG2KS/nvDsE6wfbn2m/l5LhxOfbyV15qydoDhhXDJ1GI/1T0ppPXXjN2kOQP5ml5D47r51DoTCuFxtQ534hYrYjTWMXSVifWOCpAIj8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764435531; c=relaxed/simple; bh=lFoITZ+8y9h+znHwjqA5lzaUXuTbRHz9vr6xKWUfQoQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Ip0ZxZd7KBKUAmjsCFyimU9D+qGD5pxWk5ubDT1mViYSU0qUyPLFwsjT1A2ECCORiBXczVSJES/gux9aouhySyQa0PBGcJ/s0GGV02OO3b5YKXgXjsB2Zy+zGvBS0njwIsn0sFJPtI1tFU0P0FKrdEpdaLgUja1kMreSDBcVbl0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=Fioj0ztG; arc=none smtp.client-ip=209.85.218.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="Fioj0ztG" Received: by mail-ej1-f54.google.com with SMTP id a640c23a62f3a-b7277324204so471670066b.0 for ; Sat, 29 Nov 2025 08:58:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1764435525; x=1765040325; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BNQekoeq5MvJ5okU84UxS4oYSbes7vTEJXlQrgYvFfA=; b=Fioj0ztGbpKi5xVbcQMDgGRjOEVhue1alt/Blss/r+GbLrSvS7xCBDV4X5tiABFWlb LkOF43MFCNFgY5cgFKPtCelS0ndktiNkCmDmdK0XSFU/iQg1nxebipsUzz9QmyUNbLdg afEqWn2RxQUsNyrQQG2U1Z9NsvnSj3tzqI6d9YDKl+MjPsQ6U1zaHpx76MomfOSj8sAq 4H7rIhtoM2kMoFZHiPsJmrtJPWA+YOrNuJUD2C/hRACM3xo23Dv6ON6wRHzaz3YEdOBV r/1Hvy6rlKupBqffZPjmm2Vq/zr7NSlB7iVSZGbNfqlxUhdM2HdpQBWTni/lwU8peTH7 k45g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764435525; x=1765040325; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=BNQekoeq5MvJ5okU84UxS4oYSbes7vTEJXlQrgYvFfA=; b=s3D/bFsU9suqKK8zyTtYLMrqrKmM1JIVbc/5UTQNn3yXW7AofQHPqYszrD2/ZwtABb km/FBV2SwxnxR9wIifT3FTU3TVLkImEhGxr/ePYXww93gGjOT/qA/oKatQqKaWMygcAd y+dvN53SERpJiT+kcqqh2LgyCoyWXzdQQF5ZkGO0vlqwAaw22nGC5CM2fuVB+MXyF9TS vZv7S6u109DCgjVtwS4+UH98cvRghY3pEOFMzTF3iz8a/FOUWqB+4A3VTiT8ZhjQrrvu //pjVqsOo2NZzW7Osq1SmVekIpehcA/9CdCIFb8U7G/7x7Ekc3/5aaNAeRhLuxNItYJe ZR1g== X-Forwarded-Encrypted: i=1; AJvYcCX8Hqp8Rzc6uAauAXcSETpH2T3hAU8VIGNEbn/W/Sph7XD4xh+QDrjFRdOVdSF7qpoG5Ie4ccxExZ9QoPw=@vger.kernel.org X-Gm-Message-State: AOJu0Yx0uXT5X4PtMossMGO2psIPbs19C/hNXmTWTtXU3fSdECvr+yxL XU7Lb6BmUKya1Uni945+/pojbCCYA1PmWGSRP2/PLlln3+3VKBUAJA69+CTlRAYggHE= X-Gm-Gg: ASbGncutdq9LP382VL1NXWTMbZ5tRhbpbO224tehedhJ+BNy5dlJa4x5aWNVj1Mgit9 a94W4FClbRpF+xLC/6JHKgAzPLb+/8ufwVO1J/o7h0vwqYGkASpoJr8xqIp9aZ/yp+p0bY2Twxa jmUfbEeB//8qiJz2FfwUGCJZh/q/Lswroilg5ogteBnVL2qdLKj39BQxNV686cvxOwaL7Mi42wo L7aMbS9GAlXFRtLDxuEUSPf/4XM9rivYB3Gai94fHpHuKjsFGFeJe05D4/F+SaI9dEu2d3Etwod abCdTYg6vkXzEFEPWCzpcfAPwqexaJrku5xB/6R7ZO2WQLWBiym4irEM365p9daJtjLG/9iW66U zt7AAGxDCIjt2a+iHSNfgtsV6MoMpUfWoIhzqIr/ciUTi/TYjAt0pDWY3s/IoAUpx5As3RGYof5 L6SSzVNtEm1BZDYaVI X-Google-Smtp-Source: AGHT+IH0MuHRfQrTehiJ52oUZvyc1bRjVVlQ90Y5BVCZU/AGDxq3c6qhZBRECgPEx5G8y1z2CMPY2A== X-Received: by 2002:a17:907:a09:b0:b76:7b8c:a6a2 with SMTP id a640c23a62f3a-b76c5513f0amr2236776366b.30.1764435525382; Sat, 29 Nov 2025 08:58:45 -0800 (PST) Received: from localhost ([2a02:8071:b783:6940:1d24:d58d:2b65:c291]) by smtp.gmail.com with UTF8SMTPSA id a640c23a62f3a-b76f519e2a7sm746363266b.19.2025.11.29.08.58.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Nov 2025 08:58:45 -0800 (PST) From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Eddie James , Andi Shyti Cc: Ninad Palsule , linux-i2c@vger.kernel.org, openbmc@lists.ozlabs.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman Subject: [PATCH 11/12] i2c: fsi: Convert to fsi bus probe mechanism Date: Sat, 29 Nov 2025 17:57:47 +0100 Message-ID: <1311bce0d8617c7821cfe0769e97f13dc466d749.1764434226.git.ukleinek@kernel.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1926; i=u.kleine-koenig@baylibre.com; h=from:subject:message-id; bh=lFoITZ+8y9h+znHwjqA5lzaUXuTbRHz9vr6xKWUfQoQ=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBpKyYerMbqnhdrESWnep/VE+BwW0xpjbtreFxEN ucImWFZ8nSJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCaSsmHgAKCRCPgPtYfRL+ TonZCACcm2Jdwaa3XVZ2Cp3JYYBZY68UG0Sf3G/dj+JWPDhCBlZ+/+v7prYyU4O3d63j5jPdYaY EHU3cy3rKORxvZQ7O3dHJ8Q2skeRpnrR2wTftedZVfUPNiB5jYlJKSe3sx3ktLQbThCQ1z2Zbvi l3lkI4FFBwsAaYkhjWjMj3y3qF+uJZn1qQdQSZZsqQwJFFf27tnOaNp0FRCvfmBqGmdpuMEMr5a gc85eibDINIZDLq4D+16foZZgOyemHYvJKOMt5G438IZ32J4vutnfcPLxCpIxrHsLlkcUkrFaJy CKa7WQj6VFAJxp9cuDEC1oHlZC7RgE+vdw20Qp5r1jOx9j+O X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable The fsi bus got a dedicated probe function. Make use of that. This fixes a runtime warning about the driver needing to be converted to the bus probe method. Signed-off-by: Uwe Kleine-K=C3=B6nig --- drivers/i2c/busses/i2c-fsi.c | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/drivers/i2c/busses/i2c-fsi.c b/drivers/i2c/busses/i2c-fsi.c index e98dd5dcac0f..3a7e577e6eac 100644 --- a/drivers/i2c/busses/i2c-fsi.c +++ b/drivers/i2c/busses/i2c-fsi.c @@ -674,8 +674,9 @@ static struct device_node *fsi_i2c_find_port_of_node(st= ruct device_node *fsi, return NULL; } =20 -static int fsi_i2c_probe(struct device *dev) +static int fsi_i2c_probe(struct fsi_device *fsi_dev) { + struct device *dev =3D &fsi_dev->dev; struct fsi_i2c_ctrl *i2c; struct fsi_i2c_port *port; struct device_node *np; @@ -735,14 +736,14 @@ static int fsi_i2c_probe(struct device *dev) list_add(&port->list, &i2c->ports); } =20 - dev_set_drvdata(dev, i2c); + fsi_set_drvdata(fsi_dev, i2c); =20 return 0; } =20 -static int fsi_i2c_remove(struct device *dev) +static void fsi_i2c_remove(struct fsi_device *fsi_dev) { - struct fsi_i2c_ctrl *i2c =3D dev_get_drvdata(dev); + struct fsi_i2c_ctrl *i2c =3D fsi_get_drvdata(fsi_dev); struct fsi_i2c_port *port, *tmp; =20 list_for_each_entry_safe(port, tmp, &i2c->ports, list) { @@ -750,8 +751,6 @@ static int fsi_i2c_remove(struct device *dev) i2c_del_adapter(&port->adapter); kfree(port); } - - return 0; } =20 static const struct fsi_device_id fsi_i2c_ids[] =3D { @@ -761,10 +760,10 @@ static const struct fsi_device_id fsi_i2c_ids[] =3D { =20 static struct fsi_driver fsi_i2c_driver =3D { .id_table =3D fsi_i2c_ids, + .probe =3D fsi_i2c_probe, + .remove =3D fsi_i2c_remove, .drv =3D { .name =3D "i2c-fsi", - .probe =3D fsi_i2c_probe, - .remove =3D fsi_i2c_remove, }, }; =20 --=20 2.47.3 From nobody Mon Dec 1 22:04:09 2025 Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B80A30FF03 for ; Sat, 29 Nov 2025 16:58:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764435533; cv=none; b=CXwG1Fa85XO1x/OwOIwhFe4sUdHEJvCg0i4BhlvtgKJFWp9DN9YCXhsVMY2TMjL2a6gN1jIFStboBga7tRlOG5c07z3WhabjtHU+UAxksb1wiHK3eVk+n1lS7G5EnGxbBj3u+HlDBwH3lhSLZf8yRSDv8D0azwOy3xDiExGClhA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764435533; c=relaxed/simple; bh=ZZbGTkMYTIgTc2HHYCAxYn2mLQnWvUECVJl5MHLWpEc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=i1RSZ6HUj+1FZDWemI8i341v2yAQ5f2M2mNbdjXJWAcum/jdP3V0XE/U60W4u0RtmhcBM2sTD+sFJqPQ+/x+hFobrmAesxpWxGvRelutfs++oX3DlvMwzLijEQmi2QLqRvoV+DMHYISEAcyfuWAqFVUOgMjSKE+PlZYehlHdkwM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=p1ExRqDj; arc=none smtp.client-ip=209.85.218.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="p1ExRqDj" Received: by mail-ej1-f51.google.com with SMTP id a640c23a62f3a-b734fcbf1e3so280661966b.3 for ; Sat, 29 Nov 2025 08:58:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1764435527; x=1765040327; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=PFG57/lAXGfcsZdp8Xv+tkRcXlQVV5XT9qmsBMmgDeQ=; b=p1ExRqDjd4wDbEXgcUtmYM71zIOnMDZGn/Bv4LzNZ0seM4VCuaZ+FVyEtWmjfRyE3y Yw1j+SKfygreR8cVy8tP6ugbD9JDZduSOcICyxViVWCbPNaVUyRJ8rF+bv39IWlVgJBj f4I5KhxKLmSEqEOKNUD5nPcf//mTPxzYiL8SxLWe3imc6iVLbmgun3u4ZhYJcXPbsGaG NeBlL+NMZ4NTZzr8M0FCSsg3by2iubvZ/Wd+/oMM5upCRRBuzmLz8GCGmJLhsMshpWmY rGJwV9KASDuCJjeV21W9KZQvHvnLhaSxVqzo/GeZyT66IfnelBkXbvVbV+Lpgt597/uD +Urg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764435527; x=1765040327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=PFG57/lAXGfcsZdp8Xv+tkRcXlQVV5XT9qmsBMmgDeQ=; b=uVff4dLddvTr0DJJm8KsC7bfLe9CXuYSJZTjU5lo+aNexVf3358cChA+m9/W1G29Or WLeBCKwldikfm7y8qx5WsxdtcNVe1MZg6+Sml2HyoiwtwFq1j79VtTQ6dLFoizm4A/Sd MdHZogtP5cqA+XA+2nMRPYR0c/wkXcpPCzUreuTn3xAs9y6WzwdsZCXMf6PeFflV3w1g cYjFnXBZneLPD3EwYRg3uS1+yfpZUhJG+NXDxjeFhH+Hum7PrirIU+PXnp8Nc6fY9sZm kCpCnjpTmgkfyeHxm8AJTlJOA882XWxXuXvqKEKTTm2oPKgXP0n7ew3n8F7cZoqelIUv nJ0Q== X-Forwarded-Encrypted: i=1; AJvYcCXVbT86Ca3bsrNzy5R2cHd6Moc0NPg40zZ5kovbos0SHetsFynkQFsspQB5su5Gg17LLilufH7KATuprRs=@vger.kernel.org X-Gm-Message-State: AOJu0YxxqU2PYhGompNm2zFpGT9Zu3Ij4iAmL6pVieClSG0BaXCwCdB0 1swKIBv+jPt2wbD4fd7b+P1rjvUVjX/5Xi0aYAZkq8L/piBrMCnevVsUoKGeGdogjE0= X-Gm-Gg: ASbGncujqQCZebzqt1MWfhv4ulEhqyrf0V0aMSljxZvIizvZNttUxudYTXsEEHc/WBj 2zJYitGIyvqZnKr0t06j7eu6AhsntTWiW3hx7wxThTZdlmKhXBjHiHap5bJDQnj4s+FQ/qvyA1e chYM5BPGNJiH5M2Vb/QCwg+a6lP+eXy2QQUmpP7ELfscKK6Xl2cD0KaK29hif2Lt1B9uApmMvcC z1Q6ZCZ6/+dbCSDcUAze0LW6j7FihtSS6kEZL3EncDKFQhnY13iHa7CQXMUm3IKGiN57ROadEJP 6/T55AwhnSIeYwj3NvSc2V8mUFhhTkPxGyFX17kuXLMhfw7uIcKXYr6XcrRWQmz8Hx2dAsAlZFS Em4afj8vI6XoV1SOFmQFTwh15cTuGxas57/FPplnwjM7ifmneYcxdhtnCGXy8/rjNATm2T7NyI2 KAEg4wSXWJVN41ToXq X-Google-Smtp-Source: AGHT+IFy0NAudSDXw7I2Aiji0fj/sV9rIW0nafD3DGEIhNthc68dpKGwVJNpVb+V2jIju6zOK1WZEw== X-Received: by 2002:a17:906:fa0c:b0:b76:8077:4eaa with SMTP id a640c23a62f3a-b7680774fecmr2224282766b.6.1764435526719; Sat, 29 Nov 2025 08:58:46 -0800 (PST) Received: from localhost ([2a02:8071:b783:6940:1d24:d58d:2b65:c291]) by smtp.gmail.com with UTF8SMTPSA id a640c23a62f3a-b76f5a4860fsm726556066b.63.2025.11.29.08.58.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Nov 2025 08:58:46 -0800 (PST) From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Eddie James , Mark Brown Cc: Ninad Palsule , linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman Subject: [PATCH 12/12] spi: fsi: Convert to fsi bus probe mechanism Date: Sat, 29 Nov 2025 17:57:48 +0100 Message-ID: X-Mailer: git-send-email 2.47.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1228; i=u.kleine-koenig@baylibre.com; h=from:subject:message-id; bh=ZZbGTkMYTIgTc2HHYCAxYn2mLQnWvUECVJl5MHLWpEc=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBpKyYgROy12cesDmV48VbWJFTWfD4pX9V5tIPFq WBU7MaAQ++JATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCaSsmIAAKCRCPgPtYfRL+ TmrzB/44PL/fVctVmXmkwM8vtKDKp/RzmiAggaYZ030mB5tEwnTSlzpcfa8mRjCT1atCQwmPOd1 xYtsux2go6zkiWQXhfzOUo5TdWMdkgfUGf33ElWK8+Amyx1JWixrJnH/cc34uKi7N0+SnskX44R WBPJ+6/uwH1PD6Q/vmH33P4TuPFn3M5nK+Xy5IDKeFFe+QJvvwxRdzrGaFaBfjc/kDKNzuHZ3O3 w2RDycLVKPsIxITkTlCzPB32NIrAKY7O6eFTkEDWxNb/AvT1giay9DwgQhnqWogZaRFtf0s4XwE 9iQZNr0On/KbEjfKdsf/p9iNPFfEPU4uCuUu7qjndz6M2lJ/ X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable The fsi bus got a dedicated probe function. Make use of that. This fixes a runtime warning about the driver needing to be converted to the bus probe method. Signed-off-by: Uwe Kleine-K=C3=B6nig --- drivers/spi/spi-fsi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/spi/spi-fsi.c b/drivers/spi/spi-fsi.c index f9c15b99dba5..07dc3d24f2c9 100644 --- a/drivers/spi/spi-fsi.c +++ b/drivers/spi/spi-fsi.c @@ -528,13 +528,13 @@ static size_t fsi_spi_max_transfer_size(struct spi_de= vice *spi) return SPI_FSI_MAX_RX_SIZE; } =20 -static int fsi_spi_probe(struct device *dev) +static int fsi_spi_probe(struct fsi_device *fsi) { int rc; struct device_node *np; int num_controllers_registered =3D 0; struct fsi2spi *bridge; - struct fsi_device *fsi =3D to_fsi_dev(dev); + struct device *dev =3D &fsi->dev; =20 rc =3D fsi_spi_check_mux(fsi, dev); if (rc) @@ -593,9 +593,9 @@ MODULE_DEVICE_TABLE(fsi, fsi_spi_ids); =20 static struct fsi_driver fsi_spi_driver =3D { .id_table =3D fsi_spi_ids, + .probe =3D fsi_spi_probe, .drv =3D { .name =3D "spi-fsi", - .probe =3D fsi_spi_probe, }, }; module_fsi_driver(fsi_spi_driver); --=20 2.47.3