From nobody Mon Dec 1 21:33:02 2025 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 246C51D5CC7 for ; Fri, 28 Nov 2025 07:02:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764313345; cv=none; b=O+3qHQLm4sgobNKWXQkyY5AL4qpkZDkPihKty4+gzpqeRyNGmDuH5JwSqov5VZnrgp1byVxEa9uo0ZdBySPjWkKOmtTG7H2Bfdkhg7eNg8++Ee7iNZ+9cbdbXTRjJJsmgOJpMOetwkp0UL6FEM6KQPnNi+wC5vmXzGgWpEntPw0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764313345; c=relaxed/simple; bh=YSsAlR3yqJy3EEFBffMrdKAhEV663/aG07YhhYzlEsA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GCnHNC/hUiBUDrbYox2Gni3UupLeKWu+lVJ4ry0ctyxSZP3ktXG648TlwutE8PmHcWm5nkkGNQd8H9qSGjNYaT0ZZgD8SvyGtCzqCktkCU6yig+nacXBHzSM93FFSqWNL2fHXnQ7KXQZPRS1RJgH5i62i51cg25z3R9B6OYd9Nk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Uz1Vp+v0; arc=none smtp.client-ip=209.85.210.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Uz1Vp+v0" Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-7b9c17dd591so1361085b3a.3 for ; Thu, 27 Nov 2025 23:02:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764313343; x=1764918143; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=z6Dwan2VmZRzoqc+nruHJuXpjL9VPRxB9Hq3gVoV6ww=; b=Uz1Vp+v02m61gpq5G3+7WCnfN5b+OrDSMfKLMFqTzV552sivNq69BWA05p5ko+zpx7 wLrxPKJGYxgLWHeRrBwwjhmeB7Ji3wY6nV3l/i9RuH4A0m1NhYLsJvE8SX5ynTW1JJc/ pCRXwuaKDGdWIZ+SLqoilkNxf1eCXVqd0hgjdRFssek1l0MpdYewuPDE9RwP+IUyueY0 72mYTssMWajf/KmnwTZZFLo71P6ve6kpuvhp8ayiX4ni2pzCgWino9t7zAvx98SQz5Tu WB0qkDlo9+AJjB7tuUVeED3DSpdFly39lSo2N1pTtFDbEl3SYgTF0zzb5vIcTjWhUwnh RNbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764313343; x=1764918143; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=z6Dwan2VmZRzoqc+nruHJuXpjL9VPRxB9Hq3gVoV6ww=; b=ZqL1z4rOr3O3KiBd7oOsNK04OLEY8qfJIWI56EGxo0u8ZxQONrVOXhEI5uwGp97lHA /XXCIk5CwTl+NJAdixW9DZU8l00Jr8FWOMqhs6b5b9KmnR6tq1jO+di+AaZllJ81O2Hp 8hgmhPSLcFeJjZv+QUVcwL9QKGCmwRBuSblAPQoXsDUBY4hM4FvC9k6DoV+jio+0Ocvg qMTOVAFaMiRSLf7suCN1yxF7DxMZQhR9CVRcnHwSEjnHKG5Gr/ptfprJ+ovKr55cB4iM 5CJy44wCIWOv/mzkdDa0Py/elumgxpBZhL3B6EKO0rZ5ZEUzAihpcpj5+/+l/TI2T8Ls yoxw== X-Forwarded-Encrypted: i=1; AJvYcCXri0kTDLjLxNgWAZhhCMu9Qzdx5MBGpX03XctVFVzQxcBMCLfPZ7ga2Tw7dJpfyvH7M5Q6mYU1vDJzDV8=@vger.kernel.org X-Gm-Message-State: AOJu0YyE5yoZ5BU53KctbflalOWZtsyhzccDbHztL0A+t5rPf66hlfVY loXCDNKwabEvdiZD72I66mV2IqrncylUvqp+iE13krzdnDvFLD4/fRop X-Gm-Gg: ASbGncvdgXqpCvmahoX1KxxqUvKN58jLbk0fmYToyYVgXZSADs+VRENIN0lY4eZfQk9 u4CKOa3wgbZVUhkCbPUsIhYJUPZqUxCU1I6EiJkeY0b0W/JM+P1+Uao0Bzl5RNtkj2wjh08FoVg OcV7gNojBP4BXleWh9SbC6GbfknhTbM4D8Sh4LEx3KVj+vqgSrKB+yEQhMZ6m77kv6+2irHFraF kDkEIKNbp3rjAxL0PchR9uolPGBhHlbb5xT2JBnKod0nfynISEnMbmyEKG362A6gYj4SsGF3tcB H+NPqJfd4XityjSlVKMoKajd430wENYqgMw0cuuXypsYr/ScXElgERcmmOnBAlyn46ScFsBCkXL oP6EJYpTzke+cVmggo50F/JeGI78HOde5qHxhBsoD3mL+VfYNRe78dZMHK06F25cV2q1zQzrXV4 7mLTMzUk6/AByeHVURNfXt/iMUuA== X-Google-Smtp-Source: AGHT+IH+IQitqVj1j3CAw6jNknzr4zB8MMqZXg8hNjdTrBVT+rJukm/aBPWjiVm5HNUeP2S7B19X4Q== X-Received: by 2002:a05:6a00:4f95:b0:7ab:6fdb:1d40 with SMTP id d2e1a72fcca58-7ca8740ef73mr14757832b3a.3.1764313343103; Thu, 27 Nov 2025 23:02:23 -0800 (PST) Received: from chandna.localdomain ([106.222.232.43]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7d1516f6970sm3864693b3a.17.2025.11.27.23.02.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Nov 2025 23:02:22 -0800 (PST) From: Sahil Chandna To: akpm@linux-foundation.org, david@redhat.com, lorenzo.stoakes@oracle.com, mhocko@suse.com, vbabka@suse.cz, rppt@kernel.org, surenb@google.com, hannes@cmpxchg.org, shakeel.butt@linux.dev, zhengqi.arch@bytedance.com, Liam.Howlett@oracle.com, weixugc@google.com, axelrasmussen@google.com, yuanchu@google.com, yosry.ahmed@linux.dev, nphamcs@gmail.com, chengming.zhou@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: david@kernel.org, Sahil Chandna , Matthew Wilcox , David Laight Subject: [PATCH v4 1/3] mm: pagewalk: simplify hugepage boundary calculation Date: Fri, 28 Nov 2025 12:31:42 +0530 Message-ID: <35ab82f052d248c0047c10bf01853e37e4f9b4e4.1764312627.git.chandna.sahil@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace hugepage boundary computation with ALIGN() helper instead of an open coded expression. This helps to improves code readability. This was flagged by Coccinelle (misc/minmax.cocci) as an opportunity to use min(), after which the boundary computation was updated following review suggestions. Found by: make coccicheck MODE=3Dreport M=3Dmm/ No functional change intended. Acked-by: David Hildenbrand (Red Hat) Suggested-by: David Hildenbrand (Red Hat) Suggested-by: Matthew Wilcox Suggested-by: David Laight Signed-off-by: Sahil Chandna --- mm/pagewalk.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/mm/pagewalk.c b/mm/pagewalk.c index 9f91cf85a5be..9fd59d517f37 100644 --- a/mm/pagewalk.c +++ b/mm/pagewalk.c @@ -312,8 +312,7 @@ static int walk_pgd_range(unsigned long addr, unsigned = long end, static unsigned long hugetlb_entry_end(struct hstate *h, unsigned long add= r, unsigned long end) { - unsigned long boundary =3D (addr & huge_page_mask(h)) + huge_page_size(h); - return boundary < end ? boundary : end; + return min(ALIGN(addr, huge_page_size(h)), end); } =20 static int walk_hugetlb_range(unsigned long addr, unsigned long end, --=20 2.50.1 From nobody Mon Dec 1 21:33:02 2025 Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 91B141D5CC7 for ; Fri, 28 Nov 2025 07:02:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764313353; cv=none; b=ElUvAP7IQ0EugXEhW+BplczddmqZcWySEBgcfUzohYu/nJUbi7j1Z7di/rYaGuWOMf5J8p3UbWm0GLuuKg+8ur0N3pdYFnFVfvAg4VrMxoH822o6lXPBYuMngW/IhQstmQAI1g4AWRGXf4d1hGlRmB5XPwoSS4c88qHIny6L9HU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764313353; c=relaxed/simple; bh=2Pw+PYlPoIjp31GYJtL7CC3cOrTes5aTZgGlpCDQzWg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=SHPdVkkdvrrUF6JS/2eCT9yj7PkKTh1uZW0uSMvbqZmfXYyIFlg+DPF+D80HuV/ZZbX99FSmN4YgJImcxUzhKcdLwTudzJdQL271jVLIVON87PhMUkUKA+TdYv8y4ovhhDP0nm6xWECqFyy4KEqsEoyKrW2xezQs9qwAvPATZIY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Tppl6A2U; arc=none smtp.client-ip=209.85.210.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Tppl6A2U" Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-7b9a98b751eso1168442b3a.1 for ; Thu, 27 Nov 2025 23:02:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764313351; x=1764918151; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ldaa1rRIaRl5EF/G8lLrfM3pFFPazgVKbcxuDFu05u4=; b=Tppl6A2U9v/frnwxMT50HhVq0yOoX2p0flKBCNavcnaNDuVpOcCbM+bHKA3hEnbCs9 tis/qZ23ksed7fYWPpi82VLPUzKfC/+Y/GAcHDbzK4NzX4eTkh4LPutpxXMr7PVfgTjz tokSGXtk2SDwFOAz+Cb3FZfqrk1rm0aXJqeXn7GtlDqpTtHGVhpHfIG3w5urL0s5SPl7 JHYfrOPS8TZYXH40V2Mj7hxyY4svVcav5CO6Vw7+9ehaqALW4mMoMSskGhRUPYUJ7ZN4 ML5vSRgM8B0hYx8u1Vs3KV5cBcCrTDORHfN4wuw4Q9WTZyjphM2xrV4fmnqY+RxKP5b/ PStw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764313351; x=1764918151; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ldaa1rRIaRl5EF/G8lLrfM3pFFPazgVKbcxuDFu05u4=; b=qU26fi8MCL75v/FxQsXeEyJsN8wg2B0xqd/gX7fcDP/tbEitZAe0FKbA9gwIZ/cA8Y QhphkRFw1qKCINiw0JI91QjjPmaiTm5KY1ubn6Ftk2iyeaspLQYl3VvFT2d/qwOUk5l5 SeGz8Ru26o8Io0Fhws5iTvf37MmpTGTiKSpGpuI8205mMAM88i6t/58VIy9U6JSyWW7k OvVGtrnMpDcqYK0NEB3r8GXnjvQaf/YlN4JSWKvl9THxbDt1rNZJRRSQw7prsgBSo0DS ZLrLzba6yme7v9KPF00khuiwVQJle6bIb2eJ8xewpa9VXEGlMe1k4Npvj8Ruz3NwS0sC 4ndQ== X-Forwarded-Encrypted: i=1; AJvYcCUv+ZR+sDJoUZojNwBZMNisxl+ltKq14uO0InqGpGKOUHLkyDOhgbmf9ZcFF9MXQIYtXfPFi6mJjx8lQAU=@vger.kernel.org X-Gm-Message-State: AOJu0YxUhAIxBDxO7z2QEJnz0Avdu4reppljZ1+EXGgznGg1vbPOSrIO fHBGu5rXglTMTjkJfhE4fmXAv69FvCuk5iaYXeIZr3pFPL/xRdNttNWA X-Gm-Gg: ASbGncvUJ3z36fkxwilyz6v+vVUZbz+ANO6P7Ggr3LbP2FnEQKCh3F2d9p+rAVaJ1rB Wjg5turT8i5Y+M5F0RrE137Vpt3l8prV8wKjHwFGvdewIXuM1MsqbOVfjN51eXhltTDvBkln8d/ BNbpPfRcyJQJSMMZVNKBH51/yFoDn4y3e9xDp3ZL33eWMqnxTbVmXMg8MZKcE5aVzWPox9NLcmf 7kBdkgsTxEO+KGiflorvowA7pxh0SeSUE183Sp2W6jT6NuKRRq3uoXNbQMN7+WpIA5uqcSEzrzm 1VWVejI3VeX50hwA67ti19bVq40b2DCpNaQOgFhEp5xkER/UKJv5qjuBGVRtQgG/lUaQ/9+YaCi vezNi2xkl4+idoO5mbuau1V2VMjzvX7F+p4cgNTWP6SwGsCq42l8XefyfDHsoOBFONgzvX8yD4q ovqvldn717fSSD/NukafoGd2R+eg== X-Google-Smtp-Source: AGHT+IFLY8FCMa9pQ64sU325U+C9KpdSRPiJnD1VDD+lEnxd9QofPQxxuqz3/1FcjQt20TAPXbjXGQ== X-Received: by 2002:a05:6a00:2ea0:b0:7aa:8397:7754 with SMTP id d2e1a72fcca58-7ca88e8eea9mr14312467b3a.2.1764313350601; Thu, 27 Nov 2025 23:02:30 -0800 (PST) Received: from chandna.localdomain ([106.222.232.43]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7d1516f6970sm3864693b3a.17.2025.11.27.23.02.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Nov 2025 23:02:30 -0800 (PST) From: Sahil Chandna To: akpm@linux-foundation.org, david@redhat.com, lorenzo.stoakes@oracle.com, mhocko@suse.com, vbabka@suse.cz, rppt@kernel.org, surenb@google.com, hannes@cmpxchg.org, shakeel.butt@linux.dev, zhengqi.arch@bytedance.com, Liam.Howlett@oracle.com, weixugc@google.com, axelrasmussen@google.com, yuanchu@google.com, yosry.ahmed@linux.dev, nphamcs@gmail.com, chengming.zhou@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: david@kernel.org, Sahil Chandna , SeongJae Park Subject: [PATCH v4 2/3] mm/vmscan: use %pe to print error pointers Date: Fri, 28 Nov 2025 12:31:43 +0530 Message-ID: <2c842a64fddeb0fe0cac087783aaedd97edc3191.1764312627.git.chandna.sahil@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Use the %pe printk format specifier to report error pointers directly instead of printing PTR_ERR() as a long value. This improves clarity, produces more readable error messages. This instance was flagged by the Coccinelle script (misc/ptr_err_to_pe.cocci) as an opportunity to adopt %pe. Found by: make coccicheck MODE=3Dreport M=3Dmm/ No functional change intended Acked-by: David Hildenbrand (Red Hat) Reviewed-by: SeongJae Park Signed-off-by: Sahil Chandna --- changes since v2: - Add Acked-by tag link to v2: https://lore.kernel.org/all/64e15c6b2ce86d7824f54e9e001b6f5b44a= f48b8.1763796152.git.chandna.sahil@gmail.com/ link to v3: https://lore.kernel.org/all/db049e564cafcb0913bee930d6a577ea430= 44f5b.1764177933.git.chandna.sahil@gmail.com/ --- mm/vmscan.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/vmscan.c b/mm/vmscan.c index b2fc8b626d3d..29ed0b304b5c 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -7500,8 +7500,8 @@ void __meminit kswapd_run(int nid) pgdat->kswapd =3D kthread_create_on_node(kswapd, pgdat, nid, "kswapd%d",= nid); if (IS_ERR(pgdat->kswapd)) { /* failure at boot is fatal */ - pr_err("Failed to start kswapd on node %d,ret=3D%ld\n", - nid, PTR_ERR(pgdat->kswapd)); + pr_err("Failed to start kswapd on node %d, ret=3D%pe\n", + nid, pgdat->kswapd); BUG_ON(system_state < SYSTEM_RUNNING); pgdat->kswapd =3D NULL; } else { --=20 2.50.1 From nobody Mon Dec 1 21:33:02 2025 Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B39C1D5CC7 for ; Fri, 28 Nov 2025 07:02:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764313360; cv=none; b=YHG9e5/fyMUoVEEBQAM7PiMLNOnRJyslnPOQBd69AgwThB3nDT8k+ZeyT+ANd2K6O0DMwnUzHIf0XaWJnF1+aWQriWHjAo75rz9WbIJ3DMq7nKm66xeamikOqS4Uh0lT6if5a4S8ku6OT0w/ZSoYaUTEqEPBGIb9l87Vs6NLjXE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764313360; c=relaxed/simple; bh=sdpAY96DPTBlXcVOF8rmQNj7mO5waknQex/3UyhnAu8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=MDtVjt9jO95/pEcyNBmKVhnMwS+/f2FwzkaKMErfrbT4z9zKuOkcOSTTxdH/lCUO36CnYwgYWl/8n3IUVpVnJMUpY4fppnYUA51YuALm4o3dCW4PD1VuH+L6qBYSb3V4W1MgN2uStUaSD7mYVKvWxeLeHp0UJ07l4/zFCWRcBiY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=D8IcH55i; arc=none smtp.client-ip=209.85.210.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="D8IcH55i" Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-7b7828bf7bcso1755325b3a.2 for ; Thu, 27 Nov 2025 23:02:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764313358; x=1764918158; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VbEr4NFSSDU2oD1Km1Gnmw0U8TstbeWoaIABiLKZRgU=; b=D8IcH55iu54GMMC4WFJjPxTtls43ZddM6eYw7D9jCqXQMsIauRfhenPJnULq2zDdhj j/HlHAYI3FMwAXEhnsZ5OBhhCkr/L0mKGMQywdpn18I0BSq3ikQOzLWOwgS/0pLigw2l sTJSmutHkFLxoEiOU6an5hqxqATTErRU12QkXQ1Kd7XGl+q5tc12fj6OkEMkgGwQHPZF ZWloh/T0CFzGuv0ZFShiKXfdpnV1OR3V9eim6GPrM67SsUfGSz1k1NQZY0sOLrJCQ4nH of5XJJ7BYBJA+Up8D9iqGRgmLQH25X5QH9ouR/UQXmGB+vgUR60y5B5qaCwU6w2dyVBt 1EAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764313358; x=1764918158; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=VbEr4NFSSDU2oD1Km1Gnmw0U8TstbeWoaIABiLKZRgU=; b=joZxH0lBVJsnV7uSFxk1cVodhjo9jMMEMXydT0Pma5St22xERPefIIcVZnwsd9K/XR Bw5jxnFdie8Hr36KIyjKZ9ov0MrR3JkNuJna8d7s87+61xQSyQLspSrN3I4MPO+KGGOh Kumm5m1WREm2O96uSY6e2CNOPrvpGSwoCFDnqCe+Dmwzh+uDCGWViwgn68v/0OgiGhJd Zfv8js5Awpy6moeSOk+5UPgiaAeTpGbJcNQz7zT9+uP6yuNysYA0cP62WQs2zVhZEL3G dx0H22ia5fOaSz8bCJypMozsFMxVBQsRSz0ocma5E0t6WbeAm/XTTgOpRD4+uPQogyFd hm1g== X-Forwarded-Encrypted: i=1; AJvYcCUeXB9Y2of/8yvvENzRiTNzHGqPWnUJ4grWAtf17yXdVYvMOAnOjId6QIQ6QnfOtPifzvUu673LlaruwsY=@vger.kernel.org X-Gm-Message-State: AOJu0Yz1mKmZaz5SpQZ90baUk1pvpYWBfaGS5p0Szsqm7X3bl/iWoiVK RN3oMDy5oGL4xism72GixYWkL4xDkq9Ixs9R/yC4yVMhS7vGrEu3pmir X-Gm-Gg: ASbGncvd7mmvKVDcQ38QfvxhflYlagrKSkZaETqZUfOQbGjolCdrdFPdSLb4ZOcuXtI 8zGPzLnAIm67SHxO+Tl1eCbkx6LAOfx54lJHRomdLNC3GSpTDDLBMcPG1rF0d7xhyjeO4LUfJMx U3YenvZ5v3ZFPMU28vNd2HX4/g3Lnogu5JIzs8hegaCSjcriIJUSq4iFzqzQDbni0oD9x4WKOmM xSJ/QINufNJMEQxf5KA23ljRR83hmKcXXLL0y+6wr4o4MYez8E6v1vNSDNnOo8WubCvFt1lPrli MRZXwmnqfv47/VNI3caH/SBq7GtDyjSkTQCGKEJ6tEYMbqGoz3MfeZO5DsziM3bG79f+k2S7kxH +JgxKk6Cm0qmiixIMa0lHoQuMLGXTtcmbFsUmBdxW0819O/wZE5gIUGGPyUBLxJRNPcFcX6F2gr 1VKUmUsNyBN6K82LOdVlzwj/XDcA== X-Google-Smtp-Source: AGHT+IG+jfPwGFuSGbc9384hQI66aYvYFTJMQRPbCEt7+8Y+u9MqQRIRwN5jEtL8xJ0nDPWRmCqMzA== X-Received: by 2002:a05:6a00:3e29:b0:783:c2c4:9aa5 with SMTP id d2e1a72fcca58-7c58effc088mr27998083b3a.32.1764313357839; Thu, 27 Nov 2025 23:02:37 -0800 (PST) Received: from chandna.localdomain ([106.222.232.43]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7d1516f6970sm3864693b3a.17.2025.11.27.23.02.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Nov 2025 23:02:37 -0800 (PST) From: Sahil Chandna To: akpm@linux-foundation.org, david@redhat.com, lorenzo.stoakes@oracle.com, mhocko@suse.com, vbabka@suse.cz, rppt@kernel.org, surenb@google.com, hannes@cmpxchg.org, shakeel.butt@linux.dev, zhengqi.arch@bytedance.com, Liam.Howlett@oracle.com, weixugc@google.com, axelrasmussen@google.com, yuanchu@google.com, yosry.ahmed@linux.dev, nphamcs@gmail.com, chengming.zhou@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: david@kernel.org, Sahil Chandna , SeongJae Park Subject: [PATCH v4 3/3] mm/zswap: use %pe to print error pointers Date: Fri, 28 Nov 2025 12:31:44 +0530 Message-ID: <6d729a60eb71baade3670e5bb609a068683af3eb.1764312627.git.chandna.sahil@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Use the %pe printk format specifier to report error pointers directly instead of printing PTR_ERR() as a long value. This improves clarity, produces more readable error messages. This instance was flagged by the Coccinelle script (misc/ptr_err_to_pe.cocci) as an opportunity to adopt %pe. Found by: make coccicheck MODE=3Dreport M=3Dmm/ No functional change intended. Acked-by: Yosry Ahmed Acked-by: Nhat Pham Acked-by: David Hildenbrand (Red Hat) Reviewed-by: SeongJae Park Signed-off-by: Sahil Chandna --- Changes since v2: - Add Acked-by tag. link to v2: https://lore.kernel.org/all/0c00ceedce6e0d9aed35cee5faf15fd9126= a1f70.1763796152.git.chandna.sahil@gmail.com/ link to v3: https://lore.kernel.org/all/57b7205813aa87c8f5c8bf765e5a8d88dae= ba68f.1764177933.git.chandna.sahil@gmail.com/ --- mm/zswap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/zswap.c b/mm/zswap.c index c1af782e54ec..c35604db32ad 100644 --- a/mm/zswap.c +++ b/mm/zswap.c @@ -749,8 +749,8 @@ static int zswap_cpu_comp_prepare(unsigned int cpu, str= uct hlist_node *node) =20 acomp =3D crypto_alloc_acomp_node(pool->tfm_name, 0, 0, cpu_to_node(cpu)); if (IS_ERR(acomp)) { - pr_err("could not alloc crypto acomp %s : %ld\n", - pool->tfm_name, PTR_ERR(acomp)); + pr_err("could not alloc crypto acomp %s : %pe\n", + pool->tfm_name, acomp); ret =3D PTR_ERR(acomp); goto fail; } --=20 2.50.1