From nobody Mon Dec 1 21:31:23 2025 Received: from CY3PR05CU001.outbound.protection.outlook.com (mail-westcentralusazon11023119.outbound.protection.outlook.com [40.93.201.119]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 90970334369; Thu, 27 Nov 2025 16:02:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.201.119 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764259339; cv=fail; b=fCUAi2x/VJGaLIf/Jv0umgLJYqkDtL9VAPtynlrb8U62rr0RJ0exREMkDP35g/Vpswb3obz7nDFT98e6KMIfDknJBOdslABlG5dd514fWcxFhfruRvXJy9PmPahCmpesPMpyql5Kv3rzAnHVOqetI5sXNQZcf+jvW/OdWVYBcgg= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764259339; c=relaxed/simple; bh=eorZNxmntJepG0o+V1X6ofQbdE7YdFvsGksATzX4V64=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=JRmjzRG/tHw0JgMOIPSXkZB5I9CayU9zgLghkHroy9NWyL9aV4tUbTjxh/pCgK7mDsAU5M968wCOroGXBQcktDIXsrW0/TNEzkKqmRPZFk3HExj1LNCA3YjjJ/7MLdiRc/SVKFumKkPl+/Egw7uf6btYqZIakYwbCH23+Uc600E= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=hammerspace.com; spf=pass smtp.mailfrom=hammerspace.com; dkim=pass (1024-bit key) header.d=hammerspace.com header.i=@hammerspace.com header.b=Dx42oOpG; arc=fail smtp.client-ip=40.93.201.119 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=hammerspace.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=hammerspace.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=hammerspace.com header.i=@hammerspace.com header.b="Dx42oOpG" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=OlP+tHqCz+y49J3b6kJ49Ne4CIL1fE2nJ2zZXJdMdPFwhphK+hpwvZP3J7mgWgfiW9tN51Yy+LdwnW4H9GnJpf8f0yJ6GvpnxJwDW//e9TF4YiEzhA4S71I+1hkazB9WkHS/3evIWinNHZCFgxIoqrbIU3Yckn5xKiIXn4SA7IcDduD0qeL5qk40j4H+mw/P/4rG0MGprwdGc3scAx+OH6hPxXmTM4Teq+pYe8QbYHetiiDifvMwkLScZA6Xt4pzbsPwVa3lt5/Y3OdgI2wjR8P/Wcv1p5tH5Ztmg6c7NHsVj1/ShK+Bsv0i3KwEBotC1Qh8gIypfVZNexThJyZ7Fw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YPsA0FhmhjvszZ8o71tm4/Edw2r9cbPpVjzonIvK0Qc=; b=PQ0c4hzjKWKIVsBqg7+WNW6kcAL1SfUQX0iwxte6DB6Tt4LkgW5WKAM6mKQ++jVjoEK09NPu75icwAOJoUBXdVpiCM89X2RlwaOR7tUo+piPYNRAWeXxJA0qc6OOohxzXKnPl4EJ8knNYRcrqpeUAmYVApy41HELHOyce+CaD/YUcoMu7SIuPAsZv54SamRLuUteCMidK4puYv0zKW4d0EEdhfcBHj1sYmzbsVQFETfMGWE7PnQWFQHosynZePlNim5oTnEUH11o9/niLY6gRNACxgYwackfzucuGXf/uae7zLdV4qXHtqmhFREiMTSq+S8V7ZncphjnM1HY6JQqKw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hammerspace.com; dmarc=pass action=none header.from=hammerspace.com; dkim=pass header.d=hammerspace.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hammerspace.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YPsA0FhmhjvszZ8o71tm4/Edw2r9cbPpVjzonIvK0Qc=; b=Dx42oOpGfnbo91Sh8kLdhcAPN9aqpj5ek2txTdFJw6WBP5tJPAbLMRK0kXN0zT0yVAix9rnQhBmSEa+djSQui34ckY3U1uzXWb2Ox3Gszk+sUgBKOUolmH52+NI0/f9oLSXGMvAbeqgLrRBZi3QnhDbUKSkCLsD8RbcSVYaY0W4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=hammerspace.com; Received: from SN6PR13MB2365.namprd13.prod.outlook.com (2603:10b6:805:5a::14) by SJ0PR13MB5500.namprd13.prod.outlook.com (2603:10b6:a03:421::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9366.12; Thu, 27 Nov 2025 16:02:10 +0000 Received: from SN6PR13MB2365.namprd13.prod.outlook.com ([fe80::9127:c65a:b5c5:a9d]) by SN6PR13MB2365.namprd13.prod.outlook.com ([fe80::9127:c65a:b5c5:a9d%7]) with mapi id 15.20.9366.009; Thu, 27 Nov 2025 16:02:10 +0000 From: Benjamin Coddington To: Alexander Viro , Christian Brauner , Jan Kara , Chuck Lever , Jeff Layton , NeilBrown , Olga Kornievskaia , Dai Ngo , Tom Talpey , Trond Myklebust , Mike Snitzer Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nfs@vger.kernel.org Subject: [PATCH v4 1/3] VFS: move dentry_create() from fs/open.c to fs/namei.c Date: Thu, 27 Nov 2025 11:02:03 -0500 Message-ID: <42deec53a50e1676e5501f8f1e17967d47b83681.1764259052.git.bcodding@hammerspace.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: References: Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BL0PR05CA0013.namprd05.prod.outlook.com (2603:10b6:208:91::23) To SN6PR13MB2365.namprd13.prod.outlook.com (2603:10b6:805:5a::14) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN6PR13MB2365:EE_|SJ0PR13MB5500:EE_ X-MS-Office365-Filtering-Correlation-Id: 01afa67e-86f4-4cc9-cbe9-08de2dce5236 X-MS-Exchange-AtpMessageProperties: SA X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|7416014|1800799024|921020; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?bnJ918hKPyvcjYreQF2O3C+zzKufONjgjb2W7SXcuRSR/3xYZwey3CLBJqh8?= =?us-ascii?Q?J2EQTRv/y4NaK9+5IuG+yzcMcoh1E4zrTpyXvXNcMOeMl6yGdObs7dLxYlKV?= =?us-ascii?Q?OE6y+WsmgDP7lhxoWNrezLmcOHLFf/myNlHm6rtSQbeZTU0Ks/xcI8cS2cMf?= =?us-ascii?Q?bsdY8vBbV6x5eqfnjz6ZIWbbTmBbdZRln2M6OIcTmEOPipfOtY7nQtZ72ROR?= =?us-ascii?Q?B39WwY0JX29plBHfF6fJas4or9tc64MRdjZSkmKg90jVLwm84efBMxWL/J0o?= =?us-ascii?Q?1vm40X2s+mDyQoAIpmO0bNj6vCEWxtyXITgHaZxxuMHs/SOqEDKHzLTF0e2O?= =?us-ascii?Q?6E/bLJwSwguArJeZqKmyy/r7pHxA3EBXl/h+6QJIKPQaZ5c/krj/vFntkqdt?= =?us-ascii?Q?xwRCFl4z4VmdhTWIjQM4GKi2onivvmZLug8tVvVJa3sj7TF8Wpj72lQRz8Ql?= =?us-ascii?Q?vZZtCBEqNheQsyhRkiSWB6D6sdlFxqe5MmJLIz/UqUX/8A45LkaTdJ0LE4/x?= =?us-ascii?Q?cLhiKMcaHq0LBmU4mf77yGGRFsN+lQ5dPnl+zPE9B3z/H/te+dVKfhiJwsCA?= =?us-ascii?Q?HVnfVsh2j+KX9U4GY8ir+fNwDpulHITDNh1lHYytnaehl4iEfnkPj0jok7vN?= =?us-ascii?Q?t+kRhXO4do8XKYSg48H/dip3X9kLD8wHSNITVJ/j1oMCAGFQkFBMdmJ5a5FW?= =?us-ascii?Q?cLsHbAXEJ70a9XToNB7ylCUYvNnNqEhD2cVfiTKd+DYknp9cdV5rP0SJSqBs?= =?us-ascii?Q?G1y1An/IqnOZkDlKPw8N8L4yUex2PmN6MzDZLBy9cuq5qWQWTV9QzZiIubMa?= =?us-ascii?Q?t33igmNUYmrOv7Cf6PZtrzE+tFJBgAdwbbL+BfMp/vw1SWp6GxQn9/7VePRh?= =?us-ascii?Q?KEpt0wZ4FjEADxYpyjMlZa9te4Ytles4Fd8NkZGmQ9b+SI6k2QFo9IfftgZn?= =?us-ascii?Q?P0LznuCMPqblpBTlLuU8GK0KZVdkI4NQWqIjV9ARFIm0v3Ps6C2WbmtStGDt?= =?us-ascii?Q?G/WMsLK/YDe403j0GAVx5nQHvLn5exMcbgnuT/e4y7FcLAdidmxJlvn50FKl?= =?us-ascii?Q?QNEhHgj98ZQTzMTTXM7C0WL6oxz5nHrtQPTqK/2EOUCqb4CHnykpKoxsFpv4?= =?us-ascii?Q?ONC56GAfGSyXLZL+zbyxnBhwak87V8ENIlaSmJ0JoAIf00vcksFIKh13gCeD?= =?us-ascii?Q?QQl5hd/iWb9/78BUB/QO4yJ2dpT4K+Pa4xRXlx9jILGDnz9rei2faGV/tsER?= =?us-ascii?Q?MPbtuPk2XX0L/9DCieqM6UIbuTP99K4uCotI9n4bFr0K2KYtlfMcDbNMtPOj?= =?us-ascii?Q?uBD4GVB7Jverh/WjEGdVhfw6rqwfIMj8v6pzBdBcQc+BeaOA46nJ79hE3/mF?= =?us-ascii?Q?bx9/jUpE0OQw4By5exgXGpBElvV9x17OMqJz+UkO41hPQuWMPTWl6mcG0DOB?= =?us-ascii?Q?nOgmD2oTfRyJYcZ4NGOcZRa6wvkcMZNHI6I1V9aRx/Ps+mh1epiqqa6maSPc?= =?us-ascii?Q?T272nmtZX/JTYB4=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR13MB2365.namprd13.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(7416014)(1800799024)(921020);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?erwEyW9M4iodf4mKENclV2J/iuzJaOyErTLdT+ieXWY1Kh+7DvcdR3K5mB7J?= =?us-ascii?Q?o96sljOnjRI3V4dg46j6Uzh1ogqP6rSSFsCxQ6ofXvNZpae7asBQ0OydXBZJ?= =?us-ascii?Q?3DO1gltSM6plyvpfyUvjxG6LOqZYpCQRLfj7zCrGXajs12dbGuo8qFvcQ2Hi?= =?us-ascii?Q?3wiZhfmkvRq2EEjc4a/8X1W+GjOsZ5kMtne77vPqvcLh2DqqybAhZovcLjuJ?= =?us-ascii?Q?W+ZRkZURE01eckkIiWYfCDUJWsJM7Tuzm00NghzYcHh4GG6oKhIJ8RLsPcLu?= =?us-ascii?Q?TH9foC3Wu9nRjCRw7naQCbrLKDQwZpFeWfkf92SeAoguO/AFh5QmR+rRtpX6?= =?us-ascii?Q?cBn0vMlbLR4DTme+dOr4IKCcD0vpNt5dUP4RTS0sZORlVRTGtV0jQ/ucWGQN?= =?us-ascii?Q?rYpuZ2aBk+i8upTsRtCF9n1qSk2XEtMsUJAb9jNkd+qt8GG174HWQ4Sahi2A?= =?us-ascii?Q?kryiLZjnW3q/jTUnZqVKZ/7fqOqkDjSa0ygghNdiDyNIaBz/xbiBcpR5BQOl?= =?us-ascii?Q?p1pr5UdqSnL+k95DULBCEfvrH2A+0f4amNTH5w6zr3xTbHIupl+EZVzjXXE+?= =?us-ascii?Q?L1OvmpmgaNWXCsK59Sm7NzaHcT5ldML1yAJN+ZLtz7ZKhLsLTW0w6CwyGCnO?= =?us-ascii?Q?2PMMQ/3xRie5ymkEYxic2qH2nuHjnSRwLIa65WikMcYfQSBgYxJpqJfBBBxW?= =?us-ascii?Q?OHziukwDYERn6Ec/FEdlLFa7nBgSE+FQQowWbK/17encIDsYMLgy4G83zJFn?= =?us-ascii?Q?QRtfPITKmru/COl9S/1UMn2FtQ9MeCjdi5rlgOki7O0Wg/PjCx6b2fqdJD+D?= =?us-ascii?Q?P83xHCpSQHiK3kDTnWDxs8BenPPvJt+WB2icLRhvJhF0T8enVvesu0ETaiOR?= =?us-ascii?Q?c1tqJZ8PVu6bKxoP8QCGN6Kg5AnQfxnwl4Q+YI/ArmK7aZif4+qJ/dTdTnVd?= =?us-ascii?Q?bB6YiRo+nn15OrMuEvIfHP/pa5bqJEajV3qCdW51nGClgIe444Zy2kkNf4h1?= =?us-ascii?Q?/nJ1npAMhKU6EGQHsL6VKJjsC2LJ3CusGXJOuN3r3g6Jc/+UT14TyAYFwzDC?= =?us-ascii?Q?X/WJmH33nQ54ySMXcezloDO1GrwjuFY1KBVufQ+pPI7eYk+8RHGHAFUlVMuO?= =?us-ascii?Q?Qzyk+V+h+/ukIzZHgKYAzeI8n7U5Mly/BX43rxp4iBtmzYvjqJy3wmRzEwns?= =?us-ascii?Q?6P/EZp939l6tO5IZ9YF985/chw872A+5GWF5pfRJul6BCCz5nx6p4m4O0axc?= =?us-ascii?Q?EH4+90fNr0tL+URJEz5EMCmZBr3kMYKGNnpfmmURdqWmYXXD7tria2LRnszM?= =?us-ascii?Q?tqqan3onupVFpgRKiHGkeZxlSuDSBwv+42viwGonm69a5Jzs4Knnmazk+ROJ?= =?us-ascii?Q?zppCh3qzB2Jsw7yb9R2a+ZsT87TjOX5XAthTkOE1mMHtv2Mk1F3CaB7/egB1?= =?us-ascii?Q?WyXovNrNSekw/w7dAWdfnhpUjDThciza3jJlW3fTlAOqP+yTiquOKqXHj8mI?= =?us-ascii?Q?3giQxAu3L1CLU75oPMKmXDXho+o87hlCBpVzTixQtBzHm4noZ6XAGc2h8JhR?= =?us-ascii?Q?ZfoV9qM1LsxRLrYd06am/GAGrvf+wGAgbqiaylL1GPjRXeGDLFQ5V5UCkfEe?= =?us-ascii?Q?bw=3D=3D?= X-OriginatorOrg: hammerspace.com X-MS-Exchange-CrossTenant-Network-Message-Id: 01afa67e-86f4-4cc9-cbe9-08de2dce5236 X-MS-Exchange-CrossTenant-AuthSource: SN6PR13MB2365.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Nov 2025 16:02:10.0297 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0d4fed5c-3a70-46fe-9430-ece41741f59e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: NhnOd+uEQGibJp6AYke9QLe4C8+SsuQvPS5I9PLu6OLrmTFrydntus/gzw9cvao4O8ay9Ib85hqQg+qclRmiCk1udqnE4dtnrgx0295tkcc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR13MB5500 Content-Type: text/plain; charset="utf-8" To prepare knfsd's helper dentry_create(), move it to namei.c so that it can access static functions within. Callers of dentry_create() can be viewed as being mostly done with lookup, but still need to perform a few final checks. In order to use atomic_open() we want dentry_create() to be able to access: - vfs_prepare_mode - may_o_create - atomic_open .. all of which have static declarations. Signed-off-by: Benjamin Coddington Reviewed-by: Jeff Layton --- fs/namei.c | 41 +++++++++++++++++++++++++++++++++++++++++ fs/open.c | 41 ----------------------------------------- 2 files changed, 41 insertions(+), 41 deletions(-) diff --git a/fs/namei.c b/fs/namei.c index 7377020a2cba..88f82cb5f7a0 100644 --- a/fs/namei.c +++ b/fs/namei.c @@ -4278,6 +4278,47 @@ inline struct dentry *start_creating_user_path( } EXPORT_SYMBOL(start_creating_user_path); =20 +/** + * dentry_create - Create and open a file + * @path: path to create + * @flags: O_ flags + * @mode: mode bits for new file + * @cred: credentials to use + * + * Caller must hold the parent directory's lock, and have prepared + * a negative dentry, placed in @path->dentry, for the new file. + * + * Caller sets @path->mnt to the vfsmount of the filesystem where + * the new file is to be created. The parent directory and the + * negative dentry must reside on the same filesystem instance. + * + * On success, returns a "struct file *". Otherwise a ERR_PTR + * is returned. + */ +struct file *dentry_create(const struct path *path, int flags, umode_t mod= e, + const struct cred *cred) +{ + struct file *file; + int error; + + file =3D alloc_empty_file(flags, cred); + if (IS_ERR(file)) + return file; + + error =3D vfs_create(mnt_idmap(path->mnt), + d_inode(path->dentry->d_parent), + path->dentry, mode, true); + if (!error) + error =3D vfs_open(path, file); + + if (unlikely(error)) { + fput(file); + return ERR_PTR(error); + } + return file; +} +EXPORT_SYMBOL(dentry_create); + /** * vfs_mknod - create device node or file * @idmap: idmap of the mount the inode was found from diff --git a/fs/open.c b/fs/open.c index 3d64372ecc67..d6dbb43d41bd 100644 --- a/fs/open.c +++ b/fs/open.c @@ -1144,47 +1144,6 @@ struct file *dentry_open_nonotify(const struct path = *path, int flags, return f; } =20 -/** - * dentry_create - Create and open a file - * @path: path to create - * @flags: O_ flags - * @mode: mode bits for new file - * @cred: credentials to use - * - * Caller must hold the parent directory's lock, and have prepared - * a negative dentry, placed in @path->dentry, for the new file. - * - * Caller sets @path->mnt to the vfsmount of the filesystem where - * the new file is to be created. The parent directory and the - * negative dentry must reside on the same filesystem instance. - * - * On success, returns a "struct file *". Otherwise a ERR_PTR - * is returned. - */ -struct file *dentry_create(const struct path *path, int flags, umode_t mod= e, - const struct cred *cred) -{ - struct file *f; - int error; - - f =3D alloc_empty_file(flags, cred); - if (IS_ERR(f)) - return f; - - error =3D vfs_create(mnt_idmap(path->mnt), - d_inode(path->dentry->d_parent), - path->dentry, mode, true); - if (!error) - error =3D vfs_open(path, f); - - if (unlikely(error)) { - fput(f); - return ERR_PTR(error); - } - return f; -} -EXPORT_SYMBOL(dentry_create); - /** * kernel_file_open - open a file for kernel internal use * @path: path of the file to open --=20 2.50.1 From nobody Mon Dec 1 21:31:23 2025 Received: from CY3PR05CU001.outbound.protection.outlook.com (mail-westcentralusazon11023119.outbound.protection.outlook.com [40.93.201.119]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A37702D12E2; Thu, 27 Nov 2025 16:02:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.201.119 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764259341; cv=fail; b=H1Nzfv0L4bdYSptFJ1w3caJ5xt5x4FOEkuCR9AvIAV/eX4JSbyObQnkSYj4ZCal6sKpxC4vU7lhLCAUvCbrd+YPINSTjMA1cevqib9mjt0bZ4IW0Dlqp67ZPkhYOYrEWBe5cruZrFibXMMLRxa68ZOd7kIccNhESl21mWnMgh5g= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764259341; c=relaxed/simple; bh=tcMk80bIwgXGhIK+0n/fjeT9iszU+KR2GjSwshe+CR0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=S6hAOlbRi2qXXePlw2EopyaLlyGqjZSulgf1jMrZwf12hxp9HlJ7SMxRxLgaVlhzL2jNWqa0MGPUOy6DoV8t4bIkl/ualWig3u4p6Dk360qhG6vTc1QGXXbp14XJ8fd5+GqgHlnkgTIraM6GD7wMBc8YoORQKfGfQa+aTG7hg30= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=hammerspace.com; spf=pass smtp.mailfrom=hammerspace.com; dkim=pass (1024-bit key) header.d=hammerspace.com header.i=@hammerspace.com header.b=J1QHt19v; arc=fail smtp.client-ip=40.93.201.119 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=hammerspace.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=hammerspace.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=hammerspace.com header.i=@hammerspace.com header.b="J1QHt19v" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=gm8ZK1CV3hNGoP4cWLqxYUR1mc43HK+t6g/+fgcQHLrFtkW4CBUyCCjzzqN0F4EOP1mhLWuf6vcktzf0dixYylEouAKS3Hs6egn0ax/GPGNp7MUEx61w4956R0zDxVzGp9PxSHjQ38ZN22SPE4vcjdNHAnAL0F/EAh78VLflUvEXgRITnbfnapA2BRfbp8TxwoWusBhXMema8CH9jtAoVPRnzeriDUBiQ4AOMjdd7NBBczLz2Cvw13I7g9jSXGutXXZV9hoz0+dBPo4Ebk6d95Pff0z4PkKQ1l6FHyFrOGw+nByjzc+LW9EjPbUapNVFBcSqMiPz7qauloGQV5wevg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=V2WUDHPIQMU1UZXDJl81Hi3Eu8QFmg+9QAVvWH2BjLU=; b=gFBwK78pPfmNl4MhlilhxT44SKBZslLRuFZC96L//qPcUTIj0YP2p3vD0iew/Ndrb7iISdcmABdwG5sWn5sFqW8TE9bCeu0DE/lM8gClL7FkB320GCREHuEG3U2+Ve1xiIJooFakm7IyZUpW43JhXqECQ3YsUiGEJNIA9cP9gUWQS8xoKtF1Re2vXAtqQkalJ5vTbKZm3VGoWem9BAB4UvM/xdbpGX6iE3/Ba9DOkUBQ/ax4uVDXGx6Gk7g7OtcpVvFbGS0InRB2ngvcB4aP28URupdpdgjMd0DNNe+vJeRFJleSTmH8NhdtKVQ1hs7ZOPY7i+4VlhuKXpWNMURvDA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hammerspace.com; dmarc=pass action=none header.from=hammerspace.com; dkim=pass header.d=hammerspace.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hammerspace.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=V2WUDHPIQMU1UZXDJl81Hi3Eu8QFmg+9QAVvWH2BjLU=; b=J1QHt19vImYjrKrztsgJQG7Oc4r4d3ddydjShbKy7UV/FucnxNNN2/DlAwdswgav/Kytn3xwMmNEFam4RVCnRtR2iZSzx/4LN+bfdw9VodTLlOceVtwU2jEEgz5wKbQPhR5YVooSxVjB2UaEUQAgV7J/geAst3nc5eBHdqq2fD8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=hammerspace.com; Received: from SN6PR13MB2365.namprd13.prod.outlook.com (2603:10b6:805:5a::14) by SJ0PR13MB5500.namprd13.prod.outlook.com (2603:10b6:a03:421::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9366.12; Thu, 27 Nov 2025 16:02:11 +0000 Received: from SN6PR13MB2365.namprd13.prod.outlook.com ([fe80::9127:c65a:b5c5:a9d]) by SN6PR13MB2365.namprd13.prod.outlook.com ([fe80::9127:c65a:b5c5:a9d%7]) with mapi id 15.20.9366.009; Thu, 27 Nov 2025 16:02:11 +0000 From: Benjamin Coddington To: Alexander Viro , Christian Brauner , Jan Kara , Chuck Lever , Jeff Layton , NeilBrown , Olga Kornievskaia , Dai Ngo , Tom Talpey , Trond Myklebust , Mike Snitzer Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nfs@vger.kernel.org Subject: [PATCH v4 2/3] VFS: Prepare atomic_open() for dentry_create() Date: Thu, 27 Nov 2025 11:02:04 -0500 Message-ID: X-Mailer: git-send-email 2.50.1 In-Reply-To: References: Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BL0PR05CA0013.namprd05.prod.outlook.com (2603:10b6:208:91::23) To SN6PR13MB2365.namprd13.prod.outlook.com (2603:10b6:805:5a::14) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN6PR13MB2365:EE_|SJ0PR13MB5500:EE_ X-MS-Office365-Filtering-Correlation-Id: 66ac591f-241e-4bce-94c5-08de2dce530b X-MS-Exchange-AtpMessageProperties: SA X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|7416014|1800799024|921020; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?StiK0Y4JsMHLfWVXiBQYvnndh7D2bP8QFNTRm5YtNDwri3oOs/rZcx5yNmJy?= =?us-ascii?Q?ahgWtGlhUGllWkbvVplXyxXI9Ux4i9546Vd2jHcnaSDin+L1RF0RsM+Jkcar?= =?us-ascii?Q?0r/0mBXOtk/KrTlVx5uIK3nQHpVnmctC/vxwqIvZSGhwodW44pPARr0+20FB?= =?us-ascii?Q?i8cTXjxHBKFkC+O0ajIlhFPNqzxZ8CRAxD0b8gwE2xz+YVUJdqJq8G7gned6?= =?us-ascii?Q?Apnr/54HIaInUTZUyXIsGAAM5/1EcB7fQ53Zu6yWLMiBY+UWmjL4zFnZm/r3?= =?us-ascii?Q?WnKCBwQ/N+Gvo/Er5jWmw7SviDs8/+BV5l9va9YF6R1FfZiMBRhItuM4Xett?= =?us-ascii?Q?a58lCPtM2/Y4S1TgeYfZGOplmTD2Fbu1AVk3cNe810OwfeGtiibtmjHiUEio?= =?us-ascii?Q?6bSH0Ok6O9smblRvaslWMdN9A1SFecCkJpvJmoUQBzRPwe9bn10S8tVykOj3?= =?us-ascii?Q?NUuvJ8OR2LAfmDlSo1wwjq08y/udekWpUgQd7aaLLv5PF+7XSPd+TEvas2Df?= =?us-ascii?Q?GqsZgK61EQhWBbQjsZMT9c0XwaK/CkyXtgEl1r6aoQVkesMpfaJnse01jKSU?= =?us-ascii?Q?GnT/8MsneJJDAiJHlv2QH06ud5v2kaa4kOTNcEZsdDaVq/DOxrJofegcGKod?= =?us-ascii?Q?dHqWlhFUmBkaoMP/a6R3iP/0clvWfzFmh5xmbVX17r+Lv7l8J1Yc/Wl8oF0p?= =?us-ascii?Q?RZL/l6K2oD3oGxv9v95CiA3tPfNqznC9xg9T+yTq0vZFhdYJzae/CbkkGpaE?= =?us-ascii?Q?qPOVgJlSuKfLCz/XWnauFcxZZhma9Mt8M6Bhks6upJBwo6mN1whk1O8zWl34?= =?us-ascii?Q?hcuJuADP3F3inpPn/RnwIAbR1mG8RFgX7kJvlqYhOnXcGe/u44ptQRCrtYaW?= =?us-ascii?Q?bTNlHnXRz38v3U2Hu9ePrnerkAp8OOp2Ur3648GgolrQvkEqH46VqyX8KHeu?= =?us-ascii?Q?t+fRQ0DOn0pLOMnWx5UqQODb80R5kcrUdezmays5qSNtL38JhkYJ5aX7M3cV?= =?us-ascii?Q?WfPq/gi0NqAA4VTVhTNEwy4H5RD99xTFrXsZWJyQsvzVEz1gZz4qRMX+NsRR?= =?us-ascii?Q?vXW4ku16wA087YRybO4HPNXh1gPGIO9tbdgrdjkSViYuWiVsV+yy7rg6jcaL?= =?us-ascii?Q?rW+8JS8cPwb7U/gnUkNdPfH5caulvGWKufCWwirHgB2j38ycqVBIWeTaPGdF?= =?us-ascii?Q?hH+4rKNyJHfrB5wdNlWEADVUkGID32EPcrXJVuV3wrwD+NSagC+ZdQlWQuBb?= =?us-ascii?Q?sKtWjc6Mq3JS+Fv8T2tsj5GlKaBGNcCKqwyi+HoOlxwISy0TquvO1poDNbuO?= =?us-ascii?Q?qvwGKoh/aE8EUq0A19417c6czEL0S2X8TrwkSW84wu2VyCYHKqk0enM4FnEj?= =?us-ascii?Q?b8am17XlJJ9nFj4whgwTQIU+B4H27avZFgQx/aqq+7kpAehH2sglvsjVTP1+?= =?us-ascii?Q?MPgesLlNhYnB1HigcW/6SfsmbAdZaq85hXJ/rUFm10rW4T1t3cvO75swwBNj?= =?us-ascii?Q?NlPUUjCs2wgyyi4=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR13MB2365.namprd13.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(7416014)(1800799024)(921020);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?mTFu2fqWMG+aimJyipK8yQsHtF+3IsotbZOxCQphDGatZOzlv2zcXARIHShV?= =?us-ascii?Q?2gxCd9I4Py4JMqmLVHMocyyfcb0Fh9YTLvykzDZKsfAVneByok8b1AIZGt6I?= =?us-ascii?Q?8al3IvkKh8IOevca1rRXizJbYmSRV2XteAzKGcqlhpzdTRwXwNYMwBpsJeHz?= =?us-ascii?Q?CI/iFV+/HaxNO5dgo40IqhBoIlLWqcxPH+PRwVR6ggdpDtdlmZSY7thGxs6H?= =?us-ascii?Q?eDF5BgeG+IHF0xNkwaTRvWi+HVN0FzUok7cDFyGJZFdFqK7NtWa5sIS4wu44?= =?us-ascii?Q?OZjGU//SHB0H5LMc80kTVB2knOCBldC1Wvld6iBLLPkTeUXdGqb6SMbkkpMb?= =?us-ascii?Q?IVnSNhxOfHfKWX5/4qqjippEIaBKHTo9/C/N440iBSWLy8jz48+Cr/mMnfco?= =?us-ascii?Q?VIYA/PEvpyFeHzJktU3YIrx/UgEmIqAXEydkJvKVvpSAhvrWOoMvVCYeq0Vk?= =?us-ascii?Q?EaPhrozHQyrn83LCNja2Xvnv80EfEHczeirZ5hHukZ6IExj+VZShInKUsInI?= =?us-ascii?Q?Zj+rLRjc1mdu3MVsshKat3l2w06DtiqZTmecpMX1ft43BEJ5nfKS0bq3i1z3?= =?us-ascii?Q?uEd45IMjmaTCKRcg7HBWsbyus3ETLdAkf/JehrH3+LGgQ2Fd/mMep0Y/VHV7?= =?us-ascii?Q?4EFZOTdosgPz0lpKKQLfMk9ot3Rgj8WPVMO+1sq7L1HLg+oaleEwVzmmFvZy?= =?us-ascii?Q?gz/3OTQ1xgkUTece+aaeXvMd/fBl2d9h33DoA6Xeuw5gyXWUyhUFViUWhcT6?= =?us-ascii?Q?G4y4LKAhhbe2mPpocLd6PNa6Nus/gcxgNQTUdQOvDTv2QMuF0dek6K/Mbz7N?= =?us-ascii?Q?iDtONvld9W/R7zkNWU4OlxJvHOUnq00Rxz2dPMJX6AWQ911nm0Er4r+WPzuJ?= =?us-ascii?Q?MO663228Y82x0v5GMJjHIX442ip8c5a8nxDjJrmbKR9eiwquhKk+OFVnuTdj?= =?us-ascii?Q?dG9LNT5sJnSIjdc8RytXLzamFqqUINsNd/sci26DwPCUjmQvSsdpmGwZNYBH?= =?us-ascii?Q?+WwLtPIfDV3TWepPUAtcHus+fm3KiA509galKk/u2+t93RDkapN35DXLMVjZ?= =?us-ascii?Q?uj57YIgMOUdz34z3xnOtNdch0d/LrjuKsBjHb/xNEBUN2HbtsKzBNiJERsVj?= =?us-ascii?Q?Ock+WLan25Wu96urBHhK1AqhXsWACLX4tdPwoBL6mc69ihmWnJoX4+r55NE9?= =?us-ascii?Q?mnFB3HsbVkcTnlqsa/X1r65A0Gdo5imWU6JHNQ0HD3SvuiJS8Wpt5SlKxuv2?= =?us-ascii?Q?cxiSa8T4O6XoKRrfc17PVmz4emr+OuyFkqeURZ9WeAELAIioMXn8CUt4t7Rg?= =?us-ascii?Q?ppr1QZNxja88/mi3036iKcoeGfiy4C9eP9k8oyN3lAVBA4VlnGboFT+suaD5?= =?us-ascii?Q?ZBrsjxjLsTEdJOipbYjyofPIiQmUQMILENklQwpSykLNSdpP0B37Z0X9mO1S?= =?us-ascii?Q?qLfHB2X2wHo3wPbmx0SR34YfoMQJoKWz8s7alyivTce8Lbba8zEcDnJwUo3e?= =?us-ascii?Q?NU6CUt/UjYll7AiXBDMowpAeB913VwRNXCU869KjRIPYcP8UtK/VGU7PperR?= =?us-ascii?Q?wdFXoW8yyMMRi69vBubQG01CNomn3v4hE1eHxGykQO3Na+ZLrZmyrx4ClLfS?= =?us-ascii?Q?6A=3D=3D?= X-OriginatorOrg: hammerspace.com X-MS-Exchange-CrossTenant-Network-Message-Id: 66ac591f-241e-4bce-94c5-08de2dce530b X-MS-Exchange-CrossTenant-AuthSource: SN6PR13MB2365.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Nov 2025 16:02:11.4481 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0d4fed5c-3a70-46fe-9430-ece41741f59e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2HiFFKEAFVILEugRoAEj7eq7RPvwtAxbVrrRQtXlmYMQTTS1NVPt3UgMJ4B2d6hWMnAlZgXy2KQhF/xFoTwFyACiKQziMa+omDjU+fEb0vU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR13MB5500 Content-Type: text/plain; charset="utf-8" The next patch allows dentry_create() to call atomic_open(), but it does not have fabricated nameidata. Let atomic_open() take a path instead. Since atomic_open() currently takes a nameidata of which it only uses the path and the flags, and flags are only used to update open_flags, then the flag update can happen before calling atomic_open(). Then, only the path needs be passed to atomic_open() rather than the whole nameidata. This makes it easier for dentry_create() To call atomic_open(). Signed-off-by: Benjamin Coddington Reviewed-by: Jeff Layton --- fs/namei.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/fs/namei.c b/fs/namei.c index 88f82cb5f7a0..389f91a4d121 100644 --- a/fs/namei.c +++ b/fs/namei.c @@ -3640,19 +3640,16 @@ static int may_o_create(struct mnt_idmap *idmap, * * Returns an error code otherwise. */ -static struct dentry *atomic_open(struct nameidata *nd, struct dentry *den= try, +static struct dentry *atomic_open(const struct path *path, struct dentry *= dentry, struct file *file, int open_flag, umode_t mode) { struct dentry *const DENTRY_NOT_SET =3D (void *) -1UL; - struct inode *dir =3D nd->path.dentry->d_inode; + struct inode *dir =3D path->dentry->d_inode; int error; =20 - if (nd->flags & LOOKUP_DIRECTORY) - open_flag |=3D O_DIRECTORY; - file->__f_path.dentry =3D DENTRY_NOT_SET; - file->__f_path.mnt =3D nd->path.mnt; + file->__f_path.mnt =3D path->mnt; error =3D dir->i_op->atomic_open(dir, dentry, file, open_to_namei_flags(open_flag), mode); d_lookup_done(dentry); @@ -3764,7 +3761,9 @@ static struct dentry *lookup_open(struct nameidata *n= d, struct file *file, if (create_error) open_flag &=3D ~O_CREAT; if (dir_inode->i_op->atomic_open) { - dentry =3D atomic_open(nd, dentry, file, open_flag, mode); + if (nd->flags & LOOKUP_DIRECTORY) + open_flag |=3D O_DIRECTORY; + dentry =3D atomic_open(&nd->path, dentry, file, open_flag, mode); if (unlikely(create_error) && dentry =3D=3D ERR_PTR(-ENOENT)) dentry =3D ERR_PTR(create_error); return dentry; --=20 2.50.1 From nobody Mon Dec 1 21:31:23 2025 Received: from CY3PR05CU001.outbound.protection.outlook.com (mail-westcentralusazon11023119.outbound.protection.outlook.com [40.93.201.119]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7AF23338932; Thu, 27 Nov 2025 16:02:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.201.119 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764259343; cv=fail; b=OLVwInhsc6nMefcOm1JYYrqUvxSo/v6QiGIsKXGiplilv618wO8BgarFLTTEifNRBV8jeBNODhacB8NlS538n9j4bC/XCF1oLE3G/VIllM9R3mo07hLiIFPD5Ex1RjHWmXQg9MpoWTJcxdHoldUII3PvI+TjF0YtVM86kD8mqkw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764259343; c=relaxed/simple; bh=Czg0mA9Dt4KqHPIFXl/m2UMz/hjAbFSCBCrwWM2DzA8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=ZH/8LVKbRopXjVEISEfysoyShRjZyD2ORNcyXwZ2Gm0Y/mwVxIkHTlhHNSQWZ2zPTuMfomOg65QmhhkZVbwAsN9Z+ujOjWql6PqYu3FIpxRW0QSnvdJQaRNDOhEbR/9RtxowcgVRQ8ywSpph9tm1+pl/cxxT+Wu2Z+CAZYRaKjY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=hammerspace.com; spf=pass smtp.mailfrom=hammerspace.com; dkim=pass (1024-bit key) header.d=hammerspace.com header.i=@hammerspace.com header.b=TZVdJCji; arc=fail smtp.client-ip=40.93.201.119 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=hammerspace.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=hammerspace.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=hammerspace.com header.i=@hammerspace.com header.b="TZVdJCji" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=OtqTomeP6EA0YWwajmCa8HdhOwSkxHr3p1xt3zCqfor88vIm9rv7sYu7RIG0V6iHDT1AZgipRDodPUM7+35YJy53vfZk/FeYqLzOmEMlhQGdeEj/c06iu10QlyC6XTR7G4xibyioTzvGL9wparbhxYk4BDCUgHJ7jdj7qcZiop00Eof2VDiNh3pmfUjkNZNgAAUdPAwASL7mWEd5H/rmiWQvne4/jezA8N+KG2vwVQ77JVEFtYf1avbqZsj5rSrF3MvYwf2FjMmt+KaJxOvf+99qWhmeJ8aDa3i1Q+fp2/NTKOKC0rIIHyNaYKp9znA6uCZ5V9VrjMMcZS1PQKUMYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zXzFWuXfD1ZubQyPuzgU7FjtCJpKBZsQ7n27zM078/s=; b=YLfkf+kWcK2pTTBBHbt5GkvH/q7yHRkld/52Uqz4ecn8qTnAxyHB/zLNFUvASssfRXhFviosSGu+NEw0iTfPTlWjyGhz12CsgOdyj1lyvQFuuazE+pM8aIallqLZ4NRpA3O/KencQ5YTuryjCY52Fmb0SV/tR4zJIqh+sClktt3mG2e1s8kUCsG/vm89MMa5Q+k5AHW6zH6aRD1OLcbKOXnbPPaONZdqZ4W8z4PSBJiFZ+T7lKVtd1YjeVxvYtAUzDaDeT/2/K+LcYfPWtwkF7kSy5jNo8hUcbY2AmEeQ1J/yTKU7zf6BZpzYeUE0vqaG2kFbcTaDV3a7gU/Qkb6aQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hammerspace.com; dmarc=pass action=none header.from=hammerspace.com; dkim=pass header.d=hammerspace.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hammerspace.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zXzFWuXfD1ZubQyPuzgU7FjtCJpKBZsQ7n27zM078/s=; b=TZVdJCjiuGvP1FSL6DyX/lvY1G3kH8BmIorE5QINs4xuEIHNDcbVfFrWC5glEw2UB67VbjIhC2IcqyVMzOQmIYtx1yhKn+7RnxmY2cPMk6gnE4vTiDrR3HO9jv54G3ZUJgRc/Z8SafJPlLBOwRfihuAZyazbd26ujFU9H6ziPag= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=hammerspace.com; Received: from SN6PR13MB2365.namprd13.prod.outlook.com (2603:10b6:805:5a::14) by SJ0PR13MB5500.namprd13.prod.outlook.com (2603:10b6:a03:421::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9366.12; Thu, 27 Nov 2025 16:02:13 +0000 Received: from SN6PR13MB2365.namprd13.prod.outlook.com ([fe80::9127:c65a:b5c5:a9d]) by SN6PR13MB2365.namprd13.prod.outlook.com ([fe80::9127:c65a:b5c5:a9d%7]) with mapi id 15.20.9366.009; Thu, 27 Nov 2025 16:02:12 +0000 From: Benjamin Coddington To: Alexander Viro , Christian Brauner , Jan Kara , Chuck Lever , Jeff Layton , NeilBrown , Olga Kornievskaia , Dai Ngo , Tom Talpey , Trond Myklebust , Mike Snitzer Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nfs@vger.kernel.org Subject: [PATCH v4 3/3] VFS/knfsd: Teach dentry_create() to use atomic_open() Date: Thu, 27 Nov 2025 11:02:05 -0500 Message-ID: <8e449bfb64ab055abb9fd82641a171531415a88c.1764259052.git.bcodding@hammerspace.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: References: Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BL0PR05CA0013.namprd05.prod.outlook.com (2603:10b6:208:91::23) To SN6PR13MB2365.namprd13.prod.outlook.com (2603:10b6:805:5a::14) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN6PR13MB2365:EE_|SJ0PR13MB5500:EE_ X-MS-Office365-Filtering-Correlation-Id: f94aeb58-e06f-451c-317e-08de2dce53cb X-MS-Exchange-AtpMessageProperties: SA X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|7416014|1800799024|921020; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?Yn7+W6kGTR5LutPfFpBTey2OCn1jVF2g98JuEjMxeNgKX7JR1a1IhgjXO/Q3?= =?us-ascii?Q?u7v92qzGm4XgX837po2CWcFZfSflgOAOsVxHqBrmjO+cr+HABREu3gMOQBFL?= =?us-ascii?Q?4TeBahp6jaSNWeaxVzlicq9XWQZtvmg8wItYUPkWzV+9qWkOxNZN9huuodhN?= =?us-ascii?Q?o83tORlHyf6a0odAd0fPOlD/++WO6/e0AFbOWKfwrlJYnfKIWJkYc03SNioK?= =?us-ascii?Q?7cLz/PHTt2nuEdwUl+dtpAalXaLpnMMjQYMLJTww8EjfjWut+faNUsFha258?= =?us-ascii?Q?q/10JTVv1H6th9Lg5EuS0ytZi8N5GhzcPFkam+Jv3jwYfef65noRel3pctcy?= =?us-ascii?Q?neTWZql8hHimJSvHIEREX0Kmjv1Gond+njRPxfehi1DGAPrtpABCD1eeT314?= =?us-ascii?Q?jahwxuWYm0ZG7yEwpvimPhFrr1lSI5/JZ25colulOnYDh7qnh5OBrN8iFNc1?= =?us-ascii?Q?g0x3fPBmX9TBxfEJ+HmOO0a04Fat0N4SQE51F1HOxWiuVcsNA+tSWTsLK6Iw?= =?us-ascii?Q?3dN+a0mb/OLH1tXWuqbIu+vj5RGmmkIGQDiJPoNG2Br4uIRzmjN2YwA7nvsn?= =?us-ascii?Q?0Hx2aYXfNATtipgZN9wE0R3mAgKWB1qIIkOV39iMR5sp2JCn5QCCZnSBIPEC?= =?us-ascii?Q?iO3pqJW9L+uGmX0bCzzAIRRZuy2cFWRqws+hEgqhCdfk6L0poZdwmwBq8OlY?= =?us-ascii?Q?uIHHQ34eTjQB4RyMGX2QBs4v8/Rl1Ni6WUFKc9RtQXywLgW6UfLfkduMKv7e?= =?us-ascii?Q?R5iNgHpY7PrM9uEGovFO7i7vXttmEVcYexXsC17At6ZlS/XNwYJqDOQ7wcou?= =?us-ascii?Q?lkGg5i19sS9kaSM7EwGd7ieLH+vkyCqso870V0zrCUIWwYb2CFTVpaHIOhBQ?= =?us-ascii?Q?MmYBox6V0KEJBUefHcjx4hmwTwJnRbjrlKE0wDoKuIxcS/dCFM5wFbEkjkJB?= =?us-ascii?Q?/kM4T6uo1lOP181FLbrQJp4b1r2jet5kqLQXORShQzVdz9ZkXLMNVNZFubMO?= =?us-ascii?Q?UoEmP4da/XUp7HkrwDKZvlqe+NV3dl4L8MUzMCS9G4F272UA4bUqqdNpJdFY?= =?us-ascii?Q?4QBR/lV0ZX59zGmIr7LBQkcc5R5rs3Eds7ZZRHzBboVwxHuVY8S4lu3jZRBB?= =?us-ascii?Q?ZIeWclpA2tKdFjUqFLfw0uKpkOSJJOevWce9Rntp516qPdNrduZDfja6fRV9?= =?us-ascii?Q?/3Em9NAosLjLMW4gPJuC6J9VQn59VHa3OaeDHW2FBdAtIXNwfSNkTtRKwd+D?= =?us-ascii?Q?m3A3me4NZypzybsAn87mQJ/K7pEtgLHtGsjigoACxyu3d1eV4a2c3FJWfH5u?= =?us-ascii?Q?EJHZvP2Bsg23S1sXuF72kN2J0fD1oHajDuO3ep8dJebIL9sKX3PbfD8JGYkp?= =?us-ascii?Q?adrmB/IQhww9BV+JP2nm6slkjELGL1rq0A8MVB1hwFd9RFM16OeVo+EhGCez?= =?us-ascii?Q?D5XbBw6R3JnetTgFUtggHc/WQyuvR73rNy44ke4t4xicDYx4h6cLjRhnZxnc?= =?us-ascii?Q?FH3BbkGjzOXiekU=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR13MB2365.namprd13.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(7416014)(1800799024)(921020);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?3VSDUinoilsIPs1GINW1qWFBcnWjMMJDJRQAT12SqkTCYDgHeRVVpeODDadn?= =?us-ascii?Q?TdG5/fNvnrTYfbHQhFqze7eSXthX7nQMBm8NlO5xMXZNHFYFz66Gxd+PQ74F?= =?us-ascii?Q?zCHNHa7/b5bgTp6ESsD48z5yYVExXpsfrljX1OGjkM84+yCs/j8oAlLyHCFC?= =?us-ascii?Q?/hj8MZP90vq8MtSjZNdGqQd8rGOpbLc1+NBcMJUIPfLq+bASWAfeawl6jGmm?= =?us-ascii?Q?5Uuw0hpkNSYg/uSGI4smE5LT510X6x7KbeE8xlhEE6O9t20IbpjjiLfcj/Zi?= =?us-ascii?Q?wJd7CMUVfK6OArqTW2sq+qZUQ5v5CjHP07MRJ/QHxEW9xHmjMJlUvvOKzEu8?= =?us-ascii?Q?P3JnpftmZXG9St5ifu98XRdiSbh72FRXYbC8k4XNWSSWMyXhhDNnjX1BSUUB?= =?us-ascii?Q?YapSpAi+zmKjHmxM01oBTpvidy41pATPq5jqHP7I0Vja9G51l4vuLmlKtmSG?= =?us-ascii?Q?EMJdeh05bs+OEn+jpYjLqhx/wXfovWemEXg8R1MU5MZiGzeXxQn9M9POW/S2?= =?us-ascii?Q?ksd7XtEs2AzF2vT528re6h01qEXqVeSmMqK8/UUJoaEh+wtq1/7FKZ1RMcIb?= =?us-ascii?Q?hf7U4hr2YnX1ShN6txSAwvtBbQ7W03udkWCigMdG6qQ8URTcKYyW9s5hBgyZ?= =?us-ascii?Q?R+TwwEp4NZuu8ETIKOxCVhpepKlgj7Vi4lgWGBt07BFWvTnBHZdrV7i//gAi?= =?us-ascii?Q?97rHxLtkS/hJQ6pAWYMhS2uqKstMlNInFxhBpj/sotmfeAX7h9E7VpdbcSSO?= =?us-ascii?Q?yQAaf/Igy3pBOJ4wnZCy12GTBF9jtntgXI/pKfeI7j/7RATcqr6Z8NGIvzp3?= =?us-ascii?Q?2PZY/Zsv8o3rSR3m61N5K2RiQB3rA+PS00B2cU4z9tB8jCEBIpautVJM1F50?= =?us-ascii?Q?S7a0ejyQ4seOY3SDt6v0Hyq3janLZ7nLvjwEkdeYROizrE0SfsxSwQxefKNB?= =?us-ascii?Q?ASPxfcftWUeewBZzafEtQx+WuqZcx67HmxPLHNTkJrFKf+5/bx9vULELWBw2?= =?us-ascii?Q?Lc5qjid8t1T9lQ1BNu3xk7grii7YkWTSrJjVfPPA237dXwsmESSuGYSFhnhz?= =?us-ascii?Q?PT+ZqmbY5Wyd2CXaBfzBr/P9ngJcjTx18327ZWRE2U0TARog4YDexDAEVg0X?= =?us-ascii?Q?vMRITc6Ajck+8eP64xLjABTBYuo5UgKEd001gywQW2u1B/AJ5s5DO8XtR+Cc?= =?us-ascii?Q?W9+CU4L0sg0mxl5JZlfAFDC/fBP2/eDjfcdw8n29sM+WgDUhXObBpMoiK+Oo?= =?us-ascii?Q?ocQHLPguGldEYUL1z7Tf6sI9+Tbpi33P0wqjs9uSJ0w04phrMpiOuTZo82vQ?= =?us-ascii?Q?w2U51FpBosorr7IKCnLuZgI7Eov45S84XSnqviYIKJgWwf3/jUtFJaQlsv1A?= =?us-ascii?Q?sMTLsZnlU79RYibg21Gwu5IXb5M600h3l2j32dBbcNepLoVZhqTD7SwboHTC?= =?us-ascii?Q?GeLEWpS4BLPvTXfI9YC1nRJIsM4KdJhntrVM4qfYPymHNMokh+7kDUIlyvcI?= =?us-ascii?Q?qT3/JNxmVoVGDcucI7Gv+6AwunytGKeidnSJ7Bn/aj6vqcN+AUI3kelobBdS?= =?us-ascii?Q?4aDTcEcE4TNuWO1wnWQYLlMG99IJOyS2JUqL9YWdPuGCnzj6lvODCqXL7L+/?= =?us-ascii?Q?rA=3D=3D?= X-OriginatorOrg: hammerspace.com X-MS-Exchange-CrossTenant-Network-Message-Id: f94aeb58-e06f-451c-317e-08de2dce53cb X-MS-Exchange-CrossTenant-AuthSource: SN6PR13MB2365.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Nov 2025 16:02:12.6546 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0d4fed5c-3a70-46fe-9430-ece41741f59e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Iezjkwt45t/jKuDKpBSm2oly2XanyeCRNihpqH2zpcbxyRakpDaBGGbcujPNY9vqPlfxI1DNzxWmRhnwFbZYAWMCBzpPd+VXW2jg8bd0a9U= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR13MB5500 Content-Type: text/plain; charset="utf-8" While knfsd offers combined exclusive create and open results to clients, on some filesystems those results may not be atomic. This behavior can be observed. For example, an open O_CREAT with mode 0 will succeed in creating the file but unexpectedly return -EACCES from vfs_open(). Additionally reducing the number of remote RPC calls required for O_CREAT on network filesystem provides a performance benefit in the open path. Teach knfsd's helper dentry_create() to use atomic_open() for filesystems that support it. The previously const @path is passed up to atomic_open() and may be modified depending on whether an existing entry was found or if the atomic_open() returned an error and consumed the passed-in dentry. Signed-off-by: Benjamin Coddington Reviewed-by: Jeff Layton Reviewed-by: Chuck Lever --- fs/namei.c | 46 +++++++++++++++++++++++++++++++++++++++------- fs/nfsd/nfs4proc.c | 11 ++++++++--- include/linux/fs.h | 2 +- 3 files changed, 48 insertions(+), 11 deletions(-) diff --git a/fs/namei.c b/fs/namei.c index 389f91a4d121..d70fd7362107 100644 --- a/fs/namei.c +++ b/fs/namei.c @@ -4286,6 +4286,9 @@ EXPORT_SYMBOL(start_creating_user_path); * * Caller must hold the parent directory's lock, and have prepared * a negative dentry, placed in @path->dentry, for the new file. + * If the file was looked up only or didn't need to be created, + * FMODE_OPENED will not be set, and @path will be updated with the + * new dentry. The dentry may be negative. * * Caller sets @path->mnt to the vfsmount of the filesystem where * the new file is to be created. The parent directory and the @@ -4294,21 +4297,50 @@ EXPORT_SYMBOL(start_creating_user_path); * On success, returns a "struct file *". Otherwise a ERR_PTR * is returned. */ -struct file *dentry_create(const struct path *path, int flags, umode_t mod= e, +struct file *dentry_create(struct path *path, int flags, umode_t mode, const struct cred *cred) { + struct dentry *dentry =3D path->dentry; + struct dentry *dir =3D dentry->d_parent; + struct inode *dir_inode =3D d_inode(dir); + struct mnt_idmap *idmap; struct file *file; - int error; + int error, create_error; =20 file =3D alloc_empty_file(flags, cred); if (IS_ERR(file)) return file; =20 - error =3D vfs_create(mnt_idmap(path->mnt), - d_inode(path->dentry->d_parent), - path->dentry, mode, true); - if (!error) - error =3D vfs_open(path, file); + idmap =3D mnt_idmap(path->mnt); + + if (dir_inode->i_op->atomic_open) { + path->dentry =3D dir; + mode =3D vfs_prepare_mode(idmap, dir_inode, mode, S_IALLUGO, S_IFREG); + + create_error =3D may_o_create(idmap, path, dentry, mode); + if (create_error) + flags &=3D ~O_CREAT; + + dentry =3D atomic_open(path, dentry, file, flags, mode); + error =3D PTR_ERR_OR_ZERO(dentry); + + if (unlikely(create_error) && error =3D=3D -ENOENT) + error =3D create_error; + + if (!error) { + if (file->f_mode & FMODE_CREATED) + fsnotify_create(dir->d_inode, dentry); + if (file->f_mode & FMODE_OPENED) + fsnotify_open(file); + } + + path->dentry =3D dentry; + + } else { + error =3D vfs_create(idmap, dir_inode, dentry, mode, true); + if (!error) + error =3D vfs_open(path, file); + } =20 if (unlikely(error)) { fput(file); diff --git a/fs/nfsd/nfs4proc.c b/fs/nfsd/nfs4proc.c index 7f7e6bb23a90..6990ba92bca1 100644 --- a/fs/nfsd/nfs4proc.c +++ b/fs/nfsd/nfs4proc.c @@ -194,7 +194,7 @@ static inline bool nfsd4_create_is_exclusive(int create= mode) } =20 static __be32 -nfsd4_vfs_create(struct svc_fh *fhp, struct dentry *child, +nfsd4_vfs_create(struct svc_fh *fhp, struct dentry **child, struct nfsd4_open *open) { struct file *filp; @@ -202,6 +202,9 @@ nfsd4_vfs_create(struct svc_fh *fhp, struct dentry *chi= ld, int oflags; =20 oflags =3D O_CREAT | O_LARGEFILE; + if (nfsd4_create_is_exclusive(open->op_createmode)) + oflags |=3D O_EXCL; + switch (open->op_share_access & NFS4_SHARE_ACCESS_BOTH) { case NFS4_SHARE_ACCESS_WRITE: oflags |=3D O_WRONLY; @@ -214,9 +217,11 @@ nfsd4_vfs_create(struct svc_fh *fhp, struct dentry *ch= ild, } =20 path.mnt =3D fhp->fh_export->ex_path.mnt; - path.dentry =3D child; + path.dentry =3D *child; filp =3D dentry_create(&path, oflags, open->op_iattr.ia_mode, current_cred()); + *child =3D path.dentry; + if (IS_ERR(filp)) return nfserrno(PTR_ERR(filp)); =20 @@ -353,7 +358,7 @@ nfsd4_create_file(struct svc_rqst *rqstp, struct svc_fh= *fhp, status =3D fh_fill_pre_attrs(fhp); if (status !=3D nfs_ok) goto out; - status =3D nfsd4_vfs_create(fhp, child, open); + status =3D nfsd4_vfs_create(fhp, &child, open); if (status !=3D nfs_ok) goto out; open->op_created =3D true; diff --git a/include/linux/fs.h b/include/linux/fs.h index dd3b57cfadee..2d3fcb343993 100644 --- a/include/linux/fs.h +++ b/include/linux/fs.h @@ -2883,7 +2883,7 @@ struct file *dentry_open(const struct path *path, int= flags, const struct cred *creds); struct file *dentry_open_nonotify(const struct path *path, int flags, const struct cred *cred); -struct file *dentry_create(const struct path *path, int flags, umode_t mod= e, +struct file *dentry_create(struct path *path, int flags, umode_t mode, const struct cred *cred); const struct path *backing_file_user_path(const struct file *f); =20 --=20 2.50.1