From nobody Mon Dec 1 22:04:08 2025 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 09BD52405ED for ; Thu, 27 Nov 2025 05:11:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764220312; cv=none; b=fT05mn2m7KdseVE/l/wSBUJiuJO/GO4JEVBWd5UHbgvtdtfVpFnc02eX9+E8PiVG2fZUr2UQEFB8Dfge32Lw5bB0l4EE6kTpVYPfEEBZpItB8XZKbcr2ePscPJ2TqvlZeygpq2/JIIVqW+XgboyVg+65lxvAunTcgX5TvlMxvHg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764220312; c=relaxed/simple; bh=xqoXGsLfHU7BEABl2Nwm5NzQvKTRoqZO3QwTLG4qSB4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Db2lsLH2cEhjw1Fitv56nt0a0Ie0g+JaVB2k2/fBq/ahnp7RQae4fhZQKeCW2wyGX4EFJLY4YlDP6DG/CAVB1XFB2qmETa+TYCs+M0oHsmSiXXX0i3D8bbdvvxUwhpwge75edpXn2EaFXtDHgsHKDPuXJ6Sy7oMeiYfkW+4d+IA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fJ73wRL9; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fJ73wRL9" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-2980d9b7df5so5659385ad.3 for ; Wed, 26 Nov 2025 21:11:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764220310; x=1764825110; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lH7KcWGBcyMFUXjXeQ0ZgXTh7zF56Hw8Qv1tMObDrw8=; b=fJ73wRL9ZxHL/DCrdaQGYOmOdzDcJgx8q9ohDMIW9r9nCbzYZ1y3X1mu/OIrvQjv0c bENHrhGXOSx0O/Ac6dRLcyF1GvgsV9DcufnHOrWDEKWxAL2gl1mmOCcSRy68QxkQHgJf UZt6fXr4rA2/x8t/Lzde0+7ePncyyRqxwG9u1dGwn8/mSOD7AT37ZBwCX++0eJGAp+n7 UXbGLMAJ+vMJjKwW57e+RP46FLeunBQhPx6NDexMTcuKXtGaX/TX8mHAzYv6xee9vrwG 8VptozSF+BPK0HCygMP+Kxgyazckz642R1qa6nziQf2T6U6l8gStv+FPmIil1hPoY3N7 u/lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764220310; x=1764825110; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=lH7KcWGBcyMFUXjXeQ0ZgXTh7zF56Hw8Qv1tMObDrw8=; b=s+PJFwDymmgr95x2oyYTG7OX9dFA4/NNRIDSNmvUASOq12IZhjwn4Sh1CIVoSfSJrI AdGFRJMPviN7+qpQrlz06NuSx1m54eAwzEdPXkYnP76+RDwWRB3Y5lMnoo5XEa/3/+HZ Rlnj8M9J5J+Ba0AaV+LZBseSVRgNKVkia8t1t3Po7u6aYmbk2Zz2hPEX4cziWGPnStlP IAENQIPO86d9DAQhv3IHkMfpJPw5MKL8PqcBFwds6nk+8cg3Y7034ztdyZELrIHUsVc1 jBL0H0lOvlvJQWhKHGOruziNcYqMqOXKDI/PMyOwmbTvYjgY64oTrRw+nz4JPWoBCAhz FemQ== X-Forwarded-Encrypted: i=1; AJvYcCVysBHO9he+H+iUHhaxyqiUIzTeRiLyz/QrjPS5DveBeKVGLoK9C7rRf3xL8I1Xjl8K6hueXFCFrESasUY=@vger.kernel.org X-Gm-Message-State: AOJu0YyobQxlah09caGOEhvd2RZCf+C8e6Z5th1NUMVjBwmg1zczknRV +t4ksrEAFzQKhMTRfzhB3wn5RN5M1BbNLl5gFAFBq6HYIIxCR+XOAMCq X-Gm-Gg: ASbGncuj2ir7IBnphhHqOB/seKA8kIfJvuTk2N3CIhrj+XSfvs8/wi1LkQzEe2ySHGK HmEYFPhcGIjth8U+ioad1fUrZq8Adcfmoid3S1rHinjtqNpZLnT9/YHT5znMmIiLLmjep3uIIiG L4F2/KMC+uBlraGqbvav8dV3zNQ5jwtwUN33JDOOjP7N+AOotDt9lcBC8Riw+py2Oew1ju9H1nq KM9XebEGyGLKO4KfogTiNzN8+1LY1CS9CNBeSHnCWOmNWDoKYFGulFja4PJR3RGy8XIY7k0Xdrh EyF6bsnUItgDkgzVNuiKQj6eumYEOGlvT22lNWR6umTbNnTpJ0fkb45BFnw3vprVaZdKA/paag2 XHyCTq3zUIn29xNqNfwpnijotzgBveY0dJD2J2dmdG8cms+VFWjL4EeJeZXooPqbiKewzVsFnUU v66Y7QUhKSdAlp2jtdHxqINbxnLA== X-Google-Smtp-Source: AGHT+IHNWlOwlS+0w4rINsUXZGLEAulPrevlqrPihA9vZwY8xNaNEfoM4zs7C5Q7zgzN5GDxf7Kgmg== X-Received: by 2002:a17:903:f8b:b0:295:6d30:e26f with SMTP id d9443c01a7336-29b6becfe11mr233126345ad.22.1764220310214; Wed, 26 Nov 2025 21:11:50 -0800 (PST) Received: from chandna.localdomain ([106.222.232.43]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29bce442744sm3590715ad.23.2025.11.26.21.11.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Nov 2025 21:11:49 -0800 (PST) From: Sahil Chandna To: akpm@linux-foundation.org, david@redhat.com, lorenzo.stoakes@oracle.com, mhocko@suse.com, vbabka@suse.cz, rppt@kernel.org, surenb@google.com, hannes@cmpxchg.org, shakeel.butt@linux.dev, zhengqi.arch@bytedance.com, Liam.Howlett@oracle.com, weixugc@google.com, axelrasmussen@google.com, yuanchu@google.com, yosry.ahmed@linux.dev, nphamcs@gmail.com, chengming.zhou@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: david@kernel.org, Sahil Chandna , Matthew Wilcox , David Laight Subject: [PATCH v3 1/3] mm: pagewalk: simplify hugepage boundary calculation using min() Date: Thu, 27 Nov 2025 10:41:28 +0530 Message-ID: <1e01c12f7666ade41f5f34ada24ad3de1087454f.1764177933.git.chandna.sahil@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Use the min() macro to compute the minimum value instead of an explicit=20 ternary expression. This improves readability and matches common kernel=20 style. Also change the return hugepage boundary expression for better clarity. This was flagged by Coccinelle (misc/minmax.cocci) as an opportunity to use min(). Found by: make coccicheck MODE=3Dreport M=3Dmm/ No functional change intended. Suggested-by: David Hildenbrand (Red Hat) Suggested-by: Matthew Wilcox Suggested-by: David Laight Signed-off-by: Sahil Chandna Acked-by: David Hildenbrand (Red Hat) --- changes since v2: - change the return expression for readability and clarity.=20 changes since v1: - Updated boundary calculation of huge page range for better clarity. - No Functional changes intended. link to v1: https://lore.kernel.org/all/ff24b3c573b766b187b55a38497fbad0a31= 9b9f8.1763227530.git.chandna.sahil@gmail.com/ link to v2: https://lore.kernel.org/all/f802959f58865371ba1b10081bced98e378= 4c5e4.1763796152.git.chandna.sahil@gmail.com/ --- mm/pagewalk.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/mm/pagewalk.c b/mm/pagewalk.c index 9f91cf85a5be..9fd59d517f37 100644 --- a/mm/pagewalk.c +++ b/mm/pagewalk.c @@ -312,8 +312,7 @@ static int walk_pgd_range(unsigned long addr, unsigned = long end, static unsigned long hugetlb_entry_end(struct hstate *h, unsigned long add= r, unsigned long end) { - unsigned long boundary =3D (addr & huge_page_mask(h)) + huge_page_size(h); - return boundary < end ? boundary : end; + return min(ALIGN(addr, huge_page_size(h)), end); } =20 static int walk_hugetlb_range(unsigned long addr, unsigned long end, --=20 2.50.1 From nobody Mon Dec 1 22:04:08 2025 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D4F622C0285 for ; Thu, 27 Nov 2025 05:11:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764220321; cv=none; b=GOS2ewEKIGBOCPmQm8gQUks5xY+5m1v6fktfLqcH3RamsIi/916uRqaSSggTqjCTCrfwmpYZq6lOJVmoX3fweT5V6c8Nv0OIavnVoR1l+rs6CMtzIgK2SWvMVAHdRl25/8hufGcRMI6qd5OCF5YNVzyyKWgIHuI9qOMKclv4pPk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764220321; c=relaxed/simple; bh=y8M38jrp1BwL7K6nTwYBZgaigmaSp61sKVNzVDjWK4c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Pb7VPfDnuMvYIaBGGlv2LxGGj8NZXeobZVo2l+ztIcq1ARrjD0J93olJDei4cXpAsV1/jxk1VRHxkEtnwHDJYI4Ga0ysxF4oyZYrc/NxNQb0wqLvGAxlHlotcre6kdVax5fcOP/hN09xQTNdCD+iP5Ejh+8hVSlplxq1jAMls2o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dV6c0nVh; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dV6c0nVh" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-297ef378069so4864615ad.3 for ; Wed, 26 Nov 2025 21:11:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764220318; x=1764825118; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=WgeMOXdIAsZBvoC0V9rIO6y/IvHsbJRKjSiXtyCVm64=; b=dV6c0nVhkZxufh0o7533+3RvJJBOONH1E+uYOzkLcHmkwACiX+qsNTvxk8u+DFrK3j dJMppm2noA+Pe0sfk01Zu0E9FaaiIkfb0II9FTfShgwzNmJdsUR8wc4A4pa1ofomJ5H+ zxnUYfOPgKKxVd2OANcfN++2q2FheE8QsNCsLtkvKucZMZp9E1XIXD1InxTv0xUwK90b cYgLc9lcEdDfAmB2qIuv1a51AiMn8ynzec9eBYX0YYgew9D9rsdSEuma+m8JQYhBY1+U VgeDOaTWPcMe7THtuHaZ0eQEVCUYuyFLTqB4+Q9Fw1in2BvClCMBJ8SC72jmLzIbc2SY EgEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764220318; x=1764825118; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=WgeMOXdIAsZBvoC0V9rIO6y/IvHsbJRKjSiXtyCVm64=; b=iCfSlT15XYpQ4bhmFsSzqRA1uXgALlUraXpNY567d7xAxzFxlckai6+9mt3NkyntlX 2HY7D1eTNfRpDVsTLjksCWc7XSCNZ7J2RUmhVaS9ua27uFAPJFEW/vYcU+4/mTThecxz jn9pPYwtCVVIZl6EjxXVfr2j5yvBu0PYdZ7KqTOakofXPWJbIAnx7ev592Xvgpdh0wzI fjWzVxeFO6x7aQR1QgZLzh2Xwe4oG46GRexwY2c/y0d+Bxs7TV8YINgaaa88O/F5zPdY UcaH897L0Uog5S+RnNAV7JbwnegNEei4HIQYI6EcEm5V6WWfs8sQSAL8W6JFEmX+3O/h tg0w== X-Forwarded-Encrypted: i=1; AJvYcCU3htrOSupTRJNcaaREI83O0NMwzCG/B7v9zf8AUXD+PiPL+dfSC6ywIwDCcToAW8uTIfndKfxtHHE2aZE=@vger.kernel.org X-Gm-Message-State: AOJu0YwfdZflAY4UUzKPZSjSfN+c0KCGrIeVD/NP7JrbpQnlEr+0/iZ/ Uplg2tO/7SKrSjClzma+HWCohuXi+TCGybbPtqK6+OOmX99RY0HVn5ao X-Gm-Gg: ASbGncsV8qjOVjYBCpavioDPBE7d4zv3MP8lQ7tb9vaDdKPaSH9SN3SDuS2JTSRIpeK gkYm0mpO26nRyz67E80cC0T6nv/U2wprjHy9m1HNCkd+yrPjXIHzQK8szauC8Zl+E6GEEgpn+tF diD8a3BvdbdPTaYwEFXE4tQ51D5SbpqVr/jmjOHoZAWKMyXLY1fEKTDl2hXN93psxRScHSUgYud 43IpHxSNzZM4EamhoIC28t2WZ2enh6Bs1fCuOFkYVJQYooKmk8TZFJKjl/wA4s7Ev2vtOynsWsG 8cCxaK0ET/43kp2xoGSYHUkmaP1ATeMj0HARgV7/7dsHPZJq5YMV/ZnVdqtExyLylLAu37lnvXv BZXkScY0xf/JQlPlao1H9U0YZ55DbI2hQ2l+haEQUHq7Wcn0CGYtNrT+FSj6o7HdJmJPRnqMi7z NBDidQiW2gTxxLtmaR27FjSOQAow== X-Google-Smtp-Source: AGHT+IG2SqD5u08Uif7mY1Y40qA6yPwphWnMF6xNA4b9F7VhpfG4Wnoa2CTGFQnvJ+iSE2LP0H/zHg== X-Received: by 2002:a17:903:3d0e:b0:295:460b:5619 with SMTP id d9443c01a7336-29baae4ee1amr81598835ad.8.1764220318098; Wed, 26 Nov 2025 21:11:58 -0800 (PST) Received: from chandna.localdomain ([106.222.232.43]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29bce442744sm3590715ad.23.2025.11.26.21.11.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Nov 2025 21:11:57 -0800 (PST) From: Sahil Chandna To: akpm@linux-foundation.org, david@redhat.com, lorenzo.stoakes@oracle.com, mhocko@suse.com, vbabka@suse.cz, rppt@kernel.org, surenb@google.com, hannes@cmpxchg.org, shakeel.butt@linux.dev, zhengqi.arch@bytedance.com, Liam.Howlett@oracle.com, weixugc@google.com, axelrasmussen@google.com, yuanchu@google.com, yosry.ahmed@linux.dev, nphamcs@gmail.com, chengming.zhou@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: david@kernel.org, Sahil Chandna , SeongJae Park Subject: [PATCH v3 2/3] mm/vmscan: use %pe to print error pointers Date: Thu, 27 Nov 2025 10:41:29 +0530 Message-ID: X-Mailer: git-send-email 2.50.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Use the %pe printk format specifier to report error pointers directly instead of printing PTR_ERR() as a long value. This improves clarity, produces more readable error messages. This instance was flagged by the Coccinelle script (misc/ptr_err_to_pe.cocci) as an opportunity to adopt %pe. Found by: make coccicheck MODE=3Dreport M=3Dmm/ No functional change intended Acked-by: David Hildenbrand (Red Hat) Reviewed-by: SeongJae Park Signed-off-by: Sahil Chandna --- changes since v2: - Add Acked-by tag link to v2: https://lore.kernel.org/all/64e15c6b2ce86d7824f54e9e001b6f5b44a= f48b8.1763796152.git.chandna.sahil@gmail.com/ --- mm/vmscan.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/vmscan.c b/mm/vmscan.c index b2fc8b626d3d..29ed0b304b5c 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -7500,8 +7500,8 @@ void __meminit kswapd_run(int nid) pgdat->kswapd =3D kthread_create_on_node(kswapd, pgdat, nid, "kswapd%d",= nid); if (IS_ERR(pgdat->kswapd)) { /* failure at boot is fatal */ - pr_err("Failed to start kswapd on node %d,ret=3D%ld\n", - nid, PTR_ERR(pgdat->kswapd)); + pr_err("Failed to start kswapd on node %d, ret=3D%pe\n", + nid, pgdat->kswapd); BUG_ON(system_state < SYSTEM_RUNNING); pgdat->kswapd =3D NULL; } else { --=20 2.50.1 From nobody Mon Dec 1 22:04:08 2025 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F27FD2417F0 for ; Thu, 27 Nov 2025 05:12:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764220329; cv=none; b=Ouo2owYC3v0b2kqAy3rhUUmh2FsFU/dNILSi5wBC+JC2XLbA16QOOOELc1DQPrTmQvK/1xomhNmnkWBZeVIgGO7gj29IhN2nGGWtYkkbWY2w987p+Mt+U1cyxXYXjT7u4yok+n1MjQ9flO6f0DgkL/t2vDZsyJeSnT2BYV5dm4s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764220329; c=relaxed/simple; bh=cdJoysSP8nPQcN6Ejn61b2z7cmAEZAq2J23+KVk9Uow=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ACJQ7SAcJ4eOlWz3rJV2KWxtcMOKAi+w6P/NB8BrFqKcZi+/QZQOQLSoPziM+zlfNKTnfB+WzNaEEZqTJILiNBTgsO0mrib3sG1KnMi43dMo1ehNCTFl0d+GYE/m1I9amZZQ257jN9l06YndC7uOV1GGS24J7VtltUD/Y+v+2Gs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HgYvdD91; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HgYvdD91" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-29ba9249e9dso5553185ad.3 for ; Wed, 26 Nov 2025 21:12:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764220326; x=1764825126; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4dBWalwjFnHVamtYHVsgWwLGX4A7VLiPSX3ivCHmFtM=; b=HgYvdD91dgijkM/4VIAGG02qBfVZxGVP5cRcuyHwnfk9RiXemEPGIWlJB/eFJJu/C/ 1XFBxNTZMKbG+Dpgq8YvPchLq4BFWhpUrrm+ybswqGPlgxIy313+Hey950I73Yj4L5Be Hx4zW84wRIWDmtxN7kGPeYWkN9AW2BoLvDXQOa1WlsNReFzLfeQfRYrQeN/i6owz968+ 0Shd/rlOgAiCL6a2EccWQR1TcqyaK6LxmVh5jt/ugs7AL3qqFS8i5GXDmer2krUalEHD JC4k4hpT3zKXT7ULKo4BTQtlGmLGD6uFL+pi9gy0gBLICccx375YhsfzO9hdK1yNfMJu +0HQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764220326; x=1764825126; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=4dBWalwjFnHVamtYHVsgWwLGX4A7VLiPSX3ivCHmFtM=; b=ZXDSOhseH/EUFieLKhHjw47NCkWcTfB9ZGn7/asKgz0TLZuBzBojSe9GUkfCcFTuj2 OOv9J2tcodM38bF4Wusk7XQ6p9gHLzslepUOcLsKAuMUogSfwP0SNeLLe4QPMsrKOXKv TFJmCzGIrc94JlkitaBY/AuZlKDfkdHdcNAWTJuyLVWxq78L+KwaUAEg3fmwFzhIzMzi cYj0knGLr0GgSSfQ9NCHNUvB6OA2ZgzayU1F/4+JxJLwwzRdCPZH3Z+OBCYftSSo4oyz YjZqJWgSjVdMiHijryw/ib4GtdEimykgpObPCX2bPAG0v1P9nSXp2RvUgy6wc2yqmViQ sblA== X-Forwarded-Encrypted: i=1; AJvYcCUGp7szUyDvPMoc4tGlGcuG9NdECjft6S7wGNTIKoz+z9vWzNC+iuG10s/U5IM75N2sG/sWUc7Jwt8OI0I=@vger.kernel.org X-Gm-Message-State: AOJu0YyyOtcIqHo7b+5m0splu39vdOWNA5F4fV0PktoiLW6U88zAvg0e T/1iXnQQILApY5z8c+/boFJvhJxjxyhHbJ4rLxCSz7rHo6rMM9U/2M9E X-Gm-Gg: ASbGncsyCwjt5pCVMIjpsqcxI/Q2verNSoSUeio0tzxNhykJhLqY15RNds2oPmmDs/h uepE/0lSJE11FeLw0jFNY5FOsvVdMRyhhBhB0mr7d8KB9wHTMdWmTpjwba+7zWtFkh2sgqq5Cux vrHguPGhHk9Lhtk6zCubqey6X7Z69uiY/Jn+ZsqQdqlMoMcyf79YWGjQCTwPmg2on+xubQFyHqH VNA+rGTe5V2IKYfqt+RRZIkNFMu6acnsvBGLMEk9xqHpiqX/EAKNCiHcBMb1ucA6WvNR/jdovnV FScYRxNOl9z8nJDOIQJTYDnVTYV8zCQp6ErUDrQSR8jNA5MnomOSHAhMx+LCg+AfZveXSBmmmWm GNf1tlQt3s2OesJLSwvRobdgM5HUrWd/1nCCQtBhmHc0H9kinR5i7LwBKvJzbLNMnOWIx3XjP/B olot4GKERH9kZtSVHo3LCTuVlzGQ== X-Google-Smtp-Source: AGHT+IGpQXwuWyvgDB9Zathj8M9tc7BuirjqdoY1OoTWwi2hq/0yoRma2KZWQ5SQ1e5q//SQA+zovQ== X-Received: by 2002:a17:902:d588:b0:298:529b:8956 with SMTP id d9443c01a7336-29b6c6c3732mr252944735ad.56.1764220326016; Wed, 26 Nov 2025 21:12:06 -0800 (PST) Received: from chandna.localdomain ([106.222.232.43]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29bce442744sm3590715ad.23.2025.11.26.21.11.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Nov 2025 21:12:05 -0800 (PST) From: Sahil Chandna To: akpm@linux-foundation.org, david@redhat.com, lorenzo.stoakes@oracle.com, mhocko@suse.com, vbabka@suse.cz, rppt@kernel.org, surenb@google.com, hannes@cmpxchg.org, shakeel.butt@linux.dev, zhengqi.arch@bytedance.com, Liam.Howlett@oracle.com, weixugc@google.com, axelrasmussen@google.com, yuanchu@google.com, yosry.ahmed@linux.dev, nphamcs@gmail.com, chengming.zhou@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: david@kernel.org, Sahil Chandna , SeongJae Park Subject: [PATCH v3 3/3] mm/zswap: use %pe to print error pointers Date: Thu, 27 Nov 2025 10:41:30 +0530 Message-ID: <57b7205813aa87c8f5c8bf765e5a8d88daeba68f.1764177933.git.chandna.sahil@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Use the %pe printk format specifier to report error pointers directly instead of printing PTR_ERR() as a long value. This improves clarity, produces more readable error messages. This instance was flagged by the Coccinelle script (misc/ptr_err_to_pe.cocci) as an opportunity to adopt %pe. Found by: make coccicheck MODE=3Dreport M=3Dmm/ No functional change intended. Acked-by: Yosry Ahmed Acked-by: Nhat Pham Acked-by: David Hildenbrand (Red Hat) Reviewed-by: SeongJae Park Signed-off-by: Sahil Chandna --- Changes since v2: - Add Acked-by tag. link to v2: https://lore.kernel.org/all/0c00ceedce6e0d9aed35cee5faf15fd9126= a1f70.1763796152.git.chandna.sahil@gmail.com/ --- mm/zswap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/zswap.c b/mm/zswap.c index c1af782e54ec..c35604db32ad 100644 --- a/mm/zswap.c +++ b/mm/zswap.c @@ -749,8 +749,8 @@ static int zswap_cpu_comp_prepare(unsigned int cpu, str= uct hlist_node *node) =20 acomp =3D crypto_alloc_acomp_node(pool->tfm_name, 0, 0, cpu_to_node(cpu)); if (IS_ERR(acomp)) { - pr_err("could not alloc crypto acomp %s : %ld\n", - pool->tfm_name, PTR_ERR(acomp)); + pr_err("could not alloc crypto acomp %s : %pe\n", + pool->tfm_name, acomp); ret =3D PTR_ERR(acomp); goto fail; } --=20 2.50.1