From nobody Mon Dec 1 22:41:53 2025 Received: from mx0a-00128a01.pphosted.com (mx0a-00128a01.pphosted.com [148.163.135.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 76FE731A072; Wed, 26 Nov 2025 21:56:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.135.77 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764194184; cv=none; b=EFZlcNx16MuVwAfNJomvH1DeMS+B4E6aSUUYExmaKdTmMWfTwLAaCwbNY2GWv7cbjlg7d10RoxMNeLCSk/Df+uxxiazuJTFdFZtNPz1hT+u3V4Zx5HIvnkjmANLO44A/eiRA7FLoIa+cyOQ2ZE1sI8g78b05m1vZTuRLnZFvRqE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764194184; c=relaxed/simple; bh=Coi3ZFVE227bCTzWSLuy1VnbBp3+t62LhOGXIjoB9Hs=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=pDmegzuImIA2L3i101EmHS8Isnsm6LAUcBoxn1+t51N/TiwbpfkvqcjfLakmo4Hjs6Qgtxxe+gxovDA2UM93FEBELMBHwJFG7TGqbwzsjBFLtI7Y7fQEfSErZ2POqY2sG4aENoPK3nXGPXbsyARbanotN63FNXwmn/JldnVq8wA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com; spf=pass smtp.mailfrom=analog.com; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b=J9n3n15Y; arc=none smtp.client-ip=148.163.135.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=analog.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b="J9n3n15Y" Received: from pps.filterd (m0167088.ppops.net [127.0.0.1]) by mx0a-00128a01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AQH0iHg3402813; Wed, 26 Nov 2025 16:56:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=DKIM; bh=drCae m2leCMDVQEAM4Vr+y9JnoPeaF2Ep+5+ZrhAnNM=; b=J9n3n15YM28s5puHUvnlM AgswpXvLJV9jkg3foofxVM0BG9GK7l4VlmlZYdzGKkssjQfgLHilu+B08UYnMpF6 7JTxD5YI8BShQBpCmo1YtHX+9A/wRJK0KX9rG2zvcmGOaSDms97VNOLZjWBF+nsh J0MXMI//biDvmZhmBVfJ5CELMdeJ/JPQlu9S1+MroegCewtNzS+UoptbKdhelIMF tB1BfUl/b/wMz3HsfQ/ES2h90A4IXV6YlVhQjI+rCqu81k1Ks5UHqnxBTw3zV8nx 6IPz2263D7/eVtD3eZAerHALMDhx1CyniUB+cEAsGGUCuoNU2auDJypRY0JEd7i5 A== Received: from nwd2mta3.analog.com ([137.71.173.56]) by mx0a-00128a01.pphosted.com (PPS) with ESMTPS id 4anmrux8y1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 26 Nov 2025 16:56:17 -0500 (EST) Received: from ASHBMBX9.ad.analog.com (ASHBMBX9.ad.analog.com [10.64.17.10]) by nwd2mta3.analog.com (8.14.7/8.14.7) with ESMTP id 5AQLuGdA024326 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 26 Nov 2025 16:56:16 -0500 Received: from ASHBMBX9.ad.analog.com (10.64.17.10) by ASHBMBX9.ad.analog.com (10.64.17.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.37; Wed, 26 Nov 2025 16:56:16 -0500 Received: from zeus.spd.analog.com (10.66.68.11) by ashbmbx9.ad.analog.com (10.64.17.10) with Microsoft SMTP Server id 15.2.1748.37 via Frontend Transport; Wed, 26 Nov 2025 16:56:16 -0500 Received: from JSANTO12-L01.ad.analog.com ([10.65.60.206]) by zeus.spd.analog.com (8.15.1/8.15.1) with ESMTP id 5AQLu3Jc002843; Wed, 26 Nov 2025 16:56:05 -0500 From: Jonathan Santos To: , , CC: Jonathan Santos , , , , , , , , , , Subject: [PATCH v4 1/4] dt-bindings: iio: adc: ad7768-1: add new supported parts Date: Wed, 26 Nov 2025 18:56:02 -0300 Message-ID: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ADIRuleOP-NewSCL: Rule Triggered X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTI2MDE3OCBTYWx0ZWRfX0Z+xJA3rOWxr p48YsMEjicXuTKtVd8vy7zZ/atts3NoJzWyYCwFcDmcksWJsI/DRWMj9Oay3ImDM/Yn+iPF36VL i+8T2JIoBTmW2WR92JEcQJGTo6FkCdKEbo3dQ8HanqJOQYkDr6qL9gXXqmSzjq31yDVTmv8f+zA fpzwerkK6X+ZCT1HdxwsdzojYul3KTpUkLO9YEP48of36B+PuHIX3K60KTSJ24KWg1We2L9uQ2T EtP2ByBpfEpq98sJunb69Exg9xofbXE/SvAEjU0QKnChwdgFXvUnouWiecxg+IGghevoi+L30su q9B5s/itTPXw78QaQDorCW4dDHDWNBcv5C+2BrEVk56leGXD12Z+E2qBA5Gw7Rg8Y3vYM0bZ2Y2 kMANP+uEkNglKmNzwuucfAaedJvklA== X-Proofpoint-GUID: TKVVarviLdBWFuqvbxA5noipKCdRLWD6 X-Authority-Analysis: v=2.4 cv=Qehrf8bv c=1 sm=1 tr=0 ts=69277782 cx=c_pps a=PpDZqlmH/M8setHirZLBMw==:117 a=PpDZqlmH/M8setHirZLBMw==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=gAnH3GRIAAAA:8 a=gEfo2CItAAAA:8 a=W-COrTu4jwGsOlXsrW0A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=sptkURWiP4Gy88Gu7hUp:22 X-Proofpoint-ORIG-GUID: TKVVarviLdBWFuqvbxA5noipKCdRLWD6 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-25_02,2025-11-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 suspectscore=0 bulkscore=0 spamscore=0 phishscore=0 lowpriorityscore=0 clxscore=1015 malwarescore=0 adultscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511260178 Add compatibles for supported parts in the ad7768-1 family: ADAQ7767-1, ADAQ7768-1 and ADAQ7769-1 Add property and checks for AFF gain, supported by ADAQ7767-1 and ADAQ7769-1, and for PGA gain, supported by ADAQ7768-1 and ADAQ7769-1: adi,aaf-gain-bp pga-gpios Signed-off-by: Jonathan Santos --- v4 Changes: * Inspired by [1], Included pga-gpios property for parts that support PGA g= ain. Before we were using the internal gpio controller to manage the PGA pins, but still exposing the controller for external use (causing possible conf= licts). Using pga-gpios we can let the consumer define the pins to be used for PG= A, even from the internal gpio controller (but not limited by that). The pro= blem with that approach is the deadlock described in the last patch from this = set. v3 Changes: * Renamed adi,gain-milli to adi,aaf-gain-bp. Now it represents basis points (one hundredth of a percent) as suggested by Krzysztof. Description was adjusted. Note: permille (1/1000) was also suggested as unit for this property. v2 Changes: * adi,aaf-gain property renamed to adi,gain-milli. Description was=20 simplified. * default value add to adi,gain-milli. [1]: https://lore.kernel.org/linux-iio/318c31e023ebe30cc99b8743e87e869bf5e1= f12b.1760984107.git.marcelo.schmitt@analog.com/ --- .../bindings/iio/adc/adi,ad7768-1.yaml | 64 +++++++++++++++++-- 1 file changed, 60 insertions(+), 4 deletions(-) diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7768-1.yaml b/= Documentation/devicetree/bindings/iio/adc/adi,ad7768-1.yaml index c06d0fc791d3..dfa2d7fa9fb3 100644 --- a/Documentation/devicetree/bindings/iio/adc/adi,ad7768-1.yaml +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7768-1.yaml @@ -4,18 +4,26 @@ $id: http://devicetree.org/schemas/iio/adc/adi,ad7768-1.yaml# $schema: http://devicetree.org/meta-schemas/core.yaml# =20 -title: Analog Devices AD7768-1 ADC device driver +title: Analog Devices AD7768-1 ADC family =20 maintainers: - Michael Hennerich =20 description: | - Datasheet at: - https://www.analog.com/media/en/technical-documentation/data-sheets/ad= 7768-1.pdf + Analog Devices AD7768-1 24-Bit Single Channel Low Power sigma-delta ADC = family + + https://www.analog.com/media/en/technical-documentation/data-sheets/ad77= 68-1.pdf + https://www.analog.com/media/en/technical-documentation/data-sheets/adaq= 7767-1.pdf + https://www.analog.com/media/en/technical-documentation/data-sheets/adaq= 7768-1.pdf + https://www.analog.com/media/en/technical-documentation/data-sheets/adaq= 7769-1.pdf =20 properties: compatible: - const: adi,ad7768-1 + enum: + - adi,ad7768-1 + - adi,adaq7767-1 + - adi,adaq7768-1 + - adi,adaq7769-1 =20 reg: maxItems: 1 @@ -58,6 +66,25 @@ properties: description: ADC reference voltage supply =20 + adi,aaf-gain-bp: + description: | + Specifies the gain applied by the Analog Anti-Aliasing Filter (AAF) + to the ADC input in basis points (one hundredth of a percent). + The hardware gain is determined by which input pin(s) the signal go= es + through into the AAF. The possible connections are: + * For the ADAQ7767-1: Input connected to IN1=C2=B1, IN2=C2=B1 or IN= 3=C2=B1. + * For the ADAQ7769-1: OUT_PGA pin connected to IN1_AAF+, IN2_AAF+, + or IN3_AAF+. + enum: [1430, 3640, 10000] + default: 10000 + + pga-gpios: + description: + GAIN 0, GAIN1 and GAIN2 pins for gain selection. For devices that ha= ve + PGA configuration input pins, pga-gpios must be defined. + minItems: 3 + maxItems: 3 + adi,sync-in-gpios: maxItems: 1 description: @@ -147,6 +174,35 @@ patternProperties: allOf: - $ref: /schemas/spi/spi-peripheral-props.yaml# =20 + # AAF Gain property only applies to ADAQ7767-1 and ADAQ7769-1 devices + - if: + properties: + compatible: + contains: + enum: + - adi,adaq7767-1 + - adi,adaq7769-1 + then: + required: + - adi,aaf-gain-bp + else: + properties: + adi,aaf-gain-bp: false + + - if: + properties: + compatible: + contains: + enum: + - adi,adaq7768-1 + - adi,adaq7769-1 + then: + required: + - pga-gpios + else: + properties: + pga-gpios: false + unevaluatedProperties: false =20 examples: --=20 2.34.1 From nobody Mon Dec 1 22:41:53 2025 Received: from mx0a-00128a01.pphosted.com (mx0a-00128a01.pphosted.com [148.163.135.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4DF2C2DC35C; Wed, 26 Nov 2025 21:56:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.135.77 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764194191; cv=none; b=dKFgLePzy3UYU6H0Slno67rioDngIXcXKUmwaTG+ZiVew8QlTjRwZezmlcEMuaN6O2AcTUPw9htgbTsRDuxuj9d/A4apf3pRTSj/YvkLtxRDGNJb/twezaT4OzN+wk+72ssnwIoo3Wk8zOpw2MBZio4LB3ieh8AFACYZKhk9gq0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764194191; c=relaxed/simple; bh=LgHk61xe55fJJxUBDrmTC4BmteIRUDhdYfYBROiGhhQ=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=oRxIYe23F26soYqMJGZHljKV2dfwUW9Ovnp75BKe2Pv0WGeYDd3Cvnu7sXk/vXCHggc/HkwZmj7jxiN56mDF+NCeb6pgR56+rma/UFza5aGiWYWnGO5wDmaScc85aZeoINFvq5vaku8LJ7g1M0+p4uomeuAPxUjxZA+rwYz7Ojg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com; spf=pass smtp.mailfrom=analog.com; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b=CZmBPXac; arc=none smtp.client-ip=148.163.135.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=analog.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b="CZmBPXac" Received: from pps.filterd (m0167088.ppops.net [127.0.0.1]) by mx0a-00128a01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AQHck1u3402619; Wed, 26 Nov 2025 16:56:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=DKIM; bh=Ycdb7 CnbScFsGuAoIASyU7Rt62Ua/O31gENRYBBojMg=; b=CZmBPXacl8zSXLubtqARh RPEqTc0Tu+b6OfY13QJCExQ0afpVVPqTkvgQTExN8m8HaBiOm0erdeOjqBXc0JHE 12lB3ZkN/YaeQcqxbuKK75DXXza2E4KcxNDauRf22ShHZw3zuzr9Jk2O8y4oD6Ze 1Up3Mx7WUSGQgbvVZSO4dPc9FQeoQipQJb0hdMmD0t9EJq5aJRrrHSWmjYdnH/GA jv3tpW64ERdwNVmptoz6xKR6D13QHTMR5xv4DzNspXqQiie90CAhpbYM0rjeoGS6 EcLR2VYN6KGefKxoenG8tL4AIn1u07klVVWNwzwpSdVqd2BqXNMzy4I3BVNJpUxD w== Received: from nwd2mta3.analog.com ([137.71.173.56]) by mx0a-00128a01.pphosted.com (PPS) with ESMTPS id 4anmrux8y9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 26 Nov 2025 16:56:26 -0500 (EST) Received: from ASHBMBX9.ad.analog.com (ASHBMBX9.ad.analog.com [10.64.17.10]) by nwd2mta3.analog.com (8.14.7/8.14.7) with ESMTP id 5AQLuPEH024341 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 26 Nov 2025 16:56:25 -0500 Received: from ASHBCASHYB4.ad.analog.com (10.64.17.132) by ASHBMBX9.ad.analog.com (10.64.17.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.37; Wed, 26 Nov 2025 16:56:25 -0500 Received: from ASHBMBX9.ad.analog.com (10.64.17.10) by ASHBCASHYB4.ad.analog.com (10.64.17.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.37; Wed, 26 Nov 2025 16:56:24 -0500 Received: from zeus.spd.analog.com (10.66.68.11) by ashbmbx9.ad.analog.com (10.64.17.10) with Microsoft SMTP Server id 15.2.1748.37 via Frontend Transport; Wed, 26 Nov 2025 16:56:24 -0500 Received: from JSANTO12-L01.ad.analog.com ([10.65.60.206]) by zeus.spd.analog.com (8.15.1/8.15.1) with ESMTP id 5AQLuDBa002847; Wed, 26 Nov 2025 16:56:16 -0500 From: Jonathan Santos To: , , CC: Jonathan Santos , , , , , , , , , , Subject: [PATCH v4 2/4] iio: adc: ad7768-1: introduce chip info for future multidevice support Date: Wed, 26 Nov 2025 18:56:13 -0300 Message-ID: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ADIRuleOP-NewSCL: Rule Triggered X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTI2MDE3OCBTYWx0ZWRfX2+Jn0/cAKU3a ckhgrhSpMtjVqmqrnviwBkPszFT+9YY3DFMhodTi6Q2+52LLB314hoYYBlRyYbp76MqmQE7djaW tRffDmFlpmrkIYHu5dLDKHfx1pmGLGLaudXVpVd7dtHlHEiWyMoGtqFih87JTnYOWKb4mn98AOR WFKHe6CGFMxKGQ4TP+ygakT8WxOkDYSE2nu4XEsYeuyCeYJ1adzKebxBiELrB9/barsCvXuQxzN 4P3SveuaXN4MzRzdJCv8VdtyRblov9UzQrGrxPY0u2LFtROkWz5Zm2aWnkBDZ4Ew/2RqEpq8hyU TaPeJq3IL5hvu5VEy8F8XfObKnEeGk8o8bqT5LsWGBLezxRWYAIJwuKIuPy9h1SJx1a8824greg 5GuBVHqIRpSoAm9GLEi99WAiBBNMvg== X-Proofpoint-GUID: i2cVzmOJRyoS5KhzcTEsHTTjLF6uOmvh X-Authority-Analysis: v=2.4 cv=Qehrf8bv c=1 sm=1 tr=0 ts=6927778a cx=c_pps a=PpDZqlmH/M8setHirZLBMw==:117 a=PpDZqlmH/M8setHirZLBMw==:17 a=6UeiqGixMTsA:10 a=VkNPw1HP01LnGYTKEx00:22 a=gAnH3GRIAAAA:8 a=52dTr-yYBLopz0kQKhgA:9 X-Proofpoint-ORIG-GUID: i2cVzmOJRyoS5KhzcTEsHTTjLF6uOmvh X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-25_02,2025-11-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 suspectscore=0 bulkscore=0 spamscore=0 phishscore=0 lowpriorityscore=0 clxscore=1015 malwarescore=0 adultscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511260178 Content-Type: text/plain; charset="utf-8" Add Chip info struct in SPI device to store channel information for each supported part. Signed-off-by: Jonathan Santos --- v4 Changes: * Dropped chip info check and moved the st->chip assignment early in the probe function. * Addressed indentation inconsistencies in AD7768_CHAN macro. v3 Changes: * ad7768_channel_masks removed along with available_masks element in ad7768_chip_info struct. It does not add anything for single channels, so not needed, at least for now. * fixed inconsistency in spaces before \ in AD7768_CHAN macro. v2 Changes: * removed AD7768_CHAN_INFO_NONE macro. * reordered fields in ad7768_chip_info struct. * removed trailing comma. --- drivers/iio/adc/ad7768-1.c | 64 ++++++++++++++++++++++++-------------- 1 file changed, 41 insertions(+), 23 deletions(-) diff --git a/drivers/iio/adc/ad7768-1.c b/drivers/iio/adc/ad7768-1.c index d96802b7847a..89b0ca8f584c 100644 --- a/drivers/iio/adc/ad7768-1.c +++ b/drivers/iio/adc/ad7768-1.c @@ -213,6 +213,12 @@ static const struct iio_scan_type ad7768_scan_type[] = =3D { }, }; =20 +struct ad7768_chip_info { + const char *name; + const struct iio_chan_spec *channel_spec; + int num_channels; +}; + struct ad7768_state { struct spi_device *spi; struct regmap *regmap; @@ -234,6 +240,7 @@ struct ad7768_state { struct gpio_desc *gpio_reset; const char *labels[AD7768_MAX_CHANNELS]; struct gpio_chip gpiochip; + const struct ad7768_chip_info *chip; bool en_spi_sync; /* * DMA (thus cache coherency maintenance) may require the @@ -748,24 +755,28 @@ static const struct iio_chan_spec_ext_info ad7768_ext= _info[] =3D { { } }; =20 +#define AD7768_CHAN(_idx, _msk_avail) \ +{ \ + .type =3D IIO_VOLTAGE, \ + .info_mask_separate_available =3D _msk_avail, \ + .info_mask_separate =3D BIT(IIO_CHAN_INFO_RAW), \ + .info_mask_shared_by_type =3D BIT(IIO_CHAN_INFO_SCALE) | \ + BIT(IIO_CHAN_INFO_LOW_PASS_FILTER_3DB_FREQUENCY) | \ + BIT(IIO_CHAN_INFO_OVERSAMPLING_RATIO), \ + .info_mask_shared_by_type_available =3D BIT(IIO_CHAN_INFO_OVERSAMPLING_RA= TIO), \ + .info_mask_shared_by_all =3D BIT(IIO_CHAN_INFO_SAMP_FREQ), \ + .info_mask_shared_by_all_available =3D BIT(IIO_CHAN_INFO_SAMP_FREQ), \ + .ext_info =3D ad7768_ext_info, \ + .indexed =3D 1, \ + .channel =3D _idx, \ + .scan_index =3D _idx, \ + .has_ext_scan_type =3D 1, \ + .ext_scan_type =3D ad7768_scan_type, \ + .num_ext_scan_type =3D ARRAY_SIZE(ad7768_scan_type), \ +} + static const struct iio_chan_spec ad7768_channels[] =3D { - { - .type =3D IIO_VOLTAGE, - .info_mask_separate =3D BIT(IIO_CHAN_INFO_RAW), - .info_mask_shared_by_type =3D BIT(IIO_CHAN_INFO_SCALE) | - BIT(IIO_CHAN_INFO_LOW_PASS_FILTER_3DB_FREQUENCY) | - BIT(IIO_CHAN_INFO_OVERSAMPLING_RATIO), - .info_mask_shared_by_type_available =3D BIT(IIO_CHAN_INFO_OVERSAMPLING_R= ATIO), - .info_mask_shared_by_all =3D BIT(IIO_CHAN_INFO_SAMP_FREQ), - .info_mask_shared_by_all_available =3D BIT(IIO_CHAN_INFO_SAMP_FREQ), - .ext_info =3D ad7768_ext_info, - .indexed =3D 1, - .channel =3D 0, - .scan_index =3D 0, - .has_ext_scan_type =3D 1, - .ext_scan_type =3D ad7768_scan_type, - .num_ext_scan_type =3D ARRAY_SIZE(ad7768_scan_type), - }, + AD7768_CHAN(0, 0), }; =20 static int ad7768_read_raw(struct iio_dev *indio_dev, @@ -1321,6 +1332,12 @@ static int ad7768_register_regulators(struct device = *dev, struct ad7768_state *s return 0; } =20 +static const struct ad7768_chip_info ad7768_chip_info =3D { + .name =3D "ad7768-1", + .channel_spec =3D ad7768_channels, + .num_channels =3D ARRAY_SIZE(ad7768_channels), +}; + static int ad7768_probe(struct spi_device *spi) { struct ad7768_state *st; @@ -1347,6 +1364,7 @@ static int ad7768_probe(struct spi_device *spi) return ret; } =20 + st->chip =3D spi_get_device_match_data(spi); st->spi =3D spi; =20 st->regmap =3D devm_regmap_init_spi(spi, &ad7768_regmap_config); @@ -1371,9 +1389,9 @@ static int ad7768_probe(struct spi_device *spi) =20 st->mclk_freq =3D clk_get_rate(st->mclk); =20 - indio_dev->channels =3D ad7768_channels; - indio_dev->num_channels =3D ARRAY_SIZE(ad7768_channels); - indio_dev->name =3D spi_get_device_id(spi)->name; + indio_dev->channels =3D st->chip->channel_spec; + indio_dev->num_channels =3D st->chip->num_channels; + indio_dev->name =3D st->chip->name; indio_dev->info =3D &ad7768_info; indio_dev->modes =3D INDIO_DIRECT_MODE; =20 @@ -1390,7 +1408,7 @@ static int ad7768_probe(struct spi_device *spi) =20 init_completion(&st->completion); =20 - ret =3D ad7768_set_channel_label(indio_dev, ARRAY_SIZE(ad7768_channels)); + ret =3D ad7768_set_channel_label(indio_dev, st->chip->num_channels); if (ret) return ret; =20 @@ -1409,13 +1427,13 @@ static int ad7768_probe(struct spi_device *spi) } =20 static const struct spi_device_id ad7768_id_table[] =3D { - { "ad7768-1", 0 }, + { "ad7768-1", (kernel_ulong_t)&ad7768_chip_info }, { } }; MODULE_DEVICE_TABLE(spi, ad7768_id_table); =20 static const struct of_device_id ad7768_of_match[] =3D { - { .compatible =3D "adi,ad7768-1" }, + { .compatible =3D "adi,ad7768-1", .data =3D &ad7768_chip_info }, { } }; MODULE_DEVICE_TABLE(of, ad7768_of_match); --=20 2.34.1 From nobody Mon Dec 1 22:41:53 2025 Received: from mx0a-00128a01.pphosted.com (mx0a-00128a01.pphosted.com [148.163.135.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 074C82DC35C; Wed, 26 Nov 2025 21:56:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.135.77 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764194206; cv=none; b=ju6KkWCUtlyTtHtVVWZ/5PEnDBKiJDp+sSGABF2WGnzdsNmC909Ms7zeBlz+2nEMMov8/TMK8K8Kc69xcriWTO59q6w4pVKdJluTvy9L52NcLQtdI0ZcKDnvoe1DN6FNy1gSeOU3w8RyQ+/SHax1oxkuRS4QVJV7kVFbrNyqCnM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764194206; c=relaxed/simple; bh=M4o3rABPwo7lVmOo4euWmfYyRQ9h+u244KQf14Az/fo=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=A6SDaWNFrS5B5u47mcLs5AkNmLYZyFhLeNbesAWhto4ysVYhbNeQoS6oqZs0sF+vp9dN4wrkgfMaYfcg2xVnWTQ0tAbG1Sr+o1YuJbL2+adzXYnSsF3DzoBuQgM0gwmo2elR4JdFZLyKa2YoU/sZBoWhL70ODn75hNMe9zw14G0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com; spf=pass smtp.mailfrom=analog.com; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b=VaWK5QZM; arc=none smtp.client-ip=148.163.135.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=analog.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b="VaWK5QZM" Received: from pps.filterd (m0167088.ppops.net [127.0.0.1]) by mx0a-00128a01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AQHC4FZ3402606; Wed, 26 Nov 2025 16:56:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=DKIM; bh=/jxtx 6QHkTMhkQw0AVUzT3lIVz9+rAPih16QE6v9WZs=; b=VaWK5QZMIFWeC9bUeJ03e ApaHl/3HX94nch0173rZrV7MjMQcj7Jbj0yMaLW3V9TZy7+tYROdiyDeB+nBYX45 yTg6w3Xgm+uWVUMssGy+kUObbUsi4XmA8no+4HBn732BPkzsD9wde4TxWg5qe0Pv 8i++LXn2cweBufKcWB4Qa+ejpbpPIG8tf0nipgIwQdP11ZfTgdBShz8BIMbdmdHF Y3vMiPXgtUbFUWvf44EXSqGgXXNxYSNjz/MCnILmOqoZN4CrlwTx6B6J2RGg6aYn DojKzdmZxmtHmyCreuaAtqVhy+23akX1EO83MEAIWA5wZrzrksVAUsJaU6k68nA3 A== Received: from nwd2mta4.analog.com ([137.71.173.58]) by mx0a-00128a01.pphosted.com (PPS) with ESMTPS id 4anmrux8yv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 26 Nov 2025 16:56:41 -0500 (EST) Received: from ASHBMBX8.ad.analog.com (ASHBMBX8.ad.analog.com [10.64.17.5]) by nwd2mta4.analog.com (8.14.7/8.14.7) with ESMTP id 5AQLue5P035516 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 26 Nov 2025 16:56:40 -0500 Received: from ASHBMBX9.ad.analog.com (10.64.17.10) by ASHBMBX8.ad.analog.com (10.64.17.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.37; Wed, 26 Nov 2025 16:56:40 -0500 Received: from zeus.spd.analog.com (10.66.68.11) by ashbmbx9.ad.analog.com (10.64.17.10) with Microsoft SMTP Server id 15.2.1748.37 via Frontend Transport; Wed, 26 Nov 2025 16:56:40 -0500 Received: from JSANTO12-L01.ad.analog.com ([10.65.60.206]) by zeus.spd.analog.com (8.15.1/8.15.1) with ESMTP id 5AQLuQCU002852; Wed, 26 Nov 2025 16:56:29 -0500 From: Jonathan Santos To: , , CC: Jonathan Santos , , , , , , , , , , Subject: [PATCH v4 3/4] units: add BASIS_POINTS macro Date: Wed, 26 Nov 2025 18:56:26 -0300 Message-ID: <6dafbe2577ba5fab28a84daf55111d9ede4a1938.1764101647.git.Jonathan.Santos@analog.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ADIRuleOP-NewSCL: Rule Triggered X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTI2MDE3OCBTYWx0ZWRfX7fMkSCN7xl3j PTWjodxym0a0PQnct9ZCyKODTEJ59jqwWMpSPwysTqmB/JsrgXy4M1UjVzZc/rVWbgfg540bAJS Q1++OW2ZxQBoI7iNsXm/Rleev9Rsjygr61kATT9j/ET26LAsUsKObSqR76q+mcwkCi42XiVA9Bm W39uS0NIZE/VTSisNbUc4I6loeR3qyM5Z4BANLpd9OMT8J+BpDE324ScadhsLL+nwEfAPPTvKCG ubH/LP/0U1KcSA8oNh0SaigGn4nktgro43Oinsrw1u3fyUmoOdavi77Th7HruBXENE2pVzLRZ5m T/oHB8HpQLUIf7wtP2oxf7BfB05wWe/A3gQ7r2P4bIndwQOqJVEDFR+x30usEsQKv2d/EtCtN8v d7mIoDS4e5qX8rf/0ftDjw9ERXPahQ== X-Proofpoint-GUID: IcvvVsHZkg55UxOC3AIJZsFKEgEkvsvL X-Authority-Analysis: v=2.4 cv=Qehrf8bv c=1 sm=1 tr=0 ts=69277799 cx=c_pps a=3WNzaoukacrqR9RwcOSAdA==:117 a=3WNzaoukacrqR9RwcOSAdA==:17 a=6UeiqGixMTsA:10 a=VkNPw1HP01LnGYTKEx00:22 a=gAnH3GRIAAAA:8 a=vl7k06Wm16_bTdnxtH8A:9 X-Proofpoint-ORIG-GUID: IcvvVsHZkg55UxOC3AIJZsFKEgEkvsvL X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-25_02,2025-11-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 suspectscore=0 bulkscore=0 spamscore=0 phishscore=0 lowpriorityscore=0 clxscore=1015 malwarescore=0 adultscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511260178 Content-Type: text/plain; charset="utf-8" Add macro for basis points unit, defined as a 1/100th of a percent. Signed-off-by: Jonathan Santos --- v4 Changes: * New patch. --- include/linux/units.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/linux/units.h b/include/linux/units.h index 00e15de33eca..da2c24fe5ee7 100644 --- a/include/linux/units.h +++ b/include/linux/units.h @@ -21,6 +21,8 @@ #define PICO 1000000000000ULL #define FEMTO 1000000000000000ULL =20 +#define BASIS_POINTS 10000UL + #define NANOHZ_PER_HZ 1000000000UL #define MICROHZ_PER_HZ 1000000UL #define MILLIHZ_PER_HZ 1000UL --=20 2.34.1 From nobody Mon Dec 1 22:41:53 2025 Received: from mx0a-00128a01.pphosted.com (mx0a-00128a01.pphosted.com [148.163.135.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 48AC6340A4A; Wed, 26 Nov 2025 21:56:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.135.77 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764194215; cv=none; b=EO3PLT2gPhS/i+LXzTwwVMKmv16WfeFcKPlFViGNKNMdBCSmb9jzh7Y07V4nL82xGbeF0htNnJc5ozKMkvkka2MXCnn1T8i46EN8THwWLRqkHMvE9ZfBCbLMK8jBXbFZzWiDI+5Me16EocPXlMu6xAcBnaLK0G+7b3dq9YpFluU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764194215; c=relaxed/simple; bh=2t+KqlfvYxSZoakPGhfW5wxtwr+6IUJPbn8JN14JM4I=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Dcqj/pL8TSdpBIe4sNsZXXN6T7JlGbeAKAeXjOWGhX+UnBjh5tkTMJphxttY4Pq1KSFprMocHFfLtLdxAiL+gfYyI52U8efzzTYSSE545DlcAPQC/syHuIJXe9SvIeAR+60CUV81z0iFDwxJHHWgD83EOSiKKoUqrprFr2rMwJY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com; spf=pass smtp.mailfrom=analog.com; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b=EoPUEni/; arc=none smtp.client-ip=148.163.135.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=analog.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b="EoPUEni/" Received: from pps.filterd (m0167088.ppops.net [127.0.0.1]) by mx0a-00128a01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AQHC4Fa3402606; Wed, 26 Nov 2025 16:56:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=DKIM; bh=Y/i1e p17e2L97yK3LhRAyMc8k3tL4ZTKda49GY3Irj4=; b=EoPUEni/R7y9SomwW9G/k 4/yHum8F7mNyCpTFXcqq8yYY6Y6c7rYTtNklkm17c+5AscVo0IJUWR838qCz1lUp vRYD4YX20EhV9ww992FfbX+6KvaVjEg6llGsV3MUuHhQqRloMf8hk9j8Q0Y1Ppe1 hpSZ+qC05OVti2orB8Y4K5crH+YzdzGAYwlGkQNtwnWJ7j1Glwbu6ALilqpM59tT wpYwhuDV6fp/0IN3KjwWsguu1J9UGxplQeqg/ippQdriJBYyKLnmPMW8VQEzfcKA GkUzJIa4uepqWK4T/zJdrAAs3j9WCR8BHArFy4CXQySvX/xjIgpAAbiwRvbBF/+B w== Received: from nwd2mta4.analog.com ([137.71.173.58]) by mx0a-00128a01.pphosted.com (PPS) with ESMTPS id 4anmrux903-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 26 Nov 2025 16:56:48 -0500 (EST) Received: from ASHBMBX8.ad.analog.com (ASHBMBX8.ad.analog.com [10.64.17.5]) by nwd2mta4.analog.com (8.14.7/8.14.7) with ESMTP id 5AQLulpU035527 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 26 Nov 2025 16:56:47 -0500 Received: from ASHBMBX9.ad.analog.com (10.64.17.10) by ASHBMBX8.ad.analog.com (10.64.17.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.37; Wed, 26 Nov 2025 16:56:47 -0500 Received: from zeus.spd.analog.com (10.66.68.11) by ashbmbx9.ad.analog.com (10.64.17.10) with Microsoft SMTP Server id 15.2.1748.37 via Frontend Transport; Wed, 26 Nov 2025 16:56:47 -0500 Received: from JSANTO12-L01.ad.analog.com ([10.65.60.206]) by zeus.spd.analog.com (8.15.1/8.15.1) with ESMTP id 5AQLua2p003019; Wed, 26 Nov 2025 16:56:38 -0500 From: Jonathan Santos To: , , CC: Jonathan Santos , , , , , , , , , , Subject: [PATCH v4 4/4] iio: adc: ad7768-1: add support for ADAQ776x-1 ADC Family Date: Wed, 26 Nov 2025 18:56:35 -0300 Message-ID: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ADIRuleOP-NewSCL: Rule Triggered X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTI2MDE3OCBTYWx0ZWRfX7sd72xRmjiWU k1/iUfsu0Wv0ZiNAGwlQ+idQcvZS7wJTi+6Co/7DbwwkTgBVT981SX2C2hfw3OiwJNvhAlResb1 lHRogk6E0YOizSFaoDlWV1+Udio32I314Sx0O88pfKUuIUGdjleX0yct4JhH7bV+Y3kYu8JyagX rOtOrUtXdUxhDL6S59jZCE68HZ4vwhZwT561XeG+dRmQuwrDuuHnlqefgCbfHZr26mFrqHpWGab H4Iv22SUvZgNIdMjuhhc3S89ZLjlJswIQ8yZ8dzfK22vje1JeJIk5Vu0vDHs8XbiAlcBR4530IE myTl5oUemvzx/IbZjDT5yeHztQl199X3/qqaO0u6GsRoRAQDiPTHHjghM8IPQ3/qGfCLTSvYFvF bXxQCeiWYXlYX2LokoHRiKrrFpkeEQ== X-Proofpoint-GUID: 9XfTZIktGiHSH2TTUgTdxheJfKK2V8tY X-Authority-Analysis: v=2.4 cv=Qehrf8bv c=1 sm=1 tr=0 ts=692777a0 cx=c_pps a=3WNzaoukacrqR9RwcOSAdA==:117 a=3WNzaoukacrqR9RwcOSAdA==:17 a=6UeiqGixMTsA:10 a=VkNPw1HP01LnGYTKEx00:22 a=gAnH3GRIAAAA:8 a=j908aWQ6n9cnJO2kZlgA:9 X-Proofpoint-ORIG-GUID: 9XfTZIktGiHSH2TTUgTdxheJfKK2V8tY X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-25_02,2025-11-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 suspectscore=0 bulkscore=0 spamscore=0 phishscore=0 lowpriorityscore=0 clxscore=1015 malwarescore=0 adultscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511260178 Content-Type: text/plain; charset="utf-8" Add support for ADAQ7767/68/69-1 series, which includes PGIA and Anti-aliasing filter (AAF) gains. Unlike the AD7768-1, they do not provide a VCM regulator interface. The PGA gain is configured in run-time through the scale attribute, if supported by the device. PGA is controlled by GPIOs provided in the device tree. The AAF gain is defined by hardware connections and should be specified in the device tree. Signed-off-by: Jonathan Santos --- v4 Changes: * replaced shift_right() with '>>' operator in the ad7768_fill_scale_tbl() function. * Refactored ad7768_parse_aaf_gain () as requested. * renamed ad7768_register_regulators() to ad7768_register_vcm_regulator() to better reflect its purpose (not sure if this is ok to do). * Replaced u64_fract with u32_fract -> after reviewing the numbers again, I realized that u32_fract is sufficient for these calculations. * addressed minor suggestions. * Adopted a new approach to manage the PGA GPIOs, using pga-gpios property. This avoids possible conflicts when the internal gpio controller is used externally (and also allows hardwiring, as soon as the gpio interface=20 supports it). However, using GPIOs from the device's own controller causes a deadlock when claiming direct mode in the ad7768_gpio_get() function. This happens because the direct mode remains locked by the ad7768_write_r= aw() function. I have kept this approach for now to discuss a way around this problem. It would be good to have the flexibility provided by pga-gpios=20 property. v3 Changes: * Fixed trailing comma issues. * Addressed other minor issues related to dead code, variable declaration, etc. * removed unnecessary comments and relocating some local variables. * replaced mutex_init() with devm_mutex_init(). * adopted different variables for the input and output of=20 rational_best_approximation(). Also used a u64_fract for the inputs, but=20 kept the unsigned long for the outputs, because could not create a unsign= ed long fraction number type. * ad7768_set_pga_gain(): removed the pgia enable check, relying on the regmap cache. * Moved aaf gain parsing to its own function, and now returning after warning to avoid setting a variable when it shouldn't (avoid confusion). * AAF gain is now in basis point units, so related multipliers and dividers are adjusted accordingly. v2 Changes: * Added more details to the commit message. * Some devices does not provide VCM regulator, so a new field in the chip info struct was added to indicate this. * Added 'select RATIONAL' to Kconfig. Kernel test robot pointed out compilation error due to undefined reference to=20 rational_best_approximation(). * Added lock to protect PGA value access. * precision in the PGA calculation is now dependent of the channel sign (signed or unsigned). * went back to the original scale computation: (st->vref_uv * 2) / 2^n instead of st->vref_uv / 2^(n-1). * rewrote AAF gain check and replaced error returns with warnings. I the AAF gain is not provided, a default value is used. * Addressed other minor suggestions. --- drivers/iio/adc/Kconfig | 1 + drivers/iio/adc/ad7768-1.c | 322 ++++++++++++++++++++++++++++++++++++- 2 files changed, 319 insertions(+), 4 deletions(-) diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig index 58da8255525e..396f6d45fd6d 100644 --- a/drivers/iio/adc/Kconfig +++ b/drivers/iio/adc/Kconfig @@ -387,6 +387,7 @@ config AD7768_1 depends on SPI select REGULATOR select REGMAP_SPI + select RATIONAL select IIO_BUFFER select IIO_TRIGGER select IIO_TRIGGERED_BUFFER diff --git a/drivers/iio/adc/ad7768-1.c b/drivers/iio/adc/ad7768-1.c index 89b0ca8f584c..40fb26ca3804 100644 --- a/drivers/iio/adc/ad7768-1.c +++ b/drivers/iio/adc/ad7768-1.c @@ -6,6 +6,7 @@ */ #include #include +#include #include #include #include @@ -14,8 +15,12 @@ #include #include #include +#include +#include #include #include +#include +#include #include #include #include @@ -107,10 +112,15 @@ =20 #define AD7768_VCM_OFF 0x07 =20 +#define ADAQ776X_GAIN_MAX_NANO (128 * NANO) +#define ADAQ776X_MAX_GAIN_MODES 8 + #define AD7768_TRIGGER_SOURCE_SYNC_IDX 0 =20 #define AD7768_MAX_CHANNELS 1 =20 +#define ADAQ7768_PGA_PINS 3 + enum ad7768_conv_mode { AD7768_CONTINUOUS, AD7768_ONE_SHOT, @@ -153,6 +163,51 @@ enum ad7768_scan_type { AD7768_SCAN_TYPE_HIGH_SPEED, }; =20 +enum { + AD7768_PGA_GAIN_0, + AD7768_PGA_GAIN_1, + AD7768_PGA_GAIN_2, + AD7768_PGA_GAIN_3, + AD7768_PGA_GAIN_4, + AD7768_PGA_GAIN_5, + AD7768_PGA_GAIN_6, + AD7768_PGA_GAIN_7, +}; + +enum { + AD7768_AAF_IN1, + AD7768_AAF_IN2, + AD7768_AAF_IN3, +}; + +/* PGA and AAF gains in V/V */ +static const int adaq7768_gains[] =3D { + [AD7768_PGA_GAIN_0] =3D 325, /* 0.325 */ + [AD7768_PGA_GAIN_1] =3D 650, /* 0.650 */ + [AD7768_PGA_GAIN_2] =3D 1300, /* 1.300 */ + [AD7768_PGA_GAIN_3] =3D 2600, /* 2.600 */ + [AD7768_PGA_GAIN_4] =3D 5200, /* 5.200 */ + [AD7768_PGA_GAIN_5] =3D 10400, /* 10.400 */ + [AD7768_PGA_GAIN_6] =3D 20800, /* 20.800 */ +}; + +static const int adaq7769_gains[] =3D { + [AD7768_PGA_GAIN_0] =3D 1000, /* 1.000 */ + [AD7768_PGA_GAIN_1] =3D 2000, /* 2.000 */ + [AD7768_PGA_GAIN_2] =3D 4000, /* 4.000 */ + [AD7768_PGA_GAIN_3] =3D 8000, /* 8.000 */ + [AD7768_PGA_GAIN_4] =3D 16000, /* 16.000 */ + [AD7768_PGA_GAIN_5] =3D 32000, /* 32.000 */ + [AD7768_PGA_GAIN_6] =3D 64000, /* 64.000 */ + [AD7768_PGA_GAIN_7] =3D 128000, /* 128.000 */ +}; + +static const int ad7768_aaf_gains_bp[] =3D { + [AD7768_AAF_IN1] =3D 10000, /* 1.000 */ + [AD7768_AAF_IN2] =3D 3640, /* 0.364 */ + [AD7768_AAF_IN3] =3D 1430, /* 0.143 */ +}; + /* -3dB cutoff frequency multipliers (relative to ODR) for each filter typ= e. */ static const int ad7768_filter_3db_odr_multiplier[] =3D { [AD7768_FILTER_SINC5] =3D 204, /* 0.204 */ @@ -217,6 +272,13 @@ struct ad7768_chip_info { const char *name; const struct iio_chan_spec *channel_spec; int num_channels; + const int *pga_gains; + int num_pga_modes; + int default_pga_mode; + int pgia_mode2pin_offset; + bool has_pga; + bool has_variable_aaf; + bool has_vcm_regulator; }; =20 struct ad7768_state { @@ -234,14 +296,19 @@ struct ad7768_state { unsigned int samp_freq; unsigned int samp_freq_avail[ARRAY_SIZE(ad7768_mclk_div_rates)]; unsigned int samp_freq_avail_len; + unsigned int pga_gain_mode; + unsigned int aaf_gain; + int scale_tbl[ADAQ776X_MAX_GAIN_MODES][2]; struct completion completion; struct iio_trigger *trig; + struct gpio_descs *pga_gpios; struct gpio_desc *gpio_sync_in; struct gpio_desc *gpio_reset; const char *labels[AD7768_MAX_CHANNELS]; struct gpio_chip gpiochip; const struct ad7768_chip_info *chip; bool en_spi_sync; + struct mutex pga_lock; /* protect device internal state (PGA) */ /* * DMA (thus cache coherency maintenance) may require the * transfer buffers to live in their own cache lines. @@ -464,6 +531,42 @@ static int ad7768_reg_access(struct iio_dev *indio_dev, return ret; } =20 +static void ad7768_fill_scale_tbl(struct iio_dev *dev) +{ + struct ad7768_state *st =3D iio_priv(dev); + const struct iio_scan_type *scan_type; + int val, val2, tmp0, tmp1, i; + struct u32_fract fract; + unsigned long n, d; + u64 tmp2; + + scan_type =3D iio_get_current_scan_type(dev, &dev->channels[0]); + if (scan_type->sign =3D=3D 's') + val2 =3D scan_type->realbits - 1; + else + val2 =3D scan_type->realbits; + + for (i =3D 0; i < st->chip->num_pga_modes; i++) { + /* Convert gain to a fraction format */ + fract.numerator =3D st->chip->pga_gains[i]; + fract.denominator =3D MILLI; + if (st->chip->has_variable_aaf) { + fract.numerator *=3D ad7768_aaf_gains_bp[st->aaf_gain]; + fract.denominator *=3D BASIS_POINTS; + } + + rational_best_approximation(fract.numerator, fract.denominator, + INT_MAX, INT_MAX, &n, &d); + + val =3D mult_frac(st->vref_uv, d, n); + /* Would multiply by NANO here, but value is already in milli */ + tmp2 =3D ((u64)val * MICRO) >> val2; + tmp0 =3D div_u64_rem(tmp2, NANO, &tmp1); + st->scale_tbl[i][0] =3D tmp0; /* Integer part */ + st->scale_tbl[i][1] =3D abs(tmp1); /* Fractional part */ + } +} + static int ad7768_set_sinc3_dec_rate(struct ad7768_state *st, unsigned int dec_rate) { @@ -565,12 +668,72 @@ static int ad7768_configure_dig_fil(struct iio_dev *d= ev, st->oversampling_ratio =3D ad7768_dec_rate_values[dec_rate_idx]; } =20 + /* Update scale table: scale values vary according to the precision */ + ad7768_fill_scale_tbl(dev); + ad7768_fill_samp_freq_tbl(st); =20 /* A sync-in pulse is required after every configuration change */ return ad7768_send_sync_pulse(st); } =20 +/* + * FIXME: Using GPIOs from the device's own controller causes the device + * to get stuck when claiming direct mode in the ad7768_gpio_get() functio= n. + * This happens because the direct mode remains locked by the + * ad7768_write_raw() function. + */ +static int ad7768_setup_pga(struct device *dev, struct ad7768_state *st) +{ + st->pga_gpios =3D devm_gpiod_get_array(dev, "pga", GPIOD_OUT_LOW); + if (IS_ERR(st->pga_gpios)) + return dev_err_probe(dev, PTR_ERR(st->pga_gpios), + "Failed to get PGA gpios.\n"); + + if (st->pga_gpios->ndescs !=3D ADAQ7768_PGA_PINS) + return dev_err_probe(dev, -EINVAL, + "Expected %d GPIOs for PGA control.\n", + ADAQ7768_PGA_PINS); + return 0; +} + +static int ad7768_calc_pga_gain(struct ad7768_state *st, int gain_int, + int gain_fract, int precision) +{ + u64 gain_nano; + u32 tmp; + + gain_nano =3D gain_int * NANO + gain_fract; + gain_nano =3D clamp(gain_nano, 0, ADAQ776X_GAIN_MAX_NANO); + tmp =3D DIV_ROUND_CLOSEST_ULL(gain_nano << precision, NANO); + gain_nano =3D DIV_ROUND_CLOSEST(st->vref_uv, tmp); + if (st->chip->has_variable_aaf) + gain_nano =3D DIV_ROUND_CLOSEST_ULL(gain_nano * BASIS_POINTS, + ad7768_aaf_gains_bp[st->aaf_gain]); + + return find_closest(gain_nano, st->chip->pga_gains, + (int)st->chip->num_pga_modes); +} + +static int ad7768_set_pga_gain(struct ad7768_state *st, + int gain_mode) +{ + int pgia_pins_value =3D abs(gain_mode - st->chip->pgia_mode2pin_offset); + DECLARE_BITMAP(bitmap, ADAQ7768_PGA_PINS) =3D { }; + int ret; + + guard(mutex)(&st->pga_lock); + + bitmap_write(bitmap, pgia_pins_value, 0, ADAQ7768_PGA_PINS); + ret =3D gpiod_multi_set_value_cansleep(st->pga_gpios, bitmap); + if (ret) + return ret; + + st->pga_gain_mode =3D gain_mode; + + return 0; +} + static int ad7768_gpio_direction_input(struct gpio_chip *chip, unsigned in= t offset) { struct iio_dev *indio_dev =3D gpiochip_get_data(chip); @@ -779,6 +942,10 @@ static const struct iio_chan_spec ad7768_channels[] = =3D { AD7768_CHAN(0, 0), }; =20 +static const struct iio_chan_spec adaq776x_channels[] =3D { + AD7768_CHAN(0, BIT(IIO_CHAN_INFO_SCALE)), +}; + static int ad7768_read_raw(struct iio_dev *indio_dev, struct iio_chan_spec const *chan, int *val, int *val2, long info) @@ -806,7 +973,19 @@ static int ad7768_read_raw(struct iio_dev *indio_dev, return IIO_VAL_INT; =20 case IIO_CHAN_INFO_SCALE: - *val =3D (st->vref_uv * 2) / 1000; + if (st->chip->has_pga) { + guard(mutex)(&st->pga_lock); + + *val =3D st->scale_tbl[st->pga_gain_mode][0]; + *val2 =3D st->scale_tbl[st->pga_gain_mode][1]; + return IIO_VAL_INT_PLUS_NANO; + } + + temp =3D (st->vref_uv * 2) / 1000; + if (st->chip->has_variable_aaf) + temp =3D (temp * BASIS_POINTS) / ad7768_aaf_gains_bp[st->aaf_gain]; + + *val =3D temp; *val2 =3D scan_type->realbits; =20 return IIO_VAL_FRACTIONAL_LOG2; @@ -862,18 +1041,39 @@ static int ad7768_read_avail(struct iio_dev *indio_d= ev, *length =3D st->samp_freq_avail_len; *type =3D IIO_VAL_INT; return IIO_AVAIL_LIST; + case IIO_CHAN_INFO_SCALE: + *vals =3D (int *)st->scale_tbl; + *length =3D st->chip->num_pga_modes * 2; + *type =3D IIO_VAL_INT_PLUS_NANO; + return IIO_AVAIL_LIST; default: return -EINVAL; } } =20 +static int ad7768_write_raw_get_fmt(struct iio_dev *indio_dev, + struct iio_chan_spec const *chan, long mask) +{ + switch (mask) { + case IIO_CHAN_INFO_SCALE: + return IIO_VAL_INT_PLUS_NANO; + default: + return IIO_VAL_INT_PLUS_MICRO; + } +} + static int __ad7768_write_raw(struct iio_dev *indio_dev, struct iio_chan_spec const *chan, int val, int val2, long info) { struct ad7768_state *st =3D iio_priv(indio_dev); + const struct iio_scan_type *scan_type; int ret; =20 + scan_type =3D iio_get_current_scan_type(indio_dev, chan); + if (IS_ERR(scan_type)) + return PTR_ERR(scan_type); + switch (info) { case IIO_CHAN_INFO_SAMP_FREQ: return ad7768_set_freq(st, val); @@ -885,6 +1085,21 @@ static int __ad7768_write_raw(struct iio_dev *indio_d= ev, =20 /* Update sampling frequency */ return ad7768_set_freq(st, st->samp_freq); + case IIO_CHAN_INFO_SCALE: { + int gain_mode; + + if (!st->chip->has_pga) + return -EOPNOTSUPP; + + if (scan_type->sign =3D=3D 's') + gain_mode =3D ad7768_calc_pga_gain(st, val, val2, + scan_type->realbits - 1); + else + gain_mode =3D ad7768_calc_pga_gain(st, val, val2, + scan_type->realbits); + + return ad7768_set_pga_gain(st, gain_mode); + } default: return -EINVAL; } @@ -926,6 +1141,7 @@ static const struct iio_info ad7768_info =3D { .read_raw =3D &ad7768_read_raw, .read_avail =3D &ad7768_read_avail, .write_raw =3D &ad7768_write_raw, + .write_raw_get_fmt =3D &ad7768_write_raw_get_fmt, .read_label =3D ad7768_read_label, .get_current_scan_type =3D &ad7768_get_current_scan_type, .debugfs_reg_access =3D &ad7768_reg_access, @@ -1309,8 +1525,9 @@ static const struct regulator_desc vcm_desc =3D { .owner =3D THIS_MODULE, }; =20 -static int ad7768_register_regulators(struct device *dev, struct ad7768_st= ate *st, - struct iio_dev *indio_dev) +static int ad7768_register_vcm_regulator(struct device *dev, + struct ad7768_state *st, + struct iio_dev *indio_dev) { struct regulator_config config =3D { .dev =3D dev, @@ -1332,10 +1549,82 @@ static int ad7768_register_regulators(struct device= *dev, struct ad7768_state *s return 0; } =20 +static int ad7768_parse_aaf_gain(struct device *dev, struct ad7768_state *= st) +{ + bool aaf_gain_provided; + u32 val; + int ret; + + ret =3D device_property_read_u32(dev, "adi,aaf-gain-bp", &val); + if (ret =3D=3D -EINVAL) + aaf_gain_provided =3D false; + else if (ret) + return dev_err_probe(dev, ret, "Failed to get AAF gain value\n"); + else + aaf_gain_provided =3D true; + + if (!aaf_gain_provided) { + if (st->chip->has_variable_aaf) + st->aaf_gain =3D AD7768_AAF_IN1; + return 0; + } + + if (aaf_gain_provided && !st->chip->has_variable_aaf) + return dev_err_probe(dev, -EOPNOTSUPP, + "AAF gain not supported for %s\n", st->chip->name); + + switch (val) { + case 10000: + st->aaf_gain =3D AD7768_AAF_IN1; + break; + case 3640: + st->aaf_gain =3D AD7768_AAF_IN2; + break; + case 1430: + st->aaf_gain =3D AD7768_AAF_IN3; + break; + default: + return dev_err_probe(dev, -EINVAL, "Invalid firmware provided AAF gain\n= "); + } + + return 0; +} + static const struct ad7768_chip_info ad7768_chip_info =3D { .name =3D "ad7768-1", .channel_spec =3D ad7768_channels, .num_channels =3D ARRAY_SIZE(ad7768_channels), + .has_vcm_regulator =3D true, +}; + +static const struct ad7768_chip_info adaq7767_chip_info =3D { + .name =3D "adaq7767-1", + .channel_spec =3D ad7768_channels, + .num_channels =3D ARRAY_SIZE(ad7768_channels), + .has_variable_aaf =3D true, +}; + +static const struct ad7768_chip_info adaq7768_chip_info =3D { + .name =3D "adaq7768-1", + .channel_spec =3D adaq776x_channels, + .num_channels =3D ARRAY_SIZE(adaq776x_channels), + .pga_gains =3D adaq7768_gains, + .default_pga_mode =3D AD7768_PGA_GAIN_2, + .num_pga_modes =3D ARRAY_SIZE(adaq7768_gains), + .pgia_mode2pin_offset =3D 6, + .has_pga =3D true, +}; + +static const struct ad7768_chip_info adaq7769_chip_info =3D { + .name =3D "adaq7769-1", + .channel_spec =3D adaq776x_channels, + .num_channels =3D ARRAY_SIZE(adaq776x_channels), + .pga_gains =3D adaq7769_gains, + .default_pga_mode =3D AD7768_PGA_GAIN_0, + .num_pga_modes =3D ARRAY_SIZE(adaq7769_gains), + .pgia_mode2pin_offset =3D 0, + .has_pga =3D true, + .has_variable_aaf =3D true, }; =20 static int ad7768_probe(struct spi_device *spi) @@ -1396,7 +1685,13 @@ static int ad7768_probe(struct spi_device *spi) indio_dev->modes =3D INDIO_DIRECT_MODE; =20 /* Register VCM output regulator */ - ret =3D ad7768_register_regulators(&spi->dev, st, indio_dev); + if (st->chip->has_vcm_regulator) { + ret =3D ad7768_register_vcm_regulator(&spi->dev, st, indio_dev); + if (ret) + return ret; + } + + ret =3D ad7768_parse_aaf_gain(&spi->dev, st); if (ret) return ret; =20 @@ -1407,6 +1702,19 @@ static int ad7768_probe(struct spi_device *spi) } =20 init_completion(&st->completion); + ret =3D devm_mutex_init(&spi->dev, &st->pga_lock); + if (ret) + return ret; + + if (st->chip->has_pga) { + ret =3D ad7768_setup_pga(&spi->dev, st); + if (ret) + return ret; + + ret =3D ad7768_set_pga_gain(st, st->chip->default_pga_mode); + if (ret) + return ret; + } =20 ret =3D ad7768_set_channel_label(indio_dev, st->chip->num_channels); if (ret) @@ -1428,12 +1736,18 @@ static int ad7768_probe(struct spi_device *spi) =20 static const struct spi_device_id ad7768_id_table[] =3D { { "ad7768-1", (kernel_ulong_t)&ad7768_chip_info }, + { "adaq7767-1", (kernel_ulong_t)&adaq7767_chip_info }, + { "adaq7768-1", (kernel_ulong_t)&adaq7768_chip_info }, + { "adaq7769-1", (kernel_ulong_t)&adaq7769_chip_info }, { } }; MODULE_DEVICE_TABLE(spi, ad7768_id_table); =20 static const struct of_device_id ad7768_of_match[] =3D { { .compatible =3D "adi,ad7768-1", .data =3D &ad7768_chip_info }, + { .compatible =3D "adi,adaq7767-1", .data =3D &adaq7767_chip_info }, + { .compatible =3D "adi,adaq7768-1", .data =3D &adaq7768_chip_info }, + { .compatible =3D "adi,adaq7769-1", .data =3D &adaq7769_chip_info }, { } }; MODULE_DEVICE_TABLE(of, ad7768_of_match); --=20 2.34.1