From nobody Tue Dec 2 01:22:04 2025 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 587801A23B9 for ; Sun, 23 Nov 2025 03:04:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763867095; cv=none; b=NjJ07yTRI1EHRSFAoocfhrOLhDB+exeqGcLDfhBAPl2dZKXy30fStbpZ1F+KxUzt3wDrHTSUY5iaUWeTkszkEHJjYUIfmwKHxht0XJktb5Bjq1NGQLNZyhWnZFzWJf+R++iRGv/nb/990Xe/AyRK7iFqrZ6+HrhN0TEtgXh1NmE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763867095; c=relaxed/simple; bh=bLc3zo8lOv8Ay6PwopPgrmq3v8jXaUZ/KWwhM80J2Z0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VMowez6PMFd5purAFFt4a6p6A88dYEoUMkSWDKE6Sta1Iyrt/SXqcrQN7kGXuWY5RFK410M50E5U3YoboKThDm/EIo0Kcn5f2u0Jggi3veMy5cKF53V1tIOMTzJh3L2FiyXAIhmrloDgCZ4l2GVLJ1KDoLFFi+7M1Mv8IszfKHE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=U8aIRr7k; arc=none smtp.client-ip=209.85.210.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="U8aIRr7k" Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-7baf61be569so3846602b3a.3 for ; Sat, 22 Nov 2025 19:04:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763867093; x=1764471893; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BYRW6azGDUXIo5YayTW1Mj1pqj1rOHvVGag+WenlXHw=; b=U8aIRr7k51bqLRU3ZvszPumTeGCNpBKS5wvEDuil5s5tTzimRKn6OiVbIWivXd+mz0 zXImo3q0IgBcFrdXjGs9j75VKA+zw5WaJJgnN+G3DOcymISXS97+LwNZhm2PMTZFxPs3 pK5qkNKhpboOFxyvkgfMaQ0Yopl2LIxae/S7HdPHOMJ3+YLQwy0F9KFPI0OQaoUOIv6s nV/IifyHEkQT/32OnGOBxTcgAeIubj6DNNHX/emyK4iOywBkOSm9W4RAMFL3BtVUFSnD TSEmEWugFUNoRufytyJUYv5BafCuDDkV6HIAFsUn4DoxhJwa9vq1BqEeBKOkUPV3Nv+g kFtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763867093; x=1764471893; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=BYRW6azGDUXIo5YayTW1Mj1pqj1rOHvVGag+WenlXHw=; b=GkoyywcFLoX5LN1ew7HwDCes10W16kut3I3cj/bEnPNY/OVrLE85O4gzWZwlDX2mF+ TWjVlWjuKq6N7jxxR0PK6rIi3KZh7Yd3DoNiM5lx40QBUnw7yGSaA/HeYi+BnY4mJAeU rbofPw4H/1RWYxdxkVHCzPWlPhqjFpbQRnTMB6HqNYWwd2ZrvH9J3NK7C4vVoIzgspTC vPKdTIMLf/o9tI0WqlOGqy3UFV4iJ14W9NFNa6O3t/Bf+z43jfAMR0IZmnfD1ZSZUwxR R/tMo/whG/D/ZfpON6DI4PqfjBm9KEjSjH/QaQryKlI0rR+erqmKoMBeVr0rdmnBWzlR /mKA== X-Forwarded-Encrypted: i=1; AJvYcCWJ1UtYYvGhhdBYEHJt1GuSFTPibh0jHKmPBSZ/ZJ5GJgSsToRiS5Tv6q0y0OlTVIVNTOSH3YJ1PtgHaFk=@vger.kernel.org X-Gm-Message-State: AOJu0YxN25ZVcmeFJ8jW5ufeKOjfhat+zHhdqT5vBYuO6eR1Cl9dOfLn d8f7jBjEhBzhGTWi+81Vh7q434mrwZsp2cT2iiIcYliOU3sMrz3L/D4J X-Gm-Gg: ASbGncvehccOFjIlCQOf6Fv7cZpkJbJKjXirB+QL2jnY8GPGnXxeXgWMmYit+1ZtX0p zNKMd/3Gvi3JbJUjfSOG56DuRoNFqUIY3hgmdYo5bUzmjTD0ZQ69PrE/4G50i0NHYLmEdAY3KwH Y4Nnl3udyDeiFgiSHtvEMCnlCNAUzdAtWUC9gSeh4rOQ3XvLQiU9Z6NkqSzW7N086gd1lWGjij0 fY1F4v+1rQTrsUIFG73A3qXTv+sesIg2IUFfdD39nMDYG+RTHlqYnOStfug6PZhnJDjorbovhRu VHajU/sUf1qOWfAMGJa+Hip6DPwl3Mnu4EquRRW2QFBVgrtUrmXjJe+RiPavZhn6WD7fA9bhucV qEb5BcxQqnVjY9jqSSfiRd93PNirnUb4cmC/E+Tkg1dqd7PL69IZn+VUYo4QepBnaQPyjU/zUhE t2UiU4YPJh+yyXcGtBpq8rv0MULA== X-Google-Smtp-Source: AGHT+IE3hfifAkpHaJSXvz6DlDk/mLRkqhCxAj7umlvwCUa6+K6oYf7ysiGZkzcmZ2Uu6UQHGGi2tw== X-Received: by 2002:a05:6a00:a245:b0:7a4:1880:e25e with SMTP id d2e1a72fcca58-7c58e9f97d4mr6680830b3a.30.1763867093517; Sat, 22 Nov 2025 19:04:53 -0800 (PST) Received: from chandna.localdomain ([106.222.235.50]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7c3f024adcfsm10386095b3a.31.2025.11.22.19.04.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 22 Nov 2025 19:04:53 -0800 (PST) From: Sahil Chandna To: akpm@linux-foundation.org, david@redhat.com, lorenzo.stoakes@oracle.com, mhocko@suse.com, vbabka@suse.cz, rppt@kernel.org, surenb@google.com, hannes@cmpxchg.org, shakeel.butt@linux.dev, zhengqi.arch@bytedance.com, Liam.Howlett@oracle.com, weixugc@google.com, axelrasmussen@google.com, yuanchu@google.com, yosry.ahmed@linux.dev, nphamcs@gmail.com, chengming.zhou@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Sahil Chandna , Matthew Wilcox , David Laight Subject: [PATCH v2 1/3] mm: pagewalk: simplify hugepage boundary calculation using min() Date: Sun, 23 Nov 2025 08:34:16 +0530 Message-ID: X-Mailer: git-send-email 2.50.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Use the kernel-provided min() macro to compute the minimum value instead of an explicit ternary expression. This improves readability and matches common kernel style. Also change the return hugepage boundary expression by using bitmask for better clarity. This was flagged by Coccinelle (misc/minmax.cocci) as an opportunity to use min(). Found by: make coccicheck MODE=3Dreport M=3Dmm/ No functional change intended. Suggested-by: Matthew Wilcox Suggested-by: David Laight Signed-off-by: Sahil Chandna --- changes since v1: - Updated boundary calculation of huge page range for better clarity. - No Functional changes intended. link to v1: https://lore.kernel.org/all/ff24b3c573b766b187b55a38497fbad0a31= 9b9f8.1763227530.git.chandna.sahil@gmail.com/ --- mm/pagewalk.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/mm/pagewalk.c b/mm/pagewalk.c index 9f91cf85a5be..1d38763a502a 100644 --- a/mm/pagewalk.c +++ b/mm/pagewalk.c @@ -312,8 +312,7 @@ static int walk_pgd_range(unsigned long addr, unsigned = long end, static unsigned long hugetlb_entry_end(struct hstate *h, unsigned long add= r, unsigned long end) { - unsigned long boundary =3D (addr & huge_page_mask(h)) + huge_page_size(h); - return boundary < end ? boundary : end; + return min((addr | ~huge_page_mask(h)) + 1, end); } =20 static int walk_hugetlb_range(unsigned long addr, unsigned long end, --=20 2.50.1 From nobody Tue Dec 2 01:22:04 2025 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 286E420297C for ; Sun, 23 Nov 2025 03:05:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763867102; cv=none; b=dY1o3fDi3+KYRgvsFrGz8q3mfyVPhkoXA5tR2TwfbMh6AymT/E8pVojO7PQpcmuCpqpR3JyPebn9vyT5/0YDyd/kVWavQNBn6KCxP+Pb0EXb1mORt7g662h3/wGbpW0s/K2BfDRZtFO9FE9kdZkHzN23lev8XYllnnRHFKWTfP4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763867102; c=relaxed/simple; bh=ERv3N8nf1js6gMRamzu9YNQ1wMS1KpP6ZgUoesAOA08=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Va+YIHTfq7keFzxz7B4Cp9OwfDgat4e5ed41JsxwQUYX7hJuks/Pj4FEUEprh0L5uBqDIgjpJh4ewJrGBQ2WHvWGAyGMm297e2Job0d/yteB8bzUiEGkrqlGv0dNFMVoIGpyhP0zMPujOx4NkD+w1oIBWR8HmDpYoXOYZN+gDOk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NURw17rM; arc=none smtp.client-ip=209.85.216.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NURw17rM" Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-3434700be69so4776090a91.1 for ; Sat, 22 Nov 2025 19:05:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763867100; x=1764471900; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bNgBXVliADaREJ6nkSovsbUQBYpNGNtzg4nO0JMTz5A=; b=NURw17rMiL4TAn10p5uj3IhaFNhdBlu1kTRD6jHNauPyH4TD6UsA4PeavcTvIJNYG0 9qQ1hIhw014jeiicVnCuhHjmJIkwterJ71oxkhQ9qIj9Rjfebf89QJBbjZRtPNPNjmfM nBXF3W+k5bsM55QV2SUlU7Yfj2BjqfJ9DLBofZiuUleyWfvxU2LJuuAQ7moahSkNGD/k eYgaqjNowBpMI050HDSuMG7j6Tu3IxdBD2MlUQFUQOHqLuWpFH2ue32bQ5fb3yN9G+O2 0aQ8f6Cg5OsBAEIsETqh8t1ENRekxBfCPJdyYvJzGfjyc9xOtBgF4PaDQ4YdLLJh7pJy 4QXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763867100; x=1764471900; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=bNgBXVliADaREJ6nkSovsbUQBYpNGNtzg4nO0JMTz5A=; b=OJgoUjgHGfeQ2eXDjdrJ/wMxepNXnmqypmGJmOf6SCp9l+1rG4QGUqqJdgEYzkLSab pIxVze/FXgS70crXpXeT7JjbucG1ks8pTTdBE84VbCC0D6O1wkOfgN7oyeOexPJJHCao 1yEGvjxTL3UalDdQTADwHDbxExg5q2gqWEiC4IbyaU+Hyp0XSte0bNf8ImJUziYRw2z2 FQ6FQfT49PyUBXFlOJwi3X43PszhBJJlYBUSaMLAGwzaCsGLfVqL6R2isbKM6j8RoIcc pnhnFlsDFGh+Zx9Cbqmcn9U4rkhQ0cjUH/Y5UEfI190MdPXQvIUscPgxPQNXxXKLWKVl jKoA== X-Forwarded-Encrypted: i=1; AJvYcCX5vEwvo5V52bmkusdrJsF4s3TFJ9YXvi1i7e0IY4DbhZLETNQc211cf/vmc/njGICX24JKKCy+w+DoDBo=@vger.kernel.org X-Gm-Message-State: AOJu0Yz3K9ItZUTGHATsw3GZCMiVJDc4DtZZlEHwZ6tRhoavn80/aT7C 65Ncxp2avNias+K8aBCmUN/niC7Aqos7t+IRx8OCv+OSxBUEPy9elVrJ X-Gm-Gg: ASbGnctT1g8Z22BzHOJ2XYSkP7GD/EUVPAn85nkF6Ho6iX3FgxLnUVDM//FxT25xp26 bbbgsaGF0jgdPKKf6ifCagoQPHoSAEiJtw99DoGSEP9ThfsXylpKH6HEC1ThD3VnVRh2Ol6d3wi oJUKm/B113WLP3mKML/gXgkbn0elM/gEtkVEYzVsvhKT/5xAq098Jty+SehWizWVKzYGCU0++Qz jnN0Kc9rw+VUfsqay1sbFsZe8OVztDeh01HTSAUgobB0Gl7fWgUtg/JyOzmfsmgtssJ6lZv7+kI 5OfuAPqG0SNPDUs/uRzmKF3bbcqRrRTVNyUyLZb//G73ovww0D0799gFOOkc1scWE1HHVlk6Wac tn4s6w5DATarZwTLdFUbHUYU9fJiGCl9mRIu6qwZJBm+pGWfjAaPHEKb426GAj4oIyis4gQL7xS CgXGmM76lcIAvUr9rNr4mEbTEnQQ46g8KgMNKb X-Google-Smtp-Source: AGHT+IHkIt5IF6kEl8boBJ4UTx4CK84Qp7kBat9UgYyfU8OeT0QKX8SHcmGNaB60bDxys3XwPHAOTQ== X-Received: by 2002:a17:90b:4c4e:b0:32b:c9c0:2a11 with SMTP id 98e67ed59e1d1-34733e563ffmr7489087a91.4.1763867100420; Sat, 22 Nov 2025 19:05:00 -0800 (PST) Received: from chandna.localdomain ([106.222.235.50]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7c3f024adcfsm10386095b3a.31.2025.11.22.19.04.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 22 Nov 2025 19:05:00 -0800 (PST) From: Sahil Chandna To: akpm@linux-foundation.org, david@redhat.com, lorenzo.stoakes@oracle.com, mhocko@suse.com, vbabka@suse.cz, rppt@kernel.org, surenb@google.com, hannes@cmpxchg.org, shakeel.butt@linux.dev, zhengqi.arch@bytedance.com, Liam.Howlett@oracle.com, weixugc@google.com, axelrasmussen@google.com, yuanchu@google.com, yosry.ahmed@linux.dev, nphamcs@gmail.com, chengming.zhou@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Sahil Chandna , SeongJae Park Subject: [PATCH v2 2/3] mm/vmscan: use %pe to print error pointers Date: Sun, 23 Nov 2025 08:34:17 +0530 Message-ID: <64e15c6b2ce86d7824f54e9e001b6f5b44af48b8.1763796152.git.chandna.sahil@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Use the %pe printk format specifier to report error pointers directly instead of printing PTR_ERR() as a long value. This improves clarity, produces more readable error messages. This instance was flagged by the Coccinelle script (misc/ptr_err_to_pe.cocci) as an opportunity to adopt %pe. Found by: make coccicheck MODE=3Dreport M=3Dmm/ No functional change intended Reviewed-by: SeongJae Park Signed-off-by: Sahil Chandna Acked-by: David Hildenbrand (Red Hat) --- mm/vmscan.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/vmscan.c b/mm/vmscan.c index b2fc8b626d3d..7d5b41696cc3 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -7500,8 +7500,8 @@ void __meminit kswapd_run(int nid) pgdat->kswapd =3D kthread_create_on_node(kswapd, pgdat, nid, "kswapd%d",= nid); if (IS_ERR(pgdat->kswapd)) { /* failure at boot is fatal */ - pr_err("Failed to start kswapd on node %d,ret=3D%ld\n", - nid, PTR_ERR(pgdat->kswapd)); + pr_err("Failed to start kswapd on node %d,ret=3D%pe\n", + nid, pgdat->kswapd); BUG_ON(system_state < SYSTEM_RUNNING); pgdat->kswapd =3D NULL; } else { --=20 2.50.1 From nobody Tue Dec 2 01:22:04 2025 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1463523741 for ; Sun, 23 Nov 2025 03:05:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763867110; cv=none; b=nsVr0jXxzlE2vRA1a4GhdUylWvaqfuG2g2355ulAYBpEPRmS7D/3Jm//ABLyswepqTZKOO0jBUhH+CUPWmI95qcvpcqg/oVhKWmOLScjAy5HcmACZrMYqvzR6s/McF1GuWHpgyrsH+x8iaK4Rt5aVOTANFOOYSSuJdKm2bintq8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763867110; c=relaxed/simple; bh=GefarqzEOUvY9RjSGxFE6wAG0f0G2haqpnpXut1YiPM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=OdOW8PEhw/7YNw2NwejmJLC+ndG5UEryCDl7NvnFobzXDMY3awfI9w1ENjJmMY0z0T6Qt3J0fr36NzX5JNdUkFOzJd3Em93WLjkusfJ8H9mVU901hMqK82sWcQD2uF0LJ6p/7eS8URlFDgAbC5nt4W++9UwI8IvBQ115zDLtvp4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XzezFAal; arc=none smtp.client-ip=209.85.210.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XzezFAal" Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-7aace33b75bso2999657b3a.1 for ; Sat, 22 Nov 2025 19:05:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763867108; x=1764471908; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=PnnYqS1Gva2iq8RVemeTHL95j/HsRMm9CNrwh4z6Zcs=; b=XzezFAalp8xSCl7M44rCOv4HhJqWb16Qshi0fINE/tlHHm6U9YgCTcHTz5UDEBPHCM 4g8JTGFkme54GhIVLNJG+bKsSO4Et15mPYM1huuN++kyAQ3AWofTEArjD4g6Ae2puwZ0 OSrQLQDGUNcdx4NeN1CGs7v1lyn9p1VERAHzPdsIpp6znWHI0Zx0IwEwBAYtkYVCAPvK 5kCpvtcQ8qJ09xzTrCAKfyhQ5lk4+pESmTdXaCPvdcAad3x1M1OPpdeIuPWJms9YyQjE R7uOloZC2ckzU6TTCEn/GN6f3+0Z5+a2xNT7/jAMYXybSjYvsNOORTdkccDJOBkraA4F LNSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763867108; x=1764471908; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=PnnYqS1Gva2iq8RVemeTHL95j/HsRMm9CNrwh4z6Zcs=; b=O6APm+ubBl9XercSvSzG3IB0Dbsuj/5VHSaTQLpYZqf9MRVBa/Y7dybDdNECGJPsV/ oezFLlDQmMszhW84gjRCMYIjDig71PgK7wec/6gNnj6an5g2zfcS1qlPBUlDZMlGuYvv HJStdmMPSzEF6cLRsn8p+5I+UgNlTwDEnCJgTqkOjS0Lsx9j0cIx6qe+cHwvVECetAjI Ei9t6xme+EmFgk/YljkSQl7Fn5N/Y7mlVDJ1Jaw685fqgBaW3XsWDiFVNimh5UWir0Dd InrrCLRkY/louooPCjnXIlSHOc9Hro58pokMrxTpCIu61ySbUhCA1zd7zPAA6U+xUw0g rN1g== X-Forwarded-Encrypted: i=1; AJvYcCVh29HjFukTPb+KTAmL9qHAMBzYVRNm60iqKuJ03Vn+OARhu4ZjOssTaCh4gA7E55FeXzDWOMll/MJU2FM=@vger.kernel.org X-Gm-Message-State: AOJu0YySeIUsxUPsstu0C+vv7ttV7gLyJ5jZ8gbklbEHfa3DVgGkCDsq im4KE0h6Zpe2nUZUqSZKMWDkV2Yxka9JBDgRMAECKV8uRPaejB7x07R+ X-Gm-Gg: ASbGnctvjnSM89A67k9yxO8QxWA5d7KGRUhXqRP72InCrzNmpPYYRcYa9X3O7/pbTqR V31+2T5Ko5FaU2fKytnlq1zbrAQPLqLwRJMeNDBE31+95BdkLoj45a/qNsZaXK1/tQj4lc1uojK CVtpn/YgIcZmLhM0FmOE3PKyjoaGmTW4KQUAk5m0jI/lDdK/t/BLkNJl71NlRmpZaXPvru5NmID syKZshqdIeHMOfmUIM+AvLIJLa7Xd/A7oN+2W3JgS+y/M55CcAmS23J/K11sRcPteaxmh0HwDui ufmwyqmJjIPPvhMLLf8IPdaWHlNLXYtNvyn4SP+LqISU0T/3rCZ+OeFa9wrS0Ol4xRqmPeGOXOW 9WnXzFd3tBrCH8aEqjRYhwp04TRzKyPkF7wug7Rt5sxgJC792eGvQbLdks7HggOn5gZYNiTskBw 0JbdjdbfMpt+Ez4X/0ikmRQS+GTQ== X-Google-Smtp-Source: AGHT+IFHuK7TqumMxHSpEjVPwsTdd0AYETlkSpyKy7kt0aWPWip9dphCpyMx2hcuSl0hHQG5gU/VzQ== X-Received: by 2002:a05:6a00:13a4:b0:7ab:8583:9cc7 with SMTP id d2e1a72fcca58-7c58db2cb6cmr7367436b3a.16.1763867108241; Sat, 22 Nov 2025 19:05:08 -0800 (PST) Received: from chandna.localdomain ([106.222.235.50]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7c3f024adcfsm10386095b3a.31.2025.11.22.19.05.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 22 Nov 2025 19:05:07 -0800 (PST) From: Sahil Chandna To: akpm@linux-foundation.org, david@redhat.com, lorenzo.stoakes@oracle.com, mhocko@suse.com, vbabka@suse.cz, rppt@kernel.org, surenb@google.com, hannes@cmpxchg.org, shakeel.butt@linux.dev, zhengqi.arch@bytedance.com, Liam.Howlett@oracle.com, weixugc@google.com, axelrasmussen@google.com, yuanchu@google.com, yosry.ahmed@linux.dev, nphamcs@gmail.com, chengming.zhou@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Sahil Chandna , SeongJae Park Subject: [PATCH v2 3/3] mm/zswap: use %pe to print error pointers Date: Sun, 23 Nov 2025 08:34:18 +0530 Message-ID: <0c00ceedce6e0d9aed35cee5faf15fd9126a1f70.1763796152.git.chandna.sahil@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Use the %pe printk format specifier to report error pointers directly instead of printing PTR_ERR() as a long value. This improves clarity, produces more readable error messages. This instance was flagged by the Coccinelle script (misc/ptr_err_to_pe.cocci) as an opportunity to adopt %pe. Found by: make coccicheck MODE=3Dreport M=3Dmm/ No functional change intended. Acked-by: Yosry Ahmed Acked-by: Nhat Pham Reviewed-by: SeongJae Park Signed-off-by: Sahil Chandna Acked-by: David Hildenbrand (Red Hat) --- mm/zswap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/zswap.c b/mm/zswap.c index c1af782e54ec..c35604db32ad 100644 --- a/mm/zswap.c +++ b/mm/zswap.c @@ -749,8 +749,8 @@ static int zswap_cpu_comp_prepare(unsigned int cpu, str= uct hlist_node *node) =20 acomp =3D crypto_alloc_acomp_node(pool->tfm_name, 0, 0, cpu_to_node(cpu)); if (IS_ERR(acomp)) { - pr_err("could not alloc crypto acomp %s : %ld\n", - pool->tfm_name, PTR_ERR(acomp)); + pr_err("could not alloc crypto acomp %s : %pe\n", + pool->tfm_name, acomp); ret =3D PTR_ERR(acomp); goto fail; } --=20 2.50.1