From nobody Tue Dec 2 02:31:05 2025 Received: from CH1PR05CU001.outbound.protection.outlook.com (mail-northcentralusazon11020133.outbound.protection.outlook.com [52.101.193.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 444D9253F13; Tue, 18 Nov 2025 16:34:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.193.133 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763483650; cv=fail; b=rmvxMQGejO6aJWFCr5zkyfvfLyUR49N6Uv5G8QMy6AwB3ufRC36tV24wuxA3od8Kl2ttcezKdhIIq9oddomqD5Byq0vbuyDJxXl2LjbS+wVbxQfWMDK99MSiQtmwL7uVCYiQnaLyxvwIJcCEtnVQ7cWdyu19MPLKmDvjBP8Qcdg= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763483650; c=relaxed/simple; bh=DwGczCv2J+9Hxilji6bptqtXCRyL74fOIDyDMpmI6Ns=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=YE+vMu7Bl1lF/ibRmyr2hULbxTqByKh+IIS7goMQ9KFiBW3ltT4Z0QcYafgDMwgk0h6+q7vyPSN+73QrH5YGqZE4EEVWGJ1eO/PWE2er7o4EC80XN4OqkkoojWZ1OfazJ+i4IutX8ELEkX/462Zlt0ACrYcdbtQB9kXLsOEnYYc= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=hammerspace.com; spf=pass smtp.mailfrom=hammerspace.com; dkim=pass (1024-bit key) header.d=hammerspace.com header.i=@hammerspace.com header.b=OFseOLUF; arc=fail smtp.client-ip=52.101.193.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=hammerspace.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=hammerspace.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=hammerspace.com header.i=@hammerspace.com header.b="OFseOLUF" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Fph1ed3Ro8KdckP+2uE8iN+N5orkI9ArH0gt0q6yC/0rvMG+7QpA9sbxeA8L90//RBHcrchkS0u/+lkHRgTcONEPw+KPwxJSH5Mo0253NzflA3sPQu3gUBdXitR5nOyfSLEB+zJcdkDQ5bwXoI9d7oR8DKSIH0XhD5p6dAZY58wG6dSeVXJrHYGqt9L8c30vLreyuk1AtNh6HmUNhQadNegAhH4zYHbtOUGvKmQ1ukijysQEtcM3TLY6z+wVnbdXLdmGEGH+8ZbdQzXuHCIi2DIDaK0SX+2bKZakfv5Kw4XkQrc9z2Cf59VfMvENdOpTCKPupKpoEB+6sYpo4W1LxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yXkNg2Zc2qwp5brBaFKNyTQlKLobws3PIxisakKIsO8=; b=WGjYdv23x9WcBcHPF43zmMthzUhPlaTeSHOtfe27R4nUB868PaFvCJPfw2JQOwfeQhPZagDqeiYZrr+uWC26d/qoMA1L6IRkkJj8Bf0vmDIVZy0qJHPzz+TCcRJFij/YxFqPsvh0RN3AHzp80aR0GulXyxchLg9zRknvM6+fqq4/CGu1Qur/bRqi6UwE2OFMBtRuSWE9Fu/24vD9zn6IrIql+GODr3x5cWF1xCXnowvUC0xY5pQHQe3N8Ca10pWMWoVdvlNO9L96OyBZ/a+Gjxl5kSYOenXn/SjXSGltPAOn/fqkct65M5sv2S2TbXM+c1W4SmxsApKUtQ+3JQCNrg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hammerspace.com; dmarc=pass action=none header.from=hammerspace.com; dkim=pass header.d=hammerspace.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hammerspace.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yXkNg2Zc2qwp5brBaFKNyTQlKLobws3PIxisakKIsO8=; b=OFseOLUF9+I8cx0JsOQ7pV0+cHclj8jwXDqpham+1TKPIQGDnBcAVLlzGPt7GNNBJD6tskkdZDktX4o9tpHfsHotAPyLa1Fy6jNlhvl13d3d+/YEdPv3wdnVaZRXk97RNHix9jNe04H8+fl5NWHXnn1j9H8+xpXZnVosYatKQ+I= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=hammerspace.com; Received: from SN6PR13MB2365.namprd13.prod.outlook.com (2603:10b6:805:5a::14) by MN2PR13MB4072.namprd13.prod.outlook.com (2603:10b6:208:26e::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9320.16; Tue, 18 Nov 2025 16:34:05 +0000 Received: from SN6PR13MB2365.namprd13.prod.outlook.com ([fe80::9127:c65a:b5c5:a9d]) by SN6PR13MB2365.namprd13.prod.outlook.com ([fe80::9127:c65a:b5c5:a9d%7]) with mapi id 15.20.9343.009; Tue, 18 Nov 2025 16:34:04 +0000 From: Benjamin Coddington To: Alexander Viro , Christian Brauner , Jan Kara , Chuck Lever , Jeff Layton , NeilBrown , Olga Kornievskaia , Dai Ngo , Tom Talpey Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nfs@vger.kernel.org, Trond Myklebust , Mike Snitzer Subject: [PATCH v1 1/3] VFS: move dentry_create() from fs/open.c to fs/namei.c Date: Tue, 18 Nov 2025 11:33:57 -0500 Message-ID: <9d219b32fa06998fee599815022dc70ed638d445.1763483341.git.bcodding@hammerspace.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: References: Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: PH7P223CA0021.NAMP223.PROD.OUTLOOK.COM (2603:10b6:510:338::16) To SN6PR13MB2365.namprd13.prod.outlook.com (2603:10b6:805:5a::14) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN6PR13MB2365:EE_|MN2PR13MB4072:EE_ X-MS-Office365-Filtering-Correlation-Id: 3d7dd31d-a86b-4289-5c46-08de26c049cb X-MS-Exchange-AtpMessageProperties: SA X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|7416014|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?6M205+CWvEViK3ZRfImX1Gq9n41TgVq+oMPOPHfCC5cO5/HQOMTfPtN44blQ?= =?us-ascii?Q?VZCeABCg0zL1Z8AKHs3JQdAU7QoW2p+q78DHypZOygo6J3Fk33QDOcJ7GEIQ?= =?us-ascii?Q?5Hfw9umsp0rtsu1zxdcwo3NTa6tkZkdKqJIxE6bShwIDFPZcomXWBkaYVB4i?= =?us-ascii?Q?fAATYXBYljuxFvAZAaLp4uhQMMqA8XbcECND+m5CoejytzYl/HnVOjCqyYga?= =?us-ascii?Q?5Y86ag3fCK2sCpkMSLn4lveySnryq6dO44HsEK+eoIIKIjw+XaQY6j5TNfLU?= =?us-ascii?Q?4FUX7xLhxxG4YtElq0Jpw3orSl3L12bLn1LFpoxx0jfa8vPk6Lp9IQOkVaix?= =?us-ascii?Q?yu7YcC8psJBaQG7aOf67Yrd81my0KvuvUJjtmg1VmWREjJqGjC6zON3b9KG2?= =?us-ascii?Q?f1b97Rrrqrja0jzv112tf1uKFCVZFv1SKebTjjqcFkIOFHhDHA/c5EGwzZJK?= =?us-ascii?Q?3YM3mX/Hkqt6L/UO+L8BM2IYq4mL75D3kzCyDCGAtbZCfuZeTvpvTDMJqiRc?= =?us-ascii?Q?NuG9IIrOFbWY95m3uw2nUnbTHlMqXG37SzhCpUUg/QKeeSu2Jwt06wBTsuCP?= =?us-ascii?Q?BUNYU1GzUy9FuBCrmE7maP9AB5mHD6pBXXW54tIsZYppZB1rHDPaGVL3X9r9?= =?us-ascii?Q?pFKcz7/ApS7p31wD0foFyEVIwB1KmNL96JVk6dtOgY2dqJ7rMsFFDBct2F19?= =?us-ascii?Q?Ivotxgfu9COY872vAy0VNcIlUd0FuMAsktXVYTv4eMMeedMPfFhQ8c3CzUrK?= =?us-ascii?Q?uUuqeW6HfQm2OMFj2/Tjc12DPZ/w83Ks6OwNRWf2nk8VBRyjGeDcXvelVQbS?= =?us-ascii?Q?7eF0FKg7dqVR3spxYsPqidvZZYxo8Y2yz3gsaV6i6i0+tPYocahSBo2oGR8j?= =?us-ascii?Q?SYotvgsjeLJSjcgZTncZ8cBYaJ4tJQWEla3OrASIyQTSt1OkbdpkvzcDqvgu?= =?us-ascii?Q?2JZwR/8eqQe0WyfF3AaCR6egC5aWeIyQA8kwA/84svMzilHr9wasxYg3Txsg?= =?us-ascii?Q?VIjUlr/gje4iC4zarA7ccrHJkPQEk9V/NLgo4H65Wtu8g0Y7TkOPXoJmdcq8?= =?us-ascii?Q?GK/utplhaDtO5KOGWHezhBmYFhcEj2E91f9Zmcyl09JLX+WA3wsjG8ljqIZ1?= =?us-ascii?Q?8+HFgXuUvBr6gUiSsHOW1gMzFZB/tqAHv8RuWi8/TowIe/PV1KMZqX4xxkmo?= =?us-ascii?Q?NAB4Ms5Bc3uyKY4RI9zNvryVx5BfyVjbl8sJIPSX/+SNle0WHPcUNbCppv2c?= =?us-ascii?Q?5TIxMxc2XIFFPa1H9tVHJzmKrd3qO787ckdyE1A9XjOyee1sJNxmiDB5b91t?= =?us-ascii?Q?FokO5NnBwPkAsBWVU+t/zAskJxdhIgxHPW71Z/LM7ADZReadrXrsnF62XOSz?= =?us-ascii?Q?HMNboQewdEKCkNSvCkTbRkAQHlYnDr2lmL2CBtTR7IEe1f33EFOM3jKZ99RL?= =?us-ascii?Q?bAjm1mzd4fHPn6yZfZ8iVkUIpqF31yUL?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR13MB2365.namprd13.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(7416014)(376014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?+TQU29dnh1VRz2N463T/q2+CzdH0uW9bh0mNuHylzDRtioBathKPINMb5X2d?= =?us-ascii?Q?YSlkK0hKK80e9t9SnOw6/IFJORcP8l8lfL03F2bxm7/fufeFAo7443EIqkMs?= =?us-ascii?Q?enjg+G+7VqXzN2McfuY6B1xOvrw0NCKy3XXYesmhx1hIgx803TlXamZuPZgN?= =?us-ascii?Q?toSR2/d1xa2/nCx7YQ6pB9GoitE+acpWlpuGBPkz63ZF/JNC4zRcl0CdB9Zz?= =?us-ascii?Q?OGCHTIkm8gwqs24URtyuvAlY5LKIbRZBSi3xdmNI5Np1CUAw1Bi1Xf0YG83N?= =?us-ascii?Q?RRZgA6BTDKOAsgnoVA1g//mRUJrxqrAFtE/JlZKy+3VibdAe/WfvteqKdzB8?= =?us-ascii?Q?QhpCasnhHzU2YAi9XSEMUOyWAQ0kwmERtkwGU/GzEYJ0DMnVbuJT7BhUdojf?= =?us-ascii?Q?k1l1nAc6joRGvjAaangYAO+4eKZMU9MBN7xs9mMyf1cxF3ahH4wvy6lSwDSr?= =?us-ascii?Q?E2ESgeHwOv0JjVcVbXMlR98RFqIEutiBKhHFvc27IHJXvJfls8Cw25512auI?= =?us-ascii?Q?43rFX9tzx7zF5k6SUaFL2WtavbyLBocDe0N7suFjvP5eABIYDFLx19Yz8qZ2?= =?us-ascii?Q?IfmTAzY8e20uwAhTUVxCxosFa7iVXNXOr45tLElPdfsOtgdy+orj6RvDUBfG?= =?us-ascii?Q?07BHNYqoRbln9W0XMVvmVMdHlx/5wvT2HV7luGPZ/t8cX5R33om6muzNja1z?= =?us-ascii?Q?qneTfyiSxv2DQuZJj40ihhzvTEpacON8+i6KBYoXIgWXR7VBnyRIk51j5KNW?= =?us-ascii?Q?wGZHoZIuxrm25cH+IAvLz6auZDKiCI8eLjKssHVM8hyVCo0QTuixMpgm+A2m?= =?us-ascii?Q?dplO9idEuCFEGateRLhFpAMYunPpWI4RlGGB9Yo4DfE/Kau9HrhTosapeScl?= =?us-ascii?Q?7atDsZLkBWfdl1KJe1JPMf3kN7uXaAgt6jrfoyd5wWRs40aNDuNm/VLbifwG?= =?us-ascii?Q?XlRaiPsn5liFvo72cCjFWumcUZrgZ+iprCXTSM+qKWm44Q2Vm4DxyVglPD+I?= =?us-ascii?Q?0BO/+lAduynXFJpkmOLAlidqoQOAxCXD2+ex9QCDthhpe4Cvyjw7lRSsX7bS?= =?us-ascii?Q?8047YQhAxry36TlGTRHU+ncyVoMKe5JrtRTlhsCsfQIcWooSzSGmjjdtl12a?= =?us-ascii?Q?tySYs6dQrNvRs3Qbp72m7gmpvolODoMt6Eh8ZDjMFPQ/N9LlbNfM94hwXt3j?= =?us-ascii?Q?ACQXvFFO6wDgQmtwmmsY3KYOBSWrQKyucbBRzBKuhvJ8+6uZUnGlPOwr7k+U?= =?us-ascii?Q?RTOPNSViie4Ni9BkEMBtEkl80deMvrLf/zj1yRe2m0HadSCWq5OF3kNScxKF?= =?us-ascii?Q?zgPYPAI7wSlr3GdroW4FdKpT4NqVrYoJ871c+dD/YsemUNF+vlQJOZ7x4nuc?= =?us-ascii?Q?HVyHAaGNqa5g4YYGs0Jgbi+Rsy2DH+iXbLTtBcG7X7YSyi46QnHJ+woBNrWd?= =?us-ascii?Q?vf0Pzn200q+NWlAbZMngzXwRLd5SyutgWZ470xROD39RhrsXoz3HfGlnTkyw?= =?us-ascii?Q?8/adJghsd/7EuJa2Ez369bg9GS42nlPXDNAyfOifYMdTfNdV1J0QAYGDdavi?= =?us-ascii?Q?uUOT8TvGC8coXGTDU3OT2l5rOYieNIZtb8UQFmRjNQ7mU2SQ8JlfY9qx8EJP?= =?us-ascii?Q?4w=3D=3D?= X-OriginatorOrg: hammerspace.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3d7dd31d-a86b-4289-5c46-08de26c049cb X-MS-Exchange-CrossTenant-AuthSource: SN6PR13MB2365.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2025 16:34:04.8675 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0d4fed5c-3a70-46fe-9430-ece41741f59e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: aUO9r4jAYKv/uBwXUZHW9QztCzAU2e6G/mQMa/g54/AIuySzG42A2uenTQKBRVQKOWcjASYqPT9wRiVpUbytO8hF0w3124MpRVnBxlt0V00= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR13MB4072 Content-Type: text/plain; charset="utf-8" To prepare knfsd's helper dentry_create(), move it to namei.c so that it can access static functions within. Callers of dentry_create() can be viewed as being mostly done with lookup, but still need to perform a few final checks. In order to o use atomic_open() we want dentry_create() to be able to access: - vfs_prepare_mode - may_o_create - atomic_open .. all of which have static declarations. Signed-off-by: Benjamin Coddington Reviewed-by: Jeff Layton --- fs/namei.c | 41 +++++++++++++++++++++++++++++++++++++++++ fs/open.c | 41 ----------------------------------------- 2 files changed, 41 insertions(+), 41 deletions(-) diff --git a/fs/namei.c b/fs/namei.c index cd43ff89fbaa..e2bfd2a73cba 100644 --- a/fs/namei.c +++ b/fs/namei.c @@ -4191,6 +4191,47 @@ inline struct dentry *user_path_create(int dfd, cons= t char __user *pathname, } EXPORT_SYMBOL(user_path_create); =20 +/** + * dentry_create - Create and open a file + * @path: path to create + * @flags: O_ flags + * @mode: mode bits for new file + * @cred: credentials to use + * + * Caller must hold the parent directory's lock, and have prepared + * a negative dentry, placed in @path->dentry, for the new file. + * + * Caller sets @path->mnt to the vfsmount of the filesystem where + * the new file is to be created. The parent directory and the + * negative dentry must reside on the same filesystem instance. + * + * On success, returns a "struct file *". Otherwise a ERR_PTR + * is returned. + */ +struct file *dentry_create(const struct path *path, int flags, umode_t mod= e, + const struct cred *cred) +{ + struct file *file; + int error; + + file =3D alloc_empty_file(flags, cred); + if (IS_ERR(file)) + return file; + + error =3D vfs_create(mnt_idmap(path->mnt), + d_inode(path->dentry->d_parent), + path->dentry, mode, true); + if (!error) + error =3D vfs_open(path, file); + + if (unlikely(error)) { + fput(file); + return ERR_PTR(error); + } + return file; +} +EXPORT_SYMBOL(dentry_create); + /** * vfs_mknod - create device node or file * @idmap: idmap of the mount the inode was found from diff --git a/fs/open.c b/fs/open.c index 9655158c3885..8fdece931f7d 100644 --- a/fs/open.c +++ b/fs/open.c @@ -1142,47 +1142,6 @@ struct file *dentry_open_nonotify(const struct path = *path, int flags, return f; } =20 -/** - * dentry_create - Create and open a file - * @path: path to create - * @flags: O_ flags - * @mode: mode bits for new file - * @cred: credentials to use - * - * Caller must hold the parent directory's lock, and have prepared - * a negative dentry, placed in @path->dentry, for the new file. - * - * Caller sets @path->mnt to the vfsmount of the filesystem where - * the new file is to be created. The parent directory and the - * negative dentry must reside on the same filesystem instance. - * - * On success, returns a "struct file *". Otherwise a ERR_PTR - * is returned. - */ -struct file *dentry_create(const struct path *path, int flags, umode_t mod= e, - const struct cred *cred) -{ - struct file *f; - int error; - - f =3D alloc_empty_file(flags, cred); - if (IS_ERR(f)) - return f; - - error =3D vfs_create(mnt_idmap(path->mnt), - d_inode(path->dentry->d_parent), - path->dentry, mode, true); - if (!error) - error =3D vfs_open(path, f); - - if (unlikely(error)) { - fput(f); - return ERR_PTR(error); - } - return f; -} -EXPORT_SYMBOL(dentry_create); - /** * kernel_file_open - open a file for kernel internal use * @path: path of the file to open --=20 2.50.1 From nobody Tue Dec 2 02:31:05 2025 Received: from CH1PR05CU001.outbound.protection.outlook.com (mail-northcentralusazon11020133.outbound.protection.outlook.com [52.101.193.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 468AD28312D; Tue, 18 Nov 2025 16:34:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.193.133 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763483652; cv=fail; b=ic5sICkb8PSbw/8bbhnGxvm89BMb1qgB7vNZioiRubvHgXtwL1LPaQGGerb/gsZgCMb+3BDEmUpEHfymB439sIMtatlraA2TLzD47ctH7B1ZcatTWQdjFWfYnJsluJlljOC8agh7e3sFZ2iZ4XnGPLEz+hTrIbqKN056rTp8o5o= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763483652; c=relaxed/simple; bh=DiLiGzq5gsU6XqpzKsSIHrnIlAYQTvzQfDKIyJP/UGU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=V6qIpYVRZNlcX5kRUgv4kshOzrgFloGJPNLOZ+oGuXxsHjZxKhy5QoQ2rviEPmv8hq7EQdBv1r1vMOdiNfNW0eAkp/XdOFBZEBr58u8By76bEDJkYrqVT1S36cR0FgMbahcc5ZppM0YqbalIy5EHbq+mcoPAegsbLxhusvVm6qQ= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=hammerspace.com; spf=pass smtp.mailfrom=hammerspace.com; dkim=pass (1024-bit key) header.d=hammerspace.com header.i=@hammerspace.com header.b=RG8Xj9i5; arc=fail smtp.client-ip=52.101.193.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=hammerspace.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=hammerspace.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=hammerspace.com header.i=@hammerspace.com header.b="RG8Xj9i5" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=adDtdBmaH27zpku0bGMu8F0OAGNjyJp+Jn7i5zJS9p9Mlnn+mlBhCw1tYP+yrb8KJx02COjX7VWu4Dw9ZnXyZ5ILgDYunZSnNKXQ6PxqIFpmn1MiPVTTl/ny6OAq6wmbtQ/oGCTkZ7GpLhnEsQOdHNYIu8/vOOTjZI4axSeIDu/RHw0XlMPMQ0rtj8NuUlR5TjFCcz6VjQAG+sJZNVKez2G+jOxzkbCuNldtR+Hi0ImJvG7JG2utwyUsQTsM60qldLHBXC+vNpOMXz1M9pftSgpm2pLx2/uvCylX4wwpmujgkX5TLRjqEFMOTgcX2jPwyIUS2fLbMjxS1i9dolVsyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vIRU8SrvUoj6aeaLDg15MtHgnIRy/vue8F4kvuUn8SM=; b=oskb/FP7QdBue2o5wsj/wX7KL1XP8Go5uWuMbIPFkPQddEc2Yy+8U9UyFJ3UccALU836D+41Bn78/ICsrxrXdR/Utl5x+0USWZlw5FttqGJSbgRlTI1LoFAwNxkm6BJyM29/H5X+A+Jcbewf1/ot4eZVVunTXjoScQZXpZeDFRzEAESMpGcpYaNPxyuqMrZ698z+BkKvpQDm+j6HMB/rUDfFVs06g5Tk5+iH7saPQqRvIFEDXdLjEyZlGPunm11q1pIv22FWFhKIEO7PZvQfYUWPFICVEzx4INbGDDq7bVToPj9BmgjK7j5pfPXMnU/+DI7jY1IVlcpO0+JMaHiReg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hammerspace.com; dmarc=pass action=none header.from=hammerspace.com; dkim=pass header.d=hammerspace.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hammerspace.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vIRU8SrvUoj6aeaLDg15MtHgnIRy/vue8F4kvuUn8SM=; b=RG8Xj9i5FW+rtb9gfFlIoxkOtXgb6dmp0YSnJOONY09C6K/6uQxJ+ClNcz811HTxb7Q93Hz3tfWfdmJJ26W4jPJcXWFmqpfLonmYJThJnSxEpwOEgXkLi+Y42S+O8zcIRr8r3Lg4fpapPje3SFVtX7Qd6dcZys1lVtF0eEyH0P4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=hammerspace.com; Received: from SN6PR13MB2365.namprd13.prod.outlook.com (2603:10b6:805:5a::14) by MN2PR13MB4072.namprd13.prod.outlook.com (2603:10b6:208:26e::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9320.16; Tue, 18 Nov 2025 16:34:06 +0000 Received: from SN6PR13MB2365.namprd13.prod.outlook.com ([fe80::9127:c65a:b5c5:a9d]) by SN6PR13MB2365.namprd13.prod.outlook.com ([fe80::9127:c65a:b5c5:a9d%7]) with mapi id 15.20.9343.009; Tue, 18 Nov 2025 16:34:06 +0000 From: Benjamin Coddington To: Alexander Viro , Christian Brauner , Jan Kara , Chuck Lever , Jeff Layton , NeilBrown , Olga Kornievskaia , Dai Ngo , Tom Talpey Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nfs@vger.kernel.org, Trond Myklebust , Mike Snitzer Subject: [PATCH v1 2/3] VFS: Prepare atomic_open() for dentry_create() Date: Tue, 18 Nov 2025 11:33:58 -0500 Message-ID: <333c7f8940bd9b14a2311d5e65b6c007e8079966.1763483341.git.bcodding@hammerspace.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: References: Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: PH7P223CA0021.NAMP223.PROD.OUTLOOK.COM (2603:10b6:510:338::16) To SN6PR13MB2365.namprd13.prod.outlook.com (2603:10b6:805:5a::14) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN6PR13MB2365:EE_|MN2PR13MB4072:EE_ X-MS-Office365-Filtering-Correlation-Id: ab4660cf-f50e-4889-700d-08de26c04af7 X-MS-Exchange-AtpMessageProperties: SA X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|7416014|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?lji4CXdaoT02DDMYi9f7lgc0ElxumpnWPOjwo8wc8mLCWes/6dCm6ZHUA7Aw?= =?us-ascii?Q?DhTnnsCoPMoacTs9/S8uTIjnvEGNN/im2g5U5sOhVW1NX7dxdRo1nuwWlLnb?= =?us-ascii?Q?B5qfWN23QGp+KT2IZa+1qFApTZA8fTPkOzrShw7dGqAqqlKcWw3dusa5SdDZ?= =?us-ascii?Q?vmencKcHBNIT7qWr23ZFVQ1K1vTJajT8ayxFVsmBOrepuwZEAzrKCh2RAZd3?= =?us-ascii?Q?Ev2US49U0/A9ID+8Hqlr3l4EFEr7q3fdaWyDGjAP4ZTza+c8Pu1IB6OYSr/P?= =?us-ascii?Q?dnYyL1zmavOnLA87fIgz8YydRKCG2YgCG8f4Jiq3A+8xa/Nkb4zoFxDwes4t?= =?us-ascii?Q?FqHXa4TxzNPPan5x9VNu0TP0plQoeSF5JzXcclAKovOzFPZVSoAksfL+ymHE?= =?us-ascii?Q?3/Mcxj1yLrB6nXGypysoUzp6koKhYHT/nTRGVMCnoD3VVcTbPPxDQGitw5mX?= =?us-ascii?Q?xNXbrXUW156hXUYj15DmxxjLsziHXzE9/pvSReABDb3kkN1qrFnxN4BOHhhy?= =?us-ascii?Q?tw8jfEjo5lfcPKE7ophdIU+GjlLv9o/GamxOsawyXL+BGiI9BNkXfxj+kqM0?= =?us-ascii?Q?9xcGlqn6a6aCNhbGSFhBr4sygrCxGajSM9Zz+0VdFQOvQd97XhbBXqnsluAa?= =?us-ascii?Q?VxuN8xHk21UPTddhFZuXjfY7oiUtIuZ5tAP+aLOeMqYxh+9u1g+XHnG+QicA?= =?us-ascii?Q?pLb5CXc5zyAUQFxjTkGLpy7p/sNxp7MVGkFmNAm9CSlkATEqvNdXxK4JmIQn?= =?us-ascii?Q?2PPZhktHIEvt1IMmITh8/VhiCS8/6Krbi/uhCHZszL/pDbfe3zcvI3YZOdzu?= =?us-ascii?Q?Rkn9XLuAflQX7BQ57SAGxwRPexnePRkwZ9HXa5nTiohOsRpqpjTZumMkGQDW?= =?us-ascii?Q?0UlSG3+ZRw3FBqmURVnl6u8XGreZRMah7SS4xabCiEGcqCHdfIN3NVWS9lAK?= =?us-ascii?Q?oOu96sBeW/MAnEW1AeroZoFvK/s4pJdUaQkOhtx1yDep5TdxBjqd836NYFxT?= =?us-ascii?Q?fEf/F1rIT9faA2NOZdewSmsz1rrhk/qFTa436qCgQDkQn4p+WVr1UizdOqny?= =?us-ascii?Q?9Ege023rtAfumNmhGVq9A8N6NcKQ9mqR/VYs8SI2fw0PBmi+dMf7f5l72PX4?= =?us-ascii?Q?z3LuWwWsmCqWL3u6PWfUvDSEcEI9l+2oRjUVNqsBhH2jtXAL40n/DJhEH2Ei?= =?us-ascii?Q?Wn2ke36vE2wSkMn8Jv+V62KtifE6G91BGY9EZ29ILM54ihTB9KmsJS5owuFg?= =?us-ascii?Q?U0M+1hAyEThBk31fbnCue+ueP2ntaHgnFlV9ZUH7sRiyySou2/OgL5a0oI4v?= =?us-ascii?Q?oxYACroDm0mAj+CKfQUzzeJmK0G8aJc608hKpSMoIG1a1h6x+OfHv80JIy43?= =?us-ascii?Q?jNgKSHbFr6HYX/hjWqTpVZd7I/rqKQx668IZgjaiDsNjVxMhitCS4jadQYXx?= =?us-ascii?Q?PxFn7LazRt87JCEzJCfRh6LMNSyK+p+A?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR13MB2365.namprd13.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(7416014)(376014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?wD+Ah0UkbHZohrSLEGHI87W+To7VYHKGvND7bkrDPTJ+SEh0YnRI7GE+sJ3o?= =?us-ascii?Q?skRosPMPWgGQu+NrhJdyXdLDyTDxkg/l7kYHxTWz7E13KSOk5HgDWzcBM9wG?= =?us-ascii?Q?zb65LrMjXqfXuun1e8zUL2kQz1vd2linFuhwrkfPX/6/0mmmEgoIPfMgcbX8?= =?us-ascii?Q?/jzEskwL+wV8FS47GdE2CJ5KMCPr0hPXkGCPyswBhkMxc4UQKeYsBcbSHZJq?= =?us-ascii?Q?ln6imz4g9tJAvZsg02lzXCsegQBY6+9UIByHARanLtC3+ZvitNK3bowosphr?= =?us-ascii?Q?m9k7v9LcgG+6OoeDv91P/I+ESVYjkJNxyJkkhEBtPzlSNOBeUXKwXTBmJUwS?= =?us-ascii?Q?LtLGj7Mri/cbiaikwZKlaYK0mLD+DHGSsiTpeVG6ZV/AjzfHBRz+qGupbbWi?= =?us-ascii?Q?TcQwhkBD3X2NfNPs89L32vAKZkTn+eHTUgmDsdVKoEnU6P2dHbpHsnrVV1Te?= =?us-ascii?Q?pkoonNYO4pyj23Ec/DZQGuqPzZ0XvPIAcdZpOte7ppDKyYB48uAWAHdII+ng?= =?us-ascii?Q?a9N0IR/EW2OgtfrrmEWMWGYNzKv+x/rv3UqzaEbVrBHor19wzdOPfP8cIMMn?= =?us-ascii?Q?HB9zQOKxCLkztwNnezBeVw49yrFVREYysk+kJ6Sc6jPXJDDYKdcOBIymkSuX?= =?us-ascii?Q?Vwhr9HJwBPQtBXVq8cXxhTWliQ97eA/tIf9Da/KvidnRp005fva4DSmR3k+f?= =?us-ascii?Q?sSDBrTRbL+9GJxwPoL3vu/lMQjFpmTFk7ZlUHBxrp8XkV0drDY52LrQnQWXJ?= =?us-ascii?Q?uoBSjLsqRqs238UV0mwL/MkaL9eFrUkixFuGDPaCDAlR49S1Gknkta8VG40D?= =?us-ascii?Q?fWhrzbiNFtHvmM2z83ZJDtMZ9gyS4pOzhIwWIB/QV91s+JMJ3l/TFbWWkW6k?= =?us-ascii?Q?3uzrL+srHMYiMOkdlHmeTCYIUzYA1CCf+ygFtHCA25ll3L+3QhwZXiOn+6SD?= =?us-ascii?Q?xQ+IjSLGYN1+57zBYuBVL6PFIAEedJDAB7s28sKt5XCxlBdccwHhqs/pYsJN?= =?us-ascii?Q?ChjDYAjJ62WqFR5rskpRMn7nsoWDlsvCTzR6R0a9Tw94u7ZUh50ygTlRQcc8?= =?us-ascii?Q?8DjH0ZyvK1xNqiDZS73Z/y38xHUSegS34xH5d5CgzUsred0PZbCc7NTZab6v?= =?us-ascii?Q?WjPJmG5Oqmr/EQ9dvLMouITXjHKTznmUQ6SbQlKMdSW7pnKE4mSMNkSXPLAj?= =?us-ascii?Q?NTnNekXhLzA5xZ7yO2j+8/8E7QiiZCU5WHyv3Dp5MvBYUANKrOBSflNOZBt+?= =?us-ascii?Q?hjRabS/WY2ilw10wQEttBGya1ZJARjZS7RK3YFOdiaSZiPdPAwuIUNIjhl9C?= =?us-ascii?Q?DFwH5CXH5dRTop/sIB/HWZTJQbXG/xde7mdeGt9usQ6Y3SunRLWKR6ah2WTA?= =?us-ascii?Q?Xu2gozKyvjH89cu5JAoKPOzqt9xOhvyLrifqDazqZb4KguHHmtvGhBNOJVSL?= =?us-ascii?Q?olhyKYj6GDa/bS8m8eyPgpB8q9d65gjS376/0ts0jUBedNmfxUNVXXMcb3H/?= =?us-ascii?Q?MU2n3anuxAKdJwOJLEGJEyFXBFPFP5H2Ah6x5wqbmVP2/wNp0d2FVMbIGVFx?= =?us-ascii?Q?5VbO7nvsJHXiB2LFRhLqdvgBpL0SeIYSQbm46n1KqCJHyK3WfKNUkOp7pNjX?= =?us-ascii?Q?lA=3D=3D?= X-OriginatorOrg: hammerspace.com X-MS-Exchange-CrossTenant-Network-Message-Id: ab4660cf-f50e-4889-700d-08de26c04af7 X-MS-Exchange-CrossTenant-AuthSource: SN6PR13MB2365.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2025 16:34:06.7942 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0d4fed5c-3a70-46fe-9430-ece41741f59e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ItqH55IKW0Jo/sq936bd/BiWDrNBSDX1fQuHxH+gs4k2x9hBBODgk/bM+MDtlNtJzeEL5IOkASfb2mXjnmw8bF5KYsMQmJLfjjwpR1iofxw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR13MB4072 Content-Type: text/plain; charset="utf-8" The next patch allows dentry_create() to call atomic_open(), but it does not have fabricated nameidata. Let atomic_open() take a path instead. Signed-off-by: Benjamin Coddington Reviewed-by: Jeff Layton --- fs/namei.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/fs/namei.c b/fs/namei.c index e2bfd2a73cba..9c0aad5bbff7 100644 --- a/fs/namei.c +++ b/fs/namei.c @@ -3552,19 +3552,16 @@ static int may_o_create(struct mnt_idmap *idmap, * * Returns an error code otherwise. */ -static struct dentry *atomic_open(struct nameidata *nd, struct dentry *den= try, +static struct dentry *atomic_open(const struct path *path, struct dentry *= dentry, struct file *file, int open_flag, umode_t mode) { struct dentry *const DENTRY_NOT_SET =3D (void *) -1UL; - struct inode *dir =3D nd->path.dentry->d_inode; + struct inode *dir =3D path->dentry->d_inode; int error; =20 - if (nd->flags & LOOKUP_DIRECTORY) - open_flag |=3D O_DIRECTORY; - file->f_path.dentry =3D DENTRY_NOT_SET; - file->f_path.mnt =3D nd->path.mnt; + file->f_path.mnt =3D path->mnt; error =3D dir->i_op->atomic_open(dir, dentry, file, open_to_namei_flags(open_flag), mode); d_lookup_done(dentry); @@ -3676,7 +3673,10 @@ static struct dentry *lookup_open(struct nameidata *= nd, struct file *file, if (create_error) open_flag &=3D ~O_CREAT; if (dir_inode->i_op->atomic_open) { - dentry =3D atomic_open(nd, dentry, file, open_flag, mode); + if (nd->flags & LOOKUP_DIRECTORY) + open_flag |=3D O_DIRECTORY; + + dentry =3D atomic_open(&nd->path, dentry, file, open_flag, mode); if (unlikely(create_error) && dentry =3D=3D ERR_PTR(-ENOENT)) dentry =3D ERR_PTR(create_error); return dentry; --=20 2.50.1 From nobody Tue Dec 2 02:31:05 2025 Received: from SN4PR2101CU001.outbound.protection.outlook.com (mail-southcentralusazon11022126.outbound.protection.outlook.com [40.93.195.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1632B3730F1; Tue, 18 Nov 2025 16:34:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.195.126 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763483655; cv=fail; b=asn1OdlsYwswd2FVyvQ4l6fwSDgCCWKIFLM5gJVVzZO+JpfBmJagY9T+PUWYE7+S8aACmqYn7gLSeR234yh5labfuFiZ0c/V3QFsGiL4W+AVSDRNgpjzbWo2OhX3zd0jT1xxBpr+EThPMiLtjKQevYsclm9bnPGzwuOW9ReepTg= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763483655; c=relaxed/simple; bh=vDPZScKy52yeX3O1/pkdbDKYrGRbzQxVIB2ORQXfXoM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=sQv4wZraqfOmBpn0lxKXEYtwTHuCpnSXlrzq3csvuC6NUaB1zvaTr+4WkyJcDwe1UYu3tglxcbVycO5ZRAz88f3n7zZBlUje9bsrh1PBx7V6kQuy56wWNfml8FEdvmWS5CSAqeGEv6arCtekeTYdMdSAko0z7ZLG10ZPKZwGmLI= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=hammerspace.com; spf=pass smtp.mailfrom=hammerspace.com; dkim=pass (1024-bit key) header.d=hammerspace.com header.i=@hammerspace.com header.b=LcQ8+1pn; arc=fail smtp.client-ip=40.93.195.126 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=hammerspace.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=hammerspace.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=hammerspace.com header.i=@hammerspace.com header.b="LcQ8+1pn" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=zNFm5IZlFWNhZkgTYIIFNvsG4ObF8SgvyckMa9W1v7jgTIsQJlSVVYJfYFT04qaC5qMAZt8ZHh5/WYXNjujZtA+KoH+QU/6htCf7ruAhzZRYwhg6W8fwMdmtx4wIOLq/UipIXt30NXMl1AnwTwLkKW0Uy4VesWUvdCeRxTK0NudMvLQTEzhIZD68aBIqXjgDrgiGmzD5VITr6ib0Rjn+KjDO1VaFcQjNzLNwOiFegKEZOglICYvaNorUmBh/Khc2EwM5UkKpJW7JqC5BZLN0vwGYi1BNVF/MlchqgVGEJTx4Zm7W2ENf+O6TaHMm8TFAa8Jrl1PWWSuTPyn1T7j4dg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BOSYKXuPmJkHE64d4JaFEsOCf9X+uVqt3MQzEGCnee8=; b=lhfEcA4MaxGkGt6TCw25fvwG3vAf/c3F2Wpe6X4OKmA7k7XfHNQguWFh3QeFWN+7DZAH0akaTij8oJhOp7JKaqSl/MiexCT/1rkSY4A8y6EQp42A9KGkjO2bVRsfQNbnI4oLt42mTC91jy/r78MvjdGC2AROGmeuPz075QZzlvkKAdC7W873YzmPW2t6mM+ZlAVZ1e6uCdbhUP0HwYgA8R3q3VSCcuS3AW6hVQLq9uexpe85SlLjKR1gZyYNG0IDs4BV4mjX0ZeAsfXxnPXLlD+XIH39/NX+ovPkHkio92rYr4eL66rQRVWL0BRn/8GawaL7X3KRszLMahsfUvgTDA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hammerspace.com; dmarc=pass action=none header.from=hammerspace.com; dkim=pass header.d=hammerspace.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hammerspace.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BOSYKXuPmJkHE64d4JaFEsOCf9X+uVqt3MQzEGCnee8=; b=LcQ8+1pneIOrZl6Zn/BcutrTKsXJLW7Q0NRU9omiy3dnWxCZwhZ+NNtSkogWC8GtjfXl6qAm0eYjq8P9rREcwPW41YRjyVi6LPPCfmTIp6/G6vVlZxBfYAQ4AjfJDH/kDRR3ugxHAsg8EU6B5Hfdu2dba5ZdOVdNaZ8XdP91Eks= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=hammerspace.com; Received: from SN6PR13MB2365.namprd13.prod.outlook.com (2603:10b6:805:5a::14) by PH0PR13MB4875.namprd13.prod.outlook.com (2603:10b6:510:92::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9320.22; Tue, 18 Nov 2025 16:34:08 +0000 Received: from SN6PR13MB2365.namprd13.prod.outlook.com ([fe80::9127:c65a:b5c5:a9d]) by SN6PR13MB2365.namprd13.prod.outlook.com ([fe80::9127:c65a:b5c5:a9d%7]) with mapi id 15.20.9343.009; Tue, 18 Nov 2025 16:34:08 +0000 From: Benjamin Coddington To: Alexander Viro , Christian Brauner , Jan Kara , Chuck Lever , Jeff Layton , NeilBrown , Olga Kornievskaia , Dai Ngo , Tom Talpey Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nfs@vger.kernel.org, Trond Myklebust , Mike Snitzer Subject: [PATCH v1 3/3] VFS/knfsd: Teach dentry_create() to use atomic_open() Date: Tue, 18 Nov 2025 11:33:59 -0500 Message-ID: <149570774f6cb48bf469514ca37cd636612f49b1.1763483341.git.bcodding@hammerspace.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: References: Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: PH7P223CA0021.NAMP223.PROD.OUTLOOK.COM (2603:10b6:510:338::16) To SN6PR13MB2365.namprd13.prod.outlook.com (2603:10b6:805:5a::14) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN6PR13MB2365:EE_|PH0PR13MB4875:EE_ X-MS-Office365-Filtering-Correlation-Id: abfebba7-b921-4552-8617-08de26c04c15 X-MS-Exchange-AtpMessageProperties: SA X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?SOa2xLoRzD/6clmeqmUwA8/Ur4xFwNL25Fh9WNU6IjfZ7iBjy1akYlN2U2Z+?= =?us-ascii?Q?oRSJbC2+vwr74h6EQTaOveGmMKy5ws4mTl8a7jNskphWP3eQxI0ivJNlbWhP?= =?us-ascii?Q?0ffgkAxVpLRUfNvN30dTy8cb0XckLPBzKCUe9EyIn22QXSy4dql+PMpJw7Or?= =?us-ascii?Q?2tvNVSsiighVUmNfX5W7DEI3JWVaaGT+OhAYGzLp1tTyXOyKcASnrHRAAjdY?= =?us-ascii?Q?wexzNej4hZpzKkchyImw8lOqOwsgbBi3cIwFRcf1RRZ4PmPVIHgEKbRnOnw9?= =?us-ascii?Q?lHzpuoIwrI3kggSrO2gLV6nlkG4IeTbaCewTQRgnAgDJaBPfonzFaV1gCyzr?= =?us-ascii?Q?3sM+L5wwjHc4z6L8I+9G5kccO1Whc99wyetKp2MtA0tnSpSecKH5Cfk2z0uM?= =?us-ascii?Q?W9i3obmBT6sXQRkNNM0dYbJ3eyoq3k4NCfCvcKHnXka61my/x/VINWsNe/Up?= =?us-ascii?Q?vN5gaEk7zgyZ5G7ku4pfpKYr9cRdzSb0AEahZXXPNXIR1jMbRnuAj+nxBYLV?= =?us-ascii?Q?9Sb9nX6PAt/cThAJ32Vzrl1liBFlhJpsF0tXWCJoL78YJf8ldYWc1x6dU6Mv?= =?us-ascii?Q?CPAaasMTzB14uMAQomArYBlQFBefzJ5Nf7SBwyZ2VUj7R00SNXV3g5wfiXm9?= =?us-ascii?Q?k9wgcx6OMrluYBoQBMgNdpRPDs84hDp9zcLwKgKQ0WII8/tgWVKLEI/xirBr?= =?us-ascii?Q?tzHtgzp4w5XMeEJ/ujVeb6BPnlz+09kafRyEYhQnnzxfQWayq2Qwpbslq+wd?= =?us-ascii?Q?EN9Ju6jkVD927BCnyWTwFkQ21ReGdH66tixrHtdrsNVGlNyrd+4oBB7PNmNz?= =?us-ascii?Q?vjfYVtEFuWwVHRSx7QGfeFX4A3V6DiHk+Uc5TgX2jXOc/DOsaCb1l/h2NlJd?= =?us-ascii?Q?BVPV8h1XuHHygdP+7mEbevsfjJn8MA+uvuK6fiF0OCGnMDWVqOVhAK/Pwl6B?= =?us-ascii?Q?Zzp6XDJ6vThPgVbW1aKPfpxXp13FOQ1hjYG2LsN+UcjAzjZaXecr7pRFMpyR?= =?us-ascii?Q?GN3/4Zw+Z+LTN2K6cEbXrnGeU8wOxjFBYF+dqyJ0JKX/U1lZ4wWEMTovhssv?= =?us-ascii?Q?Cu93efwzKKBAUl+vGSyGkB8pTzEGFeBA/dQ756doYPOWUtiY1sm9F3U2Xncg?= =?us-ascii?Q?qNXwnUWENyI5fQGRAcfEPDdljH1YAoPYVLEFpQ0s0ZBFGksTHEL1QsfYCJKN?= =?us-ascii?Q?pdgre/6A8xoi2+oGdOXNoap1j7EJAEmvwmjxx4Vo41U/oEEaluDGYsNVoWVS?= =?us-ascii?Q?A1QVuyJCxc0YtCrotUhKIm6LIO8WoqCiCYTIA3GRaWv+PyufjszO/zVrKOGi?= =?us-ascii?Q?8CyLq3gJI1KSAiz0+0UikHZTtbdEStQhDJKWnWXo9WVoVHUARHWHD00O0J2O?= =?us-ascii?Q?Itu8c8luho7V/kBHbJqGiHA8aLJ70qNaMqzTwLrSDEKB6vtZf953ZiwW2vFJ?= =?us-ascii?Q?hO3jsBqezUHWJsNMw9JwGhc9SuHXwN6O?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR13MB2365.namprd13.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(366016)(1800799024);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?MJelOWlojdsfa+HDStvhIsa6SOnvKpRBItL2BA/yOOZ+8Mfkgb8davnUZqpY?= =?us-ascii?Q?AGNbUXqhGN4pNkoa0Ye6OjiTHsYvhXkx6M7n3MBqZvAo8LgRMh3rLAv4buGc?= =?us-ascii?Q?QdMVon7hgFmGPbVL04zl40q/sX+6GIfHYzKecBuVmr1+YAJruMDmxQxnn5Eu?= =?us-ascii?Q?iynGzN7iBYPiNSO7vhA/MzTay+o8nF1l1vfPj9hqMQSNE0PRxgqnmwDChI9Y?= =?us-ascii?Q?SNIFzjnkKR456lgnAx0icAuKRQ+YN/wLN2LKe7fsCyyqGYtN82y2n+C8tm4K?= =?us-ascii?Q?bUYEcQ94+cC7vqe3MgfuUBBA3C02xV8mqnRAb9uGqa7MjFgm6THQhuOEgtGJ?= =?us-ascii?Q?45Ca+l8gYZdKjqHgG9H3Z90cYFDqflDw7MICuOtayAG7bHPolDzIkf4H7OHE?= =?us-ascii?Q?0QuBIuH/qGlK8Z7tvfZ7ElS+rnPh/vqouEsRjlo9D+3QmMD6gvar7b42hfMG?= =?us-ascii?Q?2E21KuFLbWiASsaNIZeSHAfz2f29hEbjnEJeU7dixVh/Si6DpaJrUdO7RgYR?= =?us-ascii?Q?7hF4xwebmDKWu5qTqFTx0AdJPZFxXX++tTyxuqy+gwB8H1qdbH8j5mbAPRKm?= =?us-ascii?Q?PN8vFHRcU6tV72bdK3W8DFQ3HGv/xG40fl1SnwiMEzSzR73LlfYaM5v8SpZ8?= =?us-ascii?Q?uEywki+hNNlIZp1mz0i9YGLCFXet/oCalcgV9MqpLTC7CEsdyo2qemFclDwo?= =?us-ascii?Q?bdjxBfcfzmc8B26ZmRO1xh5V2V+OPPvK3HPcV1yeuTh3yiLRSf1QwsbauZQQ?= =?us-ascii?Q?Pfo83UcAyQ5CIY4PVz7GFd2iQsBSahHimQCEKxoCYygj5pr+y/Xh9PGiZqJi?= =?us-ascii?Q?rzFyolZ42J4WqqT3oXXvQNUUC9PvZEUlVoKEGwk5NFAkzgmV41lujTJQIB4C?= =?us-ascii?Q?98kEzn+zU3GUAwny/q/QpwfRGjHpPgcDYmTbX1Rvo0GQcK+TofcuirS5Ch95?= =?us-ascii?Q?1VAIJGgX7ZvH3COXOCo+LLT9JQwn4Khts8tzNJzBFC5Dz7qaxU5NuhuCMbih?= =?us-ascii?Q?mc3sSkl1NoFrfI6UEL771MkZvMvC7rh+klDFwGsxOsJ8P9IkM+78OPR6+b5V?= =?us-ascii?Q?82o32Xz3mNpecdvxaLzpNaj9IQcL2RkvMWDazeZrt14QcE41MHtDYbkgc4Au?= =?us-ascii?Q?fR+f+wAcoUAnnCM4KDnc7GmHEohAFVHbzq8M9Kwwf/3Makfsx9y9ifBzG8tr?= =?us-ascii?Q?7ezagHEApp9v7WmulBOybEtxPQZ9viZavQh+UEdfdtl6e5rndtmOVq1AGtZL?= =?us-ascii?Q?o+u0waXnAPQ1kkiY7jtOVDJ5xUjtfJ/x8kqQ8Imb1YM6HRkaTTk2EiyJdZGV?= =?us-ascii?Q?xqavSusNUJwMIwVbRUxn11v75Nrki9jQ4lfRoASNZtKpM0j4wkcVK4mqLjZh?= =?us-ascii?Q?CU1/GswVIqqrJvhQf4ue6WCyrUzVWpzWZUB9uc/YE15nb6DbX1jE9LajYPvj?= =?us-ascii?Q?ppS6agjBrwabuV8Nt9wNCtyV/D3u7jG6fsvjxO5vUuPs/iOO6QrH6d5CUXHZ?= =?us-ascii?Q?K9B6HuwNrbhcc7xQ3PBqcH0iTFfSdL0ZcJdBjOpuTqZON6zZa0gStu5Ep804?= =?us-ascii?Q?0V1ti8K+QloJvRs4owGXi/CLPJOqnmH8wdQ5mjpFVONIk+cNmPTxZv0MSQ4/?= =?us-ascii?Q?/g=3D=3D?= X-OriginatorOrg: hammerspace.com X-MS-Exchange-CrossTenant-Network-Message-Id: abfebba7-b921-4552-8617-08de26c04c15 X-MS-Exchange-CrossTenant-AuthSource: SN6PR13MB2365.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2025 16:34:08.6801 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0d4fed5c-3a70-46fe-9430-ece41741f59e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: CznXY7ZaSsMyf07CfREqyQBA/l4jF4XPV6KS+jSm8teS8dXPx+P+5akHIp4N7gcFexpKtQWFc5igs+dIGcPcYiaguCAqso8gHEV3/ARJgBs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR13MB4875 Content-Type: text/plain; charset="utf-8" While knfsd offers combined exclusive create and open results to clients, on some filesystems those results may not be atomic. This behavior can be observed. For example, an open O_CREAT with mode 0 will succeed in creating the file but unexpectedly return -EACCES from vfs_open(). Additionally reducing the number of remote RPC calls required for O_CREAT on network filesystem provides a performance benefit in the open path. Teach knfsd's helper create_dentry() to use atomic_open() for filesystems that support it. Signed-off-by: Benjamin Coddington Reviewed-by: Jeff Layton --- fs/namei.c | 43 ++++++++++++++++++++++++++++++++++++------- fs/nfsd/nfs4proc.c | 8 +++++--- include/linux/fs.h | 2 +- 3 files changed, 42 insertions(+), 11 deletions(-) diff --git a/fs/namei.c b/fs/namei.c index 9c0aad5bbff7..70ab74fb5e95 100644 --- a/fs/namei.c +++ b/fs/namei.c @@ -4208,21 +4208,50 @@ EXPORT_SYMBOL(user_path_create); * On success, returns a "struct file *". Otherwise a ERR_PTR * is returned. */ -struct file *dentry_create(const struct path *path, int flags, umode_t mod= e, +struct file *dentry_create(struct path *path, int flags, umode_t mode, const struct cred *cred) { + struct dentry *dentry =3D path->dentry; + struct dentry *dir =3D dentry->d_parent; + struct inode *dir_inode =3D d_inode(dir); + struct mnt_idmap *idmap; struct file *file; - int error; + int error, create_error; =20 file =3D alloc_empty_file(flags, cred); if (IS_ERR(file)) return file; =20 - error =3D vfs_create(mnt_idmap(path->mnt), - d_inode(path->dentry->d_parent), - path->dentry, mode, true); - if (!error) - error =3D vfs_open(path, file); + idmap =3D mnt_idmap(path->mnt); + + if (dir_inode->i_op->atomic_open) { + path->dentry =3D dir; + mode =3D vfs_prepare_mode(idmap, dir_inode, mode, S_IALLUGO, S_IFREG); + + create_error =3D may_o_create(idmap, path, dentry, mode); + if (create_error) + flags &=3D ~O_CREAT; + + dentry =3D atomic_open(path, dentry, file, flags, mode); + error =3D PTR_ERR_OR_ZERO(dentry); + + if (unlikely(create_error) && error =3D=3D -ENOENT) + error =3D create_error; + + if (!error) { + if (file->f_mode & FMODE_CREATED) + fsnotify_create(dir->d_inode, dentry); + if (file->f_mode & FMODE_OPENED) + fsnotify_open(file); + } + + path->dentry =3D dentry; + + } else { + error =3D vfs_create(idmap, dir_inode, dentry, mode, true); + if (!error) + error =3D vfs_open(path, file); + } =20 if (unlikely(error)) { fput(file); diff --git a/fs/nfsd/nfs4proc.c b/fs/nfsd/nfs4proc.c index 71b428efcbb5..7ff7e5855e58 100644 --- a/fs/nfsd/nfs4proc.c +++ b/fs/nfsd/nfs4proc.c @@ -194,7 +194,7 @@ static inline bool nfsd4_create_is_exclusive(int create= mode) } =20 static __be32 -nfsd4_vfs_create(struct svc_fh *fhp, struct dentry *child, +nfsd4_vfs_create(struct svc_fh *fhp, struct dentry **child, struct nfsd4_open *open) { struct file *filp; @@ -214,9 +214,11 @@ nfsd4_vfs_create(struct svc_fh *fhp, struct dentry *ch= ild, } =20 path.mnt =3D fhp->fh_export->ex_path.mnt; - path.dentry =3D child; + path.dentry =3D *child; filp =3D dentry_create(&path, oflags, open->op_iattr.ia_mode, current_cred()); + *child =3D path.dentry; + if (IS_ERR(filp)) return nfserrno(PTR_ERR(filp)); =20 @@ -353,7 +355,7 @@ nfsd4_create_file(struct svc_rqst *rqstp, struct svc_fh= *fhp, status =3D fh_fill_pre_attrs(fhp); if (status !=3D nfs_ok) goto out; - status =3D nfsd4_vfs_create(fhp, child, open); + status =3D nfsd4_vfs_create(fhp, &child, open); if (status !=3D nfs_ok) goto out; open->op_created =3D true; diff --git a/include/linux/fs.h b/include/linux/fs.h index 601d036a6c78..772b734477e5 100644 --- a/include/linux/fs.h +++ b/include/linux/fs.h @@ -2878,7 +2878,7 @@ struct file *dentry_open(const struct path *path, int= flags, const struct cred *creds); struct file *dentry_open_nonotify(const struct path *path, int flags, const struct cred *cred); -struct file *dentry_create(const struct path *path, int flags, umode_t mod= e, +struct file *dentry_create(struct path *path, int flags, umode_t mode, const struct cred *cred); struct path *backing_file_user_path(const struct file *f); =20 --=20 2.50.1