From nobody Wed Feb 11 07:47:24 2026 Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C9D525F98B for ; Sat, 15 Nov 2025 09:10:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763197826; cv=none; b=FNm+tSeiPpydj2eDNHr6fy/HdxmA+/xw7zRfWeVvubB5y13jZuNAAgmOQfMOh8S6mGAlZ4705GfZBhZKN5Zgh153Igp+vOzu6f5rXMLVUes6hchiAT71YWwRrJf1McglNW8f0ahC6vtVorX2I6eq7f2Q+XVE0r8MNbQExbIW/Ww= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763197826; c=relaxed/simple; bh=39GjL804A0Af6T0xqj2B986g8wFCu7FUQ0sHq5hPvBs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Y5R2wgLhp1Hp6AAs7XGoq+TGUHtXijpogtFjqPUxeicomP2hI1dK4K+t1rhhkhCCE4jYrKNaG1LxahD7PAa0B2JboUdsHJf3ccRGOmxgUiOZDjxn7q++GAWwIVfG3CjTk5aYNlInlXW9+mYcv4Ib+NozvnulWlkDg4DJbaS8CNQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=m1uZM9PM; arc=none smtp.client-ip=209.85.215.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="m1uZM9PM" Received: by mail-pg1-f180.google.com with SMTP id 41be03b00d2f7-b994baabfcfso1710673a12.3 for ; Sat, 15 Nov 2025 01:10:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763197824; x=1763802624; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ucj2p+rgYAXgwVH9kYepl5CbaaWyr15G4v4y10s3RPA=; b=m1uZM9PM5/S0RV76ZkiTgEKkXZPcOkQyX8rU6jhhl2pR9bphHcCJQ4C2WKiqHbh4TL wGiwJy1AOOQfDBalTGSia+quFVUQCofAPrsARF7RxhUWYaVU8FtIkRg74XEM2W4aIA3o e960Ruc4lBUY68moQ/tD/E6yC/FTfFiBpq16j9Bb9pT2fttCEdk32lRA8Hr8Y7t9lGd0 7+IikJtivQ6sSfH7kFkVhrR33C5FcTW6FNi0PsKpVqCBXTCLux7CXhMV3mih5yl3lnwc DkrDlAIByL2tZJn3l5kgr+7IlG5haDL8PAlr8Q/9j1ROucTGaNWqwK06oyaxGUgjYheH gdpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763197824; x=1763802624; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ucj2p+rgYAXgwVH9kYepl5CbaaWyr15G4v4y10s3RPA=; b=u7Y6d8a0sRKrIvD2DoN4KkY+VAXpKQh8/416aEDFxpCviNhJCeIPISprzgATHWlIfW pKwbswQ6lLk8akQ5OcFIOh0VmdlXYXsvAxWHSY4GjkaWLwYSaun26ElHhX4sT2WcXkXQ 6fINFqNcXLataQz72QKXsNysra/AoDZ3lm8zApcVGVAkxJvxFJA7mm1HiCw60sJPP3zc WAVsEcdBKgavfqD/2+UKXmqkOVXbfsLCBHxXaFJn/U5ZUb02xDrQBV809bwYjUHbF/OL n9CR7Pas7Wby4EP02XeYYaZSh3o32JlEjy7uOob5FXHOVQAT6hg3pORQrVILPEIPpBfQ tdlQ== X-Forwarded-Encrypted: i=1; AJvYcCVRgSub7ESpW/vJQ6l9GzIGH4WTBjuyoFn1enwgrCKnSgLTHK4xZqrjTTYQjUW2Zy8eQ6VZDi663dktC3M=@vger.kernel.org X-Gm-Message-State: AOJu0Yyi0SQ1K7DgyqqApT/1uqyVzNkKKeBm33lEUyOalexDx8/ezsEC fxs5VmKifA/zCA+Dg/98zW1XRBMN5B9aziJoSxt2dSd4Lr2VsgXfthD5 X-Gm-Gg: ASbGncvN4tHwxR2s1BgJTLDG87oJrQ7aXsIf41GSH5XSkUU35QbwgcbgizmxdV+pV0+ W2azK0MAJ1XA8YwKBLjpGrPj5OtU8HGEkr+qMGMvGKxcfFzGlA44ph3+4gUbuvGlwxJoRnn2GeI r7RMq8/ZdGgtPXPfcbYg25Y3tE140UP+fLrnF0vGcoYumNZMP85IuxAcwN37u8dkVyl+kxRZrD8 KORG1hlENh2aCBReHtymZ/32SWUAqbt8l7P+KBuoWTaf3ipecl2rIK65/HA1ZQbfXhCv49DVPqw /CtxmW6aQJtJIfFa4kaAhYY48AOGyhjcmlsD0fEQ9oUytY0B2CrZAX8T1ZKelw/OsD5SloCpsRv 2ppUGhrBb0rZzT0dphMl6dXnV4Bi+zY6VJsygLLBUYKvvMLVjhZRjBa881x/QR4Sah4iQMPeXJw == X-Google-Smtp-Source: AGHT+IFdOsYpOF/1IoUjLFcOg8Bhmt7xGXHygPshYo3UvTQSI65Ig5BIOny2NN8RVI+eyWKKQcuUNQ== X-Received: by 2002:a05:7022:688a:b0:119:e56b:9899 with SMTP id a92af1059eb24-11b40b3420cmr2866205c88.0.1763197824064; Sat, 15 Nov 2025 01:10:24 -0800 (PST) Received: from geday ([2804:7f2:800b:a07a::dead:c001]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-11b060885c0sm23408196c88.3.2025.11.15.01.10.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Nov 2025 01:10:23 -0800 (PST) Date: Sat, 15 Nov 2025 06:10:17 -0300 From: Geraldo Nascimento To: linux-rockchip@lists.infradead.org Cc: Shawn Lin , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Heiko Stuebner , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Krzysztof Kozlowski , Conor Dooley , Johan Jonker , Geraldo Nascimento , Dragan Simic Subject: [PATCH 1/3] PCI: rockchip: warn of danger of 5.0 GT/s speeds Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Shawn Lin from Rockchip has reiterated that there may be danger in using their PCIe with 5.0 GT/s speeds. Warn the user if they make a DT change from the default and at the same time, drive at 2.5 GT/s only, in case the DT max-link-speed property is invalid or inexistent. Fixes: 956cd99b35a8 ("PCI: rockchip: Separate common code from RC driver") Link: https://lore.kernel.org/all/ffd05070-9879-4468-94e3-b88968b4c21b@rock= -chips.com/ Reported-by: Shawn Lin Signed-off-by: Geraldo Nascimento Reviewed-by: Dragan Simic --- drivers/pci/controller/pcie-rockchip.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/pci/controller/pcie-rockchip.c b/drivers/pci/controlle= r/pcie-rockchip.c index 0f88da378805..ed67886a6d43 100644 --- a/drivers/pci/controller/pcie-rockchip.c +++ b/drivers/pci/controller/pcie-rockchip.c @@ -66,8 +66,12 @@ int rockchip_pcie_parse_dt(struct rockchip_pcie *rockchi= p) } =20 rockchip->link_gen =3D of_pci_get_max_link_speed(node); - if (rockchip->link_gen < 0 || rockchip->link_gen > 2) - rockchip->link_gen =3D 2; + if (rockchip->link_gen < 0 || rockchip->link_gen > 2) { + rockchip->link_gen =3D 1; + dev_warn(dev, "invalid max-link-speed, set to 2.5 GT/s\n"); + } + else if (rockchip->link_gen =3D=3D 2) + dev_warn(dev, "5.0 GT/s may lead to catastrophic failure\n"); =20 for (i =3D 0; i < ROCKCHIP_NUM_PM_RSTS; i++) rockchip->pm_rsts[i].id =3D rockchip_pci_pm_rsts[i]; --=20 2.49.0 From nobody Wed Feb 11 07:47:24 2026 Received: from mail-pg1-f174.google.com (mail-pg1-f174.google.com [209.85.215.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A16F326CE23 for ; Sat, 15 Nov 2025 09:10:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763197845; cv=none; b=JcZDNoF5uyAPdp2AB6Iklfzd/1VH6I6b9QDWODzQhndawNjIkITZWynTQmSu/e9rLkwlD8Z5hScTBFCwzHYOWDBVWsxGf8YxbljJ3NUZJ25Ydqv8AKKp2pYBYzxCXNcNigwb7YtBla/cy023W7fDxDPB4Dh8a1il3svlpcSg4x0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763197845; c=relaxed/simple; bh=aLENdR9BSNy1WQU19DJ52igohwKCfgQbrHgW6IuMOew=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=IvrmHy7MuvxqP8Bd/Lgng/g1GjsM6LHT/55IpbQC3XoqSy62SedEy/I1luaZnUUDjz+oJwHZweIP1erkLg+TGXCHX9kQJQTW47OaUVLKl3jmUprDiRMqTOAF07MOmIlOvGhM59Lmb99yxnvBRX4uESQmjGg/XWkgHZADFmWJMVI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nqQ6DbKr; arc=none smtp.client-ip=209.85.215.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nqQ6DbKr" Received: by mail-pg1-f174.google.com with SMTP id 41be03b00d2f7-b98983baeacso1134823a12.1 for ; Sat, 15 Nov 2025 01:10:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763197843; x=1763802643; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=43JeYWuHKtURhUFg3KcuzTVi7n2XDdHqu+mEl6pMXsI=; b=nqQ6DbKr69gy188vRPsydq4jQPVQ7FD0QJyyvri9d0uE7IK2QFa9xlrWh0l1LJmh9m CiJqAsns83qyQVXS65tm0wC4UnhlCKi3C/Ac3QC5I47omB5fSx675k90H/Hvd3s9MOyh bUcBf0RNaVwJWZLrpALCFh6ZmSPgTJ2Ytfo1Hd5Jp+McvsVXMH5h8Itobi6mBMnb3/tp 4QN7+djhcrECGamdVvmJKHuzFMKyVz4vq3SKV98hcIr6otRuqchM2X4anSYq7LNEIDzQ +KnoQYDOXEwOJIzDSIXFEIhapxDWQuS2ulg8bjqy908Jf2MahYf7YzZzloNqKTPg4ADQ iJtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763197843; x=1763802643; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=43JeYWuHKtURhUFg3KcuzTVi7n2XDdHqu+mEl6pMXsI=; b=OB0e006TgMMGEY0wpjBS1bx4vcbCkWEakJSOe8Ljeb4wfsuFuWosXE77ZIMFXzGI2l H+zCZFykgNauVrJAjibxQMM1i77FQ9/FboSPCw9t8FDFGatAVRajlYDXn+J0JbWm8E0v 2Og3kuPZTEhR3Bd9nfMcX4qjzFGaH5QNkOlyUAsjOFwAv7Nc0+xmiWSD8lQv8lEy5ATG 3wcux23aAfPYAALapSV5eJaU2ZE26gQBhVpCzXqHXoT63Esxnskmjc/XyRe/fJyrtzx0 HJpBHgQLVIssg/gYSkYyM9iNVGvWGY/7yb8UFvOWAMPTelsoVVRoB5XMJ3W87wEejLEu VRBg== X-Forwarded-Encrypted: i=1; AJvYcCV6jK2w9DvWnKUUNwaAYfvHKNkN2Lq2nKGX8MA4oOdPW1mTdPqmXWGEhyYUFm6Wzf31DsEMss6zx4CZFjA=@vger.kernel.org X-Gm-Message-State: AOJu0YxY2hX+oBAAIav1n6uwUrm/57gbkMxnSxoi942kRhDAhE7Pm0P9 Z48aUDWEeGb+P4H7ZvAEE8rutoy5GEmcOLTRfFDM6As/MmSQf8OZLVJ7 X-Gm-Gg: ASbGncvXzQkA0lTFMtoJ8d2xQtjbLiu8XdYb6rT1RFt57tfEd+RwFrRJiG1I0ydRekb DFlZh1B77DiQL5VGnLuKugWs5QErsv1PsPxw1ElUNzgm/KM0wEDQ9KZL/hgpZ2ZSbUYRa3Znguw xvEOu2c6e0XFBM9JAhXxyU97mlMu3rrW8BQMKbLHpVhaeQUC17pH8i3RLBF0dY6//MKTt3BZLPn 6Erx7zq8gHpax8+iw40hadFGNlc/3DhLrPes7PBOz/ang6W+79D0OPFeWCIm4dejNPspa9xq77C 1rdoonHZL/plOX60PEtgSmhS+uABWbQ7YQMIIKc8Qeo7FbX1rin1l1AT+lRsKuHgBDe3hAnYX+R USSRU6hzopFBfIpvYaDz5EFWosM6qUy1EyatKjRB6c+fd97U8GL4IhmNOLKIFK1jIU3wZhSMR0Q == X-Google-Smtp-Source: AGHT+IElHt3OAfMQunNnxmg0BPEu4aQyjchDbhYGwGxKZcOlUa5P+fzvsHcgcZg533YgbRMtBY3msQ== X-Received: by 2002:a05:7301:5787:b0:2a4:3593:ddd7 with SMTP id 5a478bee46e88-2a4abab9ccemr2414709eec.4.1763197842582; Sat, 15 Nov 2025 01:10:42 -0800 (PST) Received: from geday ([2804:7f2:800b:a07a::dead:c001]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2a49d695821sm22796380eec.0.2025.11.15.01.10.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Nov 2025 01:10:42 -0800 (PST) Date: Sat, 15 Nov 2025 06:10:36 -0300 From: Geraldo Nascimento To: linux-rockchip@lists.infradead.org Cc: Shawn Lin , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Heiko Stuebner , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Krzysztof Kozlowski , Conor Dooley , Johan Jonker , Geraldo Nascimento , Dragan Simic Subject: [PATCH 2/3] PCI: rockchip-host: comment danger of 5.0 GT/s speed Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" According to Rockchip sources, there is grave danger in enabling 5.0 GT/s speed for this core. Add a comment documenting that danger and discouraging end-users from forcing higher speed through DT changes. Link: https://lore.kernel.org/all/ffd05070-9879-4468-94e3-b88968b4c21b@rock= -chips.com/ Reported-by: Shawn Lin Signed-off-by: Geraldo Nascimento Reviewed-by: Dragan Simic --- drivers/pci/controller/pcie-rockchip-host.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/pci/controller/pcie-rockchip-host.c b/drivers/pci/cont= roller/pcie-rockchip-host.c index ee1822ca01db..7e6ff76466b7 100644 --- a/drivers/pci/controller/pcie-rockchip-host.c +++ b/drivers/pci/controller/pcie-rockchip-host.c @@ -332,6 +332,11 @@ static int rockchip_pcie_host_init_port(struct rockchi= p_pcie *rockchip) /* * Enable retrain for gen2. This should be configured only after * gen1 finished. + * + * According to Rockchip this path is dangerous and may lead to + * catastrophic failure. Even if the odds are small, users are + * still discouraged to engage the corresponding DT option. + * */ status =3D rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_CR + PCI_EXP_LNKC= TL2); status &=3D ~PCI_EXP_LNKCTL2_TLS; --=20 2.49.0 From nobody Wed Feb 11 07:47:24 2026 Received: from mail-pg1-f176.google.com (mail-pg1-f176.google.com [209.85.215.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6520A26B777 for ; Sat, 15 Nov 2025 09:11:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763197867; cv=none; b=KlH+zI3iC5pbk0wknPxuOmbMiYvd0vBKmEtF27dQPc8bSClpSwqA0NqPDUSUGos3RX5VUdmforRI9offMFZBbT5p61vhCKvtuZ2YR4xBdV3kXw2I0/tkjSjaPkTI6/Ikm47y71sPfKpX+RCftDEKUSSMs/314gRrqc1yOY6PMJo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763197867; c=relaxed/simple; bh=dlBNths3bjgJwIY82AdXxJk7nz28NGpPfCGP2ldQ+VM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QojtH7otc5Quh1mDEvuxauAlvwpmC+ZQvFlWB8HRy+WAXRvEHobShyXVnnFF3Oc/cF3OTlTHsYCZeEHLJcuSDy3z7qI9wx+cMXEnFKX9L8ZRK8tuD25wuMxhvMr55pVMLv0nG9kZxSGNyLxdzEKo3T2bGU3KagdYp3peqLQziF0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Y+lsSIQW; arc=none smtp.client-ip=209.85.215.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Y+lsSIQW" Received: by mail-pg1-f176.google.com with SMTP id 41be03b00d2f7-bc8198fbaf8so1131178a12.1 for ; Sat, 15 Nov 2025 01:11:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763197866; x=1763802666; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Xq3fPnKASXQtpwph9wF/EfbRc92D/a+itaxLGojV4Lk=; b=Y+lsSIQWDzq5XlgkkHNYVdyUuDP91J2mTrc0+vCdVkzBwMD7g93NYl7tNzDeb7sdWp O94182UO9hA3u+wFfS3adetQo7KcWd5uIpzhE36nABBISP+j69Er6PMw1PJuXKde+Lrt JvcM6UjBHaY4iQwT2pYcpprzBswu38a2lAkUVubS8yMq+Onu2iHIK/bpB7KLFQ7U4YvQ 7tmwJ6ay0WID1V7yNu9cFosYZfyIuTw71Kog0oGe9wdVkBgVw21faprYYjA2gQKFxlye d6MKk/dNOhD2Xw07D+ptcPIt6DP6gdHrhXBaE9+gzHVmaN/LI3I0pZOzjQnaw5qqUWIg FEWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763197866; x=1763802666; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Xq3fPnKASXQtpwph9wF/EfbRc92D/a+itaxLGojV4Lk=; b=jUc1682x1TGAiO3RMknvAsyH7VAZVyuJ0eXTxZG3eI5PRT0/ArqSDK9hu3RYk80Dcr yyCb4qVYcED5+da35PS+0ojB75sc7kg3q+UrRz3G+nuu+HYlMz44DRsXCg7VMETbaej/ 9Na7ERhAqDGWcT8fwpdTkl0dN3yLGD7MosuFuz+KJY7tgJ1SJPzUxoOULsDfafbhkwzL reNJNWmlOY8aRnwkqaIy1Y/0lKNUvtIMV+ALQhZViWmtedMh9M9aWXGru7+gw72ioaks vQ60kPrd//huvzWRTC9+HeszptUy8Q1waQgMyhhAOSgBK4xL3rTNc8d1hyWVdmZucoNO YkMQ== X-Forwarded-Encrypted: i=1; AJvYcCX5eJpG6o0rvsn6kmMH3qVMJ8zHmLzoQ0XyHJeyEQQSvbSwhYM9/YB+YGHjHVEqBEZ6F8G3Oxou/sfTFeQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yx5srfSoubRnGuOdSy/UxZpJ2d/st0SdNjmQjsiDKA7oQotSKQW ee89MakK3AZSeJGlpa50F9B7EAQAOhE1sw/ClE2Kuy9eE/Qhh+4faooE X-Gm-Gg: ASbGncsF1vrjkDNpTQADXrd8w/oDrbl/lNFCyIQDQxEfBJz214CiJQ+LYc64T7aVBX9 Yhc/DUVF6uG7AEV4ibmuk0KHYsVXiZW66pH4+mGVaJyopJJZHni/u+sPPv2Ql4as/kPU7DiIvyq xw+nYXwqAjvUWmsU1ZRgfRbUICVuqatLYfe5xdN6PSuArWpW1nbxTsAJPTWbL9LMSIsy+wwpH7J kY5mmOJdU/Rj7TMbbd2f1QSnpnqkai2pnMYI1/dZz20Jw1+DtniZMu/sBDerj8+/zKKnLDcQ7np zsc39NF0BHzA3naE2a40mMI/5QUWRhf2f8H/XuBASCQUtamPxceRyfApKwJYAypaYmUHWXbs/Pg W2hxABZXukVKAJQ+Id6qosR/RAOjlQCIsK1X7kqEqJOt62pI+6QGqZu3pgr0AqdGgovHA+apVDg 0EuseONDii X-Google-Smtp-Source: AGHT+IH9/crdAL/odtABr+5A97CdQPw4u3wDAvn6Sjfb7QYJpDPxj2xNfdzG8PUpaUTw8aHQvHD0Zg== X-Received: by 2002:a05:7022:69a5:b0:11a:26dc:eb61 with SMTP id a92af1059eb24-11b40e7b696mr2640354c88.7.1763197865521; Sat, 15 Nov 2025 01:11:05 -0800 (PST) Received: from geday ([2804:7f2:800b:a07a::dead:c001]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2a49d695821sm22799663eec.0.2025.11.15.01.11.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Nov 2025 01:11:04 -0800 (PST) Date: Sat, 15 Nov 2025 06:10:58 -0300 From: Geraldo Nascimento To: linux-rockchip@lists.infradead.org Cc: Shawn Lin , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Heiko Stuebner , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Krzysztof Kozlowski , Conor Dooley , Johan Jonker , Geraldo Nascimento , Dragan Simic Subject: [PATCH 3/3] arm64: dts: rockchip: drop max-link-speed = <2> in helios64 PCIe Message-ID: <53332edec449b84d8a962f2b5995667766359772.1763197368.git.geraldogabriel@gmail.com> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Shawn Lin from Rockchip strongly discourages attempts to use their RK3399 PCIe core at 5.0 GT/s speed, citing concerns about catastrophic failures that may happen. Even if the odds are low, drop from last user of this property for the RK3399 platform, helios64. Fixes: 755fff528b1b ("arm64: dts: rockchip: add variables for pcie completi= on to helios64") Link: https://lore.kernel.org/all/ffd05070-9879-4468-94e3-b88968b4c21b@rock= -chips.com/ Reported-by: Shawn Lin Signed-off-by: Geraldo Nascimento Reviewed-by: Dragan Simic --- arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts b/arch/= arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts index e7d4a2f9a95e..78a7775c3b22 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts +++ b/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts @@ -424,7 +424,6 @@ &pcie_phy { =20 &pcie0 { ep-gpios =3D <&gpio2 RK_PD4 GPIO_ACTIVE_HIGH>; - max-link-speed =3D <2>; num-lanes =3D <2>; pinctrl-names =3D "default"; status =3D "okay"; --=20 2.49.0