From nobody Sun Feb 8 04:15:25 2026 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 281092BD001 for ; Mon, 10 Nov 2025 17:23:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=205.220.177.32 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762795403; cv=fail; b=dZHiAIlcR06QwJ3QfJghctqUYDvEIP0a4UJqeGHxgOxklDEYl0BkUdjkrZba3d+kr0biBULX91GL8qwntzwNsENswMsARrAlMWRodnChkgUeFTING3OABWxqv58+nT5lvVnyk3NHs2wpmRhwZwrbDeGMI520cNnVMt0bKAhTW80= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762795403; c=relaxed/simple; bh=mUoeIsRO5O8EZPUL5NPjPty0Lpg6uoIfJVO3/eFEXk4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=PNsc4P6kvOxqJq5vA1b6LJbii+Iy+4hA0VSelhLCgNBc3vya9cdWKtZpUeK1xQq5AGLx4ImT0BcmwoiuLKkupfuhpHJopOT+nPYqKBAQDZ1IOtaE81AupC+z/X/ST53ex0Mp1COWMTcMgDSoinZCW6G7RWQ+Yng9p0Fy/8EiJk0= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=P4ikck92; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b=VpI1Sm5/; arc=fail smtp.client-ip=205.220.177.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="P4ikck92"; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b="VpI1Sm5/" Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5AAH8JEE005421; Mon, 10 Nov 2025 17:23:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= corp-2025-04-25; bh=OfvnTFgi9kVmRgVGvbjHzuqJeujnO9D+wFKW29D175E=; b= P4ikck92kkReA+vrtMSeWEdmTSawKwxYQm81H3R2d1id7PmDGFPJbj5Ir0MTtgSc ES99D37pPxKO86LdJDZSqOLA+mGs/WU8hgqK0m5nyV5YNJeNZLCO2+gnoxwByIkN hS5MMgHkTg5Fbuau8mI4lm7OPl2Z9F70x1iOYfEms7rdQ8YcAXjKHRLWrvFdOXCI MILECXxo5Kdoc2Xw8FNcLEZdqdQebT335FekMvLpmxfMILsQ0sJKeo5aFOn5Z8qw w4exWbBOlthpcuJ2lDtf2AOMN9XkvghPLMOkEDbDP6Ztpfr54ve2HnCCZ9ysslrt gWSFT+v8Mqo5+fPnPt/0bw== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 4abkwx82av-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 10 Nov 2025 17:23:11 +0000 (GMT) Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 5AAFp7vX007474; Mon, 10 Nov 2025 17:23:10 GMT Received: from ph8pr06cu001.outbound.protection.outlook.com (mail-westus3azon11012029.outbound.protection.outlook.com [40.107.209.29]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 4a9va8y01a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 10 Nov 2025 17:23:10 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=LEutJ+n7cFgGwrvxWa6BaChxDt8eQ7ra+BvWthNylq0c+e3eSbOgCq5XFY053Gx6gRBbKjqeJUq41wuHzPWb5Vg3Oc68R6ookQX+d1jaJXd+/TT04/C8fr7eGMZh3efv6VGk88tVxX8DsJf6oYL5iINVw1NeAYiifsmM4C2wz7U7HpKa41xXojzqTCcKQvSHWtxwxvW4uoTKV5g/2tR06qRNOGY6JvzJok4ya+NC1Bg/cly59BuOpB0CeJv/YYxbBnTvjYmaqRiim/gbA2OTFSZjhSItooDGJdZUeMUCyLoRWAzMMB4LljJZpXbkRb/KrutPVHUPOLcXsMdE/Z4iuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OfvnTFgi9kVmRgVGvbjHzuqJeujnO9D+wFKW29D175E=; b=zTevwRi4zNP4cwKaEd7WnTtLHpmxcxmE8e6NYbJNX3oownKTNyHihqGQtF6I08VsruLs2UaNNSyIdeATOvOLbZferfOhNeqTjgNF869pBYbDxswWDgcX51ttyvYMXsnRcdt88yrJiTkbLYmUKbMZdEh+ugiwxf61Rm9cuPsYeEh9BQQ8bHphER06R525Bah5kvGh2LHkbtfwU/DYXCELtKHdJdi7k/hy2Pq8ufKi4U3y36ZmbqHyWCUlBhga7QWanTS/LEWEzMqjDQc79E7wCUw5uSkCbpEKg3/x8NU/g7ypn2czxrFaxPHOLfzaKDsa5IOgE3Lq1cGyJ/CG6uj4yw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OfvnTFgi9kVmRgVGvbjHzuqJeujnO9D+wFKW29D175E=; b=VpI1Sm5/+4ZAxD8KtO3laCEVZzBGP3JMNeGivFPqXrBGbD5/HiRsIftj7YpPcBlsbUzXJzcsiZWa2e29J/XUirOC2Es2GhDy+yy2fDk5b6LGizLFy7CPHoluoDYQlJSUbK56GV2WnaBkV9Z84KIzgIbmUIOg32epxHetxWAxbe0= Received: from DM4PR10MB8218.namprd10.prod.outlook.com (2603:10b6:8:1cc::16) by BLAPR10MB5089.namprd10.prod.outlook.com (2603:10b6:208:330::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9298.9; Mon, 10 Nov 2025 17:23:06 +0000 Received: from DM4PR10MB8218.namprd10.prod.outlook.com ([fe80::2650:55cf:2816:5f2]) by DM4PR10MB8218.namprd10.prod.outlook.com ([fe80::2650:55cf:2816:5f2%7]) with mapi id 15.20.9298.010; Mon, 10 Nov 2025 17:23:06 +0000 From: Lorenzo Stoakes To: Andrew Morton Cc: David Hildenbrand , "Liam R . Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Jann Horn , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/2] mm: rename walk_page_range_mm() Date: Mon, 10 Nov 2025 17:22:57 +0000 Message-ID: X-Mailer: git-send-email 2.51.0 In-Reply-To: References: Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: LO2P265CA0235.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:b::31) To DM4PR10MB8218.namprd10.prod.outlook.com (2603:10b6:8:1cc::16) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR10MB8218:EE_|BLAPR10MB5089:EE_ X-MS-Office365-Filtering-Correlation-Id: 7d575341-af8d-462a-86e9-08de207dcfed X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?YArd/J5zAA7Gibux2BEyWERWw1RZBMjBi+Tv6vUaKx/4DeSZqOa1mMFnBHxr?= =?us-ascii?Q?Oa4FfxWFLH0vTfq8T2bmjPLYfF61xLDiL6iJN2XKq73hpILYKUAoIaxmURiO?= =?us-ascii?Q?W+n6qcuBajQNA9OueO8O7qZVffDryqJAtoYqz7AlgODcaMUo3t8nG1t5eH92?= =?us-ascii?Q?BJ4vPruu7Ri10fHSigbzDwsYl7JKe9HQxGOrOEHuJx0Wt3lQhV7nKSyU/oif?= =?us-ascii?Q?9HubMSveJt53WDu0SiZ0HuEspLhSeXcgEX+1Q+vTH4b4eyrIKlhbVIMhZQJz?= =?us-ascii?Q?HYb+LSY46cQuJk6LEbhnon94kDIY+FYyA1XqTCVrQWNd1SVHZmZSM4uRmro+?= =?us-ascii?Q?jpCKAkCy2QvJNbpgH0JoGdV35UCoT9p0MwvxJJ2fhsuwAwixbOgP9gj8MNUX?= =?us-ascii?Q?ZoyxNL19DuAMkN9Rfs3yBOI7jkJ++eoRAhxaYIBMXC7UEdgrmDhJgZiDSknk?= =?us-ascii?Q?vM5O0Itbi04Zp09vDQh9kauZf4poBfX/NEnMT8L3pOh8g4x2APMdW48Sy9Lf?= =?us-ascii?Q?Qdfb1it09ftjAkjoHJ0fC8DHmsbBtdZ9CmzjsldN/HryWRsdFAULDx4Sv2he?= =?us-ascii?Q?05cMiMSp802dT2S/qC0d4p1coJ7ZLmh7h5EdlcIcR2TMVJNlJ0Hev4/zYO/5?= =?us-ascii?Q?1TS0E1YAwQTlUj2fQHdcwdFdFnOimDANMGZ2DSlmnbqStrBCF4hXi4PfCMbS?= =?us-ascii?Q?x9O9ZQ9wGfgoXxuVAdXf6AnRX3hmnywgK5GtpuUt+eKaREz0ObKuUJaOpi18?= =?us-ascii?Q?B28D2D/FxGwLtNhvz5dVgHrYGe58tynrhqsKQENOzkssEAIRpluJVgnp+mLR?= =?us-ascii?Q?HUMjQaZ6dX26s41j6hiTg6ZHHlXGrPc3GFm1eE+rofy/JKs/xtXB//H+sCGq?= =?us-ascii?Q?UIU9PiVF2tf+CLOrOcalA/LpkbWqEIRb3fc7Mz2ZiOBdrX1O6eWZ4tWe/hfB?= =?us-ascii?Q?+NHcmmW3Oxig1+sGe2CBrZAnRqYDweQT4jz+eE8znJroHSyKyRKD0OwkjIHL?= =?us-ascii?Q?Cv1+v0E2iuH3fgGcp4kWmsSsZbz8x9dVr4spfHzpHLWKlRy1KC2WlwB2FM/R?= =?us-ascii?Q?5XsDforg+VHjMez2GgYg5B2ylaeUAk3IXC6Wz+5ECm19ONLHJGqB4UHTNroy?= =?us-ascii?Q?I04MuT1iMT/nxz+84RDS+qHkN076gicTuiwz0oT6j8h9E0KmnFzfA45xU/4F?= =?us-ascii?Q?5acdhtLZ7MsGIADKcd4wBn1K3NJqE/XVIsGgWyIqqkq7kNUfbTf5Y3qFHgb0?= =?us-ascii?Q?PwBdASDUfSUvbzymMytkb2gjrBVttZNlG+d5lzQUvHFdWyNxJ77m23+j4Uh1?= =?us-ascii?Q?AocBnLeW6ZdPLir6tXKOSyKWpoXDPbO9PzfKhF7kDtsW0RwUe/MARxQ3ocL6?= =?us-ascii?Q?ZaDJLKO8x1PfIlbga/dnoOoGCDR0NbcHTv6rGfH22kdS8nwrBQhHLVV1dZPE?= =?us-ascii?Q?vZXZsLf73zFxlbGHykQvog8W3mBz49M2?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR10MB8218.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?JF98mVGW9U3KOPN2VH4A2GhSSYil9jA1wLPKc7ViWEL6idK5V4425/fIaxuu?= =?us-ascii?Q?slLN+vawBGcVymCbQ+EnJbKbEs9f3tVJ9gKo5UeaN7dASq0fEnxUHnK6X3bh?= =?us-ascii?Q?fGurUO8u+EWbcCICVPjPSLXfrY5Rz6RUKGvUPSAktg3E7S/Ysc3zBcAkLXmd?= =?us-ascii?Q?N105zFLVnUxbVDFmuX+NVXCxDqCEKvdf9Y5Z3sQNLdN/gyEOdTME3pXjUEQa?= =?us-ascii?Q?2DSDiAcDP4q+CUTPAvkcFUYxRAUy2j0jfIz905nY4Spq4jpgRPP+yCMIGOQb?= =?us-ascii?Q?x+P7At3igm4xCgKfKSwP75uDtoNjfGzty2pNQpl+Tipnvrg/V00Vs+3vQI1Q?= =?us-ascii?Q?73YSkZqVGuyL3x0Fg5AnokBu0MkueHOtgvmc9ROXmy4FMQfw/qmXRUg8xu2Z?= =?us-ascii?Q?8rin8YWRCDnfM3pot/izXFjMiWzrmB1tP4T6OYlOeytCrbH0L4oE0b0J+0ph?= =?us-ascii?Q?1I99Ly8QWa9K70EEBiD4dCVBPtKuiBKdW1B5DGDwMVszJSC9tHAiIvi/qiuU?= =?us-ascii?Q?7lJs/wLgmHYLs/DeZUlHRX2EAfjuqMJIWZhGn+1iNzYRbl8hfywrLduQ6dDs?= =?us-ascii?Q?0F2i5qXDK4CzpGVNy4RSiJpMGteu5rVpFy20wcbB4bZnCtqAlan6HzktJP5K?= =?us-ascii?Q?VpRNsBabo2ZS9dF0uUVTT7GpyXbCcg2xCeckb7MhoTiqn30IvtKP+KXsxg5L?= =?us-ascii?Q?91XGvaP2irdSyV5QBONenHji6o8B1m1WfxoSKqeuxSrQWQfAo6bBhMZX/n6y?= =?us-ascii?Q?3IKn3XhPuLFzI8qyvniiHUAOHtsiL5l/Jqz5R3deHWQdRcOzSR0AU865lDvG?= =?us-ascii?Q?fMi6sz8dPllE0CADy7d9CqWMOk+AEGOZ4rWuxq/8YE6rsT8gxRP0dAM6YaxK?= =?us-ascii?Q?sS/VMVPGUnJhDIEBpguYUHDCn1DGkE43njBIBLsxTeODy8T19kd2LWX+gw20?= =?us-ascii?Q?Nd9guQMPt15eIhJaEiJrSQKJ8tiEkNwZq6WM40DXdjvAS7USQr2wlQLVQj4E?= =?us-ascii?Q?mxkQCPRPgnViS4QKETFcyGudQjnOBoUZ1cPRuqXcsiQagk3z9a9UcbIlEZWg?= =?us-ascii?Q?lrx/VBGvoek6IHW63TOmAHKDI+g0BHf53hSbqf5ieyKUKbcEPSvza/uoOW+A?= =?us-ascii?Q?sRzCv6d2+D0IaFzx1BIAAqRoFgTiaXimDGTKJhtX1fz2mv/HGSHsdl/Ko6PG?= =?us-ascii?Q?vLaRjZFZvf5Sxj4F9ePbhq2VHn5VueK5qV2peisDAhBxe5N46GhDJY+XBMH1?= =?us-ascii?Q?rY8ZZkUoUh6T1iUhbomS3PnhhXOdGahL7t8eBcZfMJ3TVMbIMywjx14AFRag?= =?us-ascii?Q?ue5x/s/hyBEO6ghZb+TPxEkNEfRy6o1ERZHn8GQr4IOr0UuMLxWH45ICrs1A?= =?us-ascii?Q?uvXtAeuDb3vpdVnk+c+22+z8DlEqTT5Vi/MQ/HNOeGUnSxf3NexUDlTNl0C5?= =?us-ascii?Q?694cdGdfvv9tupEU77/kapTL2OulieVAj0Fn/+rz4CJ5J0psZDExSSrEsDdO?= =?us-ascii?Q?tmJFraxMBlP+f6tgfJFJE+QD5wpXIbu5/jyR38aB0A+sofLF5p/C7dAH6XcG?= =?us-ascii?Q?HK/zbGHvrwWRJxK/KYID0VZYEPkYE3wjk/Na3FKGfGzq4FyXJZo5U2P6UPQI?= =?us-ascii?Q?zg=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: GADYWqJkdgiPKEcqzqU9OhFrEDzuFq3zAgyFe2ENkQaFQQbwqePSoTOmWDuxeNwWpf5PcaZGRUq/5v4bR6YyqZGQcLbg54uDOc+/xEW1mBNjk1Ozqqtm3eiullbRx3uAmos00uoJ1wbXwyGj8izps0KsKz5wTW87MGXTeQCYNPb7o5Gtis+3ayKV4ouoo7I8cc2bju0TnuiTMquVGLVSwJT93P/VNqyjV3Wl7UP/9i2fzLi2vAztaF8DSFKO0pdo8JAmHLX+16glBzQMfIQYDqxNjOp+iH4gSi70GGUzlJONnwwmFMIV2gbK9jwBcuPnt7UGpYzGq/I0LJfwO2kORX0ghKPcFGNWtHxyip3ewYc1uWOC3K2xXXFYVgv9vhmO/kN+aTioj9LKih13hGNUMaOwEucFogQBxRUVWd/D+joHoTtp5RwOi+GjOSJ+nbb1vdRVGkXoZoovMd2ZFhwuvzMxDqC+eotiuVe9Cdv4fMG7u0Q6/CzTbpyi//7erxmGDxWJQx6N26MCz725I6pL0fzjVG+oZfP+dQtF9zdnnKG7qhG9pcNTQ12UuLeKJSzjPKR4gYrH03OgdZF6Wfn2affi7rTv/IQ/xwAIJCyILRo= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7d575341-af8d-462a-86e9-08de207dcfed X-MS-Exchange-CrossTenant-AuthSource: DM4PR10MB8218.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2025 17:23:06.6178 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: CCzZSUb9IKrU8Zn++q88E1aXupO6T48jG+j0afeF33qxvMqrH72NofsjT8KUk8/h3AfX4kp8nkVDiHyyUP1eGMRWdCrV7urBHSItBErmtVI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB5089 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-10_06,2025-11-10_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 malwarescore=0 spamscore=0 mlxscore=0 bulkscore=0 suspectscore=0 mlxlogscore=999 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2510240000 definitions=main-2511100147 X-Authority-Analysis: v=2.4 cv=W8A1lBWk c=1 sm=1 tr=0 ts=69121f7f cx=c_pps a=XiAAW1AwiKB2Y8Wsi+sD2Q==:117 a=XiAAW1AwiKB2Y8Wsi+sD2Q==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=6UeiqGixMTsA:10 a=GoEa3M9JfhUA:10 a=VkNPw1HP01LnGYTKEx00:22 a=yPCof4ZbAAAA:8 a=SqmF7T72WtlrkcSyQF8A:9 a=cPQSjfK2_nFv0Q5t_7PE:22 X-Proofpoint-ORIG-GUID: baVfrGkzSnj_zC8tB6uU9bZgHSMfl3qG X-Proofpoint-GUID: baVfrGkzSnj_zC8tB6uU9bZgHSMfl3qG X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTEwMDE0MiBTYWx0ZWRfXy7LLS27vNe5N Q0jBR19uh7vsrjhMTNMynQCbA/ai1wr/k9PfWv3IuWdqSiJfW6Ge/umX42X9S+X4jT5zNzWT1ZD uLJCYFGW2/TFiY3Gt1Aopt5H/XQt8p4MQiJmQBOyOl27VD1OuW1/ep19yZMNtzivoybPNxDZyBL CF0WuJmTd63PZ6tl4f8rj8RIRk2PUtOD4WEvDHld7CdbgY9cQ+2xOCG0Ixfx9Vm36dIpCqJQyVV 04kfNbC5ifivbmg9vQX6qTynMTekHN5OvV8kaemqICKy6cDVi1tziRpAzAS5mwYnmyXPuKZuyfi 8uNc9NXVB4krt6fmYtegSubl/md8rMVKiX4IY5oaCqb2lrCDbqR0vhESMHVse3PIZOcGq/me/h/ ugRVPOnTwy2LlQUnXpMSud7HQERVWg== Content-Type: text/plain; charset="utf-8" Make it clear we're referencing an unsafe variant of this function explicitly. This is laying the foundation for exposing more such functions and maintaining a consistent naming scheme. As a part of this change, rename check_ops_valid() to check_ops_safe() for consistency. Signed-off-by: Lorenzo Stoakes Acked-by: David Hildenbrand (Red Hat) Reviewed-by: Davidlohr Bueso Reviewed-by: Vlastimil Babka --- mm/internal.h | 2 +- mm/madvise.c | 4 ++-- mm/pagewalk.c | 22 +++++++++++----------- 3 files changed, 14 insertions(+), 14 deletions(-) diff --git a/mm/internal.h b/mm/internal.h index 0af87f6c2889..479234b39394 100644 --- a/mm/internal.h +++ b/mm/internal.h @@ -1652,7 +1652,7 @@ static inline void accept_page(struct page *page) #endif /* CONFIG_UNACCEPTED_MEMORY */ =20 /* pagewalk.c */ -int walk_page_range_mm(struct mm_struct *mm, unsigned long start, +int walk_page_range_mm_unsafe(struct mm_struct *mm, unsigned long start, unsigned long end, const struct mm_walk_ops *ops, void *private); int walk_page_range_debug(struct mm_struct *mm, unsigned long start, diff --git a/mm/madvise.c b/mm/madvise.c index de918b107cfc..7b938ff44be2 100644 --- a/mm/madvise.c +++ b/mm/madvise.c @@ -1171,8 +1171,8 @@ static long madvise_guard_install(struct madvise_beha= vior *madv_behavior) unsigned long nr_pages =3D 0; =20 /* Returns < 0 on error, =3D=3D 0 if success, > 0 if zap needed. */ - err =3D walk_page_range_mm(vma->vm_mm, range->start, range->end, - &guard_install_walk_ops, &nr_pages); + err =3D walk_page_range_mm_unsafe(vma->vm_mm, range->start, + range->end, &guard_install_walk_ops, &nr_pages); if (err < 0) return err; =20 diff --git a/mm/pagewalk.c b/mm/pagewalk.c index 6cace2c8814a..ab29b16abd2c 100644 --- a/mm/pagewalk.c +++ b/mm/pagewalk.c @@ -452,7 +452,7 @@ static inline void process_vma_walk_lock(struct vm_area= _struct *vma, * We usually restrict the ability to install PTEs, but this functionality= is * available to internal memory management code and provided in mm/interna= l.h. */ -int walk_page_range_mm(struct mm_struct *mm, unsigned long start, +int walk_page_range_mm_unsafe(struct mm_struct *mm, unsigned long start, unsigned long end, const struct mm_walk_ops *ops, void *private) { @@ -518,10 +518,10 @@ int walk_page_range_mm(struct mm_struct *mm, unsigned= long start, * This check is performed on all functions which are parameterised by walk * operations and exposed in include/linux/pagewalk.h. * - * Internal memory management code can use the walk_page_range_mm() functi= on to - * be able to use all page walking operations. + * Internal memory management code can use *_unsafe() functions to be able= to + * use all page walking operations. */ -static bool check_ops_valid(const struct mm_walk_ops *ops) +static bool check_ops_safe(const struct mm_walk_ops *ops) { /* * The installation of PTEs is solely under the control of memory @@ -579,10 +579,10 @@ int walk_page_range(struct mm_struct *mm, unsigned lo= ng start, unsigned long end, const struct mm_walk_ops *ops, void *private) { - if (!check_ops_valid(ops)) + if (!check_ops_safe(ops)) return -EINVAL; =20 - return walk_page_range_mm(mm, start, end, ops, private); + return walk_page_range_mm_unsafe(mm, start, end, ops, private); } =20 /** @@ -639,7 +639,7 @@ int walk_kernel_page_table_range_lockless(unsigned long= start, unsigned long end =20 if (start >=3D end) return -EINVAL; - if (!check_ops_valid(ops)) + if (!check_ops_safe(ops)) return -EINVAL; =20 return walk_pgd_range(start, end, &walk); @@ -678,7 +678,7 @@ int walk_page_range_debug(struct mm_struct *mm, unsigne= d long start, pgd, private); if (start >=3D end || !walk.mm) return -EINVAL; - if (!check_ops_valid(ops)) + if (!check_ops_safe(ops)) return -EINVAL; =20 /* @@ -709,7 +709,7 @@ int walk_page_range_vma(struct vm_area_struct *vma, uns= igned long start, return -EINVAL; if (start < vma->vm_start || end > vma->vm_end) return -EINVAL; - if (!check_ops_valid(ops)) + if (!check_ops_safe(ops)) return -EINVAL; =20 process_mm_walk_lock(walk.mm, ops->walk_lock); @@ -729,7 +729,7 @@ int walk_page_vma(struct vm_area_struct *vma, const str= uct mm_walk_ops *ops, =20 if (!walk.mm) return -EINVAL; - if (!check_ops_valid(ops)) + if (!check_ops_safe(ops)) return -EINVAL; =20 process_mm_walk_lock(walk.mm, ops->walk_lock); @@ -780,7 +780,7 @@ int walk_page_mapping(struct address_space *mapping, pg= off_t first_index, unsigned long start_addr, end_addr; int err =3D 0; =20 - if (!check_ops_valid(ops)) + if (!check_ops_safe(ops)) return -EINVAL; =20 lockdep_assert_held(&mapping->i_mmap_rwsem); --=20 2.51.0 From nobody Sun Feb 8 04:15:25 2026 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B6BE92BE7A6 for ; Mon, 10 Nov 2025 17:23:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=205.220.165.32 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762795408; cv=fail; b=GEJKamXPD93ANSawhdth1YTdistmpP1qiv9P5xsvIQr5UvRFA6E8sMW0XR0gO1RjfIGdvFH7HdinIMv234OeTaHhgd/cEmaC6ZeOcSw3XheDe6I0o+AQ/gKQtPvFMKJjy3br5MXA994i7oBNu6ea5DCpqZ7BmQsEAeo3XBltElI= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762795408; c=relaxed/simple; bh=4NfkD9dmYTsGNOQcjNksV3/t/RxaGCbbxCjR4Lzm3O0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=s4ZzPuA5GJq2CqrkZBeJ3TayeHyTN8m6N2YGMVZR6mz0Q9LTy4W7dU+Dh19osEgGTUJUjhuCeZ1riQL7TC6rKwqHKiLoPRCYgLdNLoyNOlCgghUxRVYaHFvIHLELnQsN9RX1XFpdsKbiGkRFWF6+8BpI+tOt51mMiNq4bB378UY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=l4MLg4kS; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b=htnhrsWU; arc=fail smtp.client-ip=205.220.165.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="l4MLg4kS"; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b="htnhrsWU" Received: from pps.filterd (m0333521.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5AAHKQ57032398; Mon, 10 Nov 2025 17:23:13 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= corp-2025-04-25; bh=MZxT7gE+nU4hJlXvC3qdT6m5HHnar8eu/B72opiAEKQ=; b= l4MLg4kStaJcAYzYw8xbSWChpq8rMzRYfRYwdFSVvKkrRmxteX0zDZW34rU1IzPc eZLc+Cg0gbY9WX6v8lOjLXYUd688iBXwLUDkBXUogoH2DoEOUPKCqGB9ihCyrxO0 g/71E9g5rJk8w/ZkaCbN6PIVw0O+ZS/yvVTdk0q9aEVTqIKhpmqIl9PCLF+5bVmj IEaozKJuGvr6eM6vSeWlbWIAoz7E11pyMWi5RvSscr6u1HD3Llgv1DlbYdad+Jon UfkSf4KL/mxZw+qfLpg1yts8vRl9T0s1nFnBdaMqkO+ZjgPH6STeksTVDmyZMjbW XW3yBtoT3bHZQS3dxbHzDA== Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.appoci.oracle.com [138.1.37.129]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 4abks7g3um-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 10 Nov 2025 17:23:13 +0000 (GMT) Received: from pps.filterd (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 5AAFn66c040197; Mon, 10 Nov 2025 17:23:12 GMT Received: from ph8pr06cu001.outbound.protection.outlook.com (mail-westus3azon11012070.outbound.protection.outlook.com [40.107.209.70]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 4a9va8eg9h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 10 Nov 2025 17:23:12 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Rsw6qcXL9HADEbbqCzRnMlN5qBJpI2fX+uqFLo/mlSkko+nb25Fe1oxYYdTtliyci/dqgsgf2setLfA7fkIw2qt7/aZ4YpJ9kYIUHQzQOskI2Xjkkhhv8qYYGAR4rKuZ1m2NknQmXPVSv1/joCERxlTfzbpk8Wtokfdh64DK/JDgCGzmL54FsFnIcVMopFjVsjBxJGjNous1Tv8ZeTpvUFv58ZHmdipQ8AhQWpHGUCEwJA+iMzShzkhVfAZyeCU8o3N0e6T168hr8zuTtXQYSFok2Ho7hvwzJhBEpm695cmOGjRf3Z0/KvH4PNl5Zuf+hRimawM3FPobiEWCjq/Izg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MZxT7gE+nU4hJlXvC3qdT6m5HHnar8eu/B72opiAEKQ=; b=nOKIOHY14AHsLYvtDkf9Qiagtl6E9hS/rsNB9lXqlLdTeOFADtfldcTzh//xZViK+wlT56JmpSE2q4bsE0jKUhFdH2tbAGojZ/q350KewS9BqbWkqUZ6c3WbxA4IRIErfN9fojbf3YrcovtctyYUG6HzvDqZVEyx0iulcszOP69ZXaZHVXwA95hTq0jGsESsAIaJPYvdxjuI4t604orGw+tP2zZFsi+Fcjb7Ivh7aqItgULXi14nKV90b6eBsYrgYTdW1no+mcRggI941He8CUImBYKFiGuCKhY9raAUpu2JqA/VMV3IqPV3o6sy67Fjc2sV7WkpFYaHHBKzgdUliQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MZxT7gE+nU4hJlXvC3qdT6m5HHnar8eu/B72opiAEKQ=; b=htnhrsWULv8WgZutUKjxZzHCn8xGPeP+/EU2XO6tsSiWjyBAb2+3s8XE6xWXVMnp9PDOxeSd1PtI5L5uyJ/vJRNZ8I+xCO+LthTWHK4AK56lNBcuXo1qo1F14lSp+ul41ngrkVdN0xdmgaSU9j8VPCPTxBf0C0rOsvRrj++kZ64= Received: from DM4PR10MB8218.namprd10.prod.outlook.com (2603:10b6:8:1cc::16) by BLAPR10MB5089.namprd10.prod.outlook.com (2603:10b6:208:330::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9298.9; Mon, 10 Nov 2025 17:23:08 +0000 Received: from DM4PR10MB8218.namprd10.prod.outlook.com ([fe80::2650:55cf:2816:5f2]) by DM4PR10MB8218.namprd10.prod.outlook.com ([fe80::2650:55cf:2816:5f2%7]) with mapi id 15.20.9298.010; Mon, 10 Nov 2025 17:23:08 +0000 From: Lorenzo Stoakes To: Andrew Morton Cc: David Hildenbrand , "Liam R . Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Jann Horn , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 2/2] mm/madvise: allow guard page install/remove under VMA lock Date: Mon, 10 Nov 2025 17:22:58 +0000 Message-ID: X-Mailer: git-send-email 2.51.0 In-Reply-To: References: Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: LO4P123CA0597.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:295::14) To DM4PR10MB8218.namprd10.prod.outlook.com (2603:10b6:8:1cc::16) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR10MB8218:EE_|BLAPR10MB5089:EE_ X-MS-Office365-Filtering-Correlation-Id: 4216e467-8a5b-4f7e-393b-08de207dd146 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?opyBgcnin+zAETJK6NVvZ0zoijcjsBxg7vLoj4yDcFBlGFc2D1R1drUojINN?= =?us-ascii?Q?WlEoCHWqDHb/IQEi+n+r5ULlD855rNYmHTENxidQ+BmASE6uJ/pN1+oHjScV?= =?us-ascii?Q?a0zFquyOO0Kh2dA5AIZsQ5ZMUlQl7lbAQYEMJQ2Gzu1r8r8wxdsndwuAwhf3?= =?us-ascii?Q?lcvvd9aH1xOzFVZ1TV9HRPLljI3w5bBGOMcr/scWfkjNGeB6JA1Awi9crn4a?= =?us-ascii?Q?HI7a3ci6mJEkfs3ep+vxDZGWUxOhQuc7bNiUO9HP/FLQwUbT/vgjR3BbL77D?= =?us-ascii?Q?NkH96vvYZsBdDJ+7shAkXzafl8RDJPBZBuENMOFXoJF2UMd74iv/VVVZRpzH?= =?us-ascii?Q?OErKXaRuX47vtUBm2E4DLQVWTK3nr11aLwFBV7UBft/l/sn1MCfQ3h9XaBey?= =?us-ascii?Q?GNZW9vC7u5zgXWgcbsGXsSQA1PetEE2YpeU2FVuIGMHOYq+ZDxnJQspy3rGa?= =?us-ascii?Q?oxfkCm5L+OF4u2Z3hKR26xegJdvfNgVCtt/2m4RPGu1mnr6wxb6hQICBYNMW?= =?us-ascii?Q?IpwOttKWtnBEpseNctcAezuLZlGgcMdqZ4qQ8jyjMFi1GUFLT9Zwn8/08yro?= =?us-ascii?Q?0i/RGB6MqwNxkI+AWHBbFJ+iLtLLl4pEkix/TESY2nTPR+xBF/JuqmhyvI/M?= =?us-ascii?Q?dtmiMaRaf2MVg00gUoqg6NgZPgXZQgrDqgzA5tLP5t+wOpRrIjfUSULdK5bN?= =?us-ascii?Q?46Vv/Qt/Mflj9c7i5PMIkbwTPgEx/nbGNhEErY19YRUfkvWTs8NrqJ2+SFkW?= =?us-ascii?Q?fGvLl48HoLZIAvZW3AHXM1fxlnthkTpAXS75k4+6ndI1nNWgKH/jOz/rIM1C?= =?us-ascii?Q?KLmLVnOTvhsiyEEqlzxAzbKDU6GHHEiMssXEVP/UEai5iwoG+Iz6i90xk+0s?= =?us-ascii?Q?EJT88KbZujAAXScqXr6/miiuBsJVGNWKWL0HkNtVvb5Wqq+3c9lGBqQRbXEX?= =?us-ascii?Q?DpIPoJHx4j2zwC3yGeFCHcFQqiDn+y36rn9y5Ykj3QutLlfmesr6Z8aSGecU?= =?us-ascii?Q?p3CkGGN6i8mp1XAuadXQHmb5RqQ9AtWbhssP7iyMfZPDbLe8CCE3MCSrVTqn?= =?us-ascii?Q?X2A3/Rhz1uKOUZSxCAudJj4iU62pPeFuPdoAVw2NHlnsJjA5YI0sbqqYMfPH?= =?us-ascii?Q?bywFXG7Aki2f2uNOucjztFbW5mGUJihsIyPXMfBw/BNeC8gOmvO5ZuiysdC9?= =?us-ascii?Q?lLFvk6q7lnlDJBr5cXbAFVYqr06C2GG9C/OdzpsXFtP8Y/lUJdH+V+uL+XX1?= =?us-ascii?Q?mk9aAfR5zqdmT6PW1jdCeBBRNs2RXZBlrRWLxCnkae+ROqdwKwMlW56TodPZ?= =?us-ascii?Q?YveJieVBkd92M6iiUtwwlribFQNRseVGQmDgOzi01DWsMQmd+4krj6jWRMNW?= =?us-ascii?Q?/vyGTw5s87aBWEVU/xMLc7bT2zBkmO/ZeXDFfJ6m9T0CfBkvIdFFHXZnq8qP?= =?us-ascii?Q?77CGjxbSgUWS4/zX5Lk1Reggd8/BjPME?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR10MB8218.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?802ohsG2Cz3GuTxzRNrldfcCp2qwCBue1hbt4cG07WwcGkQVAJRliM89fDAN?= =?us-ascii?Q?OiDEVL0vSl/IRRpeaYibv+EnjzeqTmiR7cjF2KY1W/1iG9cROVTXnRhX5qEa?= =?us-ascii?Q?8uCehDwYn3Be4BVH5Hmcs7w/m/LYIc8ybQ7TSdY+1+QSLdss8ZyGRefyfz/3?= =?us-ascii?Q?yA2YHAZfiyPg+vuE6qtCCUTeymX2YV4x7fxZ0em1hI6t3siZ/CsTkl5DXynv?= =?us-ascii?Q?rljgwJw5uxgLKAipjWjrYuRVmf0WKpSfNHZ+XFBqbW8WEwr/uk8LPEqUYzQd?= =?us-ascii?Q?X5nFpS1RVDVRg8KPn66XGzv7vRbdjG+LANTaUEgklZj/UUYoQ5uNR7wyVGVR?= =?us-ascii?Q?NpVNoEl2P43GO2dPjjf1Ony60PHYOyD8M98BrwYqp7NNRU+oYNWtTich4Nqo?= =?us-ascii?Q?1WsBJYYeyT9MRJXr4MKToGrDyxSP65rE2GLz/2R+wOxWjPJCuupOFKt7wu8R?= =?us-ascii?Q?t17TFbZl1F0Ej4aO9EcnsKPt82y7A0IvcL8y/7fK5cZCz0LVCr57nqjEhARg?= =?us-ascii?Q?st72bvD+CzSSD9UQPXn58Y5GSq+WLqM4ClzJYrOpJLNyRkFoY2N5ZuHVH35E?= =?us-ascii?Q?A8YH1B9C4F3OGK8pqbQd5g9O8TVDHGmBUrcxW/T2rY8mVIcfrNt9phim6QJd?= =?us-ascii?Q?KwhOkkrnPdwE4dKYt+PlRhSioqo8xAldpIAAAz/uSMOVJd81mH7iSqf2Kj+T?= =?us-ascii?Q?MaOE4hybLP39FQGzwxLLf9NL35w+RBAR+ghmcZz7+tCFOGMibXYYAuIYKuXd?= =?us-ascii?Q?qAapcu0ZaBP+S9RiVFM4FynLAf1z8luNwjCkts+jpPh4o6PZbDNFfv7I7qMX?= =?us-ascii?Q?A38QwGAkKiD/4E/O0Dhfjg22c0rDJ7p0oBsOaa9uCPmxAF/8V8oFfNklGlcL?= =?us-ascii?Q?zdMXrr6fgvx7NWxDjlx0diMmVAcgC4LhcAzII4IllRs2lGTga1/w45tQ4+QE?= =?us-ascii?Q?hKR4hszyOr63Oe8h1oHdd7/iD6S9a/Uq7dU3WPeSv3FrS0iCELdGk1mifFr4?= =?us-ascii?Q?Nwl12PNmHD9HY28axaK82AF2n/Jdq+zRzHmXTKOI3hvwtUYomeNjQN3yRIN2?= =?us-ascii?Q?QahpQNHTyfJ4RTXtlv91S3zxPE5hapFbAitSB75rVsRL+VbqgxzSzgBkXxXA?= =?us-ascii?Q?fuJhi4Fkp0vBeRt+z2rfkcYidhMmSfmgnrBp/8grMNC82PhveFByGBXk9f3M?= =?us-ascii?Q?OBDtTgtozpyHBsoo7Z2K36BhveyxN0DNrGOQ/koH8em8JAhLZmTEViGcDKiu?= =?us-ascii?Q?tjf8BSfXUokzzs8QTLumOzvx281hqtdpsGLn/De5pJ1bwnTIN0s+jm/UOaNo?= =?us-ascii?Q?eTvAx330z2I+87mLEZ5SMTsd1s1x+YYpzNoIvsDZmjXisPHwwZ3KlGs0xdzZ?= =?us-ascii?Q?ykMJkzmjaiHZZkHwkLi8VcncTXPy+/df3eZ8twWnXJu1dxmxlYxRbD/wynIC?= =?us-ascii?Q?XzSUNsXh2P82fRK3o+CHGfRxfizuK1TOFogw5o/12dI8KomS7Hzg7jY8G1xN?= =?us-ascii?Q?+l8H3LLm3Kc4Eyg7qFtkhTnOFwqSgYTsEICgMhnaERMYGp1ABEveuvF8/P2I?= =?us-ascii?Q?eyGgClogyQLBp8JePSecVbQWoBLdZc/LrDJNJgLzjqoNti8CHYJXIoygPTLd?= =?us-ascii?Q?4w=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 4Xi5F3t4mfE7Dca88vlSNLik6sJH26aet6aKdROmErE7QhEy7r5wqb+E/LNFesamG4KYb47DhUQFjzUZk6OuypQYei0a1VDJffjZ/udTcXOAo5uonExOLOkd1+lsxt5sqLNkuT+X+afKkPYrV6KFegpkrsWl6npk6D9TAApT5U8qr81zEL7ix476bjUtMS4FrmEmB6Ko5Mw7CWxC0dtzeqiP0MUoTalY2owdrmqK4CfGBXHR9dE+R1O+/6ZwQOZ+nQIer0LWsCZApAHZoN/M+prDr9eeqDimSCkOYPmZUM4uwuyNHS0VK/trFuzZGoewgGml1mGcRh+LkEedTvt0MbSY3m/7LPoyKtHoacX1NXLb0nUnjHVHR5uhMRGhGfpE8ZKwA/vOtgwe3rvUf1pDerMFkOgUpN8mVGGAGG5vthmSffcieCNdf+LtHshQJvXxA8wa6w1wCO+VljzeRqn9jI6Imv4KbEXtPsquoWP0lAZWfUkz3ryHU6puMAtIPXc7PUTje7oUaL/tV4frhS/5kpmJgpHbw8AlRuQuT+uXgXG5qjcZRARMNAbM7jGd0DCz5YrlR5+4Lc1X6N7GTF9wn3m3qVmgWBDWEhy1qcPb/X4= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4216e467-8a5b-4f7e-393b-08de207dd146 X-MS-Exchange-CrossTenant-AuthSource: DM4PR10MB8218.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2025 17:23:08.8754 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0YfAf6Hwh01AM7SHVhQWesZAWcUQpWdkE834aiPkSoQxdlNNzYP1Z/BphgAJ06TTkOCio0hdJFVlc/yxSQExVcWKjFClHriGKUQpzqEIQr8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB5089 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-10_06,2025-11-10_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 mlxscore=0 phishscore=0 mlxlogscore=999 spamscore=0 suspectscore=0 bulkscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2510240000 definitions=main-2511100147 X-Proofpoint-GUID: E-zrNWCmjy-N8mGJ7SkcTOMNb1nu7Fkz X-Authority-Analysis: v=2.4 cv=L7cQguT8 c=1 sm=1 tr=0 ts=69121f81 b=1 cx=c_pps a=WeWmnZmh0fydH62SvGsd2A==:117 a=WeWmnZmh0fydH62SvGsd2A==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=6UeiqGixMTsA:10 a=GoEa3M9JfhUA:10 a=VkNPw1HP01LnGYTKEx00:22 a=yPCof4ZbAAAA:8 a=Wu5hNObr_TVTc6B2G3wA:9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTEwMDE0MSBTYWx0ZWRfXzMaGdxqnqf+p oFYRA6+VweQ65jgsD0GqSeFniv0mMMk4nffdqvzu9KzdYN6o59p6B1oreJKUHjrSFF9bufP62zs uZ2+HsnlSW2tLjymewNyg0yQC018UQS1bDGV2NCyY0F053Jv+9Yu+qcHyM9TGzoc+OlzSSGp0cu G3v4EzW6L/mwPMb0KxcfnpOx9HpdgXfc7Efyizv0U1gLZVIXdsYlRQSRFfIU1zsJ+l+AsOsLv5Z NGE3SqfL5PEYnGUVDShaGBicGhpGY9vjol1hxB/AS3nYa92uyAovhTq6ienqKYUJYCTDa+2GPvy H/actY8B8Nd9AfImta5/JcRDmpoPJIA88+U9GNqG/6O1dM5nGRS3jdHBkWa44xk3IzoDZ7XGtVn 7NztOG4aVVxcCGaR1aOcCygYqqWJvg== X-Proofpoint-ORIG-GUID: E-zrNWCmjy-N8mGJ7SkcTOMNb1nu7Fkz Content-Type: text/plain; charset="utf-8" We only need to keep the page table stable so we can perform this operation under the VMA lock. PTE installation is stabilised via the PTE lock. One caveat is that, if we prepare vma->anon_vma we must hold the mmap read lock. We can account for this by adapting the VMA locking logic to explicitly check for this case and prevent a VMA lock from being acquired should it be the case. This check is safe, as while we might be raced on anon_vma installation, this would simply make the check conservative, there's no way for us to see an anon_vma and then for it to be cleared, as doing so requires the mmap/VMA write lock. We abstract the VMA lock validity logic to is_vma_lock_sufficient() for this purpose, and add prepares_anon_vma() to abstract the anon_vma logic. In order to do this we need to have a way of installing page tables explicitly for an identified VMA, so we export walk_page_range_vma() in an unsafe variant - walk_page_range_vma_unsafe() and use this should the VMA read lock be taken. We additionally update the comments in madvise_guard_install() to more accurately reflect the cases in which the logic may be reattempted, specifically THP huge pages being present. Signed-off-by: Lorenzo Stoakes Acked-by: David Hildenbrand (Red Hat) Reviewed-by: Davidlohr Bueso Reviewed-by: Vlastimil Babka --- mm/internal.h | 3 ++ mm/madvise.c | 110 ++++++++++++++++++++++++++++++++++++-------------- mm/pagewalk.c | 17 +++++--- 3 files changed, 94 insertions(+), 36 deletions(-) diff --git a/mm/internal.h b/mm/internal.h index 479234b39394..3702fe4a4bac 100644 --- a/mm/internal.h +++ b/mm/internal.h @@ -1655,6 +1655,9 @@ static inline void accept_page(struct page *page) int walk_page_range_mm_unsafe(struct mm_struct *mm, unsigned long start, unsigned long end, const struct mm_walk_ops *ops, void *private); +int walk_page_range_vma_unsafe(struct vm_area_struct *vma, unsigned long s= tart, + unsigned long end, const struct mm_walk_ops *ops, + void *private); int walk_page_range_debug(struct mm_struct *mm, unsigned long start, unsigned long end, const struct mm_walk_ops *ops, pgd_t *pgd, void *private); diff --git a/mm/madvise.c b/mm/madvise.c index 7b938ff44be2..8bf885b00ff8 100644 --- a/mm/madvise.c +++ b/mm/madvise.c @@ -1120,18 +1120,17 @@ static int guard_install_set_pte(unsigned long addr= , unsigned long next, return 0; } =20 -static const struct mm_walk_ops guard_install_walk_ops =3D { - .pud_entry =3D guard_install_pud_entry, - .pmd_entry =3D guard_install_pmd_entry, - .pte_entry =3D guard_install_pte_entry, - .install_pte =3D guard_install_set_pte, - .walk_lock =3D PGWALK_RDLOCK, -}; - static long madvise_guard_install(struct madvise_behavior *madv_behavior) { struct vm_area_struct *vma =3D madv_behavior->vma; struct madvise_behavior_range *range =3D &madv_behavior->range; + struct mm_walk_ops walk_ops =3D { + .pud_entry =3D guard_install_pud_entry, + .pmd_entry =3D guard_install_pmd_entry, + .pte_entry =3D guard_install_pte_entry, + .install_pte =3D guard_install_set_pte, + .walk_lock =3D get_walk_lock(madv_behavior->lock_mode), + }; long err; int i; =20 @@ -1148,8 +1147,14 @@ static long madvise_guard_install(struct madvise_beh= avior *madv_behavior) /* * If anonymous and we are establishing page tables the VMA ought to * have an anon_vma associated with it. + * + * We will hold an mmap read lock if this is necessary, this is checked + * as part of the VMA lock logic. */ if (vma_is_anonymous(vma)) { + VM_WARN_ON_ONCE(!vma->anon_vma && + madv_behavior->lock_mode !=3D MADVISE_MMAP_READ_LOCK); + err =3D anon_vma_prepare(vma); if (err) return err; @@ -1157,12 +1162,14 @@ static long madvise_guard_install(struct madvise_be= havior *madv_behavior) =20 /* * Optimistically try to install the guard marker pages first. If any - * non-guard pages are encountered, give up and zap the range before - * trying again. + * non-guard pages or THP huge pages are encountered, give up and zap + * the range before trying again. * * We try a few times before giving up and releasing back to userland to - * loop around, releasing locks in the process to avoid contention. This - * would only happen if there was a great many racing page faults. + * loop around, releasing locks in the process to avoid contention. + * + * This would only happen due to races with e.g. page faults or + * khugepaged. * * In most cases we should simply install the guard markers immediately * with no zap or looping. @@ -1171,8 +1178,13 @@ static long madvise_guard_install(struct madvise_beh= avior *madv_behavior) unsigned long nr_pages =3D 0; =20 /* Returns < 0 on error, =3D=3D 0 if success, > 0 if zap needed. */ - err =3D walk_page_range_mm_unsafe(vma->vm_mm, range->start, - range->end, &guard_install_walk_ops, &nr_pages); + if (madv_behavior->lock_mode =3D=3D MADVISE_VMA_READ_LOCK) + err =3D walk_page_range_vma_unsafe(madv_behavior->vma, + range->start, range->end, &walk_ops, + &nr_pages); + else + err =3D walk_page_range_mm_unsafe(vma->vm_mm, range->start, + range->end, &walk_ops, &nr_pages); if (err < 0) return err; =20 @@ -1193,8 +1205,7 @@ static long madvise_guard_install(struct madvise_beha= vior *madv_behavior) } =20 /* - * We were unable to install the guard pages due to being raced by page - * faults. This should not happen ordinarily. We return to userspace and + * We were unable to install the guard pages, return to userspace and * immediately retry, relieving lock contention. */ return restart_syscall(); @@ -1238,17 +1249,16 @@ static int guard_remove_pte_entry(pte_t *pte, unsig= ned long addr, return 0; } =20 -static const struct mm_walk_ops guard_remove_walk_ops =3D { - .pud_entry =3D guard_remove_pud_entry, - .pmd_entry =3D guard_remove_pmd_entry, - .pte_entry =3D guard_remove_pte_entry, - .walk_lock =3D PGWALK_RDLOCK, -}; - static long madvise_guard_remove(struct madvise_behavior *madv_behavior) { struct vm_area_struct *vma =3D madv_behavior->vma; struct madvise_behavior_range *range =3D &madv_behavior->range; + struct mm_walk_ops wallk_ops =3D { + .pud_entry =3D guard_remove_pud_entry, + .pmd_entry =3D guard_remove_pmd_entry, + .pte_entry =3D guard_remove_pte_entry, + .walk_lock =3D get_walk_lock(madv_behavior->lock_mode), + }; =20 /* * We're ok with removing guards in mlock()'d ranges, as this is a @@ -1258,7 +1268,7 @@ static long madvise_guard_remove(struct madvise_behav= ior *madv_behavior) return -EINVAL; =20 return walk_page_range_vma(vma, range->start, range->end, - &guard_remove_walk_ops, NULL); + &wallk_ops, NULL); } =20 #ifdef CONFIG_64BIT @@ -1571,6 +1581,47 @@ static bool process_madvise_remote_valid(int behavio= r) } } =20 +/* Does this operation invoke anon_vma_prepare()? */ +static bool prepares_anon_vma(int behavior) +{ + switch (behavior) { + case MADV_GUARD_INSTALL: + return true; + default: + return false; + } +} + +/* + * We have acquired a VMA read lock, is the VMA valid to be madvise'd unde= r VMA + * read lock only now we have a VMA to examine? + */ +static bool is_vma_lock_sufficient(struct vm_area_struct *vma, + struct madvise_behavior *madv_behavior) +{ + /* Must span only a single VMA.*/ + if (madv_behavior->range.end > vma->vm_end) + return false; + /* Remote processes unsupported. */ + if (current->mm !=3D vma->vm_mm) + return false; + /* Userfaultfd unsupported. */ + if (userfaultfd_armed(vma)) + return false; + /* + * anon_vma_prepare() explicitly requires an mmap lock for + * serialisation, so we cannot use a VMA lock in this case. + * + * Note we might race with anon_vma being set, however this makes this + * check overly paranoid which is safe. + */ + if (vma_is_anonymous(vma) && + prepares_anon_vma(madv_behavior->behavior) && !vma->anon_vma) + return false; + + return true; +} + /* * Try to acquire a VMA read lock if possible. * @@ -1592,15 +1643,12 @@ static bool try_vma_read_lock(struct madvise_behavi= or *madv_behavior) vma =3D lock_vma_under_rcu(mm, madv_behavior->range.start); if (!vma) goto take_mmap_read_lock; - /* - * Must span only a single VMA; uffd and remote processes are - * unsupported. - */ - if (madv_behavior->range.end > vma->vm_end || current->mm !=3D mm || - userfaultfd_armed(vma)) { + + if (!is_vma_lock_sufficient(vma, madv_behavior)) { vma_end_read(vma); goto take_mmap_read_lock; } + madv_behavior->vma =3D vma; return true; =20 @@ -1713,9 +1761,9 @@ static enum madvise_lock_mode get_lock_mode(struct ma= dvise_behavior *madv_behavi case MADV_POPULATE_READ: case MADV_POPULATE_WRITE: case MADV_COLLAPSE: + return MADVISE_MMAP_READ_LOCK; case MADV_GUARD_INSTALL: case MADV_GUARD_REMOVE: - return MADVISE_MMAP_READ_LOCK; case MADV_DONTNEED: case MADV_DONTNEED_LOCKED: case MADV_FREE: diff --git a/mm/pagewalk.c b/mm/pagewalk.c index ab29b16abd2c..9ddb10359fa9 100644 --- a/mm/pagewalk.c +++ b/mm/pagewalk.c @@ -694,9 +694,8 @@ int walk_page_range_debug(struct mm_struct *mm, unsigne= d long start, return walk_pgd_range(start, end, &walk); } =20 -int walk_page_range_vma(struct vm_area_struct *vma, unsigned long start, - unsigned long end, const struct mm_walk_ops *ops, - void *private) +int walk_page_range_vma_unsafe(struct vm_area_struct *vma, unsigned long s= tart, + unsigned long end, const struct mm_walk_ops *ops, void *private) { struct mm_walk walk =3D { .ops =3D ops, @@ -709,14 +708,22 @@ int walk_page_range_vma(struct vm_area_struct *vma, u= nsigned long start, return -EINVAL; if (start < vma->vm_start || end > vma->vm_end) return -EINVAL; - if (!check_ops_safe(ops)) - return -EINVAL; =20 process_mm_walk_lock(walk.mm, ops->walk_lock); process_vma_walk_lock(vma, ops->walk_lock); return __walk_page_range(start, end, &walk); } =20 +int walk_page_range_vma(struct vm_area_struct *vma, unsigned long start, + unsigned long end, const struct mm_walk_ops *ops, + void *private) +{ + if (!check_ops_safe(ops)) + return -EINVAL; + + return walk_page_range_vma_unsafe(vma, start, end, ops, private); +} + int walk_page_vma(struct vm_area_struct *vma, const struct mm_walk_ops *op= s, void *private) { --=20 2.51.0