From nobody Fri Dec 19 21:45:34 2025 Received: from sgoci-sdnproxy-4.icoremail.net (sgoci-sdnproxy-4.icoremail.net [129.150.39.64]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 20F1023183A; Sat, 8 Nov 2025 12:40:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=129.150.39.64 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762605653; cv=none; b=mL+e0vwKbLq66wBEH53ehsz1QOmaGE3fVWZKIjGTI75Nfo1N7sEmKDTqvA7lXIkrhkxwxjYeQv6pnQeTsUilEITRfO8r9VPDJV065YucJx1FCEinmTFS1zOa2uKL1F2CJVLAG0BBhB2N68DgmdB4fZ7XbE5W0+boOelouEpPeuM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762605653; c=relaxed/simple; bh=2rw+rkdj3yN6rzvCs3IaZNjqc7yQs7hTgHGNs4Cd4Jg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=WsjaMvWH+q0RvvR0WOIgIUd7l2Gph4+/2IPYj4RVC4yGYW5wRp5NtGKbBMwoAFwLhw9An5fvZgIN9umAAEaho49WcUJmmIcteVWfn2QSDNVluQDL6hRttwiLgjL+JBptJoFtk7i22ujPBNRsu8Wb8a/FtNIf2Cd10L4NUMPUwxs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=zju.edu.cn; spf=pass smtp.mailfrom=zju.edu.cn; arc=none smtp.client-ip=129.150.39.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=zju.edu.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=zju.edu.cn Received: from zju.edu.cn (unknown [218.12.19.144]) by mtasvr (Coremail) with SMTP id _____wBnt7A0Og9pzl92Aw--.10193S3; Sat, 08 Nov 2025 20:40:20 +0800 (CST) Received: from ubuntu.localdomain (unknown [218.12.19.144]) by mail-app3 (Coremail) with SMTP id zS_KCgCXmm0oOg9pT2gFBA--.8637S3; Sat, 08 Nov 2025 20:40:19 +0800 (CST) From: Duoming Zhou To: linux-input@vger.kernel.org Cc: linux-kernel@vger.kernel.org, dmitry.torokhov@gmail.com, kuba@kernel.org, alexander.deucher@amd.com, pali@kernel.org, hverkuil+cisco@kernel.org, akpm@linux-foundation.org, andriy.shevchenko@linux.intel.com, tglx@linutronix.de, mingo@kernel.org, Jonathan.Cameron@huawei.com, Duoming Zhou Subject: [PATCH 1/2] Input: alps - fix use-after-free bugs caused by dev3_register_work Date: Sat, 8 Nov 2025 20:40:04 +0800 Message-Id: <09288a7a69cac4eff8165c59007c3d91ad08cb44.1762604516.git.duoming@zju.edu.cn> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: zS_KCgCXmm0oOg9pT2gFBA--.8637S3 X-CM-SenderInfo: qssqjiasttq6lmxovvfxof0/1tbiAwEEAWkOS38IiQAesL X-CM-DELIVERINFO: =?B?vqiUcwXKKxbFmtjJiESix3B1w3uoVhYI+vyen2ZzBEkOnu5chDpkB+ZdGnv/zQ0PbP CR19gUWg51OTK/19Jr+UF/FUwRSaRD0WGHGtwP4B0xtPK5MJGYnQQSPXJzzHb08SP3Ifsr LzoIPSHD6BgCJK/90564eUQdYk7E7xu/5wSiWafEmaZ5GpA+trGDNppg471Gng== X-Coremail-Antispam: 1Uk129KBj93XoW7Ww13JryrCFy3Gr47WF4Dtrc_yoW8tFW7pF W5WF98G3ykW34Fka1DXF4UZFWFkwnFv343Gr1kW39xtwn8JFyYqr48tF9Yga4rKrZ5Ar47 ArZrZ39xZFWvywcCm3ZEXasCq-sJn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3Ic02F40EFcxC0VAKzVAqx4xG6I80ebIjqfuFe4nvWSU5nxnvy29KBjDU 0xBIdaVrnRJUUU9Eb4IE77IF4wAFF20E14v26r4j6ryUM7CY07I20VC2zVCF04k26cxKx2 IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48v e4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_tr0E3s1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI 0_Gr1j6F4UJwA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xvwVC2z280aVCY1x0267AK xVW0oVCq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc804VCY07AIYIkI8VC2zVCFFI0UMc 02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0I7IYx2IY67AKxVWUGVWUXwAv7VC2z280aVAF wI0_Jr0_Gr1lOx8S6xCaFVCjc4AY6r1j6r4UM4x0Y48IcxkI7VAKI48JM4x0Y48IcxkI7V AKI48G6xCjnVAKz4kxM4IIrI8v6xkF7I0E8cxan2IY04v7MxAIw28IcxkI7VAKI48JMxC2 0s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI 0_JrI_JrWlx4CE17CEb7AF67AKxVWUtVW8ZwCIc40Y0x0EwIxGrwCI42IY6xIIjxv20xvE 14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxVW8JVWxJwCI42IY6xAIw20EY4v20x vaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Jr0_Gr1lIxAIcVC2z280aVCY1x0267AKxVW8 JVW8JrUvcSsGvfC2KfnxnUUI43ZEXa7IU1yrW5UUUUU== Content-Type: text/plain; charset="utf-8" The dev3_register_work delayed work item is initialized within alps_reconnect() and scheduled upon receipt of the first bare PS/2 packet from an external PS/2 device connected to the ALPS touchpad. During device detachment, the original implementation calls flush_workqueue() in psmouse_disconnect() to ensure completion of dev3_register_work. However, the flush_workqueue() in psmouse_disconnect() only blocks and waits for work items that were already queued to the workqueue prior to its invocation. Any work items submitted after flush_workqueue() is called are not included in the set of tasks that the flush operation awaits. This means that after flush_workqueue() has finished executing, the dev3_register_work could still be scheduled. Although the psmouse state is set to PSMOUSE_CMD_MODE in psmouse_disconnect(), the scheduling of dev3_register_work remains unaffected. The race condition can occur as follows: CPU 0 (cleanup path) | CPU 1 (delayed work) psmouse_disconnect() | psmouse_set_state() | flush_workqueue() | alps_report_bare_ps2_packet() alps_disconnect() | psmouse_queue_work() kfree(priv); // FREE | alps_register_bare_ps2_mouse() | priv =3D container_of(work...); // USE | priv->dev3 // USE Add disable_delayed_work_sync() in alps_disconnect() to ensure that dev3_register_work is properly canceled and prevented from executing after the alps_data structure has been deallocated. This bug is identified by static analysis. Fixes: 04aae283ba6a ("Input: ALPS - do not mix trackstick and external PS/2= mouse data") Signed-off-by: Duoming Zhou --- drivers/input/mouse/alps.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/input/mouse/alps.c b/drivers/input/mouse/alps.c index d0cb9fb9482..df8953a5196 100644 --- a/drivers/input/mouse/alps.c +++ b/drivers/input/mouse/alps.c @@ -2975,6 +2975,7 @@ static void alps_disconnect(struct psmouse *psmouse) =20 psmouse_reset(psmouse); timer_shutdown_sync(&priv->timer); + disable_delayed_work_sync(&priv->dev3_register_work); if (priv->dev2) input_unregister_device(priv->dev2); if (!IS_ERR_OR_NULL(priv->dev3)) --=20 2.34.1 From nobody Fri Dec 19 21:45:34 2025 Received: from zg8tmty1ljiyny4xntuumtyw.icoremail.net (zg8tmty1ljiyny4xntuumtyw.icoremail.net [165.227.155.160]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5E67626CE05; Sat, 8 Nov 2025 12:40:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=165.227.155.160 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762605645; cv=none; b=myok4uVmLT8NKgSXRNX8lEiBfktrueSPUxnlPlBry5dwhAcj8yeDRzw+b4mCwNecxSunlsZtV00uZxWqSRi/XsRjNbtEB/FLQPOYG0Gk2Ol2kjkKX66Xqk0t87WzAqKKsm5NuxgF79BJO/5F3ftDnBmeC1I7Lm6SQaNkcS3du84= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762605645; c=relaxed/simple; bh=41ObkAY8Y193C4TtK7tbe23kb/tT6X2Abl26RUSazQ0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=JGjCQqzdKQYMiyrquvyQjNRo/qZJ+t6Qu63f96ZuYiEYuB+fFVuc7sfR9dQ38ucSLGM67GIo293DKpTukOce9DXZabZrHHWEXHqotjNBfpRfAC8OiuIAnU8nglHP2xRX1brjH6DwQAvB6lvRV2fJb/8JzoAVsX1VSFbJfv5z3OE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=zju.edu.cn; spf=pass smtp.mailfrom=zju.edu.cn; arc=none smtp.client-ip=165.227.155.160 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=zju.edu.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=zju.edu.cn Received: from zju.edu.cn (unknown [218.12.19.144]) by mtasvr (Coremail) with SMTP id _____wDHjWE7Og9p5192Aw--.17311S3; Sat, 08 Nov 2025 20:40:27 +0800 (CST) Received: from ubuntu.localdomain (unknown [218.12.19.144]) by mail-app3 (Coremail) with SMTP id zS_KCgCXmm0oOg9pT2gFBA--.8637S4; Sat, 08 Nov 2025 20:40:26 +0800 (CST) From: Duoming Zhou To: linux-input@vger.kernel.org Cc: linux-kernel@vger.kernel.org, dmitry.torokhov@gmail.com, kuba@kernel.org, alexander.deucher@amd.com, pali@kernel.org, hverkuil+cisco@kernel.org, akpm@linux-foundation.org, andriy.shevchenko@linux.intel.com, tglx@linutronix.de, mingo@kernel.org, Jonathan.Cameron@huawei.com, Duoming Zhou Subject: [PATCH 2/2] Input: psmouse - Replace flush_workqueue() with disable_delayed_work_sync() Date: Sat, 8 Nov 2025 20:40:05 +0800 Message-Id: <308338a0e501cbe76eea20a143faad752e3aa111.1762604516.git.duoming@zju.edu.cn> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: zS_KCgCXmm0oOg9pT2gFBA--.8637S4 X-CM-SenderInfo: qssqjiasttq6lmxovvfxof0/1tbiAwEEAWkOS38IiQAgs1 X-CM-DELIVERINFO: =?B?vlV/YQXKKxbFmtjJiESix3B1w3uoVhYI+vyen2ZzBEkOnu5chDpkB+ZdGnv/zQ0PbP CR19gUWg51OTK/19Jr+UF/FUyHQXcCmDCyIVYwuvISJcAyZ/USjg9e5GNcpjqFQ+b+4/sr LzoIPSHD6BgCJK/90564eUQdYk7E7xu/5wSiWafEojwSwUO147ZeBgnk2VOPtw== X-Coremail-Antispam: 1Uk129KBj9xXoWruF45AF13uw1rKr1kCw17Arc_yoWkArc_ua 4rXr1kWr4jkw1qg34DCr13ZF4Iy3ZIqr97Gw4rXF4DJa4Uur9xGa1DZFWkArWkX3y7GF1a kw1agryfAr42gosvyTuYvTs0mTUanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUj1kv1TuYvT s0mT0YCTnIWjqI5I8CrVACY4xI64kE6c02F40Ex7xfYxn0WfASr-VFAUDa7-sFnT9fnUUI cSsGvfJTRUUUbTAYFVCjjxCrM7AC8VAFwI0_Gr0_Xr1l1xkIjI8I6I8E6xAIw20EY4v20x vaj40_Wr0E3s1l1IIY67AEw4v_Jr0_Jr4l8cAvFVAK0II2c7xJM28CjxkF64kEwVA0rcxS w2x7M28EF7xvwVC0I7IYx2IY67AKxVWDJVCq3wA2z4x0Y4vE2Ix0cI8IcVCY1x0267AKxV W8Jr0_Cr1UM28EF7xvwVC2z280aVAFwI0_GcCE3s1l84ACjcxK6I8E87Iv6xkF7I0E14v2 6rxl6s0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l57IF6xkI12xvs2x26I8E6xACxx1l5I 8CrVACY4xI64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r1Y6r17McIj6I8E87Iv67AK xVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IYc2Ij64vIr41lF7xvr2IYc2Ij64 vIr40E4x8a64kEw24lFIxGxcIEc7CjxVA2Y2ka0xkIwI1l42xK82IYc2Ij64vIr41l4I8I 3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s026x8GjcxK67AKxV WUGVWUWwC2zVAF1VAY17CE14v26r1q6r43MIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAF wI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E14v26r4j6F4UMIIF0xvE42xK8VAvwI8IcI k0rVWUJVWUCwCI42IY6I8E87Iv67AKxVWUJVW8JwCI42IY6I8E87Iv6xkF7I0E14v26r4j 6r4UJbIYCTnIWIevJa73UjIFyTuYvjxUzMa0DUUUU Content-Type: text/plain; charset="utf-8" The original code uses flush_workqueue() in psmouse_disconnect() to ensure the completion of both resync_work and dev3_register_work. Given that alps_disconnect() already uses disable_delayed_work_sync() to cancel dev3_register_work, replacing flush_workqueue() with disable_delayed_work_sync(&psmouse->resync_work) is more robust and efficient. Signed-off-by: Duoming Zhou --- drivers/input/mouse/psmouse-base.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/mouse/psmouse-base.c b/drivers/input/mouse/psmou= se-base.c index 77ea7da3b1c..eb41c553e80 100644 --- a/drivers/input/mouse/psmouse-base.c +++ b/drivers/input/mouse/psmouse-base.c @@ -1484,7 +1484,7 @@ static void psmouse_disconnect(struct serio *serio) =20 /* make sure we don't have a resync in progress */ mutex_unlock(&psmouse_mutex); - flush_workqueue(kpsmoused_wq); + disable_delayed_work_sync(&psmouse->resync_work); mutex_lock(&psmouse_mutex); =20 if (serio->parent && serio->id.type =3D=3D SERIO_PS_PSTHRU) { --=20 2.34.1