From nobody Sat Feb 7 17:55:30 2026 Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com [209.85.167.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7574D2D0C7B for ; Mon, 27 Oct 2025 11:44:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761565501; cv=none; b=r+tyhoSkg2A+vWkDxNR+S6d72mpGFyrclLPBhbztz8O1fby6/TSSCGV4NsGGyes60Or3pDy9i5NpPkeoE0E8wXUeC3ZR9nSjabQSACXPTo+UbWZeXGnxalIif/41v3jkGpeusehaf9PT0d30DyDO2XF0OHq2kMdMYvNhlCpysfk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761565501; c=relaxed/simple; bh=bJV1pIDRQ0fTdXTVy+9+Ty5YBDV6cJyFhCJx0AZhS/k=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qk1ookgxpEbRhqAPK1eWeBwNUvESoJScRSvLVmqBtdh/Dzir3rDYhBZMUWUerIAtgv1j+mOMJWn9qp/QDpgTGIzQVBNvuztoEUZe+hYEeZHq+Ma8nZHtQihYSAi253YJpd44qdf7NReM0LQFy8S6jIIsY9a133PY5Wd5xNsJPtY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QXGVNtcM; arc=none smtp.client-ip=209.85.167.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QXGVNtcM" Received: by mail-lf1-f42.google.com with SMTP id 2adb3069b0e04-57bd482dfd2so4976120e87.2 for ; Mon, 27 Oct 2025 04:44:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761565497; x=1762170297; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=49XvEyGAPxvhOqitsb9crv994raefdDhe/gxFtABsFA=; b=QXGVNtcMT0wAIDfx3ZImI+iAyHfim36a1vtl4Akof4VdZ/dwOr0OsCDze9S7CqaQWP 7XsWhx+3Bu0XAWinWOv0esXBjMY6AdcbkXWdFBbQNUqzAm3CfxTDO7rDRBzYzyvS21oz qi9J43Gxx+C3GsW/TKvHcD4wD6ENkISLPyjv3cAd4T1GxlpmBby0O1gx/mJ9ypG4HkYZ RAwkQh/kBt7egEHi6TT+ADMg+K/Y1Wdb/lILe8Fgre3DqIqZjgeMLAgzpQqZg6sOx1wG jl+vpOIKWqIiWoKeQfKKkLyr4m1o+xoI25GAzk5vNg3W9iMNjNYnOEgwcm1kU/4KnpDt RWBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761565497; x=1762170297; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=49XvEyGAPxvhOqitsb9crv994raefdDhe/gxFtABsFA=; b=TpQEtwUDYGkDk6xmHNK/0tdP1A44FMr9Cn7vLhB+rjvHNc8Z729DiQEWdQqBDPz/7F iM7sqjEKiDl4DawOmI9IGD87fc57chCE/Z3BhpNMACNY3OQSiPJuzXPNtVO1vjrOsiuu CcauDk0w3ypIb0r8W1FFOw55WLkXAUqJklU87SsI7VLQS0QJP1Y4m1A6L9qEyaJaPLVG CwjkcJny06ZzL1oRPSni2SeVRmLMNtzgSkYWG8+tcuFqbaYvTNyPxVmdladNe58QyP7y mo8nJkP0ebOsE+ci4g5MPFDhxtomcvdXbExTnw8WLEM8Bf2CadwmganOG5Tc7JXt43Sv OXnA== X-Forwarded-Encrypted: i=1; AJvYcCUIx1oz0aZf14Y60gGnKmdeKEBrlj1WOZaOSXDX2HZHKa9oLeVxxGWYfEolEkszNESDNJraZXD7GJ9KQPg=@vger.kernel.org X-Gm-Message-State: AOJu0YxR9u05oMj4+kYfVVypWG9qlj7yFClneplG5fADXs7xEbTioZ9X giQlzaAm2XTJiNk+Smk0oO3V80qgGoMW8QpNqC/vi1k4TbjOSMM7UKlP X-Gm-Gg: ASbGnctShhKRPl+qpGqqQX2LoiW7JaVsO1JubFKs1ny3lY7X1sJ1lXwmkyVTNWtaDnG qF8cExzmwGYTWoUeScQkSzvC/bNMH3DVQ3NgJA+6t38P93IeeHghGpYEcHK3Q9/kT2naHf108uI mpS9Z4Q0uZ1fV6VvNfuAMN3dFx2ltRWzyYey19ai8ztFIitItSRVHV+k+97D2lSQqDO2YiB5ZQk F3R4qUw/zSiEFknBmpppmgPru2UAqOXzSdnApzScgiNKqSVWfJl13gCiDFUAfT/DQQeAUzXfb7J 5TQm0PedZ9OQRVQJ10iVC9dov5QweaDOGE47+zAuD1Z+jES6X6t2KTOifTTXgSiegt2mmmyIOC4 FxCVxVpbu2cOSvOMpaqQfYrv8GvNlez9j16btSul3QwSEtYiQHonUuA8AKOn4Qwn810xvLd/2b3 LHYKoYbl4lIzTpyy1Hiw== X-Google-Smtp-Source: AGHT+IHppkRrpf2Zvp69RqFdfAGMn5pFll1fc6wtMRKN0kFnwN3QGg2f0fUR8rY1Whmr9/3tyMXpaw== X-Received: by 2002:a05:6512:2390:b0:593:33f:8071 with SMTP id 2adb3069b0e04-593033f8184mr2581067e87.7.1761565496464; Mon, 27 Oct 2025 04:44:56 -0700 (PDT) Received: from mva-rohm ([2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-59301f6bef3sm2287632e87.75.2025.10.27.04.44.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Oct 2025 04:44:55 -0700 (PDT) Date: Mon, 27 Oct 2025 13:44:49 +0200 From: Matti Vaittinen To: Matti Vaittinen , Matti Vaittinen Cc: Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Sebastian Reichel , Liam Girdwood , Mark Brown , Michael Turquette , Stephen Boyd , Matti Vaittinen , Linus Walleij , Bartosz Golaszewski , Andreas Kemnade , Alexandre Belloni , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-rtc@vger.kernel.org Subject: [PATCH v2 01/15] dt-bindings: regulator: ROHM BD72720 Message-ID: <25746d258ac57ae3eee82a20fa14a8a168f35e58.1761564043.git.mazziesaccount@gmail.com> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="awBciY5eMkD6wLHN" Content-Disposition: inline In-Reply-To: --awBciY5eMkD6wLHN Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" The ROHM BD72720 is a new PMIC with 10 BUCk and 11 LDO regulators. The BD72720 is designed to support using the BUCK10 as a supply for the LDOs 1 to 4. When the BUCK10 is used for this, it can be set to a LDON_HEAD mode. In this mode, the BUCK10 voltage can't be controlled by software, but the voltage is adjusted by PMIC to match the LDO1 .. LDO4 voltages with a given offset. Offset can be 50mV .. 300mV and is changeable at 50mV steps. Add 'ldon-head-millivolt' property to denote a board which is designed to utilize the LDON_HEAD mode. All other properties are already existing. Add dt-binding doc for ROHM BD72720 regulators to make it usable. Signed-off-by: Matti Vaittinen --- Revision history: RFCv1 =3D>: - No changes --- .../regulator/rohm,bd72720-regulator.yaml | 153 ++++++++++++++++++ 1 file changed, 153 insertions(+) create mode 100644 Documentation/devicetree/bindings/regulator/rohm,bd7272= 0-regulator.yaml diff --git a/Documentation/devicetree/bindings/regulator/rohm,bd72720-regul= ator.yaml b/Documentation/devicetree/bindings/regulator/rohm,bd72720-regula= tor.yaml new file mode 100644 index 000000000000..665086f56928 --- /dev/null +++ b/Documentation/devicetree/bindings/regulator/rohm,bd72720-regulator.ya= ml @@ -0,0 +1,153 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/regulator/rohm,bd72720-regulator.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: ROHM BD72720 Power Management Integrated Circuit regulators + +maintainers: + - Matti Vaittinen + +description: | + This module is part of the ROHM BD72720 MFD device. For more details + see Documentation/devicetree/bindings/mfd/rohm,bd72720-pmic.yaml. + + The regulator controller is represented as a sub-node of the PMIC node + on the device tree. + + Regulator nodes should be named to BUCK_ and LDO_. + The valid names for BD72720 regulator nodes are + buck1, buck2, buck3, buck4, buck5, buck6, buck7, buck8, buck9, buck10 + ldo1, ldo2, ldo3, ldo4, ldo5, ldo6, ldo7, ldo8, ldo9, ldo10, ldo11 + +patternProperties: + "^ldo[1-11]$": + type: object + description: + Properties for single LDO regulator. + $ref: regulator.yaml# + + properties: + regulator-name: + pattern: "^ldo[1-11]$" + description: + should be "ldo1", ..., "ldo11" + + rohm,dvs-run-voltage: + description: + PMIC default "RUN" state voltage in uV. See below table for + LDOs which support this. 0 means disabled. + $ref: /schemas/types.yaml#/definitions/uint32 + minimum: 0 + maximum: 3300000 + + rohm,dvs-idle-voltage: + description: + PMIC default "IDLE" state voltage in uV. See below table for + LDOs which support this. 0 means disabled. + $ref: /schemas/types.yaml#/definitions/uint32 + minimum: 0 + maximum: 3300000 + + rohm,dvs-suspend-voltage: + description: + PMIC default "SUSPEND" state voltage in uV. See below table for + LDOs which support this. 0 means disabled. + $ref: /schemas/types.yaml#/definitions/uint32 + minimum: 0 + maximum: 3300000 + + rohm,dvs-lpsr-voltage: + description: + PMIC default "deep-idle" state voltage in uV. See below table for + LDOs which support this. 0 means disabled. + $ref: /schemas/types.yaml#/definitions/uint32 + minimum: 0 + maximum: 3300000 + + # Supported default DVS states: + # ldo | run | idle | suspend | lpsr + # -------------------------------------------------------------- + # 1, 2, 3, and 4 | supported | supported | supported | supported + # -------------------------------------------------------------- + # 5 - 11 | supported (*) + # -------------------------------------------------------------- + # + # (*) All states use same voltage but have own enable / disable + # settings. Voltage 0 can be specified for a state to make + # regulator disabled on that state. + + unevaluatedProperties: false + + "^buck[1-10]$": + type: object + description: + Properties for single BUCK regulator. + $ref: regulator.yaml# + + properties: + regulator-name: + pattern: "^buck[1-10]$" + description: + should be "buck1", ..., "buck10" + + rohm,ldon-head-millivolt: + description: + Set this on boards where BUCK10 is used to supply LDOs 1-4. The = bucki + voltage will be changed by the PMIC to follow the LDO output vol= tages + with the offset voltage given here. This will improve the LDO ef= ficiency. + $ref: /schemas/types.yaml#/definitions/uint32 + minimum: 50 + maximum: 300 + + rohm,dvs-run-voltage: + description: + PMIC default "RUN" state voltage in uV. See below table for + bucks which support this. 0 means disabled. + $ref: /schemas/types.yaml#/definitions/uint32 + minimum: 0 + maximum: 3300000 + + rohm,dvs-idle-voltage: + description: + PMIC default "IDLE" state voltage in uV. See below table for + bucks which support this. 0 means disabled. + $ref: /schemas/types.yaml#/definitions/uint32 + minimum: 0 + maximum: 3300000 + + rohm,dvs-suspend-voltage: + description: + PMIC default "SUSPEND" state voltage in uV. See below table for + bucks which support this. 0 means disabled. + $ref: /schemas/types.yaml#/definitions/uint32 + minimum: 0 + maximum: 3300000 + + rohm,dvs-lpsr-voltage: + description: + PMIC default "deep-idle" state voltage in uV. See below table for + bucks which support this. 0 means disabled. + $ref: /schemas/types.yaml#/definitions/uint32 + minimum: 0 + maximum: 3300000 + + # Supported default DVS states: + # buck | run | idle | suspend | lpsr + # -------------------------------------------------------------- + # 1, 2, 3, and 4 | supported | supported | supported | supported + # -------------------------------------------------------------- + # 5 - 10 | supported (*) + # -------------------------------------------------------------- + # + # (*) All states use same voltage but have own enable / disable + # settings. Voltage 0 can be specified for a state to make + # regulator disabled on that state. + + required: + - regulator-name + + unevaluatedProperties: false + +additionalProperties: false --=20 2.51.0 --awBciY5eMkD6wLHN Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEIx+f8wZb28fLKEhTeFA3/03aocUFAmj/WzEACgkQeFA3/03a ocVTUggArj/1fmI1HF43iqsDEQiiGAlrOQqr14P7kDh6+XtZXYlIHl/dHS49elmm XFABwL8sunAbCRxPKW5dkkO7fyFwBxBcYdSxMfrfvQG+mMBW6PiXGf8DTsb8Gu9K f9HTQSTzd9jAZG68YMll0gAiHqDuMK7X52XyPyxwff5pOvt6c1cmK4t0QqdZxo/t EATrZrCkAqOe/geUInymcVvRB1msabXXSn/ejxl9pChYe/y8DjpKWErwp0/rUicr FQ15ILiAsHV08pUL6lm4SIkSoPH18VOHKjvU2hcjLwMvgmcPGWc5PGWDPd1ZEgNp 0slYn8f5qf5pL4GM/tfEULb+lp8+vA== =Zids -----END PGP SIGNATURE----- --awBciY5eMkD6wLHN-- From nobody Sat Feb 7 17:55:30 2026 Received: from mail-lj1-f177.google.com (mail-lj1-f177.google.com [209.85.208.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 64D5B22A4CC for ; Mon, 27 Oct 2025 11:45:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761565515; cv=none; b=CSiH3BqfRHcAXegiBDVpbRhnTuzOVbbezUEzYIh/7LBhq72VdRHQAJnEJ77cCP5r4jI2cYr4iv5wgbUfXOWBTp+pL0I87WjsXU9nZUCJvH5Sp1DIciSZyLJquVCJwLns3omFwv3kvR9D427Z/kpspaPjtv60QIxK3FDISBrRvBs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761565515; c=relaxed/simple; bh=IjpBU42ntX9XaYmyRucOHQzBqWEweHkDi9vYXmN8LMY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=bYi/oMIK9iu3HmvxvPK1soVjgi8eaXvJLGEoYZoqAecry0errlODFEK9/nq8CVEWubyQVFJF7UmRjMaPpmiOk8iLr5y6nwfSYFFHQDadd+E4JZUgqGcKyk8kGnwoLmSUg1Xf5CJiauZ4W+jWco4E/SQ0JAT84C76PR0dXb2kgG0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ODS30pIt; arc=none smtp.client-ip=209.85.208.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ODS30pIt" Received: by mail-lj1-f177.google.com with SMTP id 38308e7fff4ca-378d50e1c77so41149401fa.0 for ; Mon, 27 Oct 2025 04:45:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761565510; x=1762170310; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=U3bvBuQH05UYV7qQeFG6dlKCPrhvCySjKkIncy7Gx44=; b=ODS30pItJia4v+EkFJTKwrB+i3DItT+o2TLpFP3zZnYPf30k+e3X/2CFVI3LZPYyMt /A3bOyjc+akTrbysEXVFYcA3GtLMHmOoCJfM/a65nt4ywNaerdGGp7ig883OMS7C+Rhw QTODaKXbrQhd9TQAhM/W0e4CJsp9wR2V7eHqemIgavolDfE54e43gllAbJ8UfIeis93x sTQGtT3tgwYUXWeYarCaWM6ZpfJ/Mjgv4jDsdDHvcntuB09SG2FdKVhnHVeswuhVyQOq SXxsSy5BwY5kw/DX1PNL/b/tJHKFWMYWPgwYMpI//dqEkWZkM3pzEe2QOam+okXFSWnf eYNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761565510; x=1762170310; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=U3bvBuQH05UYV7qQeFG6dlKCPrhvCySjKkIncy7Gx44=; b=MQpnP0WlfcwWWw14vwlQqXn/FzhnSTToyftm6O1Igq8kQVriHJkEI9EAwFg23Khb/s EOIC52Tr4rHbJAgNs3aBP+2kwXe2qvzUug/8UIIPSVMQWB/5mViJp+mJCdDjgvkItle1 zgrUq97d7itj/7c9ad0tsgRysyqi553Bpy6hkOydlLfFNJlwNJ4JquBNKQNInfCrN5YM mpzdwSeEfNqaNTLdkg4ogldTJjlCC+q6vB6sKvm8U/V04Ggvx6x8JXk1FhgUDF8TAk6C ncX/EypSpevlvoVHLfMdKPn8OTQP2nnAlyt8uzN42Mxch/vfiEZUYwLDcOnDxCOFfWxe yFPA== X-Forwarded-Encrypted: i=1; AJvYcCWy76gxOZRjyelSPZdZ5+Dgj4sDX7HLd7UM+XZXseIQseIiaqdMvB6j7sWS5ytnV71O659ES3jC3rk2W4k=@vger.kernel.org X-Gm-Message-State: AOJu0YxjPfkoIdSZ0rikyKWWJ8fMJ3pbmLj8U2KP5Yus2+80NCi55o8U eAMCFbv3yAkIGO0VIWQDmbiQ7w8ozCrN3Qzhkj7kO4/GYSgWt0XnCOtz X-Gm-Gg: ASbGncspanXC/QF/joha3AQnCBih8tCxPax1TNrjz7qXq9fkz4669/4edMiEiS1eVCU 5X7k6hiJWDhLapT/Xq/mWH0vbuDeX+Lgf5Yg1gcQSkSoqblW/mWX0X8KFgw2mXl1EQVU4XoDR8L gKr5puVL6Z80t+dTon24Gh8QPAxQr5KX+ivECCpHBh3KwDZJlthdLxR6zUWxiCeFQb7/Fo6JbaK nFUIwcG71b34h32PbU04H0Ie/T4SQ2cv28jN0/vhDYp8Wam2gLgbv6zz5eF6DyesV892vmUuQUE cGMR0lY9tTyu9tMMkRvhmUGMePIL8jCS4rNXkKlqIdoxv7e1GRtZ1EM4f7KuQBi7qM/O1Qni91b TQkzmVSuoVrzphN4QrtHS0gOAd+i3M2I9pqkLBcSbQx8iWg9j6KIpKaz1L5zFEkmiM6yMHRg7EY YjnBefvrQ= X-Google-Smtp-Source: AGHT+IG040q7cqWV71VuTHnX5coaOHS5RsTVRj/7BqmGOTBNKnaNhaPjcm0wBLEa4smz5wwn4wiKuQ== X-Received: by 2002:a05:6512:4022:b0:592:f5a4:ece6 with SMTP id 2adb3069b0e04-592f5a4f458mr5888071e87.14.1761565510170; Mon, 27 Oct 2025 04:45:10 -0700 (PDT) Received: from mva-rohm ([2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-59301f5fc75sm2207808e87.59.2025.10.27.04.45.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Oct 2025 04:45:09 -0700 (PDT) Date: Mon, 27 Oct 2025 13:45:05 +0200 From: Matti Vaittinen To: Matti Vaittinen , Matti Vaittinen Cc: Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Sebastian Reichel , Liam Girdwood , Mark Brown , Michael Turquette , Stephen Boyd , Matti Vaittinen , Linus Walleij , Bartosz Golaszewski , Andreas Kemnade , Alexandre Belloni , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-rtc@vger.kernel.org Subject: [PATCH v2 02/15] dt-bindings: Add trickle-charge upper limit Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="0aGnDoHzYmHLbrXY" Content-Disposition: inline In-Reply-To: --0aGnDoHzYmHLbrXY Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Some of the chargers for lithium-ion batteries use a trickle-charging as a first charging phase for very empty batteries, to "wake-up" the battery. Trickle-charging is a low current, constant current phase. After the voltage of the very empty battery has reached an upper limit for trickle charging, the pre-charge phase is started with a higher current. Allow defining the upper limit for trickle charging voltage, after which the charging should be changed to the pre-charging. Signed-off-by: Matti Vaittinen Reviewed-by: Linus Walleij --- Revision history: RFCv1 =3D>: - No changes --- Documentation/devicetree/bindings/power/supply/battery.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/devicetree/bindings/power/supply/battery.yaml b/= Documentation/devicetree/bindings/power/supply/battery.yaml index 491488e7b970..66bed24b3dee 100644 --- a/Documentation/devicetree/bindings/power/supply/battery.yaml +++ b/Documentation/devicetree/bindings/power/supply/battery.yaml @@ -66,6 +66,9 @@ properties: trickle-charge-current-microamp: description: current for trickle-charge phase =20 + tricklecharge-upper-limit-microvolt: + description: limit when to change to precharge from trickle charge + precharge-current-microamp: description: current for pre-charge phase =20 --=20 2.51.0 --0aGnDoHzYmHLbrXY Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEIx+f8wZb28fLKEhTeFA3/03aocUFAmj/W0EACgkQeFA3/03a ocVHlwf/WmMG+VHvvbW2L2DZtJpJaw0EfC6PYPUNs9yBLXDr+CfL0pRslVccxRKB Jmbbt/J+CQ5jhDcPysdGvd4gvl2XqZlNW74w9zBpGGeoAXN3RepiLjwPu07tbi3q KsMyf0UBeVGeZMD89Z0iyf+i9uAPjIbL7jsJ67Im5cg7H5xWctMEjPmQSAYOZI3n HLbSqG7+HsWQN/9V3fqNVE4g3O7gipBY8F0ZZQzdZcU0EEimtnwhpyUz1VHnQVIQ R9MRt7+1ynYb/Hr3y/3yUjLfNmwvD5atDA2znKphM6acJ/LgYTJA4sg2Nvco36Xw A5pNMofVjUgxD7NYCslLgrj9UeRj+Q== =OPBq -----END PGP SIGNATURE----- --0aGnDoHzYmHLbrXY-- From nobody Sat Feb 7 17:55:30 2026 Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com [209.85.167.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CFE2C2FD699 for ; Mon, 27 Oct 2025 11:45:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761565531; cv=none; b=EVCUkeBQ1nWUczABOvOXgnSLy/zEdrSYe15j00mNr6r4Or69PBhOqVjM6ylPz7nuB7J8nBUkIe2JJFoUM841//YoK76oGndxxXpTRORxIssOr8Q+otR5Hlp4Q4WALOJZnikZRcatNv26fuorB7mk1LXVE/QoEN3B387Yt1QX1LM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761565531; c=relaxed/simple; bh=DId7qrYduOi7rsQpusH3al8L0SA0hkuOAYv0jtZuJuQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=NPFLj/Orn4So6hzHHhoGsPaMMWBXByHIevc3lSiowMZG9Fx51XGVGTEySFGl63C/KSIwuZ4MQDCf8/jA+ggyw4N7pkxV5Sr00wQjcrecBmKe1ky+T6OjMKjnMgAbuJih1P2vdqq/AILuuvH614SiJsj9Lboh7uXX9A1iYY8fx5g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hI/Ll8xX; arc=none smtp.client-ip=209.85.167.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hI/Ll8xX" Received: by mail-lf1-f44.google.com with SMTP id 2adb3069b0e04-592f1988a2dso5183871e87.0 for ; Mon, 27 Oct 2025 04:45:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761565528; x=1762170328; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Vu0yAB4Kq9ci15rhEMoRcDBRFGKvubFx0Hd0y0gzj18=; b=hI/Ll8xXTd40fl1UF1A0lagyS2RpX7pkI/vpWO22qpSsN52qVDOYqs2d9iWptOcU9/ ltp8LqKIVOPvsYTzeEf+orkdOinXuhS5NN6593CcU8XGklLly22IqIlDdfuAkY8GjtJ8 qgLFugox20z+vB0w8KKbgzbF1HyudhoDuIzQS0o6Ww0Tq+qesAOBSDN8ggIBFvHZyzex UpdoWNtnUcZ0VJVYHwxb008ZmNEekT0mRbLGCwNUru37r59vekOUh+lzkv/VoQhis5QG 77ee0XHHcCcLf3JhHsx9pVUdJDYsFfJLTvuw2qSa6kAUJxZ2W4eENCiXaC+nLy30a2g9 kzBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761565528; x=1762170328; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Vu0yAB4Kq9ci15rhEMoRcDBRFGKvubFx0Hd0y0gzj18=; b=Mwsgbx29mFedEXe4iOy0JicPO17r5qX0HLbqla9sM+17atwC6Yvr2jQTfYX3yBYnwH 5crTGmr71KDEWP9YTgeC3FQAWDqJUh+NpNQ/K6ZexOPv0TjqsJ/U+Mpak2bcxfx6dNBe X5jP6cOMw6qp6rzAf5aBBlp7sHmyzAdapyIXmxFcavuPK/1VInUxCMxJY12XRgZ4ogsi g9F08hRlFPJebKZqAlbCcS7vtBLd3b6Pe2pbA5bSN94Uv5Uvou6eLV0k3nxeRNnBeGf7 eNKJGw1Qqz23Gn90fnPRKd761wc28VZSbNLfM646mb+NRSLkL2pAEv/CXVcvQHNFCCBh 1dgg== X-Forwarded-Encrypted: i=1; AJvYcCXLqrXAlWCgtlF2cAOcrKF3MUTKpMktLedSsP9nsjSGeQaFc3G3lO+eB0LjRCqT07uWEnu1RmboofrmhQo=@vger.kernel.org X-Gm-Message-State: AOJu0YxcISO5/oYYdui5731W0Uxissk6ZmkOM9vc2JcY4cMZGnkuB/od MeeX7ql+d39R9VD6n7qCwnbOTMDrk75cpF+ciFFFUo7xoiz1P2vy643X X-Gm-Gg: ASbGnctW+S431kUr4MIDoXScaKDR/+pJ2Xu+Akw7TAdeonsLtUcKrNGNz6uCz9frC7t QqGi2PYl4Rwe8F/tf9PGuKoP3GO5dh/uviJCtt+njAuuefJNNeFx6QBeZMqFtla64IUCET+ALGZ BuJDDB1GU1G11nIkweGausU7qTooHf6Mpj0v/nwotNSKiyNj3IxgOcqKBQsnhII4K0yA1Tklxl8 Jzy+6J1EjkGyxmXKfzDbt1g5YydHuK0i04OLT6FMkIjGbMQDKGS95IuyYakziQMuHB8PhcwpBlS z66whgt/5IQ9vrN3l6K7EqiqF/RLDfxTZwVK9eFmbvxixkGNPehJCubVEWCKOrnmll/jtzP1LCF q947xGhcd02wgD4OfMBqqwYQwam/oeFkJ5hiF7cHMeXzfWIkQOrZ6vjaO6t66RguPIJU2dOVhNk JAhobiykc= X-Google-Smtp-Source: AGHT+IE4YlBL7y1GNkusKn3quFm5CcV3Gp1fcQiEbVskWmnnqdz/gdXp1LualBEs8jKDJNMzkAUW4A== X-Received: by 2002:a05:6512:6183:b0:593:6b:520c with SMTP id 2adb3069b0e04-593006b5392mr2661528e87.10.1761565527766; Mon, 27 Oct 2025 04:45:27 -0700 (PDT) Received: from mva-rohm ([2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-59301f41bafsm2233916e87.12.2025.10.27.04.45.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Oct 2025 04:45:26 -0700 (PDT) Date: Mon, 27 Oct 2025 13:45:23 +0200 From: Matti Vaittinen To: Matti Vaittinen , Matti Vaittinen Cc: Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Sebastian Reichel , Liam Girdwood , Mark Brown , Michael Turquette , Stephen Boyd , Matti Vaittinen , Linus Walleij , Bartosz Golaszewski , Andreas Kemnade , Alexandre Belloni , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-rtc@vger.kernel.org Subject: [PATCH v2 03/15] dt-bindings: power: supply: BD72720 managed battery Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="e9WYiUNMm5xMUcJj" Content-Disposition: inline In-Reply-To: --e9WYiUNMm5xMUcJj Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" The BD72720 PMIC has a battery charger + coulomb counter block. These can be used to manage charging of a lithium-ion battery and to do fuel gauging. ROHM has developed a so called "zero-correction" -algorithm to improve the fuel-gauging accuracy close to the point where battery is depleted. This relies on battery specific "VDR" tables, which are measured from the battery, and which describe the voltage drop rate. More thorough explanation about the "zero correction" and "VDR" parameters is here: https://lore.kernel.org/all/676253b9-ff69-7891-1f26-a8b5bb5a421b@fi.rohmeur= ope.com/ Document the VDR zero-correction specific battery properties used by the BD72720 and some other ROHM chargers. Signed-off-by: Matti Vaittinen Reviewed-by: Linus Walleij --- Revision history: RFCv1 =3D> v2: - Add units to rohm,volt-drop-soc (tenths of %) - Give real temperatures matching the VDR tables, instead of vague 'high', 'normal', 'low', 'very low'. (Add table of temperatures and use number matching the right temperature index in the VDR table name). - Fix typoed 'algorithm' in commit message. The parameters are describing the battery voltage drop rates - so they are properties of the battery, not the charger. Thus they do not belong in the charger node. The right place for them is the battery node, which is described by the generic "battery.yaml". I was not comfortable with adding these properties to the generic battery.yaml because they are: - Meaningful only for those charger drivers which have the VDR algorithm implemented. (And even though the algorithm is not charger specific, AFAICS, it is currently only used by some ROHM PMIC drivers). - Technique of measuring the VDR tables for a battery is not widely known. AFAICS, only folks at ROHM are measuring those for some customer products. We do have those tables available for some of the products though (Kobo?). --- .../power/supply/rohm,vdr-battery.yaml | 80 +++++++++++++++++++ 1 file changed, 80 insertions(+) create mode 100644 Documentation/devicetree/bindings/power/supply/rohm,vdr= -battery.yaml diff --git a/Documentation/devicetree/bindings/power/supply/rohm,vdr-batter= y.yaml b/Documentation/devicetree/bindings/power/supply/rohm,vdr-battery.ya= ml new file mode 100644 index 000000000000..1ab3418d4338 --- /dev/null +++ b/Documentation/devicetree/bindings/power/supply/rohm,vdr-battery.yaml @@ -0,0 +1,80 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/power/supply/rohm,vdr-battery.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Battery managed by the BD72720 PMIC + +maintainers: + - Matti Vaittinen + +description: + A battery which has VDR parameters measuerd for ROHM chargers. + +allOf: + - $ref: battery.yaml# + +properties: + rohm,voltage-vdr-thresh-microvolt: + description: Threshold for starting the VDR correction + + rohm,volt-drop-soc: + description: Table of capacity values matching the values in VDR table= s. + The value should be given as tenths of a percentage. + $ref: /schemas/types.yaml#/definitions/uint32-array + + rohm,volt-drop-temperatures-millicelsius: + description: An array containing the temperature in milli celsius, for= each + of the VDR lookup table. + +patternProperties: + '^rohm,volt-drop-[0-9]-microvolt': + description: Table of the voltage drop rate (VDR) values. Each entry i= n the + table should match a capacity value in the rohm,volt-drop-soc table. + Furthermore, the values should be obtained for the temperature given= in + rohm,volt-drop-temperatures-millicelsius table at index matching the + number in this table's name. + +additionalProperties: false + +examples: + - | + power { + #address-cells =3D <1>; + #size-cells =3D <0>; + + battery: battery { + compatible =3D "simple-battery"; + + ocv-capacity-celsius =3D <25>; + ocv-capacity-table-0 =3D <4200000 100 4184314 100 4140723 95 40994= 87 90 + 4060656 85 4024350 80 3991121 75 3954379 70 3913265 65 3877821 60 + 3855577 55 3837466 50 3822194 45 3809012 40 3795984 35 3780647 30 + 3760505 25 3741532 20 3718837 15 3696698 10 3690594 5 3581427 0>; + + rohm,volt-drop-soc =3D <1000 1000 950 900 850 800 750 700 650 600 = 550 500 + 450 400 350 300 250 200 150 100 50 00 (-50)>; + + rohm,volt-drop-temperatures-millicelsius =3D <45000 25000 5000 0>; + + rohm,volt-drop-0-microvolt =3D <100 100 102 104 106 109 114 124 + 117 107 107 109 112 116 117 108 109 109 108 109 122 126 130>; + + rohm,volt-drop-1-microvolt =3D <100 100 102 105 98 100 105 102 + 101 99 98 100 103 105 109 117 111 109 110 114 128 141 154>; + + rohm,volt-drop-2-microvolt =3D <100 100 98 107 112 114 118 118 112 + 108 108 110 111 113 117 123 131 144 157 181 220 283 399>; + + rohm,volt-drop-3-temp-microvolt =3D <86 86 105 109 114 110 115 115 + 110 108 110 112 114 118 124 134 136 160 177 201 241 322 403>; + + rohm,voltage-vdr-thresh-microvolt =3D <4150000>; + + charge-full-design-microamp-hours =3D <1799000>; + voltage-max-design-microvolt =3D <4200000>; + voltage-min-design-microvolt =3D <3500000>; + degrade-cycle-microamp-hours =3D <131>; + }; + }; --=20 2.51.0 --e9WYiUNMm5xMUcJj Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEIx+f8wZb28fLKEhTeFA3/03aocUFAmj/W1MACgkQeFA3/03a ocWa5wf9FIbY2brXI4P2K+SkKL5KeUWFhV759iXcCiZETbvISYLTQUgInwo/maR0 CIjloSV2ahJ6BrG6PxHcbD67kt0VrMsF9M1s5ILlfaQwDJ+xDNqz/jFyPsV1OvWZ NhFwXu6P3hS3Z8Sz+EcHo4QxrH2PGDSbfn1ZhsSMT+j/Fgn6aOUIRBwFGSOluLfb VQi3LvkEatX9krISzcP9y/1coBFjeaxbaR9O7ifPo19uSY1kQ5CrLMbGGu/YJ5sl NetFxIsnpGdxMe288trS+BM400PIprVcdoNQwHrTtb8TmynyIExDr064x4KuHKY6 c2lMVwmaCFAU3JoJDueqjLI/FnjKmg== =fE8w -----END PGP SIGNATURE----- --e9WYiUNMm5xMUcJj-- From nobody Sat Feb 7 17:55:30 2026 Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8035C2FF17D for ; Mon, 27 Oct 2025 11:45:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761565557; cv=none; b=Iz2+KZXe905T/FI6msGhXigfsm6cQz6IoXKd+BrqSbBZZVqPAdIl9MZnkWT/a2zdasfhKCn+rnjT0OE9+WSz7U9mwrVdY5Bo7zb2BSgTkiXYkp31lt73Klii1bNllar6zlMNVeD59AoGBOwcSsUAlXau4ecgbznvy/xrgY+lBpY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761565557; c=relaxed/simple; bh=18svdfFnZ2AVuDfJS5eM2PxZOMJATrSM2OphkPYvXR0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=GYeEo9GXP62q+x2hAQ8sxDyMAYZScNdjDgBd/ootcJJNDXXM00rp3gB/FWoN7rjXsajbaXi9AYwUfCYfcfBJ37zrtsCE84K0znfgf79x0D4rRj2jTA9mgMExOrJYXuRowqb52eISfsVtGuQwE70e4uYbeMAHFiCMKIkbi2KeWWE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MrBBAJnL; arc=none smtp.client-ip=209.85.167.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MrBBAJnL" Received: by mail-lf1-f45.google.com with SMTP id 2adb3069b0e04-592fdbeb7b2so4219163e87.0 for ; Mon, 27 Oct 2025 04:45:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761565553; x=1762170353; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=7P51F10ZXwkNj1M4/2nFKdIMMqbtPwfVNv5IuoJNzBA=; b=MrBBAJnLsLq4XT1g/yZrlZ48zHPYXcWBkLO/lcKeWhUCShmEhphEM3ij5fYgAQ2x9b nSIv252Lo3ZuUwZDSES1N4I+PGHwDaKcYNVGSVZaYuvHLyN8H6/yG8jtaglWer6hPaPs MrzMKg1JT7y7O6takUcWt8oPSqqH5CQlaV6undZi0NsmU5jWcq8rxyml7DyRxv+B9njH eRc6Lykf+unzZtf/KKvp0ft7gSe9pL6z41KJowbEsfAfHeIltmgzJM71aa2BSGUsNFLT rvWVfL378FDF05ak2toO/qfnG38jNV0FmezylpfgMBEo4Yy3fbHGpuUkjwo7xIv6aV9f upRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761565554; x=1762170354; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=7P51F10ZXwkNj1M4/2nFKdIMMqbtPwfVNv5IuoJNzBA=; b=o6ta0Jj6TiT0YX3Okoqqhz7Tc9xlwYsooA3cpsr33P6OUYysshwOcXtavAFg/Qbm50 pqUID9qehs69d1sItFHDsbQiuc3EZSyHu5AnNn/w6eGE6W0IsFz0VEawnAtWjtTmHpuY oC/ewGfUioLTE+dsBCZIPD6ejsugmNNVSkbKja8plIm0VIUrxN0a/Z7F9uBX0fXNCfoJ bSJ1s9t4y1CppER+LCsIjlnP+1RLqT/Vn0PGkwe73B7jn0H7O5K8c6R7pPB0PCeb7ilc kUdDLpAY4G2DH0gsJ0uSoNHSpGNWw0LZZd71lm3CFuZ0YWajgAUwT1NkXZ1ao8GP2JO7 qp7A== X-Forwarded-Encrypted: i=1; AJvYcCXjvZCFM3QvLYuJte6e+YkBOLB4VTqmjLWq4zVfjVBo1KX/kdIOcrQzREqt51jn37vjMf0+bihqKqiictA=@vger.kernel.org X-Gm-Message-State: AOJu0YxBphwLxsQtx9zau5u3LpKIRbm9puDigrOKP6VVCqyXo+ALI0lI H7KsDxfpiD3iJclz/oaMxLdn6KKrxd5RxDoTblXiNBwxMhI9sLtEo1IH X-Gm-Gg: ASbGncvrxGKsnoEIij5aV38Dl4eEA1e8maMlpFsnYbosrIMYmXjwZIX2kDNRxr0Pujp HPaKCRvqBNrrPg2C8dhn/++cSRzi60e93PAf/8v0jcJTyBLfB8Ob7wGjLHkBjtGFSfzuPKNjkBW p4UBH67pgS/AW+6fWHxFq63YiHet13bo/RQaRSbLoZMWVbj8jjHpbOTRqKeZZfNEyDm3mnGHIde kRvCKTRxG5ku5vQ5VTaWhVa7QJCQNRwV+Drnp84kBjMRKqG0gdpIzJyPsnZ2JF2Ja+ItXccLQQf YvrCfuvAkkSwWbls7pRuty8bmw7SiAjjB+V3dz6cSzd7qVzvtcuXKH7ecFw7flFUJAoEshz5Eqy xOcNDyY/rtIuYmB0ku7J4FQYq173GazzHdRrwTxGJf8izNLnB+C7J56hLsK8XdhGV8oGVfXIAZl PVwNokmhw= X-Google-Smtp-Source: AGHT+IEMB19SdfWbPJthcHmxadT/Ntb6p8r8W41zYTZKza70M5l1DTaWfk41IQKJvw62BfTqx04f6g== X-Received: by 2002:a05:6512:3e1a:b0:58b:151:bc0f with SMTP id 2adb3069b0e04-592fca89a9dmr4055285e87.54.1761565553348; Mon, 27 Oct 2025 04:45:53 -0700 (PDT) Received: from mva-rohm ([2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-59301f7444bsm2285523e87.85.2025.10.27.04.45.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Oct 2025 04:45:52 -0700 (PDT) Date: Mon, 27 Oct 2025 13:45:46 +0200 From: Matti Vaittinen To: Matti Vaittinen , Matti Vaittinen Cc: Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Sebastian Reichel , Liam Girdwood , Mark Brown , Michael Turquette , Stephen Boyd , Matti Vaittinen , Linus Walleij , Bartosz Golaszewski , Andreas Kemnade , Alexandre Belloni , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-rtc@vger.kernel.org Subject: [PATCH v2 04/15] dt-bindings: mfd: ROHM BD72720 Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="hIp+AjNzMwe9bvg8" Content-Disposition: inline In-Reply-To: --hIp+AjNzMwe9bvg8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" The ROHM BD72720 is a power management IC integrating regulators, GPIOs, charger, LEDs, RTC and a clock gate. Add dt-binding doc for ROHM BD72720. Signed-off-by: Matti Vaittinen --- Revision history: RFCv1 =3D> v2: - Typofixes --- .../bindings/mfd/rohm,bd72720-pmic.yaml | 269 ++++++++++++++++++ 1 file changed, 269 insertions(+) create mode 100644 Documentation/devicetree/bindings/mfd/rohm,bd72720-pmic= .yaml diff --git a/Documentation/devicetree/bindings/mfd/rohm,bd72720-pmic.yaml b= /Documentation/devicetree/bindings/mfd/rohm,bd72720-pmic.yaml new file mode 100644 index 000000000000..b0d4bc01d199 --- /dev/null +++ b/Documentation/devicetree/bindings/mfd/rohm,bd72720-pmic.yaml @@ -0,0 +1,269 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/mfd/rohm,bd72720-pmic.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: ROHM BD72720 Power Management Integrated Circuit + +maintainers: + - Matti Vaittinen + +description: | + BD72720 is a single-chip power management IC for battery-powered portable + devices. The BD72720 integrates 10 bucks and 11 LDOs, and a 3000 mA + switching charger. The IC also includes a Coulomb counter, a real-time + clock (RTC), GPIOs and a 32.768 kHz clock gate. + +# In addition to the properties found from the charger node, the ROHM BD72= 720 +# uses properties from a static battery node. Please see the: +# Documentation/devicetree/bindings/power/supply/rohm,vdr-battery.yaml +# +# Following properties are used +# when present: +# +# charge-full-design-microamp-hours: Battry capacity in mAh +# voltage-max-design-microvolt: Maximum voltage +# voltage-min-design-microvolt: Minimum voltage system is still opera= ting. +# degrade-cycle-microamp-hours: Capacity lost due to aging at each fu= ll +# charge cycle. +# ocv-capacity-celsius: Array of OCV table temperatures. 1/ta= ble. +# ocv-capacity-table-: Table of OCV voltage/SOC pairs. Corre= sponds +# N.th temperature in ocv-capacity-cels= ius +# +# ROHM specific properties: +# rohm,voltage-vdr-thresh-microvolt: Threshold for starting the VDR correc= tion +# rohm,volt-drop-soc: Table of capacity values matching the +# values in VDR tables. +# rohm,volt-drop-high-temp-microvolt: VDR table for high temperature +# rohm,volt-drop-normal-temp-microvolt: VDR table for normal temperature +# rohm,volt-drop-low-temp-microvolt: VDR table for low temperature +# rohm,volt-drop-very-low-temp-microvolt: VDR table for very low temperatu= re +# +# VDR tables are (usually) determined for a specific battery by ROHM. +# The battery node would then be referred from the charger node: +# +# monitored-battery =3D <&battery>; + +properties: + compatible: + const: rohm,bd72720 + + reg: + description: + I2C slave address. + maxItems: 1 + + interrupts: + maxItems: 1 + + gpio-controller: true + + "#gpio-cells": + const: 2 + description: | + The first cell is the pin number and the second cell is used to spec= ify + flags. See ../gpio/gpio.txt for more information. + + clocks: + maxItems: 1 + + "#clock-cells": + const: 0 + + clock-output-names: + const: bd71828-32k-out + + rohm,clkout-open-drain: + description: clk32kout mode. Set to 1 for "open-drain" or 0 for "cmos". + $ref: /schemas/types.yaml#/definitions/uint32 + minimum: 0 + maximum: 1 + + rohm,charger-sense-resistor-milli-ohms: + minimum: 10 + maximum: 50 + description: | + BD72720 has a SAR ADC for measuring charging currents. External sense + resistor (RSENSE in data sheet) should be used. If some other but + 30 mOhm resistor is used the resistance value should be given here in + milli Ohms. + + regulators: + $ref: ../regulator/rohm,bd77270-regulator.yaml + description: + List of child nodes that specify the regulators. + + leds: + $ref: ../leds/rohm,bd71828-leds.yaml + + rohm,pin-dvs0: + $ref: /schemas/types.yaml#/definitions/string + description: + BD72720 has 4 different OTP options to determine the use of dvs0-pin. + OTP0 - regulator RUN state control. + OTP1 - GPI. + OTP2 - GPO. + OTP3 - Power sequencer output. + This property specifies the use of the pin. + enum: + - dvs-input + - gpi + - gpo + + rohm,pin-dvs1: + $ref: /schemas/types.yaml#/definitions/string + description: + see rohm,pin-dvs0 + enum: + - dvs-input + - gpi + - gpo + + rohm,pin-exten0: + $ref: /schemas/types.yaml#/definitions/string + description: BD72720 has an OTP option to use exten0-pin for different + purposes. Set this property accordingly. + const: gpo + + rohm,pin-exten1: + $ref: /schemas/types.yaml#/definitions/string + description: BD72720 has an OTP option to use exten1-pin for different + purposes. Set this property accordingly. + const: gpo + + rohm,pin-fault_b: + $ref: /schemas/types.yaml#/definitions/string + description: BD72720 has an OTP option to use fault_b-pin for different + purposes. Set this property accordingly. + const: gpo + +required: + - compatible + - reg + - interrupts + - clocks + - "#clock-cells" + - regulators + - gpio-controller + - "#gpio-cells" + +additionalProperties: false + +examples: + - | + #include + #include + i2c { + #address-cells =3D <1>; + #size-cells =3D <0>; + pmic: pmic@4b { + compatible =3D "rohm,bd71828"; + reg =3D <0x4b>; + + interrupt-parent =3D <&gpio1>; + interrupts =3D <29 IRQ_TYPE_LEVEL_LOW>; + + clocks =3D <&osc 0>; + #clock-cells =3D <0>; + clock-output-names =3D "bd71828-32k-out"; + + gpio-controller; + #gpio-cells =3D <2>; + gpio-reserved-ranges =3D <0 1>, <2 1>; + + rohm,charger-sense-resistor-ohms =3D <10000000>; + + regulators { + buck1: BUCK1 { + regulator-name =3D "buck1"; + regulator-min-microvolt =3D <500000>; + regulator-max-microvolt =3D <2000000>; + regulator-ramp-delay =3D <2500>; + }; + buck2: BUCK2 { + regulator-name =3D "buck2"; + regulator-min-microvolt =3D <500000>; + regulator-max-microvolt =3D <2000000>; + regulator-ramp-delay =3D <2500>; + }; + buck3: BUCK3 { + regulator-name =3D "buck3"; + regulator-min-microvolt =3D <1200000>; + regulator-max-microvolt =3D <2000000>; + }; + buck4: BUCK4 { + regulator-name =3D "buck4"; + regulator-min-microvolt =3D <1000000>; + regulator-max-microvolt =3D <1800000>; + }; + buck5: BUCK5 { + regulator-name =3D "buck5"; + regulator-min-microvolt =3D <2500000>; + regulator-max-microvolt =3D <3300000>; + }; + buck6: BUCK6 { + regulator-name =3D "buck6"; + regulator-min-microvolt =3D <500000>; + regulator-max-microvolt =3D <2000000>; + regulator-ramp-delay =3D <2500>; + }; + buck7: BUCK7 { + regulator-name =3D "buck7"; + regulator-min-microvolt =3D <500000>; + regulator-max-microvolt =3D <2000000>; + regulator-ramp-delay =3D <2500>; + }; + ldo1: LDO1 { + regulator-name =3D "ldo1"; + regulator-min-microvolt =3D <800000>; + regulator-max-microvolt =3D <3300000>; + }; + ldo2: LDO2 { + regulator-name =3D "ldo2"; + regulator-min-microvolt =3D <800000>; + regulator-max-microvolt =3D <3300000>; + }; + ldo3: LDO3 { + regulator-name =3D "ldo3"; + regulator-min-microvolt =3D <800000>; + regulator-max-microvolt =3D <3300000>; + }; + ldo4: LDO4 { + regulator-name =3D "ldo4"; + regulator-min-microvolt =3D <800000>; + regulator-max-microvolt =3D <3300000>; + }; + ldo5: LDO5 { + regulator-name =3D "ldo5"; + regulator-min-microvolt =3D <800000>; + regulator-max-microvolt =3D <3300000>; + }; + ldo6: LDO6 { + regulator-name =3D "ldo6"; + regulator-min-microvolt =3D <1800000>; + regulator-max-microvolt =3D <1800000>; + }; + ldo7_reg: LDO7 { + regulator-name =3D "ldo7"; + regulator-min-microvolt =3D <800000>; + regulator-max-microvolt =3D <3300000>; + }; + }; + + leds { + compatible =3D "rohm,bd71828-leds"; + + led-1 { + rohm,led-compatible =3D "bd71828-grnled"; + function =3D LED_FUNCTION_INDICATOR; + color =3D ; + }; + led-2 { + rohm,led-compatible =3D "bd71828-ambled"; + function =3D LED_FUNCTION_CHARGING; + color =3D ; + }; + }; + }; + }; --=20 2.51.0 --hIp+AjNzMwe9bvg8 Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEIx+f8wZb28fLKEhTeFA3/03aocUFAmj/W2oACgkQeFA3/03a ocU4Nwf+NZOvCrSF4EFmx/nHbcnTFfqwJ1Jb8JXrtp5JWuFJPue1mNQ0ESVweJFW 552k5nBinbVhlHWLuq56+bM8ieLe3G9ObLqGWX78xMS3lSELm6V6UvoyKul7YQKt mEm0YoEl5WZKB83E04m9BI1zdHOC3XB71rcKlaCVuRbYrKiLDM91LgX+9xRTq2z7 0wkrTT6ReMarMQIFag/iPeRLL20a+ihrb4CianUGSosz9RMiVo/wGB6PiPaKny25 B0qT+Yo5ZYhhDA2wts+EXCNt5o8SD2vbHrPtjXjH1+1SRxe9E0N1kxj6b6GcdnIA SoUwQcO7V0pBdq9sXCakati8B5O0Kg== =+VcJ -----END PGP SIGNATURE----- --hIp+AjNzMwe9bvg8-- From nobody Sat Feb 7 17:55:30 2026 Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com [209.85.167.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 021B02FF17F for ; Mon, 27 Oct 2025 11:46:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761565573; cv=none; b=jwWnbRiaX747uMKCndXilMB5VxW6DqeQ+r16JOt5HzLt3/TmdUZNaTqIhMxt2CqHnGq9BZYR5Ny7gu6vGsWPTnU/2Ljhkz/hJtcGUQ/o5c2aUnHbZPKxxqKiNRHKFrn/IT1HXw3CV5GlZpFm8ZO+Nv+aT0BPNwMTJ8JwkDo6Dpc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761565573; c=relaxed/simple; bh=o5X3qid/yfHH+BoyJqJHvmRGKTTPXZaHJ8WFRZQcNlE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qNlYIUvYgTm+6Q/Kd3v5ZRXZ+40xaqnO+pYXAGo/KL4NmnvcR8rHyE7JHvkMYWB9MMlpwWRZHwmx0fWIn+JuTJg6JJ9yhXNTmoX3x1a97Xxvf+3/3cjI2H0BExReRU1bUo8DH2ILZFi3EZXWtI2Fq6uHZGlBElOSqi/SkgZ9BqI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UHAh0e/6; arc=none smtp.client-ip=209.85.167.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UHAh0e/6" Received: by mail-lf1-f44.google.com with SMTP id 2adb3069b0e04-586883eb9fbso5518138e87.1 for ; Mon, 27 Oct 2025 04:46:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761565569; x=1762170369; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=5wthRWPyiVp8yh4VwotqDPqYh//R/kAW37sGEOtokSs=; b=UHAh0e/6RVCghKxy6if56ZY65mQbkLTGI+qrMbV4hqVAxukBmuRSvZtNf/fs+Afw61 qJslBlMXM31vuLRC14d6QIz6Cg2TVOeINjbjITwCU2hfQo9jel9cFBbbaa4UTY4wLCkp rp1ytV8xR46a9YoCFPjMm2mnTEdtUCWKCOtcr6gnj92T4/3UNloEdwwEA5dN4k1lmgUe diWXbfRr1w5zsRPEATqhEDZIgW8DM1xx6CQBxh6r8E2y4PvAYWSf0hBWABXuDDCj7cjz KMIf4c2R9lMbQcYUzKjRyEp+FriZUEFcGLul+avSMf0e4N3uQlMQYyBahw82MI2nHFZ1 2s+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761565569; x=1762170369; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=5wthRWPyiVp8yh4VwotqDPqYh//R/kAW37sGEOtokSs=; b=AiBD4YhjQ7DaLuH/AXHF71ryE9NZgA2CjTNWKAB7vRxeS3ABZGKO0/XhkfK6TqJ/R8 MEyMYsYfUhk5xIfY1JuhU1w8rbpEquQsDoexO4Uv8Emy3Fb+IiJ0BjblZODGtYVwxDXo 8PSDYFXkibIYtrGzdq93vtWyEQySRx4F68/GDTZ0gobtKJbScNP7sNRseyTQ/jSzMNeH GLYFQjhDXHpmwYg1ushnu9X7gKbu9IFyFMoT4S54Hlq1W6zCsz4GdgITvvCMX6tvomoN dD8+Fa8LpBg5+KvZyIt/DUgPxgP1JVCFrnJwHaqpI1dtrzMVrPgjKmhPCIJA+jql4Ti7 RqjQ== X-Forwarded-Encrypted: i=1; AJvYcCVZp9wRD7Z3KK15oMv0Viqsv2CqKvV7iACqMJsCRGJVR2T4B/GOX0MhLiRdo4R80BqCaLy4cgZ1o0GHNeU=@vger.kernel.org X-Gm-Message-State: AOJu0YwTktDsMVOY3qgGHVtCILFt+8rZ0GGBqPQeFhWmBIIQHy8rgL+g fMIQZMq4fE34tqMSuhNcRrGSGkyCfsGtpFX7Yk4zGFQf4lukbo9Tj3pB X-Gm-Gg: ASbGnctuk6ODTRiZqG9pgY8BnxIJBFbHCZRW+YqOulzsNCHRx750nOATBH7Y9znysaf /NUWfmP9QX+UC0ua9/rVfHyaGTbMODHPoh59TnSYQ7CmOtU3jRNVWVBDEhbbviHQfiA4u9FYmfK +OHGbCL0JriENa7aFlq6E8jALQ2A1k1frZ9FrQ9ybgpmam3qihcwrO//wcf58LdUK8lPM0fcXfR I2b5quVI+hR2au4edpNSEWjkjNTaTXQsY/ZMflvKId1U1OK8vHqm8DAex82/7BMDwJWA0cqGRHH IWITnY+yLvqnoyVHR5CCf4DgUn2pnWtXlYD9rrK04eDThcR3rIzZjGjJWghjY8hi0SRIa2uJoLX nKkzQxwXYp6ha2EcE6hOHp3JcWEsqxQjTHVzqmsZij8f/ntu4Uq1fLpsmbDKNyeg+UOy9iT+hI1 yXSgBkpx4= X-Google-Smtp-Source: AGHT+IGpx5VaEstHr/dfUOeY/sT/AIsaR48RyvzDra31HtwNJ+UB6/DopkQBca9Vf1sT5NaznaxtPQ== X-Received: by 2002:a05:6512:4047:20b0:591:eab5:d8dc with SMTP id 2adb3069b0e04-591eab5dd39mr5211536e87.35.1761565568841; Mon, 27 Oct 2025 04:46:08 -0700 (PDT) Received: from mva-rohm ([2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-59301f558a3sm2221582e87.51.2025.10.27.04.46.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Oct 2025 04:46:07 -0700 (PDT) Date: Mon, 27 Oct 2025 13:46:04 +0200 From: Matti Vaittinen To: Matti Vaittinen , Matti Vaittinen Cc: Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Sebastian Reichel , Liam Girdwood , Mark Brown , Michael Turquette , Stephen Boyd , Matti Vaittinen , Linus Walleij , Bartosz Golaszewski , Andreas Kemnade , Alexandre Belloni , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-rtc@vger.kernel.org Subject: [PATCH v2 05/15] dt-bindings: leds: bd72720: Add BD72720 Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="4hcLA+ux7eVKOsxx" Content-Disposition: inline In-Reply-To: --4hcLA+ux7eVKOsxx Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Add the ROHM BD72720 documentation to the binding documents. Signed-off-by: Matti Vaittinen Acked-by: Krzysztof Kozlowski --- NOTE: The Linux LED driver does currently have: values bd72720-grnled and bd72720-ambled for the rohm,led-compatible. These are handled identically to the existing bd71828-grnled and bd71828-ambled and should be removed from the driver. Thus they are not documented in the binding document. Furthermore, the BD72720 Linux driver does not use the compatible property from the LED node. The Linux driver is load and probed based on the PMIC compatible in the MFD node. Thus no compatible string for the BD72720 LED node is added. --- Revision history: RFCv1 =3D>: - No changes --- .../devicetree/bindings/leds/rohm,bd71828-leds.yaml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/leds/rohm,bd71828-leds.yaml = b/Documentation/devicetree/bindings/leds/rohm,bd71828-leds.yaml index b7a3ef76cbf4..64cc40523e3d 100644 --- a/Documentation/devicetree/bindings/leds/rohm,bd71828-leds.yaml +++ b/Documentation/devicetree/bindings/leds/rohm,bd71828-leds.yaml @@ -10,11 +10,12 @@ maintainers: - Matti Vaittinen =20 description: | - This module is part of the ROHM BD71828 MFD device. For more details - see Documentation/devicetree/bindings/mfd/rohm,bd71828-pmic.yaml. + This module is part of the ROHM BD71828 and BD72720 MFD device. For more + details see Documentation/devicetree/bindings/mfd/rohm,bd71828-pmic.yaml + and Documentation/devicetree/bindings/mfd/rohm,bd72720-pmic.yaml =20 The LED controller is represented as a sub-node of the PMIC node on the = device - tree. + tree. This should be located under "leds" - node in PMIC node. =20 The device has two LED outputs referred as GRNLED and AMBLED in data-she= et. =20 --=20 2.51.0 --4hcLA+ux7eVKOsxx Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEIx+f8wZb28fLKEhTeFA3/03aocUFAmj/W3sACgkQeFA3/03a ocW9fgf/RpKlDcHIMKbMyCIcpDbELXKdqHFVQmRDH0oXD++RG0QLz4MUO5Meanix Lrn+YT27QBVb307Hptc/7Ui9Ot+0VgjqhoF8Kam4X5M7ZTI2GFD9oIDIzzUv6G7s zbax4mKZSypJulHy0njs+VSFo37GrNcXe3oEzgEUxs7kkSz6vQEAvm6lrRZQd6Gm 0KE3eVgWb8y0ImoU9FBdjOfc6cvE0irhzNKx1POEAnePyzqwo1OlVB9p3WI9IB7c D1k3RxGwMXtl6Ze18F06LcJvEpkZUH597P+JODLa3ks12bveEQ1ncLgRlgoe6vZt jq5wDk7fUJq9ysDNwnZpCtWENVcbcw== =m6hY -----END PGP SIGNATURE----- --4hcLA+ux7eVKOsxx-- From nobody Sat Feb 7 17:55:30 2026 Received: from mail-lj1-f170.google.com (mail-lj1-f170.google.com [209.85.208.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 743362FE58E for ; Mon, 27 Oct 2025 11:46:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761565589; cv=none; b=QSROBYZSA5aEtgeucNPEMKyPjG7GS1gmaOF7hIf37NZzSZ/725kRD+aZEDvDg9fjQvZTZrfs74M5+Kr4cVM3O7LtH7oJMeP7sKRWr26CRtPr+E9A1e6ZqDY6PfbRhaZuiyuPRlB5lVbusmsonePxuTpQpVP7PpmkLLQEQdQsc94= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761565589; c=relaxed/simple; bh=X8Txm7kc9NXs2r256KmcYLuDmAR0emVi9S0sVtw0zWA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=VaSQD6gaDCv/sMXP6m0SzPCbr9I0LFN2r6q5HSXbEomriqcAq9equrgfMWrWCO7MKmrfD2R+D/Rj+PoAY5kDxKKigCfM0ZB8sgtoYLOVbpI07tW68PQKxf+DibG3LR4EJ+gLL9+3AfNVS2geTFxEWZcw2IwwV89i3BtGaeQcGuE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Zzn0a5qA; arc=none smtp.client-ip=209.85.208.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Zzn0a5qA" Received: by mail-lj1-f170.google.com with SMTP id 38308e7fff4ca-3717780ea70so59818441fa.1 for ; Mon, 27 Oct 2025 04:46:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761565586; x=1762170386; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=q8/LJkLd6VtsTiiJs7/2Xg8b/Gt7K4vmantUteWzghg=; b=Zzn0a5qACylBxIJxs7qh0SSk247rpH3cEUne5bvCp8DQ+wwZUfPPpm9EgJJqcStFVB nSAgGecjNY98RMeECl8/vErgBsrnVhliFDH+1v66fPDiqx43cRdRCXnDmeiNWa11gCJw GnBxYEuqcy4wAEXUPRQsirWKE7ZzOwBd3Q/bkwVbEFguEGCESgf1KR19GKfY6DKKmiyX GPj0GAmVbpZQzrAE2oph7TxEe7ml5pu6jxCNAdcnct0VFd6b85ccGQna0c0rmzRS42Q7 pP5i/O+iq5AGkIPd8fk7XDzknD1vuiy+Xtb9DOluLKVdmdZ994XWaDaoyydXKmtFCF+i h0yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761565586; x=1762170386; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=q8/LJkLd6VtsTiiJs7/2Xg8b/Gt7K4vmantUteWzghg=; b=XjNl41dEGIYOLk/hyhFcNiyZ3pwv8XpLuQlPvyswXT4MeKPA01fwsG7ZbKTv0vSUVZ wd7GW3cxdA4O+ofuEHTE+kHqT9JNVCyDvyTuaEQ4lgago0Y5Bd14WMe8viuijVUz0a0v b3mjOgKLVRagfxxeZq14nYAJxuDtQ5Kl8Enc3ClOd8xhtK/BSl5UIuU42AmL5zM/0Dj2 N9IG7mw5xpzf8TkLNvS4SG5iPQOlFnmQJMj5YigZXlTtXStvaP3+4QuKnkg8uKO0OOLg qb6vEc1nXqFDm1uzAYfGJNDULct5l2QBdTUon6B7eKx4KPtFYFylKB94JNi4kGOo88LE 3T0A== X-Forwarded-Encrypted: i=1; AJvYcCVnvofw1B9FD9O/Jf0KFVFa7U/d3I4q47//yF8ZBHpujM6GF4BnjqZNK/3XfbuaEMJib+D9DzL1xg9hg4c=@vger.kernel.org X-Gm-Message-State: AOJu0Yy7eIszpTEDOQthU3CKfePCBfG3A8B42tNlXhYoTL52tUvLuXDQ acYdSuai/0xhdK870P3mb8YNgIIYmuIyGgGbzCprmZqBSTYldojYwH++ X-Gm-Gg: ASbGncs+ajD9Un+Himgxe46QMjOsrAQwjKK6UR2KTffy6YXKF62eK7Hx08YNR3u5AKS h1gVKpyuYF4tejmYOXLgEZfFyS+VN/O7yBv2gRh5EAVpEtTyf+qPRuamQ/iREr9LaUjYxglVzeW 0dzQFDgoUWK3VGqPMGN6ulrkJb7gjimDhr4D6SrqLrevFJIfGl/OdpcYu8juro0s+QDyLUQC6yQ HsrAb+izKNPy0EZ4j8Qrpm6EsaE0YfiGK3zUi+FVhmqfi49OPbsr/Bn+Gc72zksMTQgLc+xlfXL I7m+m5HOardv3QmKlviPQu0NI3WDsSNcH3Ld9sjVF55TyH2UpaNYkQ49RnP9YHXaQk5ob/3Dnm9 hv0DLOsi0d3LccUTnfS7iW9qUuwi9UM/O6NnXGMnEZMMaj0gIvTQ4YKg56cQA2yNWbclIXRwSpU kZaCYFMvOiptKcvlY+RQ== X-Google-Smtp-Source: AGHT+IGoMGmaOl5pCr2S2zDRvn1ZEtFuP5D29PR12nByl2G/phztcf3r74wdfl+o7a+i+LtD36g7XQ== X-Received: by 2002:a05:651c:1989:b0:36d:6d71:4ec5 with SMTP id 38308e7fff4ca-377978ab84emr116585471fa.17.1761565585321; Mon, 27 Oct 2025 04:46:25 -0700 (PDT) Received: from mva-rohm ([2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-378ee0d43c7sm18901911fa.40.2025.10.27.04.46.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Oct 2025 04:46:24 -0700 (PDT) Date: Mon, 27 Oct 2025 13:46:19 +0200 From: Matti Vaittinen To: Matti Vaittinen , Matti Vaittinen Cc: Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Sebastian Reichel , Liam Girdwood , Mark Brown , Michael Turquette , Stephen Boyd , Matti Vaittinen , Linus Walleij , Bartosz Golaszewski , Andreas Kemnade , Alexandre Belloni , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-rtc@vger.kernel.org Subject: [PATCH v2 06/15] mfd: rohm-bd71828: Use regmap_reg_range() Message-ID: <2ad8c8b15a9eef421b5a1f83a38fd899677ac3c8.1761564043.git.mazziesaccount@gmail.com> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="yX+aGkytnEYWZinw" Content-Disposition: inline In-Reply-To: --yX+aGkytnEYWZinw Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" The regmap range tables tend to be somewhat verbose. Using the regmap_reg_range() can make the definitions slightly mode compact. Tidy the regmap range tables by using the regmap_reg_range(). Signed-off-by: Matti Vaittinen --- Revision history: RFCv1 =3D> v2: - New patch --- drivers/mfd/rohm-bd71828.c | 64 +++++++++++--------------------------- 1 file changed, 18 insertions(+), 46 deletions(-) diff --git a/drivers/mfd/rohm-bd71828.c b/drivers/mfd/rohm-bd71828.c index 84a64c3b9c9f..2a43005b67ee 100644 --- a/drivers/mfd/rohm-bd71828.c +++ b/drivers/mfd/rohm-bd71828.c @@ -157,55 +157,27 @@ static struct mfd_cell bd71828_mfd_cells[] =3D { }; =20 static const struct regmap_range bd71815_volatile_ranges[] =3D { - { - .range_min =3D BD71815_REG_SEC, - .range_max =3D BD71815_REG_YEAR, - }, { - .range_min =3D BD71815_REG_CONF, - .range_max =3D BD71815_REG_BAT_TEMP, - }, { - .range_min =3D BD71815_REG_VM_IBAT_U, - .range_max =3D BD71815_REG_CC_CTRL, - }, { - .range_min =3D BD71815_REG_CC_STAT, - .range_max =3D BD71815_REG_CC_CURCD_L, - }, { - .range_min =3D BD71815_REG_VM_BTMP_MON, - .range_max =3D BD71815_REG_VM_BTMP_MON, - }, { - .range_min =3D BD71815_REG_INT_STAT, - .range_max =3D BD71815_REG_INT_UPDATE, - }, { - .range_min =3D BD71815_REG_VM_VSYS_U, - .range_max =3D BD71815_REG_REX_CTRL_1, - }, { - .range_min =3D BD71815_REG_FULL_CCNTD_3, - .range_max =3D BD71815_REG_CCNTD_CHG_2, - }, + regmap_reg_range(BD71815_REG_SEC, BD71815_REG_YEAR), + regmap_reg_range(BD71815_REG_CONF, BD71815_REG_BAT_TEMP), + regmap_reg_range(BD71815_REG_VM_IBAT_U, BD71815_REG_CC_CTRL), + regmap_reg_range(BD71815_REG_CC_STAT, BD71815_REG_CC_CURCD_L), + regmap_reg_range(BD71815_REG_VM_BTMP_MON, BD71815_REG_VM_BTMP_MON), + regmap_reg_range(BD71815_REG_INT_STAT, BD71815_REG_INT_UPDATE), + regmap_reg_range(BD71815_REG_VM_VSYS_U, BD71815_REG_REX_CTRL_1), + regmap_reg_range(BD71815_REG_FULL_CCNTD_3, BD71815_REG_CCNTD_CHG_2), }; =20 static const struct regmap_range bd71828_volatile_ranges[] =3D { - { - .range_min =3D BD71828_REG_PS_CTRL_1, - .range_max =3D BD71828_REG_PS_CTRL_1, - }, { - .range_min =3D BD71828_REG_PS_CTRL_3, - .range_max =3D BD71828_REG_PS_CTRL_3, - }, { - .range_min =3D BD71828_REG_RTC_SEC, - .range_max =3D BD71828_REG_RTC_YEAR, - }, { - /* - * For now make all charger registers volatile because many - * needs to be and because the charger block is not that - * performance critical. - */ - .range_min =3D BD71828_REG_CHG_STATE, - .range_max =3D BD71828_REG_CHG_FULL, - }, { - .range_min =3D BD71828_REG_INT_MAIN, - .range_max =3D BD71828_REG_IO_STAT, - }, + regmap_reg_range(BD71828_REG_PS_CTRL_1, BD71828_REG_PS_CTRL_1), + regmap_reg_range(BD71828_REG_PS_CTRL_3, BD71828_REG_PS_CTRL_3), + regmap_reg_range(BD71828_REG_RTC_SEC, BD71828_REG_RTC_YEAR), + /* + * For now make all charger registers volatile because many + * needs to be and because the charger block is not that + * performance critical. + */ + regmap_reg_range(BD71828_REG_CHG_STATE, BD71828_REG_CHG_FULL), + regmap_reg_range(BD71828_REG_INT_MAIN, BD71828_REG_IO_STAT), }; =20 static const struct regmap_access_table bd71815_volatile_regs =3D { --=20 2.51.0 --yX+aGkytnEYWZinw Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEIx+f8wZb28fLKEhTeFA3/03aocUFAmj/W4sACgkQeFA3/03a ocVpYwgApX+kp0HBYeSpSy5UViGym7Dedvy9fcHINt+oeCJZEs7sGMWWjus+vkfI u8E7Cm85Di9wLPSGkApvouqpjSIQiHdypYDtFN+gTkgmUHN0hk4UlplixA1ndJmW BYkG4Ns5RmDWoXUprdSh0AWjE/NOxPmfG0EmDOaUvzAkuTFrxHK/bNFJZOdLv4fX qmLQqmsvRV1AxvZwwxSBVj9dTQ9KFR8q1rhlo2G3Bmxs7wDIaXNZuu32OTY59Eeg DNhxIXic+lhDozq7w2x/MK6p5mUYW8g1WH6PfdYcT0fxuGxD3PpnVV+Wu7A1cJTt lpR//jRSTmONw5WWN7qp5BMEbfys8A== =cZvA -----END PGP SIGNATURE----- --yX+aGkytnEYWZinw-- From nobody Sat Feb 7 17:55:30 2026 Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 43580286D5C for ; Tue, 28 Oct 2025 06:06:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761631601; cv=none; b=Kenr1wuzT9v08ppQ4nSRaU7drqSkm+dKDp9w3BSdvA8J2yPoYPl9/RQCaLPZbO7Y3+XndixlJfcRF5Op2KwTN0xne7Q6dEGaX6dZJwpzr7RRtRHrNv6Npc13JTzfNzMYlEO0ll5Cd5S+9y1pT+qKnT00kf7PvZsoiA3hB6kFJUw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761631601; c=relaxed/simple; bh=0HXAWxD2wU4akP9pcWU9G25jF3iZslCbq6r8RbCec5w=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mxLxs3/fKwoS8+2/bIknqUpMacJsJz3L801/MAYU6cdYbMXaNQjl2uut9fw5dR4g/Qn7Tuf00OfmAZcpCXXLPloHbfXTxT0QV37SYaaEigbaVymVtirLmMjdjePdCixzVaWLqhebUgY0SVG5uJVciw4CtfmtnavwTFEjBMvbrXI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=l24MqtdR; arc=none smtp.client-ip=209.85.167.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="l24MqtdR" Received: by mail-lf1-f43.google.com with SMTP id 2adb3069b0e04-592fcf7a1ceso4806615e87.1 for ; Mon, 27 Oct 2025 23:06:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761631594; x=1762236394; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=NiW1gE6UuMHLji0asFIlcgJ60qxsOHVZSJV5RZIROFE=; b=l24MqtdR4XlrGZ4AQrWIMIsfKMBgtQld3ANOghdrRXUj4oanYvDNMRoXbQ5BhL/lSl qZS+T7MpRLACOBI7F3wi6YhWf9sZjh7+P7pQNABFEACefezLX/fPgQCZME+yZXxwURdz bjLGEe5D13ZE0JLyL4GCoaUi3Z2WmRIP1bkdAILEAr7oS6pVM5xXV47FUTiABrv6uunC zet+awwqhA3A1UPUFCGmsQfeBZphhMVXTkcTiejhQrzBFcXxiBpqpfuVo/Vcmg3cmeP2 mmY49QEmbbHi9DwZR9NIdDss7s3x1qB85Z9b/JRp00EjwqdyDPP4hjucF0e/BMhw0FeW s40g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761631594; x=1762236394; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=NiW1gE6UuMHLji0asFIlcgJ60qxsOHVZSJV5RZIROFE=; b=EAmRX9rErTlfLJ5uukTnJzk1wIHkpQx8eRcgS0pqejd0Cdhb1KQtyHOJUoi7L0CsCz XYmJdTn8uxxfhGeyYnOENzznatJiGmht3vx4a48hhwJF2Vt9kKiQk0nyEz4Bs9gTMids PZ4+tSntYVRIRvYJwf43bsM33ltPJJKtDdQIZQ266vhxR3w2zE5YzumY9zl+syy2zxzu HkqtubwfClkoYcnWnmBoS1ne2KKThZHxTeaEF3HKWGq5deZpGqHL/orG0R73rLTZpRrD YFE9vPIX5fzpNjV341HAZnmcsBopnKtWuw1pd2yXDjYqmuw6rdaWzAlMGLpEECbzkwMN 7Bng== X-Forwarded-Encrypted: i=1; AJvYcCV9p7XIMHp65dsUby/PHgt1cB2NCof8PE+q+8DLAnpxCq+FbvuHDvHhkIoEqtWcSjHeMFcEX9gR5+FRVdI=@vger.kernel.org X-Gm-Message-State: AOJu0YzVxDbA1jO8Qy9XdDx8WLP40Vc3ZRJvsPxxVagc0IWtYTixPvmj 7uj0LVitHN2ucuJi1+zqjn4hGfUqGEQ0By1ECXSvXIMqILG3YAj+lDer X-Gm-Gg: ASbGncs9jE8W76VmLelO//XapvVZ404xcr4Y62gPPJ2+cJXvXT6csdq55+OQAoLGrk6 hk3DOdLoBb9Vd0QgxxON/02D4fxxXlV6QvxuDeAJnadnbcEm8YIJ+3/mLIptSNqvZg0xoGHtF9l Il3101oNVnwMfcceWrCdp/JARI+q7OF/2KaFWmerwwoo0QFOZdede83Y29SalAerjobeNUOHjaS 13YoneLICJc1BITSdNflXlEwqyh9ZZP6HDMvIr2EpC8/BWRNOUckga5UXNWaTAb59mxU/FlxRKG Scoa7QwvvTLV1gMb2BiTFu1isiNxmeyvow9kk7LzQh4w8c6Cf96Ae9ql453lO23DVUn5b3my2TG 4Ikvc09B/jXxelRpXDYugQMLAhDnDd2Nlaggtdg70VXW5hNYZbhAl2uqWHTVwAvssWYMTeUYVry BnfQzVj9k= X-Google-Smtp-Source: AGHT+IHa56y4Zi3qha4iAJhBEnuqzurYguVkbdli0M1K2RZijUEbPRaE1K/NALaFW9KMsfi3aaLMxA== X-Received: by 2002:a05:6512:3e11:b0:593:a94:7381 with SMTP id 2adb3069b0e04-5930e9cc5a9mr883711e87.36.1761631593833; Mon, 27 Oct 2025 23:06:33 -0700 (PDT) Received: from mva-rohm ([2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-59301f50b1bsm2773923e87.39.2025.10.27.23.06.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Oct 2025 23:06:31 -0700 (PDT) Date: Tue, 28 Oct 2025 08:06:21 +0200 From: Matti Vaittinen To: Matti Vaittinen Cc: linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-rtc@vger.kernel.org Subject: [PATCH v2 07/15] mfd: bd71828: Support ROHM BD72720 Message-ID: <4c964cef46a396209052aa4194d08fc03f989647.1761564043.git.mazziesaccount@gmail.com> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="/jrsf5iJRM3aFpvr" Content-Disposition: inline In-Reply-To: --/jrsf5iJRM3aFpvr Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" The ROHM BD72720 is a power management IC which continues the BD71828 family of PMICs. Similarly to the BD71815 and BD71828, the BD72720 integrates regulators, charger, RTC, clock gate and GPIOs. The main difference to the earlier PMICs is that the BD72720 has two different I2C slave addresses. In addition to the registers behind the 'main I2C address', most of the charger (and to some extent LED) control is done via registers behind a 'secondary I2C slave address', 0x4c. Signed-off-by: Matti Vaittinen --- For some reason the gmail SMTP server refused from sending this (several times). If anyone receives this more than once - I am sorry! In order to get this through I now send this only to the lists, dropping all the direct CCs... Seems I need to find alternate SMTP server for my patches :( Revision history: RFCv1 =3D> v2: (Mostly addressed comments from Lee and Andreas) - Use stacked regmaps to avoid platform data and the tango with multiple regmaps in the power-supply driver - Use regmap_reg_range() - make it clear bd72720_irq_type_base is an array - tab-out definitions in the bd72720 header - minor styling Note: This patch depends on the series: "power: supply: add charger for BD71828" by Andreas: https://lore.kernel.org/all/20250918-bd71828-charger-v5-0-851164839c28@kemn= ade.info/ There are some new variants being planned. Most notably, the BD73900 should be almost identical to the BD72720 - for everything else except the charger block. --- drivers/mfd/Kconfig | 18 +- drivers/mfd/rohm-bd71828.c | 488 +++++++++++++++++++++++- include/linux/mfd/rohm-bd72720.h | 634 +++++++++++++++++++++++++++++++ include/linux/mfd/rohm-generic.h | 1 + 4 files changed, 1126 insertions(+), 15 deletions(-) create mode 100644 include/linux/mfd/rohm-bd72720.h diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig index 6cec1858947b..61e238b316f4 100644 --- a/drivers/mfd/Kconfig +++ b/drivers/mfd/Kconfig @@ -2211,20 +2211,22 @@ config MFD_ROHM_BD718XX and emergency shut down as well as 32,768KHz clock output. =20 config MFD_ROHM_BD71828 - tristate "ROHM BD71828 and BD71815 Power Management IC" + tristate "ROHM BD718[15/28/79], BD72720 and BD73900 PMICs" depends on I2C=3Dy depends on OF select REGMAP_I2C select REGMAP_IRQ select MFD_CORE help - Select this option to get support for the ROHM BD71828 and BD71815 - Power Management ICs. BD71828GW and BD71815AGW are single-chip power - management ICs mainly for battery-powered portable devices. - The BD71828 integrates 7 buck converters and 7 LDOs. The BD71815 - has 5 bucks, 7 LDOs, and a boost for driving LEDs. Both ICs provide - also a single-cell linear charger, a Coulomb counter, a real-time - clock (RTC), GPIOs and a 32.768 kHz clock gate. + Select this option to get support for the ROHM BD71815, BD71828, + BD71879, BD72720 and BD73900 Power Management ICs. These are + single-chip power management ICs mainly for battery-powered portable + devices. + The BD71815 has 5 bucks, 7 LDOs, and a boost for driving LEDs. + The BD718[28/79] have 7 buck converters and 7 LDOs. + The BD72720 and the BD73900 have 10 bucks and 11 LDOs. + All ICs provide a single-cell linear charger, a Coulomb counter, + a real-time clock (RTC), GPIOs and a 32.768 kHz clock gate. =20 config MFD_ROHM_BD957XMUF tristate "ROHM BD9576MUF and BD9573MUF Power Management ICs" diff --git a/drivers/mfd/rohm-bd71828.c b/drivers/mfd/rohm-bd71828.c index 2a43005b67ee..2e546aa60ffd 100644 --- a/drivers/mfd/rohm-bd71828.c +++ b/drivers/mfd/rohm-bd71828.c @@ -2,7 +2,7 @@ // // Copyright (C) 2019 ROHM Semiconductors // -// ROHM BD71828/BD71815 PMIC driver +// ROHM BD718[15/28/79] and BD72720 PMIC driver =20 #include #include @@ -13,12 +13,29 @@ #include #include #include +#include #include #include #include #include #include =20 +#define BD72720_TYPED_IRQ_REG(_irq, _stat_offset, _mask, _type_offset) = \ + [_irq] =3D { \ + .reg_offset =3D (_stat_offset), \ + .mask =3D (_mask), \ + { \ + .type_reg_offset =3D (_type_offset), \ + .type_reg_mask =3D BD72720_GPIO_IRQ_TYPE_MASK, \ + .type_rising_val =3D BD72720_GPIO_IRQ_TYPE_RISING, \ + .type_falling_val =3D BD72720_GPIO_IRQ_TYPE_FALLING, \ + .type_level_low_val =3D BD72720_GPIO_IRQ_TYPE_LOW, \ + .type_level_high_val =3D BD72720_GPIO_IRQ_TYPE_HIGH, \ + .types_supported =3D IRQ_TYPE_EDGE_BOTH | \ + IRQ_TYPE_LEVEL_HIGH | IRQ_TYPE_LEVEL_LOW, \ + }, \ + } + static struct gpio_keys_button button =3D { .code =3D KEY_POWER, .gpio =3D -1, @@ -43,6 +60,12 @@ static const struct resource bd71828_rtc_irqs[] =3D { DEFINE_RES_IRQ_NAMED(BD71828_INT_RTC2, "bd70528-rtc-alm-2"), }; =20 +static const struct resource bd72720_rtc_irqs[] =3D { + DEFINE_RES_IRQ_NAMED(BD72720_INT_RTC0, "bd70528-rtc-alm-0"), + DEFINE_RES_IRQ_NAMED(BD72720_INT_RTC1, "bd70528-rtc-alm-1"), + DEFINE_RES_IRQ_NAMED(BD72720_INT_RTC2, "bd70528-rtc-alm-2"), +}; + static const struct resource bd71815_power_irqs[] =3D { DEFINE_RES_IRQ_NAMED(BD71815_INT_DCIN_RMV, "bd71815-dcin-rmv"), DEFINE_RES_IRQ_NAMED(BD71815_INT_CLPS_OUT, "bd71815-dcin-clps-out"), @@ -156,6 +179,74 @@ static struct mfd_cell bd71828_mfd_cells[] =3D { }, }; =20 +static const struct resource bd72720_power_irqs[] =3D { + DEFINE_RES_IRQ_NAMED(BD72720_INT_VBUS_RMV, "bd72720_int_vbus_rmv"), + DEFINE_RES_IRQ_NAMED(BD72720_INT_VBUS_DET, "bd72720_int_vbus_det"), + DEFINE_RES_IRQ_NAMED(BD72720_INT_VBUS_MON_RES, "bd72720_int_vbus_mon_res"= ), + DEFINE_RES_IRQ_NAMED(BD72720_INT_VBUS_MON_DET, "bd72720_int_vbus_mon_det"= ), + DEFINE_RES_IRQ_NAMED(BD72720_INT_VSYS_MON_RES, "bd72720_int_vsys_mon_res"= ), + DEFINE_RES_IRQ_NAMED(BD72720_INT_VSYS_MON_DET, "bd72720_int_vsys_mon_det"= ), + DEFINE_RES_IRQ_NAMED(BD72720_INT_VSYS_UV_RES, "bd72720_int_vsys_uv_res"), + DEFINE_RES_IRQ_NAMED(BD72720_INT_VSYS_UV_DET, "bd72720_int_vsys_uv_det"), + DEFINE_RES_IRQ_NAMED(BD72720_INT_VSYS_LO_RES, "bd72720_int_vsys_lo_res"), + DEFINE_RES_IRQ_NAMED(BD72720_INT_VSYS_LO_DET, "bd72720_int_vsys_lo_det"), + DEFINE_RES_IRQ_NAMED(BD72720_INT_VSYS_OV_RES, "bd72720_int_vsys_ov_res"), + DEFINE_RES_IRQ_NAMED(BD72720_INT_VSYS_OV_DET, "bd72720_int_vsys_ov_det"), + DEFINE_RES_IRQ_NAMED(BD72720_INT_BAT_ILIM, "bd72720_int_bat_ilim"), + DEFINE_RES_IRQ_NAMED(BD72720_INT_CHG_DONE, "bd72720_int_chg_done"), + DEFINE_RES_IRQ_NAMED(BD72720_INT_EXTEMP_TOUT, "bd72720_int_extemp_tout"), + DEFINE_RES_IRQ_NAMED(BD72720_INT_CHG_WDT_EXP, "bd72720_int_chg_wdt_exp"), + DEFINE_RES_IRQ_NAMED(BD72720_INT_BAT_MNT_OUT, "bd72720_int_bat_mnt_out"), + DEFINE_RES_IRQ_NAMED(BD72720_INT_BAT_MNT_IN, "bd72720_int_bat_mnt_in"), + DEFINE_RES_IRQ_NAMED(BD72720_INT_CHG_TRNS, "bd72720_int_chg_trns"), + + DEFINE_RES_IRQ_NAMED(BD72720_INT_VBAT_MON_RES, "bd72720_int_vbat_mon_res"= ), + DEFINE_RES_IRQ_NAMED(BD72720_INT_VBAT_MON_DET, "bd72720_int_vbat_mon_det"= ), + DEFINE_RES_IRQ_NAMED(BD72720_INT_VBAT_SHT_RES, "bd72720_int_vbat_sht_res"= ), + DEFINE_RES_IRQ_NAMED(BD72720_INT_VBAT_SHT_DET, "bd72720_int_vbat_sht_det"= ), + DEFINE_RES_IRQ_NAMED(BD72720_INT_VBAT_LO_RES, "bd72720_int_vbat_lo_res"), + DEFINE_RES_IRQ_NAMED(BD72720_INT_VBAT_LO_DET, "bd72720_int_vbat_lo_det"), + DEFINE_RES_IRQ_NAMED(BD72720_INT_VBAT_OV_RES, "bd72720_int_vbat_ov_res"), + DEFINE_RES_IRQ_NAMED(BD72720_INT_VBAT_OV_DET, "bd72720_int_vbat_ov_det"), + DEFINE_RES_IRQ_NAMED(BD72720_INT_BAT_RMV, "bd72720_int_bat_rmv"), + DEFINE_RES_IRQ_NAMED(BD72720_INT_BAT_DET, "bd72720_int_bat_det"), + DEFINE_RES_IRQ_NAMED(BD72720_INT_DBAT_DET, "bd72720_int_dbat_det"), + DEFINE_RES_IRQ_NAMED(BD72720_INT_BAT_TEMP_TRNS, "bd72720_int_bat_temp_trn= s"), + DEFINE_RES_IRQ_NAMED(BD72720_INT_LOBTMP_RES, "bd72720_int_lobtmp_res"), + DEFINE_RES_IRQ_NAMED(BD72720_INT_LOBTMP_DET, "bd72720_int_lobtmp_det"), + DEFINE_RES_IRQ_NAMED(BD72720_INT_OVBTMP_RES, "bd72720_int_ovbtmp_res"), + DEFINE_RES_IRQ_NAMED(BD72720_INT_OVBTMP_DET, "bd72720_int_ovbtmp_det"), + DEFINE_RES_IRQ_NAMED(BD72720_INT_OCUR1_RES, "bd72720_int_ocur1_res"), + DEFINE_RES_IRQ_NAMED(BD72720_INT_OCUR1_DET, "bd72720_int_ocur1_det"), + DEFINE_RES_IRQ_NAMED(BD72720_INT_OCUR2_RES, "bd72720_int_ocur2_res"), + DEFINE_RES_IRQ_NAMED(BD72720_INT_OCUR2_DET, "bd72720_int_ocur2_det"), + DEFINE_RES_IRQ_NAMED(BD72720_INT_OCUR3_RES, "bd72720_int_ocur3_res"), + DEFINE_RES_IRQ_NAMED(BD72720_INT_OCUR3_DET, "bd72720_int_ocur3_det"), + DEFINE_RES_IRQ_NAMED(BD72720_INT_CC_MON1_DET, "bd72720_int_cc_mon1_det"), + DEFINE_RES_IRQ_NAMED(BD72720_INT_CC_MON2_DET, "bd72720_int_cc_mon2_det"), + DEFINE_RES_IRQ_NAMED(BD72720_INT_CC_MON3_DET, "bd72720_int_cc_mon3_det"), +}; + +static const struct mfd_cell bd72720_mfd_cells[] =3D { + { .name =3D "bd72720-pmic", }, + { .name =3D "bd72720-gpio", }, + { .name =3D "bd72720-led", }, + { .name =3D "bd72720-clk", }, + { + .name =3D "bd72720-power", + .resources =3D bd72720_power_irqs, + .num_resources =3D ARRAY_SIZE(bd72720_power_irqs), + }, { + .name =3D "bd72720-rtc", + .resources =3D bd72720_rtc_irqs, + .num_resources =3D ARRAY_SIZE(bd72720_rtc_irqs), + }, { + .name =3D "gpio-keys", + .platform_data =3D &bd71828_powerkey_data, + .pdata_size =3D sizeof(bd71828_powerkey_data), + }, +}; + static const struct regmap_range bd71815_volatile_ranges[] =3D { regmap_reg_range(BD71815_REG_SEC, BD71815_REG_YEAR), regmap_reg_range(BD71815_REG_CONF, BD71815_REG_BAT_TEMP), @@ -180,6 +271,87 @@ static const struct regmap_range bd71828_volatile_rang= es[] =3D { regmap_reg_range(BD71828_REG_INT_MAIN, BD71828_REG_IO_STAT), }; =20 +static const struct regmap_range bd72720_volatile_ranges_4b[] =3D { + regmap_reg_range(BD72720_REG_RESETSRC_1, BD72720_REG_RESETSRC_2), + regmap_reg_range(BD72720_REG_POWER_STATE, BD72720_REG_POWER_STATE), + /* The state indicator bit changes when new state is reached */ + regmap_reg_range(BD72720_REG_PS_CTRL_1, BD72720_REG_PS_CTRL_1), + regmap_reg_range(BD72720_REG_RCVNUM, BD72720_REG_RCVNUM), + regmap_reg_range(BD72720_REG_CONF, BD72720_REG_HALL_STAT), + regmap_reg_range(BD72720_REG_RTC_SEC, BD72720_REG_RTC_YEAR), + regmap_reg_range(BD72720_REG_INT_LVL1_STAT, BD72720_REG_INT_ETC2_SRC), +}; + +static const struct regmap_range bd72720_precious_ranges_4b[] =3D { + regmap_reg_range(BD72720_REG_INT_LVL1_STAT, BD72720_REG_INT_ETC2_STAT), +}; + +/* + * The BD72720 is an odd beast in that it contains two separate sets of + * registers, both starting from address 0x0. The twist is that these "pag= es" + * are behind different I2C slave addresses. Most of the registers are beh= ind + * a slave address 0x4b, which will be used as the "main" address for this + * device. + * Most of the charger related registers are located behind slave address = 0x4c. + * It is tempting to push the dealing with the charger registers and the e= xtra + * 0x4c device in power-supply driver - but perhaps it's better for the sa= ke of + * the cleaner re-use to deal with setting up all of the regmaps here. + * Furthermore, the LED stuff may need access to both of these devices. + * + * Instead of providing one of the regmaps to sub-devices in MFD platform = data, + * we create one more 'wrapper regmap' with custom read/write operations. = These + * custom accessors will select which of the 'real' regmaps to use, based = on + * the register address. + * The register addresses are 8-bit, so we add offset 0x100 to the address= es + * behind the secondary slave 0x4c. The 'wrapper' regmap can then detect t= he + * correct slave address based on the register address and call regmap_wri= te() + * and regmap_read() using correct 'real' regmap. This way the registers of + * both of the slaves can be accessed using one 'wrapper' regmap. + * + * NOTE: The added offsets mean that the defined addresses for slave 0x4c = must + * be used through the 'wrapper' regmap because the offset must be stripped + * from the register addresses. The 0x4b can be accessed both indirectly u= sing + * the 'wrapper' regmap, and directly using the 'real' regmap. + */ +#define BD72720_SECONDARY_I2C_SLAVE 0x4c + +struct bd72720_regmaps { + struct regmap *map1_4b; + struct regmap *map2_4c; +}; + +/* Translate the slave 0x4c wrapper register address to a real one */ +#define BD72720_REG_UNWRAP(reg) ((reg) - 0x100) + +/* Ranges given to 'real' 0x4c regmap must use unwrapped addresses. */ +#define BD72720_UNWRAP_REG_RANGE(startreg, endreg) \ + regmap_reg_range(BD72720_REG_UNWRAP(startreg), BD72720_REG_UNWRAP(endreg)) +static const struct regmap_range bd72720_volatile_ranges_4c[] =3D { + /* Status information */ + BD72720_UNWRAP_REG_RANGE(BD72720_REG_CHG_STATE, BD72720_REG_CHG_EN), + /* + * Under certain circumstances, write to some bits may be + * ignored + */ + BD72720_UNWRAP_REG_RANGE(BD72720_REG_CHG_CTRL, BD72720_REG_CHG_CTRL), + /* + * TODO: Ensure this is used to advertise state, not (only?) to + * control it. + */ + BD72720_UNWRAP_REG_RANGE(BD72720_REG_VSYS_STATE_STAT, BD72720_REG_VSYS_ST= ATE_STAT), + /* Measured data */ + BD72720_UNWRAP_REG_RANGE(BD72720_REG_VM_VBAT_U, BD72720_REG_VM_VF_L), + /* Self clearing bits */ + BD72720_UNWRAP_REG_RANGE(BD72720_REG_VM_VSYS_SA_MINMAX_CTRL, + BD72720_REG_VM_VSYS_SA_MINMAX_CTRL), + /* Counters, self clearing bits */ + BD72720_UNWRAP_REG_RANGE(BD72720_REG_CC_CURCD_U, BD72720_REG_CC_CTRL), + /* Self clearing bits */ + BD72720_UNWRAP_REG_RANGE(BD72720_REG_CC_CCNTD_CTRL, BD72720_REG_CC_CCNTD_= CTRL), + /* Self clearing bits */ + BD72720_UNWRAP_REG_RANGE(BD72720_REG_IMPCHK_CTRL, BD72720_REG_IMPCHK_CTRL= ), +}; + static const struct regmap_access_table bd71815_volatile_regs =3D { .yes_ranges =3D &bd71815_volatile_ranges[0], .n_yes_ranges =3D ARRAY_SIZE(bd71815_volatile_ranges), @@ -190,6 +362,21 @@ static const struct regmap_access_table bd71828_volati= le_regs =3D { .n_yes_ranges =3D ARRAY_SIZE(bd71828_volatile_ranges), }; =20 +static const struct regmap_access_table bd72720_volatile_regs_4b =3D { + .yes_ranges =3D &bd72720_volatile_ranges_4b[0], + .n_yes_ranges =3D ARRAY_SIZE(bd72720_volatile_ranges_4b), +}; + +static const struct regmap_access_table bd72720_precious_regs_4b =3D { + .yes_ranges =3D &bd72720_precious_ranges_4b[0], + .n_yes_ranges =3D ARRAY_SIZE(bd72720_precious_ranges_4b), +}; + +static const struct regmap_access_table bd72720_volatile_regs_4c =3D { + .yes_ranges =3D &bd72720_volatile_ranges_4c[0], + .n_yes_ranges =3D ARRAY_SIZE(bd72720_volatile_ranges_4c), +}; + static const struct regmap_config bd71815_regmap =3D { .reg_bits =3D 8, .val_bits =3D 8, @@ -206,10 +393,79 @@ static const struct regmap_config bd71828_regmap =3D { .cache_type =3D REGCACHE_MAPLE, }; =20 +static int regmap_write_wrapper(void *context, unsigned int reg, unsigned = int val) +{ + struct bd72720_regmaps *maps =3D context; + + if (reg < 0x100) + return regmap_write(maps->map1_4b, reg, val); + + reg =3D BD72720_REG_UNWRAP(reg); + + return regmap_write(maps->map2_4c, reg, val); +} + +static int regmap_read_wrapper(void *context, unsigned int reg, unsigned i= nt *val) +{ + struct bd72720_regmaps *maps =3D context; + + if (reg < 0x100) + return regmap_read(maps->map1_4b, reg, val); + + reg =3D BD72720_REG_UNWRAP(reg); + + return regmap_read(maps->map2_4c, reg, val); +} + +static const struct regmap_config bd72720_wrapper_map_config =3D { + .name =3D "wrap-map", + .reg_bits =3D 9, + .val_bits =3D 8, + .max_register =3D BD72720_REG_IMPCHK_CTRL, + /* + * We don't want to duplicate caches. It would be a bit faster to + * have the cache in this 'wrapper regmap', and not in the 'real + * regmaps' bd72720_regmap_4b and bd72720_regmap_4c below. This would + * require all the subdevices to use the wrapper-map in order to be + * able to benefit from the cache. + * Currently most of the sub-devices use only the same slave-address + * as this MFD driver. Now, because we don't add the offset to the + * registers belonging to this slave, those devices can use either the + * wrapper map, or the bd72720_regmap_4b directly. This means majority + * of our sub devices don't need to care which regmap they get using + * the dev_get_regmap(). This unifies the code between the BD72720 and + * those variants which don't have this 'multiple slave addresses' + * -hassle. + * So, for a small performance penalty, we simplify the code for the + * sub-devices by having the caches in the wrapped regmaps and not here. + */ + .cache_type =3D REGCACHE_NONE, + .reg_write =3D regmap_write_wrapper, + .reg_read =3D regmap_read_wrapper, +}; + +static const struct regmap_config bd72720_regmap_4b =3D { + .reg_bits =3D 8, + .val_bits =3D 8, + .volatile_table =3D &bd72720_volatile_regs_4b, + .precious_table =3D &bd72720_precious_regs_4b, + .max_register =3D BD72720_REG_INT_ETC2_SRC, + .cache_type =3D REGCACHE_MAPLE, +}; + +static const struct regmap_config bd72720_regmap_4c =3D { + .reg_bits =3D 8, + .val_bits =3D 8, + .volatile_table =3D &bd72720_volatile_regs_4c, + .max_register =3D BD72720_REG_UNWRAP(BD72720_REG_IMPCHK_CTRL), + .cache_type =3D REGCACHE_MAPLE, +}; + /* * Mapping of main IRQ register bits to sub-IRQ register offsets so that w= e can * access corect sub-IRQ registers based on bits that are set in main IRQ - * register. BD71815 and BD71828 have same sub-register-block offests. + * register. BD71815 and BD71828 have same sub-register-block offests, the + * BD72720 has a different one. */ =20 static unsigned int bit0_offsets[] =3D {11}; /* RTC IRQ */ @@ -221,6 +477,15 @@ static unsigned int bit5_offsets[] =3D {3}; /* VSYS I= RQ */ static unsigned int bit6_offsets[] =3D {1, 2}; /* DCIN IRQ */ static unsigned int bit7_offsets[] =3D {0}; /* BUCK IRQ */ =20 +static unsigned int bd72720_bit0_offsets[] =3D {0, 1}; /* PS1 and PS2 */ +static unsigned int bd72720_bit1_offsets[] =3D {2, 3}; /* DVS1 and DVS2 */ +static unsigned int bd72720_bit2_offsets[] =3D {4}; /* VBUS */ +static unsigned int bd72720_bit3_offsets[] =3D {5}; /* VSYS */ +static unsigned int bd72720_bit4_offsets[] =3D {6}; /* CHG */ +static unsigned int bd72720_bit5_offsets[] =3D {7, 8}; /* BAT1 and BAT2 */ +static unsigned int bd72720_bit6_offsets[] =3D {9}; /* IBAT */ +static unsigned int bd72720_bit7_offsets[] =3D {10, 11}; /* ETC1 and ETC2 = */ + static const struct regmap_irq_sub_irq_map bd718xx_sub_irq_offsets[] =3D { REGMAP_IRQ_MAIN_REG_OFFSET(bit0_offsets), REGMAP_IRQ_MAIN_REG_OFFSET(bit1_offsets), @@ -232,6 +497,17 @@ static const struct regmap_irq_sub_irq_map bd718xx_sub= _irq_offsets[] =3D { REGMAP_IRQ_MAIN_REG_OFFSET(bit7_offsets), }; =20 +static const struct regmap_irq_sub_irq_map bd72720_sub_irq_offsets[] =3D { + REGMAP_IRQ_MAIN_REG_OFFSET(bd72720_bit0_offsets), + REGMAP_IRQ_MAIN_REG_OFFSET(bd72720_bit1_offsets), + REGMAP_IRQ_MAIN_REG_OFFSET(bd72720_bit2_offsets), + REGMAP_IRQ_MAIN_REG_OFFSET(bd72720_bit3_offsets), + REGMAP_IRQ_MAIN_REG_OFFSET(bd72720_bit4_offsets), + REGMAP_IRQ_MAIN_REG_OFFSET(bd72720_bit5_offsets), + REGMAP_IRQ_MAIN_REG_OFFSET(bd72720_bit6_offsets), + REGMAP_IRQ_MAIN_REG_OFFSET(bd72720_bit7_offsets), +}; + static const struct regmap_irq bd71815_irqs[] =3D { REGMAP_IRQ_REG(BD71815_INT_BUCK1_OCP, 0, BD71815_INT_BUCK1_OCP_MASK), REGMAP_IRQ_REG(BD71815_INT_BUCK2_OCP, 0, BD71815_INT_BUCK2_OCP_MASK), @@ -405,6 +681,117 @@ static const struct regmap_irq bd71828_irqs[] =3D { REGMAP_IRQ_REG(BD71828_INT_RTC2, 11, BD71828_INT_RTC2_MASK), }; =20 +static const struct regmap_irq bd72720_irqs[] =3D { + REGMAP_IRQ_REG(BD72720_INT_LONGPUSH, 0, BD72720_INT_LONGPUSH_MASK), + REGMAP_IRQ_REG(BD72720_INT_MIDPUSH, 0, BD72720_INT_MIDPUSH_MASK), + REGMAP_IRQ_REG(BD72720_INT_SHORTPUSH, 0, BD72720_INT_SHORTPUSH_MASK), + REGMAP_IRQ_REG(BD72720_INT_PUSH, 0, BD72720_INT_PUSH_MASK), + REGMAP_IRQ_REG(BD72720_INT_HALL_DET, 0, BD72720_INT_HALL_DET_MASK), + REGMAP_IRQ_REG(BD72720_INT_HALL_TGL, 0, BD72720_INT_HALL_TGL_MASK), + REGMAP_IRQ_REG(BD72720_INT_WDOG, 0, BD72720_INT_WDOG_MASK), + REGMAP_IRQ_REG(BD72720_INT_SWRESET, 0, BD72720_INT_SWRESET_MASK), + REGMAP_IRQ_REG(BD72720_INT_SEQ_DONE, 1, BD72720_INT_SEQ_DONE_MASK), + REGMAP_IRQ_REG(BD72720_INT_PGFAULT, 1, BD72720_INT_PGFAULT_MASK), + REGMAP_IRQ_REG(BD72720_INT_BUCK1_DVS, 2, BD72720_INT_BUCK1_DVS_MASK), + REGMAP_IRQ_REG(BD72720_INT_BUCK2_DVS, 2, BD72720_INT_BUCK2_DVS_MASK), + REGMAP_IRQ_REG(BD72720_INT_BUCK3_DVS, 2, BD72720_INT_BUCK3_DVS_MASK), + REGMAP_IRQ_REG(BD72720_INT_BUCK4_DVS, 2, BD72720_INT_BUCK4_DVS_MASK), + REGMAP_IRQ_REG(BD72720_INT_BUCK5_DVS, 2, BD72720_INT_BUCK5_DVS_MASK), + REGMAP_IRQ_REG(BD72720_INT_BUCK6_DVS, 2, BD72720_INT_BUCK6_DVS_MASK), + REGMAP_IRQ_REG(BD72720_INT_BUCK7_DVS, 2, BD72720_INT_BUCK7_DVS_MASK), + REGMAP_IRQ_REG(BD72720_INT_BUCK8_DVS, 2, BD72720_INT_BUCK8_DVS_MASK), + REGMAP_IRQ_REG(BD72720_INT_BUCK9_DVS, 3, BD72720_INT_BUCK9_DVS_MASK), + REGMAP_IRQ_REG(BD72720_INT_BUCK10_DVS, 3, BD72720_INT_BUCK10_DVS_MASK), + REGMAP_IRQ_REG(BD72720_INT_LDO1_DVS, 3, BD72720_INT_LDO1_DVS_MASK), + REGMAP_IRQ_REG(BD72720_INT_LDO2_DVS, 3, BD72720_INT_LDO2_DVS_MASK), + REGMAP_IRQ_REG(BD72720_INT_LDO3_DVS, 3, BD72720_INT_LDO3_DVS_MASK), + REGMAP_IRQ_REG(BD72720_INT_LDO4_DVS, 3, BD72720_INT_LDO4_DVS_MASK), + + REGMAP_IRQ_REG(BD72720_INT_VBUS_RMV, 4, BD72720_INT_VBUS_RMV_MASK), + REGMAP_IRQ_REG(BD72720_INT_VBUS_DET, 4, BD72720_INT_VBUS_DET_MASK), + REGMAP_IRQ_REG(BD72720_INT_VBUS_MON_RES, 4, BD72720_INT_VBUS_MON_RES_MASK= ), + REGMAP_IRQ_REG(BD72720_INT_VBUS_MON_DET, 4, BD72720_INT_VBUS_MON_DET_MASK= ), + REGMAP_IRQ_REG(BD72720_INT_VSYS_MON_RES, 5, BD72720_INT_VSYS_MON_RES_MASK= ), + REGMAP_IRQ_REG(BD72720_INT_VSYS_MON_DET, 5, BD72720_INT_VSYS_MON_DET_MASK= ), + REGMAP_IRQ_REG(BD72720_INT_VSYS_UV_RES, 5, BD72720_INT_VSYS_UV_RES_MASK), + REGMAP_IRQ_REG(BD72720_INT_VSYS_UV_DET, 5, BD72720_INT_VSYS_UV_DET_MASK), + REGMAP_IRQ_REG(BD72720_INT_VSYS_LO_RES, 5, BD72720_INT_VSYS_LO_RES_MASK), + REGMAP_IRQ_REG(BD72720_INT_VSYS_LO_DET, 5, BD72720_INT_VSYS_LO_DET_MASK), + REGMAP_IRQ_REG(BD72720_INT_VSYS_OV_RES, 5, BD72720_INT_VSYS_OV_RES_MASK), + REGMAP_IRQ_REG(BD72720_INT_VSYS_OV_DET, 5, BD72720_INT_VSYS_OV_DET_MASK), + REGMAP_IRQ_REG(BD72720_INT_BAT_ILIM, 6, BD72720_INT_BAT_ILIM_MASK), + REGMAP_IRQ_REG(BD72720_INT_CHG_DONE, 6, BD72720_INT_CHG_DONE_MASK), + REGMAP_IRQ_REG(BD72720_INT_EXTEMP_TOUT, 6, BD72720_INT_EXTEMP_TOUT_MASK), + REGMAP_IRQ_REG(BD72720_INT_CHG_WDT_EXP, 6, BD72720_INT_CHG_WDT_EXP_MASK), + REGMAP_IRQ_REG(BD72720_INT_BAT_MNT_OUT, 6, BD72720_INT_BAT_MNT_OUT_MASK), + REGMAP_IRQ_REG(BD72720_INT_BAT_MNT_IN, 6, BD72720_INT_BAT_MNT_IN_MASK), + REGMAP_IRQ_REG(BD72720_INT_CHG_TRNS, 6, BD72720_INT_CHG_TRNS_MASK), + + REGMAP_IRQ_REG(BD72720_INT_VBAT_MON_RES, 7, BD72720_INT_VBAT_MON_RES_MASK= ), + REGMAP_IRQ_REG(BD72720_INT_VBAT_MON_DET, 7, BD72720_INT_VBAT_MON_DET_MASK= ), + REGMAP_IRQ_REG(BD72720_INT_VBAT_SHT_RES, 7, BD72720_INT_VBAT_SHT_RES_MASK= ), + REGMAP_IRQ_REG(BD72720_INT_VBAT_SHT_DET, 7, BD72720_INT_VBAT_SHT_DET_MASK= ), + REGMAP_IRQ_REG(BD72720_INT_VBAT_LO_RES, 7, BD72720_INT_VBAT_LO_RES_MASK), + REGMAP_IRQ_REG(BD72720_INT_VBAT_LO_DET, 7, BD72720_INT_VBAT_LO_DET_MASK), + REGMAP_IRQ_REG(BD72720_INT_VBAT_OV_RES, 7, BD72720_INT_VBAT_OV_RES_MASK), + REGMAP_IRQ_REG(BD72720_INT_VBAT_OV_DET, 7, BD72720_INT_VBAT_OV_DET_MASK), + REGMAP_IRQ_REG(BD72720_INT_BAT_RMV, 8, BD72720_INT_BAT_RMV_MASK), + REGMAP_IRQ_REG(BD72720_INT_BAT_DET, 8, BD72720_INT_BAT_DET_MASK), + REGMAP_IRQ_REG(BD72720_INT_DBAT_DET, 8, BD72720_INT_DBAT_DET_MASK), + REGMAP_IRQ_REG(BD72720_INT_BAT_TEMP_TRNS, 8, BD72720_INT_BAT_TEMP_TRNS_MA= SK), + REGMAP_IRQ_REG(BD72720_INT_LOBTMP_RES, 8, BD72720_INT_LOBTMP_RES_MASK), + REGMAP_IRQ_REG(BD72720_INT_LOBTMP_DET, 8, BD72720_INT_LOBTMP_DET_MASK), + REGMAP_IRQ_REG(BD72720_INT_OVBTMP_RES, 8, BD72720_INT_OVBTMP_RES_MASK), + REGMAP_IRQ_REG(BD72720_INT_OVBTMP_DET, 8, BD72720_INT_OVBTMP_DET_MASK), + REGMAP_IRQ_REG(BD72720_INT_OCUR1_RES, 9, BD72720_INT_OCUR1_RES_MASK), + REGMAP_IRQ_REG(BD72720_INT_OCUR1_DET, 9, BD72720_INT_OCUR1_DET_MASK), + REGMAP_IRQ_REG(BD72720_INT_OCUR2_RES, 9, BD72720_INT_OCUR2_RES_MASK), + REGMAP_IRQ_REG(BD72720_INT_OCUR2_DET, 9, BD72720_INT_OCUR2_DET_MASK), + REGMAP_IRQ_REG(BD72720_INT_OCUR3_RES, 9, BD72720_INT_OCUR3_RES_MASK), + REGMAP_IRQ_REG(BD72720_INT_OCUR3_DET, 9, BD72720_INT_OCUR3_DET_MASK), + REGMAP_IRQ_REG(BD72720_INT_CC_MON1_DET, 10, BD72720_INT_CC_MON1_DET_MASK), + REGMAP_IRQ_REG(BD72720_INT_CC_MON2_DET, 10, BD72720_INT_CC_MON2_DET_MASK), + REGMAP_IRQ_REG(BD72720_INT_CC_MON3_DET, 10, BD72720_INT_CC_MON3_DET_MASK), +/* + * The GPIO1_IN and GPIO2_IN IRQs are generated from the PMIC's GPIO1 and = GPIO2 + * pins. Eg, they may be wired to other devices which can then use the PMI= C as + * an interrupt controller. The GPIO1 and GPIO2 can have the IRQ type + * specified. All of the types (falling, rising, and both edges as well as= low + * and high levels) are supported. + */ + BD72720_TYPED_IRQ_REG(BD72720_INT_GPIO1_IN, 10, BD72720_INT_GPIO1_IN_MASK= , 0), + BD72720_TYPED_IRQ_REG(BD72720_INT_GPIO2_IN, 10, BD72720_INT_GPIO2_IN_MASK= , 1), + REGMAP_IRQ_REG(BD72720_INT_VF125_RES, 11, BD72720_INT_VF125_RES_MASK), + REGMAP_IRQ_REG(BD72720_INT_VF125_DET, 11, BD72720_INT_VF125_DET_MASK), + REGMAP_IRQ_REG(BD72720_INT_VF_RES, 11, BD72720_INT_VF_RES_MASK), + REGMAP_IRQ_REG(BD72720_INT_VF_DET, 11, BD72720_INT_VF_DET_MASK), + REGMAP_IRQ_REG(BD72720_INT_RTC0, 11, BD72720_INT_RTC0_MASK), + REGMAP_IRQ_REG(BD72720_INT_RTC1, 11, BD72720_INT_RTC1_MASK), + REGMAP_IRQ_REG(BD72720_INT_RTC2, 11, BD72720_INT_RTC2_MASK), +}; + +static int bd72720_set_type_config(unsigned int **buf, unsigned int type, + const struct regmap_irq *irq_data, + int idx, void *irq_drv_data) +{ + const struct regmap_irq_type *t =3D &irq_data->type; + + /* + * The regmap IRQ ecpects IRQ_TYPE_EDGE_BOTH to be written to register + * as logical OR of the type_falling_val and type_rising_val. This is + * not how the BD72720 implements this configuration, hence we need + * to handle this specific case separately. + */ + if (type =3D=3D IRQ_TYPE_EDGE_BOTH) { + buf[0][idx] &=3D ~t->type_reg_mask; + buf[0][idx] |=3D BD72720_GPIO_IRQ_TYPE_BOTH; + + return 0; + } + + return regmap_irq_set_type_config_simple(buf, type, irq_data, idx, irq_dr= v_data); +} + static const struct regmap_irq_chip bd71828_irq_chip =3D { .name =3D "bd71828_irq", .main_status =3D BD71828_REG_INT_MAIN, @@ -437,6 +824,28 @@ static const struct regmap_irq_chip bd71815_irq_chip = =3D { .irq_reg_stride =3D 1, }; =20 +static const unsigned int bd72720_irq_type_base[] =3D {BD72720_REG_GPIO1_C= TRL}; + +static const struct regmap_irq_chip bd72720_irq_chip =3D { + .name =3D "bd72720_irq", + .main_status =3D BD72720_REG_INT_LVL1_STAT, + .irqs =3D &bd72720_irqs[0], + .num_irqs =3D ARRAY_SIZE(bd72720_irqs), + .status_base =3D BD72720_REG_INT_PS1_STAT, + .unmask_base =3D BD72720_REG_INT_PS1_EN, + .config_base =3D &bd72720_irq_type_base[0], + .num_config_bases =3D 1, + .num_config_regs =3D 2, + .set_type_config =3D bd72720_set_type_config, + .ack_base =3D BD72720_REG_INT_PS1_STAT, + .init_ack_masked =3D true, + .num_regs =3D 12, + .num_main_regs =3D 1, + .sub_reg_offsets =3D &bd72720_sub_irq_offsets[0], + .num_main_status_bits =3D 8, + .irq_reg_stride =3D 1, +}; + static int set_clk_mode(struct device *dev, struct regmap *regmap, int clkmode_reg) { @@ -483,11 +892,40 @@ static void bd71828_remove_poweroff(void *data) pm_power_off =3D NULL; } =20 +static struct regmap *bd72720_do_regmaps(struct i2c_client *i2c) +{ + struct bd72720_regmaps *maps; + struct i2c_client *secondary_i2c; + + secondary_i2c =3D devm_i2c_new_dummy_device(&i2c->dev, i2c->adapter, + BD72720_SECONDARY_I2C_SLAVE); + if (IS_ERR(secondary_i2c)) { + dev_err_probe(&i2c->dev, PTR_ERR(secondary_i2c), + "Failed to get secondary I2C\n"); + + return (struct regmap *)secondary_i2c; + } + + maps =3D devm_kzalloc(&i2c->dev, sizeof(*maps), GFP_KERNEL); + if (!maps) + return ERR_PTR(-ENOMEM); + + maps->map1_4b =3D devm_regmap_init_i2c(i2c, &bd72720_regmap_4b); + if (IS_ERR(maps->map1_4b)) + return maps->map1_4b; + + maps->map2_4c =3D devm_regmap_init_i2c(secondary_i2c, &bd72720_regmap_4c); + if (IS_ERR(maps->map2_4c)) + return maps->map2_4c; + + return devm_regmap_init(&i2c->dev, NULL, maps, &bd72720_wrapper_map_confi= g); +} + static int bd71828_i2c_probe(struct i2c_client *i2c) { struct regmap_irq_chip_data *irq_data; int ret; - struct regmap *regmap; + struct regmap *regmap =3D NULL; const struct regmap_config *regmap_config; const struct regmap_irq_chip *irqchip; unsigned int chip_type; @@ -495,6 +933,7 @@ static int bd71828_i2c_probe(struct i2c_client *i2c) int cells; int button_irq; int clkmode_reg; + int main_lvl_mask_reg =3D 0, main_lvl_val =3D 0; =20 if (!i2c->irq) { dev_err(&i2c->dev, "No IRQ configured\n"); @@ -526,16 +965,34 @@ static int bd71828_i2c_probe(struct i2c_client *i2c) */ button_irq =3D 0; break; + case ROHM_CHIP_TYPE_BD72720: + { + mfd =3D bd72720_mfd_cells; + cells =3D ARRAY_SIZE(bd72720_mfd_cells); + + regmap =3D bd72720_do_regmaps(i2c); + if (IS_ERR(regmap)) + return dev_err_probe(&i2c->dev, PTR_ERR(regmap), + "Failed to initialize Regmap\n"); + + irqchip =3D &bd72720_irq_chip; + clkmode_reg =3D BD72720_REG_OUT32K; + button_irq =3D BD72720_INT_SHORTPUSH; + main_lvl_mask_reg =3D BD72720_REG_INT_LVL1_EN; + main_lvl_val =3D BD72720_MASK_LVL1_EN_ALL; + break; + } default: dev_err(&i2c->dev, "Unknown device type"); return -EINVAL; } =20 - regmap =3D devm_regmap_init_i2c(i2c, regmap_config); - if (IS_ERR(regmap)) - return dev_err_probe(&i2c->dev, PTR_ERR(regmap), + if (!regmap) { + regmap =3D devm_regmap_init_i2c(i2c, regmap_config); + if (IS_ERR(regmap)) + return dev_err_probe(&i2c->dev, PTR_ERR(regmap), "Failed to initialize Regmap\n"); - + } ret =3D devm_regmap_add_irq_chip(&i2c->dev, regmap, i2c->irq, IRQF_ONESHOT, 0, irqchip, &irq_data); if (ret) @@ -545,6 +1002,20 @@ static int bd71828_i2c_probe(struct i2c_client *i2c) dev_dbg(&i2c->dev, "Registered %d IRQs for chip\n", irqchip->num_irqs); =20 + /* + * On some ICs the main IRQ register has corresponding mask register. + * This is not handled by the regmap IRQ. Let's enable all the main + * level IRQs here. Further writes to the main level MASK is not + * needed because masking is handled by the per IRQ 2.nd level MASK + * registers. 2.nd level masks are handled by the regmap IRQ. + */ + if (main_lvl_mask_reg) { + ret =3D regmap_write(regmap, main_lvl_mask_reg, main_lvl_val); + if (ret) { + return dev_err_probe(&i2c->dev, ret, + "Failed to enable main level IRQs\n"); + } + } if (button_irq) { ret =3D regmap_irq_get_virq(irq_data, button_irq); if (ret < 0) @@ -586,6 +1057,9 @@ static const struct of_device_id bd71828_of_match[] = =3D { }, { .compatible =3D "rohm,bd71815", .data =3D (void *)ROHM_CHIP_TYPE_BD71815, + }, { + .compatible =3D "rohm,bd72720", + .data =3D (void *)ROHM_CHIP_TYPE_BD72720, }, { }, }; diff --git a/include/linux/mfd/rohm-bd72720.h b/include/linux/mfd/rohm-bd72= 720.h new file mode 100644 index 000000000000..42fcf8f81b2f --- /dev/null +++ b/include/linux/mfd/rohm-bd72720.h @@ -0,0 +1,634 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ +/* + * Copyright 2024 ROHM Semiconductors. + * + * Author: Matti Vaittinen + */ + +#ifndef _MFD_BD72720_H +#define _MFD_BD72720_H + +#include + +enum { + BD72720_BUCK1, + BD72720_BUCK2, + BD72720_BUCK3, + BD72720_BUCK4, + BD72720_BUCK5, + BD72720_BUCK6, + BD72720_BUCK7, + BD72720_BUCK8, + BD72720_BUCK9, + BD72720_BUCK10, + BD72720_BUCK11, + BD72720_LDO1, + BD72720_LDO2, + BD72720_LDO3, + BD72720_LDO4, + BD72720_LDO5, + BD72720_LDO6, + BD72720_LDO7, + BD72720_LDO8, + BD72720_LDO9, + BD72720_LDO10, + BD72720_LDO11, + BD72720_REGULATOR_AMOUNT, +}; + +/* BD72720 interrupts */ +#define BD72720_INT_LONGPUSH_MASK BIT(0) +#define BD72720_INT_MIDPUSH_MASK BIT(1) +#define BD72720_INT_SHORTPUSH_MASK BIT(2) +#define BD72720_INT_PUSH_MASK BIT(3) +#define BD72720_INT_HALL_DET_MASK BIT(4) +#define BD72720_INT_HALL_TGL_MASK BIT(5) +#define BD72720_INT_WDOG_MASK BIT(6) +#define BD72720_INT_SWRESET_MASK BIT(7) +#define BD72720_INT_SEQ_DONE_MASK BIT(0) +#define BD72720_INT_PGFAULT_MASK BIT(4) +#define BD72720_INT_BUCK1_DVS_MASK BIT(0) +#define BD72720_INT_BUCK2_DVS_MASK BIT(1) +#define BD72720_INT_BUCK3_DVS_MASK BIT(2) +#define BD72720_INT_BUCK4_DVS_MASK BIT(3) +#define BD72720_INT_BUCK5_DVS_MASK BIT(4) +#define BD72720_INT_BUCK6_DVS_MASK BIT(5) +#define BD72720_INT_BUCK7_DVS_MASK BIT(6) +#define BD72720_INT_BUCK8_DVS_MASK BIT(7) +#define BD72720_INT_BUCK9_DVS_MASK BIT(0) +#define BD72720_INT_BUCK10_DVS_MASK BIT(1) +#define BD72720_INT_LDO1_DVS_MASK BIT(4) +#define BD72720_INT_LDO2_DVS_MASK BIT(5) +#define BD72720_INT_LDO3_DVS_MASK BIT(6) +#define BD72720_INT_LDO4_DVS_MASK BIT(7) +#define BD72720_INT_VBUS_RMV_MASK BIT(0) +#define BD72720_INT_VBUS_DET_MASK BIT(1) +#define BD72720_INT_VBUS_MON_RES_MASK BIT(2) +#define BD72720_INT_VBUS_MON_DET_MASK BIT(3) +#define BD72720_INT_VSYS_MON_RES_MASK BIT(0) +#define BD72720_INT_VSYS_MON_DET_MASK BIT(1) +#define BD72720_INT_VSYS_UV_RES_MASK BIT(2) +#define BD72720_INT_VSYS_UV_DET_MASK BIT(3) +#define BD72720_INT_VSYS_LO_RES_MASK BIT(4) +#define BD72720_INT_VSYS_LO_DET_MASK BIT(5) +#define BD72720_INT_VSYS_OV_RES_MASK BIT(6) +#define BD72720_INT_VSYS_OV_DET_MASK BIT(7) +#define BD72720_INT_BAT_ILIM_MASK BIT(0) +#define BD72720_INT_CHG_DONE_MASK BIT(1) +#define BD72720_INT_EXTEMP_TOUT_MASK BIT(2) +#define BD72720_INT_CHG_WDT_EXP_MASK BIT(3) +#define BD72720_INT_BAT_MNT_OUT_MASK BIT(4) +#define BD72720_INT_BAT_MNT_IN_MASK BIT(5) +#define BD72720_INT_CHG_TRNS_MASK BIT(7) +#define BD72720_INT_VBAT_MON_RES_MASK BIT(0) +#define BD72720_INT_VBAT_MON_DET_MASK BIT(1) +#define BD72720_INT_VBAT_SHT_RES_MASK BIT(2) +#define BD72720_INT_VBAT_SHT_DET_MASK BIT(3) +#define BD72720_INT_VBAT_LO_RES_MASK BIT(4) +#define BD72720_INT_VBAT_LO_DET_MASK BIT(5) +#define BD72720_INT_VBAT_OV_RES_MASK BIT(6) +#define BD72720_INT_VBAT_OV_DET_MASK BIT(7) +#define BD72720_INT_BAT_RMV_MASK BIT(0) +#define BD72720_INT_BAT_DET_MASK BIT(1) +#define BD72720_INT_DBAT_DET_MASK BIT(2) +#define BD72720_INT_BAT_TEMP_TRNS_MASK BIT(3) +#define BD72720_INT_LOBTMP_RES_MASK BIT(4) +#define BD72720_INT_LOBTMP_DET_MASK BIT(5) +#define BD72720_INT_OVBTMP_RES_MASK BIT(6) +#define BD72720_INT_OVBTMP_DET_MASK BIT(7) +#define BD72720_INT_OCUR1_RES_MASK BIT(0) +#define BD72720_INT_OCUR1_DET_MASK BIT(1) +#define BD72720_INT_OCUR2_RES_MASK BIT(2) +#define BD72720_INT_OCUR2_DET_MASK BIT(3) +#define BD72720_INT_OCUR3_RES_MASK BIT(4) +#define BD72720_INT_OCUR3_DET_MASK BIT(5) +#define BD72720_INT_CC_MON1_DET_MASK BIT(0) +#define BD72720_INT_CC_MON2_DET_MASK BIT(1) +#define BD72720_INT_CC_MON3_DET_MASK BIT(2) +#define BD72720_INT_GPIO1_IN_MASK BIT(4) +#define BD72720_INT_GPIO2_IN_MASK BIT(5) +#define BD72720_INT_VF125_RES_MASK BIT(0) +#define BD72720_INT_VF125_DET_MASK BIT(1) +#define BD72720_INT_VF_RES_MASK BIT(2) +#define BD72720_INT_VF_DET_MASK BIT(3) +#define BD72720_INT_RTC0_MASK BIT(4) +#define BD72720_INT_RTC1_MASK BIT(5) +#define BD72720_INT_RTC2_MASK BIT(6) + +enum { + /* + * The IRQs excluding GPIO1 and GPIO2 are ordered in a same way as the + * respective IRQ bits in status and mask registers are ordered. + * + * The BD72720_INT_GPIO1_IN and BD72720_INT_GPIO2_IN are IRQs which can + * be used by other devices. Let's have GPIO1 and GPIO2 as first IRQs + * here so we can use the regmap-IRQ with standard device tree xlate + * while devices connected to the BD72720 IRQ input pins can refer to + * the first two interrupt numbers in their device tree. If we placed + * BD72720_INT_GPIO1_IN and BD72720_INT_GPIO2_IN after the CC_MON_DET + * interrupts (like they are in the registers), the devices using + * BD72720 as an IRQ parent should refer the interrupts starting with + * an offset which might not be trivial to understand. + */ + BD72720_INT_GPIO1_IN, + BD72720_INT_GPIO2_IN, + BD72720_INT_LONGPUSH, + BD72720_INT_MIDPUSH, + BD72720_INT_SHORTPUSH, + BD72720_INT_PUSH, + BD72720_INT_HALL_DET, + BD72720_INT_HALL_TGL, + BD72720_INT_WDOG, + BD72720_INT_SWRESET, + BD72720_INT_SEQ_DONE, + BD72720_INT_PGFAULT, + BD72720_INT_BUCK1_DVS, + BD72720_INT_BUCK2_DVS, + BD72720_INT_BUCK3_DVS, + BD72720_INT_BUCK4_DVS, + BD72720_INT_BUCK5_DVS, + BD72720_INT_BUCK6_DVS, + BD72720_INT_BUCK7_DVS, + BD72720_INT_BUCK8_DVS, + BD72720_INT_BUCK9_DVS, + BD72720_INT_BUCK10_DVS, + BD72720_INT_LDO1_DVS, + BD72720_INT_LDO2_DVS, + BD72720_INT_LDO3_DVS, + BD72720_INT_LDO4_DVS, + BD72720_INT_VBUS_RMV, + BD72720_INT_VBUS_DET, + BD72720_INT_VBUS_MON_RES, + BD72720_INT_VBUS_MON_DET, + BD72720_INT_VSYS_MON_RES, + BD72720_INT_VSYS_MON_DET, + BD72720_INT_VSYS_UV_RES, + BD72720_INT_VSYS_UV_DET, + BD72720_INT_VSYS_LO_RES, + BD72720_INT_VSYS_LO_DET, + BD72720_INT_VSYS_OV_RES, + BD72720_INT_VSYS_OV_DET, + BD72720_INT_BAT_ILIM, + BD72720_INT_CHG_DONE, + BD72720_INT_EXTEMP_TOUT, + BD72720_INT_CHG_WDT_EXP, + BD72720_INT_BAT_MNT_OUT, + BD72720_INT_BAT_MNT_IN, + BD72720_INT_CHG_TRNS, + BD72720_INT_VBAT_MON_RES, + BD72720_INT_VBAT_MON_DET, + BD72720_INT_VBAT_SHT_RES, + BD72720_INT_VBAT_SHT_DET, + BD72720_INT_VBAT_LO_RES, + BD72720_INT_VBAT_LO_DET, + BD72720_INT_VBAT_OV_RES, + BD72720_INT_VBAT_OV_DET, + BD72720_INT_BAT_RMV, + BD72720_INT_BAT_DET, + BD72720_INT_DBAT_DET, + BD72720_INT_BAT_TEMP_TRNS, + BD72720_INT_LOBTMP_RES, + BD72720_INT_LOBTMP_DET, + BD72720_INT_OVBTMP_RES, + BD72720_INT_OVBTMP_DET, + BD72720_INT_OCUR1_RES, + BD72720_INT_OCUR1_DET, + BD72720_INT_OCUR2_RES, + BD72720_INT_OCUR2_DET, + BD72720_INT_OCUR3_RES, + BD72720_INT_OCUR3_DET, + BD72720_INT_CC_MON1_DET, + BD72720_INT_CC_MON2_DET, + BD72720_INT_CC_MON3_DET, + BD72720_INT_VF125_RES, + BD72720_INT_VF125_DET, + BD72720_INT_VF_RES, + BD72720_INT_VF_DET, + BD72720_INT_RTC0, + BD72720_INT_RTC1, + BD72720_INT_RTC2, +}; + +/* + * BD72720 Registers: + * The BD72720 has two sets of registers behind two different I2C slave + * addresses. "Common" registers being behind 0x4b, the charger registers + * being behind 0x4c. + */ +/* Registers behind I2C slave 0x4b */ +enum { + BD72720_REG_PRODUCT_ID, + BD72720_REG_MANUFACTURER_ID, + BD72720_REG_PMIC_REV_NUM, + BD72720_REG_NVM_REV_NUM, + BD72720_REG_BOOTSRC =3D 0x10, + BD72720_REG_RESETSRC_1, + BD72720_REG_RESETSRC_2, + BD72720_REG_RESETSRC_3, + BD72720_REG_RESETSRC_4, + BD72720_REG_RESETSRC_5, + BD72720_REG_RESETSRC_6, + BD72720_REG_RESETSRC_7, + BD72720_REG_POWER_STATE, + BD72720_REG_PS_CFG, + BD72720_REG_PS_CTRL_1, + BD72720_REG_PS_CTRL_2, + BD72720_REG_RCVCFG, + BD72720_REG_RCVNUM, + BD72720_REG_CRDCFG, + BD72720_REG_REX_CTRL, + + BD72720_REG_BUCK1_ON, + BD72720_REG_BUCK1_MODE, + /* Deep idle vsel */ + BD72720_REG_BUCK1_VSEL_DI, + /* Idle vsel */ + BD72720_REG_BUCK1_VSEL_I, + /* Suspend vsel */ + BD72720_REG_BUCK1_VSEL_S, + /* Run boot vsel */ + BD72720_REG_BUCK1_VSEL_RB, + /* Run0 ... run3 vsel */ + BD72720_REG_BUCK1_VSEL_RB0, + BD72720_REG_BUCK1_VSEL_RB1, + BD72720_REG_BUCK1_VSEL_RB2, + BD72720_REG_BUCK1_VSEL_RB3, + + BD72720_REG_BUCK2_ON, + BD72720_REG_BUCK2_MODE, + BD72720_REG_BUCK2_VSEL_DI, + BD72720_REG_BUCK2_VSEL_I, + BD72720_REG_BUCK2_VSEL_S, + /* Run vsel */ + BD72720_REG_BUCK2_VSEL_R, + + BD72720_REG_BUCK3_ON, + BD72720_REG_BUCK3_MODE, + BD72720_REG_BUCK3_VSEL_DI, + BD72720_REG_BUCK3_VSEL_I, + BD72720_REG_BUCK3_VSEL_S, + BD72720_REG_BUCK3_VSEL_R, + + BD72720_REG_BUCK4_ON, + BD72720_REG_BUCK4_MODE, + BD72720_REG_BUCK4_VSEL_DI, + BD72720_REG_BUCK4_VSEL_I, + BD72720_REG_BUCK4_VSEL_S, + BD72720_REG_BUCK4_VSEL_R, + + BD72720_REG_BUCK5_ON, + BD72720_REG_BUCK5_MODE, + BD72720_REG_BUCK5_VSEL, + + BD72720_REG_BUCK6_ON, + BD72720_REG_BUCK6_MODE, + BD72720_REG_BUCK6_VSEL, + + BD72720_REG_BUCK7_ON, + BD72720_REG_BUCK7_MODE, + BD72720_REG_BUCK7_VSEL, + + BD72720_REG_BUCK8_ON, + BD72720_REG_BUCK8_MODE, + BD72720_REG_BUCK8_VSEL, + + BD72720_REG_BUCK9_ON, + BD72720_REG_BUCK9_MODE, + BD72720_REG_BUCK9_VSEL, + + BD72720_REG_BUCK10_ON, + BD72720_REG_BUCK10_MODE, + BD72720_REG_BUCK10_VSEL, + + BD72720_REG_LDO1_ON, + BD72720_REG_LDO1_MODE1, + BD72720_REG_LDO1_MODE2, + BD72720_REG_LDO1_VSEL_DI, + BD72720_REG_LDO1_VSEL_I, + BD72720_REG_LDO1_VSEL_S, + BD72720_REG_LDO1_VSEL_RB, + BD72720_REG_LDO1_VSEL_R0, + BD72720_REG_LDO1_VSEL_R1, + BD72720_REG_LDO1_VSEL_R2, + BD72720_REG_LDO1_VSEL_R3, + + BD72720_REG_LDO2_ON, + BD72720_REG_LDO2_MODE, + BD72720_REG_LDO2_VSEL_DI, + BD72720_REG_LDO2_VSEL_I, + BD72720_REG_LDO2_VSEL_S, + BD72720_REG_LDO2_VSEL_R, + + BD72720_REG_LDO3_ON, + BD72720_REG_LDO3_MODE, + BD72720_REG_LDO3_VSEL_DI, + BD72720_REG_LDO3_VSEL_I, + BD72720_REG_LDO3_VSEL_S, + BD72720_REG_LDO3_VSEL_R, + + BD72720_REG_LDO4_ON, + BD72720_REG_LDO4_MODE, + BD72720_REG_LDO4_VSEL_DI, + BD72720_REG_LDO4_VSEL_I, + BD72720_REG_LDO4_VSEL_S, + BD72720_REG_LDO4_VSEL_R, + + BD72720_REG_LDO5_ON, + BD72720_REG_LDO5_MODE, + BD72720_REG_LDO5_VSEL, + + BD72720_REG_LDO6_ON, + BD72720_REG_LDO6_MODE, + BD72720_REG_LDO6_VSEL, + + BD72720_REG_LDO7_ON, + BD72720_REG_LDO7_MODE, + BD72720_REG_LDO7_VSEL, + + BD72720_REG_LDO8_ON, + BD72720_REG_LDO8_MODE, + BD72720_REG_LDO8_VSEL, + + BD72720_REG_LDO9_ON, + BD72720_REG_LDO9_MODE, + BD72720_REG_LDO9_VSEL, + + BD72720_REG_LDO10_ON, + BD72720_REG_LDO10_MODE, + BD72720_REG_LDO10_VSEL, + + BD72720_REG_LDO11_ON, + BD72720_REG_LDO11_MODE, + BD72720_REG_LDO11_VSEL, + + BD72720_REG_GPIO1_ON =3D 0x8b, + BD72720_REG_GPIO2_ON, + BD72720_REG_GPIO3_ON, + BD72720_REG_GPIO4_ON, + BD72720_REG_GPIO5_ON, + + BD72720_REG_GPIO1_CTRL, + BD72720_REG_GPIO2_CTRL, +#define BD72720_GPIO_IRQ_TYPE_MASK GENMASK(6, 4) +#define BD72720_GPIO_IRQ_TYPE_FALLING 0x0 +#define BD72720_GPIO_IRQ_TYPE_RISING 0x1 +#define BD72720_GPIO_IRQ_TYPE_BOTH 0x2 +#define BD72720_GPIO_IRQ_TYPE_HIGH 0x3 +#define BD72720_GPIO_IRQ_TYPE_LOW 0x4 + BD72720_REG_GPIO3_CTRL, + BD72720_REG_GPIO4_CTRL, + BD72720_REG_GPIO5_CTRL, +#define BD72720_GPIO_DRIVE_MASK BIT(1) +#define BD72720_GPIO_HIGH BIT(0) + + BD72720_REG_EPDEN_CTRL, + BD72720_REG_GATECNT_CTRL, + BD72720_REG_LED_CTRL, + + BD72720_REG_PWRON_CFG1, + BD72720_REG_PWRON_CFG2, + + BD72720_REG_OUT32K, + BD72720_REG_CONF, + BD72720_REG_HALL_STAT, + + BD72720_REG_RTC_SEC =3D 0xa0, +#define BD72720_REG_RTC_START BD72720_REG_RTC_SEC + BD72720_REG_RTC_MIN, + BD72720_REG_RTC_HOUR, + BD72720_REG_RTC_WEEK, + BD72720_REG_RTC_DAY, + BD72720_REG_RTC_MON, + BD72720_REG_RTC_YEAR, + + BD72720_REG_RTC_ALM0_SEC, +#define BD72720_REG_RTC_ALM_START BD72720_REG_RTC_ALM0_SEC + BD72720_REG_RTC_ALM0_MIN, + BD72720_REG_RTC_ALM0_HOUR, + BD72720_REG_RTC_ALM0_WEEK, + BD72720_REG_RTC_ALM0_MON, + BD72720_REG_RTC_ALM0_YEAR, + + BD72720_REG_RTC_ALM1_SEC, + BD72720_REG_RTC_ALM1_MIN, + BD72720_REG_RTC_ALM1_HOUR, + BD72720_REG_RTC_ALM1_WEEK, + BD72720_REG_RTC_ALM1_MON, + BD72720_REG_RTC_ALM1_YEAR, + + BD72720_REG_RTC_ALM0_EN, + BD72720_REG_RTC_ALM1_EN, + BD72720_REG_RTC_ALM2, + + BD72720_REG_INT_LVL1_EN =3D 0xc0, +#define BD72720_MASK_LVL1_EN_ALL GENMASK(7, 0) + BD72720_REG_INT_PS1_EN, + BD72720_REG_INT_PS2_EN, + BD72720_REG_INT_DVS1_EN, + BD72720_REG_INT_DVS2_EN, + BD72720_REG_INT_VBUS_EN, + BD72720_REG_INT_VSYS_EN, + BD72720_REG_INT_CHG_EN, + BD72720_REG_INT_BAT1_EN, + BD72720_REG_INT_BAT2_EN, + BD72720_REG_INT_IBAT_EN, + BD72720_REG_INT_ETC1_EN, + BD72720_REG_INT_ETC2_EN, + + /* + * The _STAT registers inform IRQ line state, and are used to ack IRQ. + * The _SRC registers below indicate current state of the function + * connected to the line. + */ + BD72720_REG_INT_LVL1_STAT, + BD72720_REG_INT_PS1_STAT, + BD72720_REG_INT_PS2_STAT, + BD72720_REG_INT_DVS1_STAT, + BD72720_REG_INT_DVS2_STAT, + BD72720_REG_INT_VBUS_STAT, + BD72720_REG_INT_VSYS_STAT, + BD72720_REG_INT_CHG_STAT, + BD72720_REG_INT_BAT1_STAT, + BD72720_REG_INT_BAT2_STAT, + BD72720_REG_INT_IBAT_STAT, + BD72720_REG_INT_ETC1_STAT, + BD72720_REG_INT_ETC2_STAT, + + BD72720_REG_INT_LVL1_SRC, + BD72720_REG_INT_PS1_SRC, + BD72720_REG_INT_PS2_SRC, + BD72720_REG_INT_DVS1_SRC, + BD72720_REG_INT_DVS2_SRC, + BD72720_REG_INT_VBUS_SRC, +#define BD72720_MASK_DCIN_DET BIT(1) + BD72720_REG_INT_VSYS_SRC, + BD72720_REG_INT_CHG_SRC, + BD72720_REG_INT_BAT1_SRC, + BD72720_REG_INT_BAT2_SRC, + BD72720_REG_INT_IBAT_SRC, + BD72720_REG_INT_ETC1_SRC, + BD72720_REG_INT_ETC2_SRC, +}; + +/* Register masks */ +#define BD72720_MASK_DEEP_IDLE_EN BIT(0) +#define BD72720_MASK_IDLE_EN BIT(1) +#define BD72720_MASK_SUSPEND_EN BIT(2) +#define BD72720_MASK_RUN_B_EN BIT(3) +#define BD72720_MASK_RUN_0_EN BIT(4) +#define BD72720_MASK_RUN_1_EN BIT(5) +#define BD72720_MASK_RUN_2_EN BIT(6) +#define BD72720_MASK_RUN_3_EN BIT(7) + +#define BD72720_MASK_RAMP_UP_DELAY GENMASK(7, 6) +#define BD72720_MASK_BUCK_VSEL GENMASK(7, 0) +#define BD72720_MASK_LDO12346_VSEL GENMASK(6, 0) +#define BD72720_MASK_LDO_VSEL GENMASK(7, 0) + +#define BD72720_I2C4C_ADDR_OFFSET 0x100 + +/* Registers behind I2C slave 0x4c */ +enum { + BD72720_REG_CHG_STATE =3D BD72720_I2C4C_ADDR_OFFSET, + BD72720_REG_CHG_LAST_STATE, + BD72720_REG_CHG_VBUS_STAT, + BD72720_REG_CHG_VSYS_STAT, + BD72720_REG_CHG_BAT_TEMP_STAT, + BD72720_REG_CHG_WDT_STAT, + BD72720_REG_CHG_ILIM_STAT, + BD72720_REG_CHG_CHG_STAT, + BD72720_REG_CHG_EN, + BD72720_REG_CHG_INIT, + BD72720_REG_CHG_CTRL, + BD72720_REG_CHG_SET_1, + BD72720_REG_CHG_SET_2, + BD72720_REG_CHG_SET_3, + BD72720_REG_CHG_VPRE, + BD72720_REG_CHG_VBAT_1, + BD72720_REG_CHG_VBAT_2, + BD72720_REG_CHG_VBAT_3, + BD72720_REG_CHG_VBAT_4, + BD72720_REG_CHG_BAT_SET_1, + BD72720_REG_CHG_BAT_SET_2, + BD72720_REG_CHG_BAT_SET_3, + BD72720_REG_CHG_IPRE, + BD72720_REG_CHG_IFST_TERM, + BD72720_REG_CHG_VSYS_REG, + BD72720_REG_CHG_VBUS_SET, + BD72720_REG_CHG_WDT_PRE, + BD72720_REG_CHG_WDT_FST, + BD72720_REG_CHG_LED_CTRL, + BD72720_REG_CHG_CFG_1, + BD72720_REG_CHG_IFST_1, + BD72720_REG_CHG_IFST_2, + BD72720_REG_CHG_IFST_3, + BD72720_REG_CHG_IFST_4, + BD72720_REG_CHG_S_CFG_1, + BD72720_REG_CHG_S_CFG_2, + BD72720_REG_RS_VBUS, + BD72720_REG_RS_IBUS, + BD72720_REG_RS_VSYS, + BD72720_REG_VSYS_STATE_STAT, /* 0x27 + offset*/ + + BD72720_REG_VM_VBAT_U =3D BD72720_I2C4C_ADDR_OFFSET + 0x30, + BD72720_REG_VM_VBAT_L, + BD72720_REG_VM_OCV_PRE_U, + BD72720_REG_VM_OCV_PRE_L, + BD72720_REG_VM_OCV_PST_U, + BD72720_REG_VM_OCV_PST_L, + BD72720_REG_VM_OCV_PWRON_U, + BD72720_REG_VM_OCV_PWRON_L, + BD72720_REG_VM_DVBAT_IMP_U, + BD72720_REG_VM_DVBAT_IMP_L, + BD72720_REG_VM_SA_VBAT_U, + BD72720_REG_VM_SA_VBAT_L, + BD72720_REG_VM_SA_VBAT_MIN_U, + BD72720_REG_VM_SA_VBAT_MIN_L, + BD72720_REG_VM_SA_VBAT_MAX_U, + BD72720_REG_VM_SA_VBAT_MAX_L, + BD72720_REG_REX_SA_VBAT_U, + BD72720_REG_REX_SA_VBAT_L, + BD72720_REG_VM_VSYS_U, + BD72720_REG_VM_VSYS_L, + BD72720_REG_VM_SA_VSYS_U, + BD72720_REG_VM_SA_VSYS_L, + BD72720_REG_VM_SA_VSYS_MIN_U, + BD72720_REG_VM_SA_VSYS_MIN_L, + BD72720_REG_VM_SA_VSYS_MAX_U, + BD72720_REG_VM_SA_VSYS_MAX_L, + BD72720_REG_VM_SA2_VSYS_U, + BD72720_REG_VM_SA2_VSYS_L, + BD72720_REG_VM_VBUS_U, +#define BD72720_MASK_VDCIN_U GENMASK(3, 0) + BD72720_REG_VM_VBUS_L, + BD72720_REG_VM_BATID_U, + BD72720_REG_VM_BATID_L, + BD72720_REG_VM_BATID_NOLOAD_U, + BD72720_REG_VM_BATID_NOLOAD_L, + BD72720_REG_VM_BATID_OFS_U, + BD72720_REG_VM_BATID_OFS_L, + BD72720_REG_VM_VTH_U, + BD72720_REG_VM_VTH_L, + BD72720_REG_VM_VTH_CORR_U, + BD72720_REG_VM_VTH_CORR_L, + BD72720_REG_VM_BTMP_U, + BD72720_REG_VM_BTMP_L, + BD72720_REG_VM_BTMP_IMP_U, + BD72720_REG_VM_BTMP_IMP_L, + BD72720_REG_VM_VF_U, + BD72720_REG_VM_VF_L, + BD72720_REG_VM_BATID_TH_U, + BD72720_REG_VM_BATID_TH_L, + BD72720_REG_VM_BTMP_OV_THR, + BD72720_REG_VM_BTMP_OV_DUR, + BD72720_REG_VM_BTMP_LO_THR, + BD72720_REG_VM_BTMP_LO_DUR, + BD72720_REG_ALM_VBAT_TH_U, + BD72720_REG_ALM_VBAT_TH_L, + BD72720_REG_ALM_VSYS_TH, + BD72720_REG_ALM_VBUS_TH, + BD72720_REG_ALM_VF_TH, + BD72720_REG_VSYS_MAX, + BD72720_REG_VSYS_MIN, + BD72720_REG_VM_VSYS_SA_MINMAX_CTRL, + BD72720_REG_VM_SA_CFG, /* 0x6c + offset*/ + + BD72720_REG_CC_CURCD_U =3D BD72720_I2C4C_ADDR_OFFSET + 0x70, + BD72720_REG_CC_CURCD_L, + BD72720_REG_CC_CURCD_IMP_U, + BD72720_REG_CC_CURCD_IMP_L, + BD72720_REG_CC_SA_CURCD_U, + BD72720_REG_CC_SA_CURCD_L, + BD72720_REG_CC_OCUR_MON, + BD72720_REG_CC_CCNTD_3, + BD72720_REG_CC_CCNTD_2, + BD72720_REG_CC_CCNTD_1, + BD72720_REG_CC_CCNTD_0, + BD72720_REG_REX_CCNTD_3, + BD72720_REG_REX_CCNTD_2, + BD72720_REG_REX_CCNTD_1, + BD72720_REG_REX_CCNTD_0, + BD72720_REG_FULL_CCNTD_3, + BD72720_REG_FULL_CCNTD_2, + BD72720_REG_FULL_CCNTD_1, + BD72720_REG_FULL_CCNTD_0, + BD72720_REG_CCNTD_CHG_3, + BD72720_REG_CCNTD_CHG_2, + BD72720_REG_CC_STAT, + BD72720_REG_CC_CTRL, + BD72720_REG_CC_OCUR_THR_1, + BD72720_REG_CC_OCUR_THR_2, + BD72720_REG_CC_OCUR_THR_3, + BD72720_REG_REX_CURCD_TH, + BD72720_REG_CC_BATCAP1_TH_U, + BD72720_REG_CC_BATCAP1_TH_L, + BD72720_REG_CC_BATCAP2_TH_U, + BD72720_REG_CC_BATCAP2_TH_L, + BD72720_REG_CC_BATCAP3_TH_U, + BD72720_REG_CC_BATCAP3_TH_L, + BD72720_REG_CC_CCNTD_CTRL, + BD72720_REG_CC_SA_CFG, /* 0x92 + offset*/ + BD72720_REG_IMPCHK_CTRL =3D BD72720_I2C4C_ADDR_OFFSET + 0xa0, +}; + +#endif /* __LINUX_MFD_BD72720_H */ diff --git a/include/linux/mfd/rohm-generic.h b/include/linux/mfd/rohm-gene= ric.h index 579e8dcfcca4..0a284919a6c3 100644 --- a/include/linux/mfd/rohm-generic.h +++ b/include/linux/mfd/rohm-generic.h @@ -16,6 +16,7 @@ enum rohm_chip_type { ROHM_CHIP_TYPE_BD71828, ROHM_CHIP_TYPE_BD71837, ROHM_CHIP_TYPE_BD71847, + ROHM_CHIP_TYPE_BD72720, ROHM_CHIP_TYPE_BD96801, ROHM_CHIP_TYPE_BD96802, ROHM_CHIP_TYPE_BD96805, --=20 2.51.0 --/jrsf5iJRM3aFpvr Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEIx+f8wZb28fLKEhTeFA3/03aocUFAmkAXV0ACgkQeFA3/03a ocW4lAf/bwag69g44rkG9SgTO/K+0UQ7reGUJSHaT8S+JI/644JI/aTwv9CV87Ng dl4EMzNDwf2DabATGM4MRb3C6pyC4iYJBKrBQ5RJ8sVj9fX0cyX8IjnMZBDlKarV ZlPOrZpuPVxFro94Z3UtNtbo5N67IUtu5sSPnv2sDNfsuttxGXnmbnddXDsC+A2e TlEwcgTRGQt+7kw/Hz8ps4jd+QfeAjQQQ8WHMHztznmdwaT1kmiMaHcn0UhoLUpv 7gNLhtwdxdhtU1knKoEuMepNJ7kW+Kkdup6U5vDyGdL+i7YkrE9I4eQGBwQ+RC4M /QCisYdD5NaJGBMIXJeuVWREHFyaag== =peCt -----END PGP SIGNATURE----- --/jrsf5iJRM3aFpvr-- From nobody Sat Feb 7 17:55:30 2026 Received: from mail-lj1-f177.google.com (mail-lj1-f177.google.com [209.85.208.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 75F422FD7B8 for ; Mon, 27 Oct 2025 11:47:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761565628; cv=none; b=mZxewesxnr5S/jFCtCjI5Fi0wiEJOJU6SQHv7l291VRbo/km2VReyBe6MkHTffU13iuQJUGkN4Qi4lWc6Z6YpuXvLq81PebUAY017Q37jCYdE51zOhycoqU06zyIz/q4Xp00I/1npCN5DZNSOdul3t8W3ADmtWny01UElrI+kkc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761565628; c=relaxed/simple; bh=KbZYIBikwWSI+GVCWKg5+OPGcA2UgrEFkQgweLtQ6xk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=FsA0tTIO/WqNo6gnHRoTctCw8UJMUMB6eYiPlTH2W/V25TP7SvPh3+7eeYRJaTLbQTMJ6wdHKh8QUEMcCKiaoc5AZe541i/fGauMYoM+wEswfWlTNJH3ST+qtAE7BzgFTBgck+DXG6mw0Yb4i5ntAV4Hey+ql6kxR7mDpZwU378= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gN1iBm/a; arc=none smtp.client-ip=209.85.208.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gN1iBm/a" Received: by mail-lj1-f177.google.com with SMTP id 38308e7fff4ca-3761e5287c9so54035531fa.2 for ; Mon, 27 Oct 2025 04:47:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761565623; x=1762170423; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=yPhjrYnraGxNN/VaL/O/6qvA4/L6CwleXg/ScEIiVlQ=; b=gN1iBm/aT27avoIk/DrZG8G1WrMT7FSaFrGJsRmY3xXQJT/zDpvPTVBzfxjqF+J6En pkykq5+eBwgsQR5ujS48JaFusMQrESuHebjrPDO+JfwJ7yBSZFBs0M7v9HbadRgyZtyr tvjGzNgcSQcIPURCK7YcjQ1vkbtu5y5XHqiOxqJ4ZRbZj4Pe3TeimAI1uwwWHy8O6uYl uQWSizZNparIpxig4ziJ/WAV24OnbnRVRe7MvhUAJ/g4X9uZtZE2pFdagi1G1QLXKxwy lFLvFi9PTchxpXLlGuPgwBA4EC0ZUezbxAdVmV7DBl8FjNaLAjEOk+3asKKYAgznwowM Tekg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761565623; x=1762170423; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=yPhjrYnraGxNN/VaL/O/6qvA4/L6CwleXg/ScEIiVlQ=; b=L8VQ0dgvaurRlS9s8bOdEMbh2AOeLPl398PsH0TEaXlTVg72HA/kWzui/6wi8cV+mj lzLLnvWyHV7Sza9BWLdLnYGh/FO+/PvymvjGRnD4SScEzduV8mGf/AIxnZgMrVQwATL+ xrjz33Hx7es5QzEHI0KXNohFPlJXyOZD5CH2Xq1OD/ywRU0mns0r8I4LsFBs2aMFd/YI PeQacrkzvv/4irNKg92ys546xEOYvhQlDXD3sRuZ8BnVWl9GA+XcjAtlBZKFgrM/uacc 73ulWZV0D74K+NGClzEyyCaU65/UoTvTDMCV71YCRV0OVSPZAO0cHPfWUN5c7hE/fUzs HQjg== X-Forwarded-Encrypted: i=1; AJvYcCVCzT0EunRzXx8DrJF1Pxlyf10ItPFCcEI1VTERe0yPZmwdOtEtauyRo8uLq1SuMiRWM8ad1LJAuLpnDsw=@vger.kernel.org X-Gm-Message-State: AOJu0YwfcUoZkbG17FcYBBl8b6g9YRxAeBMlfJgXwRniDQNhBtR0MN9v mVQ84NmkkSemE6vH+Hh/Pm91FahJQbAKT9DF2WSZIn69igMjNWkkWDWy X-Gm-Gg: ASbGncvfk7bLFr9xuz3qRYKAw8cXNT61MKYe3gy++Fp6YpMDEMJfYnps4D7KA5ARsPI SUVhWQAMJVbwj2FZe1ayJfFuiAjpEFL8nCs8R4P0Zix/IVdaAXCV7fVMm/slKi4Alke4wNpAmpr jDu0/v/73MPGZqjh/x+hc+dXz/YNlrMRjhB78+6wtqezD7v9UjpW3Q+2vkYQ+s/aDxjSH109EUk mfmRVlXVz+Ia6CUUtJ2Pr5Ytn0oLRtCgcGkSOUkO9I5lCjpvb6nWBj5/uFy356iJEZ64ASB0QYm fqzjf0+Tyor5yGO4IFWfIsxe9LMJcuvhEZquhaLAdkjmlWrPOFYpXDqLG2sj+aGHe0Q28qA0sDD aLMhmYC3wfVXXeynL4XdwzqWwfQONrk1f3XC6yHwf0nhWxJOva83JWZz/+hDG6JJouOGnKNMrKc uuf4ob00fF15B0bEhbxA== X-Google-Smtp-Source: AGHT+IFGTBYWCW3ld91Gaf4BxcDyit2xahwuUUbRDChRLg+8atXmQtWwSm/UbdG2xVg1KoE+9y6aEg== X-Received: by 2002:a05:651c:221f:b0:337:e151:9ec with SMTP id 38308e7fff4ca-377978aeff0mr114706621fa.16.1761565622062; Mon, 27 Oct 2025 04:47:02 -0700 (PDT) Received: from mva-rohm ([2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-378ee0d3712sm20091881fa.36.2025.10.27.04.47.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Oct 2025 04:47:01 -0700 (PDT) Date: Mon, 27 Oct 2025 13:46:57 +0200 From: Matti Vaittinen To: Matti Vaittinen , Matti Vaittinen Cc: Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Sebastian Reichel , Liam Girdwood , Mark Brown , Michael Turquette , Stephen Boyd , Matti Vaittinen , Linus Walleij , Bartosz Golaszewski , Andreas Kemnade , Alexandre Belloni , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-rtc@vger.kernel.org Subject: [PATCH v2 08/15] regulator: bd71828: rename IC specific entities Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="hHlLATUC+NJoLwSU" Content-Disposition: inline In-Reply-To: --hHlLATUC+NJoLwSU Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" The new ROHM BD72720 PMIC has similarities with the BD71828. It makes sense to support the regulator control for both PMICs using the same driver. It is often more clear to have the IC specific functions and globals named starting with the chip-name. So, as a preparatory step, prefix the BD71828 specific functions and globals with the bd71828. It would be tempting to try also removing the chip ID from those functions which will be common for both PMICs. I have bad experiences on this as it tends to lead to problems when yet another IC is being supported with the same driver, and we will have some functions used for all, some for two of the three, and some for just one. At this point I used to start inventing wildcards like BD718XX or BD7272X. This approach is pretty much always failing as we tend to eventually have something like BD73900 - where all the wildcard stuff will break down. So, my approach these days is to: - keep the original chip-id prefix for anything that had it already (and avoid the churn). - use same prefix for all things that are used by multiple ICs - typically the chip-ID of the first chip. This typically matches also the driver and file names. - use specific chip-ID as a prefix for anything which is specific to just one chip. As a preparatory step to adding the BD72720, add bd71828 prefix to all commonly usable functions and globals. Signed-off-by: Matti Vaittinen Acked-by: Mark Brown --- Revision history: RFCv1 =3D>: - No changes No functional changes intended. --- drivers/regulator/bd71828-regulator.c | 32 +++++++++++++-------------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/regulator/bd71828-regulator.c b/drivers/regulator/bd71= 828-regulator.c index dd871ffe979c..3d18dbfdb84e 100644 --- a/drivers/regulator/bd71828-regulator.c +++ b/drivers/regulator/bd71828-regulator.c @@ -28,7 +28,7 @@ struct bd71828_regulator_data { int reg_init_amnt; }; =20 -static const struct reg_init buck1_inits[] =3D { +static const struct reg_init bd71828_buck1_inits[] =3D { /* * DVS Buck voltages can be changed by register values or via GPIO. * Use register accesses by default. @@ -40,7 +40,7 @@ static const struct reg_init buck1_inits[] =3D { }, }; =20 -static const struct reg_init buck2_inits[] =3D { +static const struct reg_init bd71828_buck2_inits[] =3D { { .reg =3D BD71828_REG_PS_CTRL_1, .mask =3D BD71828_MASK_DVS_BUCK2_CTRL, @@ -48,7 +48,7 @@ static const struct reg_init buck2_inits[] =3D { }, }; =20 -static const struct reg_init buck6_inits[] =3D { +static const struct reg_init bd71828_buck6_inits[] =3D { { .reg =3D BD71828_REG_PS_CTRL_1, .mask =3D BD71828_MASK_DVS_BUCK6_CTRL, @@ -56,7 +56,7 @@ static const struct reg_init buck6_inits[] =3D { }, }; =20 -static const struct reg_init buck7_inits[] =3D { +static const struct reg_init bd71828_buck7_inits[] =3D { { .reg =3D BD71828_REG_PS_CTRL_1, .mask =3D BD71828_MASK_DVS_BUCK7_CTRL, @@ -102,9 +102,9 @@ static int buck_set_hw_dvs_levels(struct device_node *n= p, return rohm_regulator_set_dvs_levels(&data->dvs, np, desc, cfg->regmap); } =20 -static int ldo6_parse_dt(struct device_node *np, - const struct regulator_desc *desc, - struct regulator_config *cfg) +static int bd71828_ldo6_parse_dt(struct device_node *np, + const struct regulator_desc *desc, + struct regulator_config *cfg) { int ret, i; uint32_t uv =3D 0; @@ -212,8 +212,8 @@ static const struct bd71828_regulator_data bd71828_rdat= a[] =3D { */ .lpsr_on_mask =3D BD71828_MASK_LPSR_EN, }, - .reg_inits =3D buck1_inits, - .reg_init_amnt =3D ARRAY_SIZE(buck1_inits), + .reg_inits =3D bd71828_buck1_inits, + .reg_init_amnt =3D ARRAY_SIZE(bd71828_buck1_inits), }, { .desc =3D { @@ -253,8 +253,8 @@ static const struct bd71828_regulator_data bd71828_rdat= a[] =3D { .lpsr_reg =3D BD71828_REG_BUCK2_SUSP_VOLT, .lpsr_mask =3D BD71828_MASK_BUCK1267_VOLT, }, - .reg_inits =3D buck2_inits, - .reg_init_amnt =3D ARRAY_SIZE(buck2_inits), + .reg_inits =3D bd71828_buck2_inits, + .reg_init_amnt =3D ARRAY_SIZE(bd71828_buck2_inits), }, { .desc =3D { @@ -399,8 +399,8 @@ static const struct bd71828_regulator_data bd71828_rdat= a[] =3D { .lpsr_reg =3D BD71828_REG_BUCK6_SUSP_VOLT, .lpsr_mask =3D BD71828_MASK_BUCK1267_VOLT, }, - .reg_inits =3D buck6_inits, - .reg_init_amnt =3D ARRAY_SIZE(buck6_inits), + .reg_inits =3D bd71828_buck6_inits, + .reg_init_amnt =3D ARRAY_SIZE(bd71828_buck6_inits), }, { .desc =3D { @@ -440,8 +440,8 @@ static const struct bd71828_regulator_data bd71828_rdat= a[] =3D { .lpsr_reg =3D BD71828_REG_BUCK7_SUSP_VOLT, .lpsr_mask =3D BD71828_MASK_BUCK1267_VOLT, }, - .reg_inits =3D buck7_inits, - .reg_init_amnt =3D ARRAY_SIZE(buck7_inits), + .reg_inits =3D bd71828_buck7_inits, + .reg_init_amnt =3D ARRAY_SIZE(bd71828_buck7_inits), }, { .desc =3D { @@ -633,7 +633,7 @@ static const struct bd71828_regulator_data bd71828_rdat= a[] =3D { * LDO6 only supports enable/disable for all states. * Voltage for LDO6 is fixed. */ - .of_parse_cb =3D ldo6_parse_dt, + .of_parse_cb =3D bd71828_ldo6_parse_dt, }, }, { .desc =3D { --=20 2.51.0 --hHlLATUC+NJoLwSU Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEIx+f8wZb28fLKEhTeFA3/03aocUFAmj/W7EACgkQeFA3/03a ocXFRAf/X2TvPapTD+az8EHYbCCnjJcIvHuUfnEQlERv5ijnP0Gl1KSmtaVPlpvl VEVmc5eK8QfVVA8akUmsAFtEQ17BUXteFoPdjVb37GJGuyW+tH+R4GpNKRXbpsPT kxqHs/o5fxk7ESJZhWCSErb1jZyKhuluMo8331A00dHZW9zGIielOf/2Cs8eoxMf tF4+VUmvy/nfAGhfOyfvPy7WLouZFhQdgUI/u7KhsibBAlIBjVrWz2pcXsCAx2qu dtxESaLBV3H3wleVqN84Hxhiok+cPhW8tz85MtBhBxHT7tNbM+QjUe/jHxk2GnOM 5t6EpGBTVdq0zs4EwAkPzUE5uFCr2Q== =9ybE -----END PGP SIGNATURE----- --hHlLATUC+NJoLwSU-- From nobody Sat Feb 7 17:55:30 2026 Received: from mail-lj1-f177.google.com (mail-lj1-f177.google.com [209.85.208.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E5B772FE595 for ; Mon, 27 Oct 2025 11:47:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761565643; cv=none; b=TjsNkO0ELnB2c4TBmtVMiGGrlBcGo6115QrCDh38+IbfF9SFsneqadDEvEGZVcX+doXOF3Eku8qoztVbDsavg+IJHSNPRwgX67ESXpmv8D9QQgXj/Y9moC3wLVmMewcT8wOubrlSs4MH72Cl7IBB5ACJwdcy8TItL8mZFb/+L6w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761565643; c=relaxed/simple; bh=OpNQRY/E6d0571qOHtdQ5ijc2j/tKxQwb6SOsvL1+ho=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=osleMc42/qxmTVqx9bokI+ONPbfxoLhOSomA5JmVc0qvWBcpUxYY9CeIuYykfJYSFhK/ak41V7VYGBTDWr58HaSwy6klfIh0iw0uCz2FQJxhmpuePiI3kbApg0sN4Du7btcK0tPPNOsOLUapfywnMS/l3FvxMhGjA/0l7sSvX6g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fJpzbOAJ; arc=none smtp.client-ip=209.85.208.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fJpzbOAJ" Received: by mail-lj1-f177.google.com with SMTP id 38308e7fff4ca-378d54f657fso54537001fa.2 for ; Mon, 27 Oct 2025 04:47:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761565637; x=1762170437; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=kzYgp4aOPmpGbxZIe9nqZBgchif6JWQz1RGBrybdWHE=; b=fJpzbOAJudt3Xgtn50ZWZLEl7rE9oPQfR13GUoQ5TYTO9XIi6L7OUzdvlO1Pdtab6G F9klo3vEt7fRRtmLYBw9yMyJqr+4kyGLVgsWBCIkhc1P15ZAtI1RtLlCeJHWfsXz2bit lfDLk5Tf+M92IO3Ujk5wnZSgG8ii+l5CO6v9+ivWSYqkYA1dBOcSgtKTVVPodB7eKfdp OgAYxaxei329HHRORVcoiPWlP/gHSwn5MK6mT46XO0LYU2cv64m6cE/uE1uJuYYCPeez ZKvP21qumtnH4a7kcMoowv/KcrXUCVJZ+QFHMhZu5FWu6dth3JpIoPg4bhrWhS5o4lAX k6qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761565637; x=1762170437; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=kzYgp4aOPmpGbxZIe9nqZBgchif6JWQz1RGBrybdWHE=; b=oeqxWszlAkKbzrPHCHkpI0aRp0xN7Dc42AEpxr3ncTH9BPDbkSfQQJD+eV8PjU43dx gme2eKtBebgoFzN8tYG3Bmk2Sk3Rp8YEq4cwc2Sv1jNvh6JpQmZWRFEJKA5tOHbXOnY3 IoJukqMr2/+y1DYKqRC8Octa54cQGrrpEi1GIJtUWqa3xat7dwfiHnQr7WQzLcf6RRaD XWytOtFipIM+NwCftu4PZm5ISWIcJ3B8IMs1pyh6KRAO8pGLlr39CxJMaA5fHTRIAsh8 kCt3m3Wlr68+DqqzFHQdj212G0rGEUqJoHxPiMXYUIsOJnLfFowphRRbh0+1ejc22n3v 1HDg== X-Forwarded-Encrypted: i=1; AJvYcCUyCHf3c0tnR2FwfmTKM7OFUFjQQIBLtb/7Gfz9kGAapfKCkmWKrYg26sk0DWQwwvtRaKOm0dczD4KjA/8=@vger.kernel.org X-Gm-Message-State: AOJu0YxUbjGkrfjuTjEXdKTRyrfVXtn6nfO/L9Gz2wYMntyc3s9Qb4Vo dSmIenWdzFWot6dEcyK7oem0JiRzygtS+nHQyamviXp4mBYtPx34hK6Z X-Gm-Gg: ASbGnctxxBlVmlbt3hLbg40bHtEsSxoOJ2dXkFICH5LNX7hZASifaS/doKAvjzTj9hG BkdRJ7NaMFK9W0fOsD7FvwnSlbScMLLZrdzJoq6EVgwsIun77CM7klJFHYCk0EM7eC5NNRYy3Vq 2wkhCT5MNqtZpJSwikFLgRPxr3Y95nF9i/Zb5Nsn6wo+pUvBW4JaSGJ1/kvBL5Iw3tRMEU1PjGQ abOfHHKoKzhGxUIKiT+DvDjH0yuUZbcWFBvORH8u6eJg/0hKj1gmlsbykRl/KVAI0W8qwNpW+oK eHVBgVFLWJhzd+RqtNQBvg34ZzAOdsLNFrChnS4KE0ACqr/MXgGUr5o+cSLd8L7dPC8AtHwW7OS VwLVuyUvvv7D7nJZOWO3VmKLBxmOLtw4YVLZ53MRLz7gz6ppau59d7cEZsxg1C4PyKl0oEnJ4R5 xIrik48xlsmOVaKqZVDw== X-Google-Smtp-Source: AGHT+IHt3kQ9qH5Dh5PKUQPs71Ex6gp8btqyjtny5nvhsApPlvXmaSzF2KbKIqpuGel3kE7OC2sPRg== X-Received: by 2002:a05:651c:887:b0:36e:ca93:62df with SMTP id 38308e7fff4ca-3779782bffemr107005311fa.3.1761565636606; Mon, 27 Oct 2025 04:47:16 -0700 (PDT) Received: from mva-rohm ([2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-378ee09d0adsm19636271fa.16.2025.10.27.04.47.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Oct 2025 04:47:15 -0700 (PDT) Date: Mon, 27 Oct 2025 13:47:10 +0200 From: Matti Vaittinen To: Matti Vaittinen , Matti Vaittinen Cc: Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Sebastian Reichel , Liam Girdwood , Mark Brown , Michael Turquette , Stephen Boyd , Matti Vaittinen , Linus Walleij , Bartosz Golaszewski , Andreas Kemnade , Alexandre Belloni , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-rtc@vger.kernel.org Subject: [PATCH v2 09/15] regulator: bd71828: Support ROHM BD72720 Message-ID: <28f888c9784058b2d727a4b6185ac49874552847.1761564043.git.mazziesaccount@gmail.com> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="svkOyahV7o+mGO8I" Content-Disposition: inline In-Reply-To: --svkOyahV7o+mGO8I Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" ROHM BD72720 is a power management IC which integrates 10 buck and 11 LDO regulators. This PMIC has plenty of commonalities with the BD71828 and BD71879. The BD72720 does also have similar 'run-level'-concept as the BD71828 had. It allows controlling the regulator's 'en masse', although only BUCK1 and LDO1 can utilize this in BD72720. Similar to BD71828, this 'en masse' -control is not supported by this driver. Support the voltage and enable/disable state control for the BD72720. Signed-off-by: Matti Vaittinen Reviewed-by: Mark Brown --- Revision history: RFCv1 =3D>: - No changes There are some new variants planned. Most notably, the BD73900 should be similar to the BD72720 what comes to the regulator control logic. If the run-level control is needed, there are some downstream extensions available at: https://rohmsemiconductor.github.io/Linux-Kernel-PMIC-Drivers/BD72720/ --- drivers/regulator/Kconfig | 8 +- drivers/regulator/bd71828-regulator.c | 993 +++++++++++++++++++++++++- 2 files changed, 992 insertions(+), 9 deletions(-) diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig index d84f3d054c59..660863f096e3 100644 --- a/drivers/regulator/Kconfig +++ b/drivers/regulator/Kconfig @@ -241,13 +241,13 @@ config REGULATOR_BD71815 will be called bd71815-regulator. =20 config REGULATOR_BD71828 - tristate "ROHM BD71828 Power Regulator" + tristate "ROHM BD71828, BD72720 and BD73900 Power Regulators" depends on MFD_ROHM_BD71828 select REGULATOR_ROHM help - This driver supports voltage regulators on ROHM BD71828 PMIC. - This will enable support for the software controllable buck - and LDO regulators. + This driver supports voltage regulators on ROHM BD71828, + BD71879, BD72720 and BD73900 PMICs. This will enable + support for the software controllable buck and LDO regulators. =20 This driver can also be built as a module. If so, the module will be called bd71828-regulator. diff --git a/drivers/regulator/bd71828-regulator.c b/drivers/regulator/bd71= 828-regulator.c index 3d18dbfdb84e..61ba82c7c6f1 100644 --- a/drivers/regulator/bd71828-regulator.c +++ b/drivers/regulator/bd71828-regulator.c @@ -3,12 +3,15 @@ // bd71828-regulator.c ROHM BD71828GW-DS1 regulator driver // =20 +#include #include #include #include #include #include +#include #include +#include #include #include #include @@ -16,6 +19,7 @@ #include #include =20 +#define BD72720_MASK_LDON_HEAD GENMASK(2, 0) struct reg_init { unsigned int reg; unsigned int mask; @@ -64,6 +68,26 @@ static const struct reg_init bd71828_buck7_inits[] =3D { }, }; =20 +#define BD72720_MASK_DVS_BUCK1_CTRL BIT(4) +#define BD72720_MASK_DVS_LDO1_CTRL BIT(5) + +static const struct reg_init bd72720_buck1_inits[] =3D { + { + .reg =3D BD72720_REG_PS_CTRL_2, + .mask =3D BD72720_MASK_DVS_BUCK1_CTRL, + .val =3D 0, /* Disable "run-level" control */ + }, +}; + +static const struct reg_init bd72720_ldo1_inits[] =3D { + { + .reg =3D BD72720_REG_PS_CTRL_2, + .mask =3D BD72720_MASK_DVS_LDO1_CTRL, + .val =3D 0, /* Disable "run-level" control */ + }, +}; + +/* BD71828 Buck voltages */ static const struct linear_range bd71828_buck1267_volts[] =3D { REGULATOR_LINEAR_RANGE(500000, 0x00, 0xef, 6250), REGULATOR_LINEAR_RANGE(2000000, 0xf0, 0xff, 0), @@ -84,13 +108,79 @@ static const struct linear_range bd71828_buck5_volts[]= =3D { REGULATOR_LINEAR_RANGE(3300000, 0x10, 0x1f, 0), }; =20 +/* BD71828 LDO voltages */ static const struct linear_range bd71828_ldo_volts[] =3D { REGULATOR_LINEAR_RANGE(800000, 0x00, 0x31, 50000), REGULATOR_LINEAR_RANGE(3300000, 0x32, 0x3f, 0), }; =20 +/* BD72720 Buck voltages */ +static const struct linear_range bd72720_buck1234_volts[] =3D { + REGULATOR_LINEAR_RANGE(500000, 0x00, 0xc0, 6250), + REGULATOR_LINEAR_RANGE(1700000, 0xc1, 0xff, 0), +}; + +static const struct linear_range bd72720_buck589_volts[] =3D { + REGULATOR_LINEAR_RANGE(500000, 0x00, 0x78, 10000), + REGULATOR_LINEAR_RANGE(1700000, 0x79, 0xff, 0), +}; + +static const struct linear_range bd72720_buck67_volts[] =3D { + REGULATOR_LINEAR_RANGE(1500000, 0x00, 0xb4, 10000), + REGULATOR_LINEAR_RANGE(3300000, 0xb5, 0xff, 0), +}; + +/* + * The BUCK10 on BD72720 has two modes of operation, depending on a LDON_H= EAD + * setting. When LDON_HEAD is 0x0, the behaviour is as with other bucks, e= g. + * voltage can be set to a values indicated below using the VSEL register. + * + * However, when LDON_HEAD is set to 0x1 ... 0x7, BUCK 10 voltage is, acco= rding + * to the data-sheet, "automatically adjusted following LDON_HEAD setting = and + * clamped to BUCK10_VID setting". + * + * Again, reading the data-sheet shows a "typical connection" where the BU= CK10 + * is used to supply the LDOs 1-4. My assumption is that in practice, this + * means that the BUCK10 voltage will be adjusted based on the maximum out= put + * of the LDO 1-4 (to minimize power loss). This makes sense. + * + * Auto-adjusting regulators aren't something I really like to model in the + * driver though - and, if the auto-adjustment works as intended, then the= re + * should really be no need to software to care about the buck10 voltages. + * If enable/disable control is still needed, we can implement buck10 as a + * regulator with only the enable/disable ops - and device-tree can be used + * to model the supply-relations. I believe this could allow the regulator + * framework to automagically disable the BUCK10 if all LDOs that are being + * supplied by it are disabled. + */ +static const struct linear_range bd72720_buck10_volts[] =3D { + REGULATOR_LINEAR_RANGE(500000, 0x00, 0xc0, 6250), + REGULATOR_LINEAR_RANGE(1700000, 0xc1, 0xff, 0), +}; + +/* BD72720 LDO voltages */ +static const struct linear_range bd72720_ldo1234_volts[] =3D { + REGULATOR_LINEAR_RANGE(500000, 0x00, 0x50, 6250), + REGULATOR_LINEAR_RANGE(1000000, 0x51, 0x7f, 0), +}; + +static const struct linear_range bd72720_ldo57891011_volts[] =3D { + REGULATOR_LINEAR_RANGE(750000, 0x00, 0xff, 10000), +}; + +static const struct linear_range bd72720_ldo6_volts[] =3D { + REGULATOR_LINEAR_RANGE(600000, 0x00, 0x78, 10000), + REGULATOR_LINEAR_RANGE(1800000, 0x79, 0x7f, 0), +}; + static const unsigned int bd71828_ramp_delay[] =3D { 2500, 5000, 10000, 20= 000 }; =20 +/* + * BD72720 supports setting both the ramp-up and ramp-down values + * separately. Do we need to support ramp-down setting? + */ +static const unsigned int bd72720_ramp_delay[] =3D { 5000, 7500, 10000, 12= 500 }; + static int buck_set_hw_dvs_levels(struct device_node *np, const struct regulator_desc *desc, struct regulator_config *cfg) @@ -171,6 +261,24 @@ static const struct regulator_ops bd71828_ldo6_ops =3D= { .is_enabled =3D regulator_is_enabled_regmap, }; =20 +static const struct regulator_ops bd72720_regulator_ops =3D { + .enable =3D regulator_enable_regmap, + .disable =3D regulator_disable_regmap, + .is_enabled =3D regulator_is_enabled_regmap, + .list_voltage =3D regulator_list_voltage_linear_range, + .set_voltage_sel =3D regulator_set_voltage_sel_regmap, + .get_voltage_sel =3D regulator_get_voltage_sel_regmap, + .set_voltage_time_sel =3D regulator_set_voltage_time_sel, + .set_ramp_delay =3D regulator_set_ramp_delay_regmap, +}; + +static const struct regulator_ops bd72720_buck10_ldon_head_op =3D { + .enable =3D regulator_enable_regmap, + .disable =3D regulator_disable_regmap, + .is_enabled =3D regulator_is_enabled_regmap, + .set_ramp_delay =3D regulator_set_ramp_delay_regmap, +}; + static const struct bd71828_regulator_data bd71828_rdata[] =3D { { .desc =3D { @@ -677,22 +785,890 @@ static const struct bd71828_regulator_data bd71828_r= data[] =3D { }, }; =20 +#define BD72720_BUCK10_DESC_INDEX 10 +#define BD72720_NUM_BUCK_VOLTS 0x100 +#define BD72720_NUM_LDO_VOLTS 0x100 +#define BD72720_NUM_LDO12346_VOLTS 0x80 + +static const struct bd71828_regulator_data bd72720_rdata[] =3D { + { + .desc =3D { + .name =3D "buck1", + .of_match =3D of_match_ptr("buck1"), + .regulators_node =3D of_match_ptr("regulators"), + .id =3D BD72720_BUCK1, + .type =3D REGULATOR_VOLTAGE, + + /* + * The BD72720 BUCK1 and LDO1 support GPIO toggled + * sub-RUN states called RUN0, RUN1, RUN2 and RUN3. + * The "operating mode" (sub-RUN states or normal) + * can be changed by a register. + * + * When the sub-RUN states are used, the voltage and + * enable state depend on a state specific + * configuration. The voltage and enable configuration + * for BUCK1 and LDO1 can be defined for each sub-RUN + * state using BD72720_REG_[BUCK,LDO]1_VSEL_R[0,1,2,3] + * voltage selection registers and the bits + * BD72720_MASK_RUN_[0,1,2,3]_EN in the enable registers. + * The PMIC will change both the BUCK1 and LDO1 voltages + * to the states defined in these registers when + * "DVS GPIOs" are toggled. + * + * If RUN 0 .. RUN 4 states are to be used, the normal + * voltage configuration mechanisms do not apply + * and we should overwrite the ops and ignore the + * voltage setting/getting registers which are setup + * here. This is not supported for now. If you need + * this functionality, you may try merging functionality + * from a downstream driver: + * https://rohmsemiconductor.github.io/Linux-Kernel-PMIC-Drivers/BD7272= 0/ + */ + .ops =3D &bd72720_regulator_ops, + .linear_ranges =3D bd72720_buck1234_volts, + .n_linear_ranges =3D ARRAY_SIZE(bd72720_buck1234_volts), + .n_voltages =3D BD72720_NUM_BUCK_VOLTS, + .enable_reg =3D BD72720_REG_BUCK1_ON, + .enable_mask =3D BD72720_MASK_RUN_B_EN, + .vsel_reg =3D BD72720_REG_BUCK1_VSEL_RB, + .vsel_mask =3D BD72720_MASK_BUCK_VSEL, + + .ramp_delay_table =3D bd72720_ramp_delay, + .n_ramp_values =3D ARRAY_SIZE(bd72720_ramp_delay), + .ramp_reg =3D BD72720_REG_BUCK1_MODE, + .ramp_mask =3D BD72720_MASK_RAMP_UP_DELAY, + .owner =3D THIS_MODULE, + .of_parse_cb =3D buck_set_hw_dvs_levels, + }, + .dvs =3D { + .level_map =3D ROHM_DVS_LEVEL_RUN | ROHM_DVS_LEVEL_IDLE | + ROHM_DVS_LEVEL_SUSPEND | + ROHM_DVS_LEVEL_LPSR, /* Deep idle in data-sheet */ + .run_reg =3D BD72720_REG_BUCK1_VSEL_RB, + .run_mask =3D BD72720_MASK_BUCK_VSEL, + .idle_reg =3D BD72720_REG_BUCK1_VSEL_I, + .idle_mask =3D BD72720_MASK_BUCK_VSEL, + .idle_on_mask =3D BD72720_MASK_IDLE_EN, + .suspend_reg =3D BD72720_REG_BUCK1_VSEL_S, + .suspend_mask =3D BD72720_MASK_BUCK_VSEL, + .suspend_on_mask =3D BD72720_MASK_SUSPEND_EN, + .lpsr_reg =3D BD72720_REG_BUCK1_VSEL_DI, + .lpsr_mask =3D BD72720_MASK_BUCK_VSEL, + .lpsr_on_mask =3D BD72720_MASK_DEEP_IDLE_EN, + }, + .reg_inits =3D bd72720_buck1_inits, + .reg_init_amnt =3D ARRAY_SIZE(bd72720_buck1_inits), + }, { + .desc =3D { + .name =3D "buck2", + .of_match =3D of_match_ptr("buck2"), + .regulators_node =3D of_match_ptr("regulators"), + .id =3D BD72720_BUCK2, + .type =3D REGULATOR_VOLTAGE, + .ops =3D &bd72720_regulator_ops, + .linear_ranges =3D bd72720_buck1234_volts, + .n_linear_ranges =3D ARRAY_SIZE(bd72720_buck1234_volts), + .n_voltages =3D BD72720_NUM_BUCK_VOLTS, + .enable_reg =3D BD72720_REG_BUCK2_ON, + .enable_mask =3D BD72720_MASK_RUN_B_EN, + .vsel_reg =3D BD72720_REG_BUCK2_VSEL_R, + .vsel_mask =3D BD72720_MASK_BUCK_VSEL, + + .ramp_delay_table =3D bd72720_ramp_delay, + .n_ramp_values =3D ARRAY_SIZE(bd72720_ramp_delay), + .ramp_reg =3D BD72720_REG_BUCK2_MODE, + .ramp_mask =3D BD72720_MASK_RAMP_UP_DELAY, + .owner =3D THIS_MODULE, + .of_parse_cb =3D buck_set_hw_dvs_levels, + }, + .dvs =3D { + .level_map =3D ROHM_DVS_LEVEL_RUN | ROHM_DVS_LEVEL_IDLE | + ROHM_DVS_LEVEL_SUSPEND | + ROHM_DVS_LEVEL_LPSR, + .run_reg =3D BD72720_REG_BUCK2_VSEL_R, + .run_mask =3D BD72720_MASK_BUCK_VSEL, + .idle_reg =3D BD72720_REG_BUCK2_VSEL_I, + .idle_mask =3D BD72720_MASK_BUCK_VSEL, + .idle_on_mask =3D BD72720_MASK_IDLE_EN, + .suspend_reg =3D BD72720_REG_BUCK2_VSEL_S, + .suspend_mask =3D BD72720_MASK_BUCK_VSEL, + .suspend_on_mask =3D BD72720_MASK_SUSPEND_EN, + .lpsr_reg =3D BD72720_REG_BUCK2_VSEL_DI, + .lpsr_mask =3D BD72720_MASK_BUCK_VSEL, + .lpsr_on_mask =3D BD72720_MASK_DEEP_IDLE_EN, + }, + }, { + .desc =3D { + .name =3D "buck3", + .of_match =3D of_match_ptr("buck3"), + .regulators_node =3D of_match_ptr("regulators"), + .id =3D BD72720_BUCK3, + .type =3D REGULATOR_VOLTAGE, + .ops =3D &bd72720_regulator_ops, + .linear_ranges =3D bd72720_buck1234_volts, + .n_linear_ranges =3D ARRAY_SIZE(bd72720_buck1234_volts), + .n_voltages =3D BD72720_NUM_BUCK_VOLTS, + .enable_reg =3D BD72720_REG_BUCK3_ON, + .enable_mask =3D BD72720_MASK_RUN_B_EN, + .vsel_reg =3D BD72720_REG_BUCK3_VSEL_R, + .vsel_mask =3D BD72720_MASK_BUCK_VSEL, + + .ramp_delay_table =3D bd72720_ramp_delay, + .n_ramp_values =3D ARRAY_SIZE(bd72720_ramp_delay), + .ramp_reg =3D BD72720_REG_BUCK3_MODE, + .ramp_mask =3D BD72720_MASK_RAMP_UP_DELAY, + .owner =3D THIS_MODULE, + .of_parse_cb =3D buck_set_hw_dvs_levels, + }, + .dvs =3D { + .level_map =3D ROHM_DVS_LEVEL_RUN | ROHM_DVS_LEVEL_IDLE | + ROHM_DVS_LEVEL_SUSPEND | + ROHM_DVS_LEVEL_LPSR, + .run_reg =3D BD72720_REG_BUCK3_VSEL_R, + .run_mask =3D BD72720_MASK_BUCK_VSEL, + .idle_reg =3D BD72720_REG_BUCK3_VSEL_I, + .idle_mask =3D BD72720_MASK_BUCK_VSEL, + .idle_on_mask =3D BD72720_MASK_IDLE_EN, + .suspend_reg =3D BD72720_REG_BUCK3_VSEL_S, + .suspend_mask =3D BD72720_MASK_BUCK_VSEL, + .suspend_on_mask =3D BD72720_MASK_SUSPEND_EN, + .lpsr_reg =3D BD72720_REG_BUCK3_VSEL_DI, + .lpsr_mask =3D BD72720_MASK_BUCK_VSEL, + .lpsr_on_mask =3D BD72720_MASK_DEEP_IDLE_EN, + }, + }, { + .desc =3D { + .name =3D "buck4", + .of_match =3D of_match_ptr("buck4"), + .regulators_node =3D of_match_ptr("regulators"), + .id =3D BD72720_BUCK4, + .type =3D REGULATOR_VOLTAGE, + .ops =3D &bd72720_regulator_ops, + .linear_ranges =3D bd72720_buck1234_volts, + .n_linear_ranges =3D ARRAY_SIZE(bd72720_buck1234_volts), + .n_voltages =3D BD72720_NUM_BUCK_VOLTS, + .enable_reg =3D BD72720_REG_BUCK4_ON, + .enable_mask =3D BD72720_MASK_RUN_B_EN, + .vsel_reg =3D BD72720_REG_BUCK4_VSEL_R, + .vsel_mask =3D BD72720_MASK_BUCK_VSEL, + + .ramp_delay_table =3D bd72720_ramp_delay, + .n_ramp_values =3D ARRAY_SIZE(bd72720_ramp_delay), + .ramp_reg =3D BD72720_REG_BUCK4_MODE, + .ramp_mask =3D BD72720_MASK_RAMP_UP_DELAY, + .owner =3D THIS_MODULE, + .of_parse_cb =3D buck_set_hw_dvs_levels, + }, + .dvs =3D { + .level_map =3D ROHM_DVS_LEVEL_RUN | ROHM_DVS_LEVEL_IDLE | + ROHM_DVS_LEVEL_SUSPEND | + ROHM_DVS_LEVEL_LPSR, + .run_reg =3D BD72720_REG_BUCK4_VSEL_R, + .run_mask =3D BD72720_MASK_BUCK_VSEL, + .idle_reg =3D BD72720_REG_BUCK4_VSEL_I, + .idle_mask =3D BD72720_MASK_BUCK_VSEL, + .idle_on_mask =3D BD72720_MASK_IDLE_EN, + .suspend_reg =3D BD72720_REG_BUCK4_VSEL_S, + .suspend_mask =3D BD72720_MASK_BUCK_VSEL, + .suspend_on_mask =3D BD72720_MASK_SUSPEND_EN, + .lpsr_reg =3D BD72720_REG_BUCK4_VSEL_DI, + .lpsr_mask =3D BD72720_MASK_BUCK_VSEL, + .lpsr_on_mask =3D BD72720_MASK_DEEP_IDLE_EN, + }, + }, { + .desc =3D { + .name =3D "buck5", + .of_match =3D of_match_ptr("buck5"), + .regulators_node =3D of_match_ptr("regulators"), + .id =3D BD72720_BUCK5, + .type =3D REGULATOR_VOLTAGE, + .ops =3D &bd72720_regulator_ops, + .linear_ranges =3D bd72720_buck589_volts, + .n_linear_ranges =3D ARRAY_SIZE(bd72720_buck589_volts), + .n_voltages =3D BD72720_NUM_BUCK_VOLTS, + .enable_reg =3D BD72720_REG_BUCK5_ON, + .enable_mask =3D BD72720_MASK_RUN_B_EN, + .vsel_reg =3D BD72720_REG_BUCK5_VSEL, + .vsel_mask =3D BD72720_MASK_BUCK_VSEL, + + .ramp_delay_table =3D bd72720_ramp_delay, + .n_ramp_values =3D ARRAY_SIZE(bd72720_ramp_delay), + .ramp_reg =3D BD72720_REG_BUCK5_MODE, + .ramp_mask =3D BD72720_MASK_RAMP_UP_DELAY, + .owner =3D THIS_MODULE, + .of_parse_cb =3D buck_set_hw_dvs_levels, + }, + .dvs =3D { + .level_map =3D ROHM_DVS_LEVEL_RUN | ROHM_DVS_LEVEL_IDLE | + ROHM_DVS_LEVEL_SUSPEND | + ROHM_DVS_LEVEL_LPSR, + .run_reg =3D BD72720_REG_BUCK5_VSEL, + .run_mask =3D BD72720_MASK_BUCK_VSEL, + .idle_on_mask =3D BD72720_MASK_IDLE_EN, + .suspend_on_mask =3D BD72720_MASK_SUSPEND_EN, + .lpsr_on_mask =3D BD72720_MASK_DEEP_IDLE_EN, + }, + }, { + .desc =3D { + .name =3D "buck6", + .of_match =3D of_match_ptr("buck6"), + .regulators_node =3D of_match_ptr("regulators"), + .id =3D BD72720_BUCK6, + .type =3D REGULATOR_VOLTAGE, + .ops =3D &bd72720_regulator_ops, + .linear_ranges =3D bd72720_buck67_volts, + .n_linear_ranges =3D ARRAY_SIZE(bd72720_buck67_volts), + .n_voltages =3D BD72720_NUM_BUCK_VOLTS, + .enable_reg =3D BD72720_REG_BUCK6_ON, + .enable_mask =3D BD72720_MASK_RUN_B_EN, + .vsel_reg =3D BD72720_REG_BUCK6_VSEL, + .vsel_mask =3D BD72720_MASK_BUCK_VSEL, + + .ramp_delay_table =3D bd72720_ramp_delay, + .n_ramp_values =3D ARRAY_SIZE(bd72720_ramp_delay), + .ramp_reg =3D BD72720_REG_BUCK6_MODE, + .ramp_mask =3D BD72720_MASK_RAMP_UP_DELAY, + .owner =3D THIS_MODULE, + .of_parse_cb =3D buck_set_hw_dvs_levels, + }, + .dvs =3D { + .level_map =3D ROHM_DVS_LEVEL_RUN | ROHM_DVS_LEVEL_IDLE | + ROHM_DVS_LEVEL_SUSPEND | + ROHM_DVS_LEVEL_LPSR, + .run_reg =3D BD72720_REG_BUCK6_VSEL, + .run_mask =3D BD72720_MASK_BUCK_VSEL, + .idle_on_mask =3D BD72720_MASK_IDLE_EN, + .suspend_on_mask =3D BD72720_MASK_SUSPEND_EN, + .lpsr_on_mask =3D BD72720_MASK_DEEP_IDLE_EN, + }, + }, { + .desc =3D { + .name =3D "buck7", + .of_match =3D of_match_ptr("buck7"), + .regulators_node =3D of_match_ptr("regulators"), + .id =3D BD72720_BUCK7, + .type =3D REGULATOR_VOLTAGE, + .ops =3D &bd72720_regulator_ops, + .linear_ranges =3D bd72720_buck67_volts, + .n_linear_ranges =3D ARRAY_SIZE(bd72720_buck67_volts), + .n_voltages =3D BD72720_NUM_BUCK_VOLTS, + .enable_reg =3D BD72720_REG_BUCK7_ON, + .enable_mask =3D BD72720_MASK_RUN_B_EN, + .vsel_reg =3D BD72720_REG_BUCK7_VSEL, + .vsel_mask =3D BD72720_MASK_BUCK_VSEL, + + .ramp_delay_table =3D bd72720_ramp_delay, + .n_ramp_values =3D ARRAY_SIZE(bd72720_ramp_delay), + .ramp_reg =3D BD72720_REG_BUCK7_MODE, + .ramp_mask =3D BD72720_MASK_RAMP_UP_DELAY, + .owner =3D THIS_MODULE, + .of_parse_cb =3D buck_set_hw_dvs_levels, + }, + .dvs =3D { + .level_map =3D ROHM_DVS_LEVEL_RUN | ROHM_DVS_LEVEL_IDLE | + ROHM_DVS_LEVEL_SUSPEND | + ROHM_DVS_LEVEL_LPSR, + .run_reg =3D BD72720_REG_BUCK7_VSEL, + .run_mask =3D BD72720_MASK_BUCK_VSEL, + .idle_on_mask =3D BD72720_MASK_IDLE_EN, + .suspend_on_mask =3D BD72720_MASK_SUSPEND_EN, + .lpsr_on_mask =3D BD72720_MASK_DEEP_IDLE_EN, + }, + }, { + .desc =3D { + .name =3D "buck8", + .of_match =3D of_match_ptr("buck8"), + .regulators_node =3D of_match_ptr("regulators"), + .id =3D BD72720_BUCK8, + .type =3D REGULATOR_VOLTAGE, + .ops =3D &bd72720_regulator_ops, + .linear_ranges =3D bd72720_buck589_volts, + .n_linear_ranges =3D ARRAY_SIZE(bd72720_buck589_volts), + .n_voltages =3D BD72720_NUM_BUCK_VOLTS, + .enable_reg =3D BD72720_REG_BUCK8_ON, + .enable_mask =3D BD72720_MASK_RUN_B_EN, + .vsel_reg =3D BD72720_REG_BUCK8_VSEL, + .vsel_mask =3D BD72720_MASK_BUCK_VSEL, + + .ramp_delay_table =3D bd72720_ramp_delay, + .n_ramp_values =3D ARRAY_SIZE(bd72720_ramp_delay), + .ramp_reg =3D BD72720_REG_BUCK8_MODE, + .ramp_mask =3D BD72720_MASK_RAMP_UP_DELAY, + .owner =3D THIS_MODULE, + .of_parse_cb =3D buck_set_hw_dvs_levels, + }, + .dvs =3D { + .level_map =3D ROHM_DVS_LEVEL_RUN | ROHM_DVS_LEVEL_IDLE | + ROHM_DVS_LEVEL_SUSPEND | + ROHM_DVS_LEVEL_LPSR, + .run_reg =3D BD72720_REG_BUCK8_VSEL, + .run_mask =3D BD72720_MASK_BUCK_VSEL, + .idle_on_mask =3D BD72720_MASK_IDLE_EN, + .suspend_on_mask =3D BD72720_MASK_SUSPEND_EN, + .lpsr_on_mask =3D BD72720_MASK_DEEP_IDLE_EN, + }, + }, { + .desc =3D { + .name =3D "buck9", + .of_match =3D of_match_ptr("buck9"), + .regulators_node =3D of_match_ptr("regulators"), + .id =3D BD72720_BUCK9, + .type =3D REGULATOR_VOLTAGE, + .ops =3D &bd72720_regulator_ops, + .linear_ranges =3D bd72720_buck589_volts, + .n_linear_ranges =3D ARRAY_SIZE(bd72720_buck589_volts), + .n_voltages =3D BD72720_NUM_BUCK_VOLTS, + .enable_reg =3D BD72720_REG_BUCK9_ON, + .enable_mask =3D BD72720_MASK_RUN_B_EN, + .vsel_reg =3D BD72720_REG_BUCK9_VSEL, + .vsel_mask =3D BD72720_MASK_BUCK_VSEL, + + .ramp_delay_table =3D bd72720_ramp_delay, + .n_ramp_values =3D ARRAY_SIZE(bd72720_ramp_delay), + .ramp_reg =3D BD72720_REG_BUCK9_MODE, + .ramp_mask =3D BD72720_MASK_RAMP_UP_DELAY, + .owner =3D THIS_MODULE, + .of_parse_cb =3D buck_set_hw_dvs_levels, + }, + .dvs =3D { + .level_map =3D ROHM_DVS_LEVEL_RUN | ROHM_DVS_LEVEL_IDLE | + ROHM_DVS_LEVEL_SUSPEND | + ROHM_DVS_LEVEL_LPSR, + .run_reg =3D BD72720_REG_BUCK9_VSEL, + .run_mask =3D BD72720_MASK_BUCK_VSEL, + .idle_on_mask =3D BD72720_MASK_IDLE_EN, + .suspend_on_mask =3D BD72720_MASK_SUSPEND_EN, + .lpsr_on_mask =3D BD72720_MASK_DEEP_IDLE_EN, + }, + }, { + .desc =3D { + .name =3D "buck10", + .of_match =3D of_match_ptr("buck10"), + .regulators_node =3D of_match_ptr("regulators"), + .id =3D BD72720_BUCK10, + .type =3D REGULATOR_VOLTAGE, + .ops =3D &bd72720_regulator_ops, + .linear_ranges =3D bd72720_buck10_volts, + .n_linear_ranges =3D ARRAY_SIZE(bd72720_buck10_volts), + .n_voltages =3D BD72720_NUM_BUCK_VOLTS, + .enable_reg =3D BD72720_REG_BUCK10_ON, + .enable_mask =3D BD72720_MASK_RUN_B_EN, + .vsel_reg =3D BD72720_REG_BUCK10_VSEL, + .vsel_mask =3D BD72720_MASK_BUCK_VSEL, + + .ramp_delay_table =3D bd72720_ramp_delay, + .n_ramp_values =3D ARRAY_SIZE(bd72720_ramp_delay), + .ramp_reg =3D BD72720_REG_BUCK10_MODE, + .ramp_mask =3D BD72720_MASK_RAMP_UP_DELAY, + .owner =3D THIS_MODULE, + .of_parse_cb =3D buck_set_hw_dvs_levels, + }, + .dvs =3D { + .level_map =3D ROHM_DVS_LEVEL_RUN | ROHM_DVS_LEVEL_IDLE | + ROHM_DVS_LEVEL_SUSPEND | + ROHM_DVS_LEVEL_LPSR, + .run_reg =3D BD72720_REG_BUCK10_VSEL, + .run_mask =3D BD72720_MASK_BUCK_VSEL, + .idle_on_mask =3D BD72720_MASK_IDLE_EN, + .suspend_on_mask =3D BD72720_MASK_SUSPEND_EN, + .lpsr_on_mask =3D BD72720_MASK_DEEP_IDLE_EN, + }, + }, { + .desc =3D { + .name =3D "ldo1", + .of_match =3D of_match_ptr("ldo1"), + .regulators_node =3D of_match_ptr("regulators"), + .id =3D BD72720_LDO1, + .type =3D REGULATOR_VOLTAGE, + .ops =3D &bd72720_regulator_ops, + .linear_ranges =3D bd72720_ldo1234_volts, + .n_linear_ranges =3D ARRAY_SIZE(bd72720_ldo1234_volts), + .n_voltages =3D BD72720_NUM_LDO12346_VOLTS, + .enable_reg =3D BD72720_REG_LDO1_ON, + .enable_mask =3D BD72720_MASK_RUN_B_EN, + .vsel_reg =3D BD72720_REG_LDO1_VSEL_RB, + .vsel_mask =3D BD72720_MASK_LDO12346_VSEL, + + .ramp_delay_table =3D bd72720_ramp_delay, + .n_ramp_values =3D ARRAY_SIZE(bd72720_ramp_delay), + .ramp_reg =3D BD72720_REG_LDO1_MODE1, + .ramp_mask =3D BD72720_MASK_RAMP_UP_DELAY, + .owner =3D THIS_MODULE, + .of_parse_cb =3D buck_set_hw_dvs_levels, + }, + .dvs =3D { + .level_map =3D ROHM_DVS_LEVEL_RUN | ROHM_DVS_LEVEL_IDLE | + ROHM_DVS_LEVEL_SUSPEND | + ROHM_DVS_LEVEL_LPSR, + .run_reg =3D BD72720_REG_LDO1_VSEL_RB, + .run_mask =3D BD72720_MASK_LDO12346_VSEL, + .idle_reg =3D BD72720_REG_LDO1_VSEL_I, + .idle_mask =3D BD72720_MASK_LDO12346_VSEL, + .idle_on_mask =3D BD72720_MASK_IDLE_EN, + .suspend_reg =3D BD72720_REG_LDO1_VSEL_S, + .suspend_mask =3D BD72720_MASK_LDO12346_VSEL, + .suspend_on_mask =3D BD72720_MASK_SUSPEND_EN, + .lpsr_reg =3D BD72720_REG_LDO1_VSEL_DI, + .lpsr_mask =3D BD72720_MASK_LDO12346_VSEL, + .lpsr_on_mask =3D BD72720_MASK_DEEP_IDLE_EN, + }, + .reg_inits =3D bd72720_ldo1_inits, + .reg_init_amnt =3D ARRAY_SIZE(bd72720_ldo1_inits), + }, { + .desc =3D { + .name =3D "ldo2", + .of_match =3D of_match_ptr("ldo2"), + .regulators_node =3D of_match_ptr("regulators"), + .id =3D BD72720_LDO2, + .type =3D REGULATOR_VOLTAGE, + .ops =3D &bd72720_regulator_ops, + .linear_ranges =3D bd72720_ldo1234_volts, + .n_linear_ranges =3D ARRAY_SIZE(bd72720_ldo1234_volts), + .n_voltages =3D BD72720_NUM_LDO12346_VOLTS, + .enable_reg =3D BD72720_REG_LDO2_ON, + .enable_mask =3D BD72720_MASK_RUN_B_EN, + .vsel_reg =3D BD72720_REG_LDO2_VSEL_R, + .vsel_mask =3D BD72720_MASK_LDO12346_VSEL, + + .ramp_delay_table =3D bd72720_ramp_delay, + .n_ramp_values =3D ARRAY_SIZE(bd72720_ramp_delay), + .ramp_reg =3D BD72720_REG_LDO2_MODE, + .ramp_mask =3D BD72720_MASK_RAMP_UP_DELAY, + .owner =3D THIS_MODULE, + .of_parse_cb =3D buck_set_hw_dvs_levels, + }, + .dvs =3D { + .level_map =3D ROHM_DVS_LEVEL_RUN | ROHM_DVS_LEVEL_IDLE | + ROHM_DVS_LEVEL_SUSPEND | + ROHM_DVS_LEVEL_LPSR, + .run_reg =3D BD72720_REG_LDO2_VSEL_R, + .run_mask =3D BD72720_MASK_LDO12346_VSEL, + .idle_reg =3D BD72720_REG_LDO2_VSEL_I, + .idle_mask =3D BD72720_MASK_LDO12346_VSEL, + .idle_on_mask =3D BD72720_MASK_IDLE_EN, + .suspend_reg =3D BD72720_REG_LDO2_VSEL_S, + .suspend_mask =3D BD72720_MASK_LDO12346_VSEL, + .suspend_on_mask =3D BD72720_MASK_SUSPEND_EN, + .lpsr_reg =3D BD72720_REG_LDO2_VSEL_DI, + .lpsr_mask =3D BD72720_MASK_LDO12346_VSEL, + .lpsr_on_mask =3D BD72720_MASK_DEEP_IDLE_EN, + }, + }, { + .desc =3D { + .name =3D "ldo3", + .of_match =3D of_match_ptr("ldo3"), + .regulators_node =3D of_match_ptr("regulators"), + .id =3D BD72720_LDO3, + .type =3D REGULATOR_VOLTAGE, + .ops =3D &bd72720_regulator_ops, + .linear_ranges =3D bd72720_ldo1234_volts, + .n_linear_ranges =3D ARRAY_SIZE(bd72720_ldo1234_volts), + .n_voltages =3D BD72720_NUM_LDO12346_VOLTS, + .enable_reg =3D BD72720_REG_LDO3_ON, + .enable_mask =3D BD72720_MASK_RUN_B_EN, + .vsel_reg =3D BD72720_REG_LDO3_VSEL_R, + .vsel_mask =3D BD72720_MASK_LDO12346_VSEL, + + .ramp_delay_table =3D bd72720_ramp_delay, + .n_ramp_values =3D ARRAY_SIZE(bd72720_ramp_delay), + .ramp_reg =3D BD72720_REG_LDO3_MODE, + .ramp_mask =3D BD72720_MASK_RAMP_UP_DELAY, + .owner =3D THIS_MODULE, + .of_parse_cb =3D buck_set_hw_dvs_levels, + }, + .dvs =3D { + .level_map =3D ROHM_DVS_LEVEL_RUN | ROHM_DVS_LEVEL_IDLE | + ROHM_DVS_LEVEL_SUSPEND | + ROHM_DVS_LEVEL_LPSR, + .run_reg =3D BD72720_REG_LDO3_VSEL_R, + .run_mask =3D BD72720_MASK_LDO12346_VSEL, + .idle_reg =3D BD72720_REG_LDO3_VSEL_I, + .idle_mask =3D BD72720_MASK_LDO12346_VSEL, + .idle_on_mask =3D BD72720_MASK_IDLE_EN, + .suspend_reg =3D BD72720_REG_LDO3_VSEL_S, + .suspend_mask =3D BD72720_MASK_LDO12346_VSEL, + .suspend_on_mask =3D BD72720_MASK_SUSPEND_EN, + .lpsr_reg =3D BD72720_REG_LDO3_VSEL_DI, + .lpsr_mask =3D BD72720_MASK_LDO12346_VSEL, + .lpsr_on_mask =3D BD72720_MASK_DEEP_IDLE_EN, + }, + }, { + .desc =3D { + .name =3D "ldo4", + .of_match =3D of_match_ptr("ldo4"), + .regulators_node =3D of_match_ptr("regulators"), + .id =3D BD72720_LDO4, + .type =3D REGULATOR_VOLTAGE, + .ops =3D &bd72720_regulator_ops, + .linear_ranges =3D bd72720_ldo1234_volts, + .n_linear_ranges =3D ARRAY_SIZE(bd72720_ldo1234_volts), + .n_voltages =3D BD72720_NUM_LDO12346_VOLTS, + .enable_reg =3D BD72720_REG_LDO4_ON, + .enable_mask =3D BD72720_MASK_RUN_B_EN, + .vsel_reg =3D BD72720_REG_LDO4_VSEL_R, + .vsel_mask =3D BD72720_MASK_LDO12346_VSEL, + + .ramp_delay_table =3D bd72720_ramp_delay, + .n_ramp_values =3D ARRAY_SIZE(bd72720_ramp_delay), + .ramp_reg =3D BD72720_REG_LDO4_MODE, + .ramp_mask =3D BD72720_MASK_RAMP_UP_DELAY, + .owner =3D THIS_MODULE, + .of_parse_cb =3D buck_set_hw_dvs_levels, + }, + .dvs =3D { + .level_map =3D ROHM_DVS_LEVEL_RUN | ROHM_DVS_LEVEL_IDLE | + ROHM_DVS_LEVEL_SUSPEND | + ROHM_DVS_LEVEL_LPSR, + .run_reg =3D BD72720_REG_LDO4_VSEL_R, + .run_mask =3D BD72720_MASK_LDO12346_VSEL, + .idle_reg =3D BD72720_REG_LDO4_VSEL_I, + .idle_mask =3D BD72720_MASK_LDO12346_VSEL, + .idle_on_mask =3D BD72720_MASK_IDLE_EN, + .suspend_reg =3D BD72720_REG_LDO4_VSEL_S, + .suspend_mask =3D BD72720_MASK_LDO12346_VSEL, + .suspend_on_mask =3D BD72720_MASK_SUSPEND_EN, + .lpsr_reg =3D BD72720_REG_LDO4_VSEL_DI, + .lpsr_mask =3D BD72720_MASK_LDO12346_VSEL, + .lpsr_on_mask =3D BD72720_MASK_DEEP_IDLE_EN, + }, + }, { + .desc =3D { + .name =3D "ldo5", + .of_match =3D of_match_ptr("ldo5"), + .regulators_node =3D of_match_ptr("regulators"), + .id =3D BD72720_LDO5, + .type =3D REGULATOR_VOLTAGE, + .ops =3D &bd72720_regulator_ops, + .linear_ranges =3D bd72720_ldo57891011_volts, + .n_linear_ranges =3D ARRAY_SIZE(bd72720_ldo57891011_volts), + .n_voltages =3D BD72720_NUM_LDO_VOLTS, + .enable_reg =3D BD72720_REG_LDO5_ON, + .enable_mask =3D BD72720_MASK_RUN_B_EN, + .vsel_reg =3D BD72720_REG_LDO5_VSEL, + .vsel_mask =3D BD72720_MASK_LDO_VSEL, + + .ramp_delay_table =3D bd72720_ramp_delay, + .n_ramp_values =3D ARRAY_SIZE(bd72720_ramp_delay), + .ramp_reg =3D BD72720_REG_LDO5_MODE, + .ramp_mask =3D BD72720_MASK_RAMP_UP_DELAY, + .owner =3D THIS_MODULE, + .of_parse_cb =3D buck_set_hw_dvs_levels, + }, + .dvs =3D { + .level_map =3D ROHM_DVS_LEVEL_RUN | ROHM_DVS_LEVEL_IDLE | + ROHM_DVS_LEVEL_SUSPEND | + ROHM_DVS_LEVEL_LPSR, + .run_reg =3D BD72720_REG_LDO5_VSEL, + .run_mask =3D BD72720_MASK_LDO_VSEL, + .idle_on_mask =3D BD72720_MASK_IDLE_EN, + .suspend_on_mask =3D BD72720_MASK_SUSPEND_EN, + .lpsr_on_mask =3D BD72720_MASK_DEEP_IDLE_EN, + }, + }, { + .desc =3D { + .name =3D "ldo6", + .of_match =3D of_match_ptr("ldo6"), + .regulators_node =3D of_match_ptr("regulators"), + .id =3D BD72720_LDO6, + .type =3D REGULATOR_VOLTAGE, + .ops =3D &bd72720_regulator_ops, + .linear_ranges =3D bd72720_ldo6_volts, + .n_linear_ranges =3D ARRAY_SIZE(bd72720_ldo6_volts), + .n_voltages =3D BD72720_NUM_LDO12346_VOLTS, + .enable_reg =3D BD72720_REG_LDO6_ON, + .enable_mask =3D BD72720_MASK_RUN_B_EN, + .vsel_reg =3D BD72720_REG_LDO6_VSEL, + .vsel_mask =3D BD72720_MASK_LDO12346_VSEL, + + .ramp_delay_table =3D bd72720_ramp_delay, + .n_ramp_values =3D ARRAY_SIZE(bd72720_ramp_delay), + .ramp_reg =3D BD72720_REG_LDO6_MODE, + .ramp_mask =3D BD72720_MASK_RAMP_UP_DELAY, + .owner =3D THIS_MODULE, + .of_parse_cb =3D buck_set_hw_dvs_levels, + }, + .dvs =3D { + .level_map =3D ROHM_DVS_LEVEL_RUN | ROHM_DVS_LEVEL_IDLE | + ROHM_DVS_LEVEL_SUSPEND | + ROHM_DVS_LEVEL_LPSR, + .run_reg =3D BD72720_REG_LDO6_VSEL, + .run_mask =3D BD72720_MASK_LDO12346_VSEL, + .idle_on_mask =3D BD72720_MASK_IDLE_EN, + .suspend_on_mask =3D BD72720_MASK_SUSPEND_EN, + .lpsr_on_mask =3D BD72720_MASK_DEEP_IDLE_EN, + }, + }, { + .desc =3D { + .name =3D "ldo7", + .of_match =3D of_match_ptr("ldo7"), + .regulators_node =3D of_match_ptr("regulators"), + .id =3D BD72720_LDO7, + .type =3D REGULATOR_VOLTAGE, + .ops =3D &bd72720_regulator_ops, + .linear_ranges =3D bd72720_ldo57891011_volts, + .n_linear_ranges =3D ARRAY_SIZE(bd72720_ldo57891011_volts), + .n_voltages =3D BD72720_NUM_LDO_VOLTS, + .enable_reg =3D BD72720_REG_LDO7_ON, + .enable_mask =3D BD72720_MASK_RUN_B_EN, + .vsel_reg =3D BD72720_REG_LDO7_VSEL, + .vsel_mask =3D BD72720_MASK_LDO_VSEL, + + .ramp_delay_table =3D bd72720_ramp_delay, + .n_ramp_values =3D ARRAY_SIZE(bd72720_ramp_delay), + .ramp_reg =3D BD72720_REG_LDO7_MODE, + .ramp_mask =3D BD72720_MASK_RAMP_UP_DELAY, + .owner =3D THIS_MODULE, + .of_parse_cb =3D buck_set_hw_dvs_levels, + }, + .dvs =3D { + .level_map =3D ROHM_DVS_LEVEL_RUN | ROHM_DVS_LEVEL_IDLE | + ROHM_DVS_LEVEL_SUSPEND | + ROHM_DVS_LEVEL_LPSR, + .run_reg =3D BD72720_REG_LDO7_VSEL, + .run_mask =3D BD72720_MASK_LDO_VSEL, + .idle_on_mask =3D BD72720_MASK_IDLE_EN, + .suspend_on_mask =3D BD72720_MASK_SUSPEND_EN, + .lpsr_on_mask =3D BD72720_MASK_DEEP_IDLE_EN, + }, + }, { + .desc =3D { + .name =3D "ldo8", + .of_match =3D of_match_ptr("ldo8"), + .regulators_node =3D of_match_ptr("regulators"), + .id =3D BD72720_LDO8, + .type =3D REGULATOR_VOLTAGE, + .ops =3D &bd72720_regulator_ops, + .linear_ranges =3D bd72720_ldo57891011_volts, + .n_linear_ranges =3D ARRAY_SIZE(bd72720_ldo57891011_volts), + .n_voltages =3D BD72720_NUM_LDO_VOLTS, + .enable_reg =3D BD72720_REG_LDO8_ON, + .enable_mask =3D BD72720_MASK_RUN_B_EN, + .vsel_reg =3D BD72720_REG_LDO8_VSEL, + .vsel_mask =3D BD72720_MASK_LDO_VSEL, + + .ramp_delay_table =3D bd72720_ramp_delay, + .n_ramp_values =3D ARRAY_SIZE(bd72720_ramp_delay), + .ramp_reg =3D BD72720_REG_LDO8_MODE, + .ramp_mask =3D BD72720_MASK_RAMP_UP_DELAY, + .owner =3D THIS_MODULE, + .of_parse_cb =3D buck_set_hw_dvs_levels, + }, + .dvs =3D { + .level_map =3D ROHM_DVS_LEVEL_RUN | ROHM_DVS_LEVEL_IDLE | + ROHM_DVS_LEVEL_SUSPEND | + ROHM_DVS_LEVEL_LPSR, + .run_reg =3D BD72720_REG_LDO8_VSEL, + .run_mask =3D BD72720_MASK_LDO_VSEL, + .idle_on_mask =3D BD72720_MASK_IDLE_EN, + .suspend_on_mask =3D BD72720_MASK_SUSPEND_EN, + .lpsr_on_mask =3D BD72720_MASK_DEEP_IDLE_EN, + }, + }, { + .desc =3D { + .name =3D "ldo9", + .of_match =3D of_match_ptr("ldo9"), + .regulators_node =3D of_match_ptr("regulators"), + .id =3D BD72720_LDO9, + .type =3D REGULATOR_VOLTAGE, + .ops =3D &bd72720_regulator_ops, + .linear_ranges =3D bd72720_ldo57891011_volts, + .n_linear_ranges =3D ARRAY_SIZE(bd72720_ldo57891011_volts), + .n_voltages =3D BD72720_NUM_LDO_VOLTS, + .enable_reg =3D BD72720_REG_LDO9_ON, + .enable_mask =3D BD72720_MASK_RUN_B_EN, + .vsel_reg =3D BD72720_REG_LDO9_VSEL, + .vsel_mask =3D BD72720_MASK_LDO_VSEL, + + .ramp_delay_table =3D bd72720_ramp_delay, + .n_ramp_values =3D ARRAY_SIZE(bd72720_ramp_delay), + .ramp_reg =3D BD72720_REG_LDO9_MODE, + .ramp_mask =3D BD72720_MASK_RAMP_UP_DELAY, + .owner =3D THIS_MODULE, + .of_parse_cb =3D buck_set_hw_dvs_levels, + }, + .dvs =3D { + .level_map =3D ROHM_DVS_LEVEL_RUN | ROHM_DVS_LEVEL_IDLE | + ROHM_DVS_LEVEL_SUSPEND | + ROHM_DVS_LEVEL_LPSR, + .run_reg =3D BD72720_REG_LDO9_VSEL, + .run_mask =3D BD72720_MASK_LDO_VSEL, + .idle_on_mask =3D BD72720_MASK_IDLE_EN, + .suspend_on_mask =3D BD72720_MASK_SUSPEND_EN, + .lpsr_on_mask =3D BD72720_MASK_DEEP_IDLE_EN, + }, + }, { + .desc =3D { + .name =3D "ldo10", + .of_match =3D of_match_ptr("ldo10"), + .regulators_node =3D of_match_ptr("regulators"), + .id =3D BD72720_LDO10, + .type =3D REGULATOR_VOLTAGE, + .ops =3D &bd72720_regulator_ops, + .linear_ranges =3D bd72720_ldo57891011_volts, + .n_linear_ranges =3D ARRAY_SIZE(bd72720_ldo57891011_volts), + .n_voltages =3D BD72720_NUM_LDO_VOLTS, + .enable_reg =3D BD72720_REG_LDO10_ON, + .enable_mask =3D BD72720_MASK_RUN_B_EN, + .vsel_reg =3D BD72720_REG_LDO10_VSEL, + .vsel_mask =3D BD72720_MASK_LDO_VSEL, + + .ramp_delay_table =3D bd72720_ramp_delay, + .n_ramp_values =3D ARRAY_SIZE(bd72720_ramp_delay), + .ramp_reg =3D BD72720_REG_LDO10_MODE, + .ramp_mask =3D BD72720_MASK_RAMP_UP_DELAY, + .owner =3D THIS_MODULE, + .of_parse_cb =3D buck_set_hw_dvs_levels, + }, + .dvs =3D { + .level_map =3D ROHM_DVS_LEVEL_RUN | ROHM_DVS_LEVEL_IDLE | + ROHM_DVS_LEVEL_SUSPEND | + ROHM_DVS_LEVEL_LPSR, + .run_reg =3D BD72720_REG_LDO10_VSEL, + .run_mask =3D BD72720_MASK_LDO_VSEL, + .idle_on_mask =3D BD72720_MASK_IDLE_EN, + .suspend_on_mask =3D BD72720_MASK_SUSPEND_EN, + .lpsr_on_mask =3D BD72720_MASK_DEEP_IDLE_EN, + }, + }, { + .desc =3D { + .name =3D "ldo11", + .of_match =3D of_match_ptr("ldo11"), + .regulators_node =3D of_match_ptr("regulators"), + .id =3D BD72720_LDO11, + .type =3D REGULATOR_VOLTAGE, + .ops =3D &bd72720_regulator_ops, + .linear_ranges =3D bd72720_ldo57891011_volts, + .n_linear_ranges =3D ARRAY_SIZE(bd72720_ldo57891011_volts), + .n_voltages =3D BD72720_NUM_LDO_VOLTS, + .enable_reg =3D BD72720_REG_LDO11_ON, + .enable_mask =3D BD72720_MASK_RUN_B_EN, + .vsel_reg =3D BD72720_REG_LDO11_VSEL, + .vsel_mask =3D BD72720_MASK_LDO_VSEL, + + .ramp_delay_table =3D bd72720_ramp_delay, + .n_ramp_values =3D ARRAY_SIZE(bd72720_ramp_delay), + .ramp_reg =3D BD72720_REG_LDO11_MODE, + .ramp_mask =3D BD72720_MASK_RAMP_UP_DELAY, + .owner =3D THIS_MODULE, + .of_parse_cb =3D buck_set_hw_dvs_levels, + }, + .dvs =3D { + .level_map =3D ROHM_DVS_LEVEL_RUN | ROHM_DVS_LEVEL_IDLE | + ROHM_DVS_LEVEL_SUSPEND | + ROHM_DVS_LEVEL_LPSR, + .run_reg =3D BD72720_REG_LDO11_VSEL, + .run_mask =3D BD72720_MASK_LDO_VSEL, + .idle_on_mask =3D BD72720_MASK_IDLE_EN, + .suspend_on_mask =3D BD72720_MASK_SUSPEND_EN, + .lpsr_on_mask =3D BD72720_MASK_DEEP_IDLE_EN, + }, + }, +}; + +static int bd72720_buck10_ldon_head_mode(struct device *dev, + struct device_node *npreg, + struct regmap *regmap, + struct regulator_desc *buck10_desc) +{ + struct device_node *np __free(device_node) =3D + of_get_child_by_name(npreg, "buck10"); + uint32_t ldon_head; + int ldon_val; + int ret; + + if (!np) { + dev_err(dev, "failed to find buck10 regulator node\n"); + return -ENODEV; + } + + ret =3D of_property_read_u32(np, "rohm,ldon-head-millivolt", &ldon_head); + if (ret =3D=3D -EINVAL) + return 0; + if (ret) + return ret; + + /* + * LDON_HEAD mode means the BUCK10 is used to supply LDOs 1-4 and + * the BUCK 10 voltage is automatically set to follow LDO 1-4 + * settings. Thus the BUCK10 should not allow voltage [g/s]etting. + */ + buck10_desc->ops =3D &bd72720_buck10_ldon_head_op; + + ldon_val =3D ldon_head / 50 + 1; + if (ldon_head > 300) { + dev_warn(dev, "Unsupported LDON_HEAD, clamping to 300 mV\n"); + ldon_val =3D 7; + } + + return regmap_update_bits(regmap, BD72720_REG_LDO1_MODE2, + BD72720_MASK_LDON_HEAD, ldon_val); +} + +static int bd72720_dt_parse(struct device *dev, + struct regulator_desc *buck10_desc, + struct regmap *regmap) +{ + struct device_node *nproot __free(device_node) =3D + of_get_child_by_name(dev->parent->of_node, "regulators"); + + if (!nproot) { + dev_err(dev, "failed to find regulators node\n"); + return -ENODEV; + } + + return bd72720_buck10_ldon_head_mode(dev, nproot, regmap, buck10_desc); +} + static int bd71828_probe(struct platform_device *pdev) { - int i, j, ret; + int i, j, ret, num_regulators; struct regulator_config config =3D { .dev =3D pdev->dev.parent, }; + enum rohm_chip_type chip =3D platform_get_device_id(pdev)->driver_data; + struct bd71828_regulator_data *rdata; =20 config.regmap =3D dev_get_regmap(pdev->dev.parent, NULL); if (!config.regmap) return -ENODEV; =20 - for (i =3D 0; i < ARRAY_SIZE(bd71828_rdata); i++) { + switch (chip) { + case ROHM_CHIP_TYPE_BD72720: + rdata =3D devm_kmemdup(&pdev->dev, bd72720_rdata, + sizeof(bd72720_rdata), GFP_KERNEL); + if (!rdata) + return -ENOMEM; + + ret =3D bd72720_dt_parse(&pdev->dev, &rdata[BD72720_BUCK10_DESC_INDEX].d= esc, + config.regmap); + if (ret) + return ret; + + num_regulators =3D ARRAY_SIZE(bd72720_rdata); + break; + + case ROHM_CHIP_TYPE_BD71828: + rdata =3D devm_kmemdup(&pdev->dev, bd71828_rdata, + sizeof(bd71828_rdata), GFP_KERNEL); + if (!rdata) + return -ENOMEM; + + num_regulators =3D ARRAY_SIZE(bd71828_rdata); + + break; + default: + return dev_err_probe(&pdev->dev, -EINVAL, + "Unsupported device\n"); + } + + for (i =3D 0; i < num_regulators; i++) { struct regulator_dev *rdev; - const struct bd71828_regulator_data *rd; + struct bd71828_regulator_data *rd; + + rd =3D &rdata[i]; =20 - rd =3D &bd71828_rdata[i]; + config.driver_data =3D rd; rdev =3D devm_regulator_register(&pdev->dev, &rd->desc, &config); if (IS_ERR(rdev)) @@ -714,12 +1690,20 @@ static int bd71828_probe(struct platform_device *pde= v) return 0; } =20 +static const struct platform_device_id bd71828_pmic_id[] =3D { + { "bd71828-pmic", ROHM_CHIP_TYPE_BD71828 }, + { "bd72720-pmic", ROHM_CHIP_TYPE_BD72720 }, + { }, +}; +MODULE_DEVICE_TABLE(platform, bd71828_pmic_id); + static struct platform_driver bd71828_regulator =3D { .driver =3D { .name =3D "bd71828-pmic", .probe_type =3D PROBE_PREFER_ASYNCHRONOUS, }, .probe =3D bd71828_probe, + .id_table =3D bd71828_pmic_id, }; =20 module_platform_driver(bd71828_regulator); @@ -727,4 +1711,3 @@ module_platform_driver(bd71828_regulator); MODULE_AUTHOR("Matti Vaittinen "); MODULE_DESCRIPTION("BD71828 voltage regulator driver"); MODULE_LICENSE("GPL"); -MODULE_ALIAS("platform:bd71828-pmic"); --=20 2.51.0 --svkOyahV7o+mGO8I Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEIx+f8wZb28fLKEhTeFA3/03aocUFAmj/W74ACgkQeFA3/03a ocWJaQgAurgqKbwwpdhqpXm4pXWkNomyK/lYbcL5neQCS3jTa7t9VQFSafrJFb/o wPbPbY+QQXi0227e/PFriTwohdjWNIODfyy+guuXqJfoA6NW3Y58ZhuBbp5hxF9+ TLw5zmh2/3z7Mks9insOkbZaNd4mnswqsuWJSzeO4aunOXY9ArTXbrnbgb1qiJNC 45iNZjPGIJIJvRT21eJfE1+YmlarWvHOV7dgXQBRgKBMF+HMC1o7eMWc8QUgNlIw BSzzKU6sxlU1etr/uvcJTZca0m6CaAjXlZ3WWaGDW2ImAIWQngo+nRBjWb4rG9tA ZKp/wWea7QUBf2CK2e9WSbNvcw1PMQ== =ZeZV -----END PGP SIGNATURE----- --svkOyahV7o+mGO8I-- From nobody Sat Feb 7 17:55:30 2026 Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 393C82FE07B for ; Mon, 27 Oct 2025 11:47:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761565655; cv=none; b=lLuace3LrR9QPCWNwez84+WAvEnxKO+WvYpxcK9BimOoSDq68nQABe7mIJPABT8BJyTwZA9Sk8XHQACKA61WenXiJUAxqobPMNaks2zsdvFVvrOItqBUpx920Vuw2dzc32zvcSvKR8KTwNwD21pmOIiAN6stAj08PO+W0a73JPo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761565655; c=relaxed/simple; bh=K++ll1VTkwruhtw6iyV0wIyUmmctkkdXBo+Q4QF+560=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pa9pSwpjF/kQP96Wa8JgWiMfYorbCfJrRMFlHfedbeqUO8RCVs1F3DSVMvuzdnyoLY0agaTG/5g/PmC29QJWppRgEg87TVXkuhnHKNGbTPanaSALNIEuXTq2u8xGlKBPIFsPSz1OsalUA3MeYNwVhZa+mVe6A6+/YMB12wn/GTQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=I2Wcb7Uj; arc=none smtp.client-ip=209.85.167.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="I2Wcb7Uj" Received: by mail-lf1-f43.google.com with SMTP id 2adb3069b0e04-592f098f656so4733480e87.1 for ; Mon, 27 Oct 2025 04:47:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761565651; x=1762170451; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=CGZar//OHB0kzx5ytf2aEh0Z+ClSARP8AL09TkALmmY=; b=I2Wcb7Uj7i65om1NvtpTrPgZeWF/TT0LwjVCLtsxm7OTZFjMHSdqEZ0Qje+S5poZn+ AGe8oS1j5OIeZsHViAe8peUh/e6hpTt9UqC7nXWDTAkLIimIgaRXo1MqxUcUhMFCiUJH /DR4qAdRaTyADM/FKGSz/fPBN9jPLpFAplKkIk98Ajj5KXEMH+ml2zuddUdGiCxWkpB1 tRRY76tA3ef5i2T/X8oiryavJ4nQxkqhKiLn11oaMV/ZLdVyHdTxX/UucmOD1m55kDzF dC0hdyjn21iIsvb7Xie+HiGVZtOIea9sISqIBC+TwCJweTZNk8XeDmpKlDrIQo4x5HQk 6ojg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761565651; x=1762170451; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=CGZar//OHB0kzx5ytf2aEh0Z+ClSARP8AL09TkALmmY=; b=TZpnjCpBOCyIvLqXhBUbAt/rWyT7NxV8C3crN1fuYYJqJy/OW98/pkI9PoaWR3nS3C wKc8rcNBF7tYWR1u3HUk1xR3++pGw6A+pZYkv+ZDrmrCAr3DbnefQwPM2c9OmCGBkIxS lVBPP0tjPMcpGDxVUKBY+bsKjdereQz+REIqv6Pain4c3ccfvJxI5QGvEnYJvapql+Td 09iwLTAWlOH86tWBTJhJQxtZUDJ92JdJOkkenDBbqo3j58dqs6qO2VNtsiZUCGCgOvMn ayiWLZ7BPIvCsvd9xpG2gt/tVylwZ3kpzUxwwfO9n52AmYnppGtlSEs+6CuGjE5I2rMx cSeQ== X-Forwarded-Encrypted: i=1; AJvYcCWyrUtZXgB6z19kNpwVDQM5H5EEgHqZ6loW9AFhyOd7wmGbPDSTIG3ThyzzoQCSJILUR+obG2CGrCjxD0c=@vger.kernel.org X-Gm-Message-State: AOJu0Yz3IKkIDoZ/a0ZcLBXumnKwdlxjjs8LvApPkOPMy3SYGsdRnxnn 1RXirzgMdoGGFSdb6thW7LkVBxYNEYkY4O7o4NTyJzdV+LCc1wsOyJDl X-Gm-Gg: ASbGncv7nywodcFFMzoeGH7wjOsqZBMsMvtPyD0EhUcs/hRmsBWXBYq3ovuixLy84F+ 8rLMRW5KiKXfXczFTXmnOaVlxZ4bB9II82lGbWL0R55UAM3Msdp5Mx9YlSS7gDBowjY0Eiw0IuI Iycxi6UDXvo2EzafPGPOfztUbxIOczbwIk0Gz4Ewhd4A0KmJARucZnj16/OA+shpHysVk63eBpo AN3Q1TLYJ2Co6infm1zO5JZpH3qUbMminszPpiXSjR8Si2AVU0vO+XMmy/LZT2mKb7FA67tu3De PGN3grXtMYnaQQ9Fednjd0yqluTvT+R3BOHdaZqXv0Hzm1zea1QJqIPVUpgq8W2wQg8eDjzVKAm RcilCZ6sUNbrbHc7whbtgWk0R4OaKoPPkaZ+YEeNZFy5CObY41u6AXEddUq8F527N7O0laaia6Z phs231l3M= X-Google-Smtp-Source: AGHT+IESW+vCWcbsBvRwjY6wYKTNoMW4c6KJC1do8XcYzr9fNstVvSOI+Lz5dXiwbcSJoCgwR7QRrg== X-Received: by 2002:a05:6512:31d0:b0:58b:23e:249 with SMTP id 2adb3069b0e04-591d8506a26mr11834655e87.18.1761565651150; Mon, 27 Oct 2025 04:47:31 -0700 (PDT) Received: from mva-rohm ([2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-59301f60cafsm2249289e87.63.2025.10.27.04.47.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Oct 2025 04:47:30 -0700 (PDT) Date: Mon, 27 Oct 2025 13:47:25 +0200 From: Matti Vaittinen To: Matti Vaittinen , Matti Vaittinen Cc: Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Sebastian Reichel , Liam Girdwood , Mark Brown , Michael Turquette , Stephen Boyd , Matti Vaittinen , Linus Walleij , Bartosz Golaszewski , Andreas Kemnade , Alexandre Belloni , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-rtc@vger.kernel.org Subject: [PATCH v2 10/15] gpio: Support ROHM BD72720 gpios Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="pP44LjMFfDxyfF3H" Content-Disposition: inline In-Reply-To: --pP44LjMFfDxyfF3H Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" The ROHM BD72720 has 6 pins which may be configured as GPIOs. The GPIO1 ... GPIO5 and EPDEN pins. The configuration is done to OTP at the manufacturing, and it can't be read at runtime. The device-tree is required to tell the software which of the pins are used as GPIOs. Keep the pin mapping static regardless the OTP. This way the user-space can always access the BASE+N for GPIO(N+1) (N =3D 0 to 4), and BASE + 5 for the EPDEN pin. Do this by setting always the number of GPIOs to 6, and by using the valid-mask to invalidate the pins which aren't configured as GPIOs. First two pins can be set to be either input or output by OTP. Direction can't be changed by software. Rest of the pins can be set as outputs only. All of the pins support generating interrupts. Support the Input/Output state getting/setting and the output mode configuration (open-drain/push-pull). Signed-off-by: Matti Vaittinen Reviewed-by: Linus Walleij Acked-by: Bartosz Golaszewski --- Revision history: RFCv1 =3D> : - No changes --- drivers/gpio/Kconfig | 9 ++ drivers/gpio/Makefile | 1 + drivers/gpio/gpio-bd72720.c | 281 ++++++++++++++++++++++++++++++++++++ 3 files changed, 291 insertions(+) create mode 100644 drivers/gpio/gpio-bd72720.c diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig index 7ee3afbc2b05..0c612c5163c5 100644 --- a/drivers/gpio/Kconfig +++ b/drivers/gpio/Kconfig @@ -1319,6 +1319,15 @@ config GPIO_BD71828 This driver can also be built as a module. If so, the module will be called gpio-bd71828. =20 +config GPIO_BD72720 + tristate "ROHM BD72720 and BD73900 PMIC GPIO support" + depends on MFD_ROHM_BD71828 + help + Support for GPIO on ROHM BD72720 and BD73900 PMICs. There are two + pins which can be configured to GPI or GPO, and three pins which can + be configured to GPO on the ROHM PMIC. The pin configuration is done + on OTP at manufacturing. + config GPIO_BD9571MWV tristate "ROHM BD9571 GPIO support" depends on MFD_BD9571MWV diff --git a/drivers/gpio/Makefile b/drivers/gpio/Makefile index ec296fa14bfd..7a5d03db3021 100644 --- a/drivers/gpio/Makefile +++ b/drivers/gpio/Makefile @@ -45,6 +45,7 @@ obj-$(CONFIG_GPIO_BCM_KONA) +=3D gpio-bcm-kona.o obj-$(CONFIG_GPIO_BCM_XGS_IPROC) +=3D gpio-xgs-iproc.o obj-$(CONFIG_GPIO_BD71815) +=3D gpio-bd71815.o obj-$(CONFIG_GPIO_BD71828) +=3D gpio-bd71828.o +obj-$(CONFIG_GPIO_BD72720) +=3D gpio-bd72720.o obj-$(CONFIG_GPIO_BD9571MWV) +=3D gpio-bd9571mwv.o obj-$(CONFIG_GPIO_BLZP1600) +=3D gpio-blzp1600.o obj-$(CONFIG_GPIO_BRCMSTB) +=3D gpio-brcmstb.o diff --git a/drivers/gpio/gpio-bd72720.c b/drivers/gpio/gpio-bd72720.c new file mode 100644 index 000000000000..6549dbf4c7ad --- /dev/null +++ b/drivers/gpio/gpio-bd72720.c @@ -0,0 +1,281 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Support to GPIOs on ROHM BD72720 and BD79300 + * Copyright 2025 ROHM Semiconductors. + * Author: Matti Vaittinen + */ + +#include +#include +#include +#include +#include +#include +#include + +#define BD72720_GPIO_OPEN_DRAIN 0 +#define BD72720_GPIO_CMOS BIT(1) +#define BD72720_INT_GPIO1_IN_SRC 4 +/* + * The BD72720 has several "one time programmable" (OTP) configurations wh= ich + * can be set at manufacturing phase. A set of these options allow using p= ins + * as GPIO. The OTP configuration can't be read at run-time, so drivers re= ly on + * device-tree to advertise the correct options. + * + * Both DVS[0,1] pins can be configured to be used for: + * - OTP0: regulator RUN state control + * - OTP1: GPI + * - OTP2: GPO + * - OTP3: Power sequencer output + * Data-sheet also states that these PINs can always be used for IRQ but = the + * driver limits this by allowing them to be used for IRQs with OTP1 only. + * + * Pins GPIO_EXTEN0 (GPIO3), GPIO_EXTEN1 (GPIO4), GPIO_FAULT_B (GPIO5) hav= e OTP + * options for a specific (non GPIO) purposes, but also an option to confi= gure + * them to be used as a GPO. + * + * OTP settings can be separately configured for each pin. + * + * DT properties: + * "rohm,pin-dvs0" and "rohm,pin-dvs1" can be set to one of the values: + * "dvs-input", "gpi", "gpo". + * + * "rohm,pin-exten0", "rohm,pin-exten1" and "rohm,pin-fault_b" can be set = to: + * "gpo" + */ + +enum bd72720_gpio_state { + BD72720_PIN_UNKNOWN, + BD72720_PIN_GPI, + BD72720_PIN_GPO, +}; + +enum { + BD72720_GPIO1, + BD72720_GPIO2, + BD72720_GPIO3, + BD72720_GPIO4, + BD72720_GPIO5, + BD72720_GPIO_EPDEN, + BD72720_NUM_GPIOS +}; + +struct bd72720_gpio { + /* chip.parent points the MFD which provides DT node and regmap */ + struct gpio_chip chip; + /* dev points to the platform device for devm and prints */ + struct device *dev; + struct regmap *regmap; + int gpio_is_input; +}; + +static int bd72720gpi_get(struct bd72720_gpio *bdgpio, unsigned int reg_of= fset) +{ + int ret, val, shift; + + ret =3D regmap_read(bdgpio->regmap, BD72720_REG_INT_ETC1_SRC, &val); + if (ret) + return ret; + + shift =3D BD72720_INT_GPIO1_IN_SRC + reg_offset; + + return (val >> shift) & 1; +} + +static int bd72720gpo_get(struct bd72720_gpio *bdgpio, + unsigned int offset) +{ + const int regs[] =3D { BD72720_REG_GPIO1_CTRL, BD72720_REG_GPIO2_CTRL, + BD72720_REG_GPIO3_CTRL, BD72720_REG_GPIO4_CTRL, + BD72720_REG_GPIO5_CTRL, BD72720_REG_EPDEN_CTRL }; + int ret, val; + + ret =3D regmap_read(bdgpio->regmap, regs[offset], &val); + if (ret) + return ret; + + return val & BD72720_GPIO_HIGH; +} + +static int bd72720gpio_get(struct gpio_chip *chip, unsigned int offset) +{ + struct bd72720_gpio *bdgpio =3D gpiochip_get_data(chip); + + if (BIT(offset) & bdgpio->gpio_is_input) + return bd72720gpi_get(bdgpio, offset); + + return bd72720gpo_get(bdgpio, offset); +} + +static int bd72720gpo_set(struct gpio_chip *chip, unsigned int offset, + int value) +{ + struct bd72720_gpio *bdgpio =3D gpiochip_get_data(chip); + const int regs[] =3D { BD72720_REG_GPIO1_CTRL, BD72720_REG_GPIO2_CTRL, + BD72720_REG_GPIO3_CTRL, BD72720_REG_GPIO4_CTRL, + BD72720_REG_GPIO5_CTRL, BD72720_REG_EPDEN_CTRL }; + + if (BIT(offset) & bdgpio->gpio_is_input) { + dev_dbg(bdgpio->dev, "pin %d not output.\n", offset); + return -EINVAL; + } + + if (value) + return regmap_set_bits(bdgpio->regmap, regs[offset], + BD72720_GPIO_HIGH); + + return regmap_clear_bits(bdgpio->regmap, regs[offset], + BD72720_GPIO_HIGH); +} + +static int bd72720_gpio_set_config(struct gpio_chip *chip, unsigned int of= fset, + unsigned long config) +{ + struct bd72720_gpio *bdgpio =3D gpiochip_get_data(chip); + const int regs[] =3D { BD72720_REG_GPIO1_CTRL, BD72720_REG_GPIO2_CTRL, + BD72720_REG_GPIO3_CTRL, BD72720_REG_GPIO4_CTRL, + BD72720_REG_GPIO5_CTRL, BD72720_REG_EPDEN_CTRL }; + + /* + * We can only set the output mode, which makes sense only when output + * OTP configuration is used. + */ + if (BIT(offset) & bdgpio->gpio_is_input) + return -ENOTSUPP; + + switch (pinconf_to_config_param(config)) { + case PIN_CONFIG_DRIVE_OPEN_DRAIN: + return regmap_update_bits(bdgpio->regmap, + regs[offset], + BD72720_GPIO_DRIVE_MASK, + BD72720_GPIO_OPEN_DRAIN); + case PIN_CONFIG_DRIVE_PUSH_PULL: + return regmap_update_bits(bdgpio->regmap, + regs[offset], + BD72720_GPIO_DRIVE_MASK, + BD72720_GPIO_CMOS); + default: + break; + } + + return -ENOTSUPP; +} + +static int bd72720gpo_direction_get(struct gpio_chip *chip, + unsigned int offset) +{ + struct bd72720_gpio *bdgpio =3D gpiochip_get_data(chip); + + if (BIT(offset) & bdgpio->gpio_is_input) + return GPIO_LINE_DIRECTION_IN; + + return GPIO_LINE_DIRECTION_OUT; +} + +static int bd72720_valid_mask(struct gpio_chip *gc, + unsigned long *valid_mask, + unsigned int ngpios) +{ + static const char * const properties[] =3D { + "rohm,pin-dvs0", "rohm,pin-dvs1", "rohm,pin-exten0", + "rohm,pin-exten1", "rohm,pin-fault_b" + }; + struct bd72720_gpio *g =3D gpiochip_get_data(gc); + const char *val; + int i, ret; + + *valid_mask =3D BIT(BD72720_GPIO_EPDEN); + + if (!gc->parent) + return 0; + + for (i =3D 0; i < ARRAY_SIZE(properties); i++) { + ret =3D fwnode_property_read_string(dev_fwnode(gc->parent), + properties[i], &val); + + if (ret) { + if (ret =3D=3D -EINVAL) + continue; + + dev_err(g->dev, "pin %d (%s), bad configuration\n", i, + properties[i]); + + return ret; + } + + if (strcmp(val, "gpi") =3D=3D 0) { + if (i !=3D BD72720_GPIO1 && i !=3D BD72720_GPIO2) { + dev_warn(g->dev, + "pin %d (%s) does not support INPUT mode", + i, properties[i]); + continue; + } + + *valid_mask |=3D BIT(i); + g->gpio_is_input |=3D BIT(i); + } else if (strcmp(val, "gpo") =3D=3D 0) { + *valid_mask |=3D BIT(i); + } + } + + return 0; +} + +/* Template for GPIO chip */ +static const struct gpio_chip bd72720gpo_chip =3D { + .label =3D "bd72720", + .owner =3D THIS_MODULE, + .get =3D bd72720gpio_get, + .get_direction =3D bd72720gpo_direction_get, + .set =3D bd72720gpo_set, + .set_config =3D bd72720_gpio_set_config, + .init_valid_mask =3D bd72720_valid_mask, + .can_sleep =3D true, + .ngpio =3D BD72720_NUM_GPIOS, + .base =3D -1, +}; + +static int gpo_bd72720_probe(struct platform_device *pdev) +{ + struct bd72720_gpio *g; + struct device *parent, *dev; + + /* + * Bind devm lifetime to this platform device =3D> use dev for devm. + * also the prints should originate from this device. + */ + dev =3D &pdev->dev; + /* The device-tree and regmap come from MFD =3D> use parent for that */ + parent =3D dev->parent; + + g =3D devm_kzalloc(dev, sizeof(*g), GFP_KERNEL); + if (!g) + return -ENOMEM; + + g->chip =3D bd72720gpo_chip; + g->dev =3D dev; + g->chip.parent =3D parent; + g->regmap =3D dev_get_regmap(parent, NULL); + + return devm_gpiochip_add_data(dev, &g->chip, g); +} + +static const struct platform_device_id bd72720_gpio_id[] =3D { + { "bd72720-gpio" }, + { }, +}; +MODULE_DEVICE_TABLE(platform, bd72720_gpio_id); + +static struct platform_driver gpo_bd72720_driver =3D { + .driver =3D { + .name =3D "bd72720-gpio", + .probe_type =3D PROBE_PREFER_ASYNCHRONOUS, + }, + .probe =3D gpo_bd72720_probe, + .id_table =3D bd72720_gpio_id, +}; +module_platform_driver(gpo_bd72720_driver); + +MODULE_AUTHOR("Matti Vaittinen "); +MODULE_DESCRIPTION("GPIO interface for BD72720 and BD73900"); +MODULE_LICENSE("GPL"); --=20 2.51.0 --pP44LjMFfDxyfF3H Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEIx+f8wZb28fLKEhTeFA3/03aocUFAmj/W80ACgkQeFA3/03a ocUp3wf+PFsO2puwfMDS38sf+sWr8uUhdhFKcuuptYbO5oz45sOPu5LiP32iI5jW 1idVX7KNkmLT5CFnF9QnsBIcV//SnvGlrTnGLhCf4U1TaYY/kYXS5gV+kfxExgvJ CVixnigi1D4pk76eQMgRIlgNdNhHyydMkNqpGl44pyTyXvbn1JeM99rgux4EgGS3 lrPVVIKCwOC8FNmW+gxHlV0LhMOK30TUdbSBfi3aZ9SV9TC596mNM54veWF/vrSK iV3/Z5MgKRhV1NoTcRO9wO+/TM2PFP/o5VWzfrUkzliyAEFWJTZDKBfsc0rYQwA/ 4QWAoBb+ez8GpB4tHp6DYPcZ92I9Gw== =5BUy -----END PGP SIGNATURE----- --pP44LjMFfDxyfF3H-- From nobody Sat Feb 7 17:55:30 2026 Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 675623002B9 for ; Mon, 27 Oct 2025 11:47:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761565666; cv=none; b=juAs3lVG2ez6CFyeCdefktAd3l4hFs3yWMn7jUU6rI1+NRrLonKxVOLvkrLmx064mfEADLM0r2ciZ8qtWHj/Jc9ettZ/7L2HwGy6QYU4R9DAv+vuESsD9QG0LLU8f1qpJrRU5kayGb+qMiT0H/MZIsIgBSfnkOFWZfpt/WVlVDo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761565666; c=relaxed/simple; bh=p17Kucrh7jwU9Xcz2WTV3RzKYOXVG4AExxJcAYner1Y=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Dl+Y5Ky3kUmA07lAZKm05/UxM4yx10iurh3UbhQjOduDBw34QB7d+49sFGKZLIjcArE415SNBpInzYd2Xoq+FpXWRuDjy6CEnEfbqGmsgie/Z4DzNp2R4jUDn/IC5vwANrR/EQlaeuC1HpuD2UJoa/sbqbIpmmdTpWhWJRk3xBY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fu084Giv; arc=none smtp.client-ip=209.85.167.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fu084Giv" Received: by mail-lf1-f48.google.com with SMTP id 2adb3069b0e04-592f3d2d068so5994836e87.3 for ; Mon, 27 Oct 2025 04:47:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761565663; x=1762170463; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=XupAAXUKcZY4Ejq1lkE3J1vYR4j7xS27b1Ky2ExCNtQ=; b=fu084Giv9JZYfwslxWcShsu/ggSh1uh6g3u2ppw9DNg5JJbJBBdLE28d65kQ6aV2oa NEA3LdVeg1h7o7NtvJmf8uv2eUKulFZDBT1wnYmwHdoESJpgWtOKXJWWh7y6zfUIHal4 fzE6atRS3LCspctIRapDzU9I8s0Gznv8LGVmFli4dgq/SJhmZouC8YN4UbwyRMn08gPW /rFB5YlFbLBhPPr70Jo3LEN0NHXRJ5M4csnm1WlRgrhMZvoAl0B4fvkH/cIo+pQMyyhT hOkpPQ+zeyZVltutyGtS0zkHz3QyvHe3TESIDrEpwBUgJVbnVNKD5WNX5BZqLpcadjBn XD2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761565663; x=1762170463; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=XupAAXUKcZY4Ejq1lkE3J1vYR4j7xS27b1Ky2ExCNtQ=; b=Rp5wCOgZG7KLvSsIpA0j0MzlRcJuDS9W9HG5mkEtrCcYXsIW/wkjUL7peO4g94G5oC oiPQZBjWVFl2qfM+mpvi1UoN+UBDjauKcxU5g8RDNaXHrnm7BXPCcSjdXolas590BOjL Mu+QqzYb8KzsuyqVhQ93DHpIyutLY/PYrKWRGssE9x43H8k86G1F9V8C9wcE8UIeoPbl 3bxwU/KukxM0dkQVyUbFGIPCqzzfsP2bMfV7dJuJcrwoXL2z0AKOBU5fZc//F00zjA42 KlhqrS02tyCFqrm3Ki04w5s1o6cuus7GPg8xucId+68XvVtlEy60AwVSqA4YlfGWRT4M H1vA== X-Forwarded-Encrypted: i=1; AJvYcCWcffcDphETHp1uguIXfuqD7EmDrhbSL+0KTPnV0sbbZJ3X7FaYsv6ILHFiU5YbPBHOKeNd6EeCsfFx1ZY=@vger.kernel.org X-Gm-Message-State: AOJu0Yw9Lfh+M0UCGDLHxDLGIrbV6FsS56gTdY23Zp3Mx9fLuXFWsj1j HLeymM/OTOESdlf8ZvxluI/QFpvFN7PcGDxwrS9N3WuLTT1SItZLFiOs X-Gm-Gg: ASbGncsAlG1W59U8yb4F6rupr9eeaX3bMSFHxPkSK1AeiWBR+Ae9ZXGjd9j8oRVmcx/ n9Lrq7dBlmuyUIKb2DtLpnAA4fBU2ZekDYc1X7PvOMYavRxuWdP6p3cUIBi5W8XV7k0/liqSKIm QHMbviUgZ1AqGW5L3VJdF0cJkdVkZMuJzeMClBhVwItAjBHW8SqhqEo91zBHREGZetZlIv97aPc +11vIMNiz00EPpCyi56TfBst6XY40I5cGGOZyHW5cuMGIk/onNPie0EtkLC7D0eHC2M6ZnHh2Wq TtpAMQ7H24AzvaHfHgmJn9WNkzOfSNp9+vSwHsJzTgix31l87ByPAEY96XESfjfM4qRbaE9bi14 xlm0vDmEdzUjEyfE6ExYsx9vsF1JjOTsa1fFVE/+COW6xWBe+QRjPswrZrjdnlNdhdkjvsx2Cdz Ug6G9awJWMkZLsvnLB0IkYBXo1DK2k X-Google-Smtp-Source: AGHT+IF0uiGlpM6kk7ZEwBzbXbjrIni0QP5Pb+tj9gEs20ZTWYomYLWJR4y14n6ZYim0NyIT01Bxng== X-Received: by 2002:a05:6512:3c9e:b0:592:f48e:c725 with SMTP id 2adb3069b0e04-592f48ec7c2mr4210260e87.34.1761565662305; Mon, 27 Oct 2025 04:47:42 -0700 (PDT) Received: from mva-rohm ([2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-59301f41ce8sm2331591e87.6.2025.10.27.04.47.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Oct 2025 04:47:41 -0700 (PDT) Date: Mon, 27 Oct 2025 13:47:38 +0200 From: Matti Vaittinen To: Matti Vaittinen , Matti Vaittinen Cc: Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Sebastian Reichel , Liam Girdwood , Mark Brown , Michael Turquette , Stephen Boyd , Matti Vaittinen , Linus Walleij , Bartosz Golaszewski , Andreas Kemnade , Alexandre Belloni , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-rtc@vger.kernel.org Subject: [PATCH v2 11/15] clk: clk-bd718x7: Support BD72720 clk gate Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="3UxHLcOOARS3Jvq5" Content-Disposition: inline In-Reply-To: --3UxHLcOOARS3Jvq5 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" The BD72720 has similar simple clk gate as a few other ROHM PMICs. Add support for BD72720 clk gate. Signed-off-by: Matti Vaittinen --- Revision history: RFCv1 =3D>: - No changes --- drivers/clk/Kconfig | 4 ++-- drivers/clk/clk-bd718x7.c | 10 ++++++++-- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig index 3a1611008e48..619bd63a3c77 100644 --- a/drivers/clk/Kconfig +++ b/drivers/clk/Kconfig @@ -475,8 +475,8 @@ config COMMON_CLK_BD718XX tristate "Clock driver for 32K clk gates on ROHM PMICs" depends on MFD_ROHM_BD718XX || MFD_ROHM_BD71828 help - This driver supports ROHM BD71837, BD71847, BD71850, BD71815 - and BD71828 PMICs clock gates. + This driver supports ROHM BD71837, BD71847, BD71850, BD71815, + BD71828, and BD72720 PMICs clock gates. =20 config COMMON_CLK_FIXED_MMIO bool "Clock driver for Memory Mapped Fixed values" diff --git a/drivers/clk/clk-bd718x7.c b/drivers/clk/clk-bd718x7.c index ac40b669d60b..1cae974e6d1d 100644 --- a/drivers/clk/clk-bd718x7.c +++ b/drivers/clk/clk-bd718x7.c @@ -19,7 +19,8 @@ #define BD71828_REG_OUT32K 0x4B /* BD71837 and BD71847 */ #define BD718XX_REG_OUT32K 0x2E - +/* BD72720 */ +#define BD72720_REG_OUT32K 0x9a /* * BD71837, BD71847, and BD71828 all use bit [0] to clk output control */ @@ -118,6 +119,10 @@ static int bd71837_clk_probe(struct platform_device *p= dev) c->reg =3D BD71815_REG_OUT32K; c->mask =3D CLK_OUT_EN_MASK; break; + case ROHM_CHIP_TYPE_BD72720: + c->reg =3D BD72720_REG_OUT32K; + c->mask =3D CLK_OUT_EN_MASK; + break; default: dev_err(&pdev->dev, "Unknown clk chip\n"); return -EINVAL; @@ -146,6 +151,7 @@ static const struct platform_device_id bd718x7_clk_id[]= =3D { { "bd71847-clk", ROHM_CHIP_TYPE_BD71847 }, { "bd71828-clk", ROHM_CHIP_TYPE_BD71828 }, { "bd71815-clk", ROHM_CHIP_TYPE_BD71815 }, + { "bd72720-clk", ROHM_CHIP_TYPE_BD72720 }, { }, }; MODULE_DEVICE_TABLE(platform, bd718x7_clk_id); @@ -161,6 +167,6 @@ static struct platform_driver bd71837_clk =3D { module_platform_driver(bd71837_clk); =20 MODULE_AUTHOR("Matti Vaittinen "); -MODULE_DESCRIPTION("BD718(15/18/28/37/47/50) and chip clk driver"); +MODULE_DESCRIPTION("BD718(15/18/28/37/47/50) and BD72720 chip clk driver"); MODULE_LICENSE("GPL"); MODULE_ALIAS("platform:bd718xx-clk"); --=20 2.51.0 --3UxHLcOOARS3Jvq5 Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEIx+f8wZb28fLKEhTeFA3/03aocUFAmj/W9oACgkQeFA3/03a ocVksgf9FF1OVGzGvP2oM+r+3A6ONb1oRaQM6ReJDB5ubjWlruqoZFYZRhoQoHjd Rddg3OJCWDRoqDBaWT14glMzHhcZcSSp7vQLnuzhA+1hSk3vWo4iGrSXqaiyHJ8t zP5bxyqdva4ZsQriXCj4NjOQQYJ4GgmZyzbpS/Is5iyaqJcuQhWpEZeqp1TiYg/h ykucXcWJsuOry62COifxEvxO7rB15gaFRE3wFDz/DaQo2swBwxbnFPwIiWd0XlI5 hdl6W6WU7mexwHCaI1unre/LIMe+ldjYJbx0o2MGM5j/7Pv/sa5x5MaN4Vg9JXZZ IdNhK6cw41ZdyLMvLprHtNQ0qB58Cw== =ZYO/ -----END PGP SIGNATURE----- --3UxHLcOOARS3Jvq5-- From nobody Sat Feb 7 17:55:30 2026 Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0D3C82FCC1E for ; Mon, 27 Oct 2025 11:47:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761565680; cv=none; b=oiwT/L47E5/IAn9PgFEKLULpIa1KJy+GNK8hbGlEyy7y+MEm9xVGrRxU/uQUYDw3mFOreqnBhGCHG/6mPMkkENIrtigxWOaiYYpHJYD+uFF1HGqW7tgnPdZk78VPDXv4P4wR1hpwyWE2l9P7pOHXY/8I+48TUJbfAvZzky45vdg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761565680; c=relaxed/simple; bh=kxQqLXC/vocVby1iX86lsomk1qD0pPzWyqm+L27Qs4E=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pAf3NpiKV9g6CU6QxYQD1x4v60C1vlJov7ORSpzmcaBBdd9aK7yeKNL0gpOI4XHtrT/TRE/9T9wcW6EiQiPzi8P1NMPRMbO9xJN/v7R6cx7/C1FzkfGWfYCnD0a3ATJrV0w2fcHFpRObYzh9+RxFUwB9pgnHA/wOnFBHa0kGtdw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=iPUZ+4vt; arc=none smtp.client-ip=209.85.167.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iPUZ+4vt" Received: by mail-lf1-f49.google.com with SMTP id 2adb3069b0e04-59052926cf9so293757e87.1 for ; Mon, 27 Oct 2025 04:47:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761565676; x=1762170476; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=dcg40gldVVcahOKLGZMsmMG2vkEtjG8d8GcqdJrWwQY=; b=iPUZ+4vtv8XulflFkAsmcs8WVGaXoXTY0Kl6lRyvVdn/R1HMFZBSW9dQxMBkWxk1w3 juQOFuu1MIANhYoiaCM63beVPpNZJnzz5nkLyfzezhMKk2QmL2ukCL7G2au747H58THq 5U87DaQivaMYVPoYI52qI96bwZhls7u+6vLPOKo+hrT/9x/MEsWat+ghhe3sJjji/8yA HyGLy6srDEh71022QGdJJWn1rZ7L4Yr3nTfMSPZpTffl/mdvx8qLsO3wiRc2KfqWW26I 3RySBU07k+gb7r0kljCe97Sa819zzn/y60TMQbrMaprBQpUPo3fpBQsjEvnTCxeiCaJG 9wxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761565676; x=1762170476; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=dcg40gldVVcahOKLGZMsmMG2vkEtjG8d8GcqdJrWwQY=; b=cLzqxmxMTlwnSNVAUJM9twK2BH6aRx/M1tEqOOE29fFGUpS8TR2HDRlJIavIBgJVtd dJu2aht4LZzVE/uJonB20RnMO/Qp7faXLlW4lKiG3ReG7Pw+oGnxzpoTMVC0Kg0n9C9o 4HKBDhVGruGQVTN8AvNxrjKYinmk4r1VbVTEaFFw5fOeyipYqCOQb+lPSGDAZDMrZITB SeWo3DqoEy8x+463f2fMebxKOoFsL9WCqpFK2PUWRJxjwaumEatki1Uw5dsSbI1hemsU q19GfHABG9H7juGwYcu7mxErkgpQKEEh3npldiD80ar8AEunIrSoToF3qLnfmgBG4dX4 HXxg== X-Forwarded-Encrypted: i=1; AJvYcCWec7dCZCYkcgk6hAEIPrmIjU6OoOH1umUayX5LUgFgFRzBPXhP/gagFIU2dpHhkvsutY99VDhOLXR+rvU=@vger.kernel.org X-Gm-Message-State: AOJu0YwMrKRT2bZZLi+okA02cV3gBccknYJDWOtdSZUFR6TSRf82da4o S7JOQOjzA0OAxSzgFJiPtQOU11q+u9Svv58dtpJMdNhvvW+EYWcshcQC X-Gm-Gg: ASbGncveeW2A2HptTrUf0IwyV6TjX0RFjs7aKKduoNfCsaYyHSD1OrYetJJgxZZh4uY DVfYokcZ2T3N6YhdSdvnrp6rsBmJxVPhMVDpw8MHGY0JKUcnUqEAIiYxi9PPJDzudh+JCnBWzVp 90/ZlCLO6TsVNukD5JtdpNxQTD+avrm3YtrX5UeMYACvk1OZpRNpF65VMsxF9eEeDur73Co9O8G P21qP390K0fM9k1IXviSEDM75g2TPt26/EiGB414pxTKbAze8pO7+qsnEyRpB8OhylMLxzYvvtM FgmTH05oxlZ+Nqm0Q8KoJDTiWJ+CHKWzMlNTOkNU82BfkyQNHMBJq8tdyHCi2Cm4k4uaS5rvBYU 3FU3/QmsKuIELRv0KW5oFN08NJbXnlpWK97Cz/tuSjt4CP1vLXPx4hsW8lbYCTrbUfiHglXNmHz sPeD25fGs= X-Google-Smtp-Source: AGHT+IFyce7El8E94tjFtxV66B2JShxRuoYR16OveaviLm+6rof2Y2XS3w/azw2jsqyNQbUEoHRxCw== X-Received: by 2002:a05:6512:e81:b0:592:ee1f:227a with SMTP id 2adb3069b0e04-592f5a61330mr4908241e87.43.1761565676062; Mon, 27 Oct 2025 04:47:56 -0700 (PDT) Received: from mva-rohm ([2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-59301f41be8sm2308839e87.4.2025.10.27.04.47.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Oct 2025 04:47:55 -0700 (PDT) Date: Mon, 27 Oct 2025 13:47:51 +0200 From: Matti Vaittinen To: Matti Vaittinen , Matti Vaittinen Cc: Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Sebastian Reichel , Liam Girdwood , Mark Brown , Michael Turquette , Stephen Boyd , Matti Vaittinen , Linus Walleij , Bartosz Golaszewski , Andreas Kemnade , Alexandre Belloni , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-rtc@vger.kernel.org Subject: [PATCH v2 12/15] rtc: bd70528: Support BD72720 rtc Message-ID: <380ea1fdbb94a796418e8f463c6a9436001d572d.1761564043.git.mazziesaccount@gmail.com> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="iXlw/xinAhAbqwAt" Content-Disposition: inline In-Reply-To: --iXlw/xinAhAbqwAt Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" The BD72720 has similar RTC block as a few other ROHM PMICs. Add support for BD72720 RTC. Signed-off-by: Matti Vaittinen Acked-by: Alexandre Belloni --- Revision history: RFCv1 =3D>: - No changes --- drivers/rtc/Kconfig | 3 ++- drivers/rtc/rtc-bd70528.c | 21 ++++++++++++++------- 2 files changed, 16 insertions(+), 8 deletions(-) diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig index 2933c41c77c8..418f6c28847a 100644 --- a/drivers/rtc/Kconfig +++ b/drivers/rtc/Kconfig @@ -561,7 +561,8 @@ config RTC_DRV_BD70528 depends on MFD_ROHM_BD71828 help If you say Y here you will get support for the RTC - block on ROHM BD71815 and BD71828 Power Management IC. + block on ROHM BD71815, BD71828 and BD72720 Power + Management ICs. =20 This driver can also be built as a module. If so, the module will be called rtc-bd70528. diff --git a/drivers/rtc/rtc-bd70528.c b/drivers/rtc/rtc-bd70528.c index 954ac4ef53e8..4c8599761b2e 100644 --- a/drivers/rtc/rtc-bd70528.c +++ b/drivers/rtc/rtc-bd70528.c @@ -7,6 +7,7 @@ #include #include #include +#include #include #include #include @@ -262,13 +263,13 @@ static int bd70528_probe(struct platform_device *pdev) =20 /* * See also BD718XX_ALM_EN_OFFSET: - * This works for BD71828 and BD71815 as they have same offset - * between ALM0 start and ALM0_MASK. If new ICs are to be - * added this requires proper check as ALM0_MASK is not located - * at the end of ALM0 block - but after all ALM blocks so if - * amount of ALMs differ the offset to enable/disable is likely - * to be incorrect and enable/disable must be given as own - * reg address here. + * This works for BD71828, BD71815, and BD72720 as they all + * have same offset between the ALM0 start and the ALM0_MASK. + * If new ICs are to be added this requires proper check as + * the ALM0_MASK is not located at the end of ALM0 block - + * but after all ALM blocks. If amount of ALMs differ, the + * offset to enable/disable is likely to be incorrect and + * enable/disable must be given as own reg address here. */ bd_rtc->bd718xx_alm_block_start =3D BD71815_REG_RTC_ALM_START; hour_reg =3D BD71815_REG_HOUR; @@ -278,6 +279,11 @@ static int bd70528_probe(struct platform_device *pdev) bd_rtc->bd718xx_alm_block_start =3D BD71828_REG_RTC_ALM_START; hour_reg =3D BD71828_REG_RTC_HOUR; break; + case ROHM_CHIP_TYPE_BD72720: + bd_rtc->reg_time_start =3D BD72720_REG_RTC_START; + bd_rtc->bd718xx_alm_block_start =3D BD72720_REG_RTC_ALM_START; + hour_reg =3D BD72720_REG_RTC_HOUR; + break; default: dev_err(&pdev->dev, "Unknown chip\n"); return -ENOENT; @@ -337,6 +343,7 @@ static int bd70528_probe(struct platform_device *pdev) static const struct platform_device_id bd718x7_rtc_id[] =3D { { "bd71828-rtc", ROHM_CHIP_TYPE_BD71828 }, { "bd71815-rtc", ROHM_CHIP_TYPE_BD71815 }, + { "bd72720-rtc", ROHM_CHIP_TYPE_BD72720 }, { }, }; MODULE_DEVICE_TABLE(platform, bd718x7_rtc_id); --=20 2.51.0 --iXlw/xinAhAbqwAt Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEIx+f8wZb28fLKEhTeFA3/03aocUFAmj/W+cACgkQeFA3/03a ocXhuQgAohzG/FT0WPrB4EXABGvqNzmqjKaMFuBFPoGjFAkY3N/pJEmd0V7ydCP1 DSxlrk+dmquiaskjSTm7uICC3qTx5B14LpDOqF43tCQLGcuuUsbMGFEI8uMfgLQO 0146ZZUjDyA7fc4yn/+0JyIY+qzkf4cJDpe2chRxpcz0C6p7O5oCKwfTlkiXuAWy sup+V/PbhQMeKsnrJJZmpYos7w/Ayx3ISRYBKHqEuDf1uOiP3d1EPP0jU/QGd0ek BAAtnckkowJNNh9ymc7Y79298TVSnu4iIfrS+Zn8aNeJPllYBYOK4QGQSdW6P456 syqZCLS1tPmiNwW3ux7Pcn333AuT5Q== =Mpk6 -----END PGP SIGNATURE----- --iXlw/xinAhAbqwAt-- From nobody Sat Feb 7 17:55:30 2026 Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 275D12FF677 for ; Mon, 27 Oct 2025 11:48:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761565693; cv=none; b=CKeyoShgH7JHFE+OOqV6zm3bDJw4IukYRMSUTu+FSOQv58X25YzAwlc/pWfdXFqQv3hJ6IrkOAuygtmbdrJhQmd38fBA9g+LZarm7pbXN/roPczYiWwoHyrxaSoeFqW54/VVXwTqU4tfDkK9PE9/iwce5Ml3utzMCA+8s2yAUko= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761565693; c=relaxed/simple; bh=XZWwV054M9qiK218nIwhoEfRCBZY2K2ISL+JV8zHiW0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=gWqIrrAa1Kim5zgDUNDyS8VXp8SLCacvF/Cex7HfeQZhdAjF+AaOFw8fJAudF9f4JGj4R4Un1LDfKCpTfYX0mQmHN8EtxkW08/EWGNQm1na/cHJvEHTguf1b7lsYjfiC3jkElroXiG/bUWv6GmbaZoaFXgrYbgWt3rqchza7kFg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fOazdrDA; arc=none smtp.client-ip=209.85.167.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fOazdrDA" Received: by mail-lf1-f48.google.com with SMTP id 2adb3069b0e04-57bd482dfd2so4979617e87.2 for ; Mon, 27 Oct 2025 04:48:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761565689; x=1762170489; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=2WyxLWgy+GLmOKDJvSmkPG0LoCEHUMt4PkmDwMKiOHA=; b=fOazdrDAdVzPHCCUdJMM2LchT8t4zQS4TNHaldHSm2cUyzjYb9eLxy8juVECFq/++A W8+iwWfE/WHIazVJ2LMQpoQEGW1a+PAwKtWGWWiWZrvVbU8U3Lp0TeDUiB9pWf8ClX8D rcRHQlFu68sIEin/2yR6JGEvYV1fNv+vDb+v6OGJuJE7zKweYyOglV5Bq9A35tXKQ5rw c07UOlh930QzeRKAZ2D2rndOIgLok/0/jxd70DjKbKHlvM9b5NnfxH+DP8bMZ3bVQt0V WNppd2Ucr6l2x1rNYKkxXTNZYWah8Zbx9UMdLOWtPoqPuHKCyBQAWEO6VrRSqWZQtDAE CHeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761565689; x=1762170489; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=2WyxLWgy+GLmOKDJvSmkPG0LoCEHUMt4PkmDwMKiOHA=; b=lBrDX40Cd8Pfq9FHCBtxP3C5D1lL2t4bnB1xIRbTCpivCxcOIWxoy7XpTMvDJoRaQc 2XHhjscL/ShfrbiymBViaIaVyxVQdmDAjJ4qS9TldVIztESNLIeERU3WUl4ws7g5MCc/ 91T65XhabGZXPZ1I7sxbP6oWFFxhU/dj6B0S4ZrIb/iAqYzGM6Nkn9BIySx6cu94cFIE GYiulWOWSRJKVREE72cQxSgLBJYMxeTFtQyo5UCO0TLkYl6Iik9+5PRAMdKYDdpl20t4 ZlkDLHge3x5UPc68EhKrwOUTw0vePKlmhPiZPIGQFeig4Q8Refq8lrpbFpSSq+HX7vqE zUIg== X-Forwarded-Encrypted: i=1; AJvYcCVVJPOQ2gTWsC/Hp7FRY1fguMB8KjM6iI47brmF6wPTQ5WwaCMqArIBB4PJAi1BlQ5giNwB3fm5fl2zPAk=@vger.kernel.org X-Gm-Message-State: AOJu0YxS/Gb+WaxERTJVyhbkfnrlr6hgOcSD8JWGWCq8OhEA00I+kuut gVsq87LETgV7+xaobxKHHajwpJowQ/opaTGyvItADtxmONTiIglAq7lm X-Gm-Gg: ASbGncugDvNlLq0YbLHG4wefLMahPPc6qwgeK1pL8kyyG/1bbBMxTfVJvv9h2bNOKc/ nhu1owvDrloBFoI40pWICYSZVNTCRqBc+OzuyYUZfW0sPykW54ykFWXVdFmaBioD7xHqxITXzne 3KbWhPRWkU8Wc3MTgqAf6M3gblNgwFsCEI1Hlm1Ms1q7g/L1QsP5wvKJNywlqz4dWXnT1XwF9HG idFBuzEQ2DJCcGJMR0mGmjeYcGy1V3h/Q6/6CeylFWzeEtHgXp8fh3viK6eMcSu5fTZgDA/9v82 f0yMdctB4OH3CvPpcTPRwf3wuNywl5E+RRdAeEuVDq+Nwen5wRswh6Rn03wv0HPrnnZrBYcvVVg CPFPWBDiuvtipTCh7A5mDTh0igYmYqhkV1QkXiVvfd4tKB2OElXtVYrqyz4lsyz21tJCp3+JVg0 65GIppztzplAQxK1PWRA== X-Google-Smtp-Source: AGHT+IGhFV2dET4sdPBGpKbrKHn3UNt8L2evgmjiuyfGDmbke1yATwFb/UDFHADN5Gw3GttMPPu/HQ== X-Received: by 2002:a05:6512:110b:b0:592:f9ca:feef with SMTP id 2adb3069b0e04-592f9cb0158mr4555884e87.46.1761565689125; Mon, 27 Oct 2025 04:48:09 -0700 (PDT) Received: from mva-rohm ([2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-59301f50ab9sm2236579e87.38.2025.10.27.04.48.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Oct 2025 04:48:08 -0700 (PDT) Date: Mon, 27 Oct 2025 13:48:04 +0200 From: Matti Vaittinen To: Matti Vaittinen , Matti Vaittinen Cc: Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Sebastian Reichel , Liam Girdwood , Mark Brown , Michael Turquette , Stephen Boyd , Matti Vaittinen , Linus Walleij , Bartosz Golaszewski , Andreas Kemnade , Alexandre Belloni , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-rtc@vger.kernel.org Subject: [PATCH v2 13/15] power: supply: bd71828: Support wider register addresses Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="KYsPi76e1BOFrY/3" Content-Disposition: inline In-Reply-To: --KYsPi76e1BOFrY/3 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" The BD71828 power-supply driver assumes register addresses to be 8-bit. The new BD72720 will use stacked register maps to hide paging which is done using secondary I2C slave address. This requires use of 9-bit register addresses in the power-supply driver (added offset 0x100 to the 8-bit hardware register addresses). The cost is slightly used memory consumption as the members in the struct pwr_regs will be changed from u8 to unsigned int, which means 3 byte increase / member / instance. This is currently 14 members (expected to possibly be increased when adding new variants / new functionality which may introduce new registers, but not expected to grow much) and 2 instances (will be 3 instances when BD72720 gets added). So, even if the number of registers grew to 50 it'd be 150 bytes / instance. Assuming we eventually supported 5 variants, it'd be 5 * 150 bytes, which stays very reasonable considering systems we are dealing with. As a side note, we can reduce the "wasted space / member / instance" from 3 bytes to 1 byte, by using u16 instead of the unsigned int if needed. I rather use unsigned int to be initially prepared for devices with 32 bit registers if there is no need to count bytes. Signed-off-by: Matti Vaittinen --- Revision history: RFCv1 =3D> v2: - New patch --- drivers/power/supply/bd71828-power.c | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/power/supply/bd71828-power.c b/drivers/power/supply/bd= 71828-power.c index f667baedeb77..ce73c0f48397 100644 --- a/drivers/power/supply/bd71828-power.c +++ b/drivers/power/supply/bd71828-power.c @@ -44,19 +44,19 @@ #define VBAT_LOW_TH 0x00D4 =20 struct pwr_regs { - u8 vbat_avg; - u8 ibat; - u8 ibat_avg; - u8 btemp_vth; - u8 chg_state; - u8 bat_temp; - u8 dcin_stat; - u8 dcin_collapse_limit; - u8 chg_set1; - u8 chg_en; - u8 vbat_alm_limit_u; - u8 conf; - u8 vdcin; + unsigned int vbat_avg; + unsigned int ibat; + unsigned int ibat_avg; + unsigned int btemp_vth; + unsigned int chg_state; + unsigned int bat_temp; + unsigned int dcin_stat; + unsigned int dcin_collapse_limit; + unsigned int chg_set1; + unsigned int chg_en; + unsigned int vbat_alm_limit_u; + unsigned int conf; + unsigned int vdcin; }; =20 static const struct pwr_regs pwr_regs_bd71828 =3D { --=20 2.51.0 --KYsPi76e1BOFrY/3 Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEIx+f8wZb28fLKEhTeFA3/03aocUFAmj/W/QACgkQeFA3/03a ocULaQf9FnW8a4aC3CR/Gco2xpcMcYEYnN74DjgG5yHJmtFN7prPODevcHLpTL+A 6Mk6Av8UuiNaAoUq9wRlxiBb+U4c4G4oIDzaX3/niJal/J/pXerETcCPBfzZpHhx qq5fTjJsp59yOtxurBqmjykh1wNP+6F8EYCA2Ig336x2LcllG1xFyolI2JnKiKin qLr4Sr5gWtOqC32pVsFgEBAfOdV+GJskEg4wTaEQ1GlsSmt+wMWj9TurlMRXzdZ3 9/fN3vD+4GdWDiCj5BZvYHLv/DhXJUdT0OWLgxKvMDwD5pH2cfSoLpi14jifpr7f dQ11Gtvb4PMfmRvOYQ/+npJxk6apeg== =BPJb -----END PGP SIGNATURE----- --KYsPi76e1BOFrY/3-- From nobody Sat Feb 7 17:55:30 2026 Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C32962EFDB2 for ; Mon, 27 Oct 2025 11:48:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761565705; cv=none; b=dGhcN1aw2c2leGRfQoz9sWR9MUCTRgdXyNu1hciBTnxgIKkZV4qpwwJb7iESRzUrQfWH5/wNfYLS7lE3nGRjV/IIN8WhbwC0vX2R0MspK1YQuHuSzMvtSMSYq6fCwbfCChamIiVDU6qwG+vZqJl7FhAkasSV8Od2GhWQnQtGlBs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761565705; c=relaxed/simple; bh=vphWK+A0AMzgk1yGHk85ma/vS9LI0NA1Ue4lVi01IvE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=F7BOFchTFNWPTI/8NSS1l9X6my9tSjTpahP1vc5cqHGbBrpx9nvty87zmzaAH9qvP0AlKDeHTPB8+RfR9cWko0CInDP7HsX3ao2ZhOAsCRFFU3x3EmWpJ1f8aT+j8veMA/Pl+MJ5yBqnqUwBavZgW1TDrOhg827EfA9c2WQFKvM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=meiAnQvu; arc=none smtp.client-ip=209.85.167.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="meiAnQvu" Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-57bd482dfd2so4979811e87.2 for ; Mon, 27 Oct 2025 04:48:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761565701; x=1762170501; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=X+uomrWEvOwRk7YSDp0Fno0hWK35BKzejx7+3Tdrakg=; b=meiAnQvuxO8sM9YQ9ObwqvvvcAXL5mFnnvYZxDHd3ZI5m1GP3hq3mejYJ2dXPGXP/9 JZ8n4Ina86Mv2E2gOxcm8STJ+/oUOeFqMJVSEAfLCyUaot7O+gDBJLzJvDlMyewG8rrJ fISf90gyDWRYimk0qJTJfDx0560HItOvPCOEquaMNx5SiJuyJp3xtcHL+mX1QVf1r1ZY RFP6234MoDf2qgxXYAnIWseRqBTIViImNswMdxOUKqTDW2V9ek5sAG+LlS7e346lHFss cnXzPh2zsKbFs4Lg3+davh4WyCTk7eHHqZ/PJ1nKltREAH3DVImE+HGiwdzl33ww+uq3 9wZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761565701; x=1762170501; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=X+uomrWEvOwRk7YSDp0Fno0hWK35BKzejx7+3Tdrakg=; b=OgKvaop9ExooOcJeJfZBnayyH+lRd23Off7DUD2kdGU5S5fDWsj5KogN3MjRyJlvMR /GNbnJ/xrABG7ksfbgmRyq8FDiV9odKBNZKu4s3/EgZi5/+jD+3A0zmMuPI4U4kj0cGD 4b6s9hqkNUOi8AEeAGkcYrAl0uCLKuppoxh9vxSY9nl6ao11VhBZhnq7LUBe1CS4Bb6D hSO/fhBicLBo+DJnfsO3tBhirrFeTGKNA5pc8zZvsOdBi1ObPyGrrdML2X9QCdN52gzD H3UD4vMEV7bV65NKay2WZcUP3SrHVbS86QH8tpb32Cd6FRktehSAWLveIWQy4kSYHaLu jhtg== X-Forwarded-Encrypted: i=1; AJvYcCX2eeYf74sJx0QMzd9/BJtt2WnZXTuAWPjbgrpIyR/1U9fRwE8UXoI+nvWMdsXwvfFCV/lfb/hReSdBkew=@vger.kernel.org X-Gm-Message-State: AOJu0YzzNrx6fqSFE6iLjiV2Iexvr/qOvA5r6SLnYaz2NulH/vgnH4Ne 53utj0HTYBzrUTcvcut19JTlCu//NEntcmhU2AKnx87IYaS8ZPyRLtkiRw6PSix3 X-Gm-Gg: ASbGncvA70AYdifjxGJzQVE6kJJ1auXPqCc1JqWCRVCs1/Ap+woKkySxamjXdko5Ym9 9SKxiclA+AWEyD5/BowIGwwhAO3rzAjzhh6IP0aoXw+b07MplI8kOJMkJK3MpmyEyXuwPaQn8YS T8bSOOtydpo2nhA4TUe+wyJJd+IQEY1n1UiOGGA3SAqO8aB4fljCGP7/yHSc4mxd+uJJJ1bPITq C5AJRSYVa5YTWeuYI3067TPHVbL+VDptVeLAj2GNpf8EagOMeylwy71qCq8eOVNIGPEwPn8knHY vhLbNHgj7n2t6MhI/xknyx3sZWc0b0IJrGgpw32ojZcoGAVdl29UgVtbvfQvxDHNnamulkbx1ye nLaa8ecbVmZNiCmDVDs0yo70SwL4LTp4uunbeH2KGLg8dPouLLUrd/3G+UEC/kVPve2zPxQqofO NOu/HoqCg= X-Google-Smtp-Source: AGHT+IEzYz4iwzd064zeyK/8xMzi6tfZTuc4xolSnAZEu1IoCdIRhn5ishPNU212oINf3GNTfo0Srg== X-Received: by 2002:a05:6512:1599:b0:591:c2f9:e93a with SMTP id 2adb3069b0e04-591d856b716mr11598667e87.57.1761565700772; Mon, 27 Oct 2025 04:48:20 -0700 (PDT) Received: from mva-rohm ([2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-59301f83963sm2234106e87.100.2025.10.27.04.48.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Oct 2025 04:48:19 -0700 (PDT) Date: Mon, 27 Oct 2025 13:48:16 +0200 From: Matti Vaittinen To: Matti Vaittinen , Matti Vaittinen Cc: Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Sebastian Reichel , Liam Girdwood , Mark Brown , Michael Turquette , Stephen Boyd , Matti Vaittinen , Linus Walleij , Bartosz Golaszewski , Andreas Kemnade , Alexandre Belloni , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-rtc@vger.kernel.org Subject: [PATCH v2 14/15] power: supply: bd71828-power: Support ROHM BD72720 Message-ID: <1cc5671db6b6f8ece03d31e917c0fc5fba38ce80.1761564043.git.mazziesaccount@gmail.com> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="kXllvQDVIirJRly2" Content-Disposition: inline In-Reply-To: --kXllvQDVIirJRly2 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" The ROHM BD72720 is a power management IC with a charger and coulomb counter block which is closely related to the charger / coulomb counter found from the BD71815, BD71828, BD71879 which are all supported by the bd71828-power driver. Due to the similarities it makes sense to support also the BD72720 with the same driver. Add basic support for the charger logic on ROHM BD72720. Signed-off-by: Matti Vaittinen --- Revision history: RFCv1 =3D> v2: - Support using 9-bit register addresses (offset of 0x100) with the BD72720 - Simplify probe and IC data as we don't need two regmaps - Drop two BD72720 specific functions as we no longer need different regmap for it. Note: This patch depends on the series: "power: supply: add charger for BD71828" by Andreas: https://lore.kernel.org/all/20250918-bd71828-charger-v5-0-851164839c28@kemn= ade.info/ NOTE: Fuel-gauging is not supported. You can find an unmaintained downstream reference-driver with a fuel-gauge example from: https://github.com/RohmSemiconductor/Linux-Kernel-PMIC-Drivers/releases/tag= /bd72720-reference-driver-v1 --- drivers/power/supply/bd71828-power.c | 134 +++++++++++++++++++++++---- 1 file changed, 116 insertions(+), 18 deletions(-) diff --git a/drivers/power/supply/bd71828-power.c b/drivers/power/supply/bd= 71828-power.c index ce73c0f48397..438e220a9cb7 100644 --- a/drivers/power/supply/bd71828-power.c +++ b/drivers/power/supply/bd71828-power.c @@ -5,6 +5,7 @@ #include #include #include +#include #include #include #include @@ -51,12 +52,14 @@ struct pwr_regs { unsigned int chg_state; unsigned int bat_temp; unsigned int dcin_stat; + unsigned int dcin_online_mask; unsigned int dcin_collapse_limit; unsigned int chg_set1; unsigned int chg_en; unsigned int vbat_alm_limit_u; unsigned int conf; unsigned int vdcin; + unsigned int vdcin_himask; }; =20 static const struct pwr_regs pwr_regs_bd71828 =3D { @@ -67,12 +70,14 @@ static const struct pwr_regs pwr_regs_bd71828 =3D { .chg_state =3D BD71828_REG_CHG_STATE, .bat_temp =3D BD71828_REG_BAT_TEMP, .dcin_stat =3D BD71828_REG_DCIN_STAT, + .dcin_online_mask =3D BD7182x_MASK_DCIN_DET, .dcin_collapse_limit =3D BD71828_REG_DCIN_CLPS, .chg_set1 =3D BD71828_REG_CHG_SET1, .chg_en =3D BD71828_REG_CHG_EN, .vbat_alm_limit_u =3D BD71828_REG_ALM_VBAT_LIMIT_U, .conf =3D BD71828_REG_CONF, .vdcin =3D BD71828_REG_VDCIN_U, + .vdcin_himask =3D BD7182x_MASK_VDCIN_U, }; =20 static const struct pwr_regs pwr_regs_bd71815 =3D { @@ -85,6 +90,7 @@ static const struct pwr_regs pwr_regs_bd71815 =3D { .chg_state =3D BD71815_REG_CHG_STATE, .bat_temp =3D BD71815_REG_BAT_TEMP, .dcin_stat =3D BD71815_REG_DCIN_STAT, + .dcin_online_mask =3D BD7182x_MASK_DCIN_DET, .dcin_collapse_limit =3D BD71815_REG_DCIN_CLPS, .chg_set1 =3D BD71815_REG_CHG_SET1, .chg_en =3D BD71815_REG_CHG_SET1, @@ -92,6 +98,31 @@ static const struct pwr_regs pwr_regs_bd71815 =3D { .conf =3D BD71815_REG_CONF, =20 .vdcin =3D BD71815_REG_VM_DCIN_U, + .vdcin_himask =3D BD7182x_MASK_VDCIN_U, +}; + +static struct pwr_regs pwr_regs_bd72720 =3D { + .vbat_avg =3D BD72720_REG_VM_SA_VBAT_U, + .ibat =3D BD72720_REG_CC_CURCD_U, + .ibat_avg =3D BD72720_REG_CC_SA_CURCD_U, + .btemp_vth =3D BD72720_REG_VM_BTMP_U, + /* + * Note, state 0x40 IMP_CHK. not documented + * on other variants but was still handled in + * existing code. No memory traces as to why. + */ + .chg_state =3D BD72720_REG_CHG_STATE, + .bat_temp =3D BD72720_REG_CHG_BAT_TEMP_STAT, + .dcin_stat =3D BD72720_REG_INT_VBUS_SRC, + .dcin_online_mask =3D BD72720_MASK_DCIN_DET, + .dcin_collapse_limit =3D -1, /* Automatic. Setting not supported */ + .chg_set1 =3D BD72720_REG_CHG_SET_1, + .chg_en =3D BD72720_REG_CHG_EN, + /* 15mV note in data-sheet */ + .vbat_alm_limit_u =3D BD72720_REG_ALM_VBAT_TH_U, + .conf =3D BD72720_REG_CONF, /* o XSTB, only PON. Seprate slave addr */ + .vdcin =3D BD72720_REG_VM_VBUS_U, /* 10 bits not 11 as with other ICs */ + .vdcin_himask =3D BD72720_MASK_VDCIN_U, }; =20 struct bd71828_power { @@ -298,7 +329,7 @@ static int get_chg_online(struct bd71828_power *pwr, in= t *chg_online) dev_err(pwr->dev, "Failed to read DCIN status\n"); return ret; } - *chg_online =3D ((r & BD7182x_MASK_DCIN_DET) !=3D 0); + *chg_online =3D ((r & pwr->regs->dcin_online_mask) !=3D 0); =20 return 0; } @@ -329,8 +360,8 @@ static int bd71828_bat_inserted(struct bd71828_power *p= wr) ret =3D val & BD7182x_MASK_CONF_PON; =20 if (ret) - regmap_update_bits(pwr->regmap, pwr->regs->conf, - BD7182x_MASK_CONF_PON, 0); + if (regmap_update_bits(pwr->regmap, pwr->regs->conf, BD7182x_MASK_CONF_P= ON, 0)) + dev_err(pwr->dev, "Failed to write CONF register\n"); =20 return ret; } @@ -358,11 +389,13 @@ static int bd71828_init_hardware(struct bd71828_power= *pwr) int ret; =20 /* TODO: Collapse limit should come from device-tree ? */ - ret =3D regmap_write(pwr->regmap, pwr->regs->dcin_collapse_limit, - BD7182x_DCIN_COLLAPSE_DEFAULT); - if (ret) { - dev_err(pwr->dev, "Failed to write DCIN collapse limit\n"); - return ret; + if (pwr->regs->dcin_collapse_limit !=3D (unsigned int)-1) { + ret =3D regmap_write(pwr->regmap, pwr->regs->dcin_collapse_limit, + BD7182x_DCIN_COLLAPSE_DEFAULT); + if (ret) { + dev_err(pwr->dev, "Failed to write DCIN collapse limit\n"); + return ret; + } } =20 ret =3D pwr->bat_inserted(pwr); @@ -419,7 +452,7 @@ static int bd71828_charger_get_property(struct power_su= pply *psy, break; case POWER_SUPPLY_PROP_VOLTAGE_NOW: ret =3D bd7182x_read16_himask(pwr, pwr->regs->vdcin, - BD7182x_MASK_VDCIN_U, &tmp); + pwr->regs->vdcin_himask, &tmp); if (ret) return ret; =20 @@ -630,6 +663,9 @@ BD_ISR_AC(dcin_ovp_det, "DCIN OVER VOLTAGE", true) BD_ISR_DUMMY(dcin_mon_det, "DCIN voltage below threshold") BD_ISR_DUMMY(dcin_mon_res, "DCIN voltage above threshold") =20 +BD_ISR_DUMMY(vbus_curr_limit, "VBUS current limited") +BD_ISR_DUMMY(vsys_ov_res, "VSYS over-voltage cleared") +BD_ISR_DUMMY(vsys_ov_det, "VSYS over-voltage") BD_ISR_DUMMY(vsys_uv_res, "VSYS under-voltage cleared") BD_ISR_DUMMY(vsys_uv_det, "VSYS under-voltage") BD_ISR_DUMMY(vsys_low_res, "'VSYS low' cleared") @@ -878,6 +914,51 @@ static int bd7182x_get_irqs(struct platform_device *pd= ev, BDIRQ("bd71828-temp-125-over", bd71828_temp_vf125_det), BDIRQ("bd71828-temp-125-under", bd71828_temp_vf125_res), }; + static const struct bd7182x_irq_res bd72720_irqs[] =3D { + BDIRQ("bd72720_int_vbus_rmv", BD_ISR_NAME(dcin_removed)), + BDIRQ("bd72720_int_vbus_det", bd7182x_dcin_detected), + BDIRQ("bd72720_int_vbus_mon_res", BD_ISR_NAME(dcin_mon_res)), + BDIRQ("bd72720_int_vbus_mon_det", BD_ISR_NAME(dcin_mon_det)), + BDIRQ("bd72720_int_vsys_mon_res", BD_ISR_NAME(vsys_mon_res)), + BDIRQ("bd72720_int_vsys_mon_det", BD_ISR_NAME(vsys_mon_det)), + BDIRQ("bd72720_int_vsys_uv_res", BD_ISR_NAME(vsys_uv_res)), + BDIRQ("bd72720_int_vsys_uv_det", BD_ISR_NAME(vsys_uv_det)), + BDIRQ("bd72720_int_vsys_lo_res", BD_ISR_NAME(vsys_low_res)), + BDIRQ("bd72720_int_vsys_lo_det", BD_ISR_NAME(vsys_low_det)), + BDIRQ("bd72720_int_vsys_ov_res", BD_ISR_NAME(vsys_ov_res)), + BDIRQ("bd72720_int_vsys_ov_det", BD_ISR_NAME(vsys_ov_det)), + BDIRQ("bd72720_int_bat_ilim", BD_ISR_NAME(vbus_curr_limit)), + BDIRQ("bd72720_int_chg_done", bd718x7_chg_done), + BDIRQ("bd72720_int_extemp_tout", BD_ISR_NAME(chg_wdg_temp)), + BDIRQ("bd72720_int_chg_wdt_exp", BD_ISR_NAME(chg_wdg)), + BDIRQ("bd72720_int_bat_mnt_out", BD_ISR_NAME(rechg_res)), + BDIRQ("bd72720_int_bat_mnt_in", BD_ISR_NAME(rechg_det)), + BDIRQ("bd72720_int_chg_trns", BD_ISR_NAME(chg_state_changed)), + + BDIRQ("bd72720_int_vbat_mon_res", BD_ISR_NAME(bat_mon_res)), + BDIRQ("bd72720_int_vbat_mon_det", BD_ISR_NAME(bat_mon)), + BDIRQ("bd72720_int_vbat_sht_res", BD_ISR_NAME(bat_short_res)), + BDIRQ("bd72720_int_vbat_sht_det", BD_ISR_NAME(bat_short)), + BDIRQ("bd72720_int_vbat_lo_res", BD_ISR_NAME(bat_low_res)), + BDIRQ("bd72720_int_vbat_lo_det", BD_ISR_NAME(bat_low)), + BDIRQ("bd72720_int_vbat_ov_res", BD_ISR_NAME(bat_ov_res)), + BDIRQ("bd72720_int_vbat_ov_det", BD_ISR_NAME(bat_ov)), + BDIRQ("bd72720_int_bat_rmv", BD_ISR_NAME(bat_removed)), + BDIRQ("bd72720_int_bat_det", BD_ISR_NAME(bat_det)), + BDIRQ("bd72720_int_dbat_det", BD_ISR_NAME(bat_dead)), + BDIRQ("bd72720_int_bat_temp_trns", BD_ISR_NAME(temp_transit)), + BDIRQ("bd72720_int_lobtmp_res", BD_ISR_NAME(temp_bat_low_res)), + BDIRQ("bd72720_int_lobtmp_det", BD_ISR_NAME(temp_bat_low)), + BDIRQ("bd72720_int_ovbtmp_res", BD_ISR_NAME(temp_bat_hi_res)), + BDIRQ("bd72720_int_ovbtmp_det", BD_ISR_NAME(temp_bat_hi)), + BDIRQ("bd72720_int_ocur1_res", BD_ISR_NAME(bat_oc1_res)), + BDIRQ("bd72720_int_ocur1_det", BD_ISR_NAME(bat_oc1)), + BDIRQ("bd72720_int_ocur2_res", BD_ISR_NAME(bat_oc2_res)), + BDIRQ("bd72720_int_ocur2_det", BD_ISR_NAME(bat_oc2)), + BDIRQ("bd72720_int_ocur3_res", BD_ISR_NAME(bat_oc3_res)), + BDIRQ("bd72720_int_ocur3_det", BD_ISR_NAME(bat_oc3)), + BDIRQ("bd72720_int_cc_mon2_det", BD_ISR_NAME(bat_cc_mon)), + }; int num_irqs; const struct bd7182x_irq_res *irqs; =20 @@ -890,6 +971,10 @@ static int bd7182x_get_irqs(struct platform_device *pd= ev, irqs =3D &bd71815_irqs[0]; num_irqs =3D ARRAY_SIZE(bd71815_irqs); break; + case ROHM_CHIP_TYPE_BD72720: + irqs =3D &bd72720_irqs[0]; + num_irqs =3D ARRAY_SIZE(bd72720_irqs); + break; default: return -EINVAL; } @@ -958,21 +1043,27 @@ static int bd71828_power_probe(struct platform_devic= e *pdev) struct power_supply_config ac_cfg =3D {}; struct power_supply_config bat_cfg =3D {}; int ret; - struct regmap *regmap; - - regmap =3D dev_get_regmap(pdev->dev.parent, NULL); - if (!regmap) { - dev_err(&pdev->dev, "No parent regmap\n"); - return -EINVAL; - } =20 pwr =3D devm_kzalloc(&pdev->dev, sizeof(*pwr), GFP_KERNEL); if (!pwr) return -ENOMEM; =20 - pwr->regmap =3D regmap; - pwr->dev =3D &pdev->dev; + /* + * The BD72720 MFD device registers two regmaps. Power-supply driver + * uses the "wrap-map", which provides access to both of the I2C slave + * addresses used by the BD72720 + */ pwr->chip_type =3D platform_get_device_id(pdev)->driver_data; + if (pwr->chip_type !=3D ROHM_CHIP_TYPE_BD72720) + pwr->regmap =3D dev_get_regmap(pdev->dev.parent, NULL); + else + pwr->regmap =3D dev_get_regmap(pdev->dev.parent, "wrap-map"); + if (!pwr->regmap) { + dev_err(&pdev->dev, "No parent regmap\n"); + return -EINVAL; + } + + pwr->dev =3D &pdev->dev; =20 switch (pwr->chip_type) { case ROHM_CHIP_TYPE_BD71828: @@ -985,6 +1076,12 @@ static int bd71828_power_probe(struct platform_device= *pdev) pwr->get_temp =3D bd71815_get_temp; pwr->regs =3D &pwr_regs_bd71815; break; + case ROHM_CHIP_TYPE_BD72720: + pwr->bat_inserted =3D bd71828_bat_inserted; + pwr->regs =3D &pwr_regs_bd72720; + pwr->get_temp =3D bd71828_get_temp; + dev_dbg(pwr->dev, "Found ROHM BD72720\n"); + break; default: dev_err(pwr->dev, "Unknown PMIC\n"); return -EINVAL; @@ -1030,6 +1127,7 @@ static int bd71828_power_probe(struct platform_device= *pdev) static const struct platform_device_id bd71828_charger_id[] =3D { { "bd71815-power", ROHM_CHIP_TYPE_BD71815 }, { "bd71828-power", ROHM_CHIP_TYPE_BD71828 }, + { "bd72720-power", ROHM_CHIP_TYPE_BD72720 }, { }, }; MODULE_DEVICE_TABLE(platform, bd71828_charger_id); --=20 2.51.0 --kXllvQDVIirJRly2 Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEIx+f8wZb28fLKEhTeFA3/03aocUFAmj/XAAACgkQeFA3/03a ocVdMgf6Anas8qvfz0RD0Vw9709JFKXRnY3BhW7VdgpXQp3oCBodG3DqLUlljBKB ZFYae05EeQIc+/9mh4NpaVlEsa4m6a/H2rQ9ZqFAZoIKt4RHGfaEJYC9jIhndZgf EVs+dchHd5mufCIzw9w3/rDntMVIfmA5++KpapUwJbPHM0cW4WyGp7xHx2NwsOi2 cnv+aa6Ih3wS2rEMMdIPSv2WI2UbVOuYgT2JBqcuI1/Yv97SzRrZ7GXnXS80cdtg F3QyRZ2SgSIrGX0gmtE6BLssdyBevWHu+s0yRxUnGm5wq+t6WeZ5h8c7SUf6RifR U8QLcOlWcxcqaZy7hywdPKtrHuD8pA== =jIEt -----END PGP SIGNATURE----- --kXllvQDVIirJRly2-- From nobody Sat Feb 7 17:55:30 2026 Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com [209.85.167.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 90E222D3EE0 for ; Mon, 27 Oct 2025 11:48:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761565728; cv=none; b=njAmUzffbZk9Dr66rto0uc7lBgGA6HN+LO5rwaw1L3s6eQaBUIQiCKnxoxet3WZhUB+HqGYf/0A7qKM/YhhaU+gvdZG5pc1vk2D8Mt5a+wcoM7hj/yASTdbe88FQ+TA1aWn/iNEMt/kl05vvWVvpwilj7qSUl4cGR9bG+32ymB0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761565728; c=relaxed/simple; bh=i5F5XSjM3QJPOTTHFDn4pVZhOuKFqmtvKFMtVhcqG/c=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=SASeKESng41cohOK0ecFa4w1Y3o/RU4GHAGIjLR50AUXqLsW4nERG9ve8YCw19sA2CN9TvFPOC4dMVp0HpKdPcbQhZ87BUwJwVFvykXeohOdAEYQ9+1DJvoQUxq5IoXulfiz6lH2Rk5RwhzxW4i3tiOqRONyaOcvefJzghQvZmU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DOl6EGX/; arc=none smtp.client-ip=209.85.167.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DOl6EGX/" Received: by mail-lf1-f41.google.com with SMTP id 2adb3069b0e04-592ff1d80feso3211952e87.2 for ; Mon, 27 Oct 2025 04:48:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761565724; x=1762170524; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=PgT9stFn/poAbljDOlAYgxNBl2XctKW6jluiWQlJc8k=; b=DOl6EGX/+8+hk8eLbTOmrd6+VL7zsHouc81K8c5OcjjiueeAXDnY7m8eDgA5Wd8d7H +3wZPJo90Glu3zmfecJpvT4HxmuAuXgpuoAQkYVaF6ww0/W+xo6yjB3YdYKymx5++Sj7 8AXOI5K+ge/VGlEJPngZhoawc2kNlWQH0coozlMTTejMMFy0adF41dEPhrNAjFxMRivZ 3ZP7peyNbIbNQ73fOzB6RuHHbCVcO/C34cp5JIdJM1F/5q3sEfDyhBqy5s+RF+/Xc80a XougV/F30ZSrwg3FmpXyLLJPeqAhxPul3Gdqqzhuf5xxpcaXyubqyuqT2f3oyg3I8HGx WqUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761565724; x=1762170524; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=PgT9stFn/poAbljDOlAYgxNBl2XctKW6jluiWQlJc8k=; b=BnUylTO0yjXGo1hKkeQTS3ZdS6LtvcD3uchGbuotQSRQx84uIGAhP9Jspg6QHrhtUg G7l5dMyVldzAS0hwINGakoo/jUeoWsPNWgH8AziDcSHmZKVhviGAP0IGVsEaaojN5IaA CA3DqSO1WuPCoo7pi8BIH95/DnNbBJ45KN+47s7LoapjqCwj7OTrRDyi/bLjCYhmzd8j wvUbzwp5WqrYLcY8aEbI69eZ/lIyeDldkZCjTVAfbmJ7TqnbXbhcmTnF2c1VGYr+k1u7 Vd0Na0IXaWg5BeS8hxtyyAHWdAB70VAVenWGa+V5cru4eqxCEKzoXjQqd/bWSkB+M9kw JjVw== X-Forwarded-Encrypted: i=1; AJvYcCWZgUY4rw4CCA2kVSOyu75YEcZY7UswBNaUp918e7fYu5VNDDHNkZ6KvkCoaKKrk9LVrOblRFS07Ucgdgw=@vger.kernel.org X-Gm-Message-State: AOJu0YyBVG4654tPDAsh2WnyLeCrHeYY4GSUimbvshP36efYPW/k2eRM EdiiFE91k71iXM0QB0jnthepdTt9A9j9Z4IlrKMrymiRd0xWe35hD8FT X-Gm-Gg: ASbGncvs2feKyG7iqy3Dj07hOi9/y86nHS9mkk4A+TFTQBtxdH9cYPQKE/wMTsM0EuK 2NyP8yCExGzdAXTb9BclvJaM6ED5QfXRDs08HkSqfLdWz3+mmr0meHVTTngo6AdBv2RccFAyaz9 zXm4DiC9sGxAMo7I7SVnLJOC0invCAQVhnGMToNnw3PCuGnUqT5tBuUPafxrHzS6DUKfbodtcmx B7wUpNU/m8Btu2b39MdsinfZJ4vBfOj3tfz5vIv1rjMZ92YqIUoQnaOMXKe+hE0AMLNERUdad0u gpKbe9sxrsvKYocgvjRouLRaOwlYrguub2MVyAsE3LdUfiD3MIXWUMqgx47Y+8fnruSVLYzg2/o Sd2rIi3GcfV4RXFEyj36qy7mIPzZNhlN4DSiCQhhLrWDe5tqrr06Ddmf1J2dw9sZZiEzUPfT5z8 nYSCt4fbLT0JXfJOg0rw== X-Google-Smtp-Source: AGHT+IGSnZ+yAlMhSP89/zGsbZ8XNjjCkf1vNfg2R/zfGqQhGr2QeTscx5csNq8cRoakqqj6FfPRlQ== X-Received: by 2002:a05:6512:3054:b0:592:f74f:a49a with SMTP id 2adb3069b0e04-592fc9e8f2bmr2863532e87.13.1761565723504; Mon, 27 Oct 2025 04:48:43 -0700 (PDT) Received: from mva-rohm ([2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-59301f41cbbsm2306417e87.2.2025.10.27.04.48.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Oct 2025 04:48:41 -0700 (PDT) Date: Mon, 27 Oct 2025 13:48:37 +0200 From: Matti Vaittinen To: Matti Vaittinen , Matti Vaittinen Cc: Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Sebastian Reichel , Liam Girdwood , Mark Brown , Michael Turquette , Stephen Boyd , Matti Vaittinen , Linus Walleij , Bartosz Golaszewski , Andreas Kemnade , Alexandre Belloni , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-rtc@vger.kernel.org Subject: [PATCH v2 15/15] MAINTAINERS: Add ROHM BD72720 PMIC Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="PVPHd8ApeQQcOqGz" Content-Disposition: inline In-Reply-To: --PVPHd8ApeQQcOqGz Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Add the ROHM BD72720 PMIC driver files to be maintained by undersigned. Signed-off-by: Matti Vaittinen --- Revision history: RFCv1 =3D>: - No changes --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index fe01aa31c58b..7e3c1eac7cda 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -22353,6 +22353,7 @@ S: Supported F: drivers/clk/clk-bd718x7.c F: drivers/gpio/gpio-bd71815.c F: drivers/gpio/gpio-bd71828.c +F: drivers/gpio/gpio-bd72720.c F: drivers/mfd/rohm-bd71828.c F: drivers/mfd/rohm-bd718x7.c F: drivers/mfd/rohm-bd9576.c @@ -22369,6 +22370,7 @@ F: drivers/watchdog/bd96801_wdt.c F: include/linux/mfd/rohm-bd71815.h F: include/linux/mfd/rohm-bd71828.h F: include/linux/mfd/rohm-bd718x7.h +F: include/linux/mfd/rohm-bd72720.h F: include/linux/mfd/rohm-bd957x.h F: include/linux/mfd/rohm-bd96801.h F: include/linux/mfd/rohm-bd96802.h --=20 2.51.0 --PVPHd8ApeQQcOqGz Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEIx+f8wZb28fLKEhTeFA3/03aocUFAmj/XBUACgkQeFA3/03a ocX1rAf+OKqdSASLkvANGwIB/trs/JiLB0LQhsIiEMY6ZwKNN3UlkIbvSSEjJpmn nGD+STZZhVbwJP7cpf/Uz9omS2lSQDMtoCTzkzd2+8zXQuuHU0qt/EP20le9J6V6 P/wHiPXOVDfIfD/Gr6JdPQ5XtPEhyPZdY478JbR0bQyzA1AskbLKvmRKZZfsISej QEzG1Qvzw2hj3tke8B+M51Gf+pJ9Gw+bILA9b96+BTI/JmHENSIEHxok2bSC2oZE 0jJKnTR3LAtUkx7UCmvK8bgnaDTbHb5Es1tbd+ob6I4QuaUemtoDzgEILVMiXvx7 ZY462g3yI8d+cYed3UTXxIuDnsHC2w== =qVnM -----END PGP SIGNATURE----- --PVPHd8ApeQQcOqGz--