From nobody Sat Feb 7 14:57:24 2026 Received: from fw2.prolan.hu (fw2.prolan.hu [193.68.50.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E976311961; Wed, 22 Oct 2025 09:09:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.68.50.107 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761124146; cv=none; b=EXj6s1NpqW0mS9f/OI3R+o4Oc8oIYcukwVWuhjH2a3fzchd14U0GJRFgouXQe7wjieXRTEumxAekNs7i6jvZUz27izBNhulLXKbFM1tMA9Y6xvAapkJbPzKsSYtSTWWcMTK7MYfqmpbSVYJQybNu+M+MJMfWKtCBXApjcIq5TF4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761124146; c=relaxed/simple; bh=g1YAmeMzN6ozffVqPzQIrrVPv3nv4gUq1NT+8X3Q6hI=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=KcFllm76h3aIEWlM39ZLcSrWuYUrySdVT7Dv/5TYSRIZEy65kwAegul0WMzxCXvUDjj0tgHm6lEZ6EQjEf/AJJS1L3FnnpQ8X3ybPXQ+HwieNAL3FzSgt99j7bHUJ7dvoyBaWjGujaYB2LweXV8UOSzh5enNzYpUHA8mssKtows= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=prolan.hu; spf=pass smtp.mailfrom=prolan.hu; dkim=pass (4096-bit key) header.d=prolan.hu header.i=@prolan.hu header.b=VshWH/Ut; arc=none smtp.client-ip=193.68.50.107 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=prolan.hu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=prolan.hu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (4096-bit key) header.d=prolan.hu header.i=@prolan.hu header.b="VshWH/Ut" Received: from proxmox-mailgw.intranet.prolan.hu (localhost.localdomain [127.0.0.1]) by proxmox-mailgw.intranet.prolan.hu (Proxmox) with ESMTP id 2BAA2A0AC2; Wed, 22 Oct 2025 11:08:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=prolan.hu; h=cc :cc:content-transfer-encoding:content-type:content-type:date :from:from:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=mail; bh=Hqjddm9r/QWkPQVUfT2f uPoj7hfgEt2/ZG9yAxvwVhQ=; b=VshWH/UtJ9R9xro2kFmjb6fxaSehvNTjail/ EWiAMfPh5HiRCpH8SEkPtyLMQovG9aBiQbQdFokCLSD7SZcfy3J3KTh3rnsFoDsh RDTPfsf3m51zjjww+4RBU6NT7nAsLg1q4yfwHRTRPTZksPXd0ZosnHEJcOIj8Vi1 n7u8IinhXIhaRfVwH8rhXsCKbnvmBT8aBEK5ZVxBsPQgyAOHuvYM47LY1HhMzA9q wiFrYzrJlHQImfUFAU4GU2d83FhBhYNCUnijTPPmpfcbFhbTSeWNL+oz8RyqSEmy NjzTDmZhoCsfb1FFOVkND8Hsp2cMN7gkILQoJeEDF2TerwZ4bLLOVWvJXUh2EvIP fTBrRzBoLnti42IGCog4SEWjWm56c+onX+oQ1LyIZl+GhTNZAp+XT/oBrr9mm8uP rtA2XrRpjl0AET5r1MuEbylufF0Qp9HOCcx85YTOSr941rgsor/OklT1Wi2JZQRx y1c/iuq9gHVmHU7//cFaVddr3hNRm0zasT7NoAY7piquKJrIUem4G/bHDeNnv515 ig+76YJAOyMsGtAKeVToFvX79Imf+9tWMr7k4ZpGiurIruzNM9o6ulpfWSWx/HTc FkrzakBaEOqZq18ky1OB4WdiLhGN3eQ9bWr3AIhAaYQxGS48DcfAd/PFCqBwCkB6 YMsTIeM= From: Buday Csaba To: Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Philipp Zabel , , CC: Buday Csaba Subject: [PATCH net-next v4 1/4] net: mdio: common handling of phy reset properties Date: Wed, 22 Oct 2025 11:08:50 +0200 Message-ID: <58dd6c6e6684e2dc8e7a97e9ebc086a1cb273735.1761124022.git.buday.csaba@prolan.hu> X-Mailer: git-send-email 2.39.5 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ESET-AS: R=OK;S=0;OP=CALC;TIME=1761124136;VERSION=8000;MC=2712308536;ID=130158;TRN=0;CRV=0;IPC=;SP=0;SIPS=0;PI=3;F=0 X-ESET-Antispam: OK X-EsetResult: clean, is OK X-EsetId: 37303A2998FD515F647D62 Content-Type: text/plain; charset="utf-8" Reset properties of an `mdio_device` are initialized in multiple source files and multiple functions: - `reset_assert_delay` and `reset_deassert_delay` are in fwnode_mdio.c - `reset_gpio` and `reset_ctrl` are in mdio_bus.c, but handled by different functions This patch unifies the handling of all these properties into two functions. mdiobus_register_gpiod() and mdiobus_register_reset() are removed, while mdio_device_register_reset() and mdio_device_unregister_reset() are introduced instead. These functions handle both reset-controllers and reset-gpios, and also read the corresponding properties from the device tree. These changes should make tracking the reset properties easier. The reset logic is unaltered, and should work as it did before. Signed-off-by: Buday Csaba --- V3 -> V4: unmodified V2 -> V3: fixed kernel-doc warnings V1 -> V2: the return value of mdio_device_unregister_reset() is made void --- drivers/net/mdio/fwnode_mdio.c | 5 ---- drivers/net/phy/mdio_bus.c | 39 ++----------------------- drivers/net/phy/mdio_device.c | 52 ++++++++++++++++++++++++++++++++++ include/linux/mdio.h | 2 ++ 4 files changed, 56 insertions(+), 42 deletions(-) diff --git a/drivers/net/mdio/fwnode_mdio.c b/drivers/net/mdio/fwnode_mdio.c index 9b41d4697..ba7091518 100644 --- a/drivers/net/mdio/fwnode_mdio.c +++ b/drivers/net/mdio/fwnode_mdio.c @@ -92,11 +92,6 @@ int fwnode_mdiobus_phy_device_register(struct mii_bus *m= dio, if (fwnode_property_read_bool(child, "broken-turn-around")) mdio->phy_ignore_ta_mask |=3D 1 << addr; =20 - fwnode_property_read_u32(child, "reset-assert-us", - &phy->mdio.reset_assert_delay); - fwnode_property_read_u32(child, "reset-deassert-us", - &phy->mdio.reset_deassert_delay); - /* Associate the fwnode with the device structure so it * can be looked up later */ diff --git a/drivers/net/phy/mdio_bus.c b/drivers/net/phy/mdio_bus.c index cad6ed3aa..cc3f9cfb1 100644 --- a/drivers/net/phy/mdio_bus.c +++ b/drivers/net/phy/mdio_bus.c @@ -33,33 +33,6 @@ #define CREATE_TRACE_POINTS #include =20 -static int mdiobus_register_gpiod(struct mdio_device *mdiodev) -{ - /* Deassert the optional reset signal */ - mdiodev->reset_gpio =3D gpiod_get_optional(&mdiodev->dev, - "reset", GPIOD_OUT_LOW); - if (IS_ERR(mdiodev->reset_gpio)) - return PTR_ERR(mdiodev->reset_gpio); - - if (mdiodev->reset_gpio) - gpiod_set_consumer_name(mdiodev->reset_gpio, "PHY reset"); - - return 0; -} - -static int mdiobus_register_reset(struct mdio_device *mdiodev) -{ - struct reset_control *reset; - - reset =3D reset_control_get_optional_exclusive(&mdiodev->dev, "phy"); - if (IS_ERR(reset)) - return PTR_ERR(reset); - - mdiodev->reset_ctrl =3D reset; - - return 0; -} - int mdiobus_register_device(struct mdio_device *mdiodev) { int err; @@ -68,16 +41,9 @@ int mdiobus_register_device(struct mdio_device *mdiodev) return -EBUSY; =20 if (mdiodev->flags & MDIO_DEVICE_FLAG_PHY) { - err =3D mdiobus_register_gpiod(mdiodev); + err =3D mdio_device_register_reset(mdiodev); if (err) return err; - - err =3D mdiobus_register_reset(mdiodev); - if (err) - return err; - - /* Assert the reset signal */ - mdio_device_reset(mdiodev, 1); } =20 mdiodev->bus->mdio_map[mdiodev->addr] =3D mdiodev; @@ -91,8 +57,7 @@ int mdiobus_unregister_device(struct mdio_device *mdiodev) if (mdiodev->bus->mdio_map[mdiodev->addr] !=3D mdiodev) return -EINVAL; =20 - gpiod_put(mdiodev->reset_gpio); - reset_control_put(mdiodev->reset_ctrl); + mdio_device_unregister_reset(mdiodev); =20 mdiodev->bus->mdio_map[mdiodev->addr] =3D NULL; =20 diff --git a/drivers/net/phy/mdio_device.c b/drivers/net/phy/mdio_device.c index f64176e0e..fb1cb7a26 100644 --- a/drivers/net/phy/mdio_device.c +++ b/drivers/net/phy/mdio_device.c @@ -74,6 +74,58 @@ struct mdio_device *mdio_device_create(struct mii_bus *b= us, int addr) } EXPORT_SYMBOL(mdio_device_create); =20 +/** + * mdio_device_register_reset - Read and initialize the reset properties of + * an mdio device + * @mdiodev: mdio_device structure + * + * Return: Zero if successful, negative error code on failure + */ +int mdio_device_register_reset(struct mdio_device *mdiodev) +{ + struct reset_control *reset; + + /* Read optional firmware properties */ + fwnode_property_read_u32(dev_fwnode(&mdiodev->dev), "reset-assert-us", + &mdiodev->reset_assert_delay); + fwnode_property_read_u32(dev_fwnode(&mdiodev->dev), "reset-deassert-us", + &mdiodev->reset_deassert_delay); + + /* reset-gpio, bring up deasserted */ + mdiodev->reset_gpio =3D gpiod_get_optional(&mdiodev->dev, "reset", + GPIOD_OUT_LOW); + + if (IS_ERR(mdiodev->reset_gpio)) + return PTR_ERR(mdiodev->reset_gpio); + + if (mdiodev->reset_gpio) + gpiod_set_consumer_name(mdiodev->reset_gpio, "PHY reset"); + + reset =3D reset_control_get_optional_exclusive(&mdiodev->dev, "phy"); + if (IS_ERR(reset)) + return PTR_ERR(reset); + + mdiodev->reset_ctrl =3D reset; + + /* Assert the reset signal */ + mdio_device_reset(mdiodev, 1); + + return 0; +} +EXPORT_SYMBOL(mdio_device_register_reset); + +/** + * mdio_device_unregister_reset - uninitialize the reset properties of + * an mdio device + * @mdiodev: mdio_device structure + */ +void mdio_device_unregister_reset(struct mdio_device *mdiodev) +{ + gpiod_put(mdiodev->reset_gpio); + reset_control_put(mdiodev->reset_ctrl); +} +EXPORT_SYMBOL(mdio_device_unregister_reset); + /** * mdio_device_register - Register the mdio device on the MDIO bus * @mdiodev: mdio_device structure to be added to the MDIO bus diff --git a/include/linux/mdio.h b/include/linux/mdio.h index 42d6d47e4..d81b63fc7 100644 --- a/include/linux/mdio.h +++ b/include/linux/mdio.h @@ -90,6 +90,8 @@ static inline void *mdiodev_get_drvdata(struct mdio_devic= e *mdio) =20 void mdio_device_free(struct mdio_device *mdiodev); struct mdio_device *mdio_device_create(struct mii_bus *bus, int addr); +int mdio_device_register_reset(struct mdio_device *mdiodev); +void mdio_device_unregister_reset(struct mdio_device *mdiodev); int mdio_device_register(struct mdio_device *mdiodev); void mdio_device_remove(struct mdio_device *mdiodev); void mdio_device_reset(struct mdio_device *mdiodev, int value); --=20 2.39.5 From nobody Sat Feb 7 14:57:24 2026 Received: from fw2.prolan.hu (fw2.prolan.hu [193.68.50.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6011130F54C; Wed, 22 Oct 2025 09:09:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.68.50.107 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761124148; cv=none; b=mH3yiTA2aUqiqiogm27sHZpKCJbYbyYLzjPCk/T112EJbgrW6r3Z9oe404JHKChVNorGe5p5pGiQTcRxm5oT/x4Mcu1lU5TG48iUHorZURwrnFv5qilGWntJ0H1wq0DinfvYRQ86opoErcDiG3JUSaBDHhi3cx4d9OFhewIDZNQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761124148; c=relaxed/simple; bh=koZWgXQnn7LJHWsl2Nzqfl4WDuL8ilxpvvzc4qg4vxY=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=IdHcR+AnttEhBamgTmWvQhkB9nnPEGz3u12mxwZclOFDYnH6iFR0qBVgFd2qWAIgSpgnTOTvNjqkuUaZUy+D84IS48BXo6XO2xPnBiN5E+mv4qqj79bH6PObEep4YyZ8+SNH1YDVuzASEfmnhWvhrrVOz5iXmzTG2v9RUk9XMWk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=prolan.hu; spf=pass smtp.mailfrom=prolan.hu; dkim=pass (4096-bit key) header.d=prolan.hu header.i=@prolan.hu header.b=Dx0jM4j/; arc=none smtp.client-ip=193.68.50.107 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=prolan.hu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=prolan.hu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (4096-bit key) header.d=prolan.hu header.i=@prolan.hu header.b="Dx0jM4j/" Received: from proxmox-mailgw.intranet.prolan.hu (localhost.localdomain [127.0.0.1]) by proxmox-mailgw.intranet.prolan.hu (Proxmox) with ESMTP id 2AB9DA0AB4; Wed, 22 Oct 2025 11:08:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=prolan.hu; h=cc :cc:content-transfer-encoding:content-type:content-type:date :from:from:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=mail; bh=+lVcfQnH5Z5cT64ywzQO ZUW2kZQFOrzn08/uddow9Yg=; b=Dx0jM4j/Rrq9tvwIYVdhlUPGsLeBJoDXmfAg b0kMB+5tqm8PR1SY9ayHkuAO9ia7xfg1fRUe5zVMdFmvqes9ERrqmR2q5L7Sb/7c C2vf5kiRBkbI+JSiZ2J8y7UXbjZiwv4bLTBdrUsS2+y76XcyqLhA+leRFDi+si0J bLtzzs/D8RH/iQuvGaCGX0HPt/nnJtajCM931aEaF6gn4gMqynJnkLi1kCb+NDVB w3GKqt1zlLMHxPbHCWXxwhurly5hWhS1cmUw9JzAq4wlzg8ZSry+C3ZHwcBtW1ZS 2YDQE63+Vz3vS+GZxC5kTmQITdoHUyFdJlhJOHo4t39DKQiZYNlZSohKO3WWNzZU TTj0DEP34JQSs5wWVFANQnj6h59kaPbptRc8lIxQJLNyMCMwlEK3KXRi/86QxQX5 PV/j7vEhvhvpiKz7JhB2lA4K1CzkuFyG/UlTT8RKj5jfsft3M5IGZ3TEWmPHjwtY YYEyKrhKjUtzSvx+IkVtb08sqYlgYvco8GMatETzVVsB4HkV7AZiplSkKOxow7Mu tg9JyXar9r6fcvbKFFakS0sHCjeA/zlTmflOdSkLKqqH/9S+5478PgdLcCpOPVX9 udGBdZJkunXrSNzRPtNDt8w09tiTES8I6ufQsSpiHofz2EKAJBajdWWmmL9pq3vn dhH7zEw= From: Buday Csaba To: Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Philipp Zabel , , CC: Buday Csaba Subject: [PATCH net-next v4 2/4] net: mdio: change property read from fwnode_property_read_u32() to device_property_read_u32() Date: Wed, 22 Oct 2025 11:08:51 +0200 Message-ID: <41f1a73142c35a647944c13d73b8d770ccf20538.1761124022.git.buday.csaba@prolan.hu> X-Mailer: git-send-email 2.39.5 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ESET-AS: R=OK;S=0;OP=CALC;TIME=1761124136;VERSION=8000;MC=315264230;ID=130159;TRN=0;CRV=0;IPC=;SP=0;SIPS=0;PI=3;F=0 X-ESET-Antispam: OK X-EsetResult: clean, is OK X-EsetId: 37303A2998FD515F647D62 Content-Type: text/plain; charset="utf-8" Changed fwnode_property_read_u32() in mdio_device_register_reset() to device_property_read_u32(), which is more appropriate here. Signed-off-by: Buday Csaba --- V3 -> V4: unmodified V2 -> V3: unmodified V1 -> V2: added new patch based on maintainer request --- drivers/net/phy/mdio_device.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/phy/mdio_device.c b/drivers/net/phy/mdio_device.c index fb1cb7a26..5d39b25b7 100644 --- a/drivers/net/phy/mdio_device.c +++ b/drivers/net/phy/mdio_device.c @@ -86,9 +86,9 @@ int mdio_device_register_reset(struct mdio_device *mdiode= v) struct reset_control *reset; =20 /* Read optional firmware properties */ - fwnode_property_read_u32(dev_fwnode(&mdiodev->dev), "reset-assert-us", + device_property_read_u32(&mdiodev->dev, "reset-assert-us", &mdiodev->reset_assert_delay); - fwnode_property_read_u32(dev_fwnode(&mdiodev->dev), "reset-deassert-us", + device_property_read_u32(&mdiodev->dev, "reset-deassert-us", &mdiodev->reset_deassert_delay); =20 /* reset-gpio, bring up deasserted */ --=20 2.39.5 From nobody Sat Feb 7 14:57:24 2026 Received: from fw2.prolan.hu (fw2.prolan.hu [193.68.50.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 602113115A6; Wed, 22 Oct 2025 09:09:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.68.50.107 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761124148; cv=none; b=ugqj69JC8E79t4D8KoCkOlS6wiHkFPx5N4jlggF8WfAytvgPW4TkhIq95hcb9RiQ1txz3N0lEnE67d91nUKIwafVYlTXcn/Ju8DSiBmY38Z6PW1PaFrtGO6FqAxEb+NOAg3Aa8ubEBQONqWNIt/Li1wA5UKzb4rymGF85+qWMaI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761124148; c=relaxed/simple; bh=G2OOEo3rsfXSLJ4b3pmJVczmnz4uhk9lVRDIDwJIZCs=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Fr2KGBnTiNYK1nkvhv5W0t/e5mUz12HB2Ikn3Zff7SnEQlQ4DkWQgn7fvyd67h+mOQ01kH9FWBfDT8IEcJNlyYRxP8DxIp2AqoH3dsWR59EEnN6WO0Zy/U0AF1yaiEcip3/jwHFAPJJkP5XYxAQ/l1BC0fo7iOX5/WPiVR9qKQY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=prolan.hu; spf=pass smtp.mailfrom=prolan.hu; dkim=pass (4096-bit key) header.d=prolan.hu header.i=@prolan.hu header.b=ZSjOjKdv; arc=none smtp.client-ip=193.68.50.107 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=prolan.hu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=prolan.hu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (4096-bit key) header.d=prolan.hu header.i=@prolan.hu header.b="ZSjOjKdv" Received: from proxmox-mailgw.intranet.prolan.hu (localhost.localdomain [127.0.0.1]) by proxmox-mailgw.intranet.prolan.hu (Proxmox) with ESMTP id 4E84CA0255; Wed, 22 Oct 2025 11:08:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=prolan.hu; h=cc :cc:content-transfer-encoding:content-type:content-type:date :from:from:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=mail; bh=iYozPLyaUEmOmLcTWVsd K59TTR8u4rh5ZEbwwSdE814=; b=ZSjOjKdvU5YyfqhlGoq4OSTSGbZeQpphW0UR EgXGsLX2wYz6Spc/UeGIE6euX3OfZDmQcJESuypXEL8WCK+/R9okh8hOpYt6qPI9 r6JVzJYBGFOhni+84zmQLGSdOnFhltfDLIglErp8A+r/MCsIGLYmLI8Jf49Y5Y7f WWT1DxKB1eo9rZy9A7jU+vTT0IW/u/fByBlKrZTsWLTpon84OK2blnFMdJ9JtrQq SAZjyNrXzBpVKr0K0G+vYHOoKcR/S9DA2QGRe3iaGrEtgH5lTSPXpAyThYmhpKYx 9CQja60RjqtEfzb+I3Bjr1kD+IY9//ZQj+emnFTg4TZTM9xF5fKjrJYuR/kA7HN0 Ro34KyKbui7fR189TZhqhlpkfUVZPWzo9wt+jkFHNkcqxgBdVqVBEvaA+A/TCgWC fpAGDoY6KfE8EMG4+UzbhskMlqLVK6DzDa2QBoaxnsrnEGDwJbJZvu3uGITBHUvw xn7JwXRr5ff0UkHASwprmJ8xJy1xXBrJeeolLce1yQBTsmX22MxPHfiErJ+CR5Cq z1MAxDnvhSyCaiE0GIoBl3v7M/1l8E5NSdn/9XM+dv5ievrd8p3WuGnLwylv56Kk p7oEY/piBqlQkVroX1NX73qjhl6lmVd6zxvz0HPaZ7qUJIb41oXlGGdPUruzBfgO Mx03fd8= From: Buday Csaba To: Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Philipp Zabel , , CC: Buday Csaba Subject: [PATCH net-next v4 3/4] net: mdio: introduce mdio_device_has_reset() Date: Wed, 22 Oct 2025 11:08:52 +0200 Message-ID: X-Mailer: git-send-email 2.39.5 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ESET-AS: R=OK;S=0;OP=CALC;TIME=1761124136;VERSION=8000;MC=3312345989;ID=130160;TRN=0;CRV=0;IPC=;SP=0;SIPS=0;PI=3;F=0 X-ESET-Antispam: OK X-EsetResult: clean, is OK X-EsetId: 37303A2998FD515F647D62 Content-Type: text/plain; charset="utf-8" Introduced mdio_device_has_reset() to check if an MDIO device has any reset properties defined. Signed-off-by: Buday Csaba --- V3 -> V4: new commit --- drivers/net/phy/mdio_device.c | 13 +++++++++++++ include/linux/mdio.h | 1 + 2 files changed, 14 insertions(+) diff --git a/drivers/net/phy/mdio_device.c b/drivers/net/phy/mdio_device.c index 5d39b25b7..b1122bab8 100644 --- a/drivers/net/phy/mdio_device.c +++ b/drivers/net/phy/mdio_device.c @@ -170,6 +170,19 @@ void mdio_device_remove(struct mdio_device *mdiodev) } EXPORT_SYMBOL(mdio_device_remove); =20 +/** + * mdio_device_has_reset - Check if an MDIO device has reset properties de= fined + * @mdiodev: mdio_device structure + * + * Return: non-zero if the device has a reset GPIO or reset controller, + * zero otherwise. + */ +int mdio_device_has_reset(struct mdio_device *mdiodev) +{ + return (mdiodev->reset_gpio || mdiodev->reset_ctrl); +} +EXPORT_SYMBOL(mdio_device_has_reset); + void mdio_device_reset(struct mdio_device *mdiodev, int value) { unsigned int d; diff --git a/include/linux/mdio.h b/include/linux/mdio.h index d81b63fc7..83cfc051e 100644 --- a/include/linux/mdio.h +++ b/include/linux/mdio.h @@ -92,6 +92,7 @@ void mdio_device_free(struct mdio_device *mdiodev); struct mdio_device *mdio_device_create(struct mii_bus *bus, int addr); int mdio_device_register_reset(struct mdio_device *mdiodev); void mdio_device_unregister_reset(struct mdio_device *mdiodev); +int mdio_device_has_reset(struct mdio_device *mdiodev); int mdio_device_register(struct mdio_device *mdiodev); void mdio_device_remove(struct mdio_device *mdiodev); void mdio_device_reset(struct mdio_device *mdiodev, int value); --=20 2.39.5 From nobody Sat Feb 7 14:57:24 2026 Received: from fw2.prolan.hu (fw2.prolan.hu [193.68.50.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 601903112C0; Wed, 22 Oct 2025 09:09:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.68.50.107 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761124148; cv=none; b=W5wRv2BSCI2tMouY/ZAqzTt/AMN7pwbBASpVIADYluzzoMLJLsfUhRNuZubtb4e8jVDAxcc0NrB+r0YiAglMMenDSoJf7Fgggloa4sAvrb3fBm1PYOJBoMpuymyDbgZ1Tdswi2TjXPFmOMS1PQP1PNnt6K7S2Ww6BuaPZOcLTgM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761124148; c=relaxed/simple; bh=VcimyJ7/xW4JvjwglzTdwuqymBPHtHsRiVfiRusJ0k8=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=mNFiK9MwYOpwasBwYfzHUgdwhm37K+Q3khyoriFZhupgV3JLuhdjSI0NN2yeBtpukoqxNGHRc2WKZ4MYkX9b3ASgruXTwJ22Heuwys2kwqakU9H99vKupaTz5v2rGrVPCgt2LpkL/kby69id8CIC9QEKUlCNLKvfKEg1C1HCPGQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=prolan.hu; spf=pass smtp.mailfrom=prolan.hu; dkim=pass (4096-bit key) header.d=prolan.hu header.i=@prolan.hu header.b=oVF/FJ+0; arc=none smtp.client-ip=193.68.50.107 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=prolan.hu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=prolan.hu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (4096-bit key) header.d=prolan.hu header.i=@prolan.hu header.b="oVF/FJ+0" Received: from proxmox-mailgw.intranet.prolan.hu (localhost.localdomain [127.0.0.1]) by proxmox-mailgw.intranet.prolan.hu (Proxmox) with ESMTP id BFD64A09F6; Wed, 22 Oct 2025 11:08:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=prolan.hu; h=cc :cc:content-transfer-encoding:content-type:content-type:date :from:from:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=mail; bh=FV1+GYfuG3fm+jLpLTMq GoEYBia/ZfjgZeZsgAOghk4=; b=oVF/FJ+0ifnSbSJ6y/KbYUdP6IJ00LOLrwsQ T/rP3bY6+d7ey9TQ1u7JYa7z465XXFvc16sWaZKst7mR/URgq3pTdAjwBBk9sLx1 KL8yrICF8LiiFLB0OsZyPHc9VgvmaOs32WIU45m7F3dGShDrwkDY83c5x3K1ixxY 56Ma8AHO32oChIGo3RZwSAZReTI6wgEzxKwio0fVOHD/Dqha62aTwNnSKufB+M8b lHTUFejXGngtJ7oSjcSjsJuJL3wD1taB6a/LVGG734W3n8FsfQDByC0cIGzsklEq HHDpJzCvba75RRiQQ5MQE/WpcpjjrSl+bUhe3ut7DQtqe2HtQDKchAdJyPQFiLEG bqH8BTozS+1Lxb9RA1yN20Q9+djdWqc2CxUVN+BZScwe6FosI1SiyxDa2YxG0mMg C92Z6l5qrIEFoCPN66VA4TlKXNsumtAyho+NGa0s/ws/elX53XCX9UntrSnDnYlU NwmjR0tLGAl34AXmeylL4WdPEE9wytNGHtBEIpPoa8z1aaWEFDFdQf0W5PnT0XhO WVMyLIx1E21N44I5Au4f5ZGvKZvbtA9RZ2E59PtQEQjg7yqFGrXD6bCZjYIKoxmC f0AkPQNpnaHQfT+R0A3ayKsmdJRKuX98SCUNmAYlRlbmQnnpt1Vll6aWYITMtbfU JuOwPPM= From: Buday Csaba To: Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Philipp Zabel , , CC: Buday Csaba Subject: [PATCH net-next v4 4/4] net: mdio: reset PHY before attempting to access registers in fwnode_mdiobus_register_phy Date: Wed, 22 Oct 2025 11:08:53 +0200 Message-ID: X-Mailer: git-send-email 2.39.5 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ESET-AS: R=OK;S=0;OP=CALC;TIME=1761124136;VERSION=8000;MC=2911013999;ID=130161;TRN=0;CRV=0;IPC=;SP=0;SIPS=0;PI=3;F=0 X-ESET-Antispam: OK X-EsetResult: clean, is OK X-EsetId: 37303A2998FD515F647D62 Content-Type: text/plain; charset="utf-8" When the ID of an Ethernet PHY is not provided by the 'compatible' string in the device tree, its actual ID is read via the MDIO bus. For some PHYs this could be unsafe, since a hard reset may be necessary to safely access the MDIO registers. This patch adds a fallback mechanism for these devices: when reading the ID fails, the reset will be asserted, and the ID read is retried. When the reset is asserted, an info level message is printed. Signed-off-by: Buday Csaba --- V3 -> V4: dropped DT property `phy-id-read-needs-reset` to control the reset behaviour, asserting reset as a fallback mechanism instead. Added info level message for resetting. V2 -> V3: kernel-doc replaced with a comment (fixed warning) V1 -> V2: - renamed fwnode_reset_phy_before_probe() to fwnode_reset_phy() - added kernel-doc for fwnode_reset_phy() - improved error handling in fwnode_reset_phy() --- drivers/net/mdio/fwnode_mdio.c | 41 +++++++++++++++++++++++++++++++++- 1 file changed, 40 insertions(+), 1 deletion(-) diff --git a/drivers/net/mdio/fwnode_mdio.c b/drivers/net/mdio/fwnode_mdio.c index ba7091518..623120e3b 100644 --- a/drivers/net/mdio/fwnode_mdio.c +++ b/drivers/net/mdio/fwnode_mdio.c @@ -114,6 +114,40 @@ int fwnode_mdiobus_phy_device_register(struct mii_bus = *mdio, } EXPORT_SYMBOL(fwnode_mdiobus_phy_device_register); =20 +/* Hard-reset a PHY before registration */ +static int fwnode_reset_phy(struct mii_bus *bus, u32 addr, + struct fwnode_handle *phy_node) +{ + struct mdio_device *tmpdev; + int err; + + tmpdev =3D mdio_device_create(bus, addr); + if (IS_ERR(tmpdev)) + return PTR_ERR(tmpdev); + + fwnode_handle_get(phy_node); + device_set_node(&tmpdev->dev, phy_node); + err =3D mdio_device_register_reset(tmpdev); + if (err) { + mdio_device_free(tmpdev); + return err; + } + + if (mdio_device_has_reset(tmpdev)) { + dev_info(&bus->dev, + "PHY device at address %d not detected, resetting PHY.", + addr); + mdio_device_reset(tmpdev, 1); + mdio_device_reset(tmpdev, 0); + } + + mdio_device_unregister_reset(tmpdev); + mdio_device_free(tmpdev); + fwnode_handle_put(phy_node); + + return 0; +} + int fwnode_mdiobus_register_phy(struct mii_bus *bus, struct fwnode_handle *child, u32 addr) { @@ -129,8 +163,13 @@ int fwnode_mdiobus_register_phy(struct mii_bus *bus, return PTR_ERR(mii_ts); =20 is_c45 =3D fwnode_device_is_compatible(child, "ethernet-phy-ieee802.3-c45= "); - if (is_c45 || fwnode_get_phy_id(child, &phy_id)) + if (is_c45 || fwnode_get_phy_id(child, &phy_id)) { phy =3D get_phy_device(bus, addr, is_c45); + if (IS_ERR(phy)) { + fwnode_reset_phy(bus, addr, child); + phy =3D get_phy_device(bus, addr, is_c45); + } + } else phy =3D phy_device_create(bus, addr, phy_id, 0, NULL); if (IS_ERR(phy)) { --=20 2.39.5