From nobody Sun Feb 8 05:27:49 2026 Received: from fw2.prolan.hu (fw2.prolan.hu [193.68.50.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6F9CC277C9B; Fri, 17 Oct 2025 16:10:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.68.50.107 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760717424; cv=none; b=cMEt4Pr3SodckzpaRk6Mma0mE+mg5j2n/mEaqgSI9yTHhilorEjIDoF+RXigpuM7Lvxd0WA5Edw3s+ick9dd9/1hHnSbbxuym/oQ25dJIrv7VFSMIyhRPqsBmYp3hsyLCdzB624dZiDUm5zXqGwcmmlr+gIEfctPpvxli7EYGSI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760717424; c=relaxed/simple; bh=7QR8AU/m7DPl6r2PrXMtOiPfQZs8Z9/LicnwMliQpCg=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Qw1lg8WZUsKF4wl3FJGxkMXSKxTCUuj8ekcYVzrs/ViIQpAAowNepS0GD6gpy2e3VT+/9cyEcERi+gx381AQMxvwor0mEH4Ii3pCOIqsH+9MqQBXEXsSwikJGo2WWRoIphKCgPtZmVJeRd76HwNCoyFd5/RS6ng+ZvslGftDlLE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=prolan.hu; spf=pass smtp.mailfrom=prolan.hu; dkim=pass (4096-bit key) header.d=prolan.hu header.i=@prolan.hu header.b=JdgHh2vI; arc=none smtp.client-ip=193.68.50.107 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=prolan.hu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=prolan.hu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (4096-bit key) header.d=prolan.hu header.i=@prolan.hu header.b="JdgHh2vI" Received: from proxmox-mailgw.intranet.prolan.hu (localhost.localdomain [127.0.0.1]) by proxmox-mailgw.intranet.prolan.hu (Proxmox) with ESMTP id C4621A1ACB; Fri, 17 Oct 2025 18:10:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=prolan.hu; h=cc :cc:content-transfer-encoding:content-type:content-type:date :from:from:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=mail; bh=qUKLXm1HJKsNZWHiLZ/7 UZmcamu/LCklRmckKC9Wl/o=; b=JdgHh2vIZHZqgZuR6TOA8EwURSz79luKlsF3 MQ+kYPWP6LCNgP3Q40iZHh2pV+XgS0b5+UkLL9g5jg/4w8BKXa13naIjojdZeDK8 hMJedDLRs28CcctftxWp6qex4D9X9bpDkEeej5PhZtTFzVtvmhFZRCpx+VgjKpSQ qvWEK9tTdI67r2gn0WfhS16ytTSyya/TFa/G+0ApRDcXve2ZR7eIEtcPVtEq6sye lHgGm2QOzBoHf0zvRCz4zJZidw5G2kCW1QQ0Ir31BAs2hXAG68ScvupcHB5e2brx Bo9cjopeH7xW8sAPzTll7eMJosq8d6ElBCGeaCc0g0HdnuhCamEDmE09rj7/Susr iCqfugJWL6iWlE6mOElAPiG5yOLChPVJ+aD1C+9zEEXScjBzkav16Eku3dj5pObg hRDX5yzph1iMRtFYr042sTZ9uLoBW0A+c0SmH+4Hp3PfHENo7nkPWQCehL2wZp8T 2ji6JcTrd4I6efeiJkRQSWtolwzKn113UeFh6cgSvqQKVWfj4MGw9sQFcF2Uf05z s4H+3nZrAF9r562+nmWS/thhT6h4mV7ja+ybsUP76rkA5Bwniwqf0ddGbBBeo7m7 XVL7Oo26PD+BwjqGTn4mSdbjzUZEzunRaod5ITaIgs1OLM7sNB6Vc3zSUF4hskVC ATW7aEk= From: Buday Csaba To: Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , "Florian Fainelli" , , , CC: Buday Csaba Subject: [PATCH net-next v3 1/4] net: mdio: common handling of phy reset properties Date: Fri, 17 Oct 2025 18:10:08 +0200 Message-ID: X-Mailer: git-send-email 2.39.5 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ESET-AS: R=OK;S=0;OP=CALC;TIME=1760717418;VERSION=8000;MC=436976404;ID=38907;TRN=0;CRV=0;IPC=;SP=0;SIPS=0;PI=3;F=0 X-ESET-Antispam: OK X-EsetResult: clean, is OK X-EsetId: 37303A2998FD515F647660 Content-Type: text/plain; charset="utf-8" Reset properties of an `mdio_device` are initialized in multiple source files and multiple functions: - `reset_assert_delay` and `reset_deassert_delay` are in fwnode_mdio.c - `reset_gpio` and `reset_ctrl` are in mdio_bus.c, but handled by different functions This patch unifies the handling of all these properties into two functions. mdiobus_register_gpiod() and mdiobus_register_reset() are removed, while mdio_device_register_reset() and mdio_device_unregister_reset() are introduced instead. These functions handle both reset-controllers and reset-gpios, and also read the corresponding properties from the device tree. These changes should make tracking the reset properties easier. The reset logic is unaltered, and should work as it did before. Signed-off-by: Buday Csaba --- V2 -> V3: fixed kernel-doc warnings V1 -> V2: the return value of mdio_device_unregister_reset() is made void --- drivers/net/mdio/fwnode_mdio.c | 5 ---- drivers/net/phy/mdio_bus.c | 39 ++----------------------- drivers/net/phy/mdio_device.c | 52 ++++++++++++++++++++++++++++++++++ include/linux/mdio.h | 2 ++ 4 files changed, 56 insertions(+), 42 deletions(-) diff --git a/drivers/net/mdio/fwnode_mdio.c b/drivers/net/mdio/fwnode_mdio.c index 9b41d4697..ba7091518 100644 --- a/drivers/net/mdio/fwnode_mdio.c +++ b/drivers/net/mdio/fwnode_mdio.c @@ -92,11 +92,6 @@ int fwnode_mdiobus_phy_device_register(struct mii_bus *m= dio, if (fwnode_property_read_bool(child, "broken-turn-around")) mdio->phy_ignore_ta_mask |=3D 1 << addr; =20 - fwnode_property_read_u32(child, "reset-assert-us", - &phy->mdio.reset_assert_delay); - fwnode_property_read_u32(child, "reset-deassert-us", - &phy->mdio.reset_deassert_delay); - /* Associate the fwnode with the device structure so it * can be looked up later */ diff --git a/drivers/net/phy/mdio_bus.c b/drivers/net/phy/mdio_bus.c index cad6ed3aa..cc3f9cfb1 100644 --- a/drivers/net/phy/mdio_bus.c +++ b/drivers/net/phy/mdio_bus.c @@ -33,33 +33,6 @@ #define CREATE_TRACE_POINTS #include =20 -static int mdiobus_register_gpiod(struct mdio_device *mdiodev) -{ - /* Deassert the optional reset signal */ - mdiodev->reset_gpio =3D gpiod_get_optional(&mdiodev->dev, - "reset", GPIOD_OUT_LOW); - if (IS_ERR(mdiodev->reset_gpio)) - return PTR_ERR(mdiodev->reset_gpio); - - if (mdiodev->reset_gpio) - gpiod_set_consumer_name(mdiodev->reset_gpio, "PHY reset"); - - return 0; -} - -static int mdiobus_register_reset(struct mdio_device *mdiodev) -{ - struct reset_control *reset; - - reset =3D reset_control_get_optional_exclusive(&mdiodev->dev, "phy"); - if (IS_ERR(reset)) - return PTR_ERR(reset); - - mdiodev->reset_ctrl =3D reset; - - return 0; -} - int mdiobus_register_device(struct mdio_device *mdiodev) { int err; @@ -68,16 +41,9 @@ int mdiobus_register_device(struct mdio_device *mdiodev) return -EBUSY; =20 if (mdiodev->flags & MDIO_DEVICE_FLAG_PHY) { - err =3D mdiobus_register_gpiod(mdiodev); + err =3D mdio_device_register_reset(mdiodev); if (err) return err; - - err =3D mdiobus_register_reset(mdiodev); - if (err) - return err; - - /* Assert the reset signal */ - mdio_device_reset(mdiodev, 1); } =20 mdiodev->bus->mdio_map[mdiodev->addr] =3D mdiodev; @@ -91,8 +57,7 @@ int mdiobus_unregister_device(struct mdio_device *mdiodev) if (mdiodev->bus->mdio_map[mdiodev->addr] !=3D mdiodev) return -EINVAL; =20 - gpiod_put(mdiodev->reset_gpio); - reset_control_put(mdiodev->reset_ctrl); + mdio_device_unregister_reset(mdiodev); =20 mdiodev->bus->mdio_map[mdiodev->addr] =3D NULL; =20 diff --git a/drivers/net/phy/mdio_device.c b/drivers/net/phy/mdio_device.c index f64176e0e..fb1cb7a26 100644 --- a/drivers/net/phy/mdio_device.c +++ b/drivers/net/phy/mdio_device.c @@ -74,6 +74,58 @@ struct mdio_device *mdio_device_create(struct mii_bus *b= us, int addr) } EXPORT_SYMBOL(mdio_device_create); =20 +/** + * mdio_device_register_reset - Read and initialize the reset properties of + * an mdio device + * @mdiodev: mdio_device structure + * + * Return: Zero if successful, negative error code on failure + */ +int mdio_device_register_reset(struct mdio_device *mdiodev) +{ + struct reset_control *reset; + + /* Read optional firmware properties */ + fwnode_property_read_u32(dev_fwnode(&mdiodev->dev), "reset-assert-us", + &mdiodev->reset_assert_delay); + fwnode_property_read_u32(dev_fwnode(&mdiodev->dev), "reset-deassert-us", + &mdiodev->reset_deassert_delay); + + /* reset-gpio, bring up deasserted */ + mdiodev->reset_gpio =3D gpiod_get_optional(&mdiodev->dev, "reset", + GPIOD_OUT_LOW); + + if (IS_ERR(mdiodev->reset_gpio)) + return PTR_ERR(mdiodev->reset_gpio); + + if (mdiodev->reset_gpio) + gpiod_set_consumer_name(mdiodev->reset_gpio, "PHY reset"); + + reset =3D reset_control_get_optional_exclusive(&mdiodev->dev, "phy"); + if (IS_ERR(reset)) + return PTR_ERR(reset); + + mdiodev->reset_ctrl =3D reset; + + /* Assert the reset signal */ + mdio_device_reset(mdiodev, 1); + + return 0; +} +EXPORT_SYMBOL(mdio_device_register_reset); + +/** + * mdio_device_unregister_reset - uninitialize the reset properties of + * an mdio device + * @mdiodev: mdio_device structure + */ +void mdio_device_unregister_reset(struct mdio_device *mdiodev) +{ + gpiod_put(mdiodev->reset_gpio); + reset_control_put(mdiodev->reset_ctrl); +} +EXPORT_SYMBOL(mdio_device_unregister_reset); + /** * mdio_device_register - Register the mdio device on the MDIO bus * @mdiodev: mdio_device structure to be added to the MDIO bus diff --git a/include/linux/mdio.h b/include/linux/mdio.h index 42d6d47e4..d81b63fc7 100644 --- a/include/linux/mdio.h +++ b/include/linux/mdio.h @@ -90,6 +90,8 @@ static inline void *mdiodev_get_drvdata(struct mdio_devic= e *mdio) =20 void mdio_device_free(struct mdio_device *mdiodev); struct mdio_device *mdio_device_create(struct mii_bus *bus, int addr); +int mdio_device_register_reset(struct mdio_device *mdiodev); +void mdio_device_unregister_reset(struct mdio_device *mdiodev); int mdio_device_register(struct mdio_device *mdiodev); void mdio_device_remove(struct mdio_device *mdiodev); void mdio_device_reset(struct mdio_device *mdiodev, int value); --=20 2.39.5 From nobody Sun Feb 8 05:27:49 2026 Received: from fw2.prolan.hu (fw2.prolan.hu [193.68.50.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 19EB922FE0E; Fri, 17 Oct 2025 16:10:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.68.50.107 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760717424; cv=none; b=OT8fSHRkZ969ZPfh8ABurA3Qe/X9VdRMpbtsZowDI7CqU5bkOCgWM30bvo1bTgNKwTQkqr4Bd81tYobjNKw1C3KG0GmS7jbX7cEosxLrNpURWCsGoKxC4nfKnU6tEkvAY124a6LZzTBdskZcYbBZBjiSNp67jS63Y9YhK9fj0qE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760717424; c=relaxed/simple; bh=KVqa/PFGYmekcnwV/90RWGTpdgdm2rij1l5slU3qP48=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=E5vT0EwnQeaRkg0hESRuZcdI6LzkXgHedoUQjDoz2p9aG/WL0YPLlPHe2KieKWkddRPOcfuhGy1Db8lkLcsvpHtY5mlI7itqM4PwNGufjKvGUEKXznlFLPkrmKPdxTiWwcQxLPh82doKYEy7f9/g1pDMbNO0sMjPEwp2C66uR5k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=prolan.hu; spf=pass smtp.mailfrom=prolan.hu; dkim=pass (4096-bit key) header.d=prolan.hu header.i=@prolan.hu header.b=j0kfcSXG; arc=none smtp.client-ip=193.68.50.107 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=prolan.hu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=prolan.hu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (4096-bit key) header.d=prolan.hu header.i=@prolan.hu header.b="j0kfcSXG" Received: from proxmox-mailgw.intranet.prolan.hu (localhost.localdomain [127.0.0.1]) by proxmox-mailgw.intranet.prolan.hu (Proxmox) with ESMTP id 83AEDA0D06; Fri, 17 Oct 2025 18:10:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=prolan.hu; h=cc :cc:content-transfer-encoding:content-type:content-type:date :from:from:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=mail; bh=4NcY+aTFoRxO6/dGokU9 2XJTVNbCE5Phu+eGQdO1K9w=; b=j0kfcSXGI50mpT2KaAVdgXOSs0y6ZgsA0RcP pcb2svuffnTT1xDbK12CAhDeRGZWs9Y5uSyJf6ZS6f9xoDuw/t+twtGRBkFiFjsN V4JhjIZDl3K/YiVLnxjoNfZYhIEClGs92fbmUPU8gZWxK/OZL5hDRANdbbUyQl19 vZu6p8Rb5Cuc0uRIJfPF78MbGnNC2wwEt5jWX4JY2TvE/e+xVPnzCp15ic9smnQo Q97thxN4z0vddJtmHphfWZBObOUClxYmQszkjRlgXNUJJ+DgnT6u+YSBYrvOYBTh hBe2t4k2UM3MHOkCpj3meRkL1p4QPMHX8txBkF7nZdU8mAT6tWS3OMmALURe3cWy Do4ZyRA8zxMCXTkfvjZnUpIoPVO6cpeUT8Jis+HyAuGEozXb9/HmJbi1V/5DOnRh tWRNn2RuOfTlBAKONtXPLz8VbA23HX/egp4FlHCbrtxA36rsWapsJ5IqKUu/apgk o5MwTWlSr3d7W1zfSaLgBJRG1LEzhUSvfiNhwgkl4g8Rx0SQmSZ2BOKkjW4aaZIq fxamQSYN2Mpmc0H1yznFHkUPUa5AR0mrQecCFGz3K+KvjKev+OKajk3WV9Nn5QKa Du4CmHcmitdJBcyXFgmV/u0nFCYGYtobWiLetWjwBkmphCqXml9ZLCHZqIrpDZYe SwvaeaA= From: Buday Csaba To: Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , "Florian Fainelli" , , , CC: Buday Csaba Subject: [PATCH net-next v3 2/4] net: mdio: change property read from fwnode_property_read_u32() to device_property_read_u32() Date: Fri, 17 Oct 2025 18:10:09 +0200 Message-ID: <2fea0c340e7ac9aa10c03c46a2d3169ee45c7f68.1760620093.git.buday.csaba@prolan.hu> X-Mailer: git-send-email 2.39.5 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ESET-AS: R=OK;S=0;OP=CALC;TIME=1760717418;VERSION=8000;MC=4080044216;ID=38908;TRN=0;CRV=0;IPC=;SP=0;SIPS=0;PI=3;F=0 X-ESET-Antispam: OK X-EsetResult: clean, is OK X-EsetId: 37303A2998FD515F647660 Content-Type: text/plain; charset="utf-8" Changed fwnode_property_read_u32() in mdio_device_register_reset() to device_property_read_u32(), which is more appropriate here. Signed-off-by: Buday Csaba --- V2 -> V3: unmodified V1 -> V2: added new patch based on maintainer request --- drivers/net/phy/mdio_device.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/phy/mdio_device.c b/drivers/net/phy/mdio_device.c index fb1cb7a26..5d39b25b7 100644 --- a/drivers/net/phy/mdio_device.c +++ b/drivers/net/phy/mdio_device.c @@ -86,9 +86,9 @@ int mdio_device_register_reset(struct mdio_device *mdiode= v) struct reset_control *reset; =20 /* Read optional firmware properties */ - fwnode_property_read_u32(dev_fwnode(&mdiodev->dev), "reset-assert-us", + device_property_read_u32(&mdiodev->dev, "reset-assert-us", &mdiodev->reset_assert_delay); - fwnode_property_read_u32(dev_fwnode(&mdiodev->dev), "reset-deassert-us", + device_property_read_u32(&mdiodev->dev, "reset-deassert-us", &mdiodev->reset_deassert_delay); =20 /* reset-gpio, bring up deasserted */ --=20 2.39.5 From nobody Sun Feb 8 05:27:49 2026 Received: from fw2.prolan.hu (fw2.prolan.hu [193.68.50.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D2D3C27991E; Fri, 17 Oct 2025 16:10:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.68.50.107 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760717425; cv=none; b=WMxKZD9LqU0azCNlKUJZPfRyxr7cmeHI+4gvwfRHnnX/QZksy6NiaQkuxAiwLow0WGeBlTjL5UaU0jKWYuFKcmduYHd8GFrLzFYClaaqWjnUGOtHQDNydLK0AfXnmu6YRE4KxA1KsBxYd0H4KWHiLSECnn83aeJfe+Bb/OdryOA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760717425; c=relaxed/simple; bh=WVFG1HB0OoVx50SdIrecnXIPPRMeTYjaW9uCQsgV6MU=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=vFl2f7q4Jc76GV0aE6DYZ795ka/NlJZaVneGloaqsv9Z7V11T1rXyMcAXzALNqYlbqvD0TNlF590e3cev54U5nGjQItXP8bKv9cpNsRSFBuHjFEMktXGNo3d5LXdc2DR2jwwAI+kt19ycLneY6LOg96ZNLNGfCku710hte9wHOo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=prolan.hu; spf=pass smtp.mailfrom=prolan.hu; dkim=pass (4096-bit key) header.d=prolan.hu header.i=@prolan.hu header.b=svkbTNq+; arc=none smtp.client-ip=193.68.50.107 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=prolan.hu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=prolan.hu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (4096-bit key) header.d=prolan.hu header.i=@prolan.hu header.b="svkbTNq+" Received: from proxmox-mailgw.intranet.prolan.hu (localhost.localdomain [127.0.0.1]) by proxmox-mailgw.intranet.prolan.hu (Proxmox) with ESMTP id 09B0CA1BFE; Fri, 17 Oct 2025 18:10:20 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=prolan.hu; h=cc :cc:content-transfer-encoding:content-type:content-type:date :from:from:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=mail; bh=X7n7lgHq7CaDRpNdI4PF ag9rzyzV0sMHG3RoqhvXd1U=; b=svkbTNq+nUmQb4Ut5QR8k5/97q5xrh3PFG0B +UPizkvlMAAFqYusAmUFq94zht9CztiBEmnebt/0mzEhqGlBy5yzlAAAHxBaWmOu mZvCDc+j4yKfN2KEMiUugIlNJczk3wfCh7scoD9ZWIi47vCkH6LuvtMRmuEDhxIF bCzGabY+q0TMHrDvdXCT5alV1MEdPc6+uWlOJ7+RzYKFkSphzOpWWezMIMDokSTy Z2FhwpyKirNgXbHmtWoYxYRNQ0obA3lobNAxqq0dRB2BXuWQ6a3C2y+Uav7CyzI/ fNkBHwZPFnkQNnXc0xseyC26fEKnaxXs7HlD0fnbFPe7SypGH14BqSo0FMH/e39w sxkM596jCbJ+73FQgqIvFjHN/nf530fPpCc1nLv2xIM2E1yFOTZRzK786IEZkpEh D6ILwVkBg9rWQxxUO+Bufkkw/1t4LXZA7sm5LVBdVwu+l83I20SFGV9YpRwzAthI QxTBK6QrxYGQIamM9Blav2dpX6QTO9za0nMEZxDTT9WGECzNL2NsFgCElnTNwU6x rKhNHxl0yP49Bj3rq3NlxP78872t4osWvwQPNp2FzeCX2e42410MuCCERGA2dD0M WLaaviTsagEzORki8cv1TOSONDL66PH2r5C4OowsTHAYf7JJxx4+SFULzIHGPWWx vFIiKjs= From: Buday Csaba To: Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , "Florian Fainelli" , , , CC: Buday Csaba Subject: [PATCH net-next v3 3/4] dt-bindings: net: mdio: add phy-id-read-needs-reset property Date: Fri, 17 Oct 2025 18:10:10 +0200 Message-ID: <3a93b87f2bf7ea87c1251d2360e11e710772dd92.1760620093.git.buday.csaba@prolan.hu> X-Mailer: git-send-email 2.39.5 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ESET-AS: R=OK;S=0;OP=CALC;TIME=1760717418;VERSION=8000;MC=329064332;ID=38909;TRN=0;CRV=0;IPC=;SP=0;SIPS=0;PI=3;F=0 X-ESET-Antispam: OK X-EsetResult: clean, is OK X-EsetId: 37303A2998FD515F647660 Content-Type: text/plain; charset="utf-8" Some Ethernet PHYs require a hard reset before accessing their MDIO registers. When the ID is not provided by a compatible string, reading the PHY ID may fail on such devices. This patch introduces a new device tree property called `phy-id-read-needs-reset`, which can be used to hard reset the PHY before attempting to read its ID via MDIO. Signed-off-by: Buday Csaba --- V2 -> V3: unchanged V1 -> V2: added this DT binding --- Documentation/devicetree/bindings/net/ethernet-phy.yaml | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/Documentation/devicetree/bindings/net/ethernet-phy.yaml b/Docu= mentation/devicetree/bindings/net/ethernet-phy.yaml index 2ec2d9fda..b570f8038 100644 --- a/Documentation/devicetree/bindings/net/ethernet-phy.yaml +++ b/Documentation/devicetree/bindings/net/ethernet-phy.yaml @@ -215,6 +215,14 @@ properties: Delay after the reset was deasserted in microseconds. If this property is missing the delay will be skipped. =20 + phy-id-read-needs-reset: + $ref: /schemas/types.yaml#/definitions/flag + description: + Some PHYs require a hard reset before accessing MDIO registers. + This workaround allows auto-detection of the PHY ID in such cases. + When the PHY ID is provided with the 'compatible' string, setting + this property has no effect. + sfp: $ref: /schemas/types.yaml#/definitions/phandle description: --=20 2.39.5 From nobody Sun Feb 8 05:27:49 2026 Received: from fw2.prolan.hu (fw2.prolan.hu [193.68.50.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6F95E2777E0; Fri, 17 Oct 2025 16:10:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.68.50.107 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760717425; cv=none; b=mHrkT5ZYyWE3N79erz2PaiXhsf5T2eMcd+k6BRbNtor/DmIcXFGCYjMDu4yalwc/1UIrsAIrDlGgb8WbJq/l+JTrHEJ/1g42sNhR8YKEhwwOu/rtJ40kfUChs5LVG9qnwDfUre5ZWCkVikMzlp8NL8yFx4TJo0LBQ3D45i7Iaus= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760717425; c=relaxed/simple; bh=g413N2EtaCoE+cYgVBHxXA81wiQqN+EXKGi0nWOzH4o=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=UzFNNcgxN/1NCRI87fpbLbGg/Ta21086BINRlCzBFgf0H9vzD3jLfhfw/seCOq7/LyTPviVyeJR4h0p+xuZaD/C5sZv/mymdz9jm1plPZ0iGkyEZ7xLkn4o4q05a4d6afpJrkzPgXrV0QRrjKWjgmbJJMLDDQ/gJF1jp7PkgV20= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=prolan.hu; spf=pass smtp.mailfrom=prolan.hu; dkim=pass (4096-bit key) header.d=prolan.hu header.i=@prolan.hu header.b=om70ofu3; arc=none smtp.client-ip=193.68.50.107 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=prolan.hu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=prolan.hu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (4096-bit key) header.d=prolan.hu header.i=@prolan.hu header.b="om70ofu3" Received: from proxmox-mailgw.intranet.prolan.hu (localhost.localdomain [127.0.0.1]) by proxmox-mailgw.intranet.prolan.hu (Proxmox) with ESMTP id ED31AA0A26; Fri, 17 Oct 2025 18:10:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=prolan.hu; h=cc :cc:content-transfer-encoding:content-type:content-type:date :from:from:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=mail; bh=mIQwReTUSM4NJP0VNgJN 29BzTbzQt8jrZ9Cb25wJHqw=; b=om70ofu3asdgwp07pI8ZHK3fnEnGCc/4dhu8 k1/PIuGbctoZ2lfMU7v+7YrzMdrceUA6cnRaAuzULsb8bQVvqtpkU6yzbvFDmv+I b1qCWFVENgAUMWFguRQq7y6JyDDAaAQ4tXmzqjdLF7URY8wlVroXEV17APUQXuTj nUtweVfNHqiQbPg/KM0+Xz8sa7+k8JRiwaHEOP5fEWgC4D+WTlDUNIiGiwP8NE10 Zbxiy8XYxg3OQMEFn4qgbBVkiWNhL8gd5Zu0cIGF9b+9r5vRVHDt9rZmCgTj8zQm km8UuTOr1LXnBlCmQ2mNeGih6+ZysGN2+NPntDYjIsIBYnayUxL5l3rK4VBiieB2 UuWEGbbDoqfyRRJZVZO+Q/Vd2wTJmJQiJpydw8pmvY4y/3Tn4NQOfbfAvNj9JCZN 7kWeIP9fIbdFyWR8WEnjlGd/NAtQJBcUBAz6L80hfJdV3mk8fkFY+fhw4dWf+fxp /r0zN1Ui21n0CJlOP4J3ZTpzjNETvDc4lnGJtrpJgbMwsvtKZrxu8uqivCB+Wd05 Plf8dgLRev2OjlU/GV0ztrgQsVh81B7J+glLjE9NV7jvJ6/dXF+uakA2S6Ay2F/j BzQaA+X52yoV/yBg4CXiHq1FQR/q5M0+pUW3vgCMWYdcdNvbIrFk1qdXNpUqDL+0 QJt21mM= From: Buday Csaba To: Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , "Florian Fainelli" , , , CC: Buday Csaba Subject: [PATCH net-next v3 4/4] net: mdio: reset PHY before attempting to access registers in fwnode_mdiobus_register_phy Date: Fri, 17 Oct 2025 18:10:11 +0200 Message-ID: X-Mailer: git-send-email 2.39.5 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ESET-AS: R=OK;S=0;OP=CALC;TIME=1760717419;VERSION=8000;MC=3822495923;ID=62086;TRN=0;CRV=0;IPC=;SP=0;SIPS=0;PI=3;F=0 X-ESET-Antispam: OK X-EsetResult: clean, is OK X-EsetId: 37303A296767155F647660 Content-Type: text/plain; charset="utf-8" Implement support for the `phy-id-read-needs-reset` device tree property. When the ID of an ethernet PHY is not provided by the 'compatible' string in the device tree, its actual ID is read via the MDIO bus. For some PHYs this could be unsafe, since a hard reset may be necessary to safely access the MDIO registers. This patch performs the hard-reset before attempting to read the ID, when the mentioned device tree property is present. Signed-off-by: Buday Csaba --- V2 -> V3: kernel-doc replaced with a comment (fixed warning) V1 -> V2: - renamed DT property `reset-phy-before-probe` to `phy-id-read-needs-reset` - renamed fwnode_reset_phy_before_probe() to fwnode_reset_phy() - added kernel-doc for fwnode_reset_phy() - improved error handling in fwnode_reset_phy() --- drivers/net/mdio/fwnode_mdio.c | 35 +++++++++++++++++++++++++++++++++- 1 file changed, 34 insertions(+), 1 deletion(-) diff --git a/drivers/net/mdio/fwnode_mdio.c b/drivers/net/mdio/fwnode_mdio.c index ba7091518..8e8f9182a 100644 --- a/drivers/net/mdio/fwnode_mdio.c +++ b/drivers/net/mdio/fwnode_mdio.c @@ -114,6 +114,36 @@ int fwnode_mdiobus_phy_device_register(struct mii_bus = *mdio, } EXPORT_SYMBOL(fwnode_mdiobus_phy_device_register); =20 +/* Hard-reset a PHY before registration */ +static int fwnode_reset_phy(struct mii_bus *bus, u32 addr, + struct fwnode_handle *phy_node) +{ + struct mdio_device *tmpdev; + int err; + + tmpdev =3D mdio_device_create(bus, addr); + if (IS_ERR(tmpdev)) + return PTR_ERR(tmpdev); + + fwnode_handle_get(phy_node); + device_set_node(&tmpdev->dev, phy_node); + err =3D mdio_device_register_reset(tmpdev); + if (err) { + mdio_device_free(tmpdev); + return err; + } + + mdio_device_reset(tmpdev, 1); + mdio_device_reset(tmpdev, 0); + + mdio_device_unregister_reset(tmpdev); + + mdio_device_free(tmpdev); + fwnode_handle_put(phy_node); + + return 0; +} + int fwnode_mdiobus_register_phy(struct mii_bus *bus, struct fwnode_handle *child, u32 addr) { @@ -129,8 +159,11 @@ int fwnode_mdiobus_register_phy(struct mii_bus *bus, return PTR_ERR(mii_ts); =20 is_c45 =3D fwnode_device_is_compatible(child, "ethernet-phy-ieee802.3-c45= "); - if (is_c45 || fwnode_get_phy_id(child, &phy_id)) + if (is_c45 || fwnode_get_phy_id(child, &phy_id)) { + if (fwnode_property_present(child, "reset-phy-before-probe")) + fwnode_reset_phy(bus, addr, child); phy =3D get_phy_device(bus, addr, is_c45); + } else phy =3D phy_device_create(bus, addr, phy_id, 0, NULL); if (IS_ERR(phy)) { --=20 2.39.5