From nobody Wed Feb 11 03:42:00 2026 Received: from mail-lj1-f173.google.com (mail-lj1-f173.google.com [209.85.208.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 815692DA749 for ; Tue, 7 Oct 2025 08:33:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759825986; cv=none; b=IdB5bKkCwZcX9xYT8vl1pUp2jxP6GUMqAQQyo6dNXcshZTK8nz3DcF3KxNod++IxnPeg5x2FPVGozpwCmymF2QVwSEHAIm5arcprjwR339OIqTUohbkZHWKQahYaotMMtoF8YJ/QkKlAlGvDoqufRMkB9bURXuSfum4295xXpFw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759825986; c=relaxed/simple; bh=O+OzpO7nuiNp+tQ5SaJvkPQc46KvjmbBEKhSAjhrkYw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=sDaQuMjaUBdM0lcVtAyxzo4cJfFjbhex0xkUrHEPGBzalYEuRdwgm+hDaBHJ3Cg2Lo6t4xcr0E0fi4dpK7Fc8zPYIghei+WoxMoRoYBCqS58iPpEN5L5AmdcU5AdeBAQji1F2uY0I/N6XzgTYSBntn5z/TlHn68GOYWnb9YClfU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DGNcXrQL; arc=none smtp.client-ip=209.85.208.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DGNcXrQL" Received: by mail-lj1-f173.google.com with SMTP id 38308e7fff4ca-3652d7800a8so27141171fa.0 for ; Tue, 07 Oct 2025 01:33:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1759825981; x=1760430781; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=cJBgNYNLNnpXb6QYC+z4Cdfg6JdOrjXxzZiYm8s3Uh8=; b=DGNcXrQLXRNDxQrlAFAB1IWkeNAWXnvR8m6k/n9KEvtJY0hSpc/6zhioFlqedE04IA GHMMeFmQI/XezfujMwx47Q0IWyGR9QZR5c53I0fkKDrMq0iLCBY6imFreuygtXhSyand 47hme1DfA10F2qaJLKSmNWGZ76IjR6dZahMl82y0n/ZJkjzaZ2r44xK5E5MV/FwG/g5T uRCXuk6lVzVIwfbkDhFHWnltfz1k54Z7OZJ6KESqGm5QBNGrBdeVkmTMOS9g6I5pci3q 0PlU+7KsiCnj1/1jiLWZg7LCsl5BGJE8/BHpnPuE3+BqHmWxqryZucKtMDkIwNwgujFl 1LRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759825981; x=1760430781; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=cJBgNYNLNnpXb6QYC+z4Cdfg6JdOrjXxzZiYm8s3Uh8=; b=Arh/H3t4KGlfWr+s7WraNDt0bMUjYxhfYy+dIZ7flJgulmTOpmPqdQ8/yPqyAzpyzo YRikrWhXKF3aAZQY24dErv/665q8221VjX9hxgzlYiPT73Z37fcFcrsJTmIIW0kUvbPz PowQELAVhsj3j9xwZ0dqvf5lInKqiyqacu5Hh+z5gvT/TO9c+pXZiV+6CBq76QzD3HsC lDzMElIasziNfqZxuNLSlNbFh9B5SjAIv8btIkMAJWcLLTqFdPSA7rtr5NR23HBsHXSl aCgYg5tmDkfCbsAwLvRA/zG66QkOqqYR/TWRloaRlQFKWiuUcl4dhO+HH6peVGuo8VJh O4Sg== X-Forwarded-Encrypted: i=1; AJvYcCVnZqjCOa4leiqWmEr39nzH+zmGbj03PAjkUwlNdWC3japbLKhUxHq3LIaqxQk1FW+PP7lOnlUbRCqR75E=@vger.kernel.org X-Gm-Message-State: AOJu0YyJ4pDXjlKUZ0ZtFjgDqUapaJZfdf44t0qU44nOU5o2Mbmcq++f aZAUy4O+lTGtSj92mtvbO3cs77fnHM0+7J0jRJfYhCPCqFw0/Lz5D9oM X-Gm-Gg: ASbGnct/0ySZnfG1c736zkT9PMaVYyU23M2+25xqABQ2z4FVimp/nrzLVhdaDvaTYy7 W2Q1kOQOSX8fyYW5VIcusz8DZgqlMfzX7xHUeZxlMQwKgQIUJJ/NhjC5aYahTmVvM1ps7POBOrP lQFDU5E7YgzwfNv67ixnc1Hf0Ptt3bAotJTFbCj+kOyIESCv0b8liJaOb8OXsJ+IL5iKhOo94xE oqj859129jDBb8GOdYyYPUGmPG5QPk7SfP0JvH/eXndbfZWGQf8fFKoJTNKHx8j7WrvcvUesYOY 7ZV5sfni8enTuGE/Y1gpHZ9G8S0RxRsT7R4GjfyJW9dhI693mPHLmEzC5VmyizhCxItHYfeslpW d7fWoRArSnv1RNw9qLUJDuemqQMoqQ12QToJ3hDjSzuseJlQMTd+Nmw== X-Google-Smtp-Source: AGHT+IFwKKHb8VdtMnYOpULqw57rPFwDDIri68ViZGVtmZPrQ+kPcd2Uig0QzxXQ9F7ajEM3Wp83rQ== X-Received: by 2002:a2e:b888:0:b0:372:8d61:c26f with SMTP id 38308e7fff4ca-374c36f3169mr48898581fa.11.1759825981256; Tue, 07 Oct 2025 01:33:01 -0700 (PDT) Received: from mva-rohm ([2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-375f3bd4218sm7926681fa.61.2025.10.07.01.32.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Oct 2025 01:33:00 -0700 (PDT) Date: Tue, 7 Oct 2025 11:32:56 +0300 From: Matti Vaittinen To: Matti Vaittinen , Matti Vaittinen Cc: Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Sebastian Reichel , Liam Girdwood , Mark Brown , Linus Walleij , Bartosz Golaszewski , Matti Vaittinen , Andreas Kemnade , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-gpio@vger.kernel.org Subject: [RFC PATCH 01/13] dt-bindings: regulator: ROHM BD72720 Message-ID: <73d30c0c2fb56582c51b6ff9dea3f5145ed36c34.1759824376.git.mazziesaccount@gmail.com> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="3VPimhN5qZ43uOQi" Content-Disposition: inline In-Reply-To: --3VPimhN5qZ43uOQi Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" The ROHM BD72720 is a new PMIC with 10 BUCk and 11 LDO regulators. The BD72720 is designed to support using the BUCK10 as a supply for the LDOs 1 to 4. When the BUCK10 is used for this, it can be set to a LDON_HEAD mode. In this mode, the BUCK10 voltage can't be controlled by software, but the voltage is adjusted by PMIC to match the LDO1 .. LDO4 voltages with a given offset. Offset can be 50mV .. 300mV and is changeable at 50mV steps. Add 'ldon-head-millivolt' property to denote a board which is designed to utilize the LDON_HEAD mode. All other properties are already existing. Add dt-binding doc for ROHM BD72720 regulators to make it usable. Signed-off-by: Matti Vaittinen --- .../regulator/rohm,bd72720-regulator.yaml | 153 ++++++++++++++++++ 1 file changed, 153 insertions(+) create mode 100644 Documentation/devicetree/bindings/regulator/rohm,bd7272= 0-regulator.yaml diff --git a/Documentation/devicetree/bindings/regulator/rohm,bd72720-regul= ator.yaml b/Documentation/devicetree/bindings/regulator/rohm,bd72720-regula= tor.yaml new file mode 100644 index 000000000000..665086f56928 --- /dev/null +++ b/Documentation/devicetree/bindings/regulator/rohm,bd72720-regulator.ya= ml @@ -0,0 +1,153 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/regulator/rohm,bd72720-regulator.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: ROHM BD72720 Power Management Integrated Circuit regulators + +maintainers: + - Matti Vaittinen + +description: | + This module is part of the ROHM BD72720 MFD device. For more details + see Documentation/devicetree/bindings/mfd/rohm,bd72720-pmic.yaml. + + The regulator controller is represented as a sub-node of the PMIC node + on the device tree. + + Regulator nodes should be named to BUCK_ and LDO_. + The valid names for BD72720 regulator nodes are + buck1, buck2, buck3, buck4, buck5, buck6, buck7, buck8, buck9, buck10 + ldo1, ldo2, ldo3, ldo4, ldo5, ldo6, ldo7, ldo8, ldo9, ldo10, ldo11 + +patternProperties: + "^ldo[1-11]$": + type: object + description: + Properties for single LDO regulator. + $ref: regulator.yaml# + + properties: + regulator-name: + pattern: "^ldo[1-11]$" + description: + should be "ldo1", ..., "ldo11" + + rohm,dvs-run-voltage: + description: + PMIC default "RUN" state voltage in uV. See below table for + LDOs which support this. 0 means disabled. + $ref: /schemas/types.yaml#/definitions/uint32 + minimum: 0 + maximum: 3300000 + + rohm,dvs-idle-voltage: + description: + PMIC default "IDLE" state voltage in uV. See below table for + LDOs which support this. 0 means disabled. + $ref: /schemas/types.yaml#/definitions/uint32 + minimum: 0 + maximum: 3300000 + + rohm,dvs-suspend-voltage: + description: + PMIC default "SUSPEND" state voltage in uV. See below table for + LDOs which support this. 0 means disabled. + $ref: /schemas/types.yaml#/definitions/uint32 + minimum: 0 + maximum: 3300000 + + rohm,dvs-lpsr-voltage: + description: + PMIC default "deep-idle" state voltage in uV. See below table for + LDOs which support this. 0 means disabled. + $ref: /schemas/types.yaml#/definitions/uint32 + minimum: 0 + maximum: 3300000 + + # Supported default DVS states: + # ldo | run | idle | suspend | lpsr + # -------------------------------------------------------------- + # 1, 2, 3, and 4 | supported | supported | supported | supported + # -------------------------------------------------------------- + # 5 - 11 | supported (*) + # -------------------------------------------------------------- + # + # (*) All states use same voltage but have own enable / disable + # settings. Voltage 0 can be specified for a state to make + # regulator disabled on that state. + + unevaluatedProperties: false + + "^buck[1-10]$": + type: object + description: + Properties for single BUCK regulator. + $ref: regulator.yaml# + + properties: + regulator-name: + pattern: "^buck[1-10]$" + description: + should be "buck1", ..., "buck10" + + rohm,ldon-head-millivolt: + description: + Set this on boards where BUCK10 is used to supply LDOs 1-4. The = bucki + voltage will be changed by the PMIC to follow the LDO output vol= tages + with the offset voltage given here. This will improve the LDO ef= ficiency. + $ref: /schemas/types.yaml#/definitions/uint32 + minimum: 50 + maximum: 300 + + rohm,dvs-run-voltage: + description: + PMIC default "RUN" state voltage in uV. See below table for + bucks which support this. 0 means disabled. + $ref: /schemas/types.yaml#/definitions/uint32 + minimum: 0 + maximum: 3300000 + + rohm,dvs-idle-voltage: + description: + PMIC default "IDLE" state voltage in uV. See below table for + bucks which support this. 0 means disabled. + $ref: /schemas/types.yaml#/definitions/uint32 + minimum: 0 + maximum: 3300000 + + rohm,dvs-suspend-voltage: + description: + PMIC default "SUSPEND" state voltage in uV. See below table for + bucks which support this. 0 means disabled. + $ref: /schemas/types.yaml#/definitions/uint32 + minimum: 0 + maximum: 3300000 + + rohm,dvs-lpsr-voltage: + description: + PMIC default "deep-idle" state voltage in uV. See below table for + bucks which support this. 0 means disabled. + $ref: /schemas/types.yaml#/definitions/uint32 + minimum: 0 + maximum: 3300000 + + # Supported default DVS states: + # buck | run | idle | suspend | lpsr + # -------------------------------------------------------------- + # 1, 2, 3, and 4 | supported | supported | supported | supported + # -------------------------------------------------------------- + # 5 - 10 | supported (*) + # -------------------------------------------------------------- + # + # (*) All states use same voltage but have own enable / disable + # settings. Voltage 0 can be specified for a state to make + # regulator disabled on that state. + + required: + - regulator-name + + unevaluatedProperties: false + +additionalProperties: false --=20 2.51.0 --3VPimhN5qZ43uOQi Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEIx+f8wZb28fLKEhTeFA3/03aocUFAmjk0DgACgkQeFA3/03a ocUuoAf/UHyrFb8dZBCpBZPBGI26r61s/sx3VMQmnvHTtEBwVeD8i3dEnmEpFncz WsGwz8Fv5SakW0+iRpkstEfmJrsw15CUfPv6Ht9SBf0NXbGUOf+3i1d5JKH4PY0P iZU992j5YrwjfxazAwuXF/B91aYv+3cgRUPyJcSE8UAyZJU8y5NWCZadxt9QGAzB XIAeZjCSydgBvrsUT+RdRPS6blrRNvQ9NzxZ4g9Mghj4xUvYzypQIsPZWGWDj/xb /aPQtZ2KxQDv77mLmi3Hh8pIkeTL9bYcmG/oiIRhFwafUTSMi56ue/bxjJFetfCL j0HPD+rnJ0Zw4gZddYrf6d0MedH7wg== =mXl4 -----END PGP SIGNATURE----- --3VPimhN5qZ43uOQi-- From nobody Wed Feb 11 03:42:00 2026 Received: from mail-lj1-f179.google.com (mail-lj1-f179.google.com [209.85.208.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C46D2571BE for ; Tue, 7 Oct 2025 08:33:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759825996; cv=none; b=G3PrcylMlmMXNqSJGZmWDFTcznhpsrBMEhdJC3oBukup5CNDOyO3+ZoS+TtThohOV133KTyOeDMZ97yIkK+ADh5ZWXGb8mbcKbkm6k0qjnzAYIbWwNaHURngSMi/2ZzGVAsquaiIgwZwOFOTD42/3s57TNPi3tosrF8zbcvNyDo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759825996; c=relaxed/simple; bh=7uAEAm51rLd1FKqy+L2ec4vQm8vIVZoQc5npaYHbk3U=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=lgmXv97YAlDq2SWT6i2OIWXaNmgCg0VRfDs1HHBKbKnJ0UL/FfNJoj56r6ea4sEdd03//Vz4lBHQceDjXx9oDBmwVa0UWmuBdlYYN/osLnl4rBpmmegaikA+nbr8JfCHO8faaBiTd32KPX+UOfraOM/EWJoBEojzf9fG9SAD7gc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=crNa8lLa; arc=none smtp.client-ip=209.85.208.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="crNa8lLa" Received: by mail-lj1-f179.google.com with SMTP id 38308e7fff4ca-3696f1d5102so37742371fa.3 for ; Tue, 07 Oct 2025 01:33:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1759825992; x=1760430792; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=gGiMbjmQn7XfKWV9vHi8Sy/mWp58kUDQTy/MiPcOTHY=; b=crNa8lLa8EjqTStdYaRKokAEtj6ea55hG7k/uRyNzMVqXy+uf10NN+PIG7uJG19Q5+ xnUgyo/LMVKy1cPQlbUpP/GxRgpC3GvPg8DJLURlqRbnf3oPqzm5fujevlLZXND85LvA LJJaRC7/5XanRfYaMlFLgIG6CwIjcbXLYS525lycFtpyxpmazKfZ3W82ImhqmRhMOcVC /OnGgiNdl2Mz7tKKtXBKL7yYwosEqr0YvSj4w8WSHdmzM03UjHvEe6LL+UbSGYi87OOE C1gykKSVP+SPiDrw8cwSiKk3xqvNlT6+mt1pnpp9gbL2g5uvQb3gVSX9/V6x3S3LFtkM XwWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759825992; x=1760430792; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=gGiMbjmQn7XfKWV9vHi8Sy/mWp58kUDQTy/MiPcOTHY=; b=YiKNPO48GYi/iPXrUtjUJIuXarzCNa84+daGeqRMh0CTAQEPj4kvKoGbkIEm0PSCwm Q+M1ABrSIen0Q2xUyqYP4cFNlhmjsi/g3tT6prt8WNbrIN7J2JmzKazYKb/qbJQf6LkU RA4XFoGOVX2a9Q07PKGZqG1jN3ycdnrCgkhVSTUdeSCWNsJIxuKRHFeE4jdtiDLOek4l D+QyFzZaV+FNz2P1z6SQCGw+8HYpvns9KRXRQfMAih4lVKxe5Uhm14LnzUyG0/wPLQvO GPyoz6GsYGix6jB9QkWRACobRVV3HdLlB1D62j0h0QQmzOJJn0hK3Z6NnNsuNldfz23w ByMg== X-Forwarded-Encrypted: i=1; AJvYcCW6ebJE5SOWbDcRoGnDOohjaPSYVzNXYJN6bI1JhCJYzuYwtZWbGUMheWPjgfWquD4+ZNwPCw2CHv8bMpc=@vger.kernel.org X-Gm-Message-State: AOJu0YwBrz6xs2SES3p0pDrkuzY5kPb1z/7FOrg5itfbp7V+KlQ8lBmG 2juki2s9PPr5T3CzQwJJjCaBW53aX5XBQ1P82PxdzwMcNh+PJwxWC9+R X-Gm-Gg: ASbGncslIHfIqHKWPXvBeMAfL6SefjezrIuXmg2qIP2dARf/Y/QG76yY1E88BQ0KeJs HLlEbua5S8mzQx3XNAyb+qIj6UaJZSHZcp/7Z/rwflpya5PM0E+yz67hV2iuBkiRDUv3xr/F2H9 UCmcWT+92UjhgvzBtlOQwqL+Chnw3CjNfu0yD+tBQrJAlBu06JFIDU+9lxxpFjjgqlML4kQQtGp Qnef3wn0+IWQcLMlRWqluakjqSBdh8f7UjaJ/PGrlzeBf+e715TnUJcUgpCULFs3Dy1BOasupfc t3J3VumjdxOYIrEKjrj9uwpTHl+zSNPuWtLzUFFQ7Vkmc3wmQ41m5woiyQU0ZrXj/bOcfvu4nu2 kwFeWMYgDQuE5IHuP4hkUEw+tKPhIXFXLsZ9rBgWi0Nq4RC3MKLyXxPU2D3xyAMcH X-Google-Smtp-Source: AGHT+IHuGRguErrXJP9h3pDzhOaJUtpac4R4MsXzz6Y0nXTmBHq4H3FCgsyuBlP6yhqsJfsGeldLBA== X-Received: by 2002:a05:651c:4408:10b0:372:9505:725b with SMTP id 38308e7fff4ca-374c3837106mr35638181fa.34.1759825992192; Tue, 07 Oct 2025 01:33:12 -0700 (PDT) Received: from mva-rohm ([2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-375f3b64e6dsm7807951fa.39.2025.10.07.01.33.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Oct 2025 01:33:11 -0700 (PDT) Date: Tue, 7 Oct 2025 11:33:07 +0300 From: Matti Vaittinen To: Matti Vaittinen , Matti Vaittinen Cc: Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Sebastian Reichel , Liam Girdwood , Mark Brown , Linus Walleij , Bartosz Golaszewski , Matti Vaittinen , Andreas Kemnade , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-gpio@vger.kernel.org Subject: [RFC PATCH 02/13] dt-bindings: Add trickle-charge upper limit Message-ID: <072180743039027b8476525bfb3d04b3dd044be1.1759824376.git.mazziesaccount@gmail.com> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="v2C5QlrJAk9yRRw2" Content-Disposition: inline In-Reply-To: --v2C5QlrJAk9yRRw2 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Some of the chargers for lithium-ion batteries use a trickle-charging as a first charging phase for very empty batteries, to "wake-up" the battery. Trickle-charging is a low current, constant current phase. After the voltage of the very empty battery has reached an upper limit for trickle charging, the pre-charge phase is started with a higher current. Allow defining the upper limit for trickle charging voltage, after which the charging should be changed to the pre-charging. Signed-off-by: Matti Vaittinen Reviewed-by: Linus Walleij --- Documentation/devicetree/bindings/power/supply/battery.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/devicetree/bindings/power/supply/battery.yaml b/= Documentation/devicetree/bindings/power/supply/battery.yaml index 491488e7b970..66bed24b3dee 100644 --- a/Documentation/devicetree/bindings/power/supply/battery.yaml +++ b/Documentation/devicetree/bindings/power/supply/battery.yaml @@ -66,6 +66,9 @@ properties: trickle-charge-current-microamp: description: current for trickle-charge phase =20 + tricklecharge-upper-limit-microvolt: + description: limit when to change to precharge from trickle charge + precharge-current-microamp: description: current for pre-charge phase =20 --=20 2.51.0 --v2C5QlrJAk9yRRw2 Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEIx+f8wZb28fLKEhTeFA3/03aocUFAmjk0EMACgkQeFA3/03a ocXmPwgAxfL/bnwzJGbWAfYUHNKmQwT+fSbIu0KruqseE4yNXxdi24bAtxHIFSbw +WR6S46YkHhtZXkD0Ew/skbhuRAaYjmP/NbJYVQdRBj6l5GUcmxtxs3uiadOmaGU UWa3wakGNMZIdRrOguR7syzu7tq+gc6R0XS7v+EEksiFi9arXBXmknN012XK6x0E Z/ywhwDzT05HmPuxGV1BtfUd2RlZhfx1w7M9PM4dcNWi0edfB4jgwKNPEUa3A2sR SfcnNxz+lX34BASK6I2E+zqUfMmg0fBvNCDEC7xbxn98oTU9ceCuj5ADDG7c0wXd gjb9SctkHZE5Cw67sS2Vg/Lu7E975A== =b1vC -----END PGP SIGNATURE----- --v2C5QlrJAk9yRRw2-- From nobody Wed Feb 11 03:42:00 2026 Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C38F2D6E61 for ; Tue, 7 Oct 2025 08:33:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759826009; cv=none; b=oqUiXo321yiwZSsY9Us+nLtMjlvVMqtElAIv7cG+CHgfYGdZ3z46tKl8L/PNKQZlSOmRTZutPDYD5GdNzgweGNW0+/rX+Q2cgsl+EPbFB0x7Wn0J/TgqT9191vR4VL1uIEFMuojGhdRibAaLLhfGelyUOaoGC/35bCe4LgO3Ln8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759826009; c=relaxed/simple; bh=Lee8N5iEc1uUJfjt/Yh7XEwpo+Xg7SPtu0yQg/hrcno=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=syWU67GWYT2sqbrgUpmMSmS2pBT1poYWqRAPIhYZDcbLQu7bKRt7gdoQCzrG2et4kcbajg8pOIaYb5UdktBHUwEgtFXuy8BmbaXGdDI00OMgrhYDaM90Qk4g6SA3epHYFAeroEX7Fus78c1DlqYYj+kQBp+am29HI1j2LVccMVM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mm/htQGl; arc=none smtp.client-ip=209.85.167.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mm/htQGl" Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-57b8fc6097fso7884008e87.1 for ; Tue, 07 Oct 2025 01:33:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1759826005; x=1760430805; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=cIpONcxr9oHBn7Z3vExTtBudI+oTICOorfxFNOKk/YA=; b=mm/htQGlQVXJeZCixroeGOPF2i3E0wE6HmIGcOkPr21AOUD3SGHbt0hVFa40RQ/+DH whq4O6nXMYdtUKWSc3S1MNGxpqzfVMPKJM9quevthVVHaD88kWaN43Ey4tjlrotIjLAy yEQRQRV9PM9srtqXjhc+lFQQlOO6qW9oqoZ43FZm8PRf93SXYmKljk8JmURaozE8GImV RLnwIYPIAYE7C+GhDFcxjw/KgnFn4q8S7fgLbzmkDFby3k9mHk4U4bHHRy5OWlxabyD1 UYiWQ7ClYUIAdaAcb3pFGNMBeUwvT/fvuzTGNYni2PghBY/qgdYlkOTSsSgjSd797P0w pzcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759826005; x=1760430805; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=cIpONcxr9oHBn7Z3vExTtBudI+oTICOorfxFNOKk/YA=; b=eeT6VkprXN9riwNL3IIwBTrCHfDlTnMGXdPwGd8uqnbC8MiHS/mm6H1CQsvY1I0bRz D6ApsGZrjpvJm6PaJ1QJOItZj0MA1HUMEdkQZdmIYn4khD8ELomMaGRxah8ZAeEjKmOS ff8vEqJGUMLCZaO6ov+KX79g0RGjSMJFYliftu76XR/I4ZaHwVhqrsLoxADveSh9oBMK WYYf+hH+FTp+xK+9Q/RR6mRQNOcx5LZYiCUH/awuYTp4hW2xHFR6Zort5Qn8UHHfLalS KwQWjwmg3FPyZr9mbr/m87ClQTwc+O8aMGq+BiMUGQSP0p5vo6EySaAAgDG5zepVpNm8 geRQ== X-Forwarded-Encrypted: i=1; AJvYcCUIpDKtmX1nvpJptxS+0eiep3KL4SiHrjEq4GxeOgeITn19YXIDDNcdHOO11WCZ35S1lJtTSb+QZ4tpFK8=@vger.kernel.org X-Gm-Message-State: AOJu0Yw/AhYCDqToMb5g5NsMgC72quIEtoQmTNJBKhljDbuVfBb0wo0r C+ewhBAiTRHxkBmqcwKEL5e+EYha1Y/ohI0fgFrHfiiAO2tkNymiQ9lM X-Gm-Gg: ASbGncvZefolEGrgDNGmcZCsYMgtl/kVtTv1ntotXTjMPV9LO1SAkFrA96+ERtMtPTE Rb/a/czaYBNj03R1yx/oSBPKQpgSPRZUwP/oYICUKQClPQZfeZVQgO4FbU7Tzu50zVSb3hurjQI oKqmREtm2i9pLkjWzAIpLUCdvOWC0rsjohYYrlno16wskUlPN0g1XXxMmvTHIwhUsSOncKqUWsl 7ObrfB/JxS0cK9IYjE2kqArVQR8qpDSEmLKF0kerRPP5ThlsjZ1q1IzB0qPyZJzEpS7PjBQ2oYl 66ZmnKbNU87K39K17AGoc3rjyG9NzJxDJanWl0IgUN5Cp18NTcZE1FP3wAdh5EI58ZS9fWjw+zI s65OhqqhW+3xnrp9ZLlXbgG2Iemka52Ek8cr1QVcQuZSsu72Z85Nwuw== X-Google-Smtp-Source: AGHT+IGV+f3kF5i1L5zcykmsamlfxPlyY7h0Wy5wEUPfLcfYA09xWQt1P1iomSsNDQk3zL84PrE1BA== X-Received: by 2002:a05:6512:3e10:b0:57a:de0d:d9ce with SMTP id 2adb3069b0e04-58cbb90df9cmr5082960e87.44.1759826004327; Tue, 07 Oct 2025 01:33:24 -0700 (PDT) Received: from mva-rohm ([2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-58b0113f461sm5883339e87.50.2025.10.07.01.33.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Oct 2025 01:33:23 -0700 (PDT) Date: Tue, 7 Oct 2025 11:33:19 +0300 From: Matti Vaittinen To: Matti Vaittinen , Matti Vaittinen Cc: Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Sebastian Reichel , Liam Girdwood , Mark Brown , Linus Walleij , Bartosz Golaszewski , Matti Vaittinen , Andreas Kemnade , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-gpio@vger.kernel.org Subject: [RFC PATCH 03/13] dt-bindings: power: supply: BD72720 managed battery Message-ID: <19d537f9920cae5fa849b649e5bc42ba0b8e52f8.1759824376.git.mazziesaccount@gmail.com> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="AryBLfzBjdVkmgj/" Content-Disposition: inline In-Reply-To: --AryBLfzBjdVkmgj/ Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" The BD72720 PMIC has a battery charger + coulomb counter block. These can be used to manage charging of a lithium-ion battery and to do fuel gauging. ROHM has developed a so called "zero-correction" -algotihm to improve the fuel-gauging accuracy close to the point where battery is depleted. This relies on battery specific "VDR" tables, which are measured from the battery, and which describe the voltage drop rate. More thorough explanation about the "zero correction" and "VDR" parameters is here: https://lore.kernel.org/all/676253b9-ff69-7891-1f26-a8b5bb5a421b@fi.rohmeur= ope.com/ Document the VDR zero-correction specific battery properties used by the BD72720 and some other ROHM chargers. Signed-off-by: Matti Vaittinen --- The parameters are describing the battery voltage drop rates - so they are properties of the battery, not the charger. Thus they do not belong in the charger node. The right place for them is the battery node, which is described by the generic "battery.yaml". I was not comfortable with adding these properties to the generic battery.yaml because they are: - Meaningful only for those charger drivers which have the VDR algorithm implemented. (And even though the algorithm is not charger specific, AFAICS, it is currently only used by some ROHM PMIC drivers). - Technique of measuring the VDR tables for a battery is not widely known. AFAICS, only folks at ROHM are measuring those for some customer products. We do have those tables available for some of the products though (Kobo?). --- .../power/supply/rohm,vdr-battery.yaml | 78 +++++++++++++++++++ 1 file changed, 78 insertions(+) create mode 100644 Documentation/devicetree/bindings/power/supply/rohm,vdr= -battery.yaml diff --git a/Documentation/devicetree/bindings/power/supply/rohm,vdr-batter= y.yaml b/Documentation/devicetree/bindings/power/supply/rohm,vdr-battery.ya= ml new file mode 100644 index 000000000000..85611ed050fa --- /dev/null +++ b/Documentation/devicetree/bindings/power/supply/rohm,vdr-battery.yaml @@ -0,0 +1,78 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/power/supply/rohm,vdr-battery.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Battery managed by the BD72720 PMIC + +maintainers: + - Matti Vaittinen + +description: + A battery which has VDR parameters measuerd for ROHM chargers. + +allOf: + - $ref: battery.yaml# + +properties: + rohm,voltage-vdr-thresh-microvolt: + description: Threshold for starting the VDR correction + + rohm,volt-drop-soc: + description: Table of capacity values matching the values in VDR table= s. + $ref: /schemas/types.yaml#/definitions/uint32-array + + rohm,volt-drop-high-temp-microvolt: + description: VDR table for high temperature + + rohm,volt-drop-normal-temp-microvolt: + description: VDR table for normal temperature + + rohm,volt-drop-low-temp-microvolt: + description: VDR table for low temperature + + rohm,volt-drop-very-low-temp-microvolt: + description: VDR table for very low temperature + + +additionalProperties: false + +examples: + - | + power { + #address-cells =3D <1>; + #size-cells =3D <0>; + + battery: battery { + compatible =3D "simple-battery"; + + ocv-capacity-celsius =3D <25>; + ocv-capacity-table-0 =3D <4200000 100 4184314 100 4140723 95 40994= 87 90 + 4060656 85 4024350 80 3991121 75 3954379 70 3913265 65 3877821 60 + 3855577 55 3837466 50 3822194 45 3809012 40 3795984 35 3780647 30 + 3760505 25 3741532 20 3718837 15 3696698 10 3690594 5 3581427 0>; + + rohm,volt-drop-soc =3D <1000 1000 950 900 850 800 750 700 650 600 = 550 500 + 450 400 350 300 250 200 150 100 50 00 (-50)>; + + rohm,volt-drop-high-temp-microvolt =3D <100 100 102 104 106 109 1= 14 124 + 117 107 107 109 112 116 117 108 109 109 108 109 122 126 130>; + + rohm,volt-drop-normal-temp-microvolt =3D <100 100 102 105 98 100 1= 05 102 + 101 99 98 100 103 105 109 117 111 109 110 114 128 141 154>; + + rohm,volt-drop-low-temp-microvolt =3D <100 100 98 107 112 114 118 = 118 112 + 108 108 110 111 113 117 123 131 144 157 181 220 283 399>; + + rohm,volt-drop-very-low-temp-microvolt =3D <86 86 105 109 114 110 = 115 115 + 110 108 110 112 114 118 124 134 136 160 177 201 241 322 403>; + + rohm,voltage-vdr-thresh-microvolt =3D <4150000>; + + charge-full-design-microamp-hours =3D <1799000>; + voltage-max-design-microvolt =3D <4200000>; + voltage-min-design-microvolt =3D <3500000>; + degrade-cycle-microamp-hours =3D <131>; + }; + }; --=20 2.51.0 --AryBLfzBjdVkmgj/ Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEIx+f8wZb28fLKEhTeFA3/03aocUFAmjk0E8ACgkQeFA3/03a ocVydQgAvCH2QkGIf75CADfjsN5Y0T0hTaWht8JMC6xy6F8J5j1bJJxSkkRdQWhg pAjRCVJXzTe+yQ55kl77S9tpQ8IYOes6U/OlARruehTAIo6fL0m9wIKPgi3ENONS Z6n2S0rUZ8MXLPA18CPLgNbNAMnVEE1ZjU9HqkeW1obfymRB0StGF5ofIf1KH+GD FGk/at+JDBOQlOifUDGwSR/Ox6gwvARfRweHdJwUxFOu1fkeNp6k1tR1FbhU8+4z hDzBqb0JFODBeHapk9j/IZaXsoKkrRiuBxTn8w9Slr1x23m21O1DV7HqKTXmdDug o06qtym15kHvZGD0fkjz9eNfpFfkHQ== =Ip1k -----END PGP SIGNATURE----- --AryBLfzBjdVkmgj/-- From nobody Wed Feb 11 03:42:00 2026 Received: from mail-lj1-f172.google.com (mail-lj1-f172.google.com [209.85.208.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70FDB2D7394 for ; Tue, 7 Oct 2025 08:33:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759826019; cv=none; b=anCwOJ3QHK8cpPOAOrvcKSgUetIJrBd/+pz6XNPvdCE/FGfxYFFzqqZuxnNLAnI6vEnC0zykmh+qW8nYrZOIBR0airTyIJ8blLaRvBX+GzANxwjbuOGDRfQ+aXhf6LR3b0Pzw0z71HuVWF+DGZ4MQV2WUzWnGfqsae02fwvWliw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759826019; c=relaxed/simple; bh=0qm+wbM4Yxdr947/e1Ix8Os5lqI7GsRoH3zKAUCA9to=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=YyjCEUvna36x7r8v8TugR7Yu79ChhgiUiKtsq8IcxpzJA7Sf9mB36jC6iXNjF0dN04RThTSqQLD1bco9VQ155YL9owiNLOL0UWrsKOFQ0ytpKi0bKAo+W+Qevb59IzltSPAe2Qb30QYsUo9lGlPcpLYH38LPfZAP3mFESCLuGGM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hIHOF9sb; arc=none smtp.client-ip=209.85.208.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hIHOF9sb" Received: by mail-lj1-f172.google.com with SMTP id 38308e7fff4ca-3652d7800a8so27145291fa.0 for ; Tue, 07 Oct 2025 01:33:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1759826016; x=1760430816; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=XN5h3tnIJ305ES8QY9VBQb05P0G9SlLaLGLqVj1UUgA=; b=hIHOF9sbKigk+aMmH7d6xeTb2eWUePcv/rS429kcBIARy6R/ZWk4bq9d1gOTsEBuzO WreG3kCMq9+eDIzNjsaPyTMbxRivP2orRsXum45RJ7DMVBi2ZVlcuDQolPM9y30zDGgp OFQ+tq7I8OBo6mP4y/Xjpe9Dlm4ncUvnB/Wjp8Ykckx1hHoGYJQqvIU/+UfGISryZkOw BRVnnnm56D/08YwAblvORldVeOgTfiHJ/ihJ1b/jDF2Pt2R7/3wN+owUxQjKJWYsDFBW I2wrT0V7y22KLO5nFBsGTDpjXwIjGsQocycg3iSijJ7q30zG3BVACaDWHtKrCCX9dVJQ 6RiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759826016; x=1760430816; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=XN5h3tnIJ305ES8QY9VBQb05P0G9SlLaLGLqVj1UUgA=; b=FvPkhijMvxo27bBXRBRO9j8LPktDINQtW3hRIUfpw0PGMtORMEH/QeH8my6Kx+xvqq r+oRoGH9nOEG7MOkU87EaMCMBgHn4fiCKtpagD8fLf0D8dtxW/yeIYkHOTP8OmaUM73b kaOxzPY4XzqyOv8GhK08EJmyFEtFFx5QdvxPw+4FVPda16P9dNKqtUR1/+SFUnqBgr4r 91vkE+K+igKUp/H4tKq8hK9+UzwlIpYsMQzHEKFnbU3jxN/X7NPiMsmR9uct1AbfIf/w RNoINe9c6XZ+sk3LpOaJ0VpXgK4CjqBQy4VaX7GEp+vCYWLxv+QyXYj3oNsCuoZjvk0j yx2A== X-Forwarded-Encrypted: i=1; AJvYcCXekFPSc/Bis3V+wtt5KR4HVZLm4vuYyO8HBq76Cjf+CtnpYemYSn5al7b2LkF7s2imGX6SPQWsFGwxpJc=@vger.kernel.org X-Gm-Message-State: AOJu0YwqMiG2gaFOxCRiVQnpixPHh4X3L72lik12pK+whqJ98NtW2gEJ JuDJI2rRetpGQLth17TDP3VrSJnLCMHc5Kw+KWMr5Hwq+9OD7pCSWlWH X-Gm-Gg: ASbGncvO4pI9mvamsmhI6fj2NkOwbvAb6Du7zHtdBT+1dQ+q+2sdpUm/QFhQ/U1DG3I guWnrq5qmtBWvWIkYkXN62JaFffXKOrjZ/NSsGwJNqukJQVZ4U7st6kJicRD2/jBPk82qJOcpLH kwMC/gzmTBWxQOPedWsXfmMEgX0EaaOWoxaQM0lEoVCNh2no2CbiWm1463o3jAsHk2E7e1YeRXH 7E7LPvUs/YKc/KCDAW6FC6pb/vSefGW2AKqyxbLuhmwXtYtERt3crR40lPt1ssduXJ7KSwnr4c7 lzyvms/PxZN5KVspHFmIb3UGeUU4ey9XqlV8o2oeiEYAwamcsA8e3nzSlXBAGyq8M3UL5JB7vSs SiZqW5eqY/Iy93cxTCHcQOyjuUveJ0dwbArAZ9UziiLcLQRC+EuWJ8g== X-Google-Smtp-Source: AGHT+IGlm1lJ9PHKpLHxwmV/x0ZqvQNmZk0Jngo99z91DDEA7+xbdTil4A9ywTIUsWFHeL8ZC6SAww== X-Received: by 2002:a05:651c:2213:b0:332:37d5:da95 with SMTP id 38308e7fff4ca-374c3836cb1mr55556091fa.33.1759826015401; Tue, 07 Oct 2025 01:33:35 -0700 (PDT) Received: from mva-rohm ([2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-375f39d49b5sm7923001fa.13.2025.10.07.01.33.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Oct 2025 01:33:34 -0700 (PDT) Date: Tue, 7 Oct 2025 11:33:30 +0300 From: Matti Vaittinen To: Matti Vaittinen , Matti Vaittinen Cc: Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Sebastian Reichel , Liam Girdwood , Mark Brown , Linus Walleij , Bartosz Golaszewski , Matti Vaittinen , Andreas Kemnade , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-gpio@vger.kernel.org Subject: [RFC PATCH 04/13] dt-bindings: mfd: ROHM BD72720 Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Z8mvoOwLpEV7jO45" Content-Disposition: inline In-Reply-To: --Z8mvoOwLpEV7jO45 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" The ROHM BD72720 is a power management IC integrating regulators, GPIOs, charger, LEDs, RTC and a clock gate. Add dt-binding doc for ROHM BD72720. Signed-off-by: Matti Vaittinen --- .../bindings/mfd/rohm,bd72720-pmic.yaml | 269 ++++++++++++++++++ 1 file changed, 269 insertions(+) create mode 100644 Documentation/devicetree/bindings/mfd/rohm,bd72720-pmic= .yaml diff --git a/Documentation/devicetree/bindings/mfd/rohm,bd72720-pmic.yaml b= /Documentation/devicetree/bindings/mfd/rohm,bd72720-pmic.yaml new file mode 100644 index 000000000000..7f8168410121 --- /dev/null +++ b/Documentation/devicetree/bindings/mfd/rohm,bd72720-pmic.yaml @@ -0,0 +1,269 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/mfd/rohm,bd72720-pmic.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: ROHM BD72720 Power Management Integrated Circuit + +maintainers: + - Matti Vaittinen + +description: | + BD72720 is a single-chip power management IC for battery-powered portable + devices. The BD72720 integrates 10 bucks and 11 LDOs, and a 3000 mA + switching charger. The IC also includes a Coulomb counter, a real-time + clock (RTC), GPIOs and a 32.768 kHz clock gate. + +# In addition to the properties found from the charger node, the ROHM BD72= 720 +# uses properties from a static battery node. Please see the: +# Documentation/devicetree/bindings/power/supply/rohm,vdr-battery.yaml +# +# Following properties are used +# when present: +# +# charge-full-design-microamp-hours: Battry capacity in mAh +# voltage-max-design-microvolt: Maximum voltage +# voltage-min-design-microvolt: Minimum voltage system is still opera= ting. +# degrade-cycle-microamp-hours: Capacity lost due to aging at each fu= ll +# charge cycle. +# ocv-capacity-celsius: Array of OCV table temperatures. 1/ta= ble. +# ocv-capacity-table-: Table of OCV voltage/SOC pairs. Corre= sponds +# N.th temperature in ocv-capacity-cels= ius +# +# ROHM specific properties: +# rohm,voltage-vdr-thresh-microvolt: Threshold for starting the VDR correc= tion +# rohm,volt-drop-soc: Table of capacity values matching the +# values in VDR tables. +# rohm,volt-drop-high-temp-microvolt: VDR table for high temperature +# rohm,volt-drop-normal-temp-microvolt: VDR table for normal temperature +# rohm,volt-drop-low-temp-microvolt: VDR table for low temperature +# rohm,volt-drop-very-low-temp-microvolt: VDR table for very low temperatu= re +# +# VDR tables are (usually) determined for a specific battery by ROHM. +# The battery node would then be referred from the charger node: +# +# monitored-battery =3D <&battery>; + +properties: + compatible: + const: rohm,bd72720 + + reg: + description: + I2C slave address. + maxItems: 1 + + interrupts: + maxItems: 1 + + gpio-controller: true + + "#gpio-cells": + const: 2 + description: | + The first cell is the pin number and the second cell is used to spec= ify + flags. See ../gpio/gpio.txt for more information. + + clocks: + maxItems: 1 + + "#clock-cells": + const: 0 + + clock-output-names: + const: bd71828-32k-out + + rohm,clkout-open-drain: + description: clk32kout mode. Set to 1 for "open-drain" or 0 for "cmos". + $ref: /schemas/types.yaml#/definitions/uint32 + minimum: 0 + maximum: 1 + + rohm,charger-sense-resistor-milli-ohms: + minimum: 10 + maximum: 50 + description: | + BD72720 has a SAR ADC for measuring charging currents. External sense + resistor (RSENSE in data sheet) should be used. If some other but + 30 mOhm resistor is used the resistance value should be given here in + milli Ohms. + + regulators: + $ref: ../regulator/rohm,bd77270-regulator.yaml + description: + List of child nodes that specify the regulators. + + leds: + $ref: ../leds/rohm,bd71828-leds.yaml + + rohm,pin-dvs0: + $ref: /schemas/types.yaml#/definitions/string + description: + BD72720 has 4 different OTP options to determine the use of dvs0-pin. + OTP0 - regulator RUN state control. + OTP1 - GPI. + OTP2 - GPO. + OTP3 - Power sequencer output. + This property specifies the use of the pin. + enum: + - dvs-input + - gpi + - gpo + + rohm,pin-dvs1: + $ref: /schemas/types.yaml#/definitions/string + description: + see rohm,pin-dvs0 + enum: + - dvs-input + - gpi + - gpo + + rohm,pin-exten0: + $ref: /schemas/types.yaml#/definitions/string + description: BD72720 has an OTP option to use exten0-pin for different + purposes. Set this property accrdingly. + const: gpo + + rohm,pin-exten1: + $ref: /schemas/types.yaml#/definitions/string + description: BD72720 has an OTP option to use exten1-pin for different + purposes. Set this property accrdingly. + const: gpo + + rohm,pin-fault_b: + $ref: /schemas/types.yaml#/definitions/string + description: BD72720 has an OTP option to use fault_b-pin for different + purposes. Set this property accrdingly. + const: gpo + +required: + - compatible + - reg + - interrupts + - clocks + - "#clock-cells" + - regulators + - gpio-controller + - "#gpio-cells" + +additionalProperties: false + +examples: + - | + #include + #include + i2c { + #address-cells =3D <1>; + #size-cells =3D <0>; + pmic: pmic@4b { + compatible =3D "rohm,bd71828"; + reg =3D <0x4b>; + + interrupt-parent =3D <&gpio1>; + interrupts =3D <29 IRQ_TYPE_LEVEL_LOW>; + + clocks =3D <&osc 0>; + #clock-cells =3D <0>; + clock-output-names =3D "bd71828-32k-out"; + + gpio-controller; + #gpio-cells =3D <2>; + gpio-reserved-ranges =3D <0 1>, <2 1>; + + rohm,charger-sense-resistor-ohms =3D <10000000>; + + regulators { + buck1: BUCK1 { + regulator-name =3D "buck1"; + regulator-min-microvolt =3D <500000>; + regulator-max-microvolt =3D <2000000>; + regulator-ramp-delay =3D <2500>; + }; + buck2: BUCK2 { + regulator-name =3D "buck2"; + regulator-min-microvolt =3D <500000>; + regulator-max-microvolt =3D <2000000>; + regulator-ramp-delay =3D <2500>; + }; + buck3: BUCK3 { + regulator-name =3D "buck3"; + regulator-min-microvolt =3D <1200000>; + regulator-max-microvolt =3D <2000000>; + }; + buck4: BUCK4 { + regulator-name =3D "buck4"; + regulator-min-microvolt =3D <1000000>; + regulator-max-microvolt =3D <1800000>; + }; + buck5: BUCK5 { + regulator-name =3D "buck5"; + regulator-min-microvolt =3D <2500000>; + regulator-max-microvolt =3D <3300000>; + }; + buck6: BUCK6 { + regulator-name =3D "buck6"; + regulator-min-microvolt =3D <500000>; + regulator-max-microvolt =3D <2000000>; + regulator-ramp-delay =3D <2500>; + }; + buck7: BUCK7 { + regulator-name =3D "buck7"; + regulator-min-microvolt =3D <500000>; + regulator-max-microvolt =3D <2000000>; + regulator-ramp-delay =3D <2500>; + }; + ldo1: LDO1 { + regulator-name =3D "ldo1"; + regulator-min-microvolt =3D <800000>; + regulator-max-microvolt =3D <3300000>; + }; + ldo2: LDO2 { + regulator-name =3D "ldo2"; + regulator-min-microvolt =3D <800000>; + regulator-max-microvolt =3D <3300000>; + }; + ldo3: LDO3 { + regulator-name =3D "ldo3"; + regulator-min-microvolt =3D <800000>; + regulator-max-microvolt =3D <3300000>; + }; + ldo4: LDO4 { + regulator-name =3D "ldo4"; + regulator-min-microvolt =3D <800000>; + regulator-max-microvolt =3D <3300000>; + }; + ldo5: LDO5 { + regulator-name =3D "ldo5"; + regulator-min-microvolt =3D <800000>; + regulator-max-microvolt =3D <3300000>; + }; + ldo6: LDO6 { + regulator-name =3D "ldo6"; + regulator-min-microvolt =3D <1800000>; + regulator-max-microvolt =3D <1800000>; + }; + ldo7_reg: LDO7 { + regulator-name =3D "ldo7"; + regulator-min-microvolt =3D <800000>; + regulator-max-microvolt =3D <3300000>; + }; + }; + + leds { + compatible =3D "rohm,bd71828-leds"; + + led-1 { + rohm,led-compatible =3D "bd71828-grnled"; + function =3D LED_FUNCTION_INDICATOR; + color =3D ; + }; + led-2 { + rohm,led-compatible =3D "bd71828-ambled"; + function =3D LED_FUNCTION_CHARGING; + color =3D ; + }; + }; + }; + }; --=20 2.51.0 --Z8mvoOwLpEV7jO45 Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEIx+f8wZb28fLKEhTeFA3/03aocUFAmjk0FoACgkQeFA3/03a ocWcTAf/Vn3HFVm6S4PzKIzlZl2rBimOzXMq1w9SoGDhAb2/DZmVum43bkbQ/3y8 D4h27w7iz/wsqiNv91nNL7wiVExReyM10HVCbQZhD+PREFctuBjiVJQ+6XxkzQsz f0dbY1XzWs66IWifuy6iHJWAFCNwo9BzRsIJJU3NOlf9V+8B8EdDfWQ/TdPbVAPY Q3U+psSLfql+YQugz4A+yaiN5QDzQBlNrY56BNfS9xI63O9931EJotQzdHS0TRIw yvxVTNOBAsR8TOYCbbPFcXzoLsEPpWiPsevFdiO5jr6o14H/d65ycuKhmKXxSmjx DTclm3q89kj+qAd4C0KPS9ntsmBeZQ== =uMET -----END PGP SIGNATURE----- --Z8mvoOwLpEV7jO45-- From nobody Wed Feb 11 03:42:00 2026 Received: from mail-lj1-f182.google.com (mail-lj1-f182.google.com [209.85.208.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 358972D4B68 for ; Tue, 7 Oct 2025 08:33:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759826031; cv=none; b=bNZ4LyhR2AXD3YxWfp153yoOlzvLoeth0Rq4bTQEons0qus/lmI1NAuALbO3JOgq6Ayy9QmnHG5kRCBKtwIq4lTqKXHh9BLJsdW9r+0TTlTeg5LcoII5i9X5J0spqDbKk3mPSxqpBSiyWX4P8dKvrPfSaS5vlNYohWkZxppJX2o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759826031; c=relaxed/simple; bh=1iY8dgK/r7VYOZvJEas2P75fHwdABfTnDJv6B71gZwo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=o5ywlCcLKy5gfjdoF9Ei2Vw56cC3kaku91byGIIrYX5oDpkAehf1CL91p8QPjvG0t+MLin2lSGxVhxSGxknHAcgD61ZHjzd6YEJl7v9Ly2o05G3cXDO6o24VJVnvfpwQtXjVREdelPNSiazhQHQkBTROX3Y4LRDgEFdxbA3cAzI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GvtEzi7L; arc=none smtp.client-ip=209.85.208.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GvtEzi7L" Received: by mail-lj1-f182.google.com with SMTP id 38308e7fff4ca-36a6a397477so59379771fa.3 for ; Tue, 07 Oct 2025 01:33:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1759826027; x=1760430827; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=56U4cHXm/XO+yZsN8UYLacC0NRz5ruIRpTT3AQstYVU=; b=GvtEzi7LO++FCpXY5Pwj6ebSKH/tNsC43rHTbEjrKqP9pbyRAfftAvC/UXWEtYd2br tnTvfmfAhtXi6sbjedf+dxL3BW3VDl29qv1VzlLq59hYB6TtF+QD6ovw/exd621bMXir EZ3rJwkIMKpK0cbzuZv9VAlxXybRJ6iGTSs3qj5GofZ7aAqEsAAl0twjRFz8Z6hvHpoI ElJuWOHKQ6wgPA76saqaP066ZYmuFx5JOVN7xn1zahPLdvBhuKiKacQz64LF4d/UQYqf e2V3rJo3Z5jHjwLaYEUMOUfhGcqboT1Outv1Pl1NDP+bp/IsD6kNOZcTnjPZWXGjoLfz Xwig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759826027; x=1760430827; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=56U4cHXm/XO+yZsN8UYLacC0NRz5ruIRpTT3AQstYVU=; b=eX2cbe10qKrW19znyUQPwLBDM1sRxZrTONtgMdJyWuFEHgw8lgI/36Dv62xKbTFGWW fceuc4Et1YbBtzPzRraQWbT1V/J9XElgt9PfLNeentc5wrCJsHEgEQPUPIMiU6VEO3Cf TXgPGQX6rh6EWAqDKh8nj68qbxRWsVCDsZuFbftKnf/nwjWTAmnzsqiVSZjD/Qes6JPv buS9hbP1yP90vCb9gPjoMT7aA16RmZUDDLEL5EYbn7/QSwglcJq3nsICzwml1+cpa06a 02BE8Fkz4YuZDiK4ogdXMuVEtbl20eqwhY2OOqvyBn+yuFtvEMoWu2HV9nKQaT+C+f8P +pcg== X-Forwarded-Encrypted: i=1; AJvYcCVFE4yNxU6ABbJwDsPJxy3VgdDXAeYl+n++oGDmIHeB1lnyeV1L6CYPEqSkPmmpKChEGwvVIMmREpino58=@vger.kernel.org X-Gm-Message-State: AOJu0YyoCbHtbp0jVhj2EsRuEjlXpXSjKGdS23ZcgvGD33j1t5AHL4Wf 45yVVJA69ml+TComE4s+TVBhnK3fpT1d+DIMzsNxeGJBBLp3/fa5e26N X-Gm-Gg: ASbGncsCC/4jCWfGC8DyI1EPgmuETN0uJf3sXTEx9+8dQxYTarLLnrdtE//0mlRXd/K ccJnWuxuNIFoafmMrllgigZk9rE1IQBj+0JYhNwcHxwXzNzAHoZjwk3s5YsdOtHwJ6kB0Z8Z8yf maUb5MoIJGE9jkXO31EzQLkvEv4QI31KdiY9u1KwgtbP0Dp+WaU6fjSxqfpO3/SMZUGlJnqGp2R xAWt1SFCC+EVc1RgQT9o2zqXzh47aAg4nGGjDa4VAgN4uQaH70dgvHrGKZXy+NrvSx2RsK4z+gx aEzrbkzYljueUy8dRhjq8e6+JDEu2BZ37AudvVFx+UDek9gk7r4NLW+zK0Glkokwjy0d3nbu0Ua QiOOtM9NkZGX25++dICLTZxm9AkEgzkUi6uIpyyrCnT4+w4jBqWp5iw== X-Google-Smtp-Source: AGHT+IFPlR5J0y/lc2XUcE6O1X+JtlZJeu/GYYDJksj4es7AGQByzJg+EaWCHdJkoi6q7phUr464xA== X-Received: by 2002:a05:6512:39d4:b0:57e:7040:9c77 with SMTP id 2adb3069b0e04-58cbba0232bmr5051448e87.38.1759826027136; Tue, 07 Oct 2025 01:33:47 -0700 (PDT) Received: from mva-rohm ([2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-58b0112480fsm5865665e87.21.2025.10.07.01.33.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Oct 2025 01:33:45 -0700 (PDT) Date: Tue, 7 Oct 2025 11:33:42 +0300 From: Matti Vaittinen To: Matti Vaittinen , Matti Vaittinen Cc: Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Sebastian Reichel , Liam Girdwood , Mark Brown , Linus Walleij , Bartosz Golaszewski , Matti Vaittinen , Andreas Kemnade , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-gpio@vger.kernel.org Subject: [RFC PATCH 05/13] dt-bindings: leds: bd72720: Add BD72720 Message-ID: <52a4df1a12f6b480150187d956d0fcd57fe626d1.1759824376.git.mazziesaccount@gmail.com> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Hl5GOwGd5SzFL3hD" Content-Disposition: inline In-Reply-To: --Hl5GOwGd5SzFL3hD Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Add the ROHM BD72720 documentation to the binding documents. Signed-off-by: Matti Vaittinen --- NOTE: The Linux LED driver does currently have: values bd72720-grnled and bd72720-ambled for the rohm,led-compatible. These are handled identically to the existing bd71828-grnled and bd71828-ambled and should be removed from the driver. Thus they are not documented in the binding document. Furthermore, the BD72720 Linux driver does not use the compatible property from the LED node. The Linux driver is load and probed based on the PMIC compatible in the MFD node. Thus no compatible string for the BD72720 LED node is added. --- .../devicetree/bindings/leds/rohm,bd71828-leds.yaml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/leds/rohm,bd71828-leds.yaml = b/Documentation/devicetree/bindings/leds/rohm,bd71828-leds.yaml index b7a3ef76cbf4..64cc40523e3d 100644 --- a/Documentation/devicetree/bindings/leds/rohm,bd71828-leds.yaml +++ b/Documentation/devicetree/bindings/leds/rohm,bd71828-leds.yaml @@ -10,11 +10,12 @@ maintainers: - Matti Vaittinen =20 description: | - This module is part of the ROHM BD71828 MFD device. For more details - see Documentation/devicetree/bindings/mfd/rohm,bd71828-pmic.yaml. + This module is part of the ROHM BD71828 and BD72720 MFD device. For more + details see Documentation/devicetree/bindings/mfd/rohm,bd71828-pmic.yaml + and Documentation/devicetree/bindings/mfd/rohm,bd72720-pmic.yaml =20 The LED controller is represented as a sub-node of the PMIC node on the = device - tree. + tree. This should be located under "leds" - node in PMIC node. =20 The device has two LED outputs referred as GRNLED and AMBLED in data-she= et. =20 --=20 2.51.0 --Hl5GOwGd5SzFL3hD Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEIx+f8wZb28fLKEhTeFA3/03aocUFAmjk0GYACgkQeFA3/03a ocWo9ggAj4GBq9go42smGGQBwidPKeFC80081lry80AjjqdeBzWn8ydINnkvdFVU OboKgpob0WwNIuyoripCr55U0emX7Pdg/SN9pMPanh2oWvN1A3dZLfPW07smIpfC jv0WPOIeBqCOfjNRbriaGHx3mGlfjcYEJrt4TMb8JlHJpvYRMDjNzDoGI3oUGEgR lqnXCPRgb76A+OT1Gnx9zDwm8p2PpVpOnutdlxQ3JtLKpH2XjKUqQM9RhOqJ7hme ElMvS16kznuAMzBGKD5ByXcYOlFaQlg2d8IMcnUM7W9PmkVKEzoeqfE4XHZN8ljy RW+XE1gvB9Lc2j88vgeXM9rMxGO0jw== =CW2a -----END PGP SIGNATURE----- --Hl5GOwGd5SzFL3hD-- From nobody Wed Feb 11 03:42:00 2026 Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3B5312E11D7 for ; Tue, 7 Oct 2025 08:34:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759826047; cv=none; b=N+RubevjT+dUfV0iKw+w5uq+YRFEVMpnX53PR08q0KV4krzNdLKMYn+HHWCGtL+qMOvo/3VsSVM1SlP+p0mRgg4bLfFbBVinkx5gQJNjKtJ7xikVJP09ut33Tbvc5Xx426+x8on6zcFD2c1BIXmz7tAZ7s2AGDlDmCB15ySrrag= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759826047; c=relaxed/simple; bh=+9ED0qXDlzPCc/C/95pQnMIk0CaF6AYpQ95PfzXMKEA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ejVvmaAq4YPCmJIj7SmYeDW/80sqysujzQui94CuqBn0PAF05OHhgc9AO5mV5Baedcj4vCdk5gTNyUlLWTi6FCQsVgJHPuDTvNTGrZftN/bVWaRYC8pq//JRiXwZnKiZnCzyXinodZ7xwP+IWfgurNXzdKQQlofPqiZg4iTKEJk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ikGFYpBp; arc=none smtp.client-ip=209.85.167.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ikGFYpBp" Received: by mail-lf1-f52.google.com with SMTP id 2adb3069b0e04-579363a4602so6722721e87.0 for ; Tue, 07 Oct 2025 01:34:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1759826040; x=1760430840; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=gEWzELQWpFwkycmZ4StjAvB2MyjdzS7N3jqRE72kbwg=; b=ikGFYpBpCbHNBDyV7LPLhv0+h2bq+RISgjjYLOrYnq/X4U5oliiX62yxxNN/4bKtIb dDUEi0xSR2t0CVzFNsMzL8V8LweH2dKkhOqCdpPW0/repWar4OcOqG2frxYvbLMI7G0y uWVrXqppO4CWiCjiPygHQhiFeMOalyfM8kMAyUydoVHf8kMKzhJXqP5BzduqG1qYX9AD 03EYC7mRwb93vFPSaAQDpAudYVc2j4UD8erK8ePBv2u/gKGSjTqAPZd6BvnBz64ooAXp ZjP8NWtDz16B6jXHG4vygqq0bEJFMJR8mN/vto0Rz9fPt/9ocewJILPJg8J8woHQyBVr LX5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759826040; x=1760430840; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=gEWzELQWpFwkycmZ4StjAvB2MyjdzS7N3jqRE72kbwg=; b=ukhkKQ5uDt68SjWCaQnbuuARxXViv2jUF9n3/XIctZAba3keaqpniQLWHNcF4SGmu/ k8ovJhxi0oqGap+Oykb/WUA5UgrCy0WQojQfRffcmZpXDNABvTJfP83VbcGFCTUQc+pO w0D/Y57rIUv75cAfdW19ijYlvkRWEIaFaMbRCCA6Zl6VPpZD2ct8HEUF5NOlBdS/Asx1 H7LGbNXtA4xsNTXq8qNDJ+FtKDanHVMLt2t/weFW1UgTrTFRa39mOoSs+vkJo56j+Qxl S2LZny5EsxhfdqYmWGCLuGMbvoR136Rhndbn0gRnTAE+6VtNj9zv0RxBA6xnKmtTDQV1 On8Q== X-Forwarded-Encrypted: i=1; AJvYcCUv4B52BvkKX/28Icr7Az3MxMiBHbABMDfi9TQ0r71VOk8A/uYofZ3Z+mXcNY6vjb9VvE33qcGht9FqHpM=@vger.kernel.org X-Gm-Message-State: AOJu0YzWmYD0pOqlnbC5NfnlG3lM/idkOhjq8k4p2CrRbcwsW81yUZOd wZqSZxdLzU3ry+Hmu5/BhwoZBFHeqGLOw0dsxmU9U9zHaFS05kE7EVUp X-Gm-Gg: ASbGncvDb0QrynGNftffWWtmlu2I9RSm0jY3Q/SYY16wc+9SIFzewbalYSICsBPAzIw 3LQVIeU/WQYG/i28KalFr2p3FP7HTjo1L9d5P8I5NpkKb1boOI/1/Ubszp0qvO64QKJs6ta1RSD qIwKrSF7NcPLlExNrWvb6eLXgr57ElkwNnd5LPGRuKPDLtyUzumasjK9OuPyQrGmiepznQqcgY/ 2yxPLFKifnhKMQusQjYzhdycmK6wN0CBPT5pjsJfcRYN0Jt5drFMfzcIxU/ZhYSLquSKXGVH7zd lTpd2wEgOpSTPueegvQKbIcWMteqtGbSxvlsBuS0287dKFcK2JDM2oB+0YhMkRC7zNTuZP3plf6 Uu7coaPdlXaY28/WgZCRaIRpLl5WiKYenzC4sLpoLH3NEKfE9ksWMnw== X-Google-Smtp-Source: AGHT+IEtgC/vrnqImugv0UHw8Vw3kpsK2HiYhiCO2++ZQdxrYz85R4DHZrNWUkJCFaKuhzy6EDx4TQ== X-Received: by 2002:a05:6512:1381:b0:57d:d62e:b226 with SMTP id 2adb3069b0e04-58cbba02d8fmr5172906e87.44.1759826039820; Tue, 07 Oct 2025 01:33:59 -0700 (PDT) Received: from mva-rohm ([2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-58b011aa88dsm5921859e87.118.2025.10.07.01.33.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Oct 2025 01:33:58 -0700 (PDT) Date: Tue, 7 Oct 2025 11:33:54 +0300 From: Matti Vaittinen To: Matti Vaittinen , Matti Vaittinen Cc: Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Sebastian Reichel , Liam Girdwood , Mark Brown , Linus Walleij , Bartosz Golaszewski , Matti Vaittinen , Andreas Kemnade , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-gpio@vger.kernel.org Subject: [RFC PATCH 06/13] mfd: bd71828: Support ROHM BD72720 Message-ID: <93142a80d90a0ac80b27090d0c83914675aad94d.1759824376.git.mazziesaccount@gmail.com> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="rIYzeKsbmP12I0sE" Content-Disposition: inline In-Reply-To: --rIYzeKsbmP12I0sE Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" The ROHM BD72720 is a power management IC which continues the BD71828 family of PMICs. Similarly to the BD71815 and BD71828, the BD72720 integrates regulators, charger, RTC, clock gate and GPIOs. The main difference to the earlier PMICs is that the BD72720 has two different I2C slave addresses. In addition to the registers behind the 'main I2C address', most of the charger (and to some extent LED) control is done via registers behind a 'secondary I2C slave address', 0x4c. Signed-off-by: Matti Vaittinen --- Note: This patch depends on the series: "power: supply: add charger for BD71828" by Andreas: https://lore.kernel.org/all/20250918-bd71828-charger-v5-0-851164839c28@kemn= ade.info/ There are some new variants being planned. Most notably, the BD73900 should be almost identical to the BD72720 - for everything else except the charger block. --- drivers/mfd/Kconfig | 18 +- drivers/mfd/rohm-bd71828.c | 429 ++++++++++++++++++++- include/linux/mfd/rohm-bd72720.h | 632 +++++++++++++++++++++++++++++++ include/linux/mfd/rohm-generic.h | 1 + 4 files changed, 1070 insertions(+), 10 deletions(-) create mode 100644 include/linux/mfd/rohm-bd72720.h diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig index 425c5fba6cb1..d968b7a13e34 100644 --- a/drivers/mfd/Kconfig +++ b/drivers/mfd/Kconfig @@ -2170,20 +2170,22 @@ config MFD_ROHM_BD718XX and emergency shut down as well as 32,768KHz clock output. =20 config MFD_ROHM_BD71828 - tristate "ROHM BD71828 and BD71815 Power Management IC" + tristate "ROHM BD718[15/28/79], BD72720 and BD73900 PMICs" depends on I2C=3Dy depends on OF select REGMAP_I2C select REGMAP_IRQ select MFD_CORE help - Select this option to get support for the ROHM BD71828 and BD71815 - Power Management ICs. BD71828GW and BD71815AGW are single-chip power - management ICs mainly for battery-powered portable devices. - The BD71828 integrates 7 buck converters and 7 LDOs. The BD71815 - has 5 bucks, 7 LDOs, and a boost for driving LEDs. Both ICs provide - also a single-cell linear charger, a Coulomb counter, a real-time - clock (RTC), GPIOs and a 32.768 kHz clock gate. + Select this option to get support for the ROHM BD71815, BD71828, + BD71879, BD72720 and BD73900 Power Management ICs. These are + single-chip power management ICs mainly for battery-powered portable + devices. + The BD71815 has 5 bucks, 7 LDOs, and a boost for driving LEDs. + The BD718[28/79] have 7 buck converters and 7 LDOs. + The BD72720 and the BD73900 have 10 bucks and 11 LDOs. + All ICs provide a single-cell linear charger, a Coulomb counter, + a real-time clock (RTC), GPIOs and a 32.768 kHz clock gate. =20 config MFD_ROHM_BD957XMUF tristate "ROHM BD9576MUF and BD9573MUF Power Management ICs" diff --git a/drivers/mfd/rohm-bd71828.c b/drivers/mfd/rohm-bd71828.c index 84a64c3b9c9f..3516f599493e 100644 --- a/drivers/mfd/rohm-bd71828.c +++ b/drivers/mfd/rohm-bd71828.c @@ -2,7 +2,7 @@ // // Copyright (C) 2019 ROHM Semiconductors // -// ROHM BD71828/BD71815 PMIC driver +// ROHM BD718[15/28/79] and BD72720 PMIC driver =20 #include #include @@ -13,12 +13,29 @@ #include #include #include +#include #include #include #include #include #include =20 +#define BD72720_TYPED_IRQ_REG(_irq, _stat_offset, _mask, _type_offset) = \ + [_irq] =3D { \ + .reg_offset =3D (_stat_offset), \ + .mask =3D (_mask), \ + { \ + .type_reg_offset =3D (_type_offset), \ + .type_reg_mask =3D BD72720_GPIO_IRQ_TYPE_MASK, \ + .type_rising_val =3D BD72720_GPIO_IRQ_TYPE_RISING, \ + .type_falling_val =3D BD72720_GPIO_IRQ_TYPE_FALLING, \ + .type_level_low_val =3D BD72720_GPIO_IRQ_TYPE_LOW, \ + .type_level_high_val =3D BD72720_GPIO_IRQ_TYPE_HIGH, \ + .types_supported =3D IRQ_TYPE_EDGE_BOTH | \ + IRQ_TYPE_LEVEL_HIGH | IRQ_TYPE_LEVEL_LOW, \ + }, \ + } + static struct gpio_keys_button button =3D { .code =3D KEY_POWER, .gpio =3D -1, @@ -43,6 +60,12 @@ static const struct resource bd71828_rtc_irqs[] =3D { DEFINE_RES_IRQ_NAMED(BD71828_INT_RTC2, "bd70528-rtc-alm-2"), }; =20 +static const struct resource bd72720_rtc_irqs[] =3D { + DEFINE_RES_IRQ_NAMED(BD72720_INT_RTC0, "bd70528-rtc-alm-0"), + DEFINE_RES_IRQ_NAMED(BD72720_INT_RTC1, "bd70528-rtc-alm-1"), + DEFINE_RES_IRQ_NAMED(BD72720_INT_RTC2, "bd70528-rtc-alm-2"), +}; + static const struct resource bd71815_power_irqs[] =3D { DEFINE_RES_IRQ_NAMED(BD71815_INT_DCIN_RMV, "bd71815-dcin-rmv"), DEFINE_RES_IRQ_NAMED(BD71815_INT_CLPS_OUT, "bd71815-dcin-clps-out"), @@ -156,6 +179,78 @@ static struct mfd_cell bd71828_mfd_cells[] =3D { }, }; =20 +static const struct resource bd72720_power_irqs[] =3D { + DEFINE_RES_IRQ_NAMED(BD72720_INT_VBUS_RMV, "bd72720_int_vbus_rmv"), + DEFINE_RES_IRQ_NAMED(BD72720_INT_VBUS_DET, "bd72720_int_vbus_det"), + DEFINE_RES_IRQ_NAMED(BD72720_INT_VBUS_MON_RES, "bd72720_int_vbus_mon_res"= ), + DEFINE_RES_IRQ_NAMED(BD72720_INT_VBUS_MON_DET, "bd72720_int_vbus_mon_det"= ), + DEFINE_RES_IRQ_NAMED(BD72720_INT_VSYS_MON_RES, "bd72720_int_vsys_mon_res"= ), + DEFINE_RES_IRQ_NAMED(BD72720_INT_VSYS_MON_DET, "bd72720_int_vsys_mon_det"= ), + DEFINE_RES_IRQ_NAMED(BD72720_INT_VSYS_UV_RES, "bd72720_int_vsys_uv_res"), + DEFINE_RES_IRQ_NAMED(BD72720_INT_VSYS_UV_DET, "bd72720_int_vsys_uv_det"), + DEFINE_RES_IRQ_NAMED(BD72720_INT_VSYS_LO_RES, "bd72720_int_vsys_lo_res"), + DEFINE_RES_IRQ_NAMED(BD72720_INT_VSYS_LO_DET, "bd72720_int_vsys_lo_det"), + DEFINE_RES_IRQ_NAMED(BD72720_INT_VSYS_OV_RES, "bd72720_int_vsys_ov_res"), + DEFINE_RES_IRQ_NAMED(BD72720_INT_VSYS_OV_DET, "bd72720_int_vsys_ov_det"), + DEFINE_RES_IRQ_NAMED(BD72720_INT_BAT_ILIM, "bd72720_int_bat_ilim"), + DEFINE_RES_IRQ_NAMED(BD72720_INT_CHG_DONE, "bd72720_int_chg_done"), + DEFINE_RES_IRQ_NAMED(BD72720_INT_EXTEMP_TOUT, "bd72720_int_extemp_tout"), + DEFINE_RES_IRQ_NAMED(BD72720_INT_CHG_WDT_EXP, "bd72720_int_chg_wdt_exp"), + DEFINE_RES_IRQ_NAMED(BD72720_INT_BAT_MNT_OUT, "bd72720_int_bat_mnt_out"), + DEFINE_RES_IRQ_NAMED(BD72720_INT_BAT_MNT_IN, "bd72720_int_bat_mnt_in"), + DEFINE_RES_IRQ_NAMED(BD72720_INT_CHG_TRNS, "bd72720_int_chg_trns"), + + DEFINE_RES_IRQ_NAMED(BD72720_INT_VBAT_MON_RES, "bd72720_int_vbat_mon_res"= ), + DEFINE_RES_IRQ_NAMED(BD72720_INT_VBAT_MON_DET, "bd72720_int_vbat_mon_det"= ), + DEFINE_RES_IRQ_NAMED(BD72720_INT_VBAT_SHT_RES, "bd72720_int_vbat_sht_res"= ), + DEFINE_RES_IRQ_NAMED(BD72720_INT_VBAT_SHT_DET, "bd72720_int_vbat_sht_det"= ), + DEFINE_RES_IRQ_NAMED(BD72720_INT_VBAT_LO_RES, "bd72720_int_vbat_lo_res"), + DEFINE_RES_IRQ_NAMED(BD72720_INT_VBAT_LO_DET, "bd72720_int_vbat_lo_det"), + DEFINE_RES_IRQ_NAMED(BD72720_INT_VBAT_OV_RES, "bd72720_int_vbat_ov_res"), + DEFINE_RES_IRQ_NAMED(BD72720_INT_VBAT_OV_DET, "bd72720_int_vbat_ov_det"), + DEFINE_RES_IRQ_NAMED(BD72720_INT_BAT_RMV, "bd72720_int_bat_rmv"), + DEFINE_RES_IRQ_NAMED(BD72720_INT_BAT_DET, "bd72720_int_bat_det"), + DEFINE_RES_IRQ_NAMED(BD72720_INT_DBAT_DET, "bd72720_int_dbat_det"), + DEFINE_RES_IRQ_NAMED(BD72720_INT_BAT_TEMP_TRNS, "bd72720_int_bat_temp_trn= s"), + DEFINE_RES_IRQ_NAMED(BD72720_INT_LOBTMP_RES, "bd72720_int_lobtmp_res"), + DEFINE_RES_IRQ_NAMED(BD72720_INT_LOBTMP_DET, "bd72720_int_lobtmp_det"), + DEFINE_RES_IRQ_NAMED(BD72720_INT_OVBTMP_RES, "bd72720_int_ovbtmp_res"), + DEFINE_RES_IRQ_NAMED(BD72720_INT_OVBTMP_DET, "bd72720_int_ovbtmp_det"), + DEFINE_RES_IRQ_NAMED(BD72720_INT_OCUR1_RES, "bd72720_int_ocur1_res"), + DEFINE_RES_IRQ_NAMED(BD72720_INT_OCUR1_DET, "bd72720_int_ocur1_det"), + DEFINE_RES_IRQ_NAMED(BD72720_INT_OCUR2_RES, "bd72720_int_ocur2_res"), + DEFINE_RES_IRQ_NAMED(BD72720_INT_OCUR2_DET, "bd72720_int_ocur2_det"), + DEFINE_RES_IRQ_NAMED(BD72720_INT_OCUR3_RES, "bd72720_int_ocur3_res"), + DEFINE_RES_IRQ_NAMED(BD72720_INT_OCUR3_DET, "bd72720_int_ocur3_det"), + DEFINE_RES_IRQ_NAMED(BD72720_INT_CC_MON1_DET, "bd72720_int_cc_mon1_det"), + DEFINE_RES_IRQ_NAMED(BD72720_INT_CC_MON2_DET, "bd72720_int_cc_mon2_det"), + DEFINE_RES_IRQ_NAMED(BD72720_INT_CC_MON3_DET, "bd72720_int_cc_mon3_det"), +}; + +static struct regmap *bd72720_secondary_regmap; + +static const struct mfd_cell bd72720_mfd_cells[] =3D { + { .name =3D "bd72720-pmic", }, + { .name =3D "bd72720-gpio", }, + { .name =3D "bd72720-led", }, + { .name =3D "bd72720-clk", }, + { + .name =3D "bd72720-power", + .resources =3D bd72720_power_irqs, + .num_resources =3D ARRAY_SIZE(bd72720_power_irqs), + .platform_data =3D &bd72720_secondary_regmap, + .pdata_size =3D sizeof(bd72720_secondary_regmap), + }, { + .name =3D "bd72720-rtc", + .resources =3D bd72720_rtc_irqs, + .num_resources =3D ARRAY_SIZE(bd72720_rtc_irqs), + }, { + .name =3D "gpio-keys", + .platform_data =3D &bd71828_powerkey_data, + .pdata_size =3D sizeof(bd71828_powerkey_data), + }, +}; + static const struct regmap_range bd71815_volatile_ranges[] =3D { { .range_min =3D BD71815_REG_SEC, @@ -208,6 +303,95 @@ static const struct regmap_range bd71828_volatile_rang= es[] =3D { }, }; =20 +/* + * The BD72720 is an odd beast in that it contains two separate sets of + * registers, both starting from address 0x0. The twist is that these "pag= es" + * are behind different I2C slave addresses. Most of the registers are beh= ind + * a slave address 0x4b, which will be used as the "main" address for this + * device. + * Most of the charger related registers are located behind slave address = 0x4c. + * It is tempting to push the dealing with the charger registers and the e= xtra + * 0x4c device in power-supply driver - but perhaps it's better for the sa= ke of + * the cleaner re-use to deal with setting up all of the regmaps here. + * Furthermore, the LED stuff may need access to both of these devices. + */ +#define BD72720_SECONDARY_I2C_SLAVE 0x4c +static const struct regmap_range bd72720_volatile_ranges_4b[] =3D { + { + /* RESETSRC1 and 2 are write '1' to clear */ + .range_min =3D BD72720_REG_RESETSRC_1, + .range_max =3D BD72720_REG_RESETSRC_2, + }, { + .range_min =3D BD72720_REG_POWER_STATE, + .range_max =3D BD72720_REG_POWER_STATE, + }, { + /* The state indicator bit changes when new state is reached */ + .range_min =3D BD72720_REG_PS_CTRL_1, + .range_max =3D BD72720_REG_PS_CTRL_1, + }, { + .range_min =3D BD72720_REG_RCVNUM, + .range_max =3D BD72720_REG_RCVNUM, + }, { + .range_min =3D BD72720_REG_CONF, + .range_max =3D BD72720_REG_HALL_STAT, + }, { + .range_min =3D BD72720_REG_RTC_SEC, + .range_max =3D BD72720_REG_RTC_YEAR, + }, { + .range_min =3D BD72720_REG_INT_LVL1_STAT, + .range_max =3D BD72720_REG_INT_ETC2_SRC, + }, +}; + +static const struct regmap_range bd72720_precious_ranges_4b[] =3D { + { + .range_min =3D BD72720_REG_INT_LVL1_STAT, + .range_max =3D BD72720_REG_INT_ETC2_STAT, + }, +}; + +static const struct regmap_range bd72720_volatile_ranges_4c[] =3D { + { + /* Status information */ + .range_min =3D BD72720_REG_CHG_STATE, + .range_max =3D BD72720_REG_CHG_EN, + }, { + /* + * Under certain circumstances, write to some bits may be + * ignored + */ + .range_min =3D BD72720_REG_CHG_CTRL, + .range_max =3D BD72720_REG_CHG_CTRL, + }, { + /* + * TODO: Ensure this is used to advertise state, not (only?) to + * control it. + */ + .range_min =3D BD72720_REG_VSYS_STATE_STAT, + .range_max =3D BD72720_REG_VSYS_STATE_STAT, + }, { + /* Measured data */ + .range_min =3D BD72720_REG_VM_VBAT_U, + .range_max =3D BD72720_REG_VM_VF_L, + }, { + /* Self clearing bits */ + .range_min =3D BD72720_REG_VM_VSYS_SA_MINMAX_CTRL, + .range_max =3D BD72720_REG_VM_VSYS_SA_MINMAX_CTRL, + }, { + /* Counters, self clearing bits */ + .range_min =3D BD72720_REG_CC_CURCD_U, + .range_max =3D BD72720_REG_CC_CTRL, + }, { + /* Self clearing bits */ + .range_min =3D BD72720_REG_CC_CCNTD_CTRL, + .range_max =3D BD72720_REG_CC_CCNTD_CTRL, + }, { + /* Self clearing bits */ + .range_min =3D BD72720_REG_IMPCHK_CTRL, + .range_max =3D BD72720_REG_IMPCHK_CTRL, + }, +}; + static const struct regmap_access_table bd71815_volatile_regs =3D { .yes_ranges =3D &bd71815_volatile_ranges[0], .n_yes_ranges =3D ARRAY_SIZE(bd71815_volatile_ranges), @@ -218,6 +402,21 @@ static const struct regmap_access_table bd71828_volati= le_regs =3D { .n_yes_ranges =3D ARRAY_SIZE(bd71828_volatile_ranges), }; =20 +static const struct regmap_access_table bd72720_volatile_regs_4b =3D { + .yes_ranges =3D &bd72720_volatile_ranges_4b[0], + .n_yes_ranges =3D ARRAY_SIZE(bd72720_volatile_ranges_4b), +}; + +static const struct regmap_access_table bd72720_precious_regs_4b =3D { + .yes_ranges =3D &bd72720_precious_ranges_4b[0], + .n_yes_ranges =3D ARRAY_SIZE(bd72720_precious_ranges_4b), +}; + +static const struct regmap_access_table bd72720_volatile_regs_4c =3D { + .yes_ranges =3D &bd72720_volatile_ranges_4c[0], + .n_yes_ranges =3D ARRAY_SIZE(bd72720_volatile_ranges_4c), +}; + static const struct regmap_config bd71815_regmap =3D { .reg_bits =3D 8, .val_bits =3D 8, @@ -234,10 +433,28 @@ static const struct regmap_config bd71828_regmap =3D { .cache_type =3D REGCACHE_MAPLE, }; =20 +static const struct regmap_config bd72720_regmap_4b =3D { + .reg_bits =3D 8, + .val_bits =3D 8, + .volatile_table =3D &bd72720_volatile_regs_4b, + .precious_table =3D &bd72720_precious_regs_4b, + .max_register =3D BD72720_REG_INT_ETC2_SRC, + .cache_type =3D REGCACHE_MAPLE, +}; + +static const struct regmap_config bd72720_regmap_4c =3D { + .reg_bits =3D 8, + .val_bits =3D 8, + .volatile_table =3D &bd72720_volatile_regs_4c, + .max_register =3D BD72720_REG_IMPCHK_CTRL, + .cache_type =3D REGCACHE_MAPLE, +}; + /* * Mapping of main IRQ register bits to sub-IRQ register offsets so that w= e can * access corect sub-IRQ registers based on bits that are set in main IRQ - * register. BD71815 and BD71828 have same sub-register-block offests. + * register. BD71815 and BD71828 have same sub-register-block offests, the + * BD72720 has a different one. */ =20 static unsigned int bit0_offsets[] =3D {11}; /* RTC IRQ */ @@ -249,6 +466,15 @@ static unsigned int bit5_offsets[] =3D {3}; /* VSYS I= RQ */ static unsigned int bit6_offsets[] =3D {1, 2}; /* DCIN IRQ */ static unsigned int bit7_offsets[] =3D {0}; /* BUCK IRQ */ =20 +static unsigned int bd72720_bit0_offsets[] =3D {0, 1}; /* PS1 and PS2 */ +static unsigned int bd72720_bit1_offsets[] =3D {2, 3}; /* DVS1 and DVS2 */ +static unsigned int bd72720_bit2_offsets[] =3D {4}; /* VBUS */ +static unsigned int bd72720_bit3_offsets[] =3D {5}; /* VSYS */ +static unsigned int bd72720_bit4_offsets[] =3D {6}; /* CHG */ +static unsigned int bd72720_bit5_offsets[] =3D {7, 8}; /* BAT1 and BAT2 */ +static unsigned int bd72720_bit6_offsets[] =3D {9}; /* IBAT */ +static unsigned int bd72720_bit7_offsets[] =3D {10, 11}; /* ETC1 and ETC2 = */ + static const struct regmap_irq_sub_irq_map bd718xx_sub_irq_offsets[] =3D { REGMAP_IRQ_MAIN_REG_OFFSET(bit0_offsets), REGMAP_IRQ_MAIN_REG_OFFSET(bit1_offsets), @@ -260,6 +486,17 @@ static const struct regmap_irq_sub_irq_map bd718xx_sub= _irq_offsets[] =3D { REGMAP_IRQ_MAIN_REG_OFFSET(bit7_offsets), }; =20 +static const struct regmap_irq_sub_irq_map bd72720_sub_irq_offsets[] =3D { + REGMAP_IRQ_MAIN_REG_OFFSET(bd72720_bit0_offsets), + REGMAP_IRQ_MAIN_REG_OFFSET(bd72720_bit1_offsets), + REGMAP_IRQ_MAIN_REG_OFFSET(bd72720_bit2_offsets), + REGMAP_IRQ_MAIN_REG_OFFSET(bd72720_bit3_offsets), + REGMAP_IRQ_MAIN_REG_OFFSET(bd72720_bit4_offsets), + REGMAP_IRQ_MAIN_REG_OFFSET(bd72720_bit5_offsets), + REGMAP_IRQ_MAIN_REG_OFFSET(bd72720_bit6_offsets), + REGMAP_IRQ_MAIN_REG_OFFSET(bd72720_bit7_offsets), +}; + static const struct regmap_irq bd71815_irqs[] =3D { REGMAP_IRQ_REG(BD71815_INT_BUCK1_OCP, 0, BD71815_INT_BUCK1_OCP_MASK), REGMAP_IRQ_REG(BD71815_INT_BUCK2_OCP, 0, BD71815_INT_BUCK2_OCP_MASK), @@ -433,6 +670,118 @@ static const struct regmap_irq bd71828_irqs[] =3D { REGMAP_IRQ_REG(BD71828_INT_RTC2, 11, BD71828_INT_RTC2_MASK), }; =20 +static const struct regmap_irq bd72720_irqs[] =3D { + REGMAP_IRQ_REG(BD72720_INT_LONGPUSH, 0, BD72720_INT_LONGPUSH_MASK), + REGMAP_IRQ_REG(BD72720_INT_MIDPUSH, 0, BD72720_INT_MIDPUSH_MASK), + REGMAP_IRQ_REG(BD72720_INT_SHORTPUSH, 0, BD72720_INT_SHORTPUSH_MASK), + REGMAP_IRQ_REG(BD72720_INT_PUSH, 0, BD72720_INT_PUSH_MASK), + REGMAP_IRQ_REG(BD72720_INT_HALL_DET, 0, BD72720_INT_HALL_DET_MASK), + REGMAP_IRQ_REG(BD72720_INT_HALL_TGL, 0, BD72720_INT_HALL_TGL_MASK), + REGMAP_IRQ_REG(BD72720_INT_WDOG, 0, BD72720_INT_WDOG_MASK), + REGMAP_IRQ_REG(BD72720_INT_SWRESET, 0, BD72720_INT_SWRESET_MASK), + REGMAP_IRQ_REG(BD72720_INT_SEQ_DONE, 1, BD72720_INT_SEQ_DONE_MASK), + REGMAP_IRQ_REG(BD72720_INT_PGFAULT, 1, BD72720_INT_PGFAULT_MASK), + REGMAP_IRQ_REG(BD72720_INT_BUCK1_DVS, 2, BD72720_INT_BUCK1_DVS_MASK), + REGMAP_IRQ_REG(BD72720_INT_BUCK2_DVS, 2, BD72720_INT_BUCK2_DVS_MASK), + REGMAP_IRQ_REG(BD72720_INT_BUCK3_DVS, 2, BD72720_INT_BUCK3_DVS_MASK), + REGMAP_IRQ_REG(BD72720_INT_BUCK4_DVS, 2, BD72720_INT_BUCK4_DVS_MASK), + REGMAP_IRQ_REG(BD72720_INT_BUCK5_DVS, 2, BD72720_INT_BUCK5_DVS_MASK), + REGMAP_IRQ_REG(BD72720_INT_BUCK6_DVS, 2, BD72720_INT_BUCK6_DVS_MASK), + REGMAP_IRQ_REG(BD72720_INT_BUCK7_DVS, 2, BD72720_INT_BUCK7_DVS_MASK), + REGMAP_IRQ_REG(BD72720_INT_BUCK8_DVS, 2, BD72720_INT_BUCK8_DVS_MASK), + REGMAP_IRQ_REG(BD72720_INT_BUCK9_DVS, 3, BD72720_INT_BUCK9_DVS_MASK), + REGMAP_IRQ_REG(BD72720_INT_BUCK10_DVS, 3, BD72720_INT_BUCK10_DVS_MASK), + REGMAP_IRQ_REG(BD72720_INT_LDO1_DVS, 3, BD72720_INT_LDO1_DVS_MASK), + REGMAP_IRQ_REG(BD72720_INT_LDO2_DVS, 3, BD72720_INT_LDO2_DVS_MASK), + REGMAP_IRQ_REG(BD72720_INT_LDO3_DVS, 3, BD72720_INT_LDO3_DVS_MASK), + REGMAP_IRQ_REG(BD72720_INT_LDO4_DVS, 3, BD72720_INT_LDO4_DVS_MASK), + + REGMAP_IRQ_REG(BD72720_INT_VBUS_RMV, 4, BD72720_INT_VBUS_RMV_MASK), + REGMAP_IRQ_REG(BD72720_INT_VBUS_DET, 4, BD72720_INT_VBUS_DET_MASK), + REGMAP_IRQ_REG(BD72720_INT_VBUS_MON_RES, 4, BD72720_INT_VBUS_MON_RES_MASK= ), + REGMAP_IRQ_REG(BD72720_INT_VBUS_MON_DET, 4, BD72720_INT_VBUS_MON_DET_MASK= ), + REGMAP_IRQ_REG(BD72720_INT_VSYS_MON_RES, 5, BD72720_INT_VSYS_MON_RES_MASK= ), + REGMAP_IRQ_REG(BD72720_INT_VSYS_MON_DET, 5, BD72720_INT_VSYS_MON_DET_MASK= ), + REGMAP_IRQ_REG(BD72720_INT_VSYS_UV_RES, 5, BD72720_INT_VSYS_UV_RES_MASK), + REGMAP_IRQ_REG(BD72720_INT_VSYS_UV_DET, 5, BD72720_INT_VSYS_UV_DET_MASK), + REGMAP_IRQ_REG(BD72720_INT_VSYS_LO_RES, 5, BD72720_INT_VSYS_LO_RES_MASK), + REGMAP_IRQ_REG(BD72720_INT_VSYS_LO_DET, 5, BD72720_INT_VSYS_LO_DET_MASK), + REGMAP_IRQ_REG(BD72720_INT_VSYS_OV_RES, 5, BD72720_INT_VSYS_OV_RES_MASK), + REGMAP_IRQ_REG(BD72720_INT_VSYS_OV_DET, 5, BD72720_INT_VSYS_OV_DET_MASK), + REGMAP_IRQ_REG(BD72720_INT_BAT_ILIM, 6, BD72720_INT_BAT_ILIM_MASK), + REGMAP_IRQ_REG(BD72720_INT_CHG_DONE, 6, BD72720_INT_CHG_DONE_MASK), + REGMAP_IRQ_REG(BD72720_INT_EXTEMP_TOUT, 6, BD72720_INT_EXTEMP_TOUT_MASK), + REGMAP_IRQ_REG(BD72720_INT_CHG_WDT_EXP, 6, BD72720_INT_CHG_WDT_EXP_MASK), + REGMAP_IRQ_REG(BD72720_INT_BAT_MNT_OUT, 6, BD72720_INT_BAT_MNT_OUT_MASK), + REGMAP_IRQ_REG(BD72720_INT_BAT_MNT_IN, 6, BD72720_INT_BAT_MNT_IN_MASK), + REGMAP_IRQ_REG(BD72720_INT_CHG_TRNS, 6, BD72720_INT_CHG_TRNS_MASK), + + REGMAP_IRQ_REG(BD72720_INT_VBAT_MON_RES, 7, BD72720_INT_VBAT_MON_RES_MASK= ), + REGMAP_IRQ_REG(BD72720_INT_VBAT_MON_DET, 7, BD72720_INT_VBAT_MON_DET_MASK= ), + REGMAP_IRQ_REG(BD72720_INT_VBAT_SHT_RES, 7, BD72720_INT_VBAT_SHT_RES_MASK= ), + REGMAP_IRQ_REG(BD72720_INT_VBAT_SHT_DET, 7, BD72720_INT_VBAT_SHT_DET_MASK= ), + REGMAP_IRQ_REG(BD72720_INT_VBAT_LO_RES, 7, BD72720_INT_VBAT_LO_RES_MASK), + REGMAP_IRQ_REG(BD72720_INT_VBAT_LO_DET, 7, BD72720_INT_VBAT_LO_DET_MASK), + REGMAP_IRQ_REG(BD72720_INT_VBAT_OV_RES, 7, BD72720_INT_VBAT_OV_RES_MASK), + REGMAP_IRQ_REG(BD72720_INT_VBAT_OV_DET, 7, BD72720_INT_VBAT_OV_DET_MASK), + REGMAP_IRQ_REG(BD72720_INT_BAT_RMV, 8, BD72720_INT_BAT_RMV_MASK), + REGMAP_IRQ_REG(BD72720_INT_BAT_DET, 8, BD72720_INT_BAT_DET_MASK), + REGMAP_IRQ_REG(BD72720_INT_DBAT_DET, 8, BD72720_INT_DBAT_DET_MASK), + REGMAP_IRQ_REG(BD72720_INT_BAT_TEMP_TRNS, 8, BD72720_INT_BAT_TEMP_TRNS_MA= SK), + REGMAP_IRQ_REG(BD72720_INT_LOBTMP_RES, 8, BD72720_INT_LOBTMP_RES_MASK), + REGMAP_IRQ_REG(BD72720_INT_LOBTMP_DET, 8, BD72720_INT_LOBTMP_DET_MASK), + REGMAP_IRQ_REG(BD72720_INT_OVBTMP_RES, 8, BD72720_INT_OVBTMP_RES_MASK), + REGMAP_IRQ_REG(BD72720_INT_OVBTMP_DET, 8, BD72720_INT_OVBTMP_DET_MASK), + REGMAP_IRQ_REG(BD72720_INT_OCUR1_RES, 9, BD72720_INT_OCUR1_RES_MASK), + REGMAP_IRQ_REG(BD72720_INT_OCUR1_DET, 9, BD72720_INT_OCUR1_DET_MASK), + REGMAP_IRQ_REG(BD72720_INT_OCUR2_RES, 9, BD72720_INT_OCUR2_RES_MASK), + REGMAP_IRQ_REG(BD72720_INT_OCUR2_DET, 9, BD72720_INT_OCUR2_DET_MASK), + REGMAP_IRQ_REG(BD72720_INT_OCUR3_RES, 9, BD72720_INT_OCUR3_RES_MASK), + REGMAP_IRQ_REG(BD72720_INT_OCUR3_DET, 9, BD72720_INT_OCUR3_DET_MASK), + REGMAP_IRQ_REG(BD72720_INT_CC_MON1_DET, 10, BD72720_INT_CC_MON1_DET_MASK), + REGMAP_IRQ_REG(BD72720_INT_CC_MON2_DET, 10, BD72720_INT_CC_MON2_DET_MASK), + REGMAP_IRQ_REG(BD72720_INT_CC_MON3_DET, 10, BD72720_INT_CC_MON3_DET_MASK), +/* + * The GPIO1_IN and GPIO2_IN IRQs are generated from the PMIC's GPIO1 and = GPIO2 + * pins. Eg, they may be wired to other devices which can then use the PMI= C as + * an interrupt controller. The GPIO1 and GPIO2 can have the IRQ type + * specified. All of the types (falling, rising, and both edges as well as= low + * and high levels) are supported. + */ + BD72720_TYPED_IRQ_REG(BD72720_INT_GPIO1_IN, 10, BD72720_INT_GPIO1_IN_MASK= , 0), + BD72720_TYPED_IRQ_REG(BD72720_INT_GPIO2_IN, 10, BD72720_INT_GPIO2_IN_MASK= , 1), + REGMAP_IRQ_REG(BD72720_INT_VF125_RES, 11, BD72720_INT_VF125_RES_MASK), + REGMAP_IRQ_REG(BD72720_INT_VF125_DET, 11, BD72720_INT_VF125_DET_MASK), + REGMAP_IRQ_REG(BD72720_INT_VF_RES, 11, BD72720_INT_VF_RES_MASK), + REGMAP_IRQ_REG(BD72720_INT_VF_DET, 11, BD72720_INT_VF_DET_MASK), + REGMAP_IRQ_REG(BD72720_INT_RTC0, 11, BD72720_INT_RTC0_MASK), + REGMAP_IRQ_REG(BD72720_INT_RTC1, 11, BD72720_INT_RTC1_MASK), + REGMAP_IRQ_REG(BD72720_INT_RTC2, 11, BD72720_INT_RTC2_MASK), +}; + +static int bd72720_set_type_config(unsigned int **buf, unsigned int type, + const struct regmap_irq *irq_data, + int idx, void *irq_drv_data) +{ + const struct regmap_irq_type *t =3D &irq_data->type; + + /* + * The regmap IRQ ecpects IRQ_TYPE_EDGE_BOTH to be written to register + * as logical OR of the type_falling_val and type_rising_val. This is + * not how the BD72720 implements this configuration, hence we need + * to handle this specific case separately. + */ + if (type =3D=3D IRQ_TYPE_EDGE_BOTH) { + buf[0][idx] &=3D ~t->type_reg_mask; + buf[0][idx] |=3D BD72720_GPIO_IRQ_TYPE_BOTH; + + return 0; + } + + return regmap_irq_set_type_config_simple(buf, type, irq_data, idx, + irq_drv_data); +} + static const struct regmap_irq_chip bd71828_irq_chip =3D { .name =3D "bd71828_irq", .main_status =3D BD71828_REG_INT_MAIN, @@ -465,6 +814,28 @@ static const struct regmap_irq_chip bd71815_irq_chip = =3D { .irq_reg_stride =3D 1, }; =20 +static const unsigned int bd72720_irq_type_base =3D BD72720_REG_GPIO1_CTRL; + +static const struct regmap_irq_chip bd72720_irq_chip =3D { + .name =3D "bd72720_irq", + .main_status =3D BD72720_REG_INT_LVL1_STAT, + .irqs =3D &bd72720_irqs[0], + .num_irqs =3D ARRAY_SIZE(bd72720_irqs), + .status_base =3D BD72720_REG_INT_PS1_STAT, + .unmask_base =3D BD72720_REG_INT_PS1_EN, + .config_base =3D &bd72720_irq_type_base, + .num_config_bases =3D 1, + .num_config_regs =3D 2, + .set_type_config =3D bd72720_set_type_config, + .ack_base =3D BD72720_REG_INT_PS1_STAT, + .init_ack_masked =3D true, + .num_regs =3D 12, + .num_main_regs =3D 1, + .sub_reg_offsets =3D &bd72720_sub_irq_offsets[0], + .num_main_status_bits =3D 8, + .irq_reg_stride =3D 1, +}; + static int set_clk_mode(struct device *dev, struct regmap *regmap, int clkmode_reg) { @@ -511,6 +882,25 @@ static void bd71828_remove_poweroff(void *data) pm_power_off =3D NULL; } =20 +static int bd72720_get_secondary_regmap(struct i2c_client *i2c, + const struct mfd_cell *mfd, int cells) +{ + struct i2c_client *secondary_i2c; + + secondary_i2c =3D devm_i2c_new_dummy_device(&i2c->dev, i2c->adapter, + BD72720_SECONDARY_I2C_SLAVE); + if (IS_ERR(secondary_i2c)) + return dev_err_probe(&i2c->dev, PTR_ERR(secondary_i2c), + "Failed to get secondary I2C\n"); + + bd72720_secondary_regmap =3D devm_regmap_init_i2c(secondary_i2c, + &bd72720_regmap_4c); + if ((IS_ERR(bd72720_secondary_regmap))) + return PTR_ERR(bd72720_secondary_regmap); + + return 0; +} + static int bd71828_i2c_probe(struct i2c_client *i2c) { struct regmap_irq_chip_data *irq_data; @@ -523,6 +913,7 @@ static int bd71828_i2c_probe(struct i2c_client *i2c) int cells; int button_irq; int clkmode_reg; + int main_lvl_mask_reg =3D 0, main_lvl_val =3D 0; =20 if (!i2c->irq) { dev_err(&i2c->dev, "No IRQ configured\n"); @@ -554,6 +945,23 @@ static int bd71828_i2c_probe(struct i2c_client *i2c) */ button_irq =3D 0; break; + case ROHM_CHIP_TYPE_BD72720: + { + mfd =3D bd72720_mfd_cells; + cells =3D ARRAY_SIZE(bd72720_mfd_cells); + regmap_config =3D &bd72720_regmap_4b; + irqchip =3D &bd72720_irq_chip; + clkmode_reg =3D BD72720_REG_OUT32K; + button_irq =3D BD72720_INT_SHORTPUSH; + main_lvl_mask_reg =3D BD72720_REG_INT_LVL1_EN; + main_lvl_val =3D BD72720_MASK_LVL1_EN_ALL; + + ret =3D bd72720_get_secondary_regmap(i2c, mfd, cells); + if (ret) + return dev_err_probe(&i2c->dev, ret, + "Failed to initialize secondary I2C\n"); + break; + } default: dev_err(&i2c->dev, "Unknown device type"); return -EINVAL; @@ -573,6 +981,20 @@ static int bd71828_i2c_probe(struct i2c_client *i2c) dev_dbg(&i2c->dev, "Registered %d IRQs for chip\n", irqchip->num_irqs); =20 + /* + * On some ICs the main IRQ register has corresponding mask register. + * This is not handled by the regmap IRQ. Let's enable all the main + * level IRQs here. Further writes to the main level MASK is not + * needed because masking is handled by the per IRQ 2.nd level MASK + * registers. 2.nd level masks are handled by the regmap IRQ. + */ + if (main_lvl_mask_reg) { + ret =3D regmap_write(regmap, main_lvl_mask_reg, main_lvl_val); + if (ret) { + return dev_err_probe(&i2c->dev, ret, + "Failed to enable main level IRQs\n"); + } + } if (button_irq) { ret =3D regmap_irq_get_virq(irq_data, button_irq); if (ret < 0) @@ -614,6 +1036,9 @@ static const struct of_device_id bd71828_of_match[] = =3D { }, { .compatible =3D "rohm,bd71815", .data =3D (void *)ROHM_CHIP_TYPE_BD71815, + }, { + .compatible =3D "rohm,bd72720", + .data =3D (void *)ROHM_CHIP_TYPE_BD72720, }, { }, }; diff --git a/include/linux/mfd/rohm-bd72720.h b/include/linux/mfd/rohm-bd72= 720.h new file mode 100644 index 000000000000..856a6962b1b2 --- /dev/null +++ b/include/linux/mfd/rohm-bd72720.h @@ -0,0 +1,632 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ +/* + * Copyright 2024 ROHM Semiconductors. + * + * Author: Matti Vaittinen + */ + +#ifndef _MFD_BD72720_H +#define _MFD_BD72720_H + +#include + +enum { + BD72720_BUCK1, + BD72720_BUCK2, + BD72720_BUCK3, + BD72720_BUCK4, + BD72720_BUCK5, + BD72720_BUCK6, + BD72720_BUCK7, + BD72720_BUCK8, + BD72720_BUCK9, + BD72720_BUCK10, + BD72720_BUCK11, + BD72720_LDO1, + BD72720_LDO2, + BD72720_LDO3, + BD72720_LDO4, + BD72720_LDO5, + BD72720_LDO6, + BD72720_LDO7, + BD72720_LDO8, + BD72720_LDO9, + BD72720_LDO10, + BD72720_LDO11, + BD72720_REGULATOR_AMOUNT, +}; + +/* BD72720 interrupts */ +#define BD72720_INT_LONGPUSH_MASK BIT(0) +#define BD72720_INT_MIDPUSH_MASK BIT(1) +#define BD72720_INT_SHORTPUSH_MASK BIT(2) +#define BD72720_INT_PUSH_MASK BIT(3) +#define BD72720_INT_HALL_DET_MASK BIT(4) +#define BD72720_INT_HALL_TGL_MASK BIT(5) +#define BD72720_INT_WDOG_MASK BIT(6) +#define BD72720_INT_SWRESET_MASK BIT(7) +#define BD72720_INT_SEQ_DONE_MASK BIT(0) +#define BD72720_INT_PGFAULT_MASK BIT(4) +#define BD72720_INT_BUCK1_DVS_MASK BIT(0) +#define BD72720_INT_BUCK2_DVS_MASK BIT(1) +#define BD72720_INT_BUCK3_DVS_MASK BIT(2) +#define BD72720_INT_BUCK4_DVS_MASK BIT(3) +#define BD72720_INT_BUCK5_DVS_MASK BIT(4) +#define BD72720_INT_BUCK6_DVS_MASK BIT(5) +#define BD72720_INT_BUCK7_DVS_MASK BIT(6) +#define BD72720_INT_BUCK8_DVS_MASK BIT(7) +#define BD72720_INT_BUCK9_DVS_MASK BIT(0) +#define BD72720_INT_BUCK10_DVS_MASK BIT(1) +#define BD72720_INT_LDO1_DVS_MASK BIT(4) +#define BD72720_INT_LDO2_DVS_MASK BIT(5) +#define BD72720_INT_LDO3_DVS_MASK BIT(6) +#define BD72720_INT_LDO4_DVS_MASK BIT(7) +#define BD72720_INT_VBUS_RMV_MASK BIT(0) +#define BD72720_INT_VBUS_DET_MASK BIT(1) +#define BD72720_INT_VBUS_MON_RES_MASK BIT(2) +#define BD72720_INT_VBUS_MON_DET_MASK BIT(3) +#define BD72720_INT_VSYS_MON_RES_MASK BIT(0) +#define BD72720_INT_VSYS_MON_DET_MASK BIT(1) +#define BD72720_INT_VSYS_UV_RES_MASK BIT(2) +#define BD72720_INT_VSYS_UV_DET_MASK BIT(3) +#define BD72720_INT_VSYS_LO_RES_MASK BIT(4) +#define BD72720_INT_VSYS_LO_DET_MASK BIT(5) +#define BD72720_INT_VSYS_OV_RES_MASK BIT(6) +#define BD72720_INT_VSYS_OV_DET_MASK BIT(7) +#define BD72720_INT_BAT_ILIM_MASK BIT(0) +#define BD72720_INT_CHG_DONE_MASK BIT(1) +#define BD72720_INT_EXTEMP_TOUT_MASK BIT(2) +#define BD72720_INT_CHG_WDT_EXP_MASK BIT(3) +#define BD72720_INT_BAT_MNT_OUT_MASK BIT(4) +#define BD72720_INT_BAT_MNT_IN_MASK BIT(5) +#define BD72720_INT_CHG_TRNS_MASK BIT(7) +#define BD72720_INT_VBAT_MON_RES_MASK BIT(0) +#define BD72720_INT_VBAT_MON_DET_MASK BIT(1) +#define BD72720_INT_VBAT_SHT_RES_MASK BIT(2) +#define BD72720_INT_VBAT_SHT_DET_MASK BIT(3) +#define BD72720_INT_VBAT_LO_RES_MASK BIT(4) +#define BD72720_INT_VBAT_LO_DET_MASK BIT(5) +#define BD72720_INT_VBAT_OV_RES_MASK BIT(6) +#define BD72720_INT_VBAT_OV_DET_MASK BIT(7) +#define BD72720_INT_BAT_RMV_MASK BIT(0) +#define BD72720_INT_BAT_DET_MASK BIT(1) +#define BD72720_INT_DBAT_DET_MASK BIT(2) +#define BD72720_INT_BAT_TEMP_TRNS_MASK BIT(3) +#define BD72720_INT_LOBTMP_RES_MASK BIT(4) +#define BD72720_INT_LOBTMP_DET_MASK BIT(5) +#define BD72720_INT_OVBTMP_RES_MASK BIT(6) +#define BD72720_INT_OVBTMP_DET_MASK BIT(7) +#define BD72720_INT_OCUR1_RES_MASK BIT(0) +#define BD72720_INT_OCUR1_DET_MASK BIT(1) +#define BD72720_INT_OCUR2_RES_MASK BIT(2) +#define BD72720_INT_OCUR2_DET_MASK BIT(3) +#define BD72720_INT_OCUR3_RES_MASK BIT(4) +#define BD72720_INT_OCUR3_DET_MASK BIT(5) +#define BD72720_INT_CC_MON1_DET_MASK BIT(0) +#define BD72720_INT_CC_MON2_DET_MASK BIT(1) +#define BD72720_INT_CC_MON3_DET_MASK BIT(2) +#define BD72720_INT_GPIO1_IN_MASK BIT(4) +#define BD72720_INT_GPIO2_IN_MASK BIT(5) +#define BD72720_INT_VF125_RES_MASK BIT(0) +#define BD72720_INT_VF125_DET_MASK BIT(1) +#define BD72720_INT_VF_RES_MASK BIT(2) +#define BD72720_INT_VF_DET_MASK BIT(3) +#define BD72720_INT_RTC0_MASK BIT(4) +#define BD72720_INT_RTC1_MASK BIT(5) +#define BD72720_INT_RTC2_MASK BIT(6) + +enum { + /* + * The IRQs excluding GPIO1 and GPIO2 are ordered in a same way as the + * respective IRQ bits in status and mask registers are ordered. + * + * The BD72720_INT_GPIO1_IN and BD72720_INT_GPIO2_IN are IRQs which can + * be used by other devices. Let's have GPIO1 and GPIO2 as first IRQs + * here so we can use the regmap-IRQ with standard device tree xlate + * while devices connected to the BD72720 IRQ input pins can refer to + * the first two interrupt numbers in their device tree. If we placed + * BD72720_INT_GPIO1_IN and BD72720_INT_GPIO2_IN after the CC_MON_DET + * interrupts (like they are in the registers), the devices using + * BD72720 as an IRQ parent should refer the interrupts starting with + * an offset which might not be trivial to understand. + */ + BD72720_INT_GPIO1_IN, + BD72720_INT_GPIO2_IN, + BD72720_INT_LONGPUSH, + BD72720_INT_MIDPUSH, + BD72720_INT_SHORTPUSH, + BD72720_INT_PUSH, + BD72720_INT_HALL_DET, + BD72720_INT_HALL_TGL, + BD72720_INT_WDOG, + BD72720_INT_SWRESET, + BD72720_INT_SEQ_DONE, + BD72720_INT_PGFAULT, + BD72720_INT_BUCK1_DVS, + BD72720_INT_BUCK2_DVS, + BD72720_INT_BUCK3_DVS, + BD72720_INT_BUCK4_DVS, + BD72720_INT_BUCK5_DVS, + BD72720_INT_BUCK6_DVS, + BD72720_INT_BUCK7_DVS, + BD72720_INT_BUCK8_DVS, + BD72720_INT_BUCK9_DVS, + BD72720_INT_BUCK10_DVS, + BD72720_INT_LDO1_DVS, + BD72720_INT_LDO2_DVS, + BD72720_INT_LDO3_DVS, + BD72720_INT_LDO4_DVS, + BD72720_INT_VBUS_RMV, + BD72720_INT_VBUS_DET, + BD72720_INT_VBUS_MON_RES, + BD72720_INT_VBUS_MON_DET, + BD72720_INT_VSYS_MON_RES, + BD72720_INT_VSYS_MON_DET, + BD72720_INT_VSYS_UV_RES, + BD72720_INT_VSYS_UV_DET, + BD72720_INT_VSYS_LO_RES, + BD72720_INT_VSYS_LO_DET, + BD72720_INT_VSYS_OV_RES, + BD72720_INT_VSYS_OV_DET, + BD72720_INT_BAT_ILIM, + BD72720_INT_CHG_DONE, + BD72720_INT_EXTEMP_TOUT, + BD72720_INT_CHG_WDT_EXP, + BD72720_INT_BAT_MNT_OUT, + BD72720_INT_BAT_MNT_IN, + BD72720_INT_CHG_TRNS, + BD72720_INT_VBAT_MON_RES, + BD72720_INT_VBAT_MON_DET, + BD72720_INT_VBAT_SHT_RES, + BD72720_INT_VBAT_SHT_DET, + BD72720_INT_VBAT_LO_RES, + BD72720_INT_VBAT_LO_DET, + BD72720_INT_VBAT_OV_RES, + BD72720_INT_VBAT_OV_DET, + BD72720_INT_BAT_RMV, + BD72720_INT_BAT_DET, + BD72720_INT_DBAT_DET, + BD72720_INT_BAT_TEMP_TRNS, + BD72720_INT_LOBTMP_RES, + BD72720_INT_LOBTMP_DET, + BD72720_INT_OVBTMP_RES, + BD72720_INT_OVBTMP_DET, + BD72720_INT_OCUR1_RES, + BD72720_INT_OCUR1_DET, + BD72720_INT_OCUR2_RES, + BD72720_INT_OCUR2_DET, + BD72720_INT_OCUR3_RES, + BD72720_INT_OCUR3_DET, + BD72720_INT_CC_MON1_DET, + BD72720_INT_CC_MON2_DET, + BD72720_INT_CC_MON3_DET, + BD72720_INT_VF125_RES, + BD72720_INT_VF125_DET, + BD72720_INT_VF_RES, + BD72720_INT_VF_DET, + BD72720_INT_RTC0, + BD72720_INT_RTC1, + BD72720_INT_RTC2, +}; + +/* + * BD72720 Registers: + * The BD72720 has two sets of registers behind two different I2C slave + * addresses. "Common" registers being behind 0x4b, the charger registers + * being behind 0x4c. + */ +/* Registers behind I2C slave 0x4b */ +enum { + BD72720_REG_PRODUCT_ID, + BD72720_REG_MANUFACTURER_ID, + BD72720_REG_PMIC_REV_NUM, + BD72720_REG_NVM_REV_NUM, + BD72720_REG_BOOTSRC =3D 0x10, + BD72720_REG_RESETSRC_1, + BD72720_REG_RESETSRC_2, + BD72720_REG_RESETSRC_3, + BD72720_REG_RESETSRC_4, + BD72720_REG_RESETSRC_5, + BD72720_REG_RESETSRC_6, + BD72720_REG_RESETSRC_7, + BD72720_REG_POWER_STATE, + BD72720_REG_PS_CFG, + BD72720_REG_PS_CTRL_1, + BD72720_REG_PS_CTRL_2, + BD72720_REG_RCVCFG, + BD72720_REG_RCVNUM, + BD72720_REG_CRDCFG, + BD72720_REG_REX_CTRL, + + BD72720_REG_BUCK1_ON, + BD72720_REG_BUCK1_MODE, + /* Deep idle vsel */ + BD72720_REG_BUCK1_VSEL_DI, + /* Idle vsel */ + BD72720_REG_BUCK1_VSEL_I, + /* Suspend vsel */ + BD72720_REG_BUCK1_VSEL_S, + /* Run boot vsel */ + BD72720_REG_BUCK1_VSEL_RB, + /* Run0 ... run3 vsel */ + BD72720_REG_BUCK1_VSEL_RB0, + BD72720_REG_BUCK1_VSEL_RB1, + BD72720_REG_BUCK1_VSEL_RB2, + BD72720_REG_BUCK1_VSEL_RB3, + + BD72720_REG_BUCK2_ON, + BD72720_REG_BUCK2_MODE, + BD72720_REG_BUCK2_VSEL_DI, + BD72720_REG_BUCK2_VSEL_I, + BD72720_REG_BUCK2_VSEL_S, + /* Run vsel */ + BD72720_REG_BUCK2_VSEL_R, + + BD72720_REG_BUCK3_ON, + BD72720_REG_BUCK3_MODE, + BD72720_REG_BUCK3_VSEL_DI, + BD72720_REG_BUCK3_VSEL_I, + BD72720_REG_BUCK3_VSEL_S, + BD72720_REG_BUCK3_VSEL_R, + + BD72720_REG_BUCK4_ON, + BD72720_REG_BUCK4_MODE, + BD72720_REG_BUCK4_VSEL_DI, + BD72720_REG_BUCK4_VSEL_I, + BD72720_REG_BUCK4_VSEL_S, + BD72720_REG_BUCK4_VSEL_R, + + BD72720_REG_BUCK5_ON, + BD72720_REG_BUCK5_MODE, + BD72720_REG_BUCK5_VSEL, + + BD72720_REG_BUCK6_ON, + BD72720_REG_BUCK6_MODE, + BD72720_REG_BUCK6_VSEL, + + BD72720_REG_BUCK7_ON, + BD72720_REG_BUCK7_MODE, + BD72720_REG_BUCK7_VSEL, + + BD72720_REG_BUCK8_ON, + BD72720_REG_BUCK8_MODE, + BD72720_REG_BUCK8_VSEL, + + BD72720_REG_BUCK9_ON, + BD72720_REG_BUCK9_MODE, + BD72720_REG_BUCK9_VSEL, + + BD72720_REG_BUCK10_ON, + BD72720_REG_BUCK10_MODE, + BD72720_REG_BUCK10_VSEL, + + BD72720_REG_LDO1_ON, + BD72720_REG_LDO1_MODE1, + BD72720_REG_LDO1_MODE2, + BD72720_REG_LDO1_VSEL_DI, + BD72720_REG_LDO1_VSEL_I, + BD72720_REG_LDO1_VSEL_S, + BD72720_REG_LDO1_VSEL_RB, + BD72720_REG_LDO1_VSEL_R0, + BD72720_REG_LDO1_VSEL_R1, + BD72720_REG_LDO1_VSEL_R2, + BD72720_REG_LDO1_VSEL_R3, + + BD72720_REG_LDO2_ON, + BD72720_REG_LDO2_MODE, + BD72720_REG_LDO2_VSEL_DI, + BD72720_REG_LDO2_VSEL_I, + BD72720_REG_LDO2_VSEL_S, + BD72720_REG_LDO2_VSEL_R, + + BD72720_REG_LDO3_ON, + BD72720_REG_LDO3_MODE, + BD72720_REG_LDO3_VSEL_DI, + BD72720_REG_LDO3_VSEL_I, + BD72720_REG_LDO3_VSEL_S, + BD72720_REG_LDO3_VSEL_R, + + BD72720_REG_LDO4_ON, + BD72720_REG_LDO4_MODE, + BD72720_REG_LDO4_VSEL_DI, + BD72720_REG_LDO4_VSEL_I, + BD72720_REG_LDO4_VSEL_S, + BD72720_REG_LDO4_VSEL_R, + + BD72720_REG_LDO5_ON, + BD72720_REG_LDO5_MODE, + BD72720_REG_LDO5_VSEL, + + BD72720_REG_LDO6_ON, + BD72720_REG_LDO6_MODE, + BD72720_REG_LDO6_VSEL, + + BD72720_REG_LDO7_ON, + BD72720_REG_LDO7_MODE, + BD72720_REG_LDO7_VSEL, + + BD72720_REG_LDO8_ON, + BD72720_REG_LDO8_MODE, + BD72720_REG_LDO8_VSEL, + + BD72720_REG_LDO9_ON, + BD72720_REG_LDO9_MODE, + BD72720_REG_LDO9_VSEL, + + BD72720_REG_LDO10_ON, + BD72720_REG_LDO10_MODE, + BD72720_REG_LDO10_VSEL, + + BD72720_REG_LDO11_ON, + BD72720_REG_LDO11_MODE, + BD72720_REG_LDO11_VSEL, + + BD72720_REG_GPIO1_ON =3D 0x8b, + BD72720_REG_GPIO2_ON, + BD72720_REG_GPIO3_ON, + BD72720_REG_GPIO4_ON, + BD72720_REG_GPIO5_ON, + + BD72720_REG_GPIO1_CTRL, + BD72720_REG_GPIO2_CTRL, +#define BD72720_GPIO_IRQ_TYPE_MASK GENMASK(6, 4) +#define BD72720_GPIO_IRQ_TYPE_FALLING 0x0 +#define BD72720_GPIO_IRQ_TYPE_RISING 0x1 +#define BD72720_GPIO_IRQ_TYPE_BOTH 0x2 +#define BD72720_GPIO_IRQ_TYPE_HIGH 0x3 +#define BD72720_GPIO_IRQ_TYPE_LOW 0x4 + BD72720_REG_GPIO3_CTRL, + BD72720_REG_GPIO4_CTRL, + BD72720_REG_GPIO5_CTRL, +#define BD72720_GPIO_DRIVE_MASK BIT(1) +#define BD72720_GPIO_HIGH BIT(0) + + BD72720_REG_EPDEN_CTRL, + BD72720_REG_GATECNT_CTRL, + BD72720_REG_LED_CTRL, + + BD72720_REG_PWRON_CFG1, + BD72720_REG_PWRON_CFG2, + + BD72720_REG_OUT32K, + BD72720_REG_CONF, + BD72720_REG_HALL_STAT, + + BD72720_REG_RTC_SEC =3D 0xa0, +#define BD72720_REG_RTC_START BD72720_REG_RTC_SEC + BD72720_REG_RTC_MIN, + BD72720_REG_RTC_HOUR, + BD72720_REG_RTC_WEEK, + BD72720_REG_RTC_DAY, + BD72720_REG_RTC_MON, + BD72720_REG_RTC_YEAR, + + BD72720_REG_RTC_ALM0_SEC, +#define BD72720_REG_RTC_ALM_START BD72720_REG_RTC_ALM0_SEC + BD72720_REG_RTC_ALM0_MIN, + BD72720_REG_RTC_ALM0_HOUR, + BD72720_REG_RTC_ALM0_WEEK, + BD72720_REG_RTC_ALM0_MON, + BD72720_REG_RTC_ALM0_YEAR, + + BD72720_REG_RTC_ALM1_SEC, + BD72720_REG_RTC_ALM1_MIN, + BD72720_REG_RTC_ALM1_HOUR, + BD72720_REG_RTC_ALM1_WEEK, + BD72720_REG_RTC_ALM1_MON, + BD72720_REG_RTC_ALM1_YEAR, + + BD72720_REG_RTC_ALM0_EN, + BD72720_REG_RTC_ALM1_EN, + BD72720_REG_RTC_ALM2, + + BD72720_REG_INT_LVL1_EN =3D 0xc0, +#define BD72720_MASK_LVL1_EN_ALL GENMASK(7, 0) + BD72720_REG_INT_PS1_EN, + BD72720_REG_INT_PS2_EN, + BD72720_REG_INT_DVS1_EN, + BD72720_REG_INT_DVS2_EN, + BD72720_REG_INT_VBUS_EN, + BD72720_REG_INT_VSYS_EN, + BD72720_REG_INT_CHG_EN, + BD72720_REG_INT_BAT1_EN, + BD72720_REG_INT_BAT2_EN, + BD72720_REG_INT_IBAT_EN, + BD72720_REG_INT_ETC1_EN, + BD72720_REG_INT_ETC2_EN, + + /* + * The _STAT registers inform IRQ line state, and are used to ack IRQ. + * The _SRC registers below indicate current state of the function + * connected to the line. + */ + BD72720_REG_INT_LVL1_STAT, + BD72720_REG_INT_PS1_STAT, + BD72720_REG_INT_PS2_STAT, + BD72720_REG_INT_DVS1_STAT, + BD72720_REG_INT_DVS2_STAT, + BD72720_REG_INT_VBUS_STAT, + BD72720_REG_INT_VSYS_STAT, + BD72720_REG_INT_CHG_STAT, + BD72720_REG_INT_BAT1_STAT, + BD72720_REG_INT_BAT2_STAT, + BD72720_REG_INT_IBAT_STAT, + BD72720_REG_INT_ETC1_STAT, + BD72720_REG_INT_ETC2_STAT, + + BD72720_REG_INT_LVL1_SRC, + BD72720_REG_INT_PS1_SRC, + BD72720_REG_INT_PS2_SRC, + BD72720_REG_INT_DVS1_SRC, + BD72720_REG_INT_DVS2_SRC, + BD72720_REG_INT_VBUS_SRC, +#define BD72720_MASK_DCIN_DET BIT(1) + BD72720_REG_INT_VSYS_SRC, + BD72720_REG_INT_CHG_SRC, + BD72720_REG_INT_BAT1_SRC, + BD72720_REG_INT_BAT2_SRC, + BD72720_REG_INT_IBAT_SRC, + BD72720_REG_INT_ETC1_SRC, + BD72720_REG_INT_ETC2_SRC, +}; + +/* Register masks */ +#define BD72720_MASK_DEEP_IDLE_EN BIT(0) +#define BD72720_MASK_IDLE_EN BIT(1) +#define BD72720_MASK_SUSPEND_EN BIT(2) +#define BD72720_MASK_RUN_B_EN BIT(3) +#define BD72720_MASK_RUN_0_EN BIT(4) +#define BD72720_MASK_RUN_1_EN BIT(5) +#define BD72720_MASK_RUN_2_EN BIT(6) +#define BD72720_MASK_RUN_3_EN BIT(7) + +#define BD72720_MASK_RAMP_UP_DELAY GENMASK(7, 6) +#define BD72720_MASK_BUCK_VSEL GENMASK(7, 0) +#define BD72720_MASK_LDO12346_VSEL GENMASK(6, 0) +#define BD72720_MASK_LDO_VSEL GENMASK(7, 0) + +/* Registers behind I2C slave 0x4c */ +enum { + BD72720_REG_CHG_STATE, + BD72720_REG_CHG_LAST_STATE, + BD72720_REG_CHG_VBUS_STAT, + BD72720_REG_CHG_VSYS_STAT, + BD72720_REG_CHG_BAT_TEMP_STAT, + BD72720_REG_CHG_WDT_STAT, + BD72720_REG_CHG_ILIM_STAT, + BD72720_REG_CHG_CHG_STAT, + BD72720_REG_CHG_EN, + BD72720_REG_CHG_INIT, + BD72720_REG_CHG_CTRL, + BD72720_REG_CHG_SET_1, + BD72720_REG_CHG_SET_2, + BD72720_REG_CHG_SET_3, + BD72720_REG_CHG_VPRE, + BD72720_REG_CHG_VBAT_1, + BD72720_REG_CHG_VBAT_2, + BD72720_REG_CHG_VBAT_3, + BD72720_REG_CHG_VBAT_4, + BD72720_REG_CHG_BAT_SET_1, + BD72720_REG_CHG_BAT_SET_2, + BD72720_REG_CHG_BAT_SET_3, + BD72720_REG_CHG_IPRE, + BD72720_REG_CHG_IFST_TERM, + BD72720_REG_CHG_VSYS_REG, + BD72720_REG_CHG_VBUS_SET, + BD72720_REG_CHG_WDT_PRE, + BD72720_REG_CHG_WDT_FST, + BD72720_REG_CHG_LED_CTRL, + BD72720_REG_CHG_CFG_1, + BD72720_REG_CHG_IFST_1, + BD72720_REG_CHG_IFST_2, + BD72720_REG_CHG_IFST_3, + BD72720_REG_CHG_IFST_4, + BD72720_REG_CHG_S_CFG_1, + BD72720_REG_CHG_S_CFG_2, + BD72720_REG_RS_VBUS, + BD72720_REG_RS_IBUS, + BD72720_REG_RS_VSYS, + BD72720_REG_VSYS_STATE_STAT, /* 0x27 */ + + BD72720_REG_VM_VBAT_U =3D 0x30, + BD72720_REG_VM_VBAT_L, + BD72720_REG_VM_OCV_PRE_U, + BD72720_REG_VM_OCV_PRE_L, + BD72720_REG_VM_OCV_PST_U, + BD72720_REG_VM_OCV_PST_L, + BD72720_REG_VM_OCV_PWRON_U, + BD72720_REG_VM_OCV_PWRON_L, + BD72720_REG_VM_DVBAT_IMP_U, + BD72720_REG_VM_DVBAT_IMP_L, + BD72720_REG_VM_SA_VBAT_U, + BD72720_REG_VM_SA_VBAT_L, + BD72720_REG_VM_SA_VBAT_MIN_U, + BD72720_REG_VM_SA_VBAT_MIN_L, + BD72720_REG_VM_SA_VBAT_MAX_U, + BD72720_REG_VM_SA_VBAT_MAX_L, + BD72720_REG_REX_SA_VBAT_U, + BD72720_REG_REX_SA_VBAT_L, + BD72720_REG_VM_VSYS_U, + BD72720_REG_VM_VSYS_L, + BD72720_REG_VM_SA_VSYS_U, + BD72720_REG_VM_SA_VSYS_L, + BD72720_REG_VM_SA_VSYS_MIN_U, + BD72720_REG_VM_SA_VSYS_MIN_L, + BD72720_REG_VM_SA_VSYS_MAX_U, + BD72720_REG_VM_SA_VSYS_MAX_L, + BD72720_REG_VM_SA2_VSYS_U, + BD72720_REG_VM_SA2_VSYS_L, + BD72720_REG_VM_VBUS_U, +#define BD72720_MASK_VDCIN_U GENMASK(3, 0) + BD72720_REG_VM_VBUS_L, + BD72720_REG_VM_BATID_U, + BD72720_REG_VM_BATID_L, + BD72720_REG_VM_BATID_NOLOAD_U, + BD72720_REG_VM_BATID_NOLOAD_L, + BD72720_REG_VM_BATID_OFS_U, + BD72720_REG_VM_BATID_OFS_L, + BD72720_REG_VM_VTH_U, + BD72720_REG_VM_VTH_L, + BD72720_REG_VM_VTH_CORR_U, + BD72720_REG_VM_VTH_CORR_L, + BD72720_REG_VM_BTMP_U, + BD72720_REG_VM_BTMP_L, + BD72720_REG_VM_BTMP_IMP_U, + BD72720_REG_VM_BTMP_IMP_L, + BD72720_REG_VM_VF_U, + BD72720_REG_VM_VF_L, + BD72720_REG_VM_BATID_TH_U, + BD72720_REG_VM_BATID_TH_L, + BD72720_REG_VM_BTMP_OV_THR, + BD72720_REG_VM_BTMP_OV_DUR, + BD72720_REG_VM_BTMP_LO_THR, + BD72720_REG_VM_BTMP_LO_DUR, + BD72720_REG_ALM_VBAT_TH_U, + BD72720_REG_ALM_VBAT_TH_L, + BD72720_REG_ALM_VSYS_TH, + BD72720_REG_ALM_VBUS_TH, + BD72720_REG_ALM_VF_TH, + BD72720_REG_VSYS_MAX, + BD72720_REG_VSYS_MIN, + BD72720_REG_VM_VSYS_SA_MINMAX_CTRL, + BD72720_REG_VM_SA_CFG, /* 0x6c */ + + BD72720_REG_CC_CURCD_U =3D 0x70, + BD72720_REG_CC_CURCD_L, + BD72720_REG_CC_CURCD_IMP_U, + BD72720_REG_CC_CURCD_IMP_L, + BD72720_REG_CC_SA_CURCD_U, + BD72720_REG_CC_SA_CURCD_L, + BD72720_REG_CC_OCUR_MON, + BD72720_REG_CC_CCNTD_3, + BD72720_REG_CC_CCNTD_2, + BD72720_REG_CC_CCNTD_1, + BD72720_REG_CC_CCNTD_0, + BD72720_REG_REX_CCNTD_3, + BD72720_REG_REX_CCNTD_2, + BD72720_REG_REX_CCNTD_1, + BD72720_REG_REX_CCNTD_0, + BD72720_REG_FULL_CCNTD_3, + BD72720_REG_FULL_CCNTD_2, + BD72720_REG_FULL_CCNTD_1, + BD72720_REG_FULL_CCNTD_0, + BD72720_REG_CCNTD_CHG_3, + BD72720_REG_CCNTD_CHG_2, + BD72720_REG_CC_STAT, + BD72720_REG_CC_CTRL, + BD72720_REG_CC_OCUR_THR_1, + BD72720_REG_CC_OCUR_THR_2, + BD72720_REG_CC_OCUR_THR_3, + BD72720_REG_REX_CURCD_TH, + BD72720_REG_CC_BATCAP1_TH_U, + BD72720_REG_CC_BATCAP1_TH_L, + BD72720_REG_CC_BATCAP2_TH_U, + BD72720_REG_CC_BATCAP2_TH_L, + BD72720_REG_CC_BATCAP3_TH_U, + BD72720_REG_CC_BATCAP3_TH_L, + BD72720_REG_CC_CCNTD_CTRL, + BD72720_REG_CC_SA_CFG, /* 0x92 */ + BD72720_REG_IMPCHK_CTRL =3D 0xa0, +}; + +#endif /* __LINUX_MFD_BD72720_H */ diff --git a/include/linux/mfd/rohm-generic.h b/include/linux/mfd/rohm-gene= ric.h index 579e8dcfcca4..0a284919a6c3 100644 --- a/include/linux/mfd/rohm-generic.h +++ b/include/linux/mfd/rohm-generic.h @@ -16,6 +16,7 @@ enum rohm_chip_type { ROHM_CHIP_TYPE_BD71828, ROHM_CHIP_TYPE_BD71837, ROHM_CHIP_TYPE_BD71847, + ROHM_CHIP_TYPE_BD72720, ROHM_CHIP_TYPE_BD96801, ROHM_CHIP_TYPE_BD96802, ROHM_CHIP_TYPE_BD96805, --=20 2.51.0 --rIYzeKsbmP12I0sE Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEIx+f8wZb28fLKEhTeFA3/03aocUFAmjk0HIACgkQeFA3/03a ocUeKAgAp8seoMtYSCE/Vc06cSpvRckZcGC7k315GYqHEmaxsu0C/y+0YyJPPDkE sjbq9zL0oNwc1C6Cmwd69bH3Qq+HwoNWmlzoIqlFctZAJqkz1Q+A1y1jpIVgl8kf 1TUh7ZDwPNZfgDCDtTp2JOZfWzFcc+z7vy6CYLCOwMzAp7Sq9h+lYNeLqmngrlwR kbl+06QQAEaesZMKWRZJ11EFTg5JBV92kyLFrikimCtnxRa5hYg/DvPDl/EFBUoE ojSqPnt+IUJnjXHHFQulfgZPk3EpVx9iZMrJeRPeX+eYJwbwwY35L3+eo/XkPPCL EQWQWbE3GzSyaoS2xM7YrPpOpI1g0g== =N3vj -----END PGP SIGNATURE----- --rIYzeKsbmP12I0sE-- From nobody Wed Feb 11 03:42:00 2026 Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com [209.85.167.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 77DA22E11CB for ; Tue, 7 Oct 2025 08:34:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759826057; cv=none; b=MoKsbeDHHtJ6JyU4uG+HVNZ6UMhX0HuZ3d/A/896+7iPIXR0XhFc2ZuPvCUAT1zkOYgEwe3+6QbR+TaFHw58P0Ccxc2hQYNBXDAb43J2V1O4SXjlVcSQJ84NF5RpYAO6HYottHokdEAJ9C1suEq4ceqMQj7Gr9FFIqqhWdsJoxo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759826057; c=relaxed/simple; bh=EKOut8hmXYdSZ53o9Jzr0vGYAwAl38Qo7PAaLbffE0o=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=TEf7Alp7lEVf7PwbilxtzzNR0rcf2oA6ybYcLE/NzWem5cJfzvUnLQiVHTVxRf+fYwHjMtykHzdytoax6EcJSJ+wHUe1uqEA2YDkxt7QNNU5rC+pC7z9tAXwx1opiW+6hFjHgJbHh2JvyWRdmHTuaHy5Wi/swz+7PXw0e1NkTLA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BYHbtva8; arc=none smtp.client-ip=209.85.167.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BYHbtva8" Received: by mail-lf1-f44.google.com with SMTP id 2adb3069b0e04-57db15eeb11so7392072e87.2 for ; Tue, 07 Oct 2025 01:34:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1759826052; x=1760430852; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=b8t4BEhNzT2f7TxIbIXtITKbbYiOenAeGicCLXkBHNY=; b=BYHbtva8tLo9dRAPPJ6ZpfT0DvOpvAOphGnJgg9o3nF/+c+rkAwX6noYz7s8G4pZSL fcSi5X4bIykinYrpVT9pMyQ73IKmzUrr9f6au83QApIfevZJ30v0FetE3GBQ55PtNNhg BRtHnjsJjvT2djj+c3X3M/exPzpzc84JInx/olpg3r6hwwYzv89B9BMGBpzCtY5u/RoX mftGTxodimuVIBwQmcC5+iWDLosLZtMivvXIBGbWhcyCy1RhlRxhF7GaXx6wivS6n+aa W76QflMYPAdPSE/cc/1E4nUi4Tu35jCmehKYrZmTIqB8m8iS1TaeaTnoVeOyxm4Rv84m wHRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759826052; x=1760430852; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=b8t4BEhNzT2f7TxIbIXtITKbbYiOenAeGicCLXkBHNY=; b=KdtMsizYoW0xRjNLme1MHGd56ULgoRktN+/fE3Ele1wrbNKtq+6TV/I9KjZ/euNoU5 TiKqtm/dTK/mcEHJgTXue3m6eZ/yXgc4yIOtTgZvy4MigQ0JJOocX3lIBpUUjSbuVMgk oqTRowybU4wi6OGjw5bI1RGsx+5xjhbXaUDyoFo3kc5KAFBy/+z7Ewz/hKzkmw3nSS53 Vrnd3rMQrWoxss3t7IA0kd/LDlARDOYvZpi8Gu+Wf4NRODaNnSDVhTURxg5oJIcIjy/H QHrWKv1SbTTIkteITomg+EE4+SCbJU9ZAjheHSzBlV7o2qM+09y+lXeLrbkH/TBS+4as sAHQ== X-Forwarded-Encrypted: i=1; AJvYcCWCd1feizU7dxXgGaVNpiFeFnF4WJowqBrRwNtRKtuyeigC9dOTeVwq5mwu9YsN0hbqptimGphEBkYzamo=@vger.kernel.org X-Gm-Message-State: AOJu0Yx7/zPLTjsuhJHe3ikuDRV2ZfIxa6TKjUcdq1VXE0q7z8mhi7JT HWcQRmGKUHc31dFrNaV680u51oLzFz0LssI6pbuN4EyD/Z9ClGOct7Yo X-Gm-Gg: ASbGncsZxNpHbudYQvcVlf9bMyQTKWRHNjQVBerPaR7WwZXaZgYAPPY5ozG5hYwsk8U KocdMM1uVbHBmYEKgvstE9CWSgb540Z9tt251C7Kb9OzgRA0R6WVzrkN8GLMu6GrCPjOMSdGwkX ooY5bdlu9g4Px1c7Roq7/XR6jTmCfpRPo4Pn4SwVSulwBmee5Ri1qQ3N0DazjR026AaEyIWI311 +4fNJgIZjuqtj0DwYcddlel13KyPpd8hb108bSzFWoxES0b5wGYux0bYQ9YSvisq5ONwTK3lGRJ Hh5EBhUdTvZns45sJuMgc2vtk9X9xYUxqcAcWuCsU6j4UJSedfg3m0m1mZPqThY7OyX592GomxO IM7LgDeiNH7FXO1qw9iZAuaCibq67pvyd/vc2dMh5f63b92XZ+H4xMg== X-Google-Smtp-Source: AGHT+IGrjcaPa+o4BHPNmNuxaoWMfFhafV/2QkeXOazUlCWvsu3VSc9Zta2eqE8CWytfvtp5cQX0+Q== X-Received: by 2002:a05:6512:3c9b:b0:57c:79b7:8c59 with SMTP id 2adb3069b0e04-58cbaaa2210mr4353624e87.23.1759826051248; Tue, 07 Oct 2025 01:34:11 -0700 (PDT) Received: from mva-rohm ([2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-58b0112428csm5868620e87.1.2025.10.07.01.34.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Oct 2025 01:34:10 -0700 (PDT) Date: Tue, 7 Oct 2025 11:34:06 +0300 From: Matti Vaittinen To: Matti Vaittinen , Matti Vaittinen Cc: Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Sebastian Reichel , Liam Girdwood , Mark Brown , Linus Walleij , Bartosz Golaszewski , Matti Vaittinen , Andreas Kemnade , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-gpio@vger.kernel.org Subject: [RFC PATCH 07/13] regulator: bd71828: rename IC specific entities Message-ID: <101397e80b6ba8ffe3fee63090c4947e0c001c70.1759824376.git.mazziesaccount@gmail.com> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="MNOA3IQ8dAj0bpCB" Content-Disposition: inline In-Reply-To: --MNOA3IQ8dAj0bpCB Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" The new ROHM BD72720 PMIC has similarities with the BD71828. It makes sense to support the regulator control for both PMICs using the same driver. It is often more clear to have the IC specific functions and globals named starting with the chip-name. So, as a preparatory step, prefix the BD71828 specific functions and globals with the bd71828. It would be tempting to try also removing the chip ID from those functions which will be common for both PMICs. I have bad experiences on this as it tends to lead to problems when yet another IC is being supported with the same driver, and we will have some functions used for all, some for two of the three, and some for just one. At this point I used to start inventing wildcards like BD718XX or BD7272X. This approach is pretty much always failing as we tend to eventually have something like BD73900 - where all the wildcard stuff will break down. So, my approach these days is to: - keep the original chip-id prefix for anything that had it already (and avoid the churn). - use same prefix for all things that are used by multiple ICs - typically the chip-ID of the first chip. This typically matches also the driver and file names. - use specific chip-ID as a prefix for anything which is specific to just one chip. As a preparatory step to adding the BD72720, add bd71828 prefix to all commonly usable functions and globals. Signed-off-by: Matti Vaittinen --- No functional changes intended. --- drivers/regulator/bd71828-regulator.c | 32 +++++++++++++-------------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/regulator/bd71828-regulator.c b/drivers/regulator/bd71= 828-regulator.c index dd871ffe979c..3d18dbfdb84e 100644 --- a/drivers/regulator/bd71828-regulator.c +++ b/drivers/regulator/bd71828-regulator.c @@ -28,7 +28,7 @@ struct bd71828_regulator_data { int reg_init_amnt; }; =20 -static const struct reg_init buck1_inits[] =3D { +static const struct reg_init bd71828_buck1_inits[] =3D { /* * DVS Buck voltages can be changed by register values or via GPIO. * Use register accesses by default. @@ -40,7 +40,7 @@ static const struct reg_init buck1_inits[] =3D { }, }; =20 -static const struct reg_init buck2_inits[] =3D { +static const struct reg_init bd71828_buck2_inits[] =3D { { .reg =3D BD71828_REG_PS_CTRL_1, .mask =3D BD71828_MASK_DVS_BUCK2_CTRL, @@ -48,7 +48,7 @@ static const struct reg_init buck2_inits[] =3D { }, }; =20 -static const struct reg_init buck6_inits[] =3D { +static const struct reg_init bd71828_buck6_inits[] =3D { { .reg =3D BD71828_REG_PS_CTRL_1, .mask =3D BD71828_MASK_DVS_BUCK6_CTRL, @@ -56,7 +56,7 @@ static const struct reg_init buck6_inits[] =3D { }, }; =20 -static const struct reg_init buck7_inits[] =3D { +static const struct reg_init bd71828_buck7_inits[] =3D { { .reg =3D BD71828_REG_PS_CTRL_1, .mask =3D BD71828_MASK_DVS_BUCK7_CTRL, @@ -102,9 +102,9 @@ static int buck_set_hw_dvs_levels(struct device_node *n= p, return rohm_regulator_set_dvs_levels(&data->dvs, np, desc, cfg->regmap); } =20 -static int ldo6_parse_dt(struct device_node *np, - const struct regulator_desc *desc, - struct regulator_config *cfg) +static int bd71828_ldo6_parse_dt(struct device_node *np, + const struct regulator_desc *desc, + struct regulator_config *cfg) { int ret, i; uint32_t uv =3D 0; @@ -212,8 +212,8 @@ static const struct bd71828_regulator_data bd71828_rdat= a[] =3D { */ .lpsr_on_mask =3D BD71828_MASK_LPSR_EN, }, - .reg_inits =3D buck1_inits, - .reg_init_amnt =3D ARRAY_SIZE(buck1_inits), + .reg_inits =3D bd71828_buck1_inits, + .reg_init_amnt =3D ARRAY_SIZE(bd71828_buck1_inits), }, { .desc =3D { @@ -253,8 +253,8 @@ static const struct bd71828_regulator_data bd71828_rdat= a[] =3D { .lpsr_reg =3D BD71828_REG_BUCK2_SUSP_VOLT, .lpsr_mask =3D BD71828_MASK_BUCK1267_VOLT, }, - .reg_inits =3D buck2_inits, - .reg_init_amnt =3D ARRAY_SIZE(buck2_inits), + .reg_inits =3D bd71828_buck2_inits, + .reg_init_amnt =3D ARRAY_SIZE(bd71828_buck2_inits), }, { .desc =3D { @@ -399,8 +399,8 @@ static const struct bd71828_regulator_data bd71828_rdat= a[] =3D { .lpsr_reg =3D BD71828_REG_BUCK6_SUSP_VOLT, .lpsr_mask =3D BD71828_MASK_BUCK1267_VOLT, }, - .reg_inits =3D buck6_inits, - .reg_init_amnt =3D ARRAY_SIZE(buck6_inits), + .reg_inits =3D bd71828_buck6_inits, + .reg_init_amnt =3D ARRAY_SIZE(bd71828_buck6_inits), }, { .desc =3D { @@ -440,8 +440,8 @@ static const struct bd71828_regulator_data bd71828_rdat= a[] =3D { .lpsr_reg =3D BD71828_REG_BUCK7_SUSP_VOLT, .lpsr_mask =3D BD71828_MASK_BUCK1267_VOLT, }, - .reg_inits =3D buck7_inits, - .reg_init_amnt =3D ARRAY_SIZE(buck7_inits), + .reg_inits =3D bd71828_buck7_inits, + .reg_init_amnt =3D ARRAY_SIZE(bd71828_buck7_inits), }, { .desc =3D { @@ -633,7 +633,7 @@ static const struct bd71828_regulator_data bd71828_rdat= a[] =3D { * LDO6 only supports enable/disable for all states. * Voltage for LDO6 is fixed. */ - .of_parse_cb =3D ldo6_parse_dt, + .of_parse_cb =3D bd71828_ldo6_parse_dt, }, }, { .desc =3D { --=20 2.51.0 --MNOA3IQ8dAj0bpCB Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEIx+f8wZb28fLKEhTeFA3/03aocUFAmjk0H4ACgkQeFA3/03a ocWsiAgApSVT/OhJ/N/d5pftZT6izaQbs7itqR1JwXrO5jv0/AH0pqb019zRyQHL FqnwQ4794RTMDtZHvtanis3MAiGT21XGm6U72Xj2s7gyIeS89+0g29M45VW01SmZ Ahf4Ln3eazC/3j3JCPBLxLrArW89nefV5m5YH00QgxLVbEk8V/he6q8pmldLcdpq L3BEZhR+LZQ8PM1PeiMtd3AQUhIOvi0bXwl/8zeVc+ZTSbHCKsYo7FbaFhSeEIag W4etV2e5/3mOv3rF2Q76LXTleppWBRWnwXN/KqZbs0YeW3kNIC7IZrPx2G4udZN3 LDR42KhQ1eW7O6KnZcHSt/m0yuPJgw== =Tz4X -----END PGP SIGNATURE----- --MNOA3IQ8dAj0bpCB-- From nobody Wed Feb 11 03:42:00 2026 Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com [209.85.167.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 18F7E2D8771 for ; Tue, 7 Oct 2025 08:34:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759826068; cv=none; b=bMWX6R33Mh96MAPX7bis/0BQYZSNU/1OK0UbViDb15qtOdtsHwfBAwL50Zgs+tO+AafnBVAWANOXjddATf6a5tLB+JtxTOPjhZ6AVYeF+EAVMjr+Cmx/HAyuaGLHuWogFZ4cpq1lNZGRI01Su0zYnUSE+Qqyc5QUWrrW+Y4xzeI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759826068; c=relaxed/simple; bh=D2g5sM6uVDoweYU3JayVojud8U1oT/J5G5B1ojDpKpM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qs6D4CK5CY8+Tzv986f6cFnUgJ2b+87nJrFLBJuNYnCVWOUCYyt2R919SzBISnBuVJyfkEfVQJug3SxKeB/zHw5+xd9qKdJ4l+kix68cK3JMRdUxRFqkzI49Lp806vPVj1gXXIBPrQ8AdIfCLvCS85P3bvVFfnOcLkZc67Q8a30= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IdHTNzoy; arc=none smtp.client-ip=209.85.167.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IdHTNzoy" Received: by mail-lf1-f44.google.com with SMTP id 2adb3069b0e04-586883eb9fbso1029918e87.1 for ; Tue, 07 Oct 2025 01:34:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1759826063; x=1760430863; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=EPIRLT+0O2QRsODzrfmatvdPlRJxHT+wvhCdMy3rWsg=; b=IdHTNzoygFKyBRc9hS+1NsqjDF+XzAUEaTkQz1wjuD+ZtB2TgFoGvBvm9yxIfKhmJ9 oCh9MiGZinz8I2dzgpnk+HpN1DuJnuLehT+sQXJrD9+NJV9meYpJDclC/LzpNqKSWPk2 jT1gbglZC5s2vJCF8udq1bXEmBjsdHrRwk8NvjY+D0ksxysXP12+sRnse11Dkq3bplGx Dzp8dJ+mV4nyGn+WFgWQDeR9lpNdEOWH0tquQ0iJ9lXtP2i6LrExZLD6Ea4iD/vYKYV2 N6OvILxoGO+b4eEzBhi6sWmU3K4zgUlrUmSRf+Nr7ruwNCkPfqu48oOzDxlTI8kLo694 1F6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759826063; x=1760430863; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=EPIRLT+0O2QRsODzrfmatvdPlRJxHT+wvhCdMy3rWsg=; b=Tdx5NxH0/WPEU4Bs/Ha5iu5rdV/cYS//sWxdP7+JtUJlR9quhd+yoUZe6GsoOr4qKI FypfB0y9uceuIAhvwJnENml2XKtNwzTnKe7ievYmnJiALu4gYRcXr5QqICW8Buz4vWkC 4oUPvSNv74JF/qEk8ev+1TltwKa9tXL1SLPep3ybxbqCqdR/Ml0KYodQ7Qt0h4TIdl1Y QJIYY6CpElXDd+GUzLlqf5X1gXWUq4CXvxt4cTTkmopAdndHC5QZQjU+ZykU1GJSAPLY J8rRBLxuv+2BIb/rsv93CzlB8CzQz3irC77lNaWqsrR0MtVJfCaRL0RqV3GcZsuaWRBi Q2KA== X-Forwarded-Encrypted: i=1; AJvYcCUz0ekEctWJVF5AkXUP9SfyFhyAetxqXsZLypXEcxvmIE9Q7jJnK2MFcSJFOoy9Q7Pp2uozYZRmXQ+txE0=@vger.kernel.org X-Gm-Message-State: AOJu0Yzqr9I+ZAMMe3kcga+1kKFNGPQ1wmU2n5rukRvHMBpCx/SrzO7x Rui1ThhRYPLFoQEsGNZW9+hPO97ORJiCJ+Qrz7wOJ9TcSP+zHp8OHrPg X-Gm-Gg: ASbGncs+Q/sufQXI8ugHDcUtDNeFdAY25XnwSrQvbC69b3G7LD7T45fMKsBmDlrmEHF fRj4nYwz/kbQDihYqzAHJEzICOUdq4rr+2uX5x9tY4oVstInHCZmGUZvF5tGkFiJEnzzlYq/tmJ sXQsJ+OfZR2Poa+V0YrHHomeOWMB19s4s7Kb7Jx9KA/4IOsH+c+IMMPNhpl+ZpPru0w3QH0Akho neHu8IJZDx6FEbOcJ/dXk39wiriiEBWS4boJhYCerNaozPIUBRvGXA9KcIE6Pei9AvAIqCCQhMO 3ah59nHvC/fCz/7Ia6O6gr15ubwru3/oTMP2QHaLHVQwDD2X0HdG41d2qQY5FxoR4exXu71PiUE rLMzIAv/kpgv8JrKjx7PrlxMjfl2wfZFRmNgOPZzOEPuJPrhnoZki0w== X-Google-Smtp-Source: AGHT+IG1Iu5PZpaPyT51cgSBJNhPGclqsNjrEIWC0k46eLYpgwypj48lM8HgOs6wc0cTTqeNG33G8A== X-Received: by 2002:a05:6512:1597:b0:57a:6d7d:dd7f with SMTP id 2adb3069b0e04-58cb9288323mr4738777e87.5.1759826062745; Tue, 07 Oct 2025 01:34:22 -0700 (PDT) Received: from mva-rohm ([2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-58b01141dcdsm5852647e87.60.2025.10.07.01.34.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Oct 2025 01:34:21 -0700 (PDT) Date: Tue, 7 Oct 2025 11:34:17 +0300 From: Matti Vaittinen To: Matti Vaittinen , Matti Vaittinen Cc: Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Sebastian Reichel , Liam Girdwood , Mark Brown , Linus Walleij , Bartosz Golaszewski , Matti Vaittinen , Andreas Kemnade , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-gpio@vger.kernel.org Subject: [RFC PATCH 08/13] regulator: bd71828: Support ROHM BD72720 Message-ID: <073ca192148bcbf823fa76875b522b369d551f86.1759824376.git.mazziesaccount@gmail.com> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="lsIZXkrQDl0nf8se" Content-Disposition: inline In-Reply-To: --lsIZXkrQDl0nf8se Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" ROHM BD72720 is a power management IC which integrates 10 buck and 11 LDO regulators. This PMIC has plenty of commonalities with the BD71828 and BD71879. The BD72720 does also have similar 'run-level'-concept as the BD71828 had. It allows controlling the regulator's 'en masse', although only BUCK1 and LDO1 can utilize this in BD72720. Similar to BD71828, this 'en masse' -control is not supported by this driver. Support the voltage and enable/disable state control for the BD72720. Signed-off-by: Matti Vaittinen --- There are some new variants planned. Most notably, the BD73900 should be similar to the BD72720 what comes to the regulator control logic. If the run-level control is needed, there are some downstream extensions available at: https://rohmsemiconductor.github.io/Linux-Kernel-PMIC-Drivers/BD72720/ --- drivers/regulator/Kconfig | 8 +- drivers/regulator/bd71828-regulator.c | 993 +++++++++++++++++++++++++- 2 files changed, 992 insertions(+), 9 deletions(-) diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig index eaa6df1c9f80..021c4ece22ab 100644 --- a/drivers/regulator/Kconfig +++ b/drivers/regulator/Kconfig @@ -241,13 +241,13 @@ config REGULATOR_BD71815 will be called bd71815-regulator. =20 config REGULATOR_BD71828 - tristate "ROHM BD71828 Power Regulator" + tristate "ROHM BD71828, BD72720 and BD73900 Power Regulators" depends on MFD_ROHM_BD71828 select REGULATOR_ROHM help - This driver supports voltage regulators on ROHM BD71828 PMIC. - This will enable support for the software controllable buck - and LDO regulators. + This driver supports voltage regulators on ROHM BD71828, + BD71879, BD72720 and BD73900 PMICs. This will enable + support for the software controllable buck and LDO regulators. =20 This driver can also be built as a module. If so, the module will be called bd71828-regulator. diff --git a/drivers/regulator/bd71828-regulator.c b/drivers/regulator/bd71= 828-regulator.c index 3d18dbfdb84e..61ba82c7c6f1 100644 --- a/drivers/regulator/bd71828-regulator.c +++ b/drivers/regulator/bd71828-regulator.c @@ -3,12 +3,15 @@ // bd71828-regulator.c ROHM BD71828GW-DS1 regulator driver // =20 +#include #include #include #include #include #include +#include #include +#include #include #include #include @@ -16,6 +19,7 @@ #include #include =20 +#define BD72720_MASK_LDON_HEAD GENMASK(2, 0) struct reg_init { unsigned int reg; unsigned int mask; @@ -64,6 +68,26 @@ static const struct reg_init bd71828_buck7_inits[] =3D { }, }; =20 +#define BD72720_MASK_DVS_BUCK1_CTRL BIT(4) +#define BD72720_MASK_DVS_LDO1_CTRL BIT(5) + +static const struct reg_init bd72720_buck1_inits[] =3D { + { + .reg =3D BD72720_REG_PS_CTRL_2, + .mask =3D BD72720_MASK_DVS_BUCK1_CTRL, + .val =3D 0, /* Disable "run-level" control */ + }, +}; + +static const struct reg_init bd72720_ldo1_inits[] =3D { + { + .reg =3D BD72720_REG_PS_CTRL_2, + .mask =3D BD72720_MASK_DVS_LDO1_CTRL, + .val =3D 0, /* Disable "run-level" control */ + }, +}; + +/* BD71828 Buck voltages */ static const struct linear_range bd71828_buck1267_volts[] =3D { REGULATOR_LINEAR_RANGE(500000, 0x00, 0xef, 6250), REGULATOR_LINEAR_RANGE(2000000, 0xf0, 0xff, 0), @@ -84,13 +108,79 @@ static const struct linear_range bd71828_buck5_volts[]= =3D { REGULATOR_LINEAR_RANGE(3300000, 0x10, 0x1f, 0), }; =20 +/* BD71828 LDO voltages */ static const struct linear_range bd71828_ldo_volts[] =3D { REGULATOR_LINEAR_RANGE(800000, 0x00, 0x31, 50000), REGULATOR_LINEAR_RANGE(3300000, 0x32, 0x3f, 0), }; =20 +/* BD72720 Buck voltages */ +static const struct linear_range bd72720_buck1234_volts[] =3D { + REGULATOR_LINEAR_RANGE(500000, 0x00, 0xc0, 6250), + REGULATOR_LINEAR_RANGE(1700000, 0xc1, 0xff, 0), +}; + +static const struct linear_range bd72720_buck589_volts[] =3D { + REGULATOR_LINEAR_RANGE(500000, 0x00, 0x78, 10000), + REGULATOR_LINEAR_RANGE(1700000, 0x79, 0xff, 0), +}; + +static const struct linear_range bd72720_buck67_volts[] =3D { + REGULATOR_LINEAR_RANGE(1500000, 0x00, 0xb4, 10000), + REGULATOR_LINEAR_RANGE(3300000, 0xb5, 0xff, 0), +}; + +/* + * The BUCK10 on BD72720 has two modes of operation, depending on a LDON_H= EAD + * setting. When LDON_HEAD is 0x0, the behaviour is as with other bucks, e= g. + * voltage can be set to a values indicated below using the VSEL register. + * + * However, when LDON_HEAD is set to 0x1 ... 0x7, BUCK 10 voltage is, acco= rding + * to the data-sheet, "automatically adjusted following LDON_HEAD setting = and + * clamped to BUCK10_VID setting". + * + * Again, reading the data-sheet shows a "typical connection" where the BU= CK10 + * is used to supply the LDOs 1-4. My assumption is that in practice, this + * means that the BUCK10 voltage will be adjusted based on the maximum out= put + * of the LDO 1-4 (to minimize power loss). This makes sense. + * + * Auto-adjusting regulators aren't something I really like to model in the + * driver though - and, if the auto-adjustment works as intended, then the= re + * should really be no need to software to care about the buck10 voltages. + * If enable/disable control is still needed, we can implement buck10 as a + * regulator with only the enable/disable ops - and device-tree can be used + * to model the supply-relations. I believe this could allow the regulator + * framework to automagically disable the BUCK10 if all LDOs that are being + * supplied by it are disabled. + */ +static const struct linear_range bd72720_buck10_volts[] =3D { + REGULATOR_LINEAR_RANGE(500000, 0x00, 0xc0, 6250), + REGULATOR_LINEAR_RANGE(1700000, 0xc1, 0xff, 0), +}; + +/* BD72720 LDO voltages */ +static const struct linear_range bd72720_ldo1234_volts[] =3D { + REGULATOR_LINEAR_RANGE(500000, 0x00, 0x50, 6250), + REGULATOR_LINEAR_RANGE(1000000, 0x51, 0x7f, 0), +}; + +static const struct linear_range bd72720_ldo57891011_volts[] =3D { + REGULATOR_LINEAR_RANGE(750000, 0x00, 0xff, 10000), +}; + +static const struct linear_range bd72720_ldo6_volts[] =3D { + REGULATOR_LINEAR_RANGE(600000, 0x00, 0x78, 10000), + REGULATOR_LINEAR_RANGE(1800000, 0x79, 0x7f, 0), +}; + static const unsigned int bd71828_ramp_delay[] =3D { 2500, 5000, 10000, 20= 000 }; =20 +/* + * BD72720 supports setting both the ramp-up and ramp-down values + * separately. Do we need to support ramp-down setting? + */ +static const unsigned int bd72720_ramp_delay[] =3D { 5000, 7500, 10000, 12= 500 }; + static int buck_set_hw_dvs_levels(struct device_node *np, const struct regulator_desc *desc, struct regulator_config *cfg) @@ -171,6 +261,24 @@ static const struct regulator_ops bd71828_ldo6_ops =3D= { .is_enabled =3D regulator_is_enabled_regmap, }; =20 +static const struct regulator_ops bd72720_regulator_ops =3D { + .enable =3D regulator_enable_regmap, + .disable =3D regulator_disable_regmap, + .is_enabled =3D regulator_is_enabled_regmap, + .list_voltage =3D regulator_list_voltage_linear_range, + .set_voltage_sel =3D regulator_set_voltage_sel_regmap, + .get_voltage_sel =3D regulator_get_voltage_sel_regmap, + .set_voltage_time_sel =3D regulator_set_voltage_time_sel, + .set_ramp_delay =3D regulator_set_ramp_delay_regmap, +}; + +static const struct regulator_ops bd72720_buck10_ldon_head_op =3D { + .enable =3D regulator_enable_regmap, + .disable =3D regulator_disable_regmap, + .is_enabled =3D regulator_is_enabled_regmap, + .set_ramp_delay =3D regulator_set_ramp_delay_regmap, +}; + static const struct bd71828_regulator_data bd71828_rdata[] =3D { { .desc =3D { @@ -677,22 +785,890 @@ static const struct bd71828_regulator_data bd71828_r= data[] =3D { }, }; =20 +#define BD72720_BUCK10_DESC_INDEX 10 +#define BD72720_NUM_BUCK_VOLTS 0x100 +#define BD72720_NUM_LDO_VOLTS 0x100 +#define BD72720_NUM_LDO12346_VOLTS 0x80 + +static const struct bd71828_regulator_data bd72720_rdata[] =3D { + { + .desc =3D { + .name =3D "buck1", + .of_match =3D of_match_ptr("buck1"), + .regulators_node =3D of_match_ptr("regulators"), + .id =3D BD72720_BUCK1, + .type =3D REGULATOR_VOLTAGE, + + /* + * The BD72720 BUCK1 and LDO1 support GPIO toggled + * sub-RUN states called RUN0, RUN1, RUN2 and RUN3. + * The "operating mode" (sub-RUN states or normal) + * can be changed by a register. + * + * When the sub-RUN states are used, the voltage and + * enable state depend on a state specific + * configuration. The voltage and enable configuration + * for BUCK1 and LDO1 can be defined for each sub-RUN + * state using BD72720_REG_[BUCK,LDO]1_VSEL_R[0,1,2,3] + * voltage selection registers and the bits + * BD72720_MASK_RUN_[0,1,2,3]_EN in the enable registers. + * The PMIC will change both the BUCK1 and LDO1 voltages + * to the states defined in these registers when + * "DVS GPIOs" are toggled. + * + * If RUN 0 .. RUN 4 states are to be used, the normal + * voltage configuration mechanisms do not apply + * and we should overwrite the ops and ignore the + * voltage setting/getting registers which are setup + * here. This is not supported for now. If you need + * this functionality, you may try merging functionality + * from a downstream driver: + * https://rohmsemiconductor.github.io/Linux-Kernel-PMIC-Drivers/BD7272= 0/ + */ + .ops =3D &bd72720_regulator_ops, + .linear_ranges =3D bd72720_buck1234_volts, + .n_linear_ranges =3D ARRAY_SIZE(bd72720_buck1234_volts), + .n_voltages =3D BD72720_NUM_BUCK_VOLTS, + .enable_reg =3D BD72720_REG_BUCK1_ON, + .enable_mask =3D BD72720_MASK_RUN_B_EN, + .vsel_reg =3D BD72720_REG_BUCK1_VSEL_RB, + .vsel_mask =3D BD72720_MASK_BUCK_VSEL, + + .ramp_delay_table =3D bd72720_ramp_delay, + .n_ramp_values =3D ARRAY_SIZE(bd72720_ramp_delay), + .ramp_reg =3D BD72720_REG_BUCK1_MODE, + .ramp_mask =3D BD72720_MASK_RAMP_UP_DELAY, + .owner =3D THIS_MODULE, + .of_parse_cb =3D buck_set_hw_dvs_levels, + }, + .dvs =3D { + .level_map =3D ROHM_DVS_LEVEL_RUN | ROHM_DVS_LEVEL_IDLE | + ROHM_DVS_LEVEL_SUSPEND | + ROHM_DVS_LEVEL_LPSR, /* Deep idle in data-sheet */ + .run_reg =3D BD72720_REG_BUCK1_VSEL_RB, + .run_mask =3D BD72720_MASK_BUCK_VSEL, + .idle_reg =3D BD72720_REG_BUCK1_VSEL_I, + .idle_mask =3D BD72720_MASK_BUCK_VSEL, + .idle_on_mask =3D BD72720_MASK_IDLE_EN, + .suspend_reg =3D BD72720_REG_BUCK1_VSEL_S, + .suspend_mask =3D BD72720_MASK_BUCK_VSEL, + .suspend_on_mask =3D BD72720_MASK_SUSPEND_EN, + .lpsr_reg =3D BD72720_REG_BUCK1_VSEL_DI, + .lpsr_mask =3D BD72720_MASK_BUCK_VSEL, + .lpsr_on_mask =3D BD72720_MASK_DEEP_IDLE_EN, + }, + .reg_inits =3D bd72720_buck1_inits, + .reg_init_amnt =3D ARRAY_SIZE(bd72720_buck1_inits), + }, { + .desc =3D { + .name =3D "buck2", + .of_match =3D of_match_ptr("buck2"), + .regulators_node =3D of_match_ptr("regulators"), + .id =3D BD72720_BUCK2, + .type =3D REGULATOR_VOLTAGE, + .ops =3D &bd72720_regulator_ops, + .linear_ranges =3D bd72720_buck1234_volts, + .n_linear_ranges =3D ARRAY_SIZE(bd72720_buck1234_volts), + .n_voltages =3D BD72720_NUM_BUCK_VOLTS, + .enable_reg =3D BD72720_REG_BUCK2_ON, + .enable_mask =3D BD72720_MASK_RUN_B_EN, + .vsel_reg =3D BD72720_REG_BUCK2_VSEL_R, + .vsel_mask =3D BD72720_MASK_BUCK_VSEL, + + .ramp_delay_table =3D bd72720_ramp_delay, + .n_ramp_values =3D ARRAY_SIZE(bd72720_ramp_delay), + .ramp_reg =3D BD72720_REG_BUCK2_MODE, + .ramp_mask =3D BD72720_MASK_RAMP_UP_DELAY, + .owner =3D THIS_MODULE, + .of_parse_cb =3D buck_set_hw_dvs_levels, + }, + .dvs =3D { + .level_map =3D ROHM_DVS_LEVEL_RUN | ROHM_DVS_LEVEL_IDLE | + ROHM_DVS_LEVEL_SUSPEND | + ROHM_DVS_LEVEL_LPSR, + .run_reg =3D BD72720_REG_BUCK2_VSEL_R, + .run_mask =3D BD72720_MASK_BUCK_VSEL, + .idle_reg =3D BD72720_REG_BUCK2_VSEL_I, + .idle_mask =3D BD72720_MASK_BUCK_VSEL, + .idle_on_mask =3D BD72720_MASK_IDLE_EN, + .suspend_reg =3D BD72720_REG_BUCK2_VSEL_S, + .suspend_mask =3D BD72720_MASK_BUCK_VSEL, + .suspend_on_mask =3D BD72720_MASK_SUSPEND_EN, + .lpsr_reg =3D BD72720_REG_BUCK2_VSEL_DI, + .lpsr_mask =3D BD72720_MASK_BUCK_VSEL, + .lpsr_on_mask =3D BD72720_MASK_DEEP_IDLE_EN, + }, + }, { + .desc =3D { + .name =3D "buck3", + .of_match =3D of_match_ptr("buck3"), + .regulators_node =3D of_match_ptr("regulators"), + .id =3D BD72720_BUCK3, + .type =3D REGULATOR_VOLTAGE, + .ops =3D &bd72720_regulator_ops, + .linear_ranges =3D bd72720_buck1234_volts, + .n_linear_ranges =3D ARRAY_SIZE(bd72720_buck1234_volts), + .n_voltages =3D BD72720_NUM_BUCK_VOLTS, + .enable_reg =3D BD72720_REG_BUCK3_ON, + .enable_mask =3D BD72720_MASK_RUN_B_EN, + .vsel_reg =3D BD72720_REG_BUCK3_VSEL_R, + .vsel_mask =3D BD72720_MASK_BUCK_VSEL, + + .ramp_delay_table =3D bd72720_ramp_delay, + .n_ramp_values =3D ARRAY_SIZE(bd72720_ramp_delay), + .ramp_reg =3D BD72720_REG_BUCK3_MODE, + .ramp_mask =3D BD72720_MASK_RAMP_UP_DELAY, + .owner =3D THIS_MODULE, + .of_parse_cb =3D buck_set_hw_dvs_levels, + }, + .dvs =3D { + .level_map =3D ROHM_DVS_LEVEL_RUN | ROHM_DVS_LEVEL_IDLE | + ROHM_DVS_LEVEL_SUSPEND | + ROHM_DVS_LEVEL_LPSR, + .run_reg =3D BD72720_REG_BUCK3_VSEL_R, + .run_mask =3D BD72720_MASK_BUCK_VSEL, + .idle_reg =3D BD72720_REG_BUCK3_VSEL_I, + .idle_mask =3D BD72720_MASK_BUCK_VSEL, + .idle_on_mask =3D BD72720_MASK_IDLE_EN, + .suspend_reg =3D BD72720_REG_BUCK3_VSEL_S, + .suspend_mask =3D BD72720_MASK_BUCK_VSEL, + .suspend_on_mask =3D BD72720_MASK_SUSPEND_EN, + .lpsr_reg =3D BD72720_REG_BUCK3_VSEL_DI, + .lpsr_mask =3D BD72720_MASK_BUCK_VSEL, + .lpsr_on_mask =3D BD72720_MASK_DEEP_IDLE_EN, + }, + }, { + .desc =3D { + .name =3D "buck4", + .of_match =3D of_match_ptr("buck4"), + .regulators_node =3D of_match_ptr("regulators"), + .id =3D BD72720_BUCK4, + .type =3D REGULATOR_VOLTAGE, + .ops =3D &bd72720_regulator_ops, + .linear_ranges =3D bd72720_buck1234_volts, + .n_linear_ranges =3D ARRAY_SIZE(bd72720_buck1234_volts), + .n_voltages =3D BD72720_NUM_BUCK_VOLTS, + .enable_reg =3D BD72720_REG_BUCK4_ON, + .enable_mask =3D BD72720_MASK_RUN_B_EN, + .vsel_reg =3D BD72720_REG_BUCK4_VSEL_R, + .vsel_mask =3D BD72720_MASK_BUCK_VSEL, + + .ramp_delay_table =3D bd72720_ramp_delay, + .n_ramp_values =3D ARRAY_SIZE(bd72720_ramp_delay), + .ramp_reg =3D BD72720_REG_BUCK4_MODE, + .ramp_mask =3D BD72720_MASK_RAMP_UP_DELAY, + .owner =3D THIS_MODULE, + .of_parse_cb =3D buck_set_hw_dvs_levels, + }, + .dvs =3D { + .level_map =3D ROHM_DVS_LEVEL_RUN | ROHM_DVS_LEVEL_IDLE | + ROHM_DVS_LEVEL_SUSPEND | + ROHM_DVS_LEVEL_LPSR, + .run_reg =3D BD72720_REG_BUCK4_VSEL_R, + .run_mask =3D BD72720_MASK_BUCK_VSEL, + .idle_reg =3D BD72720_REG_BUCK4_VSEL_I, + .idle_mask =3D BD72720_MASK_BUCK_VSEL, + .idle_on_mask =3D BD72720_MASK_IDLE_EN, + .suspend_reg =3D BD72720_REG_BUCK4_VSEL_S, + .suspend_mask =3D BD72720_MASK_BUCK_VSEL, + .suspend_on_mask =3D BD72720_MASK_SUSPEND_EN, + .lpsr_reg =3D BD72720_REG_BUCK4_VSEL_DI, + .lpsr_mask =3D BD72720_MASK_BUCK_VSEL, + .lpsr_on_mask =3D BD72720_MASK_DEEP_IDLE_EN, + }, + }, { + .desc =3D { + .name =3D "buck5", + .of_match =3D of_match_ptr("buck5"), + .regulators_node =3D of_match_ptr("regulators"), + .id =3D BD72720_BUCK5, + .type =3D REGULATOR_VOLTAGE, + .ops =3D &bd72720_regulator_ops, + .linear_ranges =3D bd72720_buck589_volts, + .n_linear_ranges =3D ARRAY_SIZE(bd72720_buck589_volts), + .n_voltages =3D BD72720_NUM_BUCK_VOLTS, + .enable_reg =3D BD72720_REG_BUCK5_ON, + .enable_mask =3D BD72720_MASK_RUN_B_EN, + .vsel_reg =3D BD72720_REG_BUCK5_VSEL, + .vsel_mask =3D BD72720_MASK_BUCK_VSEL, + + .ramp_delay_table =3D bd72720_ramp_delay, + .n_ramp_values =3D ARRAY_SIZE(bd72720_ramp_delay), + .ramp_reg =3D BD72720_REG_BUCK5_MODE, + .ramp_mask =3D BD72720_MASK_RAMP_UP_DELAY, + .owner =3D THIS_MODULE, + .of_parse_cb =3D buck_set_hw_dvs_levels, + }, + .dvs =3D { + .level_map =3D ROHM_DVS_LEVEL_RUN | ROHM_DVS_LEVEL_IDLE | + ROHM_DVS_LEVEL_SUSPEND | + ROHM_DVS_LEVEL_LPSR, + .run_reg =3D BD72720_REG_BUCK5_VSEL, + .run_mask =3D BD72720_MASK_BUCK_VSEL, + .idle_on_mask =3D BD72720_MASK_IDLE_EN, + .suspend_on_mask =3D BD72720_MASK_SUSPEND_EN, + .lpsr_on_mask =3D BD72720_MASK_DEEP_IDLE_EN, + }, + }, { + .desc =3D { + .name =3D "buck6", + .of_match =3D of_match_ptr("buck6"), + .regulators_node =3D of_match_ptr("regulators"), + .id =3D BD72720_BUCK6, + .type =3D REGULATOR_VOLTAGE, + .ops =3D &bd72720_regulator_ops, + .linear_ranges =3D bd72720_buck67_volts, + .n_linear_ranges =3D ARRAY_SIZE(bd72720_buck67_volts), + .n_voltages =3D BD72720_NUM_BUCK_VOLTS, + .enable_reg =3D BD72720_REG_BUCK6_ON, + .enable_mask =3D BD72720_MASK_RUN_B_EN, + .vsel_reg =3D BD72720_REG_BUCK6_VSEL, + .vsel_mask =3D BD72720_MASK_BUCK_VSEL, + + .ramp_delay_table =3D bd72720_ramp_delay, + .n_ramp_values =3D ARRAY_SIZE(bd72720_ramp_delay), + .ramp_reg =3D BD72720_REG_BUCK6_MODE, + .ramp_mask =3D BD72720_MASK_RAMP_UP_DELAY, + .owner =3D THIS_MODULE, + .of_parse_cb =3D buck_set_hw_dvs_levels, + }, + .dvs =3D { + .level_map =3D ROHM_DVS_LEVEL_RUN | ROHM_DVS_LEVEL_IDLE | + ROHM_DVS_LEVEL_SUSPEND | + ROHM_DVS_LEVEL_LPSR, + .run_reg =3D BD72720_REG_BUCK6_VSEL, + .run_mask =3D BD72720_MASK_BUCK_VSEL, + .idle_on_mask =3D BD72720_MASK_IDLE_EN, + .suspend_on_mask =3D BD72720_MASK_SUSPEND_EN, + .lpsr_on_mask =3D BD72720_MASK_DEEP_IDLE_EN, + }, + }, { + .desc =3D { + .name =3D "buck7", + .of_match =3D of_match_ptr("buck7"), + .regulators_node =3D of_match_ptr("regulators"), + .id =3D BD72720_BUCK7, + .type =3D REGULATOR_VOLTAGE, + .ops =3D &bd72720_regulator_ops, + .linear_ranges =3D bd72720_buck67_volts, + .n_linear_ranges =3D ARRAY_SIZE(bd72720_buck67_volts), + .n_voltages =3D BD72720_NUM_BUCK_VOLTS, + .enable_reg =3D BD72720_REG_BUCK7_ON, + .enable_mask =3D BD72720_MASK_RUN_B_EN, + .vsel_reg =3D BD72720_REG_BUCK7_VSEL, + .vsel_mask =3D BD72720_MASK_BUCK_VSEL, + + .ramp_delay_table =3D bd72720_ramp_delay, + .n_ramp_values =3D ARRAY_SIZE(bd72720_ramp_delay), + .ramp_reg =3D BD72720_REG_BUCK7_MODE, + .ramp_mask =3D BD72720_MASK_RAMP_UP_DELAY, + .owner =3D THIS_MODULE, + .of_parse_cb =3D buck_set_hw_dvs_levels, + }, + .dvs =3D { + .level_map =3D ROHM_DVS_LEVEL_RUN | ROHM_DVS_LEVEL_IDLE | + ROHM_DVS_LEVEL_SUSPEND | + ROHM_DVS_LEVEL_LPSR, + .run_reg =3D BD72720_REG_BUCK7_VSEL, + .run_mask =3D BD72720_MASK_BUCK_VSEL, + .idle_on_mask =3D BD72720_MASK_IDLE_EN, + .suspend_on_mask =3D BD72720_MASK_SUSPEND_EN, + .lpsr_on_mask =3D BD72720_MASK_DEEP_IDLE_EN, + }, + }, { + .desc =3D { + .name =3D "buck8", + .of_match =3D of_match_ptr("buck8"), + .regulators_node =3D of_match_ptr("regulators"), + .id =3D BD72720_BUCK8, + .type =3D REGULATOR_VOLTAGE, + .ops =3D &bd72720_regulator_ops, + .linear_ranges =3D bd72720_buck589_volts, + .n_linear_ranges =3D ARRAY_SIZE(bd72720_buck589_volts), + .n_voltages =3D BD72720_NUM_BUCK_VOLTS, + .enable_reg =3D BD72720_REG_BUCK8_ON, + .enable_mask =3D BD72720_MASK_RUN_B_EN, + .vsel_reg =3D BD72720_REG_BUCK8_VSEL, + .vsel_mask =3D BD72720_MASK_BUCK_VSEL, + + .ramp_delay_table =3D bd72720_ramp_delay, + .n_ramp_values =3D ARRAY_SIZE(bd72720_ramp_delay), + .ramp_reg =3D BD72720_REG_BUCK8_MODE, + .ramp_mask =3D BD72720_MASK_RAMP_UP_DELAY, + .owner =3D THIS_MODULE, + .of_parse_cb =3D buck_set_hw_dvs_levels, + }, + .dvs =3D { + .level_map =3D ROHM_DVS_LEVEL_RUN | ROHM_DVS_LEVEL_IDLE | + ROHM_DVS_LEVEL_SUSPEND | + ROHM_DVS_LEVEL_LPSR, + .run_reg =3D BD72720_REG_BUCK8_VSEL, + .run_mask =3D BD72720_MASK_BUCK_VSEL, + .idle_on_mask =3D BD72720_MASK_IDLE_EN, + .suspend_on_mask =3D BD72720_MASK_SUSPEND_EN, + .lpsr_on_mask =3D BD72720_MASK_DEEP_IDLE_EN, + }, + }, { + .desc =3D { + .name =3D "buck9", + .of_match =3D of_match_ptr("buck9"), + .regulators_node =3D of_match_ptr("regulators"), + .id =3D BD72720_BUCK9, + .type =3D REGULATOR_VOLTAGE, + .ops =3D &bd72720_regulator_ops, + .linear_ranges =3D bd72720_buck589_volts, + .n_linear_ranges =3D ARRAY_SIZE(bd72720_buck589_volts), + .n_voltages =3D BD72720_NUM_BUCK_VOLTS, + .enable_reg =3D BD72720_REG_BUCK9_ON, + .enable_mask =3D BD72720_MASK_RUN_B_EN, + .vsel_reg =3D BD72720_REG_BUCK9_VSEL, + .vsel_mask =3D BD72720_MASK_BUCK_VSEL, + + .ramp_delay_table =3D bd72720_ramp_delay, + .n_ramp_values =3D ARRAY_SIZE(bd72720_ramp_delay), + .ramp_reg =3D BD72720_REG_BUCK9_MODE, + .ramp_mask =3D BD72720_MASK_RAMP_UP_DELAY, + .owner =3D THIS_MODULE, + .of_parse_cb =3D buck_set_hw_dvs_levels, + }, + .dvs =3D { + .level_map =3D ROHM_DVS_LEVEL_RUN | ROHM_DVS_LEVEL_IDLE | + ROHM_DVS_LEVEL_SUSPEND | + ROHM_DVS_LEVEL_LPSR, + .run_reg =3D BD72720_REG_BUCK9_VSEL, + .run_mask =3D BD72720_MASK_BUCK_VSEL, + .idle_on_mask =3D BD72720_MASK_IDLE_EN, + .suspend_on_mask =3D BD72720_MASK_SUSPEND_EN, + .lpsr_on_mask =3D BD72720_MASK_DEEP_IDLE_EN, + }, + }, { + .desc =3D { + .name =3D "buck10", + .of_match =3D of_match_ptr("buck10"), + .regulators_node =3D of_match_ptr("regulators"), + .id =3D BD72720_BUCK10, + .type =3D REGULATOR_VOLTAGE, + .ops =3D &bd72720_regulator_ops, + .linear_ranges =3D bd72720_buck10_volts, + .n_linear_ranges =3D ARRAY_SIZE(bd72720_buck10_volts), + .n_voltages =3D BD72720_NUM_BUCK_VOLTS, + .enable_reg =3D BD72720_REG_BUCK10_ON, + .enable_mask =3D BD72720_MASK_RUN_B_EN, + .vsel_reg =3D BD72720_REG_BUCK10_VSEL, + .vsel_mask =3D BD72720_MASK_BUCK_VSEL, + + .ramp_delay_table =3D bd72720_ramp_delay, + .n_ramp_values =3D ARRAY_SIZE(bd72720_ramp_delay), + .ramp_reg =3D BD72720_REG_BUCK10_MODE, + .ramp_mask =3D BD72720_MASK_RAMP_UP_DELAY, + .owner =3D THIS_MODULE, + .of_parse_cb =3D buck_set_hw_dvs_levels, + }, + .dvs =3D { + .level_map =3D ROHM_DVS_LEVEL_RUN | ROHM_DVS_LEVEL_IDLE | + ROHM_DVS_LEVEL_SUSPEND | + ROHM_DVS_LEVEL_LPSR, + .run_reg =3D BD72720_REG_BUCK10_VSEL, + .run_mask =3D BD72720_MASK_BUCK_VSEL, + .idle_on_mask =3D BD72720_MASK_IDLE_EN, + .suspend_on_mask =3D BD72720_MASK_SUSPEND_EN, + .lpsr_on_mask =3D BD72720_MASK_DEEP_IDLE_EN, + }, + }, { + .desc =3D { + .name =3D "ldo1", + .of_match =3D of_match_ptr("ldo1"), + .regulators_node =3D of_match_ptr("regulators"), + .id =3D BD72720_LDO1, + .type =3D REGULATOR_VOLTAGE, + .ops =3D &bd72720_regulator_ops, + .linear_ranges =3D bd72720_ldo1234_volts, + .n_linear_ranges =3D ARRAY_SIZE(bd72720_ldo1234_volts), + .n_voltages =3D BD72720_NUM_LDO12346_VOLTS, + .enable_reg =3D BD72720_REG_LDO1_ON, + .enable_mask =3D BD72720_MASK_RUN_B_EN, + .vsel_reg =3D BD72720_REG_LDO1_VSEL_RB, + .vsel_mask =3D BD72720_MASK_LDO12346_VSEL, + + .ramp_delay_table =3D bd72720_ramp_delay, + .n_ramp_values =3D ARRAY_SIZE(bd72720_ramp_delay), + .ramp_reg =3D BD72720_REG_LDO1_MODE1, + .ramp_mask =3D BD72720_MASK_RAMP_UP_DELAY, + .owner =3D THIS_MODULE, + .of_parse_cb =3D buck_set_hw_dvs_levels, + }, + .dvs =3D { + .level_map =3D ROHM_DVS_LEVEL_RUN | ROHM_DVS_LEVEL_IDLE | + ROHM_DVS_LEVEL_SUSPEND | + ROHM_DVS_LEVEL_LPSR, + .run_reg =3D BD72720_REG_LDO1_VSEL_RB, + .run_mask =3D BD72720_MASK_LDO12346_VSEL, + .idle_reg =3D BD72720_REG_LDO1_VSEL_I, + .idle_mask =3D BD72720_MASK_LDO12346_VSEL, + .idle_on_mask =3D BD72720_MASK_IDLE_EN, + .suspend_reg =3D BD72720_REG_LDO1_VSEL_S, + .suspend_mask =3D BD72720_MASK_LDO12346_VSEL, + .suspend_on_mask =3D BD72720_MASK_SUSPEND_EN, + .lpsr_reg =3D BD72720_REG_LDO1_VSEL_DI, + .lpsr_mask =3D BD72720_MASK_LDO12346_VSEL, + .lpsr_on_mask =3D BD72720_MASK_DEEP_IDLE_EN, + }, + .reg_inits =3D bd72720_ldo1_inits, + .reg_init_amnt =3D ARRAY_SIZE(bd72720_ldo1_inits), + }, { + .desc =3D { + .name =3D "ldo2", + .of_match =3D of_match_ptr("ldo2"), + .regulators_node =3D of_match_ptr("regulators"), + .id =3D BD72720_LDO2, + .type =3D REGULATOR_VOLTAGE, + .ops =3D &bd72720_regulator_ops, + .linear_ranges =3D bd72720_ldo1234_volts, + .n_linear_ranges =3D ARRAY_SIZE(bd72720_ldo1234_volts), + .n_voltages =3D BD72720_NUM_LDO12346_VOLTS, + .enable_reg =3D BD72720_REG_LDO2_ON, + .enable_mask =3D BD72720_MASK_RUN_B_EN, + .vsel_reg =3D BD72720_REG_LDO2_VSEL_R, + .vsel_mask =3D BD72720_MASK_LDO12346_VSEL, + + .ramp_delay_table =3D bd72720_ramp_delay, + .n_ramp_values =3D ARRAY_SIZE(bd72720_ramp_delay), + .ramp_reg =3D BD72720_REG_LDO2_MODE, + .ramp_mask =3D BD72720_MASK_RAMP_UP_DELAY, + .owner =3D THIS_MODULE, + .of_parse_cb =3D buck_set_hw_dvs_levels, + }, + .dvs =3D { + .level_map =3D ROHM_DVS_LEVEL_RUN | ROHM_DVS_LEVEL_IDLE | + ROHM_DVS_LEVEL_SUSPEND | + ROHM_DVS_LEVEL_LPSR, + .run_reg =3D BD72720_REG_LDO2_VSEL_R, + .run_mask =3D BD72720_MASK_LDO12346_VSEL, + .idle_reg =3D BD72720_REG_LDO2_VSEL_I, + .idle_mask =3D BD72720_MASK_LDO12346_VSEL, + .idle_on_mask =3D BD72720_MASK_IDLE_EN, + .suspend_reg =3D BD72720_REG_LDO2_VSEL_S, + .suspend_mask =3D BD72720_MASK_LDO12346_VSEL, + .suspend_on_mask =3D BD72720_MASK_SUSPEND_EN, + .lpsr_reg =3D BD72720_REG_LDO2_VSEL_DI, + .lpsr_mask =3D BD72720_MASK_LDO12346_VSEL, + .lpsr_on_mask =3D BD72720_MASK_DEEP_IDLE_EN, + }, + }, { + .desc =3D { + .name =3D "ldo3", + .of_match =3D of_match_ptr("ldo3"), + .regulators_node =3D of_match_ptr("regulators"), + .id =3D BD72720_LDO3, + .type =3D REGULATOR_VOLTAGE, + .ops =3D &bd72720_regulator_ops, + .linear_ranges =3D bd72720_ldo1234_volts, + .n_linear_ranges =3D ARRAY_SIZE(bd72720_ldo1234_volts), + .n_voltages =3D BD72720_NUM_LDO12346_VOLTS, + .enable_reg =3D BD72720_REG_LDO3_ON, + .enable_mask =3D BD72720_MASK_RUN_B_EN, + .vsel_reg =3D BD72720_REG_LDO3_VSEL_R, + .vsel_mask =3D BD72720_MASK_LDO12346_VSEL, + + .ramp_delay_table =3D bd72720_ramp_delay, + .n_ramp_values =3D ARRAY_SIZE(bd72720_ramp_delay), + .ramp_reg =3D BD72720_REG_LDO3_MODE, + .ramp_mask =3D BD72720_MASK_RAMP_UP_DELAY, + .owner =3D THIS_MODULE, + .of_parse_cb =3D buck_set_hw_dvs_levels, + }, + .dvs =3D { + .level_map =3D ROHM_DVS_LEVEL_RUN | ROHM_DVS_LEVEL_IDLE | + ROHM_DVS_LEVEL_SUSPEND | + ROHM_DVS_LEVEL_LPSR, + .run_reg =3D BD72720_REG_LDO3_VSEL_R, + .run_mask =3D BD72720_MASK_LDO12346_VSEL, + .idle_reg =3D BD72720_REG_LDO3_VSEL_I, + .idle_mask =3D BD72720_MASK_LDO12346_VSEL, + .idle_on_mask =3D BD72720_MASK_IDLE_EN, + .suspend_reg =3D BD72720_REG_LDO3_VSEL_S, + .suspend_mask =3D BD72720_MASK_LDO12346_VSEL, + .suspend_on_mask =3D BD72720_MASK_SUSPEND_EN, + .lpsr_reg =3D BD72720_REG_LDO3_VSEL_DI, + .lpsr_mask =3D BD72720_MASK_LDO12346_VSEL, + .lpsr_on_mask =3D BD72720_MASK_DEEP_IDLE_EN, + }, + }, { + .desc =3D { + .name =3D "ldo4", + .of_match =3D of_match_ptr("ldo4"), + .regulators_node =3D of_match_ptr("regulators"), + .id =3D BD72720_LDO4, + .type =3D REGULATOR_VOLTAGE, + .ops =3D &bd72720_regulator_ops, + .linear_ranges =3D bd72720_ldo1234_volts, + .n_linear_ranges =3D ARRAY_SIZE(bd72720_ldo1234_volts), + .n_voltages =3D BD72720_NUM_LDO12346_VOLTS, + .enable_reg =3D BD72720_REG_LDO4_ON, + .enable_mask =3D BD72720_MASK_RUN_B_EN, + .vsel_reg =3D BD72720_REG_LDO4_VSEL_R, + .vsel_mask =3D BD72720_MASK_LDO12346_VSEL, + + .ramp_delay_table =3D bd72720_ramp_delay, + .n_ramp_values =3D ARRAY_SIZE(bd72720_ramp_delay), + .ramp_reg =3D BD72720_REG_LDO4_MODE, + .ramp_mask =3D BD72720_MASK_RAMP_UP_DELAY, + .owner =3D THIS_MODULE, + .of_parse_cb =3D buck_set_hw_dvs_levels, + }, + .dvs =3D { + .level_map =3D ROHM_DVS_LEVEL_RUN | ROHM_DVS_LEVEL_IDLE | + ROHM_DVS_LEVEL_SUSPEND | + ROHM_DVS_LEVEL_LPSR, + .run_reg =3D BD72720_REG_LDO4_VSEL_R, + .run_mask =3D BD72720_MASK_LDO12346_VSEL, + .idle_reg =3D BD72720_REG_LDO4_VSEL_I, + .idle_mask =3D BD72720_MASK_LDO12346_VSEL, + .idle_on_mask =3D BD72720_MASK_IDLE_EN, + .suspend_reg =3D BD72720_REG_LDO4_VSEL_S, + .suspend_mask =3D BD72720_MASK_LDO12346_VSEL, + .suspend_on_mask =3D BD72720_MASK_SUSPEND_EN, + .lpsr_reg =3D BD72720_REG_LDO4_VSEL_DI, + .lpsr_mask =3D BD72720_MASK_LDO12346_VSEL, + .lpsr_on_mask =3D BD72720_MASK_DEEP_IDLE_EN, + }, + }, { + .desc =3D { + .name =3D "ldo5", + .of_match =3D of_match_ptr("ldo5"), + .regulators_node =3D of_match_ptr("regulators"), + .id =3D BD72720_LDO5, + .type =3D REGULATOR_VOLTAGE, + .ops =3D &bd72720_regulator_ops, + .linear_ranges =3D bd72720_ldo57891011_volts, + .n_linear_ranges =3D ARRAY_SIZE(bd72720_ldo57891011_volts), + .n_voltages =3D BD72720_NUM_LDO_VOLTS, + .enable_reg =3D BD72720_REG_LDO5_ON, + .enable_mask =3D BD72720_MASK_RUN_B_EN, + .vsel_reg =3D BD72720_REG_LDO5_VSEL, + .vsel_mask =3D BD72720_MASK_LDO_VSEL, + + .ramp_delay_table =3D bd72720_ramp_delay, + .n_ramp_values =3D ARRAY_SIZE(bd72720_ramp_delay), + .ramp_reg =3D BD72720_REG_LDO5_MODE, + .ramp_mask =3D BD72720_MASK_RAMP_UP_DELAY, + .owner =3D THIS_MODULE, + .of_parse_cb =3D buck_set_hw_dvs_levels, + }, + .dvs =3D { + .level_map =3D ROHM_DVS_LEVEL_RUN | ROHM_DVS_LEVEL_IDLE | + ROHM_DVS_LEVEL_SUSPEND | + ROHM_DVS_LEVEL_LPSR, + .run_reg =3D BD72720_REG_LDO5_VSEL, + .run_mask =3D BD72720_MASK_LDO_VSEL, + .idle_on_mask =3D BD72720_MASK_IDLE_EN, + .suspend_on_mask =3D BD72720_MASK_SUSPEND_EN, + .lpsr_on_mask =3D BD72720_MASK_DEEP_IDLE_EN, + }, + }, { + .desc =3D { + .name =3D "ldo6", + .of_match =3D of_match_ptr("ldo6"), + .regulators_node =3D of_match_ptr("regulators"), + .id =3D BD72720_LDO6, + .type =3D REGULATOR_VOLTAGE, + .ops =3D &bd72720_regulator_ops, + .linear_ranges =3D bd72720_ldo6_volts, + .n_linear_ranges =3D ARRAY_SIZE(bd72720_ldo6_volts), + .n_voltages =3D BD72720_NUM_LDO12346_VOLTS, + .enable_reg =3D BD72720_REG_LDO6_ON, + .enable_mask =3D BD72720_MASK_RUN_B_EN, + .vsel_reg =3D BD72720_REG_LDO6_VSEL, + .vsel_mask =3D BD72720_MASK_LDO12346_VSEL, + + .ramp_delay_table =3D bd72720_ramp_delay, + .n_ramp_values =3D ARRAY_SIZE(bd72720_ramp_delay), + .ramp_reg =3D BD72720_REG_LDO6_MODE, + .ramp_mask =3D BD72720_MASK_RAMP_UP_DELAY, + .owner =3D THIS_MODULE, + .of_parse_cb =3D buck_set_hw_dvs_levels, + }, + .dvs =3D { + .level_map =3D ROHM_DVS_LEVEL_RUN | ROHM_DVS_LEVEL_IDLE | + ROHM_DVS_LEVEL_SUSPEND | + ROHM_DVS_LEVEL_LPSR, + .run_reg =3D BD72720_REG_LDO6_VSEL, + .run_mask =3D BD72720_MASK_LDO12346_VSEL, + .idle_on_mask =3D BD72720_MASK_IDLE_EN, + .suspend_on_mask =3D BD72720_MASK_SUSPEND_EN, + .lpsr_on_mask =3D BD72720_MASK_DEEP_IDLE_EN, + }, + }, { + .desc =3D { + .name =3D "ldo7", + .of_match =3D of_match_ptr("ldo7"), + .regulators_node =3D of_match_ptr("regulators"), + .id =3D BD72720_LDO7, + .type =3D REGULATOR_VOLTAGE, + .ops =3D &bd72720_regulator_ops, + .linear_ranges =3D bd72720_ldo57891011_volts, + .n_linear_ranges =3D ARRAY_SIZE(bd72720_ldo57891011_volts), + .n_voltages =3D BD72720_NUM_LDO_VOLTS, + .enable_reg =3D BD72720_REG_LDO7_ON, + .enable_mask =3D BD72720_MASK_RUN_B_EN, + .vsel_reg =3D BD72720_REG_LDO7_VSEL, + .vsel_mask =3D BD72720_MASK_LDO_VSEL, + + .ramp_delay_table =3D bd72720_ramp_delay, + .n_ramp_values =3D ARRAY_SIZE(bd72720_ramp_delay), + .ramp_reg =3D BD72720_REG_LDO7_MODE, + .ramp_mask =3D BD72720_MASK_RAMP_UP_DELAY, + .owner =3D THIS_MODULE, + .of_parse_cb =3D buck_set_hw_dvs_levels, + }, + .dvs =3D { + .level_map =3D ROHM_DVS_LEVEL_RUN | ROHM_DVS_LEVEL_IDLE | + ROHM_DVS_LEVEL_SUSPEND | + ROHM_DVS_LEVEL_LPSR, + .run_reg =3D BD72720_REG_LDO7_VSEL, + .run_mask =3D BD72720_MASK_LDO_VSEL, + .idle_on_mask =3D BD72720_MASK_IDLE_EN, + .suspend_on_mask =3D BD72720_MASK_SUSPEND_EN, + .lpsr_on_mask =3D BD72720_MASK_DEEP_IDLE_EN, + }, + }, { + .desc =3D { + .name =3D "ldo8", + .of_match =3D of_match_ptr("ldo8"), + .regulators_node =3D of_match_ptr("regulators"), + .id =3D BD72720_LDO8, + .type =3D REGULATOR_VOLTAGE, + .ops =3D &bd72720_regulator_ops, + .linear_ranges =3D bd72720_ldo57891011_volts, + .n_linear_ranges =3D ARRAY_SIZE(bd72720_ldo57891011_volts), + .n_voltages =3D BD72720_NUM_LDO_VOLTS, + .enable_reg =3D BD72720_REG_LDO8_ON, + .enable_mask =3D BD72720_MASK_RUN_B_EN, + .vsel_reg =3D BD72720_REG_LDO8_VSEL, + .vsel_mask =3D BD72720_MASK_LDO_VSEL, + + .ramp_delay_table =3D bd72720_ramp_delay, + .n_ramp_values =3D ARRAY_SIZE(bd72720_ramp_delay), + .ramp_reg =3D BD72720_REG_LDO8_MODE, + .ramp_mask =3D BD72720_MASK_RAMP_UP_DELAY, + .owner =3D THIS_MODULE, + .of_parse_cb =3D buck_set_hw_dvs_levels, + }, + .dvs =3D { + .level_map =3D ROHM_DVS_LEVEL_RUN | ROHM_DVS_LEVEL_IDLE | + ROHM_DVS_LEVEL_SUSPEND | + ROHM_DVS_LEVEL_LPSR, + .run_reg =3D BD72720_REG_LDO8_VSEL, + .run_mask =3D BD72720_MASK_LDO_VSEL, + .idle_on_mask =3D BD72720_MASK_IDLE_EN, + .suspend_on_mask =3D BD72720_MASK_SUSPEND_EN, + .lpsr_on_mask =3D BD72720_MASK_DEEP_IDLE_EN, + }, + }, { + .desc =3D { + .name =3D "ldo9", + .of_match =3D of_match_ptr("ldo9"), + .regulators_node =3D of_match_ptr("regulators"), + .id =3D BD72720_LDO9, + .type =3D REGULATOR_VOLTAGE, + .ops =3D &bd72720_regulator_ops, + .linear_ranges =3D bd72720_ldo57891011_volts, + .n_linear_ranges =3D ARRAY_SIZE(bd72720_ldo57891011_volts), + .n_voltages =3D BD72720_NUM_LDO_VOLTS, + .enable_reg =3D BD72720_REG_LDO9_ON, + .enable_mask =3D BD72720_MASK_RUN_B_EN, + .vsel_reg =3D BD72720_REG_LDO9_VSEL, + .vsel_mask =3D BD72720_MASK_LDO_VSEL, + + .ramp_delay_table =3D bd72720_ramp_delay, + .n_ramp_values =3D ARRAY_SIZE(bd72720_ramp_delay), + .ramp_reg =3D BD72720_REG_LDO9_MODE, + .ramp_mask =3D BD72720_MASK_RAMP_UP_DELAY, + .owner =3D THIS_MODULE, + .of_parse_cb =3D buck_set_hw_dvs_levels, + }, + .dvs =3D { + .level_map =3D ROHM_DVS_LEVEL_RUN | ROHM_DVS_LEVEL_IDLE | + ROHM_DVS_LEVEL_SUSPEND | + ROHM_DVS_LEVEL_LPSR, + .run_reg =3D BD72720_REG_LDO9_VSEL, + .run_mask =3D BD72720_MASK_LDO_VSEL, + .idle_on_mask =3D BD72720_MASK_IDLE_EN, + .suspend_on_mask =3D BD72720_MASK_SUSPEND_EN, + .lpsr_on_mask =3D BD72720_MASK_DEEP_IDLE_EN, + }, + }, { + .desc =3D { + .name =3D "ldo10", + .of_match =3D of_match_ptr("ldo10"), + .regulators_node =3D of_match_ptr("regulators"), + .id =3D BD72720_LDO10, + .type =3D REGULATOR_VOLTAGE, + .ops =3D &bd72720_regulator_ops, + .linear_ranges =3D bd72720_ldo57891011_volts, + .n_linear_ranges =3D ARRAY_SIZE(bd72720_ldo57891011_volts), + .n_voltages =3D BD72720_NUM_LDO_VOLTS, + .enable_reg =3D BD72720_REG_LDO10_ON, + .enable_mask =3D BD72720_MASK_RUN_B_EN, + .vsel_reg =3D BD72720_REG_LDO10_VSEL, + .vsel_mask =3D BD72720_MASK_LDO_VSEL, + + .ramp_delay_table =3D bd72720_ramp_delay, + .n_ramp_values =3D ARRAY_SIZE(bd72720_ramp_delay), + .ramp_reg =3D BD72720_REG_LDO10_MODE, + .ramp_mask =3D BD72720_MASK_RAMP_UP_DELAY, + .owner =3D THIS_MODULE, + .of_parse_cb =3D buck_set_hw_dvs_levels, + }, + .dvs =3D { + .level_map =3D ROHM_DVS_LEVEL_RUN | ROHM_DVS_LEVEL_IDLE | + ROHM_DVS_LEVEL_SUSPEND | + ROHM_DVS_LEVEL_LPSR, + .run_reg =3D BD72720_REG_LDO10_VSEL, + .run_mask =3D BD72720_MASK_LDO_VSEL, + .idle_on_mask =3D BD72720_MASK_IDLE_EN, + .suspend_on_mask =3D BD72720_MASK_SUSPEND_EN, + .lpsr_on_mask =3D BD72720_MASK_DEEP_IDLE_EN, + }, + }, { + .desc =3D { + .name =3D "ldo11", + .of_match =3D of_match_ptr("ldo11"), + .regulators_node =3D of_match_ptr("regulators"), + .id =3D BD72720_LDO11, + .type =3D REGULATOR_VOLTAGE, + .ops =3D &bd72720_regulator_ops, + .linear_ranges =3D bd72720_ldo57891011_volts, + .n_linear_ranges =3D ARRAY_SIZE(bd72720_ldo57891011_volts), + .n_voltages =3D BD72720_NUM_LDO_VOLTS, + .enable_reg =3D BD72720_REG_LDO11_ON, + .enable_mask =3D BD72720_MASK_RUN_B_EN, + .vsel_reg =3D BD72720_REG_LDO11_VSEL, + .vsel_mask =3D BD72720_MASK_LDO_VSEL, + + .ramp_delay_table =3D bd72720_ramp_delay, + .n_ramp_values =3D ARRAY_SIZE(bd72720_ramp_delay), + .ramp_reg =3D BD72720_REG_LDO11_MODE, + .ramp_mask =3D BD72720_MASK_RAMP_UP_DELAY, + .owner =3D THIS_MODULE, + .of_parse_cb =3D buck_set_hw_dvs_levels, + }, + .dvs =3D { + .level_map =3D ROHM_DVS_LEVEL_RUN | ROHM_DVS_LEVEL_IDLE | + ROHM_DVS_LEVEL_SUSPEND | + ROHM_DVS_LEVEL_LPSR, + .run_reg =3D BD72720_REG_LDO11_VSEL, + .run_mask =3D BD72720_MASK_LDO_VSEL, + .idle_on_mask =3D BD72720_MASK_IDLE_EN, + .suspend_on_mask =3D BD72720_MASK_SUSPEND_EN, + .lpsr_on_mask =3D BD72720_MASK_DEEP_IDLE_EN, + }, + }, +}; + +static int bd72720_buck10_ldon_head_mode(struct device *dev, + struct device_node *npreg, + struct regmap *regmap, + struct regulator_desc *buck10_desc) +{ + struct device_node *np __free(device_node) =3D + of_get_child_by_name(npreg, "buck10"); + uint32_t ldon_head; + int ldon_val; + int ret; + + if (!np) { + dev_err(dev, "failed to find buck10 regulator node\n"); + return -ENODEV; + } + + ret =3D of_property_read_u32(np, "rohm,ldon-head-millivolt", &ldon_head); + if (ret =3D=3D -EINVAL) + return 0; + if (ret) + return ret; + + /* + * LDON_HEAD mode means the BUCK10 is used to supply LDOs 1-4 and + * the BUCK 10 voltage is automatically set to follow LDO 1-4 + * settings. Thus the BUCK10 should not allow voltage [g/s]etting. + */ + buck10_desc->ops =3D &bd72720_buck10_ldon_head_op; + + ldon_val =3D ldon_head / 50 + 1; + if (ldon_head > 300) { + dev_warn(dev, "Unsupported LDON_HEAD, clamping to 300 mV\n"); + ldon_val =3D 7; + } + + return regmap_update_bits(regmap, BD72720_REG_LDO1_MODE2, + BD72720_MASK_LDON_HEAD, ldon_val); +} + +static int bd72720_dt_parse(struct device *dev, + struct regulator_desc *buck10_desc, + struct regmap *regmap) +{ + struct device_node *nproot __free(device_node) =3D + of_get_child_by_name(dev->parent->of_node, "regulators"); + + if (!nproot) { + dev_err(dev, "failed to find regulators node\n"); + return -ENODEV; + } + + return bd72720_buck10_ldon_head_mode(dev, nproot, regmap, buck10_desc); +} + static int bd71828_probe(struct platform_device *pdev) { - int i, j, ret; + int i, j, ret, num_regulators; struct regulator_config config =3D { .dev =3D pdev->dev.parent, }; + enum rohm_chip_type chip =3D platform_get_device_id(pdev)->driver_data; + struct bd71828_regulator_data *rdata; =20 config.regmap =3D dev_get_regmap(pdev->dev.parent, NULL); if (!config.regmap) return -ENODEV; =20 - for (i =3D 0; i < ARRAY_SIZE(bd71828_rdata); i++) { + switch (chip) { + case ROHM_CHIP_TYPE_BD72720: + rdata =3D devm_kmemdup(&pdev->dev, bd72720_rdata, + sizeof(bd72720_rdata), GFP_KERNEL); + if (!rdata) + return -ENOMEM; + + ret =3D bd72720_dt_parse(&pdev->dev, &rdata[BD72720_BUCK10_DESC_INDEX].d= esc, + config.regmap); + if (ret) + return ret; + + num_regulators =3D ARRAY_SIZE(bd72720_rdata); + break; + + case ROHM_CHIP_TYPE_BD71828: + rdata =3D devm_kmemdup(&pdev->dev, bd71828_rdata, + sizeof(bd71828_rdata), GFP_KERNEL); + if (!rdata) + return -ENOMEM; + + num_regulators =3D ARRAY_SIZE(bd71828_rdata); + + break; + default: + return dev_err_probe(&pdev->dev, -EINVAL, + "Unsupported device\n"); + } + + for (i =3D 0; i < num_regulators; i++) { struct regulator_dev *rdev; - const struct bd71828_regulator_data *rd; + struct bd71828_regulator_data *rd; + + rd =3D &rdata[i]; =20 - rd =3D &bd71828_rdata[i]; + config.driver_data =3D rd; rdev =3D devm_regulator_register(&pdev->dev, &rd->desc, &config); if (IS_ERR(rdev)) @@ -714,12 +1690,20 @@ static int bd71828_probe(struct platform_device *pde= v) return 0; } =20 +static const struct platform_device_id bd71828_pmic_id[] =3D { + { "bd71828-pmic", ROHM_CHIP_TYPE_BD71828 }, + { "bd72720-pmic", ROHM_CHIP_TYPE_BD72720 }, + { }, +}; +MODULE_DEVICE_TABLE(platform, bd71828_pmic_id); + static struct platform_driver bd71828_regulator =3D { .driver =3D { .name =3D "bd71828-pmic", .probe_type =3D PROBE_PREFER_ASYNCHRONOUS, }, .probe =3D bd71828_probe, + .id_table =3D bd71828_pmic_id, }; =20 module_platform_driver(bd71828_regulator); @@ -727,4 +1711,3 @@ module_platform_driver(bd71828_regulator); MODULE_AUTHOR("Matti Vaittinen "); MODULE_DESCRIPTION("BD71828 voltage regulator driver"); MODULE_LICENSE("GPL"); -MODULE_ALIAS("platform:bd71828-pmic"); --=20 2.51.0 --lsIZXkrQDl0nf8se Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEIx+f8wZb28fLKEhTeFA3/03aocUFAmjk0IkACgkQeFA3/03a ocX32wgAmpojLqnTM3uoNv27I+jINMkEg1dbJX0Q73YpP7OvLKpd/0umH71/YPOF ojj2vO3wI1+MX77MmADMoLm4C0AbKAC3h0SAFWMyU5WUp3sN74W/gWYgAY1aNG0s zKWDlibNTFqxMewcW3yUrduAIjcOZLTFDCuV0uz6mPKMstOLnfb89z/T+I6LdTMu iYq6zqdCJIfIGOHrKPmyCKrtLN/IKWIQ5GsdZHOBe/DdlzLkRa4Id8J226mUhusf oQw2Fmw+dwReneq67SxFsG3I6UJRlAfrsb2Xt77LkC52x3bsrZCOycgGiEycyWzh K3Ldw2438Ow/ucWJ5gtGKF6QcEqNHg== =yz3b -----END PGP SIGNATURE----- --lsIZXkrQDl0nf8se-- From nobody Wed Feb 11 03:42:00 2026 Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 105172D8390 for ; Tue, 7 Oct 2025 08:34:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759826080; cv=none; b=boCr54CKsOChgZ5PTtVj46rS6HSQA91rLIHXciC4whdIrN5Xn7A+qY/IwEVez42d+9JGafe5SZSc04RKv2ebbzfHIf4/PRes0pA/NliWeY0Sm4p1ji7Io6rg7TAGQoo0xstHtyHc/d/1hdan2XTMdO/cSK4+wOPpxheTRYrRguU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759826080; c=relaxed/simple; bh=R8clJqIWgxqfvV6jstEVcRU6Y5M+f9dOjXk/4CdXbEc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=slNCLkNYjQT/gtI2CY2npsukcyaWKYSJ+Uw8QZpLBu8OG3gTw5VHXXNQejUQSVmxNfI+0caHd5CTXImOACiRCwyFYqeYk0mVg9NncJmMTxmOCQFRqbclRzJVxh7tZcSdLhLxrrcnSE+80lHtPZpQn5z2LxOXo2AaxX/EUB/l8cI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZKOGJKpy; arc=none smtp.client-ip=209.85.167.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZKOGJKpy" Received: by mail-lf1-f49.google.com with SMTP id 2adb3069b0e04-57a604fecb4so7687876e87.1 for ; Tue, 07 Oct 2025 01:34:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1759826075; x=1760430875; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=cYqOhwjmD7QzSDhAXWMY9rlGZsX+SISq8DSEREyGLpc=; b=ZKOGJKpy7XckcOzY2xg2mgVcVwsBC2+oKfQoV+z8cWw5PrF9Ontn7f10p9tZskYtf2 o/sGLylZmrGvsGgW8AC3ToldZsfny8+6rkh/56cidkM24UvOeyYCJlAn7TfxYBeKgWwc 1bIlfgFoIeYtKOeRTijasgRvdoAWI6rgFFWEsTVrdpTX9DJpWC3lWb80Y6tEwZ3ssiCr eGa+sPG1M91kZekK8r0KloA8g5Uf5/hC8F8AQ53rrMk8E5LvYlf9IHIpMpwZQD6JDpq8 WpdbRhnqde30BVooqFIwFIDVCQvWkbAkcILmUZyLBH8OwWxzEYOwZ72kNCNL7PKB9Uag N2UQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759826075; x=1760430875; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=cYqOhwjmD7QzSDhAXWMY9rlGZsX+SISq8DSEREyGLpc=; b=noWUByDKPAgg5Zh+nkFOiGrow+TlnibUt1FFR6qHfbjhCeU7Gxb+Tr3CGO9K4cnfjw Kh6SSoDhfys1ofgNDgOEhPBW73TsATk19MhFFsxHwniwYCVY9qMh3cKs+QzwkT1HH65s lADfz4iw8UmzKE2aVRlVdiblXA71nwlG6rmp4Has9sCUHAWV7x4J2HK09oElnCC7d3dh 2sRJD+sOLjxsKbvnHdIrh43knrB3udbJ9abctno3KYVqQnUeXrDgjIOKyH3n2DaJmZUh 9Kr1qf2vQuhdSnfjzTyJIeiFpx503TEYkCLULVal/rnK17NdlPahvnXUYXao62rsyzEg MN3Q== X-Forwarded-Encrypted: i=1; AJvYcCVaxWD14XBOveT2AvWw0jVBNVm4gJjCnRjn+AvfAh0E9sAYqSKv0nkRcofP4JoPRqEx/orjVJkU1TZu378=@vger.kernel.org X-Gm-Message-State: AOJu0YwNL58ETR71WDJpgbPwyjsm5dWLk35HWUPnUeddEusGsfmAO4Rh RV5g6zyQ3lCAZWhubKK3+n3ayStRXfmC4/3FA4f5n3jThNHNW1TbWdnB X-Gm-Gg: ASbGnctijgiYeR52AWt1p3wHX9FYJRqTwXxYYTOqmPUAr9dfXq/HUgC1n9qrwdpZozT //o6ZRIxh5gFRgilJUVpPqwl5TjeTlsvHO2+X2ATrfYyc8h1QSyjmWubhYUt+NaaB/Me6vBkbH4 W6rVF4Sp5PJlo2a+QMT0UKEJb5MDLBUWAhSQKX30LiNo1AxqaUGY5mTKsffZsXGJtXJBzbA1UQ7 BWWFWcb074E5RwvogJy1G4ADR9rBQ1RlrKK32J6XDvhaaDCKG8IagvRA8TiwDi4g21s6IGayt6o VVCMQNAbrLxF2daNpe6d7CQ2hUXpAx2EUgtUBlvPDCXa/Tjgt9oc2K7dMoRGDk/r7ldNheikY9z icDrpgMHmoRozsnOMuBEeV56Ax7k7g2rKy+/OytI4pH39yVoMRLPJWA== X-Google-Smtp-Source: AGHT+IHsASn0unx/AEqza4jAFGTdIMbVTcQ/sQcaQeucT8a7hY37xmWlyEPjz5QPdJAWskjmEMEQJA== X-Received: by 2002:a05:6512:b09:b0:560:8b86:75ba with SMTP id 2adb3069b0e04-58cbc680d7dmr4384427e87.52.1759826074944; Tue, 07 Oct 2025 01:34:34 -0700 (PDT) Received: from mva-rohm ([2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-58b0119ed6csm5819943e87.105.2025.10.07.01.34.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Oct 2025 01:34:33 -0700 (PDT) Date: Tue, 7 Oct 2025 11:34:30 +0300 From: Matti Vaittinen To: Matti Vaittinen , Matti Vaittinen Cc: Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Sebastian Reichel , Liam Girdwood , Mark Brown , Linus Walleij , Bartosz Golaszewski , Matti Vaittinen , Andreas Kemnade , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-gpio@vger.kernel.org Subject: [RFC PATCH 09/13] gpio: Support ROHM BD72720 gpios Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="bPmL0Nc6G4goy3sK" Content-Disposition: inline In-Reply-To: --bPmL0Nc6G4goy3sK Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" The ROHM BD72720 has 6 pins which may be configured as GPIOs. The GPIO1 ... GPIO5 and EPDEN pins. The configuration is done to OTP at the manufacturing, and it can't be read at runtime. The device-tree is required to tell the software which of the pins are used as GPIOs. Keep the pin mapping static regardless the OTP. This way the user-space can always access the BASE+N for GPIO(N+1) (N =3D 0 to 4), and BASE + 5 for the EPDEN pin. Do this by setting always the number of GPIOs to 6, and by using the valid-mask to invalidate the pins which aren't configured as GPIOs. First two pins can be set to be either input or output by OTP. Direction can't be changed by software. Rest of the pins can be set as outputs only. All of the pins support generating interrupts. Support the Input/Output state getting/setting and the output mode configuration (open-drain/push-pull). Signed-off-by: Matti Vaittinen Acked-by: Bartosz Golaszewski Reviewed-by: Linus Walleij --- drivers/gpio/Kconfig | 9 ++ drivers/gpio/Makefile | 1 + drivers/gpio/gpio-bd72720.c | 281 ++++++++++++++++++++++++++++++++++++ 3 files changed, 291 insertions(+) create mode 100644 drivers/gpio/gpio-bd72720.c diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig index d8ac40d0eb6f..86498c2cb949 100644 --- a/drivers/gpio/Kconfig +++ b/drivers/gpio/Kconfig @@ -1315,6 +1315,15 @@ config GPIO_BD71828 This driver can also be built as a module. If so, the module will be called gpio-bd71828. =20 +config GPIO_BD72720 + tristate "ROHM BD72720 and BD73900 PMIC GPIO support" + depends on MFD_ROHM_BD71828 + help + Support for GPIO on ROHM BD72720 and BD73900 PMICs. There are two + pins which can be configured to GPI or GPO, and three pins which can + be configured to GPO on the ROHM PMIC. The pin configuration is done + on OTP at manufacturing. + config GPIO_BD9571MWV tristate "ROHM BD9571 GPIO support" depends on MFD_BD9571MWV diff --git a/drivers/gpio/Makefile b/drivers/gpio/Makefile index 379f55e9ed1e..15bdaa680ca7 100644 --- a/drivers/gpio/Makefile +++ b/drivers/gpio/Makefile @@ -45,6 +45,7 @@ obj-$(CONFIG_GPIO_BCM_KONA) +=3D gpio-bcm-kona.o obj-$(CONFIG_GPIO_BCM_XGS_IPROC) +=3D gpio-xgs-iproc.o obj-$(CONFIG_GPIO_BD71815) +=3D gpio-bd71815.o obj-$(CONFIG_GPIO_BD71828) +=3D gpio-bd71828.o +obj-$(CONFIG_GPIO_BD72720) +=3D gpio-bd72720.o obj-$(CONFIG_GPIO_BD9571MWV) +=3D gpio-bd9571mwv.o obj-$(CONFIG_GPIO_BLZP1600) +=3D gpio-blzp1600.o obj-$(CONFIG_GPIO_BRCMSTB) +=3D gpio-brcmstb.o diff --git a/drivers/gpio/gpio-bd72720.c b/drivers/gpio/gpio-bd72720.c new file mode 100644 index 000000000000..6549dbf4c7ad --- /dev/null +++ b/drivers/gpio/gpio-bd72720.c @@ -0,0 +1,281 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Support to GPIOs on ROHM BD72720 and BD79300 + * Copyright 2025 ROHM Semiconductors. + * Author: Matti Vaittinen + */ + +#include +#include +#include +#include +#include +#include +#include + +#define BD72720_GPIO_OPEN_DRAIN 0 +#define BD72720_GPIO_CMOS BIT(1) +#define BD72720_INT_GPIO1_IN_SRC 4 +/* + * The BD72720 has several "one time programmable" (OTP) configurations wh= ich + * can be set at manufacturing phase. A set of these options allow using p= ins + * as GPIO. The OTP configuration can't be read at run-time, so drivers re= ly on + * device-tree to advertise the correct options. + * + * Both DVS[0,1] pins can be configured to be used for: + * - OTP0: regulator RUN state control + * - OTP1: GPI + * - OTP2: GPO + * - OTP3: Power sequencer output + * Data-sheet also states that these PINs can always be used for IRQ but = the + * driver limits this by allowing them to be used for IRQs with OTP1 only. + * + * Pins GPIO_EXTEN0 (GPIO3), GPIO_EXTEN1 (GPIO4), GPIO_FAULT_B (GPIO5) hav= e OTP + * options for a specific (non GPIO) purposes, but also an option to confi= gure + * them to be used as a GPO. + * + * OTP settings can be separately configured for each pin. + * + * DT properties: + * "rohm,pin-dvs0" and "rohm,pin-dvs1" can be set to one of the values: + * "dvs-input", "gpi", "gpo". + * + * "rohm,pin-exten0", "rohm,pin-exten1" and "rohm,pin-fault_b" can be set = to: + * "gpo" + */ + +enum bd72720_gpio_state { + BD72720_PIN_UNKNOWN, + BD72720_PIN_GPI, + BD72720_PIN_GPO, +}; + +enum { + BD72720_GPIO1, + BD72720_GPIO2, + BD72720_GPIO3, + BD72720_GPIO4, + BD72720_GPIO5, + BD72720_GPIO_EPDEN, + BD72720_NUM_GPIOS +}; + +struct bd72720_gpio { + /* chip.parent points the MFD which provides DT node and regmap */ + struct gpio_chip chip; + /* dev points to the platform device for devm and prints */ + struct device *dev; + struct regmap *regmap; + int gpio_is_input; +}; + +static int bd72720gpi_get(struct bd72720_gpio *bdgpio, unsigned int reg_of= fset) +{ + int ret, val, shift; + + ret =3D regmap_read(bdgpio->regmap, BD72720_REG_INT_ETC1_SRC, &val); + if (ret) + return ret; + + shift =3D BD72720_INT_GPIO1_IN_SRC + reg_offset; + + return (val >> shift) & 1; +} + +static int bd72720gpo_get(struct bd72720_gpio *bdgpio, + unsigned int offset) +{ + const int regs[] =3D { BD72720_REG_GPIO1_CTRL, BD72720_REG_GPIO2_CTRL, + BD72720_REG_GPIO3_CTRL, BD72720_REG_GPIO4_CTRL, + BD72720_REG_GPIO5_CTRL, BD72720_REG_EPDEN_CTRL }; + int ret, val; + + ret =3D regmap_read(bdgpio->regmap, regs[offset], &val); + if (ret) + return ret; + + return val & BD72720_GPIO_HIGH; +} + +static int bd72720gpio_get(struct gpio_chip *chip, unsigned int offset) +{ + struct bd72720_gpio *bdgpio =3D gpiochip_get_data(chip); + + if (BIT(offset) & bdgpio->gpio_is_input) + return bd72720gpi_get(bdgpio, offset); + + return bd72720gpo_get(bdgpio, offset); +} + +static int bd72720gpo_set(struct gpio_chip *chip, unsigned int offset, + int value) +{ + struct bd72720_gpio *bdgpio =3D gpiochip_get_data(chip); + const int regs[] =3D { BD72720_REG_GPIO1_CTRL, BD72720_REG_GPIO2_CTRL, + BD72720_REG_GPIO3_CTRL, BD72720_REG_GPIO4_CTRL, + BD72720_REG_GPIO5_CTRL, BD72720_REG_EPDEN_CTRL }; + + if (BIT(offset) & bdgpio->gpio_is_input) { + dev_dbg(bdgpio->dev, "pin %d not output.\n", offset); + return -EINVAL; + } + + if (value) + return regmap_set_bits(bdgpio->regmap, regs[offset], + BD72720_GPIO_HIGH); + + return regmap_clear_bits(bdgpio->regmap, regs[offset], + BD72720_GPIO_HIGH); +} + +static int bd72720_gpio_set_config(struct gpio_chip *chip, unsigned int of= fset, + unsigned long config) +{ + struct bd72720_gpio *bdgpio =3D gpiochip_get_data(chip); + const int regs[] =3D { BD72720_REG_GPIO1_CTRL, BD72720_REG_GPIO2_CTRL, + BD72720_REG_GPIO3_CTRL, BD72720_REG_GPIO4_CTRL, + BD72720_REG_GPIO5_CTRL, BD72720_REG_EPDEN_CTRL }; + + /* + * We can only set the output mode, which makes sense only when output + * OTP configuration is used. + */ + if (BIT(offset) & bdgpio->gpio_is_input) + return -ENOTSUPP; + + switch (pinconf_to_config_param(config)) { + case PIN_CONFIG_DRIVE_OPEN_DRAIN: + return regmap_update_bits(bdgpio->regmap, + regs[offset], + BD72720_GPIO_DRIVE_MASK, + BD72720_GPIO_OPEN_DRAIN); + case PIN_CONFIG_DRIVE_PUSH_PULL: + return regmap_update_bits(bdgpio->regmap, + regs[offset], + BD72720_GPIO_DRIVE_MASK, + BD72720_GPIO_CMOS); + default: + break; + } + + return -ENOTSUPP; +} + +static int bd72720gpo_direction_get(struct gpio_chip *chip, + unsigned int offset) +{ + struct bd72720_gpio *bdgpio =3D gpiochip_get_data(chip); + + if (BIT(offset) & bdgpio->gpio_is_input) + return GPIO_LINE_DIRECTION_IN; + + return GPIO_LINE_DIRECTION_OUT; +} + +static int bd72720_valid_mask(struct gpio_chip *gc, + unsigned long *valid_mask, + unsigned int ngpios) +{ + static const char * const properties[] =3D { + "rohm,pin-dvs0", "rohm,pin-dvs1", "rohm,pin-exten0", + "rohm,pin-exten1", "rohm,pin-fault_b" + }; + struct bd72720_gpio *g =3D gpiochip_get_data(gc); + const char *val; + int i, ret; + + *valid_mask =3D BIT(BD72720_GPIO_EPDEN); + + if (!gc->parent) + return 0; + + for (i =3D 0; i < ARRAY_SIZE(properties); i++) { + ret =3D fwnode_property_read_string(dev_fwnode(gc->parent), + properties[i], &val); + + if (ret) { + if (ret =3D=3D -EINVAL) + continue; + + dev_err(g->dev, "pin %d (%s), bad configuration\n", i, + properties[i]); + + return ret; + } + + if (strcmp(val, "gpi") =3D=3D 0) { + if (i !=3D BD72720_GPIO1 && i !=3D BD72720_GPIO2) { + dev_warn(g->dev, + "pin %d (%s) does not support INPUT mode", + i, properties[i]); + continue; + } + + *valid_mask |=3D BIT(i); + g->gpio_is_input |=3D BIT(i); + } else if (strcmp(val, "gpo") =3D=3D 0) { + *valid_mask |=3D BIT(i); + } + } + + return 0; +} + +/* Template for GPIO chip */ +static const struct gpio_chip bd72720gpo_chip =3D { + .label =3D "bd72720", + .owner =3D THIS_MODULE, + .get =3D bd72720gpio_get, + .get_direction =3D bd72720gpo_direction_get, + .set =3D bd72720gpo_set, + .set_config =3D bd72720_gpio_set_config, + .init_valid_mask =3D bd72720_valid_mask, + .can_sleep =3D true, + .ngpio =3D BD72720_NUM_GPIOS, + .base =3D -1, +}; + +static int gpo_bd72720_probe(struct platform_device *pdev) +{ + struct bd72720_gpio *g; + struct device *parent, *dev; + + /* + * Bind devm lifetime to this platform device =3D> use dev for devm. + * also the prints should originate from this device. + */ + dev =3D &pdev->dev; + /* The device-tree and regmap come from MFD =3D> use parent for that */ + parent =3D dev->parent; + + g =3D devm_kzalloc(dev, sizeof(*g), GFP_KERNEL); + if (!g) + return -ENOMEM; + + g->chip =3D bd72720gpo_chip; + g->dev =3D dev; + g->chip.parent =3D parent; + g->regmap =3D dev_get_regmap(parent, NULL); + + return devm_gpiochip_add_data(dev, &g->chip, g); +} + +static const struct platform_device_id bd72720_gpio_id[] =3D { + { "bd72720-gpio" }, + { }, +}; +MODULE_DEVICE_TABLE(platform, bd72720_gpio_id); + +static struct platform_driver gpo_bd72720_driver =3D { + .driver =3D { + .name =3D "bd72720-gpio", + .probe_type =3D PROBE_PREFER_ASYNCHRONOUS, + }, + .probe =3D gpo_bd72720_probe, + .id_table =3D bd72720_gpio_id, +}; +module_platform_driver(gpo_bd72720_driver); + +MODULE_AUTHOR("Matti Vaittinen "); +MODULE_DESCRIPTION("GPIO interface for BD72720 and BD73900"); +MODULE_LICENSE("GPL"); --=20 2.51.0 --bPmL0Nc6G4goy3sK Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEIx+f8wZb28fLKEhTeFA3/03aocUFAmjk0JYACgkQeFA3/03a ocVRSQgAsGU4yl/v9avbTHL13POxAGZTvz0dBHS8YmZ8iZ0q8NYZf+Rd4mFp6DWC GFQjV6ttE8VfpKQnD3YYTY/+ZqX2mKpMrJ2EuLHIFGse7VR1pVmpFhnLKgJE9zAw RsFeeU1ZtnZIy7pmt77VWw+TLGuwfzBt7mY0miRbnu5pQ4RvrX3vc2F7IjfDAjTw ZsHtEXcfl0TsrQ1IWVKQyP0zei6vt7b/oLLVwPuypd0mMOAzgh+pACtrIMDT4V89 yOtVvjmBITgfgHKhNSF3Vh2AEFne6xWe+8LAJ/lWcRazdpX/J6BK+DWHijSVthjD nn2oeJ3ecs/2lreA4JD5b8ZqY2ZN0w== =vhGB -----END PGP SIGNATURE----- --bPmL0Nc6G4goy3sK-- From nobody Wed Feb 11 03:42:00 2026 Received: from mail-lj1-f181.google.com (mail-lj1-f181.google.com [209.85.208.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0AF2A2D94BB for ; Tue, 7 Oct 2025 08:34:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759826090; cv=none; b=PA+SsldGpcYv8RpqYUH+fkM0HnslIYm0P98YPWrBUkvi5O4OQwDs45G+0bQjiR3Bq6qsp2sRCYdf7Lpl6g5WcEHMmQ0kwPVYUiIN/Nf7J2zPiZfoL0UMsn0pru3Bc2sd5JccQE4BH59XomiPUDnYXcvOaO+mBg5f/V2vTUNvKZo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759826090; c=relaxed/simple; bh=GUSjLjlYDEl8o6/jXjuzBG5/s1EogFROA51N25GkeDA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XjUlc6SR4KYa1Mnes8Jsh6iTK1rCQc8AWDMOvktEGo7BJ5twYhTUJZH6TNhCsheQBA6JWv7XWg+DR+fuL4yhpO0SjvUllp00ItgOkcziufZyOo9I3UtVgwB9TuzfiUl2e664ikATeV0MemkirpxdzkqwTnP0Qv6yGUqOAzZKB3o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mUZk0Fb8; arc=none smtp.client-ip=209.85.208.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mUZk0Fb8" Received: by mail-lj1-f181.google.com with SMTP id 38308e7fff4ca-36a448c8aa2so48521071fa.0 for ; Tue, 07 Oct 2025 01:34:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1759826087; x=1760430887; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=N4czLOo5ZnN18HLnOcC7pqQ0t9QPNLqdBoEDTR9BH/I=; b=mUZk0Fb8f9hWI98v4xxsInXObeVr8oqrgB9R0/IwE1M9YVV3VGz+Sr5UpDrQAbG++J kwy6COdt8ZLpkvq1UUl6h+cDMS1cP1f0cCLK7A7L4Kwewo1U1uO+UtU1nSeLHH0O5Gco S64RPPU4OaOe4qcZCUp1hnC6xoz4qys8kROWCj+1fJY35K1uaj9nrG5aLa0q55P6UJkZ 5nOdjbdylg1f7zeDDttzoFdYi9rl4ABdcvg3jDI42Q4L0Krq0gdzHIYJX7jMi1v4cohm n6fSo0FraSyifJVjFT5RaoqJyfVLP4TcdqTTiH18lONXVuKWigIPdbVt0DLKg7FjcnrU w6Vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759826087; x=1760430887; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=N4czLOo5ZnN18HLnOcC7pqQ0t9QPNLqdBoEDTR9BH/I=; b=lejd0etZ5wpYwKvGtlSwU1AquTt9EAgnnGnV5quhJpMq2D7x0hpKAyVIbOFUH+T+VN kQvG5koQDxj1p8wuhLebECEfl7sU5PcGeCnRA8xs54gxxKP76N8mJPvkEdEXfm0jdhI2 q3LGfw7MOfHS3C0+Ttslz7sioz8Li/yNXO+rl1reoVbpVuijtIS+zHx/1dilwHxNdDIR cI7wnHjd5rZGzuDgSSUngGFiX3TsKpkX9fUPFPBkmHBYRPa1d4Bl6GSCybd61GdNTTbi i3NZ0xajcGzTNGFzcr2YYiCrOqvrZU4v+tKYEMHdGDe3QQgl9DI1kCKMk3iWANm7jaO7 946g== X-Forwarded-Encrypted: i=1; AJvYcCUVu68pfds5iPFbEcrb6BWogiptJ1DMp2OFIlNH6ohf+lL0Fltr3v4hMPjC9W4cmVOgY+QEP8O7Q7CFQ8Q=@vger.kernel.org X-Gm-Message-State: AOJu0YxndPTA83uIcY7UbuyguD/bwGQOagGfGHwnumHinn/NvXtYzfKu s1sbZt+e4s6FuNdJlh4jshx2Z7B4v6sCNK5xpSNM2/tblT3KsV8SmU41 X-Gm-Gg: ASbGncs1uwuVTUXkb/IKxp84Y9NcT2WpHNUj/J9hs+Tn7uS/NzIy+BXrr3gklGlztgH IFQQJvmHCMHAAFBMDbCfO7KvznUbk+KTXad8JYYUGypfC/5UU49nDwIWCeGMCUJc+P1v8TVCp3C JhLI02Wve0mOB9zIHxW4KlSs7NUPtIX33SY7pdoXHiuua/rTNCooWIamYiRWymTPd/46HdRgC1I kS7aahLaQq0o6xG1nyqx6QCsIMXNgbhlPId8/aL4FmYhDDokobodwbkH3NezT/fRZuhqjg34Dal ESmmVAR+UteWsgmDGvXjKYe2b7Yd49FBMPBpXbMyqNSi+73GJPfzCpz+b0WtfcBClRfA0IeeE1c syhbqJWV36JSZuJUFHHBUdItfFMpDlPj5g9P45x5KjqbAG15MpzC154vd9R9AgmwH X-Google-Smtp-Source: AGHT+IFJwLelYLgNdfM+CTGIlVmgHDyXSlhZErg/oypat4GW4z8fl0IXAAmciErEk8L811heCPgGOA== X-Received: by 2002:a2e:bcc2:0:b0:372:8cc8:fc3d with SMTP id 38308e7fff4ca-374c36a532bmr52952751fa.1.1759826087055; Tue, 07 Oct 2025 01:34:47 -0700 (PDT) Received: from mva-rohm ([2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-375f39d2f9asm7808841fa.2.2025.10.07.01.34.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Oct 2025 01:34:45 -0700 (PDT) Date: Tue, 7 Oct 2025 11:34:42 +0300 From: Matti Vaittinen To: Matti Vaittinen , Matti Vaittinen Cc: Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Sebastian Reichel , Liam Girdwood , Mark Brown , Linus Walleij , Bartosz Golaszewski , Matti Vaittinen , Andreas Kemnade , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-gpio@vger.kernel.org Subject: [RFC PATCH 10/13] clk: clk-bd718x7: Support BD72720 clk gate Message-ID: <73e5485c34db0667b505bf73b597e0b3cd1b6060.1759824376.git.mazziesaccount@gmail.com> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="4M+VUMaCtdns8Dyt" Content-Disposition: inline In-Reply-To: --4M+VUMaCtdns8Dyt Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" The BD72720 has similar simple clk gate as a few other ROHM PMICs. Add support for BD72720 clk gate. Signed-off-by: Matti Vaittinen --- drivers/clk/Kconfig | 4 ++-- drivers/clk/clk-bd718x7.c | 10 ++++++++-- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig index 4d56475f94fc..9742a3d0c1cb 100644 --- a/drivers/clk/Kconfig +++ b/drivers/clk/Kconfig @@ -474,8 +474,8 @@ config COMMON_CLK_BD718XX tristate "Clock driver for 32K clk gates on ROHM PMICs" depends on MFD_ROHM_BD718XX || MFD_ROHM_BD71828 help - This driver supports ROHM BD71837, BD71847, BD71850, BD71815 - and BD71828 PMICs clock gates. + This driver supports ROHM BD71837, BD71847, BD71850, BD71815, + BD71828, and BD72720 PMICs clock gates. =20 config COMMON_CLK_FIXED_MMIO bool "Clock driver for Memory Mapped Fixed values" diff --git a/drivers/clk/clk-bd718x7.c b/drivers/clk/clk-bd718x7.c index ac40b669d60b..1cae974e6d1d 100644 --- a/drivers/clk/clk-bd718x7.c +++ b/drivers/clk/clk-bd718x7.c @@ -19,7 +19,8 @@ #define BD71828_REG_OUT32K 0x4B /* BD71837 and BD71847 */ #define BD718XX_REG_OUT32K 0x2E - +/* BD72720 */ +#define BD72720_REG_OUT32K 0x9a /* * BD71837, BD71847, and BD71828 all use bit [0] to clk output control */ @@ -118,6 +119,10 @@ static int bd71837_clk_probe(struct platform_device *p= dev) c->reg =3D BD71815_REG_OUT32K; c->mask =3D CLK_OUT_EN_MASK; break; + case ROHM_CHIP_TYPE_BD72720: + c->reg =3D BD72720_REG_OUT32K; + c->mask =3D CLK_OUT_EN_MASK; + break; default: dev_err(&pdev->dev, "Unknown clk chip\n"); return -EINVAL; @@ -146,6 +151,7 @@ static const struct platform_device_id bd718x7_clk_id[]= =3D { { "bd71847-clk", ROHM_CHIP_TYPE_BD71847 }, { "bd71828-clk", ROHM_CHIP_TYPE_BD71828 }, { "bd71815-clk", ROHM_CHIP_TYPE_BD71815 }, + { "bd72720-clk", ROHM_CHIP_TYPE_BD72720 }, { }, }; MODULE_DEVICE_TABLE(platform, bd718x7_clk_id); @@ -161,6 +167,6 @@ static struct platform_driver bd71837_clk =3D { module_platform_driver(bd71837_clk); =20 MODULE_AUTHOR("Matti Vaittinen "); -MODULE_DESCRIPTION("BD718(15/18/28/37/47/50) and chip clk driver"); +MODULE_DESCRIPTION("BD718(15/18/28/37/47/50) and BD72720 chip clk driver"); MODULE_LICENSE("GPL"); MODULE_ALIAS("platform:bd718xx-clk"); --=20 2.51.0 --4M+VUMaCtdns8Dyt Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQEyBAEBCgAdFiEEIx+f8wZb28fLKEhTeFA3/03aocUFAmjk0KIACgkQeFA3/03a ocU5WQf459k37WyeXVlkrKuVW7Svb4MOFVMVF+lU5Ux0Ov1BTXkwmyryvKWnRVcU m8N29E9g+ugj9vvNdnEVMKYcFM1F5VhGz1NdmIZ07SCDA8hw0/efqI7kE/0ye1g6 +5AQgMLpSxOnUy7gXAJnQXIASTfn+fkMTVmuSARJwV/VO2Rvhe3R97uOXTczzhxF BGFkeZXLr5ZM0p/UWKwoWk4GBtPNADjXnIgoQ+nGxnosR6YgwHNkWnNvs/O+XhM5 Hdew+uEBnmvmrjPpGKI00q5xV+6HC74toCTut0C4JZq2LwhXELCmrPJUhowOWV2s 12St76wJX1azrQiHe7ecQR+O8RYL =XN3R -----END PGP SIGNATURE----- --4M+VUMaCtdns8Dyt-- From nobody Wed Feb 11 03:42:00 2026 Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 82C862D8377 for ; Tue, 7 Oct 2025 08:35:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759826102; cv=none; b=syklZgYqa47D1pmCNPn1BhLT+S8fLsV+8vO90cAjbRUYtR/sqou/h7RMdYuI3rp+soCBK+DF3+HiFSlWwNoVwAFtuyPpYx3WwdE/9jdS/8p8akHvitUHMbrSXOEGM9YmZKx1OUhv5lGxIqMP8qOWUXie2PUpkUo7SgIvpNWwtd4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759826102; c=relaxed/simple; bh=fMwGdCHxW6MohES2gJ+t6jTXcg1ARbhvMneIwOskBWs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DZarE77f56gAHaKnjZig/ws29WwQiHT+l83aeJwto6x03wGgPnkLoEhI22+Xa3kdXRZlhbdKgBIwn/Xey1XdomKL2oqz1gaK7bUYNwPcidkE1j626OS5Hc+7hNi0MN4OEKgi//fPc3NiY2LE0s5kILASHNe5/WBVvp5n2aOyun0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DDo6RDzK; arc=none smtp.client-ip=209.85.167.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DDo6RDzK" Received: by mail-lf1-f52.google.com with SMTP id 2adb3069b0e04-57d5ccd73dfso6483113e87.0 for ; Tue, 07 Oct 2025 01:35:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1759826099; x=1760430899; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=kcGIK7vGgNItvss7aw1s/UA59XuZ3yqeQ2L8mlry6dY=; b=DDo6RDzKLMxcXJ86L6Y39g8g6DMEhIHvdAWtTbvTsNiNPQ1KUSj7zaSuskbF0W4f1F slvwDRUGHv5xxqcEsbuariWD5j6ZibeyIpc9r4iuxqOieELM3XmuJNjC1IWU+7ZBqBWp lLgM10DKe55aZf1zmwpV859DEFBEDdJXh3G4pqYfdvAMQgmmB0wiQNCe/7mM3NvtSQ5R XVFlFdiSJtMaoXJQzjSJISd5XUjOrnSeSiznsBr0495gisBzzv4LHHvS0/H/ihYwr8ti zQy6KjvKnBQn5d+Ixz4Heve0+H1YEOCNDoR3nOEDOzrTJLhZRvIii/gRvyn+cIZaJiCR byDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759826099; x=1760430899; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=kcGIK7vGgNItvss7aw1s/UA59XuZ3yqeQ2L8mlry6dY=; b=rwI/xrZ/5feM99KeEPGBLDewJexLbv1dbQauUZGtIoPdvWojaJeXpaNQe0WylG9gxv VJfa3id2WSEulwcdE4QQymU3hsRUUw12i5oV7/oPO+huaoLPOrKL86/WPjw3LLjqsfdq TLbXmggcCkFxvdZM8eI8/+Y09vvm/xtOAP9ubzeAg/P0P6hjHE3+QunbK4mHVoBArT1J L6z46CwgeXAl1OiMreG/6IbE929RWOyaURTLVzyskf0jHGX7wuMQd42PauTPQ806Zx/G N3CSKr8rzh7hakZCdkWN8NrZ10c1hcaJp6DpURhchJTvbeu4V4i4GCsSgZ24t3S0164F +Idw== X-Forwarded-Encrypted: i=1; AJvYcCV1QAEfdPtHPJjlOv2nubGEqVqh/V5V+Bie7XEWFjPHkUhBDlTGOGakA/a4dQkXZjPfXiCZNtO4h5I7nek=@vger.kernel.org X-Gm-Message-State: AOJu0Yzv+P/zP4puZ/6L20BnIzQ0XEFi6O+h7yN4N9noQnFfycSEpiZH fCRIFHRghr2kkzMUpBehHikwtXzYuHhzXUr8Nbnkltnae9PTe6KHm12K X-Gm-Gg: ASbGncvKq2gQ8JKg6HpZtDteGze9M86TwQdZRCIYOftnXpixZ5K7FjZXGRWTS6fPcUQ 8uWBeeF17rQzDDrPhgoUic75GBC0RmYKcLouHlnUb1AQefm4YGOaF2pHBGc7/jdgU+oE57WTsZA +rnBxLrJFUKFPoh4b3fODrhXAf+BN/KyHxYJVzOjTCYxdLD/DxZRnLvGXMo9Y1G9Ai56a3RkZ9R Eiq9tNXpH5lOQS+nZitPBKcMWtAllejhPFWAKzkxx267nrfIcd0Uki7loWlCLdfYEX3ujF4rpqs Zs5JDIBBbkFaNTyXryX5ybrDp4B9WuRn9We5As5TQhK7YC/u5HwntVPBd9g3KTldBQryhrxO5CP N+NcBthhgunBCDpC89vu+hdL0k1w1vjLMgq6PEoTana1bOQT7mp0eqA== X-Google-Smtp-Source: AGHT+IGCbWe72EPI8Kp5w6LOnXEcbYgJJAxOm5elS0846ZapppkzFMhVx/E//4GlXKMS6GDX9s2FtA== X-Received: by 2002:a05:6512:2242:b0:57b:b4da:2712 with SMTP id 2adb3069b0e04-58cb9f0b31emr4945789e87.4.1759826098553; Tue, 07 Oct 2025 01:34:58 -0700 (PDT) Received: from mva-rohm ([2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-58b0118d857sm5845292e87.84.2025.10.07.01.34.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Oct 2025 01:34:57 -0700 (PDT) Date: Tue, 7 Oct 2025 11:34:53 +0300 From: Matti Vaittinen To: Matti Vaittinen , Matti Vaittinen Cc: Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Sebastian Reichel , Liam Girdwood , Mark Brown , Linus Walleij , Bartosz Golaszewski , Matti Vaittinen , Andreas Kemnade , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-gpio@vger.kernel.org Subject: [RFC PATCH 11/13] rtc: bd70528: Support BD72720 rtc Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="07FidvfY5dUcjP6S" Content-Disposition: inline In-Reply-To: --07FidvfY5dUcjP6S Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" The BD72720 has similar RTC block as a few other ROHM PMICs. Add support for BD72720 RTC. Signed-off-by: Matti Vaittinen --- drivers/rtc/Kconfig | 3 ++- drivers/rtc/rtc-bd70528.c | 21 ++++++++++++++------- 2 files changed, 16 insertions(+), 8 deletions(-) diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig index 64f6e9756aff..bf7d78a65ac3 100644 --- a/drivers/rtc/Kconfig +++ b/drivers/rtc/Kconfig @@ -541,7 +541,8 @@ config RTC_DRV_BD70528 depends on MFD_ROHM_BD71828 help If you say Y here you will get support for the RTC - block on ROHM BD71815 and BD71828 Power Management IC. + block on ROHM BD71815, BD71828 and BD72720 Power + Management ICs. =20 This driver can also be built as a module. If so, the module will be called rtc-bd70528. diff --git a/drivers/rtc/rtc-bd70528.c b/drivers/rtc/rtc-bd70528.c index 954ac4ef53e8..4c8599761b2e 100644 --- a/drivers/rtc/rtc-bd70528.c +++ b/drivers/rtc/rtc-bd70528.c @@ -7,6 +7,7 @@ #include #include #include +#include #include #include #include @@ -262,13 +263,13 @@ static int bd70528_probe(struct platform_device *pdev) =20 /* * See also BD718XX_ALM_EN_OFFSET: - * This works for BD71828 and BD71815 as they have same offset - * between ALM0 start and ALM0_MASK. If new ICs are to be - * added this requires proper check as ALM0_MASK is not located - * at the end of ALM0 block - but after all ALM blocks so if - * amount of ALMs differ the offset to enable/disable is likely - * to be incorrect and enable/disable must be given as own - * reg address here. + * This works for BD71828, BD71815, and BD72720 as they all + * have same offset between the ALM0 start and the ALM0_MASK. + * If new ICs are to be added this requires proper check as + * the ALM0_MASK is not located at the end of ALM0 block - + * but after all ALM blocks. If amount of ALMs differ, the + * offset to enable/disable is likely to be incorrect and + * enable/disable must be given as own reg address here. */ bd_rtc->bd718xx_alm_block_start =3D BD71815_REG_RTC_ALM_START; hour_reg =3D BD71815_REG_HOUR; @@ -278,6 +279,11 @@ static int bd70528_probe(struct platform_device *pdev) bd_rtc->bd718xx_alm_block_start =3D BD71828_REG_RTC_ALM_START; hour_reg =3D BD71828_REG_RTC_HOUR; break; + case ROHM_CHIP_TYPE_BD72720: + bd_rtc->reg_time_start =3D BD72720_REG_RTC_START; + bd_rtc->bd718xx_alm_block_start =3D BD72720_REG_RTC_ALM_START; + hour_reg =3D BD72720_REG_RTC_HOUR; + break; default: dev_err(&pdev->dev, "Unknown chip\n"); return -ENOENT; @@ -337,6 +343,7 @@ static int bd70528_probe(struct platform_device *pdev) static const struct platform_device_id bd718x7_rtc_id[] =3D { { "bd71828-rtc", ROHM_CHIP_TYPE_BD71828 }, { "bd71815-rtc", ROHM_CHIP_TYPE_BD71815 }, + { "bd72720-rtc", ROHM_CHIP_TYPE_BD72720 }, { }, }; MODULE_DEVICE_TABLE(platform, bd718x7_rtc_id); --=20 2.51.0 --07FidvfY5dUcjP6S Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEIx+f8wZb28fLKEhTeFA3/03aocUFAmjk0K0ACgkQeFA3/03a ocXDUgf/ZbkPG920ohos13zRqVRAQv+HF6pfsQERzwzHlzfgMSY3VkeeJm3b9kxN Ue5IgVM6nwFTNtrr4SRu1raabFMIyBLeIzwxwsO6XimDtaeTbCkYsvkz9th4IMAB cXun1LA/d/NBCXS/tiR+sofrpCPnAB1Mug2/U2I8yimHWHTYWOok3xkLIAbl10H9 iDeH8HPaRR2QQgHJcYexf8uoq9vR3PQfT+qJnOFVaCDqYZLr+jdG5TPtoB7avWL4 B0BjmJ/Wg5RhqN8aWTlBldxjJeUKlBW/+ITEZYcZjUKCXr30Z2TYx9jHV7378hLh lU7OZE9Yd/96TA6C2NbsUg5cs6ONLQ== =koec -----END PGP SIGNATURE----- --07FidvfY5dUcjP6S-- From nobody Wed Feb 11 03:42:00 2026 Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 31C702D8377 for ; Tue, 7 Oct 2025 08:35:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759826114; cv=none; b=QutOxJBVr5y1T6yAm35480d62eMrSxczNZveKLx1HAPA5YbL1tJ8q8ea1cHSQsQ7mMd5tHr9eeUr9tmkn81X2Wr/LzidoK9bvBZv/km6Eub1tLmHbb5k/5QncpaB2pY1aTfx6nkexWuJHPX8T8CtdhGJw0y7QcwCAV7SyGc5lMw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759826114; c=relaxed/simple; bh=DjJ1vgjQstdJaFuNqie2mOz+vz+GQCcJqKmvB1Vo+W0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ZEZrHiuqWncaAySX/QuSA7Bm6kPmOfxtZtPdhoQaGWUQs1xeUGTlQSntHk5CjG5YTCw1aXxZJFUNuDUhSKtdWuyRkUjEr9ulNWKF1a6PaCdAPhJmlVAQoo5LawCCtHK2JNAGI762nM01DHogfvSeuDLnww99PmeyAccFudO4k60= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fBQNsH68; arc=none smtp.client-ip=209.85.167.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fBQNsH68" Received: by mail-lf1-f52.google.com with SMTP id 2adb3069b0e04-57bd04f2e84so6734392e87.1 for ; Tue, 07 Oct 2025 01:35:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1759826110; x=1760430910; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=WjfifAnvt7omtcWtAC6HoiCGnm3cPbQmEnl3NjpQZmY=; b=fBQNsH68id1Y/kGkhNjpd7mPS+ntU6aJIwJYi9q+xekuYm6mMUkcUCQaRkihQQ22a9 DOf3wUC4/aUqa0JAqz24yfaION5AgPLOEkEu9eNS9H/8g71voFzT1mjAzNLTUFqrLtYc KbZ6M3ji6yN5GgN5iFiGwUcME5Vv11s4xqaLD5X+4Epw1PemuJVsJG+HOgjP/MpVZSlN MZaLnnETUhmLrim/zMgFJUVfwquBV6vzszS50Kaz+KlKzWzpuwsEcmJnc5KfugSgDoqb 9hjKtsv9HIFyd0d+MSyG4YqyNyAbkdj84WI068DMKDdsLC6+rws7AGvN7vqFpLpd8qxg PaNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759826110; x=1760430910; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=WjfifAnvt7omtcWtAC6HoiCGnm3cPbQmEnl3NjpQZmY=; b=dkN96HLCcL1NfL8j4XxFOg4N53CNplldkdNr4kZKPglIm/8CPwPXxyZXwiEalW7QVe xy2oBMqZ2wAKmbhR8WXoKJqMVeD/rIB5XjQNMgw7mbC04EPbwfvtr+hXTcShBgugez6c qycdZ6XqXVamieDM5nHNIsI5t4jmMaSnpVsRRQR1a4LUerBBVTAWOdQVTor77Kjl/lMj ip9ytRoBK9cwAvXgA6Ic/stxFFNpPxXYfWImytU3vfw/gagNAJj602BvN7rKH7DrWCwj r2OX/q/rIlzAAvhhdoQVBQ6ot0wZawDXHUGA5tm2gshEHm/RbqwfkpA4KOh9zTUZdu7b 6Zsg== X-Forwarded-Encrypted: i=1; AJvYcCULJuitU6HVKg+uxqO4Kx5+VkJ+0Fwn0qTRWAKdRKU11xQ5KhSfYlVbTHa6h27kdWANya9Ha9yYbIRf96E=@vger.kernel.org X-Gm-Message-State: AOJu0YzMHxwNoq6bLYaquP2CSPC+ubqjUpDhqNyZH2teu4yKK7aPOGlf mnj9dJTFxu9UVOchSF2V9VwHiqCvwCf34Z2N6ElOWdIUEqRCnEpIrmIt X-Gm-Gg: ASbGncthM7u6SrFERJg4ASPIsRmQEVUtnzCJZ+CT37qjFywXgU7X8PBtIM80e8PC7qt 3QXIwVWifCRHMx0qwtLHKin8LoBYr+OCMfGqfy/RerBn7QOksJsXsh08fOUcqO+0L6WF4N4qb8d hqa8w7SwldrH3Kig3Nltz6it8Q/z2RRCKtpwgEs/C+NvTWQ/bmWaPxS9VFaDJZdLGma3c6Mx05g jD2cFGauGEJeIsW6+mua0s7AwzPjpJKTjWYeb5Xcnps9A0yAgZi/ttxnk3QFN9WD3E7UDPLT0pX Kv98kNxCQTcWn3M/McQ6QaII51Z6B4ILxo3Gd0qIhh7h3nFPOPW7T8RJQa9V1X2SY07g1f8fYh6 DKWhadzZthZcj5gQE9qe6ri/io6OZZww7QMcUQbN1RnPnP7d5MtC0/Q== X-Google-Smtp-Source: AGHT+IGeAjD9L5LXbUGqgoDzxxWOv4cpq97R3lyvrrA9crXR7Irv8HRoFJ8h4YjD9CHyjmPOUB0knw== X-Received: by 2002:a05:6512:3e04:b0:58b:151:bc0a with SMTP id 2adb3069b0e04-58cbbfc322fmr4367193e87.49.1759826109942; Tue, 07 Oct 2025 01:35:09 -0700 (PDT) Received: from mva-rohm ([2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-58b0118d6e6sm5862425e87.78.2025.10.07.01.35.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Oct 2025 01:35:08 -0700 (PDT) Date: Tue, 7 Oct 2025 11:35:05 +0300 From: Matti Vaittinen To: Matti Vaittinen , Matti Vaittinen Cc: Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Sebastian Reichel , Liam Girdwood , Mark Brown , Linus Walleij , Bartosz Golaszewski , Matti Vaittinen , Andreas Kemnade , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-gpio@vger.kernel.org Subject: [RFC PATCH 12/13] power: supply: bd71828-power: Support ROHM BD72720 Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="FNeSZYeqkJDtuOLg" Content-Disposition: inline In-Reply-To: --FNeSZYeqkJDtuOLg Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" The ROHM BD72720 is a power management IC with a charger and coulomb counter block which is closely related to the charger / coulomb counter found from the BD71815, BD71828, BD71879 which are all supported by the bd71828-power driver. Due to the similarities it makes sense to support also the BD72720 with the same driver. Add basic support for the charger logic on ROHM BD72720. Signed-off-by: Matti Vaittinen --- Note: This patch depends on the series: "power: supply: add charger for BD71828" by Andreas: https://lore.kernel.org/all/20250918-bd71828-charger-v5-0-851164839c28@kemn= ade.info/ NOTE: Fuel-gauging is not supported. You can find an unmaintained downstream reference-driver with a fuel-gauge example from: https://github.com/RohmSemiconductor/Linux-Kernel-PMIC-Drivers/releases/tag= /bd72720-reference-driver-v1 --- drivers/power/supply/bd71828-power.c | 172 +++++++++++++++++++++++++-- 1 file changed, 160 insertions(+), 12 deletions(-) diff --git a/drivers/power/supply/bd71828-power.c b/drivers/power/supply/bd= 71828-power.c index f667baedeb77..29fda7a52013 100644 --- a/drivers/power/supply/bd71828-power.c +++ b/drivers/power/supply/bd71828-power.c @@ -5,6 +5,7 @@ #include #include #include +#include #include #include #include @@ -57,6 +58,7 @@ struct pwr_regs { u8 vbat_alm_limit_u; u8 conf; u8 vdcin; + u8 vdcin_himask; }; =20 static const struct pwr_regs pwr_regs_bd71828 =3D { @@ -73,6 +75,7 @@ static const struct pwr_regs pwr_regs_bd71828 =3D { .vbat_alm_limit_u =3D BD71828_REG_ALM_VBAT_LIMIT_U, .conf =3D BD71828_REG_CONF, .vdcin =3D BD71828_REG_VDCIN_U, + .vdcin_himask =3D BD7182x_MASK_VDCIN_U, }; =20 static const struct pwr_regs pwr_regs_bd71815 =3D { @@ -92,10 +95,35 @@ static const struct pwr_regs pwr_regs_bd71815 =3D { .conf =3D BD71815_REG_CONF, =20 .vdcin =3D BD71815_REG_VM_DCIN_U, + .vdcin_himask =3D BD7182x_MASK_VDCIN_U, +}; + +static struct pwr_regs pwr_regs_bd72720 =3D { + .vbat_avg =3D BD72720_REG_VM_SA_VBAT_U, + .ibat =3D BD72720_REG_CC_CURCD_U, + .ibat_avg =3D BD72720_REG_CC_SA_CURCD_U, + .btemp_vth =3D BD72720_REG_VM_BTMP_U, + /* + * Note, state 0x40 IMP_CHK. not documented + * on other variants but was still handled in + * existing code. No memory traces as to why. + */ + .chg_state =3D BD72720_REG_CHG_STATE, + .bat_temp =3D BD72720_REG_CHG_BAT_TEMP_STAT, + .dcin_stat =3D BD72720_REG_INT_VBUS_SRC, + .dcin_collapse_limit =3D -1, /* Automatic. Setting not supported */ + .chg_set1 =3D BD72720_REG_CHG_SET_1, + .chg_en =3D BD72720_REG_CHG_EN, + /* 15mV note in data-sheet */ + .vbat_alm_limit_u =3D BD72720_REG_ALM_VBAT_TH_U, + .conf =3D BD72720_REG_CONF, /* o XSTB, only PON. Seprate slave addr */ + .vdcin =3D BD72720_REG_VM_VBUS_U, /* 10 bits not 11 as with other ICs */ + .vdcin_himask =3D BD72720_MASK_VDCIN_U, }; =20 struct bd71828_power { struct regmap *regmap; + struct regmap *bd72720_genregmap; enum rohm_chip_type chip_type; struct device *dev; struct power_supply *ac; @@ -107,6 +135,7 @@ struct bd71828_power { int rsens; int (*get_temp)(struct bd71828_power *pwr, int *temp); int (*bat_inserted)(struct bd71828_power *pwr); + int (*get_chg_online)(struct bd71828_power *pwr, int *chg_online); }; =20 static int bd7182x_write16(struct bd71828_power *pwr, int reg, u16 val) @@ -289,6 +318,25 @@ static int bd71828_charge_status(struct bd71828_power = *pwr, return ret; } =20 +static int bd72720_get_chg_online(struct bd71828_power *pwr, int *chg_onli= ne) +{ + int r, ret; + + /* + * Just a sanity check. Calling this without the bd72720_genregmap + * populated is a driver error. + */ + WARN_ON(!pwr->bd72720_genregmap); + ret =3D regmap_read(pwr->bd72720_genregmap, pwr->regs->dcin_stat, &r); + if (ret) { + dev_err(pwr->dev, "Failed to read DCIN status. %d\n", ret); + return ret; + } + *chg_online =3D ((r & BD72720_MASK_DCIN_DET) !=3D 0); + + return 0; +} + static int get_chg_online(struct bd71828_power *pwr, int *chg_online) { int r, ret; @@ -317,24 +365,41 @@ static int get_bat_online(struct bd71828_power *pwr, = int *bat_online) return 0; } =20 -static int bd71828_bat_inserted(struct bd71828_power *pwr) +static int __conf_bat_inserted(struct device *dev, struct regmap *regmap, = int conf_reg) { int ret, val; =20 - ret =3D regmap_read(pwr->regmap, pwr->regs->conf, &val); + ret =3D regmap_read(regmap, conf_reg, &val); if (ret) { - dev_err(pwr->dev, "Failed to read CONF register\n"); + dev_err(dev, "Failed to read CONF register\n"); return 0; } ret =3D val & BD7182x_MASK_CONF_PON; =20 if (ret) - regmap_update_bits(pwr->regmap, pwr->regs->conf, - BD7182x_MASK_CONF_PON, 0); + if (regmap_update_bits(regmap, conf_reg, BD7182x_MASK_CONF_PON, 0)) + dev_err(dev, "Failed to write CONF register\n"); =20 return ret; } =20 +static int bd72720_bat_inserted(struct bd71828_power *pwr) +{ + /* + * Just a sanity check. Calling this without the bd72720_genregmap + * populated is a driver error. + */ + WARN_ON(!pwr->bd72720_genregmap); + + return __conf_bat_inserted(pwr->dev, pwr->bd72720_genregmap, + pwr->regs->conf); +} + +static int bd71828_bat_inserted(struct bd71828_power *pwr) +{ + return __conf_bat_inserted(pwr->dev, pwr->regmap, pwr->regs->conf); +} + static int bd71815_bat_inserted(struct bd71828_power *pwr) { int ret, val; @@ -358,11 +423,13 @@ static int bd71828_init_hardware(struct bd71828_power= *pwr) int ret; =20 /* TODO: Collapse limit should come from device-tree ? */ - ret =3D regmap_write(pwr->regmap, pwr->regs->dcin_collapse_limit, - BD7182x_DCIN_COLLAPSE_DEFAULT); - if (ret) { - dev_err(pwr->dev, "Failed to write DCIN collapse limit\n"); - return ret; + if (pwr->regs->dcin_collapse_limit !=3D (u8)-1) { + ret =3D regmap_write(pwr->regmap, pwr->regs->dcin_collapse_limit, + BD7182x_DCIN_COLLAPSE_DEFAULT); + if (ret) { + dev_err(pwr->dev, "Failed to write DCIN collapse limit\n"); + return ret; + } } =20 ret =3D pwr->bat_inserted(pwr); @@ -413,13 +480,13 @@ static int bd71828_charger_get_property(struct power_= supply *psy, =20 switch (psp) { case POWER_SUPPLY_PROP_ONLINE: - ret =3D get_chg_online(pwr, &online); + ret =3D pwr->get_chg_online(pwr, &online); if (!ret) val->intval =3D online; break; case POWER_SUPPLY_PROP_VOLTAGE_NOW: ret =3D bd7182x_read16_himask(pwr, pwr->regs->vdcin, - BD7182x_MASK_VDCIN_U, &tmp); + pwr->regs->vdcin_himask, &tmp); if (ret) return ret; =20 @@ -630,6 +697,9 @@ BD_ISR_AC(dcin_ovp_det, "DCIN OVER VOLTAGE", true) BD_ISR_DUMMY(dcin_mon_det, "DCIN voltage below threshold") BD_ISR_DUMMY(dcin_mon_res, "DCIN voltage above threshold") =20 +BD_ISR_DUMMY(vbus_curr_limit, "VBUS current limited") +BD_ISR_DUMMY(vsys_ov_res, "VSYS over-voltage cleared") +BD_ISR_DUMMY(vsys_ov_det, "VSYS over-voltage") BD_ISR_DUMMY(vsys_uv_res, "VSYS under-voltage cleared") BD_ISR_DUMMY(vsys_uv_det, "VSYS under-voltage") BD_ISR_DUMMY(vsys_low_res, "'VSYS low' cleared") @@ -878,6 +948,51 @@ static int bd7182x_get_irqs(struct platform_device *pd= ev, BDIRQ("bd71828-temp-125-over", bd71828_temp_vf125_det), BDIRQ("bd71828-temp-125-under", bd71828_temp_vf125_res), }; + static const struct bd7182x_irq_res bd72720_irqs[] =3D { + BDIRQ("bd72720_int_vbus_rmv", BD_ISR_NAME(dcin_removed)), + BDIRQ("bd72720_int_vbus_det", bd7182x_dcin_detected), + BDIRQ("bd72720_int_vbus_mon_res", BD_ISR_NAME(dcin_mon_res)), + BDIRQ("bd72720_int_vbus_mon_det", BD_ISR_NAME(dcin_mon_det)), + BDIRQ("bd72720_int_vsys_mon_res", BD_ISR_NAME(vsys_mon_res)), + BDIRQ("bd72720_int_vsys_mon_det", BD_ISR_NAME(vsys_mon_det)), + BDIRQ("bd72720_int_vsys_uv_res", BD_ISR_NAME(vsys_uv_res)), + BDIRQ("bd72720_int_vsys_uv_det", BD_ISR_NAME(vsys_uv_det)), + BDIRQ("bd72720_int_vsys_lo_res", BD_ISR_NAME(vsys_low_res)), + BDIRQ("bd72720_int_vsys_lo_det", BD_ISR_NAME(vsys_low_det)), + BDIRQ("bd72720_int_vsys_ov_res", BD_ISR_NAME(vsys_ov_res)), + BDIRQ("bd72720_int_vsys_ov_det", BD_ISR_NAME(vsys_ov_det)), + BDIRQ("bd72720_int_bat_ilim", BD_ISR_NAME(vbus_curr_limit)), + BDIRQ("bd72720_int_chg_done", bd718x7_chg_done), + BDIRQ("bd72720_int_extemp_tout", BD_ISR_NAME(chg_wdg_temp)), + BDIRQ("bd72720_int_chg_wdt_exp", BD_ISR_NAME(chg_wdg)), + BDIRQ("bd72720_int_bat_mnt_out", BD_ISR_NAME(rechg_res)), + BDIRQ("bd72720_int_bat_mnt_in", BD_ISR_NAME(rechg_det)), + BDIRQ("bd72720_int_chg_trns", BD_ISR_NAME(chg_state_changed)), + + BDIRQ("bd72720_int_vbat_mon_res", BD_ISR_NAME(bat_mon_res)), + BDIRQ("bd72720_int_vbat_mon_det", BD_ISR_NAME(bat_mon)), + BDIRQ("bd72720_int_vbat_sht_res", BD_ISR_NAME(bat_short_res)), + BDIRQ("bd72720_int_vbat_sht_det", BD_ISR_NAME(bat_short)), + BDIRQ("bd72720_int_vbat_lo_res", BD_ISR_NAME(bat_low_res)), + BDIRQ("bd72720_int_vbat_lo_det", BD_ISR_NAME(bat_low)), + BDIRQ("bd72720_int_vbat_ov_res", BD_ISR_NAME(bat_ov_res)), + BDIRQ("bd72720_int_vbat_ov_det", BD_ISR_NAME(bat_ov)), + BDIRQ("bd72720_int_bat_rmv", BD_ISR_NAME(bat_removed)), + BDIRQ("bd72720_int_bat_det", BD_ISR_NAME(bat_det)), + BDIRQ("bd72720_int_dbat_det", BD_ISR_NAME(bat_dead)), + BDIRQ("bd72720_int_bat_temp_trns", BD_ISR_NAME(temp_transit)), + BDIRQ("bd72720_int_lobtmp_res", BD_ISR_NAME(temp_bat_low_res)), + BDIRQ("bd72720_int_lobtmp_det", BD_ISR_NAME(temp_bat_low)), + BDIRQ("bd72720_int_ovbtmp_res", BD_ISR_NAME(temp_bat_hi_res)), + BDIRQ("bd72720_int_ovbtmp_det", BD_ISR_NAME(temp_bat_hi)), + BDIRQ("bd72720_int_ocur1_res", BD_ISR_NAME(bat_oc1_res)), + BDIRQ("bd72720_int_ocur1_det", BD_ISR_NAME(bat_oc1)), + BDIRQ("bd72720_int_ocur2_res", BD_ISR_NAME(bat_oc2_res)), + BDIRQ("bd72720_int_ocur2_det", BD_ISR_NAME(bat_oc2)), + BDIRQ("bd72720_int_ocur3_res", BD_ISR_NAME(bat_oc3_res)), + BDIRQ("bd72720_int_ocur3_det", BD_ISR_NAME(bat_oc3)), + BDIRQ("bd72720_int_cc_mon2_det", BD_ISR_NAME(bat_cc_mon)), + }; int num_irqs; const struct bd7182x_irq_res *irqs; =20 @@ -890,6 +1005,10 @@ static int bd7182x_get_irqs(struct platform_device *p= dev, irqs =3D &bd71815_irqs[0]; num_irqs =3D ARRAY_SIZE(bd71815_irqs); break; + case ROHM_CHIP_TYPE_BD72720: + irqs =3D &bd72720_irqs[0]; + num_irqs =3D ARRAY_SIZE(bd72720_irqs); + break; default: return -EINVAL; } @@ -979,11 +1098,39 @@ static int bd71828_power_probe(struct platform_devic= e *pdev) pwr->bat_inserted =3D bd71828_bat_inserted; pwr->get_temp =3D bd71828_get_temp; pwr->regs =3D &pwr_regs_bd71828; + pwr->get_chg_online =3D get_chg_online; break; case ROHM_CHIP_TYPE_BD71815: pwr->bat_inserted =3D bd71815_bat_inserted; pwr->get_temp =3D bd71815_get_temp; pwr->regs =3D &pwr_regs_bd71815; + pwr->get_chg_online =3D get_chg_online; + break; + case ROHM_CHIP_TYPE_BD72720: + + /* + * The BD72720 has (most of) the charger related registers + * behind a secondary I2C slave address instead of paging. Most + * of the other BD72720 sub-devices need only access to + * registers behind the other slave addres. Thus the BD72720 + * core driver registers the first regmap for the real MFD I2C + * device - and this is what we get here when using the + * dev_get_regmap(parent...). For the charger we however + * (mostly) need the other regmap. The MFD hands it to us via + * platform-data and here we aquire it and use it as main + * regmap for the BD72720 power-supply. + */ + pwr->bd72720_genregmap =3D pwr->regmap; + pwr->regmap =3D *(struct regmap **)dev_get_platdata(&pdev->dev); + if (!pwr->regmap) + return dev_err_probe(&pdev->dev, -EINVAL, + "No charger regmap\n"); + + pwr->bat_inserted =3D bd72720_bat_inserted; + pwr->regs =3D &pwr_regs_bd72720; + pwr->get_chg_online =3D bd72720_get_chg_online; + pwr->get_temp =3D bd71828_get_temp; + dev_dbg(pwr->dev, "Found ROHM BD72720\n"); break; default: dev_err(pwr->dev, "Unknown PMIC\n"); @@ -1030,6 +1177,7 @@ static int bd71828_power_probe(struct platform_device= *pdev) static const struct platform_device_id bd71828_charger_id[] =3D { { "bd71815-power", ROHM_CHIP_TYPE_BD71815 }, { "bd71828-power", ROHM_CHIP_TYPE_BD71828 }, + { "bd72720-power", ROHM_CHIP_TYPE_BD72720 }, { }, }; MODULE_DEVICE_TABLE(platform, bd71828_charger_id); --=20 2.51.0 --FNeSZYeqkJDtuOLg Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEIx+f8wZb28fLKEhTeFA3/03aocUFAmjk0LkACgkQeFA3/03a ocUhigf/RxuNQ/pDDX/6n8N5+dBB2BR4/LFddU5z2klDK7wailWxNbHyIZW/MFc1 yGUevB3s3Q6nHx2IUxaIQjRMD/XvQcIvQ3SzpI0XKarECX/XBwGBni6T8Z4LMF0P 7gse55E1vYDvd0mHk2Nh6llT1Alr1imMlu4HNmmlgjExLeWrsht2Gpe4x8WHwBih kgS44WR2eld1Gtf//Aw4B99ea7kpqxmN2UJvrz6khiYnUKAX7ztvFQZQUa0NK3XH l/GlZO6B0uCGjJQggpfR2an8tQibaGMig+HvHBeFsEz3aQbPLYj7oGMVzArJ5XLD vqTjYnFTu0Bq23vBLn5YpnzDp5+Lgg== =5Fzq -----END PGP SIGNATURE----- --FNeSZYeqkJDtuOLg-- From nobody Wed Feb 11 03:42:00 2026 Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 54B702DBF7C for ; Tue, 7 Oct 2025 08:35:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759826126; cv=none; b=JMJ6D9CJwWIV62GirDs87yXFmhXAfVyHvflRLe6g9jh2lV01/KqMaF0zeiZjKqna+DqkmMywN4vRLMyJ96XHyeAtDQVMk0JNPZkG6nWv41bLcKgMNuJyF/7ts47SKyUaAdHrYlDFxb72244ngtSQHRiyRSCuJGo8JsNHJzJo/TQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759826126; c=relaxed/simple; bh=ZHDZ/62yyQM2WpcdFkqxEjcI8DLW3Glqgwz1/vt5I0o=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=EqY29mANYmOfdJWCHZGQzT4VxvCF8LINbcUwh6LIz8VmqejqKTH5I9HD8D3Iy0yo+lkqSi4+VdFozySgs+oj66nsFcwsslH1+n6fG5aSqWsC1Alb/ylYtC2M2RKaMPtB+5Gcw0OsDYpY1HyOf8sHlJMoYzBwdTr0OJgfufiTrCI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VTCUXA1+; arc=none smtp.client-ip=209.85.167.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VTCUXA1+" Received: by mail-lf1-f50.google.com with SMTP id 2adb3069b0e04-57b8fc6097fso7885901e87.1 for ; Tue, 07 Oct 2025 01:35:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1759826122; x=1760430922; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=lA2K8SX41xRVhtx0TGelIGFHrpKngX8UyetIiKY/xmk=; b=VTCUXA1+FaEj7a+2/oVxdnJNo3BnF/OqvSgUf1HOaNGCamMJjXyoGVmmIX0DegCvvn EaIib6u4cM+JuIk4JXcwxC/7+fL0Y18rEHChyr0tFnZ3FhvkDxSCUjX0crvSNwpsTvGm sNlUswMSOHz7LRZmE7+BUMnlB5TuDl468/P/8DPaRclpP7zY1B5or4B/CyMB8iw2W3VY vfyCB9crDrkUDflJccFbw/HWcM1WyQG+XVVXRlivYuVhJw8DyRJQT4fWDw137MTA+ghK on3iUUeq3DGc5ZcmsG8bd5s7snk2+xkHIQUQu2QRPJs4Aog2RCualAfCDR9Q7tAMS0iD T4qA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759826122; x=1760430922; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=lA2K8SX41xRVhtx0TGelIGFHrpKngX8UyetIiKY/xmk=; b=LlsxjCX3tgCUPuMe3bMCNhDVkWLHM+RhiVwjeQw7UopNI1XrGQb/9XMZu07yKyQtWx CprVaqhCpjdsZJ0BCu4mQInDY4ymeEGmrQyCJd7LYJhtKYUT5Mu6WFb+mko+ZTsx9n7r Jkst2n68O+bFZUdxa4Sydi+RkLzmkoj9IW65jyVnZ4UMx5BxzweKgG9udeg8FKQZtjOi Ma8Std+94PA7hcKZQT0B9JiceDZO4cJ6Ft7SA7zR7E3ycKqvxTHPlBpEnZLCCID3zfut 23OqPNmE5xWhhBpWZwys6XmQMEBlxxPzLHQ4RhFBWdF2+ZyuCLbGbR/AWLCFDXtPkyy3 38wA== X-Forwarded-Encrypted: i=1; AJvYcCUbkHntpFEcdahV5p1nU1H2zhm5O48yIsSlKbkMJ3TGcwq9BzbFoN6gma9Bz5B4nUTyfNq6foEix4BZLVY=@vger.kernel.org X-Gm-Message-State: AOJu0YymmJU74uHb1k34aJyxMOQwIxMWtdgppTZUaTFlbuvmRQX5RLnf /gfd50ZeqXkkCBPe/uy2izo31wfhCBw4+5NslIixWhPL29sVmBEDsrtt X-Gm-Gg: ASbGncskPkB0nrBpkYfUjb+tDiCQVs+i/Bqaf9UC3BTt9p1cvN2YIdNyyQ8VVxYXQOb de68XLg9MLgZdf3Q22pZYQYjLj4YMNLE9Fs800YBV1yfCS/IpA9W/mGxW/oPyhFidUk2Rxcp2oP 6SDho17VpB48kCCL7Nl4eT5Iv3apmyjyHA5cxKknLae/oMrhjXDi5TcdZXc5zwM3VJBr3joWncg tXjsPpumg2NraLtK69W3NOzBNaUoodVOOggmx9DppAsyDhD6wVgbKkbzjwN096tx0+HwkQ9oV5a s1FBH3go5aRy6x9wCsOjScNc/VsAKTbCIKk6a9rFq//w7yQkrWhdFU8FDETd+5DSI5X/ybKK3OW 0jBmtprZSLyOGBu3AtWNoZ/DYh6gEWqWlP5NGLuDf+etfB2IDgELtLkqiy9RRaZkY X-Google-Smtp-Source: AGHT+IHWvQFZoM0ayT5AgPXGKHGCCpp31nPy7gmVdN+F8yj0NL32bKU7cfG819gEXcZcLzrJj4brIQ== X-Received: by 2002:a05:6512:104b:b0:578:ed03:7b87 with SMTP id 2adb3069b0e04-58cbb4416a6mr4798688e87.33.1759826122219; Tue, 07 Oct 2025 01:35:22 -0700 (PDT) Received: from mva-rohm ([2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-58b0112462esm5893790e87.3.2025.10.07.01.35.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Oct 2025 01:35:20 -0700 (PDT) Date: Tue, 7 Oct 2025 11:35:17 +0300 From: Matti Vaittinen To: Matti Vaittinen , Matti Vaittinen Cc: Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Sebastian Reichel , Liam Girdwood , Mark Brown , Linus Walleij , Bartosz Golaszewski , Matti Vaittinen , Andreas Kemnade , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-gpio@vger.kernel.org Subject: [RFC PATCH 13/13] MAINTAINERS: Add ROHM BD72720 PMIC Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="SlztX/me0LjlXKoG" Content-Disposition: inline In-Reply-To: --SlztX/me0LjlXKoG Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Add the ROHM BD72720 PMIC driver files to be maintained by undersigned. Signed-off-by: Matti Vaittinen --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 21ec42d93ee4..3afd9cb978cf 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -21940,6 +21940,7 @@ S: Supported F: drivers/clk/clk-bd718x7.c F: drivers/gpio/gpio-bd71815.c F: drivers/gpio/gpio-bd71828.c +F: drivers/gpio/gpio-bd72720.c F: drivers/mfd/rohm-bd71828.c F: drivers/mfd/rohm-bd718x7.c F: drivers/mfd/rohm-bd9576.c @@ -21956,6 +21957,7 @@ F: drivers/watchdog/bd96801_wdt.c F: include/linux/mfd/rohm-bd71815.h F: include/linux/mfd/rohm-bd71828.h F: include/linux/mfd/rohm-bd718x7.h +F: include/linux/mfd/rohm-bd72720.h F: include/linux/mfd/rohm-bd957x.h F: include/linux/mfd/rohm-bd96801.h F: include/linux/mfd/rohm-bd96802.h --=20 2.51.0 --SlztX/me0LjlXKoG Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEIx+f8wZb28fLKEhTeFA3/03aocUFAmjk0MUACgkQeFA3/03a ocURTAgAu6dnmWP/JjZcJMWGUn+hYLg15qVmjQNYJoLBcZtaNezTwNj9uXTJeGp4 aF3xpHcZtryUyaerjRHwCYmHkyab19+2EgxtORp2dmdqVhsb/bvOcyuNLz2sFfOS eDFFRQadRdLwYbi0wx2lhHqfh9/HXUqYQjBwWSaIidlhU5sjVXlsOQYFlkOv/aZe E3h6QunJQxBavA27oVpucRouBOxpGzFLt80PyB3LwH1j2+PRN2ugZiW90TDmFZNl e8/nPHDTqoF5T3VyxAXleGRLyrfnF8d+VsTF3R6rj7aQCv2jOw2aHoI96AJAjZgO DUZUp9dgZicc5YzSzYQmOfchxX1dJg== =phW3 -----END PGP SIGNATURE----- --SlztX/me0LjlXKoG--