From nobody Wed Dec 17 17:39:09 2025 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 811A1258EE1 for ; Fri, 3 Oct 2025 09:29:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759483757; cv=none; b=J2hSN61MkMnz3X9EbB1fYjyuRElRrQTacYap/5j2Zt1O36nAOMsRG1IZME3HHk2jQuYXc9GGI7CoMqpdcAfvVLH7FKnh2cfwKmT9Sf4sU9StmA8aLW0aIeaZJJ/jVIVGCXm1CL6WwKq3Blo6hXQ+2BW1tizHZdhMrI0lAEADDoo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759483757; c=relaxed/simple; bh=b23ht0r0Mc5jU+nKU4Dq9B+xOZLGyqKkOKJbvuKCbFI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=nOPJeIWozpIN/vFzwGSldIj+9kjVGQ3+ddZzKJ7ac+k7RruDuwQlmj80eQRib04o5wB1pCCFdvkL1xDo6VTRkJID19Fh/PYbgUHhOctN9Fu51WI3a7P1ufZQ8zqk0W93GD8su4T6ad8F46SJBEfMoJxmE0uUvLQjAQ3oYp4U6Ik= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=F2b0CRHf; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="F2b0CRHf" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-421b93ee372so933668f8f.2 for ; Fri, 03 Oct 2025 02:29:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1759483754; x=1760088554; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=DVOLfuRBFnDlZv7Y9XU0gN3e9V0PE6p293X+s4H1iGA=; b=F2b0CRHfwFbAH+RWIuZ8x0hfRmxEkMGIx5xZvP8EZvV9u0M2EiTdeaeSROoOZn9hEi Wc8ka4d8wBx0qJ3zh2JgKJToSQCUu1mJjGvhWJUqrVcUBKSmRtt+uwRaBvlgvRI+L4yO we6Bu0bNarBGXtWz/i8s/5unOzEM87zG+mKTKsxqHQCti/JQFNo3HSVpm0FKy8inSLNC 1PhGx9D2/bsqQR+D1bA4kWBlg+RkY28hpd+UIf7RMVdTyJn63eHuZMA77014Mp4+139t 5z3/cgtWa6esl3Dy7+3pp7H9d+iA9VlKm0AuI74RE8SLEoFL2cY68WnnwEMqYnOUZc8e RJWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759483754; x=1760088554; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=DVOLfuRBFnDlZv7Y9XU0gN3e9V0PE6p293X+s4H1iGA=; b=d/7q7wH7E0oK5UjFoXUV/xjiU3ROI4VGMrOxSLVO5gXHcrK1s2MfASoU0dU6ZvW9ye U+VYPwUouLRWHsMlLJkvj7J+0Zragih7f5teQ/8l9WuYYz3odne2y23DNISruTQvZUZn GMRGGDbJwDeP8NQdZOeJGEwm5ZT+uwduEjgKYaP5bvjlscvsrSysz5lNUPL6pAR+ToT5 tJ4Oc2zS1wmj526ZI09VKRgEf1DaifLEw+syiJRaEQnadZSRsvskiU5B9EVQv61dy+mJ alQDjGFCLNQt/WTfuSTaJX0pJCy4Ym+oEG7KENdvEr8S+OK5U6bVV3vpHVHc435KXVXz 0SMw== X-Forwarded-Encrypted: i=1; AJvYcCUe32DEbsTUA1ShNINcr3NYnxP8Giv3dMAKNA67oDG9PAfcwOkCxIDXDygpO6xn/0+JZX8p590qjweIWho=@vger.kernel.org X-Gm-Message-State: AOJu0YxBDGoIVKkQvvQzncpFPU6C0jxkQxdGni6T3rCayfa5vHsM6iSn rl8Q5huaT2HaPX1P+zDd7abWA8UBhtIVX/0IiJ10eBeG3Z0Mt28c2o9lXYWY1FO54Vg= X-Gm-Gg: ASbGncuRafrm3HPgYm+ILUPEbtxwROVE0OH+giQWtGqir4pZmcKUccs8CaCTVWN8Y0N aKRDIbCkS8PbJg2/jVqVtJTMPzNC0Krk6MkDjyW+USCfUwIuKz3GpbZP5cAhzLULDJXjLF+KG+L DNezJd6YWPT3uqg09O2MwamwCufJFNYlEpr7vhc84gmnbT6jbDKUxvf+rLVBp2om8nwWtV7G1z3 gO1rZ9HUTwSl7cxxLj9z+h/pYTx5dsQONiEJLFKqBgGSARA1TBHhDRDBfWj9iTFPc2ax+aHIY1K +6w2IB7TJbX8xoajXQ41xvj/HIoRJSaecM6nZH54X5lttPYDdwgWJJkq3sB4ukoMsptIIKJ73CO SAd1/VMdX1riCXNwWdtwoTfs2KLnVWXEvHdc2++IKzdn8XwOfE+LMEky9 X-Google-Smtp-Source: AGHT+IGIaObKnhJNC5cX0hzI3j+FcypBs/6mUfToPI7c44aQz/5uQ/CFsJuD9hhr+7yB53BArtceZg== X-Received: by 2002:a5d:5f47:0:b0:415:7a6c:6a38 with SMTP id ffacd0b85a97d-425671c3bcdmr1424793f8f.59.1759483753631; Fri, 03 Oct 2025 02:29:13 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-4255d8a6c3esm7161779f8f.1.2025.10.03.02.29.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Oct 2025 02:29:13 -0700 (PDT) Date: Fri, 3 Oct 2025 12:29:09 +0300 From: Dan Carpenter To: Binbin Zhou Cc: Chong Qiao , Lee Jones , Huacai Chen , Corey Minyard , linux-kernel@vger.kernel.org Subject: [PATCH 1/2] mfd: ls2kbmc: Fix an IS_ERR() vs NULL check in probe() Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The devm_kzalloc() function returns NULL on error so check for that instead of error pointers. Fixes: d952bba3fbb5 ("mfd: ls2kbmc: Add Loongson-2K BMC reset function supp= ort") Signed-off-by: Dan Carpenter Reviewed-by: Huacai Chen --- drivers/mfd/ls2k-bmc-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/ls2k-bmc-core.c b/drivers/mfd/ls2k-bmc-core.c index e162b3c7c9f8..5f38514fa89e 100644 --- a/drivers/mfd/ls2k-bmc-core.c +++ b/drivers/mfd/ls2k-bmc-core.c @@ -469,7 +469,7 @@ static int ls2k_bmc_probe(struct pci_dev *dev, const st= ruct pci_device_id *id) return ret; =20 ddata =3D devm_kzalloc(&dev->dev, sizeof(*ddata), GFP_KERNEL); - if (IS_ERR(ddata)) { + if (!ddata) { ret =3D -ENOMEM; goto disable_pci; } --=20 2.51.0 From nobody Wed Dec 17 17:39:09 2025 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D5AA2BE036 for ; Fri, 3 Oct 2025 09:29:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759483765; cv=none; b=cMy8fTms10WTM09u5djSuWrkqVUQtgTaF5OqcvtyiMfdLrVGyxZm5HrdtH+YPS5X5OrwDZMtVHKVSgOrDbyA1lE03z/exOzpZA4KF3S8Icc4I1aREzbL7gl8jzP2KMvB/xZb8lEYAmZRS4jnhCc8vwYR9fAHNx7/1R5SPT3UaHE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759483765; c=relaxed/simple; bh=9KK60N4wFa13mM7zEJCtUUbwe4Cyio02GXt+F+owdus=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=TFVF2R1cwM5jfu97V6FExqVM2Fmhsx7AJbIIwqwsKfPOfkkqQ4nu7WajYwRwwbMj5mnSkeHjHwsptS5isFScWF3cRkCtkITLC6VSyrJDYmdfHO9hYGMo1If3bSUm3aom+5nWDAGlZlZOlJyn4EjW/ebToEdG4lTqlMBBd53d2VE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=TcR0fpcm; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="TcR0fpcm" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-3ee12807d97so1615604f8f.0 for ; Fri, 03 Oct 2025 02:29:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1759483762; x=1760088562; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Bc+y3Q7Z66QblI6C9bQ4T4zR+bOLr7m+usNLDo1KAu8=; b=TcR0fpcmIDQkIquHSfnfb5f5auXoMBc06T16yYUAGXS/c3vnBEwZlkEVcmtpGyR6Gh cN6dPyBhtNHW50YaCoEqW7QuSLGHpdYGKOx3hMops4KWgrhRsM6Rqj+P/EjobK3eRapg JivPXvfiLA/v9bBD4gZnuoA2NradyVWNl69hr7NOmREdwtewIXnzNeAijAKtGcnQcvD3 eLsGH3k4ZSdHLvw3HnrimZGxpsGzNi3bCSp82tntSq0x06WumsVSsO11/JZRz/2BslJD nRhwgiGcA3AA1VbECz9a1YX0oZowaOI0H+2tsZnwFvEghM4IZQpe9PNuIOnq/U28L/Fv LF8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759483762; x=1760088562; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Bc+y3Q7Z66QblI6C9bQ4T4zR+bOLr7m+usNLDo1KAu8=; b=aKbm5i4RLgveRHeWAp8O+i0tE9VIKSvO0R6NfYOlitOTQOGBXEpgtkt2ZMdPpxVabN OSh1akZf9qZaebKPZIUHpcquV8eA5UaGZu4sCjuwPs36FOjkHHNrOJf+FcXuFpRBrIls VPA1WUExJCCZaZ+AvX0jMym4oKrWYKKN/le0Q7TaJNc2cIFGcIDXXnL0rWcm+UQtvUzd WSQ1L7z2TJiwuDPc7qeWA3du3cyM88cZg0Ma2f/MmAnP74Z8FjSnoKTIBobUus9bvHjn INWn5Y4HZCxmrH3e3CmDyYYgWslZQ8OVjud6m/hJirMG3HqdWbNLRSTfSxQJbn7LpiSG YjDw== X-Forwarded-Encrypted: i=1; AJvYcCW7KfhGYNMhh2lGMJTn8XTVE01PTp7MKZiBNZZS8YgmDMwD+E+ofJAnhm8uLQ3dijM7OVmxiJDYd0mCyl0=@vger.kernel.org X-Gm-Message-State: AOJu0YzvKNqyMoN+6Jn3vt8EGhUCJxkYJ2XgF5rB8AnJHLozuwhp0jta TRbZwI8MbjIG63NTRXVu3xZt85EPfHZe0JtO8ebwOZjFFfBz6cxMlWExvuxzvpl/hmrarv2oKwV uuxmp X-Gm-Gg: ASbGncvT0V/mgahrj8QFXZIum16EmAdJN35U/jXOS0wJwsUOO7BHjdZRhM02bXozq67 rp/8L2Wqn9nSsB+lmW+CoWqnx4E6T+I59Mf9thmVdqaH9PKQbAiWqSO9Q3rMbA82LkjbqhLZ++c RaQozdUsA8p86wtPul5UueFScFHtZFDFYFjjjKVsgQIy46I1xFYtCwsv9kIkmKArfyW2bRTsTPH hpLhCqZAV4fmd9COPdQsujVDcmzn9OFIl2kHbo7Hy/Vn+2tO2qQ5eAjUxjsLs9IF1uzdbmW7AXu ITz7ibQERXKQR+bVq7FNLGxfoxsxy2V5PMMBwq/Cd4KthoGoZrCGHADgZlrfHAflaKQRYpkQYCK +/uNTtU7020kPYNMTtyXktYa8yMdxmtY+FHzDpnXkJaOsmQjEywY7QiRKp25V88TIPVASqJPb7D S3KA== X-Google-Smtp-Source: AGHT+IEGJbdVR3GcAdsB8Chc0WaIcfmujZxeb7PDK8Xm5WerDZyBZuCeiXmBbvev21tSrd9qjR+iQw== X-Received: by 2002:a05:6000:24c6:b0:3ec:dd19:5ab with SMTP id ffacd0b85a97d-425671c2e7cmr1395497f8f.61.1759483762253; Fri, 03 Oct 2025 02:29:22 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-4255d8efffasm7072394f8f.41.2025.10.03.02.29.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Oct 2025 02:29:21 -0700 (PDT) Date: Fri, 3 Oct 2025 12:29:18 +0300 From: Dan Carpenter To: Binbin Zhou Cc: Chong Qiao , Lee Jones , Corey Minyard , Huacai Chen , linux-kernel@vger.kernel.org Subject: [PATCH 2/2] mfd: ls2kbmc: check for devm_mfd_add_devices() failure Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Call pci_disable_device() if devm_mfd_add_devices() fails. Fixes: 0d64f6d1ffe9 ("mfd: ls2kbmc: Introduce Loongson-2K BMC core driver") Signed-off-by: Dan Carpenter Reviewed-by: Huacai Chen --- drivers/mfd/ls2k-bmc-core.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/mfd/ls2k-bmc-core.c b/drivers/mfd/ls2k-bmc-core.c index 5f38514fa89e..69387dad6661 100644 --- a/drivers/mfd/ls2k-bmc-core.c +++ b/drivers/mfd/ls2k-bmc-core.c @@ -495,9 +495,13 @@ static int ls2k_bmc_probe(struct pci_dev *dev, const s= truct pci_device_id *id) goto disable_pci; } =20 - return devm_mfd_add_devices(&dev->dev, PLATFORM_DEVID_AUTO, - ls2k_bmc_cells, ARRAY_SIZE(ls2k_bmc_cells), - &dev->resource[0], 0, NULL); + ret =3D devm_mfd_add_devices(&dev->dev, PLATFORM_DEVID_AUTO, + ls2k_bmc_cells, ARRAY_SIZE(ls2k_bmc_cells), + &dev->resource[0], 0, NULL); + if (ret) + goto disable_pci; + + return 0; =20 disable_pci: pci_disable_device(dev); --=20 2.51.0