From nobody Fri Oct 3 10:10:32 2025 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ABC3132ED40 for ; Tue, 2 Sep 2025 15:57:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756828677; cv=none; b=LVn5O+nDp4ix+kLpIi+NOYusTZZiJRvJ3jRDbKN7rOB86TNlBO+s6XNv3hYuOfnvjSxu3PhFuW+fUhoz/abn2Y5CkA+tV+AQiAChTKFjGyz2OAAnmN6+OEe16zJYzPeLcHzi8ewvNAyOY1DCPfgv0AOJIPyH4mTjexl0AOVX9HU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756828677; c=relaxed/simple; bh=n0fd6xEx/+Cfe0XsYnDfSmRrGzf66Rk9db0hUym7nQU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YP9zO9r5gnykOC9WT+AvkrhRlXNjKN0oe69qC+IiW8e9SgbLaODJdfVo45cV3QzqAb+2tWRsg6OYvukKMNtKxZxGAnIycVqKL9mgqGAIAcjoLKp3tSijFYG12aEQeSDoLCMAhF++/efyWtvDlzIzqa8sVxFdTtUeu1xQh8gC7ss= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hJANq9j6; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hJANq9j6" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-3dad6252eacso364123f8f.1 for ; Tue, 02 Sep 2025 08:57:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1756828674; x=1757433474; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=WazHtu/C+Ki5N7AOy13THFKawYgRh4R/pKoB6roqKlg=; b=hJANq9j62HrBa0/wTT/y0N3wWc+trvI0lhVAte19PfNWnDqUA1j0rLZF2vBCxT9HdN 1Hge3q+IyOxPr6qqwlI5UrjHvWNm8meL12fXI+69t3RfO5rVHWMOSbX/g8v7AbEhPihQ utSrQY8a/ssTcH8pJgfEX8AyruAswjxcOSQcPRLWVVdtD4K3NMLt04qx3W4lOlcTBBLa 3Jrq9Sh6H8YreQs5Rchkghq3f56T9ZUF0U19iYWOIBcdg95nMVgRI3RiC9qMlDFSwWPx Z3q0QOEtnVxbgbwo543qOGuj1akyCkaNPsXmF/uagEbzvZk/MBUDT6v35O7nAMVGsezF NUFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756828674; x=1757433474; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WazHtu/C+Ki5N7AOy13THFKawYgRh4R/pKoB6roqKlg=; b=Tsk7xVb0L70Mngyqv1BAQCCSL44NNE1cp76LA7AGXxDTZ8WDqnDnl/HxkrZD5rt6j7 ltF1PyBSeaZMDukEqyZP3eeug6rX3DuLzD961nyELUTfnGa9z8SI2X/9LomlyGymjrY1 sgdRJ0nqKdAU4r3O7pCbC76cqI6gcSPHrbC7oS5Pt7oK6OffuYJYdFCQ/vK4ODu7JLPF FR9ZlVFmgfKquj+pU5hg9rwI9ZsrNOG85uqplilfOKdsF9X/X2ri3uUcyutauNUnh2iK yUrFOmihGyY3NKekmLzOUlYg+jQf87uYOGmSthxkB7cUm3avb1nOys1EmktIzHpZ1jZg ItSA== X-Forwarded-Encrypted: i=1; AJvYcCX5esiL/0SaZhCpRyFcrSl6keVJ9tR3hxcWpaJvI9BDVeJyNBKjBujyTe/eK4NuJxapke7h5+8jiqEwUhQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yx/SiCD8F6lsrz9Vg6RT53CI3jaSV8m122wW7zo/sFV8Vu1tvYb 51IQnlHHQfQjmeZ+jvRSxadR/LePdF7jvBe1CiQ7wCdqRMQEwpxyH/Zy X-Gm-Gg: ASbGncti40iPbNxZJffDEZucME/C5+rNH61Ihv3m5BQhanQEqrRqNGwpe03gK1pFqrH NdN4wry5XybRqowWtsXU1Nc2ZQfU2szpmsuj/iaM9xubgYjPFnIqfGG0oUVJ3fkhQ0EDIbcgMVL EmCOY2+kRZ9y8tb8liH5AWZNWnvsLsusYKZMaZkVdKHq25piq7vfqqKlDSildxwxObKibYrgFH9 liRnEJWOK6yt984mRDy/f9kUJg6996mjT9Wz6Qy24jIYChr0sebBDLWArBX1Aalx/RVOtfEQhuJ tK7djavp6Ksd+MjwmraQ4n28Wz1nDM1i+sK5fZ2ZxtR7/DUtCqmpCHhBTCL1U3dEOxZ0/XAlO6f 5K/BXwhcHdulcXA== X-Google-Smtp-Source: AGHT+IHcOAzz8VVG5t22jgn5zsII5Ivg87fvqkT+HcIozssVkQ/DPJiq41qWcCUdZRNBTyTiCd9XHg== X-Received: by 2002:a05:6000:2811:b0:3d2:25ba:e7f9 with SMTP id ffacd0b85a97d-3d225bae9femr6067898f8f.46.1756828673800; Tue, 02 Sep 2025 08:57:53 -0700 (PDT) Received: from localhost ([2a03:2880:31ff:8::]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3cf3458a67esm20193336f8f.62.2025.09.02.08.57.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Sep 2025 08:57:53 -0700 (PDT) From: Yueyang Pan To: Suren Baghdasaryan , Andrew Morton , Vlastimil Babka , Michal Hocko , Brendan Jackman , Johannes Weiner , Zi Yan , Vishal Moola , Shakeel Butt , Usama Arif Cc: linux-mm@kvack.org, kernel-team@meta.com, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/2] mm/show_mem: Dump the status of the mem alloc profiling before printing Date: Tue, 2 Sep 2025 08:57:50 -0700 Message-ID: <8dc71d31de53afa4c0bb25234807b1e6ead5ba55.1756827906.git.pyyjason@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This patch prints the status of the memory allocation profiling before __show_mem actually prints the detailed allocation info. This way will let us know the `0B` we saw in allocation info is because the profiling is disabled or the allocation is actually 0B. Signed-off-by: Yueyang Pan --- mm/show_mem.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/mm/show_mem.c b/mm/show_mem.c index ecf20a93ea54..51892ce2efc4 100644 --- a/mm/show_mem.c +++ b/mm/show_mem.c @@ -427,6 +427,8 @@ void __show_mem(unsigned int filter, nodemask_t *nodema= sk, int max_zone_idx) =20 nr =3D alloc_tag_top_users(tags, ARRAY_SIZE(tags), false); if (nr) { + pr_notice("Memory alloction profiling is turned %s\n", + mem_alloc_profiling_enabled() ? "on" : "off"); pr_notice("Memory allocations:\n"); for (i =3D 0; i < nr; i++) { struct codetag *ct =3D tags[i].ct; --=20 2.47.3 From nobody Fri Oct 3 10:10:32 2025 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1DA6A32ED54 for ; Tue, 2 Sep 2025 15:57:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756828678; cv=none; b=Zxgyu3qmb6Y9sdjuCqm7jc+Xu1rosUbeWyLRd9bgEL2EPx0pjjoXnx7Wy1BKcpx3jaYDgJ+5bCjczWH2NBwRxJedy7/1Gi9sGBJTuqMkoeMAAxo8N9Jw3cgy/pqEEIWeRrV5F52CxVy4CMS4qMgFhBdrqJrjSfwbD6Tel5vVKLM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756828678; c=relaxed/simple; bh=mPMWDz+8h3MDqxJqY4ZbFAjRY2qvbs6Q/t61BwH0aSs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qLUhiStYZjWcjaK7AebTAgBXD5K93jpXSjyZ/ljWyKFSpTvupj6Y5dg+77j2IwAE1uXExziJwEyEhmcQOWj9VtkRTAv3nTAOhRctogLrJbYAq61i0hqFZN3VGdXOshMGpVmRPfPBc5CLbIuwV5jmkMdVEbtNhBtrj49R5n3/j4o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nnjJfQZ7; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nnjJfQZ7" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-45a1b065d59so38468475e9.1 for ; Tue, 02 Sep 2025 08:57:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1756828675; x=1757433475; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Y6y56X8OUTmSoo3VKz8VzAATzZ9BTMxyuZT6xksXOKo=; b=nnjJfQZ7LFv8ENIBnbdD5M/HUw3rNFm82wrf3kFPfpRaIRZEdy19QOnOLGrt+Hoo16 KF4ooNT3DmCRy6CFREQFANLafJiuNJ/5wp78olqBy7pBsG4t2mwJdyKLhrUDGzM6LsRM DV6tkI5PxM0rFP3+UevwWVa3i9AxbZh5Oicn3cSXyJAxG2wdKa+LwGokCVTdFNVNIeyQ 2ew/XxdeeU9OIy3kCpSJOuTzg7AWrzyNvn7uEmxOOMBBYQUJgvsAA2sJHE5H2lALjg/P fjwZIQ/DiDhYx4HqPnQwAUH9EmsArICtrlPaXvJSR+QcOw1M80wNwoN8eXn5qezFU8ls WlwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756828675; x=1757433475; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Y6y56X8OUTmSoo3VKz8VzAATzZ9BTMxyuZT6xksXOKo=; b=j55dZJo6iJxnG0fy5CbOz+7vJM0YYDguWrizbd6QuWQKqrcnOJ/XzSdOrgDeD7Al57 nmwf8QxgOanlzHWQs1oQHrPpb3ph0LSbiYp2uTCijiyiPpsmk61lVdz88vHudiPp6r9m M7LysWo5YxiFZAbAxDS7Ene6WvmmFPd/Wqb97btZfA6OJfZ1A4SBLMZNW7rneaQ5bXJG +YMs/SLiczUQXzfDt+viGWhHsmsK2z9fxfBS3Hf+8Z12yZ22W3YqWFno1Y++sb30Bdbq +H+sKkTUQ8t0/p49PZkIJmDpir0s+YDTdoozcDYU5Efar9M5uCxnE23fjRl4GBZrEk7D Jwsg== X-Forwarded-Encrypted: i=1; AJvYcCVOwG5xxCpLvRrAv5XSX8wvPQ1ljnD1NWu2zEk2uyhXylkNroAVhHVCXSusvvvZqSpslZr+8KD/Rgn/iWQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yw9ywcUKiWC0Hjb+bOUW2yyZOZmgaOjZazY87Yo2FZpEm2mn2aU HK2hkREEpR9LqrjXYeiriLAhYvvmpedIUH4SQSLiYfYIShGgP5y5qC9q X-Gm-Gg: ASbGncupZ7+FZtCu4y1Ng9PKzXV4IvQllqtLl/123y/WYkEdkGA9E/yuceD43py0UYU Sl9TF33yTwaQJ99v35OfLhZWwoAcH++XugV9rpxlcCU+x0iU/ARuVEqwWg+kQAOvxLxglkZnJqt OmYw7j1G5klmtydCEB+GKCU8Mzz9wtWN1GZmf0Jbn5RY4gayjx76Rjc4oExiuUlai+ReESzqrjk 8E0JVwlUAnQN4nnWhvwoQBJSo5KFpphKhMn0EUX1gJT/aAaRfKBsGWrSD3cX+E+HlEru8wDzAhx ZjtBATMUx44p+6p+yxr1x+vY5d31lBHIeUJZ0Jw3wRpV3rVGDmZrAzmwmJMqfp3R8QH7/kEYQwK mwhmyLuLv/FOvepKMczKF956GTA== X-Google-Smtp-Source: AGHT+IHdPfNYaH9+9Q+ni6q5vuGRLRXreFcdRGX5aH2suTfhR9z0SYDmT0xWmddLPp0M60fE9SBktA== X-Received: by 2002:a05:6000:2283:b0:3c8:e9d3:c392 with SMTP id ffacd0b85a97d-3d1de3bc74dmr8652135f8f.19.1756828675091; Tue, 02 Sep 2025 08:57:55 -0700 (PDT) Received: from localhost ([2a03:2880:31ff:71::]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3cf34491a7fsm19642743f8f.57.2025.09.02.08.57.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Sep 2025 08:57:54 -0700 (PDT) From: Yueyang Pan To: Suren Baghdasaryan , Andrew Morton , Vlastimil Babka , Michal Hocko , Brendan Jackman , Johannes Weiner , Zi Yan , Vishal Moola , Shakeel Butt , Usama Arif Cc: linux-mm@kvack.org, kernel-team@meta.com, linux-kernel@vger.kernel.org Subject: [PATCH v2 2/2] mm/show_mem: Add trylock while printing alloc info Date: Tue, 2 Sep 2025 08:57:51 -0700 Message-ID: <1491df0ac12a7626b7c9b00e26a6e10adb8c9045.1756827906.git.pyyjason@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In production, show_mem() can be called concurrently from two different entities, for example one from oom_kill_process() another from __alloc_pages_slowpath from another kthread. This patch adds a spinlock and invokes trylock before printing out the kernel alloc info in show_mem(). This way two alloc info won't interleave with each other, which then makes parsing easier. Signed-off-by: Yueyang Pan Acked-by: Usama Arif Acked-by: Vlastimil Babka --- mm/show_mem.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/mm/show_mem.c b/mm/show_mem.c index 51892ce2efc4..4c876ea2b66f 100644 --- a/mm/show_mem.c +++ b/mm/show_mem.c @@ -396,6 +396,7 @@ static void show_free_areas(unsigned int filter, nodema= sk_t *nodemask, int max_z =20 void __show_mem(unsigned int filter, nodemask_t *nodemask, int max_zone_id= x) { + static DEFINE_SPINLOCK(mem_alloc_profiling_spinlock); unsigned long total =3D 0, reserved =3D 0, highmem =3D 0; struct zone *zone; =20 @@ -421,7 +422,7 @@ void __show_mem(unsigned int filter, nodemask_t *nodema= sk, int max_zone_idx) printk("%lu pages hwpoisoned\n", atomic_long_read(&num_poisoned_pages)); #endif #ifdef CONFIG_MEM_ALLOC_PROFILING - { + if (spin_trylock(&mem_alloc_profiling_spinlock)) { struct codetag_bytes tags[10]; size_t i, nr; =20 @@ -449,6 +450,7 @@ void __show_mem(unsigned int filter, nodemask_t *nodema= sk, int max_zone_idx) ct->lineno, ct->function); } } + spin_unlock(&mem_alloc_profiling_spinlock); } #endif } --=20 2.47.3