From nobody Fri Oct 3 14:32:50 2025 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 26A484315F for ; Fri, 29 Aug 2025 12:48:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756471715; cv=none; b=jYs5pXodSzjinBLuGOaMViNLiy0No6iz+jwCN0xB2V+bXVzZWxAQQqPOHdJFm0HNDI4NZWngGdmfym7t3IblfZwt2D9w4RvWTnokiP6nJsQiXgS4mZ3Uk6h8oGWbLveUHK1J0CAwF3Pf2ks8+JgGOryiS752PQinEr+AjlCVTgM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756471715; c=relaxed/simple; bh=PfM+wt4euQRDG6Ic7JsVFJRNm83TNiaN/c0Z+WZKFlY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HU6Vb/RuWbsYUFM0hOi21bak7GKxl3YKDkpb4HOhiozOvKYvcTo2oR6iTF+3cAshTs1PDLGQE83Cgi9Mu/SpK+KI4JAyuAJlHD7IeLPhoHpptCWrUBXnS75h7I3ECbP9rsBMBjWwupe4D7a6X0D6HsPq9KbxoY1d0riDpLl2Kug= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=A8m+6EET; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="A8m+6EET" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-3cdc54cabb1so800754f8f.0 for ; Fri, 29 Aug 2025 05:48:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1756471712; x=1757076512; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=WTM2+VDKikHtSeaCiymICMXcXjx2xNcBiPL91bhKQr0=; b=A8m+6EETCukGWs21sDBCad6TupbQKbf8Rfc6aQhFQmN2ozdj3kOOYF6KrJjSCoSCjC ZvSQ5Hd94xrtz4VeRUhwgIHmz1n5ifx8OzeJNw9QUUWQIt+4a+MSSD1o0GNa/RAQ4MHU 4Fww5dzYZqVU9iDpjsLOZoEfkM7beHxT1UihhTiieP4aL6L5VpOf+eqWVk/oDOXmLixq /1KP0WnHJlOqShiqITDDbmgQSureHKiVQSz4z1yCN5kZsA/GrbEBxv751at1sDTqKKlj S5w+Xq683qpjRxSHyqLYiZ/aHkebOVd5WTg7eBJ2XJI+RtfR4Y12m88RYdP1Iei45mgn g3Sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756471712; x=1757076512; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=WTM2+VDKikHtSeaCiymICMXcXjx2xNcBiPL91bhKQr0=; b=eAexQs/nvTWBkwRlM1VVF26E8yeO7iruzCcCPyo7Dr0WXDipcNXQpR4IL2c4QXmdEF kqReE3ynIZvH5A3pXP3bNEuM2ylbaov9KJoiAOBy1CMd+rpDckO0H5tHI0Wx8HunBski +0lv+ks+58ufEofSIWOWVjs06Sl+tI0hgHjmIuifec+8n7BIxrz/yk1ZN1a+5oyZC8Yk SbSzRDhIbid+oyzHw/Gc0st6Kb6MevNd9XBh5XMqwUwvUOb+FmhZAfDB/m3Q/b1UlSPG TfBP2qIR0MxPzvPMxVd+i+fSB21I8l9WLuGJvZLJIdDGOhuz4M7ZPEWi9glE6Oi0VFWM 81yA== X-Forwarded-Encrypted: i=1; AJvYcCUB+8+bTUBzbQDPCCgHaglq8hv2g3m5OJGu+5iRgoNVVYX8y7AHFBvvXoUcLyvNTJcaxQu3FHHVfpXr5Rs=@vger.kernel.org X-Gm-Message-State: AOJu0Yz0AarUMoyefjfMoo+VBLaxkpXZGm721tWDYmEIO6vnwg2yUPDn lbLXLECIup1snJZ+IXPK35OtD+UYwpFJcu14Nemt90jQB3i0QLbGYIGO1q+Br5ZgjqE= X-Gm-Gg: ASbGnct8S5LygYWJz3Zh8haNHnljA4y+RPZVajaU0z0mRyUvTm1rvSK3WU4fQKOQ/jb 98dNK7HYVcY+BkT9omBatzHnqc9qO/I6tvxE3qzfXA+Ki5rS9q9aaMSBTcmPIZd6K3FqCgx0AC+ De1T82DYEfe6ZZfXPPRxqU84W457FzZFhe3HJ8KGZn3vZ+NKPVwXSuMVjkmRY7yUb0rdGnqjygN s2hRTv0qVJ17Io9vhQ1G29WKAd+eaDUWvkt+PK3vTDhRCrukGJ9legyBhMmMvCnn5a2B31G/laO EHQAbbDc1o0yG/1Ft1Y4izSDJviL0j3CgVnL/2w+ndIsqvYHg54t7B47gWq8Ee4BPXoXJYd4ejv Hz62NEzvmrlcl2GEJCevc5CHLeCM= X-Google-Smtp-Source: AGHT+IEt7FoZ+poRNkadPvFS4MiTQw46m2z3gSirCmxuvzO0nDj/MLzNGlzo9GuQ50LaspKQ2QDy4A== X-Received: by 2002:a5d:5d0b:0:b0:3cd:edee:c7f1 with SMTP id ffacd0b85a97d-3cdedeecb38mr5773224f8f.56.1756471712413; Fri, 29 Aug 2025 05:48:32 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-3cf270fbd01sm3392325f8f.13.2025.08.29.05.48.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Aug 2025 05:48:31 -0700 (PDT) Date: Fri, 29 Aug 2025 15:48:28 +0300 From: Dan Carpenter To: Solomon Peachy Cc: Thomas Gleixner , Ingo Molnar , Johannes Berg , Roopni Devanathan , "John W. Linville" , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/3] wifi: cw1200: cap SSID length in cw1200_do_join() Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" If the ssidie[1] length is more that 32 it leads to memory corruption. Fixes: a910e4a94f69 ("cw1200: add driver for the ST-E CW1100 & CW1200 WLAN = chipsets") Signed-off-by: Dan Carpenter --- drivers/net/wireless/st/cw1200/sta.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/st/cw1200/sta.c b/drivers/net/wireless/st= /cw1200/sta.c index b1dd76e8aecb..5d8eaa700779 100644 --- a/drivers/net/wireless/st/cw1200/sta.c +++ b/drivers/net/wireless/st/cw1200/sta.c @@ -1291,7 +1291,7 @@ static void cw1200_do_join(struct cw1200_common *priv) rcu_read_lock(); ssidie =3D ieee80211_bss_get_ie(bss, WLAN_EID_SSID); if (ssidie) { - join.ssid_len =3D ssidie[1]; + join.ssid_len =3D min(ssidie[1], IEEE80211_MAX_SSID_LEN); memcpy(join.ssid, &ssidie[2], join.ssid_len); } rcu_read_unlock(); --=20 2.47.2 From nobody Fri Oct 3 14:32:50 2025 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8987A314B67 for ; Fri, 29 Aug 2025 12:48:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756471722; cv=none; b=QktINBXHWNBQcsoyb07hWiwN8/yIrN20tV9jBwBv40P4ysMbhXSC3mrXLd/OSiMq5m4yaa4QnUqLumPRudyAPC2fz68nLpKtXzbHZsdFkE34eWOEHGR5f6yQTp3JxPm/Xb7x44Emv08JwTAy2AWV4Z5X/uIJQvK39Cshb2PbqFo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756471722; c=relaxed/simple; bh=45DiPpeOM5zx6/4Mw43Vd8Fx93MYiPkCbDHS8+WL5GQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BZjYNrKgXa3oWNbfJDn8Wef2TK0P8kKVIcbqpbwwfaiwv0zETwsxVmFEfnp80YtMNkpz4Ua9hDHegsMIuet41K7yfimXSJHWQNPgqqnPqCXnmkd2lfk8JZofLvdpVNzcY/vR6qLGF4oMCr3r2201x3SwkTOstR9Mj0DmV/8PKb4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=lvpOdlve; arc=none smtp.client-ip=209.85.221.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="lvpOdlve" Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-3c6abcfd142so895252f8f.2 for ; Fri, 29 Aug 2025 05:48:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1756471719; x=1757076519; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=0nz5/CZs0S2wdMdQ1/s3IpMYW+S7LKqMEZUzHzH1Avg=; b=lvpOdlvecnmDicKc5/zB/BVycefbX0gIITsiJXiIKoKT7udqSx5OLN3wfBDJ0TujMq EJccZKf6CNeH08L0hgtjb77qhEStPnfY/Jb/s8gJ4lMMW1JqaUn+eNTCxT5CrcWRfsFC Iud7UvCDkVjQ2ogAYQCBT8Oa1KcOvwEQfun1rtinaxwLGwM+xIKUoMOH8omzeFzfSPCS 3NL7p5InKq8I+3vlYx93D2UKIx5gosHsglkf3pyx8rsE+mN+7bYHvbsFUN/dHFwjIO4Q W8VXtu483iZbNUW11hZqU33rX+B4ORKCJf+vXLA34pujD8FHPeEjpzd5CfVuszLedcb7 Wklg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756471719; x=1757076519; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=0nz5/CZs0S2wdMdQ1/s3IpMYW+S7LKqMEZUzHzH1Avg=; b=nX2v7gaSWZmEoh2Oum3yxjg6I/iYTXRYfgu04FhYahzl1/yUWD/4l9nfKYz2VYuWt3 Z6J6M7ckE5UwsmKuLNwER+2yT+R9jVMaAparOugWPTioa9/yxOTGAsM7bRblPiOBf4SN eGHJY8oZZvSxte6goT7puIOFLyAlBvfsVwMHaaXiHuzrTn5SDZGgUxurchrffmXjIcTW lqLv/7nyzNpY8aSpC2+ATgGHariYDqbKSbdWCBdn9Ji3PAj2+fyADh+AyDvGIlVZIFIm +I+gLtNlrPZ8acSOs2+1ijHWaqlYWR+n196bx3s19kNXh3rb8BLgIy1wYVOqlMV2D871 PLpA== X-Forwarded-Encrypted: i=1; AJvYcCW8MEHi64JJdz2Ml5s8PoqqCWY3DYFVdjYfzckGXXuOaUc6UwlUyVQMx2/l+ak+k2fhs3/21Mfk4jJGPpM=@vger.kernel.org X-Gm-Message-State: AOJu0YwcVrp03sFgoCg01N6eOsVQR7SoMqGQod6hFcrx9pEuX4i0gLFC KYWJub0jNdsLcK4v4vssZjtcvhSN9fGWSzfRJaxYItkWXmfeOaqaNUO8xIdmhaMX7C0= X-Gm-Gg: ASbGncuvvPDnOh18VvPBpZ8u0wCYMBmQ5WUHNOs1s6ZkdTSjBpaS7LAmtrUe4jr69K/ h8yOrw1vJYHbdvPGDgjj3x6KvhfchNVuh33Bq0Gs9rcEv7Bvdy7+R4PTg8q+2LKaoRQAUnvffKq eNY3QYPdvOG3Squ1LuxLdVXhyNvR80ACv+JHSBQXICJzNg7ewxaSafI5vDrzEnx4bfAUnrlHVXp cyPiw25oJAXolKDJ+POqrapr5kkto9onKUZrqUsYfijs9ztJ3sIgrLdAMhQ0dciNOzYlZ6TgYKf BzkZmcsexG/Qz8dFuemIO5dgsKkish+Pmp+yaSulbRxEsxTIg97tqCVCYy4+r67zOU1d/U52urV wyd6ssb6P74KdhGUOf/ML2fIBsbg= X-Google-Smtp-Source: AGHT+IGAaopXDShG3tR3uCjDbASluxlUiq9mt0YUEy9CsaBbmtN4hEpvIXepYAQBzAO18uaZZewA0A== X-Received: by 2002:a05:6000:2f86:b0:3cf:1249:8048 with SMTP id ffacd0b85a97d-3cf124984a2mr2541414f8f.59.1756471718819; Fri, 29 Aug 2025 05:48:38 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-3d0f85c287fsm1493893f8f.52.2025.08.29.05.48.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Aug 2025 05:48:38 -0700 (PDT) Date: Fri, 29 Aug 2025 15:48:35 +0300 From: Dan Carpenter To: Solomon Peachy Cc: Johannes Berg , Felix Fietkau , Bjorn Helgaas , Al Viro , "John W. Linville" , linux-wireless@vger.kernel.org, libertas-dev@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/3] wifi: libertas: cap SSID len in lbs_associate() Message-ID: <2a40f5ec7617144aef412034c12919a4927d90ad.1756456951.git.dan.carpenter@linaro.org> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" If the ssid_eid[1] length is more that 32 it leads to memory corruption. Fixes: a910e4a94f69 ("cw1200: add driver for the ST-E CW1100 & CW1200 WLAN = chipsets") Signed-off-by: Dan Carpenter --- drivers/net/wireless/marvell/libertas/cfg.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/marvell/libertas/cfg.c b/drivers/net/wire= less/marvell/libertas/cfg.c index 94dd488becaf..caba7491cd5a 100644 --- a/drivers/net/wireless/marvell/libertas/cfg.c +++ b/drivers/net/wireless/marvell/libertas/cfg.c @@ -1151,10 +1151,13 @@ static int lbs_associate(struct lbs_private *priv, /* add SSID TLV */ rcu_read_lock(); ssid_eid =3D ieee80211_bss_get_ie(bss, WLAN_EID_SSID); - if (ssid_eid) - pos +=3D lbs_add_ssid_tlv(pos, ssid_eid + 2, ssid_eid[1]); - else + if (ssid_eid) { + u32 ssid_len =3D min(ssid_eid[1], IEEE80211_MAX_SSID_LEN); + + pos +=3D lbs_add_ssid_tlv(pos, ssid_eid + 2, ssid_len); + } else { lbs_deb_assoc("no SSID\n"); + } rcu_read_unlock(); =20 /* add DS param TLV */ --=20 2.47.2 From nobody Fri Oct 3 14:32:50 2025 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 64E07314B67 for ; Fri, 29 Aug 2025 12:48:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756471732; cv=none; b=D1TPQA4EW9LUdJLLqL89B5tPbNAOZXk85wFUkHT15E8COm3HrbhG5Cf1Y6C1Ww52v6DmGyoFGLiGL8aL+3ijC3W1FmDw8LbWJovIJWH36SLB4zcQx+XVlpAjHdYPu6QOHXs9wpHpTMQylpDIK/CBUCaOLjhpDC7SmNWN6jc+9Pc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756471732; c=relaxed/simple; bh=BMZ/MNijEEIk/FpGTtfiEwpO4Kns+lZU+ojwgvMo0qY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=RgDOwXyS0KP2Z3E7SFrOSrT91+jGs5mzOaOGYliybjC4TVknX85SvhlP5euMmctfWS0LH+4g7YZAIwYKoRq+HFkE0eDGlBbz/jKU3el4YXCGcAZpjYIdgG4LvbVWlNj30b6F3y8UI3pUEYuIZmjhvgylviaPmsi0ZvnGRgJXYUY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Pvr6Do8M; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Pvr6Do8M" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-3cf48bde952so759502f8f.0 for ; Fri, 29 Aug 2025 05:48:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1756471729; x=1757076529; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ck+n5rGbWRlsQRXehQxg/mLWI6V1ptp52cr6SEHZ1hA=; b=Pvr6Do8MxThFjz3Msj3YrYmGCKwv87cKqrIAfKw2jyaHQGnZ4NwgOQ/fv64hdyt3Li 1ktd6kMZKi3Ie7FAXpWMHk8nke79VkK/t3zgHVR10k2QMhBgIhjjde5F6PDmNpzE6rta 7NSyrLZewkJQIlNYvW807Y1/WNbcvHCAkdCQCMhCFVlni/GLHKT8YX4GtXUFEFdtTYIK q1kEortTHe6wgsDahDgM13uDT6I+KORAYrPg4x0jLgegJz7R9D6/cIygR/vAbD8mkiqI dB83wonzOhA/gvhWcz7GCCivDJU9z755wWOQ+1wBv0HMglcZHHHMIRrSoVancdbsZshB GiHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756471729; x=1757076529; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ck+n5rGbWRlsQRXehQxg/mLWI6V1ptp52cr6SEHZ1hA=; b=ZoMF/TltrfN3hCNNJIOPAuzLKmkYNqFXVjitFb5wQWk7MWdazA3mJyowPoPmQ1l+fB WjMvMHBqCJlgifF4qSXdV3tJLhavaa64Eeb+b4AkNU/8pNIdx0p5QoEYwFDk5FqJr4l8 AlmZWuQKxaay0LW6I9rqY6RLv92MO0neTf5sn6bbkJe4O2N1TgK+10mtuAyTN0dUva/Q gFIx6wBlaT85kdutEndcNU+KInLuTUsbfIBcwBiYGcUzW8arBOOR/SDtR5ZRhQijvJWH fqk7htFG2Rfr7+TjrS22nHmvpevSJrCGRPTQ8lwKE3GX+DrayQ1DoP+VJaBvEVR1gdTM CACw== X-Forwarded-Encrypted: i=1; AJvYcCWp3nP6kAroCvFmWrV1JeyGHMnKRkxrcMFb5hGmCzzO6yKKqqkd80CsnEPOiu0oWAErPdd94XE+ZT7yaEg=@vger.kernel.org X-Gm-Message-State: AOJu0YxzU91/0V8r+DtaxV5e7e2WCv6qyxEQ67pWO1/CL4Nh7qlOMDKY UR3NcyrA633/djJ8vCd2eEC5WdGmDyemyAYPTgN7NrYS3BP0tQupmDsLZZEHXJ+369s= X-Gm-Gg: ASbGnctyFFDWYmdJfNdaTdCrJ18+1kCXixQ5Deiarbmss3Wkk2cydBB8DrSeMElFlou YN3EagdbWrcpoj5PaWVUNTh1sXtcssrDkZL+oYFGCcFLD4bgln1hjSEj9R1SW2ZB7bubtek7bLL Kl52b5UcJ9/xa/O8cAbobRuKw/jTMg6sM+0g5FcbdYBtSrg8szqZmxdl3lWrxy5wN/ZBsdg48XS gfqKlDzapHgnKbPvmfAdaqYnYOhb19hU0y0AdsPl1E7Wh1OvymFb/7yAGs1U0BDfAiHe/scYzMw O0BsGkYw+bNSIU7N8ySSszuH4U2qCfeoCYMS04y68kl0s+1NGm7UKzv7d7ZHEUk23Vgm/mkyyHn e/AOjt87P7ZB9jRal6v3b5saWrtZwHC2R3cnMyg== X-Google-Smtp-Source: AGHT+IHqAL/pnUSG2018CghKhwcQSgL0BqvunVzn+qXjZWNrgfogLc1879jtNukYRptPvZIatFaBWg== X-Received: by 2002:a05:6000:24c1:b0:3c8:4d98:7402 with SMTP id ffacd0b85a97d-3c84d987994mr18396631f8f.39.1756471728612; Fri, 29 Aug 2025 05:48:48 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-3cf8a64fce8sm3029385f8f.34.2025.08.29.05.48.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Aug 2025 05:48:48 -0700 (PDT) Date: Fri, 29 Aug 2025 15:48:45 +0300 From: Dan Carpenter To: Marc Bornand Cc: Johannes Berg , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/3] wifi: cfg80211: sme: capp SSID length in __cfg80211_connect_result() Message-ID: <0aaaae4a3ed37c6252363c34ae4904b1604e8e32.1756456951.git.dan.carpenter@linaro.org> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" If the ssid->datalen is more than IEEE80211_MAX_SSID_LEN (32) it would lead to memory corruption so add some bounds checking. Fixes: c38c70185101 ("wifi: cfg80211: Set SSID if it is not already set") Signed-off-by: Dan Carpenter --- net/wireless/sme.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/net/wireless/sme.c b/net/wireless/sme.c index 826ec0a6355f..3a028ff287fb 100644 --- a/net/wireless/sme.c +++ b/net/wireless/sme.c @@ -900,13 +900,16 @@ void __cfg80211_connect_result(struct net_device *dev, if (!wdev->u.client.ssid_len) { rcu_read_lock(); for_each_valid_link(cr, link) { + u32 ssid_len; + ssid =3D ieee80211_bss_get_elem(cr->links[link].bss, WLAN_EID_SSID); =20 if (!ssid || !ssid->datalen) continue; =20 - memcpy(wdev->u.client.ssid, ssid->data, ssid->datalen); + ssid_len =3D min(ssid->datalen, IEEE80211_MAX_SSID_LEN); + memcpy(wdev->u.client.ssid, ssid->data, ssid_len); wdev->u.client.ssid_len =3D ssid->datalen; break; } --=20 2.47.2