From nobody Sat Oct 4 06:33:20 2025 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D662631A046 for ; Tue, 19 Aug 2025 09:38:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755596305; cv=none; b=pvrv6mDbCxHUE7O8jsZ7MQ/ka0ZGxC/TV48cOFoh+qi9d3J+1oXyopTr+ro3KxtPucQEQu2RpV5QhuzAUPLnk3H6bplwNW4Yj57uUkr9jGhKOy0xTEHol3klxjvAObe6zzH8PuvPrlF5r9jbhJFVcTDcmtD7fJbMkxD4TjT/uKU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755596305; c=relaxed/simple; bh=yeTB2l2UN+Dfs8SkRieR9aXEQAYC0WR3yQg5oK1gn74=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=u/GHIrsotJWHI+BpAvqC3ALDtLAd7Zc+NLynxXa+6+2Qh2ETDYLrXW4VL1iQrIP+bKBA5b0gLDHvOF7QVdoC4t8upgKQVxrFDX7C1aSpipHMd4eOWZ87x2ERmhgTksUGb+ell6A4TASn7lTAp1nDWq9+1vPvLt8Vd1Vyr/C6Up8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=qax5foHh; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="qax5foHh" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-45a1b001f55so22940685e9.0 for ; Tue, 19 Aug 2025 02:38:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1755596302; x=1756201102; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=cQNHUhi6q6rKtdJPu5piFu1Pt6Qdn+yGCZCHH5qFNtA=; b=qax5foHhCypgZ5WdfDPa60lxPZ+Z9AfJNn/5Bn/wl2SyBhIZgfZQGLWt+hLEu5UOHN K3as4LoEV+xTautv3DfkBS1wz1wMtqnjD8DP5oWlkR5DYSP1iYrceF8r1ipVBcWVAexC +3UIYM+/cAmUpa5GSR99HC1o8Zx+nngBYeR5f+uYYfZc2afS1QpPYF4rGXOALC0QvX5x 8vQOzrC9rVCxUeg93vcUXNUJ1YEB4AtgZL2zIFFz4WrWpswG3Rl1qN2m4q0UaeUEeiBE /GYPe60k5UUIMg36u3nYsjiYxyKabj3R5VXP3ui9I8uQk3X0yhbC9gL3w1AY7JEO5eEP tDqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755596302; x=1756201102; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=cQNHUhi6q6rKtdJPu5piFu1Pt6Qdn+yGCZCHH5qFNtA=; b=ABJXoUObwPOIHCjWvTU9lZF2HMqNrz6oGlcyzqAj+w9wXhCLVo98y8sC6Q9xeaXeL8 rXratMcNNbLWV7xlxdM57bkoP2k/01EZavRauTRPYJteFHGFU/gCphamDdZA4f0y2Bsc DnWZk9XeE4S3VKdj+MxUEQbBJhewZ0Ztz0L7X4LxrIVxEDy1pxjPvY3M4Zu7vvtg0cgY LUgb7Ex53EPcZlu8K/AoLCjnllWQwPpHTTe1WdOIACqQ2hxogrAA1N8A98gxcZV6w35H 35PnlBtAt8tDn9o0+lvQQNwIC8AE8JjzE+8u8tYwYGDToc3cUOcTGyVX00l7XpuS7yVc dMFA== X-Forwarded-Encrypted: i=1; AJvYcCX2udVzijw++kCOYZA4OyXkqO2Nfk9PACRdvAfXuqfkT1/zpoe6JLzqBw1UjQvVyNn/sLKHu/hiJjDp3s0=@vger.kernel.org X-Gm-Message-State: AOJu0YxsEbCCKoTIqigq3/iWYOGXHH1g0EVLa2GYgu91UiTXgGlXWwcB gzCK/I6mTjg3v3+YZHpYGJCn9i6k/elQYBV1eRE2vnckfv8BNCs14u3we4mcRc73Kmw= X-Gm-Gg: ASbGnctb7+6x7SJx5MYutcvMPerPV3rVfDToyhpEcM7Snyib8eWu5sxGMoA20vCWIIL VxXwh3h/HCaNLtMlCKKAJmy7EAoppFc4rXqfWe/ESf1Re5S9dEYvuCu+FGWH6AWd6uWyfTTwmPk cz8ssaD1NqzJVKyBzCpM6KpH3VQmo4mYS6C3TZHKEOQ+RjHEAlWuS7B0ZjkWN5Cc02mrYNVCV8S u6/YlMIcuBFnWVmLChE2x9UXgwKZ8MY1yBrkPGhwV1JVv5OxyW+o0R26ltnE/KlpnaeZQeyKAHX YM2rkprsbQ1FL0Su88wkxtchrDAKVgnQsRuZ+qd+pVs9pIqF9GLWS9two9ifh5vOfmE0nggIqSf nQqTY3u7xvn1HgWj1bu8BoVWgKUU= X-Google-Smtp-Source: AGHT+IGyrjULf+RdvVTDZSXTBxzshpoUU51bE+6aqkNwYFecCzQvOYD+ZNcx9bLMZ5tuTwxDYI9CKA== X-Received: by 2002:a05:6000:1449:b0:3a6:d7ec:c701 with SMTP id ffacd0b85a97d-3c0ec66078fmr1105498f8f.30.1755596302031; Tue, 19 Aug 2025 02:38:22 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-3c0748798aasm3056876f8f.14.2025.08.19.02.38.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Aug 2025 02:38:21 -0700 (PDT) Date: Tue, 19 Aug 2025 12:38:18 +0300 From: Dan Carpenter To: Maarten Lankhorst Cc: Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/3] drm/plane: Clean up 0 vs NULL issue Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The create_in_format_blob() function returns pointers, not integers. Change the zero to a NULL. Signed-off-by: Dan Carpenter --- drivers/gpu/drm/drm_plane.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_plane.c b/drivers/gpu/drm/drm_plane.c index 38f82391bfda..ad21fc855aea 100644 --- a/drivers/gpu/drm/drm_plane.c +++ b/drivers/gpu/drm/drm_plane.c @@ -210,7 +210,7 @@ static struct drm_property_blob *create_in_format_blob(= struct drm_device *dev, formats_size =3D sizeof(__u32) * plane->format_count; if (WARN_ON(!formats_size)) { /* 0 formats are never expected */ - return 0; + return NULL; } =20 modifiers_size =3D --=20 2.47.2 From nobody Sat Oct 4 06:33:20 2025 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6F42731A06C for ; Tue, 19 Aug 2025 09:38:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755596313; cv=none; b=JGEsuW3ZN2UL//rll/4eGX5gz9VwMxGy5VdtQgAgXL8lC/TwlNjVdDKZKN31YE8FpwQxORbd+cKdFkkZaa2SY/mKtJGI9aKAXFa27dP5zOJnMcOe2nJtwhLMjarKvs4Ng9ZruaHLHWWBqELgQEh6xZpQtBbhW6wvDTCPDzG0rts= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755596313; c=relaxed/simple; bh=cr7dDOeFq2kJNvj9k8XgGLyCpYIUvYq5oqsrHpO80iI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=kHOjsec3TL9w9p9Rn5z+5e6CnXrguSoLcPuchfXHxCQRGsaLxIsNoIT1mLzDJpSWRik+h1Zv9fCczIRnCQBofbemqr6yI03JyVuAThJSy8VjndIojZjyo3xnSIMNSdomvIQsXx8IqwbbG4zw98d5Nu3K5RfJW3UjEOYNM7n92To= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=q0oQIC7t; arc=none smtp.client-ip=209.85.221.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="q0oQIC7t" Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-3b9d41c1963so2517955f8f.0 for ; Tue, 19 Aug 2025 02:38:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1755596310; x=1756201110; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Sz9qrbHKfImiU0wIEPpwysb9Rj1rHIdlAeMbcs31ric=; b=q0oQIC7tzXawjoPIW1K6vsfBLOonVbV+K3zOQ5kNpgyzfFOvcZ788TwXbQ3c9byuXD DrMVPjkzIFChP9dhTAlXi8RlMUmFSoN+ejeaNxDQhYYTrbKMro0GSsqkTk/5IrBuadTp MZIgPv3imA4F9oOwWVy/K8n7uRQGUL4de6CEpEY9aT2iWS2dgWaiJejkMkD9iD9KwRIN gBXg5z+84uvjLbJhlmwVOy/xQ52Fs2jEqF9/ltG4/eW6XzHi3NMW47u+nr+uaYOTUAGR 8lczCNP8oC0N6qDUmUNEGcSMyL9qmy+l7hqBOVbkipC1JZbXc22X+2wu+by7Tro+SbNr exWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755596310; x=1756201110; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Sz9qrbHKfImiU0wIEPpwysb9Rj1rHIdlAeMbcs31ric=; b=WApfRuwmGtK05XvhytJ5x4FJrGo9C4hNIKmvsaJUsnUNJihxwdvPfIsquQHtzQqqCG NuLofdwJDspYYVTSV8QZD4R96vykpxWHgR4RGXHtEqWBEVRx5fxWWlRt+Wk7eeDLlyVG H6unIZrkF+/ramnl4bXv8tP+pJNipuvI68cJbktjg0PZRBJ5+HCy66h16+RCiteg6nWI /tFtAEXQWdN41Q8P4Ujc6ef0/jU0UggGbznOGHkikN8wA2OEWLAmY/JthDlCOcXn7KHU EY6JBhTxk3jsksAy50hQMVJEVuMjH7497MzILycrErtJiLhW9NMiCMdg6BUBN0kbypWU ouIw== X-Forwarded-Encrypted: i=1; AJvYcCX2MAA3GNQNsmav8wE5oh0MCbjutMSVZJD1ez00+t8/p+cl6yXS/VNFbUijEsOGpJEUTCN7MS7989cnNak=@vger.kernel.org X-Gm-Message-State: AOJu0Yzalw/Ec3ESNvV3hA04QT5tQALoX0N0DyThuaHDiWGH+1zwgVXb +Rl91ekDFiUohQgJYwIJ66lQhtY2BRCSQTylY8UfAjlGY9vqHwPVgQBzYhTjrGtj740= X-Gm-Gg: ASbGncuPyNPLbM8t95z2SeMMuxc8zFfOD1loQCORP7QFaEKfPItHQ7qvmdsLigc5o4d DW4YQwykfnRp9Ca72w3Jp+Ru0Hg/rxGdQBam2kMZ0YxmS7bIt7f9Tf80JeC0AIcjqUK/CCNlVN3 oAvZILiMOGuZUqFDhOjcP+CtkewDOXOHXVn4w2v94B/VCaZogukMwzCEPufEkHJ9wz7vRE0Htoo B8GIawzhChD4BTQ8NEqK8tihLrB1P4jKs1s96thBU4ZCVRP5YcwjTLWoWnU2b8CouFQu7WlwKlw 17S+x2sW7YPzAOXP2LL6YH0vcn45qPUCLy/j6q+PC5T181/t+uN3tfB/z+RxJ/YfhRHMPZXO95q XV3sVEfQRuCcyrg9BUkDm/Y3KMRw= X-Google-Smtp-Source: AGHT+IHlXFQlXQqNpNupwtpvRJnPuKsXYXg5yse55qc7nSnLb1u0RqJ4oB2cIQ0DRGelvNX7cDhImw== X-Received: by 2002:a5d:64e8:0:b0:3b8:dabe:bd78 with SMTP id ffacd0b85a97d-3c0ed1f32ffmr1300950f8f.54.1755596309645; Tue, 19 Aug 2025 02:38:29 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-3c077789c92sm2905553f8f.52.2025.08.19.02.38.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Aug 2025 02:38:29 -0700 (PDT) Date: Tue, 19 Aug 2025 12:38:26 +0300 From: Dan Carpenter To: Zack Rusin Cc: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Javier Martinez Canillas , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/3] drm/plane: Fix IS_ERR() vs NULL checks in drm_plane_create_hotspot_properties() Message-ID: <638f3e0c648c3f7c1e3b61dd180d10dc102f52dd.1755591666.git.dan.carpenter@linaro.org> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The drm_property_create_signed_range() function returns NULL on error. It doesn't return error pointers. Fix the check to match. Fixes: 8f7179a1027d ("drm/atomic: Add support for mouse hotspots") Signed-off-by: Dan Carpenter Reviewed-by: Zack Rusin --- This is a resend of a patch I sent a year ago. https://lore.kernel.org/all/CABQX2QOoq3H=3DeHdM83_k5vgHiaMu9Zsto=3DH7S95QHx= T-s16jEQ@mail.gmail.com/ --- drivers/gpu/drm/drm_plane.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_plane.c b/drivers/gpu/drm/drm_plane.c index ad21fc855aea..beef2a06bc75 100644 --- a/drivers/gpu/drm/drm_plane.c +++ b/drivers/gpu/drm/drm_plane.c @@ -338,14 +338,14 @@ static int drm_plane_create_hotspot_properties(struct= drm_plane *plane) =20 prop_x =3D drm_property_create_signed_range(plane->dev, 0, "HOTSPOT_X", INT_MIN, INT_MAX); - if (IS_ERR(prop_x)) - return PTR_ERR(prop_x); + if (!prop_x) + return -ENOMEM; =20 prop_y =3D drm_property_create_signed_range(plane->dev, 0, "HOTSPOT_Y", INT_MIN, INT_MAX); - if (IS_ERR(prop_y)) { + if (!prop_y) { drm_property_destroy(plane->dev, prop_x); - return PTR_ERR(prop_y); + return -ENOMEM; } =20 drm_object_attach_property(&plane->base, prop_x, 0); --=20 2.47.2 From nobody Sat Oct 4 06:33:20 2025 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C6B8B3115A1 for ; Tue, 19 Aug 2025 09:38:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755596322; cv=none; b=FwLJSZb61XCgbKR3Uwr6Xac41rLusy8oMYLj5uZVQqxFinfMIqqkHuhFWWo1BuRwa/DnweThxCotd8AIzbDRl0zOVDx4aM8+Q/pk5EWrtXeTYiBqINkHibnfg2Boajmdl6kt6GuF3A8knZs0WbHeU89nH7Tvb6lwVBsNvCVxT6E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755596322; c=relaxed/simple; bh=BNBYTrkKh+r61QPjXesr09akZIgnL2UxuB3fmlO0oaA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=iNPOQXS/DS1Asngq8FDJo7HjLJdl3hegLBZ8/yKKHiAU0NKA1+7vymgwPHVgZGLMPYx8/kyBqpiGL40VoPR0P97arKH1eJ0CoJe7zK2h04lA4J91VL5c7E4A5a6XayRflKL1aWkxeUcTw/+M08biw9AijQVYZtjkKwSpbKNN9sc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=ERSuohNr; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ERSuohNr" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-3b9d41c1964so3402588f8f.0 for ; Tue, 19 Aug 2025 02:38:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1755596319; x=1756201119; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=at/5eKe3PrrAbraNpLb6KoExLUDoe69Dgy/Mvb40QeY=; b=ERSuohNrCDyjY/Je7UnqxtAnuR1lFeZpQi8z0aeOCFe+Ws1MYxELdwSYR8XWcW9Hcq yc9wg/MCc9pb+7Pulg6fn15ye5xk7M2YfRlpDuFKM5YEPjA2mPwbKCOEdgF8MH5a3McL PYNbAMKXOwVa9St479M9Ot1MbeZ40ahlLkmJZc6qMyD+mvrFLL6vDOFt6KCg3uDrF/xB IWkHQi5bQtk8s3wxo7RZX9nz/ZJzvCCtQo5nC50z7agNynHKtOsJL7sD4EqkJq+Cy57U +Ouphy1Y98+T9ZUQJnsySdSNEhrM7b3VhtcLSMeNUyrvlo6BGfWqlvfi9i6ho0QUbCnX 3ZIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755596319; x=1756201119; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=at/5eKe3PrrAbraNpLb6KoExLUDoe69Dgy/Mvb40QeY=; b=EDMor1C6NfF94hlbw02RSk2pZpmt5fyWsX/K+/kophT7LIg7MYg5cTBeRLdbki1tCF evA3tGUbM+3Q5Tt0qLMYS1OPOvgLTk4LBfVwRJqkLCF/e/U8jDH24aZfF5tA6zUzL4Cx O1kt2Ej+aNXahyTmKajPIk3FNS0YPMNgaWxw+fPys3Anzoqx++AXhvJYPl697kpktsmD m/M3/oc6eqE70YR93fWWW0isLGh+VaztHMRdv/GCfYFn3oSP2iyEA8mxcJn2C4VFKIhM TH8rsqHYkNixAwhCdjkOm+t7I/GX4Mtc1RtzU9WCuyPcWc/PwI3h6XaRLaevdOoWQpvN b7Dg== X-Forwarded-Encrypted: i=1; AJvYcCUd19w1uCMhezkuLvG2BmqqGuw/pMmHz1f2YEOhN3wGF7I3HdsxMdUCbWEZIgi4rB85IIU2Ll/SDwIk+q4=@vger.kernel.org X-Gm-Message-State: AOJu0YxNsjMlSVg/vG4xysZELHRGgh74GxkUMboocoG0jUK7t9nbOcnD AxBc6JUQ8N6ma2M9N1WkvEVBiEfWEpMUu+49mif9+2OzLaVQT5uaei3L1Dg67tguIf0= X-Gm-Gg: ASbGncumNkBBv87IKz0ji7p/hwtnF2MDkAA0M3HrIcwaiwzGTSNhszi3yqx3Q8JABHv 7IKyjwOFOjyJtPTZqhfVIFDqfV1BmgYFusYJbzzPKT5UNtH4eW5sBsQag8beRLarSi27ek0Ipql JBBA6wm1DcGK1AiencU3BgSmAW7K8Qc6SxptkAu64qwOPZmmRAVqzamJTjwIEUai9GVyVP1QyCN uFPokT7uVZxD+vHH0lDj151yH44AmLoxWjAZn+cB7EoB0D1vZPRoSzJFaHylM3b071YHASvP/v9 rRcX1YM7hjIC7sf/BSabAW3hvSUOmmmCJ/vjPxKzBK/0FgG0mPaP8Lnr0jT7WCjUwKXFnJcs9f7 YyN2P3IjW4gk51ApKOrZVDgnB404= X-Google-Smtp-Source: AGHT+IFkB5hfOSqRO9ucIKbwVALsj+nCtLLW02xqPar2YbcIy4HqcpvqEUmAihdf079LhDp9jt6P0g== X-Received: by 2002:a05:6000:4028:b0:3b7:7749:aa92 with SMTP id ffacd0b85a97d-3c0ed6c4b1cmr1345276f8f.58.1755596319074; Tue, 19 Aug 2025 02:38:39 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-45a1c6bd172sm220059075e9.6.2025.08.19.02.38.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Aug 2025 02:38:38 -0700 (PDT) Date: Tue, 19 Aug 2025 12:38:35 +0300 From: Dan Carpenter To: Arun R Murthy Cc: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Ville =?iso-8859-1?Q?Syrj=E4l=E4?= , Harry Wentland , Suraj Kandpal , Xaver Hugl , Chaitanya Kumar Borah , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/3] drm/plane: Fix IS_ERR() vs NULL bugs in __drm_universal_plane_init() Message-ID: <6f9fc3889e0c79d7ac2833f3a2a6ff8b047c2b11.1755591666.git.dan.carpenter@linaro.org> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The create_in_format_blob() function returns NULL on error. It never returns error pointers. Update the check to match. Fixes: 0d6dcd741c26 ("drm/plane: modify create_in_formats to acommodate asy= nc") Signed-off-by: Dan Carpenter --- drivers/gpu/drm/drm_plane.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_plane.c b/drivers/gpu/drm/drm_plane.c index beef2a06bc75..2f5a95bc0528 100644 --- a/drivers/gpu/drm/drm_plane.c +++ b/drivers/gpu/drm/drm_plane.c @@ -483,7 +483,7 @@ static int __drm_universal_plane_init(struct drm_device= *dev, if (format_modifier_count) { blob =3D create_in_format_blob(dev, plane, plane->funcs->format_mod_supported); - if (!IS_ERR(blob)) + if (blob) drm_object_attach_property(&plane->base, config->modifiers_property, blob->base.id); @@ -492,7 +492,7 @@ static int __drm_universal_plane_init(struct drm_device= *dev, if (plane->funcs->format_mod_supported_async) { blob =3D create_in_format_blob(dev, plane, plane->funcs->format_mod_supported_async); - if (!IS_ERR(blob)) + if (blob) drm_object_attach_property(&plane->base, config->async_modifiers_property, blob->base.id); --=20 2.47.2