From nobody Sun Oct 5 14:37:52 2025 Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4D39D8836 for ; Fri, 1 Aug 2025 23:00:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754089234; cv=none; b=JptNbg7JItqBdKu19wyaTDSPZYVzwB+WV0vQ0PjY/GiXSCs56u0Cy+2S2Ip5cUDXqsFpGWSYZ9bn+S6g8FiyXQ5AKRFnneZLqxwiuvBi4VpppzVzHG6DdZFOLcBv5RlKHxupKaeY584lk3IsKd32nujRRdiOndsHaaVbdQtz9P0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754089234; c=relaxed/simple; bh=6VWhFqgFIIIqZ6lhYXMM3FSKkMvZt2i3RrAM7/Vd2mw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WTUHaEHkfh4Iop/1wDY+4zYKMEJyVQHWccC+O2+ZVefS7VUwyPdKk9tDGmG1BHx2GLEIy2yHdUCfW5COmHMn+7fbX/n7wzTcO0OLhPkH05gzsDBNBkq49Tu/B/F+o6CbrJJ0am5dk0hQDpeg3iF8B2bANcI82r0uSQnbOmAsSGc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=iNYM91T0; arc=none smtp.client-ip=209.85.208.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iNYM91T0" Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-61521cd7be2so1887633a12.3 for ; Fri, 01 Aug 2025 16:00:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1754089230; x=1754694030; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=abqEG4k6EI+O4I+vteJ6XJztfIuJJUkYy/PS43p6Afw=; b=iNYM91T0Rh86cH1+gtZp618XT7ndYuhA/ligGHJXyJq1w35RoEKVhOnE+NMNPT7uaM vp3G3G3dvRfIGdbVuDpKv7ogPjMTcQZihmLSswNLTZFVTEyOsLOTMbsyo13+T6Dn/Ah8 aWwOr3excadSWw6KX31I1re8bYYun5685a3HpQxVmWBHY6rzg1z/G+1Hc5ERZXPTipUi DXy7os3FgS6ROTBg/cHKNAzN+vIoPLEopPjlop/p8qQQaOrlVPuEERngGDQRx3NRXwbj i4kN+n/YljIe8WwRdCY0Jtu6UWQ60M8abCwwwDQXv57951DH3mYBPOhBJ6WnAg/sD1MA HFLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754089230; x=1754694030; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=abqEG4k6EI+O4I+vteJ6XJztfIuJJUkYy/PS43p6Afw=; b=bOCvLcXyjgspUDWvJOQ9e0eYX7WZatsibT9FdzDRD+dMF95W7mEneRrZU2iq0UGe2p dg/JJhCn9Uvk9Eo/mXNF8zt8YAyGNBuqlOQqt2v1XQiTV1ORFp+aFZsoSmOsRlR2c3/r zg77EF9gN0/dzDoiiFnsEJN43ZtvomUqkK1kJ4SFCs7tcIQfGwsbqJ31w0qGIDn0mZe2 QEJk3BOLaG/O92me+nUy3QXHXRvls7MZNwB6rGpdfZ70/ML7GDuZrNP58YChuhLNygt3 rTlx7NrG5Cb9YUoDFRcg4HX87OLS7xQO7q3Q/3lup1Tm+Dln6MCkSs6JCtMjmfr1qdiB FBSg== X-Forwarded-Encrypted: i=1; AJvYcCWW90BzEALI5BW0tIAw9BUungUu/0kIM2Uy/p+EwbIwKXL6t1XY6aJAoMC2wEdHsfB/bxhG5UndX6YZ0sE=@vger.kernel.org X-Gm-Message-State: AOJu0YyH0EhYTr2BmBaRlxdz+5WrPtyKDcUYLfbvzbBoqf3a7cySGMnK ubQcBEE/59CDqemHe1KWNwFuiuhtN0QUshTmXA7gXQ/w5Dk+SD2RyXOo X-Gm-Gg: ASbGncunByetbykcEavTH0pKrnvz5iQBCltJXxtZb+9XOuWcej1Nw1Rl9Rqugq1cE/M IwGcTadKfRxpkf4ZsPQLxGV8vHSmQ+uxHdo6LbCzn05d1+qx97jvyiYXuNiXse0K0FG8naw4tLP 4nZvzWwgEhVZv3M0A739K8q7ZwSohFfXT/LVSbtAcEI9onhtwrhSErmGnjjzjHPCNq2uF1Fj9St sPahBe8FTTgkCNz5+f8HmNcy5wgtj6YjJbGuAzs4wxl1W3nuSeEKpMkVD6nEj1D316J7YCSdTz5 BaojAhNRJpVCteKOIQWDiIUfAyK69kY9IX3CHCa2o8QLlyyQF0ySSkHeMAFMN+5tjf8SgTXPcDE WJCKo2fPp8DCFHzKCL7zbb3oOqPGGmrSEM+hbR3hAlB4STfbDCYeFkVGj0SLEcbMN8eQHb1I= X-Google-Smtp-Source: AGHT+IGJBab9bvw4VnN4YTk8kzAMWhGzABK21zAIbErqjtzD57IzqR8o7kVbKYxaiRnwlzZ5i9LCkw== X-Received: by 2002:a50:cc03:0:b0:615:b6b9:d873 with SMTP id 4fb4d7f45d1cf-615e715d669mr677090a12.24.1754089230336; Fri, 01 Aug 2025 16:00:30 -0700 (PDT) Received: from rs3labsrv8.iccluster.epfl.ch (nat-icclus-192-26-29-9.epfl.ch. [192.26.29.9]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-615a8ffa17csm3279290a12.49.2025.08.01.16.00.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Aug 2025 16:00:29 -0700 (PDT) From: pyyjason@gmail.com To: SeongJae Park , Andrew Morton , Usama Arif Cc: damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@meta.com, Yueyang Pan Subject: [PATCH v3 1/2] mm/damon: Move has filter to ops-common Date: Fri, 1 Aug 2025 22:59:50 +0000 Message-ID: X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Yueyang Pan This patch moves damon_pa_scheme_has_filter to ops-common. renaming to damon_ops_has_filter. Doing so allows us to reuse its logic in the vaddr version of DAMOS_STAT Signed-off-by: Yueyang Pan --- mm/damon/ops-common.c | 9 +++++++++ mm/damon/ops-common.h | 2 ++ mm/damon/paddr.c | 11 +---------- 3 files changed, 12 insertions(+), 10 deletions(-) diff --git a/mm/damon/ops-common.c b/mm/damon/ops-common.c index 99321ff5cb92..de5404477242 100644 --- a/mm/damon/ops-common.c +++ b/mm/damon/ops-common.c @@ -412,3 +412,12 @@ unsigned long damon_migrate_pages(struct list_head *fo= lio_list, int target_nid) =20 return nr_migrated; } + +bool damon_ops_has_filter(struct damos *s) +{ + struct damos_filter *f; + + damos_for_each_ops_filter(f, s) + return true; + return false; +} diff --git a/mm/damon/ops-common.h b/mm/damon/ops-common.h index 61ad54aaf256..d3d36bca90b9 100644 --- a/mm/damon/ops-common.h +++ b/mm/damon/ops-common.h @@ -21,3 +21,5 @@ int damon_hot_score(struct damon_ctx *c, struct damon_reg= ion *r, =20 bool damos_folio_filter_match(struct damos_filter *filter, struct folio *f= olio); unsigned long damon_migrate_pages(struct list_head *folio_list, int target= _nid); + +bool damon_ops_has_filter(struct damos *s); diff --git a/mm/damon/paddr.c b/mm/damon/paddr.c index 53a55c5114fb..9d9cdcc10b8e 100644 --- a/mm/damon/paddr.c +++ b/mm/damon/paddr.c @@ -262,22 +262,13 @@ static unsigned long damon_pa_migrate(struct damon_re= gion *r, struct damos *s, return applied * PAGE_SIZE; } =20 -static bool damon_pa_scheme_has_filter(struct damos *s) -{ - struct damos_filter *f; - - damos_for_each_ops_filter(f, s) - return true; - return false; -} - static unsigned long damon_pa_stat(struct damon_region *r, struct damos *s, unsigned long *sz_filter_passed) { unsigned long addr; struct folio *folio; =20 - if (!damon_pa_scheme_has_filter(s)) + if (!damon_ops_has_filter(s)) return 0; =20 addr =3D r->ar.start; --=20 2.43.0 From nobody Sun Oct 5 14:37:52 2025 Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 06F2A2222D7 for ; Fri, 1 Aug 2025 23:00:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754089236; cv=none; b=kIs5yd4jsyCytaBE35ZrSlFvXvIedpufxuoVATOAhhFrhSCizG4Bb8h7A4OfFoov+OO1j2oWUqDXLyJbDsuucKTwQGDf5Fn0LcY3gufzbmHp7/WgkEGy7MitB6YTAxODOjoQX0dw8LXjHhMOhw7ubuEVURwYztj+7z6xMgzU/VM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754089236; c=relaxed/simple; bh=aGdRJ4ByNteA2tQEeCjWddN2fTO05i9HAI+NBYdbV0c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Lfy+TBTlOTkM13y7f/AQfm1AE3XnGRBQMlMn3mA43g3kW7OPZ2TjutLDces8rg3+oWk2I5SZL/JrrjY4rH8X1vjab3t1irGAodlDRwDhb/Tg++yyR2JTBR8gwkgzRWkcgXCfSeeRPUOx2DMBn+mTnV9+LB2ezdxNx2oXQtrAVgM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Yxpgejxq; arc=none smtp.client-ip=209.85.208.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Yxpgejxq" Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-615398dc162so4223643a12.3 for ; Fri, 01 Aug 2025 16:00:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1754089233; x=1754694033; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7UIQftffFi5dmDZFojFIrkTA5pAdhvl7y5sSZY3E7b4=; b=YxpgejxqAbCoLBflR97UjaPVTGYUbGy5phZQpjewXaJicYPTYpmhzUveM/dbvottBj entuHhec4B6glcqlnyjnwwXfCkwOXbBbZWwoZf0qKIo1KfbfZtaRQjvoGBsrP9eyt5VI oLfkA71+cwwrsDIsthstGw38tBdV5KYjZBtHZYocIL5b8FpmQJH/bL8s12RPr+uLMprb B8SccDEl/jmIzIeH1Aq+kFYEOFDBfwWomq8Zvbn9oAsm6p7Q63d5/O1BIpj+XQzqOmt4 Tqf2Q7DTHpAZEMlaZgfvW/13W0B/FpkBUVi4Thoupy98xjIr9aThXzKmeeMCz+P97tA+ OxkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754089233; x=1754694033; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7UIQftffFi5dmDZFojFIrkTA5pAdhvl7y5sSZY3E7b4=; b=L5bRThncNwqlkTEMSq0cWkGKnrNEy3WRqDJNFkLgtzsAiclZ9UU35H2RInzHSPvR9H r7XYofWfAneRoTntcFkpvMZk7nrRgz14qt6I/ExMy8gtQarhTSnUe/ao1v6gaWG+1/63 brBJqp0PoyFmfXAkZ9xRLqvpK4aITIf3wlwscf2xU27XjCPs5Uvu3QX5VWTkNdPwUAaU +mR7MXqUN3iJ8GL3A9m/JY1eMdLwvOGKTaxVHUJbUB5cddMuvQ4xv8uWOshy7CPTeiJS p3dOrc5+fFKnl9VGpmjmiNK63Hl2Dw/XPCirLSbd9MhmK3Qu7mQquMFpGY8G53Cq2bdH /Oeg== X-Forwarded-Encrypted: i=1; AJvYcCUtOEajbh+kWmzFmNPrBhtd9t25GGu+UYk+tpHSOl5zjkZFqIhcRwBEQNokOz7Axrw4PBwE9NwTuQG3Q3s=@vger.kernel.org X-Gm-Message-State: AOJu0YwtHqFI4Yzb1blir+io+qUnnFDFtjoaD7/oqfJhwF2MpVlwjDel AT8LWEsHUO42Q17wk1ZMvgdl2sYgTL2LU58MOY48vNX9+QP5Bg3VhNco X-Gm-Gg: ASbGncso5lttYTV6VI+LWIMXqcqiHDGGvRS+6BNlCXBQvZ1CsdJyxEil/hPliITweb3 lBGZaaWstrq/vuC+Kh8PxG0sGUFtziFDPV27sd+X1vg9iEvyxfXBFWR39Tlx98p1gcOr7/2pgoF UNTX8C8HaasNgZHIGdxWYMi8ZU6SHVX72cMcLSv/2iBHTJr8TZ2+Qhs19g811b6SwWRGWuybt18 YgKbjlZpAJMiAN1/Y9Ta0A0W5yFMssxQpXR6gnZG8hiLr8KfrCigVuoOQa90VRyypj9nijd1lTf 0G/NBLGldNPaADOR6mNb9IMFCWy7FDQ980jsRijeorIxeZnymrzXkc7PmWM5KtaxYu+KFjkSFSo NMS4OH1S4iGxD83+Ic9l1QaE8Htf5K3euJtc08SC/BywQEsTXyye3UcnV993HVhXW+NDg36hBC7 T48KBxPA== X-Google-Smtp-Source: AGHT+IH5K61GDg0ZUw4ARCfYbwftv+OGfOfF0Y0bqBEfg6jRNeqG2wf12EBb3f41tEzQLAjAwRKi6g== X-Received: by 2002:a05:6402:3553:b0:615:9c3b:17f with SMTP id 4fb4d7f45d1cf-615e6ef235cmr916363a12.15.1754089233322; Fri, 01 Aug 2025 16:00:33 -0700 (PDT) Received: from rs3labsrv8.iccluster.epfl.ch (nat-icclus-192-26-29-9.epfl.ch. [192.26.29.9]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-615a8ffa17csm3279290a12.49.2025.08.01.16.00.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Aug 2025 16:00:32 -0700 (PDT) From: pyyjason@gmail.com To: SeongJae Park , Andrew Morton , Usama Arif Cc: damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@meta.com, Yueyang Pan Subject: [PATCH v3 2/2] mm/damon: Add damos_stat support for vaddr Date: Fri, 1 Aug 2025 22:59:51 +0000 Message-ID: <88cc271642476fa6025f3789781dfc8c2f576eab.1754088635.git.pyyjason@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Yueyang Pan This patch adds support for damos_stat in virtual address space. It leverages the walk_page_range to walk the page table and gets the folio from page table. The last folio scanned is stored in damos->last_applied to prevent double counting. Signed-off-by: Yueyang Pan --- mm/damon/vaddr.c | 103 ++++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 102 insertions(+), 1 deletion(-) diff --git a/mm/damon/vaddr.c b/mm/damon/vaddr.c index 87e825349bdf..5960d5d36123 100644 --- a/mm/damon/vaddr.c +++ b/mm/damon/vaddr.c @@ -890,6 +890,107 @@ static unsigned long damos_va_migrate(struct damon_ta= rget *target, return applied * PAGE_SIZE; } =20 +struct damos_va_stat_private { + struct damos *scheme; + unsigned long *sz_filter_passed; +}; + +static inline bool damos_va_invalid_folio(struct folio *folio, + struct damos *s) +{ + return !folio || folio =3D=3D s->last_applied; +} + +static int damos_va_stat_pmd_entry(pmd_t *pmd, unsigned long addr, + unsigned long next, struct mm_walk *walk) +{ + struct damos_va_stat_private *priv =3D walk->private; + struct damos *s =3D priv->scheme; + unsigned long *sz_filter_passed =3D priv->sz_filter_passed; + struct vm_area_struct *vma =3D walk->vma; + struct folio *folio; + spinlock_t *ptl; + pte_t *start_pte, *pte, ptent; + int nr; + +#ifdef CONFIG_TRANSPARENT_HUGEPAGE + if (pmd_trans_huge(*pmd)) { + pmd_t pmde; + + ptl =3D pmd_trans_huge_lock(pmd, vma); + if (!ptl) + return 0; + pmde =3D pmdp_get(pmd); + if (!pmd_present(pmde)) + goto huge_unlock; + + folio =3D vm_normal_folio_pmd(vma, addr, pmde); + + if (damos_va_invalid_folio(folio, s)) + goto huge_unlock; + + if (!damos_va_filter_out(s, folio, vma, addr, NULL, pmd)) + *sz_filter_passed +=3D folio_size(folio); + s->last_applied =3D folio; + +huge_unlock: + spin_unlock(ptl); + return 0; + } +#endif + start_pte =3D pte =3D pte_offset_map_lock(vma->vm_mm, pmd, addr, &ptl); + if (!start_pte) + return 0; + + for (; addr < next; pte +=3D nr, addr +=3D nr * PAGE_SIZE) { + nr =3D 1; + ptent =3D ptep_get(pte); + + if (pte_none(ptent) || !pte_present(ptent)) + continue; + + folio =3D vm_normal_folio(vma, addr, ptent); + + if (damos_va_invalid_folio(folio, s)) + continue; + + if (!damos_va_filter_out(s, folio, vma, addr, pte, NULL)) + *sz_filter_passed +=3D folio_size(folio); + nr =3D folio_nr_pages(folio); + s->last_applied =3D folio; + } + pte_unmap_unlock(start_pte, ptl); + return 0; +} + +static unsigned long damos_va_stat(struct damon_target *target, + struct damon_region *r, struct damos *s, + unsigned long *sz_filter_passed) +{ + struct damos_va_stat_private priv; + struct mm_struct *mm; + struct mm_walk_ops walk_ops =3D { + .pmd_entry =3D damos_va_stat_pmd_entry, + .walk_lock =3D PGWALK_RDLOCK, + }; + + priv.scheme =3D s; + priv.sz_filter_passed =3D sz_filter_passed; + + if (!damon_ops_has_filter(s)) + return 0; + + mm =3D damon_get_mm(target); + if (!mm) + return 0; + + mmap_read_lock(mm); + walk_page_range(mm, r->ar.start, r->ar.end, &walk_ops, &priv); + mmap_read_unlock(mm); + mmput(mm); + return 0; +} + static unsigned long damon_va_apply_scheme(struct damon_ctx *ctx, struct damon_target *t, struct damon_region *r, struct damos *scheme, unsigned long *sz_filter_passed) @@ -916,7 +1017,7 @@ static unsigned long damon_va_apply_scheme(struct damo= n_ctx *ctx, case DAMOS_MIGRATE_COLD: return damos_va_migrate(t, r, scheme, sz_filter_passed); case DAMOS_STAT: - return 0; + return damos_va_stat(t, r, scheme, sz_filter_passed); default: /* * DAMOS actions that are not yet supported by 'vaddr'. --=20 2.43.0